[GitHub] [apisix] szqm123 commented on issue #3859: request help: Error: Could not satisfy dependency lua-resty-hmac-ffi 0.05: No results matching query were found for Lua 5.3. make: *** [Makefile:67:
szqm123 commented on issue #3859: URL: https://github.com/apache/apisix/issues/3859#issuecomment-812973887 1、重新编译luarocks，安装luarocks时选择luajit作为lua编译器，不要使用lua5.3或者5.4。 进入luarocks目录： ./configure --with-lua=/usr/local/openresty/luajit --lua-suffix=jit --with-lua-include=/usr/local/openresty/luajit/include/luajit-2.1 make install 2、进入apisix目录 make deps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
iamayushdas commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606747934 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: ☺️ #OpenSourceIsLove -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
imjoey commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606747752 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: > No, there wont be a problem because its under the github server and deleting the account won't create any isse. > > Now if your are fine with this PR you can give a approval to it :smiley: @imjoey @iamayushdas Sure, very glad to know it will always work. Thanks for clarification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
iamayushdas commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606743603 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: No, there wont be a problem because its under the github server and deleting the account won't create any isse. Now if your are fine with this PR you can give a approval to it :smiley: @imjoey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
iamayushdas commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606743603 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: No, there wont be a problem because its under the github server and deleting the account won't create any isse. Now if your are fine with this PR you can give a approval to it :smiley: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
imjoey commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606742998 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: > I think CDN gives us more ease to handle @iamayushdas agreed +1 on Github CDN. Actually I'm not sure that is there any possibility for the images be unavailable to the pages. For example, the Github account which uploaded the images is deleted, or any other reasons. It's ok for me if the URLs of images will be never changed or inaccessible. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
juzhiyuan commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606740205 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3883: feat: add 5xx error page
moonming commented on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-812960319 ping @starsz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
iamayushdas commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606735081 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: I think CDN gives us more ease to handle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
juzhiyuan commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606734858 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: 樂 that's a problem. - If we put them in our repo, it's easy to maintain actually, but will make the `pull` action slower; - if we put them in the CDN, we need to upload them when updating the images, but will speedup the pull action. Both are ok to me, how about others' opinion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] moonming opened a new issue #1706: security: support HTTPS for dashboard
moonming opened a new issue #1706: URL: https://github.com/apache/apisix-dashboard/issues/1706 # Feature request ## Please describe your feature Now dashboard does not support HTTPS access, which is not safe and easy to be hijacked and sniffed. ## Describe the solution you'd like We should support HTTPS access. How about adding Apache APISIX in front of the manager API? ## Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. ## Additional context Add any other context or screenshots about the feature request here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #3883: feat: add 5xx error page
membphis commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r606733088
##
File path: apisix/error_handler.lua
##
@@ -0,0 +1,53 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx = ngx
+
+
+local html_5xx = [[
+
+
+
+
+
+Error
+
+body {
+width: 35em;
+margin: 0 auto;
+font-family: Tahoma, Verdana, Arial, sans-serif;
+}
+
+
+
+An error occurred.
+Sorry, the page you are looking for is currently unavailable.
+Please try again later.
+If you are the system administrator of this resource then you should check
+the https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L135;>error
log
+ for details.
+If you need any help, click https://apisix.apache.org/;>need
help.
+Faithfully yours, https://apisix.apache.org/;>APISIX.
+
+
+]]
+
+
+return function()
Review comment:
this is not a good way, we mainly use `Lua module` way.
it is easy to add new features later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #3883: feat: add 5xx error page
membphis commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r606732723
##
File path: apisix/error_handler.lua
##
@@ -0,0 +1,54 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx = ngx
+
+
+local html_5xx = [[
+
+
+
+
+
+Error
+
+body {
+width: 35em;
+margin: 0 auto;
+font-family: Tahoma, Verdana, Arial, sans-serif;
+}
+
+
+
+An error occurred.
+Sorry, the page you are looking for is currently unavailable.
+Please try again later.
+If you are the system administrator of this resource then you should check
+the https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L135;>error
log
+ for details.
+If you need any help, click https://apisix.apache.org/;>need
help.
Review comment:
same to https://github.com/apache/apisix/pull/3883#discussion_r603767827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
iamayushdas commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606732118 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: > @iamayushdas thank you for this. I was wondering that where the new image file is located. My pleasure sir! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
imjoey commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606727848 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: > GitHub CDN? Yep, absolutely I think. My concern is how could us maintain these images. Previous images were maintained in this repository, while the new images seem not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imjoey commented on issue #3963: request help: Distinguish the source (upstream or apisix) of the status code, whether it can be extended to all the status code
imjoey commented on issue #3963: URL: https://github.com/apache/apisix/issues/3963#issuecomment-812947978 > We can send a proposal to the mail list, who wants to do this? Hi @fukiki , is that possible for you to send a proposal email to the dev mail list for further discussion? We actually need more opinions. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
juzhiyuan commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606727417 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: GitHub CDN? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
imjoey commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606727077 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: @iamayushdas thank you for this. I was wondering that where the new image file is located. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
juzhiyuan commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606725898 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. Review comment: got it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
juzhiyuan commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606725842 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -59,7 +59,7 @@ We can debug a route both published or offline with the online debug function, w 2. Debug a offline route - + Review comment: actually, it supports not only Upstream URL, but also API Gateway's Endpoint -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] bahtou opened a new issue #338: bug: minikube setup
bahtou opened a new issue #338:
URL: https://github.com/apache/apisix-ingress-controller/issues/338
### Issue description
Trying to go through the minikube setup here:
https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/minikube.md
The installation works fine. It is when I try to test the connection by
following the practice example that I run into issues:
https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/practices/proxy-the-httpbin-service.md#test
After applying the `httpbin-route.yaml` I expected the route to be
registered in the Apisix so after running `kubectl exec -it -n ${namespace of
Apache APISIX} ${Pod name of Apache APISIX} -- curl
http://127.0.0.1:9180/apisix/admin/routes -H 'X-API-Key:
edd1c9f034335f136f87ad84b625c8f1'` the returned payload shows no record of the
httpbin.
And running `kubectl exec -it -n ${namespace of Apache APISIX} ${Pod name of
Apache APISIX} -- curl http://127.0.0.1:9080/headers -H 'Host:
local.httpbin.org'` returns a 404.
Are the docs missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal edited a comment on pull request #1705: fix/perf: detailed error for store init failure and deferred execution of closers
bisakhmondal edited a comment on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-812873638 docker registry seems temporarily down. All requests are failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1705: fix/perf: detailed error for store init failure and deferred execution of closers
bisakhmondal commented on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-812873638 docker registry seems temporary down. All requests are failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1689: docs: update the image in the USER_GUIDE.md #1683
iamayushdas commented on pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#issuecomment-812872898 @juzhiyuan have a look to this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1705: fix/perf: detailed error for store init failure and deferred execution of closers
codecov-io edited a comment on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-812696206 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=h1) Report > Merging [#1705](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=desc) (8e4ac9e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9cf91b756f33cbddeac1adb912177f5b7762def6?el=desc) (9cf91b7) will **decrease** coverage by `10.41%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1705 +/- ## === - Coverage 72.63% 62.21% -10.42% === Files 133 121 -12 Lines5740 5195 -545 Branches 666 661-5 === - Hits 4169 3232 -937 - Misses 1327 1775 +448 + Partials 244 188 -56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.31% <100.00%> (+0.05%)` | :arrow_up: | | frontend-e2e-test | `72.61% <ø> (-1.38%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `82.03% <100.00%> (-5.32%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | ... and [38 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=footer). Last update [9cf91b7...8e4ac9e](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:
[GitHub] [apisix-website] juzhiyuan commented on issue #230: docs: tell users where they are
juzhiyuan commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-812872406 oh yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan closed issue #230: docs: tell users where they are
juzhiyuan closed issue #230: URL: https://github.com/apache/apisix-website/issues/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #278: feat: add a new blog on "Traffic Split in Apache APISIX Ingress Controller"
juzhiyuan commented on issue #278: URL: https://github.com/apache/apisix-website/issues/278#issuecomment-812872377 thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1705: fix/perf: detailed error for store init failure and deferred execution of closers
codecov-io edited a comment on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-812696206 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=h1) Report > Merging [#1705](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=desc) (8e4ac9e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9cf91b756f33cbddeac1adb912177f5b7762def6?el=desc) (9cf91b7) will **decrease** coverage by `20.31%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1705 +/- ## === - Coverage 72.63% 52.31% -20.32% === Files 133 38 -95 Lines5740 2661 -3079 Branches 6660 -666 === - Hits 4169 1392 -2777 + Misses 1327 1081 -246 + Partials 244 188 -56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.31% <100.00%> (+0.05%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `82.03% <100.00%> (-5.32%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | ... and [119 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=footer). Last update [9cf91b7...8e4ac9e](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1684: program panic when failed to initialize etcd store is unreasonable
bisakhmondal commented on issue #1684: URL: https://github.com/apache/apisix-dashboard/issues/1684#issuecomment-812868469 Very true. Pushing the new changes then :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on issue #1684: program panic when failed to initialize etcd store is unreasonable
tokers commented on issue #1684: URL: https://github.com/apache/apisix-dashboard/issues/1684#issuecomment-812851771 > > @bisakhmondal We don't have to panic the program, instead, we may report the error reason and exit with a non-zero code. > > Okay, we can definitely go with it. I would like to mention an issue in this approach. We are keeping a slice of closers [ [ref](https://github.com/apache/apisix-dashboard/blob/master/api/internal/utils/closer.go) ] for all the allocated resources (including etcd connection), so in case of any error, for a graceful shutdown, the already allocated resource's closer method should be called. > > os.Exit(1) will immediately abort the program. But that is not the case for panic. Even after panic the early evaluated defers will get executed in LIFO order. So I have put `utils.CloseAll()` into a `defer` statement before the scope of any panics. > > IMHO, panic is fine here. Let me know what you think. Thanks :) Yes, I agree that all finalizers or closers should be run even if exceptions occur, the reason why I think the spontaneous `panic` is not suitable is this is a **clear and specific** exception, not a programming fault. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas opened a new issue #278: feat: add a new blog on "Traffic Split in Apache APISIX Ingress Controller"
iamayushdas opened a new issue #278: URL: https://github.com/apache/apisix-website/issues/278 **Actual Behaviour** We have old blogs in our blog page **Expected Behaviour** Newly published blog has to be added on our blog page about "Traffic Split in Apache APISIX Ingress Controller" published by our very own 'Chao Zhang' **Steps to reproduce it** https://github.com/apache/apisix-website/tree/master/website/blog **Would you like to work on the issue?** Yes i would like to work on this issue if no one else picks it up How you can solve it ? 1. Create a file called: 2021-03-27-traffic-split-in-apache-apisix-ingress-controller.md 2. Copy contents from Original File[1] to the new file; 3. File your First PR! [1] Original File: https://github.com/api7/website/blob/master/_posts/blog/en-US/traffic-split-in-apache-apisix-ingress-controller.md We are going to publish it here: https://github.com/apache/apisix-website/tree/master/website/blog  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #230: docs: tell users where they are
iamayushdas commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-812848388 i think we should close this now @juzhiyuan what say? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
iamayushdas commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606649662 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + ## Route The Route module aims to control routes by UI instead of calling APIs. ### List - + ### Create - + - + - + Review comment: See here @juzhiyuan its already updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
iamayushdas commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606638312 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. Review comment: hey @juzhiyuan there is no such screenshots in my commit. i already have updated this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1684: program panic when failed to initialize etcd store is unreasonable
bisakhmondal commented on issue #1684: URL: https://github.com/apache/apisix-dashboard/issues/1684#issuecomment-812844534 > @bisakhmondal We don't have to panic the program, instead, we may report the error reason and exit with a non-zero code. Okay, we can definitely go with it. I would like to mention an issue in this approach. We are keeping a slice of closers [ [ref](https://github.com/apache/apisix-dashboard/blob/master/api/internal/utils/closer.go) ] for all the allocated resources (including etcd connection), so in case of any error, for a graceful shutdown, the already allocated resource's closer method should be called. os.Exit(1) will immediately abort the program. But that is not the case for panic. Even after panic the early evaluated defers will get executed in LIFO order. So I have put `utils.CloseAll()` into a `defer` statement before the scope of any panics. IMHO, panic is fine here. Let me know what you think. Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Yiyiyimu closed issue #1614: Optimized front-end e2e test time
Yiyiyimu closed issue #1614: URL: https://github.com/apache/apisix-dashboard/issues/1614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Yiyiyimu merged pull request #1698: chore: reduce FE e2e ci time
Yiyiyimu merged pull request #1698: URL: https://github.com/apache/apisix-dashboard/pull/1698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore: reduce FE e2e ci time (#1698)
This is an automated email from the ASF dual-hosted git repository.
shuyangw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 297a57a chore: reduce FE e2e ci time (#1698)
297a57a is described below
commit 297a57a4081b7b55d7906f6084d319d0afc21579
Author: litesun
AuthorDate: Sat Apr 3 17:04:37 2021 +0800
chore: reduce FE e2e ci time (#1698)
---
.github/workflows/frontend-e2e-test.yml| 39 +++
...d-e2e-test.yml => frontend-plugin-e2e-test.yml} | 44 ++
web/cypress.json | 4 +-
web/package.json | 4 +-
4 files changed, 65 insertions(+), 26 deletions(-)
diff --git a/.github/workflows/frontend-e2e-test.yml
b/.github/workflows/frontend-e2e-test.yml
index 0b92f9c..98e76c6 100644
--- a/.github/workflows/frontend-e2e-test.yml
+++ b/.github/workflows/frontend-e2e-test.yml
@@ -7,6 +7,8 @@ on:
pull_request:
branches:
- master
+env:
+ CYPRESS_CACHE_FOLDER: cypress/cache
defaults:
run:
working-directory: web
@@ -15,7 +17,6 @@ jobs:
web-e2e:
name: Frontend e2e test
runs-on: ubuntu-latest
-
services:
etcd:
image: bitnami/etcd:3.4.13
@@ -28,7 +29,6 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v2
-
- name: Setup Node.js environment
uses: actions/setup-node@v2.1.5
with:
@@ -37,7 +37,7 @@ jobs:
- name: Setup golang environment
uses: actions/setup-go@v2.1.3
with:
- go-version: "1.13"
+ go-version: '1.13'
- name: Start manager-api
working-directory: ./api
@@ -45,23 +45,46 @@ jobs:
sed -i 's@# - dubbo-proxy@- dubbo-proxy@' ./conf/conf.yaml
nohup go run ./cmd/manager &
- - name: Install front-end dependencies
-run: yarn install
+ - name: Cache node_modules
+uses: actions/cache@v2
+id: yarn-cache
+with:
+ path: '*/node_modules'
+ key: '${{ runner.os }}-yarn-cache0-${{ hashFiles(''**/yarn.lock'')
}}'
+ restore-keys: |
+${{ runner.os }}-yarn-cache0
+
+ - name: Cache Cypress binary
+uses: actions/cache@v2
+id: cypress-binary-cache
+with:
+ path: '*/cypress/cache'
+ key: cypress-${{ runner.os }}-cypress-cache0-${{
hashFiles('**/package.json') }}
+ restore-keys: |
+cypress-${{ runner.os }}-cypress-cache0
+
+ - name: Install dependencies
+if: steps.yarn-cache.outputs.cache-hit != 'true'
+run: yarn
- name: Start frontend then test
-run: yarn test:e2e
+run: |
+ rm -rf cypress/integration/plugin
+ yarn test:e2e
- name: Report e2e coverage
run: npx nyc report --reporter=text-summary
- name: Upload coverage to Codecov
run: |
- bash <(curl -s https://codecov.io/bash) -f
./coverage/coverage-final.json -F frontend-e2e-test
+ bash <(curl -s https://codecov.io/bash) -f
./coverage/coverage-final.json -F frontend-e2e-test
- name: Archive code coverage results
uses: actions/upload-artifact@v2
if: always()
with:
name: cypress-report
- path: web/cypress/
+ path: |
+ web/cypress/videos
+ web/cypress/screenshots
retention-days: 5
diff --git a/.github/workflows/frontend-e2e-test.yml
b/.github/workflows/frontend-plugin-e2e-test.yml
similarity index 53%
copy from .github/workflows/frontend-e2e-test.yml
copy to .github/workflows/frontend-plugin-e2e-test.yml
index 0b92f9c..d919299 100644
--- a/.github/workflows/frontend-e2e-test.yml
+++ b/.github/workflows/frontend-plugin-e2e-test.yml
@@ -1,5 +1,4 @@
-name: Frontend e2e test
-
+name: Frontend e2e test for plugin
on:
push:
branches:
@@ -7,6 +6,8 @@ on:
pull_request:
branches:
- master
+env:
+ CYPRESS_CACHE_FOLDER: cypress/cache
defaults:
run:
working-directory: web
@@ -15,7 +16,6 @@ jobs:
web-e2e:
name: Frontend e2e test
runs-on: ubuntu-latest
-
services:
etcd:
image: bitnami/etcd:3.4.13
@@ -24,11 +24,9 @@ jobs:
- 2380:2380
env:
ALLOW_NONE_AUTHENTICATION: yes
-
steps:
- name: Checkout
uses: actions/checkout@v2
-
- name: Setup Node.js environment
uses: actions/setup-node@v2.1.5
with:
@@ -37,7 +35,7 @@ jobs:
- name: Setup golang environment
uses: actions/setup-go@v2.1.3
with:
- go-version: "1.13"
+ go-version: '1.13'
- name: Start manager-api
working-directory: ./api
@@ -45,23 +43,37 @@ jobs:
sed -i 's@# - dubbo-proxy@- dubbo-proxy@' ./conf/conf.yaml
nohup go run
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
iamayushdas commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606638312 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. Review comment: Will fix it asap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3690: Support for AzureAD/OIDC integration with APISIX
spacewander commented on issue #3690: URL: https://github.com/apache/apisix/issues/3690#issuecomment-812832903 OpenLDAP is different as it runs LDAP protocol? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: admin-api.md document adds configuration https example (#3871)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 25301d6 docs: admin-api.md document adds configuration https example
(#3871)
25301d6 is described below
commit 25301d60dfa57f14a4dfed295c8cc7d104e37e38
Author: Yuelin Zheng <2226815...@qq.com>
AuthorDate: Sat Apr 3 16:13:54 2021 +0800
docs: admin-api.md document adds configuration https example (#3871)
---
docs/en/latest/admin-api.md | 54 +++
docs/zh/latest/admin-api.md | 56 -
2 files changed, 99 insertions(+), 11 deletions(-)
diff --git a/docs/en/latest/admin-api.md b/docs/en/latest/admin-api.md
index 89ec8dc..8878817 100644
--- a/docs/en/latest/admin-api.md
+++ b/docs/en/latest/admin-api.md
@@ -560,7 +560,7 @@ In addition to the basic complex equalization algorithm
selection, APISIX's Upst
1. when it is `vars_combinations`, the `key` is required. The `key` can be any
[Nginx builtin variables](http://nginx.org/en/docs/varindex.html) combinations,
such as `$request_uri$remote_addr`.
1. If there is no value for either `hash_on` or `key`, `remote_addr` will be
used as key.
-Config Example:
+**Config Example:**
```shell
{
@@ -579,12 +579,16 @@ Config Example:
"key": "",
"name": "upstream-for-test",
"desc": "hello world",
+"scheme": "http", # The scheme used when communicating with
upstream, the default is `http`
}
```
-Example：
+**Example:**
+
+Example 1: Create an upstream and modify the data of `nodes`
```shell
+# Create upstream
$ curl http://127.0.0.1:9080/apisix/admin/upstreams/100 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -i -X PUT -d '
{
"type":"roundrobin",
@@ -595,8 +599,6 @@ $ curl http://127.0.0.1:9080/apisix/admin/upstreams/100 -H
'X-API-KEY: edd1c9f0
}
}'
HTTP/1.1 201 Created
-Date: Thu, 26 Dec 2019 04:19:34 GMT
-Content-Type: text/plain
...
@@ -665,12 +667,54 @@ After the execution is successful, nodes will not retain
the original data, and
```
+Example 2: How to proxy client request to `https` upstream service
+
+1. Create a route and configure the upstream scheme as `https`.
+
+```shell
+$ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/get",
+"upstream": {
+"type": "roundrobin",
+"scheme": "https",
+"nodes": {
+"httpbin.org:443": 1
+}
+}
+}'
+```
+
+After the execution is successful, the scheme when requesting to communicate
with the upstream will be `https`.
+
+2. Send a request for testing.
+
+```shell
+$ curl http://127.0.0.1:9080/get
+{
+ "args": {},
+ "headers": {
+"Accept": "*/*",
+"Host": "127.0.0.1",
+"User-Agent": "curl/7.29.0",
+"X-Amzn-Trace-Id": "Root=1-6058324a-0e898a7f04a5e95b526bb183",
+"X-Forwarded-Host": "127.0.0.1"
+ },
+ "origin": "127.0.0.1",
+ "url": "https://127.0.0.1/get;
+}
+```
+
+The request is successful, which means that the proxy upstream `https` is
valid.
+
+**Note:**
+
Each node can be configured with a priority. A node with low priority will
only be
used when all the nodes with higher priority are unavailable or tried.
As the default priority is 0, we can configure nodes with negative priority as
the backup.
-For example,
+For example:
```json
{
diff --git a/docs/zh/latest/admin-api.md b/docs/zh/latest/admin-api.md
index f488452..452b0f7 100644
--- a/docs/zh/latest/admin-api.md
+++ b/docs/zh/latest/admin-api.md
@@ -562,7 +562,7 @@ APISIX 的 Upstream 除了基本的复杂均衡算法选择外，还支持对上
4. 设为 `consumer` 时，`key` 不需要设置。此时哈希算法采用的 `key` 为认证通过的 `consumer_name`。
5. 如果指定的 `hash_on` 和 `key` 获取不到值时，就是用默认值：`remote_addr`。
-upstream 对象 json 配置内容：
+**upstream 对象 json 配置内容：**
```shell
{
@@ -579,15 +579,18 @@ upstream 对象 json 配置内容：
"checks": {}, # 配置健康检查的参数
"hash_on": "",
"key": "",
-"name": "upstream-xxx", # upstream 名称
+"name": "upstream-xxx", # upstream 名称
"desc": "hello world", # upstream 描述
+"scheme": "http"# 跟上游通信时使用的 scheme，默认是 `http`
}
```
-具体示例：
+**具体示例：**
+
+示例一：创建一个 upstream 并对 `nodes` 的数据做修改
```shell
-# 创建一个upstream
+# 创建一个 upstream
$ curl http://127.0.0.1:9080/apisix/admin/upstreams/100 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -i -X PUT -d '
{
"type":"roundrobin",
@@ -666,11 +669,52 @@ HTTP/1.1 200 OK
```
+示例二：将客户端请求代理到上游 `https` 服务
+
+1、创建 route 并配置 upstream 的 scheme 为 `https`。
+
+```shell
+$ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/get",
+"upstream": {
+"type": "roundrobin",
+"scheme": "https",
+"nodes": {
+"httpbin.org:443": 1
+}
+
[GitHub] [apisix] spacewander merged pull request #3871: docs: admin-api.md document adds configuration https example
spacewander merged pull request #3871: URL: https://github.com/apache/apisix/pull/3871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed pull request #3982: add the action 'init_config'
spacewander closed pull request #3982: URL: https://github.com/apache/apisix/pull/3982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3982: add the action 'init_config'
spacewander commented on pull request #3982: URL: https://github.com/apache/apisix/pull/3982#issuecomment-812832632 It should be done with `apisix init_etcd`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1689: docs: update the image in the USER_GUIDE.md #1683
juzhiyuan commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606634198 ## File path: docs/en/latest/USER_GUIDE.md ## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. Review comment:  Hi, I noticed there has an old image 樂 we don't have plugin form currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1688: feat: added policy for semantic-pr
juzhiyuan merged pull request #1688: URL: https://github.com/apache/apisix-dashboard/pull/1688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (9cf91b7 -> 6d1c8e4)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 9cf91b7 feat: Support duplicate one existing Route (#1558) add 6d1c8e4 chore: added policy for semantic-pr (#1688) No new revisions were added by this update. Summary of changes: .github/semantic.yml | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 .github/semantic.yml
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1698: chore: reduce FE e2e ci time
juzhiyuan commented on pull request #1698: URL: https://github.com/apache/apisix-dashboard/pull/1698#issuecomment-812827116 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gxlct008 commented on pull request #3980: doc: update the Getting Started guide in Chinese
gxlct008 commented on pull request #3980: URL: https://github.com/apache/apisix/pull/3980#issuecomment-812820073 @juzhiyuan I have fixed all the problems with the Markdown format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
