[GitHub] [apisix-dashboard] iamayushdas commented on issue #1810: style(fe): how about changing the navigation bar to dark?
iamayushdas commented on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824560255 > We can also refer to the examples in the documentation： https://procomponents.ant.design/components/layout#menu Thanks for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi edited a comment on issue #1810: style(fe): how about changing the navigation bar to dark?
guoqqqi edited a comment on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824558758 We can also refer to the examples in the documentation： https://procomponents.ant.design/components/layout#menu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on issue #1810: style(fe): how about changing the navigation bar to dark?
guoqqqi commented on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824558758 We can also refer to the examples in the documentation： https://procomponents.ant.design/components/layout#menu～ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #398: feat: add tcp route data structures and cache
tokers commented on pull request #398: URL: https://github.com/apache/apisix-ingress-controller/pull/398#issuecomment-824555658 @gxthrj Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] pioneer-hash commented on issue #379: bug: Synchronization configuration error when setting backends in route.yaml
pioneer-hash commented on issue #379: URL: https://github.com/apache/apisix-ingress-controller/issues/379#issuecomment-824555698 > @pioneer-hash Please try the apisix helm chart `0.3.1`. success! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #398: feat: add tcp route data structures and cache
tokers commented on a change in pull request #398:
URL:
https://github.com/apache/apisix-ingress-controller/pull/398#discussion_r618081826
##
File path: pkg/apisix/nonexistentclient.go
##
@@ -132,15 +160,19 @@ type dummyCache struct{}
var _ cache.Cache = {}
-func (c *dummyCache) InsertRoute(_ *v1.Route) error { return nil }
-func (c *dummyCache) InsertSSL(_ *v1.Ssl) error { return nil }
-func (c *dummyCache) InsertUpstream(_ *v1.Upstream) error{ return nil }
-func (c *dummyCache) GetRoute(_ string) (*v1.Route, error) { return nil,
cache.ErrNotFound }
-func (c *dummyCache) GetSSL(_ string) (*v1.Ssl, error) { return nil,
cache.ErrNotFound }
-func (c *dummyCache) GetUpstream(_ string) (*v1.Upstream, error) { return nil,
cache.ErrNotFound }
-func (c *dummyCache) ListRoutes() ([]*v1.Route, error) { return nil,
nil }
-func (c *dummyCache) ListSSL() ([]*v1.Ssl, error){ return nil,
nil }
-func (c *dummyCache) ListUpstreams() ([]*v1.Upstream, error) { return nil,
nil }
-func (c *dummyCache) DeleteRoute(_ *v1.Route) error { return nil }
-func (c *dummyCache) DeleteSSL(_ *v1.Ssl) error { return nil }
-func (c *dummyCache) DeleteUpstream(_ *v1.Upstream) error{ return nil }
+func (c *dummyCache) InsertRoute(_ *v1.Route) error{
return nil }
+func (c *dummyCache) InsertSSL(_ *v1.Ssl) error{
return nil }
+func (c *dummyCache) InsertUpstream(_ *v1.Upstream) error {
return nil }
+func (c *dummyCache) InsertStreamRoute(_ *v1.StreamRoute) error{
return nil }
+func (c *dummyCache) GetRoute(_ string) (*v1.Route, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) GetSSL(_ string) (*v1.Ssl, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) GetUpstream(_ string) (*v1.Upstream, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) GetStreamRoute(_ string) (*v1.StreamRoute, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) ListRoutes() ([]*v1.Route, error) {
return nil, nil }
+func (c *dummyCache) ListSSL() ([]*v1.Ssl, error) {
return nil, nil }
+func (c *dummyCache) ListUpstreams() ([]*v1.Upstream, error) {
return nil, nil }
+func (c *dummyCache) ListStreamRoutes() ([]*v1.StreamRoute, error) {
return nil, nil }
+func (c *dummyCache) DeleteRoute(_ *v1.Route) error{
return nil }
+func (c *dummyCache) DeleteSSL(_ *v1.Ssl) error{
return nil }
+func (c *dummyCache) DeleteUpstream(_ *v1.Upstream) error {
return nil }
+func (c *dummyCache) DeleteStreamRoute(_ *v1.StreamRoute) error{
return nil }
Review comment:
Changes will be huge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on issue #1810: style(fe): how about changing the navigation bar to dark?
iamayushdas edited a comment on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824552808 Dark mode looks good as default. should we go for it ?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1810: style(fe): how about changing the navigation bar to dark?
iamayushdas commented on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824552808 Drk mode looks good as default. should we go for it ?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas removed a comment on issue #1810: style(fe): how about changing the navigation bar to dark?
iamayushdas removed a comment on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824552447 > > @membphis @nic-chen Hi, we usually call it `Left Sidebar`. > > You could see this preview site: https://preview.pro.ant.design/dashboard/analysis > > the dark mode LGTM me too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1810: style(fe): how about changing the navigation bar to dark?
iamayushdas commented on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824552447 > > @membphis @nic-chen Hi, we usually call it `Left Sidebar`. > > You could see this preview site: https://preview.pro.ant.design/dashboard/analysis > > the dark mode LGTM me too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1792: release: new version 2.6
bisakhmondal commented on pull request #1792: URL: https://github.com/apache/apisix-dashboard/pull/1792#issuecomment-824552413 LGTM. Please update https://github.com/apache/apisix-dashboard/blob/master/docs/en/latest/deploy-with-rpm.md with v2.5's rpm binary link. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #398: feat: add tcp route data structures and cache
tokers commented on pull request #398: URL: https://github.com/apache/apisix-ingress-controller/pull/398#issuecomment-824550915 @gxthrj This PR just add the data structure for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1667: feat: run manager-api as an OS agnostic service
bisakhmondal commented on a change in pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r618091085
##
File path: api/cmd/managerapi.go
##
@@ -59,6 +60,14 @@ func printVersion() {
// NewManagerAPICommand creates the manager-api command.
func NewManagerAPICommand() *cobra.Command {
+ cobra.OnInitialize(func() {
+ var err error
+ service, err = createService()
+ if err != nil {
+ fmt.Fprintf(os.Stderr, "error occurred while
initializing service: %s", err)
Review comment:
I avoided quitting because executing plain `./manager-api` doesn't
require service struct
[ref](https://github.com/apache/apisix-dashboard/pull/1667/files#diff-2f6f18308ee739c91dc10135e339dc5ba94e1a447391574c020890e0039d15b1R80).
If somehow `createService` returns a nil service and service-specific commands
are used go runtime manager will throw an error of referencing a nil struct
before any line of actual logic of manager-api being executed (slightly
ungrateful though). Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless
iamayushdas edited a comment on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824546331 Okay, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless
iamayushdas commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824546331 Okay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-824545790 Cool. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1805: chore: icons added for auth, security, traffic, serverless
guoqqqi commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824545769 Hi, @iamayushdas The failed E2E test in this PR I suggest fixing it like this.  This way, whenever you click on the Add button, you can be sure that the subsequent actions will be performed after you click on the Add button. Thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #398: feat: add tcp route data structures and cache
tokers commented on a change in pull request #398:
URL:
https://github.com/apache/apisix-ingress-controller/pull/398#discussion_r618081826
##
File path: pkg/apisix/nonexistentclient.go
##
@@ -132,15 +160,19 @@ type dummyCache struct{}
var _ cache.Cache = {}
-func (c *dummyCache) InsertRoute(_ *v1.Route) error { return nil }
-func (c *dummyCache) InsertSSL(_ *v1.Ssl) error { return nil }
-func (c *dummyCache) InsertUpstream(_ *v1.Upstream) error{ return nil }
-func (c *dummyCache) GetRoute(_ string) (*v1.Route, error) { return nil,
cache.ErrNotFound }
-func (c *dummyCache) GetSSL(_ string) (*v1.Ssl, error) { return nil,
cache.ErrNotFound }
-func (c *dummyCache) GetUpstream(_ string) (*v1.Upstream, error) { return nil,
cache.ErrNotFound }
-func (c *dummyCache) ListRoutes() ([]*v1.Route, error) { return nil,
nil }
-func (c *dummyCache) ListSSL() ([]*v1.Ssl, error){ return nil,
nil }
-func (c *dummyCache) ListUpstreams() ([]*v1.Upstream, error) { return nil,
nil }
-func (c *dummyCache) DeleteRoute(_ *v1.Route) error { return nil }
-func (c *dummyCache) DeleteSSL(_ *v1.Ssl) error { return nil }
-func (c *dummyCache) DeleteUpstream(_ *v1.Upstream) error{ return nil }
+func (c *dummyCache) InsertRoute(_ *v1.Route) error{
return nil }
+func (c *dummyCache) InsertSSL(_ *v1.Ssl) error{
return nil }
+func (c *dummyCache) InsertUpstream(_ *v1.Upstream) error {
return nil }
+func (c *dummyCache) InsertStreamRoute(_ *v1.StreamRoute) error{
return nil }
+func (c *dummyCache) GetRoute(_ string) (*v1.Route, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) GetSSL(_ string) (*v1.Ssl, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) GetUpstream(_ string) (*v1.Upstream, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) GetStreamRoute(_ string) (*v1.StreamRoute, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) ListRoutes() ([]*v1.Route, error) {
return nil, nil }
+func (c *dummyCache) ListSSL() ([]*v1.Ssl, error) {
return nil, nil }
+func (c *dummyCache) ListUpstreams() ([]*v1.Upstream, error) {
return nil, nil }
+func (c *dummyCache) ListStreamRoutes() ([]*v1.StreamRoute, error) {
return nil, nil }
+func (c *dummyCache) DeleteRoute(_ *v1.Route) error{
return nil }
+func (c *dummyCache) DeleteSSL(_ *v1.Ssl) error{
return nil }
+func (c *dummyCache) DeleteUpstream(_ *v1.Upstream) error {
return nil }
+func (c *dummyCache) DeleteStreamRoute(_ *v1.StreamRoute) error{
return nil }
Review comment:
OK, will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #386: feat: add event & status for ApisixRoute v2
tokers commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r618081321
##
File path: pkg/ingress/status.go
##
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package ingress
+
+import (
+ "context"
+
+ "k8s.io/apimachinery/pkg/api/meta"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+ v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+ "github.com/apache/apisix-ingress-controller/pkg/kube"
+ configv2alpha1
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2alpha1"
+
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2alpha1"
+)
+
+const (
+ _onditionType = "ResourcesAvailable"
+ _commonSuccessMessage = "Sync Successfully"
+)
+
+// recordRouteStatus record ApisixRoute v2alpha1 status
+func recordRouteStatus(ar *configv2alpha1.ApisixRoute, reason, message string,
status v1.ConditionStatus) {
+ condition := metav1.Condition{
+ Type: _onditionType,
+ }
+ // build condition
+ condition.Reason = reason
+ condition.Status = status
+ condition.Message = message
+ // set to status
+ if ar.Status.Conditions == nil {
+ conditions := make([]metav1.Condition, 0)
+ ar.Status.Conditions =
+ }
+ meta.SetStatusCondition(ar.Status.Conditions, condition)
+ _, _ =
v2alpha1.New(kube.GetApisixClient().ApisixV2alpha1().RESTClient()).ApisixRoutes(ar.Namespace).
Review comment:
We don't have to new a client each time we want to update the status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #4086: feat: response-rewrite plugin response header rewriting supports NGINX variables
spacewander closed issue #4086: URL: https://github.com/apache/apisix/issues/4086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4086: feat: response-rewrite plugin response header rewriting supports NGINX variables
spacewander commented on issue #4086: URL: https://github.com/apache/apisix/issues/4086#issuecomment-824527910 Duplicate of #3727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1814: fix: store init error from etcd and deferred execution of closers
nic-chen commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-824527439 I can't think of why. This should be the same as other new PRs, but other PRs have no such problem. Just wait for the reply from GitHub Support.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e4ce674) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4590801) will **decrease** coverage by `19.37%`. > The diff coverage is `n/a`. > :exclamation: Current head e4ce674 differs from pull request most recent head f42bd93. Consider uploading reports for the commit f42bd93 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1813 +/- ## === - Coverage 71.78% 52.40% -19.38% === Files 172 39 -133 Lines6100 2740 -3360 Branches 7130 -713 === - Hits 4379 1436 -2943 + Misses 1478 1110 -368 + Partials 243 194 -49 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.40% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit f42bd93ddbfc8ac51eed8884a1d9428665ad99f2 https://deploy-preview-1813--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e44b5de) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4590801) will **decrease** coverage by `9.19%`. > The diff coverage is `n/a`. > :exclamation: Current head e44b5de differs from pull request most recent head f42bd93. Consider uploading reports for the commit f42bd93 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1813 +/- ## == - Coverage 71.78% 62.59% -9.20% == Files 172 47 -125 Lines6100 3152-2948 Branches 7130 -713 == - Hits 4379 1973-2406 + Misses 1478 869 -609 - Partials 243 310 +67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.44% <ø> (-0.13%)` | :arrow_down: | | backend-e2e-test-ginkgo | `49.58% <ø> (+0.47%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `47.22% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.68% <0.00%> (-30.54%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `73.91% <0.00%> (-18.27%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e44b5de) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4590801) will **decrease** coverage by `25.34%`. > The diff coverage is `n/a`. > :exclamation: Current head e44b5de differs from pull request most recent head f42bd93. Consider uploading reports for the commit f42bd93 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1813 +/- ## === - Coverage 71.78% 46.44% -25.35% === Files 172 47 -125 Lines6100 3152 -2948 Branches 7130 -713 === - Hits 4379 1464 -2915 + Misses 1478 1424 -54 - Partials 243 264 +21 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.44% <ø> (-0.13%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | `15.00% <0.00%> (-85.00%)` | :arrow_down: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `4.61% <0.00%> (-78.47%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `23.80% <0.00%> (-76.20%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `12.04% <0.00%> (-61.26%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1812: fix: can not configure upstream with no nodes
netlify[bot] edited a comment on pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-823852872 Deploy preview for *apisix-dashboard* ready! Built with commit 79f014e2c3e3077f1aa7c8e535b36f8b46a9c6a8 https://deploy-preview-1812--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1810: style(fe): how about changing the navigation bar to dark?
nic-chen commented on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824523472 > @membphis @nic-chen Hi, we usually call it `Left Sidebar`. > > You could see this preview site: https://preview.pro.ant.design/dashboard/analysis the dark mode LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (18b2967) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4590801) will **decrease** coverage by `19.37%`. > The diff coverage is `n/a`. > :exclamation: Current head 18b2967 differs from pull request most recent head f42bd93. Consider uploading reports for the commit f42bd93 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1813 +/- ## === - Coverage 71.78% 52.40% -19.38% === Files 172 39 -133 Lines6100 2740 -3360 Branches 7130 -713 === - Hits 4379 1436 -2943 + Misses 1478 1110 -368 + Partials 243 194 -49 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.40% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2750212) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4590801) will **decrease** coverage by `4.05%`. > The diff coverage is `n/a`. > :exclamation: Current head 2750212 differs from pull request most recent head f42bd93. Consider uploading reports for the commit f42bd93 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1813 +/- ## == - Coverage 71.78% 67.73% -4.06% == Files 172 47 -125 Lines6100 3152-2948 Branches 7130 -713 == - Hits 4379 2135-2244 + Misses 1478 757 -721 - Partials 243 260 +17 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.31% <ø> (-0.26%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.37% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `56.92% <0.00%> (-26.16%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <0.00%> (-18.75%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `40.00% <0.00%> (-10.00%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `90.47% <0.00%> (-9.53%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] ericsyh edited a comment on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
ericsyh edited a comment on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823798761 ok for close the issue. But i am quite interesting in what scenario that users will create an upstream with empty node list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1815: [Fe]: issue regarding viewport in `route` page
iamayushdas commented on issue #1815: URL: https://github.com/apache/apisix-dashboard/issues/1815#issuecomment-824521624 yes that could be the good solution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1812: fix: can not configure upstream with no nodes
netlify[bot] edited a comment on pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-823852872 Deploy preview for *apisix-dashboard* processing. Building with commit 79f014e2c3e3077f1aa7c8e535b36f8b46a9c6a8 https://app.netlify.com/sites/apisix-dashboard/deploys/6080f53255f7330008ca7e6c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2750212) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4590801) will **decrease** coverage by `19.41%`. > The diff coverage is `n/a`. > :exclamation: Current head 2750212 differs from pull request most recent head 18b2967. Consider uploading reports for the commit 18b2967 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1813 +/- ## === - Coverage 71.78% 52.37% -19.42% === Files 172 39 -133 Lines6100 2740 -3360 Branches 7130 -713 === - Hits 4379 1435 -2944 + Misses 1478 -367 + Partials 243 194 -49 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.37% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1815: [Fe]: issue regarding viewport in `route` page
juzhiyuan commented on issue #1815: URL: https://github.com/apache/apisix-dashboard/issues/1815#issuecomment-824520297 or only show some selected columns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4104: bug: if route has a proxy-rewrite plugin ， proxy-rewrite plugin in service does not take effect
spacewander commented on issue #4104: URL: https://github.com/apache/apisix/issues/4104#issuecomment-824519895 APISIX doesn't support running the same plugin twice. This breaks many assumptions and requires rewriting much of the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit 275021210a854e02b03cb8c12cb8635610b5fe17 https://app.netlify.com/sites/apisix-dashboard/deploys/6080f3fc736ff1000736b992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] cverdela edited a comment on issue #4104: bug: if route has a proxy-rewrite plugin ， proxy-rewrite plugin in service does not take effect
cverdela edited a comment on issue #4104: URL: https://github.com/apache/apisix/issues/4104#issuecomment-824513110 When both Route and Service enable the same plugin, the Route parameter has a higher priority than Service. However，I want to add proxy-rewrite plugin to both route and service -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] cverdela commented on issue #4104: bug: if route has a proxy-rewrite plugin ， proxy-rewrite plugin in service does not take effect
cverdela commented on issue #4104: URL: https://github.com/apache/apisix/issues/4104#issuecomment-824513110 When both Route and Service enable the same plugin, the Route parameter has a higher priority than Service. However，I want to add plug-ins to both route and service -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] cverdela closed issue #4104: bug: if route has a proxy-rewrite plugin ， proxy-rewrite plugin in service does not take effect
cverdela closed issue #4104: URL: https://github.com/apache/apisix/issues/4104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] cverdela commented on issue #4104: bug: if route has a proxy-rewrite plugin ， proxy-rewrite plugin in service does not take effect
cverdela commented on issue #4104: URL: https://github.com/apache/apisix/issues/4104#issuecomment-824510915 @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] cverdela commented on issue #4104: bug: if route has a proxy-rewrite plugin ， proxy-rewrite plugin in service does not take effect
cverdela commented on issue #4104: URL: https://github.com/apache/apisix/issues/4104#issuecomment-824510675 update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] cverdela commented on issue #4104: bug: if route has a proxy-rewrite plugin ， proxy-rewrite plugin in service does not take effect
cverdela commented on issue #4104:
URL: https://github.com/apache/apisix/issues/4104#issuecomment-824510557
Issue description
Environment
apisix version (cmd: apisix version):2.3 (docker image
apache/apisix:2.3-alpine )
OS (cmd: uname -a):Linux 570c5064c3f9 4.9.93-linuxkit-aufs #1 SMP Wed Jun 6
16:55:56 UTC 2018 x86_64 Linux ( docker )
OpenResty / Nginx version (cmd: nginx -V or openresty -V): openresty/1.19.3.1
etcd version, if have (cmd: run curl http://127.0.0.1:9090/v1/server_info to
get the info from server-info API):3.4.9
apisix-dashboard version, if have:2.4
luarocks version, if the issue is about installation (cmd: luarocks
--version):luarocks 3.3.1
Minimal test code / Steps to reproduce the issue
any upstream
route conifg :
{
"status": 1,
"name": "web2",
"uris": [
"/we/*"
],
"methods": [
"GET",
"HEAD",
"POST",
"PUT",
"DELETE",
"OPTIONS",
"PATCH"
],
"id": "351385589259436746",
"create_time": 1618971732,
"plugins": {
"proxy-rewrite": {
"scheme": "http",
"regex_uri": ["^/we/web(.*)", "/web$1"]
}
},
"update_time": 1618971986,
"labels": {
"API_VERSION": "1"
},
"service_id": "348075546078347976"
}
service config :
{
"update_time": 1618987372,
"id": "348075546078347976",
"upstream_id": "351385449672999625",
"plugins": {
"proxy-rewrite": {
"headers": {
"1": "2"
}
},
"serverless-pre-function": {
"phase": "log",
"functions" : ["return function() local headers_tab = ngx.req.get_headers()
for k,v in pairs(headers_tab) do
ngx.log(ngx.ERR,'--header--'..k..':'..v..'--header--') end end"]
}
},
"desc": "测试",
"name": "test",
"create_time": 1616998792
}
What's the actual result? (including assertion message & call stack if
applicable)
headers without "1"："2"
What's the expected result?
headers with "1"："2"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy commented on a change in pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
KishaniKandasamy commented on a change in pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#discussion_r618050103 ## File path: docs/en/latest/FAQ.md ## @@ -70,3 +70,6 @@ $ swagger generate spec -o ./docs/en/latest/api/api.yaml --scan-models ```shell $ swagger-markdown -i ./docs/en/latest/api/api.yaml ``` +### 6. What is the default strategy when import a duplicate route? Review comment: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Firstsawyou edited a comment on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Firstsawyou edited a comment on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-824505125 > > ok for close the issue. But i am quite interesting in what scenario that users will create a upstream with empty node list? > > @Firstsawyou any scenarios when users create an upstream with empty nodes? I have not encountered this situation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Firstsawyou commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Firstsawyou commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-824505125 > > ok for close the issue. But i am quite interesting in what scenario that users will create a upstream with empty node list? > > @Firstsawyou any scenarios when users create an upstream with empty nodes? I have not encountered this situation. Setting the upstream with empty node, it seems that there is no usage scenario. I will create an issue on the backend to discuss it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4102: Passive healthcheck not working when a route has only one upstream
spacewander commented on issue #4102: URL: https://github.com/apache/apisix/issues/4102#issuecomment-824503850 Done: https://github.com/apache/apisix/pull/4105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4105: docs(health-check): more notes
spacewander opened a new pull request #4105: URL: https://github.com/apache/apisix/pull/4105 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] hnlq715 commented on issue #1391: feat: embed all generated web assets into api binary
hnlq715 commented on issue #1391: URL: https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-824496065 Another concern is go:embed should support compress in later release, and we can use this feature to reduce binary size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gxthrj commented on issue #3963: request help: Distinguish the source (upstream or apisix) of the status code, whether it can be extended to all the status code
gxthrj commented on issue #3963: URL: https://github.com/apache/apisix/issues/3963#issuecomment-824493247 I think recording all non-2xx requests and provide a similar header of x-upstream-status is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] hnlq715 edited a comment on issue #1391: feat: embed all generated web assets into api binary
hnlq715 edited a comment on issue #1391: URL: https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-824492523 Maybe it's more practical to always embed the web assets in build process, but provide a flag to use the embed or the external assets in startup? After all, we just need one binary release in production, and it's helpful if supporting the external assets when debug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] hnlq715 commented on issue #1391: feat: embed all generated web assets into api binary
hnlq715 commented on issue #1391: URL: https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-824492523 Maybe it's more practical to always embed the web assets in build process, but provide a flag to use the embed or the external assets in startup? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: Arabic translation of README.md. (#4044)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 86e4983 docs: Arabic translation of README.md. (#4044) 86e4983 is described below commit 86e49837d20147471eeb852d60d4c5e2f15a2bd4 Author: Mujahid Al-Majali <81928799+majal...@users.noreply.github.com> AuthorDate: Thu Apr 22 05:17:02 2021 +0300 docs: Arabic translation of README.md. (#4044) Co-authored-by: John Bampton --- docs/ar/README.md | 355 ++ 1 file changed, 355 insertions(+) diff --git a/docs/ar/README.md b/docs/ar/README.md new file mode 100644 index 000..3c311e0 --- /dev/null +++ b/docs/ar/README.md @@ -0,0 +1,355 @@ + + + + +# أباتشي أبيسكس + +https://svn.apache.org/repos/asf/comdev/project-logos/originals/apisix.svg; alt="APISIX logo" height="150px" align="right" /> + +[](https://github.com/apache/apisix/actions) +[](https://github.com/apache/apisix/blob/master/LICENSE) + +**أباتشي أبيسكس** هو عبارة عن بوابة ديناميكية وفي الوقت الفعلي وعالية الاداء + +أباتشي أبيسكس توفر امتيازات حركة مرور كبيرة مثل (موازنة التحميل، المنبع الديناميكي، إصدار كناري، كسر الدائرة، المصادقة، إمكانية المراقبة، والمزيد. +يمكنك استخدام أباتشي أبيسكس للتعامل مع حركة المرور التقليدية شمالا-جنوبا +وأيضا بحركة شرق-غرب بين الخدمات. +يمكن استخدامه أيضا [كوحدة تحكم دخول k8s](https://github.com/apache/apisix-ingress-controller). + +بنية الهيكل الفني لأباتشي أبيسكس: + + +## المجتمع + +القائمة البريدية: أرسل بالبريد إلى dev-subscr...@apisix.apache.org + +اتبع الرد للاشتراك في القائمة البريدية. + +مجموعة QQ - 578997126 + +- [مساحة عمل Slack](https://join.slack.com/t/the-asf/shared_invite/zt-mrougyeu-2aG7BnFaV0VnAT9_JIUVaA) - تابع `#apisix` على Slack لمقابلة الفريق وطرح الأسئلة +-  - تابعنا وتفاعل معنا باستخدام الهاشتاج `#ApacheAPISIX` +- [bilibili فيديو](https://space.bilibili.com/551921247) +- **الاصدارات الأولى الجيدة**: + - [اباتشي ابيسكس](https://github.com/apache/apisix/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [وحدة تحكم الدخول أباتشي ابيسكس](https://github.com/apache/apisix-ingress-controller/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [لوحة القيادة أباتشي ابيسكس](https://github.com/apache/apisix-dashboard/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [مخطط خوذة أباتشي ابيسكس](https://github.com/apache/apisix-helm-chart/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [توزيع أباتشي ابيسكس](https://github.com/apache/apisix-docker/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [موقع ويب أباتشي ابيسكس](https://github.com/apache/apisix-website/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [طائرة التحكم لـ أبيسكس](https://github.com/apache/apisix-control-plane/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + +## السمات + +• يمكنك استخدام أباتشي أبيسكس كمدخل لحركة المرور لمعالجة جميع بيانات الأعمال ، بما في ذلك التوجيه الديناميكي ، والمنبع الديناميكي ، والشهادات الديناميكية ، واختبار A / B ، وإصدار الكناري ، والنشر الأزرق والأخضر ، ومعدل الحد ، والدفاع ضد الهجمات الضارة ، والمقاييس ، وإنذارات المراقبة ، وقابلية مراقبة الخدمة ، وحوكمة الخدمة ، وما إلى ذلك. + +- **جميع المنصات** + + Native: النظام الأساسي غير المقيد ، لا يوجد قفل للبائع ، يمكن تشغيل APISIX من النظام الأساسي إلى Kubernetes. + +• بيئة التشغيل: يتم دعم كل من OpenResty و Tengine. + +• يدعم ARM64: لا تقلق بشأن قفل تقنية الأشعة تحت الحمراء. + +- **متعدد البروتوكولات** + + - [TCP/UDP وكيل](docs/en/latest/stream-proxy.md): ديناميكي TCP/UDP وكيل. + - [Dubbo وكيل](docs/en/latest/plugins/dubbo-proxy.md): ديناميكي HTTP to Dubbo وكيل. + - [ديناميكي MQTT وكيل](docs/en/latest/plugins/mqtt-proxy.md): يدعم تحميل MQTT بواسطة `client_id`, وكلاهما يدعم MQTT [3.1.\*](http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html), [5.0](https://docs.oasis-open.org/mqtt/mqtt/v5.0/mqtt-v5.0.html). + - [gRPC proxy](docs/en/latest/grpc-proxy.md):توكيل حركة مرور gRPC . + - [gRPC transcoding](docs/en/latest/plugins/grpc-transcode.md): يدعم تحويل ترميز البروتوكول بحيث يمكن للعملاء الوصول إلى واجهة برمجة تطبيقات gRPC الخاصة بك باستخدام HTTP/JSON. + - مقبس الويب الوكيل + - بروتوكول الوكيل + - الوكيل Dubbo: Dubbo يعتمد على Tengine. + - HTTP(S)وكيل إعادة التوجيه + - [SSL](docs/en/latest/https.md): تحميل شهادة SSL ديناميكيًا. + +- **ديناميكية كاملة** + + - [التحديثات الطارئة والإضافات
[GitHub] [apisix] spacewander merged pull request #4044: docs: Arabic translation of README.md.
spacewander merged pull request #4044: URL: https://github.com/apache/apisix/pull/4044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #4074: request help: How to rewrite the data of backend server response?
spacewander closed issue #4074: URL: https://github.com/apache/apisix/issues/4074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
liuxiran commented on a change in pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#discussion_r618032498 ## File path: docs/en/latest/FAQ.md ## @@ -70,3 +70,6 @@ $ swagger generate spec -o ./docs/en/latest/api/api.yaml --scan-models ```shell $ swagger-markdown -i ./docs/en/latest/api/api.yaml ``` +### 6. What is the default strategy when import a duplicate route? Review comment: yep, only to fix the lint error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4096: request help: plugin proxy-rewrite in service not work
spacewander commented on issue #4096: URL: https://github.com/apache/apisix/issues/4096#issuecomment-824487695 surpassed by #4104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #4096: request help: plugin proxy-rewrite in service not work
spacewander closed issue #4096: URL: https://github.com/apache/apisix/issues/4096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4104: bug: proxy-rewrite plugin in service does not take effect
spacewander commented on issue #4104:
URL: https://github.com/apache/apisix/issues/4104#issuecomment-824487577
Can't reproduce at my side. I got:
```
2021/04/22 10:08:09 [error] 2454#2454: *2 [lua] [string "return function()
local headers_tab = ngx.req..."]:1: func(): --header--1:2--header-- while
logging request, client: 127.0.0.1, server: localhost, request: "GET /hello
HTTP/1.1", upstream: "http://127.0.0.1:1980/hello;, host: "localhost"
2021/04/22 10:08:09 [error] 2454#2454: *2 [lua] [string "return function()
local headers_tab = ngx.req..."]:1: func(): --header--host:localhost--header--
while logging request, client: 127.0.0.1, server: localhost, request: "GET
/hello HTTP/1.1", upstream: "http://127.0.0.1:1980/hello;, host: "localhost"
2021/04/22 10:08:09 [error] 2454#2454: *2 [lua] [string "return function()
local headers_tab = ngx.req..."]:1: func():
--header--connection:close--header-- while logging request, client: 127.0.0.1,
server: localhost, request: "GET /hello HTTP/1.1", upstream:
"http://127.0.0.1:1980/hello;, host: "localhost"
```
Here is my route configuration:
```
{
"uri": "/hello",
"service_id": 1
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Ben0625 commented on issue #4102: Passive healthcheck not working when a route has only one upstream
Ben0625 commented on issue #4102: URL: https://github.com/apache/apisix/issues/4102#issuecomment-824481903 > It is by design. If you only have one upstream, you don't need to care about which one is healthy. You only have one choice. OK I got it, Thanks. I think it will be clearer for users if this is mentioned in the healthcheck document. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1815: [Fe]: issue regarding viewport in `route` page
iamayushdas commented on issue #1815: URL: https://github.com/apache/apisix-dashboard/issues/1815#issuecomment-824481357 Doing that would work, but is that the only solution? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4003: docs: faq doc add use the FQDN address
spacewander merged pull request #4003: URL: https://github.com/apache/apisix/pull/4003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: faq doc add use the FQDN address (#4003)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 750a9cf docs: faq doc add use the FQDN address (#4003)
750a9cf is described below
commit 750a9cf5e7bb770899b2cc797d21bf75f329b098
Author: Yuelin Zheng <2226815...@qq.com>
AuthorDate: Thu Apr 22 09:47:32 2021 +0800
docs: faq doc add use the FQDN address (#4003)
---
docs/en/latest/FAQ.md | 28 +++-
docs/zh/latest/FAQ.md | 26 +-
2 files changed, 52 insertions(+), 2 deletions(-)
diff --git a/docs/en/latest/FAQ.md b/docs/en/latest/FAQ.md
index 8242cac..9c44159 100644
--- a/docs/en/latest/FAQ.md
+++ b/docs/en/latest/FAQ.md
@@ -392,9 +392,35 @@ HTTP/1.1 200 OK
...
# The uri match failed
-curl http://127.0.0.1:9080/12ab -i
+$ curl http://127.0.0.1:9080/12ab -i
HTTP/1.1 404 Not Found
...
```
In route, we can achieve more condition matching by combining `uri` with
`vars` field. For more details of using `vars`, please refer to
[lua-resty-expr](https://github.com/api7/lua-resty-expr).
+
+## Does the upstream node support configuring the
[FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) address
+
+This is supported. Here is an example where the `FQDN` is
`httpbin.default.svc.cluster.local`:
+
+This is supported. Here is an example where the `FQDN` is
`httpbin.default.svc.cluster.local` (a Kubernetes Service):
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/ip",
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"httpbin.default.svc.cluster.local": 1
+}
+}
+}'
+```
+
+```shell
+# Test request
+$ curl http://127.0.0.1:9080/ip -i
+HTTP/1.1 200 OK
+...
+```
diff --git a/docs/zh/latest/FAQ.md b/docs/zh/latest/FAQ.md
index 6e1fd54..c32a2d5 100644
--- a/docs/zh/latest/FAQ.md
+++ b/docs/zh/latest/FAQ.md
@@ -393,9 +393,33 @@ HTTP/1.1 200 OK
...
# uri 匹配失败
-curl http://127.0.0.1:9080/12ab -i
+$ curl http://127.0.0.1:9080/12ab -i
HTTP/1.1 404 Not Found
...
```
在 route 中，我们可以通过 `uri` 结合 `vars` 字段来实现更多的条件匹配，`vars` 的更多使用细节请参考
[lua-resty-expr](https://github.com/api7/lua-resty-expr)。
+
+## upstream 节点是否支持配置
[FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) 地址?
+
+这是支持的，下面是一个 `FQDN` 为 `httpbin.default.svc.cluster.local`(一个 Kubernetes
Service) 的示例：
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/ip",
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"httpbin.default.svc.cluster.local": 1
+}
+}
+}'
+```
+
+```shell
+# 测试请求
+$ curl http://127.0.0.1:9080/ip -i
+HTTP/1.1 200 OK
+...
+```
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #398: feat: add tcp route data structures and cache
gxthrj commented on pull request #398: URL: https://github.com/apache/apisix-ingress-controller/pull/398#issuecomment-824474669 BTW, There is no e2e test for stream route. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #398: feat: add tcp route data structures and cache
gxthrj commented on a change in pull request #398:
URL:
https://github.com/apache/apisix-ingress-controller/pull/398#discussion_r618006188
##
File path: pkg/apisix/nonexistentclient.go
##
@@ -132,15 +160,19 @@ type dummyCache struct{}
var _ cache.Cache = {}
-func (c *dummyCache) InsertRoute(_ *v1.Route) error { return nil }
-func (c *dummyCache) InsertSSL(_ *v1.Ssl) error { return nil }
-func (c *dummyCache) InsertUpstream(_ *v1.Upstream) error{ return nil }
-func (c *dummyCache) GetRoute(_ string) (*v1.Route, error) { return nil,
cache.ErrNotFound }
-func (c *dummyCache) GetSSL(_ string) (*v1.Ssl, error) { return nil,
cache.ErrNotFound }
-func (c *dummyCache) GetUpstream(_ string) (*v1.Upstream, error) { return nil,
cache.ErrNotFound }
-func (c *dummyCache) ListRoutes() ([]*v1.Route, error) { return nil,
nil }
-func (c *dummyCache) ListSSL() ([]*v1.Ssl, error){ return nil,
nil }
-func (c *dummyCache) ListUpstreams() ([]*v1.Upstream, error) { return nil,
nil }
-func (c *dummyCache) DeleteRoute(_ *v1.Route) error { return nil }
-func (c *dummyCache) DeleteSSL(_ *v1.Ssl) error { return nil }
-func (c *dummyCache) DeleteUpstream(_ *v1.Upstream) error{ return nil }
+func (c *dummyCache) InsertRoute(_ *v1.Route) error{
return nil }
+func (c *dummyCache) InsertSSL(_ *v1.Ssl) error{
return nil }
+func (c *dummyCache) InsertUpstream(_ *v1.Upstream) error {
return nil }
+func (c *dummyCache) InsertStreamRoute(_ *v1.StreamRoute) error{
return nil }
+func (c *dummyCache) GetRoute(_ string) (*v1.Route, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) GetSSL(_ string) (*v1.Ssl, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) GetUpstream(_ string) (*v1.Upstream, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) GetStreamRoute(_ string) (*v1.StreamRoute, error) {
return nil, cache.ErrNotFound }
+func (c *dummyCache) ListRoutes() ([]*v1.Route, error) {
return nil, nil }
+func (c *dummyCache) ListSSL() ([]*v1.Ssl, error) {
return nil, nil }
+func (c *dummyCache) ListUpstreams() ([]*v1.Upstream, error) {
return nil, nil }
+func (c *dummyCache) ListStreamRoutes() ([]*v1.StreamRoute, error) {
return nil, nil }
+func (c *dummyCache) DeleteRoute(_ *v1.Route) error{
return nil }
+func (c *dummyCache) DeleteSSL(_ *v1.Ssl) error{
return nil }
+func (c *dummyCache) DeleteUpstream(_ *v1.Upstream) error {
return nil }
+func (c *dummyCache) DeleteStreamRoute(_ *v1.StreamRoute) error{
return nil }
Review comment:
Can these methods be refactored to be together,
such as, dummyCache.Insert(), dummyCache.List()
##
File path: pkg/apisix/stream_route.go
##
@@ -0,0 +1,223 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package apisix
+
+import (
+ "bytes"
+ "context"
+ "encoding/json"
+
+ "go.uber.org/zap"
+
+ "github.com/apache/apisix-ingress-controller/pkg/apisix/cache"
+ "github.com/apache/apisix-ingress-controller/pkg/id"
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+ v1 "github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+type streamRouteClient struct {
+ url string
+ cluster *cluster
+}
+
+func newStreamRouteClient(c *cluster) StreamRoute {
+ return {
+ url: c.baseURL + "/stream_routes",
+ cluster: c,
+ }
+}
+
+// Get returns the StreamRoute.
+// FIXME, currently if caller pass a non-existent resource, the Get always
passes
+// through cache.
+func (r *streamRouteClient) Get(ctx context.Context, name string)
(*v1.StreamRoute, error) {
+ log.Debugw("try to look up stream_route",
+ zap.String("name", name),
+ zap.String("url", r.url),
+ zap.String("cluster", "default"),
+ )
+ rid := id.GenID(name)
+ streamRoute, err :=
[GitHub] [apisix] cverdela commented on issue #4096: request help: plugin proxy-rewrite in service not work
cverdela commented on issue #4096: URL: https://github.com/apache/apisix/issues/4096#issuecomment-824472474 https://github.com/apache/apisix/issues/4104 bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] cverdela opened a new issue #4104: bug: proxy-rewrite plugin in service does not take effect
cverdela opened a new issue #4104:
URL: https://github.com/apache/apisix/issues/4104
### Issue description
### Environment
* apisix version (cmd: `apisix version`):2.3
* OS (cmd: `uname -a`):docker
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
openresty/1.19.3.1
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info
API):3.4.9
* apisix-dashboard version, if have:2.4
* luarocks version, if the issue is about installation (cmd: `luarocks
--version`):luarocks 3.3.1
### Minimal test code / Steps to reproduce the issue
any upstream
{
"update_time": 1618987372,
"id": "348075546078347976",
"upstream_id": "351385449672999625",
"plugins": {
"proxy-rewrite": {
"headers": {
"1": "2"
}
},
"serverless-pre-function": {
"phase": "log",
"functions" : ["return function() local headers_tab =
ngx.req.get_headers() for k,v in pairs(headers_tab) do
ngx.log(ngx.ERR,'--header--'..k..':'..v..'--header--') end end"]
}
},
"desc": "测试",
"name": "test",
"create_time": 1616998792
}
### What's the actual result? (including assertion message & call stack if
applicable)
headers without "1"："2"
### What's the expected result?
headers with "1"："2"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #386: feat: add event & status for ApisixRoute v2
gxthrj commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r61885
##
File path: pkg/ingress/secret.go
##
@@ -184,9 +184,9 @@ func (c *secretController) onAdd(obj interface{}) {
return
}
- log.Debugw("secret add event arrived",
- zap.Any("object", obj),
- )
+ //log.Debugw("secret add event arrived",
+ // zap.Any("object", obj),
Review comment:
if log "object" with `zap.Any`, got error ` bad access: nil dereference`.
I changed logging field.
##
File path: pkg/ingress/endpoint.go
##
@@ -181,8 +181,8 @@ func (c *endpointsController) onAdd(obj interface{}) {
if !c.controller.namespaceWatching(key) {
return
}
- log.Debugw("endpoints add event arrived",
- zap.Any("object", obj))
+ //log.Debugw("endpoints add event arrived",
Review comment:
if log "object" with `zap.Any`, got error ` bad access: nil dereference`.
I changed logging field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #386: feat: add event & status for ApisixRoute v2
tokers commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617994188
##
File path: pkg/ingress/endpoint.go
##
@@ -181,8 +181,8 @@ func (c *endpointsController) onAdd(obj interface{}) {
if !c.controller.namespaceWatching(key) {
return
}
- log.Debugw("endpoints add event arrived",
- zap.Any("object", obj))
+ //log.Debugw("endpoints add event arrived",
Review comment:
Ping @gxthrj .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4103: bug: Multiple unhealthy HTTP increment if the size of passive.unhealthy.http_statuses is more than 1
spacewander commented on issue #4103: URL: https://github.com/apache/apisix/issues/4103#issuecomment-824462530 CC @membphis Is there special meaning for the double loop? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on pull request #1667: feat: run manager-api as a systemd daemon/service
tokers commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-824462005 @bisakhmondal I think we can change the title now, it's not so associated with systemd. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
tokers commented on a change in pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617990056
##
File path: api/cmd/managerapi.go
##
@@ -59,6 +60,14 @@ func printVersion() {
// NewManagerAPICommand creates the manager-api command.
func NewManagerAPICommand() *cobra.Command {
+ cobra.OnInitialize(func() {
+ var err error
+ service, err = createService()
+ if err != nil {
+ fmt.Fprintf(os.Stderr, "error occurred while
initializing service: %s", err)
Review comment:
I think we can quit after outputing this message.
##
File path: api/cmd/managerapi.go
##
@@ -68,91 +77,136 @@ func NewManagerAPICommand() *cobra.Command {
printVersion()
os.Exit(0)
}
+ err := manageAPI()
+ return err
+ },
+ }
- conf.InitConf()
- log.InitLogger()
+ cmd.PersistentFlags().StringVarP(, "work-dir", "p", ".",
"current work directory")
+ cmd.PersistentFlags().BoolVarP(, "version", "v", false,
"show manager-api version")
- if err := utils.WritePID(conf.PIDPath); err != nil {
- log.Errorf("failed to write pid: %s", err)
- panic(err)
- }
- utils.AppendToClosers(func() error {
- if err := os.Remove(conf.PIDPath); err != nil {
- log.Errorf("failed to remove pid path:
%s", err)
- return err
- }
- return nil
- })
-
- droplet.Option.Orchestrator = func(mws
[]droplet.Middleware) []droplet.Middleware {
- var newMws []droplet.Middleware
- // default middleware order: resp_reshape,
auto_input, traffic_log
- // We should put err_transform at second to
catch all error
- newMws = append(newMws, mws[0],
{}, {})
- newMws = append(newMws, mws[1:]...)
- return newMws
- }
+ cmd.AddCommand(newStartCommand(), newInstallCommand(),
newStatusCommand(), newStopCommand(), newRemoveCommand())
+ return cmd
+}
- if err := storage.InitETCDClient(conf.ETCDConfig); err
!= nil {
- log.Errorf("init etcd client fail: %w", err)
- panic(err)
- }
- if err := store.InitStores(); err != nil {
- log.Errorf("init stores fail: %w", err)
- panic(err)
- }
+func manageAPI() error {
+ conf.InitConf()
+ log.InitLogger()
- // routes
- r := internal.SetUpRouter()
- addr := fmt.Sprintf("%s:%d", conf.ServerHost,
conf.ServerPort)
- s := {
- Addr: addr,
- Handler: r,
- ReadTimeout: time.Duration(1000) *
time.Millisecond,
- WriteTimeout: time.Duration(5000) *
time.Millisecond,
- }
+ if err := utils.WritePID(conf.PIDPath); err != nil {
+ log.Errorf("failed to write pid: %s", err)
+ panic(err)
+ }
+ utils.AppendToClosers(func() error {
+ if err := os.Remove(conf.PIDPath); err != nil {
+ log.Errorf("failed to remove pid path: %s", err)
+ return err
+ }
+ return nil
+ })
+
+ droplet.Option.Orchestrator = func(mws []droplet.Middleware)
[]droplet.Middleware {
+ var newMws []droplet.Middleware
+ // default middleware order: resp_reshape, auto_input,
traffic_log
+ // We should put err_transform at second to catch all error
+ newMws = append(newMws, mws[0],
{}, {})
+ newMws = append(newMws, mws[1:]...)
+ return newMws
+ }
- log.Infof("The Manager API is listening on %s", addr)
+ if err := storage.InitETCDClient(conf.ETCDConfig); err != nil {
+ log.Errorf("init etcd client fail: %w", err)
+ panic(err)
+ }
+ if err := store.InitStores(); err != nil {
+ log.Errorf("init stores fail: %w", err)
+ panic(err)
+ }
- quit := make(chan os.Signal, 1)
-
[GitHub] [apisix] spacewander commented on a change in pull request #4099: feat: jwt-auth support extension payload
spacewander commented on a change in pull request #4099:
URL: https://github.com/apache/apisix/pull/4099#discussion_r617991536
##
File path: apisix/plugins/jwt-auth.lua
##
@@ -277,18 +285,44 @@ function _M.rewrite(conf, ctx)
if not consumer then
return 401, {message = "Invalid user key in JWT token"}
end
-core.log.info("consumer: ", core.json.delay_encode(consumer))
+log.info("consumer: ", core.json.delay_encode(consumer))
local _, auth_secret = algorithm_handler(consumer)
jwt_obj = jwt:verify_jwt_obj(auth_secret, jwt_obj)
-core.log.info("jwt object: ", core.json.delay_encode(jwt_obj))
+log.info("jwt object: ", core.json.delay_encode(jwt_obj))
if not jwt_obj.verified then
return 401, {message = jwt_obj.reason}
end
consumer_mod.attach_consumer(ctx, consumer, consumer_conf)
-core.log.info("hit jwt-auth rewrite")
+log.info("hit jwt-auth rewrite")
+end
+
+
+local function user_info()
Review comment:
This feature can be implemented as a local script to check.
There is no need to expose it as a public API of the gateway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix] branch master updated: fix(traffic-split): configure multiple "rules", the request will be confused between upstream (#4092)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 9456568 fix(traffic-split): configure multiple "rules", the request
will be confused between upstream (#4092)
9456568 is described below
commit 94565689f728d12e0fa5eaf2c8909bb022a75448
Author: Yuelin Zheng <2226815...@qq.com>
AuthorDate: Thu Apr 22 08:58:23 2021 +0800
fix(traffic-split): configure multiple "rules", the request will be
confused between upstream (#4092)
---
apisix/plugins/traffic-split.lua| 3 +-
docs/en/latest/plugins/traffic-split.md | 93 +
docs/zh/latest/plugins/traffic-split.md | 93 +
t/plugin/traffic-split2.t | 324
4 files changed, 511 insertions(+), 2 deletions(-)
diff --git a/apisix/plugins/traffic-split.lua b/apisix/plugins/traffic-split.lua
index 5364438..f7e75af 100644
--- a/apisix/plugins/traffic-split.lua
+++ b/apisix/plugins/traffic-split.lua
@@ -278,8 +278,7 @@ function _M.access(conf, ctx)
return
end
-local rr_up, err = core.lrucache.plugin_ctx(lrucache, ctx, nil, new_rr_obj,
-weighted_upstreams)
+local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj,
weighted_upstreams)
if not rr_up then
core.log.error("lrucache roundrobin failed: ", err)
return 500
diff --git a/docs/en/latest/plugins/traffic-split.md
b/docs/en/latest/plugins/traffic-split.md
index 9189a81..4882da1 100644
--- a/docs/en/latest/plugins/traffic-split.md
+++ b/docs/en/latest/plugins/traffic-split.md
@@ -30,6 +30,7 @@ title: traffic-split
- [Grayscale Release](#grayscale-release)
- [Blue-green Release](#blue-green-release)
- [Custom Release](#custom-release)
+ - [Matching rules correspond to
upstream](#matching-rules-correspond-to-upstream)
- [Disable Plugin](#disable-plugin)
## Name
@@ -482,6 +483,98 @@ Content-Type: text/html; charset=utf-8
hello 1980
```
+### Matching rules correspond to upstream
+
+By configuring multiple `rules`, we can achieve one-to-one correspondence
between different matching rules and upstream.
+
+**Example:**
+
+When the request header `x-api-id` is equal to 1, it hits the upstream with
port 1981; when `x-api-id` is equal to 2, it hits the upstream with port 1982;
otherwise, it hits the upstream with port 1980 (the upstream response data is
the corresponding port number).
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/hello",
+"plugins": {
+"traffic-split": {
+"rules": [
+{
+"match": [
+{
+"vars": [
+["http_x-api-id","==","1"]
+]
+}
+],
+"weighted_upstreams": [
+{
+"upstream": {
+"name": "upstream-A",
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:1981":1
+}
+},
+"weight": 3
+}
+]
+},
+{
+"match": [
+{
+"vars": [
+["http_x-api-id","==","2"]
+]
+}
+],
+"weighted_upstreams": [
+{
+"upstream": {
+"name": "upstream-B",
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:1982":1
+}
+},
+"weight": 3
+}
+]
+}
+]
+}
+},
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:1980": 1
+}
+}
+}'
+```
+
+**Test plugin:**
+
+The request header `x-api-id` is equal to 1, hitting the upstream with the
1981 port.
+
+```shell
+$ curl http://127.0.0.1:9080/hello -H 'x-api-id: 1'
+1981
+```
+
+The request header `x-api-id` is equal to 2, hitting the upstream with the
1982 port.
+
+```shell
+$ curl http://127.0.0.1:9080/hello -H 'x-api-id: 2'
+1982
+```
+
+The request header `x-api-id` is equal to 3, the rule does not match, and it
hits the upstream with port 1980.
+
[GitHub] [apisix] spacewander merged pull request #4092: fix(traffic-split): configure multiple "rules", the request will be confused between upstream
spacewander merged pull request #4092: URL: https://github.com/apache/apisix/pull/4092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1815: [Fe]: issue regarding viewport in `route` page
juzhiyuan commented on issue #1815: URL: https://github.com/apache/apisix-dashboard/issues/1815#issuecomment-824455495  How about clicking this place? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1391: feat: embed all generated web assets into api binary
LiteSun commented on issue #1391: URL: https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-824445350 Vote for supporting to specify whether to embed the web by parameter and looking forward to this feature!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
LiteSun commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-824442184 +1 for keeping the current behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1040: Support Error highlighting for plugin's code mirror
LiteSun commented on issue #1040: URL: https://github.com/apache/apisix-dashboard/issues/1040#issuecomment-824441044 Good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] 1502shivam-singh commented on pull request #1805: chore: icons added for auth, security, traffic, serverless
1502shivam-singh commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824265482 > Thanks for your suggestion @1502shivam-singh smaller icons are the issue that would be resolved by using css properties, couldn't do the css stuff because of the urgency of icons last day, > > Other icons are on the way as it takes a lot of time to think about every icon Yup , it's perfectly fine. You have got a lot of icons to design ;) > I am not sure if we are going to change the jwt-auth icon, let me complete all the icons first then will do the final touches, what say @1502shivam-singh Okay, we can do this later. I feel we should have the other icons on the dashboard too for a complete picture. Just keep in mind the "similar design" that I was implying in my above comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new issue #1815: [Fe]: issue regarding viewport in `route` page
iamayushdas opened a new issue #1815: URL: https://github.com/apache/apisix-dashboard/issues/1815 ## Issue description 1. issue occurred while running website on "1366 x 768" resolution. 2. also the subtitle of every page looks bit odd for the UI, I guess its about font, or the subtitles should have least amount of text, or should be in bullet format ## Expected behavior should be responsive on "1366 x 768" resolution ## How to Reproduce Go to "route page" ## Screenshots  ## Environment OS : Ubuntu 20.04.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy commented on a change in pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
KishaniKandasamy commented on a change in pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#discussion_r617759315 ## File path: docs/en/latest/FAQ.md ## @@ -70,3 +70,6 @@ $ swagger generate spec -o ./docs/en/latest/api/api.yaml --scan-models ```shell $ swagger-markdown -i ./docs/en/latest/api/api.yaml ``` +### 6. What is the default strategy when import a duplicate route? Review comment: may be for leaving a line樂? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
netlify[bot] edited a comment on pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134 Deploy preview for *apisix-dashboard* ready! Built with commit a7d7b5b8a1ae8fb88b206d9aef601b11233aa443 https://deploy-preview-1808--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
netlify[bot] edited a comment on pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134 Deploy preview for *apisix-dashboard* processing. Building with commit a7d7b5b8a1ae8fb88b206d9aef601b11233aa443 https://app.netlify.com/sites/apisix-dashboard/deploys/6080627e5d88f10008191d43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless
netlify[bot] edited a comment on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128 Deploy preview for *apisix-dashboard* ready! Built with commit c0e7c2d1ecb1fb5dee899635c119217468a21f43 https://deploy-preview-1805--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless
netlify[bot] edited a comment on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128 Deploy preview for *apisix-dashboard* processing. Building with commit c0e7c2d1ecb1fb5dee899635c119217468a21f43 https://app.netlify.com/sites/apisix-dashboard/deploys/60805f02ff659c0007258590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless
iamayushdas commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824215894 I am not sure if we are going to change the jwt-auth icon, let me complete all the icons first then will do the final touches, what say @1502shivam-singh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless
iamayushdas commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824213254 Thanks for your suggestion @1502shivam-singh smaller icons are the issue that would be resolved by using css properties, couldn't do the css stuff because of the urgency of icons last day, Other icons are on the way as it takes a lot of time to think about every icon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1754: feat: rewrite e2e test(rewrite-e2e-test-route-service-upstream-test) with ginkgo
juzhiyuan merged pull request #1754: URL: https://github.com/apache/apisix-dashboard/pull/1754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: rewrite e2e test(rewrite-e2e-test-route-service-upstream-test) with ginkgo (#1754)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 40930e8 feat: rewrite e2e
test(rewrite-e2e-test-route-service-upstream-test) with ginkgo (#1754)
40930e8 is described below
commit 40930e82b33de1ff852186992d4c04e43ef9d10d
Author: JinChen
AuthorDate: Wed Apr 21 23:41:40 2021 +0800
feat: rewrite e2e test(rewrite-e2e-test-route-service-upstream-test) with
ginkgo (#1754)
---
api/test/e2e/route_service_upstream_test.go| 294 --
.../e2enew/route/route_service_upstream_test.go| 425 +
2 files changed, 425 insertions(+), 294 deletions(-)
diff --git a/api/test/e2e/route_service_upstream_test.go
b/api/test/e2e/route_service_upstream_test.go
deleted file mode 100644
index e3cf072..000
--- a/api/test/e2e/route_service_upstream_test.go
+++ /dev/null
@@ -1,294 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package e2e
-
-import (
- "net/http"
- "testing"
- "time"
-
- "github.com/stretchr/testify/assert"
-)
-
-func TestRoute_Invalid_Service_And_Service(t *testing.T) {
- tests := []HttpTestCase{
- {
- Desc: "use service that not exist - dashboard",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
- "name": "route1",
- "uri": "/hello_",
- "service_id": "not-exists"
- }`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusBadRequest,
- },
- {
- Desc: "hit invalid route on data plane",
- Object: APISIXExpect(t),
- Method: http.MethodGet,
- Path: "/hello_",
- ExpectCode: http.StatusNotFound,
- },
- {
- Desc: "use upstream that not exist",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
- "name": "route1",
- "uri": "/hello_",
- "upstream_id": "not-exists"
- }`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusBadRequest,
- },
- {
- Desc: "hit invalid route on data plane",
- Object: APISIXExpect(t),
- Method: http.MethodGet,
- Path: "/hello_",
- ExpectCode: http.StatusNotFound,
- },
- {
- Desc: "create service and upstream together at the
same time",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
- "name": "route1",
- "uri": "/hello_",
- "service_id": "not-exists-service",
- "upstream_id": "not-exists-upstream"
- }`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusBadRequest,
- },
- {
- Desc: "hit invalid route on data plane",
- Object: APISIXExpect(t),
- Method: http.MethodGet,
- Path: "/hello_",
- ExpectCode: http.StatusNotFound,
-
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1040: Support Error highlighting for plugin's code mirror
juzhiyuan commented on issue #1040: URL: https://github.com/apache/apisix-dashboard/issues/1040#issuecomment-824162834 But you may face some issues from E2E test, you could ask for @guoqqqi @LiteSun to help you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1040: Support Error highlighting for plugin's code mirror
juzhiyuan commented on issue #1040: URL: https://github.com/apache/apisix-dashboard/issues/1040#issuecomment-824162470 Sure! that's what I want to do! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] 1502shivam-singh commented on pull request #1805: chore: icons added for auth, security, traffic, serverless
1502shivam-singh commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824137732 >  Nice Didn't knew some plugin-icons were already designed. Something to mention (I should have mentioned this earlier now I feel) we should keep icons with same prefix or suffix together and have these ones with similar style like for `"serverless-post and pre functions"`. To explicitly mention here, by similar style I don't only mean color from the APISIX pallete or other, I mean similar color schemes and color softness, with focus on the idea that should resonate from that icon. For example we have situation here that, all auth ones but jwt-auth have similar style. - Easiest way to circumvent this for now is to redesign "jwt-auth" and make some small guide or better follow some already created one, to design rest of the icons (like the duotone style followed currently). Also, something with sizes of the icons. Some look smaller than other like the `cors` and `wolf-rbac` one for instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: store init error from etcd and deferred execution of closers
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-824135228 Nice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit 0118bf1b9fda1b30dc793d42a8bc60b58baa9ca7 https://deploy-preview-1813--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on issue #1040: Support Error highlighting for plugin's code mirror
qian0817 commented on issue #1040: URL: https://github.com/apache/apisix-dashboard/issues/1040#issuecomment-824126221 @juzhiyuan Can I use the [monaco editor](https://microsoft.github.io/monaco-editor/) instead of codemirror to achieve this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit 0118bf1b9fda1b30dc793d42a8bc60b58baa9ca7 https://app.netlify.com/sites/apisix-dashboard/deploys/60803a7f5ee6980007323fba -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zuoshaoyi commented on issue #4100: bug: 设置upstream healthcheck后会把原来的router 关联的upstream 覆盖
zuoshaoyi commented on issue #4100: URL: https://github.com/apache/apisix/issues/4100#issuecomment-824099408 Sorry, I refer to this article to install Apisix. It seems that article is a bit old(https://www.jianshu.com/p/19607e0c7005) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1810: style(fe): how about changing the navigation bar to dark?
juzhiyuan commented on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824097209 @membphis @nic-chen Hi, we usually call it `Left Sidebar`. You could see this preview site: https://preview.pro.ant.design/dashboard/analysis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
