[apisix-java-plugin-runner] branch master created (now 0a1f075)

[spacewander]

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git.


  at 0a1f075  ci: fix .asf.yaml codestyle (#10)

No new revisions were added by this update.

[GitHub] [apisix] vincentwc edited a comment on issue #4307: request help: 创建一个路由的时候，是怎么走到apisix/admin/routes.lua的_M.put方法的啊？

[GitBox]

vincentwc edited a comment on issue #4307:
URL: https://github.com/apache/apisix/issues/4307#issuecomment-848482627


   > The interface of `/apisix/admin/*` is initialized in the 
`apisix/admin/init.lua` file. For details, please see: 
https://github.com/apache/apisix/blob/master/apisix/admin/init.lua
   
   i looked nginx.conf in /apisix/conf/nginx.conf , i don.t know how to use 
some settings
   such as 
   one :  env APISIX_PROFILE;  What is the function of this parameter
 I have find it in docs/zh/latest/profile.md,but how to set 
APISIX_PROFILE = prod?
   two:  show as my picture ,why the obj  apisix could call init.lua when 
function  _M.init_http is defined local _M ? 
   
![image](https://user-images.githubusercontent.com/31959888/119609231-da47b080-be29-11eb-8a6b-a96cc58cda60.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-java-plugin-runner] 01/01: ci: fix indent

[spacewander]

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch yamlfix
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git

commit 9415c2e803dd8ceaaca53b6c9dc3accf5b403537
Author: spacewander 
AuthorDate: Wed May 26 15:09:12 2021 +0800

ci: fix indent
---
 .asf.yaml | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/.asf.yaml b/.asf.yaml
index 5bf1058..ac966c2 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -26,14 +26,14 @@ github:
 squash:  true
 merge:   false
 rebase:  false
-features:
-  issues: true
-protected_branches:
-  main:
-required_status_checks:
-  strict: true
-  contexts:
-- CI
-required_pull_request_reviews:
-  dismiss_stale_reviews: true
-  required_approving_review_count: 1
+  features:
+issues: true
+  protected_branches:
+main:
+  required_status_checks:
+strict: true
+contexts:
+  - CI
+  required_pull_request_reviews:
+dismiss_stale_reviews: true
+required_approving_review_count: 1

[apisix-java-plugin-runner] branch yamlfix created (now 9415c2e)

[spacewander]

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a change to branch yamlfix
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git.


  at 9415c2e  ci: fix indent

This branch includes the following new commits:

 new 9415c2e  ci: fix indent

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[GitHub] [apisix-java-plugin-runner] spacewander opened a new pull request #12: ci: fix indent

[GitBox]

spacewander opened a new pull request #12:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/12


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] spacewander merged pull request #12: ci: fix indent

[GitBox]

spacewander merged pull request #12:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/12


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-java-plugin-runner] branch main updated: ci: fix indent (#12)

[spacewander]

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git


The following commit(s) were added to refs/heads/main by this push:
 new bb08c5d  ci: fix indent (#12)
bb08c5d is described below

commit bb08c5d35e636990fd9f62552b796f0ce4f8c6ed
Author: 罗泽轩 
AuthorDate: Wed May 26 15:14:24 2021 +0800

ci: fix indent (#12)
---
 .asf.yaml | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/.asf.yaml b/.asf.yaml
index 5bf1058..ac966c2 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -26,14 +26,14 @@ github:
 squash:  true
 merge:   false
 rebase:  false
-features:
-  issues: true
-protected_branches:
-  main:
-required_status_checks:
-  strict: true
-  contexts:
-- CI
-required_pull_request_reviews:
-  dismiss_stale_reviews: true
-  required_approving_review_count: 1
+  features:
+issues: true
+  protected_branches:
+main:
+  required_status_checks:
+strict: true
+contexts:
+  - CI
+  required_pull_request_reviews:
+dismiss_stale_reviews: true
+required_approving_review_count: 1

[GitHub] [apisix] oldthreefeng opened a new issue #4310: apisix docs dont have an upgrade example from older version to latest.

[GitBox]

oldthreefeng opened a new issue #4310:
URL: https://github.com/apache/apisix/issues/4310


   # Improve Docs
   just like jumpserver or others project. when the latest version is publish. 
   
   you guys should maintance an upgrade  example . Just like
   
   - apisix 2.5 to apisix 2.6
   - apisix 2.4 to apisix 2.6
   - apisix 2.3 to apisix 2.6
   - apisix 2.2 to apisix 2.6
   - apisix 1.5 to apisix 2.6 (since etcd v2 change to v3 , this is not 
recomand to upgrade.)
   
   and so on. 
   ## Please describe which part of docs should be improved or typo fixed
   
   A clear and concise description of what you want and what your use case is.
   
   ## Describe the solution you'd like
   
   A clear and concise description of what you want to happen.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] spacewander opened a new pull request #13: ci: fix indent

[GitBox]

spacewander opened a new pull request #13:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/13


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on issue #4307: request help: 创建一个路由的时候，是怎么走到apisix/admin/routes.lua的_M.put方法的啊？

[GitBox]

Firstsawyou commented on issue #4307:
URL: https://github.com/apache/apisix/issues/4307#issuecomment-848529402


   > one : env APISIX_PROFILE; What is the function of this parameter
   
   Please see here: 
https://github.com/apache/apisix/blob/master/docs/en/latest/profile.md
   
   > show as my picture ,why the obj apisix could call init.lua when function 
_M.init_http is defined local _M ?
   
   Corresponding files will be loaded from the path defined by 
`lua_package_path` (for example: apisix/init.lua, apisix.lua), you can 
understand the use of lua_package_path, you will be clear.
   
   
https://github.com/apache/apisix/blob/f7c6f4fff765116898d48de0e07eb3728f36ee0d/apisix/cli/ngx_tpl.lua#L60-L61


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-java-plugin-runner] branch master updated: ci: fix indent (#13)

[spacewander]

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git


The following commit(s) were added to refs/heads/master by this push:
 new a614be8  ci: fix indent (#13)
a614be8 is described below

commit a614be8e7910fac7b7dc6b5cf2ab10291ae9027c
Author: 罗泽轩 
AuthorDate: Wed May 26 15:21:20 2021 +0800

ci: fix indent (#13)
---
 .asf.yaml | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/.asf.yaml b/.asf.yaml
index 5bf1058..ac966c2 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -26,14 +26,14 @@ github:
 squash:  true
 merge:   false
 rebase:  false
-features:
-  issues: true
-protected_branches:
-  main:
-required_status_checks:
-  strict: true
-  contexts:
-- CI
-required_pull_request_reviews:
-  dismiss_stale_reviews: true
-  required_approving_review_count: 1
+  features:
+issues: true
+  protected_branches:
+main:
+  required_status_checks:
+strict: true
+contexts:
+  - CI
+  required_pull_request_reviews:
+dismiss_stale_reviews: true
+required_approving_review_count: 1

[GitHub] [apisix-java-plugin-runner] spacewander merged pull request #13: ci: fix indent

[GitBox]

spacewander merged pull request #13:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/13


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] vincentwc commented on issue #4307: request help: 创建一个路由的时候，是怎么走到apisix/admin/routes.lua的_M.put方法的啊？

[GitBox]

vincentwc commented on issue #4307:
URL: https://github.com/apache/apisix/issues/4307#issuecomment-848532519


   > > one : env APISIX_PROFILE; What is the function of this parameter
   > 
   > Please see here: 
https://github.com/apache/apisix/blob/master/docs/en/latest/profile.md
   > 
   > > show as my picture ,why the obj apisix could call init.lua when function 
_M.init_http is defined local _M ?
   > 
   > Corresponding files will be loaded from the path defined by 
`lua_package_path` (for example: apisix/init.lua, apisix.lua), you can 
understand the use of lua_package_path, you will be clear.
   > 
   > 
https://github.com/apache/apisix/blob/f7c6f4fff765116898d48de0e07eb3728f36ee0d/apisix/cli/ngx_tpl.lua#L60-L61
   
   thanks for your reply,  i had searched the file profile.md,but where i can 
set the APISIX_PROFILE value? or just used param in start apisix? hou to use 
,please give me a demo,thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] shuoshadow edited a comment on issue #495: request help: websocket reqeust return 415 code

[GitBox]

shuoshadow edited a comment on issue #495:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/495#issuecomment-848507043


   > @shuoshadow How did you send requests? Please give us a minimal 
reproducible case.
   
   frontend:
   
   const initSocket = () => {
   const socketURI = 
`${WEBSOCKET_URL_OBJ[props.namespace]}/api/v1/pod/exec/${props.namespace}/${props.podName}`
   
   socketRef.current = new WebSocket(socketURI)
   socketOnClose()
   socketOnOpen()
   socketOnError()
 }
   
 const socketOnClose = () => {
   socketRef.current.onclose = () => {
 socketRef.current.close()
 termRef.current.write('connet is closed!!!')
 console.log('close socket')
   }
 }
   
 const socketOnOpen = () => {
   socketRef.current.onopen = () => {
 initTerm()
   }
 }
   
   backend:
   
logger.Debug("in ExecPod")
if !ctx.IsWebsocket() {
ctx.JSON(http.StatusUnsupportedMediaType, 
hr.ErrResponse{hr.ErrorData{hr.ErrorCodePodExecError, "===not websocket 
request==="}})
return
}
   
   
![image](https://user-images.githubusercontent.com/10016360/119616001-ad4bcb80-be32-11eb-8dc3-2e2fab0819a5.png)
   =
   415 code was return by backend, !ctx.IsWebsocket() 
   func (c *Context) IsWebsocket() bool {
if strings.Contains(strings.ToLower(c.requestHeader("Connection")), 
"upgrade") &&
strings.EqualFold(c.requestHeader("Upgrade"), "websocket") {
return true
}
return false
   }
   =
   
   it works right by nginx-ingress


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] shuoshadow edited a comment on issue #495: request help: websocket reqeust return 415 code

[GitBox]

shuoshadow edited a comment on issue #495:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/495#issuecomment-848507043


   > @shuoshadow How did you send requests? Please give us a minimal 
reproducible case.
   
   frontend:
   ```javascript
   const initSocket = () => {
   const socketURI = 
`${WEBSOCKET_URL_OBJ[props.namespace]}/api/v1/pod/exec/${props.namespace}/${props.podName}`
   
   socketRef.current = new WebSocket(socketURI)
   socketOnClose()
   socketOnOpen()
   socketOnError()
 }
   
 const socketOnClose = () => {
   socketRef.current.onclose = () => {
 socketRef.current.close()
 termRef.current.write('connet is closed!!!')
 console.log('close socket')
   }
 }
   
 const socketOnOpen = () => {
   socketRef.current.onopen = () => {
 initTerm()
   }
 }
   ```
   
   backend:
   
logger.Debug("in ExecPod")
if !ctx.IsWebsocket() {
ctx.JSON(http.StatusUnsupportedMediaType, 
hr.ErrResponse{hr.ErrorData{hr.ErrorCodePodExecError, "===not websocket 
request==="}})
return
}
   
   
![image](https://user-images.githubusercontent.com/10016360/119616001-ad4bcb80-be32-11eb-8dc3-2e2fab0819a5.png)
   
   415 code was return by backend, !ctx.IsWebsocket() 
   ```golang
   func (c *Context) IsWebsocket() bool {
if strings.Contains(strings.ToLower(c.requestHeader("Connection")), 
"upgrade") &&
strings.EqualFold(c.requestHeader("Upgrade"), "websocket") {
return true
}
return false
   }
   ```
   
   it works right by nginx-ingress


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] shuoshadow edited a comment on issue #495: request help: websocket reqeust return 415 code

[GitBox]

shuoshadow edited a comment on issue #495:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/495#issuecomment-848507043


   > @shuoshadow How did you send requests? Please give us a minimal 
reproducible case.
   
   frontend:
   ```javascript
   const initSocket = () => {
   const socketURI = 
`${WEBSOCKET_URL_OBJ[props.namespace]}/api/v1/pod/exec/${props.namespace}/${props.podName}`
   
   socketRef.current = new WebSocket(socketURI)
   socketOnClose()
   socketOnOpen()
   socketOnError()
 }
   
 const socketOnClose = () => {
   socketRef.current.onclose = () => {
 socketRef.current.close()
 termRef.current.write('connet is closed!!!')
 console.log('close socket')
   }
 }
   
 const socketOnOpen = () => {
   socketRef.current.onopen = () => {
 initTerm()
   }
 }
   ```
   
   backend:
   ```golang
logger.Debug("in ExecPod")
if !ctx.IsWebsocket() {
ctx.JSON(http.StatusUnsupportedMediaType, 
hr.ErrResponse{hr.ErrorData{hr.ErrorCodePodExecError, "===not websocket 
request==="}})
return
}
   ```
   
![image](https://user-images.githubusercontent.com/10016360/119616001-ad4bcb80-be32-11eb-8dc3-2e2fab0819a5.png)
   
   415 code was return by backend, !ctx.IsWebsocket() 
   ```golang
   func (c *Context) IsWebsocket() bool {
if strings.Contains(strings.ToLower(c.requestHeader("Connection")), 
"upgrade") &&
strings.EqualFold(c.requestHeader("Upgrade"), "websocket") {
return true
}
return false
   }
   ```
   
   it works right by nginx-ingress


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] shuoshadow edited a comment on issue #495: request help: websocket reqeust return 415 code

[GitBox]

shuoshadow edited a comment on issue #495:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/495#issuecomment-848507043


   > @shuoshadow How did you send requests? Please give us a minimal 
reproducible case.
   
   frontend:
   
   const initSocket = () => {
   const socketURI = 
`${WEBSOCKET_URL_OBJ[props.namespace]}/api/v1/pod/exec/${props.namespace}/${props.podName}`
   
   socketRef.current = new WebSocket(socketURI)
   socketOnClose()
   socketOnOpen()
   socketOnError()
 }
   
 const socketOnClose = () => {
   socketRef.current.onclose = () => {
 socketRef.current.close()
 termRef.current.write('connet is closed!!!')
 console.log('close socket')
   }
 }
   
 const socketOnOpen = () => {
   socketRef.current.onopen = () => {
 initTerm()
   }
 }
   
   backend:
   
logger.Debug("in ExecPod")
if !ctx.IsWebsocket() {
ctx.JSON(http.StatusUnsupportedMediaType, 
hr.ErrResponse{hr.ErrorData{hr.ErrorCodePodExecError, "===not websocket 
request==="}})
return
}
   
   
![image](https://user-images.githubusercontent.com/10016360/119616001-ad4bcb80-be32-11eb-8dc3-2e2fab0819a5.png)
   
   415 code was return by backend, !ctx.IsWebsocket() 
   ```golang
   func (c *Context) IsWebsocket() bool {
if strings.Contains(strings.ToLower(c.requestHeader("Connection")), 
"upgrade") &&
strings.EqualFold(c.requestHeader("Upgrade"), "websocket") {
return true
}
return false
   }
   ```
   
   it works right by nginx-ingress


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Firstsawyou commented on pull request #1799: fix regex & omit vars when no value

[GitBox]

Firstsawyou commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848544147


   cc @juzhiyuan   The conflict needs to be resolved.
   Some users have repeatedly reported the bug of `regex`, we should fix it as 
soon as possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1799: fix regex & omit vars when no value

[GitBox]

iamayushdas commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848547900


   I think i should be looking into this, as he is kinda busy i guess 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Jaycean commented on issue #4157: bug: After installing the Apisix on ARM-based System,but it can't works properly.

[GitBox]

Jaycean commented on issue #4157:
URL: https://github.com/apache/apisix/issues/4157#issuecomment-848559769


   > > @Molio-tan
   > > I used kylin V10 arm64 and encountered the same problem.
   > > ```
   > > [C]: in function 'require'
   > >  /usr/local/apisix/apisix/init.lua:95: in function 'http_init_worker'
   > >  init_worker_by_lua:2: in main chunk
   > > 2021/05/14 10:33:35 [error] 111#111: init_worker_by_lua error: 
/usr/local/apisix/apisix/init.lua:95: module 'resty.worker.events' not found:
   > >  no field package.preload['resty.worker.events']
   > >  no file '/usr/local/apisix//deps/share/lua/5.1/resty/worker/events.lua'
   > >  no file 
'/usr/local/apisix//deps/share/lua/5.1/resty/worker/events/init.lua'
   > >  no file '/usr/local/apisix/resty/worker/events.lua'
   > >  no file '/usr/local/apisix/resty/worker/events/init.lua'
   > >  no file '/usr/local/openresty/site/lualib/resty/worker/events.ljbc'
   > >  no file '/usr/local/openresty/site/lualib/resty/worker/events/init.ljbc'
   > >  no file '/usr/local/openresty/lualib/resty/worker/events.ljbc'
   > >  no file '/usr/local/openresty/lualib/resty/worker/events/init.ljbc'
   > >  no file '/usr/local/openresty/site/lualib/resty/worker/events.lua'
   > >  no file '/usr/local/openresty/site/lualib/resty/worker/events/init.lua'
   > >  no file '/usr/local/openresty/lualib/resty/worker/events.lua'
   > >  no file '/usr/local/openresty/lualib/resty/worker/events/init.lua'
   > >  no file './resty/worker/events.lua'
   > >  no file 
'/usr/local/openresty/luajit/share/luajit-2.1.0-beta3/resty/worker/events.lua'
   > >  no file '/usr/local/share/lua/5.1/resty/worker/events.lua'
   > >  no file '/usr/local/share/lua/5.1/resty/worker/events/init.lua'
   > >  no file 
'/usr/local/openresty/luajit/share/lua/5.1/resty/worker/events.lua'
   > >  no file 
'/usr/local/openresty/luajit/share/lua/5.1/resty/worker/events/init.lua'
   > >  no file './resty/worker/events.lua'
   > >  no file 
'/usr/local/openresty/luajit/share/luajit-2.1.0-beta3/resty/worker/events.lua'
   > >  no file '/usr/local/share/lua/5.1/resty/worker/events.lua'
   > >  no file '/usr/local/share/lua/5.1/resty/worker/events/init.lua'
   > >  no file 
'/usr/local/openresty/luajit/share/lua/5.1/resty/worker/events.lua'
   > >  no file 
'/usr/local/openresty/luajit/share/lua/5.1/resty/worker/events/init.lua'
   > >  no file '/usr/local/apisix//deps/lib64/lua/5.1/resty/worker/events.so'
   > >  no file '/usr/local/apisix//deps/lib/lua/5.1/resty/worker/events.so'
   > >  no file '/usr/local/openresty/site/lualib/resty/worker/events.so'
   > >  no file '/usr/local/openresty/lualib/resty/worker/events.so'
   > >  no file './resty/worker/events.so'
   > >  no file '/usr/local/lib/lua/5.1/resty/worker/events.so'
   > >  no file '/usr/local/openresty/luajit/lib/lua/5.1/resty/worker/events.so'
   > >  no file '/usr/local/lib/lua/5.1/loadall.so'
   > >  no file './resty/worker/events.so'
   > >  no file '/usr/local/lib/lua/5.1/resty/worker/events.so'
   > >  no file '/usr/local/openresty/luajit/lib/lua/5.1/resty/worker/events.so'
   > >  no file '/usr/local/lib/lua/5.1/loadall.so'
   > >  no file '/usr/local/apisix//deps/lib64/lua/5.1/resty.so'
   > >  no file '/usr/local/apisix//deps/lib/lua/5.1/resty.so'
   > >  no file '/usr/local/openresty/site/lualib/resty.so'
   > >  no file '/usr/local/openresty/lualib/resty.so'
   > >  no file './resty.so'
   > >  no file '/usr/local/lib/lua/5.1/resty.so'
   > >  no file '/usr/local/openresty/luajit/lib/lua/5.1/resty.so'
   > >  no file '/usr/local/lib/lua/5.1/loadall.so'
   > >  no file './resty.so'
   > >  no file '/usr/local/lib/lua/5.1/resty.so'
   > >  no file '/usr/local/openresty/luajit/lib/lua/5.1/resty.so'
   > >  no file '/usr/local/lib/lua/5.1/loadall.so'
   > > ```
   > > 
   > > 
   > > 
   > >   
   > > 
   > > 
   > >   
   > > 
   > > 
   > > 
   > >   
   > > Moreover, I tried to compile in the centos7 arm64 container, but when I 
created a route and tried to connect, the same error occurred. CentOS\ Alpine 
\kylin V10 could not, the same error
   > > Is it possible that the path is wrong? I found that there are more "/" 
'/usr/local/apisix//'
   > > ```
   > > no file '/usr/local/apisix//deps/share/lua/5.1/resty/worker/events.lua'
   > > no file 
'/usr/local/apisix//deps/share/lua/5.1/resty/worker/events/init.lua'
   > > ```
   > > 
   > > 
   > > 
   > >   
   > > 
   > > 
   > >   
   > > 
   > > 
   > > 
   > >   
   > > cc @tokers @membphis @imjoey PTAL,
   > > I tried a lot of methods and encountered the same problem. Apisix(v2.4) 
can run, and dashboard(v2.5) can run and login.
   > > However, the created route cannot be accessed because apisix does not 
work properly.
   > 
   > @Jaycean I'm sorry for replying for you on time.By the way, have you 
solved the problem?
   > @imjoey Is there any good news for the problem?
   
   It hasn't been solved yet.


-- 
This is an automated messag

[GitHub] [apisix-ingress-controller] tokers commented on pull request #453: fix: panic of start leading. sync ingress failed when apisix not start.

[GitBox]

tokers commented on pull request #453:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/453#issuecomment-848561231


   I have merged your branch with the latest master branch, now LGTM to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers closed pull request #453: fix: panic of start leading. sync ingress failed when apisix not start.

[GitBox]

tokers closed pull request #453:
URL: https://github.com/apache/apisix-ingress-controller/pull/453


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] dmsolr commented on pull request #11: build: refactor package

[GitBox]

dmsolr commented on pull request #11:
URL: 
https://github.com/apache/apisix-java-plugin-runner/pull/11#issuecomment-848567576


   Hi @tzssangglass  It is ready to review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander opened a new pull request #4311: chore(ext-plugin): remove useless `extra_info` field

[GitBox]

spacewander opened a new pull request #4311:
URL: https://github.com/apache/apisix/pull/4311


   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #499: chore: add health check to apisix-admin and make the leader election recyclable

[GitBox]

tokers opened a new pull request #499:
URL: https://github.com/apache/apisix-ingress-controller/pull/499


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   ___
   ### Backport patches
   - Why need to backport?
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers merged pull request #499: chore: add health check to apisix-admin and make the leader election recyclable

[GitBox]

tokers merged pull request #499:
URL: https://github.com/apache/apisix-ingress-controller/pull/499


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-ingress-controller] branch master updated: chore: add health check to apisix-admin and make the leader election recyclable (#499)

[tokers]

This is an automated email from the ASF dual-hosted git repository.

tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git


The following commit(s) were added to refs/heads/master by this push:
 new 582c4b3  chore: add health check to apisix-admin and make the leader 
election recyclable (#499)
582c4b3 is described below

commit 582c4b362f26ffa8372bf520c3f774170a56c290
Author: Alex Zhang 
AuthorDate: Wed May 26 16:39:58 2021 +0800

chore: add health check to apisix-admin and make the leader election 
recyclable (#499)

Co-authored-by: Liu Peng 
---
 pkg/apisix/apisix.go  |   6 +-
 pkg/apisix/cluster.go | 122 -
 pkg/apisix/nonexistentclient.go   |   4 +
 pkg/ingress/apisix_cluster_config.go  |   3 +-
 pkg/ingress/apisix_route.go   |   3 +-
 pkg/ingress/apisix_tls.go |   3 +-
 pkg/ingress/apisix_upstream.go|   3 +-
 pkg/ingress/controller.go | 151 +-
 pkg/ingress/endpoint.go   |   2 +-
 pkg/ingress/ingress.go|   2 +-
 pkg/ingress/secret.go |   2 +-
 pkg/kube/apisix/apis/config/v2alpha1/types.go |   4 +
 pkg/kube/init.go  |  29 +++--
 13 files changed, 235 insertions(+), 99 deletions(-)

diff --git a/pkg/apisix/apisix.go b/pkg/apisix/apisix.go
index ffcb405..4200e0a 100644
--- a/pkg/apisix/apisix.go
+++ b/pkg/apisix/apisix.go
@@ -50,6 +50,8 @@ type Cluster interface {
String() string
// HasSynced checks whether all resources in APISIX cluster is synced 
to cache.
HasSynced(context.Context) error
+   // HealthCheck checks apisix cluster health in realtime.
+   HealthCheck(context.Context) error
 }
 
 // Route is the specific client interface to take over the create, update,
@@ -122,6 +124,7 @@ type apisix struct {
 func NewClient() (APISIX, error) {
cli := &apisix{
nonExistentCluster: newNonExistentCluster(),
+   clusters:   make(map[string]Cluster),
}
return cli, nil
 }
@@ -160,9 +163,6 @@ func (c *apisix) AddCluster(co *ClusterOptions) error {
if err != nil {
return err
}
-   if c.clusters == nil {
-   c.clusters = make(map[string]Cluster)
-   }
c.clusters[co.Name] = cluster
return nil
 }
diff --git a/pkg/apisix/cluster.go b/pkg/apisix/cluster.go
index d41e5dd..4d42d1e 100644
--- a/pkg/apisix/cluster.go
+++ b/pkg/apisix/cluster.go
@@ -21,7 +21,9 @@ import (
"fmt"
"io"
"io/ioutil"
+   "net"
"net/http"
+   "net/url"
"strings"
"sync/atomic"
"time"
@@ -37,8 +39,7 @@ import (
 const (
_defaultTimeout = 5 * time.Second
 
-   _cacheNotSync = iota
-   _cacheSyncing
+   _cacheSyncing = iota
_cacheSynced
 )
 
@@ -50,6 +51,19 @@ var (
ErrDuplicatedCluster = errors.New("duplicated cluster")
 
_errReadOnClosedResBody = errors.New("http: read on closed response 
body")
+
+   // Default shared transport for apisix client
+   _defaultTransport = &http.Transport{
+   Proxy: http.ProxyFromEnvironment,
+   Dial: (&net.Dialer{
+   Timeout: 3 * time.Second,
+   }).Dial,
+   DialContext: (&net.Dialer{
+   Timeout: 3 * time.Second,
+   }).DialContext,
+   ResponseHeaderTimeout: 30 * time.Second,
+   ExpectContinueTimeout: 1 * time.Second,
+   }
 )
 
 // ClusterOptions contains parameters to customize APISIX client.
@@ -63,6 +77,7 @@ type ClusterOptions struct {
 type cluster struct {
name string
baseURL  string
+   baseURLHost  string
adminKey string
cli  *http.Client
cacheState   int32
@@ -86,19 +101,21 @@ func newCluster(o *ClusterOptions) (Cluster, error) {
}
o.BaseURL = strings.TrimSuffix(o.BaseURL, "/")
 
+   u, err := url.Parse(o.BaseURL)
+   if err != nil {
+   return nil, err
+   }
+
c := &cluster{
-   name: o.Name,
-   baseURL:  o.BaseURL,
-   adminKey: o.AdminKey,
+   name:o.Name,
+   baseURL: o.BaseURL,
+   baseURLHost: u.Host,
+   adminKey:o.AdminKey,
cli: &http.Client{
-   Timeout: o.Timeout,
-   Transport: &http.Transport{
-   ResponseHeaderTimeout: o.Timeout,
-   ExpectContinueTimeout: o.Timeout,
-   },
+   Timeout:   o.Timeout,
+   Transport: _defaultTransport,
}

[GitHub] [apisix-ingress-controller] tokers commented on pull request #453: fix: panic of start leading. sync ingress failed when apisix not start.

[GitBox]

tokers commented on pull request #453:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/453#issuecomment-848584906


   https://github.com/apache/apisix-ingress-controller/pull/499 See this @slene 
, Corrupted this branch by accident 😂, but don't worry you are still the 
contributor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1799: fix regex & omit vars when no value

[GitBox]

juzhiyuan commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848588118


   > cc @juzhiyuan The conflict needs to be resolved.
   > Some users have repeatedly reported the bug of `regex`, we should fix it 
as soon as possible.
   
   ok, will fix today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] xdshivani commented on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

xdshivani commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848591280


   1. I am new to open source and I don't know why I am receiving these errors.
   2. I tried to find the broken links in local repo but, could not find it.
   3. The only faulty link I got was of kubernetes link and I fixed it in this 
PR @Yiyiyimu  @iamayushdas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1799: fix regex & omit vars when no value

[GitBox]

iamayushdas commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848600120


   > > cc @juzhiyuan The conflict needs to be resolved.
   > > Some users have repeatedly reported the bug of `regex`, we should fix it 
as soon as possible.
   > 
   > ok, will fix today.
   
   okay sir
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] shuoshadow commented on issue #495: request help: websocket reqeust failed

[GitBox]

shuoshadow commented on issue #495:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/495#issuecomment-848604466


apisix pod logs
   ```shell
   2021/05/26 09:06:29 [error] 43#43: *11 [lua] config_etcd.lua:550: failed to 
fetch data from etcd: failed to check item data of [/apisix/routes] err:failed 
to validate the 'vars' expression: rule too short,  etcd key: /apisix/routes, 
context: ngx.timer
   2021/05/26 09:06:29 [error] 47#47: *97 [lua] config_etcd.lua:550: failed to 
fetch data from etcd: failed to check item data of [/apisix/routes] err:failed 
to validate the 'vars' expression: rule too short,  etcd key: /apisix/routes, 
context: ngx.timer
   2021/05/26 09:06:29 [error] 41#41: *45 [lua] config_etcd.lua:550: failed to 
fetch data from etcd: failed to check item data of [/apisix/routes] err:failed 
to validate the 'vars' expression: rule too short,  etcd key: /apisix/routes, 
context: ngx.timer
   2021/05/26 09:06:29 [error] 44#44: *76 [lua] config_etcd.lua:550: failed to 
fetch data from etcd: failed to check item data of [/apisix/routes] err:failed 
to validate the 'vars' expression: rule too short,  etcd key: /apisix/routes, 
context: ngx.timer
   2021/05/26 09:06:29 [error] 42#42: *32 [lua] config_etcd.lua:550: failed to 
fetch data from etcd: failed to check item data of [/apisix/routes] err:failed 
to validate the 'vars' expression: rule too short,  etcd key: /apisix/routes, 
context: ngx.timer
   ```
   
   when i set websocket true by dashboard


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1799: fix regex & omit vars when no value

[GitBox]

iamayushdas edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848600120


   > > cc @juzhiyuan The conflict needs to be resolved.
   > > Some users have repeatedly reported the bug of `regex`, we should fix it 
as soon as possible.
   > 
   > ok, will fix today.
   
   can i fix this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1799: fix regex & omit vars when no value

[GitBox]

iamayushdas edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848600120


   > > cc @juzhiyuan The conflict needs to be resolved.
   > > Some users have repeatedly reported the bug of `regex`, we should fix it 
as soon as possible.
   > 
   > ok, will fix today.
   
   can i fix this? as you have to change the test files again because of that 
refactoring


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #495: request help: websocket reqeust failed

[GitBox]

tokers commented on issue #495:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/495#issuecomment-848608947


   What are your apisix-ingress-controller and apisix version?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] shuoshadow commented on issue #495: request help: websocket reqeust failed

[GitBox]

shuoshadow commented on issue #495:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/495#issuecomment-848615603


   > What are your apisix-ingress-controller and apisix version?
   
   ```shell
   bash-5.0# /usr/bin/apisix version
   /usr/local/openresty/luajit/bin/luajit ./apisix/cli/apisix.lua version
   2.5
   ```
   
   ```shell
   /ingress-apisix # ./apisix-ingress-controller --version
   apisix-ingress-controller version 0.5.0--go1.13.8
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] shuoshadow edited a comment on issue #495: request help: websocket reqeust failed

[GitBox]

shuoshadow edited a comment on issue #495:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/495#issuecomment-848615603


   > What are your apisix-ingress-controller and apisix version?
   
   ```shell
   bash-5.0# /usr/bin/apisix version
   /usr/local/openresty/luajit/bin/luajit ./apisix/cli/apisix.lua version
   2.5
   ```
   
   ```shell
   /ingress-apisix # ./apisix-ingress-controller --version
   apisix-ingress-controller version 0.5.0--go1.13.8
   ```
   
   apisix image: apache/apisix:2.5-alpine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] shuoshadow edited a comment on issue #495: request help: websocket reqeust failed

[GitBox]

shuoshadow edited a comment on issue #495:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/495#issuecomment-848615603


   > What are your apisix-ingress-controller and apisix version?
   
   ```shell
   bash-5.0# /usr/bin/apisix version
   /usr/local/openresty/luajit/bin/luajit ./apisix/cli/apisix.lua version
   2.5
   ```
   
   ```shell
   /ingress-apisix # ./apisix-ingress-controller --version
   apisix-ingress-controller version 0.5.0--go1.13.8
   ```
   
   ```shell
   apisix image: apache/apisix:2.5-alpine
   apisix-ingress-controller image: apache/apisix-ingress-controller:0.5.0
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] gxthrj merged pull request #176: fix: add 'forward error to log' for local build

[GitBox]

gxthrj merged pull request #176:
URL: https://github.com/apache/apisix-docker/pull/176


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-docker] branch master updated: fix: add forward error to log for local build (#176)

[kvn]

This is an automated email from the ASF dual-hosted git repository.

kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-docker.git


The following commit(s) were added to refs/heads/master by this push:
 new d397aca  fix: add forward error to log for local build (#176)
d397aca is described below

commit d397acaf06d585796e26e972e447764a8c286fef
Author: Shuyang Wu 
AuthorDate: Wed May 26 05:38:57 2021 -0400

fix: add forward error to log for local build (#176)

Signed-off-by: yiyiyimu 
---
 README.md   | 7 ++-
 alpine-dev/Dockerfile   | 4 
 alpine-local/Dockerfile | 5 +
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index 2044311..9e23c6c 100644
--- a/README.md
+++ b/README.md
@@ -31,11 +31,8 @@ $ make build-on-centos
 3. Build from local code:
 ```sh
 # To copy apisix into image, we need to include it in build context
-$ cd 
-
-# alpine
-
-$ APISIX_PATH=/path/to/apisix make build-on-alpine-local
+$ cp -r  ./apisix
+$ APISIX_PATH=./apisix make build-on-alpine-local
 
 # Might need root privilege if encounter "error checking context: 'can't stat'"
 ```
diff --git a/alpine-dev/Dockerfile b/alpine-dev/Dockerfile
index 0054eeb..650ee71 100644
--- a/alpine-dev/Dockerfile
+++ b/alpine-dev/Dockerfile
@@ -34,6 +34,10 @@ COPY --from=production-stage /usr/local/openresty/ 
/usr/local/openresty/
 COPY --from=production-stage /usr/local/apisix/ /usr/local/apisix/
 COPY --from=production-stage /usr/bin/apisix /usr/bin/apisix
 
+# forward request and error logs to docker log collector
+RUN ln -sf /dev/stdout /usr/local/apisix/logs/access.log \
+&& ln -sf /dev/stderr /usr/local/apisix/logs/error.log
+
 ENV 
PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/usr/local/openresty/bin
 
 EXPOSE 9080 9443
diff --git a/alpine-local/Dockerfile b/alpine-local/Dockerfile
index e0f5e56..2001186 100644
--- a/alpine-local/Dockerfile
+++ b/alpine-local/Dockerfile
@@ -34,6 +34,11 @@ COPY --from=production-stage /usr/local/openresty/ 
/usr/local/openresty/
 COPY --from=production-stage /usr/local/apisix/ /usr/local/apisix/
 COPY --from=production-stage /usr/bin/apisix /usr/bin/apisix
 
+# forward request and error logs to docker log collector
+RUN mkdir -p logs && touch logs/access.log && touch logs/error.log \
+&& ln -sf /dev/stdout /usr/local/apisix/logs/access.log \
+&& ln -sf /dev/stderr /usr/local/apisix/logs/error.log
+
 ENV 
PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/usr/local/openresty/bin
 
 EXPOSE 9080 9443

[GitHub] [apisix-docker] gxthrj commented on issue #177: dashboard image on docker hub have wrong tag

[GitBox]

gxthrj commented on issue #177:
URL: https://github.com/apache/apisix-docker/issues/177#issuecomment-848629747


   Let me HAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas removed a comment on pull request #1799: fix regex & omit vars when no value

[GitBox]

iamayushdas removed a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848600120


   > > cc @juzhiyuan The conflict needs to be resolved.
   > > Some users have repeatedly reported the bug of `regex`, we should fix it 
as soon as possible.
   > 
   > ok, will fix today.
   
   can i fix this? as you have to change the test files again because of that 
refactoring


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] sandy420 opened a new issue #4312: bug: 启用proxy-mirror后正常的请求报404

[GitBox]

sandy420 opened a new issue #4312:
URL: https://github.com/apache/apisix/issues/4312


   ### Issue description
   
   ### Environment
   
   Bug report without environment information will be ignored or closed.
   
   * apisix version (cmd: `apisix version`):2.5
   * OS (cmd: `uname -a`):centos 7.3
   * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): 
openresty/1.19.3.1
   * etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info 
API):3.4.14
   * apisix-dashboard version, if have: 2.6
   * luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   
   ### Minimal test code / Steps to reproduce the issue
   
   Bug report without steps to reproduce will be ignored or closed.
   
   1.在配置路由时启用了proxy-mirror后,无法请求报404
   路由配置的json如下:
   {
   "action": "get",
   "node": {
   "key": "/apisix/routes/356497226769367867",
   "value": {
   "upstream_id": "355766670582612795",
   "id": "356497226769367867",
   "methods": [
   "GET",
   "POST",
   "PUT",
   "DELETE",
   "PATCH",
   "HEAD",
   "OPTIONS",
   "CONNECT",
   "TRACE"
   ],
   "plugins": {
   "proxy-rewrite": {
   "host": "abc.test.com"
   },
   "proxy-mirror": {
   "host": "http://10.10.1.1:8081";
   }
   },
   "hosts": [
   "test.test.com"
   ],
   "status": 1,
   "create_time": 1622018505,
   "update_time": 1622020347,
   "name": "carpool-operation",
   "uris": [
   "/test*"
   ]
   }
   },
   "count": "1"
   }
   
   
   请求http://abc.test.com/test  返回404
   ### What's the expected result?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1921: fix: regex & omit vars when no value

[GitBox]

iamayushdas opened a new pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921


   Please answer these questions before submitting a pull request, **or your PR 
will get closed**.
   
   **Why submit this pull request?**
   
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   - [x] update Regex according to schema_def
   - [x] omit vars field in Route when no value contained
   Please update this section with detailed description.
   
   **Related issues**
   
   fix/resolve #1798 
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   - [x] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, 
please discuss on the mailing list first
   
   cc - @juzhiyuan @liuxiran @starsz @LiteSun 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1921: fix: regex & omit vars when no value

[GitBox]

netlify[bot] commented on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539


   :construction_worker: Deploy Preview for *apisix-dashboard* processing.
   
   
   :hammer: Explore the source changes: b681f4e59e8233c132b596812fb679de4651af92
   
   :mag: Inspect the deploy log: 
[https://app.netlify.com/sites/apisix-dashboard/deploys/60ae1beee4aaf1000877e8d9](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae1beee4aaf1000877e8d9?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] gxthrj commented on issue #177: dashboard image on docker hub have wrong tag

[GitBox]

gxthrj commented on issue #177:
URL: https://github.com/apache/apisix-docker/issues/177#issuecomment-848641067


   There are some error in build rules, I have fixed.
   
   
![image](https://user-images.githubusercontent.com/4413028/119641772-94e8aa80-be4c-11eb-8e77-a9661267b03e.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] gxthrj closed issue #177: dashboard image on docker hub have wrong tag

[GitBox]

gxthrj closed issue #177:
URL: https://github.com/apache/apisix-docker/issues/177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] gxthrj commented on issue #177: dashboard image on docker hub have wrong tag

[GitBox]

gxthrj commented on issue #177:
URL: https://github.com/apache/apisix-docker/issues/177#issuecomment-848645186


   Make `dev` tag auto-build. But `latest` will push by CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value

[GitBox]

netlify[bot] edited a comment on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539


   :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
   
   
   :hammer: Explore the source changes: b681f4e59e8233c132b596812fb679de4651af92
   
   :mag: Inspect the deploy log: 
[https://app.netlify.com/sites/apisix-dashboard/deploys/60ae1beee4aaf1000877e8d9](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae1beee4aaf1000877e8d9?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: 
[https://deploy-preview-1921--apisix-dashboard.netlify.app/](https://deploy-preview-1921--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #474: feat: apisixconsumer translator

[GitBox]

gxthrj commented on pull request #474:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/474#issuecomment-848646182


   @tokers Should merge master, for e2e test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #496: CI: support the timer CI to verify the stability of the ingress controller

[GitBox]

gxthrj commented on issue #496:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/496#issuecomment-848648836


   May add this in Jun.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on issue #4312: bug: 启用proxy-mirror后正常的请求报404

[GitBox]

Firstsawyou commented on issue #4312:
URL: https://github.com/apache/apisix/issues/4312#issuecomment-848657357


   Okay, let me check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #494: test: remove custom apisix-default.yaml

[GitBox]

codecov-commenter edited a comment on pull request #494:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/494#issuecomment-848428718


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#494](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (bbbeffb) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/582c4b362f26ffa8372bf520c3f774170a56c290?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (582c4b3) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head bbbeffb differs from pull request most recent 
head ca99d72. Consider uploading reports for the commit ca99d72 to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #494   +/-   ##
   ===
 Coverage   36.49%   36.49%   
   ===
 Files  50   50   
 Lines4091 4091   
   ===
 Hits 1493 1493   
 Misses   2400 2400   
 Partials  198  198   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[582c4b3...ca99d72](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #14: test: add test case about codec

[GitBox]

tzssangglass opened a new pull request #14:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/14


   1. add test cases about codec 
   2. fix bug about encode response body


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Demogorgon314 opened a new pull request #4313: feat: nacos discovery support namespace

[GitBox]

Demogorgon314 opened a new pull request #4313:
URL: https://github.com/apache/apisix/pull/4313


   ### What this PR does / why we need it:
   #4306
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [x] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #14: test: add test case about codec

[GitBox]

tzssangglass commented on pull request #14:
URL: 
https://github.com/apache/apisix-java-plugin-runner/pull/14#issuecomment-848693601


   @dmsolr @spacewander pls review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1916: Add route path search in dashboard

[GitBox]

nic-chen commented on issue #1916:
URL: 
https://github.com/apache/apisix-dashboard/issues/1916#issuecomment-848694856


   > @nic-chen Could you please give me an advise, if i update the code locally 
and want to replace the code for apisix-dashboard docker image, how can i do 
for this?
   > 
   > 
   > 
   > can i `make build` locally and replace the dictionary `html`?
   
   I think you should better build an new image


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] shuoshadow opened a new issue #500: request help: no kind is registered for the type v1.ApisixUpstream in scheme "pkg/runtime/scheme.go:100"

[GitBox]

shuoshadow opened a new issue #500:
URL: https://github.com/apache/apisix-ingress-controller/issues/500


   ### Issue description
   apisixUpstream:
   ```yaml
   apiVersion: apisix.apache.org/v1
   kind: ApisixUpstream
   metadata:
 name: kas-svc
 namespace: ops
   spec:
 timeout:
   connect: 1800s
   read: 1800s
   send: 1800s
   ```
   
   crd from v0.6.0
   ```yaml
   apiVersion: apiextensions.k8s.io/v1beta1kind: 
CustomResourceDefinitionmetadata:  name: apisixupstreams.apisix.apache.orgspec: 
 group: apisix.apache.org  versions:- name: v1  served: true  
storage: true  scope: Namespaced  names:plural: apisixupstreams
singular: apisixupstreamkind: ApisixUpstreamshortNames:  - au  
preserveUnknownFields: false  validation:openAPIV3Schema:  type: object 
 properties:spec:  type: object  properties:
loadbalancer:  type: object  properties:
type:  type: string  enum:  
  - roundrobin- chash- ewma 
   - least_connhashOn:  type: string
  enum:- vars- 
vars_combinations- header- cookie   
 - consumer   
  key:  type: string  required: 
   - typescheme:  type: string  enum:   
 - http- grpcretries:  
type: integer  minimum: 0timeout:  type: 
object  properties:connect:  type: 
stringread:  type: stringsend:  
type: stringhealthCheck:  type: object  
anyOf:- required:- active   
 - required:- active- passive   
   properties:active:  type: object 
 properties:type:  type: 
string  enum:- http 
   - https- tcp   
  timeout:  type: number  
minimum: 0concurrency:  type: integer   
   minimum: 1host:  
type: string  pattern: "^\\*?[0-9a-zA-Z-._]+$"  
  port:  type: integer  minimum: 1  
maximum: 65535httpPath: 
 type: string  minLength: 1
strictTLS:  type: boolean
requestHeaders:  type: array  minItems: 
1  items:type: string   
 healthy:  type: object  
properties:interval:  type: 
stringhttpCodes:  type: array   
   
 minItems: 1  items:
type: integerminimum: 200   
 maximum: 599successes: 
 type: integer  minimum: 1  
maximum: 254unhealthy:  type: object
  properties:interval:  
type: stringhttpCodes:  
type: array  minItems: 1  
items:type: integer
minimum: 200maximum: 599
httpFailures:  type: integer  
minimum: 1  maximum: 254
tcpFailures:  type: integer
   minimum: 1  maximum: 254 
   timeout:  type: stringpassive:   
   type: object  properties:
type:  type: string  enum:  
  - http- https- tcp
healthy:  type: object  
properties:httpCodes:  t

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #11: build: refactor package

[GitBox]

tzssangglass commented on a change in pull request #11:
URL: 
https://github.com/apache/apisix-java-plugin-runner/pull/11#discussion_r639646421



##
File path: runner-dist/src/main/bin/startup.sh
##
@@ -15,3 +15,15 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
+RUNNER_HOME=$(dirname "$0")/..
+
+RUNNER_HEAP=${JAVA_HEAP:-4g}
+
+JAVA_OPS="${JAVA_OPS} -Xmx${RUNNER_HEAP} -Xms${RUNNER_HEAP}"
+
+nohup java -jar ${JAVA_OPS} ${RUNNER_HOME}/apisxi-runner-start-*.jar \
+ 1>${RUNNER_HOME}/logs/runner.out \
+ 2>${RUNNER_HOME}/logs/runner.err &
+
+echo $! > ./logs/runner.pid

Review comment:
   It would be better to change the name of the `runner` to `java-runner`?
   because in the future there may be go language runners that also output logs 
in the `/logs` directory




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #501: Who is using APISIX ingress controller？（欢迎使用 APISIX ingress controller 的个人和公司在此留言）

[GitBox]

gxthrj opened a new issue #501:
URL: https://github.com/apache/apisix-ingress-controller/issues/501


   ## Who is using APISIX ingress controller?
   Sincerely thank everyone who constantly keeps on using and supporting APISIX 
ingress controller. We will try our best to make APISIX ingress controller 
better and make the community and ecology more prosperous.
   
   ## The original intention of this issue
   - We’d like to listen to the community to make APISIX ingress controller 
better.
   - We want to attract more partners to contribute to APISIX ingress 
controller.
   - Learn more about the practical use scenarios of APISIX ingress controller 
to facilitate the next step of planning.
   
   ## What we expect from you
   Please submit a comment in this issue to include the following information:
   
   your company, school or organization.
   your city and country.
   your contact info: blog, email, twitter (at least one).
   for what business scenario do you use APISIX ingress controller.
   
   You can refer to the following sample answer:
   ```
   * Organization: api7.ai
   * Location: ShenZhen, China
   * Contact: k...@apache.org
   * Purpose: As a API gateway control plane in Kubernetes to configure APISIX.
   ```
   Thanks again for your participation! Your support is the motivation for us 
to move forward.
   Apache APISIX community
   
   ## 谁在使用 APISIX ingress controller
   感谢正在使用和关注 APISIX ingress controller 的开发者，我们会持续投入，让 APISIX ingress controller 
项目和社区更加繁荣。
   
   ## 这个 issue 的出发点
   - 聆听社区的声音，让 APISIX ingress controller 解决实际的问题
   - 吸引更多的开发者参与和贡献
   - 更多的了解 APISIX ingress controller 的实际使用场景，以便后续版本的计划
   
   ## 我们期待您能提供
   在此提交一条评论, 评论内容包括:
   
   您所在公司、学校或组织
   您所在的城市、国家
   您的联系方式: 微博、邮箱、微信 (至少一个)
   您将 APISIX ingress controller 用于哪些业务场景
   
   可以参考下面的示例：
   ```
   组织：api7.ai
   地点：中国深圳
   联系方式： k...@apache.org
   使用场景：在 Kubernetes 集群中作为 API 网关控制平面来配置 APISIX 。
   ```
   
   多谢您的支持！
   Apache APISIX 社区


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on issue #1920: Error: .jsx: Unexpected token

[GitBox]

iamayushdas commented on issue #1920:
URL: 
https://github.com/apache/apisix-dashboard/issues/1920#issuecomment-848712758


   could you tell me steps after which you triggered with this error?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on issue #4307: request help: 创建一个路由的时候，是怎么走到apisix/admin/routes.lua的_M.put方法的啊？

[GitBox]

tzssangglass commented on issue #4307:
URL: https://github.com/apache/apisix/issues/4307#issuecomment-848722973


   this is a linux environment variable, there are many ways to set it, for 
example,
   
   ```shell
   export APISIX_PROFILE = prod
   ```
   and check it 
   
   ```shell
   echo $APISIX_PROFILE
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on issue #4157: bug: After installing the Apisix on ARM-based System,but it can't works properly.

[GitBox]

tzssangglass commented on issue #4157:
URL: https://github.com/apache/apisix/issues/4157#issuecomment-848724549


   I installed apisix on macOS M1 (arm64) successfully, but I don't have a 
kylin V10 arm64 system to verify this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas edited a comment on issue #1920: Error: .jsx: Unexpected token

[GitBox]

iamayushdas edited a comment on issue #1920:
URL: 
https://github.com/apache/apisix-dashboard/issues/1920#issuecomment-848712758


   could you tell me steps after which you triggered with this error?
   it builds and run on my machine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848779841


   @xdshivani 
   see here for some reference
   
![sinog2c.com](https://user-images.githubusercontent.com/40708551/119669897-0ed16180-be56-11eb-9a72-e3d8be4fa10a.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848780471


   > @xdshivani
   > see here for some reference
   > 
![sinog2c.com](https://user-images.githubusercontent.com/40708551/119669897-0ed16180-be56-11eb-9a72-e3d8be4fa10a.png)
   
   use this link instead: http://www.sinog2c.com/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #502: feat: add events and status for ApisixClusterConfig resource

[GitBox]

gxthrj opened a new pull request #502:
URL: https://github.com/apache/apisix-ingress-controller/pull/502


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   #455 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] iamayushdas edited a comment on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

iamayushdas edited a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848780471


   > @xdshivani
   > see here for some reference
   > 
![sinog2c.com](https://user-images.githubusercontent.com/40708551/119669897-0ed16180-be56-11eb-9a72-e3d8be4fa10a.png)
   
   use these links instead: 
   http://www.sinog2c.com/
   https://www.travelsky.com.cn/
   https://partners-intl.aliyun.com/help/doc-detail/142666.htm  for [Log server]
   https://partners-intl.aliyun.com/help/doc-detail/25485.htm for [serve list]
   https://www.alibabacloud.com/help/doc-detail/182218.htm [access services 
through SLB]
   
   hope it helps


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] iamayushdas edited a comment on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

iamayushdas edited a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848780471


   > @xdshivani
   > see here for some reference
   > 
![sinog2c.com](https://user-images.githubusercontent.com/40708551/119669897-0ed16180-be56-11eb-9a72-e3d8be4fa10a.png)
   
   use these links instead: 
   http://www.sinog2c.com/
   https://www.travelsky.com.cn/
   https://partners-intl.aliyun.com/help/doc-detail/142666.htm  for [Log server]
   https://partners-intl.aliyun.com/help/doc-detail/25485.htm for [serve list]
   https://www.alibabacloud.com/help/doc-detail/182218.htm [access services 
through SLB]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1907: feat: Use monaco editor

[GitBox]

netlify[bot] edited a comment on pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#issuecomment-845072931


   :construction_worker: Deploy Preview for *apisix-dashboard* processing.
   
   
   :hammer: Explore the source changes: 17dbe3e1faa6cb3104fe7486519139ace6069c67
   
   :mag: Inspect the deploy log: 
[https://app.netlify.com/sites/apisix-dashboard/deploys/60ae555f62fea80007290d29](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae555f62fea80007290d29?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] iamayushdas removed a comment on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

iamayushdas removed a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848779841






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848800362


   @xdshivani
   see here for some reference

![sinog2c.com](https://user-images.githubusercontent.com/40708551/119669897-0ed16180-be56-11eb-9a72-e3d8be4fa10a.png)
   
   use these links instead: 
   http://www.sinog2c.com/
   https://www.travelsky.com.cn/
   https://partners-intl.aliyun.com/help/doc-detail/142666.htm  for [Log server]
   https://partners-intl.aliyun.com/help/doc-detail/25485.htm for [serve list]
   https://www.alibabacloud.com/help/doc-detail/182218.htm [access services 
through SLB]
   
   hope it helps


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1907: feat: Use monaco editor

[GitBox]

netlify[bot] edited a comment on pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#issuecomment-845072931


   :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
   
   
   :hammer: Explore the source changes: 17dbe3e1faa6cb3104fe7486519139ace6069c67
   
   :mag: Inspect the deploy log: 
[https://app.netlify.com/sites/apisix-dashboard/deploys/60ae555f62fea80007290d29](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae555f62fea80007290d29?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: 
[https://deploy-preview-1907--apisix-dashboard.netlify.app/](https://deploy-preview-1907--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1907: feat: Use monaco editor

[GitBox]

codecov-commenter edited a comment on pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#issuecomment-845098946


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#1907](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (17dbe3e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/9728a430193331d135da4fd5661cd4100308afbf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (9728a43) will **decrease** coverage by `14.51%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1907   +/-   ##
   ===
   - Coverage   66.97%   52.46%   -14.52% 
   ===
 Files 169   38  -131 
 Lines6314 2680 -3634 
 Branches  7450  -745 
   ===
   - Hits 4229 1406 -2823 
   + Misses   1833 1086  -747 
   + Partials  252  188   -64 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `52.46% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#

[GitHub] [apisix] starsz commented on issue #4312: bug: 启用proxy-mirror后正常的请求报404

[GitBox]

starsz commented on issue #4312:
URL: https://github.com/apache/apisix/issues/4312#issuecomment-848807668


   Hi @sandy420 .What's the response body when enable the `proxy-mirror` plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1907: feat: Use monaco editor

[GitBox]

codecov-commenter edited a comment on pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#issuecomment-845098946


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#1907](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (17dbe3e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/9728a430193331d135da4fd5661cd4100308afbf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (9728a43) will **increase** coverage by `2.78%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1907  +/-   ##
   ==
   + Coverage   66.97%   69.76%   +2.78% 
   ==
 Files 169   47 -122 
 Lines6314 3205-3109 
 Branches  7450 -745 
   ==
   - Hits 4229 2236-1993 
   + Misses   1833  717-1116 
 Partials  252  252  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `46.14% <ø> (-0.07%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `45.67% <ø> (-0.25%)` | :arrow_down: |
   | backend-unit-test | `52.46% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `45.45% <0.00%> (-1.82%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `86.90% <0.00%> (-1.20%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | 
[web/src/pages/Upstream/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9MaXN0LnRzeA==)
 | | |
   | 
[web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==)
 | | |
   | 
[web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4)
 | | |
   | 
[web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXB

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1907: feat: Use monaco editor

[GitBox]

codecov-commenter edited a comment on pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#issuecomment-845098946


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#1907](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (17dbe3e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/9728a430193331d135da4fd5661cd4100308afbf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (9728a43) will **decrease** coverage by `0.73%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1907  +/-   ##
   ==
   - Coverage   66.97%   66.24%   -0.74% 
   ==
 Files 169   47 -122 
 Lines6314 3205-3109 
 Branches  7450 -745 
   ==
   - Hits 4229 2123-2106 
   + Misses   1833  814-1019 
   - Partials  252  268  +16 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `46.14% <ø> (-0.07%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `52.46% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv)
 | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `31.93% <0.00%> (-23.53%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `81.25% <0.00%> (-18.75%)` | :arrow_down: |
   | 
[api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=)
 | `40.00% <0.00%> (-10.00%)` | :arrow_down: |
   | 
[api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv)
 | `38.62% <0.00%> (-9.66%)` | :arrow_down: |
   | 
[api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==)
 | `90.47% <0.00%> (-9.53%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundatio

[GitHub] [apisix] Firstsawyou opened a new issue #4314: bug: plugin hot reloading does not take effect

[GitBox]

Firstsawyou opened a new issue #4314:
URL: https://github.com/apache/apisix/issues/4314


   ### Issue description
   
   After modifying the code of the plugin, after performing the following 
operations according to the 
[plugins.md](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins.md#hot-reload)
 document, the hot loading of the apisix plugin did not take effect.
   
   ```shell
   curl http://127.0.0.1:9080/apisix/admin/plugins/reload -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT
   ```
   
   ### Environment
   
   Bug report without environment information will be ignored or closed.
   
   * apisix version (cmd: `apisix version`): 2.6
   * OS (cmd: `uname -a`): Linux
   * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): nginx 
version: openresty/1.19.3.1
   * etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): 
3.4.0
   * apisix-dashboard version, if have:
   * luarocks version, if the issue is about installation (cmd: `luarocks 
--version`): 3.4.0
   
   ### Minimal test code / Steps to reproduce the issue
   
   Bug report without steps to reproduce will be ignored or closed.
   
   1. Modify the `limit-count` plugin code (add a warning log)
   
   ```sh
   --- a/apisix/plugins/limit-count.lua
   +++ b/apisix/plugins/limit-count.lua
   @@ -156,7 +156,7 @@ end

function _M.access(conf, ctx)
   -core.log.info("ver: ", ctx.conf_version)
   +core.log.warn("ver: ", ctx.conf_version, "hello world, 123456")
local lim, err = core.lrucache.plugin_ctx(lrucache, ctx, conf.policy, 
create_limit_obj, conf)
if not lim then
   ```
   
   2. Create a route and bind the plugin
   
   ```shell
   curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   {
   "uri": "/get",
   "plugins": {
   "limit-count": {
   "count": 3,
   "time_window": 10,
   "rejected_code": 503,
   "key": "remote_addr"
   }
   },
   "upstream": {
   "type": "roundrobin",
   "nodes": {
   "httpbin.org:80": 1
   }
   }
   }'
   ```
   
   3. Execute hot load request
   
   ```shell
   curl http://127.0.0.1:9080/apisix/admin/plugins/reload -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT
   ```
   
   4. Request a test
   
   ```shell
   curl http://127.0.0.1:9080/get -i
   HTTP/1.1 200 OK
   Content-Type: application/json
   Content-Length: 300
   Connection: keep-alive
   X-RateLimit-Limit: 3
   X-RateLimit-Remaining: 2
   ```
   
   5. View the error.log log (no log output)
   
   ```
   2021/05/26 22:13:18 [warn] 939867#939867: *164198 [lua] init.lua:290: 
sync_local_conf_to_etcd(): sync local conf to etcd, context: ngx.timer
   ```
   
   6. When the following code is commented, the plugin hot loading will take 
effect
   
   ```sh
   diff --git a/apisix/plugin.lua b/apisix/plugin.lua
   index 5b4337c..7be84ac 100644
   --- a/apisix/plugin.lua
   +++ b/apisix/plugin.lua
   @@ -167,7 +167,7 @@ local function load(plugin_names)
-- the same configure may be synchronized more than one
if plugins_eq(local_plugins_hash, processed) then
core.log.info("plugins not changed")
   -return true
   +-- return true
end

core.log.warn("new plugins: ", core.json.delay_encode(processed))
   ```
   
   ### What's the actual result? (including assertion message & call stack if 
applicable)
   
   After the hot reload request is executed, the code of the modified plugin 
cannot take effect.
   
   ### What's the expected result?
   
   After the hot load request is executed, the modification of the plugin code 
can take effect in time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

netlify[bot] edited a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-831715603


   :construction_worker: Deploy Preview for *apisix* processing.
   
   
   :hammer: Explore the source changes: 267f0a725adbff5a7435dcfd8c2aee883f11ca70
   
   :mag: Inspect the deploy log: 
[https://app.netlify.com/sites/apisix/deploys/60ae5c460cb3170007f69134](https://app.netlify.com/sites/apisix/deploys/60ae5c460cb3170007f69134?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

netlify[bot] edited a comment on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-831715603


   :heavy_check_mark: Deploy Preview for *apisix* ready!
   
   
   :hammer: Explore the source changes: 267f0a725adbff5a7435dcfd8c2aee883f11ca70
   
   :mag: Inspect the deploy log: 
[https://app.netlify.com/sites/apisix/deploys/60ae5c460cb3170007f69134](https://app.netlify.com/sites/apisix/deploys/60ae5c460cb3170007f69134?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: 
[https://deploy-preview-328--apisix.netlify.app](https://deploy-preview-328--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed pull request #1799: fix regex & omit vars when no value

[GitBox]

juzhiyuan closed pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1799: fix regex & omit vars when no value

[GitBox]

juzhiyuan commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848836199


   duplicate with https://github.com/apache/apisix-dashboard/pull/1921


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] xdshivani opened a new pull request #503: fix: ack.md link fix

[GitBox]

xdshivani opened a new pull request #503:
URL: https://github.com/apache/apisix-ingress-controller/pull/503


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   - Related issues
   - https://github.com/apache/apisix-website/issues/326
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   ___
   ### Backport patches
   - Why need to backport?
   
   - Source branch: fixlinks
   
   - Related commits and pull requests
   
   - Target branch: master
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1921: fix: regex & omit vars when no value

[GitBox]

iamayushdas commented on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848855816


   > 
![image](https://user-images.githubusercontent.com/72343596/119684898-777d0600-be77-11eb-9f7d-faaa472d7cdb.png)
   > It is better to add this assertion after line 222 to ensure that the vars 
field disappears.
   > 
   > ```
   >   cy.contains('vars').should('not.exist');
   > ```
   
   i thought its not necessary, will add this line too , thank you
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value

[GitBox]

netlify[bot] edited a comment on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539


   :construction_worker: Deploy Preview for *apisix-dashboard* processing.
   
   
   :hammer: Explore the source changes: fd32623f3230ecf2a35887f732e6f736fbe5212c
   
   :mag: Inspect the deploy log: 
[https://app.netlify.com/sites/apisix-dashboard/deploys/60ae6b174338020008865844](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae6b174338020008865844?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas removed a comment on pull request #1921: fix: regex & omit vars when no value

[GitBox]

iamayushdas removed a comment on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848855816


   > 
![image](https://user-images.githubusercontent.com/72343596/119684898-777d0600-be77-11eb-9f7d-faaa472d7cdb.png)
   > It is better to add this assertion after line 222 to ensure that the vars 
field disappears.
   > 
   > ```
   >   cy.contains('vars').should('not.exist');
   > ```
   
   i thought its not necessary, will add this line too , thank you
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1921: fix: regex & omit vars when no value

[GitBox]

iamayushdas commented on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848876379


   > It is better to add this assertion after line 222 to ensure that the vars 
field disappears.
   > 
   > ```
   >   cy.contains('vars').should('not.exist');
   > ```
   
   added , thanks for nice suggestion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1921: fix: regex & omit vars when no value

[GitBox]

iamayushdas edited a comment on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848876379


   > It is better to add this assertion after line 222 to ensure that the vars 
field disappears.
   > 
   > ```
   >   cy.contains('vars').should('not.exist');
   > ```
   
   added , thanks for nice suggestion @guoqqqi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value

[GitBox]

netlify[bot] edited a comment on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539


   :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
   
   
   :hammer: Explore the source changes: fd32623f3230ecf2a35887f732e6f736fbe5212c
   
   :mag: Inspect the deploy log: 
[https://app.netlify.com/sites/apisix-dashboard/deploys/60ae6b174338020008865844](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae6b174338020008865844?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: 
[https://deploy-preview-1921--apisix-dashboard.netlify.app](https://deploy-preview-1921--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on a change in pull request #4313: feat: nacos discovery support namespace

[GitBox]

Firstsawyou commented on a change in pull request #4313:
URL: https://github.com/apache/apisix/pull/4313#discussion_r639826338



##
File path: t/discovery/nacos.t
##
@@ -251,3 +251,134 @@ discovery:
 ]
 --- no_error_log
 [error]
+
+
+
+=== TEST 8: get APISIX-NACOS info from NACOS - no auth with namespace
+--- yaml_config eval: $::yaml_config
+--- apisix_yaml
+routes:
+  -
+uri: /hello
+upstream:
+  service_name: APISIX-NACOS
+  discovery_type: nacos
+  type: roundrobin
+  nacos_namespace_id: test_ns
+#END
+--- pipelined_requests eval
+[
+"GET /hello",
+"GET /hello",
+]
+--- response_body_like eval
+[
+qr/server [1-2]/,
+qr/server [1-2]/,
+]
+--- no_error_log
+[error, error]

Review comment:
   ```suggestion
   [error]
   ```

##
File path: apisix/discovery/nacos.lua
##
@@ -254,10 +264,10 @@ local function fetch_full_registry(premature)
 applications = up_apps
 return
 end
-
 local data, err
-for _, service_name in ipairs(infos) do
-data, err = get_url(base_uri, instance_list_path .. service_name .. 
token_param)
+for _, service_info in ipairs(infos) do
+local namespace_param = 
get_namespace_param(service_info.nacos_namespace_id);
+data, err = get_url(base_uri, instance_list_path .. 
service_info.service_name .. token_param .. namespace_param)

Review comment:
   ```suggestion
   data, err = get_url(base_uri, instance_list_path .. 
service_info.service_name ..
   token_param .. namespace_param)
   ```

##
File path: t/discovery/nacos.t
##
@@ -251,3 +251,134 @@ discovery:
 ]
 --- no_error_log
 [error]
+
+
+
+=== TEST 8: get APISIX-NACOS info from NACOS - no auth with namespace
+--- yaml_config eval: $::yaml_config
+--- apisix_yaml
+routes:
+  -
+uri: /hello
+upstream:
+  service_name: APISIX-NACOS
+  discovery_type: nacos
+  type: roundrobin
+  nacos_namespace_id: test_ns
+#END
+--- pipelined_requests eval
+[
+"GET /hello",
+"GET /hello",
+]
+--- response_body_like eval
+[
+qr/server [1-2]/,
+qr/server [1-2]/,
+]
+--- no_error_log
+[error, error]
+
+
+
+=== TEST 9: get APISIX-NACOS info from NACOS - configured in services with 
namespace
+--- yaml_config eval: $::yaml_config
+--- apisix_yaml
+routes:
+  -
+uri: /hello
+service_id: 1
+services:
+  -
+id: 1
+upstream:
+  service_name: APISIX-NACOS
+  discovery_type: nacos
+  type: roundrobin
+  nacos_namespace_id: test_ns
+#END
+--- pipelined_requests eval
+[
+"GET /hello",
+"GET /hello",
+]
+--- response_body_like eval
+[
+qr/server [1-2]/,
+qr/server [1-2]/,
+]
+--- no_error_log
+[error]
+
+
+
+=== TEST 10: get APISIX-NACOS info from NACOS - configured in upstreams + etcd 
with namespace
+--- extra_yaml_config
+discovery:
+  nacos:
+  host:
+- "http://127.0.0.1:8858";
+  fetch_interval: 1
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/upstreams/1',
+ ngx.HTTP_PUT,
+ [[{
+"service_name": "APISIX-NACOS",
+"discovery_type": "nacos",
+"type": "roundrobin",
+"nacos_namespace_id": "test_ns"
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+ngx.say(body)
+return
+end
+
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"uri": "/hello",
+"upstream_id": 1
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 11: hit with namespace
+--- extra_yaml_config
+discovery:
+  nacos:
+  host:
+- "http://127.0.0.1:8858";
+  fetch_interval: 1
+--- pipelined_requests eval
+[
+"GET /hello",
+"GET /hello",
+]
+--- response_body_like eval
+[
+qr/server [1-2]/,
+qr/server [1-2]/,
+]
+--- no_error_log
+[error]

Review comment:
   A blank line is required at the end of the file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on issue #4314: bug: plugin hot reloading does not take effect

[GitBox]

Firstsawyou commented on issue #4314:
URL: https://github.com/apache/apisix/issues/4314#issuecomment-848899640


   @spacewander 
   I think the code here should be removed so that it can support hot loading 
after modifying the plugin code. right?
   https://github.com/apache/apisix/blob/master/apisix/plugin.lua#L167-L171


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] slene commented on pull request #453: fix: panic of start leading. sync ingress failed when apisix not start.

[GitBox]

slene commented on pull request #453:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/453#issuecomment-848905195


   @tokers Bad news. You performed an incorrect git operation after force push. 
So my collaboration record is lost. 😞😔😣


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1921: fix: regex & omit vars when no value

[GitBox]

iamayushdas commented on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848918202


   @guoqqqi may i know the problem here?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1921: fix: regex & omit vars when no value

[GitBox]

codecov-commenter commented on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848921691


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#1921](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (d56b173) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/91ad26be6dcda1813419b51bc9d0203c86a1d5d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (91ad26b) will **decrease** coverage by `2.93%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head d56b173 differs from pull request most recent 
head fd32623. Consider uploading reports for the commit fd32623 to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1921  +/-   ##
   ==
   - Coverage   67.00%   64.07%   -2.94% 
   ==
 Files 169  122  -47 
 Lines6314 3112-3202 
 Branches  745  748   +3 
   ==
   - Hits 4231 1994-2237 
   + Misses   1832 1118 -714 
   + Partials  2510 -251 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `64.07% <100.00%> (+0.09%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==)
 | `66.66% <ø> (ø)` | |
   | 
[web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4)
 | `100.00% <ø> (ø)` | |
   | 
[...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4)
 | `33.33% <ø> (ø)` | |
   | 
[...pages/Route/components/Step1/RequestConfigView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1JlcXVlc3RDb25maWdWaWV3LnRzeA==)
 | `81.48% <ø> (ø)` | |
   | 
[web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=)
 | `72.35% <100.00%> (-0.11%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRo

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value

[GitBox]

netlify[bot] edited a comment on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539


   :construction_worker: Deploy Preview for *apisix-dashboard* processing.
   
   
   :hammer: Explore the source changes: 67ea11b7bec72c6efd8fef2bed893e05a9b32b0e
   
   :mag: Inspect the deploy log: 
[https://app.netlify.com/sites/apisix-dashboard/deploys/60ae7865cb6a31000812d590](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae7865cb6a31000812d590?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value

[GitBox]

netlify[bot] edited a comment on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539


   :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
   
   
   :hammer: Explore the source changes: 67ea11b7bec72c6efd8fef2bed893e05a9b32b0e
   
   :mag: Inspect the deploy log: 
[https://app.netlify.com/sites/apisix-dashboard/deploys/60ae7865cb6a31000812d590](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae7865cb6a31000812d590?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: 
[https://deploy-preview-1921--apisix-dashboard.netlify.app](https://deploy-preview-1921--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

Yiyiyimu commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848941148


   The etcd link should be 
https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md,
 but I also failed to locate where is this link. Hi @iamayushdas could you 
offer some help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] Yiyiyimu commented on issue #177: dashboard image on docker hub have wrong tag

[GitBox]

Yiyiyimu commented on issue #177:
URL: https://github.com/apache/apisix-docker/issues/177#issuecomment-848942169


   @gxthrj maybe we need to rebuild `latest` tag to `2.6`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link

[GitBox]

iamayushdas commented on pull request #328:
URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848943324


   > The etcd link should be 
https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md,
 but I also failed to locate where is this link. Hi @iamayushdas could you 
offer some help
   
   I would be a pleasure to help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu merged pull request #4309: docs: update `make lint` output

[GitBox]

Yiyiyimu merged pull request #4309:
URL: https://github.com/apache/apisix/pull/4309


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org