[GitHub] [apisix] Demogorgon314 commented on a change in pull request #4313: feat: nacos discovery support namespace
Demogorgon314 commented on a change in pull request #4313: URL: https://github.com/apache/apisix/pull/4313#discussion_r640305750 ## File path: t/discovery/nacos.t ## @@ -251,3 +251,134 @@ discovery: ] --- no_error_log [error] + + + +=== TEST 8: get APISIX-NACOS info from NACOS - no auth with namespace Review comment: fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Demogorgon314 commented on a change in pull request #4313: feat: nacos discovery support namespace
Demogorgon314 commented on a change in pull request #4313:
URL: https://github.com/apache/apisix/pull/4313#discussion_r640304176
##
File path: apisix/schema_def.lua
##
@@ -389,6 +389,10 @@ local upstream_schema = {
description = "discovery type",
type = "string",
},
+nacos_namespace_id = {
Review comment:
Yes, the would be better！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #494: test: remove custom apisix-default.yaml
codecov-commenter edited a comment on pull request #494: URL: https://github.com/apache/apisix-ingress-controller/pull/494#issuecomment-848428718 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#494](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0713fd3) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/582c4b362f26ffa8372bf520c3f774170a56c290?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (582c4b3) will **decrease** coverage by `0.21%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #494 +/- ## == - Coverage 36.49% 36.28% -0.22% == Files 50 50 Lines4091 4093 +2 == - Hits 1493 1485 -8 - Misses 2400 2406 +6 - Partials 198 202 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/annotations/redirect.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcmVkaXJlY3QuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | `36.36% <0.00%> (-18.19%)` | :arrow_down: | | [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `87.33% <0.00%> (-4.00%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [582c4b3...0713fd3](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4316: bug: etcd timeout in config is too large to be useful
Firstsawyou commented on issue #4316: URL: https://github.com/apache/apisix/issues/4316#issuecomment-849337578 Agree +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-java-plugin-runner] branch main updated (bb08c5d -> 53e1d42)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git.
from bb08c5d ci: fix indent (#12)
add 53e1d42 build: refactor package (#11)
No new revisions were added by this update.
Summary of changes:
.gitignore | 2 +
pom.xml| 70 ++
runner-core/pom.xml| 49 +
runner-dist/pom.xml| 85 ++
runner-dist/src/main/assembly/assemble.xml | 60 +++
{src => runner-dist/src}/main/bin/shutdown.sh | 11 +++
{src => runner-dist/src}/main/bin/startup.sh | 15
runner-plugin-sdk/pom.xml | 21 +-
runner-plugin/pom.xml | 7 +-
runner-starter/pom.xml | 28 ++-
.../src/main/resources/META-INF/srping.factories | 2 -
11 files changed, 281 insertions(+), 69 deletions(-)
create mode 100644 runner-dist/pom.xml
create mode 100644 runner-dist/src/main/assembly/assemble.xml
rename {src => runner-dist/src}/main/bin/shutdown.sh (77%)
rename {src => runner-dist/src}/main/bin/startup.sh (66%)
[GitHub] [apisix-java-plugin-runner] spacewander merged pull request #11: build: refactor package
spacewander merged pull request #11: URL: https://github.com/apache/apisix-java-plugin-runner/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on a change in pull request #349: feat: Announcement bar added for new release
iamayushdas commented on a change in pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#discussion_r640285065
##
File path: website/docusaurus.config.js
##
@@ -415,6 +415,22 @@ module.exports = {
copyright:
"Copyright © 2019-2021 The Apache Software Foundation. Apache APISIX,
APISIX™, Apache, the Apache feather logo, and the Apache APISIX project logo
are either registered trademarks or trademarks of the Apache Software
Foundation.",
},
+announcementBar: {
+ id: 'apisix-2.6-Release',
+ backgroundColor: "#e8433e",
+ textColor: 'white',
+ content:
+'➡️ Apache APISIX v2.6.0 released, users can view Changelogs https://github.com/apache/apisix/blob/2.6/CHANGELOG.md#260;>APISIX 2.6.0
release! ',
+},
+/*
+announcementBar: {
+ id: 'query',
Review comment:
Yes that will make easier for us to change the announcement just by un
commenting it, docusaurus and many websites uses the same strategy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #349: feat: Announcement bar added for new release
juzhiyuan commented on a change in pull request #349:
URL: https://github.com/apache/apisix-website/pull/349#discussion_r640284373
##
File path: website/docusaurus.config.js
##
@@ -415,6 +415,22 @@ module.exports = {
copyright:
"Copyright © 2019-2021 The Apache Software Foundation. Apache APISIX,
APISIX™, Apache, the Apache feather logo, and the Apache APISIX project logo
are either registered trademarks or trademarks of the Apache Software
Foundation.",
},
+announcementBar: {
+ id: 'apisix-2.6-Release',
+ backgroundColor: "#e8433e",
+ textColor: 'white',
+ content:
+'➡️ Apache APISIX v2.6.0 released, users can view Changelogs https://github.com/apache/apisix/blob/2.6/CHANGELOG.md#260;>APISIX 2.6.0
release! ',
+},
+/*
+announcementBar: {
+ id: 'query',
Review comment:
Do we need to keep this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1918: feat: added route path search
juzhiyuan commented on a change in pull request #1918:
URL: https://github.com/apache/apisix-dashboard/pull/1918#discussion_r640284149
##
File path: web/src/pages/Route/List.tsx
##
@@ -343,6 +343,7 @@ const Page: React.FC = () => {
},
{
title: formatMessage({ id: 'page.route.path' }),
+ dataIndex: 'uri',
Review comment:
You need to convert uri to [uri] and uris
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #14: test: add test case about codec
tzssangglass commented on a change in pull request #14:
URL:
https://github.com/apache/apisix-java-plugin-runner/pull/14#discussion_r640279194
##
File path:
runner-core/src/test/java/org/apache/apisix/plugin/runner/codec/impl/FlatBuffersDecoderTest.java
##
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.apisix.plugin.runner.codec.impl;
+
+import io.github.api7.A6.Err.Code;
+import io.github.api7.A6.TextEntry;
+import org.apache.apisix.plugin.runner.A6ConfigRequest;
+import org.apache.apisix.plugin.runner.A6ErrRequest;
+import org.apache.apisix.plugin.runner.A6Request;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.InjectMocks;
+import org.mockito.MockitoAnnotations;
+import org.springframework.boot.test.system.CapturedOutput;
+import org.springframework.boot.test.system.OutputCaptureExtension;
+
+import java.nio.ByteBuffer;
+
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+@ExtendWith(OutputCaptureExtension.class)
+@DisplayName("test decode data")
+class FlatBuffersDecoderTest {
+
+@InjectMocks
+FlatBuffersDecoder flatBuffersDecoder;
+
+@BeforeEach
+void setUp() {
+MockitoAnnotations.initMocks(this);
+}
+
+@Test
+@DisplayName("test empty data")
+void testEmptyData(CapturedOutput capturedOutput) {
+byte[] bytes = new byte[]{};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive empty
data"));
+}
+
+@Test
+@DisplayName("test unsupported type")
+void testUnsupportedType(CapturedOutput capturedOutput) {
+byte[] bytes = new byte[]{4};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive
unsupported type: 4"));
+}
+
+@Test
+@DisplayName("test error data length(1)")
+void testErrorDataLength1(CapturedOutput capturedOutput) {
+// data length is greater than actual length
+byte[] bytes = new byte[]{1, 0, 0, 3, 0};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive error
data length"));
+}
+
+@Test
+@DisplayName("test error data length(2)")
+void testErrorDataLength2(CapturedOutput capturedOutput) {
+// data length equal to 0
+byte[] bytes = new byte[]{1, 0, 0, 0, 0};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive error
data length"));
+}
+
+@Test
+@DisplayName("test error data length(3)")
+void testErrorDataLength3(CapturedOutput capturedOutput) {
+// wrong data content
+byte[] bytes = new byte[]{1, 0, 0, 1, 0, 1};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive error
data length"));
+}
+
+@Test
+@DisplayName("test get body")
+void testGetBody() {
+// {"name":"foo", "value":"bar"}
+byte[] bytes = new byte[]{1, 0, 0, 64, 12, 0, 0, 0, 0, 0, 6, 0, 8, 0,
4, 0, 6, 0, 0, 0, 4, 0, 0, 0, 1, 0, 0, 0, 12, 0, 0, 0, 8, 0, 12, 0, 8, 0, 4, 0,
8, 0, 0, 0, 8, 0, 0, 0, 12, 0, 0, 0, 3, 0, 0, 0, 98,
[GitHub] [apisix] Yiyiyimu opened a new pull request #4320: fix: chaos test could not directly read error.log
Yiyiyimu opened a new pull request #4320: URL: https://github.com/apache/apisix/pull/4320 Signed-off-by: yiyiyimu ### What this PR does / why we need it: After https://github.com/apache/apisix-docker/pull/176 got merged, chaos test could not directly read logs from `error.log`, but should read from kubernetes logs, since that PR forward `error.log` to docker logs interface. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #14: test: add test case about codec
tzssangglass commented on a change in pull request #14:
URL:
https://github.com/apache/apisix-java-plugin-runner/pull/14#discussion_r640277975
##
File path:
runner-core/src/test/java/org/apache/apisix/plugin/runner/codec/impl/FlatBuffersDecoderTest.java
##
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.apisix.plugin.runner.codec.impl;
+
+import io.github.api7.A6.Err.Code;
+import io.github.api7.A6.TextEntry;
+import org.apache.apisix.plugin.runner.A6ConfigRequest;
+import org.apache.apisix.plugin.runner.A6ErrRequest;
+import org.apache.apisix.plugin.runner.A6Request;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.InjectMocks;
+import org.mockito.MockitoAnnotations;
+import org.springframework.boot.test.system.CapturedOutput;
+import org.springframework.boot.test.system.OutputCaptureExtension;
+
+import java.nio.ByteBuffer;
+
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+@ExtendWith(OutputCaptureExtension.class)
+@DisplayName("test decode data")
+class FlatBuffersDecoderTest {
+
+@InjectMocks
+FlatBuffersDecoder flatBuffersDecoder;
+
+@BeforeEach
+void setUp() {
+MockitoAnnotations.initMocks(this);
+}
+
+@Test
+@DisplayName("test empty data")
+void testEmptyData(CapturedOutput capturedOutput) {
+byte[] bytes = new byte[]{};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive empty
data"));
+}
+
+@Test
+@DisplayName("test unsupported type")
+void testUnsupportedType(CapturedOutput capturedOutput) {
+byte[] bytes = new byte[]{4};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive
unsupported type: 4"));
+}
+
+@Test
+@DisplayName("test error data length(1)")
+void testErrorDataLength1(CapturedOutput capturedOutput) {
+// data length is greater than actual length
+byte[] bytes = new byte[]{1, 0, 0, 3, 0};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive error
data length"));
+}
+
+@Test
+@DisplayName("test error data length(2)")
+void testErrorDataLength2(CapturedOutput capturedOutput) {
+// data length equal to 0
+byte[] bytes = new byte[]{1, 0, 0, 0, 0};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive error
data length"));
+}
+
+@Test
+@DisplayName("test error data length(3)")
+void testErrorDataLength3(CapturedOutput capturedOutput) {
+// wrong data content
+byte[] bytes = new byte[]{1, 0, 0, 1, 0, 1};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive error
data length"));
+}
+
+@Test
+@DisplayName("test get body")
+void testGetBody() {
+// {"name":"foo", "value":"bar"}
+byte[] bytes = new byte[]{1, 0, 0, 64, 12, 0, 0, 0, 0, 0, 6, 0, 8, 0,
4, 0, 6, 0, 0, 0, 4, 0, 0, 0, 1, 0, 0, 0, 12, 0, 0, 0, 8, 0, 12, 0, 8, 0, 4, 0,
8, 0, 0, 0, 8, 0, 0, 0, 12, 0, 0, 0, 3, 0, 0, 0, 98,
[GitHub] [apisix-website] iamayushdas commented on pull request #349: feat: Announcement bar added for new release
iamayushdas commented on pull request #349: URL: https://github.com/apache/apisix-website/pull/349#issuecomment-849309609 @juzhiyuan @Yiyiyimu apisix 2.6 has been released can we now add this announcement bar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4313: feat: nacos discovery support namespace
spacewander commented on a change in pull request #4313:
URL: https://github.com/apache/apisix/pull/4313#discussion_r640276937
##
File path: t/discovery/nacos.t
##
@@ -251,3 +251,134 @@ discovery:
]
--- no_error_log
[error]
+
+
+
+=== TEST 8: get APISIX-NACOS info from NACOS - no auth with namespace
Review comment:
Need another test that the request gets 503 because the namespace is
incorrect.
##
File path: apisix/schema_def.lua
##
@@ -389,6 +389,10 @@ local upstream_schema = {
description = "discovery type",
type = "string",
},
+nacos_namespace_id = {
Review comment:
I think it would be better if we move the `nacos_namespace_id` into
`discovery_args`, like:
```
discovery_args = {
type = "object",
properties = {
namespace_id = {
description = "namespace id",
type = "string",
},
}
},
```
This change will make the schema tidy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4318: request help: Set reuquest var in header, but i don't get param from ctx.var
Firstsawyou commented on issue #4318: URL: https://github.com/apache/apisix/issues/4318#issuecomment-849308722 The request header information will not be stored in ctx.var unless we store it in advance. The request header is obtained by using nginx's `$http_PARAMETER` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #494: test: remove custom apisix-default.yaml
codecov-commenter edited a comment on pull request #494: URL: https://github.com/apache/apisix-ingress-controller/pull/494#issuecomment-848428718 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#494](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5598b02) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/582c4b362f26ffa8372bf520c3f774170a56c290?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (582c4b3) will **decrease** coverage by `0.21%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #494 +/- ## == - Coverage 36.49% 36.28% -0.22% == Files 50 50 Lines4091 4093 +2 == - Hits 1493 1485 -8 - Misses 2400 2406 +6 - Partials 198 202 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/annotations/redirect.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcmVkaXJlY3QuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | `36.36% <0.00%> (-18.19%)` | :arrow_down: | | [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `87.33% <0.00%> (-4.00%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [582c4b3...5598b02](https://codecov.io/gh/apache/apisix-ingress-controller/pull/494?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4319: fix: ensure the plugin is always reloaded
spacewander opened a new pull request #4319: URL: https://github.com/apache/apisix/pull/4319 Only trigger a reset from admin when the etcd's data is different from the one of admin. So there is no need to add check in node side. Fix #4314 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1921: fix: regex & omit vars when no value
codecov-commenter edited a comment on pull request #1921: URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848921691 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1921](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e25940c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/91ad26be6dcda1813419b51bc9d0203c86a1d5d0?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (91ad26b) will **decrease** coverage by `2.87%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1921 +/- ## == - Coverage 67.00% 64.13% -2.88% == Files 169 122 -47 Lines6314 3112-3202 Branches 745 748 +3 == - Hits 4231 1996-2235 + Misses 1832 1116 -716 + Partials 2510 -251 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `64.13% <100.00%> (+0.16%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | `66.66% <ø> (ø)` | | | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <ø> (ø)` | | | [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4) | `33.33% <ø> (ø)` | | | [...pages/Route/components/Step1/RequestConfigView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1JlcXVlc3RDb25maWdWaWV3LnRzeA==) | `81.48% <ø> (ø)` | | | [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | `72.35% <100.00%> (-0.11%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | | |
[GitHub] [apisix-website] Yiyiyimu merged pull request #328: docs: fixed kubernetes service api broken link
Yiyiyimu merged pull request #328: URL: https://github.com/apache/apisix-website/pull/328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu closed issue #326: docs: many broken links our residing in website
Yiyiyimu closed issue #326: URL: https://github.com/apache/apisix-website/issues/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: docs: fixed kubernetes service api broken link (#328)
This is an automated email from the ASF dual-hosted git repository.
shuyangw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new ad81f9f docs: fixed kubernetes service api broken link (#328)
ad81f9f is described below
commit ad81f9f5dc513840f883ffa06aaa01481bb55445
Author: Shivani chauhan <56837749+xdshiv...@users.noreply.github.com>
AuthorDate: Thu May 27 09:06:38 2021 +0530
docs: fixed kubernetes service api broken link (#328)
---
website/blog/2020-12-18-a-first-look-at-kubernetes-service-api.md | 4 ++--
website/static/data/showcases.json| 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/website/blog/2020-12-18-a-first-look-at-kubernetes-service-api.md
b/website/blog/2020-12-18-a-first-look-at-kubernetes-service-api.md
index 374b911..f2b3c83 100644
--- a/website/blog/2020-12-18-a-first-look-at-kubernetes-service-api.md
+++ b/website/blog/2020-12-18-a-first-look-at-kubernetes-service-api.md
@@ -21,7 +21,7 @@ authorImageURL:
"https://avatars2.githubusercontent.com/u/4413028?s=400=e140a6
我们知道 Kubernetes 为了将集群内部服务暴露出去，有多种方案实现，其中一个比较受大众推崇的就是 Ingress。Ingress
作为一种对外暴露服务的标准，有相当多的第三方实现，每种实现都有各自的技术栈 和 所依赖的网关的影子，相互之间并不兼容。
-为了统一各种 Ingress 的实现，便于 Kubernetes
上统一管理，[SIG-NETWORK](https://github.com/kubernetes/community/tree/master/sig-network)
社区推出了[Kubernetes Service
APIs](https://kubernetes-sigs.github.io/service-apis/) 一套标准实现，称为第二代 Ingress 。
+为了统一各种 Ingress 的实现，便于 Kubernetes
上统一管理，[SIG-NETWORK](https://github.com/kubernetes/community/tree/master/sig-network)
社区推出了[Kubernetes Service APIs](https://gateway-api.sigs.k8s.io/) 一套标准实现，称为第二代
Ingress 。
## 主题描述
@@ -149,5 +149,5 @@ RBAC（基于角色的访问控制）是用于 Kubernetes 授权的标准。允
参考:
-- https://kubernetes-sigs.github.io/service-apis/
+- https://gateway-api.sigs.k8s.io/
- https://www.apiseven.com/zh/blog/a-first-look-at-kubernetes-service-api
diff --git a/website/static/data/showcases.json
b/website/static/data/showcases.json
index 2585442..9814ce8 100644
--- a/website/static/data/showcases.json
+++ b/website/static/data/showcases.json
@@ -176,7 +176,7 @@
{
"caption": "湖南国科云通",
"image": "showcase/sinog2c.png",
-"infoLink": "http://sinog2c.com/;,
+"infoLink": "http://www.sinog2c.com/;,
"pinned": true
},
{
@@ -218,7 +218,7 @@
{
"caption": "中国航信",
"image": "showcase/TravelSky.png",
-"infoLink": "http://travelsky.com/;,
+"infoLink": "https://www.travelsky.com.cn/;,
"pinned": true
},
{
[GitHub] [apisix-java-plugin-runner] dmsolr commented on a change in pull request #11: build: refactor package
dmsolr commented on a change in pull request #11:
URL:
https://github.com/apache/apisix-java-plugin-runner/pull/11#discussion_r640263020
##
File path: runner-dist/src/main/bin/startup.sh
##
@@ -15,3 +15,15 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
+
+RUNNER_HOME=$(dirname "$0")/..
+
+RUNNER_HEAP=${JAVA_HEAP:-4g}
+
+JAVA_OPS="${JAVA_OPS} -Xmx${RUNNER_HEAP} -Xms${RUNNER_HEAP}"
+
+nohup java -jar ${JAVA_OPS} ${RUNNER_HOME}/apisxi-runner-start-*.jar \
+ 1>${RUNNER_HOME}/logs/runner.out \
+ 2>${RUNNER_HOME}/logs/runner.err &
+
+echo $! > ./logs/runner.pid
Review comment:
resolved, recheck, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Demogorgon314 edited a comment on pull request #4313: feat: nacos discovery support namespace
Demogorgon314 edited a comment on pull request #4313: URL: https://github.com/apache/apisix/pull/4313#issuecomment-849291705 > The CI is always pending on "wait nacos reg..." I changed nacos-test-service Dockerfile , should be related to this @spacewander https://github.com/api7/nacos-test-service/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Demogorgon314 commented on pull request #4313: feat: nacos discovery support namespace
Demogorgon314 commented on pull request #4313: URL: https://github.com/apache/apisix/pull/4313#issuecomment-849291705 > The CI is always pending on "wait nacos reg..." I changed nacos-test-service Dockerfile , should be related to this @spacewander https://github.com/api7/nacos-test-service/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value
netlify[bot] edited a comment on pull request #1921: URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539 :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready! :hammer: Explore the source changes: e25940c01b3e7c8b4be9cf54f697bfa5812c4887 :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60af0f034bbe390008828c2c](https://app.netlify.com/sites/apisix-dashboard/deploys/60af0f034bbe390008828c2c?utm_source=github_campaign=bot_dl) :sunglasses: Browse the preview: [https://deploy-preview-1921--apisix-dashboard.netlify.app/](https://deploy-preview-1921--apisix-dashboard.netlify.app/?utm_source=github_campaign=bot_dp) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4313: feat: nacos discovery support namespace
spacewander commented on pull request #4313: URL: https://github.com/apache/apisix/pull/4313#issuecomment-849288831 The CI is always pending on "wait nacos reg..." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] dmsolr commented on a change in pull request #14: test: add test case about codec
dmsolr commented on a change in pull request #14:
URL:
https://github.com/apache/apisix-java-plugin-runner/pull/14#discussion_r640259667
##
File path:
runner-core/src/test/java/org/apache/apisix/plugin/runner/codec/impl/FlatBuffersEncoderTest.java
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.apisix.plugin.runner.codec.impl;
+
+import io.github.api7.A6.Err.Code;
+import io.github.api7.A6.HTTPReqCall.Action;
+import io.github.api7.A6.HTTPReqCall.Rewrite;
+import io.github.api7.A6.HTTPReqCall.Stop;
+import io.netty.handler.codec.http.HttpResponseStatus;
+import org.apache.apisix.plugin.runner.A6ConfigResponse;
+import org.apache.apisix.plugin.runner.A6ErrResponse;
+import org.apache.apisix.plugin.runner.HttpResponse;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+import java.nio.ByteBuffer;
+
+@DisplayName("test encode data")
+class FlatBuffersEncoderTest {
+FlatBuffersEncoder flatBuffersEncoder = new FlatBuffersEncoder();
+
+@Test
+@DisplayName("test encode error response(1)")
+void testErrResponseEncode1() {
+A6ErrResponse errResponse = new A6ErrResponse(Code.BAD_REQUEST);
+ByteBuffer result = flatBuffersEncoder.encode(errResponse);
+byte[] res = new byte[result.remaining()];
+result.get(res);
+
+//example
+byte[] example = new byte[]{0, 0, 0, 12, 8, 0, 0, 0, 4, 0, 4, 0, 4, 0,
0, 0};
Review comment:
The same as above.
##
File path:
runner-core/src/test/java/org/apache/apisix/plugin/runner/codec/impl/FlatBuffersDecoderTest.java
##
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.apisix.plugin.runner.codec.impl;
+
+import io.github.api7.A6.Err.Code;
+import io.github.api7.A6.TextEntry;
+import org.apache.apisix.plugin.runner.A6ConfigRequest;
+import org.apache.apisix.plugin.runner.A6ErrRequest;
+import org.apache.apisix.plugin.runner.A6Request;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.InjectMocks;
+import org.mockito.MockitoAnnotations;
+import org.springframework.boot.test.system.CapturedOutput;
+import org.springframework.boot.test.system.OutputCaptureExtension;
+
+import java.nio.ByteBuffer;
+
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+@ExtendWith(OutputCaptureExtension.class)
+@DisplayName("test decode data")
+class FlatBuffersDecoderTest {
+
+@InjectMocks
+FlatBuffersDecoder flatBuffersDecoder;
+
+@BeforeEach
+void setUp() {
+MockitoAnnotations.initMocks(this);
+}
+
+@Test
+@DisplayName("test empty data")
+void testEmptyData(CapturedOutput capturedOutput) {
+byte[] bytes = new byte[]{};
+ByteBuffer buffer = ByteBuffer.wrap(bytes);
+A6Request result = flatBuffersDecoder.decode(buffer);
+Assertions.assertEquals(Code.BAD_REQUEST, ((A6ErrRequest)
result).getCode());
+Assertions.assertTrue(capturedOutput.getOut().contains("receive empty
data"));
+}
+
+@Test
+@DisplayName("test unsupported type")
+void testUnsupportedType(CapturedOutput capturedOutput) {
+byte[] bytes = new byte[]{4};
+ByteBuffer buffer =
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1921: fix: regex & omit vars when no value
iamayushdas commented on a change in pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#discussion_r640258636
##
File path:
web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
##
@@ -101,7 +104,11 @@ context('Create and Delete Route', () => {
cy.contains('Confirm').click();
cy.contains('Next').click();
-cy.get(selector.nodes_0_host).type(data.host2);
+cy.get(selector.nodes_0_host).type('@');
Review comment:
done
##
File path:
web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
##
@@ -101,7 +104,11 @@ context('Create and Delete Route', () => {
cy.contains('Confirm').click();
cy.contains('Next').click();
-cy.get(selector.nodes_0_host).type(data.host2);
+cy.get(selector.nodes_0_host).type('@');
+cy.get(selector.schemaErrorMessage).should('exist');
+cy.get(selector.nodes_0_host).clear().type('*1');
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value
netlify[bot] edited a comment on pull request #1921: URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: e25940c01b3e7c8b4be9cf54f697bfa5812c4887 :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60af0f034bbe390008828c2c](https://app.netlify.com/sites/apisix-dashboard/deploys/60af0f034bbe390008828c2c?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] sandy420 commented on issue #4312: bug: 启用proxy-mirror后正常的请求报404
sandy420 commented on issue #4312: URL: https://github.com/apache/apisix/issues/4312#issuecomment-849285059 The response returned by the mirror request is ignored.so,I don’t know what it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #495: request help: websocket reqeust failed
tokers commented on issue #495: URL: https://github.com/apache/apisix-ingress-controller/issues/495#issuecomment-849280736 @lingsamuel Please take a look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #500: request help: no kind is registered for the type v1.ApisixUpstream in scheme "pkg/runtime/scheme.go:100"
tokers commented on issue #500: URL: https://github.com/apache/apisix-ingress-controller/issues/500#issuecomment-849278148 @gxthrj @tao12345666333 @lingsamuel Have you ever seens this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #502: feat: add events and status for ApisixClusterConfig resource
tokers commented on pull request #502: URL: https://github.com/apache/apisix-ingress-controller/pull/502#issuecomment-849276933 @gxthrj Update https://github.com/apache/apisix-ingress-controller/blob/master/samples/deploy/rbac/apisix_view_clusterrole.yaml to add the permissions, also, change the clusterrole in e2e test suites, also adding some test cases to cover it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #328: docs: fixed kubernetes service api broken link
iamayushdas edited a comment on pull request #328: URL: https://github.com/apache/apisix-website/pull/328#issuecomment-849274914 > The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help It is already fixed now, thats why you aren't able to find the link -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link
iamayushdas commented on pull request #328: URL: https://github.com/apache/apisix-website/pull/328#issuecomment-849274914 > The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help It is already fixed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #328: docs: fixed kubernetes service api broken link
iamayushdas edited a comment on pull request #328: URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848943324 > The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help It would be a pleasure to help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on issue #1920: Error: .jsx: Unexpected token
iamayushdas edited a comment on issue #1920: URL: https://github.com/apache/apisix-dashboard/issues/1920#issuecomment-849270134 i just ran three commands : 1. etcd 2. make api-run 3. yarn && yarn start (inside website directory) it worked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on issue #352: use navbar_version instead of sidebar_version
Yiyiyimu commented on issue #352: URL: https://github.com/apache/apisix-website/issues/352#issuecomment-849271421 > We have multiple docs instance My bad I didn't realize this problem 藍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1921: fix: regex & omit vars when no value
iamayushdas commented on a change in pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#discussion_r640246341
##
File path:
web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
##
@@ -101,7 +104,11 @@ context('Create and Delete Route', () => {
cy.contains('Confirm').click();
cy.contains('Next').click();
-cy.get(selector.nodes_0_host).type(data.host2);
+cy.get(selector.nodes_0_host).type('@');
+cy.get(selector.schemaErrorMessage).should('exist');
+cy.get(selector.nodes_0_host).clear().type('*1');
Review comment:
ok
##
File path:
web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
##
@@ -101,7 +104,11 @@ context('Create and Delete Route', () => {
cy.contains('Confirm').click();
cy.contains('Next').click();
-cy.get(selector.nodes_0_host).type(data.host2);
+cy.get(selector.nodes_0_host).type('@');
Review comment:
okay, declaring it right away, thanks for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] Marco-Zheng commented on issue #1920: Error: .jsx: Unexpected token
Marco-Zheng commented on issue #1920: URL: https://github.com/apache/apisix-dashboard/issues/1920#issuecomment-849270595 @iamayushdas Thanks, let me try for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1920: Error: .jsx: Unexpected token
iamayushdas commented on issue #1920: URL: https://github.com/apache/apisix-dashboard/issues/1920#issuecomment-849270134 i just ran two commands : 1. etcd 2. make api-run 3. yarn && yarn start (inside website directory) it worked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: chore(ext-plugin): remove useless `extra_info` field (#4311)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new f0a5c94 chore(ext-plugin): remove useless `extra_info` field (#4311)
f0a5c94 is described below
commit f0a5c94f830c35553f22b3216b887346302c90a6
Author: 罗泽轩
AuthorDate: Thu May 27 10:27:46 2021 +0800
chore(ext-plugin): remove useless `extra_info` field (#4311)
Signed-off-by: spacewander
---
apisix/plugins/ext-plugin/init.lua | 9 -
1 file changed, 9 deletions(-)
diff --git a/apisix/plugins/ext-plugin/init.lua
b/apisix/plugins/ext-plugin/init.lua
index 190f048..9f83bf4 100644
--- a/apisix/plugins/ext-plugin/init.lua
+++ b/apisix/plugins/ext-plugin/init.lua
@@ -83,15 +83,6 @@ local schema = {
},
minItems = 1,
},
-extra_info = {
-type = "array",
-items = {
-type = "string",
-maxLength = 64,
-minLength = 1,
-},
-minItems = 1,
-}
},
}
[GitHub] [apisix-dashboard] Marco-Zheng commented on issue #1920: Error: .jsx: Unexpected token
Marco-Zheng commented on issue #1920: URL: https://github.com/apache/apisix-dashboard/issues/1920#issuecomment-849268915 @iamayushdas Hi, I manual `umi build` and `yarn run start` locally, the error was happened -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers merged pull request #4311: chore(ext-plugin): remove useless `extra_info` field
tokers merged pull request #4311: URL: https://github.com/apache/apisix/pull/4311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1921: fix: regex & omit vars when no value
liuxiran commented on a change in pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#discussion_r640244121
##
File path:
web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
##
@@ -101,7 +104,11 @@ context('Create and Delete Route', () => {
cy.contains('Confirm').click();
cy.contains('Next').click();
-cy.get(selector.nodes_0_host).type(data.host2);
+cy.get(selector.nodes_0_host).type('@');
+cy.get(selector.schemaErrorMessage).should('exist');
+cy.get(selector.nodes_0_host).clear().type('*1');
Review comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4318: request help: Set reuquest var in header, but i don't get param from ctx.var
tokers commented on issue #4318: URL: https://github.com/apache/apisix/issues/4318#issuecomment-849268666 @Firstsawyou Please take a look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1921: fix: regex & omit vars when no value
liuxiran commented on a change in pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#discussion_r640244030
##
File path:
web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
##
@@ -101,7 +104,11 @@ context('Create and Delete Route', () => {
cy.contains('Confirm').click();
cy.contains('Next').click();
-cy.get(selector.nodes_0_host).type(data.host2);
+cy.get(selector.nodes_0_host).type('@');
Review comment:
It would be better to define a data param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4316: bug: etcd timeout in config is too large to be useful
tokers commented on issue #4316: URL: https://github.com/apache/apisix/issues/4316#issuecomment-849268550 Agree +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Marco-Zheng commented on issue #1916: Add route path search in dashboard
Marco-Zheng commented on issue #1916: URL: https://github.com/apache/apisix-dashboard/issues/1916#issuecomment-849268171 @nic-chen Ok, thanks for your kindly reply -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Marco-Zheng opened a new issue #4318: request help: Set reuquest var in header, but i don't get param from ctx.var
Marco-Zheng opened a new issue #4318: URL: https://github.com/apache/apisix/issues/4318 ### Issue description I see that in the traffic-split of the official case of Apisix, ctx.var is the value from the request header, but when I put the parameter in the header when I requested it, I didn't get the value ?   ### Environment * apisix version (cmd: `apisix version`): 2.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #352: use navbar_version instead of sidebar_version
juzhiyuan commented on issue #352: URL: https://github.com/apache/apisix-website/issues/352#issuecomment-849267199 We have multiple docs instance, not sure if it's configurable 藍 What do you think? @qier222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1918: feat: added route path search
iamayushdas commented on a change in pull request #1918:
URL: https://github.com/apache/apisix-dashboard/pull/1918#discussion_r640235079
##
File path: web/src/pages/Route/List.tsx
##
@@ -343,6 +343,7 @@ const Page: React.FC = () => {
},
{
title: formatMessage({ id: 'page.route.path' }),
+ dataIndex: 'uri',
Review comment:
I have done it according to the params , is it okay to do so? Also i
have texted you the message regarding this on slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #354: bug: Official website Chinese doc showing English
juzhiyuan commented on issue #354: URL: https://github.com/apache/apisix-website/issues/354#issuecomment-849265489 cc @qier222 to have a check. Maybe related to versioned docs JS script? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #354: bug: Official website Chinese doc showing English
juzhiyuan commented on issue #354: URL: https://github.com/apache/apisix-website/issues/354#issuecomment-849263559 Wired, let me have a check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on issue #4316: bug: etcd timeout in config is too large to be useful
Yiyiyimu commented on issue #4316: URL: https://github.com/apache/apisix/issues/4316#issuecomment-849259498 Got it would fix it later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on issue #354: bug: Official website Chinese doc showing English
Yiyiyimu commented on issue #354: URL: https://github.com/apache/apisix-website/issues/354#issuecomment-849259178 ping @juzhiyuan it seems broken -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1918: feat: added route path search
iamayushdas commented on a change in pull request #1918:
URL: https://github.com/apache/apisix-dashboard/pull/1918#discussion_r640235079
##
File path: web/src/pages/Route/List.tsx
##
@@ -343,6 +343,7 @@ const Page: React.FC = () => {
},
{
title: formatMessage({ id: 'page.route.path' }),
+ dataIndex: 'uri',
Review comment:
I have done it according to the params , is it okay to do so? Also i
have texted you the message regarding this on slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1918: feat: added route path search
iamayushdas commented on a change in pull request #1918:
URL: https://github.com/apache/apisix-dashboard/pull/1918#discussion_r640235079
##
File path: web/src/pages/Route/List.tsx
##
@@ -343,6 +343,7 @@ const Page: React.FC = () => {
},
{
title: formatMessage({ id: 'page.route.path' }),
+ dataIndex: 'uri',
Review comment:
I have done it according to the params , is it okay to do so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] vincentwc closed issue #4307: request help: 创建一个路由的时候，是怎么走到apisix/admin/routes.lua的_M.put方法的啊？
vincentwc closed issue #4307: URL: https://github.com/apache/apisix/issues/4307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #4316: bug: etcd timeout in config is too large to be useful
tzssangglass commented on issue #4316: URL: https://github.com/apache/apisix/issues/4316#issuecomment-849252972 agree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #503: fix: ack.md link fix
codecov-commenter commented on pull request #503: URL: https://github.com/apache/apisix-ingress-controller/pull/503#issuecomment-849255511 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#503](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ee1cdc1) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/d8a40b7dfa49b844fd0159a4e0450c3066f24cfd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d8a40b7) will **decrease** coverage by `2.18%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #503 +/- ## == - Coverage 38.68% 36.49% -2.19% == Files 41 50 +9 Lines3345 4091 +746 == + Hits 1294 1493 +199 - Misses 1890 2400 +510 - Partials 161 198 +37 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | `60.86% <0.00%> (-39.14%)` | :arrow_down: | | [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `63.63% <0.00%> (-20.58%)` | :arrow_down: | | [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `53.84% <0.00%> (-7.38%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `23.46% <0.00%> (-6.49%)` | :arrow_down: | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `42.71% <0.00%> (-5.67%)` | :arrow_down: | | [pkg/ingress/manifest.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvbWFuaWZlc3QuZ28=) | `63.21% <0.00%> (-4.58%)` | :arrow_down: | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `35.03% <0.00%> (-0.26%)` | :arrow_down: | | [pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==) | `33.08% <0.00%> (-0.26%)` | :arrow_down: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/503/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `33.08% <0.00%> (-0.25%)` | :arrow_down: | |
[GitHub] [apisix-website] anjia0532 opened a new issue #354: bug: Official website Chinese doc showing English
anjia0532 opened a new issue #354: URL: https://github.com/apache/apisix-website/issues/354 All of them, e.g. https://apisix.apache.org/zh/docs/apisix/getting-started/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] vincentwc commented on issue #4307: request help: 创建一个路由的时候，是怎么走到apisix/admin/routes.lua的_M.put方法的啊？
vincentwc commented on issue #4307: URL: https://github.com/apache/apisix/issues/4307#issuecomment-849252735 > this is a linux environment variable, there are many ways to set it, for example, > > ```shell > export APISIX_PROFILE = prod > ``` > > and check it > > ```shell > echo $APISIX_PROFILE > ``` it will check the param in linux env not in apisix config? got it .thak you for your reply -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] anjia0532 closed issue #4317: bug: Official website Chinese doc showing English
anjia0532 closed issue #4317: URL: https://github.com/apache/apisix/issues/4317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #15: test: add test cases about filter
tzssangglass commented on pull request #15: URL: https://github.com/apache/apisix-java-plugin-runner/pull/15#issuecomment-849251504 @dmsolr @spacewander pls review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] anjia0532 opened a new issue #4317: bug: Official website Chinese doc showing English
anjia0532 opened a new issue #4317: URL: https://github.com/apache/apisix/issues/4317 ### Issue description All of them, e.g. https://apisix.apache.org/zh/docs/apisix/getting-started/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers edited a comment on pull request #453: fix: panic of start leading. sync ingress failed when apisix not start.
tokers edited a comment on pull request #453: URL: https://github.com/apache/apisix-ingress-controller/pull/453#issuecomment-849251017 > @tokers Bad news. You performed an incorrect git operation after force push. So my collaboration record is lost. It's my bad. But don't worry your collaboration is still counted, and now you are the contributor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #453: fix: panic of start leading. sync ingress failed when apisix not start.
tokers commented on pull request #453: URL: https://github.com/apache/apisix-ingress-controller/pull/453#issuecomment-849251017 > @tokers Bad news. You performed an incorrect git operation after force push. So my collaboration record is lost. It's may bad. But don't worry your collaboration is still counted, and now you are the contributor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on issue #352: use navbar_version instead of sidebar_version
Yiyiyimu commented on issue #352: URL: https://github.com/apache/apisix-website/issues/352#issuecomment-849236848 > Just to make sure, the navbar version selector is globally? If we visit the homepage, will it appear? I think yes, see https://docusaurus.io/ and https://chaos-mesh.org/. But I'm not sure if it's configuratble -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #352: use navbar_version instead of sidebar_version
juzhiyuan commented on issue #352: URL: https://github.com/apache/apisix-website/issues/352#issuecomment-849224857 Just to make sure, the navbar version selector is globally? If we visit the homepage, will it appear? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1918: feat: added route path search
juzhiyuan commented on a change in pull request #1918:
URL: https://github.com/apache/apisix-dashboard/pull/1918#discussion_r640216614
##
File path: web/src/pages/Route/List.tsx
##
@@ -343,6 +343,7 @@ const Page: React.FC = () => {
},
{
title: formatMessage({ id: 'page.route.path' }),
+ dataIndex: 'uri',
Review comment:
Actually, we use `uris` in the frontend 樂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4316: bug: etcd timeout in config is too large to be useful
spacewander commented on issue #4316: URL: https://github.com/apache/apisix/issues/4316#issuecomment-849219545 Agree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4311: chore(ext-plugin): remove useless `extra_info` field
spacewander commented on pull request #4311: URL: https://github.com/apache/apisix/pull/4311#issuecomment-849218572 @starsz I already provided it. Please read the title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Demogorgon314 commented on a change in pull request #4313: feat: nacos discovery support namespace
Demogorgon314 commented on a change in pull request #4313: URL: https://github.com/apache/apisix/pull/4313#discussion_r640209799 ## File path: apisix/discovery/nacos.lua ## @@ -254,10 +264,10 @@ local function fetch_full_registry(premature) applications = up_apps return end - local data, err -for _, service_name in ipairs(infos) do -data, err = get_url(base_uri, instance_list_path .. service_name .. token_param) +for _, service_info in ipairs(infos) do +local namespace_param = get_namespace_param(service_info.nacos_namespace_id); +data, err = get_url(base_uri, instance_list_path .. service_info.service_name .. token_param .. namespace_param) Review comment: fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu opened a new issue #4316: bug: etcd timeout in config is too large to be useful
Yiyiyimu opened a new issue #4316:
URL: https://github.com/apache/apisix/issues/4316
### Issue description
Just found adding 1s network delay between apisix and etcd could make all
operation fails, although we set default etcd timeout to 30s. The reason is
that there seems a default and non-configurable timeout context in the etcd,
and it's around 5s. After that, it would just return the error `context
deadline exceeded`.
So no matter how large we add network delay to etcd, the put operation with
grpc (test with `etcdctl`) would timeout at 5s, and RESTful API (test with
`curl`) would timeout at 7s. However, when set etcd timeout (used in
`lua-resty-http`) as 30s, we need to wait more time (30s) to get the returned
error when for example, add a route to APISIX. So I think reducing the default
timeout to 10s is enough for us, and we could remind users greater timeout
would be no use.
Here I list a `delay_time - process_time - error chart` for future reference
network delay | grpc response time | restful response time | lua-resty-etcd
response time | apisix response time | grpc error | restful error |
lua-resty-etcd error | apisix error
-- | -- | -- | -- | -- | -- | -- | -- | --
0 | 0.026 | 0.014 | 0.004 | 0.008 | | | |
50ms | 0.128 | 0.112 | 0.255 | 0.154 | | | |
200ms | 0.427 | 0.412 | 1.00 | 1.00 | | | |
500ms | 1.03 | 1.02 | 1.50 | 3.00 | | | |
800ms | 5.02 | 7.01 | 7.80 | 8.60 | context deadline exceeded | etcdserver:
request timed out | invalid response code: 500 | {"error_msg":"invalid response
code: 503"}
2s | 5.02 | 7.02 | 9.00 | 11.0 | context deadline exceeded | context
deadline exceeded | invalid response code: 500 | {"error_msg":"invalid response
code: 503"}
10s | 5.02 | 7.01 | 30.0 | 38.0 | context deadline exceeded | context
deadline exceeded | timeout | {"error_msg":"invalid response code: 503"} [from
log] failed to fetch data from etcd: no route to host
30s | 5.05 | 7.01 | | | context deadline exceeded | context
deadline exceeded | [can not create etcd client] timeout | {"error_msg":"no
route to host"}/{"error_msg":"timeout"}
### Environment
Bug report without environment information will be ignored or closed.
* apisix version (cmd: `apisix version`): docker latest version
### Minimal test code / Steps to reproduce the issue
Just like #4315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu opened a new pull request #4315: ci: add chaos test on network delay between apisix and etcd
Yiyiyimu opened a new pull request #4315: URL: https://github.com/apache/apisix/pull/4315 Signed-off-by: yiyiyimu ### What this PR does / why we need it: 1. add chaos test on network delay between apisix and etcd 2. refactor ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas removed a comment on pull request #1921: fix: regex & omit vars when no value
iamayushdas removed a comment on pull request #1921: URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848918202 @guoqqqi may i know the problem here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #505: ci: cancel duplicate workflow to reduce CI queue time
codecov-commenter commented on pull request #505: URL: https://github.com/apache/apisix-ingress-controller/pull/505#issuecomment-849156929 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/505?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#505](https://codecov.io/gh/apache/apisix-ingress-controller/pull/505?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (915e770) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/582c4b362f26ffa8372bf520c3f774170a56c290?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (582c4b3) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/505?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #505 +/- ## === Coverage 36.49% 36.49% === Files 50 50 Lines4091 4091 === Hits 1493 1493 Misses 2400 2400 Partials 198 198 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/505?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/505?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [582c4b3...915e770](https://codecov.io/gh/apache/apisix-ingress-controller/pull/505?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Yiyiyimu opened a new pull request #505: ci: cancel duplicate workflow to reduce CI queue time
Yiyiyimu opened a new pull request #505: URL: https://github.com/apache/apisix-ingress-controller/pull/505 Signed-off-by: yiyiyimu The Github Actions - cancel workflow have already been applied in apisix and dashboard, and it works well, so try to also import it here. > We always wait for CI queue time, and we always trying to reduce waiting time. Here is another method to achieve it. > > The method is that whenever a new commit added to PR, the previous running CI could be canceled since it is of no use. This could be achieved by using Github API, find the workflow on the same branch but with different SHA. And we could achieve this with [potiuk/cancel-workflow-runs](https://github.com/potiuk/cancel-workflow-runs) which is also [used in Apache Airflow](https://github.com/apache/airflow/blob/master/.github/workflows/build-images-workflow-run.yml). > > To bypass the limit of third party Actions, [the recommendation provided by Apache Infra](https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status#GitHubActionsstatus-Security) is to use submodules. > > Since the "cancel" workflow could only be triggered after merged, so I could not test it in this PR. Thus I duplicate the same situation in my own repo, and it works as expect. See https://github.com/Yiyiyimu/GithubActionsTest/pull/5 you could find previous running workflow got cancelled when a new one coming in. Also see https://github.com/Yiyiyimu/GithubActionsTest/runs/2344066993?check_suite_focus=true for cancellation detail.check_suite_focus=true for cancellation detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel opened a new issue #504: request help: Add .dockerignore to avoid unwanted cache miss
lingsamuel opened a new issue #504: URL: https://github.com/apache/apisix-ingress-controller/issues/504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #15: test: add test cases about filter
tzssangglass opened a new pull request #15: URL: https://github.com/apache/apisix-java-plugin-runner/pull/15 1. add test cases about filter 2. fix bug about encode filter chain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on issue #4157: bug: After installing the Apisix on ARM-based System,but it can't works properly.
Yiyiyimu commented on issue #4157: URL: https://github.com/apache/apisix/issues/4157#issuecomment-848952590 Successfully installed APISIX on AWS graviton2 (arm64) successfully but failed to find Kylin cloud server to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu merged pull request #4309: docs: update `make lint` output
Yiyiyimu merged pull request #4309: URL: https://github.com/apache/apisix/pull/4309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (f7c6f4f -> 3ccc5b8)
This is an automated email from the ASF dual-hosted git repository. shuyangw pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from f7c6f4f docs: fix typo (#4305) add 3ccc5b8 docs: update `make lint` output (#4309) No new revisions were added by this update. Summary of changes: CONTRIBUTING.md | 46 +- 1 file changed, 17 insertions(+), 29 deletions(-)
[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link
iamayushdas commented on pull request #328: URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848943324 > The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help I would be a pleasure to help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on issue #177: dashboard image on docker hub have wrong tag
Yiyiyimu commented on issue #177: URL: https://github.com/apache/apisix-docker/issues/177#issuecomment-848942169 @gxthrj maybe we need to rebuild `latest` tag to `2.6` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #328: docs: fixed kubernetes service api broken link
Yiyiyimu commented on pull request #328: URL: https://github.com/apache/apisix-website/pull/328#issuecomment-848941148 The etcd link should be https://github.com/etcd-io/website/blob/main/content/en/docs/next/learning/why.md, but I also failed to locate where is this link. Hi @iamayushdas could you offer some help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value
netlify[bot] edited a comment on pull request #1921: URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539 :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready! :hammer: Explore the source changes: 67ea11b7bec72c6efd8fef2bed893e05a9b32b0e :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60ae7865cb6a31000812d590](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae7865cb6a31000812d590?utm_source=github_campaign=bot_dl) :sunglasses: Browse the preview: [https://deploy-preview-1921--apisix-dashboard.netlify.app](https://deploy-preview-1921--apisix-dashboard.netlify.app?utm_source=github_campaign=bot_dp) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value
netlify[bot] edited a comment on pull request #1921: URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: 67ea11b7bec72c6efd8fef2bed893e05a9b32b0e :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60ae7865cb6a31000812d590](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae7865cb6a31000812d590?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1921: fix: regex & omit vars when no value
codecov-commenter commented on pull request #1921: URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848921691 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1921](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d56b173) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/91ad26be6dcda1813419b51bc9d0203c86a1d5d0?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (91ad26b) will **decrease** coverage by `2.93%`. > The diff coverage is `100.00%`. > :exclamation: Current head d56b173 differs from pull request most recent head fd32623. Consider uploading reports for the commit fd32623 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1921 +/- ## == - Coverage 67.00% 64.07% -2.94% == Files 169 122 -47 Lines6314 3112-3202 Branches 745 748 +3 == - Hits 4231 1994-2237 + Misses 1832 1118 -714 + Partials 2510 -251 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `64.07% <100.00%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1921?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | `66.66% <ø> (ø)` | | | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <ø> (ø)` | | | [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4) | `33.33% <ø> (ø)` | | | [...pages/Route/components/Step1/RequestConfigView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1JlcXVlc3RDb25maWdWaWV3LnRzeA==) | `81.48% <ø> (ø)` | | | [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | `72.35% <100.00%> (-0.11%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1921/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | | |
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1921: fix: regex & omit vars when no value
iamayushdas commented on pull request #1921: URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848918202 @guoqqqi may i know the problem here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] slene commented on pull request #453: fix: panic of start leading. sync ingress failed when apisix not start.
slene commented on pull request #453: URL: https://github.com/apache/apisix-ingress-controller/pull/453#issuecomment-848905195 @tokers Bad news. You performed an incorrect git operation after force push. So my collaboration record is lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4314: bug: plugin hot reloading does not take effect
Firstsawyou commented on issue #4314: URL: https://github.com/apache/apisix/issues/4314#issuecomment-848899640 @spacewander I think the code here should be removed so that it can support hot loading after modifying the plugin code. right? https://github.com/apache/apisix/blob/master/apisix/plugin.lua#L167-L171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4313: feat: nacos discovery support namespace
Firstsawyou commented on a change in pull request #4313:
URL: https://github.com/apache/apisix/pull/4313#discussion_r639826338
##
File path: t/discovery/nacos.t
##
@@ -251,3 +251,134 @@ discovery:
]
--- no_error_log
[error]
+
+
+
+=== TEST 8: get APISIX-NACOS info from NACOS - no auth with namespace
+--- yaml_config eval: $::yaml_config
+--- apisix_yaml
+routes:
+ -
+uri: /hello
+upstream:
+ service_name: APISIX-NACOS
+ discovery_type: nacos
+ type: roundrobin
+ nacos_namespace_id: test_ns
+#END
+--- pipelined_requests eval
+[
+"GET /hello",
+"GET /hello",
+]
+--- response_body_like eval
+[
+qr/server [1-2]/,
+qr/server [1-2]/,
+]
+--- no_error_log
+[error, error]
Review comment:
```suggestion
[error]
```
##
File path: apisix/discovery/nacos.lua
##
@@ -254,10 +264,10 @@ local function fetch_full_registry(premature)
applications = up_apps
return
end
-
local data, err
-for _, service_name in ipairs(infos) do
-data, err = get_url(base_uri, instance_list_path .. service_name ..
token_param)
+for _, service_info in ipairs(infos) do
+local namespace_param =
get_namespace_param(service_info.nacos_namespace_id);
+data, err = get_url(base_uri, instance_list_path ..
service_info.service_name .. token_param .. namespace_param)
Review comment:
```suggestion
data, err = get_url(base_uri, instance_list_path ..
service_info.service_name ..
token_param .. namespace_param)
```
##
File path: t/discovery/nacos.t
##
@@ -251,3 +251,134 @@ discovery:
]
--- no_error_log
[error]
+
+
+
+=== TEST 8: get APISIX-NACOS info from NACOS - no auth with namespace
+--- yaml_config eval: $::yaml_config
+--- apisix_yaml
+routes:
+ -
+uri: /hello
+upstream:
+ service_name: APISIX-NACOS
+ discovery_type: nacos
+ type: roundrobin
+ nacos_namespace_id: test_ns
+#END
+--- pipelined_requests eval
+[
+"GET /hello",
+"GET /hello",
+]
+--- response_body_like eval
+[
+qr/server [1-2]/,
+qr/server [1-2]/,
+]
+--- no_error_log
+[error, error]
+
+
+
+=== TEST 9: get APISIX-NACOS info from NACOS - configured in services with
namespace
+--- yaml_config eval: $::yaml_config
+--- apisix_yaml
+routes:
+ -
+uri: /hello
+service_id: 1
+services:
+ -
+id: 1
+upstream:
+ service_name: APISIX-NACOS
+ discovery_type: nacos
+ type: roundrobin
+ nacos_namespace_id: test_ns
+#END
+--- pipelined_requests eval
+[
+"GET /hello",
+"GET /hello",
+]
+--- response_body_like eval
+[
+qr/server [1-2]/,
+qr/server [1-2]/,
+]
+--- no_error_log
+[error]
+
+
+
+=== TEST 10: get APISIX-NACOS info from NACOS - configured in upstreams + etcd
with namespace
+--- extra_yaml_config
+discovery:
+ nacos:
+ host:
+- "http://127.0.0.1:8858;
+ fetch_interval: 1
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/upstreams/1',
+ ngx.HTTP_PUT,
+ [[{
+"service_name": "APISIX-NACOS",
+"discovery_type": "nacos",
+"type": "roundrobin",
+"nacos_namespace_id": "test_ns"
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+ngx.say(body)
+return
+end
+
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"uri": "/hello",
+"upstream_id": 1
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 11: hit with namespace
+--- extra_yaml_config
+discovery:
+ nacos:
+ host:
+- "http://127.0.0.1:8858;
+ fetch_interval: 1
+--- pipelined_requests eval
+[
+"GET /hello",
+"GET /hello",
+]
+--- response_body_like eval
+[
+qr/server [1-2]/,
+qr/server [1-2]/,
+]
+--- no_error_log
+[error]
Review comment:
A blank line is required at the end of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value
netlify[bot] edited a comment on pull request #1921: URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539 :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready! :hammer: Explore the source changes: fd32623f3230ecf2a35887f732e6f736fbe5212c :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60ae6b174338020008865844](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae6b174338020008865844?utm_source=github_campaign=bot_dl) :sunglasses: Browse the preview: [https://deploy-preview-1921--apisix-dashboard.netlify.app](https://deploy-preview-1921--apisix-dashboard.netlify.app?utm_source=github_campaign=bot_dp) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1921: fix: regex & omit vars when no value
iamayushdas edited a comment on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848876379
> It is better to add this assertion after line 222 to ensure that the vars
field disappears.
>
> ```
> cy.contains('vars').should('not.exist');
> ```
added , thanks for nice suggestion @guoqqqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1921: fix: regex & omit vars when no value
iamayushdas commented on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848876379
> It is better to add this assertion after line 222 to ensure that the vars
field disappears.
>
> ```
> cy.contains('vars').should('not.exist');
> ```
added , thanks for nice suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas removed a comment on pull request #1921: fix: regex & omit vars when no value
iamayushdas removed a comment on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848855816
>
> It is better to add this assertion after line 222 to ensure that the vars
field disappears.
>
> ```
> cy.contains('vars').should('not.exist');
> ```
i thought its not necessary, will add this line too , thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1921: fix: regex & omit vars when no value
netlify[bot] edited a comment on pull request #1921: URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848638539 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: fd32623f3230ecf2a35887f732e6f736fbe5212c :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60ae6b174338020008865844](https://app.netlify.com/sites/apisix-dashboard/deploys/60ae6b174338020008865844?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1921: fix: regex & omit vars when no value
iamayushdas commented on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848855816
>
> It is better to add this assertion after line 222 to ensure that the vars
field disappears.
>
> ```
> cy.contains('vars').should('not.exist');
> ```
i thought its not necessary, will add this line too , thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
