[GitHub] [apisix-ingress-controller] geffzhang commented on issue #569: request help: apisix ingress controller with Dapr

[GitBox]

geffzhang commented on issue #569:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/569#issuecomment-937619712


   Find the cause, start normally


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] guoqqqi opened a new pull request #647: fix: homepage Events Article links

[GitBox]

guoqqqi opened a new pull request #647:
URL: https://github.com/apache/apisix-website/pull/647


   1. Fixed invalid link to Events article on home page
   
![image](https://user-images.githubusercontent.com/72343596/136363581-0751ab51-0a02-4d71-bc65-3df61a5607ff.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] github-actions[bot] commented on pull request #4471: feat: Add access_log config item to config.yaml

[GitBox]

github-actions[bot] commented on pull request #4471:
URL: https://github.com/apache/apisix/pull/4471#issuecomment-937644354


   This pull request has been marked as stale due to 60 days of inactivity. It 
will be closed in 4 weeks if no further activity occurs. If you think that's 
incorrect or this pull request should instead be reviewed, please simply write 
any comment. Even if closed, you can still revive the PR at any time or discuss 
it on the d...@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] github-actions[bot] commented on pull request #4498: docs: added /apisix/admin/plugins/reload into admin-api.md

[GitBox]

github-actions[bot] commented on pull request #4498:
URL: https://github.com/apache/apisix/pull/4498#issuecomment-937644377


   This pull request has been marked as stale due to 60 days of inactivity. It 
will be closed in 4 weeks if no further activity occurs. If you think that's 
incorrect or this pull request should instead be reviewed, please simply write 
any comment. Even if closed, you can still revive the PR at any time or discuss 
it on the d...@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2054: fix: perform pid lookup for existing pid file

[GitBox]

codecov-commenter edited a comment on pull request #2054:
URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-895490584


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2054](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (ba38807) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `17.23%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2054   +/-   ##
   ===
   - Coverage   69.55%   52.31%   -17.24% 
   ===
 Files 187   38  -149 
 Lines7137 2957 -4180 
 Branches  8230  -823 
   ===
   - Hits 4964 1547 -3417 
   + Misses   1886 1216  -670 
   + Partials  287  194   -93 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `52.31% <0.00%> (-0.43%)` | :arrow_down: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==)
 | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
   | 
[api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.31%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2054: fix: perform pid lookup for existing pid file

[GitBox]

codecov-commenter edited a comment on pull request #2054:
URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-895490584


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2054](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (ba38807) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `2.71%`.
   > The diff coverage is `18.51%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2054  +/-   ##
   ==
   - Coverage   69.55%   66.84%   -2.72% 
   ==
 Files 187   60 -127 
 Lines7137 3812-3325 
 Branches  8230 -823 
   ==
   - Hits 4964 2548-2416 
   + Misses   1886  978 -908 
   + Partials  287  286   -1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `49.00% <18.51%> (+0.24%)` | :arrow_up: |
   | backend-unit-test | `52.31% <0.00%> (-0.43%)` | :arrow_down: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==)
 | `32.55% <18.51%> (-10.30%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `32.11% <0.00%> (-35.41%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `68.18% <0.00%> (-22.73%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `68.11% <0.00%> (-17.40%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `60.00% <0.00%> (-13.00%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `78.37% <0.00%> (-8.11%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&ut

[GitHub] [apisix] spacewander commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

spacewander commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724087432



##
File path: apisix/admin/init.lua
##
@@ -278,12 +278,13 @@ local function post_reload_plugins()
 local ok, err = check_token(api_ctx)
 if not ok then
 core.log.warn("failed to check token: ", err)
-core.response.exit(401)
+core.response.exit(401, {error_msg="failed to check token"})
 end
 
 local success, err = events.post(reload_event, get_method(), ngx_time())
 if not success then
 core.response.exit(503, err)
+

Review comment:
   Extra blank line?

##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",
   "route")
-core.response.exit(400)
+core.response.exit(400, {error_msg="stream mode is disabled, can not " 
..

Review comment:
   "stream mode is disabled, can not add any stream route"

##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",

Review comment:
   Let's fix the grammar here in the next PR

##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",
   "route")
-core.response.exit(400)
+core.response.exit(400, {error_msg="stream mode is disabled, can not " 
..
+   "to add stream"})
 end
 
 local ok, err = check_token(api_ctx)
 if not ok then
-core.log.warn("failed to check token: ", err)

Review comment:
   Let's keep the original error log




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander opened a new pull request #5175: fix: pass correct host header to health checker target nodes

[GitBox]

spacewander opened a new pull request #5175:
URL: https://github.com/apache/apisix/pull/5175


   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] valiner opened a new issue #149: 关于helm仓库 gateway 和 dashboard不兼容的情况

[GitBox]

valiner opened a new issue #149:
URL: https://github.com/apache/apisix-helm-chart/issues/149


   
![image](https://user-images.githubusercontent.com/17878390/136377096-f7757520-335a-4243-a85a-64d081e7d111.png)
   
   目前最新gateway app版本2.7
   dashboard 2.8 ,dashboard新建路由会有字段keepalive_pool,但是2.8gateway没有处理，导致一直报错。
   
   gateway app版本2.6
   dashboard 2.7
   没有问题
   
   这个问题搞了我半天！！！


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] valiner commented on issue #149: 关于helm仓库 gateway 和 dashboard不兼容的情况

[GitBox]

valiner commented on issue #149:
URL: 
https://github.com/apache/apisix-helm-chart/issues/149#issuecomment-937713097


   报错  err:additional properties forbidden, found keepalive_pool


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] valiner removed a comment on issue #149: 关于helm仓库 gateway 和 dashboard不兼容的情况

[GitBox]

valiner removed a comment on issue #149:
URL: 
https://github.com/apache/apisix-helm-chart/issues/149#issuecomment-937713097


   报错  err:additional properties forbidden, found keepalive_pool


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

juzhiyuan commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724107103



##
File path: apisix/admin/init.lua
##
@@ -215,12 +215,12 @@ local function run_stream()
 
 local resource = resources[seg_res]
 if not resource then
-core.response.exit(404)
+core.response.exit(404, {error_msg="not found"})
 end
 
 local method = str_lower(get_method())
 if not resource[method] then
-core.response.exit(404)
+core.response.exit(404, {error_msg="not found"})

Review comment:
   according to 
https://github.com/apache/apisix/blob/master/CODE_STYLE.md#space , I would 
prefer using `xx = xx`

##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",
   "route")
-core.response.exit(400)
+core.response.exit(400, {error_msg="stream mode is disabled, can not " 
..

Review comment:
   Would better use `routes` instead of `route`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3894: feat: Add ldap-auth plugin

[GitBox]

spacewander commented on a change in pull request #3894:
URL: https://github.com/apache/apisix/pull/3894#discussion_r724106848



##
File path: apisix/plugins/ldap-auth.lua
##
@@ -0,0 +1,160 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local ngx = ngx
+local ngx_re = require("ngx.re")
+local ipairs = ipairs
+local consumer_mod = require("apisix.consumer")
+local lualdap = require("lualdap")
+
+local lrucache = core.lrucache.new({
+ttl = 300, count = 512
+})
+
+local schema = {
+type = "object",
+title = "work with route or service object",
+properties = {
+base_dn = { type = "string" },
+ldap_uri = { type = "string" },
+use_tls = { type = "boolean" },
+uid = { type = "string" }
+},
+required = {"base_dn","ldap_uri"},
+}
+
+local consumer_schema = {
+type = "object",
+title = "work with consumer object",
+properties = {
+user_dn = { type = "string" },
+},
+required = {"user_dn"},
+}
+
+local plugin_name = "ldap-auth"
+
+local _M = {
+version = 0.1,
+priority = 2540,
+type = 'auth',
+name = plugin_name,
+schema = schema,
+consumer_schema = consumer_schema
+}
+
+function _M.check_schema(conf, schema_type)
+local ok, err
+if schema_type == core.schema.TYPE_CONSUMER then
+ok, err = core.schema.check(consumer_schema, conf)
+else
+ok, err = core.schema.check(schema, conf)
+end
+
+return ok, err
+end
+
+local create_consumer_cache
+do
+local consumer_names = {}
+
+function create_consumer_cache(consumers)
+core.table.clear(consumer_names)
+
+for _, consumer in ipairs(consumers.nodes) do
+core.log.info("consumer node: ", core.json.delay_encode(consumer))
+consumer_names[consumer.auth_conf.user_dn] = consumer
+end
+
+return consumer_names
+end
+
+end -- do
+
+local function extract_auth_header(authorization)
+local obj = { username = "", password = "" }
+
+local m, err = ngx.re.match(authorization, "Basic\\s(.+)", "jo")
+if err then
+-- error authorization
+return nil, err
+end
+
+local decoded, err = ngx.decode_base64(m[1])
+
+if err then
+return nil, "failed to decode authentication header"
+end
+
+local res
+res, err = ngx_re.split(decoded, ":")
+if err then
+return nil, "split authorization err:" .. err
+end
+if #res < 2 then
+return nil, "split authorization length is invalid"

Review comment:
   ```suggestion
   return nil, "split authorization err: invalid decoded data: " .. 
decoded
   ```

##
File path: apisix/plugins/ldap-auth.lua
##
@@ -0,0 +1,160 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local ngx = ngx
+local ngx_re = require("ngx.re")
+local ipairs = ipairs
+local consumer_mod = require("apisix.consumer")
+local lualdap = require("lualdap")
+
+local lrucache = core.lrucache.new({
+ttl = 300, count = 512
+})
+
+local schema = {
+type = "object",
+title = "work with route or service object",
+properties = {
+base_dn = { type = "string" },
+ldap_uri = { type = "string" },
+use_tls = { type = "boolean" },
+uid = { type = "string" }
+},
+required = {"base_dn","ldap_uri"},
+}
+
+local consumer_schema = {
+type = 

[GitHub] [apisix] elvis-cai commented on pull request #5163: fix: pass correct host header to health checker target nodes

[GitBox]

elvis-cai commented on pull request #5163:
URL: https://github.com/apache/apisix/pull/5163#issuecomment-937736847


   thanks for fixing the issue I raised in 
https://github.com/apache/apisix/issues/4906, 
   did a quick test with this change, still using the same example route config 
from the issue,  unfortunately, health check doesn't work as expected, adding 
some debug info, I found 
https://github.com/apache/apisix/pull/5163/files#diff-9af33577e041ece8fef32d8f8193f46eac83dab9e947a2cc940f36b83d5150e8R115
 `hostheader`  is always "httpbin.org",  no matter upstream node domain is 
`apple.internal.com` or `banana.internal.com`.
   another test I did is still the same line 
https://github.com/apache/apisix/pull/5163/files#diff-9af33577e041ece8fef32d8f8193f46eac83dab9e947a2cc940f36b83d5150e8R115,
 use `node.domain` could output the correct host header for health checking.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #5163: fix: pass correct host header to health checker target nodes

[GitBox]

spacewander commented on pull request #5163:
URL: https://github.com/apache/apisix/pull/5163#issuecomment-937738584


   @elvis-cai 
   What about this one?
   https://github.com/apache/apisix/pull/5175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #149: 关于helm仓库 gateway 和 dashboard不兼容的情况

[GitBox]

tao12345666333 commented on issue #149:
URL: 
https://github.com/apache/apisix-helm-chart/issues/149#issuecomment-937742182


   Due to historical reasons, the Gateway, Dashboard and Ingress controller in 
this project are all independently maintained.
   Currently we are gradually unifying its versions and will ensure that all 
components in the same Helm chart version are compatible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #5163: fix: pass correct host header to health checker target nodes

[GitBox]

spacewander commented on a change in pull request #5163:
URL: https://github.com/apache/apisix/pull/5163#discussion_r724128784



##
File path: apisix/upstream.lua
##
@@ -293,7 +293,7 @@ function _M.set_by_route(route, api_ctx)
 end
 
 if nodes_count > 1 then
-local checker = fetch_healthchecker(up_conf)
+local checker = fetch_healthchecker(up_conf, api_ctx.var.host)

Review comment:
   I am sorry, the solution I gave is incorrect. I tried to make a new one 
here: https://github.com/apache/apisix/pull/5175




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] tao12345666333 commented on a change in pull request #231: feat: Add prometheus/grafana into example

[GitBox]

tao12345666333 commented on a change in pull request #231:
URL: https://github.com/apache/apisix-docker/pull/231#discussion_r724132755



##
File path: example/prometheus_conf/prometheus.yml
##
@@ -0,0 +1,23 @@
+global:
+  scrape_interval: 1s # By default, scrape targets every 15 seconds.
+
+  # Attach these labels to any time series or alerts when communicating with
+  # external systems (federation, remote storage, Alertmanager).
+  external_labels:
+monitor: "codelab-monitor"

Review comment:
   A small comment, why add this label




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #647: fix: homepage Events Article links

[GitBox]

1502shivam-singh commented on a change in pull request #647:
URL: https://github.com/apache/apisix-website/pull/647#discussion_r724136424



##
File path: website/src/pages/sections/newsSection.jsx
##
@@ -11,7 +11,7 @@ const NewsSection = () => {
 .map((event) => {
 const publishTime = event.fileName.slice(0, 10);
 const splittedFileName = event.fileName.split("-");
-const url = `/events/${splittedFileName
+const url = `/blog/${splittedFileName

Review comment:
   You sure only doing this will work ?
   For instance -
   https://apisix.apache.org/events/2021/09/15/weekly-report (404)
   
   After change `events` -> `blog`
   
   https://apisix.apache.org/blog/2021/09/15/weekly-report (still 404) 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #647: fix: homepage Events Article links

[GitBox]

1502shivam-singh commented on a change in pull request #647:
URL: https://github.com/apache/apisix-website/pull/647#discussion_r724140001



##
File path: website/src/pages/sections/newsSection.jsx
##
@@ -11,7 +11,7 @@ const NewsSection = () => {
 .map((event) => {
 const publishTime = event.fileName.slice(0, 10);
 const splittedFileName = event.fileName.split("-");
-const url = `/events/${splittedFileName
+const url = `/blog/${splittedFileName

Review comment:
   Or are we planning to add all these articles under blog section ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] imjoey commented on a change in pull request #231: feat: Add prometheus/grafana into example

[GitBox]

imjoey commented on a change in pull request #231:
URL: https://github.com/apache/apisix-docker/pull/231#discussion_r724160377



##
File path: example/prometheus_conf/prometheus.yml
##
@@ -0,0 +1,23 @@
+global:
+  scrape_interval: 1s # By default, scrape targets every 15 seconds.
+
+  # Attach these labels to any time series or alerts when communicating with
+  # external systems (federation, remote storage, Alertmanager).
+  external_labels:
+monitor: "codelab-monitor"

Review comment:
   @tao12345666333 honestly speaking, I've no idea, even the Prometheus 
official does not provide any information about this. While it's so widely used 
and included in each Prometheus configuration file, seeming like a conventional 
label. Any insight abou this? Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander opened a new pull request #5176: test: make t/plugin/traffic-split.t stable

[GitBox]

spacewander opened a new pull request #5176:
URL: https://github.com/apache/apisix/pull/5176


   See https://github.com/apache/apisix/runs/3826870646
   
   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] tao12345666333 commented on a change in pull request #231: feat: Add prometheus/grafana into example

[GitBox]

tao12345666333 commented on a change in pull request #231:
URL: https://github.com/apache/apisix-docker/pull/231#discussion_r724179821



##
File path: example/prometheus_conf/prometheus.yml
##
@@ -0,0 +1,23 @@
+global:
+  scrape_interval: 1s # By default, scrape targets every 15 seconds.
+
+  # Attach these labels to any time series or alerts when communicating with
+  # external systems (federation, remote storage, Alertmanager).
+  external_labels:
+monitor: "codelab-monitor"

Review comment:
   In fact, this label can be considered to be used to mark the current 
prometheus instance. Here we can leave it unset, or set a more meaningful label 
for it. like this:
   
   ```suggestion
   stack: "apisix"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] jp-gouin commented on pull request #3894: feat: Add ldap-auth plugin

[GitBox]

jp-gouin commented on pull request #3894:
URL: https://github.com/apache/apisix/pull/3894#issuecomment-937814676


   @membphis , the chaos mesh test is using the apisix-docker project to build 
apisix : 
   
https://github.com/apache/apisix/blob/aa375ab2c80b748f00cb6fbc92829b6c78bd89fb/.github/workflows/chaos.yml#L41
   
   I submitted a PR to add the library in the apisix-docker 
https://github.com/apache/apisix-docker/pull/222 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] imjoey commented on a change in pull request #231: feat: Add prometheus/grafana into example

[GitBox]

imjoey commented on a change in pull request #231:
URL: https://github.com/apache/apisix-docker/pull/231#discussion_r724219483



##
File path: example/prometheus_conf/prometheus.yml
##
@@ -0,0 +1,23 @@
+global:
+  scrape_interval: 1s # By default, scrape targets every 15 seconds.
+
+  # Attach these labels to any time series or alerts when communicating with
+  # external systems (federation, remote storage, Alertmanager).
+  external_labels:
+monitor: "codelab-monitor"

Review comment:
   @tao12345666333 wow, thank you for this awesome explanation. I would 
prefer to update the label as you suggested to mark this Prometheus instance as 
part of `apisix` stack. Thanks again for your help.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-docker] branch master updated: feat: Add prometheus/grafana into example (#231)

[majunjie]

This is an automated email from the ASF dual-hosted git repository.

majunjie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-docker.git


The following commit(s) were added to refs/heads/master by this push:
 new 8ece16f  feat: Add prometheus/grafana into example (#231)
8ece16f is described below

commit 8ece16fa3316ea2d515854a618a97f55bfa776bd
Author: Joey 
AuthorDate: Thu Oct 7 22:32:07 2021 +0800

feat: Add prometheus/grafana into example (#231)

Co-authored-by: Jintao Zhang 
---
 example/docker-compose.yml |   22 +
 example/grafana_conf/config/grafana.ini|  756 +
 .../dashboards/apisix-grafana-dashboard.json   | 1730 
 .../grafana_conf/provisioning/dashboards/all.yaml  |   27 +
 .../grafana_conf/provisioning/datasources/all.yaml |   25 +
 example/prometheus_conf/prometheus.yml |   23 +
 6 files changed, 2583 insertions(+)

diff --git a/example/docker-compose.yml b/example/docker-compose.yml
index 1c5b3fd..4068dd4 100644
--- a/example/docker-compose.yml
+++ b/example/docker-compose.yml
@@ -66,6 +66,28 @@ services:
 networks:
   apisix:
 
+  prometheus:
+image: prom/prometheus:v2.25.0
+restart: always
+volumes:
+  - ./prometheus_conf/prometheus.yml:/etc/prometheus/prometheus.yml
+ports:
+  - "9090:9090"
+networks:
+  apisix:
+
+  grafana:
+image: grafana/grafana:7.3.7
+restart: always
+ports:
+  - "3000:3000"
+volumes:
+  - "./grafana_conf/provisioning:/etc/grafana/provisioning"
+  - "./grafana_conf/dashboards:/var/lib/grafana/dashboards"
+  - "./grafana_conf/config/grafana.ini:/etc/grafana/grafana.ini"
+networks:
+  apisix:
+
 networks:
   apisix:
 driver: bridge
diff --git a/example/grafana_conf/config/grafana.ini 
b/example/grafana_conf/config/grafana.ini
new file mode 100644
index 000..cb6a737
--- /dev/null
+++ b/example/grafana_conf/config/grafana.ini
@@ -0,0 +1,756 @@
+# Grafana Configuration Example #
+#
+# Everything has defaults so you only need to uncomment things you want to
+# change
+
+# possible values : production, development
+;app_mode = production
+
+# instance name, defaults to HOSTNAME environment variable value or hostname 
if HOSTNAME var is empty
+;instance_name = ${HOSTNAME}
+
+ Paths 
+[paths]
+# Path to where grafana can store temp files, sessions, and the sqlite3 db (if 
that is used)
+;data = /var/lib/grafana
+
+# Temporary files in `data` directory older than given duration will be removed
+;temp_data_lifetime = 24h
+
+# Directory where grafana can store logs
+;logs = /var/log/grafana
+
+# Directory where grafana will automatically scan and look for plugins
+;plugins = /var/lib/grafana/plugins
+
+# folder that contains provisioning config files that grafana will apply on 
startup and while running.
+;provisioning = conf/provisioning
+
+ Server 

+[server]
+# Protocol (http, https, h2, socket)
+;protocol = http
+
+# The ip address to bind to, empty will bind to all interfaces
+;http_addr =
+
+# The http port  to use
+;http_port = 3000
+
+# The public facing domain name used to access grafana from a browser
+;domain = localhost
+
+# Redirect to correct domain if host header does not match domain
+# Prevents DNS rebinding attacks
+;enforce_domain = false
+
+# The full public facing url you use in browser, used for redirects and emails
+# If you use reverse proxy and sub path specify full url (with sub path)
+;root_url = %(protocol)s://%(domain)s:%(http_port)s/
+
+# Serve Grafana from subpath specified in `root_url` setting. By default it is 
set to `false` for compatibility reasons.
+;serve_from_sub_path = false
+
+# Log web requests
+;router_logging = false
+
+# the path relative working path
+;static_root_path = public
+
+# enable gzip
+;enable_gzip = false
+
+# https certs & key file
+;cert_file =
+;cert_key =
+
+# Unix socket path
+;socket =
+
+ Database 

+[database]
+# You can configure the database connection by specifying type, host, name, 
user and password
+# as separate properties or as on string using the url properties.
+
+# Either "mysql", "postgres" or "sqlite3", it's your choice
+;type = sqlite3
+;host = 127.0.0.1:3306
+;name = grafana
+;user = root
+# If the password contains # or ; you have to wrap it with triple quotes. Ex 
"""#password;"""
+;password =
+
+# Use either URL or the previous fields to configure the database
+# Example: mysql://user:secret@host:port/database
+;url =
+
+# For "postgres" only, either "disable", "require" or "verify-full"
+;ssl_mode = disable
+
+;ca_cert_path =
+;client_key_path =
+;client_cert_path =
+;server_cert_name =
+
+# For "sqlite3" only, path relative

[GitHub] [apisix-docker] imjoey merged pull request #231: feat: Add prometheus/grafana into example

[GitBox]

imjoey merged pull request #231:
URL: https://github.com/apache/apisix-docker/pull/231


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] rmGFW closed issue #5172: request help: 404 Route Not Found

[GitBox]

rmGFW closed issue #5172:
URL: https://github.com/apache/apisix/issues/5172


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] rmGFW opened a new issue #5177: request help: Doesn't need configuration

[GitBox]

rmGFW opened a new issue #5177:
URL: https://github.com/apache/apisix/issues/5177


   ### Issue description
   
   
![image](https://user-images.githubusercontent.com/66858140/136421552-7614711d-eabf-4ff7-9560-5fad865d3e2d.png)
   
   i create a router . and i want add a basic-auth plugin, but it shows Doesn't 
need configuration
   
   ### Environment
   
   - apisix version (cmd: `apisix version`): 2.10.0
   - OS (cmd: `uname -a`): alpine image 
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have: 2.8
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] rmGFW closed issue #5177: request help: Doesn't need configuration

[GitBox]

rmGFW closed issue #5177:
URL: https://github.com/apache/apisix/issues/5177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] elvis-cai commented on pull request #5163: fix: pass correct host header to health checker target nodes

[GitBox]

elvis-cai commented on pull request #5163:
URL: https://github.com/apache/apisix/pull/5163#issuecomment-937736847


   thanks for fixing the issue I raised in 
https://github.com/apache/apisix/issues/4906, 
   did a quick test with this change, still using the same example route config 
from the issue,  unfortunately, health check doesn't work as expected, adding 
some debug info, I found 
https://github.com/apache/apisix/pull/5163/files#diff-9af33577e041ece8fef32d8f8193f46eac83dab9e947a2cc940f36b83d5150e8R115
 `hostheader`  is always "httpbin.org",  no matter upstream node domain is 
`apple.internal.com` or `banana.internal.com`.
   another test I did is still the same line 
https://github.com/apache/apisix/pull/5163/files#diff-9af33577e041ece8fef32d8f8193f46eac83dab9e947a2cc940f36b83d5150e8R115,
 use `node.domain` could output the correct host header for health checking.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #700: ApisixRoute route still work after deleting AR source

[GitBox]

tokers commented on issue #700:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/700#issuecomment-937482347


   OK, so the results of curl are correct but the page shown from the browser 
is wrong? I didn't understand the specific meaning of diagram 2 with its lines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] geffzhang commented on issue #569: request help: apisix ingress controller with Dapr

[GitBox]

geffzhang commented on issue #569:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/569#issuecomment-937619712


   Find the cause, start normally


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #3894: feat: Add ldap-auth plugin

[GitBox]

membphis commented on pull request #3894:
URL: https://github.com/apache/apisix/pull/3894#issuecomment-937476694






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] valiner removed a comment on issue #149: 关于helm仓库 gateway 和 dashboard不兼容的情况

[GitBox]

valiner removed a comment on issue #149:
URL: 
https://github.com/apache/apisix-helm-chart/issues/149#issuecomment-937713097


   报错  err:additional properties forbidden, found keepalive_pool


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on issue #582: Support PR preview

[GitBox]

juzhiyuan commented on issue #582:
URL: https://github.com/apache/apisix-website/issues/582#issuecomment-937384493


   https://docusaurus.io/docs/deployment#deploying-to-hostman


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] jp-gouin commented on pull request #3894: feat: Add ldap-auth plugin

[GitBox]

jp-gouin commented on pull request #3894:
URL: https://github.com/apache/apisix/pull/3894#issuecomment-937814676


   @membphis , the chaos mesh test is using the apisix-docker project to build 
apisix : 
   
https://github.com/apache/apisix/blob/aa375ab2c80b748f00cb6fbc92829b6c78bd89fb/.github/workflows/chaos.yml#L41
   
   I submitted a PR to add the library in the apisix-docker 
https://github.com/apache/apisix-docker/pull/222 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #5163: fix: pass correct host header to health checker target nodes

[GitBox]

spacewander commented on pull request #5163:
URL: https://github.com/apache/apisix/pull/5163#issuecomment-937738584


   @elvis-cai 
   What about this one?
   https://github.com/apache/apisix/pull/5175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander edited a comment on issue #5149: request help: use name instead of id in grafana dashboard

[GitBox]

spacewander edited a comment on issue #5149:
URL: https://github.com/apache/apisix/issues/5149#issuecomment-937427367


   No. It will be a break change. We can't change it in 2.x at least.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #5171: feat: enhance the verification of the configuration

[GitBox]

spacewander commented on a change in pull request #5171:
URL: https://github.com/apache/apisix/pull/5171#discussion_r723822935



##
File path: apisix/cli/ops.lua
##
@@ -891,6 +891,44 @@ local function cleanup()
 end
 
 
+local function test(env, backup_ngx_conf)
+-- backup nginx.conf
+local ngx_conf_path = env.apisix_home .. "/conf/nginx.conf"
+local ngx_conf_exist = io_open(ngx_conf_path)
+if ngx_conf_exist then
+local err = util.execute_cmd_with_error("mv " .. ngx_conf_path .. " "

Review comment:
   We can use `os.rename`.

##
File path: apisix/cli/ops.lua
##
@@ -891,6 +891,44 @@ local function cleanup()
 end
 
 
+local function test(env, backup_ngx_conf)
+-- backup nginx.conf
+local ngx_conf_path = env.apisix_home .. "/conf/nginx.conf"
+local ngx_conf_exist = io_open(ngx_conf_path)

Review comment:
   We can use `util.is_file_exist`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] valiner commented on issue #149: 关于helm仓库 gateway 和 dashboard不兼容的情况

[GitBox]

valiner commented on issue #149:
URL: 
https://github.com/apache/apisix-helm-chart/issues/149#issuecomment-937713097


   报错  err:additional properties forbidden, found keepalive_pool


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2054: fix: perform pid lookup for existing pid file

[GitBox]

codecov-commenter edited a comment on pull request #2054:
URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-895490584






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] imjoey commented on a change in pull request #231: feat: Add prometheus/grafana into example

[GitBox]

imjoey commented on a change in pull request #231:
URL: https://github.com/apache/apisix-docker/pull/231#discussion_r724160377



##
File path: example/prometheus_conf/prometheus.yml
##
@@ -0,0 +1,23 @@
+global:
+  scrape_interval: 1s # By default, scrape targets every 15 seconds.
+
+  # Attach these labels to any time series or alerts when communicating with
+  # external systems (federation, remote storage, Alertmanager).
+  external_labels:
+monitor: "codelab-monitor"

Review comment:
   @tao12345666333 honestly speaking, I've no idea, even the Prometheus 
official does not provide any information about this. While it's so widely used 
and included in each Prometheus configuration file, seeming like a conventional 
label. Any insight abou this? Thanks.

##
File path: example/prometheus_conf/prometheus.yml
##
@@ -0,0 +1,23 @@
+global:
+  scrape_interval: 1s # By default, scrape targets every 15 seconds.
+
+  # Attach these labels to any time series or alerts when communicating with
+  # external systems (federation, remote storage, Alertmanager).
+  external_labels:
+monitor: "codelab-monitor"

Review comment:
   @tao12345666333 wow, thank you for this awesome explanation. I would 
prefer to update the label as you suggested to mark this Prometheus instance as 
part of `apisix` stack. Thanks again for your help.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

juzhiyuan commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724107103



##
File path: apisix/admin/init.lua
##
@@ -215,12 +215,12 @@ local function run_stream()
 
 local resource = resources[seg_res]
 if not resource then
-core.response.exit(404)
+core.response.exit(404, {error_msg="not found"})
 end
 
 local method = str_lower(get_method())
 if not resource[method] then
-core.response.exit(404)
+core.response.exit(404, {error_msg="not found"})

Review comment:
   according to 
https://github.com/apache/apisix/blob/master/CODE_STYLE.md#space , I would 
prefer using `xx = xx`

##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",
   "route")
-core.response.exit(400)
+core.response.exit(400, {error_msg="stream mode is disabled, can not " 
..

Review comment:
   Would better use `routes` instead of `route`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #149: 关于helm仓库 gateway 和 dashboard不兼容的情况

[GitBox]

tao12345666333 commented on issue #149:
URL: 
https://github.com/apache/apisix-helm-chart/issues/149#issuecomment-937742182


   Due to historical reasons, the Gateway, Dashboard and Ingress controller in 
this project are all independently maintained.
   Currently we are gradually unifying its versions and will ensure that all 
components in the same Helm chart version are compatible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] github-actions[bot] commented on pull request #4471: feat: Add access_log config item to config.yaml

[GitBox]

github-actions[bot] commented on pull request #4471:
URL: https://github.com/apache/apisix/pull/4471#issuecomment-937644354


   This pull request has been marked as stale due to 60 days of inactivity. It 
will be closed in 4 weeks if no further activity occurs. If you think that's 
incorrect or this pull request should instead be reviewed, please simply write 
any comment. Even if closed, you can still revive the PR at any time or discuss 
it on the d...@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3894: feat: Add ldap-auth plugin

[GitBox]

spacewander commented on a change in pull request #3894:
URL: https://github.com/apache/apisix/pull/3894#discussion_r724106848



##
File path: apisix/plugins/ldap-auth.lua
##
@@ -0,0 +1,160 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local ngx = ngx
+local ngx_re = require("ngx.re")
+local ipairs = ipairs
+local consumer_mod = require("apisix.consumer")
+local lualdap = require("lualdap")
+
+local lrucache = core.lrucache.new({
+ttl = 300, count = 512
+})
+
+local schema = {
+type = "object",
+title = "work with route or service object",
+properties = {
+base_dn = { type = "string" },
+ldap_uri = { type = "string" },
+use_tls = { type = "boolean" },
+uid = { type = "string" }
+},
+required = {"base_dn","ldap_uri"},
+}
+
+local consumer_schema = {
+type = "object",
+title = "work with consumer object",
+properties = {
+user_dn = { type = "string" },
+},
+required = {"user_dn"},
+}
+
+local plugin_name = "ldap-auth"
+
+local _M = {
+version = 0.1,
+priority = 2540,
+type = 'auth',
+name = plugin_name,
+schema = schema,
+consumer_schema = consumer_schema
+}
+
+function _M.check_schema(conf, schema_type)
+local ok, err
+if schema_type == core.schema.TYPE_CONSUMER then
+ok, err = core.schema.check(consumer_schema, conf)
+else
+ok, err = core.schema.check(schema, conf)
+end
+
+return ok, err
+end
+
+local create_consumer_cache
+do
+local consumer_names = {}
+
+function create_consumer_cache(consumers)
+core.table.clear(consumer_names)
+
+for _, consumer in ipairs(consumers.nodes) do
+core.log.info("consumer node: ", core.json.delay_encode(consumer))
+consumer_names[consumer.auth_conf.user_dn] = consumer
+end
+
+return consumer_names
+end
+
+end -- do
+
+local function extract_auth_header(authorization)
+local obj = { username = "", password = "" }
+
+local m, err = ngx.re.match(authorization, "Basic\\s(.+)", "jo")
+if err then
+-- error authorization
+return nil, err
+end
+
+local decoded, err = ngx.decode_base64(m[1])
+
+if err then
+return nil, "failed to decode authentication header"
+end
+
+local res
+res, err = ngx_re.split(decoded, ":")
+if err then
+return nil, "split authorization err:" .. err
+end
+if #res < 2 then
+return nil, "split authorization length is invalid"

Review comment:
   ```suggestion
   return nil, "split authorization err: invalid decoded data: " .. 
decoded
   ```

##
File path: apisix/plugins/ldap-auth.lua
##
@@ -0,0 +1,160 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local ngx = ngx
+local ngx_re = require("ngx.re")
+local ipairs = ipairs
+local consumer_mod = require("apisix.consumer")
+local lualdap = require("lualdap")
+
+local lrucache = core.lrucache.new({
+ttl = 300, count = 512
+})
+
+local schema = {
+type = "object",
+title = "work with route or service object",
+properties = {
+base_dn = { type = "string" },
+ldap_uri = { type = "string" },
+use_tls = { type = "boolean" },
+uid = { type = "string" }
+},
+required = {"base_dn","ldap_uri"},
+}
+
+local consumer_schema = {
+type = 

[GitHub] [apisix-docker] imjoey merged pull request #231: feat: Add prometheus/grafana into example

[GitBox]

imjoey merged pull request #231:
URL: https://github.com/apache/apisix-docker/pull/231


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] rmGFW closed issue #5177: request help: Doesn't need configuration

[GitBox]

rmGFW closed issue #5177:
URL: https://github.com/apache/apisix/issues/5177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] rmGFW closed issue #5172: request help: 404 Route Not Found

[GitBox]

rmGFW closed issue #5172:
URL: https://github.com/apache/apisix/issues/5172


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #699: doc: add grpc proxy

[GitBox]

tokers commented on a change in pull request #699:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/699#discussion_r723866999



##
File path: docs/en/latest/practices/proxy-grpc-service.md
##
@@ -0,0 +1,224 @@
+---
+title: How to proxy the gRPC service
+---
+
+
+
+In this practice, we will introduce how to proxy the gRPC service.
+
+## Prerequisites
+
+* Prepare an available Kubernetes cluster in your workstation, we recommend 
you to use [KIND](https://kind.sigs.k8s.io/docs/user/quick-start/) to create a 
local Kubernetes cluster.
+* Install Apache APISIX in Kubernetes by [Helm 
Chart](https://github.com/apache/apisix-helm-chart).
+* Install 
[apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/blob/master/install.md).
+
+Please note that in this practice, all components will be installed in the 
`ingress-apisix` namespace. If your Kubernetes cluster does not have an 
ingress-apisix namespace, please create it first.

Review comment:
   ```suggestion
   Please note that in this practice, all components will be installed in the 
`ingress-apisix` namespace. If your Kubernetes cluster does not have such 
namespace, please create it first.
   ```

##
File path: docs/en/latest/practices/proxy-grpc-service.md
##
@@ -0,0 +1,224 @@
+---
+title: How to proxy the gRPC service
+---
+
+
+
+In this practice, we will introduce how to proxy the gRPC service.
+
+## Prerequisites
+
+* Prepare an available Kubernetes cluster in your workstation, we recommend 
you to use [KIND](https://kind.sigs.k8s.io/docs/user/quick-start/) to create a 
local Kubernetes cluster.
+* Install Apache APISIX in Kubernetes by [Helm 
Chart](https://github.com/apache/apisix-helm-chart).
+* Install 
[apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/blob/master/install.md).
+
+Please note that in this practice, all components will be installed in the 
`ingress-apisix` namespace. If your Kubernetes cluster does not have an 
ingress-apisix namespace, please create it first.
+
+```bash
+kubectl create ns ingress-apisix
+```
+
+You could install APISIX and APISIX ingress controller by running:
+
+```bash
+helm install apisix apisix/apisix -n ingress-apisix --set 
gateway.type=NodePort --set ingress-controller.enabled=true --set 
gateway.tls.enabled=true
+```
+
+Check that APISIX and apisix-ingress have been installed successfully, 
including etcd cluster / APISIX / apisix-ingress-controller.

Review comment:
   ```suggestion
   Check that all related components have been installed successfully, 
including ETCD cluster / APISIX / apisix-ingress-controller.
   ```

##
File path: docs/en/latest/practices/proxy-grpc-service.md
##
@@ -0,0 +1,224 @@
+---
+title: How to proxy the gRPC service
+---
+
+
+
+In this practice, we will introduce how to proxy the gRPC service.
+
+## Prerequisites
+
+* Prepare an available Kubernetes cluster in your workstation, we recommend 
you to use [KIND](https://kind.sigs.k8s.io/docs/user/quick-start/) to create a 
local Kubernetes cluster.
+* Install Apache APISIX in Kubernetes by [Helm 
Chart](https://github.com/apache/apisix-helm-chart).
+* Install 
[apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/blob/master/install.md).
+
+Please note that in this practice, all components will be installed in the 
`ingress-apisix` namespace. If your Kubernetes cluster does not have an 
ingress-apisix namespace, please create it first.
+
+```bash
+kubectl create ns ingress-apisix
+```
+
+You could install APISIX and APISIX ingress controller by running:
+
+```bash
+helm install apisix apisix/apisix -n ingress-apisix --set 
gateway.type=NodePort --set ingress-controller.enabled=true --set 
gateway.tls.enabled=true
+```
+
+Check that APISIX and apisix-ingress have been installed successfully, 
including etcd cluster / APISIX / apisix-ingress-controller.
+
+```bash
+k get pod -n ingress-apisix
+NAMEREADY   STATUSRESTARTS   AGE
+apisix-569f94b7b6-qt5jj 1/1 Running   0  101m
+apisix-etcd-0   1/1 Running   0  101m
+apisix-etcd-1   1/1 Running   0  101m
+apisix-etcd-2   1/1 Running   0  101m
+apisix-ingress-controller-b5f5d49db-r9cxb   1/1 Running   0  101m
+```
+
+## Prepare a gRPC service
+
+Using [yages](https://github.com/mhausenblas/yages) as the gRPC server.
+
+Declare the deployment configuration of yapes, exposing port 9000
+
+```yaml
+kubectl apply -f - 

[GitHub] [apisix] spacewander commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

spacewander commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724087432



##
File path: apisix/admin/init.lua
##
@@ -278,12 +278,13 @@ local function post_reload_plugins()
 local ok, err = check_token(api_ctx)
 if not ok then
 core.log.warn("failed to check token: ", err)
-core.response.exit(401)
+core.response.exit(401, {error_msg="failed to check token"})
 end
 
 local success, err = events.post(reload_event, get_method(), ngx_time())
 if not success then
 core.response.exit(503, err)
+

Review comment:
   Extra blank line?

##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",
   "route")
-core.response.exit(400)
+core.response.exit(400, {error_msg="stream mode is disabled, can not " 
..

Review comment:
   "stream mode is disabled, can not add any stream route"

##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",

Review comment:
   Let's fix the grammar here in the next PR

##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",
   "route")
-core.response.exit(400)
+core.response.exit(400, {error_msg="stream mode is disabled, can not " 
..
+   "to add stream"})
 end
 
 local ok, err = check_token(api_ctx)
 if not ok then
-core.log.warn("failed to check token: ", err)

Review comment:
   Let's keep the original error log




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] tao12345666333 commented on a change in pull request #231: feat: Add prometheus/grafana into example

[GitBox]

tao12345666333 commented on a change in pull request #231:
URL: https://github.com/apache/apisix-docker/pull/231#discussion_r724132755



##
File path: example/prometheus_conf/prometheus.yml
##
@@ -0,0 +1,23 @@
+global:
+  scrape_interval: 1s # By default, scrape targets every 15 seconds.
+
+  # Attach these labels to any time series or alerts when communicating with
+  # external systems (federation, remote storage, Alertmanager).
+  external_labels:
+monitor: "codelab-monitor"

Review comment:
   A small comment, why add this label

##
File path: example/prometheus_conf/prometheus.yml
##
@@ -0,0 +1,23 @@
+global:
+  scrape_interval: 1s # By default, scrape targets every 15 seconds.
+
+  # Attach these labels to any time series or alerts when communicating with
+  # external systems (federation, remote storage, Alertmanager).
+  external_labels:
+monitor: "codelab-monitor"

Review comment:
   In fact, this label can be considered to be used to mark the current 
prometheus instance. Here we can leave it unset, or set a more meaningful label 
for it. like this:
   
   ```suggestion
   stack: "apisix"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #5163: fix: pass correct host header to health checker target nodes

[GitBox]

spacewander commented on a change in pull request #5163:
URL: https://github.com/apache/apisix/pull/5163#discussion_r724128784



##
File path: apisix/upstream.lua
##
@@ -293,7 +293,7 @@ function _M.set_by_route(route, api_ctx)
 end
 
 if nodes_count > 1 then
-local checker = fetch_healthchecker(up_conf)
+local checker = fetch_healthchecker(up_conf, api_ctx.var.host)

Review comment:
   I am sorry, the solution I gave is incorrect. I tried to make a new one 
here: https://github.com/apache/apisix/pull/5175




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #5149: request help: use name instead of id in grafana dashboard

[GitBox]

spacewander commented on issue #5149:
URL: https://github.com/apache/apisix/issues/5149#issuecomment-937427367


   No. It will be a break change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #569: request help: apisix ingress controller with Dapr

[GitBox]

tokers commented on issue #569:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/569#issuecomment-937484494


   This is the default APISIX control API listening port, from the result of 
the `netstat` we cannot determine which process occupies it. Could you use 
`lsof` or other utilities to show the process?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #647: fix: homepage Events Article links

[GitBox]

1502shivam-singh commented on a change in pull request #647:
URL: https://github.com/apache/apisix-website/pull/647#discussion_r724136424



##
File path: website/src/pages/sections/newsSection.jsx
##
@@ -11,7 +11,7 @@ const NewsSection = () => {
 .map((event) => {
 const publishTime = event.fileName.slice(0, 10);
 const splittedFileName = event.fileName.split("-");
-const url = `/events/${splittedFileName
+const url = `/blog/${splittedFileName

Review comment:
   You sure only doing this will work ?
   For instance -
   https://apisix.apache.org/events/2021/09/15/weekly-report (404)
   
   After change `events` -> `blog`
   
   https://apisix.apache.org/blog/2021/09/15/weekly-report (still 404) 
   

##
File path: website/src/pages/sections/newsSection.jsx
##
@@ -11,7 +11,7 @@ const NewsSection = () => {
 .map((event) => {
 const publishTime = event.fileName.slice(0, 10);
 const splittedFileName = event.fileName.split("-");
-const url = `/events/${splittedFileName
+const url = `/blog/${splittedFileName

Review comment:
   Or are we planning to add all these articles under blog section ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] elvis-cai commented on pull request #5163: fix: pass correct host header to health checker target nodes

[GitBox]

elvis-cai commented on pull request #5163:
URL: https://github.com/apache/apisix/pull/5163#issuecomment-938218753


   > @elvis-cai What about this one? #5175
   
   Thanks @spacewander for the quick update, it works perfectly with this PR 
#5175 👍 , tested following scenarios:
   - two healthy external urls with pass_host set to "node", it load balances 
to each of them.
   - make one url to return 404, it could only return the healthy url.
   - recover 404 url, it will load balance them again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] github-actions[bot] commented on pull request #4498: docs: added /apisix/admin/plugins/reload into admin-api.md

[GitBox]

github-actions[bot] commented on pull request #4498:
URL: https://github.com/apache/apisix/pull/4498#issuecomment-937644377


   This pull request has been marked as stale due to 60 days of inactivity. It 
will be closed in 4 weeks if no further activity occurs. If you think that's 
incorrect or this pull request should instead be reviewed, please simply write 
any comment. Even if closed, you can still revive the PR at any time or discuss 
it on the d...@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated: feat: enhance the verification of the configuration (#5171)

[spacewander]

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 3e18838  feat: enhance the verification of the configuration (#5171)
3e18838 is described below

commit 3e188389e39369ecae248a47f6b829e0c08e7ae7
Author: nic-chen 
AuthorDate: Fri Oct 8 08:51:10 2021 +0800

feat: enhance the verification of the configuration (#5171)
---
 apisix/cli/ops.lua | 41 +
 docs/en/latest/how-to-build.md |  9 +
 docs/zh/latest/how-to-build.md |  9 +
 t/cli/test_validate_config.sh  | 46 ++
 4 files changed, 105 insertions(+)

diff --git a/apisix/cli/ops.lua b/apisix/cli/ops.lua
index e179522..750f5b1 100644
--- a/apisix/cli/ops.lua
+++ b/apisix/cli/ops.lua
@@ -34,6 +34,7 @@ local tostring = tostring
 local tonumber = tonumber
 local io_open = io.open
 local execute = os.execute
+local os_rename = os.rename
 local table_insert = table.insert
 local getenv = os.getenv
 local max = math.max
@@ -891,6 +892,43 @@ local function cleanup()
 end
 
 
+local function test(env, backup_ngx_conf)
+-- backup nginx.conf
+local ngx_conf_path = env.apisix_home .. "/conf/nginx.conf"
+local ngx_conf_exist = util.is_file_exist(ngx_conf_path)
+if ngx_conf_exist then
+local ok, err = os_rename(ngx_conf_path, ngx_conf_path .. ".bak")
+if not ok then
+util.die("failed to backup nginx.conf, error: ", err)
+end
+end
+
+-- reinit nginx.conf
+init(env)
+
+local test_cmd = env.openresty_args .. [[ -t -q ]]
+local test_ret = execute((test_cmd))
+
+-- restore nginx.conf
+if ngx_conf_exist then
+local ok, err = os_rename(ngx_conf_path .. ".bak", ngx_conf_path)
+if not ok then
+util.die("failed to restore original nginx.conf, error: ", err)
+end
+end
+
+-- When success,
+-- On linux, os.execute returns 0,
+-- On macos, os.execute returns 3 values: true, exit, 0, and we need the 
first.
+if (test_ret == 0 or test_ret == true) then
+print("configuration test is successful")
+return
+end
+
+util.die("configuration test failed")
+end
+
+
 local function quit(env)
 cleanup()
 
@@ -908,6 +946,8 @@ end
 
 
 local function restart(env)
+  -- test configuration
+  test(env)
   stop(env)
   start(env)
 end
@@ -943,6 +983,7 @@ local action = {
 quit = quit,
 restart = restart,
 reload = reload,
+test = test,
 }
 
 
diff --git a/docs/en/latest/how-to-build.md b/docs/en/latest/how-to-build.md
index 09c5d7c..22b3ba9 100644
--- a/docs/en/latest/how-to-build.md
+++ b/docs/en/latest/how-to-build.md
@@ -93,6 +93,15 @@ Run the following command to initialize the NGINX 
configuration file and etcd.
 apisix init
 ```
 
+### Test configuration file
+
+Run the following command to test the configuration file. APISIX will generate 
`nginx.conf` from `config.yaml` and check whether the syntax of `nginx.conf` is 
correct.
+
+```shell
+# generate `nginx.conf` from `config.yaml` and test it
+apisix test
+```
+
 ### Start Apache APISIX
 
 Run the following command to start Apache APISIX.
diff --git a/docs/zh/latest/how-to-build.md b/docs/zh/latest/how-to-build.md
index 776..c419591 100644
--- a/docs/zh/latest/how-to-build.md
+++ b/docs/zh/latest/how-to-build.md
@@ -93,6 +93,15 @@ sudo yum install -y 
https://github.com/apache/apisix/releases/download/2.10.0/ap
 apisix init
 ```
 
+### 测试配置文件
+
+运行以下命令测试配置文件。 APISIX 将根据 `config.yaml` 生成 `nginx.conf` ，并检查 `nginx.conf` 
的语法是否正确。
+
+```shell
+# generate `nginx.conf` from `config.yaml` and test it
+apisix test
+```
+
 ### 启动 Apache APISIX
 
 运行以下命令启动 Apache APISIX。
diff --git a/t/cli/test_validate_config.sh b/t/cli/test_validate_config.sh
index 96f6bf2..c2c7b69 100755
--- a/t/cli/test_validate_config.sh
+++ b/t/cli/test_validate_config.sh
@@ -89,3 +89,49 @@ fi
 git checkout conf/config-default.yaml
 
 echo "passed: allow configuring node_listen as a number in the default config"
+
+# apisix test
+git checkout conf/config.yaml
+
+out=$(./bin/apisix test 2>&1 || true)
+if ! echo "$out" | grep "configuration test is successful"; then
+echo "failed: configuration test should be successful"
+exit 1
+fi
+
+echo "pass: apisix test"
+
+./bin/apisix start
+sleep 1 # wait for apisix starts
+
+# set invalid configuration
+echo '
+nginx_config:
+main_configuration_snippet: |
+notexist on;
+' > conf/config.yaml
+
+# apisix restart
+out=$(./bin/apisix restart 2>&1 || true)
+if ! (echo "$out" | grep "\[emerg\] unknown directive \"notexist\"") && ! 
(echo "$out" | grep "APISIX is running"); then
+echo "failed: should restart failed when configuration invalid"
+exit 1
+fi
+
+echo "passed: apisix restart"
+
+# apisix test - failure scenario
+out=$(./bin

[GitHub] [apisix] spacewander closed issue #3230: bug: when modify config file apisix shoud check config file

[GitBox]

spacewander closed issue #3230:
URL: https://github.com/apache/apisix/issues/3230


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #5171: feat: enhance the verification of the configuration

[GitBox]

spacewander merged pull request #5171:
URL: https://github.com/apache/apisix/pull/5171


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #5165: bug: plugin wolf-rbac /apisix/plugin/wolf-rbac/login resturn header is text/plain , cors error

[GitBox]

spacewander commented on issue #5165:
URL: https://github.com/apache/apisix/issues/5165#issuecomment-938256763


   You can add cors as a plugin interceptor:
   
https://github.com/apache/apisix/blob/3e188389e39369ecae248a47f6b829e0c08e7ae7/apisix/api_router.lua#L30
   
   PR is welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] gxthrj commented on issue #149: 关于helm仓库 gateway 和 dashboard不兼容的情况

[GitBox]

gxthrj commented on issue #149:
URL: 
https://github.com/apache/apisix-helm-chart/issues/149#issuecomment-938257306


   It seems that we cannot directly update the dashboard sub-project, because 
dashboard and apisix have versions corresponding.
   
![image](https://user-images.githubusercontent.com/4413028/136481910-9bb14c29-c364-4127-a190-77fef2998d71.png)
   https://github.com/apache/apisix-dashboard#readme
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2154: feat: release 2.9.0

[GitBox]

starsz commented on a change in pull request #2154:
URL: https://github.com/apache/apisix-dashboard/pull/2154#discussion_r724629086



##
File path: CHANGELOG.md
##
@@ -34,6 +35,33 @@
 - [1.5.0](#150)
 - [1.0.0](#100)
 
+# 2.9.0
+
+This release contains some features and bugfixes, and all the existing 
functionalities are compatible with Apache APISIX 2.10.0.
+
+### Core
+
+- feat(plugin): allowing basic-auth to dynamically adapt to the BE rules 
[#2086](https://github.com/apache/apisix-dashboard/pull/2149)
+- feat(plugin): allowing referer-restriction to dynamically adapt to the BE 
rules [#2001](https://github.com/apache/apisix-dashboard/pull/2001)
+- refactor: migrate to viper configure manage 
[#1946](https://github.com/apache/apisix-dashboard/pull/1946)
+- feat: basic support Apache APISIX 2.10 
[#2149](https://github.com/apache/apisix-dashboard/pull/2149)
+- feat: support Manager API run on windows 
[#2125](https://github.com/apache/apisix-dashboard/pull/2125)
+
+### Bugfix
+
+- fix: supports search by name for service options when add router. 
[#2066](https://github.com/apache/apisix-dashboard/pull/2066)

Review comment:
   ```suggestion
   - fix: supports search by name for service options when add router 
[#2066](https://github.com/apache/apisix-dashboard/pull/2066)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch release/2.9.0 updated (614716a -> f50779a)

[liuxiran]

This is an automated email from the ASF dual-hosted git repository.

liuxiran pushed a change to branch release/2.9.0
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.


from 614716a  feat: release 2.9.0
 add f50779a  Update CHANGELOG.md

No new revisions were added by this update.

Summary of changes:
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[GitHub] [apisix] zhendongcmss commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

zhendongcmss commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724631887



##
File path: apisix/admin/init.lua
##
@@ -278,12 +278,13 @@ local function post_reload_plugins()
 local ok, err = check_token(api_ctx)
 if not ok then
 core.log.warn("failed to check token: ", err)
-core.response.exit(401)
+core.response.exit(401, {error_msg="failed to check token"})
 end
 
 local success, err = events.post(reload_event, get_method(), ngx_time())
 if not success then
 core.response.exit(503, err)
+

Review comment:
   Will remove it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2154: feat: release 2.9.0

[GitBox]

liuxiran commented on a change in pull request #2154:
URL: https://github.com/apache/apisix-dashboard/pull/2154#discussion_r724632154



##
File path: CHANGELOG.md
##
@@ -34,6 +35,33 @@
 - [1.5.0](#150)
 - [1.0.0](#100)
 
+# 2.9.0
+
+This release contains some features and bugfixes, and all the existing 
functionalities are compatible with Apache APISIX 2.10.0.
+
+### Core
+
+- feat(plugin): allowing basic-auth to dynamically adapt to the BE rules 
[#2086](https://github.com/apache/apisix-dashboard/pull/2149)
+- feat(plugin): allowing referer-restriction to dynamically adapt to the BE 
rules [#2001](https://github.com/apache/apisix-dashboard/pull/2001)
+- refactor: migrate to viper configure manage 
[#1946](https://github.com/apache/apisix-dashboard/pull/1946)
+- feat: basic support Apache APISIX 2.10 
[#2149](https://github.com/apache/apisix-dashboard/pull/2149)
+- feat: support Manager API run on windows 
[#2125](https://github.com/apache/apisix-dashboard/pull/2125)
+
+### Bugfix
+
+- fix: supports search by name for service options when add router. 
[#2066](https://github.com/apache/apisix-dashboard/pull/2066)

Review comment:
   thanks @starsz , fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2154: feat: release 2.9.0

[GitBox]

codecov-commenter edited a comment on pull request #2154:
URL: https://github.com/apache/apisix-dashboard/pull/2154#issuecomment-932974182


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2154](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f50779a) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `16.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2154   +/-   ##
   ===
   - Coverage   69.55%   52.70%   -16.85% 
   ===
 Files 187   38  -149 
 Lines7137 2935 -4202 
 Branches  8230  -823 
   ===
   - Hits 4964 1547 -3417 
   + Misses   1886 1194  -692 
   + Partials  287  194   -93 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `52.70% <ø> (-0.04%)` | :arrow_down: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.31%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-70.00%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3

[GitHub] [apisix] zhendongcmss commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

zhendongcmss commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724632723



##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",
   "route")
-core.response.exit(400)
+core.response.exit(400, {error_msg="stream mode is disabled, can not " 
..
+   "to add stream"})
 end
 
 local ok, err = check_token(api_ctx)
 if not ok then
-core.log.warn("failed to check token: ", err)

Review comment:
   OK, will update in next patch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] zhendongcmss commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

zhendongcmss commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724633273



##
File path: apisix/admin/init.lua
##
@@ -215,12 +215,12 @@ local function run_stream()
 
 local resource = resources[seg_res]
 if not resource then
-core.response.exit(404)
+core.response.exit(404, {error_msg="not found"})
 end
 
 local method = str_lower(get_method())
 if not resource[method] then
-core.response.exit(404)
+core.response.exit(404, {error_msg="not found"})

Review comment:
   Ok, will update in next patch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2154: feat: release 2.9.0

[GitBox]

codecov-commenter edited a comment on pull request #2154:
URL: https://github.com/apache/apisix-dashboard/pull/2154#issuecomment-932974182


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2154](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f50779a) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `2.90%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2154  +/-   ##
   ==
   - Coverage   69.55%   66.64%   -2.91% 
   ==
 Files 187   60 -127 
 Lines7137 3790-3347 
 Branches  8230 -823 
   ==
   - Hits 4964 2526-2438 
   + Misses   1886  977 -909 
 Partials  287  287  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `48.70% <ø> (-0.06%)` | :arrow_down: |
   | backend-unit-test | `52.70% <ø> (-0.04%)` | :arrow_down: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `32.11% <0.00%> (-35.41%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `68.18% <0.00%> (-22.73%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `68.11% <0.00%> (-17.40%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `60.00% <0.00%> (-13.00%)` | :arrow_down: |
   | 
[api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==)
 | `45.90% <0.00%> (-9.84%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `78.37% <0.00%> (-8.11%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=

[GitHub] [apisix] zhendongcmss commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

zhendongcmss commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724634952



##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",

Review comment:
   Do you mean change `steam `to `routes `? Can I fix it in this PR ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] zhendongcmss commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

zhendongcmss commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724634952



##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",

Review comment:
   Do you mean change `route`to `routes `? Can I fix it in this PR ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] zhendongcmss commented on pull request #5163: fix: pass correct host header to health checker target nodes

[GitBox]

zhendongcmss commented on pull request #5163:
URL: https://github.com/apache/apisix/pull/5163#issuecomment-938268284


   @spacewander will close this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] zhendongcmss closed pull request #5163: fix: pass correct host header to health checker target nodes

[GitBox]

zhendongcmss closed pull request #5163:
URL: https://github.com/apache/apisix/pull/5163


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] zhendongcmss commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

zhendongcmss commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724634952



##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",

Review comment:
   Do you mean change it to `stream mode is disabled, can not add any 
stream route` ? Can I fix it in this PR ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] zhendongcmss commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

zhendongcmss commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724634952



##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",

Review comment:
   Do you mean change it to `stream mode is disabled, can not add any 
stream routes` ? Can I fix it in this PR ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #699: doc: add grpc proxy

[GitBox]

gxthrj commented on a change in pull request #699:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/699#discussion_r724639591



##
File path: docs/en/latest/practices/proxy-grpc-service.md
##
@@ -0,0 +1,224 @@
+---
+title: How to proxy the gRPC service
+---
+
+
+
+In this practice, we will introduce how to proxy the gRPC service.
+
+## Prerequisites
+
+* Prepare an available Kubernetes cluster in your workstation, we recommend 
you to use [KIND](https://kind.sigs.k8s.io/docs/user/quick-start/) to create a 
local Kubernetes cluster.
+* Install Apache APISIX in Kubernetes by [Helm 
Chart](https://github.com/apache/apisix-helm-chart).
+* Install 
[apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/blob/master/install.md).
+
+Please note that in this practice, all components will be installed in the 
`ingress-apisix` namespace. If your Kubernetes cluster does not have an 
ingress-apisix namespace, please create it first.
+
+```bash
+kubectl create ns ingress-apisix
+```
+
+You could install APISIX and APISIX ingress controller by running:
+
+```bash
+helm install apisix apisix/apisix -n ingress-apisix --set 
gateway.type=NodePort --set ingress-controller.enabled=true --set 
gateway.tls.enabled=true
+```
+
+Check that APISIX and apisix-ingress have been installed successfully, 
including etcd cluster / APISIX / apisix-ingress-controller.
+
+```bash
+k get pod -n ingress-apisix
+NAMEREADY   STATUSRESTARTS   AGE
+apisix-569f94b7b6-qt5jj 1/1 Running   0  101m
+apisix-etcd-0   1/1 Running   0  101m
+apisix-etcd-1   1/1 Running   0  101m
+apisix-etcd-2   1/1 Running   0  101m
+apisix-ingress-controller-b5f5d49db-r9cxb   1/1 Running   0  101m
+```
+
+## Prepare a gRPC service
+
+Using [yages](https://github.com/mhausenblas/yages) as the gRPC server.
+
+Declare the deployment configuration of yapes, exposing port 9000
+
+```yaml
+kubectl apply -f - <

[GitHub] [apisix] zhendongcmss commented on a change in pull request #5174: fix: refine admin API return JSON instead of code

[GitBox]

zhendongcmss commented on a change in pull request #5174:
URL: https://github.com/apache/apisix/pull/5174#discussion_r724639886



##
File path: apisix/admin/init.lua
##
@@ -192,13 +192,13 @@ local function run_stream()
 if not local_conf.apisix.stream_proxy then
 core.log.warn("stream mode is disabled, can not to add any stream ",
   "route")
-core.response.exit(400)
+core.response.exit(400, {error_msg="stream mode is disabled, can not " 
..

Review comment:
   I think `routes` better




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2154: feat: release 2.9.0

[GitBox]

codecov-commenter edited a comment on pull request #2154:
URL: https://github.com/apache/apisix-dashboard/pull/2154#issuecomment-932974182


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2154](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f50779a) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `2.17%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2154  +/-   ##
   ==
   - Coverage   69.55%   67.38%   -2.18% 
   ==
 Files 187  187  
 Lines7137 7137  
 Branches  823  823  
   ==
   - Hits 4964 4809 -155 
   - Misses   1886 2041 +155 
 Partials  287  287  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `48.70% <ø> (-0.06%)` | :arrow_down: |
   | backend-unit-test | `52.70% <ø> (-0.04%)` | :arrow_down: |
   | frontend-e2e-test | `68.21% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `32.11% <0.00%> (-35.41%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `68.18% <0.00%> (-22.73%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `68.11% <0.00%> (-17.40%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `60.00% <0.00%> (-13.00%)` | :arrow_down: |
   | 
[api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==)
 | `45.90% <0.00%> (-9.84%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `78.37% <0.00%> (-8.11%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referra

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #699: doc: add grpc proxy

[GitBox]

gxthrj commented on a change in pull request #699:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/699#discussion_r724642006



##
File path: docs/en/latest/practices/proxy-grpc-service.md
##
@@ -0,0 +1,224 @@
+---
+title: How to proxy the gRPC service
+---
+
+
+
+In this practice, we will introduce how to proxy the gRPC service.
+
+## Prerequisites
+
+* Prepare an available Kubernetes cluster in your workstation, we recommend 
you to use [KIND](https://kind.sigs.k8s.io/docs/user/quick-start/) to create a 
local Kubernetes cluster.
+* Install Apache APISIX in Kubernetes by [Helm 
Chart](https://github.com/apache/apisix-helm-chart).
+* Install 
[apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/blob/master/install.md).
+
+Please note that in this practice, all components will be installed in the 
`ingress-apisix` namespace. If your Kubernetes cluster does not have an 
ingress-apisix namespace, please create it first.
+
+```bash
+kubectl create ns ingress-apisix
+```
+
+You could install APISIX and APISIX ingress controller by running:
+
+```bash
+helm install apisix apisix/apisix -n ingress-apisix --set 
gateway.type=NodePort --set ingress-controller.enabled=true --set 
gateway.tls.enabled=true
+```
+
+Check that APISIX and apisix-ingress have been installed successfully, 
including etcd cluster / APISIX / apisix-ingress-controller.
+
+```bash
+k get pod -n ingress-apisix
+NAMEREADY   STATUSRESTARTS   AGE
+apisix-569f94b7b6-qt5jj 1/1 Running   0  101m
+apisix-etcd-0   1/1 Running   0  101m
+apisix-etcd-1   1/1 Running   0  101m
+apisix-etcd-2   1/1 Running   0  101m
+apisix-ingress-controller-b5f5d49db-r9cxb   1/1 Running   0  101m
+```
+
+## Prepare a gRPC service
+
+Using [yages](https://github.com/mhausenblas/yages) as the gRPC server.
+
+Declare the deployment configuration of yapes, exposing port 9000
+
+```yaml
+kubectl apply -f - <9180/TCP  
   98m
+apisix-etcd ClusterIP   10.96.81.162   
2379/TCP,2380/TCP98m
+apisix-etcd-headlessClusterIP   None   
2379/TCP,2380/TCP98m
+apisix-gateway  NodePort10.96.74.145   
80:32600/TCP,443:32103/TCP   98m
+apisix-ingress-controller   ClusterIP   10.96.78.108   80/TCP
   98m
+yages   ClusterIP   10.96.37.236   9000/TCP  
   94m
+```
+
+```bash
+kubectl run -it -n ingress-apisix --rm grpcurl --restart=Never 
--image=quay.io/mhausenblas/gump:0.1 -- sh

Review comment:
   But it is too long, I think it is more appropriate to distinguish the 
commands between starting the container and the grpcurl.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #2154: feat: release 2.9.0

[GitBox]

liuxiran commented on pull request #2154:
URL: https://github.com/apache/apisix-dashboard/pull/2154#issuecomment-938273899


   
https://github.com/apache/apisix-dashboard/pull/2154/checks?check_run_id=3833771098
   
   @bzp2010 please help to check it when you have time, thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2154: feat: release 2.9.0

[GitBox]

codecov-commenter edited a comment on pull request #2154:
URL: https://github.com/apache/apisix-dashboard/pull/2154#issuecomment-932974182


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2154](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f50779a) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `2.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2154  +/-   ##
   ==
   - Coverage   69.55%   67.40%   -2.15% 
   ==
 Files 187  187  
 Lines7137 7137  
 Branches  823  823  
   ==
   - Hits 4964 4811 -153 
   - Misses   1886 2040 +154 
   + Partials  287  286   -1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `48.75% <ø> (ø)` | |
   | backend-unit-test | `52.70% <ø> (-0.04%)` | :arrow_down: |
   | frontend-e2e-test | `68.21% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `32.11% <0.00%> (-35.41%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `68.18% <0.00%> (-22.73%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `68.11% <0.00%> (-17.40%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `60.00% <0.00%> (-13.00%)` | :arrow_down: |
   | 
[api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==)
 | `45.90% <0.00%> (-9.84%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `78.37% <0.00%> (-8.11%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=githu

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2154: feat: release 2.9.0

[GitBox]

codecov-commenter edited a comment on pull request #2154:
URL: https://github.com/apache/apisix-dashboard/pull/2154#issuecomment-932974182


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2154](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f50779a) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `2.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2154  +/-   ##
   ==
   - Coverage   69.55%   67.54%   -2.01% 
   ==
 Files 187  187  
 Lines7137 7137  
 Branches  823  823  
   ==
   - Hits 4964 4821 -143 
   - Misses   1886 2029 +143 
 Partials  287  287  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `49.26% <ø> (+0.50%)` | :arrow_up: |
   | backend-unit-test | `52.70% <ø> (-0.04%)` | :arrow_down: |
   | frontend-e2e-test | `68.21% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `32.11% <0.00%> (-35.41%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `68.18% <0.00%> (-22.73%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `68.11% <0.00%> (-17.40%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `60.00% <0.00%> (-13.00%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `78.37% <0.00%> (-8.11%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.82% <0.00%> (-3.48%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&u

[GitHub] [apisix] laokan commented on issue #5165: bug: plugin wolf-rbac /apisix/plugin/wolf-rbac/login resturn header is text/plain , cors error

[GitBox]

laokan commented on issue #5165:
URL: https://github.com/apache/apisix/issues/5165#issuecomment-938282262


   add header_modify  interceptors ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #5165: bug: plugin wolf-rbac /apisix/plugin/wolf-rbac/login resturn header is text/plain , cors error

[GitBox]

spacewander commented on issue #5165:
URL: https://github.com/apache/apisix/issues/5165#issuecomment-938286562


   cors  interceptors. We can reuse the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on issue #156: https for website

[GitBox]

juzhiyuan commented on issue #156:
URL: https://github.com/apache/apisix-website/issues/156#issuecomment-938288741


   still no response from Infra :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] LuChenjing commented on issue #700: ApisixRoute route still work after deleting AR source

[GitBox]

LuChenjing commented on issue #700:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/700#issuecomment-938289344


   The result of curl the right URL is correct. But browser rewrite to a 
different URL.
   For issue2,  when I try to access the monitor2 from the browser, it will 
redirect to `http://**.**.**.**:30005/api/v1/status/config` instead of 
`http://**.**.**.**:30005/monitor2/api/v1/status/config`, so the result shown 
incorrect. 
   Is this an issue belongs to proxy-rewrite plugin?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #5165: bug: plugin wolf-rbac /apisix/plugin/wolf-rbac/login resturn header is text/plain , cors error

[GitBox]

spacewander commented on issue #5165:
URL: https://github.com/apache/apisix/issues/5165#issuecomment-938289423


   My bad! It is not about providing cors to wolf-rbac login. We just need to 
fix the login handler with `core.response.set_header("Content-Type", 
"application/json")`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 opened a new pull request #2156: refactor: entity interface format

[GitBox]

bzp2010 opened a new pull request #2156:
URL: https://github.com/apache/apisix-dashboard/pull/2156


   Please answer these questions before submitting a pull request, **or your PR 
will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Centralize and unify the interface format to make the code more readable.
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   - [x] Have you added corresponding test cases?
   - [x] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, 
please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2156: refactor: entity interface format

[GitBox]

codecov-commenter commented on pull request #2156:
URL: https://github.com/apache/apisix-dashboard/pull/2156#issuecomment-938291662


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2156](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (606b1df) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `16.81%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 606b1df differs from pull request most recent 
head 0b049e7. Consider uploading reports for the commit 0b049e7 to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2156   +/-   ##
   ===
   - Coverage   69.55%   52.74%   -16.82% 
   ===
 Files 187   38  -149 
 Lines7137 2935 -4202 
 Branches  8230  -823 
   ===
   - Hits 4964 1548 -3416 
   + Misses   1886 1193  -693 
   + Partials  287  194   -93 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `52.74% <100.00%> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <ø> (-90.91%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `80.52% <100.00%> (-8.95%)` | :arrow_down: |
   | 
[api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.31%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=p

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2156: refactor: entity interface format

[GitBox]

codecov-commenter edited a comment on pull request #2156:
URL: https://github.com/apache/apisix-dashboard/pull/2156#issuecomment-938291662


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2156](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (0b049e7) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `16.81%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 0b049e7 differs from pull request most recent 
head bb3a1ea. Consider uploading reports for the commit bb3a1ea to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2156   +/-   ##
   ===
   - Coverage   69.55%   52.74%   -16.82% 
   ===
 Files 187   38  -149 
 Lines7137 2935 -4202 
 Branches  8230  -823 
   ===
   - Hits 4964 1548 -3416 
   + Misses   1886 1193  -693 
   + Partials  287  194   -93 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `52.74% <100.00%> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <ø> (-90.91%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `80.52% <100.00%> (-8.95%)` | :arrow_down: |
   | 
[api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.31%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/dif

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2156: refactor: entity interface format

[GitBox]

codecov-commenter edited a comment on pull request #2156:
URL: https://github.com/apache/apisix-dashboard/pull/2156#issuecomment-938291662


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2156](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (bb3a1ea) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `16.81%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2156   +/-   ##
   ===
   - Coverage   69.55%   52.74%   -16.82% 
   ===
 Files 187   38  -149 
 Lines7137 2935 -4202 
 Branches  8230  -823 
   ===
   - Hits 4964 1548 -3416 
   + Misses   1886 1193  -693 
   + Partials  287  194   -93 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `52.74% <100.00%> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <ø> (-90.91%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `80.52% <100.00%> (-8.95%)` | :arrow_down: |
   | 
[api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.31%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9j

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2156: refactor: entity interface format

[GitBox]

codecov-commenter edited a comment on pull request #2156:
URL: https://github.com/apache/apisix-dashboard/pull/2156#issuecomment-938291662


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2156](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (bb3a1ea) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `2.56%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2156  +/-   ##
   ==
   - Coverage   69.55%   66.99%   -2.57% 
   ==
 Files 187   60 -127 
 Lines7137 3790-3347 
 Branches  8230 -823 
   ==
   - Hits 4964 2539-2425 
   + Misses   1886  967 -919 
   + Partials  287  284   -3 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `49.02% <100.00%> (+0.26%)` | :arrow_up: |
   | backend-unit-test | `52.74% <100.00%> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `68.18% <ø> (-22.73%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `89.47% <100.00%> (ø)` | |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `32.11% <0.00%> (-35.41%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `33.33% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `68.11% <0.00%> (-17.40%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `60.00% <0.00%> (-13.00%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2154: feat: release 2.9.0

[GitBox]

codecov-commenter edited a comment on pull request #2154:
URL: https://github.com/apache/apisix-dashboard/pull/2154#issuecomment-932974182


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2154](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f50779a) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `1.93%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2154  +/-   ##
   ==
   - Coverage   69.55%   67.61%   -1.94% 
   ==
 Files 187  187  
 Lines7137 7137  
 Branches  823  823  
   ==
   - Hits 4964 4826 -138 
   - Misses   1886 2025 +139 
   + Partials  287  286   -1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `49.44% <ø> (+0.68%)` | :arrow_up: |
   | backend-unit-test | `52.70% <ø> (-0.04%)` | :arrow_down: |
   | frontend-e2e-test | `68.21% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `32.11% <0.00%> (-35.41%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `68.18% <0.00%> (-22.73%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `68.11% <0.00%> (-17.40%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `60.00% <0.00%> (-13.00%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `78.37% <0.00%> (-8.11%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.82% <0.00%> (-3.48%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2154/diff?src=pr&el=tree&utm_medium=referral

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2144: feat: support proto API (entity)

[GitBox]

starsz commented on a change in pull request #2144:
URL: https://github.com/apache/apisix-dashboard/pull/2144#discussion_r724663821



##
File path: api/internal/core/entity/entity.go
##
@@ -290,3 +282,10 @@ type PluginConfig struct {
Plugins map[string]interface{} `json:"plugins"`
Labels  map[string]string  `json:"labels,omitempty"`
 }
+
+// swagger:model Proto

Review comment:
   But now, we don't use swagger to generate API in fact.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] moonming commented on issue #156: https for website

[GitBox]

moonming commented on issue #156:
URL: https://github.com/apache/apisix-website/issues/156#issuecomment-938298908


   I am not find the ticket for infra
   
   琚致远 ***@***.***>于2021年10月8日 周五上午10:29写道：
   
   > still no response from Infra :(
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   -- 
   Thanks,
   Ming Wen
   Twitter: _WenMing
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2156: refactor: entity interface format

[GitBox]

codecov-commenter edited a comment on pull request #2156:
URL: https://github.com/apache/apisix-dashboard/pull/2156#issuecomment-938291662


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2156](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (2483346) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/321a195b3d3423d57ec1562e5b085bc528ec1b45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (321a195) will **decrease** coverage by `1.40%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 2483346 differs from pull request most recent 
head bb3a1ea. Consider uploading reports for the commit bb3a1ea to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2156  +/-   ##
   ==
   - Coverage   69.55%   68.15%   -1.41% 
   ==
 Files 187  127  -60 
 Lines7137 3347-3790 
 Branches  823  823  
   ==
   - Hits 4964 2281-2683 
   + Misses   1886 1066 -820 
   + Partials  2870 -287 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `68.15% <ø> (-0.06%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==)
 | `70.49% <0.00%> (-3.28%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | | |
   | 
[api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv)
 | | |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | | |
   | 
[api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==)
 | | |
   | 
[api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=)
 | | |
   | 
[api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [apisix-go-plugin-runner] A11enHuang opened a new issue #41: bug: invalid memory address or nil pointer dereference

[GitBox]

A11enHuang opened a new issue #41:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/41


   ### Issue description
   
   ### Environment
   
   * APISIX Go Plugin Runner's version: 0.0.2
   * APISIX version: 2.9
   * Go version: 1.16
   * OS (cmd: `uname -a`): Linux apisix-server-6c484454b4-gvgbt 
5.14.1-1.el7.elrepo.x86_64 #1 SMP Wed Sep 1 18:34:12 EDT 2021 x86_64 x86_64 
x86_64 GNU/Linux(docker部署)
   
   给某个路由定义好go-pre-plugin一段时间后(可能是因为长时间没有请求)，go plugin会出错导致接口无法访问。异常信息:
   2021/10/08 03:03:14 [warn] 56#56: *207 [lua] init.lua:681: 
2021-10-08T03:03:14.440Z  ERROR   server/server.go:69 panic recovered: 
runtime error: invalid memory address or nil pointer dereference
   2021/10/8 上午11:03:14 
github.com/apache/apisix-go-plugin-runner/internal/server.recoverPanic
   2021/10/8 上午11:03:14 
/var/lib/jenkins/workspace/build-dev-apple-fuller-apisix-go-plugin-runner/apisix-go-plugin-runner/internal/server/server.go:69
   2021/10/8 上午11:03:14 runtime.gopanic
   2021/10/8 上午11:03:14 /root/go/src/runtime/panic.go:1038
   2021/10/8 上午11:03:14 runtime.panicmem
   2021/10/8 上午11:03:14 /root/go/src/runtime/panic.go:221
   2021/10/8 上午11:03:14 runtime.sigpanic
   2021/10/8 上午11:03:14 /root/go/src/runtime/signal_unix.go:735
   2021/10/8 上午11:03:14 github.com/google/flatbuffers/go.(*Builder).Reset
   2021/10/8 上午11:03:14 
/root/go-path/pkg/mod/github.com/google/flatbuffers@v2.0.0+incompatible/go/builder.go:45
   2021/10/8 上午11:03:14 
github.com/apache/apisix-go-plugin-runner/internal/util.PutBuilder
   2021/10/8 上午11:03:14 
/var/lib/jenkins/workspace/build-dev-apple-fuller-apisix-go-plugin-runner/apisix-go-plugin-runner/internal/util/pool.go:37
   2021/10/8 上午11:03:14 
github.com/apache/apisix-go-plugin-runner/internal/server.handleConn
   2021/10/8 上午11:03:14 
/var/lib/jenkins/workspace/build-dev-apple-fuller-apisix-go-plugin-runner/apisix-go-plugin-runner/internal/server/server.go:122
   2021/10/8 上午11:03:14 , context: ngx.timer
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org