[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2200:
URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (95c5685) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `5.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2200  +/-   ##
   ==
   - Coverage   68.02%   62.09%   -5.93% 
   ==
 Files 127   57  -70 
 Lines3359 3905 +546 
 Branches  8260 -826 
   ==
   + Hits 2285 2425 +140 
   - Misses   1074 1200 +126 
   - Partials0  280 +280 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `40.51% <ø> (?)` | |
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz)
 | | |
   | 
[web/src/components/Upstream/components/Timeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZW91dC50c3g=)
 | | |
   | 
[web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=)
 | | |
   | 
[web/src/components/Upstream/components/TLS.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVExTLnRzeA==)
 | | |
   | 
[...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==)
 | | |
   | 
[web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=)
 | | |
   | 
[...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=)
 | | |
   | 

[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760838391



##
File path: docs/zh/latest/plugins/rocketmq-logger.md
##
@@ -0,0 +1,229 @@
+---
+title: rocketmq-logger
+---
+
+
+
+## 目录
+
+- [**简介**](#简介)
+- [**属性**](#属性)
+- [**工作原理**](#工作原理)
+- [**如何启用**](#如何启用)
+- [**测试插件**](#测试插件)
+- [**禁用插件**](#禁用插件)
+
+## 简介
+
+`rocketmq-logger` 插件利用ngx_lua客户端能力,可推送JSON格式的请求日志到外部rocketmq集群。
+
+它可以将接口请求日志以 JSON 的形式推送给外部 rocketmq 
集群。如果在短时间内没有收到日志数据,请放心,它会在我们的批处理处理器中的计时器功能到期后自动发送日志。

Review comment:
   ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao edited a comment on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox


shuaijinchao edited a comment on issue #5658:
URL: https://github.com/apache/apisix/issues/5658#issuecomment-984375154


   > > @lihuawei321 @saintak @jiangkaiyuan98 Thanks feedback. Reopen and 
compression will cause log record exceptions. We will fix this problem in the 
latest version.
   > 
   > 能否加个feature,把tar czvf 改成gzip,后者更方便后续分析。在只有一个文件需要处理的时候打成一个tar包问题多多
   
   Good idea, maybe can consider supporting two compression modes. But the 
essential reason for this problem is the execution sequence of `compression` 
and `reopen`. Are you interested in fix this problem?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760838167



##
File path: docs/en/latest/plugins/rocketmq-logger.md
##
@@ -0,0 +1,234 @@
+---
+title: rocketmq-logger
+---
+
+
+
+## Summary
+
+- [**Name**](#name)
+- [**Attributes**](#attributes)
+- [**Info**](#info)
+- [**How To Enable**](#how-to-enable)
+- [**Test Plugin**](#test-plugin)
+- [**Disable Plugin**](#disable-plugin)
+
+## Name
+
+`rocketmq-logger` is a plugin which provides the ability to push requests log 
data as JSON objects to your external rocketmq clusters.
+
+This plugin provides the ability to push requests log data as JSON objects to 
your external rocketmq clusters. In case if you did not receive the log data 
don't worry give it some time it will automatically send the logs after the 
timer function expires in our Batch Processor.

Review comment:
   duplication deleted now , that was copied from kafka-logger




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760837218



##
File path: docs/en/latest/plugins/rocketmq-logger.md
##
@@ -0,0 +1,234 @@
+---
+title: rocketmq-logger
+---
+
+
+
+## Summary
+
+- [**Name**](#name)
+- [**Attributes**](#attributes)
+- [**Info**](#info)
+- [**How To Enable**](#how-to-enable)
+- [**Test Plugin**](#test-plugin)
+- [**Disable Plugin**](#disable-plugin)
+
+## Name
+
+`rocketmq-logger` is a plugin which provides the ability to push requests log 
data as JSON objects to your external rocketmq clusters.
+
+This plugin provides the ability to push requests log data as JSON objects to 
your external rocketmq clusters. In case if you did not receive the log data 
don't worry give it some time it will automatically send the logs after the 
timer function expires in our Batch Processor.
+
+For more info on Batch-Processor in Apache APISIX please refer.
+[Batch-Processor](../batch-processor.md)
+
+## Attributes
+
+| Name | Type| Requirement | Default| Valid   | 
Description 
 |
+|  | --- | --- | -- | --- | 

 |
+| nameserver_list  | object  | required|| | An 
array of rocketmq nameservers.  
 |
+| topic| string  | required|| | Target 
 topic to push data.
  |
+| key  | string  | optional|| | Keys 
of messages to send.   |
+| tag  | string  | optional   || | Tags of 
messages to send.   |
+| timeout  | integer | optional| 3  | [1,...] | 
Timeout for the upstream to send data.  
 |
+| use_tls  | boolean | optional   | false  | | Whether 
to open TLS  |
+| access_key   | string  | optional   | "" | | access 
key for ACL, empty string means disable ACL. |
+| secret_key   | string  | optional   | "" | | secret 
key for ACL。 |
+| name | string  | optional| "rocketmq logger" | | A  
unique identifier to identity the batch processor.  
   |
+| meta_format  | enum| optional| "default"  | 
["default","origin"] | `default`: collect the request information with default 
JSON way. `origin`: collect the request information with original HTTP request. 
[example](#examples-of-meta_format)|
+| batch_max_size   | integer | optional| 1000   | [1,...] | Set 
the maximum number of logs sent in each batch. When the number of logs reaches 
the set maximum, all logs will be automatically pushed to the `rocketmq` 
service. |
+| inactive_timeout | integer | optional| 5  | [1,...] | The 
maximum time to refresh the buffer (in seconds). When the maximum refresh time 
is reached, all logs will be automatically pushed to the `rocketmq` service 
regardless of whether the number of logs in the buffer reaches the set maximum 
number. |
+| buffer_duration  | integer | optional| 60 | [1,...] | 
Maximum age in seconds of the oldest entry in a batch before the batch must be 
processed.|
+| max_retry_count  | integer | optional| 0  | [0,...] | 
Maximum number of retries before removing from the processing pipe line.
 |
+| retry_delay  | integer | optional| 1  | [0,...] | Number 
of seconds the process execution should be delayed if the execution fails.  
  |
+| include_req_body | boolean | optional| false  | [false, true] | 
Whether to include the request body. false: indicates that the requested body 
is not included; true: indicates that the requested body is included. Note: if 
the request body is too big to be kept in the memory, it can't be logged due to 
Nginx's limitation. |
+| include_req_body_expr  | array  | optional|  | | When 
`include_req_body` is true, control the behavior based on the result of the 
[lua-resty-expr](https://github.com/api7/lua-resty-expr) expression. If 
present, only log the request body when the result is true. |
+| include_resp_body| boolean | optional| false | [false, true] | 
Whether to include the response body. The response body is included if and only 
if it is `true`. |
+| include_resp_body_expr  | array  | optional|  | | When 
`include_resp_body` is true, control the behavior based on the result of the 

[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760837115



##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,271 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local pairs= pairs
+local type = type
+local ipairs   = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local timer_at = ngx.timer.at
+local ngx = ngx
+local buffers = {}

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760836989



##
File path: ci/pod/docker-compose.yml
##
@@ -355,10 +355,34 @@ services:
 networks:
   apisix_net:
 
+  namesrv:

Review comment:
   @leslie-tsang thanks, I found another way




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox


shuaijinchao commented on issue #5658:
URL: https://github.com/apache/apisix/issues/5658#issuecomment-984375154


   > > @lihuawei321 @saintak @jiangkaiyuan98 Thanks feedback. Reopen and 
compression will cause log record exceptions. We will fix this problem in the 
latest version.
   > 
   > 能否加个feature,把tar czvf 改成gzip,后者更方便后续分析。在只有一个文件需要处理的时候打成一个tar包问题多多
   
   Good idea, maybe can consider supporting two compression modes. But the 
essential reason for this problem is the execution sequence of "compression" 
and "reopening". Are you interested in fix this problem?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (5bd53b2) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `18.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2233   +/-   ##
   ===
   - Coverage   68.02%   49.16%   -18.87% 
   ===
 Files 127   41   -86 
 Lines3359 3171  -188 
 Branches  8260  -826 
   ===
   - Hits 2285 1559  -726 
   - Misses   1074 1412  +338 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==)
 | | |
   | 
[web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4)
 | | |
   | 
[web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==)
 | | |
   | 
[web/src/pages/PluginTemplate/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9MaXN0LnRzeA==)
 | | |
   | 
[web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=)
 | | |
   | 
[...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==)
 | | |
   | 
[web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9nbG9iYWwudHN4)
 | | |
   | 
[...pages/Route/components/CreateStep4/CreateStep4.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0NyZWF0ZVN0ZXA0L0NyZWF0ZVN0ZXA0LnRzeA==)
 | | |
   | 

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (180ea76) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `18.86%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 180ea76 differs from pull request most recent 
head 5bd53b2. Consider uploading reports for the commit 5bd53b2 to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2233   +/-   ##
   ===
   - Coverage   68.02%   49.16%   -18.87% 
   ===
 Files 127   41   -86 
 Lines3359 3171  -188 
 Branches  8260  -826 
   ===
   - Hits 2285 1559  -726 
   - Misses   1074 1412  +338 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==)
 | | |
   | 
[web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==)
 | | |
   | 
[web/src/app.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hcHAudHN4)
 | | |
   | 
[web/src/pages/Consumer/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9zZXJ2aWNlLnRz)
 | | |
   | 
[...rc/components/Upstream/components/UpstreamType.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVXBzdHJlYW1UeXBlLnRzeA==)
 | | |
   | 
[web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4)
 | | |
   | 
[...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==)
 | | |
   | 

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2200:
URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (95c5685) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `18.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2200   +/-   ##
   ===
   - Coverage   68.02%   49.16%   -18.87% 
   ===
 Files 127   41   -86 
 Lines3359 3171  -188 
 Branches  8260  -826 
   ===
   - Hits 2285 1559  -726 
   - Misses   1074 1412  +338 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/pages/SSL/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMS9pbmRleC50c3g=)
 | | |
   | 
[web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz)
 | | |
   | 
[...components/active-check/Unhealthy/HttpFailures.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9IdHRwRmFpbHVyZXMudHN4)
 | | |
   | 
[...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==)
 | | |
   | 
[web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==)
 | | |
   | 
[...pages/Route/components/Step1/RequestConfigView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1JlcXVlc3RDb25maWdWaWV3LnRzeA==)
 | | |
   | 
[web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==)
 | | |
   | 

[GitHub] [apisix] tzssangglass commented on issue #5654: bug: URI encoding issue

2021-12-01 Thread GitBox


tzssangglass commented on issue #5654:
URL: https://github.com/apache/apisix/issues/5654#issuecomment-984370324


   Based on this configuration, what do you want to achieve and what are the 
expected results?
   
   > I created a route
   > /api/v1/groups/*
   > and made a URI Override
   > Regexp: /api(/v1/groups/.*)
   > now, I am trying this url
   > 127.0.0.1:9080/api/v1/groups/
   > and facing this issue
   > HTTP Status 400 – Bad Request
   > submitted request
   > 
[mydomain.com/api/v1/groups/%3CNumber%3E](https://mydomain.com/api/v1/groups/%3CNumber%3E)
   > forwarded request
   > 127.0.0.1:9080/api/v1/groups/
   
   there is some confusion here, I cannot got it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2200:
URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (78a627d) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `5.51%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2200  +/-   ##
   ==
   - Coverage   68.02%   62.50%   -5.52% 
   ==
 Files 127   57  -70 
 Lines3359 3905 +546 
 Branches  8260 -826 
   ==
   + Hits 2285 2441 +156 
   - Misses   1074 1180 +106 
   - Partials0  284 +284 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `40.89% <ø> (?)` | |
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...components/PluginFlow/components/Toolbar/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9Ub29sYmFyL2luZGV4LnRzeA==)
 | | |
   | 
[...tream/components/active-check/Healthy/Interval.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSW50ZXJ2YWwudHN4)
 | | |
   | 
[...src/pages/SSL/components/CertificateForm/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZUZvcm0vaW5kZXgudHN4)
 | | |
   | 
[web/src/pages/Service/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvUHJldmlldy50c3g=)
 | | |
   | 
[web/src/pages/Route/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9zZXJ2aWNlLnRz)
 | | |
   | 
[...am/components/passive-check/Unhealthy/Timeouts.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9VbmhlYWx0aHkvVGltZW91dHMudHN4)
 | | |
   | 
[web/src/pages/Service/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvU3RlcDEudHN4)
 | | |
   | 

[GitHub] [apisix] saintak commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox


saintak commented on issue #5658:
URL: https://github.com/apache/apisix/issues/5658#issuecomment-984366399


   > @lihuawei321 @saintak @jiangkaiyuan98 Thanks feedback. Reopen and 
compression will cause log record exceptions. We will fix this problem in the 
latest version.
   
   能否加个feature,把tar czvf 改成gzip,后者更方便后续分析。在只有一个文件需要处理的时候打成一个tar包问题多多:
   less tar.gz 我们会看到如下内容:
   
   -rw-r--r-- nobody/root 203 2021-12-02 15:35 
2021-12-02_15-34-00__error.log
   2021-12-02_15-34-00__error.log.tar.gz (END)
   zcat tar.gz 是这样的:
   zcat 2021-12-02_15-34-00__error.log.tar.gz
   
2021-12-02_15-34-00__error.log64414300031314152073437014142 
0ustar  nobodyroot2021/12/02 15:34:55 [warn] 4012#4012: *2507624 [lua] 
log-rotate.lua:138: rotate_file(): remove uncompressed log file: 
/usr/local/apisix/logs/2021-12-02_15-34-00__access.log ret: true, context: 
ngx.timer
   这样对后续统计分析和查看都是很不利的,相反使用gzip之后:
   less 2021-12-02_15-34-00__error.log.gz可以直接显示log内容(而不是文件信息)
   zcat 2021-12-02_15-34-00__error.log.gz
   2021/12/02 15:36:00 [warn] 4012#4012: *2510131 [lua] log-rotate.lua:138: 
rotate_file(): remove uncompressed log file: 
/usr/local/apisix/logs/2021-12-02_15-34-00__access.log ret: true, context: 
ngx.timer
   而且gzip无论是压缩还是解压会默认删除源文件。无需你们再清理原来的文件了。很方便
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2200:
URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (78a627d) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `18.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2200   +/-   ##
   ===
   - Coverage   68.02%   49.16%   -18.87% 
   ===
 Files 127   41   -86 
 Lines3359 3171  -188 
 Branches  8260  -826 
   ===
   - Hits 2285 1559  -726 
   - Misses   1074 1412  +338 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Upstream/components/TLS.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVExTLnRzeA==)
 | | |
   | 
[.../src/pages/Route/components/Step1/ProxyRewrite.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1Byb3h5UmV3cml0ZS50c3g=)
 | | |
   | 
[...eam/components/passive-check/Healthy/Successes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9IZWFsdGh5L1N1Y2Nlc3Nlcy50c3g=)
 | | |
   | 
[web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=)
 | | |
   | 
[web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==)
 | | |
   | 
[web/src/components/Upstream/components/Timeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZW91dC50c3g=)
 | | |
   | 
[...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4)
 | | |
   | 
[web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4)
 | | |
  

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5664: docs: documenting url path forwarding for faas plugins

2021-12-01 Thread GitBox


bisakhmondal commented on a change in pull request #5664:
URL: https://github.com/apache/apisix/pull/5664#discussion_r760826430



##
File path: docs/en/latest/plugins/aws-lambda.md
##
@@ -136,6 +137,43 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 
'X-API-KEY: edd1c9f034335f13
 
 **Note**: This approach assumes you already have an iam user with the 
programmatic access enabled and required permissions 
(`AmazonAPIGatewayInvokeFullAccess`) to access the endpoint.
 
+### Plugin with Path Forwarding
+
+AWS Lambda plugin supports url path forwarding while proxying request to the 
modified upstream (AWS Gateway URI endpoint). With that being said, any 
extension to the path of the base request APISIX gateway URI gets "appended" 
(path join) to the `function_uri` specified in the plugin configuration. To 
test this behavior, see the below example:

Review comment:
   Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2200:
URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (c27bb9a) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/a55568408cec5eb2628971d2098a9bef992ff548?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (a555684) will **decrease** coverage by `13.26%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2200   +/-   ##
   ===
   - Coverage   62.43%   49.16%   -13.27% 
   ===
 Files  57   41   -16 
 Lines3905 3171  -734 
   ===
   - Hits 2438 1559  -879 
   - Misses   1185 1412  +227 
   + Partials  282  200   -82 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-unit-test | `49.16% <0.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-70.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-68.19%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 

[GitHub] [apisix] saintak commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox


saintak commented on issue #5658:
URL: https://github.com/apache/apisix/issues/5658#issuecomment-984363130


   > @saintak the #5663 question, have you tried to check the file size several 
times without compression and check the integrity of the file content?
   > 
   > 
![image](https://user-images.githubusercontent.com/8529452/144373536-ec596820-7803-414d-bbc2-ca1321fadb92.png)
   
   没有尝试,我们需要启用压缩,所以没有测试不压缩的情况。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox


shuaijinchao commented on issue #5658:
URL: https://github.com/apache/apisix/issues/5658#issuecomment-984360063


   @lihuawei321  @saintak @jiangkaiyuan98  Thanks feedback. Reopen and 
compression will cause log record exceptions. We will fix this problem in the 
latest version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-helm-chart] Gallardot opened a new pull request #185: feat: add extra labels and annotations for service monitor

2021-12-01 Thread GitBox


Gallardot opened a new pull request #185:
URL: https://github.com/apache/apisix-helm-chart/pull/185


   If 
[servicemonitors.matchLabels](https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/user-guides/getting-started.md#include-servicemonitors)
 are enabled, we need some extra labels for service monitor
   
   
   
   link: #76 #87


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-go-plugin-runner] hwyzleo commented on issue #49: register plugin success but do not match it when i visit the route

2021-12-01 Thread GitBox


hwyzleo commented on issue #49:
URL: 
https://github.com/apache/apisix-go-plugin-runner/issues/49#issuecomment-984358874


   > Could you run the runner with ` -m dev` and see if it has received the RPC 
from the APISIX during the request?
   
   by the go-runner log, i thought the handleConn function is not be called, 
but i didn't find any error in apisix log during the request, how to 
troubleshoot?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] yzeng25 commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


yzeng25 commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760819633



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。
+tags: [Technology]
+---
+
+> 本文介绍了 Apache APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions 
集成到 Apache APISIX 中。
+
+
+
+Apache APISIX 为 Microsoft Azure Functions 提供了对 serverless 框架的支持。Apache APISIX 
建议定义一个启用了无服务器插件的路由,而不是在应用程序中硬编码函数URL。它使开发者能够灵活地热更新函数 URI。此外,因为 Apache APISIX 
有非常强大的认证支持,这种方法还可以减轻应用逻辑中的授权和认证问题,可以用来识别和授权客户消费者访问带有 FAAS 的特定路由。本文介绍了 Apache 
APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions(一种广泛使用的 serverless 
解决方案)集成到 Apache APISIX 中。
+
+## azure-functions 插件工作原理
+
+`azure-functions` 插件让用户为网关 URI 定义一个上游的 azure `HTTP Trigger` serverless 
功能。如果启用,该插件将终止正在进行的对该 URI 的请求,并代表客户向 azure 
FAAS(新的上游)发起一个新的请求,其中包括用户设置的合适的授权细节、请求头、请求体、参数(这三个部分都是从原始请求中传递的),并将响应体、状态码和头返回给向
 Apache APISIX 代理发出请求的原始客户。
+
+该插件支持通过 API 密钥和 azure active directory 对 azure FAAS 服务进行授权。
+
+## 如何在 Apache APISIX 中使用 azure-functions 插件
+
+该插件的主要目标是将路由配置中指定的网关路由代理到 azure function URI 上。本节为您介绍如何在 azure 云上配置和创建 
serverless HTTP Trigger。
+
+1. 首先进入 Azure 
并设置一个试用计划,最多可免费调用100万次。要了解更多关于定价的情况,请访问[这里](https://azure.microsoft.com/en-us/services/functions/#pricing)。
+
+1. 访问[Azure Portal](https://portal.azure.com/#home)。
+1. 首先,创建一个资源组,为 FAAS 创建逻辑分区。
+
![创建资源组](https://static.apiseven.com/202108/1638349069240-911b8640-2de6-4f82-b75b-fb937b0bad40.png)
+1. 用你选择的 URL 创建一个 function 应用。
+![创建一个 function 
应用](https://static.apiseven.com/202108/1638349121520-01abe8e6-bc09-4be7-b010-f7baec59f89a.png)
+
+1. 在 VSCode 编辑器中安装 [Azure Functions 
插件](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions)。安装后,通过插件认证,并安装
 azure function core tool,用于本地开发。
+
+```shell
+npm install -g azure-functions-core-tools@3 --unsafe-perm true
+```
+
+1. 将下面的代码段部署到我们刚才通过 VSCode 中的 Azure Functions 扩展面板创建的同一个function 应用中。

Review comment:
   yes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760803422



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。
+tags: [Technology]
+---
+
+> 本文介绍了 Apache APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions 
集成到 Apache APISIX 中。
+
+
+
+Apache APISIX 为 Microsoft Azure Functions 提供了对 serverless 框架的支持。Apache APISIX 
建议定义一个启用了无服务器插件的路由,而不是在应用程序中硬编码函数URL。它使开发者能够灵活地热更新函数 URI。此外,因为 Apache APISIX 
有非常强大的认证支持,这种方法还可以减轻应用逻辑中的授权和认证问题,可以用来识别和授权客户消费者访问带有 FAAS 的特定路由。本文介绍了 Apache 
APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions(一种广泛使用的 serverless 
解决方案)集成到 Apache APISIX 中。
+
+## azure-functions 插件工作原理
+
+`azure-functions` 插件让用户为网关 URI 定义一个上游的 azure `HTTP Trigger` serverless 
功能。如果启用,该插件将终止正在进行的对该 URI 的请求,并代表客户向 azure 
FAAS(新的上游)发起一个新的请求,其中包括用户设置的合适的授权细节、请求头、请求体、参数(这三个部分都是从原始请求中传递的),并将响应体、状态码和头返回给向
 Apache APISIX 代理发出请求的原始客户。
+
+该插件支持通过 API 密钥和 azure active directory 对 azure FAAS 服务进行授权。
+
+## 如何在 Apache APISIX 中使用 azure-functions 插件
+
+该插件的主要目标是将路由配置中指定的网关路由代理到 azure function URI 上。本节为您介绍如何在 azure 云上配置和创建 
serverless HTTP Trigger。
+
+1. 首先进入 Azure 
并设置一个试用计划,最多可免费调用100万次。要了解更多关于定价的情况,请访问[这里](https://azure.microsoft.com/en-us/services/functions/#pricing)。
+
+1. 访问[Azure Portal](https://portal.azure.com/#home)。
+1. 首先,创建一个资源组,为 FAAS 创建逻辑分区。
+
![创建资源组](https://static.apiseven.com/202108/1638349069240-911b8640-2de6-4f82-b75b-fb937b0bad40.png)
+1. 用你选择的 URL 创建一个 function 应用。
+![创建一个 function 
应用](https://static.apiseven.com/202108/1638349121520-01abe8e6-bc09-4be7-b010-f7baec59f89a.png)
+
+1. 在 VSCode 编辑器中安装 [Azure Functions 
插件](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions)。安装后,通过插件认证,并安装
 azure function core tool,用于本地开发。
+
+```shell
+npm install -g azure-functions-core-tools@3 --unsafe-perm true
+```
+
+1. 将下面的代码段部署到我们刚才通过 VSCode 中的 Azure Functions 扩展面板创建的同一个function 应用中。
+
+```javascript
+module.exports = async function (context, req) {
+context.log('HTTP trigger invoked on Test-APISIX.')
+
+const name = req.query.name || (req.body && req.body.name)
+const responseMessage = name
+? 'Hello, ' + name
+: 'This HTTP triggered function executed successfully. Pass a name in 
the query string or in the request body to generate a personalized response.'
+
+context.res = {
+// status: 200, /* Defaults to 200 */
+body: responseMessage,
+}
+}
+```
+
+> 这个代码段从查询参数中获取用户名字(如果不存在,则从请求体中获取)并向用户问好。
+
+### 启用 azure-functions 插件
+
+下面是一个例子,说明如何为一个特定的路由启用 azure-functions 插件。我们假设你的 HTTP Trigger 已经部署并准备好提供服务。
+
+```shell
+# enable plugin for a specific route
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"plugins": {
+"azure-functions": {
+"function_uri": 
"http://test-apisix.azurewebsites.net/api/HttpTrigger;,
+"authorization": {
+"apikey": ""
+}
+}
+},
+"uri": "/azure"
+}'
+```
+
+现在,任何对 Apache APISIX 网关上的 URI `/azure` 的请求(HTTP/1.1、HTTPS、HTTP2)都将触发对上述函数 URI 
的 HTTP 调用,响应体与响应头和响应代码将被代理回给客户端。例如:
+
+```shell
+curl -i -XGET http://localhost:9080/azure\?name=Bisakh
+HTTP/1.1 200 OK
+Content-Type: text/plain; charset=utf-8
+Transfer-Encoding: chunked
+Connection: keep-alive
+Request-Context: appId=cid-v1:38aae829-293b-43c2-82c6-fa94aec0a071
+Date: Wed, 19 Nov 2021 18:46:55 GMT
+Server: APISIX/2.10.2
+
+Hello, Bisakh
+```
+
+考虑到,Apache APISIX 
也是在[config-default.yaml](https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L26)上以
 `enable_http2: true` 运行,端口为 9081,客户端和 Apache APISIX 代理之间的任何 `HTTP/2` 通信将被代理到 
azure faas,类似于 HTTP/1.1,响应将被代理回给客户端,并有适当的标题,例如:
+
+```shell
+curl -i -XGET --http2 --http2-prior-knowledge 
http://localhost:9081/azure\?name=Bisakh
+HTTP/2 200
+content-type: text/plain; charset=utf-8
+request-context: appId=cid-v1:38aae829-293b-43c2-82c6-fa94aec0a071
+Date: Wed, 19 Nov 2021 18:46:56 GMT
+server: APISIX/2.10.2
+
+Hello, Bisakh
+```
+
+### 停用 azure-functions 插件
+
+如果你要停用 azure-functions 该插件,只需在插件配置中删除相应的 JSON 
配置,禁用`azure-functions`插件,并添加合适的上游配置。Apache APISIX 插件是热加载的,因此不需要重新启动 Apache 
APISIX。
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/azure",
+"plugins": {},
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


juzhiyuan commented on a change in pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760810704



##
File path: web/src/components/Plugin/data.tsx
##
@@ -224,4 +224,22 @@ export const PLUGIN_LIST = {
 type: PluginType.other,
 hidden: true,
   },
+  'authz-casbin': {
+type: PluginType.authentication,
+  },
+  'ldap-auth': {
+type: PluginType.authentication,
+  },
+  datadog: {

Review comment:
   We don't need the `'` here  It's a key for JS's Object




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] juzhiyuan commented on issue #782: Prometheus doc 'Grafana dashboard meta ' file link is broken

2021-12-01 Thread GitBox


juzhiyuan commented on issue #782:
URL: https://github.com/apache/apisix-website/issues/782#issuecomment-984347270


   @huang-x-h may need your help here 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (612bd5f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **increase** coverage by `3.34%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2233  +/-   ##
   ==
   + Coverage   68.02%   71.37%   +3.34% 
   ==
 Files 127   57  -70 
 Lines3359 3905 +546 
 Branches  8260 -826 
   ==
   + Hits 2285 2787 +502 
   + Misses   1074  824 -250 
   - Partials0  294 +294 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `44.53% <ø> (?)` | |
   | backend-e2e-test-ginkgo | `52.18% <ø> (?)` | |
   | backend-unit-test | `49.13% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==)
 | | |
   | 
[web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz)
 | | |
   | 
[web/src/components/Upstream/components/Timeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZW91dC50c3g=)
 | | |
   | 
[web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=)
 | | |
   | 
[web/src/components/Upstream/components/TLS.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVExTLnRzeA==)
 | | |
   | 
[...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==)
 | | |
   | 
[web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=)
 | | |
   | 

[GitHub] [apisix] shuaijinchao edited a comment on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox


shuaijinchao edited a comment on issue #5658:
URL: https://github.com/apache/apisix/issues/5658#issuecomment-984346459


   @saintak the https://github.com/apache/apisix/issues/5663 question, have you 
tried to check the file size several times without compression and check the 
integrity of the file content?
   
   
![image](https://user-images.githubusercontent.com/8529452/144373536-ec596820-7803-414d-bbc2-ca1321fadb92.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] juzhiyuan commented on issue #698: Update SkyWalking plugin's docs

2021-12-01 Thread GitBox


juzhiyuan commented on issue #698:
URL: https://github.com/apache/apisix-website/issues/698#issuecomment-984347011


   Of course 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] juzhiyuan commented on pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


juzhiyuan commented on pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#issuecomment-984346588


   
![image](https://user-images.githubusercontent.com/2106987/144373912-6a86eaaf-ca57-430c-9ef1-98b17cb2948d.png)
   
   Thanks for @SylviaBABY's review! And we could use `insert suggestions` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox


shuaijinchao commented on issue #5658:
URL: https://github.com/apache/apisix/issues/5658#issuecomment-984346459


   @saintak the https://github.com/apache/apisix/issues/5663 question, have you 
tried to check the file size several times without compression?
   
   
![image](https://user-images.githubusercontent.com/8529452/144373536-ec596820-7803-414d-bbc2-ca1321fadb92.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] juzhiyuan merged pull request #783: docs: add weeklyreport 11.30

2021-12-01 Thread GitBox


juzhiyuan merged pull request #783:
URL: https://github.com/apache/apisix-website/pull/783


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-website] branch master updated: docs: add weeklyreport 11.30 (#783)

2021-12-01 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 5af2e5a  docs: add weeklyreport 11.30 (#783)
5af2e5a is described below

commit 5af2e5ae4afe21202f2c2fcc44d77db8db2c987e
Author: lijing-21 <88811141+lijing...@users.noreply.github.com>
AuthorDate: Thu Dec 2 15:02:11 2021 +0800

docs: add weeklyreport 11.30 (#783)
---
 website/blog/2021/12/02/weekly-report-1130.md  | 137 +
 .../2021/12/02/weekly-report-1130.md   | 127 +++
 2 files changed, 264 insertions(+)

diff --git a/website/blog/2021/12/02/weekly-report-1130.md 
b/website/blog/2021/12/02/weekly-report-1130.md
new file mode 100644
index 000..b1f8a63
--- /dev/null
+++ b/website/blog/2021/12/02/weekly-report-1130.md
@@ -0,0 +1,137 @@
+---
+title: Biweekly Report|11.15-11.30 Feature Highlights Update in Progress
+keywords:
+- Apache APISIX
+- Weekly Report
+- Contributor
+- APISIX
+- API Gateway
+- Apache
+description: The Apache APISIX Community Weekly Report hopes to help community 
members better understand the weekly progress of the Apache APISIX community 
and and facilitate everyone to participate in the Apache APISIX community.
+tags: [Events]
+---
+
+> From 11.15 to 11.30, 37 contributors submitted 87 commits for Apache APISIX. 
Thank you all for your contributions to Apache APISIX. It is your selfless 
contribution to make the Apache APISIX project better!
+
+
+
+## Introduction
+
+Apache APISIX has grown as a community from the first day of open source and 
has quickly become the most active open source API gateway project in the 
world. These achievements cannot be achieved without the joint efforts of our 
community partners.
+
+"If you want to go fast, go alone.If you want to go far, go together." The 
Apache APISIX Community Weekly Report hopes to help community members better 
understand the weekly progress of the Apache APISIX community and and 
facilitate everyone to participate in the Apache APISIX community.
+
+We have also compiled some issues suitable for newcomers to the community to 
participate in! If you are interested, don't miss it!
+
+## Contributor Statistics
+
+![Contributors 
List](https://static.apiseven.com/202108/1638346484091-37307b33-3e48-402f-9a72-3819e4217b29.png)
+
+![New 
Contributors](https://static.apiseven.com/202108/1638346484108-354ecbdd-a872-4a8f-b5c6-4903bad44eca.png)
+
+## Good first issue
+
+### Issue #5451
+
+**Link**: https://github.com/apache/apisix/issues/5451
+
+**Issue description**:
+
+Nginx comes with a response content replacement library that can replace 
partial content: http://nginx.org/en/docs/http/ngx_http_sub_module.html
+
+```Nginx
+sub_filter 'http://127.0.0.1:8080/'  'https://$host/';
+```
+
+There is a library that supports regular substitution (as I remember Openresty 
already supports it by default): ngx_http_substitutions_filter_module, which 
can replace content with regular expressions: 
ngx_http_substitutions_filter_module
+
+```Nginx
+subs_filter_types text/html text/css text/xml;
+subs_filter st(\d*).example.com $1.example.com ir;
+subs_filter a.example.com s.example.com;
+subs_filter http://$host https://$host;
+```
+
+However, it seems that APISIX's response-rewrite plugin only supports full 
replacement, which is equivalent to directly replacing all responses with the 
return set by the plugin, and does not support partial content replacement:
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1  -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"methods": ["GET"],
+"uri": "/test/index.html",
+"plugins": {
+"response-rewrite": {
+"body": "{\"code\":\"ok\",\"message\":\"new json body\"}",
+"headers": {
+"X-Server-id": 3,
+"X-Server-status": "on",
+"X-Server-balancer_addr": "$balancer_ip:$balancer_port"
+},
+"vars":[
+[ "status","==","200" ]
+]
+}
+},
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:80": 1
+}
+}
+}'
+```
+
+Does this plugin support partial replacement or regular replacement? If not, 
is there any other solution for APISIX?
+
+### Issue #5647
+
+**Link**: https://github.com/apache/apisix/issues/5647
+
+**Issue description**:
+
+The current documentation provides a way to install APISIX directly using RPM 
on CentOS7, but the current APISIX has switched its dependency to apisix-base 
version without providing its RPM installation method, which will cause the 
installation to fail.
+
+![Issue 
Screenshot](https://static.apiseven.com/202108/1638346839201-3efb9807-13a7-4106-968a-5198b22d1a67.png)
+
+Is it possible to add the command for installing the RPM for 

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (612bd5f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **increase** coverage by `3.34%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2233  +/-   ##
   ==
   + Coverage   68.02%   71.37%   +3.34% 
   ==
 Files 127   57  -70 
 Lines3359 3905 +546 
 Branches  8260 -826 
   ==
   + Hits 2285 2787 +502 
   + Misses   1074  824 -250 
   - Partials0  294 +294 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `44.53% <ø> (?)` | |
   | backend-e2e-test-ginkgo | `52.18% <ø> (?)` | |
   | backend-unit-test | `49.13% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==)
 | | |
   | 
[web/src/components/Plugin/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9zZXJ2aWNlLnRz)
 | | |
   | 
[web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz)
 | | |
   | 
[web/src/components/Plugin/UI/limit-conn.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb25uLnRzeA==)
 | | |
   | 
[...nents/PluginFlow/components/FlowGraph/FlowGraph.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvRmxvd0dyYXBoLnRz)
 | | |
   | 
[...pages/SSL/components/CertificateUploader/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZVVwbG9hZGVyL2luZGV4LnRzeA==)
 | | |
   | 
[web/src/pages/SSL/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMi9pbmRleC50c3g=)
 | | |
   | 
[web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=)
 | | |
   | 

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760804943



##
File path: website/blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "Apache APISIX intergration with Azure Serverless"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: This article talks about the recent addition of a new plugin 
`azure-functions`, and gives detailed instructions on how to integrate Azure 
Functions, which is a widely used serverless solution, into the Apache APISIX 
serverless suite.
+tags: [Technology]
+---
+
+> This article talks about the recent addition of a new plugin 
`azure-functions`, and gives detailed instructions on how to integrate Azure 
Functions, which is a widely used serverless solution, into the Apache APISIX 
serverless suite.
+
+
+
+Apache APISIX provides support for serverless frameworks for popular cloud 
vendors (more coming on the way). Instead of hardcoding the function URL into 
the application, Apache APISIX suggests defining a route with the serverless 
plugin enabled. It gives the developers the flexibility to hot update the 
function URI along with completely changing the faas vendor to a different 
cloud provider with zero hassle. Also, this approach mitigates authorization 
and authentication concerns from application logic as Apache APISIX has very 
strong authentication support that could be used to identify and authorize 
client consumers to access the particular route with the faas. This article 
talks about the recent addition of a new plugin `azure-functions`, and gives 
detailed instructions on how to integrate Azure Functions, which is a widely 
used serverless solution, into the Apache APISIX serverless suite.
+
+## How azure-functions plugin works
+
+The `azure-functions` plugin lets the users define an upstream to the azure 
`HTTP Trigger` serverless function for a gateway URI. If enabled, this plugin 
terminates the ongoing request to that particular URI and initiates a new 
request to the azure faas (the new upstream) on behalf of the client with the 
suitable authorization details set by the users, request headers, request body, 
params(all these three components are passed from the original request) and 
returns the response body, status code and the headers back to the original 
client that has invoked the request to the APISIX agent.
+
+The plugin supports authorization to azure faas service via API keys and azure 
active directory.
+
+## How to Use Azure Functions with Apache APISIX
+
+The primary goal of the plugin is to proxy the gateway route specified in the 
route configuration to the azure functions URI. This section gives you a 
hands-on how to configure and create a serverless HTTP Trigger on the azure 
cloud.
+
+1. First sign up/in to Microsoft Azure and sets up a trial plan. Azure 
Functions are forever free up to 1 million invocations. To know more about how 
the pricing, visit 
[here](https://azure.microsoft.com/en-us/services/functions/#pricing).
+
+1. Visit the [Azure Portal](https://portal.azure.com/#home) (FYI, azure 
services can be accessed via the web portal, CLI & VSCode. for 
user-friendliness we are using the web).
+1. First, create a resource group to logically partition your faas that's 
you are going to create.
+![create a resource 
group](https://static.apiseven.com/202108/1638349069240-911b8640-2de6-4f82-b75b-fb937b0bad40.png)
+1. Create a function app with the URL of your choice (I am going to pick 
test-apisix).
+![create a function 
app](https://static.apiseven.com/202108/1638349121520-01abe8e6-bc09-4be7-b010-f7baec59f89a.png)
+
+1. Install the [Azure Functions 
extension](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions)
 into VSCode editor. Upon installation, authenticate via extension and install 
the azure function core tool for local development with:
+
+```shell
+npm install -g azure-functions-core-tools@3 --unsafe-perm true
+```
+
+1. Deploy the following snippet to the same function app that we just created 
via the Azure Functions extension panel in VSCode:
+
+```javascript
+module.exports = async function (context, req) {
+context.log('HTTP trigger invoked on Test-APISIX.')
+
+const name = req.query.name || (req.body && req.body.name)
+const responseMessage = name
+? 'Hello, ' + name
+: 'This HTTP triggered function executed successfully. Pass a name in 
the query string or in the request body to generate a personalized response.'
+
+context.res = {
+// status: 200, /* Defaults to 200 */
+body: responseMessage,
+}
+}
+```
+
+> This snippet takes the name from query parameters (if present, else from 

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760804662



##
File path: website/blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "Apache APISIX intergration with Azure Serverless"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: This article talks about the recent addition of a new plugin 
`azure-functions`, and gives detailed instructions on how to integrate Azure 
Functions, which is a widely used serverless solution, into the Apache APISIX 
serverless suite.
+tags: [Technology]
+---
+
+> This article talks about the recent addition of a new plugin 
`azure-functions`, and gives detailed instructions on how to integrate Azure 
Functions, which is a widely used serverless solution, into the Apache APISIX 
serverless suite.
+
+
+
+Apache APISIX provides support for serverless frameworks for popular cloud 
vendors (more coming on the way). Instead of hardcoding the function URL into 
the application, Apache APISIX suggests defining a route with the serverless 
plugin enabled. It gives the developers the flexibility to hot update the 
function URI along with completely changing the faas vendor to a different 
cloud provider with zero hassle. Also, this approach mitigates authorization 
and authentication concerns from application logic as Apache APISIX has very 
strong authentication support that could be used to identify and authorize 
client consumers to access the particular route with the faas. This article 
talks about the recent addition of a new plugin `azure-functions`, and gives 
detailed instructions on how to integrate Azure Functions, which is a widely 
used serverless solution, into the Apache APISIX serverless suite.
+
+## How azure-functions plugin works
+
+The `azure-functions` plugin lets the users define an upstream to the azure 
`HTTP Trigger` serverless function for a gateway URI. If enabled, this plugin 
terminates the ongoing request to that particular URI and initiates a new 
request to the azure faas (the new upstream) on behalf of the client with the 
suitable authorization details set by the users, request headers, request body, 
params(all these three components are passed from the original request) and 
returns the response body, status code and the headers back to the original 
client that has invoked the request to the APISIX agent.
+
+The plugin supports authorization to azure faas service via API keys and azure 
active directory.
+
+## How to Use Azure Functions with Apache APISIX
+
+The primary goal of the plugin is to proxy the gateway route specified in the 
route configuration to the azure functions URI. This section gives you a 
hands-on how to configure and create a serverless HTTP Trigger on the azure 
cloud.
+
+1. First sign up/in to Microsoft Azure and sets up a trial plan. Azure 
Functions are forever free up to 1 million invocations. To know more about how 
the pricing, visit 
[here](https://azure.microsoft.com/en-us/services/functions/#pricing).
+
+1. Visit the [Azure Portal](https://portal.azure.com/#home) (FYI, azure 
services can be accessed via the web portal, CLI & VSCode. for 
user-friendliness we are using the web).
+1. First, create a resource group to logically partition your faas that's 
you are going to create.
+![create a resource 
group](https://static.apiseven.com/202108/1638349069240-911b8640-2de6-4f82-b75b-fb937b0bad40.png)
+1. Create a function app with the URL of your choice (I am going to pick 
test-apisix).
+![create a function 
app](https://static.apiseven.com/202108/1638349121520-01abe8e6-bc09-4be7-b010-f7baec59f89a.png)
+
+1. Install the [Azure Functions 
extension](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions)
 into VSCode editor. Upon installation, authenticate via extension and install 
the azure function core tool for local development with:
+
+```shell
+npm install -g azure-functions-core-tools@3 --unsafe-perm true
+```
+
+1. Deploy the following snippet to the same function app that we just created 
via the Azure Functions extension panel in VSCode:

Review comment:
   列表格式是否应为 1. 2. 3. 等




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760803624



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。
+tags: [Technology]
+---
+
+> 本文介绍了 Apache APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions 
集成到 Apache APISIX 中。
+
+
+
+Apache APISIX 为 Microsoft Azure Functions 提供了对 serverless 框架的支持。Apache APISIX 
建议定义一个启用了无服务器插件的路由,而不是在应用程序中硬编码函数URL。它使开发者能够灵活地热更新函数 URI。此外,因为 Apache APISIX 
有非常强大的认证支持,这种方法还可以减轻应用逻辑中的授权和认证问题,可以用来识别和授权客户消费者访问带有 FAAS 的特定路由。本文介绍了 Apache 
APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions(一种广泛使用的 serverless 
解决方案)集成到 Apache APISIX 中。
+
+## azure-functions 插件工作原理
+
+`azure-functions` 插件让用户为网关 URI 定义一个上游的 azure `HTTP Trigger` serverless 
功能。如果启用,该插件将终止正在进行的对该 URI 的请求,并代表客户向 azure 
FAAS(新的上游)发起一个新的请求,其中包括用户设置的合适的授权细节、请求头、请求体、参数(这三个部分都是从原始请求中传递的),并将响应体、状态码和头返回给向
 Apache APISIX 代理发出请求的原始客户。
+
+该插件支持通过 API 密钥和 azure active directory 对 azure FAAS 服务进行授权。
+
+## 如何在 Apache APISIX 中使用 azure-functions 插件
+
+该插件的主要目标是将路由配置中指定的网关路由代理到 azure function URI 上。本节为您介绍如何在 azure 云上配置和创建 
serverless HTTP Trigger。
+
+1. 首先进入 Azure 
并设置一个试用计划,最多可免费调用100万次。要了解更多关于定价的情况,请访问[这里](https://azure.microsoft.com/en-us/services/functions/#pricing)。
+
+1. 访问[Azure Portal](https://portal.azure.com/#home)。
+1. 首先,创建一个资源组,为 FAAS 创建逻辑分区。
+
![创建资源组](https://static.apiseven.com/202108/1638349069240-911b8640-2de6-4f82-b75b-fb937b0bad40.png)
+1. 用你选择的 URL 创建一个 function 应用。
+![创建一个 function 
应用](https://static.apiseven.com/202108/1638349121520-01abe8e6-bc09-4be7-b010-f7baec59f89a.png)
+
+1. 在 VSCode 编辑器中安装 [Azure Functions 
插件](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions)。安装后,通过插件认证,并安装
 azure function core tool,用于本地开发。
+
+```shell
+npm install -g azure-functions-core-tools@3 --unsafe-perm true
+```
+
+1. 将下面的代码段部署到我们刚才通过 VSCode 中的 Azure Functions 扩展面板创建的同一个function 应用中。

Review comment:
   这几个格式都是 1. 吗




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760803422



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。
+tags: [Technology]
+---
+
+> 本文介绍了 Apache APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions 
集成到 Apache APISIX 中。
+
+
+
+Apache APISIX 为 Microsoft Azure Functions 提供了对 serverless 框架的支持。Apache APISIX 
建议定义一个启用了无服务器插件的路由,而不是在应用程序中硬编码函数URL。它使开发者能够灵活地热更新函数 URI。此外,因为 Apache APISIX 
有非常强大的认证支持,这种方法还可以减轻应用逻辑中的授权和认证问题,可以用来识别和授权客户消费者访问带有 FAAS 的特定路由。本文介绍了 Apache 
APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions(一种广泛使用的 serverless 
解决方案)集成到 Apache APISIX 中。
+
+## azure-functions 插件工作原理
+
+`azure-functions` 插件让用户为网关 URI 定义一个上游的 azure `HTTP Trigger` serverless 
功能。如果启用,该插件将终止正在进行的对该 URI 的请求,并代表客户向 azure 
FAAS(新的上游)发起一个新的请求,其中包括用户设置的合适的授权细节、请求头、请求体、参数(这三个部分都是从原始请求中传递的),并将响应体、状态码和头返回给向
 Apache APISIX 代理发出请求的原始客户。
+
+该插件支持通过 API 密钥和 azure active directory 对 azure FAAS 服务进行授权。
+
+## 如何在 Apache APISIX 中使用 azure-functions 插件
+
+该插件的主要目标是将路由配置中指定的网关路由代理到 azure function URI 上。本节为您介绍如何在 azure 云上配置和创建 
serverless HTTP Trigger。
+
+1. 首先进入 Azure 
并设置一个试用计划,最多可免费调用100万次。要了解更多关于定价的情况,请访问[这里](https://azure.microsoft.com/en-us/services/functions/#pricing)。
+
+1. 访问[Azure Portal](https://portal.azure.com/#home)。
+1. 首先,创建一个资源组,为 FAAS 创建逻辑分区。
+
![创建资源组](https://static.apiseven.com/202108/1638349069240-911b8640-2de6-4f82-b75b-fb937b0bad40.png)
+1. 用你选择的 URL 创建一个 function 应用。
+![创建一个 function 
应用](https://static.apiseven.com/202108/1638349121520-01abe8e6-bc09-4be7-b010-f7baec59f89a.png)
+
+1. 在 VSCode 编辑器中安装 [Azure Functions 
插件](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions)。安装后,通过插件认证,并安装
 azure function core tool,用于本地开发。
+
+```shell
+npm install -g azure-functions-core-tools@3 --unsafe-perm true
+```
+
+1. 将下面的代码段部署到我们刚才通过 VSCode 中的 Azure Functions 扩展面板创建的同一个function 应用中。
+
+```javascript
+module.exports = async function (context, req) {
+context.log('HTTP trigger invoked on Test-APISIX.')
+
+const name = req.query.name || (req.body && req.body.name)
+const responseMessage = name
+? 'Hello, ' + name
+: 'This HTTP triggered function executed successfully. Pass a name in 
the query string or in the request body to generate a personalized response.'
+
+context.res = {
+// status: 200, /* Defaults to 200 */
+body: responseMessage,
+}
+}
+```
+
+> 这个代码段从查询参数中获取用户名字(如果不存在,则从请求体中获取)并向用户问好。
+
+### 启用 azure-functions 插件
+
+下面是一个例子,说明如何为一个特定的路由启用 azure-functions 插件。我们假设你的 HTTP Trigger 已经部署并准备好提供服务。
+
+```shell
+# enable plugin for a specific route
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"plugins": {
+"azure-functions": {
+"function_uri": 
"http://test-apisix.azurewebsites.net/api/HttpTrigger;,
+"authorization": {
+"apikey": ""
+}
+}
+},
+"uri": "/azure"
+}'
+```
+
+现在,任何对 Apache APISIX 网关上的 URI `/azure` 的请求(HTTP/1.1、HTTPS、HTTP2)都将触发对上述函数 URI 
的 HTTP 调用,响应体与响应头和响应代码将被代理回给客户端。例如:
+
+```shell
+curl -i -XGET http://localhost:9080/azure\?name=Bisakh
+HTTP/1.1 200 OK
+Content-Type: text/plain; charset=utf-8
+Transfer-Encoding: chunked
+Connection: keep-alive
+Request-Context: appId=cid-v1:38aae829-293b-43c2-82c6-fa94aec0a071
+Date: Wed, 19 Nov 2021 18:46:55 GMT
+Server: APISIX/2.10.2
+
+Hello, Bisakh
+```
+
+考虑到,Apache APISIX 
也是在[config-default.yaml](https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L26)上以
 `enable_http2: true` 运行,端口为 9081,客户端和 Apache APISIX 代理之间的任何 `HTTP/2` 通信将被代理到 
azure faas,类似于 HTTP/1.1,响应将被代理回给客户端,并有适当的标题,例如:
+
+```shell
+curl -i -XGET --http2 --http2-prior-knowledge 
http://localhost:9081/azure\?name=Bisakh
+HTTP/2 200
+content-type: text/plain; charset=utf-8
+request-context: appId=cid-v1:38aae829-293b-43c2-82c6-fa94aec0a071
+Date: Wed, 19 Nov 2021 18:46:56 GMT
+server: APISIX/2.10.2
+
+Hello, Bisakh
+```
+
+### 停用 azure-functions 插件
+
+如果你要停用 azure-functions 该插件,只需在插件配置中删除相应的 JSON 
配置,禁用`azure-functions`插件,并添加合适的上游配置。Apache APISIX 插件是热加载的,因此不需要重新启动 Apache 
APISIX。
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/azure",
+"plugins": {},
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760802617



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。
+tags: [Technology]
+---
+
+> 本文介绍了 Apache APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions 
集成到 Apache APISIX 中。
+
+
+
+Apache APISIX 为 Microsoft Azure Functions 提供了对 serverless 框架的支持。Apache APISIX 
建议定义一个启用了无服务器插件的路由,而不是在应用程序中硬编码函数URL。它使开发者能够灵活地热更新函数 URI。此外,因为 Apache APISIX 
有非常强大的认证支持,这种方法还可以减轻应用逻辑中的授权和认证问题,可以用来识别和授权客户消费者访问带有 FAAS 的特定路由。本文介绍了 Apache 
APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions(一种广泛使用的 serverless 
解决方案)集成到 Apache APISIX 中。
+
+## azure-functions 插件工作原理
+
+`azure-functions` 插件让用户为网关 URI 定义一个上游的 azure `HTTP Trigger` serverless 
功能。如果启用,该插件将终止正在进行的对该 URI 的请求,并代表客户向 azure 
FAAS(新的上游)发起一个新的请求,其中包括用户设置的合适的授权细节、请求头、请求体、参数(这三个部分都是从原始请求中传递的),并将响应体、状态码和头返回给向
 Apache APISIX 代理发出请求的原始客户。
+
+该插件支持通过 API 密钥和 azure active directory 对 azure FAAS 服务进行授权。
+
+## 如何在 Apache APISIX 中使用 azure-functions 插件
+
+该插件的主要目标是将路由配置中指定的网关路由代理到 azure function URI 上。本节为您介绍如何在 azure 云上配置和创建 
serverless HTTP Trigger。
+
+1. 首先进入 Azure 
并设置一个试用计划,最多可免费调用100万次。要了解更多关于定价的情况,请访问[这里](https://azure.microsoft.com/en-us/services/functions/#pricing)。
+
+1. 访问[Azure Portal](https://portal.azure.com/#home)。
+1. 首先,创建一个资源组,为 FAAS 创建逻辑分区。
+
![创建资源组](https://static.apiseven.com/202108/1638349069240-911b8640-2de6-4f82-b75b-fb937b0bad40.png)
+1. 用你选择的 URL 创建一个 function 应用。
+![创建一个 function 
应用](https://static.apiseven.com/202108/1638349121520-01abe8e6-bc09-4be7-b010-f7baec59f89a.png)
+
+1. 在 VSCode 编辑器中安装 [Azure Functions 
插件](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions)。安装后,通过插件认证,并安装
 azure function core tool,用于本地开发。
+
+```shell
+npm install -g azure-functions-core-tools@3 --unsafe-perm true
+```
+
+1. 将下面的代码段部署到我们刚才通过 VSCode 中的 Azure Functions 扩展面板创建的同一个function 应用中。
+
+```javascript
+module.exports = async function (context, req) {
+context.log('HTTP trigger invoked on Test-APISIX.')
+
+const name = req.query.name || (req.body && req.body.name)
+const responseMessage = name
+? 'Hello, ' + name
+: 'This HTTP triggered function executed successfully. Pass a name in 
the query string or in the request body to generate a personalized response.'
+
+context.res = {
+// status: 200, /* Defaults to 200 */
+body: responseMessage,
+}
+}
+```
+
+> 这个代码段从查询参数中获取用户名字(如果不存在,则从请求体中获取)并向用户问好。
+
+### 启用 azure-functions 插件
+
+下面是一个例子,说明如何为一个特定的路由启用 azure-functions 插件。我们假设你的 HTTP Trigger 已经部署并准备好提供服务。
+
+```shell
+# enable plugin for a specific route
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"plugins": {
+"azure-functions": {
+"function_uri": 
"http://test-apisix.azurewebsites.net/api/HttpTrigger;,
+"authorization": {
+"apikey": ""
+}
+}
+},
+"uri": "/azure"
+}'
+```
+
+现在,任何对 Apache APISIX 网关上的 URI `/azure` 的请求(HTTP/1.1、HTTPS、HTTP2)都将触发对上述函数 URI 
的 HTTP 调用,响应体与响应头和响应代码将被代理回给客户端。例如:
+
+```shell
+curl -i -XGET http://localhost:9080/azure\?name=Bisakh
+HTTP/1.1 200 OK
+Content-Type: text/plain; charset=utf-8
+Transfer-Encoding: chunked
+Connection: keep-alive
+Request-Context: appId=cid-v1:38aae829-293b-43c2-82c6-fa94aec0a071
+Date: Wed, 19 Nov 2021 18:46:55 GMT
+Server: APISIX/2.10.2
+
+Hello, Bisakh
+```
+
+考虑到,Apache APISIX 
也是在[config-default.yaml](https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L26)上以
 `enable_http2: true` 运行,端口为 9081,客户端和 Apache APISIX 代理之间的任何 `HTTP/2` 通信将被代理到 
azure faas,类似于 HTTP/1.1,响应将被代理回给客户端,并有适当的标题,例如:
+
+```shell
+curl -i -XGET --http2 --http2-prior-knowledge 
http://localhost:9081/azure\?name=Bisakh
+HTTP/2 200
+content-type: text/plain; charset=utf-8
+request-context: appId=cid-v1:38aae829-293b-43c2-82c6-fa94aec0a071
+Date: Wed, 19 Nov 2021 18:46:56 GMT
+server: APISIX/2.10.2
+
+Hello, Bisakh
+```
+
+### 停用 azure-functions 插件
+
+如果你要停用 azure-functions 该插件,只需在插件配置中删除相应的 JSON 
配置,禁用`azure-functions`插件,并添加合适的上游配置。Apache APISIX 插件是热加载的,因此不需要重新启动 Apache 
APISIX。
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/azure",
+"plugins": {},
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760801943



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。
+tags: [Technology]
+---
+
+> 本文介绍了 Apache APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions 
集成到 Apache APISIX 中。
+
+
+
+Apache APISIX 为 Microsoft Azure Functions 提供了对 serverless 框架的支持。Apache APISIX 
建议定义一个启用了无服务器插件的路由,而不是在应用程序中硬编码函数URL。它使开发者能够灵活地热更新函数 URI。此外,因为 Apache APISIX 
有非常强大的认证支持,这种方法还可以减轻应用逻辑中的授权和认证问题,可以用来识别和授权客户消费者访问带有 FAAS 的特定路由。本文介绍了 Apache 
APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions(一种广泛使用的 serverless 
解决方案)集成到 Apache APISIX 中。
+
+## azure-functions 插件工作原理
+
+`azure-functions` 插件让用户为网关 URI 定义一个上游的 azure `HTTP Trigger` serverless 
功能。如果启用,该插件将终止正在进行的对该 URI 的请求,并代表客户向 azure 
FAAS(新的上游)发起一个新的请求,其中包括用户设置的合适的授权细节、请求头、请求体、参数(这三个部分都是从原始请求中传递的),并将响应体、状态码和头返回给向
 Apache APISIX 代理发出请求的原始客户。
+
+该插件支持通过 API 密钥和 azure active directory 对 azure FAAS 服务进行授权。
+
+## 如何在 Apache APISIX 中使用 azure-functions 插件
+
+该插件的主要目标是将路由配置中指定的网关路由代理到 azure function URI 上。本节为您介绍如何在 azure 云上配置和创建 
serverless HTTP Trigger。
+
+1. 首先进入 Azure 
并设置一个试用计划,最多可免费调用100万次。要了解更多关于定价的情况,请访问[这里](https://azure.microsoft.com/en-us/services/functions/#pricing)。
+
+1. 访问[Azure Portal](https://portal.azure.com/#home)。
+1. 首先,创建一个资源组,为 FAAS 创建逻辑分区。
+
![创建资源组](https://static.apiseven.com/202108/1638349069240-911b8640-2de6-4f82-b75b-fb937b0bad40.png)
+1. 用你选择的 URL 创建一个 function 应用。
+![创建一个 function 
应用](https://static.apiseven.com/202108/1638349121520-01abe8e6-bc09-4be7-b010-f7baec59f89a.png)
+
+1. 在 VSCode 编辑器中安装 [Azure Functions 
插件](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions)。安装后,通过插件认证,并安装
 azure function core tool,用于本地开发。
+
+```shell
+npm install -g azure-functions-core-tools@3 --unsafe-perm true
+```
+
+1. 将下面的代码段部署到我们刚才通过 VSCode 中的 Azure Functions 扩展面板创建的同一个function 应用中。
+
+```javascript
+module.exports = async function (context, req) {
+context.log('HTTP trigger invoked on Test-APISIX.')
+
+const name = req.query.name || (req.body && req.body.name)
+const responseMessage = name
+? 'Hello, ' + name
+: 'This HTTP triggered function executed successfully. Pass a name in 
the query string or in the request body to generate a personalized response.'
+
+context.res = {
+// status: 200, /* Defaults to 200 */
+body: responseMessage,
+}
+}
+```
+
+> 这个代码段从查询参数中获取用户名字(如果不存在,则从请求体中获取)并向用户问好。
+
+### 启用 azure-functions 插件
+
+下面是一个例子,说明如何为一个特定的路由启用 azure-functions 插件。我们假设你的 HTTP Trigger 已经部署并准备好提供服务。
+
+```shell
+# enable plugin for a specific route
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"plugins": {
+"azure-functions": {
+"function_uri": 
"http://test-apisix.azurewebsites.net/api/HttpTrigger;,
+"authorization": {
+"apikey": ""
+}
+}
+},
+"uri": "/azure"
+}'
+```
+
+现在,任何对 Apache APISIX 网关上的 URI `/azure` 的请求(HTTP/1.1、HTTPS、HTTP2)都将触发对上述函数 URI 
的 HTTP 调用,响应体与响应头和响应代码将被代理回给客户端。例如:
+
+```shell
+curl -i -XGET http://localhost:9080/azure\?name=Bisakh
+HTTP/1.1 200 OK
+Content-Type: text/plain; charset=utf-8
+Transfer-Encoding: chunked
+Connection: keep-alive
+Request-Context: appId=cid-v1:38aae829-293b-43c2-82c6-fa94aec0a071
+Date: Wed, 19 Nov 2021 18:46:55 GMT
+Server: APISIX/2.10.2
+
+Hello, Bisakh
+```
+
+考虑到,Apache APISIX 
也是在[config-default.yaml](https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L26)上以
 `enable_http2: true` 运行,端口为 9081,客户端和 Apache APISIX 代理之间的任何 `HTTP/2` 通信将被代理到 
azure faas,类似于 HTTP/1.1,响应将被代理回给客户端,并有适当的标题,例如:
+
+```shell
+curl -i -XGET --http2 --http2-prior-knowledge 
http://localhost:9081/azure\?name=Bisakh
+HTTP/2 200
+content-type: text/plain; charset=utf-8
+request-context: appId=cid-v1:38aae829-293b-43c2-82c6-fa94aec0a071
+Date: Wed, 19 Nov 2021 18:46:56 GMT
+server: APISIX/2.10.2
+
+Hello, Bisakh
+```
+
+### 停用 azure-functions 插件
+
+如果你要停用 azure-functions 该插件,只需在插件配置中删除相应的 JSON 
配置,禁用`azure-functions`插件,并添加合适的上游配置。Apache APISIX 插件是热加载的,因此不需要重新启动 Apache 
APISIX。

Review comment:
   因为前文中出现的都是“您”,建议这里同步或者直接把人称代词去掉改为“如果需要停用x”




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To 

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760801356



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。
+tags: [Technology]
+---
+
+> 本文介绍了 Apache APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions 
集成到 Apache APISIX 中。
+
+
+
+Apache APISIX 为 Microsoft Azure Functions 提供了对 serverless 框架的支持。Apache APISIX 
建议定义一个启用了无服务器插件的路由,而不是在应用程序中硬编码函数URL。它使开发者能够灵活地热更新函数 URI。此外,因为 Apache APISIX 
有非常强大的认证支持,这种方法还可以减轻应用逻辑中的授权和认证问题,可以用来识别和授权客户消费者访问带有 FAAS 的特定路由。本文介绍了 Apache 
APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions(一种广泛使用的 serverless 
解决方案)集成到 Apache APISIX 中。
+
+## azure-functions 插件工作原理
+
+`azure-functions` 插件让用户为网关 URI 定义一个上游的 azure `HTTP Trigger` serverless 
功能。如果启用,该插件将终止正在进行的对该 URI 的请求,并代表客户向 azure 
FAAS(新的上游)发起一个新的请求,其中包括用户设置的合适的授权细节、请求头、请求体、参数(这三个部分都是从原始请求中传递的),并将响应体、状态码和头返回给向
 Apache APISIX 代理发出请求的原始客户。
+
+该插件支持通过 API 密钥和 azure active directory 对 azure FAAS 服务进行授权。
+
+## 如何在 Apache APISIX 中使用 azure-functions 插件
+
+该插件的主要目标是将路由配置中指定的网关路由代理到 azure function URI 上。本节为您介绍如何在 azure 云上配置和创建 
serverless HTTP Trigger。
+
+1. 首先进入 Azure 
并设置一个试用计划,最多可免费调用100万次。要了解更多关于定价的情况,请访问[这里](https://azure.microsoft.com/en-us/services/functions/#pricing)。
+
+1. 访问[Azure Portal](https://portal.azure.com/#home)。
+1. 首先,创建一个资源组,为 FAAS 创建逻辑分区。
+
![创建资源组](https://static.apiseven.com/202108/1638349069240-911b8640-2de6-4f82-b75b-fb937b0bad40.png)
+1. 用你选择的 URL 创建一个 function 应用。
+![创建一个 function 
应用](https://static.apiseven.com/202108/1638349121520-01abe8e6-bc09-4be7-b010-f7baec59f89a.png)
+
+1. 在 VSCode 编辑器中安装 [Azure Functions 
插件](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions)。安装后,通过插件认证,并安装
 azure function core tool,用于本地开发。
+
+```shell
+npm install -g azure-functions-core-tools@3 --unsafe-perm true
+```
+
+1. 将下面的代码段部署到我们刚才通过 VSCode 中的 Azure Functions 扩展面板创建的同一个function 应用中。
+
+```javascript
+module.exports = async function (context, req) {
+context.log('HTTP trigger invoked on Test-APISIX.')
+
+const name = req.query.name || (req.body && req.body.name)
+const responseMessage = name
+? 'Hello, ' + name
+: 'This HTTP triggered function executed successfully. Pass a name in 
the query string or in the request body to generate a personalized response.'
+
+context.res = {
+// status: 200, /* Defaults to 200 */
+body: responseMessage,
+}
+}
+```
+
+> 这个代码段从查询参数中获取用户名字(如果不存在,则从请求体中获取)并向用户问好。
+
+### 启用 azure-functions 插件
+
+下面是一个例子,说明如何为一个特定的路由启用 azure-functions 插件。我们假设你的 HTTP Trigger 已经部署并准备好提供服务。

Review comment:
   下面我们将通过一个示例为大家说明xx




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760801040



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。
+tags: [Technology]
+---
+
+> 本文介绍了 Apache APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions 
集成到 Apache APISIX 中。
+
+
+
+Apache APISIX 为 Microsoft Azure Functions 提供了对 serverless 框架的支持。Apache APISIX 
建议定义一个启用了无服务器插件的路由,而不是在应用程序中硬编码函数URL。它使开发者能够灵活地热更新函数 URI。此外,因为 Apache APISIX 
有非常强大的认证支持,这种方法还可以减轻应用逻辑中的授权和认证问题,可以用来识别和授权客户消费者访问带有 FAAS 的特定路由。本文介绍了 Apache 
APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions(一种广泛使用的 serverless 
解决方案)集成到 Apache APISIX 中。
+
+## azure-functions 插件工作原理
+
+`azure-functions` 插件让用户为网关 URI 定义一个上游的 azure `HTTP Trigger` serverless 
功能。如果启用,该插件将终止正在进行的对该 URI 的请求,并代表客户向 azure 
FAAS(新的上游)发起一个新的请求,其中包括用户设置的合适的授权细节、请求头、请求体、参数(这三个部分都是从原始请求中传递的),并将响应体、状态码和头返回给向
 Apache APISIX 代理发出请求的原始客户。
+
+该插件支持通过 API 密钥和 azure active directory 对 azure FAAS 服务进行授权。
+
+## 如何在 Apache APISIX 中使用 azure-functions 插件
+
+该插件的主要目标是将路由配置中指定的网关路由代理到 azure function URI 上。本节为您介绍如何在 azure 云上配置和创建 
serverless HTTP Trigger。
+
+1. 首先进入 Azure 
并设置一个试用计划,最多可免费调用100万次。要了解更多关于定价的情况,请访问[这里](https://azure.microsoft.com/en-us/services/functions/#pricing)。

Review comment:
   调用 100 万次




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan opened a new issue #5671: docs: skywalking-logger plugin doc is using an incorrect configuration demo

2021-12-01 Thread GitBox


juzhiyuan opened a new issue #5671:
URL: https://github.com/apache/apisix/issues/5671


   ### Improved or typo fixed.
   
   Please see https://apisix.apache.org/docs/apisix/plugins/skywalking-logger
   
   
![image](https://user-images.githubusercontent.com/2106987/144371319-6b66d78a-9900-4244-b1bd-f4837a4faf2c.png)
   
   
   ### Solution
   
   樂 There should be `skywalking-logger` with proper configurations, right?
   
   
https://github.com/apache/apisix/blob/master/apisix/plugins/skywalking-logger.lua


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760800344



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。
+tags: [Technology]
+---
+
+> 本文介绍了 Apache APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions 
集成到 Apache APISIX 中。
+
+
+
+Apache APISIX 为 Microsoft Azure Functions 提供了对 serverless 框架的支持。Apache APISIX 
建议定义一个启用了无服务器插件的路由,而不是在应用程序中硬编码函数URL。它使开发者能够灵活地热更新函数 URI。此外,因为 Apache APISIX 
有非常强大的认证支持,这种方法还可以减轻应用逻辑中的授权和认证问题,可以用来识别和授权客户消费者访问带有 FAAS 的特定路由。本文介绍了 Apache 
APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions(一种广泛使用的 serverless 
解决方案)集成到 Apache APISIX 中。

Review comment:
   而不是在应用程序中硬编码函数URL➡️而不是在应用程序中采用硬编码函数 URL




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760799976



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。
+tags: [Technology]
+---
+
+> 本文介绍了 Apache APISIX 最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure Functions 
集成到 Apache APISIX 中。

Review comment:
   同上




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #784: docs: add azure-function plugin blog

2021-12-01 Thread GitBox


SylviaBABY commented on a change in pull request #784:
URL: https://github.com/apache/apisix-website/pull/784#discussion_r760799904



##
File path: 
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/apisix-supports-azure-functions.md
##
@@ -0,0 +1,182 @@
+---
+title: "azure-functions 插件发布,Apache APISIX 支持 Azure Functions 集成"
+author: "Bisakh Mondal"
+authorURL: "https://github.com/bisakhmondal;
+authorImageURL: "https://avatars.githubusercontent.com/u/41498427?v=4;
+keywords: 
+- Apache APISIX
+- Azure Functions
+- Microsoft
+- Serverless
+description: 本文介绍了最近增加的一个新插件`azure-functions`,并详细说明了如何将 Azure 
Functions(一种广泛使用的 serverless 解决方案)集成到 Apache APISIX 中。

Review comment:
   最近增加的一个新插件➡️最近新增的插件x




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path

2021-12-01 Thread GitBox


lxm commented on pull request #779:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-984335293


   > > > We may also add some test cases.
   > > 
   > > 
   > > have written more test cases. retested the feature
   > 
   > By say adding test cases, we'd better also add the E2E test cases.
   
   working on it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] 123liubao commented on issue #698: Update SkyWalking plugin's docs

2021-12-01 Thread GitBox


123liubao commented on issue #698:
URL: https://github.com/apache/apisix-website/issues/698#issuecomment-984324331


   Hello, @juzhiyuan I want to work on this, please assign it to me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] huang-x-h commented on issue #782: Prometheus doc 'Grafana dashboard meta ' file link is broken

2021-12-01 Thread GitBox


huang-x-h commented on issue #782:
URL: https://github.com/apache/apisix-website/issues/782#issuecomment-984316005


   Should i send a PR or you just fixed it ? not diffcult :) @juzhiyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan opened a new issue #5668: docs: ldap-auth plugin's doc is missing Consumer parameters

2021-12-01 Thread GitBox


juzhiyuan opened a new issue #5668:
URL: https://github.com/apache/apisix/issues/5668


   ### Improved or typo fixed.
   
   According to `ldap-auth` plugin's implementation[1], our docs are missing 
parameters when configuring Consumer.
   
   See https://apisix.apache.org/docs/apisix/plugins/ldap-auth/
   
   ### Solution
   
   Add the description of Consumer parameters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (612bd5f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **increase** coverage by `3.29%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2233  +/-   ##
   ==
   + Coverage   68.02%   71.31%   +3.29% 
   ==
 Files 127   57  -70 
 Lines3359 3905 +546 
 Branches  8260 -826 
   ==
   + Hits 2285 2785 +500 
   + Misses   1074  825 -249 
   - Partials0  295 +295 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `44.53% <ø> (?)` | |
   | backend-e2e-test-ginkgo | `51.93% <ø> (?)` | |
   | backend-unit-test | `49.13% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==)
 | | |
   | 
[web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4)
 | | |
   | 
[...ages/Route/components/Step2/RequestRewriteView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAyL1JlcXVlc3RSZXdyaXRlVmlldy50c3g=)
 | | |
   | 
[web/src/pages/PluginTemplate/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9zZXJ2aWNlLnRz)
 | | |
   | 
[web/src/pages/Route/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAyL2luZGV4LnRzeA==)
 | | |
   | 
[web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9nbG9iYWwudHN4)
 | | |
   | 
[web/src/pages/Dashboard/Dashboard.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvRGFzaGJvYXJkLnRzeA==)
 | | |
   | 
[web/src/pages/Consumer/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1ByZXZpZXcudHN4)
 | | |
   | 

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


leslie-tsang commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760768602



##
File path: docs/zh/latest/plugins/rocketmq-logger.md
##
@@ -0,0 +1,229 @@
+---
+title: rocketmq-logger
+---
+
+
+
+## 目录
+
+- [**简介**](#简介)
+- [**属性**](#属性)
+- [**工作原理**](#工作原理)
+- [**如何启用**](#如何启用)
+- [**测试插件**](#测试插件)
+- [**禁用插件**](#禁用插件)
+
+## 简介
+
+`rocketmq-logger` 插件利用ngx_lua客户端能力,可推送JSON格式的请求日志到外部rocketmq集群。
+
+它可以将接口请求日志以 JSON 的形式推送给外部 rocketmq 
集群。如果在短时间内没有收到日志数据,请放心,它会在我们的批处理处理器中的计时器功能到期后自动发送日志。

Review comment:
   The translation seems to be out of sync.
   BTW, please add a space between English and Chinese, Ref to 
[document-style-guide](https://github.com/ruanyf/document-style-guide/blob/master/docs/text.md#%E5%AD%97%E9%97%B4%E8%B7%9D)

##
File path: docs/en/latest/plugins/rocketmq-logger.md
##
@@ -0,0 +1,234 @@
+---
+title: rocketmq-logger
+---
+
+
+
+## Summary
+
+- [**Name**](#name)
+- [**Attributes**](#attributes)
+- [**Info**](#info)
+- [**How To Enable**](#how-to-enable)
+- [**Test Plugin**](#test-plugin)
+- [**Disable Plugin**](#disable-plugin)
+
+## Name
+
+`rocketmq-logger` is a plugin which provides the ability to push requests log 
data as JSON objects to your external rocketmq clusters.
+
+This plugin provides the ability to push requests log data as JSON objects to 
your external rocketmq clusters. In case if you did not receive the log data 
don't worry give it some time it will automatically send the logs after the 
timer function expires in our Batch Processor.

Review comment:
   Why should we repeat it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] leslie-tsang commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


leslie-tsang commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760763518



##
File path: docs/en/latest/plugins/rocketmq-logger.md
##
@@ -0,0 +1,234 @@
+---
+title: rocketmq-logger
+---
+
+
+
+## Summary
+
+- [**Name**](#name)
+- [**Attributes**](#attributes)
+- [**Info**](#info)
+- [**How To Enable**](#how-to-enable)
+- [**Test Plugin**](#test-plugin)
+- [**Disable Plugin**](#disable-plugin)
+
+## Name
+
+`rocketmq-logger` is a plugin which provides the ability to push requests log 
data as JSON objects to your external rocketmq clusters.
+
+This plugin provides the ability to push requests log data as JSON objects to 
your external rocketmq clusters. In case if you did not receive the log data 
don't worry give it some time it will automatically send the logs after the 
timer function expires in our Batch Processor.
+
+For more info on Batch-Processor in Apache APISIX please refer.
+[Batch-Processor](../batch-processor.md)
+
+## Attributes
+
+| Name | Type| Requirement | Default| Valid   | 
Description 
 |
+|  | --- | --- | -- | --- | 

 |
+| nameserver_list  | object  | required|| | An 
array of rocketmq nameservers.  
 |
+| topic| string  | required|| | Target 
 topic to push data.
  |
+| key  | string  | optional|| | Keys 
of messages to send.   |
+| tag  | string  | optional   || | Tags of 
messages to send.   |
+| timeout  | integer | optional| 3  | [1,...] | 
Timeout for the upstream to send data.  
 |
+| use_tls  | boolean | optional   | false  | | Whether 
to open TLS  |
+| access_key   | string  | optional   | "" | | access 
key for ACL, empty string means disable ACL. |
+| secret_key   | string  | optional   | "" | | secret 
key for ACL。 |
+| name | string  | optional| "rocketmq logger" | | A  
unique identifier to identity the batch processor.  
   |
+| meta_format  | enum| optional| "default"  | 
["default","origin"] | `default`: collect the request information with default 
JSON way. `origin`: collect the request information with original HTTP request. 
[example](#examples-of-meta_format)|
+| batch_max_size   | integer | optional| 1000   | [1,...] | Set 
the maximum number of logs sent in each batch. When the number of logs reaches 
the set maximum, all logs will be automatically pushed to the `rocketmq` 
service. |
+| inactive_timeout | integer | optional| 5  | [1,...] | The 
maximum time to refresh the buffer (in seconds). When the maximum refresh time 
is reached, all logs will be automatically pushed to the `rocketmq` service 
regardless of whether the number of logs in the buffer reaches the set maximum 
number. |
+| buffer_duration  | integer | optional| 60 | [1,...] | 
Maximum age in seconds of the oldest entry in a batch before the batch must be 
processed.|
+| max_retry_count  | integer | optional| 0  | [0,...] | 
Maximum number of retries before removing from the processing pipe line.
 |
+| retry_delay  | integer | optional| 1  | [0,...] | Number 
of seconds the process execution should be delayed if the execution fails.  
  |
+| include_req_body | boolean | optional| false  | [false, true] | 
Whether to include the request body. false: indicates that the requested body 
is not included; true: indicates that the requested body is included. Note: if 
the request body is too big to be kept in the memory, it can't be logged due to 
Nginx's limitation. |
+| include_req_body_expr  | array  | optional|  | | When 
`include_req_body` is true, control the behavior based on the result of the 
[lua-resty-expr](https://github.com/api7/lua-resty-expr) expression. If 
present, only log the request body when the result is true. |
+| include_resp_body| boolean | optional| false | [false, true] | 
Whether to include the response body. The response body is included if and only 
if it is `true`. |
+| include_resp_body_expr  | array  | optional|  | | When 
`include_resp_body` is true, control the behavior based on the result of 

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (612bd5f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **increase** coverage by `3.29%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2233  +/-   ##
   ==
   + Coverage   68.02%   71.31%   +3.29% 
   ==
 Files 127   57  -70 
 Lines3359 3905 +546 
 Branches  8260 -826 
   ==
   + Hits 2285 2785 +500 
   + Misses   1074  825 -249 
   - Partials0  295 +295 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `44.53% <ø> (?)` | |
   | backend-e2e-test-ginkgo | `51.93% <ø> (?)` | |
   | backend-unit-test | `49.13% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==)
 | | |
   | 
[...components/active-check/Unhealthy/HttpFailures.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9IdHRwRmFpbHVyZXMudHN4)
 | | |
   | 
[web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4)
 | | |
   | 
[web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=)
 | | |
   | 
[web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==)
 | | |
   | 
[web/src/pages/SSL/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMS9pbmRleC50c3g=)
 | | |
   | 
[web/src/components/Upstream/components/Retries.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvUmV0cmllcy50c3g=)
 | | |
   | 
[web/src/pages/SSL/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvc2VydmljZS50cw==)
 | | |
   | 

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


bzp2010 commented on a change in pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760758760



##
File path: web/src/components/Plugin/data.tsx
##
@@ -224,4 +224,22 @@ export const PLUGIN_LIST = {
 type: PluginType.other,
 hidden: true,
   },
+  'authz-casbin': {
+type: PluginType.authentication,
+  },
+  'ldap-auth': {
+type: PluginType.authentication,
+  },
+  datadog: {

Review comment:
   @zaunist I've tried that, but it gets automatically removed by lint when 
doing a commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (612bd5f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **increase** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2233  +/-   ##
   ==
   + Coverage   68.02%   68.16%   +0.14% 
   ==
 Files 127   57  -70 
 Lines3359 3905 +546 
 Branches  8260 -826 
   ==
   + Hits 2285 2662 +377 
   + Misses   1074  949 -125 
   - Partials0  294 +294 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test-ginkgo | `51.93% <ø> (?)` | |
   | backend-unit-test | `49.13% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==)
 | | |
   | 
[...components/active-check/HttpsVerifyCertificate.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0h0dHBzVmVyaWZ5Q2VydGlmaWNhdGUudHN4)
 | | |
   | 
[...pages/SSL/components/CertificateUploader/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZVVwbG9hZGVyL2luZGV4LnRzeA==)
 | | |
   | 
[...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4)
 | | |
   | 
[...components/PluginFlow/components/Toolbar/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9Ub29sYmFyL2luZGV4LnRzeA==)
 | | |
   | 
[web/src/pages/Route/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAyL2luZGV4LnRzeA==)
 | | |
   | 
[web/src/pages/Upstream/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9MaXN0LnRzeA==)
 | | |
   | 

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


bzp2010 commented on a change in pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760758760



##
File path: web/src/components/Plugin/data.tsx
##
@@ -224,4 +224,22 @@ export const PLUGIN_LIST = {
 type: PluginType.other,
 hidden: true,
   },
+  'authz-casbin': {
+type: PluginType.authentication,
+  },
+  'ldap-auth': {
+type: PluginType.authentication,
+  },
+  datadog: {

Review comment:
   I've tried that, but it gets automatically removed by lint when doing a 
commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


zaunist commented on a change in pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760758406



##
File path: web/src/components/Plugin/data.tsx
##
@@ -224,4 +224,22 @@ export const PLUGIN_LIST = {
 type: PluginType.other,
 hidden: true,
   },
+  'authz-casbin': {
+type: PluginType.authentication,
+  },
+  'ldap-auth': {
+type: PluginType.authentication,
+  },
+  datadog: {

Review comment:
   ```suggestion
 'datadog': {
   ```
   need `'` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (612bd5f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `18.89%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2233   +/-   ##
   ===
   - Coverage   68.02%   49.13%   -18.90% 
   ===
 Files 127   41   -86 
 Lines3359 3171  -188 
 Branches  8260  -826 
   ===
   - Hits 2285 1558  -727 
   - Misses   1074 1413  +339 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.13% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==)
 | | |
   | 
[web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz)
 | | |
   | 
[web/src/components/Upstream/components/Timeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZW91dC50c3g=)
 | | |
   | 
[web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=)
 | | |
   | 
[web/src/components/Upstream/components/TLS.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVExTLnRzeA==)
 | | |
   | 
[...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==)
 | | |
   | 
[web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=)
 | | |
   | 
[...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=)
 | | |
   | 

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (973e6ee) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **increase** coverage by `3.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2233  +/-   ##
   ==
   + Coverage   68.02%   71.08%   +3.06% 
   ==
 Files 127   57  -70 
 Lines3359 3905 +546 
 Branches  8260 -826 
   ==
   + Hits 2285 2776 +491 
   + Misses   1074  835 -239 
   - Partials0  294 +294 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `44.07% <ø> (?)` | |
   | backend-e2e-test-ginkgo | `51.60% <ø> (?)` | |
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../src/pages/User/components/LoginMethodPassword.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL2NvbXBvbmVudHMvTG9naW5NZXRob2RQYXNzd29yZC50c3g=)
 | | |
   | 
[web/src/components/HeaderDropdown/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0hlYWRlckRyb3Bkb3duL2luZGV4LnRzeA==)
 | | |
   | 
[web/src/pages/SSL/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMi9pbmRleC50c3g=)
 | | |
   | 
[...nents/Upstream/components/ServiceDiscoveryArgs.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvU2VydmljZURpc2NvdmVyeUFyZ3MudHN4)
 | | |
   | 
[...eam/components/active-check/Unhealthy/Timeouts.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9UaW1lb3V0cy50c3g=)
 | | |
   | 
[web/src/access.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hY2Nlc3MudHM=)
 | | |
   | 
[web/src/pages/SSL/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMS9pbmRleC50c3g=)
 | | |
   | 

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (973e6ee) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `5.79%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2233  +/-   ##
   ==
   - Coverage   68.02%   62.22%   -5.80% 
   ==
 Files 127   57  -70 
 Lines3359 3905 +546 
 Branches  8260 -826 
   ==
   + Hits 2285 2430 +145 
   - Misses   1074 1194 +120 
   - Partials0  281 +281 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `44.07% <ø> (?)` | |
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9zZXJ2aWNlLnRz)
 | | |
   | 
[web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz)
 | | |
   | 
[web/src/components/Plugin/UI/limit-conn.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb25uLnRzeA==)
 | | |
   | 
[...nents/PluginFlow/components/FlowGraph/FlowGraph.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvRmxvd0dyYXBoLnRz)
 | | |
   | 
[...pages/SSL/components/CertificateUploader/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZVVwbG9hZGVyL2luZGV4LnRzeA==)
 | | |
   | 
[web/src/pages/SSL/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMi9pbmRleC50c3g=)
 | | |
   | 
[web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=)
 | | |
   | 
[web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=)
 | | |
   | 

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (973e6ee) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `18.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2233   +/-   ##
   ===
   - Coverage   68.02%   49.16%   -18.87% 
   ===
 Files 127   41   -86 
 Lines3359 3171  -188 
 Branches  8260  -826 
   ===
   - Hits 2285 1559  -726 
   - Misses   1074 1412  +338 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...nents/PluginFlow/components/FlowGraph/FlowGraph.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvRmxvd0dyYXBoLnRz)
 | | |
   | 
[web/src/pages/Service/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL3NlcnZpY2UudHM=)
 | | |
   | 
[...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==)
 | | |
   | 
[web/src/components/Plugin/UI/api-breaker.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9hcGktYnJlYWtlci50c3g=)
 | | |
   | 
[web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4)
 | | |
   | 
[web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=)
 | | |
   | 
[web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4)
 | | |
   | 
[web/src/pages/SSL/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvTGlzdC50c3g=)
 | | |
   | 

[GitHub] [apisix] jiangkaiyuan98 commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox


jiangkaiyuan98 commented on issue #5658:
URL: https://github.com/apache/apisix/issues/5658#issuecomment-984273472


   我是将enable_compression设置为true后,会出现access.log没有日志的现象
   
![image](https://user-images.githubusercontent.com/4942/144355443-955ab22d-0d9a-4215-9dc8-e5a31837c7a3.png)
   将enable_compression改为false后就正常了
   
![image](https://user-images.githubusercontent.com/4942/144355687-959f239d-ccc9-4cd6-9948-beb823233545.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


bzp2010 commented on a change in pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760747010



##
File path: api/conf/schema.json
##
@@ -5501,10 +6814,14 @@
"type": "object"
}
},
-   "required": ["protocol_level", "protocol_name", 
"upstream"],
+   "required": [
+   "protocol_level",
+   "protocol_name",
+   "upstream"
+   ],
"type": "object"
},
"version": 0.1
}
}
-}
+}

Review comment:
   Yes, I will add EOL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (39c50c7) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `18.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2233   +/-   ##
   ===
   - Coverage   68.02%   49.16%   -18.87% 
   ===
 Files 127   41   -86 
 Lines3359 3171  -188 
 Branches  8260  -826 
   ===
   - Hits 2285 1559  -726 
   - Misses   1074 1412  +338 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...nents/PluginFlow/components/FlowGraph/FlowGraph.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvRmxvd0dyYXBoLnRz)
 | | |
   | 
[web/src/pages/Service/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL3NlcnZpY2UudHM=)
 | | |
   | 
[...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==)
 | | |
   | 
[web/src/components/Plugin/UI/api-breaker.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9hcGktYnJlYWtlci50c3g=)
 | | |
   | 
[web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4)
 | | |
   | 
[web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=)
 | | |
   | 
[web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4)
 | | |
   | 
[web/src/pages/SSL/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvTGlzdC50c3g=)
 | | |
   | 

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


codecov-commenter commented on pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#issuecomment-984268585


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2233](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (c94cea3) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cbcac5f) will **decrease** coverage by `23.49%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2233   +/-   ##
   ===
   - Coverage   68.02%   44.53%   -23.50% 
   ===
 Files 127   57   -70 
 Lines3359 3905  +546 
 Branches  8260  -826 
   ===
   - Hits 2285 1739  -546 
   - Misses   1074 1879  +805 
   - Partials0  287  +287 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `44.53% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2233?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4)
 | | |
   | 
[...es/Route/components/DebugViews/DebugParamsView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdQYXJhbXNWaWV3LnRzeA==)
 | | |
   | 
[web/src/pages/Upstream/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9jb21wb25lbnRzL1N0ZXAxLnRzeA==)
 | | |
   | 
[.../src/pages/Route/components/Step1/ProxyRewrite.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1Byb3h5UmV3cml0ZS50c3g=)
 | | |
   | 
[web/src/pages/SSL/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvQ3JlYXRlLnRzeA==)
 | | |
   | 
[web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz)
 | | |
   | 
[web/src/pages/Setting/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL3NlcnZpY2UudHM=)
 | | |
   | 
[web/src/access.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2233/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hY2Nlc3MudHM=)
 | | |
   | 

[GitHub] [apisix-dashboard] zaunist commented on pull request #2201: test: migrate route remote addr e2e

2021-12-01 Thread GitBox


zaunist commented on pull request #2201:
URL: https://github.com/apache/apisix-dashboard/pull/2201#issuecomment-984267980


   cc @bzp2010 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


zaunist commented on a change in pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r760742640



##
File path: api/conf/schema.json
##
@@ -5501,10 +6814,14 @@
"type": "object"
}
},
-   "required": ["protocol_level", "protocol_name", 
"upstream"],
+   "required": [
+   "protocol_level",
+   "protocol_name",
+   "upstream"
+   ],
"type": "object"
},
"version": 0.1
}
}
-}
+}

Review comment:
   Do we need a new line at end of file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 opened a new pull request #2233: feat: basic support Apache APISIX 2.11

2021-12-01 Thread GitBox


bzp2010 opened a new pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233


   Please answer these questions before submitting a pull request, **or your PR 
will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Adapt Apache APISIX version 2.11, synchronize schema to support new plugins.
   
   **Related issues**
   
   follow: 
[https://github.com/apache/apisix/pull/5567](https://github.com/apache/apisix/pull/5567)
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   - [x] Have you added corresponding test cases?
   - [x] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, 
please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] saintak commented on issue #5658: request help: unable to collect logs when log-rotate plugin is enabled

2021-12-01 Thread GitBox


saintak commented on issue #5658:
URL: https://github.com/apache/apisix/issues/5658#issuecomment-984264664


   > hi, @lihuawei321 @saintak , can you provide the steps to reproduce it? 
According to the document configuration, I did not reproduce the problem.
   
   我是设置成120秒切割一次,很明显能看出来最后一次切割会影响本次和前一次的文件。参见我提的issue #5663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] han6565 edited a comment on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox


han6565 edited a comment on issue #781:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984263687


   > 
   
   > There are actually two problems here.
   > 
   > * About modifying the route created by apisix-ingress in the dashboard
   > 
   > **We do not recommend this, or even refuse to do so.** Because this will 
cause various unexpected problems. When using apisix-ingress, you should ensure 
that all input is done by manipulating resources in K8s.
   > 
   @tao12345666333 
   能说下为什么不建议或者拒绝修改route么,比如我要增加或者删除限流插件这种,会有什么问题么,我看ingress-controller 
寻找route是根据namespace和service等生成ID,来做两边对照的,如果我在controller生成route后就只在deashboard操作一些插件,只在删除route时再由controller操作,不去碰触upstream和route的其他内容这样也会有问题么。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] han6565 commented on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox


han6565 commented on issue #781:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984263687


   > 
   
   > There are actually two problems here.
   > 
   > * About modifying the route created by apisix-ingress in the dashboard
   > 
   > **We do not recommend this, or even refuse to do so.** Because this will 
cause various unexpected problems. When using apisix-ingress, you should ensure 
that all input is done by manipulating resources in K8s.
   > 
   能说下为什么不建议或者拒绝修改route么,比如我要增加或者删除限流插件这种,会有什么问题么,我看ingress-controller 
寻找route是根据namespace和service等生成ID,来做两边对照的,如果我在controller生成route后就只在deashboard操作一些插件,只在删除route时再由controller操作,不去碰触upstream和route的其他内容这样也会有问题么。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao opened a new pull request #5667: docs(log-rotate): fix typo

2021-12-01 Thread GitBox


shuaijinchao opened a new pull request #5667:
URL: https://github.com/apache/apisix/pull/5667


   ### What this PR does / why we need it:
   
   
   `USER1` is not a signal name. The description in the log is misleading. If 
you need to describe the signal in detail, can should use the description 
`User-defined signal 1` in the Man Manual instead of `USER1`
   
   ### Pre-submission checklist:
   
   
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] han6565 edited a comment on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox


han6565 edited a comment on issue #781:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984248910


   我也跟你遇见一样的问题,修改apisix-dashboard源码,他那有个长度验证,改长点就完了.
   修改位置如果我没记错应该是/api/conf/schema.json 寻找route下的name,把最长改长点


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] han6565 commented on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox


han6565 commented on issue #781:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984248910


   我也跟你遇见一样的问题,修改apisix-dashboard源码,他那有个长度验证,改长点就完了,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760727687



##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,271 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local pairs= pairs
+local type = type
+local ipairs   = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local timer_at = ngx.timer.at
+local ngx = ngx
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "object",
+minProperties = 1,
+patternProperties = {

Review comment:
   chaged to  [ "127.0.0.1:9876" ]




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760727805



##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,271 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local pairs= pairs
+local type = type
+local ipairs   = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local timer_at = ngx.timer.at
+local ngx = ngx
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "object",
+minProperties = 1,
+patternProperties = {
+[".*"] = {
+description = "the port of rocketmq nameserver",
+type = "integer",
+minimum = 1,
+maximum = 65535,
+},
+},
+},
+rocketmq_topic = {type = "string"},

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao commented on issue #5658: request help: 开启log-rotate插件后日志采集不到

2021-12-01 Thread GitBox


shuaijinchao commented on issue #5658:
URL: https://github.com/apache/apisix/issues/5658#issuecomment-984244609


   hi, @lihuawei321 @saintak , can you provide the steps to reproduce it? 
According to the document configuration, I did not reproduce the problem.
   
   
![image](https://user-images.githubusercontent.com/8529452/144348736-cc7d61a2-abec-4aa2-9212-0bab27551308.png)
   
   
![image](https://user-images.githubusercontent.com/8529452/144348960-7322bc37-5a6a-47f0-9889-fca6aa2cb522.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760723620



##
File path: ci/pod/docker-compose.yml
##
@@ -355,10 +355,34 @@ services:
 networks:
   apisix_net:
 
+  namesrv:

Review comment:
   the conf in contaner use this name as a host address, if changed, broker 
will fail to connect nameserver. and I cant find a way to change the config 
file, do you have any idea?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2232: fix(username_regex): cp consumer name regx different with dp

2021-12-01 Thread GitBox


codecov-commenter commented on pull request #2232:
URL: https://github.com/apache/apisix-dashboard/pull/2232#issuecomment-984239320


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2232?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2232](https://codecov.io/gh/apache/apisix-dashboard/pull/2232?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (0ef4c2c) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cc1e5d4804f3db20ae52d32dd6f879b46aa331ea?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cc1e5d4) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2232/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2232?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#2232   +/-   ##
   ===
 Coverage   68.07%   68.07%   
   ===
 Files 127  127   
 Lines3352 3352   
 Branches  824  824   
   ===
 Hits 2282 2282   
 Misses   1070 1070   
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `68.07% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2232?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2232/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==)
 | `100.00% <ø> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2232?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2232?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Last update 
[cc1e5d4...0ef4c2c](https://codecov.io/gh/apache/apisix-dashboard/pull/2232?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #740: feat: Fix lb ingress status

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #740:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/740#issuecomment-962736571


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#740](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (a46283a) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f4708675c6304ad019881ad7e0ac7a0affd3e6bd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f470867) will **decrease** coverage by `0.20%`.
   > The diff coverage is `11.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #740  +/-   ##
   ==
   - Coverage   32.28%   32.08%   -0.21% 
   ==
 Files  66   66  
 Lines6808 6944 +136 
   ==
   + Hits 2198 2228  +30 
   - Misses   4353 4466 +113 
   + Partials  257  250   -7 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv)
 | `0.00% <ø> (ø)` | |
   | 
[pkg/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvaW5ncmVzcy5nbw==)
 | `6.89% <0.00%> (-1.22%)` | :arrow_down: |
   | 
[pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==)
 | `77.77% <100.00%> (+1.95%)` | :arrow_up: |
   | 
[pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=)
 | `65.68% <100.00%> (+0.68%)` | :arrow_up: |
   | 
[pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==)
 | `38.92% <0.00%> (+2.01%)` | :arrow_up: |
   | 
[pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv)
 | `33.33% <0.00%> (+3.30%)` | :arrow_up: |
   | 
[pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=)
 | `100.00% <0.00%> (+20.00%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 

[GitHub] [apisix-dashboard] liuxiran merged pull request #2231: feat: support post args advanced match

2021-12-01 Thread GitBox


liuxiran merged pull request #2231:
URL: https://github.com/apache/apisix-dashboard/pull/2231


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-dashboard] branch master updated: feat: support post args advanced match (#2231)

2021-12-01 Thread liuxiran
This is an automated email from the ASF dual-hosted git repository.

liuxiran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new cbcac5f  feat: support post args advanced match (#2231)
cbcac5f is described below

commit cbcac5f74b1da44540603493f0f4bfe417de414b
Author: Zeping Bai 
AuthorDate: Thu Dec 2 10:21:23 2021 +0800

feat: support post args advanced match (#2231)
---
 ...route-with-advanced-matching-conditions.spec.js | 10 -
 .../Route/components/Step1/MatchingRulesView.tsx   | 26 +++---
 web/src/pages/Route/locales/en-US.ts   |  9 +++-
 web/src/pages/Route/locales/zh-CN.ts   |  8 ++-
 web/src/pages/Route/transform.ts   | 11 +
 web/src/pages/Route/typing.d.ts|  2 +-
 6 files changed, 50 insertions(+), 16 deletions(-)

diff --git 
a/web/cypress/integration/route/create-route-with-advanced-matching-conditions.spec.js
 
b/web/cypress/integration/route/create-route-with-advanced-matching-conditions.spec.js
index ae4a2fc..45cc98d 100644
--- 
a/web/cypress/integration/route/create-route-with-advanced-matching-conditions.spec.js
+++ 
b/web/cypress/integration/route/create-route-with-advanced-matching-conditions.spec.js
@@ -23,7 +23,6 @@ context('Create Route with advanced matching conditions', () 
=> {
 nodes_0_port: '#submitNodes_0_port',
 nodes_0_weight: '#submitNodes_0_weight',
 deleteAlert: '.ant-modal-body',
-notificationCloseIcon: '.ant-notification-close-icon',
 notification: '.ant-notification-notice-message',
 parameterPosition: '#position',
 ruleCard: '.ant-modal',
@@ -79,7 +78,7 @@ context('Create Route with advanced matching conditions', () 
=> {
 .click()
 .then(() => {
   cy.get('.ant-select-dropdown').within(() => {
-cy.contains('Build-in').should('be.visible').click();
+cy.contains('Built-in').should('be.visible').click();
   });
 });
   cy.get(selector.ruleCard).within(() => {
@@ -94,7 +93,7 @@ context('Create Route with advanced matching conditions', () 
=> {
 cy.get(selector.advancedMatchingTable).should('exist');
 cy.wrap(opreatorList).each((operator, index) => {
   cy.get(selector.advancedMatchingTableCell).within(() => {
-cy.contains('td', 'Build-in Parameter').should('be.visible');
+cy.contains('td', 'Built-in Parameter').should('be.visible');
 cy.contains('td', data.matchingParamName).should('be.visible');
 cy.contains('td', matchingValueList1[index]).should('be.visible');
   });
@@ -128,14 +127,14 @@ context('Create Route with advanced matching conditions', 
() => {
   });
   });
   cy.get(selector.ruleCard).within(() => {
-cy.get(`[title="Build-in Parameter"]`).should('have.class', 
'ant-select-selection-item');
+cy.get(`[title="Built-in Parameter"]`).should('have.class', 
'ant-select-selection-item');
 cy.get(selector.name).clear().type(data.matchingParamName);
 cy.get(`[title="${opreator}"]`).should('have.class', 
'ant-select-selection-item');
 cy.get(selector.value).clear().type(matchingValueList2[index]);
 cy.contains('Confirm').click();
   });
   cy.get(selector.advancedMatchingTableCell).within(() => {
-cy.contains('td', 'Build-in Parameter').should('be.visible');
+cy.contains('td', 'Built-in Parameter').should('be.visible');
 cy.contains('td', data.matchingParamName).should('be.visible');
 cy.contains('td', matchingValueList2[index]).should('be.visible');
   });
@@ -183,6 +182,5 @@ context('Create Route with advanced matching conditions', 
() => {
 cy.contains('OK').click();
   });
 cy.get(selector.notification).should('contain', data.deleteRouteSuccess);
-cy.get(selector.notificationCloseIcon).click();
   });
 });
diff --git a/web/src/pages/Route/components/Step1/MatchingRulesView.tsx 
b/web/src/pages/Route/components/Step1/MatchingRulesView.tsx
index ccbb97c..90760a3 100644
--- a/web/src/pages/Route/components/Step1/MatchingRulesView.tsx
+++ b/web/src/pages/Route/components/Step1/MatchingRulesView.tsx
@@ -15,11 +15,13 @@
  * limitations under the License.
  */
 import React, { useState } from 'react';
-import { Button, Table, Modal, Form, Select, Input, Space, notification } from 
'antd';
+import { Button, Table, Modal, Form, Select, Input, Space, notification, 
Typography } from 'antd';
 import { useIntl } from 'umi';
 
 import PanelSection from '@/components/PanelSection';
 
+const { Title, Text } = Typography;
+
 const MatchingRulesView: React.FC = ({
   advancedMatchingRules,
   disabled,
@@ -113,11 +115,14 @@ const MatchingRulesView: 
React.FC = ({
   case 'arg':
 renderText = formatMessage({ id: 

[GitHub] [apisix-ingress-controller] BuptZyc commented on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox


BuptZyc commented on issue #781:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984229613


   主要是想开启ext-plugin-pre-req使用自定义插件。不推荐修改路由的话,想问下怎么开启插件并进行配置呢


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] leslie-tsang commented on a change in pull request #5660: test(core.log): fix unit test case

2021-12-01 Thread GitBox


leslie-tsang commented on a change in pull request #5660:
URL: https://github.com/apache/apisix/pull/5660#discussion_r760712163



##
File path: apisix/core/log.lua
##
@@ -15,13 +15,13 @@
 -- limitations under the License.
 --
 
-local ngx = ngx
-local ngx_log  = ngx.log
-local require  = require
-local select = select
+local ngx  = ngx
+local ngx_log  = ngx.log
+local require  = require
+local select   = select

Review comment:
   OK




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on pull request #2232: fix(username_regex): cp consumer name regx different with dp

2021-12-01 Thread GitBox


zaunist commented on pull request #2232:
URL: https://github.com/apache/apisix-dashboard/pull/2232#issuecomment-984228233


   cc @liuxiran @bzp2010 @LiteSun @juzhiyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist opened a new pull request #2232: fix(username_regex): cp consumer name regx different with dp

2021-12-01 Thread GitBox


zaunist opened a new pull request #2232:
URL: https://github.com/apache/apisix-dashboard/pull/2232


   Please answer these questions before submitting a pull request, **or your PR 
will get closed**.
   
   **Why submit this pull request?**
   
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   APISIX support consumer name start with number, but APISIX-Dashboard does't 
support. Does the APISIX-Dashboard need to support consumer that start with 
number.
   And there is the APISIX regex 
https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L693 
   
   
![image](https://user-images.githubusercontent.com/38528079/144344163-d18e186d-71a5-4381-b9fe-ab68f08399be.png)
   
   After change:
   
   https://user-images.githubusercontent.com/38528079/144344365-98cdf30e-0b0c-4fda-a18d-c58719cdba79.png;>
   
   
   **Related issues**
   
   fix/resolve #2196 
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, 
please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander opened a new pull request #5666: feat(mqtt-proxy): support using route's upstrewam

2021-12-01 Thread GitBox


spacewander opened a new pull request #5666:
URL: https://github.com/apache/apisix/pull/5666


   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [x] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on a change in pull request #5653: feat: rocketmq logger

2021-12-01 Thread GitBox


spacewander commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r760703274



##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,271 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local pairs= pairs
+local type = type
+local ipairs   = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local timer_at = ngx.timer.at
+local ngx = ngx
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "object",
+minProperties = 1,
+patternProperties = {
+[".*"] = {
+description = "the port of rocketmq nameserver",
+type = "integer",
+minimum = 1,
+maximum = 65535,
+},
+},
+},
+rocketmq_topic = {type = "string"},

Review comment:
   We can use `topic` directly? Since this is already a rocketmq plugin, 
there is no need to repeat rocketmq.

##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,271 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local pairs= pairs
+local type = type
+local ipairs   = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local timer_at = ngx.timer.at
+local ngx = ngx
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "object",
+minProperties = 1,
+patternProperties = {

Review comment:
   Is it necessary to use IP:PORT KV structure? There is no way to 
configure two brokers with the same IP, even they can have different ports.

##
File path: ci/pod/docker-compose.yml
##
@@ -355,10 +355,34 @@ services:
 networks:
   apisix_net:
 
+  namesrv:

Review comment:
   Better to add a rocketmq prefix for the service, because this file is a 
common file.

##
File path: ci/pod/docker-compose.yml
##
@@ -355,10 +355,34 @@ services:
 networks:
   apisix_net:
 
+  namesrv:
+image: apacherocketmq/rocketmq:4.6.0
+container_name: rmqnamesrv
+restart: unless-stopped
+ports:
+  - "9876:9876"
+command: sh mqnamesrv
+networks:
+  rocketmq_net:
+
+  broker:

Review 

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2231: feat: support post args advanced match

2021-12-01 Thread GitBox


codecov-commenter commented on pull request #2231:
URL: https://github.com/apache/apisix-dashboard/pull/2231#issuecomment-984221756


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2231?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2231](https://codecov.io/gh/apache/apisix-dashboard/pull/2231?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (c480fa5) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/cc1e5d4804f3db20ae52d32dd6f879b46aa331ea?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (cc1e5d4) will **decrease** coverage by `0.11%`.
   > The diff coverage is `36.36%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2231/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2231?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2231  +/-   ##
   ==
   - Coverage   68.07%   67.96%   -0.12% 
   ==
 Files 127  127  
 Lines3352 3359   +7 
 Branches  824  826   +2 
   ==
   + Hits 2282 2283   +1 
   - Misses   1070 1076   +6 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `67.96% <36.36%> (-0.12%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2231?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2231/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=)
 | `77.41% <33.33%> (-1.27%)` | :arrow_down: |
   | 
[...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2231/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==)
 | `74.73% <40.00%> (-2.19%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2231?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2231?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Last update 
[cc1e5d4...c480fa5](https://codecov.io/gh/apache/apisix-dashboard/pull/2231?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #183: feat(apisix): add service monitor support

2021-12-01 Thread GitBox


tokers commented on a change in pull request #183:
URL: https://github.com/apache/apisix-helm-chart/pull/183#discussion_r760705861



##
File path: charts/apisix/templates/configmap.yaml
##
@@ -226,6 +226,13 @@ data:
 
 {{- if .Values.customPlugins.enabled }}
 plugin_attr:
+  {{- if .Values.serviceMonitor.enabled }}
+  prometheus:
+export_addr:
+  ip: 0.0.0.0

Review comment:
   Is the endpoint port defined on ServiceMonitor is a container port? If 
so, I think is OK.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tokers commented on pull request #779: feat: support regex in path

2021-12-01 Thread GitBox


tokers commented on pull request #779:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-984214474


   > > We may also add some test cases.
   > 
   > have written more test cases. retested the feature
   
   By say adding test cases, we'd better also add the E2E test cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #779: feat: support regex in path

2021-12-01 Thread GitBox


tokers commented on a change in pull request #779:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r760700157



##
File path: pkg/kube/translation/annotations/types.go
##
@@ -18,6 +18,10 @@ import (
"strings"
 )
 
+const (
+   AnnotationsPrefix = "k8s.apisix.apache.org/"

Review comment:
   OK, let's add some comments for exportable constants.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #740: feat: Fix lb ingress status

2021-12-01 Thread GitBox


codecov-commenter edited a comment on pull request #740:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/740#issuecomment-962736571


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#740](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (a46283a) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f4708675c6304ad019881ad7e0ac7a0affd3e6bd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f470867) will **decrease** coverage by `0.21%`.
   > The diff coverage is `11.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #740  +/-   ##
   ==
   - Coverage   32.28%   32.07%   -0.22% 
   ==
 Files  66   65   -1 
 Lines6808 6943 +135 
   ==
   + Hits 2198 2227  +29 
   - Misses   4353 4466 +113 
   + Partials  257  250   -7 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv)
 | `0.00% <ø> (ø)` | |
   | 
[pkg/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvaW5ncmVzcy5nbw==)
 | `6.89% <0.00%> (-1.22%)` | :arrow_down: |
   | 
[pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==)
 | `77.77% <100.00%> (+1.95%)` | :arrow_up: |
   | 
[pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=)
 | `65.68% <100.00%> (+0.68%)` | :arrow_up: |
   | 
[test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv)
 | | |
   | 
[pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==)
 | `38.92% <0.00%> (+2.01%)` | :arrow_up: |
   | 
[pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv)
 | `33.33% <0.00%> (+3.30%)` | :arrow_up: |
   | 
[pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=)
 | `100.00% <0.00%> (+20.00%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/740?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 

[GitHub] [apisix] spacewander commented on a change in pull request #5660: fix(core.log): fix unit test case

2021-12-01 Thread GitBox


spacewander commented on a change in pull request #5660:
URL: https://github.com/apache/apisix/pull/5660#discussion_r760697707



##
File path: apisix/core/log.lua
##
@@ -15,13 +15,13 @@
 -- limitations under the License.
 --
 
-local ngx = ngx
-local ngx_log  = ngx.log
-local require  = require
-local select = select
+local ngx  = ngx
+local ngx_log  = ngx.log
+local require  = require
+local select   = select

Review comment:
   Please avoid changing the irrelevant code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on a change in pull request #5664: docs: documenting url path forwarding for faas plugins

2021-12-01 Thread GitBox


spacewander commented on a change in pull request #5664:
URL: https://github.com/apache/apisix/pull/5664#discussion_r760693386



##
File path: docs/en/latest/plugins/aws-lambda.md
##
@@ -136,6 +137,43 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 
'X-API-KEY: edd1c9f034335f13
 
 **Note**: This approach assumes you already have an iam user with the 
programmatic access enabled and required permissions 
(`AmazonAPIGatewayInvokeFullAccess`) to access the endpoint.
 
+### Plugin with Path Forwarding
+
+AWS Lambda plugin supports url path forwarding while proxying request to the 
modified upstream (AWS Gateway URI endpoint). With that being said, any 
extension to the path of the base request APISIX gateway URI gets "appended" 
(path join) to the `function_uri` specified in the plugin configuration. To 
test this behavior, see the below example:

Review comment:
   Better to emphasize that the uri of the route needs to be ended with `*`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #782: request help: APISIX Ingress Annotation Document

2021-12-01 Thread GitBox


tao12345666333 commented on issue #782:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/782#issuecomment-984205198


   You can find some available annotations and examples of their use here. 
https://github.com/apache/apisix-ingress-controller/tree/master/test/e2e/annotations
   
   Welcome to submit PR and improve the document together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #776: request help: Can I use admin api to define some rule, and use the upstream the crd defiled?

2021-12-01 Thread GitBox


tao12345666333 commented on issue #776:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/776#issuecomment-984204130


   1. yes, you can.
   
   2. Of course you can, as long as you guarantee that there is no conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #781: request help: The route name generated by default is too long

2021-12-01 Thread GitBox


tao12345666333 commented on issue #781:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-984202850


   There are actually two problems here.
   
   * About modifying the route created by apisix-ingress in the dashboard
   
   **We do not recommend this, or even refuse to do so.** Because this will 
cause various unexpected problems. When using apisix-ingress, you should ensure 
that all input is done by manipulating resources in K8s.
   
   * The generated name is too long
   
   Can't be modified at the moment, welcome to submit PR modification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming merged pull request #5655: docs: add aws lambda plugin to readme

2021-12-01 Thread GitBox


moonming merged pull request #5655:
URL: https://github.com/apache/apisix/pull/5655


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix] branch master updated: docs: add aws lambda plugin to readme (#5655)

2021-12-01 Thread wenming
This is an automated email from the ASF dual-hosted git repository.

wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 13c119f  docs: add aws lambda plugin to readme (#5655)
13c119f is described below

commit 13c119f55957f9abde71847f4874ccc25b3ae20a
Author: Bisakh 
AuthorDate: Thu Dec 2 06:21:28 2021 +0530

docs: add aws lambda plugin to readme (#5655)

Co-authored-by: 罗泽轩 
---
 README.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index abce5e2..1591e54 100644
--- a/README.md
+++ b/README.md
@@ -153,8 +153,9 @@ A/B testing, canary release, blue-green deployment, limit 
rate, defense against
 
 - **Serverless**
   - [Lua functions](docs/en/latest/plugins/serverless.md): Invoke functions in 
each phase in APISIX.
-  - [Azure functions](docs/en/latest/plugins/azure-functions.md): seamless 
integration with Azure Serverless Function as a dynamic upstream to proxy all 
requests for a particular URI to the Microsoft Azure cloud.
-  - [Apache OpenWhisk](docs/en/latest/plugins/openwhisk.md): seamless 
integration with Apache OpenWhisk as a dynamic upstream to proxy all requests 
for a particular URI to your own OpenWhisk cluster.
+  - [AWS Lambda](docs/en/latest/plugins/aws-lambda.md): Integration with AWS 
Lambda function as a dynamic upstream to proxy all requests for a particular 
URI to the AWS API gateway endpoint. Supports authorization via api key and AWS 
IAM access secret.
+  - [Azure Functions](docs/en/latest/plugins/azure-functions.md): Seamless 
integration with Azure Serverless Function as a dynamic upstream to proxy all 
requests for a particular URI to the Microsoft Azure cloud.
+  - [Apache OpenWhisk](docs/en/latest/plugins/openwhisk.md): Seamless 
integration with Apache OpenWhisk as a dynamic upstream to proxy all requests 
for a particular URI to your own OpenWhisk cluster.
 
 ## Get Started
 


  1   2   >