[GitHub] [apisix-website] okaybase opened a new pull request #812: docs: release dashboard 2.10.0

2021-12-14 Thread GitBox


okaybase opened a new pull request #812:
URL: https://github.com/apache/apisix-website/pull/812


   Changes:
   
   update dashboard version to 2.10.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] commented on pull request #812: docs: release dashboard 2.10.0

2021-12-14 Thread GitBox


netlify[bot] commented on pull request #812:
URL: https://github.com/apache/apisix-website/pull/812#issuecomment-994466387


    Deploy Preview for *apache-apisix* processing.
   
   
    Explore the source changes: b90a29440eb60b7ad73f80e19b4e8ab56e1ef5c7
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61b99fb8391bfa0008d3b09f](https://app.netlify.com/sites/apache-apisix/deploys/61b99fb8391bfa0008d3b09f)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao opened a new pull request #5822: docs(google-cloud-logging): update document format and description

2021-12-14 Thread GitBox


shuaijinchao opened a new pull request #5822:
URL: https://github.com/apache/apisix/pull/5822


   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-helm-chart] Gallardot commented on a change in pull request #196: feat(apisix): add component label

2021-12-14 Thread GitBox


Gallardot commented on a change in pull request #196:
URL: https://github.com/apache/apisix-helm-chart/pull/196#discussion_r769347357



##
File path: charts/apisix/templates/service-admin.yaml
##
@@ -25,6 +25,7 @@ metadata:
 {{- end }}
   labels:
 {{- include "apisix.labels" . | nindent 4 }}
+app.kubernetes.io/component: apisix-admin

Review comment:
   How about `app.kubernetes.io/service` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] wangxiaochuang opened a new pull request #5821: feat(plugins): make plugins more powerfull

2021-12-14 Thread GitBox


wangxiaochuang opened a new pull request #5821:
URL: https://github.com/apache/apisix/pull/5821


   we can use ngx.req.set_uri(..., true) and some other's only rewrite phase 
functions
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


tzssangglass commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994443650


   I'm not familiar with k8s deployments. @tokers do you have any idea?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-docker] ccwall3 opened a new issue #252: nc: bad address 'apisix-admin.ingress-apisix.svc.cluster.local'

2021-12-14 Thread GitBox


ccwall3 opened a new issue #252:
URL: https://github.com/apache/apisix-docker/issues/252


   waiting for apisix-admin
   nc: bad address 'apisix-admin.ingress-apisix.svc.cluster.local'
   waiting for apisix-admin
   nc: bad address 'apisix-admin.ingress-apisix.svc.cluster.local'
   waiting for apisix-admin
   nc: bad address 'apisix-admin.ingress-apisix.svc.cluster.local'
   waiting for apisix-admin
   nc: bad address 'apisix-admin.ingress-apisix.svc.cluster.local'
   waiting for apisix-admin
   
   rancher deploy  apisix-ingress-controller
   
![image](https://user-images.githubusercontent.com/7711718/146144466-31a98272-edb1-4871-aa8c-41494833eeb0.png)
   
   
![image](https://user-images.githubusercontent.com/7711718/146144490-1e0a0f60-cd91-4ba5-ad1e-545cf07db101.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nimohunter opened a new issue #2246: [openapi upload error] kin-openapi lastest version is 0.86.0, and our go.mod version is 0.32.0

2021-12-14 Thread GitBox


nimohunter opened a new issue #2246:
URL: https://github.com/apache/apisix-dashboard/issues/2246


   # Feature request
   
   ## Please describe your feature
   
   OpenAPI upload openAPI yaml return error about ref error .
   
   > Request Error Code: 1 failed to resolve 
"#/definitions/dto.EnvironmentReq" in fragment in URI: "definitions": struct 
field "definitions" not found
   
   ## Describe the solution you'd like
   
   i'd like to solve it with MR by update kin-openapi version to lastest and 
this can solve the problem.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao opened a new pull request #5820: fix(sls-logger): log entry unable get millisecond timestamp

2021-12-14 Thread GitBox


shuaijinchao opened a new pull request #5820:
URL: https://github.com/apache/apisix/pull/5820


   ### What this PR does / why we need it:
   
   
   log entry unable get millisecond timestamp
   
   ### Pre-submission checklist:
   
   
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] okaybase merged pull request #2241: feat: release 2.10.0

2021-12-14 Thread GitBox


okaybase merged pull request #2241:
URL: https://github.com/apache/apisix-dashboard/pull/2241


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-dashboard] branch master updated: feat: release 2.10 (#2241)

2021-12-14 Thread okaybase
This is an automated email from the ASF dual-hosted git repository.

okaybase pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 1a9d76b  feat: release 2.10 (#2241)
1a9d76b is described below

commit 1a9d76bf081307525b5af98b6b74325f4d37907b
Author: okaybase <75366457+okayb...@users.noreply.github.com>
AuthorDate: Wed Dec 15 15:21:38 2021 +0800

feat: release 2.10 (#2241)

Co-authored-by: lixingwang 
---
 CHANGELOG.md   | 26 ++
 README.md  |  2 +-
 api/VERSION|  2 +-
 docs/en/latest/config.json |  2 +-
 docs/en/latest/develop.md  |  2 +-
 docs/en/latest/install.md  |  4 ++--
 web/package.json   |  2 +-
 7 files changed, 33 insertions(+), 7 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index cc72b6c..3eca895 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@
 
 # Table of Contents
 
+- [2.10.0](#2100)
 - [2.9.0](#290)
 - [2.8.0](#280)
 - [2.7.1](#271)
@@ -35,6 +36,31 @@
 - [1.5.0](#150)
 - [1.0.0](#100)
 
+# 2.10.0
+
+This release contains some features and bugfixes, and all the existing 
functionalities are compatible with Apache APISIX 2.11.0.
+
+### Core
+
+- feat: basic support Apache APISIX 2.11 
[#2233](https://github.com/apache/apisix-dashboard/pull/2233)
+- feat: support post args advanced match 
[#2231](https://github.com/apache/apisix-dashboard/pull/2231)
+- feat: Setting default language to english in APISIX Dashboard 
[#2212](https://github.com/apache/apisix-dashboard/pull/2212)
+- feat: add gzip middleware 
[#2178](https://github.com/apache/apisix-dashboard/pull/2178)
+- feat: add Type function to store interface 
[#2160](https://github.com/apache/apisix-dashboard/pull/2160)
+
+### Bugfix
+
+- fix: cp consumer name regx different with dp 
[#2232](https://github.com/apache/apisix-dashboard/pull/2232)
+- fix: plugin_configs should store with etcd prefix 
[#2226](https://github.com/apache/apisix-dashboard/pull/2226)
+- fix: correct the property name for tcp_failures 
[#2221](https://github.com/apache/apisix-dashboard/pull/2221)
+- fix: login repeat 2 times 
[#2179](https://github.com/apache/apisix-dashboard/pull/2179)
+- fix: select Use the domain or IP from Node List 
[#2168](https://github.com/apache/apisix-dashboard/pull/2168)
+
+### CI
+
+- ci: clean up the E2E test environment 
[#2225](https://github.com/apache/apisix-dashboard/pull/2225)
+- ci: add issue stale processor 
[#2169](https://github.com/apache/apisix-dashboard/pull/2169)
+
 # 2.9.0
 
 This release contains some features and bugfixes, and all the existing 
functionalities are compatible with Apache APISIX 2.10.0.
diff --git a/README.md b/README.md
index dc0569d..e97c6c3 100644
--- a/README.md
+++ b/README.md
@@ -32,7 +32,7 @@
 
 - The master version should be used with Apache APISIX master version.
 
-- The latest released version is [2.9.0](https://apisix.apache.org/downloads/) 
and is compatible with [Apache APISIX 
2.10.0](https://apisix.apache.org/downloads/).
+- The latest released version is 
[2.10.0](https://apisix.apache.org/downloads/) and is compatible with [Apache 
APISIX 2.11.0](https://apisix.apache.org/downloads/).
 
 ## What's Apache APISIX Dashboard
 
diff --git a/api/VERSION b/api/VERSION
index c8e38b6..10c2c0c 100644
--- a/api/VERSION
+++ b/api/VERSION
@@ -1 +1 @@
-2.9.0
+2.10.0
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
index 9c1869d..5b66c37 100644
--- a/docs/en/latest/config.json
+++ b/docs/en/latest/config.json
@@ -1,5 +1,5 @@
 {
-  "version": "2.9.0",
+  "version": "2.10.0",
   "sidebar": [
 {
   "type": "category",
diff --git a/docs/en/latest/develop.md b/docs/en/latest/develop.md
index b0102fe..23fb767 100644
--- a/docs/en/latest/develop.md
+++ b/docs/en/latest/develop.md
@@ -30,7 +30,7 @@ Before development, refer to this [guide](./deploy.md) to 
install dependencies.
 ## Clone the project
 
 ```sh
-$ git clone -b release/2.9.0 https://github.com/apache/apisix-dashboard.git
+$ git clone -b release/2.10.0 https://github.com/apache/apisix-dashboard.git
 ```
 
 ## Start developing
diff --git a/docs/en/latest/install.md b/docs/en/latest/install.md
index bd3d110..97ffda9 100644
--- a/docs/en/latest/install.md
+++ b/docs/en/latest/install.md
@@ -48,7 +48,7 @@ Please replace `` to your configure file path.
 
 ```shell
 # 1. install RPM package
-sudo yum install -y 
https://github.com/apache/apisix-dashboard/releases/download/v2.9.0/apisix-dashboard-2.9.0-0.el7.x86_64.rpm
+sudo yum install -y 
https://github.com/apache/apisix-dashboard/releases/download/v2.10.0/apisix-dashboard-2.10.0-0.el7.x86_64.rpm
 ```
 
 ### Launch
@@ -91,7 +91,7 @@ For `web`:
 ### Download {#source-download}
 
 ```shell
-git clone -b release/2.9.0 https://github.com/apache/apisix-dashboard.git && 
cd apisix-dashboard
+git clone -b release/2.10.0 

[GitHub] [apisix] spacewander commented on issue #5798: bug: the presence of plugin information is overwritten when generating the schema.json file

2021-12-14 Thread GitBox


spacewander commented on issue #5798:
URL: https://github.com/apache/apisix/issues/5798#issuecomment-994411161


   Fixed in https://github.com/apache/apisix/pull/4947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander closed issue #5798: bug: the presence of plugin information is overwritten when generating the schema.json file

2021-12-14 Thread GitBox


spacewander closed issue #5798:
URL: https://github.com/apache/apisix/issues/5798


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #196: feat(apisix): add component label

2021-12-14 Thread GitBox


tao12345666333 commented on a change in pull request #196:
URL: https://github.com/apache/apisix-helm-chart/pull/196#discussion_r769316230



##
File path: charts/apisix/templates/service-admin.yaml
##
@@ -25,6 +25,7 @@ metadata:
 {{- end }}
   labels:
 {{- include "apisix.labels" . | nindent 4 }}
+app.kubernetes.io/component: apisix-admin

Review comment:
   In fact, from the semantics of `component`, they are the same componet.
   I don’t think this label is reasonable enough.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-dashboard] tag v2.10 created (now a896a8b)

2021-12-14 Thread okaybase
This is an automated email from the ASF dual-hosted git repository.

okaybase pushed a change to tag v2.10
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.


  at a896a8b  (commit)
No new revisions were added by this update.


[GitHub] [apisix] bzp2010 commented on a change in pull request #5779: feat: supprot OPA plugin complex response

2021-12-14 Thread GitBox


bzp2010 commented on a change in pull request #5779:
URL: https://github.com/apache/apisix/pull/5779#discussion_r769291451



##
File path: apisix/plugins/opa.lua
##
@@ -89,13 +90,31 @@ function _M.access(conf, ctx)
 -- parse the results of the decision
 local data, err = core.json.decode(res.body)
 
-if err then
+if err or not data or not data.result then
 core.log.error("invalid response body: ", res.body, " err: ", err)

Review comment:
   splited to "invalid response body" and "invalid OPA decision format"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] laughingyear commented on issue #5799: request help: install issue

2021-12-14 Thread GitBox


laughingyear commented on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994401584


   > > > > > Please follow this doc 
https://apisix.apache.org/docs/apisix/how-to-build to install Apache APISIX, 
thanks.
   > > > > 
   > > > > 
   > > > > i follow this,it shows
   > > > > failure: repodata/repomd.xml from release: [Errno 256] No more 
mirrors to try. 
https://repos.apiseven.com/packages/centos/2.2/x86_64/repodata/repomd.xml: 
[Errno 14] HTTPS Error 404 - Not Found
   > > > 
   > > > 
   > > > Hi, @laughingyear . Did you compile the kernel yourself? The version 
`2.2` looks like a customised kernel. If you use customised kernel, this guide 
may not be suiteable for you.
   > > 
   > > 
   > > is there some way i can install?
   > 
   > If you use customised kernel, you need install dependencies by your self. 
There is a shell script to install dependencies, you could refer 
[here](https://github.com/apache/apisix/blob/936d9ac72b722b308a0a0dce01e0784a135d0cef/utils/install-dependencies.sh#L46)
   
   i reinstall openresty
   
   Installed:
 openresty.x86_64 0:1.19.9.1-1.el7  

 
   
   Dependency Installed:
 openresty-openssl111.x86_64 0:1.1.1l-1.el7 
   openresty-pcre.x86_64 0:8.44-1.el7
openresty-zlib.x86_64 0:1.2.11-3.el7.centos  
   
   then i reinstall apisix
   it shows:
   
   Error: apisix-base conflicts with openresty-1.19.9.1-1.el7.x86_64
You could try using --skip-broken to work around the problem
   ** Found 185 pre-existing rpmdb problem(s), 'yum check' output follows:
   
   apisix-base conflicts with openresty-1.19.9.1-1.el7.x86_64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] nic-chen commented on issue #5796: bug: The traffic split plug-in runs and reports an error according to the official configuration

2021-12-14 Thread GitBox


nic-chen commented on issue #5796:
URL: https://github.com/apache/apisix/issues/5796#issuecomment-994390161


   @zhangyiyou5  could you show the config of the route stored in ETCD?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-helm-chart] Gallardot opened a new pull request #196: feat(apisix): add component label

2021-12-14 Thread GitBox


Gallardot opened a new pull request #196:
URL: https://github.com/apache/apisix-helm-chart/pull/196


   The `servicemonitor` matches both `apisix-admin` and `apisix-gateway` 
services, and Prometheus generates two scrape jobs. Adding a `component` label 
would be more appropriate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-helm-chart] branch master updated: docs: add service monitor parameters doc (#194)

2021-12-14 Thread zhangjintao
This is an automated email from the ASF dual-hosted git repository.

zhangjintao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git


The following commit(s) were added to refs/heads/master by this push:
 new 8e150aa  docs: add service monitor parameters doc (#194)
8e150aa is described below

commit 8e150aa7b159d9b47cc94fd4981548b90792a4c9
Author: 祁宏钢 
AuthorDate: Wed Dec 15 14:21:24 2021 +0800

docs: add service monitor parameters doc (#194)
---
 charts/apisix/README.md | 12 
 1 file changed, 12 insertions(+)

diff --git a/charts/apisix/README.md b/charts/apisix/README.md
index 16c550a..039a67f 100644
--- a/charts/apisix/README.md
+++ b/charts/apisix/README.md
@@ -195,3 +195,15 @@ Configurations for apisix-dashboard sub chart.
 ### ingress-controller parameters
 
 Configurations for Apache APISIX ingress-controller sub chart.
+
+### serviceMonitor parameters
+
+| Parameter  | Description 
 | Default  |
+| -- | 
 | 
 |
+| `serviceMonitor.enabled`   | Enable or disable Apache APISIX 
serviceMonitor   | `false`  |
+| `serviceMonitor.namespace` | Namespace where the serviceMonitor is 
deployed   | `""` |
+| `serviceMonitor.interval`  | Interval at which metrics should be scraped 
 | `15s`|
+| `serviceMonitor.path`  | Path of the Prometheus metrics endpoint 
 | `/apisix/prometheus/metrics` |
+| `serviceMonitor.containerPort` | Container port which Prometheus metrics are 
exposed  | `9091`   |
+| `serviceMonitor.labels`| Label selector for select services and 
their underlying endpoint objects | `{}` |
+| `serviceMonitor.annotations`   | ServiceMonitor annotations  
 | `{}` |


[GitHub] [apisix] bzp2010 commented on a change in pull request #5779: feat: supprot OPA plugin complex response

2021-12-14 Thread GitBox


bzp2010 commented on a change in pull request #5779:
URL: https://github.com/apache/apisix/pull/5779#discussion_r769291451



##
File path: apisix/plugins/opa.lua
##
@@ -89,13 +90,31 @@ function _M.access(conf, ctx)
 -- parse the results of the decision
 local data, err = core.json.decode(res.body)
 
-if err then
+if err or not data or not data.result then
 core.log.error("invalid response body: ", res.body, " err: ", err)

Review comment:
   splited to "invalid response body" and "invalid OPA decision format"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] bzp2010 commented on a change in pull request #5779: feat: supprot OPA plugin complex response

2021-12-14 Thread GitBox


bzp2010 commented on a change in pull request #5779:
URL: https://github.com/apache/apisix/pull/5779#discussion_r769291451



##
File path: apisix/plugins/opa.lua
##
@@ -89,13 +90,31 @@ function _M.access(conf, ctx)
 -- parse the results of the decision
 local data, err = core.json.decode(res.body)
 
-if err then
+if err or not data or not data.result then
 core.log.error("invalid response body: ", res.body, " err: ", err)

Review comment:
   splited




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-helm-chart] qihonggang opened a new pull request #195: docs: update service monitor labels description

2021-12-14 Thread GitBox


qihonggang opened a new pull request #195:
URL: https://github.com/apache/apisix-helm-chart/pull/195


   update labels description #194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #194: docs: add service monitor parameters doc

2021-12-14 Thread GitBox


tao12345666333 merged pull request #194:
URL: https://github.com/apache/apisix-helm-chart/pull/194


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-14 Thread GitBox


tao12345666333 commented on pull request #791:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-994359893


   Sorry for delay. Let me take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] bzp2010 commented on a change in pull request #5779: feat: supprot OPA plugin complex response

2021-12-14 Thread GitBox


bzp2010 commented on a change in pull request #5779:
URL: https://github.com/apache/apisix/pull/5779#discussion_r769272000



##
File path: apisix/plugins/opa.lua
##
@@ -89,13 +90,31 @@ function _M.access(conf, ctx)
 -- parse the results of the decision
 local data, err = core.json.decode(res.body)
 
-if err then
+if err or not data or not data.result then
 core.log.error("invalid response body: ", res.body, " err: ", err)

Review comment:
   I split it into an "invalid response body", and "invalid OPA decision 
format: xxx err: `result` field does not exist".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao opened a new pull request #5819: feat(splunk): support splunk hec logging plugin

2021-12-14 Thread GitBox


shuaijinchao opened a new pull request #5819:
URL: https://github.com/apache/apisix/pull/5819


   ### What this PR does / why we need it:
   
   
   FIX #5636
   
   ### Pre-submission checklist:
   
   
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander merged pull request #5818: chore: don't use rebase to resolve merge conflicts

2021-12-14 Thread GitBox


spacewander merged pull request #5818:
URL: https://github.com/apache/apisix/pull/5818


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix] branch master updated: chore: don't use rebase to resolve merge conflicts (#5818)

2021-12-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new c567cf3  chore: don't use rebase to resolve merge conflicts (#5818)
c567cf3 is described below

commit c567cf32634cd848cd6314e6b7434f3ebd778ef2
Author: 罗泽轩 
AuthorDate: Wed Dec 15 13:58:00 2021 +0800

chore: don't use rebase to resolve merge conflicts (#5818)
---
 .github/PULL_REQUEST_TEMPLATE.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index e43448e..862a6ce 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -10,7 +10,8 @@ Please follow the requirements:
 2. Test is required for the feat/fix PR, unless you have a good reason
 3. Doc is required for the feat PR
 4. Use a new commit to resolve review instead of `push -f`
-5. Use "request review" to notify the reviewer once you have resolved the 
review
+5. If you need to resolve merge conflicts after the PR is reviewed, please 
merge master but do not rebase
+6. Use "request review" to notify the reviewer once you have resolved the 
review
 -->
 
 * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?


[GitHub] [apisix] spacewander opened a new pull request #5818: chore: don't use rebase to resolve merge conflicts

2021-12-14 Thread GitBox


spacewander opened a new pull request #5818:
URL: https://github.com/apache/apisix/pull/5818


   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj opened a new issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua

2021-12-14 Thread GitBox


zjzwjcbj opened a new issue #5817:
URL: https://github.com/apache/apisix/issues/5817


   ### Issue description
   
   macos Big Sur. M1 .When make install ,shows cannot mkdir /usr/share/lua .  I 
have closed SIP .How can I do?
   
   https://user-images.githubusercontent.com/26433840/146130503-52afa4e6-c005-4c24-9864-d84b33955929.png;>
   
   
   ### Environment
   
   - apisix version (cmd: `apisix version`):2.10.0
   - OS (cmd: `uname -a`):
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] guoqqqi commented on pull request #810: refactor: load images from CDN

2021-12-14 Thread GitBox


guoqqqi commented on pull request #810:
URL: https://github.com/apache/apisix-website/pull/810#issuecomment-994311671


   @Si-ege ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] vcqr closed issue #5815: bug: 使用nacos做服务发现,不支持spring cloud程序?

2021-12-14 Thread GitBox


vcqr closed issue #5815:
URL: https://github.com/apache/apisix/issues/5815


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on a change in pull request #5779: feat: supprot OPA plugin complex response

2021-12-14 Thread GitBox


spacewander commented on a change in pull request #5779:
URL: https://github.com/apache/apisix/pull/5779#discussion_r769238189



##
File path: apisix/plugins/opa.lua
##
@@ -89,13 +90,31 @@ function _M.access(conf, ctx)
 -- parse the results of the decision
 local data, err = core.json.decode(res.body)
 
-if err then
+if err or not data or not data.result then
 core.log.error("invalid response body: ", res.body, " err: ", err)

Review comment:
   We should distinguish "not data or not data.result" in the error log.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #811: docs: add Deploy APISIX in Kubernetes blog

2021-12-14 Thread GitBox


netlify[bot] edited a comment on pull request #811:
URL: https://github.com/apache/apisix-website/pull/811#issuecomment-994266352


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
    Explore the source changes: a5a207acbfa4a86ee6c8b468e0c31d97d3e9ae8b
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61b96949f05058a4fc58](https://app.netlify.com/sites/apache-apisix/deploys/61b96949f05058a4fc58)
   
    Browse the preview: 
[https://deploy-preview-811--apache-apisix.netlify.app](https://deploy-preview-811--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #811: docs: add Deploy APISIX in Kubernetes blog

2021-12-14 Thread GitBox


netlify[bot] edited a comment on pull request #811:
URL: https://github.com/apache/apisix-website/pull/811#issuecomment-994266352


    Deploy Preview for *apache-apisix* processing.
   
   
    Explore the source changes: a5a207acbfa4a86ee6c8b468e0c31d97d3e9ae8b
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61b96949f05058a4fc58](https://app.netlify.com/sites/apache-apisix/deploys/61b96949f05058a4fc58)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] laughingyear commented on issue #5799: request help: install issue

2021-12-14 Thread GitBox


laughingyear commented on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994270027


   > > > > > Please follow this doc 
https://apisix.apache.org/docs/apisix/how-to-build to install Apache APISIX, 
thanks.
   > > > > 
   > > > > 
   > > > > i follow this,it shows
   > > > > failure: repodata/repomd.xml from release: [Errno 256] No more 
mirrors to try. 
https://repos.apiseven.com/packages/centos/2.2/x86_64/repodata/repomd.xml: 
[Errno 14] HTTPS Error 404 - Not Found
   > > > 
   > > > 
   > > > Hi, @laughingyear . Did you compile the kernel yourself? The version 
`2.2` looks like a customised kernel. If you use customised kernel, this guide 
may not be suiteable for you.
   > > 
   > > 
   > > is there some way i can install?
   > 
   > If you use customised kernel, you need install dependencies by your self. 
There is a shell script to install dependencies, you could refer 
[here](https://github.com/apache/apisix/blob/936d9ac72b722b308a0a0dce01e0784a135d0cef/utils/install-dependencies.sh#L46)
   
   I change the apache-apisix.repo
   
   chage baseurl from
   baseurl=https://repos.apiseven.com/packages/centos/$releasever/$basearch
   
   to 
   baseurl=https://repos.apiseven.com/packages/centos/7/$basearch
   
   then i reinstall apisix:
   yum install apisix
   
   it shows:
   
   Error: Package: apisix-base-1.19.9.1.0-0.el7.x86_64 (release)
  Requires: openresty-openssl111 >= 1.1.1h-1
   Error: Package: apisix-base-1.19.9.1.0-0.el7.x86_64 (release)
  Requires: openresty-zlib >= 1.2.11-3
   Error: Package: apisix-base-1.19.9.1.0-0.el7.x86_64 (release)
  Requires: openresty-pcre >= 8.44-1
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2245: The `禁用` button on the plugin list page has ambiguity issues

2021-12-14 Thread GitBox


juzhiyuan commented on issue #2245:
URL: 
https://github.com/apache/apisix-dashboard/issues/2245#issuecomment-994269638


   Discussion could be found here. 
https://lists.apache.org/thread/z91bmlvstrj6hs8cmz0496tmd1orjmxc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #811: docs: add Deploy APISIX in Kubernetes blog

2021-12-14 Thread GitBox


netlify[bot] edited a comment on pull request #811:
URL: https://github.com/apache/apisix-website/pull/811#issuecomment-994266352


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
    Explore the source changes: f119af1b802cf8edfc11b5d139a4e220874cf169
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61b96716ec948b000888e25b](https://app.netlify.com/sites/apache-apisix/deploys/61b96716ec948b000888e25b)
   
    Browse the preview: 
[https://deploy-preview-811--apache-apisix.netlify.app](https://deploy-preview-811--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-helm-chart] qihonggang opened a new pull request #194: docs: add service monitor parameters doc

2021-12-14 Thread GitBox


qihonggang opened a new pull request #194:
URL: https://github.com/apache/apisix-helm-chart/pull/194


   add doc #192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #811: docs: add Deploy APISIX in Kubernetes blog

2021-12-14 Thread GitBox


netlify[bot] edited a comment on pull request #811:
URL: https://github.com/apache/apisix-website/pull/811#issuecomment-994266352


    Deploy Preview for *apache-apisix* processing.
   
   
    Explore the source changes: f119af1b802cf8edfc11b5d139a4e220874cf169
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61b96716ec948b000888e25b](https://app.netlify.com/sites/apache-apisix/deploys/61b96716ec948b000888e25b)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #811: docs: add Deploy APISIX in Kubernetes blog

2021-12-14 Thread GitBox


netlify[bot] edited a comment on pull request #811:
URL: https://github.com/apache/apisix-website/pull/811#issuecomment-994266352


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
    Explore the source changes: 87fbcc6433cec5e686be0c438a591caeb763beba
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61b9661470c3ee000821b52a](https://app.netlify.com/sites/apache-apisix/deploys/61b9661470c3ee000821b52a)
   
    Browse the preview: 
[https://deploy-preview-811--apache-apisix.netlify.app](https://deploy-preview-811--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] commented on pull request #811: docs: add Deploy APISIX in Kubernetes blog

2021-12-14 Thread GitBox


netlify[bot] commented on pull request #811:
URL: https://github.com/apache/apisix-website/pull/811#issuecomment-994266352


    Deploy Preview for *apache-apisix* processing.
   
   
    Explore the source changes: 87fbcc6433cec5e686be0c438a591caeb763beba
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61b9661470c3ee000821b52a](https://app.netlify.com/sites/apache-apisix/deploys/61b9661470c3ee000821b52a)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SylviaBABY opened a new pull request #811: docs: add Deploy APISIX in Kubernetes blog

2021-12-14 Thread GitBox


SylviaBABY opened a new pull request #811:
URL: https://github.com/apache/apisix-website/pull/811


   Changes: add Deploy APISIX in Kubernetes blog
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-java-plugin-runner] branch main updated: chore: upgrade log4j2 version to 2.16.0 (#99)

2021-12-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git


The following commit(s) were added to refs/heads/main by this push:
 new 82bef6b  chore: upgrade log4j2 version to 2.16.0 (#99)
82bef6b is described below

commit 82bef6b162887ac126c31477b3f477e5c50ffe8a
Author: tzssangglass 
AuthorDate: Wed Dec 15 11:49:28 2021 +0800

chore: upgrade log4j2 version to 2.16.0 (#99)
---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 5178f67..d8bd47f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -77,7 +77,7 @@
 
 org.apache.logging.log4j
 log4j-bom
-2.15.0
+2.16.0
 pom
 import
 


[GitHub] [apisix-dashboard] jie123108 opened a new issue #2245: The `禁用` button on the plugin list page has ambiguity issues

2021-12-14 Thread GitBox


jie123108 opened a new issue #2245:
URL: https://github.com/apache/apisix-dashboard/issues/2245


   ### Issue description
   
   I recently used the `apisix-dashboard` in my project, on the plugins list 
page, for a plugin that had been enabled. 
   It may not be appropriate to call it `禁用` here, right?   It would be more 
appropriate to name it "编辑”.
   
   `禁用` gives the impression that when you click it, the plugin will be 
disabled. But in fact it is edited (including the disable function)
   
   
   For those who are familiar with this feature, it may not be a problem. But a 
newcomer, seeing this `禁用` button for the first time, especially in a 
production environment, should be afraid to click it.
   
   ### Expected behavior
   
   Maybe a new `配置/编辑(Configure)` button should be used. The `禁用` button 
function becomes really disabled.
   
   ### How to Reproduce
   
   dashboard plagin pages
   
   ### Screenshots
   
   _No response_
   
   ### Environment
   
   - apisix version (cmd: `apisix version`):
   - OS (cmd: `uname -a`):
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `etcd --version`):
   - apisix-dashboard version, if have:
   - Browser version, if have:
   
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] spacewander merged pull request #99: chore: upgrade log4j2 version to 2.16.0

2021-12-14 Thread GitBox


spacewander merged pull request #99:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/99


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix] branch master updated: feat(vault): vault lua module, integration with jwt-auth authentication plugin (#5745)

2021-12-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 0d4f65a  feat(vault): vault lua module, integration with jwt-auth 
authentication plugin (#5745)
0d4f65a is described below

commit 0d4f65a9ae06430388af609ca0dcad386225d616
Author: Bisakh 
AuthorDate: Wed Dec 15 09:15:59 2021 +0530

feat(vault): vault lua module, integration with jwt-auth authentication 
plugin (#5745)
---
 apisix/core/vault.lua   | 122 
 apisix/plugins/jwt-auth.lua | 166 +
 ci/centos7-ci.sh|   3 +
 ci/common.sh|   6 +
 ci/linux-ci-init-service.sh |   3 +
 ci/linux_openresty_common_runner.sh |   5 +-
 ci/pod/docker-compose.yml   |  18 ++
 conf/config-default.yaml|  13 ++
 docs/en/latest/plugins/jwt-auth.md  |  89 -
 t/certs/private.pem |  27 +++
 t/certs/public.pem  |   9 +
 t/plugin/jwt-auth-vault.t   | 362 
 12 files changed, 777 insertions(+), 46 deletions(-)

diff --git a/apisix/core/vault.lua b/apisix/core/vault.lua
new file mode 100644
index 000..f98926d
--- /dev/null
+++ b/apisix/core/vault.lua
@@ -0,0 +1,122 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local http = require("resty.http")
+local json = require("cjson")
+
+local fetch_local_conf = require("apisix.core.config_local").local_conf
+local norm_path = require("pl.path").normpath
+
+local _M = {}
+
+local function fetch_vault_conf()
+local conf, err = fetch_local_conf()
+if not conf then
+return nil, "failed to fetch vault configuration from config yaml: " 
.. err
+end
+
+if not conf.vault then
+return nil, "accessing vault data requires configuration information"
+end
+return conf.vault
+end
+
+
+local function make_request_to_vault(method, key, skip_prefix, data)
+local vault, err = fetch_vault_conf()
+if not vault then
+return nil, err
+end
+
+local httpc = http.new()
+-- config timeout or default to 5000 ms
+httpc:set_timeout((vault.timeout or 5)*1000)
+
+local req_addr = vault.host
+if not skip_prefix then
+req_addr = req_addr .. norm_path("/v1/"
+.. vault.prefix .. "/" .. key)
+else
+req_addr = req_addr .. norm_path("/v1/" .. key)
+end
+
+local res, err = httpc:request_uri(req_addr, {
+method = method,
+headers = {
+["X-Vault-Token"] = vault.token
+},
+body = core.json.encode(data or  {}, true)
+})
+if not res then
+return nil, err
+end
+
+return res.body
+end
+
+-- key is the vault kv engine path, joined with config yaml vault prefix.
+-- It takes an extra optional boolean param skip_prefix. If enabled, it simply 
doesn't use the
+-- prefix defined inside config yaml under vault config for fetching data.
+local function get(key, skip_prefix)
+core.log.info("fetching data from vault for key: ", key)
+
+local res, err = make_request_to_vault("GET", key, skip_prefix)
+if not res or err then
+return nil, "failed to retrtive data from vault kv engine " .. err
+end
+
+return json.decode(res)
+end
+
+_M.get = get
+
+-- key is the vault kv engine path, data is json key vaule pair.
+-- It takes an extra optional boolean param skip_prefix. If enabled, it simply 
doesn't use the
+-- prefix defined inside config yaml under vault config for storing data.
+local function set(key, data, skip_prefix)
+core.log.info("stroing data into vault for key: ", key,
+"and value: ", core.json.delay_encode(data, true))
+
+local res, err = make_request_to_vault("POST", key, skip_prefix, data)
+if not res or err then
+return nil, "failed to store data into vault kv engine " .. err
+end
+
+return true
+end
+_M.set = set
+
+
+-- key is the vault kv engine path, joined with config yaml vault prefix.
+-- It takes an extra 

[GitHub] [apisix] spacewander merged pull request #5745: feat(vault): vault lua module, integration with jwt-auth authentication plugin

2021-12-14 Thread GitBox


spacewander merged pull request #5745:
URL: https://github.com/apache/apisix/pull/5745


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2105: Proposal: restful API for Route module

2021-12-14 Thread GitBox


juzhiyuan commented on issue #2105:
URL: 
https://github.com/apache/apisix-dashboard/issues/2105#issuecomment-994263985


   Yes, will continue this proposal in V3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on issue #5796: bug: The traffic split plug-in runs and reports an error according to the official configuration

2021-12-14 Thread GitBox


juzhiyuan commented on issue #5796:
URL: https://github.com/apache/apisix/issues/5796#issuecomment-994263213


   Thanks!
   
   > Steps to reproduce
   > step1:login APISIX Dashboard -> route -> edit-> next -> next -> 
Orchestration -> choose "traffic-split" -> input config -> > save
   > step2: Open browser to enter route, page show apisix err, log show as 
follows
   
   May need @nic-chen's help to have a check 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on pull request #5816: fix(mqtt-proxy): client id can be empty

2021-12-14 Thread GitBox


spacewander commented on pull request #5816:
URL: https://github.com/apache/apisix/pull/5816#issuecomment-994263179


   One can also use `-i client_id` to work around this, like `mosquitto_pub -t 
test -m "Hallo" -p 9100 -i aaa`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander opened a new pull request #5816: fix(mqtt-proxy): client id can be empty

2021-12-14 Thread GitBox


spacewander opened a new pull request #5816:
URL: https://github.com/apache/apisix/pull/5816


   Fix #5802
   
   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] bzp2010 commented on pull request #5779: feat: supprot OPA plugin complex response

2021-12-14 Thread GitBox


bzp2010 commented on pull request #5779:
URL: https://github.com/apache/apisix/pull/5779#issuecomment-994258788


   ping @shuaijinchao PTAL thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhangyiyou5 commented on issue #5796: bug: The traffic split plug-in runs and reports an error according to the official configuration

2021-12-14 Thread GitBox


zhangyiyou5 commented on issue #5796:
URL: https://github.com/apache/apisix/issues/5796#issuecomment-994258631


   > The replication process has been updated
   
   The replication process has been updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhangyiyou5 commented on issue #5796: bug: The traffic split plug-in runs and reports an error according to the official configuration

2021-12-14 Thread GitBox


zhangyiyou5 commented on issue #5796:
URL: https://github.com/apache/apisix/issues/5796#issuecomment-994258442


   > > 这个配置,放在旧版本中,是可以用的。 新版本就会提示这个语法错误
   > 
   > Hi, please provide more information about your issue, then we could know 
what exactly you encounter.
   > 
   > Back to your question, please provide your reproduction steps in more 
detailed.
   
   The replication process has been updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] vcqr opened a new issue #5815: bug: 使用nacos做服务发现,不支持spring cloud程序?

2021-12-14 Thread GitBox


vcqr opened a new issue #5815:
URL: https://github.com/apache/apisix/issues/5815


   ### Issue description
   
   [error] 47#47: *117481 upstream prematurely closed connection while reading 
response header from upstream
   
   ### Environment
   
   - apisix version (cmd: `apisix version`):
   - OS (cmd: `uname -a`):
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   
   
   ### Steps to reproduce
   
   使用spring cloud grpc程序注册到nacos中,port在meta data中gRPC_port=
   
   ### Actual result
   
   502 Bad Gateway
   openresty
   
   ### Error log
   
   [error] 47#47: *117481 upstream prematurely closed connection while reading 
response header from upstream, client: 172.18.0.1
   
   ### Expected result
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao commented on issue #5813: request help: Data import problem

2021-12-14 Thread GitBox


shuaijinchao commented on issue #5813:
URL: https://github.com/apache/apisix/issues/5813#issuecomment-994255487


   Currently there is no support for importing standalone mode data into etcd.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] dyrnq commented on issue #5814: bug: java plugin error permission denied

2021-12-14 Thread GitBox


dyrnq commented on issue #5814:
URL: https://github.com/apache/apisix/issues/5814#issuecomment-994254764


   open  user  configuration, such as `root` or other user with permission
   
   ```yaml
   apisix:
 nginx_config:   # config for render the template to 
generate nginx.conf
   user: root# specifies the execution user of the 
worker process.
 # the "user" directive makes sense only if 
the master process runs with super-user privileges.
 # if you're not root user,the default is 
current user.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zaunist commented on issue #5799: request help: install issue

2021-12-14 Thread GitBox


zaunist commented on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994254335


   > > > > Please follow this doc 
https://apisix.apache.org/docs/apisix/how-to-build to install Apache APISIX, 
thanks.
   > > > 
   > > > 
   > > > i follow this,it shows
   > > > failure: repodata/repomd.xml from release: [Errno 256] No more mirrors 
to try. 
https://repos.apiseven.com/packages/centos/2.2/x86_64/repodata/repomd.xml: 
[Errno 14] HTTPS Error 404 - Not Found
   > > 
   > > 
   > > Hi, @laughingyear . Did you compile the kernel yourself? The version 
`2.2` looks like a customised kernel. If you use customised kernel, this guide 
may not be suiteable for you.
   > 
   > is there some way i can install?
   
   If you use customised kernel, you need install dependencies by your self. 
There is a shell script to install dependencies, you could refer 
[here](https://github.com/apache/apisix/blob/936d9ac72b722b308a0a0dce01e0784a135d0cef/utils/install-dependencies.sh#L46)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zaunist removed a comment on issue #5799: request help: install issue

2021-12-14 Thread GitBox


zaunist removed a comment on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994253739


   > 
   
   If you use customised kernel, you need install dependencies by your self. 
There is a shell script to install dependencies, you could refer 
[here](https://github.com/apache/apisix/blob/936d9ac72b722b308a0a0dce01e0784a135d0cef/utils/install-dependencies.sh#L46)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zaunist commented on issue #5799: request help: install issue

2021-12-14 Thread GitBox


zaunist commented on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994253739


   > 
   
   If you use customised kernel, you need install dependencies by your self. 
There is a shell script to install dependencies, you could refer 
[here](https://github.com/apache/apisix/blob/936d9ac72b722b308a0a0dce01e0784a135d0cef/utils/install-dependencies.sh#L46)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] laughingyear commented on issue #5799: request help: install issue

2021-12-14 Thread GitBox


laughingyear commented on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994250951


   > > > Please follow this doc 
https://apisix.apache.org/docs/apisix/how-to-build to install Apache APISIX, 
thanks.
   > > 
   > > 
   > > i follow this,it shows
   > > failure: repodata/repomd.xml from release: [Errno 256] No more mirrors 
to try. 
https://repos.apiseven.com/packages/centos/2.2/x86_64/repodata/repomd.xml: 
[Errno 14] HTTPS Error 404 - Not Found
   > 
   > Hi, @laughingyear . Did you compile the kernel yourself? The version `2.2` 
looks like a customised kernel. If you use customised kernel, this guide may 
not be suiteable for you.
   
   is there some way i can install?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #99: chore: upgrade log4j2 version to 2.16.0

2021-12-14 Thread GitBox


tzssangglass opened a new pull request #99:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/99


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] sunyu-2020 commented on issue #5813: request help: Data import problem

2021-12-14 Thread GitBox


sunyu-2020 commented on issue #5813:
URL: https://github.com/apache/apisix/issues/5813#issuecomment-994250046


   Yes, is there a solution that has been implemented


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on issue #2105: Proposal: restful API for Route module

2021-12-14 Thread GitBox


zaunist commented on issue #2105:
URL: 
https://github.com/apache/apisix-dashboard/issues/2105#issuecomment-994248551


   Hi, community. My understanding, is this proposal to convert the manager-api 
into an adminapi?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on issue #2243: 默认没有监听 ipv4 TCP 使用ip:9000 不能访问

2021-12-14 Thread GitBox


zaunist commented on issue #2243:
URL: 
https://github.com/apache/apisix-dashboard/issues/2243#issuecomment-994247123


   Hi, @jusm , how do you build manager-api ? Could you give me more info ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-14 Thread GitBox


neverCase commented on pull request #791:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-994246184


   ping @tao12345666333 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] leslie-tsang edited a comment on issue #5813: request help: Data import problem

2021-12-14 Thread GitBox


leslie-tsang edited a comment on issue #5813:
URL: https://github.com/apache/apisix/issues/5813#issuecomment-994244413


   You mean start APISIX via [standalone 
mode](https://apisix.apache.org/zh/docs/apisix/stand-alone/) and then migrate 
the configuration in `apisix.yaml`(generate by 
[kong-to-apisix](https://github.com/api7/kong-to-apisix)) to etcd cluster ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #797: chore: specify the K8S cluster version used for the test

2021-12-14 Thread GitBox


gxthrj commented on pull request #797:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/797#issuecomment-994244986


   e2e failed. Re-runed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] sunyu-2020 opened a new issue #5814: bug: java plugin error permission denied

2021-12-14 Thread GitBox


sunyu-2020 opened a new issue #5814:
URL: https://github.com/apache/apisix/issues/5814


   ### Issue description
   
   Use java to develop extension plug-ins,se docker as a container,when the 
network is abnormal or the container restarts,the sock file in the container 
reports an error:permission denied
   
   ### Environment
   
   - apisix version (cmd: `apisix version`):
   - OS (cmd: `uname -a`):
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   
   
   ### Steps to reproduce
   
   Use java to develop extension plug-ins,se docker as a container,when the 
network is abnormal or the container restarts,the sock file in the container 
reports an error:permission denied
   
   ### Actual result
   
   The container restarts or the network is abnormal and no longer reports an 
error permission problem
   
   ### Error log
   
   2021/12/13 09:21:40 [error] 49#49: *1748952 [lua] init.lua:689: 
phase_func(): failed to connect to the unix socket 
unix:/usr/local/apisix/conf/apisix-46.sock: permission denied, 
   
   ### Expected result
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] leslie-tsang commented on issue #5813: request help: Data import problem

2021-12-14 Thread GitBox


leslie-tsang commented on issue #5813:
URL: https://github.com/apache/apisix/issues/5813#issuecomment-994244413


   You mean start APISIX via `standalone mode` and then migrate the 
configuration in `apisix.yaml` to etcd cluster ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zaunist edited a comment on issue #5799: request help: install issue

2021-12-14 Thread GitBox


zaunist edited a comment on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994243130


   > > Please follow this doc 
https://apisix.apache.org/docs/apisix/how-to-build to install Apache APISIX, 
thanks.
   > 
   > i follow this,it shows
   > 
   > failure: repodata/repomd.xml from release: [Errno 256] No more mirrors to 
try. https://repos.apiseven.com/packages/centos/2.2/x86_64/repodata/repomd.xml: 
[Errno 14] HTTPS Error 404 - Not Found
   
   Hi, @laughingyear . Did you compile the kernel yourself? The version `2.2` 
looks like a customised kernel. If you use customised kernel, this guide may 
not be suiteable for you. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zaunist commented on issue #5799: request help: install issue

2021-12-14 Thread GitBox


zaunist commented on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994243130


   > > Please follow this doc 
https://apisix.apache.org/docs/apisix/how-to-build to install Apache APISIX, 
thanks.
   > 
   > i follow this,it shows
   > 
   > failure: repodata/repomd.xml from release: [Errno 256] No more mirrors to 
try. https://repos.apiseven.com/packages/centos/2.2/x86_64/repodata/repomd.xml: 
[Errno 14] HTTPS Error 404 - Not Found
   
   Hi, @laughingyear . Did you compile the kernel yourself? The version `2.2` 
looks like a customised kernel. If you use customised kernel, this guide may 
not be for you. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zuiyangqingzhou commented on issue #5798: bug: the presence of plugin information is overwritten when generating the schema.json file

2021-12-14 Thread GitBox


zuiyangqingzhou commented on issue #5798:
URL: https://github.com/apache/apisix/issues/5798#issuecomment-994242873


   > > add test_mode = {type = "boolean",default = false,} to the schema 
configuration file of the plugin limit-conn
   > 
   > There are two limit-conn plugins: 
https://github.com/apache/apisix/blob/master/apisix/plugins/limit-conn.lua 
https://github.com/apache/apisix/blob/master/apisix/stream/plugins/limit-conn.lua
   > 
   > Which plugin do you add the field to?
   
   this one: 
https://github.com/apache/apisix/blob/master/apisix/plugins/limit-conn.lua
   
   export via `127.0.0.1:9090/v1/schema` will be overwritten by stream 
limit-conn
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] sunyu-2020 opened a new issue #5813: request help: Data import problem

2021-12-14 Thread GitBox


sunyu-2020 opened a new issue #5813:
URL: https://github.com/apache/apisix/issues/5813


   ### Issue description
   
   How to import apisix.yaml into etcd cluster
   
   ### Environment
   
   - apisix version (cmd: `apisix version`):
   - OS (cmd: `uname -a`):
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] ctdsyz opened a new issue #5812: feat: support to use plugin_config_id for Service

2021-12-14 Thread GitBox


ctdsyz opened a new issue #5812:
URL: https://github.com/apache/apisix/issues/5812


   ### Issue description
   
   Now, only Route supports the plugin_config_id to reuse common plugin 
configurations.
   
   It is useful to support plugin_config_id for Service too, since it already 
has a property named "plugins": 
 
https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#service
   
   
   
   ### Environment
   
   - all version
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on issue #5799: request help: install issue

2021-12-14 Thread GitBox


juzhiyuan commented on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994236392


   No idea what happened 藍藍 need @shuaijinchao's help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on a change in pull request #5793: docs: sync stream proxy Chinese version

2021-12-14 Thread GitBox


tzssangglass commented on a change in pull request #5793:
URL: https://github.com/apache/apisix/pull/5793#discussion_r769189003



##
File path: docs/zh/latest/stream-proxy.md
##
@@ -147,7 +147,7 @@ curl http://127.0.0.1:9080/apisix/admin/stream_routes/1 -H 
'X-API-KEY: edd1c9f03
ERROR 2013 (HY000): Lost connection to MySQL server at 'reading initial 
communication packet', system error: 2
```
 
-   Instead making a request to the APISIX host and port where the filter 
matching succeeds:
+   而给 APISIX 的主机和端口发出请求,过滤器匹配成功。

Review comment:
   I see, here seems a little unclear. 
   
   Here we can express: the following request matches stream route 1, so it can 
be proxied to mysql normally.

##
File path: docs/zh/latest/stream-proxy.md
##
@@ -92,6 +96,68 @@ curl http://127.0.0.1:9080/apisix/admin/stream_routes/1 -H 
'X-API-KEY: edd1c9f03
 
 例子中 APISIX 会把服务器地址为 `127.0.0.1`, 端口为 `2000` 代理到上游地址 `127.0.0.1:1995`。
 
+让我们再举一个实际场景的例子:
+
+1. 将此配置放在 `config.yaml` 中
+
+   ```yaml
+   apisix:
+ stream_proxy: # TCP/UDP proxy
+   tcp: # TCP proxy address list
+ - 9100 # by default uses 0.0.0.0
+ - "127.0.0.10:9101"
+   ```
+
+2. 现在运行一个 mysql docker 容器并将端口 3306 暴露给主机
+
+   ```shell
+   $ docker run --name mysql -e MYSQL_ROOT_PASSWORD=toor -p 3306:3306 -d mysql
+   # check it using a mysql client that it works
+   $ mysql --host=127.0.0.1 --port=3306 -u root -p
+   Enter password:
+   Welcome to the MySQL monitor.  Commands end with ; or \g.
+   Your MySQL connection id is 25
+   ...
+   mysql>
+   ```
+
+3. 现在我们将创建一个带有服务器过滤的 stream 路由:
+
+   ```shell
+   curl http://127.0.0.1:9080/apisix/admin/stream_routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+   {
+   "server_addr": "127.0.0.10",
+   "server_port": 9101,
+   "upstream": {
+   "nodes": {
+   "127.0.0.1:3306": 1
+   },
+   "type": "roundrobin"
+   }
+   }'
+   ```
+
+   每当 APISIX 服务器 `127.0.0.10` 和端口 `9101` 收到连接时,它只会将请求转发到 mysql 上游。让我们测试一下:
+
+4. 向 `9100` 发出请求(在 config.yaml 中启用 stream 代理端口),过滤器匹配失败。
+
+   ```shell
+   $ mysql --host=127.0.0.1 --port=9100 -u root -p
+   Enter password:
+   ERROR 2013 (HY000): Lost connection to MySQL server at 'reading initial 
communication packet', system error: 2

Review comment:
   Is there any special output in the apisix logs at the time of this error?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] laughingyear commented on issue #5799: request help: install issue

2021-12-14 Thread GitBox


laughingyear commented on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994221803


   > Please follow this doc https://apisix.apache.org/docs/apisix/how-to-build 
to install Apache APISIX, thanks.
   
   i follow this,it shows
   
   failure: repodata/repomd.xml from release: [Errno 256] No more mirrors to 
try.
   https://repos.apiseven.com/packages/centos/2.2/x86_64/repodata/repomd.xml: 
[Errno 14] HTTPS Error 404 - Not Found


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] laughingyear commented on issue #5799: request help: install issue

2021-12-14 Thread GitBox


laughingyear commented on issue #5799:
URL: https://github.com/apache/apisix/issues/5799#issuecomment-994221556


   > same as #4594
   > 
   > try with [#4594 
(comment)](https://github.com/apache/apisix/issues/4594#issuecomment-879225419)
   
   i try as follow:
   "
   You can try the following steps:
   
   rm -rf /apisix-path/deps
   Recompile and install luarocks and specify the luajit header file directory, 
for example: ./configure 
--with-lua-include=/openresty-path/luajit/include/luajit-2.1
   Enter the apisix directory and re-execute make deps to install dependencies
   "
   
   when i rerun "make deps"
   it shows:
   Error: Failed installing dependency: 
https://luarocks.org/luasec-0.9-1.src.rock - Could not find header file for 
OPENSSL
 No file openssl/ssl.h in /usr/local/openresty/openssl/include
   You may have to install OPENSSL in your system and/or pass OPENSSL_DIR or 
OPENSSL_INCDIR to the luarocks command.
   Example: luarocks install luasec OPENSSL_DIR=/usr/local
   make: *** [deps] Error 1
   
   
   should I reinstall openssl? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj edited a comment on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


zjzwjcbj edited a comment on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994213546


   I use /apisix/admin/plugins/third-plugin   can find . But  list not found. 
   
![image](https://user-images.githubusercontent.com/26433840/146108252-03cf97df-2e78-468a-8721-6776a24b022a.png)
   
   curl http://127.0.0.1:9180/apisix/admin/plugins/list -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1'
   
   
["real-ip","zipkin","request-id","fault-injection","serverless-pre-function","key-auth","batch-requests","cors","ip-restriction","ua-restriction","referer-restriction","uri-blocker","request-validation","openid-connect","authz-casbin","wolf-rbac","hmac-auth","basic-auth","jwt-auth","consumer-restriction","authz-keycloak","proxy-mirror","proxy-cache","proxy-rewrite","api-breaker","limit-conn","limit-count","limit-req","node-status","gzip","traffic-split","redirect","response-rewrite","grpc-transcode","prometheus","echo","http-logger","sls-logger","tcp-logger","kafka-logger","syslog","udp-logger","serverless-post-function"]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #5755: [DISCUSS]: Improving the performance of the prometheus plugin

2021-12-14 Thread GitBox


tzssangglass commented on issue #5755:
URL: https://github.com/apache/apisix/issues/5755#issuecomment-994214217


   > I think this solution is similar to 
[Kong/kong@3fc3961](https://github.com/Kong/kong/commit/3fc396173856d6377d906543d6e538fccd3fea28)?
   > 
   > Maybe we can also use counter for it: 
[Kong/kong@`d65101f`/kong/tools/utils.lua#L1438](https://github.com/Kong/kong/blob/d65101fe80fd7ac9870a84d34d81bda8bcb461ac/kong/tools/utils.lua#L1438)
   
   counter is for call yield in a loop?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


zjzwjcbj commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994213546


   I use /apisix/admin/plugins/third-plugin   can find
   
![image](https://user-images.githubusercontent.com/26433840/146108252-03cf97df-2e78-468a-8721-6776a24b022a.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


tzssangglass commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994211018


   > I change the config-default.yaml and the config.yaml is not changed. Is it 
right?
   
   no, we should not change `config-default.yaml`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


tzssangglass commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994210739


   my version is 2.10.2, I don't think it's a version problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


zjzwjcbj commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994210728


   > > You can check if the plugin file exists in the `apisix/plugins/` 
directory and the permissions of the file.
   > 
   > Can it be the version problem? 
![image](https://user-images.githubusercontent.com/26433840/146106823-797c209e-7413-4992-a726-aebbbf83b134.png)
   
   I  change the config-default.yaml  and the config.yaml is not changed.  Is 
it right?
   
![image](https://user-images.githubusercontent.com/26433840/146107651-0160b750-964b-49b7-a789-3a30d23361a5.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj edited a comment on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


zjzwjcbj edited a comment on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994206507


   And  I change the
   
   > You can check if the plugin file exists in the `apisix/plugins/` directory 
and the permissions of the file.
   Seem no difference 
   
![image](https://user-images.githubusercontent.com/26433840/146107239-2a7c9f8a-1692-43a7-a46e-6df70fd7719d.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


zjzwjcbj commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994207036


   > You can check if the plugin file exists in the `apisix/plugins/` directory 
and the permissions of the file.
   
   Can it be the version problem
   
![image](https://user-images.githubusercontent.com/26433840/146106823-797c209e-7413-4992-a726-aebbbf83b134.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj edited a comment on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


zjzwjcbj edited a comment on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994207036


   > You can check if the plugin file exists in the `apisix/plugins/` directory 
and the permissions of the file.
   
   Can it be the version problem?
   
![image](https://user-images.githubusercontent.com/26433840/146106823-797c209e-7413-4992-a726-aebbbf83b134.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


zjzwjcbj commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994206507


   And  I change the
   
   > You can check if the plugin file exists in the `apisix/plugins/` directory 
and the permissions of the file.
   Seem no difference 
   
![image](https://user-images.githubusercontent.com/26433840/146106683-a55c76fa-d00b-4dd2-9e74-b20a51b15c88.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


tzssangglass commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994205621


   You can check if the plugin file exists in the `apisix/plugins/` directory 
and the permissions of the file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


tzssangglass commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994204454


   I cannot reproduce it.
   
   ```
   $ ls apisix/plugins/third-plugin.lua
   apisix/plugins/third-plugin.lua
   ```
   
   here is my log, you can see that plugin is in used.
   ```
   2021/12/15 09:27:40 [warn] 88794#3201972: *35259 [lua] third-plugin.lua:19: 
phase_func(): test, client: 127.0.0.1, server: _, request: "GET /get 
HTTP/1.1", host: "127.0.0.1:9080"
   2021/12/15 09:27:40 [warn] 88794#3201972: *35259 [lua] third-plugin.lua:20: 
phase_func(): nil, client: 127.0.0.1, server: _, request: "GET /get HTTP/1.1", 
host: "127.0.0.1:9080"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #797: chore: specify the K8S cluster version used for the test

2021-12-14 Thread GitBox


codecov-commenter commented on pull request #797:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/797#issuecomment-994203158


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#797](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (c1fbfbd) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/d4c5b093e95fca630f9a879111c3394fd1b12ec6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (d4c5b09) will **increase** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #797  +/-   ##
   ==
   + Coverage   33.09%   33.14%   +0.04% 
   ==
 Files  67   67  
 Lines7127 7142  +15 
   ==
   + Hits 2359 2367   +8 
   - Misses   4499 4505   +6 
   - Partials  269  270   +1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv)
 | `72.72% <0.00%> (-2.28%)` | :arrow_down: |
   | 
[pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==)
 | `1.00% <0.00%> (-0.01%)` | :arrow_down: |
   | 
[test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv)
 | | |
   | 
[pkg/api/router/apisix\_healthz.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvYXBpc2l4X2hlYWx0aHouZ28=)
 | `66.66% <0.00%> (ø)` | |
   | 
[pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=)
 | `82.27% <0.00%> (+0.46%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Last update 
[d4c5b09...c1fbfbd](https://codecov.io/gh/apache/apisix-ingress-controller/pull/797?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


zjzwjcbj commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994201859


   > can you show the `third-party` plugin' code as text, let me check it.
   
   
   
   > > can you show the `third-party` plugin' code as text, let me check it.
   > 
   > local core = require("apisix.core") local plugin_name = "third-plugin" 
local schema = { type = "object", properties = { content = { type = "string" } 
} }
   > 
   > local _M = { version = 0.2, priority = 5000, name = plugin_name, schema = 
schema, }
   > 
   > function _M.access(conf, ctx) core.log.warn("test") 
core.log.warn(conf.content) end
   > 
   > return _M
   
   
   
   > can you show the `third-party` plugin' code as text, let me check it.
   
   The code should be ok.I changed the 'key-auth.lua' plugin with this code and 
it worked.
   
![image](https://user-images.githubusercontent.com/26433840/146105733-e5656ea3-ba2b-4330-96ea-08f4ab81fbd2.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #797: chore: specify the K8S cluster version used for the test

2021-12-14 Thread GitBox


tao12345666333 opened a new pull request #797:
URL: https://github.com/apache/apisix-ingress-controller/pull/797


   Signed-off-by: Jintao Zhang 
   
   
   
   ### Type of change:
   
   
   
 - [x] CI
   
   ### What this PR does / why we need it:
   
   
   
   Specify the K8S cluster version used for the test. To avoid CI failure 
due to inconsistent local environment version.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-14 Thread GitBox


tzssangglass commented on issue #5767:
URL: https://github.com/apache/apisix/issues/5767#issuecomment-994200318


   > from the log , that is 3 instance in the apisix, but that is one in the 
nacos.
   
   I don't really understand this. how did you determine that there were three 
instances? AFAIK, it is possible that the logs are output by different workers.
   
   pls provide some more information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-14 Thread GitBox


zjzwjcbj commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-994200350


   > can you show the `third-party` plugin' code as text, let me check it.
   
   local core = require("apisix.core")
   local plugin_name = "third-plugin"
   local schema = {
   type = "object",
   properties = {
   content = {
   type = "string" }
   }
   }
   
   local _M = {
   version = 0.2,
   priority = 5000,
   name = plugin_name,
   schema = schema,
   }
   
   function _M.access(conf, ctx)
   core.log.warn("test")
   core.log.warn(conf.content)
   end
   
   return _M


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on issue #5798: bug: the presence of plugin information is overwritten when generating the schema.json file

2021-12-14 Thread GitBox


spacewander commented on issue #5798:
URL: https://github.com/apache/apisix/issues/5798#issuecomment-994198368


   > add test_mode = {type = "boolean",default = false,} to the schema 
configuration file of the plugin limit-conn
   
   There are two limit-conn plugins:
   https://github.com/apache/apisix/blob/master/apisix/plugins/limit-conn.lua
   
https://github.com/apache/apisix/blob/master/apisix/stream/plugins/limit-conn.lua
   
   Which plugin do you add the field to?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on issue #5714: Proposal: support OpenPolicyAgent for access control

2021-12-14 Thread GitBox


juzhiyuan commented on issue #5714:
URL: https://github.com/apache/apisix/issues/5714#issuecomment-994198059


   Its here: https://www.openpolicyagent.org/docs/latest/ecosystem/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   >