[GitHub] [apisix-ingress-controller] suninuni commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
suninuni commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003300644 Thanks, I have no other questions. And for this panic, it depends on you whether to resolve it or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2276: feat: add dashboard overview
codecov-commenter edited a comment on pull request #2276: URL: https://github.com/apache/apisix-dashboard/pull/2276#issuecomment-1003299981 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2276?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2276](https://codecov.io/gh/apache/apisix-dashboard/pull/2276?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5b1a01e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25ac15a128aba569d9e7ad98e96425ef8026fd38?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25ac15a) will **decrease** coverage by `5.67%`. > The diff coverage is `9.30%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2276?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2276 +/- ## == - Coverage 68.07% 62.40% -5.68% == Files 127 58 -69 Lines3370 4032 +662 Branches 8290 -829 == + Hits 2294 2516 +222 - Misses 1076 1157 +81 - Partials0 359 +359 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `35.73% <9.30%> (?)` | | | backend-e2e-test-ginkgo | `57.96% <9.30%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2276?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `90.90% <ø> (ø)` | | | [api/internal/handler/overview/overview.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvb3ZlcnZpZXcvb3ZlcnZpZXcuZ28=) | `8.59% <8.59%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.80% <100.00%> (ø)` | | | [web/src/components/LabelsfDrawer/LabelsDrawer.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0xhYmVsc2ZEcmF3ZXIvTGFiZWxzRHJhd2VyLnRzeA==) | | | | [web/src/access.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hY2Nlc3MudHM=) | | | | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | | | | [web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=) | | | | [web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==) | | | |
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2276: feat: add dashboard overview
codecov-commenter commented on pull request #2276: URL: https://github.com/apache/apisix-dashboard/pull/2276#issuecomment-1003299981 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2276?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2276](https://codecov.io/gh/apache/apisix-dashboard/pull/2276?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5b1a01e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25ac15a128aba569d9e7ad98e96425ef8026fd38?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25ac15a) will **decrease** coverage by `32.33%`. > The diff coverage is `9.30%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2276?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2276 +/- ## === - Coverage 68.07% 35.73% -32.34% === Files 127 58 -69 Lines3370 4032 +662 Branches 8290 -829 === - Hits 2294 1441 -853 - Misses 1076 2324 +1248 - Partials0 267 +267 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `35.73% <9.30%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2276?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `68.18% <ø> (ø)` | | | [api/internal/handler/overview/overview.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvb3ZlcnZpZXcvb3ZlcnZpZXcuZ28=) | `8.59% <8.59%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `80.48% <100.00%> (ø)` | | | [...components/active-check/HttpsVerifyCertificate.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0h0dHBzVmVyaWZ5Q2VydGlmaWNhdGUudHN4) | | | | [...eb/src/components/Upstream/components/TimeUnit.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZVVuaXQudHN4) | | | | [...am/components/passive-check/Unhealthy/Timeouts.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9VbmhlYWx0aHkvVGltZW91dHMudHN4) | | | | [web/src/pages/SSL/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2276/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMi9pbmRleC50c3g=) | | | |
[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
tao12345666333 edited a comment on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003297684 When upgrading from APISIX Ingress v1.2 to v1.3, you need to upgrade ApisixRoute resources first, because we have removed the support for the following: * remove `spec.http[].backend` using `spec.http[].backends` instead * remove `spec.tcp` using `spec.stream` instead xref: https://github.com/apache/apisix-ingress-controller/pull/698 And we have introduced the `v2beta2` version of ApisixRoute, it's will be the default api version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
tao12345666333 edited a comment on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003299256 > Can I wait until version 1.5 to upgrade ApisixRoute from v1beta1 to v2? There are too many changes in our clusters for each modification. Yes, you can. Note the following configuration before upgrading: * `spec.http[].bakend` * `spec.stream` There is not much breaking change in other parts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
tao12345666333 commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003299256 > Can I wait until version 1.5 to upgrade ApisixRoute from v1beta1 to v2? There are too many changes in our clusters for each modification. Yes, you can. Note the following configuration before upgrading: * `spec.http.bakend` * `spec.stream` There is not much breaking change in other parts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Drery commented on pull request #5940: feat: mocking plugin
Drery commented on pull request #5940: URL: https://github.com/apache/apisix/pull/5940#issuecomment-1003299223 @shuaijinchao @juzhiyuan Thank you. I already send a proposal to the mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tiyorn opened a new issue #5983: request help: 上游配置https，一直报错401
tiyorn opened a new issue #5983: URL: https://github.com/apache/apisix/issues/5983 ### Issue description 上游配置为https，一直报401，怀疑跟ssl有关系。请问APISIX转发https请求至上游的时候，是否会受到SSL certificate verification的干扰，有没有开关可以关闭SSL certificates verify ### Environment - apisix version (cmd: `apisix version`):2.9 - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist opened a new pull request #2276: feat: add dashboard overview
zaunist opened a new pull request #2276: URL: https://github.com/apache/apisix-dashboard/pull/2276 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** added dashboard backend API for apisix status summary. **Related issues** ref https://summer.iscas.ac.cn/#/org/prodetail/210050270 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
tao12345666333 commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003298355 >In 1.4, apisix.apache.org/v2beta3 will be the stored version? Yes. In the last few versions, we are upgrading the api version, in order to make it easier to use. It is explained in the release note of version 1.3 and #707 https://github.com/apache/apisix-ingress-controller/blob/master/CHANGELOG.md#roadmap-1 > In next release(v1.4), all custom resource versions will be upgraded to version v2beta3, and version v2 will be GA released in version 1.5. Please go to #707 for detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
tao12345666333 commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003297684 When upgrading from APISIX Ingress v1.2 to v1.3, you need to upgrade ApisixRoute resources first, because we have removed the support for the following: * remove `spec.backend` using `spec.backends` instead * remove `spec.tcp` using `spec.stream` instead xref: https://github.com/apache/apisix-ingress-controller/pull/698 And we have introduced the `v2beta2` version of ApisixRoute, it's will be the default api version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] suninuni commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
suninuni commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003297698 > Can you try to run `kubectl api-resources --api-group=apisix.apache.org` ? > > ``` > $ kubectl api-resources --api-group=apisix.apache.org > NAME SHORTNAMES APIVERSION NAMESPACED KIND > apisixclusterconfigs acc apisix.apache.org/v2beta3 false ApisixClusterConfig > apisixconsumersac apisix.apache.org/v2beta3 true ApisixConsumer > apisixpluginconfigsapc apisix.apache.org/v2beta3 true ApisixPluginConfig > apisixroutes ar apisix.apache.org/v2beta3 true ApisixRoute > apisixtlsesatls apisix.apache.org/v2beta3 true ApisixTls > apisixupstreamsau apisix.apache.org/v2beta3 true ApisixUpstream > ``` In 1.4, apisix.apache.org/v2beta3 will be the stored version? Can I wait until version 1.5 to upgrade ApisixRoute from v1beta1 to v2? There are too many changes in our clusters for each modification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5969: Hope to add support for setting the custom host header to be used for upstream's artive checks!
tzssangglass commented on issue #5969: URL: https://github.com/apache/apisix/issues/5969#issuecomment-1003297286 @sandy420 pls check this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #105: fix: disable null as key of req/resp headers and args
tzssangglass opened a new pull request #105: URL: https://github.com/apache/apisix-java-plugin-runner/pull/105 Signed-off-by: tzssangglass Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bugfix - Description When the key of the following three functions is set to null, the request will block ``` httpResponse.setArg(null, null); httpResponse.setReqHeader(null, null); httpResponse.setHeader(null, null); ``` - How to fix? Add a judgement to stop this abnormal behaviour. ___ ### New feature or improvement - Describe the details and related test reports. - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lihuawei321 opened a new issue #5982: 怎样在access.log里输出upstream的名称
lihuawei321 opened a new issue #5982: URL: https://github.com/apache/apisix/issues/5982 ### Issue description 我用upstrem_name并没有获取到上游的名称。 ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yourgracee edited a comment on issue #5981: request help: 剪除路径后被再次路由
yourgracee edited a comment on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003296100 > please provide specific cases and steps to reproduce. 1.配置一条/foo/bar 改写为 /foo的路由正则改写（"regex_uri": ["^/foo/(.*)","/$1"]），绑定后端A服务 2.配置一条为/bar的路径重定向到其他路径，绑定后端B服务 3.访问/foo/bar 4.本应该跳转到A服务，结果跳转到B服务 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yourgracee edited a comment on issue #5981: request help: 剪除路径后被再次路由
yourgracee edited a comment on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003296100 > please provide specific cases and steps to reproduce. 1.配置一条/foo/bar 改写为 /foo的路由正则改写（"regex_uri": ["^/foo/(.*)","/$1"]），绑定后端A服务 2.配置一条为/foo的路径重定向到其他路径，绑定后端B服务 3.访问/foo/bar 4.本应该跳转到A服务，结果跳转到B服务 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yourgracee removed a comment on issue #5981: request help: 剪除路径后被再次路由
yourgracee removed a comment on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003295141 1.配置一条/foo/bar 改写为 /foo的路由正则改写，绑定后端A服务 2.配置一条为/foo的路径重定向到其他路径，绑定后端B服务 3.访问/foo/bar 4.本应该跳转到A服务，结果跳转到B服务 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yourgracee commented on issue #5981: request help: 剪除路径后被再次路由
yourgracee commented on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003296100 > please provide specific cases and steps to reproduce. 1.配置一条/foo/bar 改写为 /foo的路由正则改写，绑定后端A服务 2.配置一条为/foo的路径重定向到其他路径，绑定后端B服务 3.访问/foo/bar 4.本应该跳转到A服务，结果跳转到B服务 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yourgracee edited a comment on issue #5981: request help: 剪除路径后被再次路由
yourgracee edited a comment on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003295141 1.配置一条/foo/bar 改写为 /foo的路由正则改写，绑定后端A服务 2.配置一条为/foo的路径重定向到其他路径，绑定后端B服务 3.访问/foo/bar 4.本应该跳转到A服务，结果跳转到B服务 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] suninuni commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
suninuni commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003295147 > Can you try to run `kubectl api-resources --api-group=apisix.apache.org` ? > > ``` > $ kubectl api-resources --api-group=apisix.apache.org > NAME SHORTNAMES APIVERSION NAMESPACED KIND > apisixclusterconfigs acc apisix.apache.org/v2beta3 false ApisixClusterConfig > apisixconsumersac apisix.apache.org/v2beta3 true ApisixConsumer > apisixpluginconfigsapc apisix.apache.org/v2beta3 true ApisixPluginConfig > apisixroutes ar apisix.apache.org/v2beta3 true ApisixRoute > apisixtlsesatls apisix.apache.org/v2beta3 true ApisixTls > apisixupstreamsau apisix.apache.org/v2beta3 true ApisixUpstream > ``` ``` # kubectl api-resources --api-group=apisix.apache.org NAME SHORTNAMES APIVERSION NAMESPACED KIND apisixclusterconfigs acc apisix.apache.org/v2alpha1 false ApisixClusterConfig apisixconsumersac apisix.apache.org/v2alpha1 true ApisixConsumer apisixroutes ar apisix.apache.org/v2beta2true ApisixRoute apisixtlsesatls apisix.apache.org/v1 true ApisixTls apisixupstreamsau apisix.apache.org/v1 true ApisixUpstream ``` Now I can get it normally, maybe I can try it when I upgrade other environments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yourgracee commented on issue #5981: request help: 剪除路径后被再次路由
yourgracee commented on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003295141 1.配置一条/foo/bar 改写为 /foo的路由正则改写，绑定后端A服务 2.配置一条为/foo的路径重定向到其他服务，绑定后端B服务 3.访问/foo/bar 4.本应该跳转到A服务，结果跳转到B服务 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #5981: request help: 剪除路径后被再次路由
shuaijinchao commented on issue #5981: URL: https://github.com/apache/apisix/issues/5981#issuecomment-1003294573 please provide specific cases and steps to reproduce. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5979: feat: add separately install support for `install-dependencies.sh`
spacewander commented on a change in pull request #5979:
URL: https://github.com/apache/apisix/pull/5979#discussion_r776942418
##
File path: utils/install-dependencies.sh
##
@@ -125,15 +125,34 @@ function install_luarocks() {
# Entry
function main() {
OS_NAME=$(uname -s | tr '[:upper:]' '[:lower:]')
-if [[ "${OS_NAME}" == "linux" ]]; then
-multi_distro_installation
-install_luarocks
-install_etcd
-elif [[ "${OS_NAME}" == "darwin" ]]; then
-install_dependencies_on_mac_osx
-else
-echo "Non-surported distribution"
+if [[ "$#" == 0 ]]; then
+if [[ "${OS_NAME}" == "linux" ]]; then
+multi_distro_installation
+install_luarocks
+install_etcd
+elif [[ "${OS_NAME}" == "darwin" ]]; then
+install_dependencies_on_mac_osx
+else
+echo "Non-surported distribution"
+fi
+return
fi
+
+case_opt=$1
+case "${case_opt}" in
+"install_etcd")
+install_etcd
+;;
+"install_luarocks")
+install_luarocks
+;;
+"multi_distro_installation")
+multi_distro_installation
+;;
+*)
+echo "Unsupported method"
Review comment:
Better to echo the unknown input
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
tao12345666333 commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003292591 Can you try to run `kubectl api-resources --api-group=apisix.apache.org` ? ``` $ kubectl api-resources --api-group=apisix.apache.org NAME SHORTNAMES APIVERSION NAMESPACED KIND apisixclusterconfigs acc apisix.apache.org/v2beta3 false ApisixClusterConfig apisixconsumersac apisix.apache.org/v2beta3 true ApisixConsumer apisixpluginconfigsapc apisix.apache.org/v2beta3 true ApisixPluginConfig apisixroutes ar apisix.apache.org/v2beta3 true ApisixRoute apisixtlsesatls apisix.apache.org/v2beta3 true ApisixTls apisixupstreamsau apisix.apache.org/v2beta3 true ApisixUpstream ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5970: docs: add OPA plugin document
bzp2010 commented on a change in pull request #5970:
URL: https://github.com/apache/apisix/pull/5970#discussion_r776941626
##
File path: docs/en/latest/plugins/opa.md
##
@@ -0,0 +1,275 @@
+---
+title: opa
+---
+
+
+
+## Summary
+
+- [**Description**](#description)
+- [**Attributes**](#attributes)
+- [**Data Definition**](#data-definition)
+- [**Example**](#example)
+
+## Description
+
+The `opa` plugin is used to integrate with Open Policy Agent. By using this
plugin, users can decouple functions such as authentication and access to
services and reduce the complexity of the application system.
+
+## Attributes
+
+| Name | Type | Requirement | Default | Valid | Description |
+| -- | -- | -- | -- | -- | -- |
+| host | string | required | | | Open Policy Agent service host (eg.
https://localhost:8181) |
+| ssl_verify | boolean | optional | true | | Whether to verify the
certificate |
+| policy | string | required | | | OPA policy path (It is a combination of
`package` and `decision`. When you need to use advanced features such as custom
response, `decision` can be omitted) |
+| timeout | integer | optional | 6ms | [1, 6]ms | HTTP call timeout. |
+| keepalive | boolean | optional | true | | HTTP keepalive |
+| keepalive_timeout | integer | optional | 6ms | [1000,...] | keepalive
idle timeout |
+| keepalive_pool | integer | optional | 5 | [1,...] | Connection pool limit |
+| with_route | boolean | optional | false | | Whether to send information
about the current route. |
+| with_service | boolean | optional | false | | Whether to send information
about the current service. |
+| with_consumer | boolean | optional | false | | Whether to send information
about the current consumer. (It may contain sensitive information such as
apikey, so please turn it on only if you are sure it is safe) |
+
+## Data Definition
+
+### APISIX to OPA service
+
+The `type` indicates that the request type. (e.g. `http` or `stream`)
+The `reqesut` is used when the request type is `http`, it contains the basic
information of the request. (e.g. url, header)
+The `var` contains basic information about this requested connection. (e.g.
IP, port, request timestamp)
+The `route`, `service`, and `consumer` will be sent only after the `opa`
plugin has enabled the relevant features, and their contents are same as those
stored by APISIX in etcd.
+
+```json
+{
+"type": "http",
+"request": {
+"scheme": "http",
+"path": "\/get",
+"headers": {
+"user-agent": "curl\/7.68.0",
+"accept": "*\/*",
+"host": "127.0.0.1:9080"
+},
+"query": {},
+"port": 9080,
+"method": "GET",
+"host": "127.0.0.1"
+},
+"var": {
+"timestamp": 1701234567,
+"server_addr": "127.0.0.1",
+"server_port": "9080",
+"remote_port": "port",
+"remote_addr": "ip address"
+},
+"route": {},
+"service": {},
+"consumer": {}
+}
+```
+
+### OPA service response to APISIX
+
+In the response, `result` is automatically added by OPA. The `allow` is
indispensable and will indicate whether the request is allowed to be forwarded
through the APISIX.
+The reason, headers, and status_code are optional and are only returned when
you need to use a custom response, as you'll see in the next section with the
actual use case for it.
+
+```json
+{
+"result": {
Review comment:
We have used 4 spaces in the previous document, should I change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5970: docs: add OPA plugin document
bzp2010 commented on a change in pull request #5970: URL: https://github.com/apache/apisix/pull/5970#discussion_r776941462 ## File path: docs/en/latest/plugins/opa.md ## @@ -0,0 +1,275 @@ +--- +title: opa +--- + + + +## Summary + +- [**Description**](#description) +- [**Attributes**](#attributes) +- [**Data Definition**](#data-definition) +- [**Example**](#example) + +## Description + +The `opa` plugin is used to integrate with Open Policy Agent. By using this plugin, users can decouple functions such as authentication and access to services and reduce the complexity of the application system. + +## Attributes + +| Name | Type | Requirement | Default | Valid | Description | +| -- | -- | -- | -- | -- | -- | +| host | string | required | | | Open Policy Agent service host (eg. https://localhost:8181) | +| ssl_verify | boolean | optional | true | | Whether to verify the certificate | +| policy | string | required | | | OPA policy path (It is a combination of `package` and `decision`. When you need to use advanced features such as custom response, `decision` can be omitted) | +| timeout | integer | optional | 6ms | [1, 6]ms | HTTP call timeout. | Review comment: I think this is exactly in line with the expression of the concept of interval in mathematics, which means => 1 and <= 6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] suninuni commented on issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
suninuni commented on issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823#issuecomment-1003291552 related https://github.com/apache/apisix-ingress-controller/issues/672#issuecomment-973047308 @tao12345666333 And after I applied the new version of crd, I couldn't get ApisixRoute through k8s cli for a long time. Is there any way to refresh k8s api server? ``` Error from server (NotFound): Unable to list "apisix.apache.org/v1, Resource=apisixroutes": the server could not find the requested resource (get apisixroutes.apisix.apache.org) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2271](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9cd2df4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25ac15a128aba569d9e7ad98e96425ef8026fd38?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25ac15a) will **increase** coverage by `3.32%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2271 +/- ## == + Coverage 68.07% 71.39% +3.32% == Files 127 57 -70 Lines3370 3905 +535 Branches 8290 -829 == + Hits 2294 2788 +494 + Misses 1076 823 -253 - Partials0 294 +294 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.33% <100.00%> (?)` | | | backend-e2e-test-ginkgo | `59.46% <100.00%> (?)` | | | backend-unit-test | `49.19% <100.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `90.90% <ø> (ø)` | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `67.30% <100.00%> (ø)` | | | [web/src/pages/PluginTemplate/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9zZXJ2aWNlLnRz) | | | | [web/src/pages/Service/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvU3RlcDEudHN4) | | | | [...mponents/Upstream/components/active-check/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1R5cGUudHN4) | | | | [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | | | | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | | | |
[GitHub] [apisix-ingress-controller] suninuni opened a new issue #823: bug: panic when upgrade from 1.2 to 1.3 because of not set spec.http[].backends in v1beta1/ApisixRoute
suninuni opened a new issue #823: URL: https://github.com/apache/apisix-ingress-controller/issues/823 ### Issue description I upgraded apisixroute from v1alpha1 to v2beta1 before, so I kept `spec.http[].backend` in ApisixRoute. And now, I'm trying to upgrade apisix-ingress-controller from 1.2 to 1.3, then I ran into this problem. After investigation, this is because in the new version of CRD, ApisixRoute is stored as the v2beta2 version, but because the previous configuration file does not set `spec.http[].backends`, so `spec.http[].backends` is none in ApisixRoute v2beta2 version. ### Environment - 1.2 1.3 ### Minimal test code / Steps to reproduce 1. upgrade from 1.2 to 1.3 ### Actual result apisix-ingress-controller crashed. ### Error log ``` panic: runtime error: index out of range [0] with length 0 goroutine 300 [running]: github.com/apache/apisix-ingress-controller/pkg/kube/translation.(*translator).translateHTTPRouteV2beta2(0xc000402000, 0xc000246cb0, 0xc00076e000, 0x1cb68b9, 0x1cb68b9) /build/controller/pkg/kube/translation/apisix_route.go:320 +0x2400 github.com/apache/apisix-ingress-controller/pkg/kube/translation.(*translator).TranslateRouteV2beta2(0xc000402000, 0xc00076e000, 0x19, 0x1, 0x1) /build/controller/pkg/kube/translation/apisix_route.go:287 +0x7c github.com/apache/apisix-ingress-controller/pkg/ingress.(*apisixRouteController).sync(0xc0007646a0, 0x1fdabe0, 0xc3c280, 0xc00046ec00, 0x8, 0xc000948780) /build/controller/pkg/ingress/apisix_route.go:178 +0x2227 github.com/apache/apisix-ingress-controller/pkg/ingress.(*apisixRouteController).runWorker(0xc0007646a0, 0x1fdabe0, 0xc3c280) /build/controller/pkg/ingress/apisix_route.go:79 +0x57 created by github.com/apache/apisix-ingress-controller/pkg/ingress.(*apisixRouteController).run /build/controller/pkg/ingress/apisix_route.go:68 +0x245 ``` ### Expected result Avoid panic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yourgracee opened a new issue #5981: request help: 剪除路径后被再次路由
yourgracee opened a new issue #5981: URL: https://github.com/apache/apisix/issues/5981 ### Issue description 我按照官网文档FAQ中的方法剪除路径：  但是我还有一条路由规则是针对/bar的，因此再次被路由到不正确的服务，请问如何配置？ ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2271](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9cd2df4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25ac15a128aba569d9e7ad98e96425ef8026fd38?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25ac15a) will **decrease** coverage by `5.84%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2271 +/- ## == - Coverage 68.07% 62.22% -5.85% == Files 127 57 -70 Lines3370 3905 +535 Branches 8290 -829 == + Hits 2294 2430 +136 - Misses 1076 1190 +114 - Partials0 285 +285 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.33% <100.00%> (?)` | | | backend-unit-test | `49.19% <100.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `68.18% <ø> (ø)` | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `67.30% <100.00%> (ø)` | | | [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | | | | [web/src/pages/User/Logout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ291dC50c3g=) | | | | [web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb25zdGFudHMudHM=) | | | | [web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz) | | | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | | | | [web/src/pages/PluginTemplate/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9zZXJ2aWNlLnRz) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2271](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9cd2df4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25ac15a128aba569d9e7ad98e96425ef8026fd38?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25ac15a) will **decrease** coverage by `18.87%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2271 +/- ## === - Coverage 68.07% 49.19% -18.88% === Files 127 41 -86 Lines3370 3171 -199 Branches 8290 -829 === - Hits 2294 1560 -734 - Misses 1076 1412 +336 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.19% <100.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (ø)` | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `67.30% <100.00%> (ø)` | | | [web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=) | | | | [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | | | | [...omponents/passive-check/Unhealthy/HttpFailures.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9VbmhlYWx0aHkvSHR0cEZhaWx1cmVzLnRzeA==) | | | | [web/src/components/Plugin/UI/api-breaker.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9hcGktYnJlYWtlci50c3g=) | | | | [...nents/Upstream/components/active-check/Timeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1RpbWVvdXQudHN4) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2271](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (70cdc42) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25ac15a128aba569d9e7ad98e96425ef8026fd38?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25ac15a) will **decrease** coverage by `5.94%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2271 +/- ## == - Coverage 68.07% 62.12% -5.95% == Files 127 57 -70 Lines3370 3905 +535 Branches 8290 -829 == + Hits 2294 2426 +132 - Misses 1076 1193 +117 - Partials0 286 +286 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.15% <100.00%> (?)` | | | backend-unit-test | `49.22% <100.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `68.18% <ø> (ø)` | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `67.30% <100.00%> (ø)` | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [web/src/components/Plugin/UI/limit-conn.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb25uLnRzeA==) | | | | [web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=) | | | | [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | | | | [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | | | |
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5970: docs: add OPA plugin document
juzhiyuan commented on a change in pull request #5970:
URL: https://github.com/apache/apisix/pull/5970#discussion_r776939207
##
File path: docs/en/latest/plugins/opa.md
##
@@ -0,0 +1,275 @@
+---
+title: opa
+---
+
+
+
+## Summary
+
+- [**Description**](#description)
+- [**Attributes**](#attributes)
+- [**Data Definition**](#data-definition)
+- [**Example**](#example)
+
+## Description
+
+The `opa` plugin is used to integrate with Open Policy Agent. By using this
plugin, users can decouple functions such as authentication and access to
services and reduce the complexity of the application system.
Review comment:
Do we need to add a link to it?
```suggestion
The `opa` plugin is used to integrate with [Open Policy
Agent](https://www.openpolicyagent.org/). By using this plugin, users can
decouple functions such as authentication and access to services and reduce the
complexity of the application system.
```
##
File path: docs/en/latest/plugins/opa.md
##
@@ -0,0 +1,275 @@
+---
+title: opa
+---
+
+
+
+## Summary
+
+- [**Description**](#description)
+- [**Attributes**](#attributes)
+- [**Data Definition**](#data-definition)
+- [**Example**](#example)
+
+## Description
+
+The `opa` plugin is used to integrate with Open Policy Agent. By using this
plugin, users can decouple functions such as authentication and access to
services and reduce the complexity of the application system.
+
+## Attributes
+
+| Name | Type | Requirement | Default | Valid | Description |
+| -- | -- | -- | -- | -- | -- |
+| host | string | required | | | Open Policy Agent service host (eg.
https://localhost:8181) |
+| ssl_verify | boolean | optional | true | | Whether to verify the
certificate |
+| policy | string | required | | | OPA policy path (It is a combination of
`package` and `decision`. When you need to use advanced features such as custom
response, `decision` can be omitted) |
+| timeout | integer | optional | 6ms | [1, 6]ms | HTTP call timeout. |
+| keepalive | boolean | optional | true | | HTTP keepalive |
+| keepalive_timeout | integer | optional | 6ms | [1000,...] | keepalive
idle timeout |
+| keepalive_pool | integer | optional | 5 | [1,...] | Connection pool limit |
+| with_route | boolean | optional | false | | Whether to send information
about the current route. |
+| with_service | boolean | optional | false | | Whether to send information
about the current service. |
+| with_consumer | boolean | optional | false | | Whether to send information
about the current consumer. (It may contain sensitive information such as
apikey, so please turn it on only if you are sure it is safe) |
+
+## Data Definition
+
+### APISIX to OPA service
+
+The `type` indicates that the request type. (e.g. `http` or `stream`)
+The `reqesut` is used when the request type is `http`, it contains the basic
information of the request. (e.g. url, header)
+The `var` contains basic information about this requested connection. (e.g.
IP, port, request timestamp)
+The `route`, `service`, and `consumer` will be sent only after the `opa`
plugin has enabled the relevant features, and their contents are same as those
stored by APISIX in etcd.
+
+```json
+{
+"type": "http",
+"request": {
+"scheme": "http",
+"path": "\/get",
+"headers": {
+"user-agent": "curl\/7.68.0",
+"accept": "*\/*",
+"host": "127.0.0.1:9080"
+},
+"query": {},
+"port": 9080,
+"method": "GET",
+"host": "127.0.0.1"
+},
+"var": {
+"timestamp": 1701234567,
+"server_addr": "127.0.0.1",
+"server_port": "9080",
+"remote_port": "port",
+"remote_addr": "ip address"
+},
+"route": {},
+"service": {},
+"consumer": {}
+}
+```
+
+### OPA service response to APISIX
+
+In the response, `result` is automatically added by OPA. The `allow` is
indispensable and will indicate whether the request is allowed to be forwarded
through the APISIX.
+The reason, headers, and status_code are optional and are only returned when
you need to use a custom response, as you'll see in the next section with the
actual use case for it.
+
+```json
+{
+"result": {
Review comment:
Let's use 2 spaces here?
##
File path: docs/en/latest/plugins/opa.md
##
@@ -0,0 +1,275 @@
+---
+title: opa
+---
+
+
+
+## Summary
+
+- [**Description**](#description)
+- [**Attributes**](#attributes)
+- [**Data Definition**](#data-definition)
+- [**Example**](#example)
+
+## Description
+
+The `opa` plugin is used to integrate with Open Policy Agent. By using this
plugin, users can decouple functions such as authentication and access to
services and reduce the complexity of the application system.
+
+## Attributes
+
+| Name | Type | Requirement | Default | Valid | Description |
+| -- | -- | -- | -- | -- | -- |
+| host | string | required | | |
[GitHub] [apisix] spacewander opened a new pull request #5980: ci: rerun flaky tests
spacewander opened a new pull request #5980: URL: https://github.com/apache/apisix/pull/5980 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5727: feat: add CSRF plugin
juzhiyuan commented on a change in pull request #5727: URL: https://github.com/apache/apisix/pull/5727#discussion_r776939023 ## File path: docs/zh/latest/plugins/csrf.md ## @@ -65,7 +65,13 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335 这条路由已经开启保护，当你使用 GET 之外的方法访问，请求会被拦截并返回 401 状态码。 -2. 使用 `GET` 请求 `/hello`，在响应中会有一个携带了加密 `token` 的 `Cookie`。Token 字段的名字为插件配置中的 `name` 值，如果没有配置的话默认值为 `apisix_csrf_token`。 +2. 使用 `GET` 请求 `/hello`，在响应中会有一个携带了加密 `token` 的 `Cookie`。Token 字段的名字为插件配置中的 `name` 值，如果没有配置的话默认值为 `apisix-csrf-token`。 Review comment: ```suggestion 2. 使用 `GET` 请求 `/hello`，在响应中会有一个携带了加密 `token` 的 `Cookie`。Token 字段的名字为插件配置中的 `name` 值，如果没有配置该值，那么默认值为 `apisix-csrf-token`。 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2271](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (70cdc42) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25ac15a128aba569d9e7ad98e96425ef8026fd38?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25ac15a) will **decrease** coverage by `18.84%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2271 +/- ## === - Coverage 68.07% 49.22% -18.85% === Files 127 41 -86 Lines3370 3171 -199 Branches 8290 -829 === - Hits 2294 1561 -733 - Misses 1076 1411 +335 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.22% <100.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (ø)` | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `67.30% <100.00%> (ø)` | | | [web/src/components/LabelsfDrawer/LabelsDrawer.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0xhYmVsc2ZEcmF3ZXIvTGFiZWxzRHJhd2VyLnRzeA==) | | | | [web/src/access.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hY2Nlc3MudHM=) | | | | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | | | | [web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=) | | | | [web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==) | | | | [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | | | |
[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2271: feat(upstream): add upstream priority field
zaunist commented on a change in pull request #2271:
URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776938633
##
File path: api/internal/core/store/validate.go
##
@@ -165,12 +165,6 @@ func checkUpstream(upstream *entity.UpstreamDef) error {
return nil
}
- if upstream.PassHost == "node" && upstream.Nodes != nil {
- if nodes := entity.NodesFormat(upstream.Nodes);
len(nodes.([]*entity.Node)) != 1 {
- return fmt.Errorf("only support single node for `node`
mode currently")
- }
- }
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #104: fix: ensure correct encoding and decoding when data length is greater…
tzssangglass opened a new pull request #104: URL: https://github.com/apache/apisix-java-plugin-runner/pull/104 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #103: chore: support run on macos
tzssangglass opened a new pull request #103: URL: https://github.com/apache/apisix-java-plugin-runner/pull/103 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. support run and deug on macos - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #2271: feat(upstream): add upstream priority field
nic-chen commented on a change in pull request #2271:
URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776936358
##
File path: api/internal/core/store/validate.go
##
@@ -165,12 +165,6 @@ func checkUpstream(upstream *entity.UpstreamDef) error {
return nil
}
- if upstream.PassHost == "node" && upstream.Nodes != nil {
- if nodes := entity.NodesFormat(upstream.Nodes);
len(nodes.([]*entity.Node)) != 1 {
- return fmt.Errorf("only support single node for `node`
mode currently")
- }
- }
Review comment:
should not remove this block of code. see:
https://github.com/apache/apisix/blob/master/apisix/upstream.lua#L397-L401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2271: feat(upstream): add upstream priority field
starsz commented on a change in pull request #2271:
URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776934614
##
File path: api/internal/core/store/validate.go
##
@@ -165,12 +165,6 @@ func checkUpstream(upstream *entity.UpstreamDef) error {
return nil
}
- if upstream.PassHost == "node" && upstream.Nodes != nil {
- if nodes := entity.NodesFormat(upstream.Nodes);
len(nodes.([]*entity.Node)) != 1 {
- return fmt.Errorf("only support single node for `node`
mode currently")
- }
- }
Review comment:
@guoqqqi Need to adjust the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] crazyMonkey1995 edited a comment on issue #822: bug: CRD and Endpoint watch performance
crazyMonkey1995 edited a comment on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003280263 > > Okay, why not make an appointment next week, so I can summarize it briefly. > > Sure. Due to the holiday, how about we make an appointment next Tuesday 14:00? Or other time you have free. Emailed you.How about 5pm, I had other arrangements earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang opened a new pull request #5979: feat: add separately install support for `install-dependencies.sh`
leslie-tsang opened a new pull request #5979: URL: https://github.com/apache/apisix/pull/5979 ### What this PR does / why we need it: Add separately install support for [install-dependencies.sh](https://github.com/apache/apisix/blob/master/utils/install-dependencies.sh) Ref to #5795 > Now we can install via ```bash ./utils/install-dependencies.sh install_etcd ``` ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003280263 > > Okay, why not make an appointment next week, so I can summarize it briefly. > > Sure. Due to the holiday, how about we make an appointment next Tuesday 14:00? Or other time you have free. Emailed you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #799: proposal: Add annotations to combine ApisixPluginConfig with k8s ingress resource
tao12345666333 commented on issue #799: URL: https://github.com/apache/apisix-ingress-controller/issues/799#issuecomment-1003278806 Hi, ApisixPluginConfig has been implemented. See #638 for details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2271](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a9afa95) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25ac15a128aba569d9e7ad98e96425ef8026fd38?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25ac15a) will **increase** coverage by `3.14%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2271 +/- ## == + Coverage 68.07% 71.21% +3.14% == Files 127 57 -70 Lines3370 3902 +532 Branches 8290 -829 == + Hits 2294 2779 +485 + Misses 1076 831 -245 - Partials0 292 +292 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.05% <100.00%> (?)` | | | backend-e2e-test-ginkgo | `59.09% <100.00%> (?)` | | | backend-unit-test | `49.24% <100.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `90.90% <ø> (ø)` | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `71.28% <ø> (ø)` | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `67.30% <100.00%> (ø)` | | | [...tream/components/active-check/Healthy/Interval.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSW50ZXJ2YWwudHN4) | | | | [...mponents/Upstream/components/active-check/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1R5cGUudHN4) | | | | [web/src/pages/SSL/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvTGlzdC50c3g=) | | | | [...am/components/passive-check/Unhealthy/Timeouts.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9VbmhlYWx0aHkvVGltZW91dHMudHN4) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2271](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a9afa95) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25ac15a128aba569d9e7ad98e96425ef8026fd38?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25ac15a) will **decrease** coverage by `0.08%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2271 +/- ## == - Coverage 68.07% 67.99% -0.09% == Files 127 57 -70 Lines3370 3902 +532 Branches 8290 -829 == + Hits 2294 2653 +359 + Misses 1076 961 -115 - Partials0 288 +288 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `59.09% <100.00%> (?)` | | | backend-unit-test | `49.24% <100.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `90.90% <ø> (ø)` | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `71.28% <ø> (ø)` | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `67.30% <100.00%> (ø)` | | | [web/src/components/RightContent/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9pbmRleC50c3g=) | | | | [...es/Route/components/DebugViews/DebugParamsView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdQYXJhbXNWaWV3LnRzeA==) | | | | [web/src/pages/PluginTemplate/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [web/src/pages/PluginTemplate/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9DcmVhdGUudHN4) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2271: feat(upstream): add upstream priority field
codecov-commenter edited a comment on pull request #2271: URL: https://github.com/apache/apisix-dashboard/pull/2271#issuecomment-1002645837 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2271](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a9afa95) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/25ac15a128aba569d9e7ad98e96425ef8026fd38?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25ac15a) will **decrease** coverage by `18.82%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2271 +/- ## === - Coverage 68.07% 49.24% -18.83% === Files 127 41 -86 Lines3370 3168 -202 Branches 8290 -829 === - Hits 2294 1560 -734 - Misses 1076 1410 +334 - Partials0 198 +198 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.24% <100.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2271?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (ø)` | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `58.97% <ø> (ø)` | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `67.30% <100.00%> (ø)` | | | [web/src/components/PanelSection/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BhbmVsU2VjdGlvbi9pbmRleC50c3g=) | | | | [web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4) | | | | [web/src/pages/Service/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvU3RlcDEudHN4) | | | | [web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=) | | | | [web/src/pages/Upstream/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2271/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | |
[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2271: feat(upstream): add upstream priority field
zaunist commented on a change in pull request #2271:
URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776930378
##
File path: api/test/e2enew/upstream/upstream_priority_test.go
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package upstream
+
+import (
+ "encoding/json"
+ "net/http"
+
+ "github.com/onsi/ginkgo"
+ "github.com/onsi/gomega"
+
+ "github.com/apisix/manager-api/test/e2enew/base"
+)
+
+// just test for schema check
+var _ = ginkgo.Describe("Upstream priority", func() {
+ ginkgo.It("create upstream with priority", func() {
+ createUpstreamBody := make(map[string]interface{})
+ createUpstreamBody["nodes"] = []map[string]interface{}{
+ {
+ "host": base.UpstreamIp,
+ "port": 1980,
+ "weight": 1,
+ "priority": 10,
+ },
+ }
+ createUpstreamBody["type"] = "roundrobin"
+ createUpstreamBody["retries"] = 5
+ createUpstreamBody["retry_timeout"] = 5.5
+ _createUpstreamBody, err := json.Marshal(createUpstreamBody)
+ gomega.Expect(err).To(gomega.BeNil())
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/upstreams/priority",
+ Body: string(_createUpstreamBody),
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ })
+ })
+ ginkgo.It("delete upstream", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodDelete,
+ Path: "/apisix/admin/upstreams/priority",
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ })
+ })
Review comment:
Added test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #731: docs: Grafana Dashboard Configuration
gxthrj merged pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: docs: Grafana Dashboard Configuration (#731)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new ae69cd3 docs: Grafana Dashboard Configuration (#731)
ae69cd3 is described below
commit ae69cd3ee42245100b1c559df4518a418f66f6bd
Author: Sindweller
AuthorDate: Fri Dec 31 13:10:35 2021 +0800
docs: Grafana Dashboard Configuration (#731)
---
docs/assets/images/dashboard_view_1.png| Bin 0 -> 184051 bytes
docs/assets/images/dashboard_view_2.png| Bin 0 -> 513551 bytes
docs/assets/images/dashboard_view_3.png| Bin 0 -> 41542 bytes
docs/assets/images/datasource_1.png| Bin 0 -> 11759 bytes
docs/assets/images/datasource_2.png| Bin 0 -> 39480 bytes
docs/assets/images/grafana.png | Bin 0 -> 35260 bytes
docs/assets/images/img.png | Bin 0 -> 14548 bytes
docs/assets/images/import_via_panel_json.png | Bin 0 -> 33758 bytes
docs/assets/images/metrics_data.png| Bin 0 -> 266696 bytes
.../json/apisix-ingress-controller-grafana.json| 848 +
docs/en/latest/plugins/prometheus.md | 124 +++
11 files changed, 972 insertions(+)
diff --git a/docs/assets/images/dashboard_view_1.png
b/docs/assets/images/dashboard_view_1.png
new file mode 100644
index 000..030ab27
Binary files /dev/null and b/docs/assets/images/dashboard_view_1.png differ
diff --git a/docs/assets/images/dashboard_view_2.png
b/docs/assets/images/dashboard_view_2.png
new file mode 100644
index 000..96f9e46
Binary files /dev/null and b/docs/assets/images/dashboard_view_2.png differ
diff --git a/docs/assets/images/dashboard_view_3.png
b/docs/assets/images/dashboard_view_3.png
new file mode 100644
index 000..48a5ad3
Binary files /dev/null and b/docs/assets/images/dashboard_view_3.png differ
diff --git a/docs/assets/images/datasource_1.png
b/docs/assets/images/datasource_1.png
new file mode 100644
index 000..3bb7eb1
Binary files /dev/null and b/docs/assets/images/datasource_1.png differ
diff --git a/docs/assets/images/datasource_2.png
b/docs/assets/images/datasource_2.png
new file mode 100644
index 000..ef6958c
Binary files /dev/null and b/docs/assets/images/datasource_2.png differ
diff --git a/docs/assets/images/grafana.png b/docs/assets/images/grafana.png
new file mode 100644
index 000..f3ef338
Binary files /dev/null and b/docs/assets/images/grafana.png differ
diff --git a/docs/assets/images/img.png b/docs/assets/images/img.png
new file mode 100644
index 000..de412e9
Binary files /dev/null and b/docs/assets/images/img.png differ
diff --git a/docs/assets/images/import_via_panel_json.png
b/docs/assets/images/import_via_panel_json.png
new file mode 100644
index 000..16ff562
Binary files /dev/null and b/docs/assets/images/import_via_panel_json.png differ
diff --git a/docs/assets/images/metrics_data.png
b/docs/assets/images/metrics_data.png
new file mode 100644
index 000..65a3b98
Binary files /dev/null and b/docs/assets/images/metrics_data.png differ
diff --git a/docs/assets/other/json/apisix-ingress-controller-grafana.json
b/docs/assets/other/json/apisix-ingress-controller-grafana.json
new file mode 100644
index 000..77c27d2
--- /dev/null
+++ b/docs/assets/other/json/apisix-ingress-controller-grafana.json
@@ -0,0 +1,848 @@
+{
+ "annotations": {
+"list": [
+ {
+"builtIn": 1,
+"datasource": "Prometheus",
+"enable": true,
+"hide": true,
+"iconColor": "rgba(0, 211, 255, 1)",
+"limit": 100,
+"name": "Annotations & Alerts",
+"showIn": 0,
+"type": "dashboard"
+ }
+]
+ },
+ "description": "Ingress Controller of Apache APISIX",
+ "editable": true,
+ "gnetId": 11719,
+ "graphTooltip": 0,
+ "id": 9,
+ "iteration": 1632975622801,
+ "links": [],
+ "panels": [
+{
+ "collapsed": false,
+ "datasource": "Prometheus",
+ "gridPos": {
+"h": 1,
+"w": 24,
+"x": 0,
+"y": 0
+ },
+ "id": 10,
+ "panels": [],
+ "title": "APISIX Ingress controller",
+ "type": "row"
+},
+{
+ "datasource": null,
+ "description": "Whether the role of controller instance is leader",
+ "fieldConfig": {
+"defaults": {
+ "color": {
+"mode": "thresholds"
+ },
+ "mappings": [
+{
+ "from": "",
+ "id": 1,
+ "text": "Candidate",
+ "to": "",
+ "type": 1,
+ "value": "0"
+},
+{
+ "from": "",
+ "id": 2,
+ "text": "Leader",
+ "to": "",
+ "type": 1,
+ "value": "1"
+}
+ ],
+
[GitHub] [apisix] leslie-tsang commented on issue #5976: request help: remove unused utils script
leslie-tsang commented on issue #5976: URL: https://github.com/apache/apisix/issues/5976#issuecomment-1003269514 cc @membphis @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance
tao12345666333 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003267993 > Okay, why not make an appointment next week, so I can summarize it briefly. Sure. Due to the holiday, how about we make an appointment next Tuesday 14:00? Or other time you have free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003265875 > > I want to know if you would consider combining apisix-ingress-controller with this way: [apache/apisix#4880](https://github.com/apache/apisix/pull/4880) > > It has not been put into the current roadmap. > > Can we make an online meeting? I want to know the specific problems you are currently encountering and your thoughts. Okay, why not make an appointment next week, so I can summarize it briefly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration
tao12345666333 commented on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-1003265292 @Sindweller LGTM. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj edited a comment on issue #822: bug: CRD and Endpoint watch performance
gxthrj edited a comment on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003263080 > > > > Thanks for your report. > > > > > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0 > > > > > > > > > > > > What's your apisix-ingress-controller version? The latest version is v1.4 (not release) > > > > The problem you encountered is somewhat similar to #806 and #760 > > > > > > > > > It's v1.4，I incorrectly provided the version of apisix > > > > > > How did you install ingress-controller? using helm？ > > Yes, I make my own helm chart, because at that time the official only supported 1.3.0 at the highest Please help confirm whether your own `ingress-controller` image contains bugfix #760. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #822: bug: CRD and Endpoint watch performance
gxthrj commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003263080 > > > > Thanks for your report. > > > > > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0 > > > > > > > > > > > > What's your apisix-ingress-controller version? The latest version is v1.4 (not release) > > > > The problem you encountered is somewhat similar to #806 and #760 > > > > > > > > > It's v1.4，I incorrectly provided the version of apisix > > > > > > How did you install ingress-controller? using helm？ > > Yes, I make my own helm chart, because at that time the official only supported 1.3.0 at the highest Please help confirm whether your own `ingress-controller· image contains bugfix #760. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance
tao12345666333 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003262634 > I want to know if you would consider combining apisix-ingress-controller with this way: [apache/apisix#4880](https://github.com/apache/apisix/pull/4880) It has not been put into the current roadmap. Can we make an online meeting? I want to know the specific problems you are currently encountering and your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003262434 > > > Thanks for your report. > > > > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0 > > > > > > > > > What's your apisix-ingress-controller version? The latest version is v1.4 (not release) > > > The problem you encountered is somewhat similar to #806 and #760 > > > > > > It's v1.4，I incorrectly provided the version of apisix > > How did you install ingress-controller? using helm？ Yes, I make my own helm chart, because at that time the official only supported 1.3.0 at the highest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003261711 I want to know if you would consider combining apisix-ingress-controller with this way: https://github.com/apache/apisix/pull/4880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #822: bug: CRD and Endpoint watch performance
gxthrj commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003261701 > > Thanks for your report. > > > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0 > > > > > > What's your apisix-ingress-controller version? The latest version is v1.4 (not release) > > The problem you encountered is somewhat similar to #806 and #760 > > It's v1.4，I incorrectly provided the version of apisix How did you install ingress-controller? using helm？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003260796 > Thanks for your report. > > > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0 > > What's your apisix-ingress-controller version? The latest version is v1.4 (not release) > > The problem you encountered is somewhat similar to #806 and #760 It's v1.4，I incorrectly provided the version of apisix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #822: bug: CRD and Endpoint watch performance
gxthrj commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003260571 Yes, before #706 we indeed have this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance
tao12345666333 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003260112 before #706 , we using `workqueue.AddRateLimited`, this will cause some problems. >This bug is due to a workqueue shared under the same resource, and a ratelimit mechanism is added to this workqueue, but we only need to add the ratelimit when retrying fails, and when normal resource changes, we should immediately add the workqueue to be processed . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #822: bug: CRD and Endpoint watch performance
tao12345666333 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003259597 Thanks for your report. > * your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0 What's your apisix-ingress-controller version? The latest version is v1.4 (not release) The problem you encountered is somewhat similar to #806 and https://github.com/apache/apisix-ingress-controller/pull/760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] crazyMonkey1995 commented on issue #822: bug: CRD and Endpoint watch performance
crazyMonkey1995 commented on issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822#issuecomment-1003259464 Maybe I’ve said too much, I just think it’s better if the service discovery is done by apisix itself -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] crazyMonkey1995 opened a new issue #822: bug: CRD and Endpoint watch performance
crazyMonkey1995 opened a new issue #822: URL: https://github.com/apache/apisix-ingress-controller/issues/822 ### Issue description After I create 3000+ apisixroute objects in the cluster, when the apisix-ingress-controller is started or restarting(OOM Maybe), due to the rate limit of client-go, the resource synchronization time is very long, so the changes of endpoints within this time will not be affected synchronize in time, causing 502 problems  Similar to the above question, it seems that the changes of endpoints cannot be synchronized to apisix in a very timely manner. I guess it is because the link of this control loop is too long, watchEndpoints -> translate -> apisix-admin-api -> etcd To sum up, this kind of performance definitely cannot be put into production. I think it is better for apisix to do service discovery by itself? https://github.com/apache/apisix/pull/4880 ### Environment - your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 2.11.0 - your Kubernetes cluster version (output of kubectl version): .1.18.8 - if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a): ### Minimal test code / Steps to reproduce - ### Actual result - ### Error log - ### Expected result Endpoints can be watched in time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan closed issue #5814: bug: java plugin error permission denied
juzhiyuan closed issue #5814: URL: https://github.com/apache/apisix/issues/5814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration
tao12345666333 commented on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-1003258223 @Sindweller Thanks! It looks great to me! Please fix the markdown lint error. Then we can merge this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on issue #5814: bug: java plugin error permission denied
leslie-tsang commented on issue #5814: URL: https://github.com/apache/apisix/issues/5814#issuecomment-1003258203 > @juzhiyuan Consider solved. Feel free to reopen it if need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #731: feat: Grafana Dashboard Configuration
tao12345666333 commented on a change in pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918990 ## File path: docs/en/latest/plugins/prometheus.md ## @@ -0,0 +1,124 @@ +--- +title: prometheus +--- + + + +This guide shows how to monitor Apache APISIX Ingress Controller using Prometheus and Grafana. + +## Enable Prometheus + +You can find example CRD files in `apisix-ingress-controller/samples/deploy/crd/v1`. +The CRD file `ApisixClusterConfig` is required to use to enable prometheus in global configurations. +In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe Prometheus settings. +```yaml Review comment: looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Sindweller commented on a change in pull request #731: feat: Grafana Dashboard Configuration
Sindweller commented on a change in pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918809 ## File path: docs/en/latest/plugins/prometheus.md ## @@ -0,0 +1,124 @@ +--- +title: prometheus +--- + + + +This guide shows how to monitor Apache APISIX Ingress Controller using Prometheus and Grafana. + +## Enable Prometheus + +You can find example CRD files in `apisix-ingress-controller/samples/deploy/crd/v1`. +The CRD file `ApisixClusterConfig` is required to use to enable prometheus in global configurations. +In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe Prometheus settings. +```yaml Review comment: please see if I understand the usage of crd file. (in current commit) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Sindweller commented on a change in pull request #731: feat: Grafana Dashboard Configuration
Sindweller commented on a change in pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r776918809 ## File path: docs/en/latest/plugins/prometheus.md ## @@ -0,0 +1,124 @@ +--- +title: prometheus +--- + + + +This guide shows how to monitor Apache APISIX Ingress Controller using Prometheus and Grafana. + +## Enable Prometheus + +You can find example CRD files in `apisix-ingress-controller/samples/deploy/crd/v1`. +The CRD file `ApisixClusterConfig` is required to use to enable prometheus in global configurations. +In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe Prometheus settings. +```yaml Review comment: please see if I understand the usage of crd file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #821: Bugfix: fetching newest Endpoint before sync
codecov-commenter commented on pull request #821: URL: https://github.com/apache/apisix-ingress-controller/pull/821#issuecomment-1003257320 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/821?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#821](https://codecov.io/gh/apache/apisix-ingress-controller/pull/821?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a78ed04) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/990971d4e892b47a6758edb40042c3decde92846?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (990971d) will **decrease** coverage by `0.02%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/821?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #821 +/- ## == - Coverage 32.14% 32.11% -0.03% == Files 71 70 -1 Lines7727 7731 +4 == - Hits 2484 2483 -1 - Misses 4968 4973 +5 Partials 275 275 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/821?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/821/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnQuZ28=) | `0.00% <0.00%> (ø)` | | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/821/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/821?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/821?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [990971d...a78ed04](https://codecov.io/gh/apache/apisix-ingress-controller/pull/821?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] chzhuo opened a new pull request #821: Bugfix: fetching newest Endpoint before sync
chzhuo opened a new pull request #821: URL: https://github.com/apache/apisix-ingress-controller/pull/821 ### Type of change: - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches ### What this PR does / why we need it: Related issue: #806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #1652: add support for Vault
spacewander commented on issue #1652: URL: https://github.com/apache/apisix/issues/1652#issuecomment-1003254134 Solved by https://github.com/apache/apisix/pull/5745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #1652: add support for Vault
spacewander closed issue #1652: URL: https://github.com/apache/apisix/issues/1652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5714: Proposal: support OpenPolicyAgent for access control
spacewander commented on issue #5714: URL: https://github.com/apache/apisix/issues/5714#issuecomment-1003253957 Already done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5714: Proposal: support OpenPolicyAgent for access control
spacewander closed issue #5714: URL: https://github.com/apache/apisix/issues/5714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #4301: bug: skywalking not work when upsteam timeout
spacewander closed issue #4301: URL: https://github.com/apache/apisix/issues/4301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gxthrj commented on pull request #4880: feat: add k8s discovery module
gxthrj commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1003252010 > After our test, apisix-ingress-controller has many problems, so I plan to give up apisix-ingress-controller. I am looking forward to this feature very much, I wonder if you can push it forward? Welcome to report issues in [apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/issues) to help each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5971: fix: upgrade skywalking to `0.6.0`
spacewander merged pull request #5971: URL: https://github.com/apache/apisix/pull/5971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix: upgrade skywalking to `0.6.0` (#5971)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new cc09ef3 fix: upgrade skywalking to `0.6.0` (#5971)
cc09ef3 is described below
commit cc09ef3b69089be62718455d9f919879bf28318b
Author: YuanSheng Wang
AuthorDate: Fri Dec 31 11:13:13 2021 +0800
fix: upgrade skywalking to `0.6.0` (#5971)
---
rockspec/apisix-master-0.rockspec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rockspec/apisix-master-0.rockspec
b/rockspec/apisix-master-0.rockspec
index d2186df..883cd42 100644
--- a/rockspec/apisix-master-0.rockspec
+++ b/rockspec/apisix-master-0.rockspec
@@ -55,7 +55,7 @@ dependencies = {
"lua-resty-ipmatcher = 0.6.1",
"lua-resty-kafka = 0.07",
"lua-resty-logger-socket = 2.0-0",
-"skywalking-nginx-lua = 0.5.0",
+"skywalking-nginx-lua = 0.6.0",
"base64 = 1.5-2",
"binaryheap = 0.4",
"dkjson = 2.5-2",
[GitHub] [apisix] spacewander commented on issue #5976: request help: remove unused utils script
spacewander commented on issue #5976: URL: https://github.com/apache/apisix/issues/5976#issuecomment-1003251398 Good. Can we cc the authors of these scripts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5969: Hope to add support for setting the custom host header to be used for upstream's artive checks!
spacewander commented on issue #5969: URL: https://github.com/apache/apisix/issues/5969#issuecomment-1003251120 Fixed in https://github.com/apache/apisix/pull/5175? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tao12345666333 commented on pull request #4880: feat: add k8s discovery module
tao12345666333 commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1003251040 @crazyMonkey1995 If you have any questions or suggestions about this project, welcome to participate in our community bi-weekly meeting. Thanks https://github.com/apache/apisix-ingress-controller/issues/614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5973: ssl是否支持双向认证？
tzssangglass commented on issue #5973: URL: https://github.com/apache/apisix/issues/5973#issuecomment-1003250734 yes, and you need to use apisix-base. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5969: Hope to add support for setting the custom host header to be used for upstream's artive checks!
tzssangglass commented on issue #5969: URL: https://github.com/apache/apisix/issues/5969#issuecomment-1003250434 > > @sandy420 You can hint that the health check endpoint only accepts domain access, not ip access. > > how do it ? @tzssangglass What I mean is that you could have indicated in the issue that your upstream service only accepts domain name access, thus raising the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #4880: feat: add k8s discovery module
moonming commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1003250242 > any update for this PR? can we merge this PR first? @membphis please push this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang opened a new issue #5976: request help: remove unused utils script
leslie-tsang opened a new issue #5976: URL: https://github.com/apache/apisix/issues/5976 ### Issue description Currently, some utility scripts no longer fit the master branch and we should remove them to make sure no one gets confused. ## Solution > unused utils script * [utils/check-version.sh](https://github.com/apache/apisix/blob/master/utils/check-version.sh) - no longer been used. * [utils/gen-install-folder.sh](https://github.com/apache/apisix/blob/master/utils/gen-install-folder.sh) - no longer been used, don't work as expect as well. * [utils/install_yaml_conf.sh](https://github.com/apache/apisix/blob/master/utils/install_yaml_conf.sh) - no longer been used, [Makefile](https://github.com/apache/apisix/blob/master/Makefile) don't refer to it any more. ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tao12345666333 commented on pull request #4880: feat: add k8s discovery module
tao12345666333 commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1003250011 > apisix-ingress-controller has many problems @crazyMonkey1995 Have you submitted an issue to the apisix-ingress-controller project? What problem did you encounter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Baoyuantop commented on a change in pull request #5727: feat: add CSRF plugin
Baoyuantop commented on a change in pull request #5727:
URL: https://github.com/apache/apisix/pull/5727#discussion_r776914120
##
File path: apisix/plugins/csrf.lua
##
@@ -0,0 +1,168 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local resty_sha256 = require("resty.sha256")
+local ck = require("resty.cookie")
+local ngx = ngx
+local plugin_name = "csrf"
+local ngx_encode_base64 = ngx.encode_base64
+local ngx_decode_base64 = ngx.decode_base64
+local timer = ngx.time
+local cookie_time = ngx.cookie_time
+local math = math
+
+local schema = {
+type = "object",
+properties = {
+ key = {
+description = "use to generate csrf token",
+type = "string",
+ },
+ expires = {
+description = "expires time for csrf token",
+type = "integer",
+default = 7200
+ },
+ name = {
+description = "the csrf token name",
+type = "string",
+default = "apisix_csrf_token"
+ }
+},
+required = {"key"}
+}
+
+local _M = {
+version = 0.1,
+priority = 3500,
+name = plugin_name,
+schema = schema,
+}
+
+function _M.check_schema(conf)
+return core.schema.check(schema, conf)
+end
+
+
+local function gen_sign(random, expires, key)
+local sha256 = resty_sha256:new()
+
+local sign = {
+ random = random,
+ expires = expires,
+ key = key,
+}
+
+sha256:update(core.json.encode(sign))
+local digest = sha256:final()
+
+return ngx_encode_base64(digest)
+end
+
+
+local function gen_csrf_token(conf)
+local random = math.random();
+local sign = gen_sign(random, conf.expires, conf.key)
+
+local token = {
+ random = random,
+ expires = conf.expires,
+ sign = sign,
+}
+
+local cookie = ngx_encode_base64(core.json.encode(token))
+return cookie
+end
+
+
+local function check_csrf_token(conf, ctx, token)
+local _token = ngx_decode_base64(token)
+local _token_table, err = core.json.decode(_token)
+if err then
+ core.log.error("decode token error: ", err)
+ return false
+end
+
+local random = _token_table["random"]
+if not random then
+ core.log.warn("no random in token")
+ return false
+end
+
+local expires = _token_table["expires"]
+if not expires then
+ core.log.warn("no expires in token")
+ return false
+end
+
+local sign = gen_sign(random, expires, conf.key)
+if _token_table["sign"] ~= sign then
+ return false
+end
+
+return true
+end
+
+
+function _M.access(conf, ctx)
+local method = ctx.var.request_method
+if method == 'GET' then
+ return
+end
+
+local token = core.request.header(ctx, conf.name)
+if not token then
+ return 401, {error_msg = "no csrf token in request header"}
+end
+
+local cookie, err = ck:new()
+if not cookie then
+ return nil, err
+end
+
+local field_cookie, err = cookie:get(conf.name)
+if not field_cookie then
+ return 401, {error_msg = "no csrf cookie"}
+end
+
+if err then
+ core.log.error(err)
+ return 400, {error_msg = "read csrf cookie failed"}
+end
+
+if token ~= field_cookie then
+ return 401, {error_msg = "csrf token mismatch"}
+end
+
+local result = check_csrf_token(conf, ctx, token)
+if not result then
+ return 401, {error_msg = "Failed to verify the csrf token signature"}
+end
+end
+
+
+function _M.header_filter(conf, ctx)
+local method = ctx.var.request_method
+if method == 'GET' then
Review comment:
OPTIONS has been added to take into account cross-domain requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #4880: feat: add k8s discovery module
membphis commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1003248676 > After our test, apisix-ingress-controller has many problems, so I plan to give up apisix-ingress-controller. I am looking forward to this feature very much, I wonder if you can push it forward? @tao12345666333 @crazyMonkey1995 You can talk about specific issues together, online meeting is better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] shuaijinchao commented on issue #37: How can i get request body from this plugin ?
shuaijinchao commented on issue #37: URL: https://github.com/apache/apisix-python-plugin-runner/issues/37#issuecomment-1003248668 > do we have any plan about this feature? Yes, we will support it in subsequent versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] shuaijinchao commented on issue #37: How can i get request body from this plugin ?
shuaijinchao commented on issue #37: URL: https://github.com/apache/apisix-python-plugin-runner/issues/37#issuecomment-1003248563 > And I have one more question. Following the example of the stop plugin, I called self.stop() and rewrote Response.body. Why is nothing displayed in the browser? But can see it with Curl You need to rewrite Contet-Type. In addition, self.stop() will be obsolete in subsequent versions. We need to align the logic with Go and Java. You can check the examples in the documentation in the master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2271: feat(upstream): add upstream priority field
zaunist commented on a change in pull request #2271:
URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776911080
##
File path: api/test/e2enew/upstream/upstream_priority_test.go
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package upstream
+
+import (
+ "encoding/json"
+ "net/http"
+
+ "github.com/onsi/ginkgo"
+ "github.com/onsi/gomega"
+
+ "github.com/apisix/manager-api/test/e2enew/base"
+)
+
+// just test for schema check
+var _ = ginkgo.Describe("Upstream priority", func() {
+ ginkgo.It("create upstream with priority", func() {
+ createUpstreamBody := make(map[string]interface{})
+ createUpstreamBody["nodes"] = []map[string]interface{}{
+ {
+ "host": base.UpstreamIp,
+ "port": 1980,
+ "weight": 1,
+ "priority": 10,
+ },
+ }
+ createUpstreamBody["type"] = "roundrobin"
+ createUpstreamBody["retries"] = 5
+ createUpstreamBody["retry_timeout"] = 5.5
+ _createUpstreamBody, err := json.Marshal(createUpstreamBody)
+ gomega.Expect(err).To(gomega.BeNil())
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/upstreams/priority",
+ Body: string(_createUpstreamBody),
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ })
+ })
+ ginkgo.It("delete upstream", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodDelete,
+ Path: "/apisix/admin/upstreams/priority",
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ })
+ })
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] sandy420 commented on issue #5969: Hope to add support for setting the custom host header to be used for upstream's artive checks!
sandy420 commented on issue #5969: URL: https://github.com/apache/apisix/issues/5969#issuecomment-1003243580 > @sandy420 You can hint that the health check endpoint only accepts domain access, not ip access. how do it ? @tzssangglass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on issue #5855: bug: unambiguous fully-qualified domain name(FQDN), i.e. ended in a dot.
leslie-tsang commented on issue #5855: URL: https://github.com/apache/apisix/issues/5855#issuecomment-1003243278 Hello there, @dickens7 Would you submit a PR to fix it ? Here is an [example](https://github.com/apache/apisix/pull/5971) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
