[GitHub] [apisix] mscb402 commented on issue #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox


mscb402 commented on issue #8710:
URL: https://github.com/apache/apisix/issues/8710#issuecomment-1396483717

   You can close this issue now :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] githubxubin closed issue #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox


githubxubin closed issue #8710: 前后端跨域问题 CORS policy 
URL: https://github.com/apache/apisix/issues/8710


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] githubxubin commented on issue #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox


githubxubin commented on issue #8710:
URL: https://github.com/apache/apisix/issues/8710#issuecomment-1396470001

   > If still have a problem, you can set `Access-Control-Allow-Origin: 
http://domain.com`. Change domain.com to your domain
   
   okey ~  thanks it is ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] mscb402 commented on issue #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox


mscb402 commented on issue #8710:
URL: https://github.com/apache/apisix/issues/8710#issuecomment-1396469247

   If still have a problem, you can set `Access-Control-Allow-Origin: 
http://domain.com`. Change  domain.com to your domain


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] mscb402 commented on issue #8709: help request: Setting up routing path

2023-01-18 Thread GitBox


mscb402 commented on issue #8709:
URL: https://github.com/apache/apisix/issues/8709#issuecomment-1396406154

   This is a example of how to config `regex_uri` in proxy_rewrite `regex_uri 
:["^/food/(.*)$",  "/$1"]`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] mscb402 commented on issue #8709: help request: Setting up routing path

2023-01-18 Thread GitBox


mscb402 commented on issue #8709:
URL: https://github.com/apache/apisix/issues/8709#issuecomment-1396404919

   If you want to access `/food/v1/dashes` and return contents by path 
`/v1/dashes`. You need to add a proxy-rewrite plugin. 
https://apisix.apache.org/docs/apisix/plugins/proxy-rewrite/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] mscb402 commented on issue #8709: help request: Setting up routing path

2023-01-18 Thread GitBox


mscb402 commented on issue #8709:
URL: https://github.com/apache/apisix/issues/8709#issuecomment-1396403642

   Does this `Whitelabel Error Page` is your upstream response? If so, that 
means your config is not right. If your upstream is "example.com" if you set 
`/*` and access `/v1/dashes` APISIX will be translated to 
`example.com/v1/dashes` which returns right. But when you set the path to 
`/food/*` and access `/food/v1/dashes` APISIX will be translated to 
`example.com/food/v1/dashes`. Obviously, this path does not exist.
   So there is why your upstream server returned 404.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] juzhiyuan merged pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-18 Thread GitBox


juzhiyuan merged PR #1468:
URL: https://github.com/apache/apisix-website/pull/1468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on a diff in pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-18 Thread GitBox


juzhiyuan commented on code in PR #1468:
URL: https://github.com/apache/apisix-website/pull/1468#discussion_r1080776370


##
blog/en/blog/2023/01/02/accessing_apisix-dashboard_from_everywhere_with_keycloak_authentication.md:
##
@@ -0,0 +1,1152 @@
+---
+title: "Accessing APISIX-Dashboard from Everywhere with Keycloak 
Authentication"
+authors:
+  - name: "Busico Mirto Silvio"
+title: ""
+url: "https://github.com/MirtoBusico;
+image_url: 
"https://avatars.githubusercontent.com/u/11090934?s=400=644e4f87c2fad56760f6eb4f46cbcb4db059880a=4;
+keywords:
+  - Alternatives to NGINX
+  - Access and Authentication
+  - Nginx reverse proxy
+  - OpenID-Connect
+  - Keycloak
+description: This guest blog shares how to expose the APISIX Dashboard using 
APISIX to authenticate access with the OpenID-Connect plugin and Keycloak 
server to manage identities.
+tags:
+  - APISIX Basics
+  - API Gateway Concepts
+  - Authorization & Authentication
+cover: https://github.com/MirtoBusico/assets-for-blogs/blob/main/blog01a.png

Review Comment:
   ```suggestion
   cover: https://static.apiseven.com/uploads/2023/01/19/FKDU7U6j_blog01a.png
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] mscb402 opened a new pull request, #8711: feat: file logger plugin support response body in variable

2023-01-18 Thread GitBox


mscb402 opened a new pull request, #8711:
URL: https://github.com/apache/apisix/pull/8711

   ### Description
   
   We need to add a new var resp_body to let the user put it in a log format 
which let the user use the response in the way there want.
   
   Fixes #8705
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] mscb402 commented on issue #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox


mscb402 commented on issue #8710:
URL: https://github.com/apache/apisix/issues/8710#issuecomment-1396397833

   Maybe you can set allow credentials to true.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-18 Thread GitBox


juzhiyuan commented on PR #1468:
URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1396397685

   Thanks to @MirtoBusico and @Yilialinn!
   
   > Hi @juzhiyuan, I've done my review. Hope you can change the status from 
draft to approve if you have no questions
   
   I just changed the status from Draft to Ready for Review :) Usually once the 
author thinks it's ready, they can change it directly  
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] KID-G opened a new pull request, #1480: docs:add what is service mesh blog

2023-01-18 Thread GitBox


KID-G opened a new pull request, #1480:
URL: https://github.com/apache/apisix-website/pull/1480

   Changes:
   
   Add what is service mesh blog
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] netlify[bot] commented on pull request #1480: docs:add what is service mesh blog

2023-01-18 Thread GitBox


netlify[bot] commented on PR #1480:
URL: https://github.com/apache/apisix-website/pull/1480#issuecomment-1396395376

   ###  Deploy Preview for *apache-apisix* 
processing.
   
   
   |  Name | Link |
   |-||
   | Latest commit | 
ed2218f3a79e337a8da87f855b91641b833fbcaa |
   | Latest deploy log | 
https://app.netlify.com/sites/apache-apisix/deploys/63c8b99e0e57f85edec7 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] githubxubin opened a new issue, #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox


githubxubin opened a new issue, #8710:
URL: https://github.com/apache/apisix/issues/8710

   ### Description
   
   1.新建路由 开启cors 插件
   `{
 "uri": "/cor/*",
 "name": "test",
 "desc": "test",
 "methods": [
   "GET",
   "POST",
   "PUT",
   "DELETE",
   "PATCH",
   "HEAD",
   "OPTIONS",
   "CONNECT",
   "TRACE"
 ],
 "plugins": {
   "cors": {
 "allow_credential": false,
 "allow_headers": "*",
 "allow_methods": "*",
 "allow_origins": "*",
 "disable": false,
 "expose_headers": "*",
 "max_age": 5
   },
   "proxy-rewrite": {
 "regex_uri": [
   "^/cor(/|$)(.*)",
   "/$2"
 ]
   }
 },
 "upstream": {
   "nodes": [
 {
   "host": "192.168.85.66",
   "port": 8001,
   "weight": 1
 }
   ],
   "timeout": {
 "connect": 6,
 "send": 6,
 "read": 6
   },
   "type": "roundrobin",
   "scheme": "http",
   "pass_host": "pass",
   "keepalive_pool": {
 "idle_timeout": 60,
 "requests": 1000,
 "size": 320
   }
 },
 "labels": {
   "API_VERSION": "v1.0"
 },
 "status": 1
   }`
   
   
   2.前后端分离项目,直接调用路由地址,google 浏览器 报跨域错误
   
![image](https://user-images.githubusercontent.com/39228009/213348858-40190bff-719f-4b95-a294-fe7393e95e3a.png)
   
   
   ### Environment
   
   - APISIX version (run `apisix version`):
   - Operating system (run `uname -a`):
   - OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
   - etcd version, if relevant (run `curl 
http://127.0.0.1:9090/v1/server_info`):
   - APISIX Dashboard version, if relevant:
   - Plugin runner version, for issues related to plugin runners:
   - LuaRocks version, for installation issues (run `luarocks --version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] Fabriceli commented on a diff in pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox


Fabriceli commented on code in PR #1478:
URL: https://github.com/apache/apisix-website/pull/1478#discussion_r1080763913


##
blog/zh/blog/2023/01/18/consul-with-apisix.md:
##
@@ -0,0 +1,271 @@
+---
+title: "Apache APISIX 集成原生 Consul 服务发现能力"
+authors:
+  - name: "李奕浩"
+title: "Author"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+  - name: "李奕浩"
+title: "Technical Writer"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+keywords:
+- API Gateway
+- Consul
+- 服务发现
+- 服务注册
+description: 云原生 API 网关 Apache APISIX 支持基于 Consul 的服务发现。本文讲述了在 Apache APISIX 
中实现服务发现和服务注册的全过程及 consul 的相关原理。

Review Comment:
   done



##
blog/zh/blog/2023/01/18/consul-with-apisix.md:
##
@@ -0,0 +1,271 @@
+---
+title: "Apache APISIX 集成原生 Consul 服务发现能力"
+authors:
+  - name: "李奕浩"
+title: "Author"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+  - name: "李奕浩"
+title: "Technical Writer"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;

Review Comment:
   done



##
blog/en/blog/2023/01/18/consul-with-apisix.md:
##
@@ -0,0 +1,278 @@
+---
+title: "How to Integrate API Gateway and Consul? Not Consul K/V"
+authors:
+  - name: "Yihao LI"
+title: "Author"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+  - name: "Yihao LI"
+title: "Technical Writer"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] Fabriceli commented on a diff in pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox


Fabriceli commented on code in PR #1478:
URL: https://github.com/apache/apisix-website/pull/1478#discussion_r1080763797


##
blog/zh/blog/2023/01/18/consul-with-apisix.md:
##
@@ -0,0 +1,271 @@
+---
+title: "Apache APISIX 集成原生 Consul 服务发现能力"
+authors:
+  - name: "李奕浩"
+title: "Author"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+  - name: "李奕浩"
+title: "Technical Writer"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+keywords:
+- API Gateway
+- Consul
+- 服务发现
+- 服务注册
+description: 云原生 API 网关 Apache APISIX 支持基于 Consul 的服务发现。本文讲述了在 Apache APISIX 
中实现服务发现和服务注册的全过程及 consul 的相关原理。
+tags: [Ecosystem]
+image: 
https://static.apiseven.com/2022/blog/0818/ecosystem/HashiCorp%20Consul.png
+---
+
+## 背景
+
+### 关于 Apache APISIX
+
+Apache APISIX 是 Apache 软件基金会下的云原生 API 
网关,它兼具动态、实时、高性能等特点,提供了负载均衡、动态上游、灰度发布(金丝雀发布)、服务熔断、身份认证、可观测性等丰富的流量管理功能。我们可以使用 
Apache APISIX 来处理传统的南北向流量,也可以处理服务间的东西向流量。
+
+### 关于 Consul
+
+Consul 是 HashiCorp 公司推出的开源工具,用于实现分布式系统的服务发现与配置,提供了服务注册与发现、健康检查、Key/Value 
存储、多数据中心的能力。
+
+## 准备阶段
+
+本文中的测试环境使用 docker-compose 搭建
+
+1. 下载 Apache APISIX
+
+   ```sh
+   git clone https://github.com/apache/apisix-docker.git
+   ```
+
+2. 创建并运行 Consul
+
+   ```sh
+   docker run --rm --name consul_1 -d -p 8500:8500 consul:1.8 consul agent 
-server -bootstrap-expect=1 -node=agent-one -client 0.0.0.0 -log-level info 
-data-dir=/consul/data -enable-script-checks
+   ```
+
+3. 更新 Apache APISIX 中的配置文件`apisix_conf/config.yaml`
+
+   ```yaml
+   # config.yml
+   # ... other config
+   discovery:
+ consul:
+   servers:
+ - "http://127.0.0.1:8500;
+   ```
+
+4. 启动 Apache APISIX
+
+   ```sh
+   # 进 example 文件夹,启动 APISIX
+   docker-compose -f docker-compose.yml -p apisix-docker  up -d
+   ```
+
+5. 测试服务已经包含了两个 Web 服务,确认 Web 服务的 IP 地址
+
+   ```sh
+   $ sudo docker inspect -f='{{.Name}} - {{range 
.NetworkSettings.Networks}}{{.IPAddress}}{{end}}' $(sudo docker ps -aq) | grep 
web
+   # 输出
+   /apisix-docker-web1-1 - 172.21.0.5
+   /apisix-docker-web2-1 - 172.21.0.6
+   ```
+
+6. 请求 Consul HTTP API 将 Web 服务注册到 Consul
+
+   ```sh
+   # 使用 Web 对应的 IP 和 port 进行注册
+   $ curl --location --request PUT 
'http://127.0.0.1:8500/v1/agent/service/register' \
+   --header 'Content-Type: application/json' \
+   --data '{
+  "ID": "service_a1",
+  "Name": "service_a",
+  "Tags": ["primary", "v1"],
+  "Address": "172.21.0.5",
+  "Port": 9081,
+  "Weights": {
+ "Passing": 10,
+ "Warning": 1
+  }
+   }'
+
+   $ curl --location --request PUT 
'http://127.0.0.1:8500/v1/agent/service/register' \
+   --header 'Content-Type: application/json' \
+   --data '{
+  "ID": "service_a2",
+  "Name": "service_a",
+  "Tags": ["primary", "v1"],
+  "Address": "172.21.0.6",
+  "Port": 9082,
+  "Weights": {
+ "Passing": 10,
+ "Warning": 1
+  }
+   }'
+   ```
+
+7. 查看测试服务是否注册成功
+
+   ```sh
+   $ curl --location --request GET 
'http://127.0.0.1:8500/v1/catalog/service/service_a'
+   ```
+
+   其中,`/v1/catalog/service/`后的路径是服务名称,即服务注册时候的`name`。
+   返回消息体如下则表示成功注册。
+
+  ```json
+   [{
+  "ID": "7a36c6f1-f701-9c67-8db8-7b8551d36b4a",
+  "Node": "agent-one",
+  "Address": "172.23.0.2",
+  "Datacenter": "dc1",
+  "TaggedAddresses": {
+ "lan": "172.23.0.2",
+ "lan_ipv4": "172.23.0.2",
+ "wan": "172.23.0.2",
+ "wan_ipv4": "172.23.0.2"
+  },
+  "NodeMeta": {
+ "consul-network-segment": ""
+  },
+  "ServiceKind": "",
+  "ServiceID": "service_a1",
+  "ServiceName": "service_a",
+  "ServiceTags": ["primary", "v1"],
+  "ServiceAddress": "172.20.10.2",
+  "ServiceTaggedAddresses": {
+ "lan_ipv4": {
+"Address": "172.20.10.2",
+"Port": 9082
+ },
+ "wan_ipv4": {
+"Address": "172.20.10.2",
+"Port": 9082
+ }
+  },
+  "ServiceWeights": {
+ "Passing": 10,
+ "Warning": 1
+  },
+  "ServiceMeta": {},
+  "ServicePort": 9082,
+  "ServiceEnableTagOverride": false,
+  "ServiceProxy": {
+ "MeshGateway": {},
+ "Expose": {}
+  },
+  "ServiceConnect": {},
+  "CreateIndex": 46,
+  "ModifyIndex": 124
+   }, {
+  "ID": "7a36c6f1-f701-9c67-8db8-7b8551d36b4a",
+  "Node": "agent-one",
+  "Address": "172.23.0.2",
+  "Datacenter": "dc1",
+  "TaggedAddresses": {
+ "lan": "172.23.0.2",
+ "lan_ipv4": "172.23.0.2",
+ "wan": "172.23.0.2",
+ "wan_ipv4": "172.23.0.2"
+  },
+  "NodeMeta": {
+ "consul-network-segment": ""
+  },
+  "ServiceKind": "",
+  "ServiceID": "service_a2",
+  "ServiceName": "service_a",
+  "ServiceTags": ["primary", "v1"],
+  "ServiceAddress": "172.20.10.2",
+  "ServiceTaggedAddresses": {
+ "lan_ipv4": {
+"Address": 

[GitHub] [apisix-website] netlify[bot] commented on pull request #1479: docs:add weekly report 20230115

2023-01-18 Thread GitBox


netlify[bot] commented on PR #1479:
URL: https://github.com/apache/apisix-website/pull/1479#issuecomment-1396377833

   ###  Deploy Preview for *apache-apisix* 
processing.
   
   
   |  Name | Link |
   |-||
   | Latest commit | 
3db1a60e76b0c78d6d641026a87e77736ea53f5d |
   | Latest deploy log | 
https://app.netlify.com/sites/apache-apisix/deploys/63c8b1dcf961dc0008295d2e |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] KID-G opened a new pull request, #1479: docs:add weekly report 20230115

2023-01-18 Thread GitBox


KID-G opened a new pull request, #1479:
URL: https://github.com/apache/apisix-website/pull/1479

   Changes:
   
   Add weekly report 20230115
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] SylviaBABY commented on a diff in pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox


SylviaBABY commented on code in PR #1478:
URL: https://github.com/apache/apisix-website/pull/1478#discussion_r1080753000


##
blog/en/blog/2023/01/18/consul-with-apisix.md:
##
@@ -0,0 +1,278 @@
+---
+title: "How to Integrate API Gateway and Consul? Not Consul K/V"
+authors:
+  - name: "Yihao LI"
+title: "Author"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+  - name: "Yihao LI"
+title: "Technical Writer"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;

Review Comment:
   you can delete this part, only keep "Author". Cause you are the author of 
this article, and no one else edits this article except you. such as this:(same 
with ZH)
   https://user-images.githubusercontent.com/39793568/213342198-dd5153ab-714c-4cb7-91c1-a3d780825ddb.png;>
   



##
blog/zh/blog/2023/01/18/consul-with-apisix.md:
##
@@ -0,0 +1,271 @@
+---
+title: "Apache APISIX 集成原生 Consul 服务发现能力"
+authors:
+  - name: "李奕浩"
+title: "Author"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+  - name: "李奕浩"
+title: "Technical Writer"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;

Review Comment:
   ditto



##
blog/zh/blog/2023/01/18/consul-with-apisix.md:
##
@@ -0,0 +1,271 @@
+---
+title: "Apache APISIX 集成原生 Consul 服务发现能力"
+authors:
+  - name: "李奕浩"
+title: "Author"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+  - name: "李奕浩"
+title: "Technical Writer"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+keywords:
+- API Gateway
+- Consul
+- 服务发现
+- 服务注册
+description: 云原生 API 网关 Apache APISIX 支持基于 Consul 的服务发现。本文讲述了在 Apache APISIX 
中实现服务发现和服务注册的全过程及 consul 的相关原理。

Review Comment:
   ```suggestion
   description: 云原生 API 网关 Apache APISIX 支持基于 Consul 的服务发现。本文讲述了在 Apache APISIX 
中实现服务发现和服务注册的全过程及 Consul 的相关原理。
   ```



##
blog/zh/blog/2023/01/18/consul-with-apisix.md:
##
@@ -0,0 +1,271 @@
+---
+title: "Apache APISIX 集成原生 Consul 服务发现能力"
+authors:
+  - name: "李奕浩"
+title: "Author"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+  - name: "李奕浩"
+title: "Technical Writer"
+url: "https://github.com/Fabriceli;
+image_url: "https://github.com/Fabriceli.png;
+keywords:
+- API Gateway
+- Consul
+- 服务发现
+- 服务注册
+description: 云原生 API 网关 Apache APISIX 支持基于 Consul 的服务发现。本文讲述了在 Apache APISIX 
中实现服务发现和服务注册的全过程及 consul 的相关原理。
+tags: [Ecosystem]
+image: 
https://static.apiseven.com/2022/blog/0818/ecosystem/HashiCorp%20Consul.png
+---
+
+## 背景
+
+### 关于 Apache APISIX
+
+Apache APISIX 是 Apache 软件基金会下的云原生 API 
网关,它兼具动态、实时、高性能等特点,提供了负载均衡、动态上游、灰度发布(金丝雀发布)、服务熔断、身份认证、可观测性等丰富的流量管理功能。我们可以使用 
Apache APISIX 来处理传统的南北向流量,也可以处理服务间的东西向流量。
+
+### 关于 Consul
+
+Consul 是 HashiCorp 公司推出的开源工具,用于实现分布式系统的服务发现与配置,提供了服务注册与发现、健康检查、Key/Value 
存储、多数据中心的能力。
+
+## 准备阶段
+
+本文中的测试环境使用 docker-compose 搭建
+
+1. 下载 Apache APISIX
+
+   ```sh
+   git clone https://github.com/apache/apisix-docker.git
+   ```
+
+2. 创建并运行 Consul
+
+   ```sh
+   docker run --rm --name consul_1 -d -p 8500:8500 consul:1.8 consul agent 
-server -bootstrap-expect=1 -node=agent-one -client 0.0.0.0 -log-level info 
-data-dir=/consul/data -enable-script-checks
+   ```
+
+3. 更新 Apache APISIX 中的配置文件`apisix_conf/config.yaml`
+
+   ```yaml
+   # config.yml
+   # ... other config
+   discovery:
+ consul:
+   servers:
+ - "http://127.0.0.1:8500;
+   ```
+
+4. 启动 Apache APISIX
+
+   ```sh
+   # 进 example 文件夹,启动 APISIX
+   docker-compose -f docker-compose.yml -p apisix-docker  up -d
+   ```
+
+5. 测试服务已经包含了两个 Web 服务,确认 Web 服务的 IP 地址
+
+   ```sh
+   $ sudo docker inspect -f='{{.Name}} - {{range 
.NetworkSettings.Networks}}{{.IPAddress}}{{end}}' $(sudo docker ps -aq) | grep 
web
+   # 输出
+   /apisix-docker-web1-1 - 172.21.0.5
+   /apisix-docker-web2-1 - 172.21.0.6
+   ```
+
+6. 请求 Consul HTTP API 将 Web 服务注册到 Consul
+
+   ```sh
+   # 使用 Web 对应的 IP 和 port 进行注册
+   $ curl --location --request PUT 
'http://127.0.0.1:8500/v1/agent/service/register' \
+   --header 'Content-Type: application/json' \
+   --data '{
+  "ID": "service_a1",
+  "Name": "service_a",
+  "Tags": ["primary", "v1"],
+  "Address": "172.21.0.5",
+  "Port": 9081,
+  "Weights": {
+ "Passing": 10,
+ "Warning": 1
+  }
+   }'
+
+   $ curl --location --request PUT 
'http://127.0.0.1:8500/v1/agent/service/register' \
+   --header 'Content-Type: application/json' \
+   --data '{
+  "ID": "service_a2",
+  "Name": "service_a",
+  "Tags": ["primary", "v1"],
+  "Address": "172.21.0.6",
+  "Port": 9082,
+  "Weights": {
+ "Passing": 10,
+ "Warning": 1
+  }
+   }'
+   ```
+
+7. 查看测试服务是否注册成功
+
+   ```sh
+   $ curl --location --request GET 

[GitHub] [apisix-website] Fabriceli commented on pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox


Fabriceli commented on PR #1478:
URL: https://github.com/apache/apisix-website/pull/1478#issuecomment-1396349413

   > @Fabriceli thanks for your contribution! Looking forward to this article.
   > 
   > You can check this part to fix Lint errors https://user-images.githubusercontent.com/39793568/213334227-cbc83409-5400-49d0-9799-5feea32ac6d5.png;>
 https://user-images.githubusercontent.com/39793568/213334233-e184fd6c-7164-4a21-8e16-208f9df289ed.png;>
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] Fabriceli commented on issue #1587: feat request: ApisixConsumer CRD add openid-connect support

2023-01-18 Thread GitBox


Fabriceli commented on issue #1587:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/1587#issuecomment-1396348718

   > @Fabriceli APISIX consumer is used for those built-in **internal** 
authentication, which replies on users to configure the auth credentials on the 
consumer, while for OpenID connect, you don't need a consumer. So IMHO, this 
feature is not reasonable.
   
   thanks, but i am confused about the Consumer with these auth plugins, How 
can I set up Keycloak with these auth plugins in Consumer? Our team want to 
manager Consumer with Keycloak auth, for the moment, Does Consumer support this 
feature?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] SylviaBABY commented on issue #8698: [docs]: deployment-role.md is not exist

2023-01-18 Thread GitBox


SylviaBABY commented on issue #8698:
URL: https://github.com/apache/apisix/issues/8698#issuecomment-1396345588

   > @SylviaBABY @yzeng25 Hi, do you have time to fix this?
   
   will fix it this week, thanks for remind


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-dashboard] ronething commented on issue #2716: Support configuring multiple prefixes of etcd for apisix-dashboard

2023-01-18 Thread GitBox


ronething commented on issue #2716:
URL: 
https://github.com/apache/apisix-dashboard/issues/2716#issuecomment-1396339009

   same as https://github.com/apache/apisix-dashboard/issues/2549


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] SkyeYoung commented on issue #8698: [docs]: deployment-role.md is not exist

2023-01-18 Thread GitBox


SkyeYoung commented on issue #8698:
URL: https://github.com/apache/apisix/issues/8698#issuecomment-1396333688

   @SylviaBABY @yzeng25 Hi, do you have time to fix this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] tokers commented on issue #1587: feat request: ApisixConsumer CRD add openid-connect support

2023-01-18 Thread GitBox


tokers commented on issue #1587:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/1587#issuecomment-1396326953

   @Fabriceli APISIX consumer is used for those built-in **internal** 
authentication, which replies on users to configure the auth credentials on the 
consumer, while for OpenID connect, you don't need a consumer. So IMHO, this 
feature is not reasonable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] SylviaBABY commented on pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox


SylviaBABY commented on PR #1478:
URL: https://github.com/apache/apisix-website/pull/1478#issuecomment-1396326549

   @Fabriceli thanks for your contribution! Looking forward to this article. 
   
   You can check this part to fix Lint errors
   https://user-images.githubusercontent.com/39793568/213334227-cbc83409-5400-49d0-9799-5feea32ac6d5.png;>
   https://user-images.githubusercontent.com/39793568/213334233-e184fd6c-7164-4a21-8e16-208f9df289ed.png;>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] AlinsRan opened a new pull request, #1605: doc: add svc-namespace description to the annotations

2023-01-18 Thread GitBox


AlinsRan opened a new pull request, #1605:
URL: https://github.com/apache/apisix-ingress-controller/pull/1605

   
   
   ### Type of change:
   
   
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix-ingress-controller#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] jensg-st commented on issue #1602: bug: DNS resolution on Ubuntu 22.04.1 LTS

2023-01-18 Thread GitBox


jensg-st commented on issue #1602:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/1602#issuecomment-1387359424

   The `etc/resolv.conf` looks alright:
   
   ```
   search apisix.svc.cluster.local svc.cluster.local cluster.local 
local.ds-networks.de
   nameserver 10.43.0.10
   options ndots:5
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] tao12345666333 commented on issue #8686: feat: As a user, I want to the consumer support openid-connect plugin as an auth plugin, so that we can use openid-connect plugin to config c

2023-01-18 Thread GitBox


tao12345666333 commented on issue #8686:
URL: https://github.com/apache/apisix/issues/8686#issuecomment-1387230513

   cc @soulbird @spacewander 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1587: feat request: ApisixConsumer CRD add openid-connect support

2023-01-18 Thread GitBox


tao12345666333 commented on issue #1587:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/1587#issuecomment-1387229094

   Thanks, I will back tomorrow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] mgonzaga1990 opened a new issue, #8709: help request: Setting up routing path

2023-01-18 Thread GitBox


mgonzaga1990 opened a new issue, #8709:
URL: https://github.com/apache/apisix/issues/8709

   ### Description
   
   I have Apache APISIX setup in docker and it is using consul service 
discovery.
   
   Everything works fine if my route is **/*** however if I changed it to 
something like **/food/*** it returns 404.
   
   
![image](https://user-images.githubusercontent.com/21145779/213183482-405be1ee-bc41-4681-aff0-0994cbf0b717.png)
   
   _with /* path_
   
![image](https://user-images.githubusercontent.com/21145779/213183870-3b5e196b-ad0b-4216-9201-31779d00682d.png)
   
![image](https://user-images.githubusercontent.com/21145779/213183770-de007934-7a7f-4bb1-b4e1-6affc7d29414.png)
   
   _with /food/* path_
   
![image](https://user-images.githubusercontent.com/21145779/213183994-a56782d5-ea51-49dd-a131-b0cb753db48d.png)
   
![image](https://user-images.githubusercontent.com/21145779/213184059-7c7e4b63-35db-4a70-8cab-d48fa00927c4.png)
   
   
   Note: I have tested that APISIX is connected to consul properly. I just 
having issues setting up custom path.
   
   ### Environment
   
   - APISIX version (run `apisix version`):
   - Operating system (run `uname -a`):
   - OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
   - etcd version, if relevant (run `curl 
http://127.0.0.1:9090/v1/server_info`):
   - APISIX Dashboard version, if relevant:
   - Plugin runner version, for issues related to plugin runners:
   - LuaRocks version, for installation issues (run `luarocks --version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] Yilialinn commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-18 Thread GitBox


Yilialinn commented on PR #1468:
URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1386887578

   Hi @juzhiyuan, I've done my review. Hope you can change the status from 
draft to approve if you have no questions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] Gallardot opened a new pull request, #1604: docs: update prowered-by.md

2023-01-18 Thread GitBox


Gallardot opened a new pull request, #1604:
URL: https://github.com/apache/apisix-ingress-controller/pull/1604

   
   Thanks to the community, great job!
   ### Type of change:
   
   
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix-ingress-controller#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1602: bug: DNS resolution on Ubuntu 22.04.1 LTS

2023-01-18 Thread GitBox


tao12345666333 commented on issue #1602:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/1602#issuecomment-1386734933

   Can you try to exec into the pod and look at `/etc/resolv.conf` ?
   
   
   
   > Other than that you can close the issue because we are building our own 
image on Ubuntu now because centos is not longer supported/maintained and we 
need UTC as timezone. This is just FYI.
   
   good point! I think we can modify it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] netlify[bot] commented on pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox


netlify[bot] commented on PR #1478:
URL: https://github.com/apache/apisix-website/pull/1478#issuecomment-1386727588

   ###  Deploy Preview for *apache-apisix* 
processing.
   
   
   |  Name | Link |
   |-||
   | Latest commit | 
7dfc1885ba573ad4766a1cb05cd5980ff8fab070 |
   | Latest deploy log | 
https://app.netlify.com/sites/apache-apisix/deploys/63c7b8f53b580700096612c3 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] Fabriceli opened a new pull request, #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox


Fabriceli opened a new pull request, #1478:
URL: https://github.com/apache/apisix-website/pull/1478

   Fixes: #[Add issue number here]
   
   Changes:
   
   add apisix with consul blog
   
   
   Screenshots of the change:
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] monkeyDluffy6017 commented on issue #8702: if etcd is down,the apisix not affect service?

2023-01-18 Thread GitBox


monkeyDluffy6017 commented on issue #8702:
URL: https://github.com/apache/apisix/issues/8702#issuecomment-1386726390

   > if etcd cluster is down ,the apisix also can handle the requests
   
   Yes, Just can't update the data anymore after the etcd cluster is down


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1603: chore(deps): bump some dependencies

2023-01-18 Thread GitBox


codecov-commenter commented on PR #1603:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/1603#issuecomment-1386716080

   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1603?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#1603](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1603?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (f841ab8) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/31714eb4ae13c25ea0de1b2b7af0469f01938738?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (31714eb) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#1603   +/-   ##
   ===
 Coverage   41.30%   41.30%   
   ===
 Files  87   87   
 Lines7460 7460   
   ===
 Hits 3081 3081   
 Misses   4026 4026   
 Partials  353  353   
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] snail2sky opened a new issue, #8708: apisix 能否支持对管理人员更细粒度的授权

2023-01-18 Thread GitBox


snail2sky opened a new issue, #8708:
URL: https://github.com/apache/apisix/issues/8708

   ### Description
   
   1. 
目前只要能登陆到apisix的dashboard,那么就能操作dashboard的所有功能,这其实在生产环境中是很危险的,目前是否支持更细粒度的授权?
   2. 
其次,apisix到底是一个什么样的定位呢?到底是交给运维人员管理,还是交由研发管理?运维将所有的相关域名的流量直接打到研发的apisix中,让研发根据自己的需求做更细粒度的调度?能否给出几个最佳实践
   3. 能否对相关的域名做批量替换upstream,主要指的是灾演情况
   
   - 因为我是运维人员,从我的观点来看,apisix有点像网络架构中的接入层的交换机,而不是核心层的,apisix应该离realserver 
(apiserver) 很近,而且经常操作他的人应该是研发,而不是运维;当然运维也可以用apisix 做汇聚层、甚至是核心层的 nginx,但是不会针对 
具体的 api进行转发,而只需要将域名的所有流量转发给研发的 apisix即可


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request, #1603: chore(deps): bump some dependencies

2023-01-18 Thread GitBox


tao12345666333 opened a new pull request, #1603:
URL: https://github.com/apache/apisix-ingress-controller/pull/1603

   
   
   ### Type of change:
   
   
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   ### What this PR does / why we need it:
   
   
   
   closes: #1600 
   closes: #1542
   ### Pre-submission checklist:
   
   
   
   * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix-ingress-controller#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] Yilialinn commented on a diff in pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-18 Thread GitBox


Yilialinn commented on code in PR #1468:
URL: https://github.com/apache/apisix-website/pull/1468#discussion_r1073252529


##
blog/en/blog/2023/01/02/accessing_apisix-dashboard_from_everywhere_with_keycloak_authentication.md:
##
@@ -0,0 +1,1152 @@
+---
+title: "Accessing APISIX-Dashboard from Everywhere with Keycloak 
Authentication"
+authors:
+  - name: "Busico Mirto Silvio"
+title: ""
+url: "https://github.com/MirtoBusico;
+image_url: 
"https://avatars.githubusercontent.com/u/11090934?s=400=644e4f87c2fad56760f6eb4f46cbcb4db059880a=4;
+keywords:
+  - Alternatives to NGINX
+  - Access and Authentication
+  - Nginx reverse proxy
+  - OpenID-Connect
+  - Keycloak
+description: This guest blog shares how to expose the APISIX Dashboard using 
APISIX to authenticate access with the OpenID-Connect plugin and Keycloak 
server to manage identities.
+tags:
+  - APISIX Basics
+  - API Gateway Concepts
+  - Authorization & Authentication
+cover: https://github.com/MirtoBusico/assets-for-blogs/blob/main/blog01a.png
+---
+
+> This article describes how to setup an external access to apisix-dashboard 
protecting the URL with authentication managed by a keycloak server.
+
+
+
+![framework](https://github.com/MirtoBusico/assets-for-blogs/blob/main/blog01a.png)
+
+This article presents how to setup a framework where a user can access the 
Apisix-dashboard protected using an authentication system managed by a Keycloak 
server.
+
+## Prerequisites
+
+Basic understanding of nginx reverse proxy, kubernetes, apisix and openid 
connect.
+
+> A lot of information on this matter can be found in ["Use Keycloak with API 
Gateway to secure 
APIs"](https://apisix.apache.org/blog/2022/07/06/use-keycloak-with-api-gateway-to-secure-apis/)
 blog post
+
+Here I'll present instructions, examples, code and screenshots taken from my 
home lab.
+
+The framework used in this article consists of some KVM virtual machines (from 
now VM):
+
+| VM Name | Role | Services | Description |
+|-|--|--|-|
+|   hdev  |  Development|kubectl, istioctl, helm  | 
workstation from where manage the cluster   |
+|   hserv |  external services| DNS server, Nginx, Keycloak  | 
services used by the cluster VM and external users|
+|   hkm   | Kubernetes master | master node | control plane 
manager for K8S|
+|   hkw1  | K8S worker 1| first worker node | node for 
hosting pods|
+|   hkw2  | K8S worker 2| second worker node | node for 
hosting pods|
+|   hkw3  | K8S worker 3| third worker node | node for 
hosting pods|
+
+The **hserv** VM have two lan cards: one on an external lan to expose services 
and one an internal lan to communicate with the Kubernetes (from now K8S) 
cluster.
+All the other VM are only connected to the internal lan.
+
+All the machines resolve the IP addresses using the DNS server installed on 
**hserv**
+
+**Hserv** and **hdev** machines have a Graphical User Interface (from now 
GUI). All the other machines have only the character console.
+
+> The real framework is more complex. Here are reported only the relevant 
components
+
+All machines use Ubuntu distribution but commands reported here should worh 
for other distributions with some modifications.
+The username used throughout this article will be **"sysop"** So the home 
directory will be indicated as **"/home/sysop"** or **"~/"**.
+
+## Create a Certification authority and certificates

Review Comment:
   ```suggestion
   ## Create a Certification Authority and Certificates
   ```



##
blog/en/blog/2023/01/02/accessing_apisix-dashboard_from_everywhere_with_keycloak_authentication.md:
##
@@ -0,0 +1,1152 @@
+---
+title: "Accessing APISIX-Dashboard from Everywhere with Keycloak 
Authentication"
+authors:
+  - name: "Busico Mirto Silvio"
+title: ""
+url: "https://github.com/MirtoBusico;
+image_url: 
"https://avatars.githubusercontent.com/u/11090934?s=400=644e4f87c2fad56760f6eb4f46cbcb4db059880a=4;
+keywords:
+  - Alternatives to NGINX
+  - Access and Authentication
+  - Nginx reverse proxy
+  - OpenID-Connect
+  - Keycloak
+description: This guest blog shares how to expose the APISIX Dashboard using 
APISIX to authenticate access with the OpenID-Connect plugin and Keycloak 
server to manage identities.
+tags:
+  - APISIX Basics
+  - API Gateway Concepts
+  - Authorization & Authentication
+cover: https://github.com/MirtoBusico/assets-for-blogs/blob/main/blog01a.png
+---
+
+> This article describes how to setup an external access to apisix-dashboard 
protecting the URL with authentication managed by a keycloak server.
+
+
+
+![framework](https://github.com/MirtoBusico/assets-for-blogs/blob/main/blog01a.png)
+
+This article presents how to setup a framework where a user can access the 
Apisix-dashboard protected using an authentication system 

[GitHub] [apisix-helm-chart] tokers merged pull request #413: doc: update apisix doc for new users

2023-01-18 Thread GitBox


tokers merged PR #413:
URL: https://github.com/apache/apisix-helm-chart/pull/413


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] unsw-luopan commented on issue #8540: bug: can't run apifix by offical document

2023-01-18 Thread GitBox


unsw-luopan commented on issue #8540:
URL: https://github.com/apache/apisix/issues/8540#issuecomment-1386679494

   save my life..same error, same mirror


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] uran0sH commented on issue #5453: request help: proxy-cache plugin, why the cache expiration time cannot be configured dynamically?

2023-01-18 Thread GitBox


uran0sH commented on issue #5453:
URL: https://github.com/apache/apisix/issues/5453#issuecomment-1386676004

   So do I need to modify the config of Nginx and reload it in `header_filter`? 
Are there some operations to modify the config of Nginx? I am so confused about 
it. Could you give me some ideas?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] huacnlee opened a new pull request, #8707: Improve autocorrect

2023-01-17 Thread GitBox


huacnlee opened a new pull request, #8707:
URL: https://github.com/apache/apisix/pull/8707

   ### Description
   
   
   
   
   Fixes # (issue)
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] JohnQI8888 commented on issue #8680: help request: 是否有文档可以指导实现多环境

2023-01-17 Thread GitBox


JohnQI commented on issue #8680:
URL: https://github.com/apache/apisix/issues/8680#issuecomment-1386565194

   > > 支持  /* 这样的通配符吗?
   > 
   > you can have a try
   
   Thanks for help, and another problem is we still work in apisix 1.6.x,  I 
don't think it can work for us.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] Fabriceli commented on a diff in pull request #8651: fix: fix fetch all service info from consul

2023-01-17 Thread GitBox


Fabriceli commented on code in PR #8651:
URL: https://github.com/apache/apisix/pull/8651#discussion_r1073110176


##
apisix/discovery/consul/init.lua:
##
@@ -242,48 +215,76 @@ function _M.connect(premature, consul_server, retry_delay)
 
 -- if current index different last index then update service
 if consul_server.index ~= watch_result.headers['X-Consul-Index'] then
+local up_services = core.table.new(0, #watch_result.body)
+local consul_client_svc = resty_consul:new({
+host = consul_server.host,
+port = consul_server.port,
+connect_timeout = consul_server.connect_timeout,
+read_timeout = consul_server.read_timeout,
+})
+for service_name, _ in pairs(watch_result.body) do
+-- check if the service_name is 'skip service'
+if skip_service_map[service_name] then
+goto CONTINUE
+end
+-- get node from service
+local svc_url = consul_server.consul_sub_url .. "/" .. service_name
+local result, err = consul_client_svc:get(svc_url)
+local error_info = (err ~= nil and err) or
+((result ~= nil and result.status ~= 200) and 
result.status)
+if error_info then
+log.error("connect consul: ", consul_server.consul_server_url,
+" by svc url: ", svc_url, ", with error: ", error_info)

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox


e1ijah1 commented on code in PR #8681:
URL: https://github.com/apache/apisix/pull/8681#discussion_r1073070382


##
t/cli/plugin/test_file_logger_std_output.sh:
##
@@ -0,0 +1,75 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+. ./t/cli/common.sh
+
+log_file=logs/stdout.log
+
+if [ -f "$log_file" ]; then
+rm "$log_file"
+fi
+
+make init
+
+stdbuf -o0 /usr/local/openresty/bin/openresty -p . -g 'daemon off;' > 
"$log_file" 2>&1 &

Review Comment:
   I ran 'make run' without daemon mode, but it didn't print out standard 
output.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] netlify[bot] commented on pull request #1477: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.2

2023-01-17 Thread GitBox


netlify[bot] commented on PR #1477:
URL: https://github.com/apache/apisix-website/pull/1477#issuecomment-1386453065

   ###  Deploy Preview for *apache-apisix* 
processing.
   
   
   |  Name | Link |
   |-||
   | Latest commit | 
90f4dc03d06d58526991c43c33eca1968cd6e0b4 |
   | Latest deploy log | 
https://app.netlify.com/sites/apache-apisix/deploys/63c76f266f5d490008231ed9 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] dependabot[bot] commented on pull request #1465: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1

2023-01-17 Thread GitBox


dependabot[bot] commented on PR #1465:
URL: https://github.com/apache/apisix-website/pull/1465#issuecomment-1386452168

   Superseded by #1477.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] dependabot[bot] closed pull request #1465: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1

2023-01-17 Thread GitBox


dependabot[bot] closed pull request #1465: chore(deps): bump 
peaceiris/actions-gh-pages from 3.9.0 to 3.9.1
URL: https://github.com/apache/apisix-website/pull/1465


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] dependabot[bot] opened a new pull request, #1477: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.2

2023-01-17 Thread GitBox


dependabot[bot] opened a new pull request, #1477:
URL: https://github.com/apache/apisix-website/pull/1477

   Bumps 
[peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) 
from 3.9.0 to 3.9.2.
   
   Release notes
   Sourced from https://github.com/peaceiris/actions-gh-pages/releases;>peaceiris/actions-gh-pages's
 releases.
   
   actions-github-pages v3.9.2
   See https://github.com/peaceiris/actions-gh-pages/blob/v3.9.2/CHANGELOG.md;>CHANGELOG.md
 for more details.
   actions-github-pages v3.9.1
   
   update deps
   
   See https://github.com/peaceiris/actions-gh-pages/blob/v3.9.1/CHANGELOG.md;>CHANGELOG.md
 for more details.
   
   
   
   Changelog
   Sourced from https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md;>peaceiris/actions-gh-pages's
 changelog.
   
   https://github.com/peaceiris/actions-gh-pages/compare/v3.9.1...v3.9.2;>3.9.2
 (2023-01-17)
   chore
   
   rename cicd (https://github.com/peaceiris/actions-gh-pages/commit/32c9288f553bbcbf66869cf553c82754431faf03;>32c9288)
   replace npm ci with install (https://github.com/peaceiris/actions-gh-pages/commit/983978086a87d25a1ff678aa1ef4c2acc413784a;>9839780)
   
   ci
   
   add github-actions npm (https://github.com/peaceiris/actions-gh-pages/commit/5e5dc6d02eeb18001e0a7af6d6fcbabd4fd9e2b7;>5e5dc6d)
   enable automerge (https://github.com/peaceiris/actions-gh-pages/commit/dd7d77895818fd15ebecf20b6bf76028d377e1b6;>dd7d778)
   remove dependabot (https://github.com/peaceiris/actions-gh-pages/commit/7af79a873e9c2b6c37690db94012342fdb90914a;>7af79a8)
   remove enabledManagers (https://github.com/peaceiris/actions-gh-pages/commit/cba22ba760f1c7e62c9ae43167ea68ca9de56506;>cba22ba)
   use peaceiris/workflows/setup-node 0.19.1 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/818;>#818)
 (https://github.com/peaceiris/actions-gh-pages/commit/416f539fb4263ec46f9bbee251e87cfeae9f85ff;>416f539),
 closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/818;>#818
   
   deps
   
   apply npm audit fix (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/809;>#809)
 (https://github.com/peaceiris/actions-gh-pages/commit/e3aa46d23bbf7f669a6d92c15dda089b2edf4959;>e3aa46d),
 closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/809;>#809
   
   https://github.com/peaceiris/actions-gh-pages/compare/v3.9.0...v3.9.1;>3.9.1
 (2023-01-05)
   chore
   
   change cicd label name (https://github.com/peaceiris/actions-gh-pages/commit/180896524151a5634ff5815a72c59467fc27c874;>1808965)
   
   ci
   
   add Renovate config (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/802;>#802)
 (https://github.com/peaceiris/actions-gh-pages/commit/072d16c439270cd3a36c3e0977ccbe10f2b2bc55;>072d16c),
 closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/802;>#802
   bump actions/dependency-review-action from 2 to 3 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/799;>#799)
 (https://github.com/peaceiris/actions-gh-pages/commit/e3b45f27007dc55bcdd52f01e38af6f61576ec7f;>e3b45f2),
 closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/799;>#799
   bump peaceiris/actions-github-app-token from 1.1.4 to 1.1.5 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/798;>#798)
 (https://github.com/peaceiris/actions-gh-pages/commit/a5f971f112fd50b6dd28469f23be2618b1ea87e7;>a5f971f),
 closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/798;>#798
   bump peaceiris/actions-mdbook from 1.1.14 to 1.2.0 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/793;>#793)
 (https://github.com/peaceiris/actions-gh-pages/commit/9af6a68dde7720af8fd55364c2c637ca5922a879;>9af6a68),
 closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/793;>#793
   bump peaceiris/workflows from 0.17.1 to 0.17.2 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/794;>#794)
 (https://github.com/peaceiris/actions-gh-pages/commit/087a759f907a127fdee23c8994321ff96f7d9430;>087a759),
 closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/794;>#794
   bump peaceiris/workflows from 0.17.2 to 0.18.1 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/806;>#806)
 (https://github.com/peaceiris/actions-gh-pages/commit/f94667a25cd2716a8a046111457e4b17c8c28407;>f94667a),
 closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/806;>#806
   
   deps
   
   bump @​actions/github from 5.0.1 to 5.1.1 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/785;>#785)
 (https://github.com/peaceiris/actions-gh-pages/commit/679dbf02f69022f8c402975fdefe41ddb31516cd;>679dbf0),
 closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/785;>#785
   bump @​actions/glob from 0.2.1 to 0.3.0 

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox


e1ijah1 commented on code in PR #8681:
URL: https://github.com/apache/apisix/pull/8681#discussion_r1073070382


##
t/cli/plugin/test_file_logger_std_output.sh:
##
@@ -0,0 +1,75 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+. ./t/cli/common.sh
+
+log_file=logs/stdout.log
+
+if [ -f "$log_file" ]; then
+rm "$log_file"
+fi
+
+make init
+
+stdbuf -o0 /usr/local/openresty/bin/openresty -p . -g 'daemon off;' > 
"$log_file" 2>&1 &

Review Comment:
   I ran 'make run' without daemon mode, but it didn't print out standard 
output.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] ronething commented on pull request #8640: feat: stream subsystem support kubernetes service discovery

2023-01-17 Thread GitBox


ronething commented on PR #8640:
URL: https://github.com/apache/apisix/pull/8640#issuecomment-1386445246

   @tokers @soulbird Could you please take a look, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox


shreemaan-abhishek commented on code in PR #8660:
URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068637


##
apisix/plugins/jwt-auth.lua:
##
@@ -274,32 +234,16 @@ end
 local function get_rsa_or_ecdsa_keypair(conf, consumer_name)
 local public_key = conf.public_key
 local private_key = conf.private_key
--- if keys are present in conf, no need to query vault (fallback)
+
 if public_key and private_key then
 return public_key, private_key
+elseif public_key and not private_key then
+return public_key, nil, "missing private key"

Review Comment:
   should we add a nil check there? I think we should. Even the previous 
implementation would return nil in some cases. Not sure why it is not being 
checked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox


shreemaan-abhishek commented on code in PR #8660:
URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068637


##
apisix/plugins/jwt-auth.lua:
##
@@ -274,32 +234,16 @@ end
 local function get_rsa_or_ecdsa_keypair(conf, consumer_name)
 local public_key = conf.public_key
 local private_key = conf.private_key
--- if keys are present in conf, no need to query vault (fallback)
+
 if public_key and private_key then
 return public_key, private_key
+elseif public_key and not private_key then
+return public_key, nil, "missing private key"

Review Comment:
   should we add a nil check there?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox


shreemaan-abhishek commented on code in PR #8660:
URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068429


##
apisix/plugins/jwt-auth.lua:
##
@@ -274,32 +234,16 @@ end
 local function get_rsa_or_ecdsa_keypair(conf, consumer_name)
 local public_key = conf.public_key
 local private_key = conf.private_key
--- if keys are present in conf, no need to query vault (fallback)
+
 if public_key and private_key then
 return public_key, private_key
+elseif public_key and not private_key then
+return public_key, nil, "missing private key"

Review Comment:
   Should we add a nil check there? 樂 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] spacewander commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox


spacewander commented on code in PR #8681:
URL: https://github.com/apache/apisix/pull/8681#discussion_r1073059505


##
apisix/plugins/file-logger.lua:
##
@@ -39,7 +41,7 @@ local schema = {
 }
 }
 },
-required = {"path"}
+required = { "path" }

Review Comment:
   The blank line and other style issue are not addressed totally



##
apisix/plugins/file-logger.lua:
##
@@ -108,19 +115,23 @@ if is_apisix_or then
 end
 end
 
+

Review Comment:
   Ditto



##
t/cli/plugin/test_file_logger_std_output.sh:
##
@@ -0,0 +1,75 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+. ./t/cli/common.sh
+
+log_file=logs/stdout.log
+
+if [ -f "$log_file" ]; then
+rm "$log_file"

Review Comment:
   We can avoid using real file, like 
https://github.com/apache/apisix/blob/4131fbf641c02eb4209ffa9cddbe0bea247e990b/t/cli/test_validate_config.sh#L30



##
t/cli/plugin/test_file_logger_std_output.sh:
##
@@ -0,0 +1,75 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+. ./t/cli/common.sh
+
+log_file=logs/stdout.log
+
+if [ -f "$log_file" ]; then
+rm "$log_file"
+fi
+
+make init
+
+stdbuf -o0 /usr/local/openresty/bin/openresty -p . -g 'daemon off;' > 
"$log_file" 2>&1 &

Review Comment:
   Would you please use the suggestion in 
https://github.com/apache/apisix/pull/8681#issuecomment-1384864654?
   We are testing APISIX - better to avoid running bare openresty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] yzeng25 merged pull request #1476: docs:add mafengwo usercase blog

2023-01-17 Thread GitBox


yzeng25 merged PR #1476:
URL: https://github.com/apache/apisix-website/pull/1476


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] mscb402 commented on issue #8705: feat: As a user, I want file-logger plugin support record response body in a custom format, so that make the log format more flexible

2023-01-17 Thread GitBox


mscb402 commented on issue #8705:
URL: https://github.com/apache/apisix/issues/8705#issuecomment-1386436970

   @spacewander 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] mscb402 commented on issue #8705: feat: As a user, I want file-logger plugin support record response body in a custom format, so that make the log format more flexible

2023-01-17 Thread GitBox


mscb402 commented on issue #8705:
URL: https://github.com/apache/apisix/issues/8705#issuecomment-1386436647

   @tokers 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] mscb402 opened a new issue, #8705: feat: As a user, I want file-logger plugin support record response body in a custom format, so that make the log format more flexible

2023-01-17 Thread GitBox


mscb402 opened a new issue, #8705:
URL: https://github.com/apache/apisix/issues/8705

   ### Description
   
   As a user, I would like the file-logger plugin to support logging the 
response body in a custom format to make the logging format more flexible. 
   Currently the file-logger plugin supports logging the response body, but not 
logging the response in the way the user wants. 
   So if the user configures the log format in meta. There will be no way to 
log the response body. Only clear log format in meta will be enabled.
   So I want to add a new var `resp_body` to let the user put it in a log 
format which let the user use the response in the way there want. 
   What do you think about this? If you think this is ok, pls assign me to add 
this feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] spacewander commented on a diff in pull request #8651: fix: fix fetch all service info from consul

2023-01-17 Thread GitBox


spacewander commented on code in PR #8651:
URL: https://github.com/apache/apisix/pull/8651#discussion_r1073064191


##
apisix/discovery/consul/init.lua:
##
@@ -242,48 +215,76 @@ function _M.connect(premature, consul_server, retry_delay)
 
 -- if current index different last index then update service
 if consul_server.index ~= watch_result.headers['X-Consul-Index'] then
+local up_services = core.table.new(0, #watch_result.body)
+local consul_client_svc = resty_consul:new({
+host = consul_server.host,
+port = consul_server.port,
+connect_timeout = consul_server.connect_timeout,
+read_timeout = consul_server.read_timeout,
+})
+for service_name, _ in pairs(watch_result.body) do
+-- check if the service_name is 'skip service'
+if skip_service_map[service_name] then
+goto CONTINUE
+end
+-- get node from service
+local svc_url = consul_server.consul_sub_url .. "/" .. service_name
+local result, err = consul_client_svc:get(svc_url)
+local error_info = (err ~= nil and err) or
+((result ~= nil and result.status ~= 200) and 
result.status)
+if error_info then
+log.error("connect consul: ", consul_server.consul_server_url,
+" by svc url: ", svc_url, ", with error: ", error_info)

Review Comment:
   Would you like to fix the indent when adding them as new code? 
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #5453: request help: proxy-cache plugin, why the cache expiration time cannot be configured dynamically?

2023-01-17 Thread GitBox


spacewander commented on issue #5453:
URL: https://github.com/apache/apisix/issues/5453#issuecomment-1386432946

   It uses nginx's proxy-cache


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] yzeng25 commented on pull request #1476: docs:add mafengwo usercase blog

2023-01-17 Thread GitBox


yzeng25 commented on PR #1476:
URL: https://github.com/apache/apisix-website/pull/1476#issuecomment-1386426670

   PTAL @SylviaBABY , cc @SkyeYoung @juzhiyuan .
   
   - Displayed  properly under **Blog** and **Case Studies** page
   - Author's properties all checked valid
   - Blog content all checked valid
   
   Below are related screenshots.
   
   ![WeChat 
Screenshot_2023011831](https://user-images.githubusercontent.com/36651058/213074730-24321e3e-0bf2-4508-a4b8-d87cc5c44b26.png)
   
   ![WeChat 
Screenshot_20230118111234](https://user-images.githubusercontent.com/36651058/213074742-3cac631c-2307-48f5-902f-f4fe1910723b.png)
   
   ![WeChat 
Screenshot_20230118111355](https://user-images.githubusercontent.com/36651058/213074743-a7aef53c-c8c5-4f07-80b0-d4f87b2f598c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] e1ijah1 commented on pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox


e1ijah1 commented on PR #8681:
URL: https://github.com/apache/apisix/pull/8681#issuecomment-1386421353

   > Can you add a test in https://github.com/apache/apisix/tree/master/t/cli?
   
   The test has been added. Please take a look if you're available. 
@spacewander 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #297: #296: added admin ingress

2023-01-17 Thread GitBox


tao12345666333 commented on PR #297:
URL: 
https://github.com/apache/apisix-helm-chart/pull/297#issuecomment-1386418081

   Hi, #442  has been merged, which allows exposing admin API through Ingress.
   
   https://github.com/apache/apisix-helm-chart/pull/442#issuecomment-1376806537 
This reason convinced me.
   
   Thanks for your contribution.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-helm-chart] tao12345666333 closed issue #441: feat: allow exposing admin api via ingress resource

2023-01-17 Thread GitBox


tao12345666333 closed issue #441: feat: allow exposing admin api via ingress 
resource
URL: https://github.com/apache/apisix-helm-chart/issues/441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #441: feat: allow exposing admin api via ingress resource

2023-01-17 Thread GitBox


tao12345666333 commented on issue #441:
URL: 
https://github.com/apache/apisix-helm-chart/issues/441#issuecomment-1386413589

   ok, #442 has been merged, I will close this one, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #401: fix: enable tls for the tcp address

2023-01-17 Thread GitBox


tao12345666333 merged PR #401:
URL: https://github.com/apache/apisix-helm-chart/pull/401


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] spacewander commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox


spacewander commented on code in PR #8660:
URL: https://github.com/apache/apisix/pull/8660#discussion_r1073050987


##
apisix/plugins/jwt-auth.lua:
##
@@ -274,32 +234,16 @@ end
 local function get_rsa_or_ecdsa_keypair(conf, consumer_name)
 local public_key = conf.public_key
 local private_key = conf.private_key
--- if keys are present in conf, no need to query vault (fallback)
+
 if public_key and private_key then
 return public_key, private_key
+elseif public_key and not private_key then
+return public_key, nil, "missing private key"

Review Comment:
   Will it be a problem in 
https://github.com/shreemaan-abhishek/apisix/blob/09f6c5971176b6fd60b9c090aacd1c556c072d1d/apisix/plugins/jwt-auth.lua#L291?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #610: proposal: New architecture of Apache APISIX Ingress controller

2023-01-17 Thread GitBox


tao12345666333 commented on issue #610:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/610#issuecomment-1386361494

   ![2023-01-18 
09-56-25屏幕截图](https://user-images.githubusercontent.com/3264292/213062313-eb915ee9-560f-47d3-976d-94cf8f9b939a.png)
   
   
   I have a new idea.
   
   Since APISIX v3 has added the capability of gRPC-client, some optimizations 
have been made to the CP/DP deployment model in APISIX v3.
   So we can apply this model in APISIX Ingress, implement a gRPC server 
similar to ETCD in APISIX-Ingress-Controller, let it serve as the control 
plane, and APISIX, which is actually a data plane, connects to it through gRPC.
   
   In this way, the data plane APISIX is exactly the same as normal APISIX, not 
in Standalone mode, so you can use all the capabilities of APISIX without any 
modification to APISIX.
   
   WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] yzeng25 commented on a diff in pull request #1476: docs:add mafengwo usercase blog

2023-01-17 Thread GitBox


yzeng25 commented on code in PR #1476:
URL: https://github.com/apache/apisix-website/pull/1476#discussion_r1073010881


##
blog/zh/blog/2023/01/15/mafengwo-with-apisix.md:
##
@@ -0,0 +1,140 @@
+---
+title: "马蜂窝如何利用 APISIX 网关实现微服务架构升级
+"

Review Comment:
   ```suggestion
   title: "马蜂窝如何利用 APISIX 网关实现微服务架构升级"
   ```



##
blog/zh/blog/2023/01/15/mafengwo-with-apisix.md:
##
@@ -0,0 +1,140 @@
+---
+title: "马蜂窝如何利用 APISIX 网关实现微服务架构升级
+"
+authors:
+  - name: "董红帅"
+title: "Author"
+url: "https://github.com/hansedong;
+image_url: "https://github.com/hansedong.png;
+keywords: 
+- 马蜂窝
+- Apache APISIX
+- 网关
+- 架构
+description: 本文从马蜂窝的微服务架构平台蜂效迭代过程和应用 APISIX 后的产品实践角度,为大家呈现了基于 APISIX 的网关应用实例。
+tags: [Case Studies]
+image: 
https://static.apiseven.com/uploads/2023/01/17/GhQuQxSZ_20230117-111941.png
+---
+
+> 本文从马蜂窝的微服务架构平台蜂效迭代过程和应用 APISIX 后的产品实践角度,为大家呈现了基于 APISIX 的网关应用实例。
+
+
+
+>作者:[董红帅](https://github.com/hansedong),马蜂窝微服务体系建设以及基础服务能力建设专家。

Review Comment:
   ```suggestion
   > 作者:[董红帅](https://github.com/hansedong),马蜂窝微服务体系建设以及基础服务能力建设专家。
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] spacewander closed issue #7785: bug: The `/` in the log will be added with an extra `\` when enabled file-logger and sls-logger

2023-01-17 Thread GitBox


spacewander closed issue #7785: bug: The `/` in the log will be added with an 
extra `\` when enabled file-logger and sls-logger
URL: https://github.com/apache/apisix/issues/7785


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] spacewander merged pull request #8684: fix: remove backslash before slash when encoding

2023-01-17 Thread GitBox


spacewander merged PR #8684:
URL: https://github.com/apache/apisix/pull/8684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] spacewander merged pull request #8672: ci: kafka should register port in the zookeeper same as exposed

2023-01-17 Thread GitBox


spacewander merged PR #8672:
URL: https://github.com/apache/apisix/pull/8672


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] yzeng25 commented on a diff in pull request #1471: docs:add four blogs

2023-01-17 Thread GitBox


yzeng25 commented on code in PR #1471:
URL: https://github.com/apache/apisix-website/pull/1471#discussion_r1073009544


##
blog/zh/blog/2023/01/11/apisix-amesh-introduction.md:
##
@@ -0,0 +1,87 @@
+---
+title: "基于 APISIX 的服务网格方案 Amesh 积极开发中!"
+authors:
+  - name: "lingsamuel"
+title: "Author"
+url: "https://github.com/lingsamuel;
+image_url: "https://github.com/lingsamuel.png;
+keywords: 
+- Apache APISIX
+- Amesh
+- Service Mesh
+- 服务网格
+- Kubernetes
+description: Amesh 是 Apache APISIX 的服务网格库。它适配了 xDS 协议,可以从诸如 Istio 
的控制平面中接收数据,并生成 APISIX 所需的数据结构,使得 APISIX 能够在服务网格领域作为数据面发挥作用。
+tags: [Ecosystem]
+---
+
+> 
在云原生快速发展的前提下,服务网格领域也开始逐渐火热。目前阶段,大家所熟知的服务网格解决方案很多,每种产品又各有其优势。因此在面对不同的行业或者业务背景时,每个人的选型想法都各不相同。
+
+
+
+> 作者 [lingsamuel](https://github.com/lingsamuel),API7.ai 云原生技术专家,Apache APISIX 
Committer。
+
+Apache APISIX 是一个动态、实时、高性能的云原生 API 
网关,提供负载均衡、动态上游、灰度发布、服务熔断、身份认证、可观测性等丰富的流量管理功能。基于 APISIX 的扩展道路上,除了 APISIX Ingress 
在云原生领域被各大厂商开始关注外,基于 APISIX 的服务网格方案也在积极迭代中。
+
+## 基于 APISIX 的服务网格方案
+
+[Amesh](https://github.com/api7/amesh) 是 [Apache 
APISIX](https://github.com/apache/apisix) 的服务网格库。它适配了 xDS 协议,可以从诸如 Istio 
的控制平面中接收数据,并生成 APISIX 所需的数据结构,使得 APISIX 能够在服务网格领域作为数据面发挥作用。
+
+依靠 Amesh,APISIX 可以工作在服务网格模式下,不使用传统的 etcd 作为数据中心,而是使用 shdict 与 Amesh 
库直接进行数据交换,避免了额外的性能损耗,使得大规模部署成为可能。
+
+通过使用 Amesh,可以在服务网格领域获得 APISIX 具备的高性能、丰富的流量管理功能、易扩展性等多种优势。
+
+### Amesh 的架构
+
+Amesh 通过适配 xDS 协议,可以让 APISIX 替代 Istio 所使用的 envoy 组件来接管集群流量。在实际使用中,APISIX 将作为 
Pod 的 Sidecar 接管网格内的所有流量。目前 Amesh 的架构如下图所示:
+
+![Amesh 
架构](https://static.apiseven.com/uploads/2023/01/10/VMKr49uF_image%20%2830%29.png)

Review Comment:
   This wasn't fixed. This picture and the next picture share the same problem: 
a red line under 'xDS' should be removed.

   ![WeChat 
Screenshot_20230118094733](https://user-images.githubusercontent.com/36651058/213061208-20b314f8-cbd5-4368-a566-aab5b46eccf7.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] SkyeYoung commented on a diff in pull request #1474: fix the display of apisix-dashboard's version and download url

2023-01-17 Thread GitBox


SkyeYoung commented on code in PR #1474:
URL: https://github.com/apache/apisix-website/pull/1474#discussion_r1073008099


##
package.json:
##
@@ -17,6 +17,7 @@
   "scripts": {
 "sync-docs": "yarn workspace scripts sync-docs",
 "generate-repos-info": "yarn workspace scripts generate-repos-info",
+"generate-dashboard-latest-version": "yarn workspace scripts 
generate-dashboard-latest-version",

Review Comment:
   I think this can generate all repos' versions, not only the dashboard



##
config/downloads.json:
##
@@ -0,0 +1 @@
+[{"name":"APISIX®","nameInParamCase":"apisix","description":"A dynamic, 
real-time, high-performance API 
gateway.","shape":"triangle","color":"#e8433e","githubRepo":"apache/apisix","githubBranch":"master","downloadPath":"apisix/3.1.0/apache-apisix-3.1.0-src","dockerhubPath":"apisix","version":"3.1.0","LTSDownloadPath":"apisix/2.15.1/apache-apisix-2.15.1-src","LTSVersion":"2.15.1","releaseDate":"2022-12-29","firstDocPath":"/getting-started"},{"name":"APISIX®
 Dashboard","nameInParamCase":"dashboard","description":"Designed to make it as 
easy as possible for users to operate Apache APISIX through a frontend 
interface.","shape":"square","color":"#10B981","githubRepo":"apache/apisix-dashboard","githubBranch":"master","downloadPath":"apisix/dashboard/v2.15.0/apache-apisix-dashboard-v2.15.0-src","dockerhubPath":"apisix-dashboard","version":"v2.15.0","releaseDate":"2022-12-13","firstDocPath":"/USER_GUIDE"},{"name":"APISIX®
 Ingress Controller","nameInParamCase":"ingress-controller","descri
 ption":"An Apache APISIX control plane 
component.","shape":"hexagon","color":"#2563EB","githubRepo":"apache/apisix-ingress-controller","githubBranch":"master","downloadPath":"apisix/ingress-controller/1.3.0/apache-apisix-ingress-controller-1.3.0-src","dockerhubPath":"apisix-ingress-controller","version":"1.3.0","releaseDate":"2021-10-17","firstDocPath":"/getting-started"},{"name":"APISIX®
 Java Plugin Runner","nameInParamCase":"java-plugin-runner","description":"Runs 
Apache APISIX plugins written in Java. Implemented as a sidecar that 
accompanies Apache 
APISIX.","shape":"star","color":"#FB9300","githubRepo":"apache/apisix-java-plugin-runner","githubBranch":"main","downloadPath":"apisix/java-plugin-runner/0.4.0/apisix-java-plugin-runner-0.4.0-src","version":"0.4.0","releaseDate":"2022-11-11","firstDocPath":"/development"},{"name":"APISIX®
 Go Plugin Runner","nameInParamCase":"go-plugin-runner","description":"Runs 
Apache APISIX plugins written in Go. Implemented as a sidecar that acco
 mpanies Apache 
APISIX.","shape":"octagon","color":"#3B14A7","githubRepo":"apache/apisix-go-plugin-runner","githubBranch":"master","downloadPath":"apisix/go-plugin-runner/0.5.0/apisix-go-plugin-runner-0.5.0-src","version":"0.5.0","releaseDate":"2022-11-10","firstDocPath":"/getting-started"},{"name":"APISIX®
 Python Plugin 
Runner","nameInParamCase":"python-plugin-runner","description":"Runs Apache 
APISIX plugins written in Python. Implemented as a sidecar that accompanies 
Apache 
APISIX.","shape":"shield","color":"#1296DB","githubRepo":"apache/apisix-python-plugin-runner","githubBranch":"master","downloadPath":"apisix/python-plugin-runner/0.2.0/apisix-python-plugin-runner-0.2.0-src","version":"0.2.0","releaseDate":"2022-03-04","firstDocPath":"/getting-started"}]

Review Comment:
   DITTO, if you want to keep this, pls format it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] SkyeYoung commented on a diff in pull request #1474: fix the display of apisix-dashboard's version and download url

2023-01-17 Thread GitBox


SkyeYoung commented on code in PR #1474:
URL: https://github.com/apache/apisix-website/pull/1474#discussion_r1073007163


##
config/docs.json:
##
@@ -0,0 +1 @@
+[{"name":"APISIX®","nameInParamCase":"apisix","description":"A dynamic, 
real-time, high-performance API 
gateway.","shape":"triangle","color":"#e8433e","githubRepo":"apache/apisix","version":"3.1.0","releaseDate":"2022-12-29","firstDocPath":"/getting-started"},{"name":"APISIX®
 Dashboard","nameInParamCase":"dashboard","description":"Designed to make it as 
easy as possible for users to operate Apache APISIX through a frontend 
interface.","shape":"square","color":"#10B981","githubRepo":"apache/apisix-dashboard","version":"v2.15.0","releaseDate":"2022-12-13","firstDocPath":"/USER_GUIDE"},{"name":"APISIX®
 Ingress Controller","nameInParamCase":"ingress-controller","description":"An 
Apache APISIX control plane 
component.","shape":"hexagon","color":"#2563EB","githubRepo":"apache/apisix-ingress-controller","version":"1.3.0","releaseDate":"2021-10-17","firstDocPath":"/getting-started"},{"name":"APISIX®
 Helm Charts","nameInParamCase":"helm-chart","description":"An Apache APISIX 
Helm Charts 
 provide the installation of Apache APISIX components for 
kubernetes.","shape":"pentagon","color":"#C71585","githubRepo":"apache/apisix-helm-chart","version":"0.4.0","releaseDate":"2021-03-12","firstDocPath":"/apisix"},{"name":"APISIX®
 Docker","nameInParamCase":"docker","description":"Docker tooling for Apache 
APISIX.","shape":"diamond","color":"#FFD700","githubRepo":"apache/apisix-docker","version":"1.0.0","releaseDate":"2020-12-1","firstDocPath":"/build"},{"name":"APISIX®
 Java Plugin Runner","nameInParamCase":"java-plugin-runner","description":"Runs 
Apache APISIX plugins written in Java. Implemented as a sidecar that 
accompanies Apache 
APISIX.","shape":"star","color":"#FB9300","githubRepo":"apache/apisix-java-plugin-runner","version":"0.4.0","releaseDate":"2022-11-11","firstDocPath":"/development"},{"name":"APISIX®
 Go Plugin Runner","nameInParamCase":"go-plugin-runner","description":"Runs 
Apache APISIX plugins written in Go. Implemented as a sidecar that accompanies 
Apache APISI
 
X.","shape":"octagon","color":"#3B14A7","githubRepo":"apache/apisix-go-plugin-runner","version":"0.5.0","releaseDate":"2022-11-10","firstDocPath":"/getting-started"},{"name":"APISIX®
 Python Plugin 
Runner","nameInParamCase":"python-plugin-runner","description":"Runs Apache 
APISIX plugins written in Python. Implemented as a sidecar that accompanies 
Apache 
APISIX.","shape":"shield","color":"#1296DB","githubRepo":"apache/apisix-python-plugin-runner","version":"0.2.0","releaseDate":"2022-03-04","firstDocPath":"/getting-started"}]

Review Comment:
   You can remove all unnecessary content to reduce the size of the file. 樂 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-website] yzeng25 commented on pull request #1471: docs:add four blogs

2023-01-17 Thread GitBox


yzeng25 commented on PR #1471:
URL: https://github.com/apache/apisix-website/pull/1471#issuecomment-1386343155

   Hi @SylviaBABY @SkyeYoung @juzhiyuan , need further review and approvals for 
this pull request.
   
   Review contents can be found at 
https://deploy-preview-1471--apache-apisix.netlify.app/zh/blog/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] github-actions[bot] closed issue #1322: bug: controller will erase status from ingress that uses another class

2023-01-17 Thread GitBox


github-actions[bot] closed issue #1322: bug: controller will erase status from 
ingress that uses another class
URL: https://github.com/apache/apisix-ingress-controller/issues/1322


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] github-actions[bot] commented on issue #1322: bug: controller will erase status from ingress that uses another class

2023-01-17 Thread GitBox


github-actions[bot] commented on issue #1322:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/1322#issuecomment-1386333626

   This issue has been closed due to lack of activity. If you think that is 
incorrect, or the issue requires additional review, you can revive the issue at 
any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] SylviaBABY merged pull request #8701: docs: fix plugin config naming

2023-01-17 Thread GitBox


SylviaBABY merged PR #8701:
URL: https://github.com/apache/apisix/pull/8701


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] SylviaBABY merged pull request #8700: docs: fix code block

2023-01-17 Thread GitBox


SylviaBABY merged PR #8700:
URL: https://github.com/apache/apisix/pull/8700


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-dashboard] cherishman2005 closed issue #2712: error An unexpected error occurred: "https://registry.yarnpkg.com/@ant-design/icons/-/icons-4.6.2.tgz: self signed certificate in certifi

2023-01-17 Thread GitBox


cherishman2005 closed issue #2712: error An unexpected error occurred: 
"https://registry.yarnpkg.com/@ant-design/icons/-/icons-4.6.2.tgz: self signed 
certificate in certificate chain".
URL: https://github.com/apache/apisix-dashboard/issues/2712


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] flechter opened a new issue, #8703: Support plugin opend-id connect in stream proxy route

2023-01-17 Thread GitBox


flechter opened a new issue, #8703:
URL: https://github.com/apache/apisix/issues/8703

   ### Description
   
   We try to use stream proxy, but we would like to add a keycloak autorisation 
for using the route.
   When we try to add the plugin openid-connect we have the error : 
   {"error_msg":"unknown plugin [openid-connect]"}
   do you plan to add this type of plugin in stream proxy route ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] elkh510 commented on issue #8081: help request: access static file by custom nginx.conf but error

2023-01-17 Thread GitBox


elkh510 commented on issue #8081:
URL: https://github.com/apache/apisix/issues/8081#issuecomment-1385522538

   figured
   so in our test environment we have apisix ingress that  point to test 
deployment.
   apisix contains nginx and test deployment contains nginx
   after we added 
[changes](https://github.com/apache/apisix/issues/8081#issuecomment-1276959203) 
to both nginx all start worked as expected


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] wnz27 commented on issue #1568: request help: how to define ApisixPluginConfig and in apisixroute use some other param to overwrite some param

2023-01-17 Thread GitBox


wnz27 commented on issue #1568:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/1568#issuecomment-1385478748

   > > ### Issue description
   > > if i want to 1、define a ApisixPluginConfig use some plugin 2、define a 
apisixRoute and set same plugin in ApisixPluginConfig with some different param 
it‘s can work?
   > > ### Environment
   > > 
   > > * your apisix-ingress-controller version (output of 
apisix-ingress-controller version --long):
   > > * your Kubernetes cluster version (output of kubectl version):
   > > * if you run apisix-ingress-controller in Bare-metal environment, also 
show your OS version (uname -a):
   > 
   > Yes they can. The relationship between them just likes the global rules 
and routes in Apache APISIX.
   
   but it doesn't take effect


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-ingress-controller] wnz27 commented on issue #1568: request help: how to define ApisixPluginConfig and in apisixroute use some other param to overwrite some param

2023-01-17 Thread GitBox


wnz27 commented on issue #1568:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/1568#issuecomment-1385477785

   > You can actually try it out, they have different priorities
   
   i try it, but dont  take effect. the plugin config not auto merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] kellyseeme opened a new issue, #8702: if etcd is down,the apisix not affect service?

2023-01-17 Thread GitBox


kellyseeme opened a new issue, #8702:
URL: https://github.com/apache/apisix/issues/8702

   ### Description
   
   if etcd cluster is down ,the apisix also can handle the requests?just affect 
if the apisix is restart or reload?how much time will be ok if etcd cluster 
down?
   
   ### Environment
   
   - APISIX version (run `apisix version`): 2.15.1
   - Operating system (run `uname -a`):
   - OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
   - etcd version, if relevant (run `curl 
http://127.0.0.1:9090/v1/server_info`):
   - APISIX Dashboard version, if relevant:
   - Plugin runner version, for issues related to plugin runners:
   - LuaRocks version, for installation issues (run `luarocks --version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-docker] sashokbg commented on a diff in pull request #405: fix: config files overwritten by docker-entrypoint.sh

2023-01-17 Thread GitBox


sashokbg commented on code in PR #405:
URL: https://github.com/apache/apisix-docker/pull/405#discussion_r1072157494


##
centos/docker-entrypoint.sh:
##
@@ -22,18 +22,22 @@ PREFIX=${APISIX_PREFIX:=/usr/local/apisix}
 
 if [[ "$1" == "docker-start" ]]; then
 if [ "$APISIX_STAND_ALONE" = "true" ]; then
-cat > ${PREFIX}/conf/config.yaml << _EOC_
+if [ ! -f ${PREFIX}/conf/config.yaml ]; then

Review Comment:
   Or another fix would be to put defaults for these values in the code ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-docker] sashokbg commented on a diff in pull request #405: fix: config files overwritten by docker-entrypoint.sh

2023-01-17 Thread GitBox


sashokbg commented on code in PR #405:
URL: https://github.com/apache/apisix-docker/pull/405#discussion_r1072156896


##
centos/docker-entrypoint.sh:
##
@@ -22,18 +22,22 @@ PREFIX=${APISIX_PREFIX:=/usr/local/apisix}
 
 if [[ "$1" == "docker-start" ]]; then
 if [ "$APISIX_STAND_ALONE" = "true" ]; then
-cat > ${PREFIX}/conf/config.yaml << _EOC_
+if [ ! -f ${PREFIX}/conf/config.yaml ]; then

Review Comment:
   How  about using a gist like this ?
   
   https://gist.github.com/pkuczynski/8665367



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] ronething commented on issue #8680: help request: 是否有文档可以指导实现多环境

2023-01-17 Thread GitBox


ronething commented on issue #8680:
URL: https://github.com/apache/apisix/issues/8680#issuecomment-1385255160

   >   支持  /* 这样的通配符吗?
   
   you can have a try


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] JohnQI8888 commented on issue #8680: help request: 是否有文档可以指导实现多环境

2023-01-17 Thread GitBox


JohnQI commented on issue #8680:
URL: https://github.com/apache/apisix/issues/8680#issuecomment-1385185623

 支持  /* 这样的通配符吗?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix-dashboard] huweihuang opened a new issue, #2716: Support configuring multiple prefixes of etcd for apisix-dashboard

2023-01-17 Thread GitBox


huweihuang opened a new issue, #2716:
URL: https://github.com/apache/apisix-dashboard/issues/2716

   Background:
   Because we have deployed multiple sets of apisix in a k8s cluster and used 
different prefixes to distinguish different apisix services. So I want to 
configure multiple sets of Apisix routes through one apisix dashboard.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #8701: docs: fix plugin config naming

2023-01-17 Thread GitBox


shreemaan-abhishek opened a new pull request, #8701:
URL: https://github.com/apache/apisix/pull/8701

   ### Description
   
   Fixed plugin config naming.
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] github-actions[bot] commented on issue #5879: docs: Mention four features that can be added later

2023-01-17 Thread GitBox


github-actions[bot] commented on issue #5879:
URL: https://github.com/apache/apisix/issues/5879#issuecomment-1385138777

   This issue has been closed due to lack of activity. If you think that is 
incorrect, or the issue requires additional review, you can revive the issue at 
any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] github-actions[bot] closed issue #5879: docs: Mention four features that can be added later

2023-01-17 Thread GitBox


github-actions[bot] closed issue #5879: docs: Mention four features that can be 
added later
URL: https://github.com/apache/apisix/issues/5879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #8700: docs: fix code block

2023-01-17 Thread GitBox


shreemaan-abhishek opened a new pull request, #8700:
URL: https://github.com/apache/apisix/pull/8700

   ### Description
   
   The documentation for plugin config looks like this currently (inappropriate 
code block formatting):
   
   https://user-images.githubusercontent.com/61597896/212868122-c2cfa309-d72a-44ce-8a63-c43d1d2c71cc.png;>
   
   This has been fixed:
   
   https://user-images.githubusercontent.com/61597896/212868450-eb1d258a-4d95-488c-9fb9-b3643a15a50f.png;>
   
   
   Fixes # (issue)
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



<    1   2   3   4   5   6   7   8   9   10   >