Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/97/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/96/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 7:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1910/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1001

to look at the new patch set (#7).

Change subject: Add EXISTS/NOT EXISTS.
..

Add EXISTS/NOT EXISTS.

- Fixed the precedence order of NOT.

Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/exists.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/not_exists.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/constant.ast
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/exists/exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/list/exists/exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/exists/exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/not_exists/not_exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/relational_division/relational_division.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/binary/subbinary/subbinary_01.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/custord/customer_q_04/customer_q_04.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/custord/customer_q_05/customer_q_05.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/list/listify_03/listify_03.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/abs4/abs4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/add_double/add_double.1.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/ceiling4/ceiling4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/floor4/floor4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round-half-to-even24/round-half-to-even24.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round-half-to-even5/round-half-to-even5.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round4/round4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/unary-minus_double_02/unary-minus_double_02.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/unary-minus_float_02/unary-minus_float_02.3.ast
M 

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1001/5/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj:

Line 1844: uexpr.setExprType(exprType);
> It would be nice to throw a ParseException here (hoping that that'll contai
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/96/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1908/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: add error code and string formatting to exception

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: add error code and string formatting to exception
..


add error code and string formatting to exception

Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1000
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 
---
A 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
M 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/rewriting/ErrorReportingTest.java
3 files changed, 108 insertions(+), 4 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
new file mode 100644
index 000..1a883b5
--- /dev/null
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.hyracks.api.exceptions;
+
+public class ErrorCode extends HyracksException {
+public static final int UNKNOWN = 0;
+}
diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
index eaf8df9..73f921f 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
@@ -18,24 +18,76 @@
  */
 package org.apache.hyracks.api.exceptions;
 
+import java.io.Serializable;
+import java.util.Formatter;
+
 public class HyracksDataException extends HyracksException {
 private static final long serialVersionUID = 1L;
 
+public static final String NONE = "";
+public static final String HYRACKS = "HYR";
+
+private final String component;
+private final int errorCode;
+private final Serializable[] params;
 private String nodeId;
 
+private volatile transient String msgCache;
+
 public HyracksDataException() {
+this(NONE, ErrorCode.UNKNOWN, new Object[0]);
 }
 
 public HyracksDataException(String message) {
-super(message);
+this(NONE, ErrorCode.UNKNOWN, message);
 }
 
 public HyracksDataException(Throwable cause) {
-super(cause);
+this(NONE, ErrorCode.UNKNOWN, cause);
 }
 
 public HyracksDataException(String message, Throwable cause) {
+this(NONE, ErrorCode.UNKNOWN, message, cause);
+}
+
+public HyracksDataException(String component, int errorCode, 
Serializable... params) {
+this.component = component;
+this.errorCode = errorCode;
+this.params = params;
+}
+
+public HyracksDataException(String component, int errorCode, String 
message, Serializable... params) {
+super(message);
+this.component = component;
+this.errorCode = errorCode;
+this.params = params;
+}
+
+public HyracksDataException(String component, int errorCode, Throwable 
cause, Serializable... params) {
+super(cause);
+this.component = component;
+this.errorCode = errorCode;
+this.params = params;
+}
+
+public HyracksDataException(String component, int errorCode, String 
message, Throwable cause,
+Serializable... params) {
 super(message, cause);
+this.component = component;
+this.errorCode = errorCode;
+this.params = params;
+}
+
+public String 

Change in asterixdb[master]: add error code and string formatting to exception

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: add error code and string formatting to exception
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/999/4/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/TuplePointer.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/TuplePointer.java:

Line 21: public class TuplePointer implements IResetable {
> The tuple pointer has a reset method to change the pointer.
But that does not keep us from making the class final, right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1907/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Preston Carman (Code Review)]

Preston Carman has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 4:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/999/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java:

Line 76: throws AsterixException {
> As these are runtime exceptions, could we make them HyracksDataExceptions?
Done


https://asterix-gerrit.ics.uci.edu/#/c/999/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java:

Line 38: public boolean validateInterval(AIntervalPointable ip1) throws 
AsterixException {
> HyracksDataException?
Done. A little bit of a rabbit hole.


https://asterix-gerrit.ics.uci.edu/#/c/999/4/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/TuplePointer.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/TuplePointer.java:

Line 21: public class TuplePointer implements IResetable {
> Make TuplePointer final, so we can inline the getters?
The tuple pointer has a reset method to change the pointer.


Line 48: public boolean equals(Object o) {
> How about this:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Preston Carman (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/999

to look at the new patch set (#5).

Change subject: Sonar fixes and other clean up items.
..

Sonar fixes and other clean up items.

Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/SkipSecondaryIndexSearchExpressionAnnotation.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AIntervalPointable.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/AIntervalTypeComputer.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/AbstractComparisonEvaluator.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AIntervalConstructorDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/GetOverlappingIntervalDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalAfterDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalBeforeDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalCoveredByDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalCoversDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalEndedByDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalEndsDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalMeetsDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalMetByDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalOverlappedByDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalOverlapsDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalStartedByDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalStartsDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/OverlapDescriptor.java
A 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/AbstractExpressionAnnotation.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ExpressionAnnotationNoCopyImpl.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/IndexedNLJoinExpressionAnnotation.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/ReplicateOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractExchangePOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/BroadcastExchangePOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/OneToOneExchangePOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/RandomMergeExchangePOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/ReplicatePOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/UnionAllPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/IPartitioningProperty.java
M 

Change in asterixdb[master]: TweetParser Extension

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1002

to look at the new patch set (#4).

Change subject: TweetParser Extension
..

TweetParser Extension

This patch includes following changes:

1. ExtendedTweetParser to parse more than fix attributes.

2. Changed the twitter feeds message unit from Status to String.

3. Fixed bug ASTERIXDB-1471.

4. Fixed bug ASTERIXDB-1352.

Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java
M 
asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AOrderedListType.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java
12 files changed, 407 insertions(+), 150 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/02/1002/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1002
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Index-only plan

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 11:

Addressed Till's comments.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/999/4/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/TuplePointer.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/TuplePointer.java:

Line 48: public boolean equals(Object o) {
How about this:

public boolean equals(Object o) {
if (this == o) {
return true;
} else if (o == null || getClass() != o.getClass()) {
return false;
} else {
final TuplePointer that = (TuplePointer) o;
return frameIndex == that.frameIndex && tupleIndex == 
that.tupleIndex;
}
}


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fulltext search initial implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fulltext search initial implementation
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/989
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Fulltext search initial implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fulltext search initial implementation
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1905/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/989
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 4:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/999/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java:

Line 76: throws AsterixException {
As these are runtime exceptions, could we make them HyracksDataExceptions?


https://asterix-gerrit.ics.uci.edu/#/c/999/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java:

Line 38: public boolean validateInterval(AIntervalPointable ip1) throws 
AsterixException {
HyracksDataException?


https://asterix-gerrit.ics.uci.edu/#/c/999/4/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/TuplePointer.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/TuplePointer.java:

Line 21: public class TuplePointer implements IResetable {
Make TuplePointer final, so we can inline the getters?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

[jira] [Assigned] (ASTERIXDB-1459) Debugging support for code that's generated ...

[Yingyi Bu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu reassigned ASTERIXDB-1459:


Assignee: Michael Blow  (was: Yingyi Bu)

> Debugging support for code that's generated ...
> ---
>
> Key: ASTERIXDB-1459
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1459
> Project: Apache AsterixDB
>  Issue Type: Task
>  Components: AsterixDB
>Reporter: Till Westmann
>Assignee: Michael Blow
>
> ... or hidden behind generated code. Currently we generate some byte code to 
> avoid repetitive implementation of some language features. The disadvantage 
> of this approach is that the generated byte code (and code that's called from 
> the generated byte code) is difficult to debug. 
> We need to find a way to debug such code (e.g. by generating Java code that 
> could be picked up by a debugger?).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: TweetParser Extension

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: TweetParser Extension
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1904/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1002
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: TweetParser Extension

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1002

to look at the new patch set (#3).

Change subject: TweetParser Extension
..

TweetParser Extension

This patch includes following changes:

1. ExtendedTweetParser to parse more than fix attributes.

2. Changed the twitter feeds message unit from Status to String.

3. Fixed bug ASTERIXDB-1471.

4. Fixed bug ASTERIXDB-1352.

Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java
M 
asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AOrderedListType.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java
12 files changed, 407 insertions(+), 149 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/02/1002/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1002
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: add error code and string formatting to exception

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: add error code and string formatting to exception
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/93/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: TweetParser extension

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: TweetParser extension
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1903/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1002
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: This patch includes following changes:

[Xikui Wang (Code Review)]

Xikui Wang has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1002

Change subject: This patch includes following changes:
..

This patch includes following changes:

1. ExtendedTweetParser to parse more than fix attributes.

2. Changed the twitter feeds message unit from Status to String.

3. Fixed bug ASTERIXDB-1471.

4. Fixed bug ASTERIXDB-1352.

Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java
M 
asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AOrderedListType.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java
12 files changed, 408 insertions(+), 149 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/02/1002/1

diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
index e31325a..80e716d 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
@@ -28,13 +28,9 @@
 import org.apache.asterix.external.util.FeedLogManager;
 import org.apache.hyracks.api.exceptions.HyracksDataException;
 
-import twitter4j.Query;
-import twitter4j.QueryResult;
-import twitter4j.Status;
-import twitter4j.Twitter;
-import twitter4j.TwitterException;
+import twitter4j.*;
 
-public class TwitterPullRecordReader implements IRecordReader {
+public class TwitterPullRecordReader implements IRecordReader {
 
 private Query query;
 private Twitter twitter;
@@ -42,14 +38,14 @@
 private QueryResult result;
 private int nextTweetIndex = 0;
 private long lastTweetIdReceived = 0;
-private GenericRecord record;
+private GenericRecord record;
 
 public TwitterPullRecordReader(Twitter twitter, String keywords, int 
requestInterval) {
 this.twitter = twitter;
 this.requestInterval = requestInterval;
 this.query = new Query(keywords);
 this.query.setCount(100);
-this.record = new GenericRecord();
+this.record = new GenericRecord<>();
 }
 
 @Override
@@ -62,7 +58,7 @@
 }
 
 @Override
-public IRawRecord next() throws IOException, InterruptedException {
+public IRawRecord next() throws IOException, InterruptedException {
 if (result == null || nextTweetIndex >= result.getTweets().size()) {
 Thread.sleep(1000 * requestInterval);
 query.setSinceId(lastTweetIdReceived);
@@ -79,7 +75,8 @@
 if (lastTweetIdReceived < tweet.getId()) {
 lastTweetIdReceived = tweet.getId();
 }
-record.set(tweet);
+String jsonTweet = TwitterObjectFactory.getRawJSON(tweet); // 
transform tweet obj to json
+record.set(jsonTweet);
 return record;
 } else {
 return null;
diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
index f04cdb9..02c3963 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
@@ -27,30 +27,25 @@
 import 

Change in asterixdb[master]: Fulltext search initial implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fulltext search initial implementation
..


Patch Set 5: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/94/ : 
FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/989
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Fulltext search initial implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fulltext search initial implementation
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/94/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/989
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1496) Having an ability to put nullable field information when creating an enforced index

[Michael J. Carey (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380149#comment-15380149
 ] 

Michael J. Carey commented on ASTERIXDB-1496:
-

Maybe since Abdullah was in this vicinity (sort of) he could do this?

> Having an ability to put nullable field information when creating an enforced 
> index
> ---
>
> Key: ASTERIXDB-1496
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1496
> Project: Apache AsterixDB
>  Issue Type: Improvement
>Reporter: Taewoo Kim
>Assignee: Abdullah Alamoudi
>
> It would be nice if we have an ability to put nullable field ("?") 
> information when creating an enforced type index to indicate whether the 
> field is nullable or not.
> The current syntax
> create index fbSendTimeIdx on FacebookMessages(send-time:datetime) type btree 
> enforced;
> The proposed syntax(nullable field)
> create index fbSendTimeIdx on FacebookMessages(send-time:datetime?) type 
> btree enforced;
> or 
> (non-nullable field)
> create index fbSendTimeIdx on FacebookMessages(send-time:datetime) type btree 
> enforced;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1496) Having an ability to put nullable field information when creating an enforced index

[Michael J. Carey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael J. Carey updated ASTERIXDB-1496:

Assignee: Abdullah Alamoudi

> Having an ability to put nullable field information when creating an enforced 
> index
> ---
>
> Key: ASTERIXDB-1496
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1496
> Project: Apache AsterixDB
>  Issue Type: Improvement
>Reporter: Taewoo Kim
>Assignee: Abdullah Alamoudi
>
> It would be nice if we have an ability to put nullable field ("?") 
> information when creating an enforced type index to indicate whether the 
> field is nullable or not.
> The current syntax
> create index fbSendTimeIdx on FacebookMessages(send-time:datetime) type btree 
> enforced;
> The proposed syntax(nullable field)
> create index fbSendTimeIdx on FacebookMessages(send-time:datetime?) type 
> btree enforced;
> or 
> (non-nullable field)
> create index fbSendTimeIdx on FacebookMessages(send-time:datetime) type btree 
> enforced;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Fulltext search initial implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fulltext search initial implementation
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1902/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/989
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Fulltext search initial implementation

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fulltext search initial implementation
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/989
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: add error code and string formatting to exception

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: add error code and string formatting to exception
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/93/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Fulltext search initial implementation

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Fulltext search initial implementation
..


Patch Set 4:

(4 comments)

Thanks for the comments.

https://asterix-gerrit.ics.uci.edu/#/c/989/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:

Line 1349: return k == Kind.LITERAL_EXPRESSION || k == 
Kind.LIST_CONSTRUCTOR_EXPRESSION
> I would replace all of this with a switch which returns true for all these 
Done


https://asterix-gerrit.ics.uci.edu/#/c/989/4/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/OperatorExpr.java
File 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/OperatorExpr.java:

Line 88: boolean cmp = t == OperatorType.EQ || t == OperatorType.NEQ || 
t == OperatorType.GT;
> I would replace this with an enum switch.
Done


https://asterix-gerrit.ics.uci.edu/#/c/989/4/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/string/UTF8StringUtil.java
File 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/string/UTF8StringUtil.java:

Line 382: if (lengthByteIncluded) {
> The decision if the length byte is included is taken in the calling code an
Done


Line 428: if (lengthByteIncluded) {
> see above
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/989
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

[jira] [Created] (ASTERIXDB-1532) Need friendlier error msg(s) for open index errors

[Michael J. Carey (JIRA)]

Michael J. Carey created ASTERIXDB-1532:
---

 Summary: Need friendlier error msg(s) for open index errors
 Key: ASTERIXDB-1532
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1532
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: AsterixDB, Error Reporting, Translator - AQL
 Environment: Very recent binary bits from Apache AsterixDB site
Reporter: Michael J. Carey
Priority: Minor


RUN THESE COMMANDS:

drop dataverse TinySocial if exists;
create dataverse TinySocial;
use dataverse TinySocial;
create type ChirpUserType as { screenName: string }
create type ChirpMessageType as closed { chirpId: string }
create type GleambookUserType as { id: int64 }
create type GleambookMessageType as { messageId: int64 }

create dataset GleambookUsers(GleambookUserType) primary key id;
create dataset GleambookMessages(GleambookMessageType) primary key messageId;
create dataset ChirpUsers(ChirpUserType) primary key screenName;
create dataset ChirpMessages(ChirpMessageType) primary key chirpId;

create index gbUserSinceIdx on GleambookUsers(userSince:datetime) enforced;
create index gbAuthorIdx on GleambookMessages(authorId:int64) type btree 
enforced;
create index gbSenderLocIndex on GleambookMessages(senderLocation:point) type 
rtree enforced;
create index gbMessageIdx on GleambookMessages(message) type keyword enforced;

AND YOU'LL GET THIS RESULT:

Unknown type [message] [AlgebricksException]

AND IN MY OPINION:

While 100% accurate, it's really terse - it would be nicer to give an error 
message such as the following.  (The same will be true for other things that 
might pop as errors in Algebricks.)

The data type for indexed field "message" was not specified but is required 
when specifying an index on a field not included in the dataset schema.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/92/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: add error code and string formatting to exception

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: add error code and string formatting to exception
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1901/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: add error code and string formatting to exception

[Till Westmann (Code Review)]

Hello Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1000

to look at the new patch set (#6).

Change subject: add error code and string formatting to exception
..

add error code and string formatting to exception

Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
---
A 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
M 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/rewriting/ErrorReportingTest.java
3 files changed, 108 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/00/1000/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/91/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/91/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1001

to look at the new patch set (#5).

Change subject: Add EXISTS/NOT EXISTS.
..

Add EXISTS/NOT EXISTS.

- Fixed the precedence order of NOT.

Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/exists.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/not_exists.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/constant.ast
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/exists/exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/list/exists/exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/exists/exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/not_exists/not_exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/relational_division/relational_division.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/binary/subbinary/subbinary_01.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/custord/customer_q_04/customer_q_04.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/custord/customer_q_05/customer_q_05.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/list/listify_03/listify_03.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/abs4/abs4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/add_double/add_double.1.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/ceiling4/ceiling4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/floor4/floor4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round-half-to-even24/round-half-to-even24.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round-half-to-even5/round-half-to-even5.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round4/round4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/unary-minus_double_02/unary-minus_double_02.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/unary-minus_float_02/unary-minus_float_02.3.ast
M 

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1900/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1899/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1001

to look at the new patch set (#3).

Change subject: Add EXISTS/NOT EXISTS.
..

Add EXISTS/NOT EXISTS.

Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/exists.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/not_exists.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/constant.ast
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/exists/exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/list/exists/exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/exists/exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/not_exists/not_exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/relational_division/relational_division.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/binary/subbinary/subbinary_01.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/custord/customer_q_04/customer_q_04.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/custord/customer_q_05/customer_q_05.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/list/listify_03/listify_03.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/abs4/abs4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/add_double/add_double.1.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/ceiling4/ceiling4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/floor4/floor4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round-half-to-even24/round-half-to-even24.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round-half-to-even5/round-half-to-even5.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round4/round4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/unary-minus_double_02/unary-minus_double_02.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/unary-minus_float_02/unary-minus_float_02.3.ast
M 

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1897/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1898/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: add error code and string formatting to exception

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: add error code and string formatting to exception
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1000/5/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java:

Line 104: msgCache = formatMessage(component, errorCode, 
super.getMessage(), params);
If multiple threads access getMessage() for a particular exception instance, 
could one get a message that is not fully constructed?  i.e. should msgCache be 
volatile?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1001

to look at the new patch set (#2).

Change subject: Add EXISTS/NOT EXISTS.
..

Add EXISTS/NOT EXISTS.

Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/exists.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/not_exists.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/constant.ast
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/exists/exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/exists/exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/not_exists/not_exists.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division/relational_division.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division2/relational_division2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/relational_division3/relational_division3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/list/exists/exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/exists/exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/not_exists/not_exists.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/relational_division/relational_division.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/binary/subbinary/subbinary_01.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/custord/customer_q_04/customer_q_04.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/custord/customer_q_05/customer_q_05.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/list/listify_03/listify_03.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/abs4/abs4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/add_double/add_double.1.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/ceiling4/ceiling4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/floor4/floor4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round-half-to-even24/round-half-to-even24.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round-half-to-even5/round-half-to-even5.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/round4/round4.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/unary-minus_double_02/unary-minus_double_02.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/numeric/unary-minus_float_02/unary-minus_float_02.3.ast
M 

[jira] [Assigned] (ASTERIXDB-1487) Fuzzy select-join on inverted index poses inconsistent results.

[Wenhai (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wenhai reassigned ASTERIXDB-1487:
-

Assignee: Wenhai

> Fuzzy select-join on inverted index poses inconsistent results.
> ---
>
> Key: ASTERIXDB-1487
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1487
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB
> Environment: MAC 4 cores, 8GB memory. The current master till 
> 3/17/2016.
>Reporter: Wenhai
>Assignee: Wenhai
>Priority: Critical
> Attachments: csx-small-multi-id.txt, dblp-small-multi-id.txt
>
>
> As shown in below. After we switching the two "for" branches of the fuzzy 
> join over a select, the results are consistent.
> Schema
> {noformat}
> drop dataverse test if exists;
> create dataverse test;
> use dataverse test;
> create type DBLPNestedType as closed {
>   id: int64,
>   dblpid: string,
>   title: string,
>   authors: string,
>   misc: string
> }
> create type DBLPType as closed {
>   nested: DBLPNestedType
> }
> create type CSXNestedType as closed {
>   id: int64,
>   csxid: string,
>   title: string,
>   authors: string,
>   misc: string
> }
> create type CSXType as closed {
>   nested: CSXNestedType
> }
> create dataset DBLPtmp(DBLPNestedType) primary key id;
> create dataset CSXtmp(CSXNestedType) primary key id;
> create dataset DBLP(DBLPType) primary key nested.id;
> create dataset CSX(CSXType) primary key nested.id;
> use dataverse test;
> load dataset DBLPtmp
> using localfs
> (("path"="asterix_nc1://data/dblp-small/dblp-small-multi-id.txt"),("format"="delimited-text"),("delimiter"=":"),("quote"="\u"))
>  pre-sorted;
> load dataset CSXtmp
> using localfs
> (("path"="asterix_nc1://data/pub-small/csx-small-multi-id.txt"),("format"="delimited-text"),("delimiter"=":"),("quote"="\u"));
> insert into dataset DBLP(
> for $x in dataset DBLPtmp
> return {
> "nested": $x
> }
> );
> insert into dataset CSX(
> for $x in dataset CSXtmp
> return {
> "nested": $x
> }
> );
> {noformat}
> Indexes
> {noformat}
> create index keyword_index on DBLP(nested.title) type keyword; 
> create index keyword_indexdbauhors on DBLP(nested.authors) type keyword;
> create index keyword_indexcsxauthors on CSX(nested.authors) type keyword;
> {noformat}
> The following query
> {noformat}
> use dataverse test;
> set simthresholds '.1'
> let $s := count(
> for $o in dataset DBLP
> for $t in dataset CSX
> where contains($o.nested.title, "System") and word-tokens($o.nested.authors) 
> ~= word-tokens($t.nested.authors)
> return $o
> )
> return $s
> {noformat}
> will return 28, while the query
> {noformat}
> use dataverse test;
> set simthresholds '.1'
> let $s := count(
> for $t in dataset CSX
> for $o in dataset DBLP
> where contains($o.nested.title, "System") and word-tokens($o.nested.authors) 
> ~= word-tokens($t.nested.authors)
> return $o
> )
> return $s
> {noformat}
> will return 3 or pose a error in a big dataset.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/90/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Sonar fixes and other clean up items.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1896/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Refactor General Active Classes

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Refactor General Active Classes
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/89/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/977
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8f33ee5b45c5e090b08c24a102e369aae43c04
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Refactor General Active Classes

[abdullah alamoudi (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/977

to look at the new patch set (#3).

Change subject: Refactor General Active Classes
..

Refactor General Active Classes

This change is the first of a series of changes aiming to refactor
feed related classes into generic active and feed specific.
In this change, we introduce asterix-active which will be one level
below asterix-external-data. The ultimate goal is to have a very
flexible framewrok for long running activities within asterix.

Change-Id: I0a8f33ee5b45c5e090b08c24a102e369aae43c04
---
A asterixdb/asterix-active/pom.xml
A 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveEvent.java
A 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveJob.java
A 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveJobNotificationHandler.java
A 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java
R 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActivePartitionMessage.java
R 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveRuntime.java
A 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveRuntimeId.java
A 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveRuntimeManager.java
A 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveRuntimeRegistry.java
A asterixdb/asterix-active/src/main/java/org/apache/asterix/active/Activity.java
C 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActivityState.java
R 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ConcurrentFramePool.java
A asterixdb/asterix-active/src/main/java/org/apache/asterix/active/EntityId.java
R 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/FrameAction.java
C 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java
R 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveMessage.java
C 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveRuntime.java
A 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveRuntimeRegistry.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/AQLAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/DDLAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/UpdateAPIServlet.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ActiveLifecycleListener.java
D 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedJoint.java
D 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/IApplicationMessage.java
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/FeedOperationCounter.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IFeed.java
D 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IFeedConnectionManager.java
M 

Change in asterixdb[master]: Refactor General Active Classes

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Refactor General Active Classes
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1895/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/977
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8f33ee5b45c5e090b08c24a102e369aae43c04
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/88/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/88/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: add error code and string formatting to exception

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: add error code and string formatting to exception
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add EXISTS/NOT EXISTS.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add EXISTS/NOT EXISTS.
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1894/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1001
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec20753659e2de2fd65e5f858e0f73796b907d0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: add error code and string formatting to exception

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: add error code and string formatting to exception
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/87/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1531) Order by bug for composite order keys and nested fields

[Yingyi Bu (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378960#comment-15378960
 ] 

Yingyi Bu commented on ASTERIXDB-1531:
--

Got it.  I can reproduce that now.  It is a bug in data property handling -- 
the optimizer thinks the data is ordered by chirpId and thus it doesn't need to 
sort again.

Here is the optimized plan:

{noformat}
distribute result [%0->$$0]
-- DISTRIBUTE_RESULT  |PARTITIONED|
  exchange 
  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
project ([$$0])
-- STREAM_PROJECT  |PARTITIONED|
  exchange 
  -- SORT_MERGE_EXCHANGE [$$5(ASC) ]  |PARTITIONED|
project ([$$0, $$5])
-- STREAM_PROJECT  |PARTITIONED|
  assign [$$6] <- [function-call: asterix:field-access-by-name, 
Args:[function-call: asterix:field-access-by-name, Args:[%0->$$0, AString: 
{user}], AString: {screenName}]]
  -- ASSIGN  |PARTITIONED|
exchange 
-- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
  data-scan []<-[$$5, $$0] <- test:ChirpMessages
  -- DATASOURCE_SCAN  |PARTITIONED|
exchange 
-- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
  empty-tuple-source
  -- EMPTY_TUPLE_SOURCE  |PARTITIONED|
{noformat}

> Order by bug for composite order keys and nested fields
> ---
>
> Key: ASTERIXDB-1531
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1531
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Translator - AQL
> Environment: 101-like demo (modified TinySocial) on current/latest 
> binary bits for Mac
>Reporter: Michael J. Carey
>Assignee: Yingyi Bu
> Attachments: tinysocialnew.zip
>
>
> use dataverse TinySocial;  // okay, a name-modified version thereof
> from $cm in dataset ChirpMessages
> order by $cm.user.screen-name, $cm.chirpid
> select $cm;
> ---> This just orders by chirpid.  (You can repro by doing the same thing 
> with the current TinySocial data using the non-renamed stuff - so I won't 
> attach all the repro stuff here unless you want me too, in which case I can.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: add error code and string formatting to exception

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: add error code and string formatting to exception
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/87/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: add error code and string formatting to exception

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: add error code and string formatting to exception
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1893/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: add error code and string formatting to exception

[Till Westmann (Code Review)]

Hello Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1000

to look at the new patch set (#5).

Change subject: add error code and string formatting to exception
..

add error code and string formatting to exception

Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
---
A 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
M 
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/rewriting/ErrorReportingTest.java
3 files changed, 108 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/00/1000/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 

[jira] [Commented] (ASTERIXDB-1531) Order by bug for composite order keys and nested fields

[Michael J. Carey (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378900#comment-15378900
 ] 

Michael J. Carey commented on ASTERIXDB-1531:
-

Sorry, my repro dataset was different than the filed query bug's state of the 
world.
Here's a buggy query (I think) that shows the problem (if I'm not mistaken) on 
the attached data.
Note that I also retrieve the field values so you can see it's not a missing 
info problem.

use dataverse TinySocial;
from $cm in dataset ChirpMessages
order by $cm.user.screenName, $cm.chirpId
select {"name":$cm.user.screenName, "id":$cm.chirpId};


> Order by bug for composite order keys and nested fields
> ---
>
> Key: ASTERIXDB-1531
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1531
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Translator - AQL
> Environment: 101-like demo (modified TinySocial) on current/latest 
> binary bits for Mac
>Reporter: Michael J. Carey
>Assignee: Yingyi Bu
> Attachments: tinysocialnew.zip
>
>
> use dataverse TinySocial;  // okay, a name-modified version thereof
> from $cm in dataset ChirpMessages
> order by $cm.user.screen-name, $cm.chirpid
> select $cm;
> ---> This just orders by chirpid.  (You can repro by doing the same thing 
> with the current TinySocial data using the non-renamed stuff - so I won't 
> attach all the repro stuff here unless you want me too, in which case I can.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)