Change in asterixdb[master]: Improve Test Classes
Jenkins has posted comments on this change. Change subject: Improve Test Classes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2374/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1112 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0672ae13b9afce7965e651b543b0799e5ed84d06 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Improve Test Classes
abdullah alamoudi has uploaded a new patch set (#2). Change subject: Improve Test Classes .. Improve Test Classes This change enables ExecutionTestUtil to handle different IntegrationUtil implementations. In addition, it enables mutation of fields of SelectRuntimeFactory. Change-Id: I0672ae13b9afce7965e651b543b0799e5ed84d06 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java M asterixdb/asterix-external-data/pom.xml M asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryBooleanInspectorImpl.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SelectOperator.java M hyracks-fullstack/algebricks/algebricks-data/src/main/java/org/apache/hyracks/algebricks/data/impl/BinaryBooleanInspectorImpl.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/StreamSelectRuntimeFactory.java 8 files changed, 43 insertions(+), 26 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/12/1112/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1112 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0672ae13b9afce7965e651b543b0799e5ed84d06 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: Improve Test Classes
Jenkins has posted comments on this change. Change subject: Improve Test Classes .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1112 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0672ae13b9afce7965e651b543b0799e5ed84d06 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Improve Test Classes
Jenkins has posted comments on this change. Change subject: Improve Test Classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2373/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1112 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0672ae13b9afce7965e651b543b0799e5ed84d06 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Improve Test Classes
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1112
Change subject: Improve Test Classes
..
Improve Test Classes
This change enables ExecutionTestUtil to handle different
IntegrationUtil implementations. In addition, it enables mutation
of fields of SelectRuntimeFactory.
Change-Id: I0672ae13b9afce7965e651b543b0799e5ed84d06
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
M asterixdb/asterix-external-data/pom.xml
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryBooleanInspectorImpl.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SelectOperator.java
M
hyracks-fullstack/algebricks/algebricks-data/src/main/java/org/apache/hyracks/algebricks/data/impl/BinaryBooleanInspectorImpl.java
M
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/StreamSelectRuntimeFactory.java
8 files changed, 43 insertions(+), 25 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/12/1112/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
index 03ed3c4..7cc6ec9 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
@@ -83,6 +83,7 @@
}
};
ncStartThread.start();
+ncStartThread.join();
}
hcc = new HyracksConnection(cc.getConfig().clientNetIpAddress,
cc.getConfig().clientNetPort);
ncs = nodeControllers.toArray(new
NodeControllerService[nodeControllers.size()]);
@@ -217,15 +218,16 @@
*/
public static void main(String[] args) {
AsterixHyracksIntegrationUtil integrationUtil = new
AsterixHyracksIntegrationUtil();
-run(integrationUtil);
+run(integrationUtil, false, false);
}
-protected static void run(final AsterixHyracksIntegrationUtil
integrationUtil) {
+protected static void run(final AsterixHyracksIntegrationUtil
integrationUtil, boolean cleanupOnStart,
+boolean cleanupOnShutdow) {
Runtime.getRuntime().addShutdownHook(new Thread() {
@Override
public void run() {
try {
-integrationUtil.deinit(false);
+integrationUtil.deinit(cleanupOnShutdow);
} catch (Exception e) {
e.printStackTrace();
}
@@ -234,7 +236,7 @@
try {
System.setProperty(GlobalConfig.CONFIG_FILE_PROPERTY,
"asterix-build-configuration.xml");
-integrationUtil.init(false);
+integrationUtil.init(cleanupOnStart);
while (true) {
Thread.sleep(1);
}
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
index 3195c39..c73be7a 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
@@ -44,15 +44,16 @@
protected static final String TEST_CONFIG_FILE_NAME =
"asterix-build-configuration.xml";
-protected static TestGroup FailedGroup;
+public static TestGroup FailedGroup;
public static AsterixHyracksIntegrationUtil integrationUtil = new
AsterixHyracksIntegrationUtil();
public static List setUp(boolean cleanup) throws
Exception {
-return setUp(cleanup, TEST_CONFIG_FILE_NAME);
+return setUp(cleanup, TEST_CONFIG_FILE_NAME, integrationUtil, true);
}
-public static List setUp(boolean cleanup, String
configFile) throws Exception {
+public static List setUp(boolean cleanup, String
configFile,
+AsterixHyracksIntegrationUtil integrationUtil, boolean startHdfs)
throws Exception {
System.out.println("Starting setup");
if (LOGGER.isLoggable(Level.INFO)) {
LOGGER.info("Starting setup");
@@ -68,7 +69,9 @@
LOGGER.info("initializing HDFS");
}
-HDFSCluster.getInstance().setup();
+if (startHdfs) {
+HDFSCluster.getInstance().setup();
+}
Change in asterixdb[master]: Fixes related to ASTERIXDB-1534
Jenkins has posted comments on this change. Change subject: Fixes related to ASTERIXDB-1534 .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/441/ -- To view, visit https://asterix-gerrit.ics.uci.edu/ To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If51e0cd183f9d5ed6edaebef4a0568a6c67062e3 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Jenkins has posted comments on this change. Change subject: some WebUI hackery .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/442/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Misc Cleanup, SonarQube Fixes
Jenkins has posted comments on this change. Change subject: Misc Cleanup, SonarQube Fixes .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1108 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If87126cdd435067a50087e339522a36021fbc2c0 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add several builtin functions.
Yingyi Bu has posted comments on this change.
Change subject: Add several builtin functions.
..
Patch Set 11:
(11 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-like/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-like/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp:
Line 29: where ((p.p_partkey = l.l_partkey) and (((p.p_brand = 'Brand#12')
and tpch.regexp_contains(p.p_container,'SM CASE||SM BOX||SM PACK||SM PKG') and
(l.l_quantity >= 1) and (l.l_quantity <= 11) and (p.p_size >= 1) and (p.p_size
<= 5) and tpch.regexp_contains(l.l_shipmode,'AIR||AIR REG') and
(l.l_shipinstruct = 'DELIVER IN PERSON')) or ((p.p_brand = 'Brand#23') and
tpch.regexp_contains(p.p_container,'MED BAG||MED BOX||MED PKG||MED PACK') and
(l.l_quantity >= 10) and (l.l_quantity <= 20) and (p.p_size >= 1) and (p.p_size
<= 10) and tpch.regexp_contains(l.l_shipmode,'AIR||AIR REG') and
(l.l_shipinstruct = 'DELIVER IN PERSON')) or ((p.p_brand = 'Brand#34') and
tpch.regexp_contains(p.p_container,'LG CASE||LG BOX||LG PACK||LG PKG') and
(l.l_quantity >= 20) and (l.l_quantity <= 30) and (p.p_size >= 1) and (p.p_size
<= 15) and tpch.regexp_contains(l.l_shipmode,'AIR||AIR REG') and
(l.l_shipinstruct = 'DELIVER IN PERSON'
> Can we/should we remove the dataverse from these function names?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppBuiltinFunctionRewriteVisitor.java
File
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppBuiltinFunctionRewriteVisitor.java:
Line 21: import static
org.apache.asterix.lang.sqlpp.util.FunctionMapUtil.normalizedListInputFunctions;
> revert this file?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppListInputFunctionRewriteVisitor.java
File
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppListInputFunctionRewriteVisitor.java:
Line 33: * This visitor rewrites severael variable-arg user-facing functions
to their coressponding
> s/severael/several/
Done
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractBinaryStringStringEval.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractBinaryStringStringEval.java:
Line 69: private void writeResult(IPointable resultPointable) throws
AlgebricksException {
> We could pull this up one level (if we had one level more) - not sure if th
The method is only for outputting strings, and uses the fields resultStrPtr
defined in this class.
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractUnaryStringStringEval.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractUnaryStringStringEval.java:
Line 87: throws AlgebricksException;
> If this would be allowed to throw IOException as well, then we could handle
Done
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringTrim2Descriptor.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringTrim2Descriptor.java:
Line 59: private StringTrimer stringTrimer = new
StringTrimer(resultBuilder, resultArray);
> s/stringTrimer/stringTrimmer/ ?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringTrimDescriptor.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringTrimDescriptor.java:
Line 59: private StringTrimer stringTrimer = new
StringTrimer(resultBuilder, resultArray, " ");
> s/stringTrimer/stringTrimmer/ ?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/utils/RegExpMatcher.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/utils/RegExpMatcher.java:
Line 56: private final StringBuffer resultBuf = new StringBuffer();
> That's indeed a good point.
Matcher.appendReplacement requires a StringBuffer.
Line 118: patternGenerator == null ? inputPatternString
: patternGenerator
> Pull the conditional expression out of the then and the else branch?
Done
https://asterix-gerrit.ics.uci.edu/#/c/11
Change in asterixdb[master]: Enable ExecutionTestUtil to Handle Different IntegrationUtil...
Michael Blow has posted comments on this change. Change subject: Enable ExecutionTestUtil to Handle Different IntegrationUtil Implementations .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34ed919b39789c2254d63961c1628dd7b60f5ff2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Misc Cleanup, SonarQube Fixes
Jenkins has posted comments on this change. Change subject: Misc Cleanup, SonarQube Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2372/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1108 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If87126cdd435067a50087e339522a36021fbc2c0 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Misc Cleanup, SonarQube Fixes
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1108 to look at the new patch set (#2). Change subject: Misc Cleanup, SonarQube Fixes .. Misc Cleanup, SonarQube Fixes Change-Id: If87126cdd435067a50087e339522a36021fbc2c0 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java M asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/FuzzyJoinMemory.java M asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/recordgroup/RecordGroupLengthCount.java M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/struct/OperatorType.java M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/struct/UnaryExprType.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADouble.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AFloat.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractComplexType.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/BuiltinType.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicaStateChecker.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java 12 files changed, 67 insertions(+), 71 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/08/1108/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1108 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If87126cdd435067a50087e339522a36021fbc2c0 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: Add several builtin functions.
Jenkins has posted comments on this change. Change subject: Add several builtin functions. .. Patch Set 12: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1104 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Add several builtin functions.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1104 to look at the new patch set (#12). Change subject: Add several builtin functions. .. Add several builtin functions. - add functions such as greatest, least, concat(||), initcap(title), regexp_contains, regexp_like, regexp_position, regexp_replace, ltrim, trim, rtrim, position; - refactor string functions; - remove undocumented function "regexp", which is equivalent to "matches"; - remove AQL.html and SQLPP.html since they are generated in "target/". Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java M asterixdb/asterix-app/src/test/resources/runtimets/queries/tpch-sql-like/q19_discounted_revenue/q19_discounted_revenue.3.query.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/tpch/q19_discounted_revenue/q19_discounted_revenue.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/greatest_mixed/greatest_mixed.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/least_mixed/least_mixed.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/concat_func/concat_func.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/concat_pipe/concat_pipe.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/concat_pipe_multi/concat_pipe_multi.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/initcap/initcap.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/ltrim/ltrim.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/position/position.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_contains/regexp_contains.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_contains_with_flag/regexp_contains.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_like/regexp_like.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_like_with_flag/regexp_like_with_flag.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_position/regexp_position.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_position_with_flag/regexp_position_with_flag.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_replace/regexp_replace.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/rtrim/rtrim.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/title/title.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/trim/trim.1.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-like/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-with-index/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/greatest_mixed/greatest_mixed.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/least_mixed/least_mixed.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/concat_pipe_multi/concat_pipe_multi.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/initcap/initcap.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/ltrim/ltrim.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_like/regexp_like.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/rtrim/rtrim.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/trim/trim.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/re
Change in asterixdb[master]: Add several builtin functions.
Jenkins has posted comments on this change. Change subject: Add several builtin functions. .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2371/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1104 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
Michael Blow has submitted this change and it was merged.
Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
..
Avoid NPE in AsterixHyracksIntegrationUtil.deinit
Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1107
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Michael Blow
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
index b1bf418..03ed3c4 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
@@ -56,6 +56,7 @@
private AsterixPropertiesAccessor propertiesAccessor;
public void init(boolean deleteOldInstanceData) throws Exception {
+ncs = new NodeControllerService[0]; // ensure that ncs is not null
propertiesAccessor = new AsterixPropertiesAccessor();
if (deleteOldInstanceData) {
deleteTransactionLogs();
--
To view, visit https://asterix-gerrit.ics.uci.edu/1107
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
Michael Blow has posted comments on this change. Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1107 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/440/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Jenkins has posted comments on this change. Change subject: some WebUI hackery .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/439/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fixes related to ASTERIXDB-1534
Jenkins has posted comments on this change. Change subject: Fixes related to ASTERIXDB-1534 .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/438/ -- To view, visit https://asterix-gerrit.ics.uci.edu/ To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If51e0cd183f9d5ed6edaebef4a0568a6c67062e3 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2370/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Yingyi Bu has posted comments on this change.
Change subject: ASTERIXDB-1592: fix and regression tests.
..
Patch Set 2:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1110/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/LocalGroupingProperty.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/LocalGroupingProperty.java:
Line 35: private List preferredOrderEnforcer = new
ArrayList<>();
> Could we make this final?
Done
Line 43: if (preferredOrderEnforcer != null) {
> Do we still need this check, if there's a default value after construction?
This check is for the input parameter, not the class member field.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1110
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: Yingyi Bu
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1110 to look at the new patch set (#3). Change subject: ASTERIXDB-1592: fix and regression tests. .. ASTERIXDB-1592: fix and regression tests. Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc --- A asterixdb/asterix-app/data/tpcds/catalog_returns.csv A asterixdb/asterix-app/data/tpcds/catalog_sales.csv A asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1596.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1596.plan A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/LocalGroupingProperty.java 10 files changed, 423 insertions(+), 15 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/10/1110/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Till Westmann has posted comments on this change.
Change subject: ASTERIXDB-1592: fix and regression tests.
..
Patch Set 2:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1110/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/LocalGroupingProperty.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/LocalGroupingProperty.java:
Line 35: private List preferredOrderEnforcer = new
ArrayList<>();
Could we make this final?
Line 43: if (preferredOrderEnforcer != null) {
Do we still need this check, if there's a default value after construction?
--
To view, visit https://asterix-gerrit.ics.uci.edu/1110
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes
Change in asterixdb[master]: some WebUI hackery
Hello Michael Blow, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1097 to look at the new patch set (#7). Change subject: some WebUI hackery .. some WebUI hackery - use query/service endpoint (and SQL++) - add option to display JSON - some code simplification Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java M asterixdb/asterix-app/src/main/resources/queryui/css/master.css M asterixdb/asterix-app/src/main/resources/queryui/js/main.js M asterixdb/asterix-app/src/main/resources/queryui/queryui.html 4 files changed, 62 insertions(+), 57 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/97/1097/7 -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: some WebUI hackery
Jenkins has posted comments on this change. Change subject: some WebUI hackery .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2369/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Jenkins has posted comments on this change. Change subject: some WebUI hackery .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/437/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Jenkins has posted comments on this change. Change subject: some WebUI hackery .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2368/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Hello Michael Blow, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1097 to look at the new patch set (#6). Change subject: some WebUI hackery .. some WebUI hackery - use query/service endpoint (and SQL++) - add option to display JSON - some code simplification Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java M asterixdb/asterix-app/src/main/resources/queryui/css/master.css M asterixdb/asterix-app/src/main/resources/queryui/js/main.js M asterixdb/asterix-app/src/main/resources/queryui/queryui.html 4 files changed, 60 insertions(+), 39 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/97/1097/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: some WebUI hackery
Jenkins has posted comments on this change. Change subject: some WebUI hackery .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2367/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Hello Michael Blow, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1097 to look at the new patch set (#5). Change subject: some WebUI hackery .. some WebUI hackery - use query/service endpoint (and SQL++) - add option to display JSON - some code simplification Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java M asterixdb/asterix-app/src/main/resources/queryui/css/master.css M asterixdb/asterix-app/src/main/resources/queryui/js/main.js M asterixdb/asterix-app/src/main/resources/queryui/queryui.html 4 files changed, 60 insertions(+), 39 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/97/1097/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/436/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add several builtin functions.
Till Westmann has posted comments on this change.
Change subject: Add several builtin functions.
..
Patch Set 11:
(11 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-like/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-like/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp:
Line 29: where ((p.p_partkey = l.l_partkey) and (((p.p_brand = 'Brand#12')
and tpch.regexp_contains(p.p_container,'SM CASE||SM BOX||SM PACK||SM PKG') and
(l.l_quantity >= 1) and (l.l_quantity <= 11) and (p.p_size >= 1) and (p.p_size
<= 5) and tpch.regexp_contains(l.l_shipmode,'AIR||AIR REG') and
(l.l_shipinstruct = 'DELIVER IN PERSON')) or ((p.p_brand = 'Brand#23') and
tpch.regexp_contains(p.p_container,'MED BAG||MED BOX||MED PKG||MED PACK') and
(l.l_quantity >= 10) and (l.l_quantity <= 20) and (p.p_size >= 1) and (p.p_size
<= 10) and tpch.regexp_contains(l.l_shipmode,'AIR||AIR REG') and
(l.l_shipinstruct = 'DELIVER IN PERSON')) or ((p.p_brand = 'Brand#34') and
tpch.regexp_contains(p.p_container,'LG CASE||LG BOX||LG PACK||LG PKG') and
(l.l_quantity >= 20) and (l.l_quantity <= 30) and (p.p_size >= 1) and (p.p_size
<= 15) and tpch.regexp_contains(l.l_shipmode,'AIR||AIR REG') and
(l.l_shipinstruct = 'DELIVER IN PERSON'
Can we/should we remove the dataverse from these function names?
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppBuiltinFunctionRewriteVisitor.java
File
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppBuiltinFunctionRewriteVisitor.java:
Line 21: import static
org.apache.asterix.lang.sqlpp.util.FunctionMapUtil.normalizedListInputFunctions;
revert this file?
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppListInputFunctionRewriteVisitor.java
File
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppListInputFunctionRewriteVisitor.java:
Line 33: * This visitor rewrites severael variable-arg user-facing functions
to their coressponding
s/severael/several/
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractBinaryStringStringEval.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractBinaryStringStringEval.java:
Line 69: private void writeResult(IPointable resultPointable) throws
AlgebricksException {
We could pull this up one level (if we had one level more) - not sure if that's
worth it, though.
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractUnaryStringStringEval.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractUnaryStringStringEval.java:
Line 87: throws AlgebricksException;
If this would be allowed to throw IOException as well, then we could handle the
exception wrapping in evaluate and save some exception wrapping in subclasses
(and utility classes like StringTrimmer).
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringTrim2Descriptor.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringTrim2Descriptor.java:
Line 59: private StringTrimer stringTrimer = new
StringTrimer(resultBuilder, resultArray);
s/stringTrimer/stringTrimmer/ ?
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringTrimDescriptor.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringTrimDescriptor.java:
Line 59: private StringTrimer stringTrimer = new
StringTrimer(resultBuilder, resultArray, " ");
s/stringTrimer/stringTrimmer/ ?
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/utils/RegExpMatcher.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/utils/RegExpMatcher.java:
Line 56: private final StringBuffer resultBuf = new StringBuffer();
> MAJOR SonarQube violation:
That's indeed a good point.
Line 118: patternGenerator == null ? inputPatternString
: patternGenerator
Pull the conditional expression out of the then and the else branch?
https://asterix-gerrit.ics.uci.edu/#/c/1104/11/asterixdb/asteri
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/436/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 2: Integration-Tests-1 Integration Tests Timed Out https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/434/ : ABORTED -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Updated] (ASTERIXDB-1607) Test support for supplemental characters in strings
[ https://issues.apache.org/jira/browse/ASTERIXDB-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till updated ASTERIXDB-1607: Summary: Test support for supplemental characters in strings (was: Test support for supplemental Characters in strings) > Test support for supplemental characters in strings > --- > > Key: ASTERIXDB-1607 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1607 > Project: Apache AsterixDB > Issue Type: Bug > Components: AsterixDB, Functions - AQL, Hyracks >Reporter: Till > > Test that supplemental characters in strings are supported end-to-end. > One possible resource might be > http://www.i18nguy.com/unicode/supplementary-test.html . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ASTERIXDB-1607) Test support for supplemental Characters in strings
Till created ASTERIXDB-1607: --- Summary: Test support for supplemental Characters in strings Key: ASTERIXDB-1607 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1607 Project: Apache AsterixDB Issue Type: Bug Components: AsterixDB, Functions - AQL, Hyracks Reporter: Till Test that supplemental characters in strings are supported end-to-end. One possible resource might be http://www.i18nguy.com/unicode/supplementary-test.html . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Change in asterixdb[master]: Fixes related to ASTERIXDB-1534
Jenkins has posted comments on this change. Change subject: Fixes related to ASTERIXDB-1534 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2366/ -- To view, visit https://asterix-gerrit.ics.uci.edu/ To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If51e0cd183f9d5ed6edaebef4a0568a6c67062e3 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fixes related to ASTERIXDB-1534
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/ to look at the new patch set (#2). Change subject: Fixes related to ASTERIXDB-1534 .. Fixes related to ASTERIXDB-1534 - Cleanup boolean conditions and exceptions from SonarQube comments - Fix issue where filter page in on-disk LSM components can be confused with root page on restart Change-Id: If51e0cd183f9d5ed6edaebef4a0568a6c67062e3 --- M hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java 2 files changed, 38 insertions(+), 35 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/11//2 -- To view, visit https://asterix-gerrit.ics.uci.edu/ To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If51e0cd183f9d5ed6edaebef4a0568a6c67062e3 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: Fixes related to ASTERIXDB-1534
Ian Maxon has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/
Change subject: Fixes related to ASTERIXDB-1534
..
Fixes related to ASTERIXDB-1534
- Cleanup boolean conditions and exceptions from SonarQube comments
- Fix issue where filter page in on-disk LSM components
can be confused with root page on restart
Change-Id: If51e0cd183f9d5ed6edaebef4a0568a6c67062e3
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
2 files changed, 40 insertions(+), 35 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/11//1
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
index fbb16b2..e7a1123 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
@@ -18,7 +18,6 @@
*/
package org.apache.hyracks.storage.am.common.freepage;
-import java.util.logging.Logger;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.storage.am.common.api.IMetaDataPageManager;
@@ -44,7 +43,6 @@
private boolean appendOnly = false;
ICachedPage confiscatedMetaNode;
ICachedPage filterPage;
-private static Logger LOGGER =
Logger.getLogger(LinkedMetaDataPageManager.class.getName());
public LinkedMetaDataPageManager(IBufferCache bufferCache,
ITreeIndexMetaDataFrameFactory metaDataFrameFactory) {
this.bufferCache = bufferCache;
@@ -65,7 +63,8 @@
// allocate a new page in the chain of meta pages
int newPage = metaFrame.getFreePage();
if (newPage < 0) {
-throw new Exception("Inconsistent Meta Page State. It has
no space, but it also has no entries.");
+throw new HyracksDataException(
+ "Inconsistent Meta Page State. It has no space,
but it also has no entries.");
}
ICachedPage newNode =
bufferCache.pin(BufferedFileHandle.getDiskPageId(fileId, newPage), false);
@@ -87,8 +86,6 @@
bufferCache.unpin(newNode);
}
}
-} catch (Exception e) {
-e.printStackTrace();
} finally {
metaNode.releaseWriteLatch(true);
bufferCache.unpin(metaNode);
@@ -181,7 +178,7 @@
@Override
public int getMaxPage(ITreeIndexMetaDataFrame metaFrame) throws
HyracksDataException {
ICachedPage metaNode;
-if (!appendOnly || (appendOnly && confiscatedMetaNode == null)) {
+if (!appendOnly || confiscatedMetaNode == null) {
int mdPage = getFirstMetadataPage();
if (mdPage < 0) {
return IBufferCache.INVALID_PAGEID;
@@ -197,7 +194,7 @@
maxPage = metaFrame.getMaxPage();
} finally {
metaNode.releaseReadLatch();
-if (!appendOnly || (appendOnly && confiscatedMetaNode == null)) {
+if (!appendOnly || confiscatedMetaNode == null) {
bufferCache.unpin(metaNode);
}
}
@@ -235,7 +232,7 @@
public int getFilterPageId() throws HyracksDataException {
ICachedPage metaNode;
int filterPageId = NO_FILTER_IN_PLACE;
-if (!appendOnly || (appendOnly && confiscatedMetaNode == null)) {
+if (!appendOnly || confiscatedMetaNode == null) {
metaNode =
bufferCache.pin(BufferedFileHandle.getDiskPageId(fileId,
getFirstMetadataPage()), false);
} else {
metaNode = confiscatedMetaNode;
@@ -251,7 +248,7 @@
}
} finally {
metaNode.releaseReadLatch();
-if (!appendOnly || (appendOnly && confiscatedMetaNode == null)) {
+if (!appendOnly || confiscatedMetaNode == null) {
bufferCache.unpin(metaNode);
}
}
@@ -316,7 +313,7 @@
@Override
public boolean isMetaPage(ITreeIndexMetaDataFrame metaFrame) {
-return (metaFrame.getLevel() == META_PAGE_LEVEL_INDICATOR);
+return metaFrame.getLevel() == META_PAGE_LEVEL_INDICATOR;
}
@Override
@@ -345,6 +342,7 @@
ITreeIndexMetaDataFrame metaFrame =
metaDataFrameFactory.createFrame();
metaFrame.setPage
Change in asterixdb[master]: Fixes related to ASTERIXDB-1534
Jenkins has posted comments on this change. Change subject: Fixes related to ASTERIXDB-1534 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2365/ -- To view, visit https://asterix-gerrit.ics.uci.edu/ To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If51e0cd183f9d5ed6edaebef4a0568a6c67062e3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Michael Carey has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: Code-Review+1 Since I'm a novice reviewer, I won't +2 it, but I would if I had more confidence. :-) -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Michael Carey has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: Looked at the code and plans - looks good to me. (Got a jump start in person during a meeting today that helped a lot.) -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/434/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Michael Carey has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: NOTE: A number of the (optimizer only) test cases affected by this change were previously WRONG! I.e., we had WRONG PLANS (as in correctness wrong, not just performance wrong) checked in as the expected results. I wonder how many other cases might be like that. Scary. I wonder if there's a need for an audit of the expected results in our optimizer test cases? -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2364/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Yingyi Bu has uploaded a new patch set (#2). Change subject: ASTERIXDB-1592: fix and regression tests. .. ASTERIXDB-1592: fix and regression tests. Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc --- A asterixdb/asterix-app/data/tpcds/catalog_returns.csv A asterixdb/asterix-app/data/tpcds/catalog_sales.csv A asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1596.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1596.plan A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/LocalGroupingProperty.java 10 files changed, 422 insertions(+), 13 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/10/1110/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
Jenkins has posted comments on this change. Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/433/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1107 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2363/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1592: fix and regression tests.
Yingyi Bu has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1110 Change subject: ASTERIXDB-1592: fix and regression tests. .. ASTERIXDB-1592: fix and regression tests. Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc --- A asterixdb/asterix-app/data/tpcds/catalog_returns.csv A asterixdb/asterix-app/data/tpcds/catalog_sales.csv A asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1596.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1596.plan A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/tpcds/query-ASTERIXDB-1596/query-ASTERIXDB-1596.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/LocalGroupingProperty.java 10 files changed, 418 insertions(+), 13 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/10/1110/1 diff --git a/asterixdb/asterix-app/data/tpcds/catalog_returns.csv b/asterixdb/asterix-app/data/tpcds/catalog_returns.csv new file mode 100644 index 000..539afa9 --- /dev/null +++ b/asterixdb/asterix-app/data/tpcds/catalog_returns.csv @@ -0,0 +1,16 @@ +2450926|45816|2|14601|797995|6189|9583|14601|797995|4703|9583|1|106|2|2|30|2|47|3888.31|233.29|4121.60|91.23|1348.90|3577.24|186.64|124.43|1673.42| +2450946|74710|4|14601|797995|6189|9583|82809|665550|991|14832|1|17|2|5|6|2|49|2490.18|99.60|2589.78|52.54|1867.39|323.72|931.57|1234.89|2019.53| +2451065|71104|6|25383|3755|2480|5652|2311|700704|5571|12485|4|7|13|2|1|4|12|64.32|4.50|68.82|22.97|78.60|1.28|55.47|7.57|106.07| +2450954|28638|8|76801|90299|3797|42495|71681|1168758|7154|35197|2|9|12|3|6|5|20|829.40|49.76|879.16|60.00|308.00|622.05|176.24|31.11|417.76| +2451023|44538|10|31351|528859|5567|23122|33027|737861|54|2647|1|78|12|5|16|6|6|403.08|36.27|439.35|4.58|199.44|354.71|27.57|20.80|240.29| +2450992|10904|1|31351|528859|5567|23122|48008|1289384|1410|27436|1|54|7|3|4|6|7|23.17|1.85|25.02|19.85|7.07|6.25|9.64|7.28|28.77| +2451016|60162|3|7767414994|||4335||29|3|413.94|0.00318.73|35.22|59.99|185.36| +2450926|30343|5|41731|1046123|5715|32107|88927|865466|4658|2697|1|65|14|3|5|11|17|1283.67|51.34|1335.01|71.97|58.31|449.28|183.56|650.83|181.62| +2451058|53881|7|41731|1046123|5715|32107|28053|1827904|2936|21968|1|42|11|5|17|11|9|29.79|1.19|30.98|91.16|59.67|0.00|20.85|8.94|152.02| +2451039|11891|9|36748|83584|2773|8362|53188|1816862|2974|34286|4|11|2|1|13|12|61|2119.75|84.79|2204.54|30.32|271.45|1441.43|529.08|149.24|386.56| +2451035|37877|2|36022|1502404|6833|19662|14294|1764552|4145|34491|1|18|3|1|17|13|27|54.81|0.00|54.81|7.04|146.07|12.05|40.19|2.57|153.11| +2450867|64669|4|36022|1502404|6833|19662|16573|1482438|6726|38614|1|43|18|1|34|13|18|100.44|5.02|105.46|70.47|196.92|9.03|82.26|9.15|272.41| +2450952|64639|6|24957|189998|3839|7327|95061|1639056|2195|3287|2|56|17|1|3|16|40|407.60|32.60|440.20|2.01|296.40|362.76|19.72|25.12|331.01| +2450940|15515|8|24957|189998|3839|7327|51292|1218513|1645|32377|2|75|13|5|2|16|44|2157.76|43.15|2200.91|46.29|1280.84|1834.09|51.78|271.89|1370.28| +2450986|44014|1|82003|599432|3708|27937|26895|1075366|3615|41511|4|9|12|1|2|18|10|339.60|30.56|370.16|25.06|157.70|196.96|45.64|97.00|213.32| +2450997|16008|3|82003|599432|3708|27937|95809|452924|4311|28451|4|33|5|2|7|18|44|2618.44|235.65|2854.09|83.74|5117.64|968.82|65.98|1583.64|5437.03| diff --git a/asterixdb/asterix-app/data/tpcds/catalog_sales.csv b/asterixdb/asterix-app/data/tpcds/catalog_sales.csv new file mode 100644 index 000..100f191 --- /dev/null +++ b/asterixdb/asterix-app/data/tpcds/catalog_sales.csv @@ -0,0 +1,19 @@ +2450815|38212|2450886|62153|1822764|5775|19986|62153|1822764|5775|19986|4|62|3|4|1|196|1|47|27.70|44.32|42.99|62.51|2020.53|1301.90|2083.04|101.02|0.00|1041.52|2020.53|2121.55|3062.05|3163.07|718.63| +2450815|38212|2450846|62153|1822764|5775|19986|62153|1822764|5775|19986|4|31|8|2|2|270|1|20|87.55|260.89|153.92|2139.40|3078.40|1751.00|5217.80|71.41|1292.92|1356.60|1785.48|1856.89|3142.08|3213.49|34.48| +2450815|38212|2450868|62153|1822764|5775|19986|62153|1822764|5775|19986|4|76|2|2|3|97|1|19|69.86|88.72|29.27|1129.55|556.13|1327.34|1685.68|33.36|0.00|168.53|556.13|589.49|724.66|758.02|-771.21| +2450815|38212|2450851|62153|1822764|5775|19986|62153|1822764|5775|19986|4|89|15|2|2|284|2|50|70.00|205.10|188.69|820.50|9434.50|3500.00|10255.00|377.38|0.00|4307.00|9434.50|9811.88|13
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2362/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Jenkins has posted comments on this change. Change subject: some WebUI hackery .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2361/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: some WebUI hackery
Hello Michael Blow, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1097 to look at the new patch set (#4). Change subject: some WebUI hackery .. some WebUI hackery - use query/service endpoint (and SQL++) - add option to display JSON - some code simplification Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java M asterixdb/asterix-app/src/main/resources/queryui/css/master.css M asterixdb/asterix-app/src/main/resources/queryui/js/main.js M asterixdb/asterix-app/src/main/resources/queryui/queryui.html 4 files changed, 57 insertions(+), 39 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/97/1097/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
Jenkins has posted comments on this change. Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/433/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1107 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/432/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
Jenkins has posted comments on this change. Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2360/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1107 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1107 to look at the new patch set (#2). Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit .. Avoid NPE in AsterixHyracksIntegrationUtil.deinit Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/07/1107/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1107 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1451: Fix type propagation to enforced indexes
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1451: Fix type propagation to enforced indexes .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/431/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1109 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/432/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2359/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1451: Fix type propagation to enforced indexes
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1451: Fix type propagation to enforced indexes .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/431/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1109 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2358/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1094 to look at the new patch set (#6). Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. ASTERIXDB-1186: fixed a composite primary index search issue. - Providing only one field to a composite primary index search now works properly by broadcasting search predicates to all nodes. Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_03.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_04.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_05.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_06.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_03.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_04.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_05.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_06.plan M asterixdb/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv19/cross-dv19.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.query.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.adm M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlIndex.java 20 files changed, 12,252 insertions(+), 66 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/94/1094/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 5: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1094/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java: Line 84: this.isCompositeIndex = isCompositeIndex; > The detour from btreeJobGenParams to obtain isCompositeIndex and numberOfKe Done Line 156: || (isCompositeIndex && (lowKeyVarList.size() == numberOfKeyFields) > remove isCompositeIndex in the right branch of "||" Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1451: Fix type propagation to enforced indexes
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1451: Fix type propagation to enforced indexes .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2357/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1109 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1451: Fix type propagation to enforced indexes
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1109 to look at the new patch set (#3). Change subject: ASTERIXDB-1451: Fix type propagation to enforced indexes .. ASTERIXDB-1451: Fix type propagation to enforced indexes This change includes the following: - Introduce cast function in case of delete operation after the primary index to ensure types are passed correctly to enforced indexes. - Introduce cast function in case of upsert operation before old secondary keys extraction to ensure types are passed correctly to enforced indexes. - Sonar-Qube fixes. Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.2.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.3.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.4.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.5.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.2.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.3.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.4.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.5.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.5.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.5.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 14 files changed, 415 insertions(+), 82 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/09/1109/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1109 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: ASTERIXDB-1451: Fix type propagation to enforced indexes
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1451: Fix type propagation to enforced indexes .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/430/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1109 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Issue Comment Deleted] (ASTERIXDB-1606) Optimize "last value" query
[ https://issues.apache.org/jira/browse/ASTERIXDB-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingyi Bu updated ASTERIXDB-1606: - Comment: was deleted (was: Does any database provide (1)? GREATEST is a function name in most database, e.g.: https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm :-)) > Optimize "last value" query > --- > > Key: ASTERIXDB-1606 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1606 > Project: Apache AsterixDB > Issue Type: Bug >Reporter: Steven Jacobs >Priority: Minor > > We need to work on optimizing queries looking for a "most recent" or > "greatest" value of a given field. > As an example, consider an append-only dataset filled with user locations > over time, and suppose we want to know the user's last known location. > Currently, we would need to do this as an: > order by $record.timeStamp > limit 1 > We could improve this in two ways: > 1) Improve usability by providing an alias syntax for users, e.g. "where > greatest timeStamp" > 2) Improve the compilation of such a job to only retrieve a single record. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ASTERIXDB-1606) Optimize "last value" query
[ https://issues.apache.org/jira/browse/ASTERIXDB-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435344#comment-15435344 ] Yingyi Bu commented on ASTERIXDB-1606: -- Does any database provide (1)? GREATEST is a function name in most database, e.g.: https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm :-) > Optimize "last value" query > --- > > Key: ASTERIXDB-1606 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1606 > Project: Apache AsterixDB > Issue Type: Bug >Reporter: Steven Jacobs >Priority: Minor > > We need to work on optimizing queries looking for a "most recent" or > "greatest" value of a given field. > As an example, consider an append-only dataset filled with user locations > over time, and suppose we want to know the user's last known location. > Currently, we would need to do this as an: > order by $record.timeStamp > limit 1 > We could improve this in two ways: > 1) Improve usability by providing an alias syntax for users, e.g. "where > greatest timeStamp" > 2) Improve the compilation of such a job to only retrieve a single record. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ASTERIXDB-1606) Optimize "last value" query
[ https://issues.apache.org/jira/browse/ASTERIXDB-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435343#comment-15435343 ] Yingyi Bu edited comment on ASTERIXDB-1606 at 8/24/16 5:29 PM: --- Does any database provide (1)? GREATEST is a function name in most databases, e.g.: https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm :-) was (Author: buyingyi): Does any database provide (1)? GREATEST is a function name in most database, e.g.: https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm :-) > Optimize "last value" query > --- > > Key: ASTERIXDB-1606 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1606 > Project: Apache AsterixDB > Issue Type: Bug >Reporter: Steven Jacobs >Priority: Minor > > We need to work on optimizing queries looking for a "most recent" or > "greatest" value of a given field. > As an example, consider an append-only dataset filled with user locations > over time, and suppose we want to know the user's last known location. > Currently, we would need to do this as an: > order by $record.timeStamp > limit 1 > We could improve this in two ways: > 1) Improve usability by providing an alias syntax for users, e.g. "where > greatest timeStamp" > 2) Improve the compilation of such a job to only retrieve a single record. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ASTERIXDB-1606) Optimize "last value" query
[ https://issues.apache.org/jira/browse/ASTERIXDB-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435343#comment-15435343 ] Yingyi Bu commented on ASTERIXDB-1606: -- Does any database provide (1)? GREATEST is a function name in most database, e.g.: https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm :-) > Optimize "last value" query > --- > > Key: ASTERIXDB-1606 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1606 > Project: Apache AsterixDB > Issue Type: Bug >Reporter: Steven Jacobs >Priority: Minor > > We need to work on optimizing queries looking for a "most recent" or > "greatest" value of a given field. > As an example, consider an append-only dataset filled with user locations > over time, and suppose we want to know the user's last known location. > Currently, we would need to do this as an: > order by $record.timeStamp > limit 1 > We could improve this in two ways: > 1) Improve usability by providing an alias syntax for users, e.g. "where > greatest timeStamp" > 2) Improve the compilation of such a job to only retrieve a single record. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Change in asterixdb[master]: ASTERIXDB-1451: Fix type propagation to enforced indexes
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1451: Fix type propagation to enforced indexes .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/430/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1109 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-1606) Optimize "last value" query
[ https://issues.apache.org/jira/browse/ASTERIXDB-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435307#comment-15435307 ] Till commented on ASTERIXDB-1606: - I'm not too enthusiastic to add new syntax, that's just me :) If we do it, a good way to go about it is to introduce it as a "syntactical sugar", .i.e. we provide a precise translation from the new syntax to the existing syntax and ensure that the new syntax works as expected in all contexts that the existing syntax works. So if you'd like to introduce this, I'd propose to create a small writeup that explains the sugar and to discuss it on the dev list. As for the implementation, I think that it should do precisely what the sugar says - which is to translate the new syntax to the existing syntax and then apply all optimizations on the normalized algebraic representation of the query. I think that there should be no knowledge of the use of the sugar in the operator-tree, as it would be bad if there we different ways to express the same semantics in the query language but only one way would be optimized correctly. Does this make sense? > Optimize "last value" query > --- > > Key: ASTERIXDB-1606 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1606 > Project: Apache AsterixDB > Issue Type: Bug >Reporter: Steven Jacobs >Priority: Minor > > We need to work on optimizing queries looking for a "most recent" or > "greatest" value of a given field. > As an example, consider an append-only dataset filled with user locations > over time, and suppose we want to know the user's last known location. > Currently, we would need to do this as an: > order by $record.timeStamp > limit 1 > We could improve this in two ways: > 1) Improve usability by providing an alias syntax for users, e.g. "where > greatest timeStamp" > 2) Improve the compilation of such a job to only retrieve a single record. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 5: (2 comments) Obtain the index info (composite or not, number of fields from AqlIndex) in BTreeSearchOperator, such that other source files can stay unchanged. https://asterix-gerrit.ics.uci.edu/#/c/1094/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java: Line 84: this.isCompositeIndex = isCompositeIndex; The detour from btreeJobGenParams to obtain isCompositeIndex and numberOfKeyFields seems awkward to me. Can we directly obtain the information from idx (AqlIndex) in the if-block at line 154? E.g., add a private method in this class to obtain the info from idx. Line 156: || (isCompositeIndex && (lowKeyVarList.size() == numberOfKeyFields) remove isCompositeIndex in the right branch of "||" -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1451: Fix type propagation to enforced indexes
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1451: Fix type propagation to enforced indexes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2356/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1109 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1451: Fix type propagation to enforced indexes
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1109 to look at the new patch set (#2). Change subject: ASTERIXDB-1451: Fix type propagation to enforced indexes .. ASTERIXDB-1451: Fix type propagation to enforced indexes This change includes the following: - Introduce cast function in case of delete operation after the primary index to ensure types are passed correctly to enforced indexes. - Introduce cast function in case of upsert operation before old secondary keys extraction to ensure types are passed correctly to enforced indexes. - Sonar-Qube fixes. Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.2.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.3.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.4.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.5.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.2.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.3.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.4.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.5.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.5.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.5.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 14 files changed, 415 insertions(+), 82 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/09/1109/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1109 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: ASTERIXDB-1451: Fix type propagation to enforced indexes
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1451: Fix type propagation to enforced indexes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2355/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1109 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1451: Fix type propagation to enforced indexes
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1109
Change subject: ASTERIXDB-1451: Fix type propagation to enforced indexes
..
ASTERIXDB-1451: Fix type propagation to enforced indexes
This change includes the following:
- Introduce cast function in case of delete operation
after the primary index to ensure types are passed
correctly to enforced indexes.
- Introduce cast function in case of upsert operation
before old secondary keys extraction to ensure types
are passed correctly to enforced indexes.
- Sonar-Qube fixes.
Change-Id: I1b4572ca541e6a9fbaf1d7f107f76630c854abdd
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.1.ddl.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.2.ddl.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.3.ddl.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.4.ddl.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.5.query.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.1.ddl.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.2.ddl.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.3.ddl.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.4.ddl.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.5.query.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/results/open-index-enforced/type-checking/enforced-type-delete/enforced-type-delete.5.adm
A
asterixdb/asterix-app/src/test/resources/runtimets/results/open-index-enforced/type-checking/enforced-type-upsert/enforced-type-upsert.5.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
14 files changed, 415 insertions(+), 82 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/09/1109/1
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
index c64258f..c1c983e 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
@@ -20,7 +20,6 @@
import java.util.ArrayList;
import java.util.Collections;
-import java.util.Comparator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Stack;
@@ -136,7 +135,7 @@
* inserted/deleted.
*/
while (fid != AsterixBuiltinFunctions.OPEN_RECORD_CONSTRUCTOR) {
-if (op2.getInputs().size() == 0) {
+if (op2.getInputs().isEmpty()) {
return false;
}
op2 = (AbstractLogicalOperator)
op2.getInputs().get(0).getValue();
@@ -146,8 +145,8 @@
AssignOperator assignOp = (AssignOperator) op2;
ILogicalExpression assignExpr =
assignOp.getExpressions().get(0).getValue();
if (assignExpr.getExpressionTag() ==
LogicalExpressionTag.FUNCTION_CALL) {
-ScalarFunctionCallExpression funcExpr =
-(ScalarFunctionCallExpression)
assignOp.getExpressions().get(0).getValue();
+ScalarFunctionCallExpression funcExpr =
(ScalarFunctionCallExpression) assignOp.getExpressions()
+.get(0).getValue();
fid = funcExpr.getFunctionIdentifier();
}
}
@@ -187,9 +186,6 @@
if (dataset.hasMetaPart()) {
metaType = (ARecordType)
mp.findType(dataset.getMetaItemTypeDataverseName(),
dataset.getMetaItemTypeName());
}
-// recType might be replaced with enforced record type and we want to
keep a reference to the original record
-// type
-ARecordType originalRec
Change in asterixdb[master]: Add several builtin functions.
Jenkins has posted comments on this change. Change subject: Add several builtin functions. .. Patch Set 11: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/429/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1104 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: TweetParser Extension
Yingyi Bu has submitted this change and it was merged.
Change subject: TweetParser Extension
..
TweetParser Extension
This patch includes following changes:
1. ExtendedTweetParser to parse more than fix attributes.
2. Changed the twitter feeds message unit from Status to String.
Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1002
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Yingyi Bu
---
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql
A
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AOrderedListType.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java
15 files changed, 482 insertions(+), 154 deletions(-)
Approvals:
Yingyi Bu: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql
new file mode 100644
index 000..ddffc43
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description : This test query will check the revised
+ *parser from two perspective: open Tweet
+ *will automatically includes all fields
+ *from tweet status; closed TwitterUser
+ *type will only includes specified fields.
+ *consumer.secret is missing here to create
+ *exception.
+ * Expected Res : Failure
+ */
+
+drop dataverse feeds if exists;
+create dataverse feeds;
+use dataverse feeds;
+
+create type TwitterUser as closed{
+screen_name: string,
+lang: string,
+friends_count: int32,
+statuses_count: int32
+};
+
+create type Tweet as open
+{
+ id: int64,
+ user: TwitterUser
+}
+
+create dataset Tweets (Tweet)
+primary key id;
+
+create feed TwitterFeed using push_twitter(
+("type-name"="Tweet"),
+("format"="twitter-status"),//
+("consumer.key"=""),
+("access.token"=""),
+("access.token.secret"=""));
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql
new file mode 100644
index 000..66ede3f
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtim
Change in asterixdb[master]: TweetParser Extension
Yingyi Bu has posted comments on this change. Change subject: TweetParser Extension .. Patch Set 14: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: TweetParser Extension
Jenkins has posted comments on this change. Change subject: TweetParser Extension .. Patch Set 14: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/428/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Add several builtin functions.
Jenkins has posted comments on this change. Change subject: Add several builtin functions. .. Patch Set 11: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/429/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1104 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Add several builtin functions.
Jenkins has posted comments on this change. Change subject: Add several builtin functions. .. Patch Set 11: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1104 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add several builtin functions.
Jenkins has posted comments on this change. Change subject: Add several builtin functions. .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2354/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1104 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add several builtin functions.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1104 to look at the new patch set (#11). Change subject: Add several builtin functions. .. Add several builtin functions. - add functions such as greatest, least, concat(||), initcap(title), regexp_contains, regexp_like, regexp_position, regexp_replace, ltrim, trim, rtrim, position; - refactor string functions; - remove undocumented function "regexp", which is equivalent to "matches"; - remove AQL.html and SQLPP.html since they are generated in "target/". Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java M asterixdb/asterix-app/src/test/resources/runtimets/queries/tpch-sql-like/q19_discounted_revenue/q19_discounted_revenue.3.query.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/tpch/q19_discounted_revenue/q19_discounted_revenue.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/greatest_mixed/greatest_mixed.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/least_mixed/least_mixed.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/concat_func/concat_func.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/concat_pipe/concat_pipe.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/concat_pipe_multi/concat_pipe_multi.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/initcap/initcap.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/ltrim/ltrim.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/position/position.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_contains/regexp_contains.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_contains_with_flag/regexp_contains.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_like/regexp_like.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_like_with_flag/regexp_like_with_flag.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_position/regexp_position.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_position_with_flag/regexp_position_with_flag.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/regexp_replace/regexp_replace.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/rtrim/rtrim.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/title/title.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/trim/trim.1.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-like/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-with-index/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/q19_discounted_revenue/q19_discounted_revenue.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/greatest_mixed/greatest_mixed.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/least_mixed/least_mixed.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/concat_pipe_multi/concat_pipe_multi.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/initcap/initcap.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/ltrim/ltrim.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_like/regexp_like.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/rtrim/rtrim.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/string/trim/trim.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/re
Change in asterixdb[master]: TweetParser Extension
Jenkins has posted comments on this change. Change subject: TweetParser Extension .. Patch Set 14: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/428/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: TweetParser Extension
Jenkins has posted comments on this change. Change subject: TweetParser Extension .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2353/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: TweetParser Extension
Hello abdullah alamoudi, Yingyi Bu, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1002 to look at the new patch set (#14). Change subject: TweetParser Extension .. TweetParser Extension This patch includes following changes: 1. ExtendedTweetParser to parse more than fix attributes. 2. Changed the twitter feeds message unit from Status to String. Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 --- A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AOrderedListType.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java 15 files changed, 482 insertions(+), 154 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/02/1002/14 -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: TweetParser Extension
Jenkins has posted comments on this change. Change subject: TweetParser Extension .. Patch Set 13: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/427/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: TweetParser Extension
Jenkins has posted comments on this change. Change subject: TweetParser Extension .. Patch Set 13: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/427/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Add several builtin functions.
Jenkins has posted comments on this change. Change subject: Add several builtin functions. .. Patch Set 10: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/426/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1104 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: TweetParser Extension
Jenkins has posted comments on this change. Change subject: TweetParser Extension .. Patch Set 13: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2352/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: TweetParser Extension
Hello abdullah alamoudi, Yingyi Bu, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1002 to look at the new patch set (#13). Change subject: TweetParser Extension .. TweetParser Extension This patch includes following changes: 1. ExtendedTweetParser to parse more than fix attributes. 2. Changed the twitter feeds message unit from Status to String. Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 --- A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AOrderedListType.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java 15 files changed, 482 insertions(+), 154 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/02/1002/13 -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Add several builtin functions.
Jenkins has posted comments on this change. Change subject: Add several builtin functions. .. Patch Set 10: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/426/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1104 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
