Change in asterixdb[master]: fix NPE in ValidateUtil

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: fix NPE in ValidateUtil
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/561/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1139
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f623441a3f5b72a9a0621d32d9d1a6aa5567d66
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: fix NPE in ValidateUtil

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: fix NPE in ValidateUtil
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1139
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f623441a3f5b72a9a0621d32d9d1a6aa5567d66
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: fix NPE in ValidateUtil

[Till Westmann (Code Review)]

Hello Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1139

to look at the new patch set (#5).

Change subject: fix NPE in ValidateUtil
..

fix NPE in ValidateUtil

Change-Id: I8f623441a3f5b72a9a0621d32d9d1a6aa5567d66
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/ValidateUtil.java
M asterixdb/asterix-app/src/test/resources/metadata/testsuite.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
4 files changed, 15 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/39/1139/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1139
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f623441a3f5b72a9a0621d32d9d1a6aa5567d66
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/560/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1628: Fixed an issue in External Hash Group by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1628: Fixed an issue in External Hash Group by
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/559/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1144
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8901d2b64659fb0d2b97d73f45a9fe113232e860
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: Add the BETWEEN operator.
..


Add the BETWEEN operator.

Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1143
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/int_not_between/int_not_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/int_not_between/int_not_between.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/struct/OperatorType.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
11 files changed, 270 insertions(+), 3 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found



diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
new file mode 100644
index 000..106fc9d
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+drop dataverse test1 if exists;
+create dataverse test1;
+use test1;
+
+create type TestType as open {
+key1: int32,
+key2: int32,
+fname : string,
+lname : string
+}
+
+create dataset DsOne(TestType) primary key key1;
+create dataset DsTwo(TestType) primary key key1;
+
+FROM DsOne x, DsTwo y
+WHERE x.key2 /*+ indexnl */ BETWEEN y.key1 AND 10
+SELECT VALUE x
+;
diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
new file mode 100644
index 000..05af741
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
@@ -0,0 +1,13 @@
+-- DISTRIBUTE_RESULT  |PARTITIONED|
+  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
+-- STREAM_PROJECT  |PARTITIONED|
+  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
+-- BTREE_SEARCH  |PARTITIONED|
+  -- BROADCAST_EXCHANGE  |PARTITIONED|
+-- STREAM_SELECT  |PARTITIONED|
+  -- ASSIGN  |PARTITIONED|
+-- STREAM_PROJECT  |PARTITIONED|
+  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
+-- DATASOURCE_SCAN  |PARTITIONED|
+  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
+-- EMPTY_TUPLE_SOURCE  |PARTITIONED|
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
new file mode 100644
index 000..20aff6d
--- /dev/null
+++ 

Change in asterixdb[master]: Add the BETWEEN operator.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 4:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/557/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1628: Fixed an issue in External Hash Group by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1628: Fixed an issue in External Hash Group by
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/559/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1144
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8901d2b64659fb0d2b97d73f45a9fe113232e860
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-HasComments: No

Change in asterixdb[master]: fix NPE in ValidateUtil

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: fix NPE in ValidateUtil
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/556/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1139
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f623441a3f5b72a9a0621d32d9d1a6aa5567d66
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1628: Fixed an issue in External Hash Group by

[Jianfeng Jia (Code Review)]

Jianfeng Jia has posted comments on this change.

Change subject: ASTERIXDB-1628: Fixed an issue in External Hash Group by
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1144
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8901d2b64659fb0d2b97d73f45a9fe113232e860
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By ...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By to 
conform to the memory budget
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/558/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2518/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Yingyi Bu (Code Review)]

Hello Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1143

to look at the new patch set (#5).

Change subject: Add the BETWEEN operator.
..

Add the BETWEEN operator.

Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/int_not_between/int_not_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/int_not_between/int_not_between.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/struct/OperatorType.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
11 files changed, 270 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/43/1143/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/555/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/557/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add functions: atan2, power, trunc, and uuid.

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: Add functions: atan2, power, trunc, and uuid.
..


Add functions: atan2, power, trunc, and uuid.

Change-Id: I3aa3be97809be7d03bbab919252af7bbfe6f00e0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1138
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
Integration-Tests: Jenkins 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/uuid/uuid.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/atan2/atan2.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/power/power.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/trunc/trunc.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/misc/uuid/uuid.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/atan2/atan2.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/power/power.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/trunc/trunc.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/FunctionMapUtil.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericDoubleOutputFunctionTypeComputer.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericInt8OutputFunctionTypeComputer.java
R 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRound2TypeComputer.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericATan2Descriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericModuloDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundHalfToEven2Descriptor.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericTruncDescriptor.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/UUIDDescriptor.java
20 files changed, 712 insertions(+), 170 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
index 27454e3..09cb856 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
@@ -165,6 +165,7 @@
 import org.apache.asterix.runtime.evaluators.functions.NotDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.NumericACosDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.NumericASinDescriptor;
+import org.apache.asterix.runtime.evaluators.functions.NumericATan2Descriptor;
 import org.apache.asterix.runtime.evaluators.functions.NumericATanDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.NumericAbsDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.NumericAddDescriptor;
@@ -186,6 +187,7 @@
 import org.apache.asterix.runtime.evaluators.functions.NumericSqrtDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.NumericSubDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.NumericTanDescriptor;
+import org.apache.asterix.runtime.evaluators.functions.NumericTruncDescriptor;
 import 
org.apache.asterix.runtime.evaluators.functions.NumericUnaryMinusDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.OrDescriptor;
 import 
org.apache.asterix.runtime.evaluators.functions.OrderedListConstructorDescriptor;
@@ -234,6 +236,7 @@
 import 
org.apache.asterix.runtime.evaluators.functions.SubstringBeforeDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.SubstringDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.SwitchCaseDescriptor;
+import org.apache.asterix.runtime.evaluators.functions.UUIDDescriptor;
 import 
org.apache.asterix.runtime.evaluators.functions.UnorderedListConstructorDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.WordTokensDescriptor;
 import 
org.apache.asterix.runtime.evaluators.functions.binary.BinaryConcatDescriptor;
@@ -416,6 +419,7 @@
 
   

Change in asterixdb[master]: fix NPE in ValidateUtil

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: fix NPE in ValidateUtil
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/556/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1139
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f623441a3f5b72a9a0621d32d9d1a6aa5567d66
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add functions: atan2, power, trunc, and uuid.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add functions: atan2, power, trunc, and uuid.
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/554/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa3be97809be7d03bbab919252af7bbfe6f00e0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1628: Fixed an issue in External Hash Group by

[Taewoo Kim (Code Review)]

Taewoo Kim has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1144

Change subject: ASTERIXDB-1628: Fixed an issue in External Hash Group by
..

ASTERIXDB-1628: Fixed an issue in External Hash Group by

 - The number of partitions in External Hash Group By is now
   properly calculated by considering a corner case.

Change-Id: I8901d2b64659fb0d2b97d73f45a9fe113232e860
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
1 file changed, 11 insertions(+), 7 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/44/1144/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
index f08d27d..85a7609 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
@@ -238,17 +238,21 @@
 };
 }
 
-private int getNumOfPartitions(int nubmerOfFramesForData, int frameLimit) {
-if (frameLimit > nubmerOfFramesForData) {
+private int getNumOfPartitions(int nubmerOfFramesForDataAndHashTable, int 
frameLimit) {
+if (frameLimit >= nubmerOfFramesForDataAndHashTable * FUDGE_FACTOR) {
 return 1; // all in memory, we will create a big partition
 }
+// The formula is based on Shapiro's paper - 
http://cs.stanford.edu/people/chrismre/cs345/rl/shapiro.pdf.
+// Check the page 249 for more details.
 int numberOfPartitions = (int) (Math
-.ceil((nubmerOfFramesForData * FUDGE_FACTOR - frameLimit) / 
(frameLimit - 1)));
-if (numberOfPartitions <= 0) {
-numberOfPartitions = 1; //becomes in-memory hash
-}
+.ceil((nubmerOfFramesForDataAndHashTable * FUDGE_FACTOR - 
frameLimit) / (frameLimit - 1)));
+// Actually, at this stage, we know that this is not a in-memory hash 
(#frames required > #frameLimit).
+// So we want to guarantee that the number of partition is at least 
two because there is a corner case.
+numberOfPartitions = Math.max(2, numberOfPartitions);
+// If the number of partitions is greater than the memory budget, 
there might be a case that we can't
+// allocate at least one frame for each partition in memory. So, we 
deal with those cases here.
 if (numberOfPartitions > frameLimit) {
-numberOfPartitions = (int) 
Math.ceil(Math.sqrt(nubmerOfFramesForData * FUDGE_FACTOR));
+numberOfPartitions = (int) 
Math.ceil(Math.sqrt(nubmerOfFramesForDataAndHashTable * FUDGE_FACTOR));
 return Math.max(2, Math.min(numberOfPartitions, frameLimit));
 }
 return numberOfPartitions;

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1144
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8901d2b64659fb0d2b97d73f45a9fe113232e860
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 

Change in asterixdb[master]: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By ...

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By to 
conform to the memory budget
..


Patch Set 9:

@Jianfeng: thanks. Will do.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/555/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: improve display of end-time for jobs in Hyracks console

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: improve display of end-time for jobs in Hyracks console
..


improve display of end-time for jobs in Hyracks console

Change-Id: I80383dd0d35d0bbb83e00f56e094392d6d375a6d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1140
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/resources/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.html
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.java
index 709e406..32ac3f5 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.java
@@ -92,7 +92,10 @@
 }
 
 private String longToDateString(long milliseconds) {
-SimpleDateFormat sdf = new SimpleDateFormat("MMM dd, HH:mm:ss");
+if (milliseconds == 0) {
+return "n/a";
+}
+SimpleDateFormat sdf = new SimpleDateFormat("MMM dd,  HH:mm:ss");
 Date date = new Date(milliseconds);
 return sdf.format(date);
 }
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/resources/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.html
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/resources/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.html
index bdba2cb..bbb22b7 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/resources/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.html
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/resources/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.html
@@ -49,6 +49,7 @@
 Status
 Create Time
 Start Time
+End Time
 Job Details
 
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1140
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80383dd0d35d0bbb83e00f56e094392d6d375a6d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By ...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By to 
conform to the memory budget
..


Patch Set 9:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add functions: atan2, power, trunc, and uuid.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add functions: atan2, power, trunc, and uuid.
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/554/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa3be97809be7d03bbab919252af7bbfe6f00e0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add upsert option for feed

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add upsert option for feed
..


Patch Set 13: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/553/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5133e7c6941fea4110cc9983f99502f364dc810
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By ...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1566,ASTERIXDB-1628: Fixed External Hash Group By to 
conform to the memory budget
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2516/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add functions: atan2, power, trunc, and uuid.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add functions: atan2, power, trunc, and uuid.
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/552/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa3be97809be7d03bbab919252af7bbfe6f00e0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: improve display of end-time for jobs in Hyracks console

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: improve display of end-time for jobs in Hyracks console
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1140
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80383dd0d35d0bbb83e00f56e094392d6d375a6d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 3: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/550/ : 
ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2515/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: fix NPE in ValidateUtil

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: fix NPE in ValidateUtil
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2514/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1139
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f623441a3f5b72a9a0621d32d9d1a6aa5567d66
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1143/3/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java:

Line 111: // The grammar guarantees that the BETWEEN operator gets 
exact three expressions.
> s/exact/exactly/
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add the BETWEEN operator.

[Yingyi Bu (Code Review)]

Hello Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1143

to look at the new patch set (#4).

Change subject: Add the BETWEEN operator.
..

Add the BETWEEN operator.

Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/int_not_between/int_not_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/int_not_between/int_not_between.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/struct/OperatorType.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
11 files changed, 270 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/43/1143/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: fix NPE in ValidateUtil

[Till Westmann (Code Review)]

Hello Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1139

to look at the new patch set (#4).

Change subject: fix NPE in ValidateUtil
..

fix NPE in ValidateUtil

Change-Id: I8f623441a3f5b72a9a0621d32d9d1a6aa5567d66
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/ValidateUtil.java
M asterixdb/asterix-app/src/test/resources/metadata/testsuite.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
4 files changed, 15 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/39/1139/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1139
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f623441a3f5b72a9a0621d32d9d1a6aa5567d66
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Add the BETWEEN operator.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1143/3/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java:

Line 111: // The grammar guarantees that the BETWEEN operator gets 
exact three expressions.
s/exact/exactly/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add functions: atan2, power, trunc, and uuid.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add functions: atan2, power, trunc, and uuid.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2513/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa3be97809be7d03bbab919252af7bbfe6f00e0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add functions: atan2, power, trunc, and uuid.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add functions: atan2, power, trunc, and uuid.
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa3be97809be7d03bbab919252af7bbfe6f00e0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add string function repeat and split.

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: Add string function repeat and split.
..


Add string function repeat and split.

Change-Id: Ib9de5a59807d5ff51fa5d72444053f87cf8dd289
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1141
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/repeat/repeat.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/repeat_error/repeat_error.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/split/split.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/repeat/repeat.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/split/split.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java
R 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringIntToStringTypeComputer.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringToInt64ListTypeComputer.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringToStringListTypeComputer.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRepeatDescriptor.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringSplitDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java
14 files changed, 536 insertions(+), 17 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
index a1746cc..27454e3 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
@@ -222,6 +222,8 @@
 import 
org.apache.asterix.runtime.evaluators.functions.StringRegExpPositionWithFlagDescriptor;
 import 
org.apache.asterix.runtime.evaluators.functions.StringRegExpReplaceDescriptor;
 import 
org.apache.asterix.runtime.evaluators.functions.StringRegExpReplaceWithFlagsDescriptor;
+import org.apache.asterix.runtime.evaluators.functions.StringRepeatDescriptor;
+import org.apache.asterix.runtime.evaluators.functions.StringSplitDescriptor;
 import 
org.apache.asterix.runtime.evaluators.functions.StringStartsWithDescriptor;
 import 
org.apache.asterix.runtime.evaluators.functions.StringToCodePointDescriptor;
 import org.apache.asterix.runtime.evaluators.functions.StringTrim2Descriptor;
@@ -513,6 +515,8 @@
 functionsToInjectUnkownHandling.add(StringLTrim2Descriptor.FACTORY);
 functionsToInjectUnkownHandling.add(StringRTrim2Descriptor.FACTORY);
 functionsToInjectUnkownHandling.add(StringPositionDescriptor.FACTORY);
+functionsToInjectUnkownHandling.add(StringRepeatDescriptor.FACTORY);
+functionsToInjectUnkownHandling.add(StringSplitDescriptor.FACTORY);
 
 // Constructors
 
functionsToInjectUnkownHandling.add(ABooleanConstructorDescriptor.FACTORY);
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/repeat/repeat.1.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/repeat/repeat.1.query.sqlpp
new file mode 100644
index 000..17904c7
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/repeat/repeat.1.query.sqlpp
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * 

Change in asterixdb[master]: Add string function repeat and split.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add string function repeat and split.
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1141
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9de5a59807d5ff51fa5d72444053f87cf8dd289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Add upsert option for feed

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add upsert option for feed
..


Patch Set 13:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/553/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5133e7c6941fea4110cc9983f99502f364dc810
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add upsert option for feed

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add upsert option for feed
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2512/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5133e7c6941fea4110cc9983f99502f364dc810
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add upsert option for feed

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1068

to look at the new patch set (#13).

Change subject: Add upsert option for feed
..

Add upsert option for feed

For ASTERIXDB-1567. Provide "upsert-feed"="true" for
feed configuration, which changes the default record
insert to upsert. Added one test case for upsert feed.

Change-Id: Ic5133e7c6941fea4110cc9983f99502f364dc810
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
A asterixdb/asterix-app/data/tinysocial/twu_update.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.3.server.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.4.sleep.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.5.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.6.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.7.server.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.8.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/upsert-feed/upsert-feed.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
15 files changed, 279 insertions(+), 12 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/68/1068/13
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic5133e7c6941fea4110cc9983f99502f364dc810
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Add upsert option for feed

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add upsert option for feed
..


Patch Set 12:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/551/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5133e7c6941fea4110cc9983f99502f364dc810
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add functions: atan2, power, trunc, and uuid.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add functions: atan2, power, trunc, and uuid.
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2511/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa3be97809be7d03bbab919252af7bbfe6f00e0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Add functions: atan2, power, trunc, and uuid.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1138

to look at the new patch set (#5).

Change subject: Add functions: atan2, power, trunc, and uuid.
..

Add functions: atan2, power, trunc, and uuid.

Change-Id: I3aa3be97809be7d03bbab919252af7bbfe6f00e0
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/uuid/uuid.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/atan2/atan2.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/power/power.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/trunc/trunc.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/misc/uuid/uuid.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/atan2/atan2.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/power/power.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/trunc/trunc.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/FunctionMapUtil.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericDoubleOutputFunctionTypeComputer.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericInt8OutputFunctionTypeComputer.java
R 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRound2TypeComputer.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericATan2Descriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericModuloDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundHalfToEven2Descriptor.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericTruncDescriptor.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/UUIDDescriptor.java
20 files changed, 712 insertions(+), 170 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/38/1138/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3aa3be97809be7d03bbab919252af7bbfe6f00e0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Add upsert option for feed

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add upsert option for feed
..


Patch Set 12:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2510/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5133e7c6941fea4110cc9983f99502f364dc810
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add upsert option for feed

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1068

to look at the new patch set (#12).

Change subject: Add upsert option for feed
..

Add upsert option for feed

For ASTERIXDB-1567. Provide "upsert-feed"="true" for
feed configuration, which changes the default record
insert to upsert. Added one test case for upsert feed.

Change-Id: Ic5133e7c6941fea4110cc9983f99502f364dc810
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
A asterixdb/asterix-app/data/tinysocial/twu_update.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.3.server.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.4.sleep.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.5.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.6.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.7.server.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/upsert-feed/upsert-feed.8.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/upsert-feed/upsert-feed.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
15 files changed, 279 insertions(+), 12 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/68/1068/12
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic5133e7c6941fea4110cc9983f99502f364dc810
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Add functions: atan2, power, trunc, and uuid.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add functions: atan2, power, trunc, and uuid.
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1138/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericATan2Descriptor.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericATan2Descriptor.java:

Line 102: switch (typeTag) {
It seems that this casting switch might be useful in more than one place. Is 
that right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa3be97809be7d03bbab919252af7bbfe6f00e0
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2509/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1143

to look at the new patch set (#3).

Change subject: Add the BETWEEN operator.
..

Add the BETWEEN operator.

Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/int_not_between/int_not_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/int_not_between/int_not_between.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/struct/OperatorType.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
11 files changed, 270 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/43/1143/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2508/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1143

to look at the new patch set (#2).

Change subject: Add the BETWEEN operator.
..

Add the BETWEEN operator.

Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/int_not_between/int_not_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/int_not_between/int_not_between.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/struct/OperatorType.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
11 files changed, 269 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/43/1143/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

[jira] [Commented] (ASTERIXDB-1628) The number of partitions in External Hash-Groupby is calculated improperly for smaller data size.

[Taewoo Kim (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459716#comment-15459716
 ] 

Taewoo Kim commented on ASTERIXDB-1628:
---

After having a discussion with [~che...@gmail.com] and [~javierjia], we have 
concluded that the above code could be revised as follows:

{code}
private int getNumOfPartitions(int nubmerOfFramesForDataAndHashTable, int 
frameLimit) {
if (frameLimit >= nubmerOfFramesForDataAndHashTable * FUDGE_FACTOR) {
return 1; // all in memory, we will create a big partition
}
int numberOfPartitions = (int) (Math
.ceil((nubmerOfFramesForDataAndHashTable * FUDGE_FACTOR - 
frameLimit) / (frameLimit - 1)));
// Actually, in this case, this is not a in-memory hash (#frames 
required > #frameLimit)
// so we guarantee that the number of partition is at least two.
numberOfPartitions = Math.max(2, numberOfPartitions);

if (numberOfPartitions > frameLimit) {
numberOfPartitions = (int) 
Math.ceil(Math.sqrt(nubmerOfFramesForDataAndHashTable * FUDGE_FACTOR));
return Math.max(2, Math.min(numberOfPartitions, frameLimit));
}
return numberOfPartitions;
}
{code}

> The number of partitions in External Hash-Groupby is calculated improperly 
> for smaller data size.
> -
>
> Key: ASTERIXDB-1628
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1628
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Taewoo Kim
>Assignee: Taewoo Kim
>  Labels: soon
>
> If the number of frames required for a data (e.g., external file), say A,  is 
> slightly larger than the number of available frames (= memory budget), say B, 
> then the number of partitions may be calculated as 1 and it will cause the 
> infinite cycles during the merge phase.
> If the number of partition is 1, the current code assumes that there is no 
> spilling due to the out of memory budget and the output of the build phase is 
> directly generated as the final output. 
> But, if A > B, then a spill would happen and once a partition is spilled to 
> the disk, it can't be generated as the final output. So, the merge process 
> goes to the next round that just creates only one partition again and tries 
> to generate some as final output. But, it can't. Thus, an infinite cycle 
> begins.
> The resolution is that if A > B, we should not set the number of partition as 
> one.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.

[Chen Li (Code Review)]

Chen Li has posted comments on this change.

Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
..


Patch Set 8:

@wenhai: Similar to another "fuzzy issue", I talked to @taewoo about this 
patch.  I suggest you two schedule a skype time to go through the changes 
together to explain/approve those changes.  Also I think it's critical to make 
sure proper comments are added, and those comments are clear.  Try to avoid 
grammatical mistakes in the comments.  Thanks!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add the BETWEEN operator.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1143

Change subject: Add the BETWEEN operator.
..

Add the BETWEEN operator.

Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/int_not_between/int_not_between.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/int_not_between/int_not_between.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/struct/OperatorType.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/OperatorExpressionVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
11 files changed, 271 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/43/1143/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
new file mode 100644
index 000..106fc9d
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/primary-between-join_01.sqlpp
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+drop dataverse test1 if exists;
+create dataverse test1;
+use test1;
+
+create type TestType as open {
+key1: int32,
+key2: int32,
+fname : string,
+lname : string
+}
+
+create dataset DsOne(TestType) primary key key1;
+create dataset DsTwo(TestType) primary key key1;
+
+FROM DsOne x, DsTwo y
+WHERE x.key2 /*+ indexnl */ BETWEEN y.key1 AND 10
+SELECT VALUE x
+;
diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
new file mode 100644
index 000..05af741
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-between-join_01.plan
@@ -0,0 +1,13 @@
+-- DISTRIBUTE_RESULT  |PARTITIONED|
+  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
+-- STREAM_PROJECT  |PARTITIONED|
+  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
+-- BTREE_SEARCH  |PARTITIONED|
+  -- BROADCAST_EXCHANGE  |PARTITIONED|
+-- STREAM_SELECT  |PARTITIONED|
+  -- ASSIGN  |PARTITIONED|
+-- STREAM_PROJECT  |PARTITIONED|
+  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
+-- DATASOURCE_SCAN  |PARTITIONED|
+  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
+-- EMPTY_TUPLE_SOURCE  |PARTITIONED|
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
new file mode 100644
index 000..20aff6d
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/datetime_range_between/datetime_range_between.1.ddl.sqlpp
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work 

Change in asterixdb[master]: Add the BETWEEN operator.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add the BETWEEN operator.
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2507/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1143
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1628) The number of partitions in External Hash-Groupby is calculated improperly for smaller data size.

[Taewoo Kim (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459537#comment-15459537
 ] 

Taewoo Kim commented on ASTERIXDB-1628:
---

[~che...@gmail.com] suggested another simple idea:

if (nubmerOfFramesForData(=D) * FUDGE_FACTOR) / frameLimit(=M) < M, 
 then numberOfPartitions = D  * FUDGE_FACTOR / M.
else
 numberOfPartitions = M.
 

> The number of partitions in External Hash-Groupby is calculated improperly 
> for smaller data size.
> -
>
> Key: ASTERIXDB-1628
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1628
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Taewoo Kim
>Assignee: Taewoo Kim
>  Labels: soon
>
> If the number of frames required for a data (e.g., external file), say A,  is 
> slightly larger than the number of available frames (= memory budget), say B, 
> then the number of partitions may be calculated as 1 and it will cause the 
> infinite cycles during the merge phase.
> If the number of partition is 1, the current code assumes that there is no 
> spilling due to the out of memory budget and the output of the build phase is 
> directly generated as the final output. 
> But, if A > B, then a spill would happen and once a partition is spilled to 
> the disk, it can't be generated as the final output. So, the merge process 
> goes to the next round that just creates only one partition again and tries 
> to generate some as final output. But, it can't. Thus, an infinite cycle 
> begins.
> The resolution is that if A > B, we should not set the number of partition as 
> one.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Chen Li (Code Review)]

Chen Li has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 5:

(2 comments)

@Wenhai: In this patch, can you give a high-level description of the changes, 
including the symptom, bug source, and the fix?

https://asterix-gerrit.ics.uci.edu/#/c/1076/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java:

Line 252: fuzzy.add(new FuzzyJoinRule());
Rename "fuzzy" to "fuzzyRules"?


Line 253: // Embedding the prefix join instead of ~= cause the newly 
subplan derived from the AggregateOp->NTSOp
I am not quite following this comment.  Can you try to rephrase it to make it 
more clear?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: Yes

[jira] [Commented] (ASTERIXDB-1628) The number of partitions in External Hash-Groupby is calculated improperly for smaller data size.

[Taewoo Kim (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459530#comment-15459530
 ] 

Taewoo Kim commented on ASTERIXDB-1628:
---

The current code calculates the number of partitions based on "Hybrid Hash 
Join" part in [Shapiro's 
paper|http://cs.stanford.edu/people/chrismre/cs345/rl/shapiro.pdf] (page. 249). 
   

{code}
private int getNumOfPartitions(int nubmerOfFramesForData, int frameLimit) {
if (frameLimit > nubmerOfFramesForData) {
return 1; // all in memory, we will create a big partition
}
int numberOfPartitions = (int) (Math
.ceil((nubmerOfFramesForData * FUDGE_FACTOR - frameLimit) / 
(frameLimit - 1)));
if (numberOfPartitions <= 0) {
numberOfPartitions = 1; //becomes in-memory hash
}
if (numberOfPartitions > frameLimit) {
numberOfPartitions = (int) 
Math.ceil(Math.sqrt(nubmerOfFramesForData * FUDGE_FACTOR));
return Math.max(2, Math.min(numberOfPartitions, frameLimit));
}
return numberOfPartitions;
}
{code}

Actually, the second formula tells us that if we have enough number of memory 
buffer (= numberOfPartitions), which is not an entire memory budget, then we 
can finish the process in numberOfPartitions + 1 steps. 
{code}
int numberOfPartitions = (int) (Math.ceil((nubmerOfFramesForData * 
FUDGE_FACTOR - frameLimit) / (frameLimit - 1)));
{code}





> The number of partitions in External Hash-Groupby is calculated improperly 
> for smaller data size.
> -
>
> Key: ASTERIXDB-1628
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1628
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Taewoo Kim
>Assignee: Taewoo Kim
>  Labels: soon
>
> If the number of frames required for a data (e.g., external file), say A,  is 
> slightly larger than the number of available frames (= memory budget), say B, 
> then the number of partitions may be calculated as 1 and it will cause the 
> infinite cycles during the merge phase.
> If the number of partition is 1, the current code assumes that there is no 
> spilling due to the out of memory budget and the output of the build phase is 
> directly generated as the final output. 
> But, if A > B, then a spill would happen and once a partition is spilled to 
> the disk, it can't be generated as the final output. So, the merge process 
> goes to the next round that just creates only one partition again and tries 
> to generate some as final output. But, it can't. Thus, an infinite cycle 
> begins.
> The resolution is that if A > B, we should not set the number of partition as 
> one.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ASTERIXDB-1631) TypeComputeUtils doesn't work well with type ANY

[Abdullah Alamoudi (JIRA)]

Abdullah Alamoudi created ASTERIXDB-1631:


 Summary: TypeComputeUtils doesn't work well with type ANY
 Key: ASTERIXDB-1631
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1631
 Project: Apache AsterixDB
  Issue Type: Bug
Reporter: Abdullah Alamoudi
Assignee: Yingyi Bu


Type ANY can be nullable or missable but it is not treated that way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ASTERIXDB-1630) ATypeHierarchy doesn't consider promoting type ANY

[Abdullah Alamoudi (JIRA)]

Abdullah Alamoudi created ASTERIXDB-1630:


 Summary: ATypeHierarchy doesn't consider promoting type ANY
 Key: ASTERIXDB-1630
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1630
 Project: Apache AsterixDB
  Issue Type: Bug
Reporter: Abdullah Alamoudi
Assignee: Yingyi Bu


Methods such as compatible with any will always return false.
Not sure if this is the expected behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Start/Stop Sample Scripts for Windows

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Start/Stop Sample Scripts for Windows
..


Patch Set 2:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/549/ : 
UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1142
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6eee2156a5c6e40e0e864c2b8be2c08593e71b1
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Add string function repeat and split.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add string function repeat and split.
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/547/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1141
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9de5a59807d5ff51fa5d72444053f87cf8dd289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-1629) Union All with global aggregates fails

[Yingyi Bu (JIRA)]

Yingyi Bu created ASTERIXDB-1629:


 Summary: Union All with global aggregates fails
 Key: ASTERIXDB-1629
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1629
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: Optimizer
Reporter: Yingyi Bu
Assignee: Yingyi Bu


query:

{noformat}
SELECT COUNT(1)  AS one FROM items
UNION ALL
SELECT COUNT(1) AS one FROM items;
{noformat}

A runtime error is thrown:
{noformat}
Invalid types for casting, required type generalized-record-type: closed {
  one: UNION(INT64, NULL, MISSING)
}
, input type null: closed {
  one: UNION(INT64, NULL, MISSING)
}
 [IllegalStateException]
{noformat}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Start/Stop Sample Scripts for Windows

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Start/Stop Sample Scripts for Windows
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/549/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1142
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6eee2156a5c6e40e0e864c2b8be2c08593e71b1
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
..


Patch Set 8:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/548/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Start/Stop Sample Scripts for Windows

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Start/Stop Sample Scripts for Windows
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1142
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6eee2156a5c6e40e0e864c2b8be2c08593e71b1
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Add string function repeat and split.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add string function repeat and split.
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/547/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1141
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9de5a59807d5ff51fa5d72444053f87cf8dd289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: RangeGenerator aggfunc for the numeric/asciiString datatype ...

[Wenhai Li (Code Review)]

Wenhai Li has posted comments on this change.

Change subject: RangeGenerator aggfunc for the numeric/asciiString datatype 
based on parallel streaming histogram. The following commits from your working 
branch will be included:
..


Patch Set 41:

@Preston
Ok, that's also what I expected. Several testCases in both runtimes and 
optimizers are definitely necessary.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/806
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I450d0962fbeacfb2b6ab9fae0750f025ef17ba01
Gerrit-PatchSet: 41
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: RangeGenerator aggfunc for the numeric/asciiString datatype ...

[Preston Carman (Code Review)]

Preston Carman has posted comments on this change.

Change subject: RangeGenerator aggfunc for the numeric/asciiString datatype 
based on parallel streaming histogram. The following commits from your working 
branch will be included:
..


Patch Set 41: Code-Review+1

We can add query plan test when the sort query plan is updated.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/806
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I450d0962fbeacfb2b6ab9fae0750f025ef17ba01
Gerrit-PatchSet: 41
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Start/Stop Sample Scripts for Windows

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1142

to look at the new patch set (#2).

Change subject: Start/Stop Sample Scripts for Windows
..

Start/Stop Sample Scripts for Windows

- Fix windows binaries (ncservice, cc, nc, helper)
- Add windows start/stop sample cluster scripts

Change-Id: Id6eee2156a5c6e40e0e864c2b8be2c08593e71b1
---
M .gitignore
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-client-helper/src/main/assembly/assembly.xml
M asterixdb/asterix-server/pom.xml
M asterixdb/asterix-server/src/main/assembly/binary-assembly.xml
A asterixdb/asterix-server/src/main/samples/local/bin/start-sample-cluster.bat
A asterixdb/asterix-server/src/main/samples/local/bin/stop-sample-cluster.bat
7 files changed, 174 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/42/1142/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1142
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id6eee2156a5c6e40e0e864c2b8be2c08593e71b1
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Wenhai Li (Code Review)]

Wenhai Li has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 5:

@Taewoo and Chen
Four comments are inlined as required and I remove the 
AsterixExtractFunctionsFromJoinConditionRule. That will be fine in the current 
master since the Assign Variables have been correctly handled by the second 
round of RemoveUsedAssign. The comments are inlined in the denoted lines.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

[Preston Carman (Code Review)]

Preston Carman has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 7:

Is this change ready now?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Start/Stop Sample Scripts for Windows

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Start/Stop Sample Scripts for Windows
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1142/1/asterixdb/asterix-client-helper/pom.xml
File asterixdb/asterix-client-helper/pom.xml:

Line 51:   cbashelper
> That's a strange name.
copy n' paste problems.  Done.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1142
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6eee2156a5c6e40e0e864c2b8be2c08593e71b1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

[jira] [Commented] (ASTERIXDB-1628) The number of partitions in External Hash-Groupby is calculated improperly for smaller data size.

[Jianfeng Jia (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459083#comment-15459083
 ] 

Jianfeng Jia commented on ASTERIXDB-1628:
-

So we can have a quick fix as you suggest? The first round is always guaranteed 
to have >= 2, and then after that since we've already known the partition size, 
we can enforce the rule that " if A > B, we should not set the number of 
partition as one."

> The number of partitions in External Hash-Groupby is calculated improperly 
> for smaller data size.
> -
>
> Key: ASTERIXDB-1628
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1628
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Taewoo Kim
>Assignee: Taewoo Kim
>  Labels: soon
>
> If the number of frames required for a data (e.g., external file), say A,  is 
> slightly larger than the number of available frames (= memory budget), say B, 
> then the number of partitions may be calculated as 1 and it will cause the 
> infinite cycles during the merge phase.
> If the number of partition is 1, the current code assumes that there is no 
> spilling due to the out of memory budget and the output of the build phase is 
> directly generated as the final output. 
> But, if A > B, then a spill would happen and once a partition is spilled to 
> the disk, it can't be generated as the final output. So, the merge process 
> goes to the next round that just creates only one partition again and tries 
> to generate some as final output. But, it can't. Thus, an infinite cycle 
> begins.
> The resolution is that if A > B, we should not set the number of partition as 
> one.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.

[Wenhai Li (Code Review)]

Wenhai Li has posted comments on this change.

Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
..


Patch Set 8:

@Chen
It's a quite strange query, the high-level comments towards the example is like:
1. We setup a fuzzy join over A.a ~= B.b based on a word index over A.a
2. We want to aggregate on B's fields.
If we switch the consequence of A and B in the two "FOR" lines, we get 
inconsistent result. The RemoveUnusedOneToOneEuquiJoinRule remove the branch of 
A after "pseudo" broadcase B to A for enabling "SELECT" instead of fuzzy join. 
But that is wrong.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Start/Stop Sample Scripts for Windows

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Start/Stop Sample Scripts for Windows
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1142/1/asterixdb/asterix-client-helper/pom.xml
File asterixdb/asterix-client-helper/pom.xml:

Line 51:   cbashelper
That's a strange name.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1142
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6eee2156a5c6e40e0e864c2b8be2c08593e71b1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2505/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.

[Wenhai Li (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1119

to look at the new patch set (#8).

Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
..

ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.

1. Add the test case of ASTERIX-1487 with half records required.
2. Disable the join branch pruning in case of unnestmap following 
datasourcescan.

commit 957aaa59f279b53c7901758f88a1820dd8b689c9
Author: Michael 
Date:   Fri Aug 26 06:53:00 2016 -0700

ASTERIX-1487: fix the wrong plan for inverted index.

Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
6 files changed, 139 insertions(+), 17 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/19/1119/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Add string function repeat and split.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add string function repeat and split.
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1141
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9de5a59807d5ff51fa5d72444053f87cf8dd289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/546/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No

Change in asterixdb[master]: Add string function repeat and split.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1141

to look at the new patch set (#3).

Change subject: Add string function repeat and split.
..

Add string function repeat and split.

Change-Id: Ib9de5a59807d5ff51fa5d72444053f87cf8dd289
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/repeat/repeat.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/repeat_error/repeat_error.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/split/split.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/repeat/repeat.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/split/split.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java
R 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringIntToStringTypeComputer.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringToInt64ListTypeComputer.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringToStringListTypeComputer.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRepeatDescriptor.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringSplitDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java
14 files changed, 536 insertions(+), 17 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/41/1141/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1141
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9de5a59807d5ff51fa5d72444053f87cf8dd289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Add string function repeat and split.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add string function repeat and split.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2504/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1141
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9de5a59807d5ff51fa5d72444053f87cf8dd289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1628) The number of partitions in External Hash-Groupby is calculated improperly for smaller data size.

[Taewoo Kim (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458993#comment-15458993
 ] 

Taewoo Kim commented on ASTERIXDB-1628:
---

The slide 8 and 9 of the following presentation might be helpful.
https://docs.google.com/presentation/d/1AExoTqQlx9va-AaiZ6OSPxBuQ3NJqz-cG5NGrjdk5FU/edit?usp=sharing


> The number of partitions in External Hash-Groupby is calculated improperly 
> for smaller data size.
> -
>
> Key: ASTERIXDB-1628
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1628
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Taewoo Kim
>Assignee: Taewoo Kim
>  Labels: soon
>
> If the number of frames required for a data (e.g., external file), say A,  is 
> slightly larger than the number of available frames (= memory budget), say B, 
> then the number of partitions may be calculated as 1 and it will cause the 
> infinite cycles during the merge phase.
> If the number of partition is 1, the current code assumes that there is no 
> spilling due to the out of memory budget and the output of the build phase is 
> directly generated as the final output. 
> But, if A > B, then a spill would happen and once a partition is spilled to 
> the disk, it can't be generated as the final output. So, the merge process 
> goes to the next round that just creates only one partition again and tries 
> to generate some as final output. But, it can't. Thus, an infinite cycle 
> begins.
> The resolution is that if A > B, we should not set the number of partition as 
> one.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1628) The number of partitions in External Hash-Groupby is calculated improperly for smaller data size.

[Taewoo Kim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Taewoo Kim updated ASTERIXDB-1628:
--
Labels: soon  (was: )

> The number of partitions in External Hash-Groupby is calculated improperly 
> for smaller data size.
> -
>
> Key: ASTERIXDB-1628
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1628
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Taewoo Kim
>Assignee: Taewoo Kim
>  Labels: soon
>
> If the number of frames required for a data (e.g., external file), say A,  is 
> slightly larger than the number of available frames (= memory budget), say B, 
> then the number of partitions may be calculated as 1 and it will cause the 
> infinite cycles during the merge phase.
> If the number of partition is 1, the current code assumes that there is no 
> spilling due to the out of memory budget and the output of the build phase is 
> directly generated as the final output. 
> But, if A > B, then a spill would happen and once a partition is spilled to 
> the disk, it can't be generated as the final output. So, the merge process 
> goes to the next round that just creates only one partition again and tries 
> to generate some as final output. But, it can't. Thus, an infinite cycle 
> begins.
> The resolution is that if A > B, we should not set the number of partition as 
> one.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ASTERIXDB-1628) The number of partitions in External Hash-Groupby is calculated improperly for smaller data size.

[Taewoo Kim (JIRA)]

Taewoo Kim created ASTERIXDB-1628:
-

 Summary: The number of partitions in External Hash-Groupby is 
calculated improperly for smaller data size.
 Key: ASTERIXDB-1628
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1628
 Project: Apache AsterixDB
  Issue Type: Bug
Reporter: Taewoo Kim
Assignee: Taewoo Kim


If the number of frames required for a data (e.g., external file), say A,  is 
slightly larger than the number of available frames (= memory budget), say B, 
then the number of partitions may be calculated as 1 and it will cause the 
infinite cycles during the merge phase.

If the number of partition is 1, the current code assumes that there is no 
spilling due to the out of memory budget and the output of the build phase is 
directly generated as the final output. 

But, if A > B, then a spill would happen and once a partition is spilled to the 
disk, it can't be generated as the final output. So, the merge process goes to 
the next round that just creates only one partition again and tries to generate 
some as final output. But, it can't. Thus, an infinite cycle begins.

The resolution is that if A > B, we should not set the number of partition as 
one.   




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/546/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2503/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Wenhai Li (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1076

to look at the new patch set (#5).

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..

Applied the multiway fuzzyjoin based on the prefix-based join and the 
selectFuzzyJoin testCases.

The following commits from your working branch will be included:

commit 53cc48b1b8579a8c3355849f0fc619af3d76daba
Author: Michael 
Date:   Fri Aug 12 11:34:21 2016 -0700

Initial fuzzy join framework with multiple split and temporary ngram fix.

Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/FuzzyUtils.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
A asterixdb/asterix-app/data/dblp-small/csx-small-multi-id.txt
A asterixdb/asterix-app/data/dblp-small/dblp-small-multi-id.txt
A asterixdb/asterix-app/data/pub-small/csx-small-multi-id.txt
A asterixdb/asterix-app/data/pub-small/dblp-small-multi-id.txt
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join-noeqjoin/ngram-jaccard-inline.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join-noeqjoin/word-jaccard-inline.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/issue741.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/leftouterjoin-probe-pidx-with-join-jaccard-check-idx_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-fuzzyeq-jaccard_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-fuzzyeq-jaccard_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-fuzzyeq-jaccard_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_04.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard_04.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-fuzzyeq-jaccard_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-fuzzyeq-jaccard_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-fuzzyeq-jaccard_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard-check-after-btree-access.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard-check_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard-check_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard-check_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard-check_04.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard_04.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/inverted-index-join/leftouterjoin-probe-pidx-with-join-jaccard-check-idx_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/inverted-index-join/ngram-fuzzyeq-jaccard_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/inverted-index-join/ngram-jaccard-check_01.plan
M 

[jira] [Commented] (ASTERIXDB-1238) Refactor AqlMetadataProvider

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458602#comment-15458602
 ] 

ASF subversion and git services commented on ASTERIXDB-1238:


Commit 55a558f21a5b7d864f46b4bd247f7719e7fe864b in asterixdb's branch 
refs/heads/master from [~mhubail]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=55a558f ]

ASTERIXDB-1238: Refactor AqlMetadataProvider

Change-Id: If2720817c5659622e1f713653856825d612eb892
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1016
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: abdullah alamoudi 


> Refactor AqlMetadataProvider
> 
>
> Key: ASTERIXDB-1238
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1238
> Project: Apache AsterixDB
>  Issue Type: Improvement
>  Components: AsterixDB, Metadata
>Reporter: Abdullah Alamoudi
>Assignee: Murtadha Hubail
>Priority: Minor
>
> The infamous AqlMetadataProvider is over stuffed with compiler related 
> functionalities. In particular, the task of transforming physical operator 
> into hyracks operator descriptors.
> It grew to more than 3000 lines of code and clearly needs to be refactored.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1238: Refactor AqlMetadataProvider

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1238: Refactor AqlMetadataProvider
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1016
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2720817c5659622e1f713653856825d612eb892
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1238: Refactor AqlMetadataProvider

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1238: Refactor AqlMetadataProvider
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/545/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1016
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2720817c5659622e1f713653856825d612eb892
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1238: Refactor AqlMetadataProvider

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1238: Refactor AqlMetadataProvider
..


Patch Set 7:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/545/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1016
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2720817c5659622e1f713653856825d612eb892
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1627) create-polygon() from array of double is giving wrong numbers

[Wail Alkowaileet (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457874#comment-15457874
 ] 

Wail Alkowaileet commented on ASTERIXDB-1627:
-

I suspect this bug is related to:
https://issues.apache.org/jira/browse/ASTERIXDB-1616
and 
https://issues.apache.org/jira/browse/ASTERIXDB-1334

No sure though.

> create-polygon() from array of double is giving wrong numbers
> -
>
> Key: ASTERIXDB-1627
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1627
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Data Formats, Data Model
>Reporter: Wail Alkowaileet
>
> Hi,
> Data:
> https://www.dropbox.com/s/52c6uxufuldqzmm/statesJson.zip?dl=0
> DDL:
> {noformat}
> drop dataverse TwitterDataverse if exists
> create dataverse TwitterDataverse
> use dataverse TwitterDataverse
> create type StateType as {
> uid: uuid
> }
> create dataset States(StateType) 
> primary key uid autogenerated
> {noformat}
> DML:
> {noformat}
> use dataverse TwitterDataverse
> load dataset States using localfs
> (("path"="localhost:///path/to/statesJson"),
> ("format"="adm"))
> {noformat}
> Get the array of doubles from the GeoJSON:
> {noformat}
> use dataverse TwitterDataverse
> let $polygon := (for $x in dataset States
> where $x.features[0].geometry.'type' = "Polygon"
> limit 1
> let $list := (for $i in $x.features[0].geometry.coordinates[0]
> for $j in $i
> for $k in $j
> return $k
> )
> return $list
> )
> return $polygon
> {noformat}
> Output:
> {noformat}
> [ -87.359296, 35.00118, -85.606675, 34.984749, -85.431413, 34.124869, 
> -85.184951, 32.859696, -85.069935, 32.580372, -84.960397, 32.421541, 
> -85.004212, 32.322956, -84.889196, 32.262709, -85.058981, 32.13674, 
> -85.053504, 32.01077, -85.141136, 31.840985, -85.042551, 31.539753, 
> -85.113751, 31.27686, -85.004212, 31.003013, -85.497137, 30.997536, 
> -87.600282, 30.997536, -87.633143, 30.86609, -87.408589, 30.674397, 
> -87.446927, 30.510088, -87.37025, 30.427934, -87.518128, 30.280057, 
> -87.655051, 30.247195, -87.90699, 30.411504, -87.934375, 30.657966, 
> -88.011052, 30.685351, -88.10416, 30.499135, -88.137022, 30.318396, 
> -88.394438, 30.367688, -88.471115, 31.895754, -88.241084, 33.796253, 
> -88.098683, 34.891641, -88.202745, 34.995703, -87.359296, 35.00118 ]
> {noformat}
> applying create-polygon() on the resulting array:
> {noformat}
> use dataverse TwitterDataverse
> let $polygon := (for $x in dataset States
> where $x.features[0].geometry.'type' = "Polygon"
> limit 1
> let $list := (for $i in $x.features[0].geometry.coordinates[0]
> for $j in $i
> for $k in $j
> return $k
> )
> return $list
> )
> return create-polygon($polygon)
> {noformat}
> Output:
> {noformat}
> polygon("2.920390972995509E-247,1.1352293178511514E-249 
> 2.920084986948524E-247,1.1352270767181132E-249 
> 2.9200543883612843E-247,1.1351097919833495E-249 
> 2.920011359130714E-247,1.1349372266489597E-249 
> 2.919991278753279E-247,1.1348991277964998E-249 
> 2.919972154767195E-247,1.1348774637832571E-249 
> 2.919979804326711E-247,1.1348640171214245E-249 
> 2.919959723949276E-247,1.1348557996336175E-249 
> 2.919989366319753E-247,1.1348386178864513E-249 
> 2.91998841010299E-247,1.1348214360028882E-249 
> 2.9200037095711975E-247,1.1347765887907304E-249 
> 2.919986497844052E-247,1.134694414731042E-249 
> 2.9199989284873825E-247,1.1346226992921991E-249 
> 2.919979804326711E-247,1.1345479956759716E-249 
> 2.92006586296244E-247,1.1345465015872795E-249 
> 2.920433046183905E-247,1.1345465015872795E-249 
> 2.920438783309895E-247,1.1345106440042545E-249 
> 2.920399578946376E-247,1.134458351445616E-249 
> 2.920406272289129E-247,1.134413529057645E-249 
> 2.9203928854290354E-247,1.13439111856E-249 
> 2.920418703107048E-247,1.1343507781509548E-249 
> 2.9204426081769465E-247,1.134341813618802E-249 
> 2.9204865936242805E-247,1.134386636006773E-249 
> 2.920491374708095E-247,1.1344538691795396E-249 
> 2.920504761568189E-247,1.1344613396230002E-249 
> 2.920521017078572E-247,1.1344105411530538E-249 
> 2.92052675437915E-247,1.1343612367717997E-249 
> 2.9205716960432465E-247,1.1343746832972356E-249 
> 2.92058508290334E-247,1.1347915294048584E-249 
> 2.9205449223230584E-247,1.1350649698681716E-249 
> 2.9205200608618086E-247,1.1352143771006265E-249 
> 2.920538228805718E-247,1.1352285708068053E-249 
> 2.920390972995509E-247,1.1352293178511514E-249")
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1627) create-polygon() from array of double is giving wrong numbers

[Wail Alkowaileet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wail Alkowaileet updated ASTERIXDB-1627:

Description: 
Hi,
Data:
https://www.dropbox.com/s/52c6uxufuldqzmm/statesJson.zip?dl=0

DDL:
{noformat}
drop dataverse TwitterDataverse if exists
create dataverse TwitterDataverse
use dataverse TwitterDataverse

create type StateType as {
uid: uuid
}

create dataset States(StateType) 
primary key uid autogenerated
{noformat}

DML:
{noformat}
use dataverse TwitterDataverse
load dataset States using localfs
(("path"="localhost:///path/to/statesJson"),
("format"="adm"))
{noformat}

Get the array of doubles from the GeoJSON:
{noformat}
use dataverse TwitterDataverse
let $polygon := (for $x in dataset States
where $x.features[0].geometry.'type' = "Polygon"
limit 1

let $list := (for $i in $x.features[0].geometry.coordinates[0]
for $j in $i
for $k in $j
return $k
)
return $list
)
return $polygon
{noformat}

Output:
{noformat}
[ -87.359296, 35.00118, -85.606675, 34.984749, -85.431413, 34.124869, 
-85.184951, 32.859696, -85.069935, 32.580372, -84.960397, 32.421541, 
-85.004212, 32.322956, -84.889196, 32.262709, -85.058981, 32.13674, -85.053504, 
32.01077, -85.141136, 31.840985, -85.042551, 31.539753, -85.113751, 31.27686, 
-85.004212, 31.003013, -85.497137, 30.997536, -87.600282, 30.997536, 
-87.633143, 30.86609, -87.408589, 30.674397, -87.446927, 30.510088, -87.37025, 
30.427934, -87.518128, 30.280057, -87.655051, 30.247195, -87.90699, 30.411504, 
-87.934375, 30.657966, -88.011052, 30.685351, -88.10416, 30.499135, -88.137022, 
30.318396, -88.394438, 30.367688, -88.471115, 31.895754, -88.241084, 33.796253, 
-88.098683, 34.891641, -88.202745, 34.995703, -87.359296, 35.00118 ]
{noformat}

applying create-polygon() on the resulting array:
{noformat}
use dataverse TwitterDataverse
let $polygon := (for $x in dataset States
where $x.features[0].geometry.'type' = "Polygon"
limit 1

let $list := (for $i in $x.features[0].geometry.coordinates[0]
for $j in $i
for $k in $j
return $k
)
return $list
)
return create-polygon($polygon)
{noformat}

Output:
{noformat}
polygon("2.920390972995509E-247,1.1352293178511514E-249 
2.920084986948524E-247,1.1352270767181132E-249 
2.9200543883612843E-247,1.1351097919833495E-249 
2.920011359130714E-247,1.1349372266489597E-249 
2.919991278753279E-247,1.1348991277964998E-249 
2.919972154767195E-247,1.1348774637832571E-249 
2.919979804326711E-247,1.1348640171214245E-249 
2.919959723949276E-247,1.1348557996336175E-249 
2.919989366319753E-247,1.1348386178864513E-249 
2.91998841010299E-247,1.1348214360028882E-249 
2.9200037095711975E-247,1.1347765887907304E-249 
2.919986497844052E-247,1.134694414731042E-249 
2.9199989284873825E-247,1.1346226992921991E-249 
2.919979804326711E-247,1.1345479956759716E-249 
2.92006586296244E-247,1.1345465015872795E-249 
2.920433046183905E-247,1.1345465015872795E-249 
2.920438783309895E-247,1.1345106440042545E-249 
2.920399578946376E-247,1.134458351445616E-249 
2.920406272289129E-247,1.134413529057645E-249 
2.9203928854290354E-247,1.13439111856E-249 
2.920418703107048E-247,1.1343507781509548E-249 
2.9204426081769465E-247,1.134341813618802E-249 
2.9204865936242805E-247,1.134386636006773E-249 
2.920491374708095E-247,1.1344538691795396E-249 
2.920504761568189E-247,1.1344613396230002E-249 
2.920521017078572E-247,1.1344105411530538E-249 
2.92052675437915E-247,1.1343612367717997E-249 
2.9205716960432465E-247,1.1343746832972356E-249 
2.92058508290334E-247,1.1347915294048584E-249 
2.9205449223230584E-247,1.1350649698681716E-249 
2.9205200608618086E-247,1.1352143771006265E-249 
2.920538228805718E-247,1.1352285708068053E-249 
2.920390972995509E-247,1.1352293178511514E-249")
{noformat}



  was:
Hi,
Data:
https://www.dropbox.com/s/52c6uxufuldqzmm/statesJson.zip?dl=0

DDL:
{noformat}
drop dataverse TwitterDataverse if exists
create dataverse TwitterDataverse
use dataverse TwitterDataverse

create type StateType as {
uid: uuid
}

create dataset States(StateType) 
primary key uid autogenerated
{noformat}

DML:
{noformat}
use dataverse TwitterDataverse
load dataset States using localfs
(("path"="localhost:///path/to/statesJson"),
("format"="adm"))
{noformat}

Get the array of doubles from the GeoJSON:
{noformat}
use dataverse TwitterDataverse
let $polygon := (for $x in dataset States
where $x.features[0].geometry.'type' = "Polygon"
limit 1

let $list := (for $i in $x.features[0].geometry.coordinates[0]
for $j in $i
for $k in $j
return $k
)
return $list
)
return $polygon
{noformat}

Output:
{noformat}
[ -87.359296, 35.00118, -85.606675, 34.984749, -85.431413, 34.124869, 
-85.184951, 32.859696, -85.069935, 32.580372, -84.960397, 32.421541, 
-85.004212, 32.322956, -84.889196, 32.262709, -85.058981, 32.13674, -85.053504, 
32.01077, -85.141136, 31.840985, -85.042551, 31.539753, -85.113751, 31.27686, 
-85.004212, 31.003013, -85.497137, 30.997536, -87.600282, 30.997536, 

[jira] [Created] (ASTERIXDB-1627) create-polygon() from array of double is giving wrong numbers

[Wail Alkowaileet (JIRA)]

Wail Alkowaileet created ASTERIXDB-1627:
---

 Summary: create-polygon() from array of double is giving wrong 
numbers
 Key: ASTERIXDB-1627
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1627
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: Data Formats, Data Model
Reporter: Wail Alkowaileet


Hi,
Data:
https://www.dropbox.com/s/52c6uxufuldqzmm/statesJson.zip?dl=0

DDL:
{noformat}
drop dataverse TwitterDataverse if exists
create dataverse TwitterDataverse
use dataverse TwitterDataverse

create type StateType as {
uid: uuid
}

create dataset States(StateType) 
primary key uid autogenerated
{noformat}

DML:
{noformat}
use dataverse TwitterDataverse
load dataset States using localfs
(("path"="localhost:///path/to/statesJson"),
("format"="adm"))
{noformat}

Get the array of doubles from the GeoJSON:
{noformat}
use dataverse TwitterDataverse
let $polygon := (for $x in dataset States
where $x.features[0].geometry.'type' = "Polygon"
limit 1

let $list := (for $i in $x.features[0].geometry.coordinates[0]
for $j in $i
for $k in $j
return $k
)
return $list
)
return $polygon
{noformat}

Output:
{noformat}
[ -87.359296, 35.00118, -85.606675, 34.984749, -85.431413, 34.124869, 
-85.184951, 32.859696, -85.069935, 32.580372, -84.960397, 32.421541, 
-85.004212, 32.322956, -84.889196, 32.262709, -85.058981, 32.13674, -85.053504, 
32.01077, -85.141136, 31.840985, -85.042551, 31.539753, -85.113751, 31.27686, 
-85.004212, 31.003013, -85.497137, 30.997536, -87.600282, 30.997536, 
-87.633143, 30.86609, -87.408589, 30.674397, -87.446927, 30.510088, -87.37025, 
30.427934, -87.518128, 30.280057, -87.655051, 30.247195, -87.90699, 30.411504, 
-87.934375, 30.657966, -88.011052, 30.685351, -88.10416, 30.499135, -88.137022, 
30.318396, -88.394438, 30.367688, -88.471115, 31.895754, -88.241084, 33.796253, 
-88.098683, 34.891641, -88.202745, 34.995703, -87.359296, 35.00118 ]
{noformat}

applying create-polygon() on the resulting array:
{noformat}
use dataverse TwitterDataverse
let $polygon := (for $x in dataset States
where $x.features[0].geometry.'type' = "Polygon"
limit 1

let $list := (for $i in $x.features[0].geometry.coordinates[0]
for $j in $i
for $k in $j
return $k
)
return $list
)
return create-polygon($polygon)

Output:
{noformat}
polygon("2.920390972995509E-247,1.1352293178511514E-249 
2.920084986948524E-247,1.1352270767181132E-249 
2.9200543883612843E-247,1.1351097919833495E-249 
2.920011359130714E-247,1.1349372266489597E-249 
2.919991278753279E-247,1.1348991277964998E-249 
2.919972154767195E-247,1.1348774637832571E-249 
2.919979804326711E-247,1.1348640171214245E-249 
2.919959723949276E-247,1.1348557996336175E-249 
2.919989366319753E-247,1.1348386178864513E-249 
2.91998841010299E-247,1.1348214360028882E-249 
2.9200037095711975E-247,1.1347765887907304E-249 
2.919986497844052E-247,1.134694414731042E-249 
2.9199989284873825E-247,1.1346226992921991E-249 
2.919979804326711E-247,1.1345479956759716E-249 
2.92006586296244E-247,1.1345465015872795E-249 
2.920433046183905E-247,1.1345465015872795E-249 
2.920438783309895E-247,1.1345106440042545E-249 
2.920399578946376E-247,1.134458351445616E-249 
2.920406272289129E-247,1.134413529057645E-249 
2.9203928854290354E-247,1.13439111856E-249 
2.920418703107048E-247,1.1343507781509548E-249 
2.9204426081769465E-247,1.134341813618802E-249 
2.9204865936242805E-247,1.134386636006773E-249 
2.920491374708095E-247,1.1344538691795396E-249 
2.920504761568189E-247,1.1344613396230002E-249 
2.920521017078572E-247,1.1344105411530538E-249 
2.92052675437915E-247,1.1343612367717997E-249 
2.9205716960432465E-247,1.1343746832972356E-249 
2.92058508290334E-247,1.1347915294048584E-249 
2.9205449223230584E-247,1.1350649698681716E-249 
2.9205200608618086E-247,1.1352143771006265E-249 
2.920538228805718E-247,1.1352285708068053E-249 
2.920390972995509E-247,1.1352293178511514E-249")
{noformat}





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ASTERIXDB-1616) NPE when printing record inside open type with unicode fields

[Wail Alkowaileet (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457826#comment-15457826
 ] 

Wail Alkowaileet commented on ASTERIXDB-1616:
-

Hi Ian,

Unfortunately, I tried to see what's going on but really couldn't figure it out.

> NPE when printing record inside open type with unicode fields
> -
>
> Key: ASTERIXDB-1616
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1616
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Ian Maxon
>Assignee: Ian Maxon
>
> DDL: 
> https://github.com/kevincoakley/asterixdb_tests/blob/master/notebooks/asterixdb-spark/Count%20one_percent%20Tweets%20Spark%20Single.ipynb
> Data: 
> https://object.cloud.sdsc.edu/v1/AUTH_kcoakley/asterixdblogs/2015_11_07_00_onepercent.txt
> Basically just a scan+limit on the one_percent dataset will give 
> IndexOutOfBounds. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1238: Refactor AqlMetadataProvider

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1238: Refactor AqlMetadataProvider
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2502/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1016
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2720817c5659622e1f713653856825d612eb892
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No