Change in asterixdb[master]: Disable search in upsert with no secondary indexes
Jenkins has posted comments on this change. Change subject: Disable search in upsert with no secondary indexes .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1077/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4af1dc73ec909b98ce0c981c687f1b9bf13030fa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Disable search in upsert with no secondary indexes
Jenkins has posted comments on this change. Change subject: Disable search in upsert with no secondary indexes .. Patch Set 1: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1077/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4af1dc73ec909b98ce0c981c687f1b9bf13030fa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Disable search in upsert with no secondary indexes
Jenkins has posted comments on this change. Change subject: Disable search in upsert with no secondary indexes .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2641/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1711 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4af1dc73ec909b98ce0c981c687f1b9bf13030fa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/268/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/264/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3654/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5131/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/447/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2642/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/189/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Cleanup Logging, Report Joined Nodes, Misc Cleanup
Michael Blow has submitted this change and it was merged.
Change subject: Cleanup Logging, Report Joined Nodes, Misc Cleanup
..
Cleanup Logging, Report Joined Nodes, Misc Cleanup
- Minor refactoring of NodeControllerService startup
- Cleanup logging in GlobalRecoveryManager / LifeCycleComponentManager
- Enable TestExecutor to accept non-200 status codes
- Use ExecutorService for GlobalRecovery thread
- Eliminate NPE when metadata node goes down before global recovery
starts
Change-Id: I87b6b45e1a0cdc7a8b77d80b4e603d927aa60b8a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1706
Tested-by: Jenkins
BAD: Jenkins
Reviewed-by: Till Westmann
Integration-Tests: Jenkins
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/ICCServiceContext.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/lifecycle/LifeCycleComponentManager.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCDriver.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
8 files changed, 177 insertions(+), 170 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
index 9c66f57..bf7d5eb 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
@@ -123,7 +123,7 @@
.create(ClusterProperties.INSTANCE.getCluster(), repStrategy,
ccServiceCtx);
ExternalLibraryUtils.setUpExternaLibraries(libraryManager, false);
componentProvider = new StorageComponentProvider();
-GlobalRecoveryManager.instantiate((HyracksConnection) getHcc(),
componentProvider);
+GlobalRecoveryManager.instantiate(ccServiceCtx, getHcc(),
componentProvider);
appCtx = new CcApplicationContext(ccServiceCtx, getHcc(),
libraryManager, resourceIdManager,
() -> MetadataManager.INSTANCE,
GlobalRecoveryManager.instance(), ftStrategy,
new ActiveLifecycleListener());
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
index 722bb78..1816a25 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
@@ -45,7 +45,8 @@
import org.apache.asterix.metadata.utils.ExternalIndexingOperations;
import org.apache.asterix.metadata.utils.MetadataConstants;
import org.apache.asterix.runtime.utils.ClusterStateManager;
-import org.apache.hyracks.api.client.HyracksConnection;
+import org.apache.hyracks.api.application.ICCServiceContext;
+import org.apache.hyracks.api.client.IHyracksClientConnection;
import org.apache.hyracks.api.job.JobId;
import org.apache.hyracks.api.job.JobSpecification;
@@ -55,10 +56,13 @@
private static GlobalRecoveryManager instance;
private static ClusterState state;
private final IStorageComponentProvider componentProvider;
-private HyracksConnection hcc;
+private final ICCServiceContext ccServiceCtx;
+private IHyracksClientConnection hcc;
-private GlobalRecoveryManager(HyracksConnection hcc,
IStorageComponentProvider componentProvider) {
+private GlobalRecoveryManager(ICCServiceContext ccServiceCtx,
IHyracksClientConnection hcc,
+ IStorageComponentProvider componentProvider)
{
setState(ClusterState.UNUSABLE);
+this.ccServiceCtx = ccServiceCtx;
this.hcc = hcc;
this.componentProvider = componentProvider;
}
@@ -97,142 +101,140 @@
final ClusterState newState = ClusterStateManager.INSTANCE.getState();
boolean needToRecover = !newState.equals(state) && (newState ==
ClusterState.ACTIVE);
if (needToRecover) {
-Thread recoveryThread = new Thread(new Runnable() {
-@Override
-
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 9: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2643/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Taewoo Kim has posted comments on this change.
Change subject: Hyracks Unit tests for LSM Filters
..
Patch Set 9:
(7 comments)
One Q: is there a test for "filtered = true" case? All I saw was "filtered =
false".
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/StubIOOperationCallback.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/StubIOOperationCallback.java:
PS9, Line 35:
Can you move this to the line 28 and make it as a java doc style?
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestDriver.java
File
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestDriver.java:
Line 43: BTreeLeafFrameType leafType, boolean filtered) throws
Exception;
> CRITICAL SonarQube violation:
Can we handle this? Or, it doesn't have to be handled?
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestUtils.java
File
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestUtils.java:
Line 302: if (filtered) {
Please put a simple comment about this? What does this do?
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TreeIndexTestUtils.java
File
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TreeIndexTestUtils.java:
Line 187: boolean filtered, Random rnd) throws Exception {
> CRITICAL SonarQube violation:
Here, too: Exception
Line 210: if (filtered) {
I have a feeling that the same code is repeated. Can we integrate them and put
them in one place? Just a thought.
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTest.java
File
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTest.java:
Line 32:
Can we put java-doc style comments here? What does this test do?
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTestDriver.java
File
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTestDriver.java:
Line 46:
Also, can we put java-doc style comments here?
--
To view, visit https://asterix-gerrit.ics.uci.edu/1704
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon
Gerrit-Reviewer: Ian Maxon
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Jianfeng Jia
Gerrit-Reviewer: Taewoo Kim
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/448/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Jenkins has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3655/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Jenkins has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/265/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Jenkins has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/269/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Jenkins has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5132/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Jenkins has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/449/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Jenkins has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/190/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2642/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Jenkins has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2644/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1078/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2645/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 9: Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2643/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Jenkins has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1079/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1078/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Jenkins has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1079/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5133/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/266/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1709 to look at the new patch set (#4). Change subject: Enable HTTP API processing on NCs .. Enable HTTP API processing on NCs - Query/Status/Result are answered by NC nodes - other HTTP requests are proxied to the CC node - SessionConfig refactoring – split into config and output (SessionOutput) - TestExecutor now can send http requests do multiple nodes (round robin) - Remove dependencies on Xerces Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionOutput.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ResultUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementResponseMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/DefaultStatementExecutorFactory.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/aql/translator/QueryTranslatorTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/async-deferred/AsyncDeferredQueries.xml M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/ICcApplicationContext.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java M asterixdb/asterix-external-data/pom.xml M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/CcApplicationContext.java M asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/xml/TestSuiteParser.java M asterixdb/asterix-yarn/pom.xml M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java A hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ProxyHandler.java 38 files changed, 1,034 insertions(+), 343 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/09/1709/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/270/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3656/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/450/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/191/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Jenkins has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2644/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2646/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Make Index Op Contexts fields private
Ian Maxon has posted comments on this change.
Change subject: Make Index Op Contexts fields private
..
Patch Set 1:
(3 comments)
Couple sonarqube comments that seem prudent to address, other than that +2
https://asterix-gerrit.ics.uci.edu/#/c/1712/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/PartitionedInMemoryInvertedIndex.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/PartitionedInMemoryInvertedIndex.java:
Line 135: inMemListCursor.prepare(ctx.getBtreeAccessor(),
ctx.getBtreePred(), ctx.getTokenFieldsCmp(), ctx.getBtreeCmp());
> MAJOR SonarQube violation:
+1
https://asterix-gerrit.ics.uci.edu/#/c/1712/1/hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTreeOpContext.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTreeOpContext.java:
Line 160: public ArrayList getLSNUpdates() {
> MAJOR SonarQube violation:
+1
Line 172: public ArrayList getNSNUpdates() {
> MAJOR SonarQube violation:
+1
--
To view, visit https://asterix-gerrit.ics.uci.edu/1712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi
Gerrit-Reviewer: Ian Maxon
Gerrit-Reviewer: Jenkins
Gerrit-HasComments: Yes
Change in asterixdb[master]: Make Index Op Contexts fields private
Jenkins has posted comments on this change. Change subject: Make Index Op Contexts fields private .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2645/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1080/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: BAD-1 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1080/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Enable HTTP API processing on NCs
Jenkins has posted comments on this change. Change subject: Enable HTTP API processing on NCs .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2646/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Ian Maxon has posted comments on this change.
Change subject: Hyracks Unit tests for LSM Filters
..
Patch Set 9:
(7 comments)
> (7 comments)
>
> One Q: is there a test for "filtered = true" case? All I saw was
> "filtered = false".
Yes, it is in LSMBTreeFilterMergeTestDriver. That is the impetus behind adding
the parameter :)
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/StubIOOperationCallback.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/StubIOOperationCallback.java:
PS9, Line 35:
> Can you move this to the line 28 and make it as a java doc style?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestDriver.java
File
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestDriver.java:
Line 43: BTreeLeafFrameType leafType, boolean filtered) throws
Exception;
> Can we handle this? Or, it doesn't have to be handled?
That would require changing quite a lot.The original signature had this.
Sonarqube is just complaining because I changed that line for other reasons.
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestUtils.java
File
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestUtils.java:
Line 302: if (filtered) {
> Please put a simple comment about this? What does this do?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TreeIndexTestUtils.java
File
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TreeIndexTestUtils.java:
Line 187: boolean filtered, Random rnd) throws Exception {
> Here, too: Exception
See other comment.
Line 210: if (filtered) {
> I have a feeling that the same code is repeated. Can we integrate them and
Good point, refactored.
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTest.java
File
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTest.java:
Line 32:
> Can we put java-doc style comments here? What does this test do?
This is the purpose of the change. It does what LSMBTreeMergeTest does but, it
does it with a filter and validates the filter state on each step of the
test.The comments are in the Driver class which has the actual test.
https://asterix-gerrit.ics.uci.edu/#/c/1704/9/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTestDriver.java
File
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTestDriver.java:
Line 46:
> Also, can we put java-doc style comments here?
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1704
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon
Gerrit-Reviewer: Ian Maxon
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Jianfeng Jia
Gerrit-Reviewer: Taewoo Kim
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/271/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3657/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/267/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5134/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Hello Jianfeng Jia, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1704 to look at the new patch set (#10). Change subject: Hyracks Unit tests for LSM Filters .. Hyracks Unit tests for LSM Filters Basic tests for filter behaviors in LSMBTrees. Simply uses the PK as the filtering attribute for now. Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 --- M hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/utils/TupleUtils.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/StubIOOperationCallback.java M hyracks-fullstack/hyracks/hyracks-test-support/pom.xml M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexBulkLoadTest.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexDeleteTest.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexInsertTest.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexSortedInsertTest.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestContext.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestDriver.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexTestUtils.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexUpdateTest.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexUpsertTest.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/IndexTestContext.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TreeIndexTestUtils.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/rtree/AbstractRTreeTestContext.java M hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/rtree/AbstractRTreeTestDriver.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeBulkLoadTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeDeleteTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeInsertTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeSearchCursorTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeSortedInsertTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeUpdateTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeUpsertTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/util/BTreeTestContext.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/pom.xml M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeBulkLoadTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeDeleteTest.java A hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTest.java A hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeFilterMergeTestDriver.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeInsertTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeLifecycleTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeMergeTest.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeMergeTestDriver.jav
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/451/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2647/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/192/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5135/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/452/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/268/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/272/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1707 to look at the new patch set (#3). Change subject: Ensure Proper Process is Killed With Managix Stop .. Ensure Proper Process is Killed With Managix Stop Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a --- M asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh M asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh M asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh M hyracks-fullstack/pom.xml 4 files changed, 20 insertions(+), 14 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/07/1707/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2648/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3658/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/193/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1081/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1081/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Hyracks Unit tests for LSM Filters
Jenkins has posted comments on this change. Change subject: Hyracks Unit tests for LSM Filters .. Patch Set 10: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2647/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1704 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e79c0a25d5d6be727b9ebad841801024c00e94 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1082/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1082/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2648/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Ian Maxon has posted comments on this change.
Change subject: Ensure Proper Process is Killed With Managix Stop
..
Patch Set 3:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1707/3/asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh
File
asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh:
PS3, Line 20: '{ print $2 }'`
Isn't $2 the TTY not the PID?
https://asterix-gerrit.ics.uci.edu/#/c/1707/3/asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh
File
asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh:
PS3, Line 21:
: INFO=``
seems like this isnt used anymore?
--
To view, visit https://asterix-gerrit.ics.uci.edu/1707
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Ian Maxon
Gerrit-Reviewer: Jenkins
Gerrit-HasComments: Yes
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Xikui Wang has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1713
Change subject: Fix continue ingestion bug when exception happens
..
Fix continue ingestion bug when exception happens
1. Fix the bug when exception happens, localfs adapter couldn't pick up
a new file to continue the ingestion.
2. Change the exception handling from string to error code.
Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676
---
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
5 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/13/1713/1
diff --git
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
index 9de9dde..702cb0a 100644
---
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
+++
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
@@ -117,7 +117,7 @@
public static final int
INPUT_RECORD_RECORD_WITH_METADATA_AND_PK_NULL_IN_NON_OPTIONAL = 3018;
public static final int
INPUT_RECORD_RECORD_WITH_METADATA_AND_PK_CANNT_GET_PKEY = 3019;
public static final int FEED_CHANGE_FEED_CONNECTIVITY_ON_ALIVE_FEED = 3020;
-public static final int
FEED_MANAGEMENT_FEED_EVENT_REGISTER_INTAKE_JOB_FAIL = 3021;
+public static final int RECORD_READER_MALFORMED_INPUT_STREAM = 3021;
public static final int PROVIDER_DATAFLOW_CONTROLLER_UNKNOWN_DATA_SOURCE =
3022;
public static final int
PROVIDER_DATASOURCE_FACTORY_UNKNOWN_INPUT_STREAM_FACTORY = 3023;
public static final int
UTIL_EXTERNAL_DATA_UTILS_FAIL_CREATE_STREAM_FACTORY = 3024;
diff --git
a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
index b6423f6..fa64037 100644
--- a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
+++ b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
@@ -103,7 +103,7 @@
3018 = Field %1$s of meta record is not an optional type so it cannot accept
null value.
3019 = Can't get PK from record part
3020 = This operation cannot be done when Feed %1$s is alive.
-3021 = Could not register feed intake job [%1$s] for feed %2$s
+3021 = Malformed Input Stream.
3022 = Unknown data source type: %1$s
3023 = Unknown input stream factory: %1$s
3024 = Failed to create stream factory
diff --git
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
index 1b12dc1..d01859e 100644
---
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
+++
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
@@ -177,7 +177,7 @@
if (!recordReader.handleException(th)) {
finish();
}
-return closed.get();
+return !closed.get();
}
public IRecordReader getReader() {
diff --git
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
index 4d6d004..7614e6e 100644
---
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
+++
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
@@ -20,7 +20,9 @@
import java.io.IOException;
+import org.apache.asterix.common.exceptions.ErrorCode;
import org.apache.asterix.common.exceptions.ExceptionUtils;
+import org.apache.asterix.common.exceptions.RuntimeDataException;
import org.apache.asterix.external.api.AsterixInputStream;
import org.apache.asterix.external.util.ExternalDataConstants;
import org.apache.hyracks.api.exceptions.HyracksDataException;
@@ -101,7 +103,7 @@
// corrupted file. clear the buffer and stop reading
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Jenkins has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/273/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Jenkins has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/453/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Jenkins has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/269/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Jenkins has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2649/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Jenkins has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3659/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Jenkins has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5136/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Jenkins has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/194/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/454/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1707 to look at the new patch set (#4). Change subject: Ensure Proper Process is Killed With Managix Stop .. Ensure Proper Process is Killed With Managix Stop Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a --- M asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh M asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh M asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh M hyracks-fullstack/pom.xml 4 files changed, 19 insertions(+), 14 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/07/1707/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/274/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/270/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Michael Blow has posted comments on this change.
Change subject: Ensure Proper Process is Killed With Managix Stop
..
Patch Set 3:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1707/3/asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh
File
asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh:
PS3, Line 20: '{ print $2 }'`
> Isn't $2 the TTY not the PID?
not with -f, PID is $2, PPID is $3
https://asterix-gerrit.ics.uci.edu/#/c/1707/3/asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh
File
asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh:
PS3, Line 21:
: INFO=``
> seems like this isnt used anymore?
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1707
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Ian Maxon
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-HasComments: Yes
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2650/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/195/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5137/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Jenkins has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3660/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Refactor TestExecutor
Michael Blow has posted comments on this change. Change subject: Refactor TestExecutor .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Ian Maxon has posted comments on this change.
Change subject: Ensure Proper Process is Killed With Managix Stop
..
Patch Set 3:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1707/3/asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh
File
asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh:
PS3, Line 20: '{ print $2 }'`
> not with -f, PID is $2, PPID is $3
Oh, derp, I was testing it locally with the wrong arg.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1707
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Ian Maxon
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-HasComments: Yes
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Ian Maxon has posted comments on this change. Change subject: Ensure Proper Process is Killed With Managix Stop .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1707 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Jenkins has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1083/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Jenkins has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens .. Patch Set 1: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1083/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Remove Unused / Historical Hyracks Modules
Jenkins has posted comments on this change. Change subject: Remove Unused / Historical Hyracks Modules .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5138/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa058eb7c73696e1ead2c05c1ee34dbe9055ce52 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Remove Unused / Historical Hyracks Modules
Jenkins has posted comments on this change. Change subject: Remove Unused / Historical Hyracks Modules .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/275/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa058eb7c73696e1ead2c05c1ee34dbe9055ce52 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Remove Unused / Historical Hyracks Modules
Jenkins has posted comments on this change. Change subject: Remove Unused / Historical Hyracks Modules .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/271/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa058eb7c73696e1ead2c05c1ee34dbe9055ce52 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Remove Unused / Historical Hyracks Modules
Jenkins has posted comments on this change. Change subject: Remove Unused / Historical Hyracks Modules .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/196/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa058eb7c73696e1ead2c05c1ee34dbe9055ce52 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Remove Unused / Historical Hyracks Modules
Jenkins has posted comments on this change. Change subject: Remove Unused / Historical Hyracks Modules .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3661/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa058eb7c73696e1ead2c05c1ee34dbe9055ce52 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Remove Unused / Historical Hyracks Modules
Jenkins has posted comments on this change. Change subject: Remove Unused / Historical Hyracks Modules .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/455/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa058eb7c73696e1ead2c05c1ee34dbe9055ce52 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix continue ingestion bug when exception happens
Jenkins has posted comments on this change. Change subject: Fix continue ingestion bug when exception happens .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2649/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1713 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8656a4d1afabbc1b481eb97509a861b22478676 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Remove Unused / Historical Hyracks Modules
Jenkins has posted comments on this change. Change subject: Remove Unused / Historical Hyracks Modules .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2651/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1714 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa058eb7c73696e1ead2c05c1ee34dbe9055ce52 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure Proper Process is Killed With Managix Stop
Michael Blow has submitted this change and it was merged.
Change subject: Ensure Proper Process is Killed With Managix Stop
..
Ensure Proper Process is Killed With Managix Stop
Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1707
Reviewed-by: Ian Maxon
Sonar-Qube: Jenkins
Tested-by: Jenkins
---
M asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh
M asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh
M asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh
M hyracks-fullstack/pom.xml
4 files changed, 19 insertions(+), 14 deletions(-)
Approvals:
Ian Maxon: Looks good to me, approved
Jenkins: Verified; No violations found
diff --git
a/asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh
b/asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh
index 4663bba..e8bc326 100755
---
a/asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh
+++
b/asterixdb/asterix-events/src/main/resources/events/cc_failure/cc_failure.sh
@@ -17,8 +17,6 @@
# specific language governing permissions and limitations
# under the License.
-CC_PARENT_ID_INFO=`ps -ef | grep asterix | grep cc_start | grep -v ssh`
-CC_PARENT_ID=`echo $CC_PARENT_ID_INFO | tr -s " " | cut -d " " -f2`
-CC_ID_INFO=`ps -ef | grep asterix | grep $CC_PARENT_ID | grep -v bash`
-CC_ID=`echo $CC_ID_INFO | tr -s " " | cut -d " " -f2`
+CC_PARENT_ID=`ps -ef | grep asterix | grep cc_start | grep -v ssh | awk '{
print $2 }'`
+CC_ID=`ps -ef | grep asterix | grep $CC_PARENT_ID | grep -v bash | awk "\\\$3
== $CC_PARENT_ID { print \\\$2 }"`
kill -9 $CC_ID
diff --git
a/asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh
b/asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh
index 9b0dcbb..50dfb26 100755
---
a/asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh
+++
b/asterixdb/asterix-events/src/main/resources/events/node_failure/nc_failure.sh
@@ -19,16 +19,20 @@
NC_ID=$1
-INFO=`ps -ef | grep nc_join | grep -v grep | grep -v ssh| grep $NC_ID | head
-n 1`
-PARENT_ID=`echo $INFO | cut -d " " -f2`
-PID_INFO=`ps -ef | grep asterix | grep -v grep | grep -v nc_join | grep
$PARENT_ID`
-PID=`echo $PID_INFO | cut -d " " -f2`
+PARENT_ID=`ps -ef | grep nc_join | grep -v grep | grep -v ssh| grep $NC_ID |
head -n 1 | awk '{ print $2 }'`
+PID=`ps -ef | grep asterix | awk "\\\$3 == $PARENT_ID { print \\\$2 }"`
kill -15 $PID
-cmd_output=$(ps -ef | awk '{print $2}' |grep "^$PID$")
-while [ ${#cmd_output} -ne 0 ]
+cmd_output=$(ps -ef | awk "\\\$3 == $PID {print \\\$2}")
+tries=0
+while [ ${#cmd_output} -ne 0 -a $tries -lt 15 ]
do
sleep 1
kill -15 $PID
- cmd_output=$(ps -ef | awk '{print $2}' |grep "^$PID$")
+ tries=`expr $tries + 1`
+ cmd_output=$(ps -ef | awk "\\\$3 == $PID {print \\\$2}")
done
+if [ ${#cmd_output} -ne 0 ];
+then
+ kill -9 $PID
+fi
\ No newline at end of file
diff --git
a/asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh
b/asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh
index 5ed2f7e..521b402 100755
---
a/asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh
+++
b/asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh
@@ -24,15 +24,15 @@
if [ $NC_ID == 'ANY' ]
then
NC_ID="."
- PARENT_ID=`ps -ej | tr -s " " | grep nc_join | grep -v grep | grep -v ssh |
cut -d " " -f2 | head -n 1`
+ PARENT_ID=`ps -ej | tr -s " " | grep nc_join | grep -v grep | grep -v ssh |
awk '{ print $2 }' | head -n 1`
PARENT_PROCESS_ENTRY=`ps -ef | grep $PARENT_ID | grep -v grep | head -n 1`
NC_ID=`echo ${PARENT_PROCESS_ENTRY##* }`
echo "NCid is $NC_ID" >> ~/try.txt
else
- PARENT_ID=`ps -ej | tr -s " " | grep nc_join | grep -v grep | grep -v ssh |
grep $NC_ID | cut -d " " -f2 | head -n 1`
+ PARENT_ID=`ps -ej | tr -s " " | grep nc_join | grep -v grep | grep -v ssh |
grep $NC_ID | awk '{ print $2 }' | head -n 1`
fi
-PID=`ps -ej | tr -s " " | grep hyracks | grep -v grep | grep -v nc_join |
grep $PARENT_ID | cut -d " " -f2 | head -n 1`
+PID=`ps -ej | tr -s " " | grep hyracks | grep -v grep | grep -v nc_join | awk
"\\\$3 == $PARENT_ID { print \\\$2 }" | head -n 1`
kill -9 $PID
sleep $3
diff --git a/hyracks-fullstack/pom.xml b/hyracks-fullstack/pom.xml
index 310e346..0ab040b 100644
--- a/hyracks-fullstack/pom.xml
+++ b/hyracks-fullstack/pom.xml
@@ -225,6 +225,9 @@
true
+
+**/*.iml
+
--
To view, visit https://asterix-gerrit.ics.uci.edu/1707
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I781317c8266f5e310fcee771f98a53081d9cc34a
