Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/71/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/946/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3147/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/755/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/675/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/770/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4143/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/337/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1828
Change subject: Attempt to reconnect IPCHandle on connection failure
..
Attempt to reconnect IPCHandle on connection failure
IPCHandles can become invalid due to network interruption or node
crash/restart. Automatically retry connection in event of attempt
to use disconnected handle.
Change-Id: I069dcd59898021054462c8213fb623df2deec598
---
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java
5 files changed, 84 insertions(+), 43 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/28/1828/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
index 79033d8..dc7bad0 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
@@ -54,8 +54,8 @@
CCNCFunctions.NodeRegistrationResult result;
Map ncConfiguration = new HashMap<>();
try {
-INodeController nodeController = new
NodeControllerRemoteProxy(ncIPCHandle);
-NodeControllerState state = new
NodeControllerState(nodeController, reg);
+INodeController nc = new
NodeControllerRemoteProxy(ccs.getClusterIPC(), reg.getNodeControllerAddress());
+NodeControllerState state = new NodeControllerState(nc, reg);
INodeManager nodeManager = ccs.getNodeManager();
nodeManager.addNode(id, state);
IApplicationConfig cfg =
state.getNCConfig().getConfigManager().getNodeEffectiveConfig(id);
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
index 83ef32b..1e4f786 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
@@ -18,7 +18,9 @@
*/
package org.apache.hyracks.control.common.ipc;
+import java.net.InetSocketAddress;
import java.util.List;
+import java.util.logging.Logger;
import org.apache.hyracks.api.comm.NetworkAddress;
import org.apache.hyracks.api.dataflow.TaskAttemptId;
@@ -34,24 +36,47 @@
import org.apache.hyracks.control.common.job.profiling.om.JobProfile;
import org.apache.hyracks.control.common.job.profiling.om.TaskProfile;
import org.apache.hyracks.ipc.api.IIPCHandle;
+import org.apache.hyracks.ipc.exceptions.IPCException;
+import org.apache.hyracks.ipc.impl.IPCSystem;
public class ClusterControllerRemoteProxy implements IClusterController {
-private final IIPCHandle ipcHandle;
+private static final Logger LOGGER =
Logger.getLogger(ClusterControllerRemoteProxy.class.getName());
-public ClusterControllerRemoteProxy(IIPCHandle ipcHandle) {
-this.ipcHandle = ipcHandle;
+private final IPCSystem ipc;
+private final InetSocketAddress inetSocketAddress;
+private final int clusterConnectRetries;
+private IIPCHandle ipcHandle;
+
+public ClusterControllerRemoteProxy(IPCSystem ipc, InetSocketAddress
inetSocketAddress, int clusterConnectRetries) {
+this.ipc = ipc;
+this.inetSocketAddress = inetSocketAddress;
+this.clusterConnectRetries = clusterConnectRetries;
+}
+
+private IIPCHandle ensureIpcHandle() throws IPCException {
+final boolean first = ipcHandle == null;
+if (first || !ipcHandle.isConnected()) {
+if (!first) {
+LOGGER.warning("ipcHandle " + ipcHandle + " disconnected;
retrying connection");
+}
+ipcHandle =
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5622/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/61/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Attempt to reconnect IPCHandle on connection failure
Jenkins has posted comments on this change. Change subject: Attempt to reconnect IPCHandle on connection failure .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/47/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1828 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcd59898021054462c8213fb623df2deec598 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Yingyi Bu has submitted this change and it was merged.
Change subject: Cancel the on-going job if waitForCompletion is interrupted.
..
Cancel the on-going job if waitForCompletion is interrupted.
Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1825
Sonar-Qube: Jenkins
Tested-by: Jenkins
BAD: Jenkins
Reviewed-by: Michael Blow
Integration-Tests: Jenkins
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java
M
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractMultiNCIntegrationTest.java
M
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/CancelJobTest.java
3 files changed, 56 insertions(+), 17 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified; No violations found; No violations found; Verified
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java
index 4b3aff2..ad54110 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java
@@ -138,7 +138,13 @@
@Override
public void waitForCompletion(JobId jobId) throws Exception {
-hci.waitForCompletion(jobId);
+try {
+hci.waitForCompletion(jobId);
+} catch (InterruptedException e) {
+// Cancels an on-going job if the current thread gets interrupted.
+hci.cancelJob(jobId);
+throw e;
+}
}
@Override
diff --git
a/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractMultiNCIntegrationTest.java
b/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractMultiNCIntegrationTest.java
index 148d4f5..05a7e2d 100644
---
a/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractMultiNCIntegrationTest.java
+++
b/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractMultiNCIntegrationTest.java
@@ -26,8 +26,6 @@
import java.util.logging.Level;
import java.util.logging.Logger;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.node.ArrayNode;
import org.apache.commons.io.FileUtils;
import org.apache.hyracks.api.client.HyracksConnection;
import org.apache.hyracks.api.client.IHyracksClientConnection;
@@ -40,6 +38,7 @@
import org.apache.hyracks.api.job.JobFlag;
import org.apache.hyracks.api.job.JobId;
import org.apache.hyracks.api.job.JobSpecification;
+import org.apache.hyracks.api.job.JobStatus;
import org.apache.hyracks.api.job.resource.IJobCapacityController;
import org.apache.hyracks.client.dataset.HyracksDataset;
import org.apache.hyracks.control.cc.BaseCCApplication;
@@ -52,8 +51,9 @@
import org.apache.hyracks.dataflow.common.comm.util.ByteBufferInputStream;
import org.junit.AfterClass;
import org.junit.BeforeClass;
-import org.junit.Rule;
-import org.junit.rules.TemporaryFolder;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.node.ArrayNode;
public abstract class AbstractMultiNCIntegrationTest {
@@ -69,9 +69,6 @@
private static IHyracksClientConnection hcc;
private final List outputFiles;
-
-@Rule
-public TemporaryFolder outputFolder = new TemporaryFolder();
public AbstractMultiNCIntegrationTest() {
outputFiles = new ArrayList<>();
@@ -131,6 +128,10 @@
protected void waitForCompletion(JobId jobId) throws Exception {
hcc.waitForCompletion(jobId);
+}
+
+protected JobStatus getJobStatus(JobId jobId) throws Exception {
+return hcc.getJobStatus(jobId);
}
protected void cancelJob(JobId jobId) throws Exception {
@@ -205,15 +206,6 @@
}
}
}
-}
-
-protected File createTempFile() throws IOException {
-File tempFile = File.createTempFile(getClass().getName(), ".tmp",
outputFolder.getRoot());
-if (LOGGER.isLoggable(Level.INFO)) {
-LOGGER.info("Output file: " + tempFile.getAbsolutePath());
-}
-outputFiles.add(tempFile);
-return tempFile;
}
public static class DummyApplication extends BaseCCApplication {
diff --git
a/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/o
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3146/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1380/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3145/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1380/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1938: Keep empty disk components when merge/flush
Dmitry Lychagin has posted comments on this change. Change subject: ASTERIXDB-1938: Keep empty disk components when merge/flush .. Patch Set 2: Code-Review+1 This patch fixes my testcase. -- To view, visit https://asterix-gerrit.ics.uci.edu/1826 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f7ec41f56a2f9124920d67657f88160634f0e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3144/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/70/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/754/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Michael Blow has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3146/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/46/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5621/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/60/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/769/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/336/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/945/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4142/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Jenkins has posted comments on this change. Change subject: Add sendError() to AbstractServlet .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/674/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1827 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add sendError() to AbstractServlet
Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1827
Change subject: Add sendError() to AbstractServlet
..
Add sendError() to AbstractServlet
Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197
---
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
1 file changed, 19 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/27/1827/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
index 1030686..3c41165 100644
---
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
+++
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
@@ -91,10 +91,25 @@
}
}
-protected void notAllowed(HttpMethod method, IServletResponse response)
throws IOException {
-response.setStatus(HttpResponseStatus.METHOD_NOT_ALLOWED);
+protected void sendError(IServletResponse response, HttpResponseStatus
status, String message)
+throws IOException {
+response.setStatus(status);
HttpUtil.setContentType(response, HttpUtil.ContentType.TEXT_PLAIN,
HttpUtil.Encoding.UTF8);
-response.writer().write("Method " + method + " not allowed for the
requested resource.\n");
+if (message != null) {
+response.writer().println(message);
+}
+if (LOGGER.isLoggable(Level.INFO)) {
+LOGGER.info("sendError: status=" + status + ", message=" +
message);
+}
+}
+
+protected void sendError(IServletResponse response, HttpResponseStatus
status) throws IOException {
+sendError(response, status, null);
+}
+
+protected void notAllowed(HttpMethod method, IServletResponse response)
throws IOException {
+sendError(response, HttpResponseStatus.METHOD_NOT_ALLOWED,
+"Method " + method + " not allowed for the requested
resource.");
}
@SuppressWarnings("squid:S1172")
@@ -168,4 +183,5 @@
public String toString() {
return this.getClass().getSimpleName() + Arrays.toString(paths);
}
+
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/1827
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I24a1d5a6d06f37a9a02056b829541ce96a38b197
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1379/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1379/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1378/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3143/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1378/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/944/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/69/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Yingyi Bu has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1825/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java: PS3, Line 146: // Re-interrupts the current thread to make sure that consequent things get interrupted. > I think you don't need to re-interrupt since you are propagating the Interr Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/753/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3145/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/335/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4141/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/768/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/673/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1825 to look at the new patch set (#4). Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Cancel the on-going job if waitForCompletion is interrupted. Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractMultiNCIntegrationTest.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/CancelJobTest.java 3 files changed, 56 insertions(+), 17 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/1825/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/59/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/45/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5620/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Miscellaneous minor cleanups.
Yingyi Bu has submitted this change and it was merged.
Change subject: Miscellaneous minor cleanups.
..
Miscellaneous minor cleanups.
Change-Id: I08911bc62c573da483174a71b71949162ca229f2
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1815
Sonar-Qube: Jenkins
Integration-Tests: Jenkins
Tested-by: Jenkins
BAD: Jenkins
Reviewed-by: Michael Blow
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/ActivityClusterGraphRewriter.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivity.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/base/AbstractOperatorDescriptor.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/result/ResultWriterOperatorDescriptor.java
4 files changed, 17 insertions(+), 17 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified; No violations found; No violations found; Verified
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/ActivityClusterGraphRewriter.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/ActivityClusterGraphRewriter.java
index 38e7fbe..20f128d 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/ActivityClusterGraphRewriter.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/ActivityClusterGraphRewriter.java
@@ -50,7 +50,8 @@
* @author yingyib
*/
public class ActivityClusterGraphRewriter {
-private static String ONE_TO_ONE_CONNECTOR =
"org.apache.hyracks.dataflow.std.connectors.OneToOneConnectorDescriptor";
+private static final String ONE_TO_ONE_CONNECTOR =
"org.apache.hyracks.dataflow.std.connectors."
++ "OneToOneConnectorDescriptor";
/**
* rewrite an activity cluster graph to eliminate
@@ -63,7 +64,7 @@
public void rewrite(ActivityClusterGraph acg) {
acg.getActivityMap().clear();
acg.getConnectorMap().clear();
-Map invertedActivitySuperActivityMap = new
HashMap();
+Map invertedActivitySuperActivityMap = new
HashMap<>();
for (Entry entry :
acg.getActivityClusterMap().entrySet()) {
rewriteIntraActivityCluster(entry.getValue(),
invertedActivitySuperActivityMap);
}
@@ -82,18 +83,18 @@
private void rewriteInterActivityCluster(ActivityCluster ac,
Map invertedActivitySuperActivityMap) {
Map> blocked2BlockerMap =
ac.getBlocked2BlockerMap();
-Map invertedAid2SuperAidMap = new
HashMap();
+Map invertedAid2SuperAidMap = new HashMap<>();
for (Entry entry :
invertedActivitySuperActivityMap.entrySet()) {
invertedAid2SuperAidMap.put(entry.getKey().getActivityId(),
entry.getValue().getActivityId());
}
-Map> replacedBlocked2BlockerMap = new
HashMap>();
+Map> replacedBlocked2BlockerMap = new
HashMap<>();
for (Entry> entry :
blocked2BlockerMap.entrySet()) {
ActivityId blocked = entry.getKey();
ActivityId replacedBlocked = invertedAid2SuperAidMap.get(blocked);
Set blockers = entry.getValue();
Set replacedBlockers = null;
if (blockers != null) {
-replacedBlockers = new HashSet();
+replacedBlockers = new HashSet<>();
for (ActivityId blocker : blockers) {
replacedBlockers.add(invertedAid2SuperAidMap.get(blocker));
ActivityCluster dependingAc =
ac.getActivityClusterGraph().getActivityMap()
@@ -131,9 +132,9 @@
Map,
Pair>> connectorActivityMap = ac
.getConnectorActivityMap();
ActivityClusterGraph acg = ac.getActivityClusterGraph();
-Map startActivities = new HashMap();
-Map superActivities = new
HashMap();
-Map> toBeExpendedMap = new
HashMap>();
+Map startActivities = new HashMap<>();
+Map superActivities = new HashMap<>();
+Map> toBeExpendedMap = new HashMap<>();
/**
* Build the initial super activities
@@ -234,8 +235,8 @@
Map connMap =
ac.getConnectorMap();
Map connRecordDesc =
ac.getConnectorRecordDescriptorMap();
-Map superActivityProducerPort = new
HashMap();
-Map superActivityConsumerPort = new
HashMap();
+Map superActivityProducerPort = new
HashMap<>();
+Map superActivityConsumerPort = new
HashMap<>();
for (Entry entry :
superActivities.entrySet()) {
superActivityProducerPort.put(entry.getValue(), 0);
superActivityConsumerPort.put(entry.getValue(), 0);
@@ -305,7 +306,7 @@
*/
for (Entry entry :
superActivities.entrySet()) {
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/68/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Till Westmann has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Code-Review+1 Just rebased - anybody feel free to submit. -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/752/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3144/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/58/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1618 to look at the new patch set (#42). Change subject: Support IFrameWriter contract check. .. Support IFrameWriter contract check. - add a instance-level flag for injecting operators to check IFrameWriter contract violations; - check contract violations in runtime tests. Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/aql/translator/QueryTranslatorTest.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JobUtils.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SinkPOperator.java A hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/EnforcePushRuntime.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IPushRuntime.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/AggregateRuntimeFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputPushRuntime.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputSinkPushRuntime.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputSourcePushRuntime.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/AlgebricksMetaOperatorDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/sort/InMemorySortRuntimeFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/EmptyTupleSourceRuntimeFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/NestedTupleSourceRuntimeFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/RunningAggregateRuntimeFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/SinkWriterRuntime.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/StreamSelectRuntimeFactory.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksTaskContext.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/EnforceFrameWriter.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/IOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobFlag.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobRun.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/JobStartWork.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apach
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4140/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/672/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/767/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/943/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5619/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/334/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Support IFrameWriter contract check.
Jenkins has posted comments on this change. Change subject: Support IFrameWriter contract check. .. Patch Set 42: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/44/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Miscellaneous minor cleanups.
Michael Blow has posted comments on this change. Change subject: Miscellaneous minor cleanups. .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1815 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08911bc62c573da483174a71b71949162ca229f2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Michael Blow has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1825/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java: PS3, Line 146: // Re-interrupts the current thread to make sure that consequent things get interrupted. I think you don't need to re-interrupt since you are propagating the InterruptedException. -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3143/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3142/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Cleanup Task printStackTrace/interrupted handling/misc
Michael Blow has submitted this change and it was merged.
Change subject: Cleanup Task printStackTrace/interrupted handling/misc
..
Cleanup Task printStackTrace/interrupted handling/misc
Change-Id: I1ea6d4d6d8108768503e4ab11fe504423d76c291
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1824
Tested-by: Jenkins
BAD: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Till Westmann
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
3 files changed, 49 insertions(+), 32 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
Objections:
Jenkins: Violations found
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
index 3c70dba..b52a6a5 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
@@ -91,6 +91,7 @@
public static final int RESOURCE_DOES_NOT_EXIST = 55;
public static final int
DISK_COMPONENT_SCAN_NOT_ALLOWED_FOR_SECONDARY_INDEX = 56;
public static final int CANNOT_FIND_MATTER_TUPLE_FOR_ANTI_MATTER_TUPLE =
57;
+public static final int TASK_ABORTED = 58;
// Compilation error codes.
public static final int RULECOLLECTION_NOT_INSTANCE_OF_LIST = 1;
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
b/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
index 604b534..35a2fc5 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
@@ -18,8 +18,6 @@
#
# 0 --- : runtime errors
-# 1 1: compilation errors
-
1 = Unsupported operation %1$s in %2$s operator
2 = Error in processing tuple %1$s in a frame
4 = The file with absolute path %1$s is not within any of the current IO
devices
@@ -53,8 +51,8 @@
32 = No record for partition %1$s of result set %2$s
33 = Inserting duplicate keys into the primary storage
34 = Cannot load an index that is not empty
-35 = Modify not supported in External LSM Inedx
-36 = Flush not supported in External LSM Inedx
+35 = Modify not supported in External LSM Index
+36 = Flush not supported in External LSM Index
37 = Index key not found
38 = Index is not updatable
39 = Merge Threshold is less than or equal to 0
@@ -76,4 +74,7 @@
55 = Resource does not exist for %1$s
56 = LSM disk component scan is not allowed for a secondary index
57 = Couldn't find the matter tuple for anti-matter tuple in the primary index
+58 = Task %1$s was aborted
+
+# 1 1: compilation errors
1 = The given rule collection %1$s is not an instance of the List class.
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
index 7224b49..04d48f3 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
@@ -18,6 +18,8 @@
*/
package org.apache.hyracks.control.nc;
+import static org.apache.hyracks.api.exceptions.ErrorCode.TASK_ABORTED;
+
import java.io.Serializable;
import java.nio.ByteBuffer;
import java.util.ArrayList;
@@ -29,6 +31,8 @@
import java.util.Set;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Semaphore;
+import java.util.logging.Level;
+import java.util.logging.Logger;
import org.apache.hyracks.api.comm.IFrameReader;
import org.apache.hyracks.api.comm.IFrameWriter;
@@ -64,6 +68,8 @@
import org.apache.hyracks.control.nc.work.NotifyTaskFailureWork;
public class Task implements IHyracksTaskContext, ICounterContext, Runnable {
+private static final Logger LOGGER =
Logger.getLogger(Task.class.getName());
+
private final Joblet joblet;
private final TaskAttemptId taskAttemptId;
@@ -262,7 +268,7 @@
// Calls synchronized addPendingThread(..) to make sure that in the
abort() method,
// the thread is not escaped from interruption.
if (!addPendingThread(ct)) {
-exceptions.add(new InterruptedException("Task " +
getTaskAttemptId() + " was abo
Change in asterixdb[master]: Strip query string from servlet localPath
Michael Blow has submitted this change and it was merged.
Change subject: Strip query string from servlet localPath
..
Strip query string from servlet localPath
Path should not contain query string; remove it when extracting
localPath from request uri.
Change-Id: I0b4942fb1249807fcee9d3047568dc1749798d85
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1819
Sonar-Qube: Jenkins
Integration-Tests: Jenkins
Tested-by: Jenkins
BAD: Jenkins
Reviewed-by: Till Westmann
---
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; No violations found; Verified
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
index d029bbc..1030686 100644
---
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
+++
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/AbstractServlet.java
@@ -139,7 +139,8 @@
public String localPath(IServletRequest request) {
final String uri = request.getHttpRequest().uri();
-return uri.substring(trim(uri));
+int queryStart = uri.indexOf("?");
+return queryStart == -1 ? uri.substring(trim(uri)) :
uri.substring(trim(uri), queryStart);
}
public String servletPath(IServletRequest request) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/1819
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b4942fb1249807fcee9d3047568dc1749798d85
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Suppress stacktraces on expected exceptions
Michael Blow has submitted this change and it was merged.
Change subject: Suppress stacktraces on expected exceptions
..
Suppress stacktraces on expected exceptions
Change-Id: Ifce33d34d7ef3551613a67fdbfe45b143c46be86
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1823
Sonar-Qube: Jenkins
Tested-by: Jenkins
BAD: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Till Westmann
---
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
1 file changed, 35 insertions(+), 9 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; No violations found; Verified
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
index 55c98d1..c8c8aec 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
@@ -27,6 +27,7 @@
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.OutputStream;
+import java.io.PrintStream;
import java.io.PrintWriter;
import java.io.StringWriter;
import java.lang.reflect.InvocationTargetException;
@@ -453,25 +454,50 @@
throws Exception {
if
(!responseCodeValidator.test(httpResponse.getStatusLine().getStatusCode())) {
String errorBody = EntityUtils.toString(httpResponse.getEntity());
-String exceptionMsg;
+String[] errors;
try {
// First try to parse the response for a JSON error response.
ObjectMapper om = new ObjectMapper();
JsonNode result = om.readTree(errorBody);
-String[] errors = { result.get("error-code").asText(),
result.get("summary").asText(),
+errors = new String[] {
result.get("error-code").get(1).asText(), result.get("summary").asText(),
result.get("stacktrace").asText() };
-GlobalConfig.ASTERIX_LOGGER.log(Level.SEVERE, errors[2]);
-exceptionMsg = "HTTP operation failed: " + errors[0] +
"\nSTATUS LINE: " + httpResponse.getStatusLine()
-+ "\nSUMMARY: " + errors[1] + "\nSTACKTRACE: " +
errors[2];
} catch (Exception e) {
// whoops, not JSON (e.g. 404) - just include the body
GlobalConfig.ASTERIX_LOGGER.log(Level.SEVERE, errorBody);
-exceptionMsg = "HTTP operation failed:" + "\nSTATUS LINE: " +
httpResponse.getStatusLine()
-+ "\nERROR_BODY: " + errorBody;
+throw new Exception("HTTP operation failed:" + "\nSTATUS LINE:
" + httpResponse.getStatusLine()
++ "\nERROR_BODY: " + errorBody, e);
}
-throw new Exception(exceptionMsg);
+throw new ParsedException("HTTP operation failed: " + errors[0] +
"\nSTATUS LINE: "
++ httpResponse.getStatusLine() + "\nSUMMARY: " +
errors[2].split("\n")[0], errors[2]);
}
return httpResponse;
+}
+
+static class ParsedException extends Exception {
+
+private final String savedStack;
+
+ParsedException(String message, String stackTrace) {
+super(message);
+savedStack = stackTrace;
+}
+
+@Override
+public String toString() {
+return getMessage();
+}
+
+@Override
+public void printStackTrace(PrintStream s) {
+super.printStackTrace(s);
+s.println("Caused by: " + savedStack);
+}
+
+@Override
+public void printStackTrace(PrintWriter s) {
+super.printStackTrace(s);
+s.println("Caused by: " + savedStack);
+}
}
public InputStream executeQuery(String str, OutputFormat fmt, URI uri,
List params)
@@ -1260,7 +1286,7 @@
if (failedGroup != null) {
failedGroup.getTestCase().add(testCaseCtx.getTestCase());
}
-throw new Exception("Test \"" + testFile + "\"
FAILED!", e);
+throw new Exception("Test \"" + testFile + "\"
FAILED!");
}
} finally {
if (numOfFiles == testFileCtxs.size()) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/1823
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifce33d34d7ef3551613a67fdbfe45b143c46be86
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: Suppress stacktraces on expected exceptions
Till Westmann has posted comments on this change. Change subject: Suppress stacktraces on expected exceptions .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1823 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifce33d34d7ef3551613a67fdbfe45b143c46be86 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1938: Keep empty disk components when merge/flush
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1938: Keep empty disk components when merge/flush .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3141/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1826 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f7ec41f56a2f9124920d67657f88160634f0e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Cleanup Task printStackTrace/interrupted handling/misc
Till Westmann has posted comments on this change. Change subject: Cleanup Task printStackTrace/interrupted handling/misc .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1824 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ea6d4d6d8108768503e4ab11fe504423d76c291 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1377/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1377/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3139/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Luo Chen has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1818/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java: PS5, Line 275: leComponents.get(i).getComponentSize() > maxMergableComponentSize > This method is called by both isMergeLagging and diskComponentAdded. A typo here... while some disk components are being merged. -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1938: Keep empty disk components when merge/flush
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1938: Keep empty disk components when merge/flush .. Patch Set 2: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1376/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1826 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f7ec41f56a2f9124920d67657f88160634f0e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Luo Chen has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 5: Hi reviewers, Here is some experiment results for this change (not very thorough). The experiments were done based on Cloudberry twitter dataset, and the dataset has 6 secondary indexes. The AsterixDB was using default configuration based on NCService. Each experiment keeps ingesting data for one hour, and I recorded the number of tweets ingested. The results are as below: MaxMergeableSizePrefix Prefix with Size Factor 128M7.11M 8.32M 512M4.75M 7.77M 1024M 4.38M 7.71M Basically, it always out-performs the prefix policy, and, more importantly, it makes the ingestion more robust w.r.t. MaxMergeableSize -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1938: Keep empty disk components when merge/flush
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1938: Keep empty disk components when merge/flush .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1376/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1826 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f7ec41f56a2f9124920d67657f88160634f0e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/67/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/751/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/942/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3142/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/671/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/43/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/57/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/333/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4139/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5618/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Jenkins has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/766/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1818 to look at the new patch set (#6). Change subject: Avoid always merging old components in prefix policy .. Avoid always merging old components in prefix policy Current, the prefix policy always looks at the components from oldest to newest to schedule merge. One negative consequence is that the oldest (largest) component gets merged over and over again until it reaches the size limit. This is undesirable since it takes O(n^2) disk IOs (n is the number of flushed components) to produce a final component. This patch is a temporary fix of this behavior, taken from the idea of HBase compaction policy (https://www.ngdata.com/visualizing-hbase -flushes-and-compactions/). The basic idea is that it introduces some size factor (for now it's 1.2) to control the merge behavior. When the prefix policy finds a sequence of components to merge, we also check the oldest (largest) component in the sequence should be smaller than 1.2*the total size of all younger components. By doing so, we can avoid merging oldest components over and over again, making the disk IOs O(nlog n). Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java M hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-common-test/pom.xml A hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-common-test/src/test/java/org/apache/hyracks/storage/am/lsm/common/test/PrefixMergePolicyTest.java 3 files changed, 296 insertions(+), 38 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/18/1818/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Luo Chen has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 5: (4 comments) > (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1818/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java: PS5, Line 47: take > taken Done PS5, Line 270: @return > complete the java doc Done PS5, Line 275: immutableComponents.get(i).getState() != ComponentState.READABLE_UNWRITABLE > This probably won't happen because this method is called from a synchronize This method is called by both isMergeLagging and diskComponentAdded. In isMergeLagging, this is possible since it is called by a flush thread, while some disk components are being flushed. In diskComponentAdded, this shouldn't happen, since if some components are being merged, we would ignore this round of merge. PS5, Line 284: immutableComponents.get(j).getState() != ComponentState.READABLE_UNWRITABL > This probably won't happen because this method is called from a synchronize Same as above. -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Luo Chen has posted comments on this change.
Change subject: Avoid always merging old components in prefix policy
..
Patch Set 5:
(1 comment)
> (1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1818/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java:
Line 310: if (mergable) {
> I think this comment is valid.
I think it's hard to reduce them...The purpose of these if-else statements is
that we can terminate the algorithm early when some conditions are met (given
this algorithm has to be fast)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1818
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen
Gerrit-Reviewer: Ian Maxon
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Jianfeng Jia
Gerrit-Reviewer: Luo Chen
Gerrit-Reviewer: Yingyi Bu
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Luo Chen has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 5: (1 comment) > (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1818/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java: PS5, Line 303: // otherwise, we can look ahead to see if adding more younger components : // could pass the ratio check. > It looks to me that the old algorithm is O(2*n) for the worst case. However I haven't done any profiling yet, but seems to me this is not a big problem for the following reasons. First, the new algorithm skips all too large disk components (just like the old algorithm). Then it checks the remaining disk components to merge. The key point is that the number of the remaining components is very small, basically similar to maxToleranceComponentCount (normally 5 to 10 maybe?). It has optimizations to stop early for most cases. I think it should be fine, given the actual number components we need to look at is often very small. -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Cancel the on-going job if waitForCompletion is interrupted.
Jenkins has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. .. Patch Set 3: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1375/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Avoid always merging old components in prefix policy
Yingyi Bu has posted comments on this change. Change subject: Avoid always merging old components in prefix policy .. Patch Set 5: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1818/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java: PS5, Line 47: take taken PS5, Line 270: @return complete the java doc PS5, Line 275: immutableComponents.get(i).getState() != ComponentState.READABLE_UNWRITABLE This probably won't happen because this method is called from a synchronized block from LSMHarness? PS5, Line 284: immutableComponents.get(j).getState() != ComponentState.READABLE_UNWRITABL This probably won't happen because this method is called from a synchronized block from LSMHarness? PS5, Line 303: // otherwise, we can look ahead to see if adding more younger components : // could pass the ratio check. It looks to me that the old algorithm is O(2*n) for the worst case. However, I suspect this algorithm is of O(n^2) for the worst case. This method, as part of diskComponentAdded() is run in the synchronized block of primaryIndexOpTracker, i.e., synchronized(opTracker) in LSMHarness. That means, this method will block consequent reads, writes, merges, and flushes on all local partitions of the dataset until it's done. Therefore, the algorithm here has to be very fast. However, I couldn't think of a O(n) approach quickly -- maybe it's not possible... But running that with O(n^2) doesn't seem desirable. -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1938: Keep empty disk components when merge/flush
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1938: Keep empty disk components when merge/flush .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/66/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1826 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f7ec41f56a2f9124920d67657f88160634f0e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
