Change in asterixdb[master]: [NO ISSUE][STO] Introduce Index Checkpoints

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][STO] Introduce Index Checkpoints
..


Patch Set 11:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2200/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManagerProvider.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManagerProvider.java:

PS11, Line 43: indexCheckpointManagerMap.putIfAbsent(ref, new 
IndexCheckpointManager(getIndexPath(ref)));
 : return indexCheckpointManagerMap.get(ref);
we are already synchronized on the indexCheckpointManagerMap.
We should only create an IndexCheckpointManager if it doesn't exist.


https://asterix-gerrit.ics.uci.edu/#/c/2200/11/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java:

PS11, Line 630: 
  : 
  : 
  : 
  : 
  : 
  : 
  : 
  : 
  : 
  : 
  : 
  : 
can we keep the comment?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2200
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2282bf8ea3660242e599b3f5f20678301a8
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][STO] Introduce Index Checkpoints

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][STO] Introduce Index Checkpoints
..


Patch Set 11:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2200/11//COMMIT_MSG
Commit Message:

PS11, Line 10: no
I think there are storage changes.


https://asterix-gerrit.ics.uci.edu/#/c/2200/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManager.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManager.java:

PS11, Line 147: IOException
This seems to lose the root exception.


PS11, Line 161: fromJson
Can this return null?


PS11, Line 165: IOException
Would it make sense to throw IOExceptions inside the class instead of logging 
here?


https://asterix-gerrit.ics.uci.edu/#/c/2200/11/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBuffer.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBuffer.java:

PS11, Line 323: logRecord
Looks like we'll get an NPE here, if the thread is interrupted when waiting on 
the queue.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2200
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2282bf8ea3660242e599b3f5f20678301a8
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE] Jackson parser for JSON format

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE] Jackson parser for JSON format
..


Patch Set 7:

two small comments, looks good otherwise, tested it and confirmed 4x speedup.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE] Jackson parser for JSON format

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE] Jackson parser for JSON format
..


Patch Set 7:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2076/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParserFactory.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParserFactory.java:

PS7, Line 53:  @throws AsterixException
:  * if the parser does not support certain types 
defined in {@value recordType}.
:  */
Can we instead have the factory create ADMParser in case the record type needs 
it?
Or would that not be possible?


https://asterix-gerrit.ics.uci.edu/#/c/2076/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ObjectPool.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/jackson/ObjectPool.java:

PS7, Line 41: LinkedList
use ArrayDequeue? LinkedList<> will create a node object with each add call.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter

[Luo Chen (Code Review)]

Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter
..


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2201/2/hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java:

PS2, Line 45: 
: private static final int DEFAULT_BLOOM_FILTER_VERSION = 0;
: 
: private static final int BLOCKED_BLOOM_FILTER_VERSION = 1;
> I see. And we are certainly initializing the unused space to 0? And what I 
Hmm...I'm not using the storage version in the local resource, but just use 
this trick to handle backward-compatibility (but we can remove this as well, if 
some recent patches would break storage anyway).

BTW, for bloom filter we only use the first few bytes to store meta, and the 
next bytes are guaranteed to be initialized to 0 by java ByteBuffer.


PS2, Line 247: throw 
HyracksDataException.create(ErrorCode.CANNOT_DEACTIVATE_PINNED_BLOOM_FILTER);
> How's it different though, than the normal lifecycle of an index? Deactivat
Well, the thing is that an active index is not always used by queries. If it's 
idle, we can still evict some of pages from buffer cache (this is different 
from deactive an index entirely).

Here the query is typically a large query, with a lot of primary key lookups. 
Previous, we pin/unpin pages for each primary key check. This change allows 
pages are only pinned once, and unpinned after the query finishes.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2201
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e8e0db9b60d5addfaf61ebb372a1bcb2d2d5957
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter
..


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2201/2/hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java:

PS2, Line 45: 
: private static final int DEFAULT_BLOOM_FILTER_VERSION = 0;
: 
: private static final int BLOCKED_BLOOM_FILTER_VERSION = 1;
> The old bloom filter didn't store this version information. And because of 
I see. And we are certainly initializing the unused space to 0? And what I mean 
by the existing storage version is the other version information that is not 
stored in the bloomfilter metadata, but rather in the local resource


PS2, Line 247: throw 
HyracksDataException.create(ErrorCode.CANNOT_DEACTIVATE_PINNED_BLOOM_FILTER);
> pinAllPages/unpinAllPages should be called by the query (e.g., a lot of pk 
How's it different though, than the normal lifecycle of an index? Deactivating 
any storage that is in use by a query would be bad. Why not just pin all the 
pages when it is active, and then unpin them when it is evicted? We do 
something similar during bulk load already.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2201
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e8e0db9b60d5addfaf61ebb372a1bcb2d2d5957
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4821/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2409/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2112/ 
(6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1793/ 
(3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5833/ (7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2659/ (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/990/
 (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2450/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2155

to look at the new patch set (#16).

Change subject: [WIP] Delete managix
..

[WIP] Delete managix

Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
---
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalUDFLibrarian.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/FaultToleranceStrategyFactory.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/MetadataNodeFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
D asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixCLI.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterWorkExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
A asterixdb/asterix-app/src/main/resources/cc.conf
A asterixdb/asterix-app/src/main/resources/cc2.conf
A asterixdb/asterix-app/src/main/resources/cc3.conf
A asterixdb/asterix-app/src/main/resources/cc4.conf
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/aql/translator/QueryTranslatorTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/ClusterStateManagerTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/active/ActiveStatsTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/MultiPartitionLSMIndexTest.java
M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dml/DmlTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/APIExecutionTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/AqlExecutionFullParallelismIT.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/AqlExecutionLessParallelismIT.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/AqlExecutionTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/AqlExecutionTestIT.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateExecutionFullParallelismTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateExecutionLessParallelismTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/MetricsExecutionTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RebalanceTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RebalanceWithCancellationIT.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionFullParallelismIT.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionIT.java
M 

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7333/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1781/ 
(9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2463/ 
(1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1810/
 (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Steven Jacobs (Code Review)]

Steven Jacobs has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Hi, I think along with this change we need to update the CWiki BAD Extension 
guide 
(https://cwiki.apache.org/confluence/display/ASTERIXDB/Creating+a+BAD+Cluster+of+AsterixDB).
 I wouldn't mind making the change, but I'm not actually clear on how to set up 
a BAD cluster with the new framework.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: [NO ISSUE] Eliminate BAD dependency on managix

[Steven Jacobs (Code Review)]

Steven Jacobs has posted comments on this change.

Change subject: [NO ISSUE] Eliminate BAD dependency on managix
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2194
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I702b532a03a39ac9b53a4c1f2c4e5f3868cb7700
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4820/ 
: FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4820/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2155

to look at the new patch set (#15).

Change subject: [WIP] Delete managix
..

[WIP] Delete managix

Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
---
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalUDFLibrarian.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/FaultToleranceStrategyFactory.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/MetadataNodeFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
D asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixCLI.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterWorkExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
A asterixdb/asterix-app/src/main/resources/cc.conf
A asterixdb/asterix-app/src/main/resources/cc2.conf
A asterixdb/asterix-app/src/main/resources/cc3.conf
A asterixdb/asterix-app/src/main/resources/cc4.conf
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/aql/translator/QueryTranslatorTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/ClusterStateManagerTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/active/ActiveStatsTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/MultiPartitionLSMIndexTest.java
M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dml/DmlTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/APIExecutionTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/AqlExecutionFullParallelismIT.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/AqlExecutionLessParallelismIT.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/AqlExecutionTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/AqlExecutionTestIT.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateExecutionFullParallelismTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateExecutionLessParallelismTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/MetricsExecutionTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RebalanceTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RebalanceWithCancellationIT.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionFullParallelismIT.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionIT.java
M 

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5832/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1780/ 
(4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1792/ 
(5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7332/ (7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2658/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1809/
 (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/989/
 (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2408/ (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2449/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2462/ 
(8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP] Delete managix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP] Delete managix
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2111/ 
(9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter

[Luo Chen (Code Review)]

Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter
..


Patch Set 2:

(3 comments)

Thanks for the comments!

https://asterix-gerrit.ics.uci.edu/#/c/2201/2/hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java:

PS2, Line 45: 
: private static final int DEFAULT_BLOOM_FILTER_VERSION = 0;
: 
: private static final int BLOCKED_BLOOM_FILTER_VERSION = 1;
> Interesting, why's this different than the existing storage version? And ho
The old bloom filter didn't store this version information. And because of the 
initialization of buffer, the version is automatically 0...But right now we 
store it as 1.


PS2, Line 142: 
 : boolean unpinWhenExit = false;
> Why this and pagesPinned? Why're they different?
I want to expose an API (pinAllPages) to the caller such that a query can pin 
all pages at the beginning, and then call contains, and finally call 
unpinAllPages. Since bloom filter is very small, this avoids the overhead of 
pin/unpin pages every time during a contains call (which leads to another cache 
miss...)

However, if the query didn't call pinAllPages initially, it still works as 
before.


PS2, Line 247: throw 
HyracksDataException.create(ErrorCode.CANNOT_DEACTIVATE_PINNED_BLOOM_FILTER);
> Why is this the case, that it can't be evicted? Won't this possibly interfe
pinAllPages/unpinAllPages should be called by the query (e.g., a lot of pk 
lookups after search secondary index). If a bloom filter is being used by a 
query, it would be a bad idea to evict it's pages...


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2201
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e8e0db9b60d5addfaf61ebb372a1bcb2d2d5957
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][TEST] Add NC Storage API Test

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][TEST] Add NC Storage API Test
..


Patch Set 6: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/4tr2Hz : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2195
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76c336a66e32036a34d30ce6d3a31195c342c4a9
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO] Introduce Index Checkpoints

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Introduce Index Checkpoints
..


Patch Set 11: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/ySm4ce : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2200
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2282bf8ea3660242e599b3f5f20678301a8
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO] Introduce Index Checkpoints

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Introduce Index Checkpoints
..


Patch Set 11: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2249/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2200
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2282bf8ea3660242e599b3f5f20678301a8
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO] Introduce Index Checkpoints

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Introduce Index Checkpoints
..


Patch Set 11:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2249/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2200
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2282bf8ea3660242e599b3f5f20678301a8
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter
..


Patch Set 2:

(3 comments)

Very cool, I have some questions if you wouldn't mind answering them.

https://asterix-gerrit.ics.uci.edu/#/c/2201/2/hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java:

PS2, Line 45: 
: private static final int DEFAULT_BLOOM_FILTER_VERSION = 0;
: 
: private static final int BLOCKED_BLOOM_FILTER_VERSION = 1;
Interesting, why's this different than the existing storage version? And how 
would we know there would be a 0 there before this?


PS2, Line 142: 
 : boolean unpinWhenExit = false;
Why this and pagesPinned? Why're they different?


PS2, Line 247: throw 
HyracksDataException.create(ErrorCode.CANNOT_DEACTIVATE_PINNED_BLOOM_FILTER);
Why is this the case, that it can't be evicted? Won't this possibly interfere 
with dataset memory management?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2201
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e8e0db9b60d5addfaf61ebb372a1bcb2d2d5957
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: Yes