Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3285 ) Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O .. Patch Set 8: Verified+1 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3285/8/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponent.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponent.java: https://asterix-gerrit.ics.uci.edu/#/c/3285/8/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponent.java@138 PS8, Line 138: ChainedLSMDiskComponentBulkLoader Should this return a ILSMDiskComponentBulkLoader instead? -- To view, visit https://asterix-gerrit.ics.uci.edu/3285 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b Gerrit-Change-Number: 3285 Gerrit-PatchSet: 8 Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 13 Jun 2019 00:32:09 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O
Till Westmann has removed Anon. E. Moose (1000171) from this change. ( https://asterix-gerrit.ics.uci.edu/3285 ) Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O .. Removed reviewer null with the following votes: * Contrib-2 by Anon. E. Moose (1000171) -- To view, visit https://asterix-gerrit.ics.uci.edu/3285 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b Gerrit-Change-Number: 3285 Gerrit-PatchSet: 8 Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37816efc92ee9f5e66f29ce74dec4c6c5bd07c6f Gerrit-Change-Number: 3432 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 12 Jun 2019 16:54:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()
Till Westmann has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3433 )
Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..
Patch Set 7:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java:
https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@160
PS7, Line 160: // Validity of arguments
Do we have this behavior (only accepting whole numbers) for casting floating
point to integer in other functions as well ?
https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@169
PS7, Line 169: switch (valueTypeTag) {
Would it make sense to fold this in (i.e. set roundingDigit to 0 and run the
code in line 207)?
--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Comment-Date: Tue, 11 Jun 2019 15:47:38 +
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][COMP] Better error messages for dump_index
Till Westmann has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3431 )
Change subject: [NO ISSUE][COMP] Better error messages for dump_index
..
[NO ISSUE][COMP] Better error messages for dump_index
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: I87d75f7264c1eecf178300a1b0a67b351cce0216
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3431
Contrib: Jenkins
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Till Westmann
Reviewed-by: Murtadha Hubail
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetResourcesRewriter.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexRewriter.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/FunctionRewriter.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/StorageComponentsRewriter.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.4.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.5.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.6.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.7.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.8.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.9.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
13 files changed, 160 insertions(+), 21 deletions(-)
Approvals:
Jenkins: Verified; No violations found; ; Verified
Till Westmann: Looks good to me, but someone else must approve
Murtadha Hubail: Looks good to me, approved
Anon. E. Moose (1000171):
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetResourcesRewriter.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetResourcesRewriter.java
index 47c1045..f1687b5 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetResourcesRewriter.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetResourcesRewriter.java
@@ -27,6 +27,7 @@
import org.apache.hyracks.algebricks.core.algebra.base.IOptimizationContext;
import
org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression;
import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier;
+import org.apache.hyracks.api.exceptions.SourceLocation;
public class DatasetResourcesRewriter extends FunctionRewriter {
@@ -42,13 +43,13 @@
@Override
public DatasetResourcesDatasource toDatasource(IOptimizationContext
context, AbstractFunctionCallExpression f)
throws AlgebricksException {
-String dataverseName = getString(f.getArguments(), 0);
-String datasetName = getString(f.getArguments(), 1);
+final SourceLocation loc = f.getSourceLocation();
+String dataverseName = getString(loc, f.getArguments(), 0);
+String datasetName = getString(loc, f.getArguments(), 1);
MetadataProvider metadataProvider = (MetadataProvider)
context.getMetadataProvider();
Dataset dataset = metadataProvider.findDataset(dataverseName,
datasetName);
if (dataset == null) {
-throw new
CompilationException(ErrorCode.UNKNOWN_DATASET_IN_DATAVERSE,
f.getSourceLocation(), datasetName,
-dataverseName);
+throw new
CompilationException(ErrorCode.UNKNOWN_DATASET_IN_DATAVERSE, loc, datasetName,
dataverseName);
}
return new
DatasetResourcesDatasource(context.getComputationNodeDomain(),
dataset.getDatasetId());
}
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexRewriter.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexRewriter.java
index c91e9b0..08e5d51 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexRewriter.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexRewriter.java
@@ -29,6 +29,7 @@
import org.apache.hyracks.algebricks.core.algebra.base.IOptimizationContext;
import
org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression;
import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier;
+import org.apache.hyracks.api.exceptions.SourceLocation;
import
org.apache.hyracks.storage.am.common.dataflow.IndexDataflowHelpe
Change in asterixdb[master]: [NO ISSUE][COMP] Better error messages for dump_index
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3431 ) Change subject: [NO ISSUE][COMP] Better error messages for dump_index .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3431 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87d75f7264c1eecf178300a1b0a67b351cce0216 Gerrit-Change-Number: 3431 Gerrit-PatchSet: 1 Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Sat, 08 Jun 2019 00:27:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Better error messages for dump_index
Till Westmann has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3431
Change subject: [NO ISSUE][COMP] Better error messages for dump_index
..
[NO ISSUE][COMP] Better error messages for dump_index
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: I87d75f7264c1eecf178300a1b0a67b351cce0216
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetResourcesRewriter.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexRewriter.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/FunctionRewriter.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/StorageComponentsRewriter.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.4.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.5.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.6.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.7.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.8.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/dump_index/dump_index.9.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
13 files changed, 160 insertions(+), 21 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/31/3431/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetResourcesRewriter.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetResourcesRewriter.java
index 47c1045..f1687b5 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetResourcesRewriter.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetResourcesRewriter.java
@@ -27,6 +27,7 @@
import org.apache.hyracks.algebricks.core.algebra.base.IOptimizationContext;
import
org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression;
import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier;
+import org.apache.hyracks.api.exceptions.SourceLocation;
public class DatasetResourcesRewriter extends FunctionRewriter {
@@ -42,13 +43,13 @@
@Override
public DatasetResourcesDatasource toDatasource(IOptimizationContext
context, AbstractFunctionCallExpression f)
throws AlgebricksException {
-String dataverseName = getString(f.getArguments(), 0);
-String datasetName = getString(f.getArguments(), 1);
+final SourceLocation loc = f.getSourceLocation();
+String dataverseName = getString(loc, f.getArguments(), 0);
+String datasetName = getString(loc, f.getArguments(), 1);
MetadataProvider metadataProvider = (MetadataProvider)
context.getMetadataProvider();
Dataset dataset = metadataProvider.findDataset(dataverseName,
datasetName);
if (dataset == null) {
-throw new
CompilationException(ErrorCode.UNKNOWN_DATASET_IN_DATAVERSE,
f.getSourceLocation(), datasetName,
-dataverseName);
+throw new
CompilationException(ErrorCode.UNKNOWN_DATASET_IN_DATAVERSE, loc, datasetName,
dataverseName);
}
return new
DatasetResourcesDatasource(context.getComputationNodeDomain(),
dataset.getDatasetId());
}
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexRewriter.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexRewriter.java
index c91e9b0..08e5d51 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexRewriter.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DumpIndexRewriter.java
@@ -29,6 +29,7 @@
import org.apache.hyracks.algebricks.core.algebra.base.IOptimizationContext;
import
org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression;
import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier;
+import org.apache.hyracks.api.exceptions.SourceLocation;
import
org.apache.hyracks.storage.am.common.dataflow.IndexDataflowHelperFactory;
public class DumpIndexRewriter extends FunctionRewriter {
@@ -44,24 +45,24 @@
@Override
public DumpIndexDatasource toDatasource(IOptimizationContext context,
AbstractFunctionCallExpression f)
throws AlgebricksException {
-String dataverseName = getString(f.getArguments(), 0);
-
Change in asterixdb[master]: [NO ISSUE] Changed the minimum number of partitions in optimized hybr...
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3350 ) Change subject: [NO ISSUE] Changed the minimum number of partitions in optimized hybrid hash join - user model changes: no - storage format changes : no - interface changes: no .. Patch Set 6: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/3350/6//COMMIT_MSG Commit Message: https://asterix-gerrit.ics.uci.edu/#/c/3350/6//COMMIT_MSG@7 PS6, Line 7: [NO ISSUE] add empty line after the subject line https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting https://asterix-gerrit.ics.uci.edu/#/c/3350/6//COMMIT_MSG@13 PS6, Line 13: As please limit the line length to 77 chars https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting https://asterix-gerrit.ics.uci.edu/#/c/3350/6//COMMIT_MSG@13 PS6, Line 13: asterixdb AsterixDB -- To view, visit https://asterix-gerrit.ics.uci.edu/3350 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61 Gerrit-Change-Number: 3350 Gerrit-PatchSet: 6 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Fri, 07 Jun 2019 15:41:37 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource
Till Westmann has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3426 )
Change subject: [NO ISSUE][RT][COMP] Use more components to identify a
datasource
..
[NO ISSUE][RT][COMP] Use more components to identify a datasource
- user model changes: no
- storage format changes: no
- interface changes: additional constructor for DataSourceId
Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3426
Contrib: Jenkins
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Hussain Towaileb
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
2 files changed, 40 insertions(+), 18 deletions(-)
Approvals:
Jenkins: Verified; No violations found; ; Verified
Anon. E. Moose (1000171):
Hussain Towaileb: Looks good to me, approved
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
index d0ff67e..cb7e357 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
@@ -36,7 +36,7 @@
public TPCDSDataGeneratorDatasource(INodeDomain domain, String tableName,
double scalingFactor)
throws AlgebricksException {
-super(createDataSourceId(tableName), domain);
+super(createDataSourceId(tableName, scalingFactor), domain);
this.tableName = tableName;
this.scalingFactor = scalingFactor;
}
@@ -46,13 +46,15 @@
* DataSourceId. This eliminates the issue of creating a single function
even though multiple functions calls
* are happening with different parameters and the optimizer understands
them as a single function.
*
- * @param tableName table name to be added as part of the DataSourceId
- *
+ * @param tableName
+ *table name to be added as part of the DataSourceId
+ * @param scalingFactor
+ *scaling factor to be added as part of the DataSourceId
* @return A DataSourceId that's based on the function details and its
parameters
*/
-private static DataSourceId createDataSourceId(String tableName) {
+private static DataSourceId createDataSourceId(String tableName, double
scalingFactor) {
return new
DataSourceId(TPCDSDataGeneratorRewriter.TPCDS_DATA_GENERATOR.getNamespace(),
-TPCDSDataGeneratorRewriter.TPCDS_DATA_GENERATOR.getName() +
"." + tableName);
+TPCDSDataGeneratorRewriter.TPCDS_DATA_GENERATOR.getName(),
tableName, Double.toString(scalingFactor));
}
@Override
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
index c96fcd1..d61ae15 100644
---
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
@@ -19,43 +19,63 @@
package org.apache.asterix.metadata.declared;
-import java.util.Objects;
+import java.util.Arrays;
public final class DataSourceId {
-private String dataverseName;
-private String datasourceName;
+private String[] components;
+/**
+ * The original constructor taking
+ *
+ * @param dataverseName
+ *the dataverse (namespace) for this datasource
+ * @param datasourceName
+ *the name for this datasource
+ */
public DataSourceId(String dataverseName, String datasourceName) {
-this.dataverseName = dataverseName;
-this.datasourceName = datasourceName;
+this(new String[] { dataverseName, datasourceName });
+}
+
+/**
+ * An extended constructor taking an arbitrary number of name components.
+ * This constructor allows the definition of datasources that have the
same dataverse name and datasource name but
+ * that would expose different behavior. It enables the definition of
(compile-time) parameterized datasources.
+ * Please note that the first 2 parameters still need to be 1) a dataverse
name and 2) a datasource name.
+ *
+ * @param components
+ *name components used to construct the datasource identifier.
+ */
+public DataSourceId(String... components) {
+this.components = components;
}
@Override
public String toString() {
-return dataverseName + "." + datasourceName;
+
Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3426 ) Change subject: [NO ISSUE][RT][COMP] Use more components to identify a datasource .. Patch Set 3: (1 comment) > Patch Set 2: > > (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3426/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java: https://asterix-gerrit.ics.uci.edu/#/c/3426/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java@44 PS2, Line 44: datasou > Should be "datasource" name I think, no? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef Gerrit-Change-Number: 3426 Gerrit-PatchSet: 3 Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Fri, 07 Jun 2019 02:29:17 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource
Hello Anon. E. Moose (1000171), Hussain Towaileb, Jenkins, Murtadha Hubail, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3426 to look at the new patch set (#3). Change subject: [NO ISSUE][RT][COMP] Use more components to identify a datasource .. [NO ISSUE][RT][COMP] Use more components to identify a datasource - user model changes: no - storage format changes: no - interface changes: additional constructor for DataSourceId Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java 2 files changed, 40 insertions(+), 18 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/26/3426/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/3426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef Gerrit-Change-Number: 3426 Gerrit-PatchSet: 3 Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource
Hello Anon. E. Moose (1000171), Jenkins, Murtadha Hubail, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3426 to look at the new patch set (#2). Change subject: [NO ISSUE][RT][COMP] Use more components to identify a datasource .. [NO ISSUE][RT][COMP] Use more components to identify a datasource - user model changes: no - storage format changes: no - interface changes: additional constructor for DataSourceId Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java 2 files changed, 40 insertions(+), 18 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/26/3426/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef Gerrit-Change-Number: 3426 Gerrit-PatchSet: 2 Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3426 ) Change subject: [NO ISSUE][RT][COMP] Use more components to identify a datasource .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3426 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef Gerrit-Change-Number: 3426 Gerrit-PatchSet: 1 Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 05 Jun 2019 04:16:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource
Till Westmann has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3426
Change subject: [NO ISSUE][RT][COMP] Use more components to identify a
datasource
..
[NO ISSUE][RT][COMP] Use more components to identify a datasource
- user model changes: no
- storage format changes: no
- interface changes: additional constructor for DataSourceId
Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
2 files changed, 23 insertions(+), 18 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/26/3426/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
index d0ff67e..cb7e357 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
@@ -36,7 +36,7 @@
public TPCDSDataGeneratorDatasource(INodeDomain domain, String tableName,
double scalingFactor)
throws AlgebricksException {
-super(createDataSourceId(tableName), domain);
+super(createDataSourceId(tableName, scalingFactor), domain);
this.tableName = tableName;
this.scalingFactor = scalingFactor;
}
@@ -46,13 +46,15 @@
* DataSourceId. This eliminates the issue of creating a single function
even though multiple functions calls
* are happening with different parameters and the optimizer understands
them as a single function.
*
- * @param tableName table name to be added as part of the DataSourceId
- *
+ * @param tableName
+ *table name to be added as part of the DataSourceId
+ * @param scalingFactor
+ *scaling factor to be added as part of the DataSourceId
* @return A DataSourceId that's based on the function details and its
parameters
*/
-private static DataSourceId createDataSourceId(String tableName) {
+private static DataSourceId createDataSourceId(String tableName, double
scalingFactor) {
return new
DataSourceId(TPCDSDataGeneratorRewriter.TPCDS_DATA_GENERATOR.getNamespace(),
-TPCDSDataGeneratorRewriter.TPCDS_DATA_GENERATOR.getName() +
"." + tableName);
+TPCDSDataGeneratorRewriter.TPCDS_DATA_GENERATOR.getName(),
tableName, Double.toString(scalingFactor));
}
@Override
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
index c96fcd1..8c4c63b 100644
---
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
@@ -19,43 +19,46 @@
package org.apache.asterix.metadata.declared;
-import java.util.Objects;
+import java.util.Arrays;
public final class DataSourceId {
-private String dataverseName;
-private String datasourceName;
+private String[] components;
public DataSourceId(String dataverseName, String datasourceName) {
-this.dataverseName = dataverseName;
-this.datasourceName = datasourceName;
+this(new String[] { dataverseName, datasourceName });
+}
+
+public DataSourceId(String... components) {
+this.components = components;
}
@Override
public String toString() {
-return dataverseName + "." + datasourceName;
+return String.join(".", components);
}
public String getDataverseName() {
-return dataverseName;
+return components[0];
}
public String getDatasourceName() {
-return datasourceName;
+return components[1];
}
@Override
public boolean equals(Object o) {
-if (this == o)
+if (this == o) {
return true;
-if (o == null || getClass() != o.getClass())
+}
+if (o == null || getClass() != o.getClass()) {
return false;
-DataSourceId that = (DataSourceId) o;
-return Objects.equals(dataverseName, that.dataverseName) &&
Objects.equals(datasourceName, that.datasourceName);
+}
+return Arrays.equals(components, ((DataSourceId) o).components);
}
@Override
public int hashCode() {
-return Objects.hash(dataverseName, datasourceName);
+return Arrays.hashCode(components);
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To u
Change in asterixdb[master]: Refactoring OptimizedHybrishHashJoin Introduced RunfilesManager and P...
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3421 ) Change subject: Refactoring OptimizedHybrishHashJoin Introduced RunfilesManager and PartitionsManager .. Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3421/1//COMMIT_MSG Commit Message: https://asterix-gerrit.ics.uci.edu/#/c/3421/1//COMMIT_MSG@7 PS1, Line 7: Refactoring Let's avoid using continuous tense for the commit message and - if this is related to a JIRA issue - add a JIRA issue and component to the subject line. -- To view, visit https://asterix-gerrit.ics.uci.edu/3421 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f6d011f8af256b290cc28a04a412bcbd005920a Gerrit-Change-Number: 3421 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 03 Jun 2019 06:53:25 + Gerrit-HasComments: Yes
Change in asterixdb[master]: Step1-Making partitionManager for hash join
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3422 ) Change subject: Step1-Making partitionManager for hash join .. Patch Set 4: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3422/4//COMMIT_MSG Commit Message: https://asterix-gerrit.ics.uci.edu/#/c/3422/4//COMMIT_MSG@7 PS4, Line 7: Step1 If there's a JIRA issue for this, if'd be better to add this issue to this message. It's fine that have multiples fixes to address a single issue. https://asterix-gerrit.ics.uci.edu/#/c/3422/4//COMMIT_MSG@7 PS4, Line 7: Making Let's avoid using continuous tense for the commute messages. -- To view, visit https://asterix-gerrit.ics.uci.edu/3422 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8 Gerrit-Change-Number: 3422 Gerrit-PatchSet: 4 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 03 Jun 2019 06:49:34 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 5: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/3412/5//COMMIT_MSG Commit Message: https://asterix-gerrit.ics.uci.edu/#/c/3412/5//COMMIT_MSG@7 PS5, Line 7: [ASTERIXDB-2577] Please add a component (I think [RT] would be the right one here) following the structure described in https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting . https://asterix-gerrit.ics.uci.edu/#/c/3412/5//COMMIT_MSG@18 PS5, Line 18: will fix fixes? https://asterix-gerrit.ics.uci.edu/#/c/3412/5//COMMIT_MSG@14 PS5, Line 14: During the probe phase there should be one frame per each : spilled partition otherwise the whole memory may be used : to store in memory partitions. In this case, every record : that is matching with a spilled partition from build phase : will be flushed directly to the disk. If we have an issue in JIRA, it is better to describe the problem in JIRA and only describe the change here. -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 5 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 03 Jun 2019 06:45:09 + Gerrit-HasComments: Yes
Change in asterixdb[master]: Merge commit '79b243' from stabilization-f69489
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3418 ) Change subject: Merge commit '79b243' from stabilization-f69489 .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2387663ab0cd4544eb9ec6f12ec2ba74136ef83 Gerrit-Change-Number: 3418 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Fri, 31 May 2019 01:37:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Make ClusterControllerService Extensible
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3417 ) Change subject: [NO ISSUE][OTH] Make ClusterControllerService Extensible .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3417 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87ec46a29b2421d88df15494fe6331a0ae5d37f4 Gerrit-Change-Number: 3417 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 30 May 2019 15:34:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2579][DOC] Document uuid/upsert/insert behavior
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3414 ) Change subject: [ASTERIXDB-2579][DOC] Document uuid/upsert/insert behavior .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3414 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ba526c79de8cb744dc41ebc797389e68333c5ce Gerrit-Change-Number: 3414 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 30 May 2019 15:05:42 + Gerrit-HasComments: No
Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3411 ) Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3411 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 Gerrit-Change-Number: 3411 Gerrit-PatchSet: 4 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 29 May 2019 05:41:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3410/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java: https://asterix-gerrit.ics.uci.edu/#/c/3410/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java@65 PS3, Line 65: \t In a future version we should either parameterize the ResponseFieldPrinters to allow for indeed or non-indented output or had different printers for both cases. -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 29 May 2019 05:40:07 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3404/2/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/RangeMapBuilder.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/RangeMapBuilder.java: https://asterix-gerrit.ics.uci.edu/#/c/3404/2/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/RangeMapBuilder.java@180 PS2, Line 180: " + " Can we remove this string concatenation? -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Fri, 24 May 2019 23:46:23 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON
Till Westmann has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3401 )
Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..
Patch Set 2: Code-Review+2
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/3401/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DistributeResultOperator.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DistributeResultOperator.java:
https://asterix-gerrit.ics.uci.edu/#/c/3401/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DistributeResultOperator.java@100
PS2, Line 100: public IResultMetadata getResultMetadata() {
: return resultMetadata;
: }
Move this next to the other accessors?
--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Comment-Date: Thu, 23 May 2019 23:55:30 +
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3370 ) Change subject: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement .. Patch Set 10: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3370 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22100d3ff29864b8bfd54b0decb183e5056fdb4a Gerrit-Change-Number: 3370 Gerrit-PatchSet: 10 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 14 May 2019 02:04:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Additional constructor for TaggedValuePointable
Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3242 to look at the new patch set (#6). Change subject: [NO ISSUE] Additional constructor for TaggedValuePointable .. [NO ISSUE] Additional constructor for TaggedValuePointable - user model changes: no - storage format changes: no - interface changes: see above Change-Id: I3cad369ecb2f7cafd901f11e757272dce7e1e6b5 --- M hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/TaggedValuePointable.java 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/42/3242/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/3242 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3cad369ecb2f7cafd901f11e757272dce7e1e6b5 Gerrit-Change-Number: 3242 Gerrit-PatchSet: 6 Gerrit-Owner: Till Westmann Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2563][API] Allow All Nodes To Receive Queries
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3388 ) Change subject: [ASTERIXDB-2563][API] Allow All Nodes To Receive Queries .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31f7937d46b4532c30e2201b3e434e62e5c4a4de Gerrit-Change-Number: 3388 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 13 May 2019 22:58:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2555][RT][COMP] Make hash join use logical comparison
Till Westmann has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3387 )
Change subject: [ASTERIXDB-2555][RT][COMP] Make hash join use logical comparison
..
Patch Set 2:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3387/2/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/evaluators/TuplePairEvaluatorFactory.java
File
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/evaluators/TuplePairEvaluatorFactory.java:
https://asterix-gerrit.ics.uci.edu/#/c/3387/2/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/evaluators/TuplePairEvaluatorFactory.java@84
PS2, Line 84: if
(binaryBooleanInspector.getBooleanValue(p.getByteArray(), p.getStartOffset(),
p.getLength())) {
: return 0;
: } else {
: return 1;
: }
> should we use a ternary op here?
+1
https://asterix-gerrit.ics.uci.edu/#/c/3387/2/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/evaluators/TuplePairEvaluatorFactory.java@116
PS2, Line 116: if (fIdx < leftFieldCount) {
: return refLeft.getFieldData(fIdx);
: } else {
: return refRight.getFieldData(fIdx -
leftFieldCount);
: }
ternary?
https://asterix-gerrit.ics.uci.edu/#/c/3387/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/value/ITuplePairComparator.java
File
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/value/ITuplePairComparator.java:
https://asterix-gerrit.ics.uci.edu/#/c/3387/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/value/ITuplePairComparator.java@27
PS2, Line 27: CriticalPath
What does this do?
--
To view, visit https://asterix-gerrit.ics.uci.edu/3387
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1834967fdd913fdc76003f09636b2450d07cd5e
Gerrit-Change-Number: 3387
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Gerrit-Comment-Date: Thu, 09 May 2019 22:27:53 +
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][COMP] Reduce memory requirements for metadata only queries
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3385 ) Change subject: [NO ISSUE][COMP] Reduce memory requirements for metadata only queries .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3385 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d8902f88f61953e839e2fa0b06a77c324edbc57 Gerrit-Change-Number: 3385 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 09 May 2019 22:00:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Reduce memory requirements for metadata only queries
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3385 ) Change subject: [NO ISSUE][COMP] Reduce memory requirements for metadata only queries .. Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3385/2/asterixdb/asterix-algebra/pom.xml File asterixdb/asterix-algebra/pom.xml: https://asterix-gerrit.ics.uci.edu/#/c/3385/2/asterixdb/asterix-algebra/pom.xml@258 PS2, Line 258: it.unimi.dsi Do we need to do something to the LICENSE/NOTICE? -- To view, visit https://asterix-gerrit.ics.uci.edu/3385 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d8902f88f61953e839e2fa0b06a77c324edbc57 Gerrit-Change-Number: 3385 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 09 May 2019 21:52:41 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3370 ) Change subject: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement .. Patch Set 7: (5 comments) Added we few more (mostly naming-related) comments. https://asterix-gerrit.ics.uci.edu/#/c/3370/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordMergeTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordMergeTypeComputer.java: https://asterix-gerrit.ics.uci.edu/#/c/3370/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordMergeTypeComputer.java@50 PS7, Line 50: INSTANCE_UUID_IGNORE_DUPLICATE There seems to be nothing UUID-specifc in here. https://asterix-gerrit.ics.uci.edu/#/c/3370/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordMergeTypeComputer.java@115 PS7, Line 115: another rule : // handles checking the appropriate type where do we check types? https://asterix-gerrit.ics.uci.edu/#/c/3370/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3370/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeEvaluator.java@162 PS4, Line 162: handleDuplicateFieldNameButNotOfTypeRecord() > What would you recommend that I rename this method to? One way to think about this could be to distinguish between "conflicting" and "non-conflicting" fields or "mergeable" and "non-mergeable" fields. The current method name provides a detailed description, but doesn't provide (at least to me) an intuition about the 2 branches. E.g. we could call the method "handleConflictingFields" and elaborate on the mechanics of "conflicting" in a comment. https://asterix-gerrit.ics.uci.edu/#/c/3370/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeEvaluator.java@207 PS4, Line 207: IVisitablePointable leftValue, IVisitablePointable rightValue, boolean openFromParent, int nestedLevel) > As this is part of the normal record-merge behavior, I thought it would be It looks like a private method in a new file - so I don't see the continuity of a previous implementation https://asterix-gerrit.ics.uci.edu/#/c/3370/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeUuidIgnoreDuplicateDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeUuidIgnoreDuplicateDescriptor.java: https://asterix-gerrit.ics.uci.edu/#/c/3370/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeUuidIgnoreDuplicateDescriptor.java@43 PS7, Line 43: RecordMergeUuidIgnoreDuplicate RecordMergeIgnoreDuplicateFields or RecordMergeIgnoreConflictingFields? It seems that there's nothing UUID specific about the fields we are ignoring. -- To view, visit https://asterix-gerrit.ics.uci.edu/3370 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22100d3ff29864b8bfd54b0decb183e5056fdb4a Gerrit-Change-Number: 3370 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 09 May 2019 01:25:51 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][DOC] Refresh and update text-example
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3356 ) Change subject: [NO ISSUE][DOC] Refresh and update text-example .. Patch Set 3: For nicer rendering on GitHub, it might be useful to use markdown for the READMEs. -- To view, visit https://asterix-gerrit.ics.uci.edu/3356 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie756e790994cd6d8dad69cce1bb728923cc0398c Gerrit-Change-Number: 3356 Gerrit-PatchSet: 3 Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 09 May 2019 00:44:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] show aggregate functions in JSON plan
Till Westmann has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3384 )
Change subject: [NO ISSUE] show aggregate functions in JSON plan
..
[NO ISSUE] show aggregate functions in JSON plan
- user model changes: more information in JSON plan
- storage format changes: no
- interface changes: no
Change-Id: Ie4ba74d8455844e3913a4d4b5e2761b5ed23028b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3384
Reviewed-by: Murtadha Hubail
Integration-Tests: Murtadha Hubail
Tested-by: Murtadha Hubail
---
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Murtadha Hubail: Looks good to me, approved; Verified; Verified
diff --git
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
index e56a8bd..f4e8003 100644
---
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
+++
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
@@ -171,6 +171,10 @@
@Override
public Void visitAggregateOperator(AggregateOperator op, Integer indent)
throws AlgebricksException {
addIndent(indent).append("\"operator\": \"aggregate\"");
+if (!op.getExpressions().isEmpty()) {
+addIndent(0).append(",\n");
+pprintExprList(op.getExpressions(), indent);
+}
variablePrintHelper(op.getVariables(), indent);
return null;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/3384
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4ba74d8455844e3913a4d4b5e2761b5ed23028b
Gerrit-Change-Number: 3384
Gerrit-PatchSet: 4
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NO ISSUE] show aggregate functions in JSON plan
Hello Anon. E. Moose (1000171), Jenkins, Murtadha Hubail, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3384 to look at the new patch set (#3). Change subject: [NO ISSUE] show aggregate functions in JSON plan .. [NO ISSUE] show aggregate functions in JSON plan - user model changes: more information in JSON plan - storage format changes: no - interface changes: no Change-Id: Ie4ba74d8455844e3913a4d4b5e2761b5ed23028b --- M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/84/3384/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/3384 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie4ba74d8455844e3913a4d4b5e2761b5ed23028b Gerrit-Change-Number: 3384 Gerrit-PatchSet: 3 Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE] show aggregate functions in JSON plan
Hello Anon. E. Moose (1000171), Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3384 to look at the new patch set (#2). Change subject: [NO ISSUE] show aggregate functions in JSON plan .. [NO ISSUE] show aggregate functions in JSON plan Change-Id: Ie4ba74d8455844e3913a4d4b5e2761b5ed23028b --- M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/84/3384/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3384 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie4ba74d8455844e3913a4d4b5e2761b5ed23028b Gerrit-Change-Number: 3384 Gerrit-PatchSet: 2 Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: MB-34087: show aggregate functions in JSON plan
Till Westmann has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3384
Change subject: MB-34087: show aggregate functions in JSON plan
..
MB-34087: show aggregate functions in JSON plan
Change-Id: Ie4ba74d8455844e3913a4d4b5e2761b5ed23028b
---
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/84/3384/1
diff --git
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
index e56a8bd..f4e8003 100644
---
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
+++
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
@@ -171,6 +171,10 @@
@Override
public Void visitAggregateOperator(AggregateOperator op, Integer indent)
throws AlgebricksException {
addIndent(indent).append("\"operator\": \"aggregate\"");
+if (!op.getExpressions().isEmpty()) {
+addIndent(0).append(",\n");
+pprintExprList(op.getExpressions(), indent);
+}
variablePrintHelper(op.getVariables(), indent);
return null;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/3384
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4ba74d8455844e3913a4d4b5e2761b5ed23028b
Gerrit-Change-Number: 3384
Gerrit-PatchSet: 1
Gerrit-Owner: Till Westmann
Change in asterixdb[master]: [NO ISSUE][FUN] Simplify error message + cleanup
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3381 ) Change subject: [NO ISSUE][FUN] Simplify error message + cleanup .. Patch Set 3: Code-Review+2 Forwarding Hussain's +2 after a rebase. -- To view, visit https://asterix-gerrit.ics.uci.edu/3381 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bbcb63f266685befc80de957687249191345063 Gerrit-Change-Number: 3381 Gerrit-PatchSet: 3 Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 08 May 2019 02:19:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Simplify error message + cleanup
Till Westmann has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3381 ) Change subject: [NO ISSUE][FUN] Simplify error message + cleanup .. [NO ISSUE][FUN] Simplify error message + cleanup - user model changes: different error message - storage format changes: no - interface changes: no Change-Id: I5bbcb63f266685befc80de957687249191345063 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3381 Sonar-Qube: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Till Westmann --- R asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.query.sqlpp R asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.query.sqlpp R asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.1.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties 5 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins: Verified; No violations found; Verified Till Westmann: Looks good to me, approved diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.3.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.query.sqlpp similarity index 100% rename from asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.3.query.sqlpp rename to asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.query.sqlpp diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.3.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.query.sqlpp similarity index 100% rename from asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.3.query.sqlpp rename to asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.query.sqlpp diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.3.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.1.query.sqlpp similarity index 100% rename from asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.3.query.sqlpp rename to asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.1.query.sqlpp diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml index baeb7c5..9a561fc 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml +++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml @@ -8855,7 +8855,7 @@ datagen_sf_1_invalid_table -Invalid value +is not a TPC-DS table name false diff --git a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties index 4243837..36a2021 100644 --- a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties +++ b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties @@ -76,7 +76,7 @@ 39 = Expected integer value, got %1$s 40 = No statement provided 41 = Request %1$s has been cancelled -42 = Invalid value: function %1$s input \"%2$s\" did not match any TPC-DS tables +42 = %1$s: \"%2$s\" is not a TPC-DS table name 100 = Unsupported JRE: %1$s -- To view, visit https://asterix-gerrit.ics.uci.edu/3381 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5bbcb63f266685befc80de957687249191345063 Gerrit-Change-Number: 3381 Gerrit-PatchSet: 4 Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling
Till Westmann has uploaded a new patch set (#38) to the change originally created by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/3226 ) Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. [ASTERIXDB-2532][RT] per-operator profiling Enables profiling in queries at the operator-level when the analyze variable is set in a query. Change-Id: Ie16f3901ae5b32920d8552d5fd1ec8bb6e2ec8ae --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceRequestParameters.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ProfiledExecutionTest.java A asterixdb/asterix-app/src/test/resources/cc-single.conf A asterixdb/asterix-app/src/test/resources/runtimets/profiled.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.3.profile.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/profile/full-scan/full-scan.3.regexjson M asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IARecordBuilder.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/OpenRecordConstructorDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/AlgebricksMetaOperatorDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java R hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/com/job/profiling/counters/Counter.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/IPassableTimer.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedFrameWriter.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java R hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/OperatorStats.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/AggregateCounter.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/impl/ClientCounterContext.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/StatsCollector.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/om/TaskProfile.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Joblet.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/sort/SortGroupByOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybr
Change in asterixdb[master]: [NO ISSUE][CONF] Add compilation provider to NC application context
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3378 ) Change subject: [NO ISSUE][CONF] Add compilation provider to NC application context .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb4dc6d8dbc00c8a701fddb1a3205d1070078cb4 Gerrit-Change-Number: 3378 Gerrit-PatchSet: 3 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Anon. E. Moose Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 07 May 2019 01:03:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][CONF] Add compilation provider to NC application context
Till Westmann has removed a vote on this change. Change subject: [NO ISSUE][CONF] Add compilation provider to NC application context .. Removed Contrib-2 by Anon. E. Moose (1000171) -- To view, visit https://asterix-gerrit.ics.uci.edu/3378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ibb4dc6d8dbc00c8a701fddb1a3205d1070078cb4 Gerrit-Change-Number: 3378 Gerrit-PatchSet: 3 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Anon. E. Moose Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: Finished translating all old aql files with the exception of a few st...
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3383 ) Change subject: Finished translating all old aql files with the exception of a few straglers and fuzzyjoin. Should be up to date with master .. Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3383/2//COMMIT_MSG Commit Message: https://asterix-gerrit.ics.uci.edu/#/c/3383/2//COMMIT_MSG@1 PS2, Line 1: Parent: 631846bf ([ASTERIXDB-2552][RT] Reuse objects on reseting buffer manager) : Author: mileshong1 : AuthorDate: 2019-05-06 09:56:25 -0700 : Commit: mileshong1 : CommitDate: 2019-05-06 09:56:25 -0700 : : Finished translating all old aql files with the exception of a few straglers and fuzzyjoin. Should be up to date with master : : The following commits from your working branch will be included: : : Added almost all translated files and the new data files. Only fuzzyjoin and a couple straglers at this point. : : commit 8f7baf9b5714787e5b816f9fa99cb679dd815c30 : Author: mileshong1 : Date: Mon May 6 00:34:52 2019 -0700 : : Added translated files and new data files to new branch off master : : Change-Id: Id0257d3895ce902461ebcc61d95ec44e65878275 Please use the format described here https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting -- To view, visit https://asterix-gerrit.ics.uci.edu/3383 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0257d3895ce902461ebcc61d95ec44e65878275 Gerrit-Change-Number: 3383 Gerrit-PatchSet: 2 Gerrit-Owner: Anon. E. Moose Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 06 May 2019 20:15:53 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3370 ) Change subject: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement .. Patch Set 4: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3370/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3370/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeEvaluator.java@162 PS4, Line 162: handleDuplicateFieldNameButNotOfTypeRecord() > This is the same old merge record evaluator class, this method is the only We should work on a better name for the method. Can we start by formulating what happens in the if- and else-branches? https://asterix-gerrit.ics.uci.edu/#/c/3370/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeEvaluator.java@207 PS4, Line 207: IVisitablePointable leftValue, IVisitablePointable rightValue, boolean openFromParent, int nestedLevel) > MAJOR SonarQube violation: As this is a private method, moving the parameter should be feasible and safe. -- To view, visit https://asterix-gerrit.ics.uci.edu/3370 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22100d3ff29864b8bfd54b0decb183e5056fdb4a Gerrit-Change-Number: 3370 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 06 May 2019 16:32:25 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling
Till Westmann has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3226 )
Change subject: [ASTERIXDB-2532][RT] per-operator profiling
..
Patch Set 36:
(11 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java@362
PS36, Line 362: ObjectMapper om = new ObjectMapper();
Do the other printers use Jackson as well?
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/asterixdb/asterix-app/src/test/resources/runtimets/results/profile/full-scan/full-scan.3.regexjson
File
asterixdb/asterix-app/src/test/resources/runtimets/results/profile/full-scan/full-scan.3.regexjson:
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/asterixdb/asterix-app/src/test/resources/runtimets/results/profile/full-scan/full-scan.3.regexjson@61
PS36, Line 61:
looks wrong
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
File
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java@68
PS36, Line 68: IFrameWriter fw = outputWriter;
: if (profile) {
: fw = TimedFrameWriter.time(outputWriter, ctx,
"Aggregate Writer");
: } else if (enforce) {
: fw = EnforceFrameWriter.enforce(outputWriter);
: }
need to test different combinations of profile and enforce
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java
File
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java@108
PS36, Line 108: start = (enforce && !profile)
What is the relationship between profile and enforce?
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java
File
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java@43
PS36, Line 43: HyracksDataException
I think that this is not needed.
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
File
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java@157
PS36, Line 157: (enforce && !profile)
again, what's the relationship? we should have (and enforce) one policy
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
File
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java@183
PS36, Line 183: (enforce && !profile)
clarify relationship
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/sort/SortGroupByOperatorDescriptor.java
File
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/sort/SortGroupByOperatorDescriptor.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/sort/SortGroupByOperatorDescriptor.java@149
PS36, Line 149: IRunGenerator
no
Change in asterixdb[master]: [ASTERIXDB-2552][RT] Reuse objects on reseting buffer manager
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3372 ) Change subject: [ASTERIXDB-2552][RT] Reuse objects on reseting buffer manager .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3372 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88bea27e5024c621412ef609475e2a7ba1913afa Gerrit-Change-Number: 3372 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Sat, 04 May 2019 21:18:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Simplify error message + cleanup
Till Westmann has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3381 Change subject: [NO ISSUE][FUN] Simplify error message + cleanup .. [NO ISSUE][FUN] Simplify error message + cleanup - user model changes: different error message - storage format changes: no - interface changes: no Change-Id: I5bbcb63f266685befc80de957687249191345063 --- R asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.query.sqlpp R asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.query.sqlpp R asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.1.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties 5 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/81/3381/1 diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.3.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.query.sqlpp similarity index 100% rename from asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.3.query.sqlpp rename to asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.query.sqlpp diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.3.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.query.sqlpp similarity index 100% rename from asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.3.query.sqlpp rename to asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.query.sqlpp diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.3.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.1.query.sqlpp similarity index 100% rename from asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.3.query.sqlpp rename to asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.1.query.sqlpp diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml index 1f093d7..c3a7ae7 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml +++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml @@ -8855,7 +8855,7 @@ datagen_sf_1_invalid_table -Invalid value +is not a TPC-DS table name false diff --git a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties index a69a6cf..794ad48 100644 --- a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties +++ b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties @@ -75,7 +75,7 @@ 39 = Expected integer value, got %1$s 40 = No statement provided 41 = Request %1$s has been cancelled -42 = Invalid value: function %1$s input \"%2$s\" did not match any TPC-DS tables +42 = %1$s: \"%2$s\" is not a TPC-DS table name 100 = Unsupported JRE: %1$s -- To view, visit https://asterix-gerrit.ics.uci.edu/3381 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5bbcb63f266685befc80de957687249191345063 Gerrit-Change-Number: 3381 Gerrit-PatchSet: 1 Gerrit-Owner: Till Westmann
Change in asterixdb[master]: [NO ISSUE][CONF] Add compilation provider to NC application context
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3378 ) Change subject: [NO ISSUE][CONF] Add compilation provider to NC application context .. Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3378/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java: https://asterix-gerrit.ics.uci.edu/#/c/3378/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java@206 PS2, Line 206: IOException, AsterixException Just stick with "Exception" like most other methods in this class? https://asterix-gerrit.ics.uci.edu/#/c/3378/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java: https://asterix-gerrit.ics.uci.edu/#/c/3378/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java@195 PS2, Line 195: IOException, AsterixException Just stick with "Exception" like most other methods in this class? -- To view, visit https://asterix-gerrit.ics.uci.edu/3378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb4dc6d8dbc00c8a701fddb1a3205d1070078cb4 Gerrit-Change-Number: 3378 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Anon. E. Moose Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Sat, 04 May 2019 00:29:51 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2552][RT] Reuse objects on reseting buffer manager
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3372 ) Change subject: [ASTERIXDB-2552][RT] Reuse objects on reseting buffer manager .. Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3372/2/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameFreeSlotBiggestFirst.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameFreeSlotBiggestFirst.java: https://asterix-gerrit.ics.uci.edu/#/c/3372/2/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameFreeSlotBiggestFirst.java@104 PS2, Line 104: // TODO(ali): fix to not release resources In this change? -- To view, visit https://asterix-gerrit.ics.uci.edu/3372 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88bea27e5024c621412ef609475e2a7ba1913afa Gerrit-Change-Number: 3372 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Fri, 03 May 2019 15:50:31 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][FUN] Introduce data generator function
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [NO ISSUE][FUN] Introduce data generator function .. Patch Set 11: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3360 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb6bd6f697628395c70008e6f730bc5ca403da5e Gerrit-Change-Number: 3360 Gerrit-PatchSet: 11 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 29 Apr 2019 22:08:53 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Introduce data generator data source functions
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [WIP] Introduce data generator data source functions .. Patch Set 10: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3360/10/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java: https://asterix-gerrit.ics.uci.edu/#/c/3360/10/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java@64 PS10, Line 64: // TODO(Hussain) check if it is safe to assume that we're receiving constant expressions only as arguments. It would certainly make sense to add tests that pass a) the result of a simple expression (e.g. concatenate 2 strings to produce the table name, add 2 numbers to get to the scale factor) to the function or b) pass a variable to on of the function parameters. https://asterix-gerrit.ics.uci.edu/#/c/3360/10/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.3.query.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/10/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.3.query.sqlpp@20 PS10, Line 20: set `import-private-functions` `true`; : rename this file to use "1" instead of "3" https://asterix-gerrit.ics.uci.edu/#/c/3360/10/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.3.query.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/10/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.3.query.sqlpp@20 PS10, Line 20: set `import-private-functions` `true`; rename this file to use "1" instead of "3" https://asterix-gerrit.ics.uci.edu/#/c/3360/10/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.3.query.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/10/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.3.query.sqlpp@20 PS10, Line 20: set `import-private-functions` `true`; rename this file to use "1" instead of "3" -- To view, visit https://asterix-gerrit.ics.uci.edu/3360 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb6bd6f697628395c70008e6f730bc5ca403da5e Gerrit-Change-Number: 3360 Gerrit-PatchSet: 10 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 29 Apr 2019 16:22:36 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [WIP] Introduce data generator data source functions
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [WIP] Introduce data generator data source functions .. Patch Set 7: (8 comments) https://asterix-gerrit.ics.uci.edu/#/c/3360/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java: https://asterix-gerrit.ics.uci.edu/#/c/3360/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java@101 PS6, Line 101: */ > Done. (Change not uploaded yet) The methods are not needed. SQ was just complaining as there are curly braces around the code for each CASE. I'm confident that the version that I've pasted won't get SQ complaints. https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.ddl.sqlpp@1 PS7, Line 1: /* : * Licensed to the Apache Software Foundation (ASF) under one : * or more contributor license agreements. See the NOTICE file : * distributed with this work for additional information : * regarding copyright ownership. The ASF licenses this file : * to you under the Apache License, Version 2.0 (the : * "License"); you may not use this file except in compliance : * with the License. You may obtain a copy of the License at : * : * http://www.apache.org/licenses/LICENSE-2.0 : * : * Unless required by applicable law or agreed to in writing, : * software distributed under the License is distributed on an : * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY : * KIND, either express or implied. See the License for the : * specific language governing permissions and limitations : * under the License. : */ I don't think that we need this empty (except for comments) file ... https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.2.update.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.2.update.sqlpp@1 PS7, Line 1: /* : * Licensed to the Apache Software Foundation (ASF) under one : * or more contributor license agreements. See the NOTICE file : * distributed with this work for additional information : * regarding copyright ownership. The ASF licenses this file : * to you under the Apache License, Version 2.0 (the : * "License"); you may not use this file except in compliance : * with the License. You may obtain a copy of the License at : * : * http://www.apache.org/licenses/LICENSE-2.0 : * : * Unless required by applicable law or agreed to in writing, : * software distributed under the License is distributed on an : * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY : * KIND, either express or implied. See the License for the : * specific language governing permissions and limitations : * under the License. : */ same as before https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.ddl.sqlpp@1 PS7, Line 1: /* : * Licensed to the Apache Software Foundation (ASF) under one : * or more contributor license agreements. See the NOTICE file : * distributed with this work for additional information : * regarding copyright ownership. The ASF licenses this file : * to you under the Apache License, Version 2.0 (the : * "Licens
Change in asterixdb[master]: [WIP] Introduce data generator data source functions
Till Westmann has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3360 )
Change subject: [WIP] Introduce data generator data source functions
..
Patch Set 6:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3360/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java:
https://asterix-gerrit.ics.uci.edu/#/c/3360/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java@30
PS6, Line 30: random
Could we take the word "random" out again? It shouldn't be really random :)
https://asterix-gerrit.ics.uci.edu/#/c/3360/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorReader.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorReader.java:
https://asterix-gerrit.ics.uci.edu/#/c/3360/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorReader.java@116
PS6, Line 116: IllegalArgumentException
We should have a better error here. Providing a non-existing table name
currently yields an internal error. (And let's add test case for that.)
https://asterix-gerrit.ics.uci.edu/#/c/3360/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java:
https://asterix-gerrit.ics.uci.edu/#/c/3360/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java@101
PS6, Line 101: private double getScalingFactor(AsterixConstantValue
scalingFactorArgumentValue) throws TypeMismatchException {
This should be equivalent (and much shorter):
private double getScalingFactor(AsterixConstantValue
scalingFactorArgumentValue) throws TypeMismatchException {
switch (scalingFactorArgumentValue.getObject().getType().getTypeTag()) {
case TINYINT:
return ((AInt8)
scalingFactorArgumentValue.getObject()).getByteValue();
case SMALLINT:
return ((AInt16)
scalingFactorArgumentValue.getObject()).getShortValue();
case INTEGER:
return ((AInt32)
scalingFactorArgumentValue.getObject()).getIntegerValue();
case BIGINT:
return ((AInt64)
scalingFactorArgumentValue.getObject()).getLongValue();
case FLOAT:
return ((AFloat)
scalingFactorArgumentValue.getObject()).getFloatValue();
case DOUBLE:
return ((ADouble)
scalingFactorArgumentValue.getObject()).getDoubleValue();
default:
throw new TypeMismatchException(TPCDS_DATA_GENERATOR, 1,
scalingFactorArgumentValue.getObject().getType().getTypeTag(), ATypeTag.TINYINT,
ATypeTag.SMALLINT, ATypeTag.INTEGER, ATypeTag.BIGINT,
ATypeTag.FLOAT, ATypeTag.DOUBLE);
}
}
But I'm wondering if we already have such a utility function somewhere that we
could reuse.
--
To view, visit https://asterix-gerrit.ics.uci.edu/3360
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb6bd6f697628395c70008e6f730bc5ca403da5e
Gerrit-Change-Number: 3360
Gerrit-PatchSet: 6
Gerrit-Owner: Hussain Towaileb
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-Comment-Date: Sun, 28 Apr 2019 06:30:42 +
Gerrit-HasComments: Yes
Change in asterixdb[master]: [WIP] Introduce data generator data source functions
Till Westmann has uploaded a new patch set (#5) to the change originally created by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [WIP] Introduce data generator data source functions .. [WIP] Introduce data generator data source functions Change-Id: Idb6bd6f697628395c70008e6f730bc5ca403da5e --- M asterixdb/asterix-app/pom.xml A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDatasource.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSFunction.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/util/MetadataBuiltinFunctions.java M asterixdb/pom.xml 7 files changed, 358 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/60/3360/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/3360 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb6bd6f697628395c70008e6f730bc5ca403da5e Gerrit-Change-Number: 3360 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [WIP] Introduce data generator data source functions
Till Westmann has uploaded a new patch set (#4) to the change originally created by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [WIP] Introduce data generator data source functions .. [WIP] Introduce data generator data source functions Change-Id: Idb6bd6f697628395c70008e6f730bc5ca403da5e --- M asterixdb/asterix-app/pom.xml A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDatasource.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSFunction.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/util/MetadataBuiltinFunctions.java M asterixdb/pom.xml 7 files changed, 382 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/60/3360/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/3360 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb6bd6f697628395c70008e6f730bc5ca403da5e Gerrit-Change-Number: 3360 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [WIP] Introduce data generator data source functions
Till Westmann has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3360 )
Change subject: [WIP] Introduce data generator data source functions
..
Patch Set 4:
(17 comments)
Looks good so far - just a few small comments.
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java:
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java@35
PS3, Line 35: should
will
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java@71
PS3, Line 71: record.reset
I think (hope) that we don't need to reset a new CharArrayRecord.
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java@103
PS3, Line 103: .filter(table ->
tableName.toLowerCase().equals(table.getName().toLowerCase()))
> MAJOR SonarQube violation:
+1
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java@137
PS3, Line 137: stringRecord.substring(0, stringRecord.length() - 1)
We should avoid appending the comma instead of copying the whole record here.
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java@141
PS3, Line 141: private FunctionIdentifier getIdentifier() {
> MAJOR SonarQube violation:
+1
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java:
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@38
PS3, Line 38: random data
according to the specification of the TPC Benchmark DS
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@38
PS3, Line 38: This depends on the solution provided by Teradata which is a
: * conversion of the TPC-DS data generator from C to Java, which
can be found here:
: * https://github.com/Teradata/tpcds
remove
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@42
PS3, Line 42: generated data
data generator
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@42
PS3, Line 42: depends on the provided
takes
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@43
PS3, Line 43: string representing the table name to use as a schema
a valid table name
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@44
PS3, Line 44: number representing the scaling factor to determine the number of
rows to generator
the desired scaling factor
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@62
PS3, Line 62: ((AsterixConstantValue) tableNameArgument.getValue())
extract variable tableNameArgumentValue
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@62
PS3, Line 62: type1
tableNameType?
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@63
PS3, Line 63: ((AsterixConstantValue) scalingFactorArgument.getValue())
extract variable scalingFactorArgumentValue
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@63
PS3, Line 63: type2
scalingFactorType?
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@75
PS3, Line 75: TODO
+1
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/util/MetadataBuiltinFunctions.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/MetadataBuiltinFunctions.java:
https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/util/MetadataBuiltinFunctions.java@62
PS3, Line 62: // TODO probably need to move the TPCDS function somewhere else
since it's not metadata
this is metadata for builtin functions - it belongs here
--
To view, visit https://asterix-gerrit.ics.uci.edu/336
Change in asterixdb[master]: [NO ISSUE][CONF] Introduce ConfigValidator
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3359 ) Change subject: [NO ISSUE][CONF] Introduce ConfigValidator .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3359 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e9dcde9c93feb2c9e2bdfe790f121b751d4c8ad Gerrit-Change-Number: 3359 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 23 Apr 2019 15:00:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling
Till Westmann has uploaded a new patch set (#30) to the change originally created by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/3226 ) Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. [ASTERIXDB-2532][RT] per-operator profiling Enables profiling in queries at the operator-level when the analyze variable is set in a query. Change-Id: Ie16f3901ae5b32920d8552d5fd1ec8bb6e2ec8ae --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceRequestParameters.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ProfiledExecutionTest.java A asterixdb/asterix-app/src/test/resources/cc-single.conf A asterixdb/asterix-app/src/test/resources/runtimets/profiled.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.3.profile.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/profile/full-scan/full-scan.3.regexadm M asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IARecordBuilder.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/OpenRecordConstructorDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/AlgebricksMetaOperatorDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java R hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/com/job/profiling/counters/Counter.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/IPassableTimer.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedFrameWriter.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java R hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/OperatorStats.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/AggregateCounter.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/impl/ClientCounterContext.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/StatsCollector.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/om/TaskProfile.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Joblet.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/sort/SortGroupByOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybri
Change in asterixdb[master]: [NO ISSUE][FUN] Return elapsedTime in Seconds
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3348 ) Change subject: [NO ISSUE][FUN] Return elapsedTime in Seconds .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3348 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I412101ea43c1cbe13b15ed3ebb246af3c52e7b17 Gerrit-Change-Number: 3348 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 17 Apr 2019 23:30:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3226 ) Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. Patch Set 27: (12 comments) https://asterix-gerrit.ics.uci.edu/#/c/3226/25/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java: https://asterix-gerrit.ics.uci.edu/#/c/3226/25/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java@85 PS25, Line 85: static fi > It actually gets deserialized elsewhere, but I can make it serializable. Don't the Stats objects get sent around via IPC? https://asterix-gerrit.ics.uci.edu/#/c/3226/27/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: https://asterix-gerrit.ics.uci.edu/#/c/3226/27/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java@358 PS27, Line 358: printProfile I think that the indentation/pretty printing happens in the ResultPrinter, could you check where the other sub elements of the response envelope are serialized? https://asterix-gerrit.ics.uci.edu/#/c/3226/27/asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IARecordBuilder.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IARecordBuilder.java: https://asterix-gerrit.ics.uci.edu/#/c/3226/27/asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IARecordBuilder.java@58 PS27, Line 58: AsterixException HyracksDataException https://asterix-gerrit.ics.uci.edu/#/c/3226/27/asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IARecordBuilder.java@69 PS27, Line 69: * @throws IOException : * @throws AsterixException : HyracksDataException https://asterix-gerrit.ics.uci.edu/#/c/3226/27/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/FieldAccessByNameEvalFactory.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/FieldAccessByNameEvalFactory.java: https://asterix-gerrit.ics.uci.edu/#/c/3226/27/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/FieldAccessByNameEvalFactory.java@110 PS27, Line 110: Remove the empty lines/revert file? https://asterix-gerrit.ics.uci.edu/#/c/3226/27/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedOperatorNodePushable.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedOperatorNodePushable.java: https://asterix-gerrit.ics.uci.edu/#/c/3226/27/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedOperatorNodePushable.java@36 PS27, Line 36: boolean skipFw remove? https://asterix-gerrit.ics.uci.edu/#/c/3226/27/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedOperatorNodePushable.java@71 PS27, Line 71: } remove empty line above? https://asterix-gerrit.ics.uci.edu/#/c/3226/27/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java: https://asterix-gerrit.ics.uci.edu/#/c/3226/27/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java@43 PS27, Line 43: getOperatorStats remove this one? https://asterix-gerrit.ics.uci.edu/#/c/3226/27/hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/impl/ClientCounterContext.java File hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/impl/ClientCounterContext.java: https://asterix-gerrit.ics.uci.edu/#/c/3226/27/hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/impl/ClientCounterContext.java@33 PS27, Line 33: org.apache.hyracks.api.com Is this a new package? https://asterix-gerrit.ics.uci.edu/#/c/3226/27/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/StatsCollector.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/StatsCollector.java: https://asterix-gerrit.ics.uci.edu/#/c/3226/27/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/StatsCollector.java@51 PS27, Line 51: getOperatorStats remove this as we have the other one? https://asterix-gerrit.ics.uci.edu/#/c/3226/27/hyracks-fullsta
Change in asterixdb[master]: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3336 ) Change subject: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider .. Patch Set 3: Code-Review+2 Looks good. Please file issues for the big TODOs in here. -- To view, visit https://asterix-gerrit.ics.uci.edu/3336 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37767a3f3d1e3b29597d2a4998c0b60005cadb09 Gerrit-Change-Number: 3336 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 17 Apr 2019 05:21:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3336 ) Change subject: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider .. Patch Set 3: > Patch Set 3: Contrib-2 > > Analytics Compatibility Tests Failed > https://cbjenkins.page.link/mbwcq6bPc7hUUgnB7 : UNSTABLE overriding known failing test -- To view, visit https://asterix-gerrit.ics.uci.edu/3336 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37767a3f3d1e3b29597d2a4998c0b60005cadb09 Gerrit-Change-Number: 3336 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 17 Apr 2019 05:20:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3336 ) Change subject: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider .. Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3336/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java: https://asterix-gerrit.ics.uci.edu/#/c/3336/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java@97 PS2, Line 97: // TODO(ali): Good question. File an issues and/or ask somebody who relies on lowercase comparisons? https://asterix-gerrit.ics.uci.edu/#/c/3336/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/TypeTraitProvider.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/TypeTraitProvider.java: https://asterix-gerrit.ics.uci.edu/#/c/3336/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/TypeTraitProvider.java@36 PS2, Line 36: TWELVE_BYTES Stick with the naming convention? -- To view, visit https://asterix-gerrit.ics.uci.edu/3336 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37767a3f3d1e3b29597d2a4998c0b60005cadb09 Gerrit-Change-Number: 3336 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 16 Apr 2019 19:53:44 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][COMP] Minor cleanup in VariableCheckAndRewriteVisitor
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3343 ) Change subject: [NO ISSUE][COMP] Minor cleanup in VariableCheckAndRewriteVisitor .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3343 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icaab2a29f787439eebd67e44aa6a9e92df422a98 Gerrit-Change-Number: 3343 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 16 Apr 2019 00:11:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling
Till Westmann has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3226 )
Change subject: [ASTERIXDB-2532][RT] per-operator profiling
..
Patch Set 25:
(30 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3226/25//COMMIT_MSG
Commit Message:
https://asterix-gerrit.ics.uci.edu/#/c/3226/25//COMMIT_MSG@9
PS25, Line 9: the analyze
: variable is set in a query
I think that it would be more consistent, if we used a parameter for the HTTP
interface for the profile (similar to the way we do it for the plans).
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java@85
PS25, Line 85: transient
Why don't we need to serialize the jobProfile?
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java@51
PS25, Line 51: jobProfile
Wondering if we should just call this "profile". What do you think?
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.3.profile.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.3.profile.sqlpp:
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.3.profile.sqlpp@27
PS25, Line 27: set analyze "true";
I think that it would be more consistent, if we used a parameter for the HTTP
interface for the profile (similar to the way we do it for the plans).
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
File
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java@69
PS25, Line 69: if (profile) {
It seems that it should be possible to have both wrappers:
if (profile) {
fw = TimedFrameWriter.time(fw, ctx, "Aggregate Writer");
}
if (enforce) {
fw = EnforceFrameWriter.enforce(fw);
}
Is there a known reason why that wouldn't work?
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java
File
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java@65
PS25, Line 65: start
it seems that the wrapping code from NestedPlansRunningAggregatorFactory should
be applicable here as well
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java@108
PS25, Line 108: start
it seems that the wrapping code from NestedPlansRunningAggregatorFactory should
be applicable here as well
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/IPassableTimer.java
File
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/IPassableTimer.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/IPassableTimer.java@21
PS25, Line 21: IPassableTimer
Add some explanation to this interface?
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedFrameWriter.java
File
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedFrameWriter.java:
https://asterix-gerrit.ics.uci.edu/#/c/3226/25/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedFrameWriter.java@40
PS25, Li
Change in asterixdb[master]: [ASTERIXDB-2539][COMP] Exclude LET variables from "Single Variable Re...
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3322 ) Change subject: [ASTERIXDB-2539][COMP] Exclude LET variables from "Single Variable Resolution" rule .. Patch Set 4: Code-Review+2 (2 comments) Looks good - found 1 typo in there docs. Please forward the +2 if you decide to fix the typo before submission. https://asterix-gerrit.ics.uci.edu/#/c/3322/4/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_3_resolution.md File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_3_resolution.md: https://asterix-gerrit.ics.uci.edu/#/c/3322/4/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_3_resolution.md@261 PS4, Line 261: expresion expression https://asterix-gerrit.ics.uci.edu/#/c/3322/4/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/Sql92AggregateFunctionVisitor.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/Sql92AggregateFunctionVisitor.java: https://asterix-gerrit.ics.uci.edu/#/c/3322/4/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/Sql92AggregateFunctionVisitor.java@169 PS4, Line 169: // TODO: move to VariableCheckAndRewriteVisitor File a task for this? -- To view, visit https://asterix-gerrit.ics.uci.edu/3322 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b9f70a1671378f5216ec4e30416d4d67c3df089 Gerrit-Change-Number: 3322 Gerrit-PatchSet: 4 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Fri, 12 Apr 2019 02:24:50 + Gerrit-HasComments: Yes
Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB][CLUS] Add failed nodes API to ClusterStateManager
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3335 ) Change subject: [NO ISSUE][*DB][CLUS] Add failed nodes API to ClusterStateManager .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3335 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-MessageType: comment Gerrit-Change-Id: I1b56b29c38f0bbfe54b30ee5781770e90404c528 Gerrit-Change-Number: 3335 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Thu, 11 Apr 2019 21:39:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][API] Rename Request Cancellation API Parameter
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][API] Rename Request Cancellation API Parameter .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3334 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I357762beff5384e52ce6f25837d2390f02ad10ad Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Make Dump_Index Function Return An Array of ...
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][FUN] Make Dump_Index Function Return An Array of Values .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3332 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffdd0c1ad490952eb9bebdd0ac5015deddb3be42 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][STO] Ensure Invalid Merged Components Are Deleted
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][STO] Ensure Invalid Merged Components Are Deleted .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3331 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d72b1b614718e2e283bc72a874c140d178d1e0 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Fail Fast On Request Cancellation After Job C...
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][RT] Fail Fast On Request Cancellation After Job Completion .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3321 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4f154f11305e2f8286e0707b5b3adec905633a4 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use RuntimeMXBean.getPid() when available
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Use RuntimeMXBean.getPid() when available .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3312 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2371171dfc01423921c2e2d04fbc68a38978f2e Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Multiple parameters for two-step aggregatio...
Till Westmann has submitted this change and it was merged.
Change subject: [NO ISSUE][COMP] Multiple parameters for two-step aggregation
functions
..
[NO ISSUE][COMP] Multiple parameters for two-step aggregation functions
- user model changes: no
- storage format changes: no
- interface changes: yes
Details:
Hooks to enable aggregate functions have multiple arguments.
Change-Id: Ibaef2c0b2cf858d1aa7dd0f645f773fd04a865b3
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3298
Reviewed-by: Till Westmann
Integration-Tests: Jenkins
Tested-by: Till Westmann
Contrib: Jenkins
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggFuncIntoStandaloneAggregateRule.java
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/AbstractScalarAggregateDescriptor.java
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceCombinerRule.java
4 files changed, 23 insertions(+), 9 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Till Westmann: Looks good to me, approved; Verified
Jenkins: ; Verified
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggFuncIntoStandaloneAggregateRule.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggFuncIntoStandaloneAggregateRule.java
index c0dc8be..4ae25e8 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggFuncIntoStandaloneAggregateRule.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggFuncIntoStandaloneAggregateRule.java
@@ -218,8 +218,11 @@
List> aggArgs = new
ArrayList>();
aggArgs.add(aggOpExpr.getArguments().get(0));
+int sz = assignFuncExpr.getArguments().size();
+aggArgs.addAll(assignFuncExpr.getArguments().subList(1, sz));
AggregateFunctionCallExpression aggFuncExpr =
BuiltinFunctions.makeAggregateFunctionExpression(aggFuncIdent, aggArgs);
+
aggFuncExpr.setSourceLocation(assignFuncExpr.getSourceLocation());
LogicalVariable newVar = context.newVar();
aggOp.getVariables().add(newVar);
@@ -241,10 +244,9 @@
for (Mutable exprRef : exprRefs) {
ILogicalExpression expr = exprRef.getValue();
-if (expr.getExpressionTag() == LogicalExpressionTag.VARIABLE) {
-if (((VariableReferenceExpression)
expr).getVariableReference().equals(aggVar)) {
-return false;
-}
+if ((expr.getExpressionTag() == LogicalExpressionTag.VARIABLE)
+&& ((VariableReferenceExpression)
expr).getVariableReference().equals(aggVar)) {
+return false;
}
if (expr.getExpressionTag() != LogicalExpressionTag.FUNCTION_CALL)
{
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
index d2bbc04..217b065 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
@@ -252,7 +252,8 @@
throw new NullPointerException("Error parsing expected or
actual result file for " + scriptFile);
}
if (!TestHelper.equalJson(expectedJson, actualJson)) {
-throw new ComparisonException("Result for " + scriptFile +
" didn't match the expected JSON");
+throw new ComparisonException(
+"Result for " + scriptFile + " didn't match the
expected JSON" + "\n" + actualJson);
}
return;
}
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/AbstractScalarAggregateDescriptor.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/AbstractScalarAggregateDescriptor.java
index de376c6..2a311fb 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/AbstractScalarAggregateDescriptor.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/AbstractScalarAggregateDescriptor.java
@@ -43,10 +43,18 @@
@Override
public IScalarEvaluatorFactory createEvaluatorFactory(final
IScalarEvaluatorFactory[] args)
throws AlgebricksException {
-// The aggregate function will get a SingleFieldFrameTupleReference
that points to the result of the ScanCollection.
-
Change in asterixdb[master]: [NO ISSUE][COMP] Multiple parameters for two-step aggregatio...
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][COMP] Multiple parameters for two-step aggregation functions .. Patch Set 6: Verified+1 Apparently all tests ran - not sure why there is no vote. -- To view, visit https://asterix-gerrit.ics.uci.edu/3298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaef2c0b2cf858d1aa7dd0f645f773fd04a865b3 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: sandeep.gu...@couchbase.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Multiple parameters for two-step aggregatio...
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3298 to look at the new patch set (#6). Change subject: [NO ISSUE][COMP] Multiple parameters for two-step aggregation functions .. [NO ISSUE][COMP] Multiple parameters for two-step aggregation functions - user model changes: no - storage format changes: no - interface changes: yes Details: Hooks to enable aggregate functions have multiple arguments. Change-Id: Ibaef2c0b2cf858d1aa7dd0f645f773fd04a865b3 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggFuncIntoStandaloneAggregateRule.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/AbstractScalarAggregateDescriptor.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceCombinerRule.java 4 files changed, 23 insertions(+), 9 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/98/3298/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/3298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibaef2c0b2cf858d1aa7dd0f645f773fd04a865b3 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: sandeep.gu...@couchbase.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NO ISSUE][COMP] Multiple parameters for two-step aggregatio...
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][COMP] Multiple parameters for two-step aggregation functions .. Patch Set 6: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaef2c0b2cf858d1aa7dd0f645f773fd04a865b3 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: sandeep.gu...@couchbase.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Make StreamSelectRuntimeFactory Extensible
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][RT] Make StreamSelectRuntimeFactory Extensible .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3308 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c575e6c037e5c8c1818cfa3c6b0bf65697bfb9e Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] SonarQube fixes
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] SonarQube fixes .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3307 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f135fa10a0f78c967f2803bb2c3bce83e96a123 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add Completed_Requests Function
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][FUN] Add Completed_Requests Function .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f47d523c683c3879ec52ce5bdaf16ce338e8e46 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2536][COMP] Do not push Select through RunningAgg...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2536][COMP] Do not push Select through RunningAggregate .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3305 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae9e69d2a15664360ae8f05fd09eba1a38e346c7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add Completed_Requests Function
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][FUN] Add Completed_Requests Function .. Patch Set 3: (2 comments) Looks good, but the "elapsedTime" is strange - it seems to include time that passed before the query submission. https://asterix-gerrit.ics.uci.edu/#/c/3301/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ClientRequestsRequest.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ClientRequestsRequest.java: PS3, Line 43: RequestsType requestsType just RequestType ? PS3, Line 62: requests type "request type"? -- To view, visit https://asterix-gerrit.ics.uci.edu/3301 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f47d523c683c3879ec52ce5bdaf16ce338e8e46 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3226 to look at the new patch set (#23). Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. [ASTERIXDB-2532][RT] per-operator profiling Enables profiling in queries at the operator-level when the analyze variable is set in a query. Change-Id: Ie16f3901ae5b32920d8552d5fd1ec8bb6e2ec8ae --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ProfiledExecutionTest.java A asterixdb/asterix-app/src/test/resources/cc-single.conf A asterixdb/asterix-app/src/test/resources/runtimets/profiled.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.3.profile.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/profile/full-scan/full-scan.3.regexadm M asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IARecordBuilder.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/OpenRecordConstructorDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/AlgebricksMetaOperatorDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java R hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/com/job/profiling/counters/Counter.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/IPassableTimer.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedFrameWriter.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java R hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/OperatorStats.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/AggregateCounter.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/impl/ClientCounterContext.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/StatsCollector.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/om/TaskProfile.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Joblet.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/sort/SortGroupByOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/result/ResultWriterOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractEx
Change in asterixdb[master]: [NO ISSUE] Use correct type tag
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Use correct type tag .. Patch Set 1: Integration-Tests+1 Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3292 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I078b22179d62a43904de42e9fdad7995d4a8c864 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use correct type tag
Till Westmann has submitted this change and it was merged.
Change subject: [NO ISSUE] Use correct type tag
..
[NO ISSUE] Use correct type tag
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: I078b22179d62a43904de42e9fdad7995d4a8c864
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3292
Integration-Tests: Till Westmann
Tested-by: Till Westmann
Reviewed-by: Ali Alsuliman
---
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Anon. E. Moose #1000171:
Till Westmann: Verified; Verified
Ali Alsuliman: Looks good to me, approved
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
index b4cc4ce..a972e5a 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
@@ -79,7 +79,7 @@
throw new TypeMismatchException(sourceLoc,
getIdentifier(), 0, typeTag0,
ATypeTag.SERIALIZED_INTERVAL_TYPE_TAG);
}
-byte typeTag1 = argPtr0.getTag();
+byte typeTag1 = argPtr1.getTag();
if (typeTag1 != ATypeTag.SERIALIZED_INTERVAL_TYPE_TAG)
{
throw new TypeMismatchException(sourceLoc,
getIdentifier(), 1, typeTag1,
ATypeTag.SERIALIZED_INTERVAL_TYPE_TAG);
--
To view, visit https://asterix-gerrit.ics.uci.edu/3292
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I078b22179d62a43904de42e9fdad7995d4a8c864
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NO ISSUE][FUN] active_requests() returns more requests
Till Westmann has abandoned this change. Change subject: [NO ISSUE][FUN] active_requests() returns more requests .. Abandoned use a different (additional) function instead -- To view, visit https://asterix-gerrit.ics.uci.edu/3295 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I945ba790853bbcbff29dbb4daa4e0df96f7cae2d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE][*DB] Update version to 0.9.5-SNAPSHOT
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][*DB] Update version to 0.9.5-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3297 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I753d3993cc936fa31c9879208f94ef94c5569545 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] active_requests() returns more requests
Till Westmann has uploaded a new patch set (#2). Change subject: [NO ISSUE][FUN] active_requests() returns more requests .. [NO ISSUE][FUN] active_requests() returns more requests - user model changes: yes - storage format changes: no - interface changes: no The active_requests() function returns a few recently completed requests in addition to the currently running requests. Change-Id: I945ba790853bbcbff29dbb4daa4e0df96f7cae2d --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/ClientRequest.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClientRequest.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/RequestTracker.java 4 files changed, 41 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/95/3295/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3295 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I945ba790853bbcbff29dbb4daa4e0df96f7cae2d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE][FUN] active_requests() return more requests
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3295
Change subject: [NO ISSUE][FUN] active_requests() return more requests
..
[NO ISSUE][FUN] active_requests() return more requests
- user model changes: yes
- storage format changes: no
- interface changes: no
The active_requests() function returns a few recently completed requests in
addition to the currently running requests.
Change-Id: I945ba790853bbcbff29dbb4daa4e0df96f7cae2d
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/ClientRequest.java
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClientRequest.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/RequestTracker.java
4 files changed, 41 insertions(+), 4 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/95/3295/1
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
index 50e6cc2..cce1213 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
@@ -44,6 +44,7 @@
if (complete) {
return;
}
+state = "completed";
complete = true;
}
@@ -53,6 +54,7 @@
return;
}
complete();
+state = "cancelled";
if (cancellable) {
doCancel(appCtx);
}
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/ClientRequest.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/ClientRequest.java
index c19bb02..c051026 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/ClientRequest.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/ClientRequest.java
@@ -51,6 +51,11 @@
setRunning();
}
+@Override
+public JobId getJobId() {
+return jobId;
+}
+
public Thread getExecutor() {
return executor;
}
diff --git
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClientRequest.java
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClientRequest.java
index 430cd2a..0cc0ba0 100644
---
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClientRequest.java
+++
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClientRequest.java
@@ -20,6 +20,7 @@
import org.apache.asterix.common.dataflow.ICcApplicationContext;
import org.apache.hyracks.api.exceptions.HyracksDataException;
+import org.apache.hyracks.api.job.JobId;
public interface IClientRequest {
@@ -38,6 +39,13 @@
String getClientContextId();
/**
+ * The JobId assigned by the system for job execution
+ *
+ * @return the system provided JobId
+ */
+JobId getJobId();
+
+/**
* Mark the request as complete, non-cancellable anymore
*/
void complete();
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/RequestTracker.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/RequestTracker.java
index a0ab559..61403e0 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/RequestTracker.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/RequestTracker.java
@@ -20,18 +20,25 @@
import java.util.Collection;
import java.util.Collections;
+import java.util.HashSet;
import java.util.Map;
import java.util.Objects;
+import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
import org.apache.asterix.common.api.IClientRequest;
import org.apache.asterix.common.api.IRequestTracker;
import org.apache.asterix.common.dataflow.ICcApplicationContext;
import org.apache.hyracks.api.exceptions.HyracksDataException;
+import org.apache.hyracks.api.job.JobId;
+import org.apache.hyracks.control.cc.ClusterControllerService;
+import org.apache.hyracks.control.cc.job.JobRun;
public class RequestTracker implements IRequestTracker {
private final Map runningRequests = new
ConcurrentHashMap<>();
+private final Map archivedRequests = new
ConcurrentHashMap<>();
private final Map clientIdRequests = new
ConcurrentHashMap<>();
private final ICcApplicationContext ccAppCtx;
@@ -81,7 +88,9 @@
@Override
public synchronized Collection getRunningRequests() {
-return Collections.unmodifiableCollection(runningRequests.values());
+Collection
Change in asterixdb[master]: [NO ISSUE] Additional constructor for TaggedValuePointable
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Additional constructor for TaggedValuePointable .. Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3242/5/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/TaggedValuePointable.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/TaggedValuePointable.java: PS5, Line 39: value.set(bytes, start + 1, length - 1); > Shouldn't this be changed depending on whether "start" points to the tag or Yes, we would need to adjust the pointers when setting the pointable. -- To view, visit https://asterix-gerrit.ics.uci.edu/3242 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cad369ecb2f7cafd901f11e757272dce7e1e6b5 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE] Use correct type tag
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3292
Change subject: [NO ISSUE] Use correct type tag
..
[NO ISSUE] Use correct type tag
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: I078b22179d62a43904de42e9fdad7995d4a8c864
---
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/92/3292/1
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
index b4cc4ce..a972e5a 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java
@@ -79,7 +79,7 @@
throw new TypeMismatchException(sourceLoc,
getIdentifier(), 0, typeTag0,
ATypeTag.SERIALIZED_INTERVAL_TYPE_TAG);
}
-byte typeTag1 = argPtr0.getTag();
+byte typeTag1 = argPtr1.getTag();
if (typeTag1 != ATypeTag.SERIALIZED_INTERVAL_TYPE_TAG)
{
throw new TypeMismatchException(sourceLoc,
getIdentifier(), 1, typeTag1,
ATypeTag.SERIALIZED_INTERVAL_TYPE_TAG);
--
To view, visit https://asterix-gerrit.ics.uci.edu/3292
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I078b22179d62a43904de42e9fdad7995d4a8c864
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3226 to look at the new patch set (#22). Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. [ASTERIXDB-2532][RT] per-operator profiling Enables profiling in queries at the operator-level when the analyze variable is set in a query. Change-Id: Ie16f3901ae5b32920d8552d5fd1ec8bb6e2ec8ae --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ProfiledExecutionTest.java A asterixdb/asterix-app/src/test/resources/cc-single.conf A asterixdb/asterix-app/src/test/resources/runtimets/profiled.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.3.profile.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/profile/full-scan/full-scan.3.regexadm M asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IARecordBuilder.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/OpenRecordConstructorDescriptor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/FieldAccessByNameEvalFactory.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/AlgebricksMetaOperatorDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java R hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/com/job/profiling/counters/Counter.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/IPassableTimer.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedFrameWriter.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java R hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/OperatorStats.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/AggregateCounter.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/impl/ClientCounterContext.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/StatsCollector.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/om/TaskProfile.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Joblet.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/sort/SortGroupByOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin
Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3226 to look at the new patch set (#21). Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. [ASTERIXDB-2532][RT] per-operator profiling Enables profiling in queries at the operator-level when the analyze variable is set in a query. Change-Id: Ie16f3901ae5b32920d8552d5fd1ec8bb6e2ec8ae --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ProfiledExecutionTest.java A asterixdb/asterix-app/src/test/resources/cc-single.conf A asterixdb/asterix-app/src/test/resources/runtimets/profiled.xml A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.3.profile.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/profile/full-scan/full-scan.4.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/profile/full-scan/full-scan.3.regexadm M asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IARecordBuilder.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/OpenRecordConstructorDescriptor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/FieldAccessByNameEvalFactory.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/AlgebricksMetaOperatorDescriptor.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java R hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/com/job/profiling/counters/Counter.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/IPassableTimer.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedFrameWriter.java A hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataflow/TimedOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IStatsCollector.java R hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/OperatorStats.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/AggregateCounter.java M hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/stats/impl/ClientCounterContext.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/StatsCollector.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/om/TaskProfile.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Joblet.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/sort/SortGroupByOperatorDescriptor.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin
Change in asterixdb[master]: [ASTERIXDB-2516][RT] Make asterix types comparators singleto...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] Make asterix types comparators singleton and stateless .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3255 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Apply / enforce java import order
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Apply / enforce java import order .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3288 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55d976c4df10d9919c6a25683be2a3e3304e65d9 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2516][RT] Make asterix types comparators singleto...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] Make asterix types comparators singleton and stateless .. Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3255/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/ACirclePartialBinaryComparatorFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/ACirclePartialBinaryComparatorFactory.java: PS2, Line 37: INSTANCE_COMP Would it make sense to call this COMPARATOR? It would be used in other code as ACirclePartialBinaryComparatorFactory.COMPARATOR, which seems ok. https://asterix-gerrit.ics.uci.edu/#/c/3255/2/hyracks-fullstack/hyracks/hyracks-hdfs/src/main/java/org/apache/hyracks/hdfs/lib/RawBinaryComparatorFactory.java File hyracks-fullstack/hyracks/hyracks-hdfs/src/main/java/org/apache/hyracks/hdfs/lib/RawBinaryComparatorFactory.java: PS2, Line 24: TODO It seems that we should remove the one is AsterixDB. -- To view, visit https://asterix-gerrit.ics.uci.edu/3255 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][OTH] Make Query Service Parameters Extensible
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][OTH] Make Query Service Parameters Extensible .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3283 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice7b70279da899cce1fe89140bc158642fd13348 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] IApplication interface change to allow confi...
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][OTH] IApplication interface change to allow configuring loggers .. Patch Set 3: Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3281 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9724d9f12650f8e2c1f9d25c098028c75da7606 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] IApplication interface change to allow confi...
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][OTH] IApplication interface change to allow configuring loggers .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3281 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9724d9f12650f8e2c1f9d25c098028c75da7606 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Avoid writing field names & values wh...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][COMP] Avoid writing field names & values when comparing records .. Patch Set 1: Code-Review+1 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java: PS1, Line 117: getTagOffset I think that we should also consider to inline a few of these methods, if they only have one consumer. Having well-named methods help to create self-describing code, but having too many methods can negate the benefits. https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java: Line 61: // TODO: how come the item type in this instance is "null" > not anymore. https://asterix-gerrit.ics.uci.edu/#/c/3247/ Indeed! -- To view, visit https://asterix-gerrit.ics.uci.edu/3280 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19ac95a91749b2983bf06f763e463521a97a261c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][TYPE] Avoid 'null' collection types
Till Westmann has submitted this change and it was merged.
Change subject: [NO ISSUE][TYPE] Avoid 'null' collection types
..
[NO ISSUE][TYPE] Avoid 'null' collection types
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: Id7ab2a20e776152ecf35d5bd01b1eded7e987e26
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3247
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Michael Blow
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java
3 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Michael Blow: Looks good to me, approved
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
index 9edfddb..bb620b0 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
@@ -48,6 +48,8 @@
import org.apache.asterix.om.types.TypeSignature;
import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
+import static org.apache.asterix.om.types.BuiltinType.ANY;
+
public class TypeTranslator {
private TypeTranslator() {
@@ -200,7 +202,7 @@
throws AlgebricksException {
TypeExpression tExpr = oltd.getItemTypeExpression();
String typeName = typeSignature != null ? typeSignature.getName() :
null;
-AOrderedListType aolt = new AOrderedListType(null, typeName);
+AOrderedListType aolt = new AOrderedListType(ANY, typeName);
setCollectionItemType(tExpr, typeMap, incompleteItemTypes,
incompleteFieldTypes, aolt, defaultDataverse);
return aolt;
}
@@ -212,7 +214,7 @@
throws AlgebricksException {
TypeExpression tExpr = ultd.getItemTypeExpression();
String typeName = typeSignature != null ? typeSignature.getName() :
null;
-AUnorderedListType ault = new AUnorderedListType(null, typeName);
+AUnorderedListType ault = new AUnorderedListType(ANY, typeName);
setCollectionItemType(tExpr, typeMap, incompleteItemTypes,
incompleteFieldTypes, ault, defaulDataverse);
return ault;
}
diff --git
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java
index 9defce0..711b2f3 100644
---
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java
+++
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java
@@ -31,8 +31,7 @@
private static final long serialVersionUID = 1L;
-// TODO: why is the item type "null"? why not ANY?
-public static final AUnorderedListType FULLY_OPEN_UNORDEREDLIST_TYPE = new
AUnorderedListType(null, "");
+public static final AUnorderedListType FULLY_OPEN_UNORDEREDLIST_TYPE = new
AUnorderedListType(BuiltinType.ANY, "");
/**
* @param itemType
diff --git
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java
index 1b2b8fe..4b748a9 100644
---
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java
+++
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java
@@ -18,6 +18,8 @@
*/
package org.apache.asterix.om.types;
+import java.util.Objects;
+
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.io.IJsonSerializable;
import org.apache.hyracks.api.io.IPersistedResourceRegistry;
@@ -33,7 +35,7 @@
AbstractCollectionType(IAType itemType, String typeName) {
super(typeName);
-this.itemType = itemType;
+this.itemType = Objects.requireNonNull(itemType);
}
public boolean isTyped() {
--
To view, visit https://asterix-gerrit.ics.uci.edu/3247
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7ab2a20e776152ecf35d5bd01b1eded7e987e26
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Avoid writing into buffer when compar...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][COMP] Avoid writing into buffer when comparing numbers .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3272 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie089d386a9ab8271f2833c05ffdfb0d484937b51 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
