Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-11 Thread Ali Alsuliman (Code Review) 
Ali Alsuliman has submitted this change and it was merged.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


[ASTERIXDB-2516][COMP] Change logical comparators handling of null/missing

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Change the result of comparing against null and missing.
For arrays, comparing against null or missing item will result in incomparable.
For records, comparing against a null field will result in incomparable.
- modified test cases accordingly
- moved few object factories to the common place.
- modified compareRecords to avoid string construction for field names
- few code clean-ups.

Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3259
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Dmitry Lychagin 
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.014.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.021.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.022.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/records/records.005.adm
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/CompareHashUtil.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AbstractAGenericBinaryComparator.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalScalarBinaryComparator.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/ObjectFactories.java
11 files changed, 67 insertions(+), 125 deletions(-)

Approvals:
  Jenkins: Verified; ; Verified
  Dmitry Lychagin: Looks good to me, approved

Objections:
  Anon. E. Moose #1000171: Violations found
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.adm
index d386253..e1b8022 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.adm
@@ -1 +1 @@
-{ "t1": { "c": "[[1.0,4], [5,9,11,14]] = [[1.0,4], [5,9,11,14]]", "r": true }, 
"t2": { "c": "[[5,2,7], ['green','black'], [date('2013-01-01')]] = [[5,2,7], 
['green','black'], [date('2013-01-01')]]", "r": true }, "t3": { "c": 
"[['white','yellow','brown'], 6] != [['white','yellow','brown'], double('6')]", 
"r": false }, "t4": { "c": "[['white','yellow','brown'], 6] != [double('6'), 
['white','yellow','brown']]", "r": null }, "t5": { "c": "[ [[1,2,3], 'gold', 
['sql++', 5]], [tinyint('4'), tinyint('5')], smallint('2')] > [ [[1,2,3], 
'gold', ['sql++', 5]], [bigint('4'), int('5')], double('0.2')]", "r": true }, 
"t6": { "c": "[[[1,2], 99], 77] <= [[['flute',2], 99], 77]", "r": null }, "t7": 
{ "c": "[[[1,2], 99], 77] <= [[[missing,2], 99], 77]" }, "t8": { "c": "[5, 
[8,1], [[0, 4], 'b']] > [5, [8,1], [[0, 4], 'a', 'c']]", "r": true }, "t9": { 
"c": "[[1, null], 9] = [[1, 2], 9]", "r": null }, "t10": { "c": "[[1, null], 9] 
= [[1, 2], 99]", "r": false }, "t11": { "c": "[[1, null], 9] < [[1, 2], 9
 ]", "r": null }, "t12": { "c": "[[1, null], 9] < [[1, 2], 99]", "r": null }, 
"t13": { "c": "[[1, null], 9] > [[1, 2], 9]", "r": null }, "t14": { "c": "[[1, 
null], 9] > [[1, 2], 99]", "r": null }, "t15": { "c": "[1,2] = {{1,2}}", "r": 
null }, "t16": { "c": "{'id':99, 'name':'sam'} != [99, 'sam']", "r": null }, 
"t17": { "c": "[[1, 'string'], 9] = [[1, 2], 9]", "r": null }, "t18": { "c": 
"[[1, 'string'], 9] = [[1, 2], 99]", "r": null }, "t19": { "c": "[[1, 
'string'], 9] < [[1, 2], 9]", "r": null }, "t20": { "c": "[[1, 'string'], 9] < 
[[1, 2], 99]", "r": null }, "t21": { "c": "[[1, 'string'], 9] > [[1, 2], 9]", 
"r": null }, "t22": { "c": "[[1, 'string'], 9] > [[1, 2], 99]", "r": null } }
\ No newline at end of file
+{ "t1": { "c": "[[1.0,4], [5,9,11,14]] = [[1.0,4], [5,9,11,14]]", "r": true }, 
"t2": { "c": "[[5,2,7], ['green','black'], [date('2013-01-01')]] = [[5,2,7], 
['green','black'], [date('2013-01-01')]]", "r": true }, "t3": { "c": 
"[['white','yellow','brown'], 6] != [['white','yellow','brown'], double('6')]", 
"r": false }, "t4": { "c": "[['white','yellow','brown'], 6] != [double('6'),

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-11 Thread Dmitry Lychagin (Code Review) 
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4047/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4047/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/301/ 
(16/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8096/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/ZU8KZ8 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8096/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://goo.gl/ZRkLGA : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5279/ 
(15/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/625/
 (12/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/688/
 (6/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3327/ 
(9/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5223/ 
(13/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9269/ (2/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5537/ 
(4/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/484/ (1/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5313/
 (14/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/135/ 
(11/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5894/ (7/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5685/ 
(3/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10801/ (8/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5531/
 (5/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5318/ 
(10/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Change logical comparators handling o...

2019-03-10 Thread Ali Alsuliman (Code Review) 
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3259

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of 
null/missing
..

[ASTERIXDB-2516][COMP] Change logical comparators handling of null/missing

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Change the result of comparing against null and missing.
For arrays, comparing against null or missing item will result in incomparable.
For records, comparing against a null field will result in incomparable.
- modified test cases accordingly
- moved few object factories to the common place.
- modified compareRecords to avoid string construction for field names
- few code clean-ups.

Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.014.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.021.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.022.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/records/records.005.adm
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/CompareHashUtil.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AbstractAGenericBinaryComparator.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalScalarBinaryComparator.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/ObjectFactories.java
11 files changed, 67 insertions(+), 125 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/59/3259/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann