Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Peeyush Gupta :
Peeyush Gupta has submitted this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 )
Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable
..
[ASTERIXDB-3391][OTH] Make DML statements cancellable
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
With this patch INSERT/UPSERT/DELETE and COPY statements are marked
cancellable. For atomic statements, the statements are cancelled as
long as the ingestion job is running i.e., ACKs from all nodes/partitions
are not received and the CC has not decided to commit the statement yet.
Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257
Reviewed-by: Murtadha Hubail
Integration-Tests: Jenkins
Tested-by: Murtadha Hubail
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
A
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/atomic_statements/AtomicStatementsCancellationTest.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
5 files changed, 169 insertions(+), 6 deletions(-)
Approvals:
Murtadha Hubail: Looks good to me, approved; Verified
Anon. E. Moose #1000171:
Jenkins: Verified
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
index 0436ea8..84a6488 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
@@ -54,9 +54,9 @@
if (complete) {
return;
}
-complete();
-state = State.CANCELLED;
if (cancellable) {
+complete();
+state = State.CANCELLED;
doCancel(appCtx);
}
}
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
index 0786895..9d1e108 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
@@ -215,6 +215,7 @@
@Override
public void abortTransaction(JobId jobId) throws Exception {
IGlobalTransactionContext context = getTransactionContext(jobId);
+context.resetAcksReceived();
if (context.getTxnStatus() == TransactionStatus.PREPARED) {
sendJobRollbackMessages(context);
}
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index 34648dd..3035496 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@ -4009,10 +4009,12 @@
final ClientRequest clientRequest =
(ClientRequest)
requestTracker.get(requestParameters.getRequestReference().getUuid());
clientRequest.setJobId(jobId);
+clientRequest.markCancellable();
String nameBefore = Thread.currentThread().getName();
try {
Thread.currentThread().setName(nameBefore + " :
WaitForCompletionForJobId: " + jobId);
hcc.waitForCompletion(jobId);
+ensureNotCancelled(clientRequest);
} finally {
Thread.currentThread().setName(nameBefore);
}
@@ -4151,7 +4153,7 @@
ClientRequest clientRequest = (ClientRequest)
requestTracker.get(reqParams.getRequestReference().getUuid());
if (stmtInsertUpsert.getReturnExpression() != null) {
deliverResult(hcc, resultSet, compiler, metadataProvider, locker,
resultDelivery, outMetadata, stats,
-reqParams, false, stmt, clientRequest);
+reqParams, true, stmt, clientRequest);
} else {
locker.lock();
JobId jobId = null;
@@ -4176,10 +4178,12 @@
}
jobId = JobUtils.runJob(hcc, jobSpec, jobFlags, false);
clientRequest.setJobId(jobId);
+clientRequest.markCancellable();
String nameBefore = Thread.currentThread().getName();
try {
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Murtadha Hubail : Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Murtadha Hubail has removed a vote from this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Removed Verified-1 by Jenkins -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 5 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-MessageType: deleteVote
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Murtadha Hubail : Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Patch Set 5: Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 5 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Mon, 06 May 2024 20:35:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Patch Set 5: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/yQYwsEe8VzAh2M8H9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 5 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Mon, 06 May 2024 19:35:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Jenkins : Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/466/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 5 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Mon, 06 May 2024 18:49:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Murtadha Hubail : Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 5 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Mon, 06 May 2024 18:21:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Patch Set 5: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/uvGx6F8jueEWCbVY6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 5 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Mon, 06 May 2024 17:22:09 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Peeyush Gupta : Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Hello Murtadha Hubail, Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, Murtadha Hubail, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 to look at the new patch set (#5). Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. [ASTERIXDB-3391][OTH] Make DML statements cancellable - user model changes: no - storage format changes: no - interface changes: no Details: With this patch INSERT/UPSERT/DELETE and COPY statements are marked cancellable. For atomic statements, the statements are cancelled as long as the ingestion job is running i.e., ACKs from all nodes/partitions are not received and the CC has not decided to commit the statement yet. Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/atomic_statements/AtomicStatementsCancellationTest.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java 5 files changed, 165 insertions(+), 6 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/57/18257/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 5 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-MessageType: newpatchset
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Murtadha Hubail : Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Patch Set 4: Code-Review+2 (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257/comment/8494e701_3054a0e8 PS4, Line 4252: clientRequest.setJobId(jobId); Don't you need clientRequest.markCancellable(); after this? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Sat, 04 May 2024 15:12:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Peeyush Gupta : Attention is currently required from: Ali Alsuliman, Murtadha Hubail. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Patch Set 4: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Wed, 01 May 2024 17:59:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Jenkins : Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/426/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Wed, 01 May 2024 02:32:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Hubail. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Patch Set 4: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/oek8pLowMQKVpdnf6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Tue, 30 Apr 2024 23:01:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
Attention is currently required from: Ali Alsuliman, Murtadha Hubail. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 ) Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. Patch Set 4: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/Ysh7uxqj7vYqw8VdA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Tue, 30 Apr 2024 20:51:35 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Peeyush Gupta : Attention is currently required from: Ali Alsuliman, Murtadha Hubail. Hello Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, Murtadha Hubail, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 to look at the new patch set (#4). Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. [ASTERIXDB-3391][OTH] Make DML statements cancellable - user model changes: no - storage format changes: no - interface changes: no Details: With this patch INSERT/UPSERT/DELETE and COPY statements are marked cancellable. For atomic statements, the statements are cancelled as long as the ingestion job is running i.e., ACKs from all nodes/partitions are not received and the CC has not decided to commit the statement yet. Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/atomic_statements/AtomicStatementsCancellationTest.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java 5 files changed, 164 insertions(+), 6 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/57/18257/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-MessageType: newpatchset
Change in asterixdb[master]: [ASTERIXDB-3391][OTH] Make DML statements cancellable
>From Peeyush Gupta : Attention is currently required from: Peeyush Gupta. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 to look at the new patch set (#3). Change subject: [ASTERIXDB-3391][OTH] Make DML statements cancellable .. [ASTERIXDB-3391][OTH] Make DML statements cancellable - user model changes: no - storage format changes: no - interface changes: no Details: With this patch INSERT/UPSERT/DELETE and COPY statements are marked cancellable. For atomic statements, the statements are cancelled as long as the ingestion job is running i.e., ACKs from all nodes/partitions are not received and the CC has not decided to commit the statement yet. Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/atomic_statements/AtomicStatementsCancellationTest.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java 6 files changed, 165 insertions(+), 7 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/57/18257/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0 Gerrit-Change-Number: 18257 Gerrit-PatchSet: 3 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Peeyush Gupta Gerrit-MessageType: newpatchset
