Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj :
Ritik Raj has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )
Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge
policy
..
Patch Set 13:
(4 comments)
File
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/607e1d55_ac03a0d9
PS12, Line 118: // getMergableIndexesRange gives the [startComponentIndex,
endComponentIndex] which can be merged based on the provided condition
: // 1. localMinMergeComponentCount <=
range(startComponentIndex, endComponentIndex) <= maxMergeComponentCount
: // 2. sumOfComponents(startComponentIndex,
endComponentIndex) < maxComponentSize
: // In order to satisfy range(startComponentIndex,
endComponentIndex) <= maxMergeComponentCount, the search range is bounded by
leftBoundary, and if we reach the maxComponentSize before
: // reaching the leftBoundary, we get our boundary where
startIndex > leftBoundary.
: // but in case the components in the range does not
contribute enough to exceed maxComponentSize then the candidate range
: // will be [leftBoundary, endComponentIndex] which
satisfies both 1 & 2.
> Minor: Use JavaDoc instead for the comments about methods. […]
Done
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/07b2a515_f882e477
PS12, Line 137: new MergableSolution(null, 0);
> Minor: Create a static final member (constat) for no solution
Done
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/037bc995_19289dd9
PS12, Line 188: if (!getMergableComponentsCount) {
> Minor: Flip the logic to avoid not '!' […]
Done
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/72dd2862_41413b65
PS12, Line 204: MergableSolution(null, totalMergableComponentsCount);
> Minor: create another constructor: […]
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 13
Gerrit-Owner: Ritik Raj
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Ritik Raj
Gerrit-Reviewer: Wail Alkowaileet
Gerrit-Reviewer: Wail Alkowaileet
Gerrit-Comment-Date: Tue, 14 May 2024 20:18:16 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wail Alkowaileet
Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Wail Alkowaileet, Ali Alsuliman. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 12: (2 comments) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/b29b4ef9_c89c05b3 PS12, Line 126: getMergableComponentsCount > Minor: find a better name. […] yes. will update the name. will address with the other comments in a follow-up patch. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/47d05338_aa9a84cf PS12, Line 182: since we exceeded the leftBoundary > Minor: Is this true even when the 'break;' above is reached? […] no, the condition shouldn't be true, if "break" is encountered, then we surely breached the maxComponentSize limit. Considering `probableStartIndex = leftBoundaryIndex` and if the break is encountered, then it won't ever be equal to `probableStartIndex = leftBoundaryIndex - 1` -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 12 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Mon, 13 May 2024 16:48:09 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Wail Alkowaileet, Ali Alsuliman. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 12: Code-Review+1 (1 comment) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/2c43571e_b9353b21 PS10, Line 38: NAME > we don't need to prefix the parameter names with the policy name Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 12 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Mon, 13 May 2024 11:10:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Murtadha Hubail Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Jenkins : Attention is currently required from: Wail Alkowaileet, Ali Alsuliman. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 12: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/534/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 12 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Fri, 10 May 2024 22:28:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Wail Alkowaileet, Ali Alsuliman. Hello Murtadha Hubail, Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, Wail Alkowaileet, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 to look at the new patch set (#12). Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy - user model changes: yes - storage format changes: no - interface changes: no Details: - Added storage property to set max mergable component size. - The new merge policy will schedule merges similar to the current ConcurrentMergePolicy but it will consider the max mergable component size. Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 --- M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/DatasetDeclParametersUtil.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm A asterixdb/asterix-common/src/test/java/org/apache/asterix/test/SizeBoundedConcurrentMergePolicyTest.java M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/qu
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Wail Alkowaileet, Ali Alsuliman. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 11: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 11 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Fri, 10 May 2024 14:36:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Jenkins : Attention is currently required from: Wail Alkowaileet, Ali Alsuliman, Ritik Raj. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 11: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/530/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 11 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Fri, 10 May 2024 10:56:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Wail Alkowaileet, Ali Alsuliman, Ritik Raj. Hello Murtadha Hubail, Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, Wail Alkowaileet, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 to look at the new patch set (#11). Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy - user model changes: yes - storage format changes: no - interface changes: no Details: - Added storage property to set max mergable component size. - The new merge policy will schedule merges similar to the current ConcurrentMergePolicy but it will consider the max mergable component size. Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 --- M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/DatasetDeclParametersUtil.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm A asterixdb/asterix-common/src/test/java/org/apache/asterix/test/SizeBoundedConcurrentMergePolicyTest.java M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm M asterixdb/asterix-app/src/test/resources
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Murtadha Hubail : Attention is currently required from: Wail Alkowaileet, Ali Alsuliman, Ritik Raj. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 10: (1 comment) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/30a7c57a_cda0a84d PS10, Line 38: NAME we don't need to prefix the parameter names with the policy name -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 10 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Thu, 09 May 2024 21:59:06 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
Attention is currently required from: Murtadha Hubail, Wail Alkowaileet, Ali Alsuliman, Ritik Raj. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 10: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/QAUDT58k7JCGxGjc9 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 10 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Thu, 09 May 2024 21:49:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
Attention is currently required from: Murtadha Hubail, Wail Alkowaileet, Ali Alsuliman, Ritik Raj. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 8: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/3J83hRNvfd37m4pc6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 8 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Thu, 09 May 2024 21:04:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Jenkins : Attention is currently required from: Murtadha Hubail, Wail Alkowaileet, Ali Alsuliman. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 10: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/516/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 10 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Thu, 09 May 2024 20:17:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
Attention is currently required from: Murtadha Hubail, Wail Alkowaileet, Ali Alsuliman. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 10: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/R6Gfk9fhu5XjRUqx9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 10 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Thu, 09 May 2024 18:40:05 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Murtadha Hubail, Wail Alkowaileet, Ali Alsuliman. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 10: (1 comment) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/98e82be2_1873449e PS8, Line 147: rangeLength >= localMinMergeComponentCount : && ((resultantComponentSize - currentComponentSize - oldestComponentSize) : * sizeRatio >= oldestComponentSize) > Extract as a method. It is always a good idea to have equations as a named > method/function. […] tried refactoring a bit, but does not seem much improvement on the if statements. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 10 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Thu, 09 May 2024 18:10:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Hello Murtadha Hubail, Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, Wail Alkowaileet, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 to look at the new patch set (#10). Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy - user model changes: yes - storage format changes: no - interface changes: no Details: - Added storage property to set max mergable component size. - The new merge policy will schedule merges similar to the current ConcurrentMergePolicy but it will consider the max mergable component size. Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 --- M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/DatasetDeclParametersUtil.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm A asterixdb/asterix-common/src/test/java/org/apache/asterix/test/SizeBoundedConcurrentMergePolicyTest.java M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm M asterixdb/asterix-app/sr
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Hello Murtadha Hubail, Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, Wail Alkowaileet, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 to look at the new patch set (#9). Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy - user model changes: yes - storage format changes: no - interface changes: no Details: - Added storage property to set max mergable component size. - The new merge policy will schedule merges similar to the current ConcurrentMergePolicy but it will consider the max mergable component size. Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 --- M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/DatasetDeclParametersUtil.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm A asterixdb/asterix-common/src/test/java/org/apache/asterix/test/SizeBoundedConcurrentMergePolicyTest.java M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm M asterixdb/asterix-app/src
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Wail Alkowaileet :
Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik
Raj, Wail Alkowaileet.
Wail Alkowaileet has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )
Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge
policy
..
Patch Set 8:
(3 comments)
File
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/3ef1f571_13d79761
PS8, Line 147: rangeLength >= localMinMergeComponentCount
: && ((resultantComponentSize -
currentComponentSize - oldestComponentSize)
: * sizeRatio >=
oldestComponentSize)
Extract as a method. It is always a good idea to have equations as a named
method/function.
This 'equation' and the one below is similar except for the part
resultantComponentSize - X and X can be either:
- currentComponentSize - oldestComponentSize
- oldestComponentSize
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/f6023550_37a9ff58
PS8, Line 147: if (rangeLength >= localMinMergeComponentCount
: && ((resultantComponentSize -
currentComponentSize - oldestComponentSize)
: * sizeRatio >=
oldestComponentSize)) {
: mergableComponentRanges++;
: if (possibleRange == null) {
: possibleRange = Pair.of(j + 1, end);
: }
:
: if (mergableComponentRanges >
maxAllowedCountOfMergableRange) {
: return new
MergableSolution(possibleRange, true);
: }
:
: if (onlyOne) {
: return new
MergableSolution(possibleRange, false);
: } else {
: end = j;
: found = true;
: }
: }
Extract as a method
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/7ff4cceb_4dabe2f7
PS8, Line 172: if (rangeLength >= localMinMergeComponentCount
: && ((resultantComponentSize -
oldestComponentSize) * sizeRatio >= oldestComponentSize)) {
: mergableComponentRanges++;
: if (possibleRange == null) {
: possibleRange = Pair.of(j + 1, end);
: }
:
: if (mergableComponentRanges >
maxAllowedCountOfMergableRange) {
: return new
MergableSolution(possibleRange, true);
: }
:
: if (onlyOne) {
: return new
MergableSolution(possibleRange, false);
: } else {
: end = j;
: found = true;
: }
: }
This will be similar to the extracted method above. Call it
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 8
Gerrit-Owner: Ritik Raj
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Ritik Raj
Gerrit-Reviewer: Wail Alkowaileet
Gerrit-CC: Wail Alkowaileet
Gerrit-Attention: Murtadha Hubail
Gerrit-Attention: Ali Alsuliman
Gerrit-Attention: Ritik Raj
Gerrit-Attention: Wail Alkowaileet
Gerrit-Comment-Date: Thu, 09 May 2024 16:20:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 8: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/2ecXrBGx73QT6Wcv6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 8 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Wed, 08 May 2024 10:41:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Jenkins : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 8: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/491/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 8 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Wed, 08 May 2024 09:30:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 8: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/pNJfwXT8nE9YHra87 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 8 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Wed, 08 May 2024 08:29:55 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Hello Murtadha Hubail, Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, Wail Alkowaileet, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 to look at the new patch set (#8). Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy - user model changes: yes - storage format changes: no - interface changes: no Details: - Added storage property to set max mergable component size. - The new merge policy will schedule merges similar to the current ConcurrentMergePolicy but it will consider the max mergable component size. Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 --- M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm A asterixdb/asterix-common/src/test/java/org/apache/asterix/test/SizeBoundedConcurrentMergePolicyTest.java M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp M asterixdb/asterix-a
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 7: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/5E1AEDrL5FMnJXSFA : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 7 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Wed, 08 May 2024 06:34:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Jenkins : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Wail Alkowaileet. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/490/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 7 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Wed, 08 May 2024 05:21:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Wail Alkowaileet. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 7: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/WH4QEy2Wx4ATxJmb6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 7 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Wed, 08 May 2024 04:24:18 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Wail Alkowaileet. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 7: (1 comment) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/fd812c19_af781af5 PS6, Line 74: INTEGER > Switch back to long? StorageUtil has a method that returns the value as long Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 7 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Wed, 08 May 2024 04:10:59 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Hello Murtadha Hubail, Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, Wail Alkowaileet, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 to look at the new patch set (#7). Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy - user model changes: yes - storage format changes: no - interface changes: no Details: - Added storage property to set max mergable component size. - The new merge policy will schedule merges similar to the current ConcurrentMergePolicy but it will consider the max mergable component size. Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 --- M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm A asterixdb/asterix-common/src/test/java/org/apache/asterix/test/SizeBoundedConcurrentMergePolicyTest.java M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp M asterixdb/asterix-app/src/test/reso
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Murtadha Hubail : Attention is currently required from: Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 6: (1 comment) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/931a713f_c6e49da3 PS6, Line 74: INTEGER Switch back to long? StorageUtil has a method that returns the value as long -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 6 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Tue, 07 May 2024 22:03:09 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 6: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/XXyEnaLNg2z8ZzS29 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 6 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Tue, 07 May 2024 21:43:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Jenkins : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj, Wail Alkowaileet. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 6: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/484/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 6 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ritik Raj Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Tue, 07 May 2024 19:34:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Wail Alkowaileet. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 6: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/FG1UWjKQGzRpgv8N9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 6 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Tue, 07 May 2024 18:33:37 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Wail Alkowaileet. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 ) Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. Patch Set 6: (1 comment) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/28d2082d_d1dffc27 PS5, Line 182: getMergableComponentsIndex > The variable names currently make the logic hard to follow. […] looking into this -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 Gerrit-Change-Number: 18264 Gerrit-PatchSet: 6 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Ritik Raj Gerrit-Reviewer: Wail Alkowaileet Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Tue, 07 May 2024 18:20:44 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy
>From Ritik Raj : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Wail Alkowaileet. Hello Murtadha Hubail, Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, Wail Alkowaileet, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 to look at the new patch set (#6). Change subject: [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy .. [ASTERIXDB-3394][STO] Introducing size bounded concurrent merge policy - user model changes: yes - storage format changes: no - interface changes: no Details: - Added storage property to set max mergable component size. - The new merge policy will schedule merges similar to the current ConcurrentMergePolicy but it will consider the max mergable component size. Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274 --- M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm A asterixdb/asterix-common/src/test/java/org/apache/asterix/test/SizeBoundedConcurrentMergePolicyTest.java M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java M asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp M asterixdb/asterix-app/src/test
