subject:"Change in asterixdb\[master\]\: \[NO ISSUE\]\[COMP\] fix resolving PK field accesses \& rewriting..."

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Ali Alsuliman (Code Review)

Ali Alsuliman has submitted this change and it was merged.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


[NO ISSUE][COMP] fix resolving PK field accesses & rewriting of meta()

- user model changes: no
- storage format changes: no
- interface changes: no

details:
This patch fixes resolving PK field accesses to the primary key
variable (e.g. $ds.getField("id") is turned into $13 where id is a PK).
The fix considers whether the PK is coming from the data record or the
meta record.
The patch also includes fixing rewriting of meta() references and
replacing them with their corresponding meta variables. Now nested plans
are visited also when looking for meta() references to take care of cases
where the data scan producing the meta variable and the meta() references
happen to be inside the nested plans.
MetaFunctionToMetaVariable() is fired also after the rules which eliminate
subplans to allow for rewriting of the meta() if it couldn't be replaced
when the meta() reference was in the subplan but referring to meta variable
outside the nested plan.
ReinferAllTypesRule() is now fired before ByNameToByIndexFieldAccessRule()
to allow the latter rule to get the up-to-date types in the whole plan.

Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3018
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Contrib: Jenkins 
Reviewed-by: Dmitry Lychagin 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
A asterixdb/asterix-app/data/csv/people.csv
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_1.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_3.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_4.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/with_clause_meta.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_1.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_3.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_4.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/with_clause_meta.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.7.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.7.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/meta/meta_in_with_clause/meta_in_with_clause.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/meta/meta_in_with_clause/meta_in_with_clause.4.adm
A 
asterixdb/asterix

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Dmitry Lychagin (Code Review)

Dmitry Lychagin has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/Jp79wP : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3781/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7527/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3781/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/133/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Analytics Compatibility Compilation Successful
https://goo.gl/uKknrC : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7527/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/131/
 (12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4667/ 
(9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4703/
 (2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8649/ (3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5271/ (7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5087/ 
(1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4612/ 
(6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4700/ 
(10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10182/ (11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5042/
 (8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4922/ 
(5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2711/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-06 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/f8GYWs : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Analytics Compatibility Tests Failed
https://goo.gl/KQ6ACo : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/ptwQfp : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7517/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3773/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3773/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/123/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7517/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Analytics Compatibility Compilation Successful
https://goo.gl/37xCh2 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/121/
 (12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8639/ (2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4690/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10172/ (7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5032/
 (1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2701/ 
(3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4602/ 
(10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Ali Alsuliman (Code Review)

Hello Anon. E. Moose #1000171, Jenkins, Michael Blow, Dmitry Lychagin,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3018

to look at the new patch set (#3).

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..

[NO ISSUE][COMP] fix resolving PK field accesses & rewriting of meta()

- user model changes: no
- storage format changes: no
- interface changes: no

details:
This patch fixes resolving PK field accesses to the primary key
variable (e.g. $ds.getField("id") is turned into $13 where id is a PK).
The fix considers whether the PK is coming from the data record or the
meta record.
The patch also includes fixing rewriting of meta() references and
replacing them with their corresponding meta variables. Now nested plans
are visited also when looking for meta() references to take care of cases
where the data scan producing the meta variable and the meta() references
happen to be inside the nested plans.
MetaFunctionToMetaVariable() is fired also after the rules which eliminate
subplans to allow for rewriting of the meta() if it couldn't be replaced
when the meta() reference was in the subplan but referring to meta variable
outside the nested plan.
ReinferAllTypesRule() is now fired before ByNameToByIndexFieldAccessRule()
to allow the latter rule to get the up-to-date types in the whole plan.

Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
A asterixdb/asterix-app/data/csv/people.csv
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_1.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_3.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_4.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/with_clause_meta.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_1.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_3.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_4.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/with_clause_meta.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.7.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.7.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/meta/meta_in_with_clause/meta_in_with_clause.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/meta/meta_in_with_clause/meta_in_with_clause.4.adm
A 
asterixdb/asterix-app/s

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5261/ (11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4657/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4693/
 (5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4912/ 
(6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5077/ 
(9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Dmitry Lychagin (Code Review)

Dmitry Lychagin has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3018/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java:

Line 286: "Field assignOp " + 
assignOp.getExpressions().get(0).getValue()
Minor. Should remain "Field access", not "Field assignOp", right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3772/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3772/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Michael Blow (Code Review)

Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2: Verified+1

Ali pointed out I was looking at the result of an old patch, restoring the +1 
Verified

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Ali Alsuliman (Code Review)

Ali Alsuliman has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

@Mike I think you're referring to patch 1. I updated the error message in patch 
2

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/116/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Michael Blow (Code Review)

Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2: Contrib+1 Integration-Tests+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-05 Thread Michael Blow (Code Review)

Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2: Verified-1

there is a failure here: 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/115/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/TYRXAj : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3768/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7511/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3768/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5026/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://goo.gl/Ctsjks : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7511/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/115/
 (12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4596/ 
(1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10166/ (9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4651/ 
(6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2695/ 
(3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/116/
 (10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4687/
 (11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4684/ 
(5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Ali Alsuliman (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3018

to look at the new patch set (#2).

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..

[NO ISSUE][COMP] fix resolving PK field accesses & rewriting of meta()

- user model changes: no
- storage format changes: no
- interface changes: no

details:
This patch fixes resolving PK field accesses to the primary key
variable (e.g. $ds.getField("id") is turned into $13 where id is a PK).
The fix considers whether the PK is coming from the data record or the
meta record.
The patch also includes fixing rewriting of meta() references and
replacing them with their corresponding meta variables. Now nested plans
are visited also when looking for meta() references to take care of cases
where the data scan producing the meta variable and the meta() references
happen to be inside the nested plans.
MetaFunctionToMetaVariable() is fired also after the rules which eliminate
subplans to allow for rewriting of the meta() if it couldn't be replaced
when the meta() reference was in the subplan but referring to meta variable
outside the nested plan.
ReinferAllTypesRule() is now fired before ByNameToByIndexFieldAccessRule()
to allow the latter rule to get the up-to-date types in the whole plan.

Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
A asterixdb/asterix-app/data/csv/people.csv
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_1.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_3.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_4.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/with_clause_meta.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_1.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_3.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_4.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/with_clause_meta.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.7.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.7.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/meta/meta_in_with_clause/meta_in_with_clause.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/meta/meta_in_with_clause/meta_in_with_clause.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/res

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5255/ (4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5071/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8633/ (2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4906/ 
(7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/bVmzPd : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3767/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7510/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3767/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5025/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/3xiE11 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7510/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/114/
 (12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Ali Alsuliman (Code Review)

Ali Alsuliman has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3018

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..

[NO ISSUE][COMP] fix resolving PK field accesses & rewriting of meta()

- user model changes: no
- storage format changes: no
- interface changes: no

details:
This patch fixes resolving PK field accesses to the primary key
variable (e.g. $ds.getField("id") is turned into $13 where id is a PK).
The fix considers whether the PK is coming from the data record or the
meta record.
The patch also includes fixing rewriting of meta() references and
replacing them with their corresponding meta variables. Now nested plans
are visited also when looking for meta() references to take care of cases
where the data scan producing the meta variable and the meta() references
happen to be inside the nested plans.
MetaFunctionToMetaVariable() is fired also after the rules which eliminate
subplans to allow for rewriting of the meta() if it couldn't be replaced
when the meta() reference was in the subplan but referring to meta variable
outside the nested plan.
ReinferAllTypesRule() is now fired before ByNameToByIndexFieldAccessRule()
to allow the latter rule to get the up-to-date types in the whole plan.

Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
A asterixdb/asterix-app/data/csv/people.csv
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_1.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_3.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/field_access_with_data_and_meta_4.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/with_clause_meta.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_1.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_3.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/field_access_with_data_and_meta_4.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/with_clause_meta.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/meta_in_with_clause/meta_in_with_clause.7.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.6.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/meta/resolving_pk_with_meta/resolving_pk_with_meta.7.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/meta/meta_in_with_clause/meta_in_with_clause.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/meta/meta_in_with_clause/meta_in_with_clause.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/meta/meta_in_with_clause/meta_in_with_clause.5.adm
A 
asterixdb/asterix-

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/115/
 (7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10165/ (6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5070/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4686/
 (9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5254/ (10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4683/ 
(1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2694/ 
(2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4595/ 
(11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4905/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4650/ 
(5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting...

2018-11-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of 
meta()
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8632/ (3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

90 matches

Mail list logo