Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 2: hybrid hash join was used as a reference for correctness, for us to locate where the bug is. For example, for a query, if we replace the join operator to hybrid hash join, the results become correct, then we know the issue is in optimized hash join. The reason is that optimized hash join is much more complex than hybrid hash join. -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 2: I wonder why we can't do it by only keeping the optimized hybrid hash join. -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 2: Thanks for the comment. If we have a correctness issue in the optimized hybrid hash join, then we we can put a designed data set and check the correctness of the result after fixing the bug. Also, for the code-wise, since HashTable now uses the bufferManager interface to get/release frames, that structure needs to be reflected in the hybrid hash join, too. -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 2: Pls keep hybrid hash join. Just in case the OptimizedHybridHashJoin has some correctness bugs, we can use hybrid hash join for comparisons. We did that previously. -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3330/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 2: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1146/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1146/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3329/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1353 to look at the new patch set (#2). Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) - Removed Grace Hash Join and Hybrid Hash Join that are not currently being used since we always use Optimized Hybrid Hash Join. Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba --- M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HybridHashJoinPOperator.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java D hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/GraceHashJoinOperatorDescriptor.java D hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/GraceHashJoinOperatorNodePushable.java D hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/GraceHashJoinPartitionBuildOperatorNodePushable.java D hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/GraceHashJoinPartitionState.java D hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HybridHashJoinOperatorDescriptor.java D hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/TPCHCustomerOrderHashJoinTest.java M hyracks-fullstack/hyracks/hyracks-examples/tpch-example/tpchclient/src/main/java/org/apache/hyracks/examples/tpch/client/Join.java 9 files changed, 5 insertions(+), 2,165 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/53/1353/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1139/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1139/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3317/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join ...
Taewoo Kim has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1353
Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join
(not being used)
..
ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used)
- Removed Grace Hash Join and Hybrid Hash Join that are not currently being
used
since we always use Optimized Hybrid Hash Join.
Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba
---
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HybridHashJoinPOperator.java
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
D
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/GraceHashJoinOperatorDescriptor.java
D
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/GraceHashJoinOperatorNodePushable.java
D
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/GraceHashJoinPartitionBuildOperatorNodePushable.java
D
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/GraceHashJoinPartitionState.java
D
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HybridHashJoinOperatorDescriptor.java
D
hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/TPCHCustomerOrderHashJoinTest.java
M
hyracks-fullstack/hyracks/hyracks-examples/tpch-example/tpchclient/src/main/java/org/apache/hyracks/examples/tpch/client/Join.java
9 files changed, 5 insertions(+), 2,165 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/53/1353/1
diff --git
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HybridHashJoinPOperator.java
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HybridHashJoinPOperator.java
index 248bc4f..fe82f68 100644
---
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HybridHashJoinPOperator.java
+++
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HybridHashJoinPOperator.java
@@ -46,7 +46,6 @@
import org.apache.hyracks.api.dataflow.IOperatorDescriptor;
import org.apache.hyracks.api.dataflow.value.IBinaryComparator;
import org.apache.hyracks.api.dataflow.value.IBinaryComparatorFactory;
-import org.apache.hyracks.api.dataflow.value.IBinaryHashFunctionFactory;
import org.apache.hyracks.api.dataflow.value.IBinaryHashFunctionFamily;
import org.apache.hyracks.api.dataflow.value.IMissingWriterFactory;
import org.apache.hyracks.api.dataflow.value.IPredicateEvaluatorFactory;
@@ -56,32 +55,28 @@
import org.apache.hyracks.api.dataflow.value.RecordDescriptor;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.job.IOperatorDescriptorRegistry;
-import org.apache.hyracks.dataflow.std.join.HybridHashJoinOperatorDescriptor;
import
org.apache.hyracks.dataflow.std.join.OptimizedHybridHashJoinOperatorDescriptor;
public class HybridHashJoinPOperator extends AbstractHashJoinPOperator {
private final int memSizeInFrames;
private final int maxInputBuildSizeInFrames;
-private final int aveRecordsPerFrame;
private final double fudgeFactor;
private static final Logger LOGGER =
Logger.getLogger(HybridHashJoinPOperator.class.getName());
public HybridHashJoinPOperator(JoinKind kind, JoinPartitioningType
partitioningType,
List sideLeftOfEqualities, List
sideRightOfEqualities,
-int memSizeInFrames, int maxInputSizeInFrames, int
aveRecordsPerFrame, double fudgeFactor) {
+int memSizeInFrames, int maxInputSizeInFrames, double fudgeFactor)
{
super(kind, partitioningType, sideLeftOfEqualities,
sideRightOfEqualities);
this.memSizeInFrames = memSizeInFrames;
this.maxInputBuildSizeInFrames = maxInputSizeInFrames;
-this.aveRecordsPerFrame = aveRecordsPerFrame;
this.fudgeFactor = fudgeFactor;
LOGGER.fine("HybridHashJoinPOperator constructed with: JoinKind=" +
kind + ", JoinPartitioningType="
+ partitioningType + ", List=" +
sideLeftOfEqualities + ", List="
+ sideRightOfEqualities + ", int memSizeInFrames=" +
memSizeInFrames + ", int maxInputSize0InFrames="
-+ maxInputSizeInFrames + ", int aveRecordsPerFrame=" +
aveRecordsPerFrame + ", double fudgeFactor="
-+ fudgeFactor + ".");
++ maxInputSizeI
