Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-13 Thread Ian Maxon (Code Review)
Ian Maxon has submitted this change and it was merged.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


[NO ISSUE] Fix logging in NCServiceIT

This test had a strange logging setup; the logging
for the actual IT was not configured to log outside
of /tmp, and the NCService processes had no log4j2
configuration set.

Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3189
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M hyracks-fullstack/hyracks/hyracks-server/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksNCServiceProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/nc-blue.conf
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/nc-red.conf
M hyracks-fullstack/pom.xml
10 files changed, 94 insertions(+), 19 deletions(-)

Approvals:
  Jenkins: Verified; No violations found; Verified
  Michael Blow: Looks good to me, approved



diff --git a/hyracks-fullstack/hyracks/hyracks-server/pom.xml 
b/hyracks-fullstack/hyracks/hyracks-server/pom.xml
index 8b59870..1a94210 100644
--- a/hyracks-fullstack/hyracks/hyracks-server/pom.xml
+++ b/hyracks-fullstack/hyracks/hyracks-server/pom.xml
@@ -185,5 +185,9 @@
   org.apache.logging.log4j
   log4j-api
 
+
+  commons-io
+  commons-io
+
   
 
diff --git 
a/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
 
b/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
index 4983ba1..544d414 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
@@ -19,16 +19,24 @@
 package org.apache.hyracks.test.server;
 
 import java.io.File;
+import java.io.FileOutputStream;
 import java.io.IOException;
+import java.io.PrintWriter;
 import java.net.InetAddress;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.nio.file.StandardOpenOption;
 import java.util.Iterator;
 
+import org.apache.commons.io.FileUtils;
 import org.apache.http.HttpResponse;
 import org.apache.http.HttpStatus;
 import org.apache.http.client.HttpClient;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.impl.client.HttpClients;
 import org.apache.http.util.EntityUtils;
+import org.apache.hyracks.test.server.process.HyracksCCProcess;
+import org.apache.hyracks.test.server.process.HyracksNCServiceProcess;
 import org.apache.hyracks.test.server.process.HyracksVirtualCluster;
 import org.apache.hyracks.util.file.FileUtil;
 import org.apache.logging.log4j.LogManager;
@@ -55,8 +63,13 @@
 @BeforeClass
 public static void setUp() throws Exception {
 cluster = new HyracksVirtualCluster(new File(APP_HOME), null);
-cluster.addNCService(new File(RESOURCE_DIR, "nc-red.conf"), new 
File(LOG_DIR, "nc-red.log"));
-cluster.addNCService(new File(RESOURCE_DIR, "nc-blue.conf"), new 
File(LOG_DIR, "nc-blue.log"));
+File tempConf = new File(TARGET_DIR, "cc.conf");
+FileUtils.copyFile(new File(RESOURCE_DIR, "cc.conf"), tempConf);
+Files.write(tempConf.toPath(), ("log.dir: " + LOG_DIR).getBytes(), 
StandardOpenOption.APPEND);
+File log4jPath = new File(FileUtil.joinPath("..", "..", "src", "test", 
"resources", "log4j2-hyracks-test.xml"));
+
+cluster.addNCService(new File(RESOURCE_DIR, "nc-red.conf"), new 
File(LOG_DIR, "nc-red.log"), log4jPath);
+cluster.addNCService(new File(RESOURCE_DIR, "nc-blue.conf"), new 
File(LOG_DIR, "nc-blue.log"), log4jPath);
 
 try {
 Thread.sleep(2000);
@@ -64,7 +77,7 @@
 }
 
 // Start CC
-cluster.start(new File(RESOURCE_DIR, "cc.conf"), new File(LOG_DIR, 
"cc.log"));
+cluster.start(tempConf, new File(LOG_DIR, "cc.log"), log4jPath);
 
 try {
 Thread.sleep(1);
diff --git 
a/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
 

Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-13 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app-stabilization-f69489/40/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-13 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

TRIGGER: asterix-gerrit-verify-no-installer-app-stabilization-f69489

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7967/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7967/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/550/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5527/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5160/
 (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5070/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5738/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/326/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3172/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9112/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10642/ (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5382/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Ian Maxon (Code Review)
Hello Jenkins, Michael Blow,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3189

to look at the new patch set (#6).

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..

[NO ISSUE] Fix logging in NCServiceIT

This test had a strange logging setup; the logging
for the actual IT was not configured to log outside
of /tmp, and the NCService processes had no log4j2
configuration set.

Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
---
M hyracks-fullstack/hyracks/hyracks-server/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksNCServiceProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/nc-blue.conf
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/nc-red.conf
M hyracks-fullstack/pom.xml
10 files changed, 94 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/3189/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5123/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5161/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Ian Maxon (Code Review)
Hello Jenkins, Michael Blow,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3189

to look at the new patch set (#5).

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..

[NO ISSUE] Fix logging in NCServiceIT

This test had a strange logging setup; the logging
for the actual IT was not configured to log outside
of /tmp, and the NCService processes had no log4j2
configuration set.

Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
---
M hyracks-fullstack/hyracks/hyracks-server/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksNCServiceProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/nc-blue.conf
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/nc-red.conf
M hyracks-fullstack/pom.xml
10 files changed, 96 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/3189/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Ian Maxon (Code Review)
Ian Maxon has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3189/4/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java:

PS4, Line 70: HyracksNCServiceProcess red =
: 
> I think that we can remove this again
Done


PS4, Line 72: HyracksNCServiceProcess blue = 
> I think that we can remove this again
Done


PS4, Line 81: new File(TARGET_DIR, "cc.conf")
> use 'tempConf' ?
Done


PS4, Line 81: HyracksCCProcess cc = 
> I think that we can remove this again
Done


https://asterix-gerrit.ics.uci.edu/#/c/3189/4/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java:

PS4, Line 37: this.configFile = configFile;
: this.logFile = logFile;
: this.appHome = appHome;
: this.workingDir = workingDir;
> this(configFile, logFile, appHome, workingDir);
Done, in NCProcess too.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3189/4/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java:

PS4, Line 70: HyracksNCServiceProcess red =
: 
I think that we can remove this again


PS4, Line 72: HyracksNCServiceProcess blue = 
I think that we can remove this again


PS4, Line 81: new File(TARGET_DIR, "cc.conf")
use 'tempConf' ?


PS4, Line 81: HyracksCCProcess cc = 
I think that we can remove this again


https://asterix-gerrit.ics.uci.edu/#/c/3189/4/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java:

PS4, Line 37: this.configFile = configFile;
: this.logFile = logFile;
: this.appHome = appHome;
: this.workingDir = workingDir;
this(configFile, logFile, appHome, workingDir);


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7962/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9105/ (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Ian Maxon (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3189

to look at the new patch set (#3).

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..

[NO ISSUE] Fix logging in NCServiceIT

This test had a strange logging setup; the logging
for the actual IT was not configured to log outside
of /tmp, and the NCService processes had no log4j2
configuration set.

Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
---
M hyracks-fullstack/hyracks/hyracks-server/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksNCServiceProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/nc-blue.conf
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/nc-red.conf
M hyracks-fullstack/pom.xml
10 files changed, 103 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/3189/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4: Code-Review+1

I would like to look at the logs once Jenkins run is complete

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5155/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7962/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5376/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/320/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5375/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5155/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5064/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10636/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3166/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Ian Maxon (Code Review)
Ian Maxon has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

(9 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3189/2/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java:

PS2, Line 73: addArg
> Isn't this too late? Isn't the process already started?
Yes it is, I altered the way I do this in patch 3.


PS2, Line 84: new File(TARGET_DIR, "cc.conf")
> This seems to be the same as tempConf, could we use it?
Done.


https://asterix-gerrit.ics.uci.edu/#/c/3189/2/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java:

PS2, Line 34: args = new ArrayList<>()
> Could we do this in HyracksServerProcess?
Done


https://asterix-gerrit.ics.uci.edu/#/c/3189/2/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java:

PS2, Line 41: args
> = new ArrayList<>()
Done


https://asterix-gerrit.ics.uci.edu/#/c/3189/2/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java:

PS2, Line 38:  
> WS
Done


PS2, Line 54:  
> WS
Done


PS2, Line 70:  
> WS
Done


PS2, Line 87:  
> WS
Done


https://asterix-gerrit.ics.uci.edu/#/c/3189/2/hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf:

PS2, Line 32: [common]
> Does adding tis empty section do something?
Yes, for NCServiceIT, I append the actual wanted log directory based on LOG_DIR 
into a copy of this file in target/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5154/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9106/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5733/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/545/
 (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5522/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Ian Maxon (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3189

to look at the new patch set (#4).

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..

[NO ISSUE] Fix logging in NCServiceIT

This test had a strange logging setup; the logging
for the actual IT was not configured to log outside
of /tmp, and the NCService processes had no log4j2
configuration set.

Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
---
M hyracks-fullstack/hyracks/hyracks-server/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksNCServiceProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/nc-blue.conf
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/nc-red.conf
M hyracks-fullstack/pom.xml
10 files changed, 103 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/3189/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5117/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5063/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10635/ (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5116/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5521/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/319/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3165/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5732/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5154/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/544/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

(9 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3189/2/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java:

PS2, Line 73: addArg
Isn't this too late? Isn't the process already started?


PS2, Line 84: new File(TARGET_DIR, "cc.conf")
This seems to be the same as tempConf, could we use it?


https://asterix-gerrit.ics.uci.edu/#/c/3189/2/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java:

PS2, Line 34: args = new ArrayList<>()
Could we do this in HyracksServerProcess?


https://asterix-gerrit.ics.uci.edu/#/c/3189/2/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java:

PS2, Line 41: args
= new ArrayList<>()


https://asterix-gerrit.ics.uci.edu/#/c/3189/2/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java:

PS2, Line 38:  
WS


PS2, Line 54:  
WS


PS2, Line 70:  
WS


PS2, Line 87:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/3189/2/hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf
File 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf:

PS2, Line 32: [common]
Does adding tis empty section do something?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7953/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7953/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/536/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5513/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5146/
 (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5108/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5055/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/311/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3157/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5724/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Ian Maxon (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3189

to look at the new patch set (#2).

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..

[NO ISSUE] Fix logging in NCServiceIT

This test had a strange logging setup; the logging
for the actual IT was not configured to log outside
of /tmp, and the NCService processes had no log4j2
configuration set.

Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
---
M hyracks-fullstack/hyracks/hyracks-server/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksNCServiceProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf
A 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/log4j2-hyracks-test.xml
M hyracks-fullstack/pom.xml
9 files changed, 120 insertions(+), 15 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/3189/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9097/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5146/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5367/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10627/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7944/ 
: FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7944/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/526/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5503/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5135/
 (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5044/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5713/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9086/ (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/300/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3146/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5356/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5097/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5135/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10616/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3189
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4.1-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4.1-pre-rc]: [NO ISSUE] Fix logging in NCServiceIT

2019-02-11 Thread Ian Maxon (Code Review)
Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3189

Change subject: [NO ISSUE] Fix logging in NCServiceIT
..

[NO ISSUE] Fix logging in NCServiceIT

This test had a strange logging setup; the logging
for the actual IT was not configured to log outside
of /tmp, and the NCService processes had no log4j2
configuration set.

Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949
---
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksNCServiceProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksServerProcess.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksVirtualCluster.java
M 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/NCServiceIT/cc.conf
A 
hyracks-fullstack/hyracks/hyracks-server/src/test/resources/log4j2-hyracks-test.xml
M hyracks-fullstack/pom.xml
8 files changed, 116 insertions(+), 15 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/3189/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
 
b/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
index 4983ba1..d955aed 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java
@@ -19,16 +19,24 @@
 package org.apache.hyracks.test.server;
 
 import java.io.File;
+import java.io.FileOutputStream;
 import java.io.IOException;
+import java.io.PrintWriter;
 import java.net.InetAddress;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.nio.file.StandardOpenOption;
 import java.util.Iterator;
 
+import org.apache.commons.io.FileUtils;
 import org.apache.http.HttpResponse;
 import org.apache.http.HttpStatus;
 import org.apache.http.client.HttpClient;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.impl.client.HttpClients;
 import org.apache.http.util.EntityUtils;
+import org.apache.hyracks.test.server.process.HyracksCCProcess;
+import org.apache.hyracks.test.server.process.HyracksNCServiceProcess;
 import org.apache.hyracks.test.server.process.HyracksVirtualCluster;
 import org.apache.hyracks.util.file.FileUtil;
 import org.apache.logging.log4j.LogManager;
@@ -55,8 +63,17 @@
 @BeforeClass
 public static void setUp() throws Exception {
 cluster = new HyracksVirtualCluster(new File(APP_HOME), null);
-cluster.addNCService(new File(RESOURCE_DIR, "nc-red.conf"), new 
File(LOG_DIR, "nc-red.log"));
-cluster.addNCService(new File(RESOURCE_DIR, "nc-blue.conf"), new 
File(LOG_DIR, "nc-blue.log"));
+File tempConf = new File(TARGET_DIR, "cc.conf");
+FileUtils.copyFile(new File(RESOURCE_DIR, "cc.conf"), tempConf);
+Files.write(tempConf.toPath(), ("log.dir: " + LOG_DIR).getBytes(), 
StandardOpenOption.APPEND);
+String log4jPath = "-Dlog4j.configurationFile="
++ FileUtil.joinPath(".", "src", "test", "resources", 
"log4j2-hyracks-test.xml");
+HyracksNCServiceProcess red =
+cluster.addNCService(new File(RESOURCE_DIR, "nc-red.conf"), 
new File(LOG_DIR, "nc-red.log"));
+red.addArg(log4jPath);
+HyracksNCServiceProcess blue =
+cluster.addNCService(new File(RESOURCE_DIR, "nc-blue.conf"), 
new File(LOG_DIR, "nc-blue.log"));
+blue.addArg(log4jPath);
 
 try {
 Thread.sleep(2000);
@@ -64,7 +81,9 @@
 }
 
 // Start CC
-cluster.start(new File(RESOURCE_DIR, "cc.conf"), new File(LOG_DIR, 
"cc.log"));
+HyracksCCProcess cc = cluster.init(new File(TARGET_DIR, "cc.conf"), 
new File(LOG_DIR, "cc.log"));
+cc.addArg(log4jPath);
+cc.start();
 
 try {
 Thread.sleep(1);
diff --git 
a/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
 
b/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
index b39def5..4f0d27c 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java
@@ -19,6 +19,7 @@
 package org.apache.hyracks.test.server.process;
 
 import java.io.File;
+import