Re: [PR] java interop - triple protocol-java -go [dubbo-go-samples]
fansofml commented on code in PR #730:
URL: https://github.com/apache/dubbo-go-samples/pull/730#discussion_r1535041363
##
java_interop/protobuf-triple/java/java-client/pom.xml:
##
@@ -0,0 +1,79 @@
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.example
+java
+1.0-SNAPSHOT
+
+
+8
+8
+UTF-8
+3.1.7
+
+
+
+junit
+junit
+4.13
+test
+
+
+org.apache.dubbo
+dubbo
+${dubbo.version}
+
+
+org.apache.dubbo
+dubbo-dependencies-zookeeper-curator5
+pom
+${dubbo.version}
+
+
+com.google.protobuf
+protobuf-java
+3.19.4
+
+
+
+
+
+
+kr.motd.maven
+os-maven-plugin
+1.6.1
+
+
+
+
+org.xolstice.maven.plugins
+protobuf-maven-plugin
+0.6.1
+
+
+
com.google.protobuf:protoc:3.19.4:exe:${os.detected.classifier}
+
+
+dubbo
+org.apache.dubbo
+dubbo-compiler
+${dubbo.version}
+
org.apache.dubbo.gen.tri.Dubbo3TripleGenerator
Review Comment:
I have added instructions on how to generate proto in the README.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [WIP] Test hessian4 [dubbo]
sonarcloud[bot] commented on PR #13974: URL: https://github.com/apache/dubbo/pull/13974#issuecomment-2014301491 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13974) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_dubbo=13974=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13974=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13974=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13974=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13974=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13974) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:Update FileTest [dubbo]
sonarcloud[bot] commented on PR #13978: URL: https://github.com/apache/dubbo/pull/13978#issuecomment-2014279056 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13978) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13978=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13978=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13978=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13978) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] java interop - triple protocol-java -go [dubbo-go-samples]
fansofml commented on code in PR #730:
URL: https://github.com/apache/dubbo-go-samples/pull/730#discussion_r1534954271
##
java_interop/protobuf-triple/go/go-client/cmd/client.go:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+ "context"
+ "dubbo.apache.org/dubbo-go/v3/client"
+ _ "dubbo.apache.org/dubbo-go/v3/imports"
+ greet
"github.com/apache/dubbo-go-samples/java_interop/protobuf-triple/go/proto"
+ "github.com/dubbogo/gost/log/logger"
+)
+
+// export
DUBBO_GO_CONFIG_PATH=$PATH_TO_SAMPLES/rpc/triple/pb/dubbogo-java/go-client/conf/dubbogo.yml
+func main() {
+
+ cli, err := client.NewClient(
+ client.WithClientURL("127.0.0.1:36969"),
+ )
+ if err != nil {
+ panic(err)
+ }
+ if err != nil {
Review Comment:
ok,i will change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] triple request missed http header like scheme, host etc. [dubbo-go]
2456868764 opened a new issue, #2642:
URL: https://github.com/apache/dubbo-go/issues/2642
### Environment
- Server:
- Client:
- Protocol:
- Registry:
### Issue description
there is dubbo filter demo code which just output attachments :
func (f *mtlsFilter) Invoke(ctx context.Context, invoker protocol.Invoker,
invocation protocol.Invocation) protocol.Result {
// get request schema
attachments :=
ctx.Value(constant.AttachmentKey).(map[string]interface{})
for key, attachment := range attachments {
logger.Infof("get triple attachment key %s = %s", key,
attachment.([]string)[0])
}
}
```
and output as follow:
```
2024-03-22 02:15:34 INFOlogger/logging.go:42get triple
attachment key [retries ] = %!s(MISSING)
2024-03-22 02:15:34 INFOlogger/logging.go:42get triple
attachment key [user-agent grpc-go-triple/0.1.0 (go1.21.6)] = %!s(MISSING)
2024-03-22 02:15:34 INFOlogger/logging.go:42get triple
attachment key [te trailers] = %!s(MISSING)
2024-03-22 02:15:34 INFOlogger/logging.go:42get triple
attachment key [content-type application/grpc+proto] = %!s(MISSING)
2024-03-22 02:15:34 INFOlogger/logging.go:42get triple
attachment key [interface greet.GreetService] = %!s(MISSING)
2024-03-22 02:15:34 INFOlogger/logging.go:42get triple
attachment key [grpc-accept-encoding gzip] = %!s(MISSING)
2024-03-22 02:15:34 INFOlogger/logging.go:42get triple
attachment key [timeout ] = %!s(MISSING)
2024-03-22 02:15:34 INFOlogger/logging.go:42get triple
attachment key [grpc-timeout 2999023u] = %!s(MISSING)
2024-03-22 02:15:34 INFOlogger/logging.go:42get triple
attachment key [accept-encoding identity] = %!s(MISSING)
```
and miss some common http header like scheme ,host etc.
### Logs
Click me to check logs
```
Copy logs to here.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] client can't get attachments which is set from server [dubbo-go]
2456868764 opened a new issue, #2641:
URL: https://github.com/apache/dubbo-go/issues/2641
### Environment
- Server: Dubbo-go, master
- Client: Dubbo-go, master
- Protocol: Triple
- Registry: N/A
### Issue description
server code
```
func (srv *GreetTripleServer) Greet(ctx context.Context, req
*greet.GreetRequest) (*greet.GreetResponse, error) {
resp := {Greeting: req.Name}
ctx = context.WithValue(ctx, constant.AttachmentKey,
map[string]interface{}{"server_info": "dubbo httpbin"})
return resp, nil
}
```
client code
```
ctx := context.Background()
resp, err := svc.Greet(ctx, {Name: "hello world"})
if err != nil {
c.JSON(http.StatusBadGateway, err.Error())
return
}
attachments := make(map[string]interface{})
if ctx.Value(constant.AttachmentKey) != nil {
attachments =
ctx.Value(constant.AttachmentKey).(map[string]interface{})
}
```
and found that client attachments is nil.
then use curl to simulate as http which return is follow:
(base) ➜ dubbo-go git:(feat-security) ✗ curl -v -H
"content-type:application/json" http://127.0.0.1:8000/greet.GreetService/Greet
-d '{"name":"hello"}'
* Trying 127.0.0.1:8000...
* Connected to 127.0.0.1 (127.0.0.1) port 8000 (#0)
> POST /greet.GreetService/Greet HTTP/1.1
> Host: 127.0.0.1:8000
> User-Agent: curl/8.1.2
> Accept: */*
> content-type:application/json
> Content-Length: 16
>
< HTTP/1.1 200 OK
< Accept-Encoding: gzip
< Content-Type: application/json
< Date: Fri, 22 Mar 2024 03:05:43 GMT
< Content-Length: 20
<
* Connection #0 to host 127.0.0.1 left intact
{"greeting":"hello"}%
no attachments return
### Logs
Click me to check logs
```
Copy logs to here.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Merge CommonConfigPostProcessor and ConfigPostProcessor [dubbo]
heliang666s commented on issue #13959: URL: https://github.com/apache/dubbo/issues/13959#issuecomment-2014215789 Could you assign it to me? Thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] feat:Update FileTest [dubbo]
Stellar1999 opened a new pull request, #13978: URL: https://github.com/apache/dubbo/pull/13978 …-spi in 3.3 (#13961) ## What is the purpose of the change Update FileTest to support check dubbo-all-shaded and dubbo-core-spi in 3.3 ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [WIP] Test hessian4 [dubbo]
sonarcloud[bot] commented on PR #13974: URL: https://github.com/apache/dubbo/pull/13974#issuecomment-2014199790 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13974) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13974=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13974=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13974=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13974=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13974=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13974) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Replacing Micrometer with OTEL [dubbo]
AlbumenJ commented on issue #13953: URL: https://github.com/apache/dubbo/issues/13953#issuecomment-2014198752 > > PTAL @AlbumenJ @songxiaosheng > > Is it reasonable for java to use micromter to bridge otel and other languages to directly use the otel official client? For metrics, use micrometer is reasonable now. But for tracing, use OTEL would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Use ExecutorService instead of event loop for Netty connection [dubbo]
AlbumenJ commented on code in PR #13904:
URL: https://github.com/apache/dubbo/pull/13904#discussion_r1534959792
##
dubbo-remoting/dubbo-remoting-netty4/src/test/java/org/apache/dubbo/remoting/transport/netty4/ConnectionTest.java:
##
@@ -138,6 +138,7 @@ void connectSyncTest() throws Throwable {
nettyPortUnificationServer.bind();
// auto reconnect
+Thread.sleep(6);
Review Comment:
Use awaitility to verify
##
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/AbstractClient.java:
##
@@ -55,13 +63,23 @@ public abstract class AbstractClient extends
AbstractEndpoint implements Client
protected volatile ExecutorService executor;
+protected volatile ScheduledExecutorService connectivityExecutor;
+
+private ApplicationModel applicationModel;
+
+protected long reconnectDuaration;
+
public AbstractClient(URL url, ChannelHandler handler) throws
RemotingException {
super(url, handler);
// set default needReconnect true when channel is not connected
needReconnect = url.getParameter(Constants.SEND_RECONNECT_KEY, true);
+applicationModel = url.getOrDefaultApplicationModel();
Review Comment:
Directly get Framework Model here would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix memory leak of tri protocol [dubbo]
AlbumenJ commented on PR #13973: URL: https://github.com/apache/dubbo/pull/13973#issuecomment-2014196497  Is this test failure related with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Merge CommonConfigPostProcessor and ConfigPostProcessor [dubbo]
AlbumenJ commented on issue #13959: URL: https://github.com/apache/dubbo/issues/13959#issuecomment-2014195818 > hello,I am new there,I want to try this,thank you! Please go ahead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix telnet ctrl+c issue #13812 [dubbo]
AlbumenJ merged PR #13921: URL: https://github.com/apache/dubbo/pull/13921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] java interop - triple protocol-java -go [dubbo-go-samples]
FoghostCn commented on code in PR #730:
URL: https://github.com/apache/dubbo-go-samples/pull/730#discussion_r1534954688
##
java_interop/protobuf-triple/java/java-client/pom.xml:
##
@@ -0,0 +1,79 @@
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.example
+java
+1.0-SNAPSHOT
+
+
+8
+8
+UTF-8
+3.1.7
+
+
+
+junit
+junit
+4.13
+test
+
+
+org.apache.dubbo
+dubbo
+${dubbo.version}
+
+
+org.apache.dubbo
+dubbo-dependencies-zookeeper-curator5
+pom
+${dubbo.version}
+
+
+com.google.protobuf
+protobuf-java
+3.19.4
+
+
+
+
+
+
+kr.motd.maven
+os-maven-plugin
+1.6.1
+
+
+
+
+org.xolstice.maven.plugins
+protobuf-maven-plugin
+0.6.1
+
+
+
com.google.protobuf:protoc:3.19.4:exe:${os.detected.classifier}
+
+
+dubbo
+org.apache.dubbo
+dubbo-compiler
+${dubbo.version}
+
org.apache.dubbo.gen.tri.Dubbo3TripleGenerator
Review Comment:
plz remove the generated codes and add a reademe to tell people how to
generate them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] java interop - triple protocol-java -go [dubbo-go-samples]
FoghostCn commented on code in PR #730:
URL: https://github.com/apache/dubbo-go-samples/pull/730#discussion_r1534954688
##
java_interop/protobuf-triple/java/java-client/pom.xml:
##
@@ -0,0 +1,79 @@
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.example
+java
+1.0-SNAPSHOT
+
+
+8
+8
+UTF-8
+3.1.7
+
+
+
+junit
+junit
+4.13
+test
+
+
+org.apache.dubbo
+dubbo
+${dubbo.version}
+
+
+org.apache.dubbo
+dubbo-dependencies-zookeeper-curator5
+pom
+${dubbo.version}
+
+
+com.google.protobuf
+protobuf-java
+3.19.4
+
+
+
+
+
+
+kr.motd.maven
+os-maven-plugin
+1.6.1
+
+
+
+
+org.xolstice.maven.plugins
+protobuf-maven-plugin
+0.6.1
+
+
+
com.google.protobuf:protoc:3.19.4:exe:${os.detected.classifier}
+
+
+dubbo
+org.apache.dubbo
+dubbo-compiler
+${dubbo.version}
+
org.apache.dubbo.gen.tri.Dubbo3TripleGenerator
Review Comment:
plz remove the generated codes and add doc how to generated them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] java interop - triple protocol-java -go [dubbo-go-samples]
FoghostCn commented on code in PR #730:
URL: https://github.com/apache/dubbo-go-samples/pull/730#discussion_r1534954688
##
java_interop/protobuf-triple/java/java-client/pom.xml:
##
@@ -0,0 +1,79 @@
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.example
+java
+1.0-SNAPSHOT
+
+
+8
+8
+UTF-8
+3.1.7
+
+
+
+junit
+junit
+4.13
+test
+
+
+org.apache.dubbo
+dubbo
+${dubbo.version}
+
+
+org.apache.dubbo
+dubbo-dependencies-zookeeper-curator5
+pom
+${dubbo.version}
+
+
+com.google.protobuf
+protobuf-java
+3.19.4
+
+
+
+
+
+
+kr.motd.maven
+os-maven-plugin
+1.6.1
+
+
+
+
+org.xolstice.maven.plugins
+protobuf-maven-plugin
+0.6.1
+
+
+
com.google.protobuf:protoc:3.19.4:exe:${os.detected.classifier}
+
+
+dubbo
+org.apache.dubbo
+dubbo-compiler
+${dubbo.version}
+
org.apache.dubbo.gen.tri.Dubbo3TripleGenerator
Review Comment:
plz remove the generate code and add doc how to generated them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] java interop - triple protocol-java -go [dubbo-go-samples]
fansofml commented on code in PR #730:
URL: https://github.com/apache/dubbo-go-samples/pull/730#discussion_r1534954271
##
java_interop/protobuf-triple/go/go-client/cmd/client.go:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+ "context"
+ "dubbo.apache.org/dubbo-go/v3/client"
+ _ "dubbo.apache.org/dubbo-go/v3/imports"
+ greet
"github.com/apache/dubbo-go-samples/java_interop/protobuf-triple/go/proto"
+ "github.com/dubbogo/gost/log/logger"
+)
+
+// export
DUBBO_GO_CONFIG_PATH=$PATH_TO_SAMPLES/rpc/triple/pb/dubbogo-java/go-client/conf/dubbogo.yml
+func main() {
+
+ cli, err := client.NewClient(
+ client.WithClientURL("127.0.0.1:36969"),
+ )
+ if err != nil {
+ panic(err)
+ }
+ if err != nil {
Review Comment:
好的，我去修改一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] java interop - triple protocol-java -go [dubbo-go-samples]
FoghostCn commented on code in PR #730:
URL: https://github.com/apache/dubbo-go-samples/pull/730#discussion_r1534952754
##
java_interop/protobuf-triple/go/go-client/cmd/client.go:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+ "context"
+ "dubbo.apache.org/dubbo-go/v3/client"
+ _ "dubbo.apache.org/dubbo-go/v3/imports"
+ greet
"github.com/apache/dubbo-go-samples/java_interop/protobuf-triple/go/proto"
+ "github.com/dubbogo/gost/log/logger"
+)
+
+// export
DUBBO_GO_CONFIG_PATH=$PATH_TO_SAMPLES/rpc/triple/pb/dubbogo-java/go-client/conf/dubbogo.yml
+func main() {
+
+ cli, err := client.NewClient(
+ client.WithClientURL("127.0.0.1:36969"),
+ )
+ if err != nil {
+ panic(err)
+ }
+ if err != nil {
Review Comment:
plz remove no used code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] upgrade dubbo-samples-api-with-registry to jdk17 and dubbo 3.3 [dubbo-samples]
QuYao-Fighting opened a new pull request, #1109: URL: https://github.com/apache/dubbo-samples/pull/1109 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix/retry opt (#2598) [dubbo-go]
Phixsura closed pull request #2601: Fix/retry opt (#2598) URL: https://github.com/apache/dubbo-go/pull/2601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Replacing Micrometer with OTEL [dubbo]
songxiaosheng commented on issue #13953: URL: https://github.com/apache/dubbo/issues/13953#issuecomment-2014058951 > PTAL @AlbumenJ @songxiaosheng Is it reasonable for java to use micromter to bridge otel and other languages to directly use the otel official client? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] update: multi-registry [dubbo-samples]
Rawven commented on PR #1090: URL: https://github.com/apache/dubbo-samples/pull/1090#issuecomment-2013134905 Because the local environment is different from the test environment, it took me a lot of time and commits to locate the problem, but I feel that this time it should have been perfected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] into master from 3.2.0-release [dubbo-spi-extensions]
codecov-commenter commented on PR #297: URL: https://github.com/apache/dubbo-spi-extensions/pull/297#issuecomment-2012925197 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/297?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 0.27%. Comparing base [(`ceff747`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/commit/ceff7478d34ef7596c213371179843945fdeb9d6?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`39f03fa`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/297?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master#297 +/- ## - Coverage 26.69% 0.27% -26.42% + Complexity 1087 6 -1081 Files 297 298+1 Lines 13593 13620 +27 Branches 17201721+1 - Hits 3629 38 -3591 - Misses 9609 13579 +3970 + Partials355 3 -352 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/297?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat:Move Mesh Rule Router to SPI Extensions #13957 [dubbo]
AmmyHaber closed pull request #13977: feat:Move Mesh Rule Router to SPI Extensions #13957 URL: https://github.com/apache/dubbo/pull/13977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] java interop - triple protocol-java -go [dubbo-go-samples]
fansofml opened a new pull request, #730: URL: https://github.com/apache/dubbo-go-samples/pull/730 #699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]
AmmyHaber commented on issue #13957: URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2012821493 I send a pull request about this issue,please check it.[#13977](https://github.com/apache/dubbo/pull/13977/commits/0accf5445238553d263dcebb19e0d6f70d160bda) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] feat:Move Mesh Rule Router to SPI Extensions #13957 [dubbo]
AmmyHaber opened a new pull request, #13977: URL: https://github.com/apache/dubbo/pull/13977 ## What is the purpose of the change I see this issue#13957,it require to move Mesh Rule Router to apache/dubbo-spi-extensions ## Brief changelog remove Mesh Rule Router,if someone need it ,he can import it from apache/dubbo-spi-extensions ## Verifying this change I delete classes and test classes in dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh, and copy them to apache/dubbo-spi-extensions. I run test in spi extensions,all test pass. ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [x] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Use ExecutorService instead of event loop for Netty connection [dubbo]
hanpen24 commented on code in PR #13904:
URL: https://github.com/apache/dubbo/pull/13904#discussion_r1534167182
##
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyConnectionClient.java:
##
@@ -374,7 +385,7 @@ public void operationComplete(ChannelFuture future) {
"Failed to connect to server: " +
getConnectAddress());
}
},
-1L,
+1,
Review Comment:
@AlbumenJ
Thank you for your review.
I have modified the code to get the idle time before reconnection. By
default, it will now wait for 6ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Use ExecutorService instead of event loop for Netty connection [dubbo]
sonarcloud[bot] commented on PR #13904: URL: https://github.com/apache/dubbo/pull/13904#issuecomment-2012661936 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13904) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13904=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13904=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13904=false=true)  [25.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13904=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13904=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13904) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix memory leak of tri protocol [dubbo]
sonarcloud[bot] commented on PR #13973: URL: https://github.com/apache/dubbo/pull/13973#issuecomment-2012528815 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13973) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13973=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13973=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13973=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13973=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13973=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13973) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Merge CommonConfigPostProcessor and ConfigPostProcessor [dubbo]
heliang666s commented on issue #13959: URL: https://github.com/apache/dubbo/issues/13959#issuecomment-2012398707 hello,I am new there,I want to try this,thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix memory leak of tri protocol [dubbo]
oxsean commented on PR #13973: URL: https://github.com/apache/dubbo/pull/13973#issuecomment-2012306491 @icodening LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Implement Tracing [dubbo-js]
openlg commented on issue #382: URL: https://github.com/apache/dubbo-js/issues/382#issuecomment-2012264246 I'll handle this task -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix telnet ctrl+c issue #13812 [dubbo]
sonarcloud[bot] commented on PR #13921: URL: https://github.com/apache/dubbo/pull/13921#issuecomment-2012051702 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13921) **Quality Gate passed** Issues  [3 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13921=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13921=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13921=false=true)  [96.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13921=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13921=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13921) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) branch master updated: UPDATE dubbo-samples-spring-security (#1081)
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git
The following commit(s) were added to refs/heads/master by this push:
new 5f66eb90d UPDATE dubbo-samples-spring-security (#1081)
5f66eb90d is described below
commit 5f66eb90d449935cca3a43c0fb191c3b20f37239
Author: 0turnsole0 <130824243+0turnso...@users.noreply.github.com>
AuthorDate: Thu Mar 21 19:25:08 2024 +0800
UPDATE dubbo-samples-spring-security (#1081)
---
.../dubbo-samples-spring-security-common/pom.xml | 56
.../DefaultObjectMapperCodecCustomer.java | 2 +-
.../SecuritySerializationConfig.java} | 19 +-
.../serialization/SerializationApplication.java} | 17 +-
.../dubbo-samples-spring-security-consumer/pom.xml | 83 ++
.../samples/security/ConsumerApplication.java} | 23 +-
.../org/apache/dubbo/samples/security/Task.java} | 49 ++--
.../src/main/resources/application.yml | 28 ++
.../src/test/java/security/ConsumerTests.java | 77 +
.../pom.xml| 31 +++
.../dubbo/samples/security}/api/UserService.java | 4 +-
.../apache/dubbo/samples/security}/model/User.java | 9 +-
.../dubbo-samples-spring-security-provider/pom.xml | 88 ++
.../samples/security/ProviderApplication.java} | 32 +--
.../samples/security/impl}/UserServiceImpl.java| 8 +-
.../src/main/resources/application.yml | 24 ++
2-advanced/dubbo-samples-spring-security/pom.xml | 146 --
.../{src/main/resources => }/readme.md | 23 +-
.../{src/main/resources => }/readme_zh.md | 25 +-
.../org/apache/dubbo/samples/SecurityProvider.java | 59
.../dubbo/samples/zookeeper/EmbeddedZooKeeper.java | 309 -
.../apache/dubbo/samples/zookeeper/ZKTools.java| 107 ---
...ring.security.jackson.ObjectMapperCodecCustomer | 1 -
.../src/main/resources/config-center.properties| 32 ---
.../src/main/resources/log4j2.xml | 29 --
.../resources/spring/dubbo-consumer.properties | 21 --
.../resources/spring/dubbo-provider.properties | 22 --
27 files changed, 557 insertions(+), 767 deletions(-)
diff --git
a/2-advanced/dubbo-samples-spring-security/dubbo-samples-spring-security-common/pom.xml
b/2-advanced/dubbo-samples-spring-security/dubbo-samples-spring-security-common/pom.xml
new file mode 100644
index 0..a351dadf5
--- /dev/null
+++
b/2-advanced/dubbo-samples-spring-security/dubbo-samples-spring-security-common/pom.xml
@@ -0,0 +1,56 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+
+org.apache.dubbo
+dubbo-samples-spring-security
+1.0-SNAPSHOT
+
+
+dubbo-samples-spring-security-common
+
+
+
+
+
+org.apache.dubbo
+dubbo
+
+
+
+
+org.springframework.boot
+spring-boot-starter
+
+
+
+
+
+
+
+org.springframework.boot
+spring-boot-maven-plugin
+
+
+
+
+
diff --git
a/2-advanced/dubbo-samples-spring-security/src/main/java/org/apache/dubbo/samples/custom/DefaultObjectMapperCodecCustomer.java
b/2-advanced/dubbo-samples-spring-security/dubbo-samples-spring-security-common/src/main/java/org/apache/dubbo/samples/security/serialization/DefaultObjectMapperCodecCustomer.java
similarity index 95%
copy from
2-advanced/dubbo-samples-spring-security/src/main/java/org/apache/dubbo/samples/custom/DefaultObjectMapperCodecCustomer.java
copy to
2-advanced/dubbo-samples-spring-security/dubbo-samples-spring-security-common/src/main/java/org/apache/dubbo/samples/security/serialization/DefaultObjectMapperCodecCustomer.java
index d89889bfa..a2ed0607e 100644
---
a/2-advanced/dubbo-samples-spring-security/src/main/java/org/apache/dubbo/samples/custom/DefaultObjectMapperCodecCustomer.java
+++
b/2-advanced/dubbo-samples-spring-security/dubbo-samples-spring-security-common/src/main/java/org/apache/dubbo/samples/security/serialization/DefaultObjectMapperCodecCustomer.java
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.dubbo.samples.custom;
+package org.apache.dubbo.samples.security.serialization;
import org.apache.dubbo.spring.security.jackson.ObjectMapperCodec;
import org.apache.dubbo.spring.security.jackson.ObjectMapperCodecCustomer;
diff --git
a/2-advanced/dubbo-samples-spring-security/src/main/java/org/apache/dubbo/samples/api/UserService.java
Re: [PR] UPDATE dubbo-samples-spring-security [dubbo-samples]
chickenlj merged PR #1081: URL: https://github.com/apache/dubbo-samples/pull/1081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] upgrade 2-advanced/dubbo-samples-generic to jdk17 and spring3 [dubbo-samples]
3424672656 commented on PR #1107: URL: https://github.com/apache/dubbo-samples/pull/1107#issuecomment-2011975367 The case_version.conf file needs to change the test conditions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix telnet ctrl+c issue #13812 [dubbo]
hengyoush commented on PR #13921: URL: https://github.com/apache/dubbo/pull/13921#issuecomment-2011951349 > Can you pls add some test cases verify it? I added a unit test, and tested manually: https://github.com/apache/dubbo/assets/32724602/e9f9e3d0-797f-4b12-8690-aa478d5e954f;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] update: multi-registry [dubbo-samples]
Rawven closed pull request #1090: update: multi-registry URL: https://github.com/apache/dubbo-samples/pull/1090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat(filter): add seata samples. [dubbo-go-samples]
AlexStocks commented on code in PR #718: URL: https://github.com/apache/dubbo-go-samples/pull/718#discussion_r1533646906 ## compatibility/seata-go/tcc/server/service/user_provider.go: ## @@ -19,11 +19,8 @@ package service import ( Review Comment: import 格式不要动 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] upgrade config for api-with-registry [dubbo-samples]
Res-Nah opened a new pull request, #1108: URL: https://github.com/apache/dubbo-samples/pull/1108 upgrade jdk version and pom.xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix the problem of multiple namespaces in MetadataReport [dubbo]
sonarcloud[bot] commented on PR #13971: URL: https://github.com/apache/dubbo/pull/13971#issuecomment-2011793259 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13971) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13971=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13971=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13971=false=true)  [48.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13971=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13971=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13971) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] bug in FastJson2ObjectInput.readBytes and FastJson2ObjectOutput.writeBytes [dubbo]
AlbumenJ closed issue #13697: bug in FastJson2ObjectInput.readBytes and FastJson2ObjectOutput.writeBytes URL: https://github.com/apache/dubbo/issues/13697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]
walklown commented on PR #1096: URL: https://github.com/apache/dubbo-samples/pull/1096#issuecomment-2011739395 Thanks for @chickenlj 's help ! All test cases have passed, and I have rolled back the conflicting changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] For HTTP/1 unary mode, use Content-Length instead of chunk [dubbo]
finefuture commented on issue #13933: URL: https://github.com/apache/dubbo/issues/13933#issuecomment-2011649417 I'm working on it, please assign it to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] bug in FastJson2ObjectInput.readBytes and FastJson2ObjectOutput.writeBytes [dubbo]
finefuture commented on issue #13697: URL: https://github.com/apache/dubbo/issues/13697#issuecomment-2011647627 Fixed in #13968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] 3.3.0 When is GA? [dubbo]
AlbumenJ closed issue #13975: 3.3.0 When is GA? URL: https://github.com/apache/dubbo/issues/13975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] dubbo 3.1.7 [dubbo]
AlbumenJ commented on issue #13972: URL: https://github.com/apache/dubbo/issues/13972#issuecomment-2011642341 `dubbo-kubernetes` has been moved to https://github.com/apache/dubbo-spi-extensions/tree/master/dubbo-kubernetes. You can submit a PR to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Rest Protocol to SPI Extensions [dubbo]
AlbumenJ commented on issue #13958: URL: https://github.com/apache/dubbo/issues/13958#issuecomment-2011624162 > i am willing to do it.could you show more details?Do i need to move the file and make sure it can works?or something else? 1. Copy all the related files to apache/dubbo-spi-extensions repo. 2. test it work proper or not 3. Remove the origin code in apache/dubbo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix readBytes and writeBytes methods in fastjson2 [dubbo]
AlbumenJ merged PR #13968: URL: https://github.com/apache/dubbo/pull/13968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] 3.3.0 When is GA? [dubbo]
luxiao opened a new issue, #13975: URL: https://github.com/apache/dubbo/issues/13975 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar feature requirement. ### Apache Dubbo Component Java SDK (apache/dubbo) ### Descriptions 3.3.0 When is GA? ### Related issues _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] resolvePackagesToScan modify function [dubbo]
AlbumenJ commented on issue #13964: URL: https://github.com/apache/dubbo/issues/13964#issuecomment-2011618764 Why? `packagesToScan` is a collection now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] update curator version [dubbo-integration-cases]
AlbumenJ merged PR #19: URL: https://github.com/apache/dubbo-integration-cases/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] build(deps): bump github.com/docker/docker from 24.0.7+incompatible to 24.0.9+incompatible [dubbo-go-pixiu]
baerwang merged PR #619: URL: https://github.com/apache/dubbo-go-pixiu/pull/619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] refactor(dubbo-samples-configcenter-api): upgrade samples [dubbo-samples]
conghuhu closed pull request #1092: refactor(dubbo-samples-configcenter-api): upgrade samples URL: https://github.com/apache/dubbo-samples/pull/1092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] refactor(dubbo-samples-configcenter-api): upgrade samples [dubbo-samples]
conghuhu commented on PR #1092: URL: https://github.com/apache/dubbo-samples/pull/1092#issuecomment-2011399037 This case uses the Dubbo API, so it should not be refactored to Springboot. So, I suggest turning off this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] [WIP] Test hessian4 [dubbo]
AlbumenJ opened a new pull request, #13974: URL: https://github.com/apache/dubbo/pull/13974 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Update FileTest in 3.3 [dubbo]
Stellar1999 commented on issue #13961: URL: https://github.com/apache/dubbo/issues/13961#issuecomment-2011312608 "I would like to try to do this. Can you assign it to me? Thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) branch master updated: Fix failed test s(#1106)
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git
The following commit(s) were added to refs/heads/master by this push:
new 5701859f3 Fix failed test s(#1106)
5701859f3 is described below
commit 5701859f342c811e23cc3104e45e16c0a829be9c
Author: hqbfz <125714719+3424672...@users.noreply.github.com>
AuthorDate: Thu Mar 21 14:26:09 2024 +0800
Fix failed test s(#1106)
---
2-advanced/dubbo-samples-autowire/case-configuration.yml | 9 +
.../dubbo/samples/autowire/consumer/AutowireServiceIT.java | 3 ++-
.../java/org/apache/dubbo/demo/consumer/DemoServiceConfigIT.java | 2 +-
.../test/java/org/apache/dubbo/demo/consumer/DemoServiceIT.java | 4
.../main/java/org/apache/dubbo/demo/consumer/Application.java| 1 -
5 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/2-advanced/dubbo-samples-autowire/case-configuration.yml
b/2-advanced/dubbo-samples-autowire/case-configuration.yml
index 6a789280a..4e4a292fc 100644
--- a/2-advanced/dubbo-samples-autowire/case-configuration.yml
+++ b/2-advanced/dubbo-samples-autowire/case-configuration.yml
@@ -22,6 +22,14 @@ services:
type: app
basedir: dubbo-samples-autowire-provider
mainClass: org.apache.dubbo.samples.autowire.provider.ProviderBootstrap
+systemProps:
+- zookeeper.address=zookeeper
+waitPortsBeforeRun:
+- zookeeper:2181
+checkPorts:
+- 20880
+depends_on:
+- zookeeper
autowire-consumer:
type: test
@@ -38,3 +46,4 @@ services:
- autowire-provider:20880
depends_on:
- autowire-provider
+ - zookeeper
diff --git
a/2-advanced/dubbo-samples-autowire/dubbo-samples-autowire-consumer/src/test/java/org/apache/dubbo/samples/autowire/consumer/AutowireServiceIT.java
b/2-advanced/dubbo-samples-autowire/dubbo-samples-autowire-consumer/src/test/java/org/apache/dubbo/samples/autowire/consumer/AutowireServiceIT.java
index e67ac7a58..c93715305 100644
---
a/2-advanced/dubbo-samples-autowire/dubbo-samples-autowire-consumer/src/test/java/org/apache/dubbo/samples/autowire/consumer/AutowireServiceIT.java
+++
b/2-advanced/dubbo-samples-autowire/dubbo-samples-autowire-consumer/src/test/java/org/apache/dubbo/samples/autowire/consumer/AutowireServiceIT.java
@@ -19,13 +19,14 @@ package org.apache.dubbo.samples.autowire.consumer;
import org.apache.dubbo.config.annotation.DubboReference;
import org.apache.dubbo.samples.autowire.api.HelloService;
+import org.apache.dubbo.spring.boot.autoconfigure.DubboAutoConfiguration;
import org.junit.Assert;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.test.context.junit4.SpringRunner;
-@SpringBootTest
+@SpringBootTest(classes = {DubboAutoConfiguration.class})
@RunWith(SpringRunner.class)
public class AutowireServiceIT {
diff --git
a/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/dubbo-servicediscovery-migration-consumer/src/test/java/org/apache/dubbo/demo/consumer/DemoServiceConfigIT.java
b/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/dubbo-servicediscovery-migration-consumer/src/test/java/org/apache/dubbo/demo/consumer/DemoServiceConfigIT.java
index bd518a0e7..c46a877f5 100644
---
a/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/dubbo-servicediscovery-migration-consumer/src/test/java/org/apache/dubbo/demo/consumer/DemoServiceConfigIT.java
+++
b/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/dubbo-servicediscovery-migration-consumer/src/test/java/org/apache/dubbo/demo/consumer/DemoServiceConfigIT.java
@@ -47,7 +47,7 @@ public class DemoServiceConfigIT {
RegistryConfig registryConfig = new RegistryConfig(applicationModel);
registryConfig.setProtocol("zookeeper");
-registryConfig.setAddress(System.getProperty("zookeeper.address",
"10.21.32.39"));
+registryConfig.setAddress(System.getProperty("zookeeper.address",
"127.0.0.1"));
registryConfig.setPort(Integer.parseInt(System.getProperty("zookeeper.port",
"2181")));
applicationModel.getApplicationConfigManager().setApplication(applicationConfig);
diff --git
a/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/dubbo-servicediscovery-migration-consumer/src/test/java/org/apache/dubbo/demo/consumer/DemoServiceIT.java
b/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/dubbo-servicediscovery-migration-consumer/src/test/java/org/apache/dubbo/demo/consumer/DemoServiceIT.java
index b3c77913d..81c05bb50 100644
---
a/2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/dubbo-servicediscovery-migration-consumer/src/test/java/org/apache/dubbo/demo/consumer/DemoServiceIT.java
+++
Re: [PR] Fix test [dubbo-samples]
chickenlj merged PR #1106: URL: https://github.com/apache/dubbo-samples/pull/1106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] dubbo3 应用级服务发现 泛化调用异常 [dubbo]
CrazyHZM commented on issue #12694: URL: https://github.com/apache/dubbo/issues/12694#issuecomment-2011290153 Supported, please try the latest version. @cy1ng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
