Re: [PR] Fix netty memory leak [dubbo]
AlbumenJ merged PR #14127: URL: https://github.com/apache/dubbo/pull/14127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2099690812 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14127=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14127=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
AlbumenJ commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2099664657 @finefuture Please ping me once all the test cases pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2097379931 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14127=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14127=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
finefuture commented on code in PR #14127:
URL: https://github.com/apache/dubbo/pull/14127#discussion_r1584753409
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http2/GenericHttp2ServerTransportListener.java:
##
@@ -164,7 +165,7 @@ protected void onMetadataCompletion(Http2Header metadata) {
@Override
protected void onDataCompletion(Http2InputMessage message) {
if (message.isEndStream()) {
-serverCallListener.onComplete();
Review Comment:
Closing the decoder triggers the onComplete method of the serverCallListener.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
oxsean commented on code in PR #14127:
URL: https://github.com/apache/dubbo/pull/14127#discussion_r1583086955
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http2/GenericHttp2ServerTransportListener.java:
##
@@ -164,7 +165,7 @@ protected void onMetadataCompletion(Http2Header metadata) {
@Override
protected void onDataCompletion(Http2InputMessage message) {
if (message.isEndStream()) {
-serverCallListener.onComplete();
Review Comment:
Why remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
oxsean commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2082719092 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2080846921 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14127=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14127=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
finefuture commented on code in PR #14127:
URL: https://github.com/apache/dubbo/pull/14127#discussion_r1581838112
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http1/DefaultHttp11ServerTransportListener.java:
##
@@ -82,6 +83,15 @@ protected HttpMessageListener buildHttpMessageListener() {
return new DefaultHttpMessageListener(listeningDecoder);
}
+@Override
+protected void doOnData(HttpInputMessage message) {
Review Comment:
This only applies to http1 and http2, not grpc, because grpc will accumulate
inputStream.
ByteBuf is released when an exception occurs in grpc's doOnData process.
Under normal circumstances, ByteBuf will be released by the close method of
LengthFieldStreamingDecoder.
Normal scene:
Error scene:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
finefuture commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2080751859  Failure to close the decoder when using the grpc protocol causes netty memory leaks. The decoder should be closed when judging endStream.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
finefuture commented on code in PR #14127:
URL: https://github.com/apache/dubbo/pull/14127#discussion_r1581836609
##
dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/HttpOutputMessage.java:
##
@@ -29,6 +29,11 @@ public interface HttpOutputMessage {
public OutputStream getBody() {
return INPUT_STREAM;
}
+
+@Override
+public void close() throws Exception {
+INPUT_STREAM.close();
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
oxsean commented on code in PR #14127:
URL: https://github.com/apache/dubbo/pull/14127#discussion_r1577996697
##
dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/HttpOutputMessage.java:
##
@@ -29,6 +29,11 @@ public interface HttpOutputMessage {
public OutputStream getBody() {
return INPUT_STREAM;
}
+
+@Override
+public void close() throws Exception {
+INPUT_STREAM.close();
Review Comment:
Unnecessary
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http1/DefaultHttp11ServerTransportListener.java:
##
@@ -82,6 +83,15 @@ protected HttpMessageListener buildHttpMessageListener() {
return new DefaultHttpMessageListener(listeningDecoder);
}
+@Override
+protected void doOnData(HttpInputMessage message) {
Review Comment:
Is http2 also need it? so I think add it into Ondata is more reasonable:
```Java
public void onData(MESSAGE message) {
executor.execute(() -> {
try {
doOnData(message);
} catch (Throwable t) {
logError(t);
onError(t);
} finally {
try {
message.close();
} catch (Exception e) {
onError(e);
}
}
});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2074480062 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14127=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14127=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2074424326 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14127=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14127=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix netty memory leak [dubbo]
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2074379860 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14127=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14127=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14127=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14127) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
