[jira] [Commented] (JCLOUDS-425) bad substitution error after compile

2014-02-14 Thread Ignasi Barrera (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901348#comment-13901348
 ] 

Ignasi Barrera commented on JCLOUDS-425:


Instead of using the files in src you should unpack the generated zip/tar 
files in assembly/target. Those packages should contain the generated CLI.

 bad substitution error after compile
 

 Key: JCLOUDS-425
 URL: https://issues.apache.org/jira/browse/JCLOUDS-425
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-cli
Affects Versions: 1.7.0
 Environment: Linux Mint Olivia
Reporter: Marc Morata

 I've downloaded the last version from the repository. This is the link:
 http://search.maven.org/remotecontent?filepath=org/apache/jclouds/cli/jclouds-cli/1.7.0/jclouds-cli-1.7.0-source-release.tar.gz
 After unpack it, I've run the mvn clean install command. When it finishes 
 with a 'BUILD SUCCESS' I try to run the jclouds and I get the following error:
 ./assembly/src/main/filtered-resources/unix/bin/jclouds
 jclouds: Ignoring predefined value for KARAF_HOME
 shell: Ignoring predefined value for KARAF_HOME
 /opt/tools/jclouds-cli-1.7.0/assembly/src/main/filtered-resources/unix/bin/shell:
  line 264: 
 $KARAF_HOME/system/org/apache/jclouds/cli/runner/${project.version}/runner-${project.version}.jar:
  bad substitution
 I guess ${project.version} should be changed by the right version.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (JCLOUDS-425) bad substitution error after compile

2014-02-14 Thread Marc Morata (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901375#comment-13901375
 ] 

Marc Morata commented on JCLOUDS-425:
-

It worked!

Thanks.

 bad substitution error after compile
 

 Key: JCLOUDS-425
 URL: https://issues.apache.org/jira/browse/JCLOUDS-425
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-cli
Affects Versions: 1.7.0
 Environment: Linux Mint Olivia
Reporter: Marc Morata

 I've downloaded the last version from the repository. This is the link:
 http://search.maven.org/remotecontent?filepath=org/apache/jclouds/cli/jclouds-cli/1.7.0/jclouds-cli-1.7.0-source-release.tar.gz
 After unpack it, I've run the mvn clean install command. When it finishes 
 with a 'BUILD SUCCESS' I try to run the jclouds and I get the following error:
 ./assembly/src/main/filtered-resources/unix/bin/jclouds
 jclouds: Ignoring predefined value for KARAF_HOME
 shell: Ignoring predefined value for KARAF_HOME
 /opt/tools/jclouds-cli-1.7.0/assembly/src/main/filtered-resources/unix/bin/shell:
  line 264: 
 $KARAF_HOME/system/org/apache/jclouds/cli/runner/${project.version}/runner-${project.version}.jar:
  bad substitution
 I guess ${project.version} should be changed by the right version.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Closed] (JCLOUDS-425) bad substitution error after compile

2014-02-14 Thread Marc Morata (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marc Morata closed JCLOUDS-425.
---


 bad substitution error after compile
 

 Key: JCLOUDS-425
 URL: https://issues.apache.org/jira/browse/JCLOUDS-425
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-cli
Affects Versions: 1.7.0
 Environment: Linux Mint Olivia
Reporter: Marc Morata

 I've downloaded the last version from the repository. This is the link:
 http://search.maven.org/remotecontent?filepath=org/apache/jclouds/cli/jclouds-cli/1.7.0/jclouds-cli-1.7.0-source-release.tar.gz
 After unpack it, I've run the mvn clean install command. When it finishes 
 with a 'BUILD SUCCESS' I try to run the jclouds and I get the following error:
 ./assembly/src/main/filtered-resources/unix/bin/jclouds
 jclouds: Ignoring predefined value for KARAF_HOME
 shell: Ignoring predefined value for KARAF_HOME
 /opt/tools/jclouds-cli-1.7.0/assembly/src/main/filtered-resources/unix/bin/shell:
  line 264: 
 $KARAF_HOME/system/org/apache/jclouds/cli/runner/${project.version}/runner-${project.version}.jar:
  bad substitution
 I guess ${project.version} should be changed by the right version.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Resolved] (JCLOUDS-425) bad substitution error after compile

2014-02-14 Thread Marc Morata (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marc Morata resolved JCLOUDS-425.
-

Resolution: Not A Problem

 bad substitution error after compile
 

 Key: JCLOUDS-425
 URL: https://issues.apache.org/jira/browse/JCLOUDS-425
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-cli
Affects Versions: 1.7.0
 Environment: Linux Mint Olivia
Reporter: Marc Morata

 I've downloaded the last version from the repository. This is the link:
 http://search.maven.org/remotecontent?filepath=org/apache/jclouds/cli/jclouds-cli/1.7.0/jclouds-cli-1.7.0-source-release.tar.gz
 After unpack it, I've run the mvn clean install command. When it finishes 
 with a 'BUILD SUCCESS' I try to run the jclouds and I get the following error:
 ./assembly/src/main/filtered-resources/unix/bin/jclouds
 jclouds: Ignoring predefined value for KARAF_HOME
 shell: Ignoring predefined value for KARAF_HOME
 /opt/tools/jclouds-cli-1.7.0/assembly/src/main/filtered-resources/unix/bin/shell:
  line 264: 
 $KARAF_HOME/system/org/apache/jclouds/cli/runner/${project.version}/runner-${project.version}.jar:
  bad substitution
 I guess ${project.version} should be changed by the right version.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (JCLOUDS-468) Nova needs to handle key pair creation better in the ComputeService

2014-02-14 Thread Everett Toews (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901544#comment-13901544
 ] 

Everett Toews commented on JCLOUDS-468:
---

+1 



 Nova needs to handle key pair creation better in the ComputeService
 ---

 Key: JCLOUDS-468
 URL: https://issues.apache.org/jira/browse/JCLOUDS-468
 Project: jclouds
  Issue Type: Improvement
  Components: jclouds-compute
Reporter: Everett Toews
Priority: Minor
  Labels: openstack
 Fix For: 1.8.0


 Nova needs a strategy so it behaves more like 
 org.jclouds.aws.ec2.compute.strategy.CreateKeyPairPlacementAndSecurityGroupsAsNeededAndReturnRunOptions.createNewKeyPairUnlessUserSpecifiedOtherwise()
  
 Right now it only has 
 org.jclouds.openstack.nova.v2_0.compute.loaders.CreateUniqueKeyPair which 
 does not examine TemplateOptions to determine what to do. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-14 Thread Everett Toews
@trainman419 The live test is failing for me. It's running against Keystone v2 
API in Havana. I'm running it with the following command in the 
`apis/openstack-keystone` dir.

mvn clean test -Plive 
-Dtest.openstack-keystone.endpoint=http://162.242.219.27:5000/v2.0/ 
-Dtest.openstack-keystone.identity=admin:admin 
-Dtest.openstack-keystone.credential=devstack 
-Dtest=UserApiLiveTest#testAddDeleteUser

I get the error

Failed tests:   

testAddDeleteUser(org.jclouds.openstack.keystone.v2_0.features.UserApiLiveTest):
 
command: POST http://162.242.219.27:35357/v2.0/users HTTP/1.1 failed with 
response:
HTTP/1.1 400 Bad Request; 
content: [{error: {message: create_user() takes exactly 3 arguments (2 
given), code: 400, title: Bad Request}}]

You can that mvn command to test from your side too.

You can also check your logs in 
`apis/openstack-keystone/target/test-data/jclouds-wire.log` It appears to me 
that the add method isn't send any body content.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35099131

[jclouds-labs-openstack] Adds support for Rackspace Cloud Files API (#79)

2014-02-14 Thread Jeremy Daggett
This PR adds initial support for the Rackspace Cloud Files API. There are many 
changes in this PR and will address comments immediately. Thanks.  

JIRA: 
https://issues.apache.org/jira/browse/JCLOUDS-423

Additions:
  - Added support for CloudFilesApi/CDNApi
  - Added mock/live tests
  - Refactored listFirstPage() and listAt() API methods to list() and 
listWithOptions(…)
  - General Swift API cleanup: docs and tests
  - Added support for Internal URL

Command to run live tests:
mvn clean install -Plive -Dtest.rackspace-cloudfiles.identity=lt;usernamegt; 
-Dtest.rackspace-cloudfiles.credential=lt;passwordgt; 
-Dtest.rackspace-cloudfiles.endpoint=https://identity.api.rackspacecloud.com/v2.0
 

To test a specific region, add “-Dtest.jclouds.region=lt;regionIdgt;” to the 
above command.

Tested against various Rackspace Cloud Files US regions.

Caveats:
- BlobStore Live/Integration Test Failures - under investigation.
- CloudFiles US provider lacking BlobStore integration tests until above 
failures are addressed.
- Temporarily removed Static Web feature awaiting documentation clarification.
- JavaDocs can always use more attention/love.
You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-labs-openstack cloudfiles

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/79

-- Commit Summary --

  * JCLOUDS-423 - Adds support for Rackspace Cloud Files API

-- File Changes --

M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/SwiftApi.java (8)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/SwiftApiMetadata.java
 (1)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedSwiftBlobStore.java
 (6)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/config/SwiftHttpApiModule.java
 (39)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/config/SwiftTypeAdapters.java
 (4)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/domain/Account.java
 (20)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/domain/BulkDeleteResponse.java
 (10)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/domain/Container.java
 (36)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/domain/ExtractArchiveResponse.java
 (6)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/domain/Segment.java
 (10)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/domain/SwiftObject.java
 (26)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/AccountApi.java
 (13)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/BulkApi.java
 (4)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/ContainerApi.java
 (35)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/ObjectApi.java
 (41)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/StaticLargeObjectApi.java
 (2)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/functions/ParseAccountFromHeaders.java
 (8)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/functions/ParseContainerFromHeaders.java
 (17)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/functions/ParseObjectFromResponse.java
 (12)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/functions/ParseObjectListFromResponse.java
 (10)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/handlers/SwiftErrorHandler.java
 (4)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/options/CreateContainerOptions.java
 (50)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/options/ListContainerOptions.java
 (47)
M 
openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/reference/SwiftHeaders.java
 (35)
M 
openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/TemporaryUrlSignerLiveTest.java
 (6)
M 
openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/config/SwiftTypeAdaptersTest.java
 (66)
M 
openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/AccountApiLiveTest.java
 (11)
M 
openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/AccountApiMockTest.java
 (31)
M 
openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/BulkApiLiveTest.java
 (11)
M 
openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/BulkApiMockTest.java
 (8)
M 
openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ContainerApiLiveTest.java
 (43)
M 
openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ContainerApiMockTest.java
 (123)
M 
openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/CreatePublicContainerLiveTest.java
 (5)
M 

Re: [jclouds-labs-openstack] Adds support for Rackspace Cloud Files API (#79)

2014-02-14 Thread CloudBees pull request builder plugin
[jclouds-labs-openstack-pull-requests 
#164](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/164/)
 SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/79#issuecomment-35110792

[jira] [Commented] (JCLOUDS-423) Implement Rackspace Cloud Files

2014-02-14 Thread Jeremy Daggett (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901751#comment-13901751
 ] 

Jeremy Daggett commented on JCLOUDS-423:


Running list of all of the PRs that will implement this feature.
Code:
https://github.com/jclouds/jclouds-labs-openstack/pull/73
https://github.com/jclouds/jclouds-labs-openstack/pull/79

Examples:

Documentation:

 Implement Rackspace Cloud Files
 ---

 Key: JCLOUDS-423
 URL: https://issues.apache.org/jira/browse/JCLOUDS-423
 Project: jclouds
  Issue Type: Improvement
  Components: jclouds-labs-openstack
Affects Versions: 1.7.0
Reporter: Jeremy Daggett
Assignee: Jeremy Daggett
  Labels: openstack, rackspace, swift

 Rackspace Cloud Files is an implementation of the OpenStack Swift API. This 
 new provider provides support for multiple regions via the 
 RegionScopedSwiftBlobStore
 API Docs:
 http://docs.rackspace.com/files/api/v1/cf-devguide/content/index.html



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (JCLOUDS-467) nameNodes only taking first name with AWS

2014-02-14 Thread Andrew Bayer (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901839#comment-13901839
 ] 

Andrew Bayer commented on JCLOUDS-467:
--

I was thinking maybe something like...

{code}
  ListString namesToUse = Lists.newArrayList(nodeNames);
  if (generateInstanceNames  !common.containsKey(Name)) {
 for (Map.EntryString, ? extends NodeMetadata entry : 
instancesById.entrySet()) {
String id = entry.getKey();
String name;
if (!namesToUse.isEmpty()) {
   name = namesToUse.remove(0);
} else {
{code}

Does that seem reasonable?

 nameNodes only taking first name with AWS
 -

 Key: JCLOUDS-467
 URL: https://issues.apache.org/jira/browse/JCLOUDS-467
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-compute
Reporter: Everett Toews
Assignee: Andrew Bayer
 Fix For: 1.8.0


 I'll put nameNodes into TemplateOptions but only the first gets used.
 {code}
 public class NameNodes {
 public static final String MCW = multi-cloud-workshop;
 public static final String LOAD_BALANCER = MCW + -lb;
 public static final String DATABASE = MCW + -db;
 public static final String WEB_SERVER_01 = MCW + -webserver-01;
 public static final String WEB_SERVER_02 = MCW + -webserver-02;
 private final ComputeService computeService;
 public static void main(String[] args) {
 NameNodes nameNodes = null;
 try {
 nameNodes = new NameNodes();
 nameNodes.createServers();
 } catch (Throwable e) {
 e.printStackTrace();
 } finally {
 if (nameNodes != null) {
 nameNodes.close();
 }
 }
 }
 public NameNodes() throws IOException {
 IterableModule modules = ImmutableSet.Moduleof(
 new SLF4JLoggingModule(),
 new SshjSshClientModule());
 Properties overrides = new Properties();
 overrides.setProperty(POLL_INITIAL_PERIOD, 3);
 overrides.setProperty(POLL_MAX_PERIOD, 3);
 ComputeServiceContext context = ContextBuilder.newBuilder(aws-ec2)
 .credentials(myAwsAccessKeyId, myAwsSecretAccessKey)
 .modules(modules)
 .overrides(overrides)
 .buildView(ComputeServiceContext.class);
 computeService = context.getComputeService();
 }
 private MapString, NodeMetadata createServers() throws 
 RunNodesException, IOException {
 SetString nodeNames = ImmutableSet.of(DATABASE, WEB_SERVER_01, 
 WEB_SERVER_02, LOAD_BALANCER);
 System.out.println(format(Creating servers %s, Joiner.on(, 
 ).join(nodeNames)));
 TemplateOptions options = computeService.templateOptions()
 .nodeNames(nodeNames)
 .inboundPorts(22);
 Template template = computeService.templateBuilder()
 
 .imageNameMatches(ubuntu/images/ubuntu-precise-12.04-amd64-server-20131003)
 .locationId(us-west-2)
 .hardwareId(m1.small)
 .options(options)
 .build();
 Set? extends NodeMetadata nodes = 
 computeService.createNodesInGroup(MCW, 4, template);
 MapString, NodeMetadata nameToNode = newHashMap();
 System.out.println(Created servers:);
 for (NodeMetadata node: nodes) {
 String name = node.getName();
 String publicIpAddress = 
 getOnlyElement(node.getPublicAddresses());
 String user = node.getCredentials().getUser();
 System.out.println(format(  %-40s %s@%s, name, user, 
 publicIpAddress));
 nameToNode.put(name, node);
 }
 return nameToNode;
 }
 private void close() {
 computeService.getContext().close();
 }
 }
 {code}
 The output is
 {code}
 Creating servers multi-cloud-workshop-db, multi-cloud-workshop-webserver-01, 
 multi-cloud-workshop-webserver-02, multi-cloud-workshop-lb
 Created servers:
   multi-cloud-workshop-db  ubuntu@54.184.78.205
   multi-cloud-workshop-db  ubuntu@54.203.107.107
   multi-cloud-workshop-db  ubuntu@54.202.100.94
   multi-cloud-workshop-db  ubuntu@54.184.52.175
 {code}
 Confirmed the names of the instances in the AWS console too.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Created] (JCLOUDS-470) region missing from group name in AWSEC2SecurityGroupExtension

2014-02-14 Thread Everett Toews (JIRA)
Everett Toews created JCLOUDS-470:
-

 Summary: region missing from group name in 
AWSEC2SecurityGroupExtension
 Key: JCLOUDS-470
 URL: https://issues.apache.org/jira/browse/JCLOUDS-470
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-compute
Reporter: Everett Toews
 Fix For: 1.8.0, 1.7.2


In AWSEC2SecurityGroupExtension.createSecurityGroup(String name, String region) 
 markerGroup never has the region slash encoded into it, which is necessary for 
parsing further down in the code.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Assigned] (JCLOUDS-470) region missing from group name in AWSEC2SecurityGroupExtension

2014-02-14 Thread Andrew Bayer (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Bayer reassigned JCLOUDS-470:


Assignee: Andrew Bayer

 region missing from group name in AWSEC2SecurityGroupExtension
 --

 Key: JCLOUDS-470
 URL: https://issues.apache.org/jira/browse/JCLOUDS-470
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-compute
Reporter: Everett Toews
Assignee: Andrew Bayer
  Labels: aws
 Fix For: 1.8.0, 1.7.2


 In AWSEC2SecurityGroupExtension.createSecurityGroup(String name, String 
 region)  markerGroup never has the region slash encoded into it, which is 
 necessary for parsing further down in the code.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-14 Thread Austin
Thanks! I'll give that a try from here and see if I can get the live tests 
working.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35120286

Re: [jclouds] JCLOUDS-470. Include region in group name for AWSEC2SecurityGroupExtensi... (#291)

2014-02-14 Thread BuildHive
[jclouds » jclouds 
#843](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/843/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/291#issuecomment-35123953

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread CloudBees pull request builder plugin
[jclouds-pull-requests 
#603](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/603/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292#issuecomment-35125311

Re: [jclouds] JCLOUDS-470. Include region in group name for AWSEC2SecurityGroupExtensi... (#291)

2014-02-14 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests 
#1073](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1073/) 
UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/291#issuecomment-35125312

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests 
#1074](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1074/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292#issuecomment-35125395

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread BuildHive
[jclouds » jclouds 
#844](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/844/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292#issuecomment-35127875

Re: [jclouds] JCLOUDS-470. Include region in group name for AWSEC2SecurityGroupExtensi... (#291)

2014-02-14 Thread Andrew Phillips
 @@ -41,13 +46,6 @@
  import org.jclouds.net.domain.IpPermission;
  import org.jclouds.net.domain.IpProtocol;
  
 -import com.google.common.base.Function;
 -import com.google.common.base.Supplier;
 -import com.google.common.cache.LoadingCache;
 -import com.google.common.collect.Iterables;
 -import com.google.common.collect.Multimap;
 -import com.google.common.util.concurrent.ListeningExecutorService;
 -

IDE-related reordering, I'm guessing?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/291/files#r9766399

Re: [jclouds] JCLOUDS-470. Include region in group name for AWSEC2SecurityGroupExtensi... (#291)

2014-02-14 Thread Andrew Phillips
+1 - looks good to me.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/291#issuecomment-35130627

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread Andrew Phillips
 @@ -175,12 +175,13 @@ public String apply(NodeMetadata in) {
MapString, ? extends NodeMetadata instancesById = 
 Maps.uniqueIndex(input, instanceId);
ImmutableSet.BuilderNodeMetadata builder = 
 ImmutableSet.NodeMetadata builder();
  
 +  ListString namesToUse = Lists.newArrayList(nodeNames);

[minor] Static import of `Lists.newArrayList`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292/files#r9766523

Re: [jclouds] JCLOUDS-470. Include region in group name for AWSEC2SecurityGroupExtensi... (#291)

2014-02-14 Thread Andrew Phillips
 jclouds-java-7-pull-requests #1073 UNSTABLE

Unrelated [test 
failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1073/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/291#issuecomment-35130749

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread Andrew Phillips
if (generateInstanceNames  !common.containsKey(Name)) {
   for (Map.EntryString, ? extends NodeMetadata entry : 
 instancesById.entrySet()) {
  String id = entry.getKey();
  String name;
 -if (!nodeNames.isEmpty()) {
 -   name = Iterables.get(nodeNames, 0);
 +if (!namesToUse.isEmpty()) {
 +   name = namesToUse.remove(0);

Just want to check that I'm understanding the change...we need to _remove_ the 
element to ensure that, next time around, we get the _next_ candidate in line 
(rather than the same one again)?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292/files#r9766605

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread Andrew Bayer
if (generateInstanceNames  !common.containsKey(Name)) {
   for (Map.EntryString, ? extends NodeMetadata entry : 
 instancesById.entrySet()) {
  String id = entry.getKey();
  String name;
 -if (!nodeNames.isEmpty()) {
 -   name = Iterables.get(nodeNames, 0);
 +if (!namesToUse.isEmpty()) {
 +   name = namesToUse.remove(0);

Exactly.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292/files#r9766743

Re: [jclouds-labs-openstack] Adds support for Rackspace Cloud Files API (#79)

2014-02-14 Thread Andrew Phillips
@jdaggett Just to make sure I'm getting this right...this is a different/new 
version of the CloudFiles API as that covered by the [current 
provider](https://github.com/jclouds/jclouds/blob/master/apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/CloudFilesApiMetadata.java)?
 If so, could you amend the PR title to reflect that? ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/79#issuecomment-35131486

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread Andrew Phillips
A question and a minor comment, that's all. +1 - looks good to me. Thanks, 
@abayer!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292#issuecomment-35131001

Re: [jclouds-labs-openstack] Adds support for multi-region implementation of Rackspace Cloud Files API (#79)

2014-02-14 Thread Jeremy Daggett
@demobox I updated the PR title and additional clarification on running live 
tests. Thx!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/79#issuecomment-35132057

[jclouds] Backport JCLOUDS-467 to 1.7.x (#293)

2014-02-14 Thread Andrew Bayer

You can merge this Pull Request by running:

  git pull https://github.com/abayer/jclouds-1 jclouds-467-for-1.7.x

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/293

-- Commit Summary --

  * JCLOUDS-467. Properly iterate over node names for EC2 instance creation.

-- File Changes --

M apis/ec2/src/main/java/org/jclouds/ec2/compute/EC2ComputeService.java (48)
M 
apis/ec2/src/test/java/org/jclouds/ec2/compute/EC2ComputeServiceExpectTest.java 
(69)
M apis/ec2/src/test/resources/describe_instances_running-named.xml (114)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/293.patch
https://github.com/jclouds/jclouds/pull/293.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/293


Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

2014-02-14 Thread Andrew Phillips
Pending PR builders, +1 - looks good to me!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-35133169

[jira] [Commented] (JCLOUDS-470) region missing from group name in AWSEC2SecurityGroupExtension

2014-02-14 Thread Andrew Bayer (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13902079#comment-13902079
 ] 

Andrew Bayer commented on JCLOUDS-470:
--

Pushed to master, will push to 1.7.x when build finishes there.

 region missing from group name in AWSEC2SecurityGroupExtension
 --

 Key: JCLOUDS-470
 URL: https://issues.apache.org/jira/browse/JCLOUDS-470
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-compute
Reporter: Everett Toews
Assignee: Andrew Bayer
  Labels: aws
 Fix For: 1.8.0, 1.7.2


 In AWSEC2SecurityGroupExtension.createSecurityGroup(String name, String 
 region)  markerGroup never has the region slash encoded into it, which is 
 necessary for parsing further down in the code.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (JCLOUDS-467) nameNodes only taking first name with AWS

2014-02-14 Thread Andrew Bayer (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Bayer updated JCLOUDS-467:
-

Fix Version/s: 1.7.2

Went with the list approach - committed to master, PR pending BuildHive and 
then pushing to 1.7.x as well.

 nameNodes only taking first name with AWS
 -

 Key: JCLOUDS-467
 URL: https://issues.apache.org/jira/browse/JCLOUDS-467
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-compute
Reporter: Everett Toews
Assignee: Andrew Bayer
 Fix For: 1.8.0, 1.7.2


 I'll put nameNodes into TemplateOptions but only the first gets used.
 {code}
 public class NameNodes {
 public static final String MCW = multi-cloud-workshop;
 public static final String LOAD_BALANCER = MCW + -lb;
 public static final String DATABASE = MCW + -db;
 public static final String WEB_SERVER_01 = MCW + -webserver-01;
 public static final String WEB_SERVER_02 = MCW + -webserver-02;
 private final ComputeService computeService;
 public static void main(String[] args) {
 NameNodes nameNodes = null;
 try {
 nameNodes = new NameNodes();
 nameNodes.createServers();
 } catch (Throwable e) {
 e.printStackTrace();
 } finally {
 if (nameNodes != null) {
 nameNodes.close();
 }
 }
 }
 public NameNodes() throws IOException {
 IterableModule modules = ImmutableSet.Moduleof(
 new SLF4JLoggingModule(),
 new SshjSshClientModule());
 Properties overrides = new Properties();
 overrides.setProperty(POLL_INITIAL_PERIOD, 3);
 overrides.setProperty(POLL_MAX_PERIOD, 3);
 ComputeServiceContext context = ContextBuilder.newBuilder(aws-ec2)
 .credentials(myAwsAccessKeyId, myAwsSecretAccessKey)
 .modules(modules)
 .overrides(overrides)
 .buildView(ComputeServiceContext.class);
 computeService = context.getComputeService();
 }
 private MapString, NodeMetadata createServers() throws 
 RunNodesException, IOException {
 SetString nodeNames = ImmutableSet.of(DATABASE, WEB_SERVER_01, 
 WEB_SERVER_02, LOAD_BALANCER);
 System.out.println(format(Creating servers %s, Joiner.on(, 
 ).join(nodeNames)));
 TemplateOptions options = computeService.templateOptions()
 .nodeNames(nodeNames)
 .inboundPorts(22);
 Template template = computeService.templateBuilder()
 
 .imageNameMatches(ubuntu/images/ubuntu-precise-12.04-amd64-server-20131003)
 .locationId(us-west-2)
 .hardwareId(m1.small)
 .options(options)
 .build();
 Set? extends NodeMetadata nodes = 
 computeService.createNodesInGroup(MCW, 4, template);
 MapString, NodeMetadata nameToNode = newHashMap();
 System.out.println(Created servers:);
 for (NodeMetadata node: nodes) {
 String name = node.getName();
 String publicIpAddress = 
 getOnlyElement(node.getPublicAddresses());
 String user = node.getCredentials().getUser();
 System.out.println(format(  %-40s %s@%s, name, user, 
 publicIpAddress));
 nameToNode.put(name, node);
 }
 return nameToNode;
 }
 private void close() {
 computeService.getContext().close();
 }
 }
 {code}
 The output is
 {code}
 Creating servers multi-cloud-workshop-db, multi-cloud-workshop-webserver-01, 
 multi-cloud-workshop-webserver-02, multi-cloud-workshop-lb
 Created servers:
   multi-cloud-workshop-db  ubuntu@54.184.78.205
   multi-cloud-workshop-db  ubuntu@54.203.107.107
   multi-cloud-workshop-db  ubuntu@54.202.100.94
   multi-cloud-workshop-db  ubuntu@54.184.52.175
 {code}
 Confirmed the names of the instances in the AWS console too.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


Jenkins build became unstable: jclouds » jclouds #845

2014-02-14 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/845/



Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-14 Thread BuildHive
[jclouds » jclouds 
#845](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/845/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35134154

Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-14 Thread Andrew Phillips
 jclouds » jclouds #845 UNSTABLE

Real [test 
failures](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds.api$openstack-keystone/845/testReport/junit/org.jclouds.openstack.keystone.v2_0.features/UserApiExpectTest/testCreateUser/)
 here.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35137246

Re: [jclouds-labs-openstack] Adds support for multi-region implementation of Rackspace Cloud Files API (#79)

2014-02-14 Thread Zack Shoylev
 +* @param containerName
 +*   corresponds to {@link Container#name()}.
 +* @return the CDNContainer or null, if not found.
 +* 
 +* @see a
 +*  
 href=http://docs.openstack.org/api/openstack-object-storage/1.0/content/retrieve-Container-metadata.html;
 +*  Get Container Metadata API/a
 +*
 +   @Named(cdn:enable)
 +   @PUT
 +   @ResponseParser(ParseCDNContainerURIFromHeaders.class)
 +   @Fallback(NullOnNotFoundOr404.class)
 +   @Path(/{containerName})
 +   @Nullable
 +   URI enable(@PathParam(containerName) String containerName);
 +   */

?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/79/files#r9768452

Re: [jclouds-labs-openstack] Adds support for multi-region implementation of Rackspace Cloud Files API (#79)

2014-02-14 Thread Jeremy Daggett
 +* @param containerName
 +*   corresponds to {@link Container#name()}.
 +* @return the CDNContainer or null, if not found.
 +* 
 +* @see a
 +*  
 href=http://docs.openstack.org/api/openstack-object-storage/1.0/content/retrieve-Container-metadata.html;
 +*  Get Container Metadata API/a
 +*
 +   @Named(cdn:enable)
 +   @PUT
 +   @ResponseParser(ParseCDNContainerURIFromHeaders.class)
 +   @Fallback(NullOnNotFoundOr404.class)
 +   @Path(/{containerName})
 +   @Nullable
 +   URI enable(@PathParam(containerName) String containerName);
 +   */

Whoops, will fix now.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/79/files#r9768583

Re: [jclouds-labs-openstack] Adds support for multi-region implementation of Rackspace Cloud Files API (#79)

2014-02-14 Thread Zack Shoylev
Lots of refactoring as well, nice! It seems some of the javadoc has to be 
finished. I would say this is not a problem, especially if waiting for some 
service-side answers?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/79#issuecomment-35138366

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread BuildHive
[jclouds » jclouds 
#846](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/846/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292#issuecomment-35140361

Jenkins build is back to stable : jclouds » jclouds #846

2014-02-14 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/846/changes