Re: [jclouds] Use try-with-resources where appropriate (#506)
[jclouds » jclouds #1591](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1591/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/506#issuecomment-54416925
[jira] [Created] (JCLOUDS-702) Create ProfitBricks Provider
Reijhanniel Jearl Campos created JCLOUDS-702: Summary: Create ProfitBricks Provider Key: JCLOUDS-702 URL: https://issues.apache.org/jira/browse/JCLOUDS-702 Project: jclouds Issue Type: Task Reporter: Reijhanniel Jearl Campos -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jclouds] Use try-with-resources where appropriate (#506)
[jclouds » jclouds #1590](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1590/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/506#issuecomment-54411145
Re: [jclouds] Remove ByteStreams2.asByteSource (#507)
[jclouds-pull-requests-java-6 #56](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/56/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/507#issuecomment-54407697
[jclouds] Remove ByteStreams2.asByteSource (#507)
This method is dangerous since all ByteSource should provide a new InputStream on every call to openStream while the method returns the same InputStream for non-repeatable Payloads. You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds bytestreams2-asbytesource Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/507 -- Commit Summary -- * Remove ByteStreams2.asByteSource -- File Changes -- M core/src/main/java/org/jclouds/io/ByteStreams2.java (11) M core/src/main/java/org/jclouds/io/internal/BasePayloadSlicer.java (3) -- Patch Links -- https://github.com/jclouds/jclouds/pull/507.patch https://github.com/jclouds/jclouds/pull/507.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/507
Re: [jclouds] Use try-with-resources where appropriate (#506)
[jclouds-pull-requests-java-6 #55](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/55/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/506#issuecomment-54407233
Re: [jclouds] Use try-with-resources where appropriate (#506)
> ByteStreams.copy(his, ByteStreams.nullOutputStream());
> return his.hash();
> - } finally {
> - Closeables.closeQuietly(input);
> - }
> - }
> -
> - public static byte[] toByteArrayAndClose(InputStream input) throws
> IOException {
Removed without deprecation since this is a @Beta API.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/506/files#r17095518
Re: [jclouds] Use try-with-resources where appropriate (#506)
[jclouds-pull-requests-java-6 #54](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/54/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/506#issuecomment-54407102
Re: [jclouds] Use try-with-resources where appropriate (#506)
[jclouds-pull-requests-java-6 #53](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/53/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/506#issuecomment-54406175
[jclouds] Use try-with-resources where appropriate (#506)
This is more succinct and idiomatic Java style. You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds try-with-resources Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/506 -- Commit Summary -- * Replace all calls to Closeables.closeQuietly * Replace all calls to Closeables.close * Replace some calls to Closeables2.closeQuietly -- File Changes -- M apis/byon/src/main/java/org/jclouds/byon/domain/YamlNode.java (7) M apis/byon/src/main/java/org/jclouds/byon/functions/NodesFromYamlStream.java (7) M apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java (6) M apis/filesystem/src/test/java/org/jclouds/filesystem/FilesystemAsyncBlobStoreTest.java (17) M blobstore/src/main/java/org/jclouds/blobstore/TransientStorageStrategy.java (6) M core/src/main/java/org/jclouds/JcloudsVersion.java (6) M core/src/main/java/org/jclouds/crypto/Pems.java (7) M core/src/main/java/org/jclouds/http/HttpUtils.java (6) M core/src/main/java/org/jclouds/http/functions/ParseFirstJsonValueNamed.java (5) M core/src/main/java/org/jclouds/http/functions/ParseSax.java (7) M core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java (19) M core/src/main/java/org/jclouds/io/ByteStreams2.java (10) M core/src/main/java/org/jclouds/logging/internal/Wire.java (13) M core/src/main/java/org/jclouds/util/Strings2.java (7) M core/src/test/java/org/jclouds/http/BackoffLimitedRetryJavaTest.java (22) M core/src/test/java/org/jclouds/http/BaseHttpCommandExecutorServiceIntegrationTest.java (130) M core/src/test/java/org/jclouds/http/BaseJettyTest.java (5) M drivers/gae/src/main/java/org/jclouds/gae/ConvertToGaeRequest.java (5) M drivers/jsch/src/main/java/org/jclouds/ssh/jsch/JschSshClient.java (5) M drivers/okhttp/src/test/java/org/jclouds/http/okhttp/OkHttpCommandExecutorServiceTest.java (17) M providers/glesys/src/test/java/org/jclouds/glesys/compute/GleSYSExperimentLiveTest.java (16) -- Patch Links -- https://github.com/jclouds/jclouds/pull/506.patch https://github.com/jclouds/jclouds/pull/506.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/506
Re: [jclouds-labs-openstack] OpenStack Heat Support (#138)
Can you also please add the testing info to [Testing OpenStack](https://wiki.apache.org/jclouds/Testing%20OpenStack)? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/138#issuecomment-54375377
Re: [jclouds-labs-openstack] OpenStack Heat Support (#138)
+1 Tested against Rackspace using mvn clean install -Plive -Dtest.openstack-heat.identity= -Dtest.openstack-heat.credential= -Dtest.openstack-heat.endpoint=https://identity.api.rackspacecloud.com/v2.0/ Live tests passed. :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/138#issuecomment-54375186
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
> +"name": "sampledb"
> +}
> +],
> +"host": "%",
> +"name": "demouser"
> +}
> +]
> +}
> +{% endhighlight %}
> +
> +To parse the response, jclouds uses [domain
> classes](https://github.com/jclouds/jclouds/blob/master/apis/openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/domain/User.java)
> to represent the JSON data returned by the service. The array of "users" is
> unwrapped into individual User domain objects. Conversely, when creating
> users, domain objects are transformed into a JSON request body.
> +
> +Because of the relative simplicity of user creation in trove, jclouds
> developers can use a create method in the features package without having to
> build an instance of the User class. For example, the developer might use a
> method such as
> +
> +{% highlight Java %}
> +boolean create(String userName, String password, String databaseName);
remove one space before String databaseName
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/124/files#r17074065
Re: [jclouds] Nova API Updates (#505)
[jclouds-pull-requests #1141](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1141/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/505#issuecomment-54350141
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
> @@ -0,0 +1,119 @@ > +--- > +author: Zack Shoylev > +comments: true > +date: 2014-09-03 23:00:00+00:00 > +layout: post > +slug: better-builders-with-jclouds > +title: Better Builders with jclouds! > +--- > + > +# Better Builders with jclouds > + > +If you are a new [jclouds](https://developer.rackspace.com/sdks/java/) > developer, or even if you are already developing jclouds support for any of > the OpenStack or Rackspace APIs, you have likely seen the domain classes that > are used throughout the the jclouds codebase. Change link to jclouds.apache.org. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124/files#r17072809
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
> @@ -0,0 +1,119 @@ > +--- > +author: Zack Shoylev > +comments: true > +date: 2014-09-03 23:00:00+00:00 > +layout: post > +slug: better-builders-with-jclouds > +title: Better Builders with jclouds! > +--- > + > +# Better Builders with jclouds > + > +If you are a new [jclouds](https://developer.rackspace.com/sdks/java/) > developer, or even if you are already developing jclouds support for any of > the OpenStack or Rackspace APIs, you have likely seen the domain classes that > are used throughout the the jclouds codebase. > +These classes are used to represent OpenStack resources, particularly the > JSON structures supported by OpenStack APIs. > + Add a `` between these paragraphs. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124/files#r17072775
Re: [jclouds-labs-openstack] Glance API ListImageOptions should support changesSince() (#137)
> @@ -54,6 +54,24 @@
> /**
> * Return only those images having a matching name attribute
> */
> + public ListImageOptions changesSince(Date ifModifiedSince) {
> + queryParameters.put("changes-since", checkNotNull(ifModifiedSince,
> "ifModifiedSince").getTime() / 1000 + "");
The checkNotNull message should be more descriptive.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/137/files#r17072742
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
> @@ -0,0 +1,119 @@ > +--- > +author: Zack Shoylev > +comments: true > +date: 2014-09-03 23:00:00+00:00 > +layout: post > +slug: better-builders-with-jclouds > +title: Better Builders with jclouds! > +--- > + > +# Better Builders with jclouds No need to repeat the title here. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124/files#r17072721
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
Go to http://89d96d9cf66576b30bb2-b935cd5295eaeed0a1e6ee8fc0c31ef7.r95.cf5.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124#issuecomment-54349579
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
[jclouds-site-pull-requests #392](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/392/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124#issuecomment-54349279
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
Reopened #124. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124#event-160761654
Re: [jclouds] Nova API Updates (#505)
+1 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/505#issuecomment-54348575
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124#issuecomment-54346972
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
[jclouds-site-pull-requests #391](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/391/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124#issuecomment-54346770
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
Closed #124. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124#event-160752544
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
Reopened #124. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124#event-160752549
Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)
[jclouds-pull-requests #1140](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1140/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#issuecomment-54345178
Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)
[jclouds » jclouds #1587](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1587/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#issuecomment-54344344
Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)
@jdaggett : Still have to resolve the checkstyle issue, but kind of stuck because there was no diff when I copied the license header from another file. Otherwise I think it's ready for another review. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-54343262
Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
> @@ -40,7 +40,7 @@ public String toString() {
>return name;
> }
>
> - /**
Internal to jclouds?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17068569
Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
Most of these changes were based on comments here: https://github.com/jclouds/jclouds-labs-openstack/pull/132 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54340665
Re: [jclouds] Nova API Updates (#505)
[jclouds-pull-requests-java-6 #52](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/52/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/505#issuecomment-54340206
[jclouds] Nova API Updates (#505)
This PR updates the `api-versionUpdated api-version and removed upper bounds wildcards for extension APIs You can merge this Pull Request by running: git pull https://github.com/rackspace/jclouds nova/update Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/505 -- Commit Summary -- * Updated api-version and removed upper bounds wildcards for extension APIs -- File Changes -- M apis/openstack-nova/pom.xml (4) M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/NovaApi.java (32) -- Patch Links -- https://github.com/jclouds/jclouds/pull/505.patch https://github.com/jclouds/jclouds/pull/505.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/505
Re: [jclouds] Implemented compute attach interfaces extension. (#497)
> @@ -261,6 +262,13 @@ > Optional getConsolesApi( > @EndpointParam(parser = RegionToEndpoint.class) String region); > > + /** > + * Provides access to attach interface features. > + */ > + @Delegate > + Optional getAttachInterfaceApi( All of the APIs are changing to this format since the upper bounds wildcard isn't necessary. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/497/files#r17067479
Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)
@jasdeep-hundal Ping! Is there anything else that needs to be done with this PR? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-54337653
Re: [jclouds] Token based authentication in openstack-keystone (#433)
@demobox What are you thinking here? `${credential}` ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/433#issuecomment-54337052
Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)
> @@ -35,7 +35,7 @@ > > > http://localhost:5000/v2.0/ > > -1.1 > +2 Follow on PR! This should have been changed in #390 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503/files#r17065200
Re: [jclouds-labs-openstack] OpenStack Heat Support (#138)
@everett-toews I updated the read me with instructions on running the live tests. We should do this for all of the other APIs! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/138#issuecomment-54336413
Re: [jclouds] Ensure that Content-MD5 has 128 bits (#504)
[jclouds » jclouds #1586](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1586/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/504#issuecomment-54335558
Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)
[jclouds-pull-requests-java-6 #51](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/51/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#issuecomment-54334589
Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)
@everett-toews The `AvailabilityZone` domain classes are also in the incorrect location I created [JCLOUDS-700](https://issues.apache.org/jira/browse/JCLOUDS-700) to track those necessary changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#issuecomment-54334092
Re: [jclouds-labs-openstack] OpenStack Heat Support (#138)
[jclouds-labs-openstack-pull-requests #404](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/404/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/138#issuecomment-54332775
Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
There are other instances where `/**` changed to `/*` and if you could revert those changes that would be awesome! +1 once the changes and other comments have been addressed. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54332242
Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
>
> - Rule newSecGroupRule = null;
> - for(Rule sgr : securityGroup.getRules()) {
> -if(sgr.getId().equals(rule.getId())) {
> - newSecGroupRule = sgr;
> - break;
> -}
> - }
> - assertNotNull(newSecGroupRule, "Did not find the new rule in the
> group.");
> +assertEquals(securityGroup.getRules().size(), 3);
`assertEquals(securityGroup.getRules().size(), 3, "Expected 3 default rules");`
as was on line 54...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17064283
Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)
> + > + /* > + * Check request > + */ > + assertEquals(server.getRequestCount(), 3); > + assertAuthentication(server); > + assertRequest(server.takeRequest(), "GET", > "/v2.0/security-group-rules"); > + assertRequest(server.takeRequest(), "GET", > "/v2.0/security-group-rules?marker=71c1e68c-171a-4aa2-aca5-50ea153a3718"); > + > + /* > + * Check response > + */ > + assertNotNull(rules); > + assertEquals(rules.size(), 8); > + assertEquals(rules.get(0).getId(), > "3c0e45ff-adaf-4124-b083-bf390e5482ff"); > + assertEquals(rules.get(7).getId(), > "f7d45c89-008e-4bab-88ad-d6811724c51c2"); Yep, should be ordered (we are using List-based collections for these). It should match the response order. I will add some comments to the test. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r17063823
Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
> @@ -18,8 +18,8 @@ > package org.jclouds.openstack.neutron.v2.domain; > > /** > - * Enumerates supported Network types. > - * > + * Enumerates supported Network types. > + * > * @see* > "http://docs.openstack.org/api/openstack-network/2.0/content/provider_ext.html";>api > doc Nuke the links too ;) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17064007
Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
> @@ -40,7 +40,7 @@ public String toString() {
>return name;
> }
>
> - /**
`/**` was OK here, so why the change?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17063974
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
[jclouds-site-pull-requests #390](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/390/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124#issuecomment-54330214
Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
> @@ -38,7 +38,7 @@ public String toString() {
>return name();
> }
>
> - /**
> + /*
Same as above!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17063978
Re: [jclouds-site] Domain classes, better builders blog post. (#124)
to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124#issuecomment-54330496
[jclouds-site] Domain classes, better builders blog post. (#124)
You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-site jclouds-domain-classes Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-site/pull/124 -- Commit Summary -- * Domain classes, better builders blog post. -- File Changes -- A _posts/2014-09-03-better-builders.md (119) -- Patch Links -- https://github.com/jclouds/jclouds-site/pull/124.patch https://github.com/jclouds/jclouds-site/pull/124.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/124
Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
[jclouds-labs-openstack-pull-requests #403](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/403/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54329013
Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
[jclouds » jclouds-labs-openstack #1665](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1665/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54328616
Re: [jclouds] Ensure that Content-MD5 has 128 bits (#504)
[jclouds-pull-requests-java-6 #50](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/50/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/504#issuecomment-54327043
Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
I still have to figure out if we want to do something about *Options to distinguish from the old patterns. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139#issuecomment-54326965
[jclouds-labs-openstack] Cleans up neutron code (#139)
You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-labs-openstack neutron-small-cleanup Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-openstack/pull/139 -- Commit Summary -- * Cleans up neutron code -- File Changes -- M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/IPv6DHCPMode.java (2) M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/NetworkStatus.java (2) M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/NetworkType.java (16) M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/Rule.java (12) M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/RuleDirection.java (2) M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/RuleEthertype.java (2) M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/RuleProtocol.java (2) M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/SecurityGroup.java (2) M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/VIFType.java (2) M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/VNICType.java (2) M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/extensions/SecurityGroupApi.java (4) M openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2/extensions/SecurityGroupApiLiveTest.java (77) -- Patch Links -- https://github.com/jclouds/jclouds-labs-openstack/pull/139.patch https://github.com/jclouds/jclouds-labs-openstack/pull/139.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139
Re: [jclouds] Ensure that Content-MD5 has 128 bits (#504)
Closed #504. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/504#event-160678568
Re: [jclouds] Ensure that Content-MD5 has 128 bits (#504)
> jclouds-pull-requests #1138 ABORTED Doesn't look happy :-( ``` [ERROR] There was a timeout or other error in the fork ``` Will clear the workspace and bounce... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/504#issuecomment-54326572
Re: [jclouds] Ensure that Content-MD5 has 128 bits (#504)
Reopened #504. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/504#event-160678575
Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)
> + > + /* > + * Check request > + */ > + assertEquals(server.getRequestCount(), 3); > + assertAuthentication(server); > + assertRequest(server.takeRequest(), "GET", > "/v2.0/security-group-rules"); > + assertRequest(server.takeRequest(), "GET", > "/v2.0/security-group-rules?marker=71c1e68c-171a-4aa2-aca5-50ea153a3718"); > + > + /* > + * Check response > + */ > + assertNotNull(rules); > + assertEquals(rules.size(), 8); > + assertEquals(rules.get(0).getId(), > "3c0e45ff-adaf-4124-b083-bf390e5482ff"); > + assertEquals(rules.get(7).getId(), > "f7d45c89-008e-4bab-88ad-d6811724c51c2"); > In this case this tests that paging was successful. Again, probably didn't express myself clearly here ;-) It looks like we are testing not just that the size of the collection is as expected, but that the order (well, we only test the first and last) is "as expected". Are these intended to be ordered, then? And does the order need to match the order in which they are represented in the response, or is there some other ordering criterion? A comment in the test to clarify that would help, I think ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r17062091
Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)
> + assertRequest(server.takeRequest(), "POST", > "/v2.0/security-groups", "/security_group_create_request.json"); > + > + /* > + * Check response > + */ > + assertNotNull(securityGroup); > + assertEquals(securityGroup.getId(), > "2076db17-a522-4506-91de-c6dd8e837028"); > + assertEquals(securityGroup.getTenantId(), > "e4f50856753b4dc6afee5fa6b9b6c550"); > + assertEquals(securityGroup.getName(), "new-webservers"); > + assertEquals(securityGroup.getDescription(), "security group for > webservers"); > + > + Rule sgr0 = securityGroup.getRules().get(0); > + Rule sgr1 = securityGroup.getRules().get(1); > + > + assertEquals(sgr0.getId(), "38ce2d8e-e8f1-48bd-83c2-d33cb9f50c3d"); > + assertEquals(sgr1.getId(), "565b9502-12de-4ffd-91e9-68885cff6ae1"); > Just making sure the Rule collection got parsed within the Security Group. Sorry, I wasn't clear. Is the result _meant_ to be ordered? In that case, I can see that we might want to test that the rules are returned in the right order. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r17061983
Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)
> + > + /* > + * Check request > + */ > + assertEquals(server.getRequestCount(), 3); > + assertAuthentication(server); > + assertRequest(server.takeRequest(), "GET", > "/v2.0/security-group-rules"); > + assertRequest(server.takeRequest(), "GET", > "/v2.0/security-group-rules?marker=71c1e68c-171a-4aa2-aca5-50ea153a3718"); > + > + /* > + * Check response > + */ > + assertNotNull(rules); > + assertEquals(rules.size(), 8); > + assertEquals(rules.get(0).getId(), > "3c0e45ff-adaf-4124-b083-bf390e5482ff"); > + assertEquals(rules.get(7).getId(), > "f7d45c89-008e-4bab-88ad-d6811724c51c2"); In this case this tests that paging was successful. The other cases usually make sure the collection is fine. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r17061424
Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)
> + assertRequest(server.takeRequest(), "POST", > "/v2.0/security-groups", "/security_group_create_request.json"); > + > + /* > + * Check response > + */ > + assertNotNull(securityGroup); > + assertEquals(securityGroup.getId(), > "2076db17-a522-4506-91de-c6dd8e837028"); > + assertEquals(securityGroup.getTenantId(), > "e4f50856753b4dc6afee5fa6b9b6c550"); > + assertEquals(securityGroup.getName(), "new-webservers"); > + assertEquals(securityGroup.getDescription(), "security group for > webservers"); > + > + Rule sgr0 = securityGroup.getRules().get(0); > + Rule sgr1 = securityGroup.getRules().get(1); > + > + assertEquals(sgr0.getId(), "38ce2d8e-e8f1-48bd-83c2-d33cb9f50c3d"); > + assertEquals(sgr1.getId(), "565b9502-12de-4ffd-91e9-68885cff6ae1"); Just making sure the Rule collection got parsed within the Security Group. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r17061284
Re: [jclouds] Ensure that Content-MD5 has 128 bits (#504)
[jclouds-pull-requests #1138](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1138/) ABORTED --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/504#issuecomment-54320167
[jira] [Updated] (JCLOUDS-153) Remove the jclouds Executors
[ https://issues.apache.org/jira/browse/JCLOUDS-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-153: Fix Version/s: (was: 2.0.0) > Remove the jclouds Executors > > > Key: JCLOUDS-153 > URL: https://issues.apache.org/jira/browse/JCLOUDS-153 > Project: jclouds > Issue Type: Sub-task > Components: jclouds-core >Affects Versions: 1.7.0 >Reporter: Ignasi Barrera > > Once all providers and apis have been un-asynched, the jclouds executors (and > all their related stuff such as the FutureIterables class) used to perform > the asynchronous api calls should be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-683) Promote oauth API
[ https://issues.apache.org/jira/browse/JCLOUDS-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-683: Fix Version/s: (was: 2.0.0) > Promote oauth API > - > > Key: JCLOUDS-683 > URL: https://issues.apache.org/jira/browse/JCLOUDS-683 > Project: jclouds > Issue Type: Task > Components: jclouds-core, jclouds-labs-google >Affects Versions: 2.0.0 >Reporter: Jeremy Daggett >Priority: Trivial > > Promote the oauth API to the main jclouds/jclouds repo so that other > apis/providers can leverage it. > Original email thread: > http://markmail.org/search/?q=jclouds+list%3Aorg.apache.jclouds.dev+OAuth#query:jclouds%20list%3Aorg.apache.jclouds.dev%20OAuth%20order%3Adate-backward+page:1+mid:wc3th3fantvxy6zy+state:results -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-456) Cinder clone volume
[ https://issues.apache.org/jira/browse/JCLOUDS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-456: Fix Version/s: (was: 2.0.0) > Cinder clone volume > --- > > Key: JCLOUDS-456 > URL: https://issues.apache.org/jira/browse/JCLOUDS-456 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Reporter: Everett Toews >Priority: Minor > Labels: openstack, rackspace > > Support cloning an existing volume. > API doc: > http://docs.rackspace.com/cbs/api/v1.0/cbs-devguide/content/POST_createVolume_v1__tenant_id__volumes_v1__tenant_id__volumes.html) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-688) Nova ServerApi.createImageFromServer() does not consider metadata
[
https://issues.apache.org/jira/browse/JCLOUDS-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul updated JCLOUDS-688:
Fix Version/s: (was: 2.0.0)
> Nova ServerApi.createImageFromServer() does not consider metadata
> -
>
> Key: JCLOUDS-688
> URL: https://issues.apache.org/jira/browse/JCLOUDS-688
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-core
>Affects Versions: 1.6.0, 1.7.0, 1.8.0
>Reporter: Jeremy Daggett
>
> The
> [{{createImageFromServer}}|https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/ServerApi.java#L307]
> method should allow users to pass a map of user metadata. The current
> Payload annotation sends an [empty
> map|https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/ServerApi.java#L304].
> This method should be deprecated and updated with a new implementation that
> allows for passing the map of metadata.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (JCLOUDS-150) Remove async interface from AWS APIs/providers, rename *Client to *Api
[ https://issues.apache.org/jira/browse/JCLOUDS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-150: Fix Version/s: (was: 2.0.0) > Remove async interface from AWS APIs/providers, rename *Client to *Api > -- > > Key: JCLOUDS-150 > URL: https://issues.apache.org/jira/browse/JCLOUDS-150 > Project: jclouds > Issue Type: Sub-task > Components: jclouds-core, jclouds-labs-aws >Affects Versions: 1.7.0 >Reporter: Andrew Bayer > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-404) Support Rackspace Cloud Backup
[ https://issues.apache.org/jira/browse/JCLOUDS-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-404: Fix Version/s: (was: 2.0.0) > Support Rackspace Cloud Backup > -- > > Key: JCLOUDS-404 > URL: https://issues.apache.org/jira/browse/JCLOUDS-404 > Project: jclouds > Issue Type: New Feature > Components: jclouds-labs-openstack >Reporter: Jeremy Daggett >Priority: Minor > > Implement the Rackspace Cloud Backup v1 API. A new provider will be needed to > support this API. Any work should be done in the jclouds-labs-openstack > project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-468) Nova needs to handle key pair creation better in the ComputeService
[ https://issues.apache.org/jira/browse/JCLOUDS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-468: Fix Version/s: (was: 2.0.0) > Nova needs to handle key pair creation better in the ComputeService > --- > > Key: JCLOUDS-468 > URL: https://issues.apache.org/jira/browse/JCLOUDS-468 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Reporter: Everett Toews >Priority: Minor > Labels: openstack > > Nova needs a strategy so it behaves more like > org.jclouds.aws.ec2.compute.strategy.CreateKeyPairPlacementAndSecurityGroupsAsNeededAndReturnRunOptions.createNewKeyPairUnlessUserSpecifiedOtherwise() > > Right now it only has > org.jclouds.openstack.nova.v2_0.compute.loaders.CreateUniqueKeyPair which > does not examine TemplateOptions to determine what to do. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-47) Port CloudWatch Code To Newer jclouds Coding Standards
[ https://issues.apache.org/jira/browse/JCLOUDS-47?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-47: --- Fix Version/s: (was: 2.0.0) > Port CloudWatch Code To Newer jclouds Coding Standards > -- > > Key: JCLOUDS-47 > URL: https://issues.apache.org/jira/browse/JCLOUDS-47 > Project: jclouds > Issue Type: New Feature >Affects Versions: 1.6.0 >Reporter: Jeremy Whitlock >Priority: Blocker > Labels: CloudWatch > Original Estimate: 48h > Remaining Estimate: 48h > > The current CloudWatch code uses deprecated APIs and exposes APIs in a manner > not consistent with current jclouds coding standards. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-472) Option [OS reload] for softlayer node should be added
[ https://issues.apache.org/jira/browse/JCLOUDS-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-472: Fix Version/s: (was: 2.0.0) > Option [OS reload] for softlayer node should be added > - > > Key: JCLOUDS-472 > URL: https://issues.apache.org/jira/browse/JCLOUDS-472 > Project: jclouds > Issue Type: New Feature > Components: jclouds-compute >Affects Versions: 1.6.2 >Reporter: Evgeny Fisher >Priority: Critical > Labels: softlayer > > In softlayer console OS reload command can be found. Actually it rebuilds CCI > instance. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-212) Add cloud database abstraction a la compute/blobstore
[ https://issues.apache.org/jira/browse/JCLOUDS-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-212: Fix Version/s: (was: 2.0.0) > Add cloud database abstraction a la compute/blobstore > - > > Key: JCLOUDS-212 > URL: https://issues.apache.org/jira/browse/JCLOUDS-212 > Project: jclouds > Issue Type: Improvement > Components: jclouds-core >Affects Versions: 1.8.0 >Reporter: Andrew Bayer > > Let's add an abstraction for cloud databases, a la compute/blobstore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-536) Support Nova Quota Sets Extension API
[ https://issues.apache.org/jira/browse/JCLOUDS-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-536: Fix Version/s: (was: 2.0.0) > Support Nova Quota Sets Extension API > - > > Key: JCLOUDS-536 > URL: https://issues.apache.org/jira/browse/JCLOUDS-536 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Affects Versions: 1.8.0 >Reporter: Jeremy Daggett > Labels: openstack > > JCLOUDS-526 proposes the removal of the legacy Nova QuotaClassApi, however > the QuotaApi currently maps to the "os-quota-class" OpenStack Nova Extension. > The domain object for Quota needs to be updated to reflect the added/removed > fields. > volumes, gigabytes, and cores have been removed. > quota_set, fixed_ips, and injected_file_path_bytes have been added. > Unit/Live Tests will need to be updated -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-210) Add abstraction layer for DNS a la compute/blobstore
[ https://issues.apache.org/jira/browse/JCLOUDS-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-210: Fix Version/s: (was: 2.0.0) > Add abstraction layer for DNS a la compute/blobstore > > > Key: JCLOUDS-210 > URL: https://issues.apache.org/jira/browse/JCLOUDS-210 > Project: jclouds > Issue Type: Improvement > Components: jclouds-core >Affects Versions: 1.8.0 >Reporter: Andrew Bayer > > Let's get an abstraction layer for DNS APIs/providers added, a la > compute/blobstore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-514) Need to be able to attach block volumes at instance creation in Nova
[
https://issues.apache.org/jira/browse/JCLOUDS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul updated JCLOUDS-514:
Fix Version/s: (was: 2.0.0)
> Need to be able to attach block volumes at instance creation in Nova
>
>
> Key: JCLOUDS-514
> URL: https://issues.apache.org/jira/browse/JCLOUDS-514
> Project: jclouds
> Issue Type: New Feature
> Components: jclouds-compute, jclouds-core
>Reporter: Jasdeep Hundal
> Labels: features
>
> The Nova API allows for attaching block volumes to an instance at creation
> time, it would be nice to access this feature through JClouds.
> Example Nova JSON:
> {"server": {"name": "jasdeep-test", "imageRef":
> "ed5912af-ff25-4ff3-bbec-6c00898c14b8", "block_device_mapping":
> [{"volume_size": "", "volume_id": "f696b2aa-4c83-40ad-ab25-984b59dd2e3c",
> "delete_on_termination": "1", "device_name": "vda"}], "flavorRef": "small",
> "max_count": 1, "min_count": 1}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (JCLOUDS-609) Adding vCloud API 1.5 support
[ https://issues.apache.org/jira/browse/JCLOUDS-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-609: Fix Version/s: (was: 2.0.0) > Adding vCloud API 1.5 support > - > > Key: JCLOUDS-609 > URL: https://issues.apache.org/jira/browse/JCLOUDS-609 > Project: jclouds > Issue Type: Improvement >Reporter: Melan Nimesh > > Adding vCloud API 1.5 support for jclouds -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-39) Rename packages from org.jclouds -> org.apache.jclouds
[ https://issues.apache.org/jira/browse/JCLOUDS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-39: --- Fix Version/s: (was: 2.0.0) > Rename packages from org.jclouds -> org.apache.jclouds > -- > > Key: JCLOUDS-39 > URL: https://issues.apache.org/jira/browse/JCLOUDS-39 > Project: jclouds > Issue Type: Task > Components: jclouds-chef, jclouds-cli, jclouds-core, jclouds-karaf, > jclouds-labs, jclouds-labs-aws, jclouds-labs-google, jclouds-labs-openstack >Affects Versions: 1.8.0 >Reporter: Andrew Bayer >Priority: Blocker > > We need to rename packages from org.jclouds to org.apache.jclouds. Maven > groupIds are already done, but the actual packages need to change too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-152) Remove the RestContext
[ https://issues.apache.org/jira/browse/JCLOUDS-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-152: Fix Version/s: (was: 2.0.0) > Remove the RestContext > -- > > Key: JCLOUDS-152 > URL: https://issues.apache.org/jira/browse/JCLOUDS-152 > Project: jclouds > Issue Type: Sub-task > Components: jclouds-core >Affects Versions: 1.7.0 >Reporter: Ignasi Barrera > > Once all providers and apis have been un-asynched, the RestContext class and > all its related stuff must be removed, and the ApiContext used instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-172) "Graduate" GCE to core
[ https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-172: Fix Version/s: (was: 2.0.0) > "Graduate" GCE to core > -- > > Key: JCLOUDS-172 > URL: https://issues.apache.org/jira/browse/JCLOUDS-172 > Project: jclouds > Issue Type: Task > Components: jclouds-labs-google >Affects Versions: 1.8.0 >Reporter: Andrew Bayer >Priority: Critical > > We should really get GCE to a "finished" state and include it in 1.7.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-40) remove Async interface from all apis and providers
[ https://issues.apache.org/jira/browse/JCLOUDS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-40: --- Fix Version/s: (was: 2.0.0) > remove Async interface from all apis and providers > -- > > Key: JCLOUDS-40 > URL: https://issues.apache.org/jira/browse/JCLOUDS-40 > Project: jclouds > Issue Type: Improvement > Components: jclouds-blobstore, jclouds-core, jclouds-labs, > jclouds-labs-aws, jclouds-labs-google, jclouds-labs-openstack >Affects Versions: 1.7.0 >Reporter: Adrian Cole > Original Estimate: 72h > Remaining Estimate: 72h > > In jclouds 1.6.0, we deprecated all async interfaces. Let's use this issue > and subtasks to track removing it and all supporting code from 1.7.x (current > master) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-579) Fix broken test cases in CloudSigma2ApiExpectTest.java
[ https://issues.apache.org/jira/browse/JCLOUDS-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-579: Fix Version/s: (was: 2.0.0) > Fix broken test cases in CloudSigma2ApiExpectTest.java > -- > > Key: JCLOUDS-579 > URL: https://issues.apache.org/jira/browse/JCLOUDS-579 > Project: jclouds > Issue Type: Bug > Components: jclouds-labs >Affects Versions: 1.7.2 >Reporter: rahul ruikar > Labels: cloudsigma > Original Estimate: 12h > Remaining Estimate: 12h > > Some testcases are broken in CloudSigma2 are broken. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-237) Implement module discovery
[ https://issues.apache.org/jira/browse/JCLOUDS-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-237: Fix Version/s: (was: 2.0.0) > Implement module discovery > -- > > Key: JCLOUDS-237 > URL: https://issues.apache.org/jira/browse/JCLOUDS-237 > Project: jclouds > Issue Type: Improvement >Reporter: Ioannis Canellos > > Currently, when we are creating a Context, we are adding the modules to the > context builder programmatically. > This works great, but its not very tooling friendly. A tool would need a way > to find out which modules are available so that it can display them to the > user and let him select which modules he wants to use. > A discovery mechanism like the one we already have for Apis & Providers would > be an awesome addition. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)
+1 After the few comments have been addressed. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#issuecomment-54301540
Re: [jclouds] Add ByteSourcePayloadIterator to BasePayloadSlicer (#501)
> +
> + @Override
> + public Payload next() {
> + if (!hasNext()) {
> +throw new NoSuchElementException();
> + }
> +
> + Payload payload = nextPayload;
> + nextPayload = getNextPayload();
> +
> + return payload;
> + }
> +
> + @Override
> + public void remove() {
> + throw new UnsupportedOperationException();
[minor] Any message we can add here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/501/files#r17046999
Re: [jclouds] Add ByteSourcePayloadIterator to BasePayloadSlicer (#501)
> +
> + return payload;
> + }
> +
> + @Override
> + public void remove() {
> + throw new UnsupportedOperationException();
> + }
> +
> + @Override
> + public Iterator iterator() {
> + return this;
> + }
> +
> + private Payload getNextPayload() {
> + try {
[minor] Does the `try` need to enclose so much?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/501/files#r17047056
Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)
> + @Override
> + protected Function>
> markerToNextForArg0(Optional arg0) {
> + String region = arg0.isPresent() ? arg0.get().toString() : null;
> + final SecurityGroupApi securityGroupApi =
> api.getSecurityGroupApi(region).get();
> + return new Function>() {
> +
> + @SuppressWarnings("unchecked")
> + @Override
> + public IterableWithMarker apply(Object input) {
> +PaginationOptions paginationOptions =
> PaginationOptions.class.cast(input);
> +return
> IterableWithMarker.class.cast(securityGroupApi.listSecurityGroups(paginationOptions));
> + }
> +
> + @Override
> + public String toString() {
> +return "listSecurityGroups()";
> That is my understanding. Should we be doing something else here?
I don't know ;-) If we feel this is an accurate toString description of this
class then no, I think we're fine.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r17046194
Re: [jclouds] Add ByteSourcePayloadIterator to BasePayloadSlicer (#501)
> @@ -50,14 +50,14 @@
> @Singleton
> public class BasePayloadSlicer implements PayloadSlicer {
>
> - public static class PayloadIterator implements Iterable,
> Iterator {
> + private static class InputStreamPayloadIterator implements
> Iterable, Iterator {
Seems safe enough to me. Is there any easy way we can check for (public) usage
of this class?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/501/files#r17046913
Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)
> @@ -24,7 +24,7 @@ > > import org.jclouds.Fallbacks.EmptyFluentIterableOnNotFoundOr404; > import org.jclouds.openstack.keystone.v2_0.filters.AuthenticateRequest; > -import org.jclouds.openstack.nova.v2_0.domain.regionscoped.AvailabilityZone; > +import org.jclouds.openstack.nova.v2_0.domain.zonescoped.AvailabilityZone; This should still use `regionscoped` right? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503/files#r17050508
Re: [jclouds] Add ByteSourcePayloadIterator to BasePayloadSlicer (#501)
> jclouds » jclouds #1578 UNSTABLE Looks like this could be a [real test failure](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds.provider$aws-ec2/1578/testReport/junit/org.jclouds.aws.ec2/AWSEC2ContextBuilderTest/testConvertImageSyntaxWhenStar/)? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/501#issuecomment-54294554
Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)
> +
> +/**
> + * Tests parsing and Guice wiring of RouterApi
> + */
> +@Test(groups = "live", testName = "SecurityGroupApiLiveTest")
> +public class SecurityGroupApiLiveTest extends BaseNeutronApiLiveTest {
> +
> + /**
> +* Smoke test for the Security Group extension for Neutron
> +*/
> + public void testCreateUpdateAndDeleteSecurityGroup() {
> + for (String region : api.getConfiguredRegions()) {
> + SecurityGroupApi sgApi = api.getSecurityGroupApi(region).get();
> +
> + SecurityGroup securityGroup = sgApi.create(
> +
> SecurityGroup.createOptions().name("jclouds-test").description("jclouds test
> security group").build());
> you can have the same name multiple times, I think.
Ah, OK. As long as we're not setting ourselves up for spurious test failures
down the line...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r17046213
Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)
> +
> + // Refresh
> + securityGroup = sgApi.getSecurityGroup(securityGroup.getId());
> +
> + assertEquals(securityGroup.getName(), "jclouds-test");
> + assertEquals(securityGroup.getDescription(), "jclouds test security
> group");
> +
> + assertEquals(securityGroup.getRules().size(), 3, "Expected 2
> default rules");
> +
> + Rule newSecGroupRule = null;
> + for(Rule sgr : securityGroup.getRules()) {
> +if(sgr.getId().equals(rule.getId())) {
> + newSecGroupRule = sgr;
> + break;
> +}
> + }
> Rather keep it as is?
Sure!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r17046224
Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)
> + return name;
> + }
> +
> + /**
> +* This provides GSON enum support in jclouds.
> +* */
> + public static RuleDirection fromValue(String name){
> + if (name != null) {
> + for (RuleDirection value : RuleDirection.values()) {
> +if (name.equalsIgnoreCase(value.name)) {
> + return value;
> +}
> + }
> + return UNRECOGNIZED;
> + }
> + return null;
> Technically ok with this, but might have to apply it in a lot of places.
Then also fine with keeping as-is.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r17046171
Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)
> @@ -35,7 +35,7 @@ > > > http://localhost:5000/v2.0/ > > -1.1 > +2 Changing this version is _way_ out of scope for this PR. Please remove it from the commit. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503/files#r17050329
Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)
> @@ -19,7 +19,7 @@ > import com.google.common.base.Optional; > import com.google.common.collect.FluentIterable; > > -import org.jclouds.openstack.nova.v2_0.domain.regionscoped.AvailabilityZone; > +import org.jclouds.openstack.nova.v2_0.domain.zonescoped.AvailabilityZone; This should still use `regionscoped` right? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503/files#r17050521
Re: [jclouds] Add ByteSourcePayloadIterator to BasePayloadSlicer (#501)
> @@ -71,6 +71,33 @@ public void testIterableSliceExpectedMulti() throws
> IOException {
> }
>
> @Test
> + public void testIterableSliceWithRepeatingByteSource0() throws
> IOException {
Just curious about the reason for the test name (why the trailing `0`)?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/501/files#r17047099
Re: [jclouds] Add ByteSourcePayloadIterator to BasePayloadSlicer (#501)
> @@ -130,6 +130,68 @@ private Payload createPayload(byte[] content) {
>
> }
>
> + private static class ByteSourcePayloadIterator implements
> Iterable, Iterator {
> + private final ByteSource input;
> + private final ContentMetadata metaData;
[minor] `meta` to match the constructor param - or rename that to match this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/501/files#r17046977
