[jira] [Resolved] (JCLOUDS-1443) unable to resolve URI with complex host
[
https://issues.apache.org/jira/browse/JCLOUDS-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1443.
-
Resolution: Fixed
> unable to resolve URI with complex host
> ---
>
> Key: JCLOUDS-1443
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1443
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-core
>Reporter: Mathieu Tortuyaux
>Priority: Minor
> Labels: easyfix
> Fix For: 2.2.0, 2.1.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We need to be sure that the base URL in this [method|
> https://github.com/tormath1/jclouds/blob/master/core/src/main/java/org/jclouds/rest/internal/RestAnnotationProcessor.java#L576]
> is ending with a `/`. If not, the final URL will be wrong formatted.
> Example:
> {code:java}
> public class Toto {
> public static void main(String []argv) throws Exception {
> URI uri1 = URI.create("https://www.googleapis.com/compute/v1";);
> URI uri2 =
> URI.create("projects/a-project/regions/us-east1/subnetworks/toto");
> URI uri3 = URI.create("https://www.googleapis.com/compute/v1/";);
> System.out.println(uri1.resolve(uri2));
> // output:
> https://www.googleapis.com/compute/projects/a-project/regions/us-east1/subnetworks/toto
> System.out.println(uri3.resolve(uri2));
> // output:
> https://www.googleapis.com/compute/v1/projects/a-project/regions/us-east1/subnetworks/toto
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (JCLOUDS-1443) unable to resolve URI with complex host
[
https://issues.apache.org/jira/browse/JCLOUDS-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1443:
Fix Version/s: 2.1.2
2.2.0
> unable to resolve URI with complex host
> ---
>
> Key: JCLOUDS-1443
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1443
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-core
>Reporter: Mathieu Tortuyaux
>Priority: Minor
> Labels: easyfix
> Fix For: 2.2.0, 2.1.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We need to be sure that the base URL in this [method|
> https://github.com/tormath1/jclouds/blob/master/core/src/main/java/org/jclouds/rest/internal/RestAnnotationProcessor.java#L576]
> is ending with a `/`. If not, the final URL will be wrong formatted.
> Example:
> {code:java}
> public class Toto {
> public static void main(String []argv) throws Exception {
> URI uri1 = URI.create("https://www.googleapis.com/compute/v1";);
> URI uri2 =
> URI.create("projects/a-project/regions/us-east1/subnetworks/toto");
> URI uri3 = URI.create("https://www.googleapis.com/compute/v1/";);
> System.out.println(uri1.resolve(uri2));
> // output:
> https://www.googleapis.com/compute/projects/a-project/regions/us-east1/subnetworks/toto
> System.out.println(uri3.resolve(uri2));
> // output:
> https://www.googleapis.com/compute/v1/projects/a-project/regions/us-east1/subnetworks/toto
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (JCLOUDS-1339) Support launching an x1 EC2 instance
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1339. - Resolution: Fixed > Support launching an x1 EC2 instance > > > Key: JCLOUDS-1339 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1339 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Affects Versions: 2.0.2 >Reporter: Markus Kuppe >Priority: Major > Labels: aws-ec2 > Fix For: 2.2.0, 2.1.2 > > > The current version of jclouds-compute does not support launching x1 > (x1.32xlarge and x1.16xlarge) EC instances. x1 instances are memory optimized > instances with a high core count tailored to demanding workloads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JCLOUDS-1339) Support launching an x1 EC2 instance
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1339: Fix Version/s: 2.1.2 2.2.0 > Support launching an x1 EC2 instance > > > Key: JCLOUDS-1339 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1339 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Affects Versions: 2.0.2 >Reporter: Markus Kuppe >Priority: Major > Labels: aws-ec2 > Fix For: 2.2.0, 2.1.2 > > > The current version of jclouds-compute does not support launching x1 > (x1.32xlarge and x1.16xlarge) EC instances. x1 instances are memory optimized > instances with a high core count tailored to demanding workloads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)
Closed #1235. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1235#event-1806022560
Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/88f44a6d) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/ca063d8b). Thanks @lemmy! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1235#issuecomment-415522613
Re: [jclouds/jclouds] [JCLOUDS-1443] - Fix resolution uri (#1234)
Closed #1234. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1234#event-1806020959
Re: [jclouds/jclouds] [JCLOUDS-1443] - Fix resolution uri (#1234)
Amended the commit message to include the JIRA issue ref and merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/bcc6a264) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/591fe84d). Thanks @tormath1! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1234#issuecomment-415522371
[jira] [Commented] (JCLOUDS-1339) Support launching an x1 EC2 instance
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590652#comment-16590652 ] ASF subversion and git services commented on JCLOUDS-1339: -- Commit ca063d8bfa88ec08c94c99416574cb7958058a26 in jclouds's branch refs/heads/2.1.x from Markus Alexander Kuppe [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=ca063d8 ] JCLOUDS-1339: Support launching an x1 EC2 instance https://issues.apache.org/jira/browse/JCLOUDS-1339 > Support launching an x1 EC2 instance > > > Key: JCLOUDS-1339 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1339 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Affects Versions: 2.0.2 >Reporter: Markus Kuppe >Priority: Major > Labels: aws-ec2 > > The current version of jclouds-compute does not support launching x1 > (x1.32xlarge and x1.16xlarge) EC instances. x1 instances are memory optimized > instances with a high core count tailored to demanding workloads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCLOUDS-1339) Support launching an x1 EC2 instance
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590651#comment-16590651 ] ASF subversion and git services commented on JCLOUDS-1339: -- Commit ca063d8bfa88ec08c94c99416574cb7958058a26 in jclouds's branch refs/heads/2.1.x from Markus Alexander Kuppe [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=ca063d8 ] JCLOUDS-1339: Support launching an x1 EC2 instance https://issues.apache.org/jira/browse/JCLOUDS-1339 > Support launching an x1 EC2 instance > > > Key: JCLOUDS-1339 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1339 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Affects Versions: 2.0.2 >Reporter: Markus Kuppe >Priority: Major > Labels: aws-ec2 > > The current version of jclouds-compute does not support launching x1 > (x1.32xlarge and x1.16xlarge) EC instances. x1 instances are memory optimized > instances with a high core count tailored to demanding workloads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCLOUDS-1443) unable to resolve URI with complex host
[
https://issues.apache.org/jira/browse/JCLOUDS-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590650#comment-16590650
]
ASF subversion and git services commented on JCLOUDS-1443:
--
Commit 591fe84dd923cdf189d3da5362ccaa4128e8935a in jclouds's branch
refs/heads/2.1.x from [~tormath1]
[ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=591fe84 ]
JCLOUDS-1443: fix(rest/processor): check if `/` is ending a default endpoint
> unable to resolve URI with complex host
> ---
>
> Key: JCLOUDS-1443
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1443
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-core
>Reporter: Mathieu Tortuyaux
>Priority: Minor
> Labels: easyfix
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We need to be sure that the base URL in this [method|
> https://github.com/tormath1/jclouds/blob/master/core/src/main/java/org/jclouds/rest/internal/RestAnnotationProcessor.java#L576]
> is ending with a `/`. If not, the final URL will be wrong formatted.
> Example:
> {code:java}
> public class Toto {
> public static void main(String []argv) throws Exception {
> URI uri1 = URI.create("https://www.googleapis.com/compute/v1";);
> URI uri2 =
> URI.create("projects/a-project/regions/us-east1/subnetworks/toto");
> URI uri3 = URI.create("https://www.googleapis.com/compute/v1/";);
> System.out.println(uri1.resolve(uri2));
> // output:
> https://www.googleapis.com/compute/projects/a-project/regions/us-east1/subnetworks/toto
> System.out.println(uri3.resolve(uri2));
> // output:
> https://www.googleapis.com/compute/v1/projects/a-project/regions/us-east1/subnetworks/toto
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JCLOUDS-1443) unable to resolve URI with complex host
[
https://issues.apache.org/jira/browse/JCLOUDS-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590643#comment-16590643
]
ASF subversion and git services commented on JCLOUDS-1443:
--
Commit bcc6a2648834335d711cee7cb219e4ad7552979b in jclouds's branch
refs/heads/master from [~tormath1]
[ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=bcc6a26 ]
JCLOUDS-1443: fix(rest/processor): check if `/` is ending a default endpoint
> unable to resolve URI with complex host
> ---
>
> Key: JCLOUDS-1443
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1443
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-core
>Reporter: Mathieu Tortuyaux
>Priority: Minor
> Labels: easyfix
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We need to be sure that the base URL in this [method|
> https://github.com/tormath1/jclouds/blob/master/core/src/main/java/org/jclouds/rest/internal/RestAnnotationProcessor.java#L576]
> is ending with a `/`. If not, the final URL will be wrong formatted.
> Example:
> {code:java}
> public class Toto {
> public static void main(String []argv) throws Exception {
> URI uri1 = URI.create("https://www.googleapis.com/compute/v1";);
> URI uri2 =
> URI.create("projects/a-project/regions/us-east1/subnetworks/toto");
> URI uri3 = URI.create("https://www.googleapis.com/compute/v1/";);
> System.out.println(uri1.resolve(uri2));
> // output:
> https://www.googleapis.com/compute/projects/a-project/regions/us-east1/subnetworks/toto
> System.out.println(uri3.resolve(uri2));
> // output:
> https://www.googleapis.com/compute/v1/projects/a-project/regions/us-east1/subnetworks/toto
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JCLOUDS-1339) Support launching an x1 EC2 instance
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590645#comment-16590645 ] ASF subversion and git services commented on JCLOUDS-1339: -- Commit 88f44a6d8edc92e76bfe1a5fd0a00bdde6b16148 in jclouds's branch refs/heads/master from Markus Alexander Kuppe [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=88f44a6 ] JCLOUDS-1339: Support launching an x1 EC2 instance https://issues.apache.org/jira/browse/JCLOUDS-1339 > Support launching an x1 EC2 instance > > > Key: JCLOUDS-1339 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1339 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Affects Versions: 2.0.2 >Reporter: Markus Kuppe >Priority: Major > Labels: aws-ec2 > > The current version of jclouds-compute does not support launching x1 > (x1.32xlarge and x1.16xlarge) EC instances. x1 instances are memory optimized > instances with a high core count tailored to demanding workloads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCLOUDS-1339) Support launching an x1 EC2 instance
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590644#comment-16590644 ] ASF subversion and git services commented on JCLOUDS-1339: -- Commit 88f44a6d8edc92e76bfe1a5fd0a00bdde6b16148 in jclouds's branch refs/heads/master from Markus Alexander Kuppe [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=88f44a6 ] JCLOUDS-1339: Support launching an x1 EC2 instance https://issues.apache.org/jira/browse/JCLOUDS-1339 > Support launching an x1 EC2 instance > > > Key: JCLOUDS-1339 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1339 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Affects Versions: 2.0.2 >Reporter: Markus Kuppe >Priority: Major > Labels: aws-ec2 > > The current version of jclouds-compute does not support launching x1 > (x1.32xlarge and x1.16xlarge) EC instances. x1 instances are memory optimized > instances with a high core count tailored to demanding workloads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1235#pullrequestreview-149036803
Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)
nacx commented on this pull request.
> @@ -290,6 +290,19 @@ private EC2HardwareBuilder hs1() {
virtualizationTypes(VirtualizationType.HVM,
VirtualizationType.PARAVIRTUAL);
return this;
}
+
+ private EC2HardwareBuilder x1() {
+ virtualizationTypes(VirtualizationType.HVM);
+
+ // TODO X1 is not deprecated, but it requires that you are using
a VPC
+ // until we have a way for hardware instances to be filtered
based on network
+ // we do NOT want X1 selected automatically.
+ // You get: org.jclouds.aws.AWSResponseException: request POST
https://ec2.eu-west-1.amazonaws.com/ HTTP/1.1 failed with code 400, error:
AWSError{requestId='2300b99e-ddc0-42ab-b1ed-9d628a161be4', requestToken='null',
code='VPCResourceNotSpecified', message='The specified instance type can only
be used in a VPC. A subnet ID or network interface ID is required to carry out
the request.', context='{Response=, Errors=}'}
+ // A user can explicitly request a x1 if they are also setting up
a VPC.
+ deprecated();
Yep. Instead of abusing the `deprecated` thing we should add a method that says
`requiresVPC()` or similar to properly mark those hardware profiles, and remove
that ugly and confusing comment, but that's for another PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1235#discussion_r212408537
Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)
lemmy commented on this pull request.
> @@ -290,6 +290,19 @@ private EC2HardwareBuilder hs1() {
virtualizationTypes(VirtualizationType.HVM,
VirtualizationType.PARAVIRTUAL);
return this;
}
+
+ private EC2HardwareBuilder x1() {
+ virtualizationTypes(VirtualizationType.HVM);
+
+ // TODO X1 is not deprecated, but it requires that you are using
a VPC
+ // until we have a way for hardware instances to be filtered
based on network
+ // we do NOT want X1 selected automatically.
+ // You get: org.jclouds.aws.AWSResponseException: request POST
https://ec2.eu-west-1.amazonaws.com/ HTTP/1.1 failed with code 400, error:
AWSError{requestId='2300b99e-ddc0-42ab-b1ed-9d628a161be4', requestToken='null',
code='VPCResourceNotSpecified', message='The specified instance type can only
be used in a VPC. A subnet ID or network interface ID is required to carry out
the request.', context='{Response=, Errors=}'}
+ // A user can explicitly request a x1 if they are also setting up
a VPC.
+ deprecated();
Thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1235#discussion_r212399157
Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)
andreaturli commented on this pull request.
> @@ -290,6 +290,19 @@ private EC2HardwareBuilder hs1() {
virtualizationTypes(VirtualizationType.HVM,
VirtualizationType.PARAVIRTUAL);
return this;
}
+
+ private EC2HardwareBuilder x1() {
+ virtualizationTypes(VirtualizationType.HVM);
+
+ // TODO X1 is not deprecated, but it requires that you are using
a VPC
+ // until we have a way for hardware instances to be filtered
based on network
+ // we do NOT want X1 selected automatically.
+ // You get: org.jclouds.aws.AWSResponseException: request POST
https://ec2.eu-west-1.amazonaws.com/ HTTP/1.1 failed with code 400, error:
AWSError{requestId='2300b99e-ddc0-42ab-b1ed-9d628a161be4', requestToken='null',
code='VPCResourceNotSpecified', message='The specified instance type can only
be used in a VPC. A subnet ID or network interface ID is required to carry out
the request.', context='{Response=, Errors=}'}
+ // A user can explicitly request a x1 if they are also setting up
a VPC.
+ deprecated();
I think it makes sense. I'll merge it asap
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1235#discussion_r212389076
Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)
lemmy commented on this pull request.
> @@ -290,6 +290,19 @@ private EC2HardwareBuilder hs1() {
virtualizationTypes(VirtualizationType.HVM,
VirtualizationType.PARAVIRTUAL);
return this;
}
+
+ private EC2HardwareBuilder x1() {
+ virtualizationTypes(VirtualizationType.HVM);
+
+ // TODO X1 is not deprecated, but it requires that you are using
a VPC
+ // until we have a way for hardware instances to be filtered
based on network
+ // we do NOT want X1 selected automatically.
+ // You get: org.jclouds.aws.AWSResponseException: request POST
https://ec2.eu-west-1.amazonaws.com/ HTTP/1.1 failed with code 400, error:
AWSError{requestId='2300b99e-ddc0-42ab-b1ed-9d628a161be4', requestToken='null',
code='VPCResourceNotSpecified', message='The specified instance type can only
be used in a VPC. A subnet ID or network interface ID is required to carry out
the request.', context='{Response=, Errors=}'}
+ // A user can explicitly request a x1 if they are also setting up
a VPC.
+ deprecated();
May I ask to split the discussion about the deprecation - since it also applies
to the existing t2 instance type - into a separate issue? I wait for the x1
support to be included in snapshot builds. Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1235#discussion_r212385813
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
@alibazlamit pushed 2 commits. c7b21e6 minor build fixes d17319e minor changes -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431/files/60147d505ecf776574f4259ff00efe7cd9a0e472..d17319e16d03dc8d6b43097fda82adc4e4a9
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
@alibazlamit pushed 8 commits. 202b03e Baremetal update dd664e0 updates f5b715d Baremetal update a4dfa41 Add baremetal logic to ComputeServiceAdapter ba010cc test fix 5a027df Update code for review 9f41453 JCLOUDS-1386 1&1 Baremetal servers e4dd572 Merge branch 'oneandone-baremetal-update' of https://github.com/StackPointCloud/jclouds-labs into oneandone-baremetal-update -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431/files/1903c2ccac1f0b22a9e73a32806a44339c9748a3..e4dd5723b3113eecca52b60403fbe0cd2b5f413c
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
alibazlamit commented on this pull request.
> @@ -78,26 +81,43 @@ public ServerToNodeMetadata(Function
> fnVolume,
@Override
public NodeMetadata apply(final Server server) {
checkNotNull(server, "Null server");
+ String hardwareId = null;
DataCenter dataCenter =
api.dataCenterApi().get(server.datacenter().id());
Location location = find(locations.get(), idEquals(dataCenter.id()));
changed
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#discussion_r212283174
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
alibazlamit commented on this pull request.
> }
}
- // provision server
- Server server = null;
- Double cores = ComputeServiceUtils.getCores(hardware);
- Double ram = (double) hardware.getRam();
- if (ram < 1024) {
- ram = 0.5;
- } else {
- ram = ram / 1024;
+ //configuring Firewall rules
+ Map portsRange = getPortRangesFromList(inboundPorts);
I suggest we open a separate PR addressing any backwards concern you might have
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#discussion_r212277861
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
alibazlamit commented on this pull request.
> - SingleServerAppliance appliance =
> api.serverApplianceApi().get(image.getId());
- if (appliance.minHddSize() > volume.getSize()) {
- minHddSize = appliance.minHddSize();
- }
-}
-Hdd.CreateHdd hdd = Hdd.CreateHdd.create(minHddSize,
volume.isBootDevice());
-hdds.add(hdd);
- } catch (Exception ex) {
-throw Throwables.propagate(ex);
-
+ String imageId = image.getId();
+ Hardware hardwareModel =
generateHardwareRequest.isFlavor(hardware.getId());
+ boolean isBaremetal = hardware.getName() == null ? false :
hardware.getName().contains(baremetalModelsKey);
+ ServerAppliance workingImage;
+
+ //choose the correct image based on the server type baremetal or cloud
no need as the PR will get even more complicated to review
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#discussion_r212277695
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
alibazlamit commented on this pull request.
> @@ -179,9 +179,46 @@
return new NodeAndInitialCredentials(updateServer,
updateServer.id(), serverCredentials);
}
+ private ServerAppliance findWorkingImage(String imageId,
Types.ServerTypeCompatibility serverType) {
changed
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#discussion_r212277619
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
alibazlamit commented on this pull request.
> @@ -253,7 +253,7 @@ public static ApplianceType fromValue(String v) {
}
public enum OSImageType {
- Standard, Minimal, Personal, ISO_OS, ISO_TOOL, NULL, UNRECOGNIZED;
+ STANDARD, MINIMAL, Personal, ISO_OS, ISO_TOOL, NULL, UNRECOGNIZED;
done
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#discussion_r212277586
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
alibazlamit commented on this pull request.
> @@ -283,4 +283,22 @@ public String toString() {
return value;
}
}
+
+ public enum ServerType {
+ cloud, baremetal, UNRECOGNIZED;
done
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#discussion_r212277605
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
alibazlamit commented on this pull request.
> @@ -283,4 +283,22 @@ public String toString() {
return value;
}
}
+
+ public enum ServerType {
+ cloud, baremetal, UNRECOGNIZED;
+
+ public static ServerType fromValue(String v) {
+ return Enums.getIfPresent(ServerType.class, v).or(UNRECOGNIZED);
+ }
+
+ }
+
+ public enum ServerTypeCompatibility {
+ vps, cloud, baremetal, UNRECOGNIZED;
done
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#discussion_r212277592
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
@andreaturli a few of your comments do make sense about this PR, i will address those issues so we can move on. I don't see why i would separate Recovery Images it is a very small feature and i am not sure that will really affect reviewing the PR. In my opinion i think that most of the things that you are asking me to change will make reviewing this PR difficult, like changing firewall policies and moving few lines of code into a separate method, changes like that made this PR look messy and increase the diff. I agree with you about being committed to jClouds best practices, but from my experience this is not the right PR to go back and review things that were already accepted by jClouds. I have addressed all the small changes that make sense, i can post the live test results yet again.I hope you agree with me about closing this PR before its gets even worst -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-415386348
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
alibazlamit commented on this pull request.
> }
@Override
public void suspendNode(String id) {
waitServerUntilAvailable.apply(getNode(id));
- api.serverApi().updateStatus(id,
Server.UpdateStatus.create(Types.ServerAction.POWER_OFF,
Types.ServerActionMethod.HARDWARE));
+ api.serverApi().updateStatus(id,
Server.UpdateStatus.create(Types.ServerAction.POWER_OFF,
Types.ServerActionMethod.HARDWARE, false, null));
it will remain powered off
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#discussion_r212275678
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
alibazlamit commented on this pull request.
> }
@Override
public void resumeNode(String id) {
- api.serverApi().updateStatus(id,
Server.UpdateStatus.create(Types.ServerAction.POWER_ON,
Types.ServerActionMethod.HARDWARE));
+ api.serverApi().updateStatus(id,
Server.UpdateStatus.create(Types.ServerAction.POWER_ON,
Types.ServerActionMethod.HARDWARE, false, null));
nothing happens
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#discussion_r212275634
[jira] [Comment Edited] (JCLOUDS-1444) Outage on any endpoint in catalog blocks usage of other endpoints
[
https://issues.apache.org/jira/browse/JCLOUDS-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589805#comment-16589805
]
Ignasi Barrera edited comment on JCLOUDS-1444 at 8/23/18 8:44 AM:
--
As a workaround you can configure the {{jclouds.regions}} property with the
list of regions you want to use and jclouds should only hit those regions.
was (Author: nacx):
As a workaround you can configure the {{jclouds regions}} property with the
list of regions you want to use and jclouds should only hit those regions.
> Outage on any endpoint in catalog blocks usage of other endpoints
> -
>
> Key: JCLOUDS-1444
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1444
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-compute
>Affects Versions: 2.1.1
> Environment: OVH OpenStack
>Reporter: Gilles Coremans
>Priority: Major
> Labels: NovaComputeService, openstack, openstack-nova
>
> I was trying to create a template using the ComputeService backed by the nova
> API (I was connecting to OVH, which does not have a jClouds provider).
> However, one of their regions was down for maintenance. This caused the
> following error:
> {code:java}
> SEVERE: Cannot retry after server error, command has exceeded retry limit 5:
> [method=org.jclouds.openstack.nova.v2_0.features.ImageApi.public abstract
> org.jclouds.collect.PagedIterable
> org.jclouds.openstack.nova.v2_0.features.ImageApi.listInDetail()[],
> request=GET https://compute.bhs3.cloud.ovh.net/v2/[tenant]/images/detail
> HTTP/1.1{code}
> I feel that jClouds shold handle this case gracefully and simply skip the
> offending API, rather than failing with NullPointerExceptions and making it
> impossible to create templates as long as any endpoint is down for whatever
> reason.
> This is the reply one gets when querying the given URL directly:
> {code:java}
> $ curl https://compute.bhs3.cloud.ovh.net/v2/[tenant]/images/detail
> curl: (52) Empty reply from server
> {code}
> I verified on OVH's site that this region was indeed down for maintenance:
> [http://travaux.ovh.net/?do=details&id=32795&PHPSESSID=b0747f889c42d0b97fedeb393cc16b0e|http://travaux.ovh.net/?do=details&id=32795&PHPSESSID=b0747f889c42d0b97fedeb393cc16b0e)]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JCLOUDS-1444) Outage on any endpoint in catalog blocks usage of other endpoints
[
https://issues.apache.org/jira/browse/JCLOUDS-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589805#comment-16589805
]
Ignasi Barrera commented on JCLOUDS-1444:
-
As a workaround you can configure the {{jclouds regions}} property with the
list of regions you want to use and jclouds should only hit those regions.
> Outage on any endpoint in catalog blocks usage of other endpoints
> -
>
> Key: JCLOUDS-1444
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1444
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-compute
>Affects Versions: 2.1.1
> Environment: OVH OpenStack
>Reporter: Gilles Coremans
>Priority: Major
> Labels: NovaComputeService, openstack, openstack-nova
>
> I was trying to create a template using the ComputeService backed by the nova
> API (I was connecting to OVH, which does not have a jClouds provider).
> However, one of their regions was down for maintenance. This caused the
> following error:
> {code:java}
> SEVERE: Cannot retry after server error, command has exceeded retry limit 5:
> [method=org.jclouds.openstack.nova.v2_0.features.ImageApi.public abstract
> org.jclouds.collect.PagedIterable
> org.jclouds.openstack.nova.v2_0.features.ImageApi.listInDetail()[],
> request=GET https://compute.bhs3.cloud.ovh.net/v2/[tenant]/images/detail
> HTTP/1.1{code}
> I feel that jClouds shold handle this case gracefully and simply skip the
> offending API, rather than failing with NullPointerExceptions and making it
> impossible to create templates as long as any endpoint is down for whatever
> reason.
> This is the reply one gets when querying the given URL directly:
> {code:java}
> $ curl https://compute.bhs3.cloud.ovh.net/v2/[tenant]/images/detail
> curl: (52) Empty reply from server
> {code}
> I verified on OVH's site that this region was indeed down for maintenance:
> [http://travaux.ovh.net/?do=details&id=32795&PHPSESSID=b0747f889c42d0b97fedeb393cc16b0e|http://travaux.ovh.net/?do=details&id=32795&PHPSESSID=b0747f889c42d0b97fedeb393cc16b0e)]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
