[GitHub] [jclouds] nacx commented on a change in pull request #27: JCLOUDS-1497: Fix checkstyle-suppressions for jcloud-labs

2019-05-07 Thread GitBox
nacx commented on a change in pull request #27: JCLOUDS-1497: Fix 
checkstyle-suppressions for jcloud-labs
URL: https://github.com/apache/jclouds/pull/27#discussion_r281929022
 
 

 ##
 File path: resources/checkstyle.xml
 ##
 @@ -48,7 +48,7 @@
 
 
 
-
+   
 
 Review comment:
   Right. I ran a local build and only in `core` there were more than 40 
violations. I fixed them, then found the same in another project... So I agree 
the value this check provides is close to zero and I think removing it is OK.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [jclouds] gaul commented on a change in pull request #27: JCLOUDS-1497: Fix checkstyle-suppressions for jcloud-labs

2019-05-07 Thread GitBox
gaul commented on a change in pull request #27: JCLOUDS-1497: Fix 
checkstyle-suppressions for jcloud-labs
URL: https://github.com/apache/jclouds/pull/27#discussion_r281874730
 
 

 ##
 File path: resources/checkstyle.xml
 ##
 @@ -48,7 +48,7 @@
 
 
 
-
+   
 
 Review comment:
   This check should find redundant modifiers like `public` in interfaces, not 
static imports.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Jenkins build is back to normal : jclouds-labs-openstack #36

2019-05-07 Thread Apache Jenkins Server
See 




[GitHub] [jclouds-labs-openstack] nacx merged pull request #1: Fix checkstyle violations

2019-05-07 Thread GitBox
nacx merged pull request #1: Fix checkstyle violations
URL: https://github.com/apache/jclouds-labs-openstack/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [jclouds-labs-openstack] nacx opened a new pull request #1: Fix checkstyle violations

2019-05-07 Thread GitBox
nacx opened a new pull request #1: Fix checkstyle violations
URL: https://github.com/apache/jclouds-labs-openstack/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Jenkins build is back to normal : jclouds-labs-aws #35

2019-05-07 Thread Apache Jenkins Server
See 



Build failed in Jenkins: jclouds-labs-openstack #35

2019-05-07 Thread Apache Jenkins Server
See 

--
[...truncated 241.99 KB...]
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 61 implicit excludes (use -debug for more details).
[INFO] Exclude: **/src/test/resources/**/*.sh
[INFO] Exclude: **/src/test/resources/**/*.bat
[INFO] Exclude: **/src/test/resources/**/*.cmd
[INFO] Exclude: **/src/test/resources/**/*.txt
[INFO] Exclude: **/src/test/resources/**/*.gz
[INFO] Exclude: **/src/test/resources/**/*.xml
[INFO] Exclude: **/src/test/resources/**/*.crt
[INFO] Exclude: src/test/resources/html/*.html
[INFO] Exclude: **/services/*LoggingModule
[INFO] Exclude: **/services/*ApiMetadata
[INFO] Exclude: **/services/*ProviderMetadata
[INFO] Exclude: **/LICENSE.txt
[INFO] Exclude: **/header.txt
[INFO] Exclude: **/NOTICE.txt
[INFO] Exclude: **/DISCLAIMER
[INFO] Exclude: **/BUILD.txt
[INFO] Exclude: **/CHANGES.txt
[INFO] Exclude: **/README.md
[INFO] Exclude: **/README.txt
[INFO] Exclude: **/DEPENDENCIES
[INFO] Exclude: **/CONTRIBUTING.md
[INFO] Exclude: **/*json
[INFO] Exclude: **/*readme
[INFO] Exclude: **/test
[INFO] Exclude: **/test.pub
[INFO] Exclude: **/src/test/resources/**/ssh-*.pub
[INFO] Exclude: **/target/**
[INFO] Exclude: **/test-output/**
[INFO] Exclude: **/bin/**
[INFO] Exclude: **/.settings/**
[INFO] Exclude: **/.classpath
[INFO] Exclude: **/.dir-locals.el
[INFO] Exclude: **/.project
[INFO] Exclude: **/.idea/**
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/*.eml
[INFO] Exclude: **/*.ipr
[INFO] Exclude: **/*.iws
[INFO] Exclude: **/*.DS_STORE
[INFO] Exclude: **/TAGS
[INFO] Exclude: **/.metadata/**
[INFO] Exclude: **/atlassian-ide-plugin.xml
[INFO] Exclude: **/.DS_Store
[INFO] Exclude: .mailmap
[INFO] Exclude: .git/**
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.gitattributes
[INFO] Exclude: **/.java-version
[INFO] Exclude: **/modernizer_exclusions.txt
[INFO] Exclude: **/.factorypath
[INFO] Exclude: **/.apt_generated/**
[INFO] Exclude: **/.checkstyle
[INFO] Exclude: nb-configuration.xml
[INFO] Exclude: nbactions.xml
[INFO] Exclude: .repository/**
[INFO] Exclude: gc.log
[INFO] 44 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 44 licenses.
[INFO] 
[INFO] --- maven-jar-plugin:2.4:test-jar (default) @ rackspace-autoscale ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-javadoc-plugin:2.9:jar (javadoc) @ rackspace-autoscale ---
[INFO] Toolchain in javadoc-plugin: JDK[/home/jenkins/tools/java/latest1.7/]
[INFO] 
14 warnings
[WARNING] Javadoc Warnings
[WARNING] 
:40:
 warning - Tag @see: can't find getWebhooks() in 
org.jclouds.rackspace.autoscale.v1.domain.CreateWebhook
[WARNING] 
:75:
 warning - Tag @see: can't find type(String) in 
org.jclouds.rackspace.autoscale.v1.domain.CreateScalingPolicy.Builder
[WARNING] 
:92:
 warning - Tag @see: can't find target(int) in 
org.jclouds.rackspace.autoscale.v1.domain.CreateScalingPolicy.Builder
[WARNING] 
:101:
 warning - Tag @see: can't find targetType(int) in 
org.jclouds.rackspace.autoscale.v1.domain.CreateScalingPolicy.Builder
[WARNING] 
:381:
 warning - Tag @see: reference not found: 
ScalingPolicy.Builder#cronSchedule(String)
[WARNING] 
:386:
 warning - Tag @see: reference not found: 
ScalingPolicy.Builder#atSchedule(String)
[WARNING] 
:99:
 warning - Tag @see:illegal character: "60" in 
"GroupConfiguration.Builder#metadata(Map)"
[WARNING] 
:99:
 warning - Tag @see:illegal character: "62" in 

Jenkins build is back to normal : jclouds-labs #48

2019-05-07 Thread Apache Jenkins Server
See 




[jira] [Updated] (JCLOUDS-1497) Fix jclouds-labs after JCLOUDS-1496

2019-05-07 Thread Ignasi Barrera (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignasi Barrera updated JCLOUDS-1497:

Component/s: jclouds-core

> Fix jclouds-labs after JCLOUDS-1496
> ---
>
> Key: JCLOUDS-1497
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1497
> Project: jclouds
>  Issue Type: Task
>  Components: jclouds-core
>Reporter: Olaf Flebbe
>Priority: Major
> Fix For: 2.2.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> See https://builds.apache.org/job/jclouds-labs/46/
> In order to reproduce run in jclouds-labs
> {code}
>  mvn -DskipTests  install  -U -e -Psrc,doc,jenkins
> {code}
> checkstyle-suppressions.xml  is not found in jclouds-labs. checkstyle.xml is 
> found because it is included in jclouds-resources.jar. Adding 
> checkstyle-suppressions to jclouds-resources did not work either:
> checkstyle-6.1.1 does load supressions from the class path, but IMO 
> incorrectly (see 
> https://github.com/checkstyle/checkstyle/blob/checkstyle-6.1.1/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionsLoader.java
>  )
> {code}
> // check to see if the file is in the classpath
> try {
> final URL configUrl = SuppressionsLoader.class
> .getResource(aFilename);
> if (configUrl == null) {
> throw new FileNotFoundException(aFilename);
> }
> uri = configUrl.toURI();
>  {code}
> This won't load stuff from jclouds-resources.jar on the classpath, but 
> resources from checkstyle itself.
> Even using current checkstyle will not work, since this code has only been 
> refactored but func-wise not altered.
> So we have only a limited number of options (beyond fixing checkstyle).
> # Add the file/dir resources/checkstyle-suppressions.xml to jclouds (having 
> an ugly dependency) 
> # Remove the check triggering the checkstyle problem.
> The check triggering the problem where we need the suppressions for, is the 
> "header" module checking for the presence of the proper apache license header 
> in each java file. 
> May I suggest to remove the "header" check, since it is already covered by 
> the apache-rat tool anyway? (Problem arises because some autogenerated 
> transient code  does not include the ASF license header.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (JCLOUDS-1497) Fix jclouds-labs after JCLOUDS-1496

2019-05-07 Thread Ignasi Barrera (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignasi Barrera resolved JCLOUDS-1497.
-
Resolution: Fixed

> Fix jclouds-labs after JCLOUDS-1496
> ---
>
> Key: JCLOUDS-1497
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1497
> Project: jclouds
>  Issue Type: Task
>  Components: jclouds-core
>Reporter: Olaf Flebbe
>Priority: Major
> Fix For: 2.2.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> See https://builds.apache.org/job/jclouds-labs/46/
> In order to reproduce run in jclouds-labs
> {code}
>  mvn -DskipTests  install  -U -e -Psrc,doc,jenkins
> {code}
> checkstyle-suppressions.xml  is not found in jclouds-labs. checkstyle.xml is 
> found because it is included in jclouds-resources.jar. Adding 
> checkstyle-suppressions to jclouds-resources did not work either:
> checkstyle-6.1.1 does load supressions from the class path, but IMO 
> incorrectly (see 
> https://github.com/checkstyle/checkstyle/blob/checkstyle-6.1.1/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionsLoader.java
>  )
> {code}
> // check to see if the file is in the classpath
> try {
> final URL configUrl = SuppressionsLoader.class
> .getResource(aFilename);
> if (configUrl == null) {
> throw new FileNotFoundException(aFilename);
> }
> uri = configUrl.toURI();
>  {code}
> This won't load stuff from jclouds-resources.jar on the classpath, but 
> resources from checkstyle itself.
> Even using current checkstyle will not work, since this code has only been 
> refactored but func-wise not altered.
> So we have only a limited number of options (beyond fixing checkstyle).
> # Add the file/dir resources/checkstyle-suppressions.xml to jclouds (having 
> an ugly dependency) 
> # Remove the check triggering the checkstyle problem.
> The check triggering the problem where we need the suppressions for, is the 
> "header" module checking for the presence of the proper apache license header 
> in each java file. 
> May I suggest to remove the "header" check, since it is already covered by 
> the apache-rat tool anyway? (Problem arises because some autogenerated 
> transient code  does not include the ASF license header.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCLOUDS-1497) Fix jclouds-labs after JCLOUDS-1496

2019-05-07 Thread Ignasi Barrera (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignasi Barrera updated JCLOUDS-1497:

Fix Version/s: 2.2.0

> Fix jclouds-labs after JCLOUDS-1496
> ---
>
> Key: JCLOUDS-1497
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1497
> Project: jclouds
>  Issue Type: Task
>Reporter: Olaf Flebbe
>Priority: Major
> Fix For: 2.2.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> See https://builds.apache.org/job/jclouds-labs/46/
> In order to reproduce run in jclouds-labs
> {code}
>  mvn -DskipTests  install  -U -e -Psrc,doc,jenkins
> {code}
> checkstyle-suppressions.xml  is not found in jclouds-labs. checkstyle.xml is 
> found because it is included in jclouds-resources.jar. Adding 
> checkstyle-suppressions to jclouds-resources did not work either:
> checkstyle-6.1.1 does load supressions from the class path, but IMO 
> incorrectly (see 
> https://github.com/checkstyle/checkstyle/blob/checkstyle-6.1.1/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionsLoader.java
>  )
> {code}
> // check to see if the file is in the classpath
> try {
> final URL configUrl = SuppressionsLoader.class
> .getResource(aFilename);
> if (configUrl == null) {
> throw new FileNotFoundException(aFilename);
> }
> uri = configUrl.toURI();
>  {code}
> This won't load stuff from jclouds-resources.jar on the classpath, but 
> resources from checkstyle itself.
> Even using current checkstyle will not work, since this code has only been 
> refactored but func-wise not altered.
> So we have only a limited number of options (beyond fixing checkstyle).
> # Add the file/dir resources/checkstyle-suppressions.xml to jclouds (having 
> an ugly dependency) 
> # Remove the check triggering the checkstyle problem.
> The check triggering the problem where we need the suppressions for, is the 
> "header" module checking for the presence of the proper apache license header 
> in each java file. 
> May I suggest to remove the "header" check, since it is already covered by 
> the apache-rat tool anyway? (Problem arises because some autogenerated 
> transient code  does not include the ASF license header.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCLOUDS-1496) Update maven-compiler-plugin for increased JDK compatibility

2019-05-07 Thread Ignasi Barrera (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignasi Barrera updated JCLOUDS-1496:

Component/s: jclouds-core

> Update maven-compiler-plugin for increased JDK compatibility 
> -
>
> Key: JCLOUDS-1496
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1496
> Project: jclouds
>  Issue Type: Task
>  Components: jclouds-core
>Reporter: Olaf Flebbe
>Priority: Major
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> The maven-compiler-plugin is referenced in the wrong clause of the pom file.
> It should be within .
> (See for instance 
> https://maven.apache.org/plugins/maven-compiler-plugin/usage.html )
> Otherwise you will see Nullptr Exceptions for instance with JDK11.
> For now I propose to only move the plugin and use current version 3.8.0. 
> Increasing the errorprone module version will trigger a lot of diagnostics in 
> errorprone plugins, which should be dealt seperately.
> Doublechecked: Still compiles with java 1.8 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (JCLOUDS-1496) Update maven-compiler-plugin for increased JDK compatibility

2019-05-07 Thread Ignasi Barrera (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignasi Barrera resolved JCLOUDS-1496.
-
Resolution: Fixed

> Update maven-compiler-plugin for increased JDK compatibility 
> -
>
> Key: JCLOUDS-1496
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1496
> Project: jclouds
>  Issue Type: Task
>  Components: jclouds-core
>Reporter: Olaf Flebbe
>Priority: Major
> Fix For: 2.2.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> The maven-compiler-plugin is referenced in the wrong clause of the pom file.
> It should be within .
> (See for instance 
> https://maven.apache.org/plugins/maven-compiler-plugin/usage.html )
> Otherwise you will see Nullptr Exceptions for instance with JDK11.
> For now I propose to only move the plugin and use current version 3.8.0. 
> Increasing the errorprone module version will trigger a lot of diagnostics in 
> errorprone plugins, which should be dealt seperately.
> Doublechecked: Still compiles with java 1.8 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCLOUDS-1496) Update maven-compiler-plugin for increased JDK compatibility

2019-05-07 Thread Ignasi Barrera (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignasi Barrera updated JCLOUDS-1496:

Fix Version/s: 2.2.0

> Update maven-compiler-plugin for increased JDK compatibility 
> -
>
> Key: JCLOUDS-1496
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1496
> Project: jclouds
>  Issue Type: Task
>  Components: jclouds-core
>Reporter: Olaf Flebbe
>Priority: Major
> Fix For: 2.2.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> The maven-compiler-plugin is referenced in the wrong clause of the pom file.
> It should be within .
> (See for instance 
> https://maven.apache.org/plugins/maven-compiler-plugin/usage.html )
> Otherwise you will see Nullptr Exceptions for instance with JDK11.
> For now I propose to only move the plugin and use current version 3.8.0. 
> Increasing the errorprone module version will trigger a lot of diagnostics in 
> errorprone plugins, which should be dealt seperately.
> Doublechecked: Still compiles with java 1.8 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Jenkins build is back to normal : jclouds-cli #70

2019-05-07 Thread Apache Jenkins Server
See 



[jira] [Commented] (JCLOUDS-1497) Fix jclouds-labs after JCLOUDS-1496

2019-05-07 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/JCLOUDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834594#comment-16834594
 ] 

ASF subversion and git services commented on JCLOUDS-1497:
--

Commit b05ab8ee4b84f17ef59631c2f9d48269a54eac4c in jclouds-labs's branch 
refs/heads/master from Olaf Flebbe
[ https://gitbox.apache.org/repos/asf?p=jclouds-labs.git;h=b05ab8e ]

JCLOUDS-1497: Fix checkstyle violations (#3)



> Fix jclouds-labs after JCLOUDS-1496
> ---
>
> Key: JCLOUDS-1497
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1497
> Project: jclouds
>  Issue Type: Task
>Reporter: Olaf Flebbe
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> See https://builds.apache.org/job/jclouds-labs/46/
> In order to reproduce run in jclouds-labs
> {code}
>  mvn -DskipTests  install  -U -e -Psrc,doc,jenkins
> {code}
> checkstyle-suppressions.xml  is not found in jclouds-labs. checkstyle.xml is 
> found because it is included in jclouds-resources.jar. Adding 
> checkstyle-suppressions to jclouds-resources did not work either:
> checkstyle-6.1.1 does load supressions from the class path, but IMO 
> incorrectly (see 
> https://github.com/checkstyle/checkstyle/blob/checkstyle-6.1.1/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionsLoader.java
>  )
> {code}
> // check to see if the file is in the classpath
> try {
> final URL configUrl = SuppressionsLoader.class
> .getResource(aFilename);
> if (configUrl == null) {
> throw new FileNotFoundException(aFilename);
> }
> uri = configUrl.toURI();
>  {code}
> This won't load stuff from jclouds-resources.jar on the classpath, but 
> resources from checkstyle itself.
> Even using current checkstyle will not work, since this code has only been 
> refactored but func-wise not altered.
> So we have only a limited number of options (beyond fixing checkstyle).
> # Add the file/dir resources/checkstyle-suppressions.xml to jclouds (having 
> an ugly dependency) 
> # Remove the check triggering the checkstyle problem.
> The check triggering the problem where we need the suppressions for, is the 
> "header" module checking for the presence of the proper apache license header 
> in each java file. 
> May I suggest to remove the "header" check, since it is already covered by 
> the apache-rat tool anyway? (Problem arises because some autogenerated 
> transient code  does not include the ASF license header.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [jclouds-labs] nacx commented on issue #3: JCLOUDS-1497: Fix checkstyle violations

2019-05-07 Thread GitBox
nacx commented on issue #3: JCLOUDS-1497: Fix checkstyle violations
URL: https://github.com/apache/jclouds-labs/pull/3#issuecomment-490015842
 
 
   Bulild will succeed when the main repo snapshots get published


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [jclouds-labs] nacx merged pull request #3: JCLOUDS-1497: Fix checkstyle violations

2019-05-07 Thread GitBox
nacx merged pull request #3: JCLOUDS-1497: Fix checkstyle violations
URL: https://github.com/apache/jclouds-labs/pull/3
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (JCLOUDS-1497) Fix jclouds-labs after JCLOUDS-1496

2019-05-07 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/JCLOUDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834586#comment-16834586
 ] 

ASF subversion and git services commented on JCLOUDS-1497:
--

Commit 92a3c68838edc47f8864e4fe539fdb25e71a3cd4 in jclouds's branch 
refs/heads/master from Olaf Flebbe
[ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=92a3c68 ]

JCLOUDS-1497: Fix checkstyle-suppressions for jcloud-labs (#27)

* Fix NoWhitespaceBefore Checkstyle Violation

* checkstyle updates: remove suppressionsfilter from checkstyle.xml

* suppressions now done in maven-checkstyle-plugin


> Fix jclouds-labs after JCLOUDS-1496
> ---
>
> Key: JCLOUDS-1497
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1497
> Project: jclouds
>  Issue Type: Task
>Reporter: Olaf Flebbe
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> See https://builds.apache.org/job/jclouds-labs/46/
> In order to reproduce run in jclouds-labs
> {code}
>  mvn -DskipTests  install  -U -e -Psrc,doc,jenkins
> {code}
> checkstyle-suppressions.xml  is not found in jclouds-labs. checkstyle.xml is 
> found because it is included in jclouds-resources.jar. Adding 
> checkstyle-suppressions to jclouds-resources did not work either:
> checkstyle-6.1.1 does load supressions from the class path, but IMO 
> incorrectly (see 
> https://github.com/checkstyle/checkstyle/blob/checkstyle-6.1.1/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionsLoader.java
>  )
> {code}
> // check to see if the file is in the classpath
> try {
> final URL configUrl = SuppressionsLoader.class
> .getResource(aFilename);
> if (configUrl == null) {
> throw new FileNotFoundException(aFilename);
> }
> uri = configUrl.toURI();
>  {code}
> This won't load stuff from jclouds-resources.jar on the classpath, but 
> resources from checkstyle itself.
> Even using current checkstyle will not work, since this code has only been 
> refactored but func-wise not altered.
> So we have only a limited number of options (beyond fixing checkstyle).
> # Add the file/dir resources/checkstyle-suppressions.xml to jclouds (having 
> an ugly dependency) 
> # Remove the check triggering the checkstyle problem.
> The check triggering the problem where we need the suppressions for, is the 
> "header" module checking for the presence of the proper apache license header 
> in each java file. 
> May I suggest to remove the "header" check, since it is already covered by 
> the apache-rat tool anyway? (Problem arises because some autogenerated 
> transient code  does not include the ASF license header.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [jclouds] nacx commented on a change in pull request #27: JCLOUDS-1497: Fix checkstyle-suppressions for jcloud-labs

2019-05-07 Thread GitBox
nacx commented on a change in pull request #27: JCLOUDS-1497: Fix 
checkstyle-suppressions for jcloud-labs
URL: https://github.com/apache/jclouds/pull/27#discussion_r281555351
 
 

 ##
 File path: resources/checkstyle.xml
 ##
 @@ -48,7 +48,7 @@
 
 
 
-
+   
 
 Review comment:
   I'm wondering why this check was not failing before. Anyway, I agree there 
is little value in this one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [jclouds] nacx merged pull request #27: JCLOUDS-1497: Fix checkstyle-suppressions for jcloud-labs

2019-05-07 Thread GitBox
nacx merged pull request #27: JCLOUDS-1497: Fix checkstyle-suppressions for 
jcloud-labs
URL: https://github.com/apache/jclouds/pull/27
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Build failed in Jenkins: jclouds-labs #47

2019-05-07 Thread Apache Jenkins Server
See 

--
[...truncated 126.08 KB...]
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot 
initialize module SuppressionFilter - Cannot set property 'file' in module 
SuppressionFilter to 'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:179)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.jvnet.hudson.maven3.launcher.Maven35Launcher.main 
(Maven35Launcher.java:130)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at jenkins.maven3.agent.Maven35Main.launch (Maven35Main.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform (UserRequest.java:212)
at hudson.remoting.UserRequest.perform (UserRequest.java:54)
at hudson.remoting.Request$2.run (Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Cannot set 
property 'file' in module SuppressionFilter to 
'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:152)
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:158)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecu

Build failed in Jenkins: jclouds-labs-openstack #34

2019-05-07 Thread Apache Jenkins Server
See 

--
[...truncated 58.68 KB...]
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot 
initialize module SuppressionFilter - Cannot set property 'file' in module 
SuppressionFilter to 'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:179)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.jvnet.hudson.maven3.launcher.Maven35Launcher.main 
(Maven35Launcher.java:130)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at jenkins.maven3.agent.Maven35Main.launch (Maven35Main.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform (UserRequest.java:212)
at hudson.remoting.UserRequest.perform (UserRequest.java:54)
at hudson.remoting.Request$2.run (Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Cannot set 
property 'file' in module SuppressionFilter to 
'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:152)
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:158)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.l

Build failed in Jenkins: jclouds-labs-aws #34

2019-05-07 Thread Apache Jenkins Server
See 

--
[...truncated 58.48 KB...]
at hudson.remoting.Request$2.run (Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot 
initialize module SuppressionFilter - Cannot set property 'file' in module 
SuppressionFilter to 'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:179)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.jvnet.hudson.maven3.launcher.Maven35Launcher.main 
(Maven35Launcher.java:130)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at jenkins.maven3.agent.Maven35Main.launch (Maven35Main.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform (UserRequest.java:212)
at hudson.remoting.UserRequest.perform (UserRequest.java:54)
at hudson.remoting.Request$2.run (Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Cannot set 
property 'file' in module SuppressionFilter to 
'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:152)
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:158)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apach

[jira] [Comment Edited] (JCLOUDS-1166) Remove uses of the 'com.google.gson.internal' package

2019-05-07 Thread Ignasi Barrera (JIRA)


[ 
https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834504#comment-16834504
 ] 

Ignasi Barrera edited comment on JCLOUDS-1166 at 5/7/19 8:33 AM:
-

The main issue here is that simply upgrading will break jclouds in OSGi, as the 
classes we use in the {{internal}} packages won't be available there.

So, we have to make the call for the fix:

* Now jclouds-karaf and jclouds-cli will be managed by the Apache Karaf 
community:
** If we go for the custom bundle approach (probably something that could land 
in ServiceMix), should the Karaf team take care of it?
** If not, where should we host/maintain that bundle?
* If we are going to the copy approach, then we should copy the relevant 
classes and work towards refactoring the code so we don't need that stuff.

[~andrewp], [~gaul], [~jbonofre] thoughts?


was (Author: nacx):
The main issue here is that simply upgrading will break jclouds in OSGi, as the 
classes we use in the {{internal}} packages won't be available there.

So, we have to make the call for the fix:

* Now jclouds-karaf and jclouds-cli will be managed by the Apache Karaf 
community:
** If we go for the custom bundle approach (probably something that could land 
in ServiceMix), should the Karaf team take care of it?
** If not, where should we host/maintain that bundle?
* If we are going to the copy approach, then we should copy the relevant 
classes and work towards refacotring the code so we don't need that stuff.

[~andrewp], [~gaul], [~jbonofre] thoughts?

> Remove uses of the 'com.google.gson.internal' package
> -
>
> Key: JCLOUDS-1166
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1166
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-chef, jclouds-core
>Affects Versions: 1.9.2
>Reporter: Ignasi Barrera
>Priority: Major
>  Labels: gson
>
> Starting from Gson 2.6, the {{com.google.gson.internal}} packages are no 
> longer exported in the OSGi bundles. This makes it impossible to use jclouds 
> in an OSGi environment if upgrading to such versions of Gson.
> There is no change to add the exports back for that package (see [this 
> discussion|https://github.com/google/gson/pull/916]), so we should stop using 
> those classes.
> See also: http://markmail.org/message/olgebygfgdy3hwtm



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JCLOUDS-1166) Remove uses of the 'com.google.gson.internal' package

2019-05-07 Thread Ignasi Barrera (JIRA)


[ 
https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834504#comment-16834504
 ] 

Ignasi Barrera commented on JCLOUDS-1166:
-

The main issue here is that simply upgrading will break jclouds in OSGi, as the 
classes we use in the {{internal}} packages won't be available there.

So, we have to make the call for the fix:

* Now jclouds-karaf and jclouds-cli will be managed by the Apache Karaf 
community:
** If we go for the custom bundle approach (probably something that could land 
in ServiceMix), should the Karaf team take care of it?
** If not, where should we host/maintain that bundle?
* If we are going to the copy approach, then we should copy the relevant 
classes and work towards refacotring the code so we don't need that stuff.

[~andrewp], [~gaul], [~jbonofre] thoughts?

> Remove uses of the 'com.google.gson.internal' package
> -
>
> Key: JCLOUDS-1166
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1166
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-chef, jclouds-core
>Affects Versions: 1.9.2
>Reporter: Ignasi Barrera
>Priority: Major
>  Labels: gson
>
> Starting from Gson 2.6, the {{com.google.gson.internal}} packages are no 
> longer exported in the OSGi bundles. This makes it impossible to use jclouds 
> in an OSGi environment if upgrading to such versions of Gson.
> There is no change to add the exports back for that package (see [this 
> discussion|https://github.com/google/gson/pull/916]), so we should stop using 
> those classes.
> See also: http://markmail.org/message/olgebygfgdy3hwtm



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCLOUDS-1499) Disable sonatype snapshot repository for plugins

2019-05-07 Thread Ignasi Barrera (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignasi Barrera updated JCLOUDS-1499:

Fix Version/s: 2.2.0

> Disable sonatype snapshot repository for plugins
> 
>
> Key: JCLOUDS-1499
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1499
> Project: jclouds
>  Issue Type: Task
>Affects Versions: 2.2.0
>Reporter: Olaf Flebbe
>Priority: Major
> Fix For: 2.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As far as I can see, the ossrh repository 
> (https://oss.sonatype.org/content/repositories/snapshots)
> is not needed. 
> It slows down compilation considerably.
> Lets remove the maven repository from the pom



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCLOUDS-1499) Disable sonatype snapshot repository for plugins

2019-05-07 Thread Ignasi Barrera (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignasi Barrera updated JCLOUDS-1499:

Component/s: jclouds-core

> Disable sonatype snapshot repository for plugins
> 
>
> Key: JCLOUDS-1499
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1499
> Project: jclouds
>  Issue Type: Task
>  Components: jclouds-core
>Affects Versions: 2.2.0
>Reporter: Olaf Flebbe
>Priority: Major
> Fix For: 2.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As far as I can see, the ossrh repository 
> (https://oss.sonatype.org/content/repositories/snapshots)
> is not needed. 
> It slows down compilation considerably.
> Lets remove the maven repository from the pom



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCLOUDS-1499) Disable sonatype snapshot repository for plugins

2019-05-07 Thread Ignasi Barrera (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignasi Barrera updated JCLOUDS-1499:

Affects Version/s: 2.2.0

> Disable sonatype snapshot repository for plugins
> 
>
> Key: JCLOUDS-1499
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1499
> Project: jclouds
>  Issue Type: Task
>Affects Versions: 2.2.0
>Reporter: Olaf Flebbe
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As far as I can see, the ossrh repository 
> (https://oss.sonatype.org/content/repositories/snapshots)
> is not needed. 
> It slows down compilation considerably.
> Lets remove the maven repository from the pom



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (JCLOUDS-1499) Disable sonatype snapshot repository for plugins

2019-05-07 Thread Ignasi Barrera (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignasi Barrera resolved JCLOUDS-1499.
-
Resolution: Fixed

> Disable sonatype snapshot repository for plugins
> 
>
> Key: JCLOUDS-1499
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1499
> Project: jclouds
>  Issue Type: Task
>  Components: jclouds-core
>Affects Versions: 2.2.0
>Reporter: Olaf Flebbe
>Priority: Major
> Fix For: 2.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As far as I can see, the ossrh repository 
> (https://oss.sonatype.org/content/repositories/snapshots)
> is not needed. 
> It slows down compilation considerably.
> Lets remove the maven repository from the pom



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JCLOUDS-1499) Disable sonatype snapshot repository for plugins

2019-05-07 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/JCLOUDS-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834495#comment-16834495
 ] 

ASF subversion and git services commented on JCLOUDS-1499:
--

Commit f1d4f900bf01919abaff0adb16a82aa30694c759 in jclouds's branch 
refs/heads/master from Olaf Flebbe
[ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=f1d4f90 ]

JCLOUDS-1499: Disable sonatype snapshot repository for plugins (#28)



> Disable sonatype snapshot repository for plugins
> 
>
> Key: JCLOUDS-1499
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1499
> Project: jclouds
>  Issue Type: Task
>Reporter: Olaf Flebbe
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> As far as I can see, the ossrh repository 
> (https://oss.sonatype.org/content/repositories/snapshots)
> is not needed. 
> It slows down compilation considerably.
> Lets remove the maven repository from the pom



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [jclouds] nacx merged pull request #28: JCLOUDS-1499: Disable sonatype snapshot repository for plugins

2019-05-07 Thread GitBox
nacx merged pull request #28: JCLOUDS-1499: Disable sonatype snapshot 
repository for plugins
URL: https://github.com/apache/jclouds/pull/28
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services