[jira] [Comment Edited] (OFBIZ-10696) ConcurrentModificationException in ShoppingCart.cleanUpShipGroups
[
https://issues.apache.org/jira/browse/OFBIZ-10696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713593#comment-16713593
]
Jacques Le Roux edited comment on OFBIZ-10696 at 12/8/18 6:20 PM:
--
Thanks Danny,
Actually it does not even work. My Predicate uses an iterator when actually
{{removeIf()}} uses its own iterator so I get a {{NoSuchElementException}}.
Anyway was just a quick try, I was curious if I could use an Iterator in a
Predicate for {{removeIf()}}.
I also tested your change, and no surprise it's OK.
was (Author: jacques.le.roux):
Thanks Danny,
Actually it does not even works. My Predicate use an iterator when actually
{{removeIf()}} use its own iterator so I get a {{NoSuchElementException}}.
Anyway was just a quick try, I was curious if I could use an Iterator in a
Predicate for {{removeIf()}}.
I also tested your change, and no surprise it's OK.
> ConcurrentModificationException in ShoppingCart.cleanUpShipGroups
> -
>
> Key: OFBIZ-10696
> URL: https://issues.apache.org/jira/browse/OFBIZ-10696
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Danny Trunk
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06
>
> Attachments: OFBIZ-10696.diff
>
>
> {code:java}
> java.util.ConcurrentModificationException: null
> at
> java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:966)
> ~[?:1.8.0_181]
> at java.util.LinkedList$ListItr.next(LinkedList.java:888)
> ~[?:1.8.0_181]
> at
> org.apache.ofbiz.order.shoppingcart.ShoppingCart.cleanUpShipGroups(ShoppingCart.java:2199)
> ~[ofbiz.jar:?]
> {code}
> There's a for-loop over shipInfo and a call to clear inside this loop which
> leads to a ConcurrentModificationException:
> https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java?view=markup#l2251
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10699) request map to create party content in controller.xml exists twice
Pierre Smits created OFBIZ-10699:
Summary: request map to create party content in controller.xml
exists twice
Key: OFBIZ-10699
URL: https://issues.apache.org/jira/browse/OFBIZ-10699
Project: OFBiz
Issue Type: Bug
Components: party
Affects Versions: Trunk
Reporter: Pierre Smits
In controller.xml of the Party component the following exist:
{code:java}
{code}
and
{code:java}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10231) Convert ProductServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713722#comment-16713722 ] Pierre Smits commented on OFBIZ-10231: -- Hi [~mbrohl], That question seems, at this moment in time, superfluous as the ticket shows that there is no 'Assignee' identified. Best regards, Pierre > Convert ProductServices.xml mini lang to groovy > --- > > Key: OFBIZ-10231 > URL: https://issues.apache.org/jira/browse/OFBIZ-10231 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10252) Making the use of the "button-style-2" class for backend menus consistent
[ https://issues.apache.org/jira/browse/OFBIZ-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713720#comment-16713720 ] Pierre Smits commented on OFBIZ-10252: -- Without a style guide it is hard to form an opinion on the matter. But simply replacing one undescribed/unexplained element 'button-style-2' with one other undescribed/unexplained element 'functional-button-bar' does add much value. Also, as every button bar is functional a name like 'functional-button-bar' does not help. We also have to take into consideration that style guides vary per theme (and the front-end framework applied by the theme). Currently we have the 'OFBiz' way, applied to Common-Theme with deviation/variation thereon in Bluelight, Flatgrey and Tomahawk themes and the E-commerce component themes EC_Default and Multiflex. Then we have the Bootstrap oriented RainbowStone theme. The impact downstream (on the themes, and their renderers) is inherent with changing this. > Making the use of the "button-style-2" class for backend menus consistent > - > > Key: OFBIZ-10252 > URL: https://issues.apache.org/jira/browse/OFBIZ-10252 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > > While doing some work on the backend of OFBiz, I noticed, that in some cases > the functional buttons of the application I am using are styled with the > class "button-bar button-style-2" and in some other cases are only styled > with "button-bar". > Here are some suggenstions: > * The use of the class "button-bar button-style-2" should be consistent > * The class should get another name, "button-style-2" doesn't really fit its > purpose, I would suggest to name the whole class "button-bar > functional-button-bar" > * If the class "button-style-2" is used for different buttons too, I would > suggest making a new class "functional-button-bar" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10231) Convert ProductServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713694#comment-16713694 ] Michael Brohl commented on OFBIZ-10231: --- Do you work on this, [~Dennis Balkir]? > Convert ProductServices.xml mini lang to groovy > --- > > Key: OFBIZ-10231 > URL: https://issues.apache.org/jira/browse/OFBIZ-10231 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-10187:
-
Assignee: Michael Brohl
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: 16.11.04
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> I do not see any reason to not allow class attributes in html code. There
> might be other problems with these rules but this is a showstopper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10252) Making the use of the "button-style-2" class for backend menus consistent
[ https://issues.apache.org/jira/browse/OFBIZ-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713693#comment-16713693 ] Michael Brohl commented on OFBIZ-10252: --- Hi devs, any thought on this? > Making the use of the "button-style-2" class for backend menus consistent > - > > Key: OFBIZ-10252 > URL: https://issues.apache.org/jira/browse/OFBIZ-10252 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > > While doing some work on the backend of OFBiz, I noticed, that in some cases > the functional buttons of the application I am using are styled with the > class "button-bar button-style-2" and in some other cases are only styled > with "button-bar". > Here are some suggenstions: > * The use of the class "button-bar button-style-2" should be consistent > * The class should get another name, "button-style-2" doesn't really fit its > purpose, I would suggest to name the whole class "button-bar > functional-button-bar" > * If the class "button-style-2" is used for different buttons too, I would > suggest making a new class "functional-button-bar" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10322) Add Asciidoc template for plugin creation task
[ https://issues.apache.org/jira/browse/OFBIZ-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713688#comment-16713688 ] Michael Brohl commented on OFBIZ-10322: --- We'll work on that. > Add Asciidoc template for plugin creation task > -- > > Key: OFBIZ-10322 > URL: https://issues.apache.org/jira/browse/OFBIZ-10322 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Trivial > > Create a README.adoc stub and help file stub in the new format under > framework/resources/templates and use in the plugin creation task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10300) Convert Minilang to Groovy Guide into asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713690#comment-16713690 ] Michael Brohl commented on OFBIZ-10300: --- [~bjugl], can you please provide an up-to-date patch? Thanks! > Convert Minilang to Groovy Guide into asciidoc > --- > > Key: OFBIZ-10300 > URL: https://issues.apache.org/jira/browse/OFBIZ-10300 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Attachments: > OFBIZ-10300_Convert_Minilang_to_Groovy_guide_into_asciidoc.patch > > > Convert [~Dennis Balkir]s [Minilang to Groovy > Guide|https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+From+Mini+Language+to+Groovy] > into AsciiDoc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10318) Developer Manual: propose initial structure and contents
[ https://issues.apache.org/jira/browse/OFBIZ-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713689#comment-16713689 ] Michael Brohl commented on OFBIZ-10318: --- This has already been started and is in progress... > Developer Manual: propose initial structure and contents > > > Key: OFBIZ-10318 > URL: https://issues.apache.org/jira/browse/OFBIZ-10318 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Labels: asciidoc, documentation > > The developer manual should be given an initial overall structure to make it > easier for contributors to add their content. There are also many resources > in the wiki which could be mapped to the structure to move them step-by-step > to the document. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10322) Add Asciidoc template for plugin creation task
[ https://issues.apache.org/jira/browse/OFBIZ-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10322: - Assignee: Michael Brohl > Add Asciidoc template for plugin creation task > -- > > Key: OFBIZ-10322 > URL: https://issues.apache.org/jira/browse/OFBIZ-10322 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Trivial > > Create a README.adoc stub and help file stub in the new format under > framework/resources/templates and use in the plugin creation task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10326) Implement dependency from "State/Province" Field to "Country" in New Employee Form
[ https://issues.apache.org/jira/browse/OFBIZ-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10326. - Resolution: Fixed Fix Version/s: Upcoming Branch 17.12.01 Thanks Benjamin, your patch is in trunk r1848469 and backported to release branch 17.12 r1848472 > Implement dependency from "State/Province" Field to "Country" in New Employee > Form > -- > > Key: OFBIZ-10326 > URL: https://issues.apache.org/jira/browse/OFBIZ-10326 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Fix For: 17.12.01, Upcoming Branch > > Attachments: > OFBIZ-10326_org.apache.ofbiz.humanres.widget.Employee_dependentDropdown.patch > > > In OFBiz go to Facility -> Contact Information -> New Contact Information > Select "Postal Address" in the dropdown and click "create". In this form the > "State/Province" dropdown is dependant on the "Country" dropdown. Once a > country is selected the States of that country will be in the selection of > the first dropdown. This behaviour should be part of every form which has an > address as an input. The dropdown dependencies are realized with the > getDependentDropdownValues function in miscAjaxFunctions.js. > A place where this functionality is missing is in the HR section of OFBiz. > Got to HR -> Employees -> New Employee > ([https://localhost:8443/humanres/control/NewEmployee]) > Here, the "State" dropdown lists ALL states which are listed in the geo > entity. It would be nice to implement dependant dropdowns here aswell. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10698) Improve german translations for the hr component
Michael Brohl created OFBIZ-10698: - Summary: Improve german translations for the hr component Key: OFBIZ-10698 URL: https://issues.apache.org/jira/browse/OFBIZ-10698 Project: OFBiz Issue Type: Improvement Components: humanres Reporter: Michael Brohl Assignee: Michael Brohl During the tests for OFBIZ-10326 I noticed several UI labels which were not translated. This should be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10326) Implement dependency from "State/Province" Field to "Country" in New Employee Form
[ https://issues.apache.org/jira/browse/OFBIZ-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10326: -- Affects Version/s: Release Branch 17.12 > Implement dependency from "State/Province" Field to "Country" in New Employee > Form > -- > > Key: OFBIZ-10326 > URL: https://issues.apache.org/jira/browse/OFBIZ-10326 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-10326_org.apache.ofbiz.humanres.widget.Employee_dependentDropdown.patch > > > In OFBiz go to Facility -> Contact Information -> New Contact Information > Select "Postal Address" in the dropdown and click "create". In this form the > "State/Province" dropdown is dependant on the "Country" dropdown. Once a > country is selected the States of that country will be in the selection of > the first dropdown. This behaviour should be part of every form which has an > address as an input. The dropdown dependencies are realized with the > getDependentDropdownValues function in miscAjaxFunctions.js. > A place where this functionality is missing is in the HR section of OFBiz. > Got to HR -> Employees -> New Employee > ([https://localhost:8443/humanres/control/NewEmployee]) > Here, the "State" dropdown lists ALL states which are listed in the geo > entity. It would be nice to implement dependant dropdowns here aswell. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10326) Implement dependency from "State/Province" Field to "Country" in New Employee Form
[ https://issues.apache.org/jira/browse/OFBIZ-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713680#comment-16713680 ] Pierre Smits commented on OFBIZ-10326: -- Setting appropriate component (based on patch provided). > Implement dependency from "State/Province" Field to "Country" in New Employee > Form > -- > > Key: OFBIZ-10326 > URL: https://issues.apache.org/jira/browse/OFBIZ-10326 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-10326_org.apache.ofbiz.humanres.widget.Employee_dependentDropdown.patch > > > In OFBiz go to Facility -> Contact Information -> New Contact Information > Select "Postal Address" in the dropdown and click "create". In this form the > "State/Province" dropdown is dependant on the "Country" dropdown. Once a > country is selected the States of that country will be in the selection of > the first dropdown. This behaviour should be part of every form which has an > address as an input. The dropdown dependencies are realized with the > getDependentDropdownValues function in miscAjaxFunctions.js. > A place where this functionality is missing is in the HR section of OFBiz. > Got to HR -> Employees -> New Employee > ([https://localhost:8443/humanres/control/NewEmployee]) > Here, the "State" dropdown lists ALL states which are listed in the geo > entity. It would be nice to implement dependant dropdowns here aswell. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10326) Implement dependency from "State/Province" Field to "Country" in New Employee Form
[ https://issues.apache.org/jira/browse/OFBIZ-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10326: - Component/s: (was: framework) humanres > Implement dependency from "State/Province" Field to "Country" in New Employee > Form > -- > > Key: OFBIZ-10326 > URL: https://issues.apache.org/jira/browse/OFBIZ-10326 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-10326_org.apache.ofbiz.humanres.widget.Employee_dependentDropdown.patch > > > In OFBiz go to Facility -> Contact Information -> New Contact Information > Select "Postal Address" in the dropdown and click "create". In this form the > "State/Province" dropdown is dependant on the "Country" dropdown. Once a > country is selected the States of that country will be in the selection of > the first dropdown. This behaviour should be part of every form which has an > address as an input. The dropdown dependencies are realized with the > getDependentDropdownValues function in miscAjaxFunctions.js. > A place where this functionality is missing is in the HR section of OFBiz. > Got to HR -> Employees -> New Employee > ([https://localhost:8443/humanres/control/NewEmployee]) > Here, the "State" dropdown lists ALL states which are listed in the geo > entity. It would be nice to implement dependant dropdowns here aswell. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10241) orderSkipInvoice, complete an order without generating an invoice
[ https://issues.apache.org/jira/browse/OFBIZ-10241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713672#comment-16713672 ] Michael Brohl commented on OFBIZ-10241: --- Hi [~aouvrard], any chance to respond to the questions? > orderSkipInvoice, complete an order without generating an invoice > - > > Key: OFBIZ-10241 > URL: https://issues.apache.org/jira/browse/OFBIZ-10241 > Project: OFBiz > Issue Type: Improvement >Reporter: Antoine Ouvrard >Priority: Minor > Attachments: OFBIZ-10241-order-skip-invoice-parameter.patch > > > In some case, we need to delay billing at the end of the month for > example. > But to complete the order we need to disable triggering the > invoice generation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10326) Implement dependency from "State/Province" Field to "Country" in New Employee Form
[ https://issues.apache.org/jira/browse/OFBIZ-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10326: - Assignee: Michael Brohl (was: Benjamin Jugl) > Implement dependency from "State/Province" Field to "Country" in New Employee > Form > -- > > Key: OFBIZ-10326 > URL: https://issues.apache.org/jira/browse/OFBIZ-10326 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-10326_org.apache.ofbiz.humanres.widget.Employee_dependentDropdown.patch > > > In OFBiz go to Facility -> Contact Information -> New Contact Information > Select "Postal Address" in the dropdown and click "create". In this form the > "State/Province" dropdown is dependant on the "Country" dropdown. Once a > country is selected the States of that country will be in the selection of > the first dropdown. This behaviour should be part of every form which has an > address as an input. The dropdown dependencies are realized with the > getDependentDropdownValues function in miscAjaxFunctions.js. > A place where this functionality is missing is in the HR section of OFBiz. > Got to HR -> Employees -> New Employee > ([https://localhost:8443/humanres/control/NewEmployee]) > Here, the "State" dropdown lists ALL states which are listed in the geo > entity. It would be nice to implement dependant dropdowns here aswell. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10469) Improve Accounting - AR container structure
[ https://issues.apache.org/jira/browse/OFBIZ-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713678#comment-16713678 ] Pierre Smits commented on OFBIZ-10469: -- This implementation is a work-around, and circumvents the actual issue. The problem is not with how the screens are rendered by the referencing portal page , but rather with how the portal-page container is rendered through the HTMLScreenMacroLibrary.ftl of the theme. This may also be impacted by MacroScreenRenderer.java and/or StringScreenRenderer.java. > Improve Accounting - AR container structure > --- > > Key: OFBIZ-10469 > URL: https://issues.apache.org/jira/browse/OFBIZ-10469 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: accounting-ar_main-page.patch > > > I found some structural differences while looking on accounting-ar -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713677#comment-16713677 ] Michael Brohl commented on OFBIZ-10331: --- Hi [~Dennis Balkir], please check and update the two patches so we can close this issue, thanks! > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10333) Improve Party
[ https://issues.apache.org/jira/browse/OFBIZ-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713674#comment-16713674 ] Michael Brohl commented on OFBIZ-10333: --- Hi [~Dennis Balkir], can you please check Deepak's comment? Thank you! > Improve Party > - > > Key: OFBIZ-10333 > URL: https://issues.apache.org/jira/browse/OFBIZ-10333 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-party.template-party.AddCheckForParty.patch, > OFBIZ-10221-party.template-party.profileBlocks.ProductStores.patch, > OFBIZ-10221-party.template-party.profileBlocks.Visits.patch, > OFBIZ-10221-party.template.party.EditShoppingList.patch, > OFBIZ-10221-party.template.party.profileblocks.Attributes.patch, > OFBIZ-10221-party.template.party.profileblocks.Contact.patch, > OFBIZ-10221-party.template.party.profileblocks.Content.patch, > OFBIZ-10221-party.template.party.profileblocks.ContentList.patch, > OFBIZ-10221-party.template.party.profileblocks.Notes.patch, > OFBIZ-10221-party.template.party.profileblocks.UserLogin.patch > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713673#comment-16713673
]
Michael Brohl commented on OFBIZ-10688:
---
Hi Benjamin,
can you explain how the patch fixes the bug? Thank you!
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-10688:
-
Assignee: Michael Brohl (was: Benjamin Jugl)
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10607: - Assignee: Michael Brohl > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713671#comment-16713671 ] Michael Brohl commented on OFBIZ-10607: --- +1 for removing the code. Any objections? > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10697) ControlEventListener improvement: check debug level
Michael Brohl created OFBIZ-10697: - Summary: ControlEventListener improvement: check debug level Key: OFBIZ-10697 URL: https://issues.apache.org/jira/browse/OFBIZ-10697 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk, Release Branch 17.12 Reporter: Michael Brohl Assignee: Michael Brohl The Debug.logXXX statements should be preceded with a check for the debug level to optimize the performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10330) ControlEventListener - Change Log-Level
[ https://issues.apache.org/jira/browse/OFBIZ-10330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10330. - Resolution: Implemented Fix Version/s: Upcoming Branch 17.12.01 Thanks Benjamin, your patch is in trunk r1848467. I also backported to release branch 17.12 in r1848468. It's not a bug but annyoing in the logs fpr productive systems. > ControlEventListener - Change Log-Level > --- > > Key: OFBIZ-10330 > URL: https://issues.apache.org/jira/browse/OFBIZ-10330 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Fix For: 17.12.01, Upcoming Branch > > Attachments: OFBIZ-10330_ControlEventListener_ChangeLogLevel.patch > > > the Log-Level of the Message "Could not find visit value object in > session." currently is "warning". It should be set to info. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10330) ControlEventListener - Change Log-Level
[ https://issues.apache.org/jira/browse/OFBIZ-10330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10330: -- Affects Version/s: Release Branch 17.12 > ControlEventListener - Change Log-Level > --- > > Key: OFBIZ-10330 > URL: https://issues.apache.org/jira/browse/OFBIZ-10330 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-10330_ControlEventListener_ChangeLogLevel.patch > > > the Log-Level of the Message "Could not find visit value object in > session." currently is "warning". It should be set to info. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10330) ControlEventListener - Change Log-Level
[ https://issues.apache.org/jira/browse/OFBIZ-10330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10330: -- Issue Type: Improvement (was: Bug) > ControlEventListener - Change Log-Level > --- > > Key: OFBIZ-10330 > URL: https://issues.apache.org/jira/browse/OFBIZ-10330 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-10330_ControlEventListener_ChangeLogLevel.patch > > > the Log-Level of the Message "Could not find visit value object in > session." currently is "warning". It should be set to info. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10464) Improve Accounting - AP container structure
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10464. - Resolution: Fixed Fix Version/s: Upcoming Branch Thanks Dennis, your patch is in trunk r1848461 > Improve Accounting - AP container structure > --- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10464) Improve Accounting - AP container structure
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10464: -- Summary: Improve Accounting - AP container structure (was: Improve Accounting -AP) > Improve Accounting - AP container structure > --- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10469) Improve Accounting - AR container structure
[ https://issues.apache.org/jira/browse/OFBIZ-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10469. - Resolution: Fixed Fix Version/s: Upcoming Branch Thanks Dennis, your patch is in trunk r1848459 > Improve Accounting - AR container structure > --- > > Key: OFBIZ-10469 > URL: https://issues.apache.org/jira/browse/OFBIZ-10469 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: accounting-ar_main-page.patch > > > I found some structural differences while looking on accounting-ar -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10469) Improve Accounting - AR container structure
[ https://issues.apache.org/jira/browse/OFBIZ-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10469: -- Summary: Improve Accounting - AR container structure (was: Improve Accounting - AR) > Improve Accounting - AR container structure > --- > > Key: OFBIZ-10469 > URL: https://issues.apache.org/jira/browse/OFBIZ-10469 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Attachments: accounting-ar_main-page.patch > > > I found some structural differences while looking on accounting-ar -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10469) Improve Accounting - AR
[ https://issues.apache.org/jira/browse/OFBIZ-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10469: -- Affects Version/s: Release Branch 17.12 Trunk > Improve Accounting - AR > --- > > Key: OFBIZ-10469 > URL: https://issues.apache.org/jira/browse/OFBIZ-10469 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Attachments: accounting-ar_main-page.patch > > > I found some structural differences while looking on accounting-ar -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10476) Fix / Remove Compdoc?
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713642#comment-16713642 ] Michael Brohl commented on OFBIZ-10476: --- I've started a discussion in the dev list, see https://lists.apache.org/thread.html/1a0a3b84f81c9b1692161f3337df3016a9e86137330bfb2ff72d4ca4@%3Cdev.ofbiz.apache.org%3E > Fix / Remove Compdoc? > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Bug > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10533) Seed data sequence bug regarding "MIDNIGHT_DAILY" TemporalExpression
[ https://issues.apache.org/jira/browse/OFBIZ-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10533. - Resolution: Fixed Fix Version/s: Upcoming Branch 16.11.06 17.12.01 Thanks Martin, your fix is in trunk r1848449 and backported to release branch 17.12 r1848450 release branch 16.11 r1848451 > Seed data sequence bug regarding "MIDNIGHT_DAILY" TemporalExpression > > > Key: OFBIZ-10533 > URL: https://issues.apache.org/jira/browse/OFBIZ-10533 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Minor > Fix For: 17.12.01, 16.11.06, Upcoming Branch > > Attachments: OFBIZ-10533_TemporalExpression-MIDNIGHT_DAILY.patch > > > Module framework/service: > The TemporalExpression for "MIDNIGHT_DAILY" has to be loaded as seed data > instead of initial-seed data to be available for other seed-initial usages of > this TemporalExpression. > For example the "cleanSyncRemoveInfo" service is scheduled via seed-inital > data in EntityScheduledServices.xml using this TemporalExpression, which is > not available while initializing a fresh database because it is loaded as > initial-seed data from framework/services/data/SchedulesServices.xml after > EntityScheduledServices.xml. > So i moved this TemporalExpression to the other TemporalExpression seed data > in ServiceSeedData.xml. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10533) Seed data sequence bug regarding "MIDNIGHT_DAILY" TemporalExpression
[ https://issues.apache.org/jira/browse/OFBIZ-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10533: -- Affects Version/s: Release Branch 17.12 Release Branch 16.11 > Seed data sequence bug regarding "MIDNIGHT_DAILY" TemporalExpression > > > Key: OFBIZ-10533 > URL: https://issues.apache.org/jira/browse/OFBIZ-10533 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-10533_TemporalExpression-MIDNIGHT_DAILY.patch > > > Module framework/service: > The TemporalExpression for "MIDNIGHT_DAILY" has to be loaded as seed data > instead of initial-seed data to be available for other seed-initial usages of > this TemporalExpression. > For example the "cleanSyncRemoveInfo" service is scheduled via seed-inital > data in EntityScheduledServices.xml using this TemporalExpression, which is > not available while initializing a fresh database because it is loaded as > initial-seed data from framework/services/data/SchedulesServices.xml after > EntityScheduledServices.xml. > So i moved this TemporalExpression to the other TemporalExpression seed data > in ServiceSeedData.xml. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10642) Fallthrough in switch-case of org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.java
[ https://issues.apache.org/jira/browse/OFBIZ-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10642. - Resolution: Fixed Fix Version/s: Upcoming Branch 17.12.01 Thanks Benjamin, your fix is in trunk r1848447 release branch 17.12 r1848448 No backport needed for 16.11 because it ise if/else statments. > Fallthrough in switch-case of > org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.java > -- > > Key: OFBIZ-10642 > URL: https://issues.apache.org/jira/browse/OFBIZ-10642 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Fix For: 17.12.01, Upcoming Branch > > Attachments: OFBIZ-10642_fallthrough_in_switchcase.patch > > > org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.GatewayResponse(InputStream, > GatewayRequest): > Line 157 et. seq.: > Breaks missing in switch case. > As this particular one replaces an if-else construct, these should be added. > I will provide a patch within a short time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10642) Fallthrough in switch-case of org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.java
[ https://issues.apache.org/jira/browse/OFBIZ-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10642: -- Affects Version/s: Release Branch 17.12 > Fallthrough in switch-case of > org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.java > -- > > Key: OFBIZ-10642 > URL: https://issues.apache.org/jira/browse/OFBIZ-10642 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-10642_fallthrough_in_switchcase.patch > > > org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.GatewayResponse(InputStream, > GatewayRequest): > Line 157 et. seq.: > Breaks missing in switch case. > As this particular one replaces an if-else construct, these should be added. > I will provide a patch within a short time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10653) Missing nullcheck in service createContactListParty
[
https://issues.apache.org/jira/browse/OFBIZ-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-10653.
-
Resolution: Fixed
Fix Version/s: Upcoming Branch
16.11.06
17.12.01
Thanks Dennis,
your fix is in trunk r1848444
and backported in
release branch 17.12 r1848445
release branch 16.11 r1848446
> Missing nullcheck in service createContactListParty
> ---
>
> Key: OFBIZ-10653
> URL: https://issues.apache.org/jira/browse/OFBIZ-10653
> Project: OFBiz
> Issue Type: Bug
> Components: marketing
>Affects Versions: Trunk, 16.11.05, Release Branch 17.12
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 17.12.01, 16.11.06, Upcoming Branch
>
> Attachments: OFBIZ-10653_ContactListServices.patch
>
>
> This service searches for the primary email-address of the given party, if it
> doesn't have a preffered contact mechanism ID in its parameters.
> For this it uses the service {{getPartyEmail}} which, as a result, can
> deliver an optional email-address.
> This is where the problem is: the result is optional.
> Without any further checks, the result, empty or not, will be used to call
> another service called {{createContactListPartyStatus}}. For this service the
> field {{preferredContactMechId}} is a non optional input value, which is set
> before from the result of {{getPartyEmail}}.
> If the party email could not be found, because a party group is added, or
> simply because the party has no mail given for some reason, this service call
> will result in an error because of missing parameters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10653) Missing nullcheck in service createContactListParty
[
https://issues.apache.org/jira/browse/OFBIZ-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-10653:
--
Affects Version/s: Release Branch 17.12
16.11.05
> Missing nullcheck in service createContactListParty
> ---
>
> Key: OFBIZ-10653
> URL: https://issues.apache.org/jira/browse/OFBIZ-10653
> Project: OFBiz
> Issue Type: Bug
> Components: marketing
>Affects Versions: Trunk, 16.11.05, Release Branch 17.12
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10653_ContactListServices.patch
>
>
> This service searches for the primary email-address of the given party, if it
> doesn't have a preffered contact mechanism ID in its parameters.
> For this it uses the service {{getPartyEmail}} which, as a result, can
> deliver an optional email-address.
> This is where the problem is: the result is optional.
> Without any further checks, the result, empty or not, will be used to call
> another service called {{createContactListPartyStatus}}. For this service the
> field {{preferredContactMechId}} is a non optional input value, which is set
> before from the result of {{getPartyEmail}}.
> If the party email could not be found, because a party group is added, or
> simply because the party has no mail given for some reason, this service call
> will result in an error because of missing parameters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10676) UI bug in scrum component
[ https://issues.apache.org/jira/browse/OFBIZ-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713607#comment-16713607 ] Pierre Smits commented on OFBIZ-10676: -- To inform (potential) adopters better, this ticket should (regarding the Component(s) field) not be associated with the 'scrum' component, but with the 'common-theme' component. > UI bug in scrum component > - > > Key: OFBIZ-10676 > URL: https://issues.apache.org/jira/browse/OFBIZ-10676 > Project: OFBiz > Issue Type: Bug > Components: scrum >Affects Versions: Trunk, 16.11.05, Release Branch 17.12 >Reporter: Dinesh Mohanty >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 16.11.06, Upcoming Branch > > Attachments: OFBIZ-10676_OfbizUtil.patch > > > An Self XSS bug is present for "Product Backlog Item" for adding a Product > Backlog details of the issue has been emailed to security team. > *Steps to Reproduce:* > 1. Login into Scrum Management Portal as *productowner* and click on your > desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* > 2. The above url in my case is > [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] > 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the > value to *alert(1)* and click on OK > 4. One can see that the XSS payload executed confirming the Self XSS > Note: Same has been confirmed by Security Team so publishing publicly through > Ofbiz Jira platform. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10642) Fallthrough in switch-case of org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.java
[ https://issues.apache.org/jira/browse/OFBIZ-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10642: -- Description: org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.GatewayResponse(InputStream, GatewayRequest): Line 157 et. seq.: Breaks missing in switch case. As this particular one replaces an if-else construct, these should be added. I will provide a patch within a short time. was: org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.GatewayResponse(InputStream, GatewayRequest): Line 157 et. seq.: Breaks missing in switch case. As this particular one replaces an if-else construct, these should be added. I will provide a patch withi a short time. > Fallthrough in switch-case of > org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.java > -- > > Key: OFBIZ-10642 > URL: https://issues.apache.org/jira/browse/OFBIZ-10642 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-10642_fallthrough_in_switchcase.patch > > > org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.GatewayResponse(InputStream, > GatewayRequest): > Line 157 et. seq.: > Breaks missing in switch case. > As this particular one replaces an if-else construct, these should be added. > I will provide a patch within a short time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10654) Update and fix openstreetmap.org integration
[ https://issues.apache.org/jira/browse/OFBIZ-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10654. - > Update and fix openstreetmap.org integration > > > Key: OFBIZ-10654 > URL: https://issues.apache.org/jira/browse/OFBIZ-10654 > Project: OFBiz > Issue Type: Bug > Components: example, framework >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Blocker > Labels: backport-needed > Fix For: Upcoming Branch, Release Branch 17.12 > > Attachments: > OFBIZ-10654_fix_openstreetmap.org_integration_example.patch, > OFBIZ-10654_fix_openstreetmap.org_integration_framework.patch > > > The openstreetmap.org integration is quite old (2.13.1) while there is > version 5.3.0 is out since Nov. 18. Additionally, the marker display still > does not work. > I'm going to fix this while working on an integration example for a customer > project. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10654) Update and fix openstreetmap.org integration
[ https://issues.apache.org/jira/browse/OFBIZ-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10654: -- Labels: (was: backport-needed) > Update and fix openstreetmap.org integration > > > Key: OFBIZ-10654 > URL: https://issues.apache.org/jira/browse/OFBIZ-10654 > Project: OFBiz > Issue Type: Bug > Components: example, framework >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Blocker > Fix For: Upcoming Branch, Release Branch 17.12 > > Attachments: > OFBIZ-10654_fix_openstreetmap.org_integration_example.patch, > OFBIZ-10654_fix_openstreetmap.org_integration_framework.patch > > > The openstreetmap.org integration is quite old (2.13.1) while there is > version 5.3.0 is out since Nov. 18. Additionally, the marker display still > does not work. > I'm going to fix this while working on an integration example for a customer > project. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10676) UI bug in scrum component
[ https://issues.apache.org/jira/browse/OFBIZ-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10676: -- Labels: (was: security) > UI bug in scrum component > - > > Key: OFBIZ-10676 > URL: https://issues.apache.org/jira/browse/OFBIZ-10676 > Project: OFBiz > Issue Type: Bug > Components: scrum >Affects Versions: Trunk, 16.11.05, Release Branch 17.12 >Reporter: Dinesh Mohanty >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 16.11.06, Upcoming Branch > > Attachments: OFBIZ-10676_OfbizUtil.patch > > > An Self XSS bug is present for "Product Backlog Item" for adding a Product > Backlog details of the issue has been emailed to security team. > *Steps to Reproduce:* > 1. Login into Scrum Management Portal as *productowner* and click on your > desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* > 2. The above url in my case is > [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] > 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the > value to *alert(1)* and click on OK > 4. One can see that the XSS payload executed confirming the Self XSS > Note: Same has been confirmed by Security Team so publishing publicly through > Ofbiz Jira platform. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10676) UI bug in scrum component
[ https://issues.apache.org/jira/browse/OFBIZ-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10676. - Thank you [~dkmin] for reporting. > UI bug in scrum component > - > > Key: OFBIZ-10676 > URL: https://issues.apache.org/jira/browse/OFBIZ-10676 > Project: OFBiz > Issue Type: Bug > Components: scrum >Affects Versions: Trunk, 16.11.05, Release Branch 17.12 >Reporter: Dinesh Mohanty >Assignee: Michael Brohl >Priority: Major > Labels: security > Fix For: 17.12.01, 16.11.06, Upcoming Branch > > Attachments: OFBIZ-10676_OfbizUtil.patch > > > An Self XSS bug is present for "Product Backlog Item" for adding a Product > Backlog details of the issue has been emailed to security team. > *Steps to Reproduce:* > 1. Login into Scrum Management Portal as *productowner* and click on your > desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* > 2. The above url in my case is > [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] > 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the > value to *alert(1)* and click on OK > 4. One can see that the XSS payload executed confirming the Self XSS > Note: Same has been confirmed by Security Team so publishing publicly through > Ofbiz Jira platform. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10696) ConcurrentModificationException in ShoppingCart.cleanUpShipGroups
[
https://issues.apache.org/jira/browse/OFBIZ-10696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713593#comment-16713593
]
Jacques Le Roux commented on OFBIZ-10696:
-
Thanks Danny,
Actually it does not even works. My Predicate use an iterator when actually
{{removeIf()}} use its own iterator so I get a {{NoSuchElementException}}.
Anyway was just a quick try, I was curious if I could use an Iterator in a
Predicate for {{removeIf()}}.
I also tested your change, and no surprise it's OK.
> ConcurrentModificationException in ShoppingCart.cleanUpShipGroups
> -
>
> Key: OFBIZ-10696
> URL: https://issues.apache.org/jira/browse/OFBIZ-10696
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Danny Trunk
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06
>
> Attachments: OFBIZ-10696.diff
>
>
> {code:java}
> java.util.ConcurrentModificationException: null
> at
> java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:966)
> ~[?:1.8.0_181]
> at java.util.LinkedList$ListItr.next(LinkedList.java:888)
> ~[?:1.8.0_181]
> at
> org.apache.ofbiz.order.shoppingcart.ShoppingCart.cleanUpShipGroups(ShoppingCart.java:2199)
> ~[ofbiz.jar:?]
> {code}
> There's a for-loop over shipInfo and a call to clear inside this loop which
> leads to a ConcurrentModificationException:
> https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java?view=markup#l2251
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10676) UI bug in scrum component
[ https://issues.apache.org/jira/browse/OFBIZ-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10676: -- Summary: UI bug in scrum component (was: Self XSS in OFBizUtil) > UI bug in scrum component > - > > Key: OFBIZ-10676 > URL: https://issues.apache.org/jira/browse/OFBIZ-10676 > Project: OFBiz > Issue Type: Bug > Components: scrum >Affects Versions: Trunk, 16.11.05, Release Branch 17.12 >Reporter: Dinesh Mohanty >Assignee: Michael Brohl >Priority: Major > Labels: security > Attachments: OFBIZ-10676_OfbizUtil.patch > > > An Self XSS bug is present for "Product Backlog Item" for adding a Product > Backlog details of the issue has been emailed to security team. > *Steps to Reproduce:* > 1. Login into Scrum Management Portal as *productowner* and click on your > desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* > 2. The above url in my case is > [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] > 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the > value to *alert(1)* and click on OK > 4. One can see that the XSS payload executed confirming the Self XSS > Note: Same has been confirmed by Security Team so publishing publicly through > Ofbiz Jira platform. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10676) Self XSS in OFBizUtil
[ https://issues.apache.org/jira/browse/OFBIZ-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10676: -- Description: An Self XSS bug is present for "Product Backlog Item" for adding a Product Backlog details of the issue has been emailed to security team. *Steps to Reproduce:* 1. Login into Scrum Management Portal as *productowner* and click on your desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* 2. The above url in my case is [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the value to *alert(1)* and click on OK 4. One can see that the XSS payload executed confirming the Self XSS Note: Same has been confirmed by Security Team so publishing publicly through Ofbiz Jira platform. was: An Self XSS Vulnerability is present for "Product Backlog Item" for adding a Product Backlog details of the issue has been emailed to security team. *Steps to Reproduce:* 1. Login into Scrum Management Portal as *productowner* and click on your desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* 2. The above url in my case is [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the value to *alert(1)* and click on OK 4. One can see that the XSS payload executed confirming the Self XSS Note: Same has been confirmed by Security Team so publishing publicly through Ofbiz Jira platform. > Self XSS in OFBizUtil > - > > Key: OFBIZ-10676 > URL: https://issues.apache.org/jira/browse/OFBIZ-10676 > Project: OFBiz > Issue Type: Bug > Components: scrum >Affects Versions: Trunk, 16.11.05, Release Branch 17.12 >Reporter: Dinesh Mohanty >Assignee: Michael Brohl >Priority: Major > Labels: security > Attachments: OFBIZ-10676_OfbizUtil.patch > > > An Self XSS bug is present for "Product Backlog Item" for adding a Product > Backlog details of the issue has been emailed to security team. > *Steps to Reproduce:* > 1. Login into Scrum Management Portal as *productowner* and click on your > desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* > 2. The above url in my case is > [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] > 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the > value to *alert(1)* and click on OK > 4. One can see that the XSS payload executed confirming the Self XSS > Note: Same has been confirmed by Security Team so publishing publicly through > Ofbiz Jira platform. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10676) Self XSS in OFBizUtil
[ https://issues.apache.org/jira/browse/OFBIZ-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10676: -- Summary: Self XSS in OFBizUtil (was: Self XSS) > Self XSS in OFBizUtil > - > > Key: OFBIZ-10676 > URL: https://issues.apache.org/jira/browse/OFBIZ-10676 > Project: OFBiz > Issue Type: Bug > Components: scrum >Affects Versions: Trunk, 16.11.05, Release Branch 17.12 >Reporter: Dinesh Mohanty >Assignee: Michael Brohl >Priority: Major > Labels: security > Attachments: OFBIZ-10676_OfbizUtil.patch > > > An Self XSS Vulnerability is present for "Product Backlog Item" for adding a > Product Backlog details of the issue has been emailed to security team. > *Steps to Reproduce:* > 1. Login into Scrum Management Portal as *productowner* and click on your > desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* > 2. The above url in my case is > [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] > 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the > value to *alert(1)* and click on OK > 4. One can see that the XSS payload executed confirming the Self XSS > Note: Same has been confirmed by Security Team so publishing publicly through > Ofbiz Jira platform. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10676) Self XSS
[ https://issues.apache.org/jira/browse/OFBIZ-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10676: -- Affects Version/s: (was: 16.11.06) (was: 17.12.01) Release Branch 17.12 > Self XSS > > > Key: OFBIZ-10676 > URL: https://issues.apache.org/jira/browse/OFBIZ-10676 > Project: OFBiz > Issue Type: Bug > Components: scrum >Affects Versions: Trunk, 16.11.05, Release Branch 17.12 >Reporter: Dinesh Mohanty >Assignee: Michael Brohl >Priority: Major > Labels: security > Attachments: OFBIZ-10676_OfbizUtil.patch > > > An Self XSS Vulnerability is present for "Product Backlog Item" for adding a > Product Backlog details of the issue has been emailed to security team. > *Steps to Reproduce:* > 1. Login into Scrum Management Portal as *productowner* and click on your > desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* > 2. The above url in my case is > [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] > 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the > value to *alert(1)* and click on OK > 4. One can see that the XSS payload executed confirming the Self XSS > Note: Same has been confirmed by Security Team so publishing publicly through > Ofbiz Jira platform. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
