[jira] [Commented] (OFBIZ-12021) "description" and "comment" datatypes unnecessarily limited to 255 char

2020-09-26 Thread ddev (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202675#comment-17202675
 ] 

ddev commented on OFBIZ-12021:
--

Sounds good

> "description" and "comment" datatypes unnecessarily limited to 255 char 
> 
>
> Key: OFBIZ-12021
> URL: https://issues.apache.org/jira/browse/OFBIZ-12021
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel, framework/entity
>Reporter: ddev
>Priority: Minor
> Attachments: documentation-first-draft.diff, field-types-v2.diff
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> "description" and "comment" fields are restricted to 255 char.  However after 
> some research I found that all the supported databases support longer then 
> 255 char
> I would expect users to want to write more then 255 char in a comment (I know 
> I personally can).
> I have included diff of my proposed solution as a attachment  (I am 
> unfamiliar with the procedures for submitting patches here)
> A discussion has been started on dev ML: 
> https://markmail.org/message/7utrgejc2c44i37u
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12009) No Tags on New Virtual Product page

2020-09-26 Thread Kirti Arora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirti Arora updated OFBIZ-12009:

Attachment: OFBIZ-12009.patch

> No Tags on New Virtual Product page
> ---
>
> Key: OFBIZ-12009
> URL: https://issues.apache.org/jira/browse/OFBIZ-12009
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Akash Jain
>Assignee: Kirti Arora
>Priority: Minor
> Attachments: OFBIZ-12009.patch
>
>
> Tags option should not be available on new virtual product (Catalog > Product 
> > New Virtual Product) page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11220) Issues on Checkout without login

2020-09-26 Thread Rahul Chohal (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Chohal reassigned OFBIZ-11220:


Assignee: Rahul Chohal  (was: Phalak Minal Yuvraj)

> Issues on Checkout without login
> 
>
> Key: OFBIZ-11220
> URL: https://issues.apache.org/jira/browse/OFBIZ-11220
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11, Release Branch 17.12, Trunk
>Reporter: Rashi Dhagat
>Assignee: Rahul Chohal
>Priority: Critical
> Attachments: PersonalInfoPage.png, WithoutState.webm
>
>
> Steps to regenerate:
>  # Open url [https://demo-stable.ofbiz.apache.org/ecommerce/control/main]
>  # Add item to cart
>  # Click on Quick Checkout
>  # Click on checkout under Checkout Without Login section
>  # Enter Personal Info and continue
>  # Enter the address and continue
> Actual :
>  # Asterisk symbol on personal info page is on the input field instead of on 
> field name.
>  # No validation on contact no on the personal Info page
>  # Able to proceed without adding state in the address.
> Please refer attachment for same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap

2020-09-26 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11971.
-
Fix Version/s: (was: Trunk)
   17.12.05
   18.12.01
   Resolution: Fixed

Thanks Amit Gadaley for your contribution.

> Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
> ---
>
> Key: OFBIZ-11971
> URL: https://issues.apache.org/jira/browse/OFBIZ-11971
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Amit Gadaley
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-11971.patch
>
>
> 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId  in ReturnItemTypeMap data 
> and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type 
> data does not exists.
> The following data exist for miscellaneous charges in data files:
>  returnAdjustmentTypeId="RET_MISC_ADJ"/>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap

2020-09-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202612#comment-17202612
 ] 

ASF subversion and git services commented on OFBIZ-11971:
-

Commit f1e8ea734fea6398648e0756b38b75551f984f91 in ofbiz-framework's branch 
refs/heads/release17.12 from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f1e8ea7 ]

Fixed: Incorrect data issue for InvoiceItemTypeMap and ReturnItemTypeMap.
(OFBIZ-11971)
As we have returnItemTypeId as RET_MISC_ADJ, same should be used in 
ReturnItemTypeMap and corresponding InvoiceItemTypeMap.
Thanks Amit Gadaley for reporting and providing the patch.


> Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
> ---
>
> Key: OFBIZ-11971
> URL: https://issues.apache.org/jira/browse/OFBIZ-11971
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Amit Gadaley
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-11971.patch
>
>
> 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId  in ReturnItemTypeMap data 
> and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type 
> data does not exists.
> The following data exist for miscellaneous charges in data files:
>  returnAdjustmentTypeId="RET_MISC_ADJ"/>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11965) Improve service name as per best practices

2020-09-26 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202610#comment-17202610
 ] 

Suraj Khurana commented on OFBIZ-11965:
---

Hello Vaibhav,

Thanks for providing the patch.
We are using deprecated tags currently for older services and they will be 
removed in next release. Please explore deprecated tag used in service 
definition and do the required changes in the patch.

Also, please move tickets to Patch Provided status once you have uploaded the 
complete patch, so that more reviewers can review and committers can approach 
it.

Let me know in case some more info required from  my side.

TIA.

> Improve service name as per best practices
> --
>
> Key: OFBIZ-11965
> URL: https://issues.apache.org/jira/browse/OFBIZ-11965
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11965-NamingConventionFix.patch
>
>
> Following service names should be corrected as per naming convention best 
> practices:
>  * SagePayPaymentAuthorisation
>  * SagePayPaymentRefund
>  * SagePayPaymentRelease
>  * SagePayPaymentVoid
>  * SetTimeZoneFromBrowser
>  * SagePayPaymentAuthentication



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11986) createPartyGroupRoleAndContactMechs service not working

2020-09-26 Thread sourabh jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202609#comment-17202609
 ] 

sourabh jain commented on OFBIZ-11986:
--

I have added the patch for the fix.

OFBIZ-11986.patch
Please let me know if any modification is needed.

> createPartyGroupRoleAndContactMechs service not working
> ---
>
> Key: OFBIZ-11986
> URL: https://issues.apache.org/jira/browse/OFBIZ-11986
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: sourabh jain
>Priority: Major
> Attachments: OFBIZ-11986.patch
>
>
> While researched on ticket OFBIZ-11896 identified that groovy version of 
> createPartyGroupRoleAndContactMechs service (converted from mini lang at rev 
> 8af7cf877583acf100d1229260e62fe7f4c92563 ) is not working. Identify these two 
> reasons,
>  # resolvePartyGroupMap called incorrectly
>  # resolvePostalAddressMap and resolveTelecomNumberMap implemented 
> incorrectly as 'postalAddress' and 'telecomNumber' map processor not 
> available into PartyMapProcs.xml.
> There may be more reasons along with these two reasons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11986) createPartyGroupRoleAndContactMechs service not working

2020-09-26 Thread sourabh jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

sourabh jain updated OFBIZ-11986:
-
Attachment: OFBIZ-11986.patch

> createPartyGroupRoleAndContactMechs service not working
> ---
>
> Key: OFBIZ-11986
> URL: https://issues.apache.org/jira/browse/OFBIZ-11986
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: sourabh jain
>Priority: Major
> Attachments: OFBIZ-11986.patch
>
>
> While researched on ticket OFBIZ-11896 identified that groovy version of 
> createPartyGroupRoleAndContactMechs service (converted from mini lang at rev 
> 8af7cf877583acf100d1229260e62fe7f4c92563 ) is not working. Identify these two 
> reasons,
>  # resolvePartyGroupMap called incorrectly
>  # resolvePostalAddressMap and resolveTelecomNumberMap implemented 
> incorrectly as 'postalAddress' and 'telecomNumber' map processor not 
> available into PartyMapProcs.xml.
> There may be more reasons along with these two reasons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

2020-09-26 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11680:
-

Assignee: Suraj Khurana

> ViewQuoteProfit shows fields in wrong order
> ---
>
> Key: OFBIZ-11680
> URL: https://issues.apache.org/jira/browse/OFBIZ-11680
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: quote
> Attachments: OFBIZ-11680.patch, Screen Shot 2020-05-09 at 10.40.39.png
>
>
> See attached image.
> Total amount (of the quote) should be before total cost.
> On line items,  the quoteUnitPrice should be before averageCost



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11454) Content for Blogs is not properly saved

2020-09-26 Thread Prakhar Kumar (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202608#comment-17202608
 ] 

Prakhar Kumar commented on OFBIZ-11454:
---

I have started investigating the issue and while doing so, I noticed that the 
blog summary is also not getting rendered for a newly created blog. 
Furthermore, demo blogs like 'Cute Kid', which display text and image properly, 
doesn't show the same content while editing.

> Content for Blogs is not properly saved
> ---
>
> Key: OFBIZ-11454
> URL: https://issues.apache.org/jira/browse/OFBIZ-11454
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Prakhar Kumar
>Priority: Minor
>
> Do as follows:
>  # Open Url: [https://demo-trunk.ofbiz.apache.org/ecomseo/] (or stable)
>  # Click on a Blog to navigate there.
>  # Create New Blog Post
>  # Fill the fields with text and image and submit as "publish".
> ERROR: The content will not be available and replaced by placeholders
> EXPECTED: Blogarticle should be displayed showing all text and images



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11986) createPartyGroupRoleAndContactMechs service not working

2020-09-26 Thread sourabh jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

sourabh jain reassigned OFBIZ-11986:


Assignee: sourabh jain  (was: Akash Jain)

> createPartyGroupRoleAndContactMechs service not working
> ---
>
> Key: OFBIZ-11986
> URL: https://issues.apache.org/jira/browse/OFBIZ-11986
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: sourabh jain
>Priority: Major
>
> While researched on ticket OFBIZ-11896 identified that groovy version of 
> createPartyGroupRoleAndContactMechs service (converted from mini lang at rev 
> 8af7cf877583acf100d1229260e62fe7f4c92563 ) is not working. Identify these two 
> reasons,
>  # resolvePartyGroupMap called incorrectly
>  # resolvePostalAddressMap and resolveTelecomNumberMap implemented 
> incorrectly as 'postalAddress' and 'telecomNumber' map processor not 
> available into PartyMapProcs.xml.
> There may be more reasons along with these two reasons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12027) Create 'New Communication' button should be removed from create new communication screen.

2020-09-26 Thread Shubham Choudhary (Jira)
Shubham Choudhary created OFBIZ-12027:
-

 Summary: Create 'New Communication' button should be removed from 
create new communication screen.
 Key: OFBIZ-12027
 URL: https://issues.apache.org/jira/browse/OFBIZ-12027
 Project: OFBiz
  Issue Type: Sub-task
  Components: party
Reporter: Shubham Choudhary
Assignee: Shubham Choudhary






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap

2020-09-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202606#comment-17202606
 ] 

ASF subversion and git services commented on OFBIZ-11971:
-

Commit 2fef06ba3894fa40bfa36601f2ecf56bbcc259e5 in ofbiz-framework's branch 
refs/heads/release18.12 from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2fef06b ]

Fixed: Incorrect data issue for InvoiceItemTypeMap and ReturnItemTypeMap.
(OFBIZ-11971)
As we have returnItemTypeId as RET_MISC_ADJ, same should be used in 
ReturnItemTypeMap and corresponding InvoiceItemTypeMap.
Thanks Amit Gadaley for reporting and providing the patch.


> Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
> ---
>
> Key: OFBIZ-11971
> URL: https://issues.apache.org/jira/browse/OFBIZ-11971
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Amit Gadaley
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-11971.patch
>
>
> 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId  in ReturnItemTypeMap data 
> and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type 
> data does not exists.
> The following data exist for miscellaneous charges in data files:
>  returnAdjustmentTypeId="RET_MISC_ADJ"/>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12023) Label issue on List Companies page

2020-09-26 Thread Pradeep Choudhary (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202605#comment-17202605
 ] 

Pradeep Choudhary commented on OFBIZ-12023:
---

This issue is occurring due to the hyperlink title is not supporting character 
encoding for special characters.

Please track progress under OFBIZ-12026.

> Label issue on List Companies page
> --
>
> Key: OFBIZ-12023
> URL: https://issues.apache.org/jira/browse/OFBIZ-12023
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Priority: Major
> Attachments: importExportUiLableIssue.png
>
>
> # Navigate to URL: 'accounting/control/ListCompanies'
>  # Under the companies list, the last column has button for import export.
>  # The System is not showing proper label.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12023) Label issue on List Companies page

2020-09-26 Thread Pradeep Choudhary (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary reassigned OFBIZ-12023:
-

Assignee: (was: Pradeep Choudhary)

> Label issue on List Companies page
> --
>
> Key: OFBIZ-12023
> URL: https://issues.apache.org/jira/browse/OFBIZ-12023
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Priority: Major
> Attachments: importExportUiLableIssue.png
>
>
> # Navigate to URL: 'accounting/control/ListCompanies'
>  # Under the companies list, the last column has button for import export.
>  # The System is not showing proper label.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12026) Hyperlink title under form widget doesn't support character encoding for special characters

2020-09-26 Thread Pradeep Choudhary (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-12026:
--
Attachment: Screenshot from 2020-09-26 18-16-25.png

> Hyperlink title under form widget doesn't support character encoding for 
> special characters
> ---
>
> Key: OFBIZ-12026
> URL: https://issues.apache.org/jira/browse/OFBIZ-12026
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Pradeep Choudhary
>Priority: Minor
> Attachments: Screenshot from 2020-09-26 18-16-25.png
>
>
> When we use any title with special characters for hyperlink tag, it shows 
> broken string on UI.
> here,
> {code:java}
>   widget-style="buttontext">
>   target="ImportExport">
>  
>  
> 
> {code}
>  target="ImportExport">
> It should render a button with the title "Import/Export. But it shows as 
> {code:java}
> ImportExport{code}
> Please check attached image for the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12026) Hyperlink title under form widget doesn't support character encoding for special characters

2020-09-26 Thread Pradeep Choudhary (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-12026:
--
Description: 
When we use any title with special characters for hyperlink tag, it shows 
broken string on UI.

here,
{code:java}
 
 
 
 

{code}


It should render a button with the title "Import/Export. But it shows as  '
{code:java}
ImportExport{code}
+{color:#172b4d}'{color}+

Please check attached image for the same.

 

  was:
When we use any title with special characters for hyperlink tag, it shows 
broken string on UI.

here,
{code:java}
 
 
 
 

{code}


It should render a button with the title "Import/Export. But it shows as  
'+{color:#172b4d}ImportExport'{color}+

Please check attached image for the same.

 


> Hyperlink title under form widget doesn't support character encoding for 
> special characters
> ---
>
> Key: OFBIZ-12026
> URL: https://issues.apache.org/jira/browse/OFBIZ-12026
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Pradeep Choudhary
>Priority: Minor
> Attachments: Screenshot from 2020-09-26 18-16-25.png
>
>
> When we use any title with special characters for hyperlink tag, it shows 
> broken string on UI.
> here,
> {code:java}
>   widget-style="buttontext">
>   target="ImportExport">
>  
>  
> 
> {code}
>  target="ImportExport">
> It should render a button with the title "Import/Export. But it shows as  '
> {code:java}
> ImportExport{code}
> +{color:#172b4d}'{color}+
> Please check attached image for the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12026) Hyperlink title under form widget doesn't support character encoding for special characters

2020-09-26 Thread Pradeep Choudhary (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-12026:
--
Description: 
When we use any title with special characters for hyperlink tag, it shows 
broken string on UI.

here,
{code:java}
 
 
 
 

{code}


It should render a button with the title "Import/Export. But it shows as 
{code:java}
ImportExport{code}
Please check attached image for the same.

 

  was:
When we use any title with special characters for hyperlink tag, it shows 
broken string on UI.

here,
{code:java}
 
 
 
 

{code}


It should render a button with the title "Import/Export. But it shows as  '
{code:java}
ImportExport{code}
+{color:#172b4d}'{color}+

Please check attached image for the same.

 


> Hyperlink title under form widget doesn't support character encoding for 
> special characters
> ---
>
> Key: OFBIZ-12026
> URL: https://issues.apache.org/jira/browse/OFBIZ-12026
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Pradeep Choudhary
>Priority: Minor
> Attachments: Screenshot from 2020-09-26 18-16-25.png
>
>
> When we use any title with special characters for hyperlink tag, it shows 
> broken string on UI.
> here,
> {code:java}
>   widget-style="buttontext">
>   target="ImportExport">
>  
>  
> 
> {code}
>  target="ImportExport">
> It should render a button with the title "Import/Export. But it shows as 
> {code:java}
> ImportExport{code}
> Please check attached image for the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap

2020-09-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202604#comment-17202604
 ] 

ASF subversion and git services commented on OFBIZ-11971:
-

Commit d7408de03fbf7acb379f89c4afcc1ac74596bea3 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d7408de ]

Fixed: Incorrect data issue for InvoiceItemTypeMap and ReturnItemTypeMap.
(OFBIZ-11971)
As we have returnItemTypeId as RET_MISC_ADJ, same should be used in 
ReturnItemTypeMap and corresponding InvoiceItemTypeMap.
Thanks Amit Gadaley for reporting and providing the patch.


> Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
> ---
>
> Key: OFBIZ-11971
> URL: https://issues.apache.org/jira/browse/OFBIZ-11971
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Amit Gadaley
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-11971.patch
>
>
> 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId  in ReturnItemTypeMap data 
> and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type 
> data does not exists.
> The following data exist for miscellaneous charges in data files:
>  returnAdjustmentTypeId="RET_MISC_ADJ"/>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12026) Hyperlink title under form widget doesn't support character encoding for special characters

2020-09-26 Thread Pradeep Choudhary (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-12026:
--
Description: 
When we use any title with special characters for hyperlink tag, it shows 
broken string on UI.

here,
{code:java}
 
 
 
 

{code}


It should render a button with the title "Import/Export. But it shows as  
'+{color:#172b4d}ImportExport'{color}+

Please check attached image for the same.

 

  was:
When we use any title with special characters for hyperlink tag, it shows 
broken string on UI.

here,
{code:java}
 
 
 
 

{code}



It should render a button with the title "Import/Export. But it shows as 
"ImportExport"

Please check attached image for the same.

 


> Hyperlink title under form widget doesn't support character encoding for 
> special characters
> ---
>
> Key: OFBIZ-12026
> URL: https://issues.apache.org/jira/browse/OFBIZ-12026
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Pradeep Choudhary
>Priority: Minor
>
> When we use any title with special characters for hyperlink tag, it shows 
> broken string on UI.
> here,
> {code:java}
>   widget-style="buttontext">
>   target="ImportExport">
>  
>  
> 
> {code}
>  target="ImportExport">
> It should render a button with the title "Import/Export. But it shows as  
> '+{color:#172b4d}ImportExport'{color}+
> Please check attached image for the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12026) Hyperlink title under form widget doesn't support character encoding for special characters

2020-09-26 Thread Pradeep Choudhary (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-12026:
--
Description: 
When we use any title with special characters for hyperlink tag, it shows 
broken string on UI.

here,
{code:java}
 
 
 
 

{code}



It should render a button with the title "Import/Export. But it shows as 
"ImportExport"

Please check attached image for the same.

 

> Hyperlink title under form widget doesn't support character encoding for 
> special characters
> ---
>
> Key: OFBIZ-12026
> URL: https://issues.apache.org/jira/browse/OFBIZ-12026
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Pradeep Choudhary
>Priority: Minor
>
> When we use any title with special characters for hyperlink tag, it shows 
> broken string on UI.
> here,
> {code:java}
>   widget-style="buttontext">
>   target="ImportExport">
>  
>  
> 
> {code}
>  target="ImportExport">
> It should render a button with the title "Import/Export. But it shows as 
> "ImportExport"
> Please check attached image for the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap

2020-09-26 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11971:
--
Affects Version/s: Release Branch 17.12
   Release Branch 18.12

> Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
> ---
>
> Key: OFBIZ-11971
> URL: https://issues.apache.org/jira/browse/OFBIZ-11971
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Amit Gadaley
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-11971.patch
>
>
> 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId  in ReturnItemTypeMap data 
> and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type 
> data does not exists.
> The following data exist for miscellaneous charges in data files:
>  returnAdjustmentTypeId="RET_MISC_ADJ"/>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12026) Hyperlink title under form widget doesn't support character encoding for special characters

2020-09-26 Thread Pradeep Choudhary (Jira)
Pradeep Choudhary created OFBIZ-12026:
-

 Summary: Hyperlink title under form widget doesn't support 
character encoding for special characters
 Key: OFBIZ-12026
 URL: https://issues.apache.org/jira/browse/OFBIZ-12026
 Project: OFBiz
  Issue Type: Bug
Affects Versions: Trunk, Release Branch 17.12
Reporter: Pradeep Choudhary






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11582) Required fields for party content upload are not checked

2020-09-26 Thread Mohammed Rehan Khan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammed Rehan Khan updated OFBIZ-11582:

Attachment: OFBiz_ Party Manager_ View Party Profile.png

> Required fields for party content upload are not checked
> 
>
> Key: OFBIZ-11582
> URL: https://issues.apache.org/jira/browse/OFBIZ-11582
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBiz_ Party Manager_ View Party Profile.png
>
>
> I noticed that the purpose and the file to upload fields are no longer 
> required. I guess it's because this no longer works 
> http://svn.apache.org/viewvc?view=revision=1087254. Is then the 
> "required error" CSS class missing?
> It works well in old demo (R13) and somehow in stable (R16). I was lost 
> somehow since...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11582) Required fields for party content upload are not checked

2020-09-26 Thread Mohammed Rehan Khan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202603#comment-17202603
 ] 

Mohammed Rehan Khan commented on OFBIZ-11582:
-

Hello [~jleroux] , [~akash.jain] 

After taking the latest update of the trunk, I am not able to regenerate the 
issue. 
Required fields party content upload and purpose are working fine with the 
required error message.

Please find the attached screenshot for more details.

--
Thanks !!

> Required fields for party content upload are not checked
> 
>
> Key: OFBIZ-11582
> URL: https://issues.apache.org/jira/browse/OFBIZ-11582
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Akash Jain
>Priority: Major
>
> I noticed that the purpose and the file to upload fields are no longer 
> required. I guess it's because this no longer works 
> http://svn.apache.org/viewvc?view=revision=1087254. Is then the 
> "required error" CSS class missing?
> It works well in old demo (R13) and somehow in stable (R16). I was lost 
> somehow since...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11605) Unable to change Order Status

2020-09-26 Thread Devanshu Vyas (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202602#comment-17202602
 ] 

Devanshu Vyas commented on OFBIZ-11605:
---

Hello [~Rahul.marjiwe], I followed all the steps shared in the ticket 
description. I was also not able to replicate the issue.

I checked with the other order statuses as well, and all is working well. If 
you could share some more details and screenshots, it would be great.

This could be a local machine issue as well, so if this is the case then we can 
close this ticket.

 

 

> Unable to change Order Status 
> --
>
> Key: OFBIZ-11605
> URL: https://issues.apache.org/jira/browse/OFBIZ-11605
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Rahul Marjiwe
>Assignee: Rahul Marjiwe
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11605.patch
>
>
> Step to generate:
>  # Go to the order manager and select the order entry menu.
>  #  select the supplier for a purchase order and click on continue.
>  #  In Create  Purchase Order screen add any product Id, quantity, and click 
> on add to order.
>  # Click on Finalize order and continue.
>  #  On Purchase Order : Order Entry Ship-To Settings click on continue.
>  #  For order notes and additional party-id click on continue.
>  # In order-confirmation screen click on Create Order button.
>  # In orderview screen click on approve order button. 
> Actual: it is rendering the error message after click on  approve order 
> button. 
> Expected: Change order status created to approve. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11965) Improve service name as per best practices

2020-09-26 Thread Vaibhav Hood (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202600#comment-17202600
 ] 

Vaibhav Hood edited comment on OFBIZ-11965 at 9/26/20, 12:20 PM:
-

[^OFBIZ-11965-NamingConventionFix.patch]

Made the required changes in the naming conventions for the services reported 
and added the patch for the same.


was (Author: vaibhav.hood):
[^OFBIZ-11965-NamingConventionFix.patch]Made the required changes in the naming 
conventions for the services reported and added the patch for the same.

> Improve service name as per best practices
> --
>
> Key: OFBIZ-11965
> URL: https://issues.apache.org/jira/browse/OFBIZ-11965
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11965-NamingConventionFix.patch
>
>
> Following service names should be corrected as per naming convention best 
> practices:
>  * SagePayPaymentAuthorisation
>  * SagePayPaymentRefund
>  * SagePayPaymentRelease
>  * SagePayPaymentVoid
>  * SetTimeZoneFromBrowser
>  * SagePayPaymentAuthentication



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11965) Improve service name as per best practices

2020-09-26 Thread Vaibhav Hood (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202600#comment-17202600
 ] 

Vaibhav Hood edited comment on OFBIZ-11965 at 9/26/20, 12:20 PM:
-

[^OFBIZ-11965-NamingConventionFix.patch]Made the required changes in the naming 
conventions for the services reported and added the patch for the same.


was (Author: vaibhav.hood):
Made the required changes in the naming conventions for the services reported 
and added the patch for the same.

> Improve service name as per best practices
> --
>
> Key: OFBIZ-11965
> URL: https://issues.apache.org/jira/browse/OFBIZ-11965
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11965-NamingConventionFix.patch
>
>
> Following service names should be corrected as per naming convention best 
> practices:
>  * SagePayPaymentAuthorisation
>  * SagePayPaymentRefund
>  * SagePayPaymentRelease
>  * SagePayPaymentVoid
>  * SetTimeZoneFromBrowser
>  * SagePayPaymentAuthentication



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11965) Improve service name as per best practices

2020-09-26 Thread Vaibhav Hood (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202600#comment-17202600
 ] 

Vaibhav Hood commented on OFBIZ-11965:
--

Made the required changes in the naming conventions for the services reported 
and added the patch for the same.

> Improve service name as per best practices
> --
>
> Key: OFBIZ-11965
> URL: https://issues.apache.org/jira/browse/OFBIZ-11965
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11965-NamingConventionFix.patch
>
>
> Following service names should be corrected as per naming convention best 
> practices:
>  * SagePayPaymentAuthorisation
>  * SagePayPaymentRefund
>  * SagePayPaymentRelease
>  * SagePayPaymentVoid
>  * SetTimeZoneFromBrowser
>  * SagePayPaymentAuthentication



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11965) Improve service name as per best practices

2020-09-26 Thread Vaibhav Hood (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vaibhav Hood reassigned OFBIZ-11965:


Assignee: (was: Vaibhav Hood)

> Improve service name as per best practices
> --
>
> Key: OFBIZ-11965
> URL: https://issues.apache.org/jira/browse/OFBIZ-11965
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11965-NamingConventionFix.patch
>
>
> Following service names should be corrected as per naming convention best 
> practices:
>  * SagePayPaymentAuthorisation
>  * SagePayPaymentRefund
>  * SagePayPaymentRelease
>  * SagePayPaymentVoid
>  * SetTimeZoneFromBrowser
>  * SagePayPaymentAuthentication



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11898) Create new Find Security Group screen

2020-09-26 Thread Chinmay Patidar (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Patidar updated OFBIZ-11898:

Attachment: OFBIZ-11898.patch

> Create new Find Security Group screen 
> --
>
> Key: OFBIZ-11898
> URL: https://issues.apache.org/jira/browse/OFBIZ-11898
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11898.patch
>
>
> Implement new Find Security Group screen under 
> webtools/control/FindSecurityGroup to facilitate webtools users to find 
> appropriate security group with search parameters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11898) Create new Find Security Group screen

2020-09-26 Thread Chinmay Patidar (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Patidar updated OFBIZ-11898:

Attachment: (was: OFBIZ-11898)

> Create new Find Security Group screen 
> --
>
> Key: OFBIZ-11898
> URL: https://issues.apache.org/jira/browse/OFBIZ-11898
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
>
> Implement new Find Security Group screen under 
> webtools/control/FindSecurityGroup to facilitate webtools users to find 
> appropriate security group with search parameters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11965) Improve service name as per best practices

2020-09-26 Thread Vaibhav Hood (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vaibhav Hood updated OFBIZ-11965:
-
Attachment: OFBIZ-11965-NamingConventionFix.patch

> Improve service name as per best practices
> --
>
> Key: OFBIZ-11965
> URL: https://issues.apache.org/jira/browse/OFBIZ-11965
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Vaibhav Hood
>Priority: Minor
> Attachments: OFBIZ-11965-NamingConventionFix.patch
>
>
> Following service names should be corrected as per naming convention best 
> practices:
>  * SagePayPaymentAuthorisation
>  * SagePayPaymentRefund
>  * SagePayPaymentRelease
>  * SagePayPaymentVoid
>  * SetTimeZoneFromBrowser
>  * SagePayPaymentAuthentication



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11898) Create new Find Security Group screen

2020-09-26 Thread Chinmay Patidar (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202599#comment-17202599
 ] 

Chinmay Patidar commented on OFBIZ-11898:
-

Provided patch containing the support with which the user would be able to 
search/filter the Security Groups list. Thanks [~pawan] for reporting the issue.

> Create new Find Security Group screen 
> --
>
> Key: OFBIZ-11898
> URL: https://issues.apache.org/jira/browse/OFBIZ-11898
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-11898
>
>
> Implement new Find Security Group screen under 
> webtools/control/FindSecurityGroup to facilitate webtools users to find 
> appropriate security group with search parameters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11898) Create new Find Security Group screen

2020-09-26 Thread Chinmay Patidar (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Patidar reassigned OFBIZ-11898:
---

Assignee: (was: Chinmay Patidar)

> Create new Find Security Group screen 
> --
>
> Key: OFBIZ-11898
> URL: https://issues.apache.org/jira/browse/OFBIZ-11898
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11898
>
>
> Implement new Find Security Group screen under 
> webtools/control/FindSecurityGroup to facilitate webtools users to find 
> appropriate security group with search parameters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11898) Create new Find Security Group screen

2020-09-26 Thread Chinmay Patidar (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Patidar updated OFBIZ-11898:

Attachment: OFBIZ-11898

> Create new Find Security Group screen 
> --
>
> Key: OFBIZ-11898
> URL: https://issues.apache.org/jira/browse/OFBIZ-11898
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-11898
>
>
> Implement new Find Security Group screen under 
> webtools/control/FindSecurityGroup to facilitate webtools users to find 
> appropriate security group with search parameters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

2020-09-26 Thread Lalit Dashora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora reassigned OFBIZ-11680:
-

Assignee: (was: Lalit Dashora)

> ViewQuoteProfit shows fields in wrong order
> ---
>
> Key: OFBIZ-11680
> URL: https://issues.apache.org/jira/browse/OFBIZ-11680
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: quote
> Attachments: OFBIZ-11680.patch, Screen Shot 2020-05-09 at 10.40.39.png
>
>
> See attached image.
> Total amount (of the quote) should be before total cost.
> On line items,  the quoteUnitPrice should be before averageCost



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11185) OrderReadHelper.getAvailableOrderHeaderAdjustments improvements

2020-09-26 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11185.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks Amit Gadaley for providing the patch.

> OrderReadHelper.getAvailableOrderHeaderAdjustments improvements
> ---
>
> Key: OFBIZ-11185
> URL: https://issues.apache.org/jira/browse/OFBIZ-11185
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11185.patch
>
>
> We have a helper method in OrderReadHelper named as 
> getAvailableOrderHeaderAdjustments which is used to fetch order header 
> adjustments available for return.
> It should also check for amount, it might possible, orderHeader adjustment 
> was of $100 and once a return is created for $20, then available $80 would 
> not render while creating second return for the same order.
> So instead of checking only for orderAdjustmentId in ReturnAdjustment, it 
> should also check for adjustment amount.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11185) OrderReadHelper.getAvailableOrderHeaderAdjustments improvements

2020-09-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202596#comment-17202596
 ] 

ASF subversion and git services commented on OFBIZ-11185:
-

Commit fa86887eb6e90b73df19082236821543e90c8215 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fa86887 ]

Improved: Handle case of partial amount available for return in adjustment in 
OrderReadHelper.getAvailableOrderHeaderAdjustments method.
(OFBIZ-11185)
Currently it filters all the adjustment that has correspoding returnAdjustment, 
it should check for amount as well.
Thanks Amit Gadaley for providing the patch.


> OrderReadHelper.getAvailableOrderHeaderAdjustments improvements
> ---
>
> Key: OFBIZ-11185
> URL: https://issues.apache.org/jira/browse/OFBIZ-11185
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11185.patch
>
>
> We have a helper method in OrderReadHelper named as 
> getAvailableOrderHeaderAdjustments which is used to fetch order header 
> adjustments available for return.
> It should also check for amount, it might possible, orderHeader adjustment 
> was of $100 and once a return is created for $20, then available $80 would 
> not render while creating second return for the same order.
> So instead of checking only for orderAdjustmentId in ReturnAdjustment, it 
> should also check for adjustment amount.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-7451) Update Blog summary throws database exception when characters exceeds more than 255 characters

2020-09-26 Thread Ankit Joshi (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202595#comment-17202595
 ] 

Ankit Joshi commented on OFBIZ-7451:


Hello Everyone,

I've verified the Blogs creation workflow and as the data model 
(ElectronicText.textData)  utilizing to store the Blog Summary has enough 
character limit (fieldType: very-long) which discards the 255 characters limit 
as reported in the ticket. So, this issue doesn't persist now. Hence, please 
let me know if anyone has any concerns or we can close the ticket.

> Update Blog summary throws database exception when characters exceeds more 
> than 255 characters
> --
>
> Key: OFBIZ-7451
> URL: https://issues.apache.org/jira/browse/OFBIZ-7451
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Vishal Chhabria
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2020-09-26 Thread Praveen Patil (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Patil updated OFBIZ-10386:
--
Attachment: (was: ViewProfile.patch)

> Empty field is reflecting on Contact list section on Profile Page
> -
>
> Key: OFBIZ-10386
> URL: https://issues.apache.org/jira/browse/OFBIZ-10386
> Project: OFBiz
>  Issue Type: Bug
> Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
>Reporter: Archana Asthana
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: EmptyFields.png, ViewProfileV2.patch
>
>
> Steps to generate: 
> Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
> On the profile page, Go down to Contact list
> Empty fields are displaying before Verify Subscription button
> Expected: The field should have some specifications to be filled up
> Image is attached for reference



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2020-09-26 Thread Praveen Patil (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202593#comment-17202593
 ] 

Praveen Patil commented on OFBIZ-10386:
---

Attached the updated patch. [~devanshu] please have a look.

> Empty field is reflecting on Contact list section on Profile Page
> -
>
> Key: OFBIZ-10386
> URL: https://issues.apache.org/jira/browse/OFBIZ-10386
> Project: OFBiz
>  Issue Type: Bug
> Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
>Reporter: Archana Asthana
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: EmptyFields.png, ViewProfileV2.patch
>
>
> Steps to generate: 
> Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
> On the profile page, Go down to Contact list
> Empty fields are displaying before Verify Subscription button
> Expected: The field should have some specifications to be filled up
> Image is attached for reference



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2020-09-26 Thread Praveen Patil (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Patil updated OFBIZ-10386:
--
Attachment: ViewProfileV2.patch

> Empty field is reflecting on Contact list section on Profile Page
> -
>
> Key: OFBIZ-10386
> URL: https://issues.apache.org/jira/browse/OFBIZ-10386
> Project: OFBiz
>  Issue Type: Bug
> Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
>Reporter: Archana Asthana
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: EmptyFields.png, ViewProfile.patch, ViewProfileV2.patch
>
>
> Steps to generate: 
> Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
> On the profile page, Go down to Contact list
> Empty fields are displaying before Verify Subscription button
> Expected: The field should have some specifications to be filled up
> Image is attached for reference



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

2020-09-26 Thread Lalit Dashora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora updated OFBIZ-11680:
--
Attachment: OFBIZ-11680.patch

> ViewQuoteProfit shows fields in wrong order
> ---
>
> Key: OFBIZ-11680
> URL: https://issues.apache.org/jira/browse/OFBIZ-11680
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Lalit Dashora
>Priority: Major
>  Labels: quote
> Attachments: OFBIZ-11680.patch, Screen Shot 2020-05-09 at 10.40.39.png
>
>
> See attached image.
> Total amount (of the quote) should be before total cost.
> On line items,  the quoteUnitPrice should be before averageCost



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12025) Unable to add address while selecting option split shipment

2020-09-26 Thread Rashi Dhagat (Jira)
Rashi Dhagat created OFBIZ-12025:


 Summary: Unable to add address while selecting option split 
shipment
 Key: OFBIZ-12025
 URL: https://issues.apache.org/jira/browse/OFBIZ-12025
 Project: OFBiz
  Issue Type: Bug
Affects Versions: 17.12.04
Reporter: Rashi Dhagat
 Attachments: NewAddress-SplitShipmenterror.png, SplitShipmentError.webm

Steps to regenerate:
1. Add multiple items in the cart

2. Click on View cart

3. Click on checkout

4. Click on Split shipment option

5. Click on Add new address
Actual: Error renders while trying to add the address or selecting the existing 
address.
Please refer to the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

2020-09-26 Thread Lalit Dashora (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202592#comment-17202592
 ] 

Lalit Dashora commented on OFBIZ-11680:
---

Hi,

Please find the attached patch which has the improvement of fields on Quote 
profit screen.

Thanks!

> ViewQuoteProfit shows fields in wrong order
> ---
>
> Key: OFBIZ-11680
> URL: https://issues.apache.org/jira/browse/OFBIZ-11680
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Lalit Dashora
>Priority: Major
>  Labels: quote
> Attachments: Screen Shot 2020-05-09 at 10.40.39.png
>
>
> See attached image.
> Total amount (of the quote) should be before total cost.
> On line items,  the quoteUnitPrice should be before averageCost



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11924) Issues with additional image on ecommerce

2020-09-26 Thread Arpit Mor (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202591#comment-17202591
 ] 

Arpit Mor commented on OFBIZ-11924:
---

Hello [~akash.jain],

I have verified and both issues #1 and #2 still exist.

Can you please verify and share the screenshots or a video if everything works 
fine.

Thanks

> Issues with additional image on ecommerce
> -
>
> Key: OFBIZ-11924
> URL: https://issues.apache.org/jira/browse/OFBIZ-11924
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Akash Jain
>Priority: Minor
> Attachments: Add1.jpg, Add2.jpg, Add3.jpg, Image2.1.png, Image2.2.png
>
>
> Following issues were found:
>  
> #1) Additional image uploaded for product is not displayed (if product 
> already has additional image)
> Steps to regenerate:
>  * Download additional images attached in the ticket
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=WG-5569]
>  * Browse additional images that are downloaded in the earlier step
>  * Click on upload button
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Tiny-Chrome-Widget-WG-5569.html]
>  
> Actual: Uploaded additional images are not displayed
>  
> Expected: Uploaded additional image should be displayed on ecommerce
>  
> Note: This issue is product specific, for product: Tiny Chrome Widget (Id: 
> WG-5569), uploaded additional images are not displayed. But for product: Nan 
> Gizmo (Id: GZ-1001), uploaded additional images are displayed
>  
> #2) UI issue on ecommerce when additional images are uploaded for product
> Steps to regenerate:
>  * Download additional images attached in the ticket
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1001]
>  * Browse additional images that are downloaded in the earlier step
>  * Click on upload button
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Nan-Gizmo-GZ-1001.html]
>  
> Actual: Please refer attachment: Image2.1
> Expected: Please refer attachment: Image 2.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-11924) Issues with additional image on ecommerce

2020-09-26 Thread Arpit Mor (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Mor reopened OFBIZ-11924:
---

> Issues with additional image on ecommerce
> -
>
> Key: OFBIZ-11924
> URL: https://issues.apache.org/jira/browse/OFBIZ-11924
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Akash Jain
>Priority: Minor
> Attachments: Add1.jpg, Add2.jpg, Add3.jpg, Image2.1.png, Image2.2.png
>
>
> Following issues were found:
>  
> #1) Additional image uploaded for product is not displayed (if product 
> already has additional image)
> Steps to regenerate:
>  * Download additional images attached in the ticket
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=WG-5569]
>  * Browse additional images that are downloaded in the earlier step
>  * Click on upload button
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Tiny-Chrome-Widget-WG-5569.html]
>  
> Actual: Uploaded additional images are not displayed
>  
> Expected: Uploaded additional image should be displayed on ecommerce
>  
> Note: This issue is product specific, for product: Tiny Chrome Widget (Id: 
> WG-5569), uploaded additional images are not displayed. But for product: Nan 
> Gizmo (Id: GZ-1001), uploaded additional images are displayed
>  
> #2) UI issue on ecommerce when additional images are uploaded for product
> Steps to regenerate:
>  * Download additional images attached in the ticket
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1001]
>  * Browse additional images that are downloaded in the earlier step
>  * Click on upload button
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Nan-Gizmo-GZ-1001.html]
>  
> Actual: Please refer attachment: Image2.1
> Expected: Please refer attachment: Image 2.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10426) When creating blog or forums, it failed to save

2020-09-26 Thread Aman Mishra (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202590#comment-17202590
 ] 

Aman Mishra commented on OFBIZ-10426:
-

Thanks [~jleroux] for the exact error details and logs. I will check for the 
same.

Thanks!

> When creating blog or forums, it failed to save
> ---
>
> Key: OFBIZ-10426
> URL: https://issues.apache.org/jira/browse/OFBIZ-10426
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jason Hao
>Assignee: Aman Mishra
>Priority: Major
> Attachments: OFBIZ-10426-R17-Article.png, OFBIZ-10426-R17-Blog.png, 
> OFBIZ-10426-Working.png, blog-error.png
>
>
> Create a blog or forum and click save button, it will popup with error 
> message. The reason is because the mapKey passed from front end cannot be 
> handled by the service. The solution is not to pass the mapKey to the service.
> Steps:  
> 1) navigate to 
> https://demo-trunk.ofbiz.apache.org/content/control/blogContent?blogContentId=BLOGROOTBIGAL
> 2) create a new article  
> https://demo-trunk.ofbiz.apache.org/content/control/EditBlogArticle?blogContentId=BLOGROOTBIGAL
>  
> ERROR: Could not complete the Post a new Content article Entry 
> [file:/Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent|file:///Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent]
>  process [problem invoking the [createTextContent] service with the map named 
> [createText] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-06-01 
> 21:38:24.088(java.sql.Timestamp)][createdTxStamp,2018-06-01 
> 21:38:24.086(java.sql.Timestamp)][currentPassword,
> {SHA}
> 47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Shanghai(java.lang.String)][lastUpdatedStamp,2018-06-02
>  03:00:52.632(java.sql.Timestamp)][lastUpdatedTxStamp,2018-06-02 
> 03:00:52.632(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
>  textData=hello, dataTemplateTypeId=NONE, mapKey=MAIN, contentIdFrom=ASK, 
> description=hello, partyId=admin, locale=en_US, 
> dataResourceTypeId=ELECTRONIC_TEXT, contentName=hell world}]: Unknown 
> parameter found: [createTextContent.contentIdFrom]Unknown parameter found: 
> [createTextContent.mapKey]]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12024) Error renders while adding gift card

2020-09-26 Thread Rashi Dhagat (Jira)
Rashi Dhagat created OFBIZ-12024:


 Summary: Error renders while adding gift card
 Key: OFBIZ-12024
 URL: https://issues.apache.org/jira/browse/OFBIZ-12024
 Project: OFBiz
  Issue Type: Bug
Affects Versions: 17.12.04
Reporter: Rashi Dhagat
 Attachments: ErrorGiftcard.webm, GiftCardError.png

Steps to regenerate:
1. Click on gift card

2. Select the variant

3. Enter the additional information and click on submit.
Actual: Nothing to do here and error message displays whereas gift card is 
added in the cart.
Please refer to the attachment.



 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10426) When creating blog or forums, it failed to save

2020-09-26 Thread Aman Mishra (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202589#comment-17202589
 ] 

Aman Mishra commented on OFBIZ-10426:
-

Thanks [~jleroux] for the details.

I tried replicating the same.

Verified the functionality over R17/stable code base (*ofbiz-framework branch 
release17.12 (stable)*) 

Successfully able to create a blog as well as an article without any error. 
Please refer:

!OFBIZ-10426-R17-Blog.png! !OFBIZ-10426-R17-Article.png!

Please validate and share the steps if you are still facing the same error.

Thanks!

> When creating blog or forums, it failed to save
> ---
>
> Key: OFBIZ-10426
> URL: https://issues.apache.org/jira/browse/OFBIZ-10426
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jason Hao
>Assignee: Aman Mishra
>Priority: Major
> Attachments: OFBIZ-10426-R17-Article.png, OFBIZ-10426-R17-Blog.png, 
> OFBIZ-10426-Working.png, blog-error.png
>
>
> Create a blog or forum and click save button, it will popup with error 
> message. The reason is because the mapKey passed from front end cannot be 
> handled by the service. The solution is not to pass the mapKey to the service.
> Steps:  
> 1) navigate to 
> https://demo-trunk.ofbiz.apache.org/content/control/blogContent?blogContentId=BLOGROOTBIGAL
> 2) create a new article  
> https://demo-trunk.ofbiz.apache.org/content/control/EditBlogArticle?blogContentId=BLOGROOTBIGAL
>  
> ERROR: Could not complete the Post a new Content article Entry 
> [file:/Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent|file:///Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent]
>  process [problem invoking the [createTextContent] service with the map named 
> [createText] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-06-01 
> 21:38:24.088(java.sql.Timestamp)][createdTxStamp,2018-06-01 
> 21:38:24.086(java.sql.Timestamp)][currentPassword,
> {SHA}
> 47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Shanghai(java.lang.String)][lastUpdatedStamp,2018-06-02
>  03:00:52.632(java.sql.Timestamp)][lastUpdatedTxStamp,2018-06-02 
> 03:00:52.632(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
>  textData=hello, dataTemplateTypeId=NONE, mapKey=MAIN, contentIdFrom=ASK, 
> description=hello, partyId=admin, locale=en_US, 
> dataResourceTypeId=ELECTRONIC_TEXT, contentName=hell world}]: Unknown 
> parameter found: [createTextContent.contentIdFrom]Unknown parameter found: 
> [createTextContent.mapKey]]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11961) Refactor hardcoded shipping integration service references to make them configurable

2020-09-26 Thread Anushi Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202588#comment-17202588
 ] 

Anushi Gupta commented on OFBIZ-11961:
--

Hello [~mridulpathak],
I have gone through the discussions and created the mentioned entity as per my 
understanding.
I am adding patch for the same.

Please let me know the improvements. [^OFBIZ-11961.patch] 

> Refactor hardcoded shipping integration service references to make them 
> configurable
> 
>
> Key: OFBIZ-11961
> URL: https://issues.apache.org/jira/browse/OFBIZ-11961
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product/facility
>Affects Versions: Trunk
>Reporter: Mridul Pathak
>Assignee: Mridul Pathak
>Priority: Minor
> Attachments: OFBIZ-11961.patch
>
>
> Introduce a new entity “ProductStoreShipmentSettings” to configure available 
> shipping gateway services for shipping carriers at product store level. To 
> begin with the entity could have following fields,
> 1. productStoreId (pk)
> 2. carrierPartyId (pk)
> 3. shipmentServiceEnumId (pk)
> 4. shipmentService
> 5. shipmentGatewayConfigId (Ideally this field should become party of this 
> new entity, though it is currently supported in ProductStoreShipmentMeth 
> entity)
>  
> Mailing List Reference: 
> https://lists.apache.org/thread.html/rde6be39555b09af27e4e53f57788c98d0928a1569c3f92578ba44b6d%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11961) Refactor hardcoded shipping integration service references to make them configurable

2020-09-26 Thread Anushi Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anushi Gupta updated OFBIZ-11961:
-
Attachment: OFBIZ-11961.patch

> Refactor hardcoded shipping integration service references to make them 
> configurable
> 
>
> Key: OFBIZ-11961
> URL: https://issues.apache.org/jira/browse/OFBIZ-11961
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product/facility
>Affects Versions: Trunk
>Reporter: Mridul Pathak
>Assignee: Mridul Pathak
>Priority: Minor
> Attachments: OFBIZ-11961.patch
>
>
> Introduce a new entity “ProductStoreShipmentSettings” to configure available 
> shipping gateway services for shipping carriers at product store level. To 
> begin with the entity could have following fields,
> 1. productStoreId (pk)
> 2. carrierPartyId (pk)
> 3. shipmentServiceEnumId (pk)
> 4. shipmentService
> 5. shipmentGatewayConfigId (Ideally this field should become party of this 
> new entity, though it is currently supported in ProductStoreShipmentMeth 
> entity)
>  
> Mailing List Reference: 
> https://lists.apache.org/thread.html/rde6be39555b09af27e4e53f57788c98d0928a1569c3f92578ba44b6d%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12013) Create button should be removed from create screen of various Catalog features

2020-09-26 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-12013:
--

Assignee: Akash Jain  (was: Kirti Arora)

> Create button should be removed from create screen of various Catalog features
> --
>
> Key: OFBIZ-12013
> URL: https://issues.apache.org/jira/browse/OFBIZ-12013
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product/catalog
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11490) Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to groovy DSL

2020-09-26 Thread Sourabh Punyani (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202586#comment-17202586
 ] 

Sourabh Punyani commented on OFBIZ-11490:
-

Hello [~devanshu],

I have added a patch (OFBIZ-11490.patch) for the same. Also, I have verified 
the test cases for the same using ./gradlew "ofbiz --test component=accounting 
--test suitename=paymenttests".

Please verify it.

> Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to 
> groovy DSL
> 
>
> Key: OFBIZ-11490
> URL: https://issues.apache.org/jira/browse/OFBIZ-11490
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
> Attachments: OFBIZ-11490.patch
>
>
> Convert the createPaymentAndPaymentGroupForInvoices service code from 
> mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12006) Error in Product Party

2020-09-26 Thread Shubham Choudhary (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shubham Choudhary reassigned OFBIZ-12006:
-

Assignee: Akash Jain  (was: Shubham Choudhary)

> Error in Product Party
> --
>
> Key: OFBIZ-12006
> URL: https://issues.apache.org/jira/browse/OFBIZ-12006
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Major
> Attachments: Product_Party_Error.png
>
>
> Error when creating parties for product, attached screen-shot for the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11490) Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to groovy DSL

2020-09-26 Thread Sourabh Punyani (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sourabh Punyani updated OFBIZ-11490:

Attachment: OFBIZ-11490.patch

> Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to 
> groovy DSL
> 
>
> Key: OFBIZ-11490
> URL: https://issues.apache.org/jira/browse/OFBIZ-11490
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
> Attachments: OFBIZ-11490.patch
>
>
> Convert the createPaymentAndPaymentGroupForInvoices service code from 
> mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12009) No Tags on New Virtual Product page

2020-09-26 Thread Kirti Arora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirti Arora reassigned OFBIZ-12009:
---

Assignee: Kirti Arora  (was: Akash Jain)

> No Tags on New Virtual Product page
> ---
>
> Key: OFBIZ-12009
> URL: https://issues.apache.org/jira/browse/OFBIZ-12009
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Akash Jain
>Assignee: Kirti Arora
>Priority: Minor
>
> Tags option should not be available on new virtual product (Catalog > Product 
> > New Virtual Product) page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10426) When creating blog or forums, it failed to save

2020-09-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202583#comment-17202583
 ] 

Jacques Le Roux commented on OFBIZ-10426:
-

Forum works well

> When creating blog or forums, it failed to save
> ---
>
> Key: OFBIZ-10426
> URL: https://issues.apache.org/jira/browse/OFBIZ-10426
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jason Hao
>Assignee: Aman Mishra
>Priority: Major
> Attachments: OFBIZ-10426-R17-Article.png, OFBIZ-10426-R17-Blog.png, 
> OFBIZ-10426-Working.png, blog-error.png
>
>
> Create a blog or forum and click save button, it will popup with error 
> message. The reason is because the mapKey passed from front end cannot be 
> handled by the service. The solution is not to pass the mapKey to the service.
> Steps:  
> 1) navigate to 
> https://demo-trunk.ofbiz.apache.org/content/control/blogContent?blogContentId=BLOGROOTBIGAL
> 2) create a new article  
> https://demo-trunk.ofbiz.apache.org/content/control/EditBlogArticle?blogContentId=BLOGROOTBIGAL
>  
> ERROR: Could not complete the Post a new Content article Entry 
> [file:/Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent|file:///Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent]
>  process [problem invoking the [createTextContent] service with the map named 
> [createText] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-06-01 
> 21:38:24.088(java.sql.Timestamp)][createdTxStamp,2018-06-01 
> 21:38:24.086(java.sql.Timestamp)][currentPassword,
> {SHA}
> 47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Shanghai(java.lang.String)][lastUpdatedStamp,2018-06-02
>  03:00:52.632(java.sql.Timestamp)][lastUpdatedTxStamp,2018-06-02 
> 03:00:52.632(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
>  textData=hello, dataTemplateTypeId=NONE, mapKey=MAIN, contentIdFrom=ASK, 
> description=hello, partyId=admin, locale=en_US, 
> dataResourceTypeId=ELECTRONIC_TEXT, contentName=hell world}]: Unknown 
> parameter found: [createTextContent.contentIdFrom]Unknown parameter found: 
> [createTextContent.mapKey]]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12006) Error in Product Party

2020-09-26 Thread Shubham Choudhary (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shubham Choudhary reassigned OFBIZ-12006:
-

Assignee: Shubham Choudhary  (was: Akash Jain)

> Error in Product Party
> --
>
> Key: OFBIZ-12006
> URL: https://issues.apache.org/jira/browse/OFBIZ-12006
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Reporter: Akash Jain
>Assignee: Shubham Choudhary
>Priority: Major
> Attachments: Product_Party_Error.png
>
>
> Error when creating parties for product, attached screen-shot for the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10426) When creating blog or forums, it failed to save

2020-09-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202582#comment-17202582
 ] 

Jacques Le Roux commented on OFBIZ-10426:
-

Hi Aman,

I saw that you put 2 images with succesful creations for blog and articles. So 
I tried locally with R17 HEAD too, after doing a "{{g cleanAll eclipse loadAll 
ofbiz}}" to be sure there was no interactions with a previous existing trunk 
Derby DB.

I was able to create a new "test" blog, but not to create a "test" article 
inside it. The problem is with the createContentPurpose service. It works in 
trunk, did not try with R18. Here is the whole (sorry long but complete) trace:

{noformat}
     __  _
  / __ \/ / __ )(_)___
 / / / / /_  / __  / /_  /
/ /_/ / __/ / /_/ / / / /_
\/_/   /_/_/ /___/  is started and ready.

2020-09-26 12:52:16,162 |main |BirtContainer 
|I| BIRT supported formats: xlsx, postscript, docx, pptx, pdf, ppt, 
xls_spudsoft, doc, html, odp, xls, odt, ods
2020-09-26 12:52:16,162 |main |ContainerLoader   
|I| Started container birt-container
2020-09-26 12:52:16,922 |OFBiz-JobPoller  |JobManager
|I| No crashed jobs to re-schedule
2020-09-26 12:52:17,045 |OFBiz-JobQueue-1 |TransactionUtil   
|W| No transaction in place, so not suspending.
2020-09-26 12:52:17,052 |OFBiz-JobQueue-1 |SequenceUtil  
|W| Lock failed; no sequence row was found, will try to add a new one for 
sequence: JobSandbox
2020-09-26 12:52:17,066 |OFBiz-JobQueue-1 |SequenceUtil  
|I| Got bank of sequenced IDs for [JobSandbox]; curSeqId=1, maxSeqId=10100, 
bankSize=100
2020-09-26 12:52:17,072 |OFBiz-JobQueue-0 |PersistedServiceJob   
|I| Job  [Delete auto-save shopping list for anonymous users] Id [8009] -- Next 
runtime: Sun Sep 27 00:00:00 CEST 2020
2020-09-26 12:52:17,072 |OFBiz-JobQueue-1 |PersistedServiceJob   
|I| Job  [Create Also Bought Product Associations] Id [8008] -- Next runtime: 
Sun Sep 27 00:00:00 CEST 2020
2020-09-26 12:52:17,089 |OFBiz-JobQueue-0 |AbstractEngine
|I| Loaded Service Locations: 
{eedcc-test=https://localhost:8443/webtools/control/httpService, 
entity-sync-http=https://localhost:8443/webtools/control/httpServ
ice, rita-rmi=rmi://localhost:1099/RMIDispatcher, 
main-rmi=rmi://localhost:1099/RMIDispatcher, 
main-soap=http://localhost:8080/webtools/control/SOAPService, 
entity-sync-rmi=rmi://localhost:1099/RMIDispatcher, main-http=http://localhost:8
080/webtools/control/httpService}
2020-09-26 12:52:17,160 |OFBiz-JobQueue-0 |ServiceDispatcher 
|T| Sync service [default/autoDeleteAutoSaveShoppingList] finished in [77] 
milliseconds
2020-09-26 12:52:17,168 |OFBiz-JobQueue-0 |PersistedServiceJob   
|I| Job  [Replacement Held Order Auto-Cancel] Id [8007] -- Next runtime: Sun 
Sep 27 00:00:00 CEST 2020
2020-09-26 12:52:17,222 |OFBiz-JobQueue-0 |ServiceDispatcher 
|T| Sync service [default/autoCancelReplacementOrders] finished in [53] 
milliseconds
2020-09-26 12:52:17,244 |OFBiz-JobQueue-0 |PersistedServiceJob   
|I| Job  [BackOrder Notification] Id [8000] -- Next runtime: Sun Sep 27 
00:00:00 CEST 2020
2020-09-26 12:52:17,282 |OFBiz-JobQueue-0 |InventoryServices 
|I| OOS Inventory Items: 0
2020-09-26 12:52:17,282 |OFBiz-JobQueue-0 |ServiceDispatcher 
|T| Sync service [default/checkInventoryAvailability] finished in [38] 
milliseconds
2020-09-26 12:52:17,291 |OFBiz-JobQueue-0 |PersistedServiceJob   
|I| Job  [Auto-create Fixed Asset Maintenances] Id [FAM_AUTO_CREATE] -- Next 
runtime: Sat Sep 26 13:52:17 CEST 2020
2020-09-26 12:52:17,358 |OFBiz-JobQueue-1 |ServiceDispatcher 
|T| Sync service [default/createAlsoBoughtProductAssocsForOrder] finished in 
[161] milliseconds
2020-09-26 12:52:17,361 |OFBiz-JobQueue-1 |ServiceDispatcher 
|T| Sync service [default/createAlsoBoughtProductAssocsForOrder] finished in 
[3] milliseconds
2020-09-26 12:52:17,361 |OFBiz-JobQueue-1 |ServiceDispatcher 
|T| Sync service [default/createAlsoBoughtProductAssocs] finished in [278] 
milliseconds
2020-09-26 12:52:17,391 |OFBiz-JobQueue-1 |PersistedServiceJob   
|W| Persisted Job [9000] references a RecurrenceInfo, recommend using 
TemporalExpression instead
2020-09-26 12:52:17,406 |OFBiz-JobQueue-0 |ScriptUtil
|I| The following 2 scripting engines were found:
2020-09-26 12:52:17,406 |OFBiz-JobQueue-0 |ScriptUtil
|I| Engine name: Oracle Nashorn
2020-09-26 12:52:17,407 |OFBiz-JobQueue-0 |ScriptUtil
|I|   Version: 1.8.0_202
2020-09-26 12:52:17,407 |OFBiz-JobQueue-0 |ScriptUtil
|I|   Language: ECMAScript
2020-09-26 

[jira] [Commented] (OFBIZ-10512) Change order of parameters in runSyncIgnore

2020-09-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202581#comment-17202581
 ] 

Jacques Le Roux commented on OFBIZ-10512:
-

That's right Pradeep,

I was more thinking about moving {{Map context}} to 
the end when I "plussed". This said this is very minor and I don't think it's 
worth the whole refactoring effort if nothing is provided by the reporter. So 
please feel free to close as "Won't do" if you think so :)

> Change order of parameters in runSyncIgnore
> ---
>
> Key: OFBIZ-10512
> URL: https://issues.apache.org/jira/browse/OFBIZ-10512
> Project: OFBiz
>  Issue Type: Wish
>Reporter: Niklas Fallik
>Priority: Minor
>
> It is confusing that the order of the arguments passed to 
> LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
> cf.
> {code:java}
> void runSyncIgnore(String serviceName, Map context, 
> int transactionTimeout, boolean requireNewTransaction) throws 
> ServiceAuthException, ServiceValidationException, GenericServiceException;
> {code}
>  
> {code:java}
> void runSyncIgnore(String serviceName, int transactionTimeout, boolean 
> requireNewTransaction, Object... context) throws ServiceAuthException, 
> ServiceValidationException, GenericServiceException; {code}
> cf.
> LocalDispatcher.java[101 + 102]
>  
> The context parameter could be passed as second or as fourth argument, no 
> matter if it is a Map or an Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12013) Create button should be removed from create screen of various Catalog features

2020-09-26 Thread Kirti Arora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirti Arora reassigned OFBIZ-12013:
---

Assignee: Kirti Arora  (was: Akash Jain)

> Create button should be removed from create screen of various Catalog features
> --
>
> Key: OFBIZ-12013
> URL: https://issues.apache.org/jira/browse/OFBIZ-12013
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product/catalog
>Reporter: Akash Jain
>Assignee: Kirti Arora
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #235: OFBIZ-11855 Improved: Convert RoutingServices.xml mini lang to groovy.

2020-09-26 Thread GitBox


sonarcloud[bot] commented on pull request #235:
URL: https://github.com/apache/ofbiz-framework/pull/235#issuecomment-699477360


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=235=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=235=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=235=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=235=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=235=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=235=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=235=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_ofbiz-framework=235=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=235=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=235=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=235=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=235)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=235=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=235=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11855) Convert RoutingServices.xml mini-lang to groovy

2020-09-26 Thread Yashwant Dhakad (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202580#comment-17202580
 ] 

Yashwant Dhakad commented on OFBIZ-11855:
-

I have completed the migration from mini lang to groovy for both 
(getProductRouting, getRoutingTaskAssocs) services.

> Convert RoutingServices.xml mini-lang to groovy
> ---
>
> Key: OFBIZ-11855
> URL: https://issues.apache.org/jira/browse/OFBIZ-11855
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Wiebke Pätzold
>Assignee: Yashwant Dhakad
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11728) Create new component, data configuration and connection request

2020-09-26 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11728:
-

Assignee: Suraj Khurana  (was: Shikha Jaiswal)

> Create new component, data configuration and connection request
> ---
>
> Key: OFBIZ-11728
> URL: https://issues.apache.org/jira/browse/OFBIZ-11728
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Shikha Jaiswal
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11728.patch
>
>
> We will be doing following tasks in this ticket:
> # Create a new component named *shopify*
> # Basic configuration data setup
> # Implement a method for HTTP connection request with Shopify
> To store configuration details we will create entity *ShopifyConfig*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] yashwantdhakad opened a new pull request #235: OFBIZ-11855 Improved: Convert RoutingServices.xml mini lang to groovy.

2020-09-26 Thread GitBox


yashwantdhakad opened a new pull request #235:
URL: https://github.com/apache/ofbiz-framework/pull/235


   OFBIZ-11855 Improved: Convert RoutingServices.xml mini lang to groovy.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (OFBIZ-11867) Convert ShoppingCartTests.xml to Groovy

2020-09-26 Thread Praveen Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma reassigned OFBIZ-11867:
--

Assignee: Praveen Sharma

> Convert ShoppingCartTests.xml to Groovy
> ---
>
> Key: OFBIZ-11867
> URL: https://issues.apache.org/jira/browse/OFBIZ-11867
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Praveen Sharma
>Priority: Minor
> Attachments: OFBIZ-11867.patch
>
>
> Convert ShoppingCartTests XML file to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11861) Convert ShoppingListTests.xml to Groovy

2020-09-26 Thread Praveen Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202579#comment-17202579
 ] 

Praveen Sharma commented on OFBIZ-11861:


Attached the patch for the same.
This can be tested using this command:
./gradlew "ofbiz --test component=order --test suitename=shoppinglisttests"

> Convert ShoppingListTests.xml to Groovy
> ---
>
> Key: OFBIZ-11861
> URL: https://issues.apache.org/jira/browse/OFBIZ-11861
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Praveen Sharma
>Priority: Minor
> Attachments: OFBIZ-11861.patch
>
>
> Convert ShoppingListTests XML file to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11861) Convert ShoppingListTests.xml to Groovy

2020-09-26 Thread Praveen Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma updated OFBIZ-11861:
---
Attachment: OFBIZ-11861.patch

> Convert ShoppingListTests.xml to Groovy
> ---
>
> Key: OFBIZ-11861
> URL: https://issues.apache.org/jira/browse/OFBIZ-11861
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Praveen Sharma
>Priority: Minor
> Attachments: OFBIZ-11861.patch
>
>
> Convert ShoppingListTests XML file to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10512) Change order of parameters in runSyncIgnore

2020-09-26 Thread Pradeep Choudhary (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202578#comment-17202578
 ] 

Pradeep Choudhary commented on OFBIZ-10512:
---

Here,


{code:java}
void runSyncIgnore(String serviceName, int transactionTimeout, boolean 
requireNewTransaction, Object... context) throws ServiceAuthException, 
ServiceValidationException, GenericServiceException; {code}

'context' parameter is used as var args (variable argument) in this method ie. 
This argument can accept variable number of values.

As per the java conventions, it should be always at the last of the list. If we 
try to move it, java shows the following error: "Vararg parameter must be the 
last in the list".

We can also check the reference for this it
{code:java}
@Override
public void runSyncIgnore(String serviceName, int transactionTimeout, boolean 
requireNewTransaction, Object... context)
 throws ServiceAuthException, ServiceValidationException, 
GenericServiceException {
 runSyncIgnore(serviceName, ServiceUtil.makeContext(context), 
transactionTimeout, requireNewTransaction);
}{code}
GenericDispatcherFactory.java [141]

I this above example, same method calls the override method to place the 
'context' param at 2nd place.

We can't change the position of context parameter in runSyncIgnore method due 
to java limitation for using varargs.

> Change order of parameters in runSyncIgnore
> ---
>
> Key: OFBIZ-10512
> URL: https://issues.apache.org/jira/browse/OFBIZ-10512
> Project: OFBiz
>  Issue Type: Wish
>Reporter: Niklas Fallik
>Priority: Minor
>
> It is confusing that the order of the arguments passed to 
> LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
> cf.
> {code:java}
> void runSyncIgnore(String serviceName, Map context, 
> int transactionTimeout, boolean requireNewTransaction) throws 
> ServiceAuthException, ServiceValidationException, GenericServiceException;
> {code}
>  
> {code:java}
> void runSyncIgnore(String serviceName, int transactionTimeout, boolean 
> requireNewTransaction, Object... context) throws ServiceAuthException, 
> ServiceValidationException, GenericServiceException; {code}
> cf.
> LocalDispatcher.java[101 + 102]
>  
> The context parameter could be passed as second or as fourth argument, no 
> matter if it is a Map or an Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12023) Label issue on List Companies page

2020-09-26 Thread Pradeep Choudhary (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary reassigned OFBIZ-12023:
-

Assignee: Pradeep Choudhary  (was: Lalit Dashora)

> Label issue on List Companies page
> --
>
> Key: OFBIZ-12023
> URL: https://issues.apache.org/jira/browse/OFBIZ-12023
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Pradeep Choudhary
>Priority: Major
> Attachments: importExportUiLableIssue.png
>
>
> # Navigate to URL: 'accounting/control/ListCompanies'
>  # Under the companies list, the last column has button for import export.
>  # The System is not showing proper label.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11605) Unable to change Order Status

2020-09-26 Thread Nameet Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202577#comment-17202577
 ] 

Nameet Jain commented on OFBIZ-11605:
-

[~Rahul.marjiwe] I followed the steps shared in the description.  I was not 
able to replicate the reported issue.
 
Can you please share more details or some screenshots if you are able to 
reproduce the issue?

Thanks

> Unable to change Order Status 
> --
>
> Key: OFBIZ-11605
> URL: https://issues.apache.org/jira/browse/OFBIZ-11605
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Rahul Marjiwe
>Assignee: Rahul Marjiwe
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11605.patch
>
>
> Step to generate:
>  # Go to the order manager and select the order entry menu.
>  #  select the supplier for a purchase order and click on continue.
>  #  In Create  Purchase Order screen add any product Id, quantity, and click 
> on add to order.
>  # Click on Finalize order and continue.
>  #  On Purchase Order : Order Entry Ship-To Settings click on continue.
>  #  For order notes and additional party-id click on continue.
>  # In order-confirmation screen click on Create Order button.
>  # In orderview screen click on approve order button. 
> Actual: it is rendering the error message after click on  approve order 
> button. 
> Expected: Change order status created to approve. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12023) Label issue on List Companies page

2020-09-26 Thread Lalit Dashora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora reassigned OFBIZ-12023:
-

Assignee: Lalit Dashora

> Label issue on List Companies page
> --
>
> Key: OFBIZ-12023
> URL: https://issues.apache.org/jira/browse/OFBIZ-12023
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: importExportUiLableIssue.png
>
>
> # Navigate to URL: 'accounting/control/ListCompanies'
>  # Under the companies list, the last column has button for import export.
>  # The System is not showing proper label.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12023) Label issue on List Companies page

2020-09-26 Thread Lalit Dashora (Jira)
Lalit Dashora created OFBIZ-12023:
-

 Summary: Label issue on List Companies page
 Key: OFBIZ-12023
 URL: https://issues.apache.org/jira/browse/OFBIZ-12023
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Trunk
Reporter: Lalit Dashora
 Attachments: importExportUiLableIssue.png

# Navigate to URL: 'accounting/control/ListCompanies'
 # Under the companies list, the last column has button for import export.
 # The System is not showing proper label.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2020-09-26 Thread Archana Asthana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202576#comment-17202576
 ] 

Archana Asthana commented on OFBIZ-10386:
-

Hello [~praveen.patil] I think marketing one will be more sensible, Please go 
ahead with this one.

> Empty field is reflecting on Contact list section on Profile Page
> -
>
> Key: OFBIZ-10386
> URL: https://issues.apache.org/jira/browse/OFBIZ-10386
> Project: OFBiz
>  Issue Type: Bug
> Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
>Reporter: Archana Asthana
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: EmptyFields.png, ViewProfile.patch
>
>
> Steps to generate: 
> Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
> On the profile page, Go down to Contact list
> Empty fields are displaying before Verify Subscription button
> Expected: The field should have some specifications to be filled up
> Image is attached for reference



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11387) Convert createMissingCategoryContentAltUrlInline service from mini-lang to groovy DSL

2020-09-26 Thread Anushi Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anushi Gupta updated OFBIZ-11387:
-
Attachment: OFBIZ-11387.patch

> Convert createMissingCategoryContentAltUrlInline service from mini-lang to 
> groovy DSL
> -
>
> Key: OFBIZ-11387
> URL: https://issues.apache.org/jira/browse/OFBIZ-11387
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Anushi Gupta
>Priority: Major
> Attachments: OFBIZ-11387.patch
>
>
> Convert createMissingCategoryContentAltUrlInline service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11901) Provide OOTB support to calculate distance between two geo points

2020-09-26 Thread Ravi Lodhi (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202572#comment-17202572
 ] 

Ravi Lodhi commented on OFBIZ-11901:


Hello [~surajk],

The patch looks good to me. Thanks for implementing this.

> Provide OOTB support to calculate distance between two geo points
> -
>
> Key: OFBIZ-11901
> URL: https://issues.apache.org/jira/browse/OFBIZ-11901
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11901.patch
>
>
> Though there are many third party capabilities available in the form of 
> API's, this can easily be calculated within OFBiz as well.
> This method will be providing direct spatial distance between two geo points.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #14: Implemented: Added new inventory cycle count feature for warehouse.(OFBIZ-10577)

2020-09-26 Thread GitBox


sonarcloud[bot] commented on pull request #14:
URL: https://github.com/apache/ofbiz-framework/pull/14#issuecomment-699472445


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issues?id
 =apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) 
to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2020-09-26 Thread Praveen Patil (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202569#comment-17202569
 ] 

Praveen Patil commented on OFBIZ-10386:
---

Hi [~archana.asthana] as Devanshu said, there is a text field already available 
in what you are referring to as blank space, we just need the proper header 
name for that. The patch that I have provided has  
"_FormFieldTitle_optInVerifyCode_" label, can you just confirm which one is 
more suitable for the purpose out of Denanshu's suggestions.  

> Empty field is reflecting on Contact list section on Profile Page
> -
>
> Key: OFBIZ-10386
> URL: https://issues.apache.org/jira/browse/OFBIZ-10386
> Project: OFBiz
>  Issue Type: Bug
> Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
>Reporter: Archana Asthana
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: EmptyFields.png, ViewProfile.patch
>
>
> Steps to generate: 
> Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
> On the profile page, Go down to Contact list
> Empty fields are displaying before Verify Subscription button
> Expected: The field should have some specifications to be filled up
> Image is attached for reference



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2020-09-26 Thread Archana Asthana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202565#comment-17202565
 ] 

Archana Asthana commented on OFBIZ-10386:
-

Thank you so much Praveen and Devanshu for your efforts. Yes, as you can refer 
to the image attached, the entire section seems empty with the header and the 
content missing in that field. 
So please provide the appropriate solution for this issue. I agree that there 
should be a header column to tell the purpose of the text boxes, before the 
Verify Subscription button. 

> Empty field is reflecting on Contact list section on Profile Page
> -
>
> Key: OFBIZ-10386
> URL: https://issues.apache.org/jira/browse/OFBIZ-10386
> Project: OFBiz
>  Issue Type: Bug
> Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
>Reporter: Archana Asthana
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: EmptyFields.png, ViewProfile.patch
>
>
> Steps to generate: 
> Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
> On the profile page, Go down to Contact list
> Empty fields are displaying before Verify Subscription button
> Expected: The field should have some specifications to be filled up
> Image is attached for reference



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10426) When creating blog or forums, it failed to save

2020-09-26 Thread Aman Mishra (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Mishra updated OFBIZ-10426:

Attachment: OFBIZ-10426-R17-Blog.png
OFBIZ-10426-R17-Article.png

> When creating blog or forums, it failed to save
> ---
>
> Key: OFBIZ-10426
> URL: https://issues.apache.org/jira/browse/OFBIZ-10426
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jason Hao
>Assignee: Aman Mishra
>Priority: Major
> Attachments: OFBIZ-10426-R17-Article.png, OFBIZ-10426-R17-Blog.png, 
> OFBIZ-10426-Working.png, blog-error.png
>
>
> Create a blog or forum and click save button, it will popup with error 
> message. The reason is because the mapKey passed from front end cannot be 
> handled by the service. The solution is not to pass the mapKey to the service.
> Steps:  
> 1) navigate to 
> https://demo-trunk.ofbiz.apache.org/content/control/blogContent?blogContentId=BLOGROOTBIGAL
> 2) create a new article  
> https://demo-trunk.ofbiz.apache.org/content/control/EditBlogArticle?blogContentId=BLOGROOTBIGAL
>  
> ERROR: Could not complete the Post a new Content article Entry 
> [file:/Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent|file:///Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent]
>  process [problem invoking the [createTextContent] service with the map named 
> [createText] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-06-01 
> 21:38:24.088(java.sql.Timestamp)][createdTxStamp,2018-06-01 
> 21:38:24.086(java.sql.Timestamp)][currentPassword,
> {SHA}
> 47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Shanghai(java.lang.String)][lastUpdatedStamp,2018-06-02
>  03:00:52.632(java.sql.Timestamp)][lastUpdatedTxStamp,2018-06-02 
> 03:00:52.632(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
>  textData=hello, dataTemplateTypeId=NONE, mapKey=MAIN, contentIdFrom=ASK, 
> description=hello, partyId=admin, locale=en_US, 
> dataResourceTypeId=ELECTRONIC_TEXT, contentName=hell world}]: Unknown 
> parameter found: [createTextContent.contentIdFrom]Unknown parameter found: 
> [createTextContent.mapKey]]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole

2020-09-26 Thread Devanshu Vyas (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202562#comment-17202562
 ] 

Devanshu Vyas commented on OFBIZ-10379:
---

I believe, when the AP and AR web apps will be removed, then this would be gone 
along with it. But, until then we can think of it as a bug and try to fix it.

> Exception handling for Add a new Party Role at createInvoiceRole
> 
>
> Key: OFBIZ-10379
> URL: https://issues.apache.org/jira/browse/OFBIZ-10379
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
>Reporter: Aayush jain
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: Error.png, OFBIZ-10379.patch
>
>
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
> 2. Add a party Id which does not assigned as a role for accounts
> 3. Enter Percentage
> 4. Click on submit button
> Actual Result: 
> Throwing an exception error for the invalid case, Kindly refer attachment for 
> the same
> Expected Result:
> We must handle exceptions with a proper error message, I don't think this is 
> working fine, It should be correct with proper message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-09-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202561#comment-17202561
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit 1361c3cdaf7d6756cc9abdc6c37450ef3d46f921 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=1361c3c ]

Improved: Updated code to bypass auth for services having auth=false
2. Implemented ServiceValidationFilter to return various HTTP responses based 
on request's context(OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2020-09-26 Thread Devanshu Vyas (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202559#comment-17202559
 ] 

Devanshu Vyas commented on OFBIZ-10386:
---

Hello [~archana.asthana], 

I checked on the profile screen and found that there is a text box before the 
Verify Subscription button. Are you reporting the missing of the text box?

OR
as per the patch from [~praveen.patil], there should be a header/column for the 
text box. And in this case, I would suggest using 
_MarketingContactListOptInVerifyCode_ as the UiLabel instead of 
_FormFieldTitle_optInVerifyCode_.

Let me know which is the case, so we can finalize on a solution. Cause we have 
both ready.

 

> Empty field is reflecting on Contact list section on Profile Page
> -
>
> Key: OFBIZ-10386
> URL: https://issues.apache.org/jira/browse/OFBIZ-10386
> Project: OFBiz
>  Issue Type: Bug
> Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
>Reporter: Archana Asthana
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: EmptyFields.png, ViewProfile.patch
>
>
> Steps to generate: 
> Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
> On the profile page, Go down to Contact list
> Empty fields are displaying before Verify Subscription button
> Expected: The field should have some specifications to be filled up
> Image is attached for reference



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11901) Provide OOTB support to calculate distance between two geo points

2020-09-26 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202558#comment-17202558
 ] 

Suraj Khurana commented on OFBIZ-11901:
---

Hello [~lodhiravi],

I have attached a patch, could you please review it.

TIA.

> Provide OOTB support to calculate distance between two geo points
> -
>
> Key: OFBIZ-11901
> URL: https://issues.apache.org/jira/browse/OFBIZ-11901
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11901.patch
>
>
> Though there are many third party capabilities available in the form of 
> API's, this can easily be calculated within OFBiz as well.
> This method will be providing direct spatial distance between two geo points.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11901) Provide OOTB support to calculate distance between two geo points

2020-09-26 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11901:
--
Attachment: OFBIZ-11901.patch

> Provide OOTB support to calculate distance between two geo points
> -
>
> Key: OFBIZ-11901
> URL: https://issues.apache.org/jira/browse/OFBIZ-11901
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11901.patch
>
>
> Though there are many third party capabilities available in the form of 
> API's, this can easily be calculated within OFBiz as well.
> This method will be providing direct spatial distance between two geo points.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12022) Extra whitespace in code

2020-09-26 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-12022.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This fixed around *42* checkstyle issues.

> Extra whitespace in code
> 
>
> Key: OFBIZ-12022
> URL: https://issues.apache.org/jira/browse/OFBIZ-12022
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12022.patch
>
>
> Found some code occurences where there are some extra spaces, need to correct 
> them for checkstyle



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12022) Extra whitespace in code

2020-09-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202553#comment-17202553
 ] 

ASF subversion and git services commented on OFBIZ-12022:
-

Commit 1ff89570320263e92514ffad637252ba3473cf3e in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1ff8957 ]

Improved: Corrected some spacing issues in code, where there are extra white 
spaces, this will fix some checkstyle issues in applications component.
(OFBIZ-12022)


> Extra whitespace in code
> 
>
> Key: OFBIZ-12022
> URL: https://issues.apache.org/jira/browse/OFBIZ-12022
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Trivial
> Attachments: OFBIZ-12022.patch
>
>
> Found some code occurences where there are some extra spaces, need to correct 
> them for checkstyle



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12022) Extra whitespace in code

2020-09-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202552#comment-17202552
 ] 

ASF subversion and git services commented on OFBIZ-12022:
-

Commit acdddaf85ccffdb3764dc274e7b9ef46ea6e469a in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=acdddaf ]

Improved: Corrected some spacing issues in code, where there are extra white 
spaces, this will fix some checkstyle issues in framework component.
(OFBIZ-12022)


> Extra whitespace in code
> 
>
> Key: OFBIZ-12022
> URL: https://issues.apache.org/jira/browse/OFBIZ-12022
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Trivial
> Attachments: OFBIZ-12022.patch
>
>
> Found some code occurences where there are some extra spaces, need to correct 
> them for checkstyle



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12021) "description" and "comment" datatypes unnecessarily limited to 255 char

2020-09-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202548#comment-17202548
 ] 

Jacques Le Roux commented on OFBIZ-12021:
-

Hi,

I think you are right, and we can take the "risk". I'll though ask on dev ML if 
it's OK for everyone and will wait a week before commiting in case of ["lazy 
consensus"|http://community.apache.org/committers/lazyConsensus.html]

> "description" and "comment" datatypes unnecessarily limited to 255 char 
> 
>
> Key: OFBIZ-12021
> URL: https://issues.apache.org/jira/browse/OFBIZ-12021
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel, framework/entity
>Reporter: ddev
>Priority: Minor
> Attachments: documentation-first-draft.diff, field-types-v2.diff
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> "description" and "comment" fields are restricted to 255 char.  However after 
> some research I found that all the supported databases support longer then 
> 255 char
> I would expect users to want to write more then 255 char in a comment (I know 
> I personally can).
> I have included diff of my proposed solution as a attachment  (I am 
> unfamiliar with the procedures for submitting patches here)
> A discussion has been started on dev ML: 
> https://markmail.org/message/7utrgejc2c44i37u
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11374) Convert createSimpleTextContent service from mini-lang to groovy DSL

2020-09-26 Thread Sourabh Punyani (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202545#comment-17202545
 ] 

Sourabh Punyani commented on OFBIZ-11374:
-

Hello [~devanshu],

I have added a patch(OFBIZ-11374.patch) for the same.

Please verify.

> Convert createSimpleTextContent service from mini-lang to groovy DSL
> 
>
> Key: OFBIZ-11374
> URL: https://issues.apache.org/jira/browse/OFBIZ-11374
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
> Attachments: OFBIZ-11374.patch
>
>
> Convert createSimpleTextContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11374) Convert createSimpleTextContent service from mini-lang to groovy DSL

2020-09-26 Thread Sourabh Punyani (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sourabh Punyani updated OFBIZ-11374:

Attachment: OFBIZ-11374.patch

> Convert createSimpleTextContent service from mini-lang to groovy DSL
> 
>
> Key: OFBIZ-11374
> URL: https://issues.apache.org/jira/browse/OFBIZ-11374
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
> Attachments: OFBIZ-11374.patch
>
>
> Convert createSimpleTextContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11378) Convert createCommContentDataResource service from mini-lang to groovy DSL

2020-09-26 Thread Anushi Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anushi Gupta updated OFBIZ-11378:
-
Attachment: OFBIZ-11378.patch

> Convert createCommContentDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11378
> URL: https://issues.apache.org/jira/browse/OFBIZ-11378
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Anushi Gupta
>Priority: Minor
> Attachments: OFBIZ-11378.patch
>
>
> Convert createCommContentDataResource service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-26 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11926.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Indeed, thanks for the reminder Suraj

> Checkstyle: Variable name must match pattern
> 
>
> Key: OFBIZ-11926
> URL: https://issues.apache.org/jira/browse/OFBIZ-11926
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, 
> OFBIZ-11926.patch
>
>
> All final data members of the class must match this naming pattern 
> '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12018) Open FTL File from browser

2020-09-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202539#comment-17202539
 ] 

Jacques Le Roux commented on OFBIZ-12018:
-

Hi James,

About
bq. Works with "widget.dev.cmd.openSourceFile=c:\\\photon\\\eclipse.exe 
${sourceLocation}"
I set a wrong path, it works in  bakend with the default, ie
widget.dev.cmd.openSourceFile=eclipse ${sourceLocation}

 is in ecommerce controller and it works also 
in ecommerce but not ecomseo. 

I thought it could be relatated to this line
{{if (!path.contains("common-theme") && !path.contains("ecommerce")) {}}
but changing to 
{{if (!path.contains("common-theme") && !path.contains("ecom")) {}}
does not help


> Open FTL File from browser 
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename 
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11861) Convert ShoppingListTests.xml to Groovy

2020-09-26 Thread Praveen Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma reassigned OFBIZ-11861:
--

Assignee: Praveen Sharma

> Convert ShoppingListTests.xml to Groovy
> ---
>
> Key: OFBIZ-11861
> URL: https://issues.apache.org/jira/browse/OFBIZ-11861
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Praveen Sharma
>Priority: Minor
>
> Convert ShoppingListTests XML file to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11918) Incorrect error message in the checkout page if last name is missing

2020-09-26 Thread Rashi Dhagat (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rashi Dhagat updated OFBIZ-11918:
-
Attachment: AllValidInfo.webm

> Incorrect error message in the checkout page if last name is missing
> 
>
> Key: OFBIZ-11918
> URL: https://issues.apache.org/jira/browse/OFBIZ-11918
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12
>Reporter: Rashi Dhagat
>Assignee: Anushi Gupta
>Priority: Critical
> Attachments: AllValidInfo.webm, LastNameMissing.webm
>
>
> Steps to regenerate:
> 1. Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/ 
> |https://demo-trunk.ofbiz.apache.org/ecomseo/]
> 2. Add item in the cart
> 3. Click on Quick Checkout 
> 4. Click on checkout under Checkout Without Login section
> 5. Enter details
> 6. Select Payment Option as Credit Card
> 7. Enter Details without last name
> 8. Select the shipping method
> 9. Click on Submit Order
> Actual: No message for the last name missing instead "No payment Method Type 
> selected " message displays.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11918) Incorrect error message in the checkout page if last name is missing

2020-09-26 Thread Rashi Dhagat (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202538#comment-17202538
 ] 

Rashi Dhagat edited comment on OFBIZ-11918 at 9/26/20, 7:10 AM:


Hii [~anushi.gupta10],
 I verified this with all valid billing details and its working fine. There 
will be an error if an invalid data is filled. [^AllValidInfo.webm]


was (Author: rashi.dhagat):
Hii [~anushi.gupta10],
I verified this with all valid billing details and its working fine. There will 
be an error if an invalid data is filled. [^AllInfoCorrect.webm]

> Incorrect error message in the checkout page if last name is missing
> 
>
> Key: OFBIZ-11918
> URL: https://issues.apache.org/jira/browse/OFBIZ-11918
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12
>Reporter: Rashi Dhagat
>Assignee: Anushi Gupta
>Priority: Critical
> Attachments: AllValidInfo.webm, LastNameMissing.webm
>
>
> Steps to regenerate:
> 1. Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/ 
> |https://demo-trunk.ofbiz.apache.org/ecomseo/]
> 2. Add item in the cart
> 3. Click on Quick Checkout 
> 4. Click on checkout under Checkout Without Login section
> 5. Enter details
> 6. Select Payment Option as Credit Card
> 7. Enter Details without last name
> 8. Select the shipping method
> 9. Click on Submit Order
> Actual: No message for the last name missing instead "No payment Method Type 
> selected " message displays.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11918) Incorrect error message in the checkout page if last name is missing

2020-09-26 Thread Rashi Dhagat (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rashi Dhagat updated OFBIZ-11918:
-
Attachment: (was: AllInfoCorrect.webm)

> Incorrect error message in the checkout page if last name is missing
> 
>
> Key: OFBIZ-11918
> URL: https://issues.apache.org/jira/browse/OFBIZ-11918
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12
>Reporter: Rashi Dhagat
>Assignee: Anushi Gupta
>Priority: Critical
> Attachments: LastNameMissing.webm
>
>
> Steps to regenerate:
> 1. Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/ 
> |https://demo-trunk.ofbiz.apache.org/ecomseo/]
> 2. Add item in the cart
> 3. Click on Quick Checkout 
> 4. Click on checkout under Checkout Without Login section
> 5. Enter details
> 6. Select Payment Option as Credit Card
> 7. Enter Details without last name
> 8. Select the shipping method
> 9. Click on Submit Order
> Actual: No message for the last name missing instead "No payment Method Type 
> selected " message displays.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >