[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #325: (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation

2021-11-02 Thread GitBox


JacquesLeRoux merged pull request #325:
URL: https://github.com/apache/ofbiz-framework/pull/325


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #330: (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation

2021-11-02 Thread GitBox


JacquesLeRoux merged pull request #330:
URL: https://github.com/apache/ofbiz-framework/pull/330


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #329: Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation"

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #329:
URL: https://github.com/apache/ofbiz-framework/pull/329#issuecomment-957266373


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=329=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=329=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=329=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=329)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=329=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #328: Improved: seed data (OFBIZ-12355)

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #328:
URL: https://github.com/apache/ofbiz-framework/pull/328#issuecomment-957263785


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=328=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=328=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=328=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=328)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=328=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=328=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #330: (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #330:
URL: https://github.com/apache/ofbiz-framework/pull/330#issuecomment-957306907


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=330=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=330=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=330=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=330)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=330=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=330=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #327: Fixed: Quote item quantity field not visable (OFBIZ-12357)

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #327:
URL: https://github.com/apache/ofbiz-framework/pull/327#issuecomment-957185768


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=327=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=327=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=327=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=327)
 No Coverage information  
   
[![0.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.1%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=327=new_duplicated_lines_density=list)
 [0.1% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=327=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #328: Improved: seed data (OFBIZ-12355)

2021-11-02 Thread GitBox


JacquesLeRoux merged pull request #328:
URL: https://github.com/apache/ofbiz-framework/pull/328


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #325: (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation

2021-11-02 Thread GitBox


JacquesLeRoux merged pull request #325:
URL: https://github.com/apache/ofbiz-framework/pull/325


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #326: Fixed: Quote item quantity field not visable (OFBIZ 12357)

2021-11-02 Thread GitBox


JacquesLeRoux merged pull request #326:
URL: https://github.com/apache/ofbiz-framework/pull/326


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #326: Fixed: Quote item quantity field not visable (OFBIZ 12357)

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #326:
URL: https://github.com/apache/ofbiz-framework/pull/326#issuecomment-956325201






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #330: (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation

2021-11-02 Thread GitBox


JacquesLeRoux merged pull request #330:
URL: https://github.com/apache/ofbiz-framework/pull/330


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #329: Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation"

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #329:
URL: https://github.com/apache/ofbiz-framework/pull/329#issuecomment-957266373


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=329=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=329=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=329=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=329)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=329=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #328: Improved: seed data (OFBIZ-12355)

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #328:
URL: https://github.com/apache/ofbiz-framework/pull/328#issuecomment-957263785


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=328=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=328=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=328=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=328)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=328=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=328=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #330: (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #330:
URL: https://github.com/apache/ofbiz-framework/pull/330#issuecomment-957306907


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=330=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=330=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=330=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=330)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=330=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=330=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #327: Fixed: Quote item quantity field not visable (OFBIZ-12357)

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #327:
URL: https://github.com/apache/ofbiz-framework/pull/327#issuecomment-957185768


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=327=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=327=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=327=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=327)
 No Coverage information  
   
[![0.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.1%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=327=new_duplicated_lines_density=list)
 [0.1% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=327=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #328: Improved: seed data (OFBIZ-12355)

2021-11-02 Thread GitBox


JacquesLeRoux merged pull request #328:
URL: https://github.com/apache/ofbiz-framework/pull/328


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (OFBIZ-12361) Try to reduce the SARIF file used by CodeQL for Java classes

2021-11-02 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-12361:
---

 Summary: Try to reduce the SARIF file used by CodeQL for Java 
classes
 Key: OFBIZ-12361
 URL: https://issues.apache.org/jira/browse/OFBIZ-12361
 Project: OFBiz
  Issue Type: Improvement
  Components: GitHub
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12356) Try to reduce "Incomplete string escaping or encoding branch" issues reported by CodeQL

2021-11-02 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12356:

Component/s: GitHub

> Try to reduce "Incomplete string escaping or encoding branch" issues reported 
> by CodeQL
> ---
>
> Key: OFBIZ-12356
> URL: https://issues.apache.org/jira/browse/OFBIZ-12356
> Project: OFBiz
>  Issue Type: Improvement
>  Components: GitHub, themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> At 
> https://github.com/apache/ofbiz-framework/security/code-scanning?query=is%3AIncomplete+string+escaping+or+encoding+branch%3Atrunk+severity%3Ahigh
> GH CodeQL reports 556 "Incomplete string escaping or encoding branch" issues 
> (there are 588 issues at all). 
> Most of them are in jQuery-UI but not only:
> {quote}
> Incomplete string escaping or encoding
> (Library) 
> themes/common-theme/webapp/common/js/jquery/ui/jquery-ui-1.12.1.js:17591 • 
> {quote}
> Some are reported inside jQuery itself:
> {quote}
> Incomplete string escaping or encoding
> themes/common-theme/webapp/common/js/jquery/plugins/jsTree/jquery.jstree.js:2961
>  • 
> {quote}
> So this only an attempt to clarify among the 23 pages(!) reported by 
> upgrading jQuery-UI to 1.13.0. 
> While working on this I crossed an issue related to element.form() that is 
> now [element._form() in jQuery-UI 
> 1.13.0|https://jqueryui.com/changelog/1.13.0/#ui-core]. I think it appears 
> only in OfbizUtil.js because it's loaded after jQuery-UI.
> I also tried to load jQuery-UI with npmInstall but unfortunately 
> https://jqueryui.com/upgrade-guide/1.12/#official-package-on-npm (ie 
> jquery-ui.js & jquery-ui-min.js)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12341) Complete checkstyle related work

2021-11-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437453#comment-17437453
 ] 

ASF subversion and git services commented on OFBIZ-12341:
-

Commit a5a878389343ae385e77235cfe242684fe2e94cc in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a5a8783 ]

Improved: Complete checkstyle related work (OFBIZ-12341)

I forgot to put tasks.checkstyleMain.maxErrors at zero.
While at it now show new violations in console


> Complete checkstyle related work
> 
>
> Key: OFBIZ-12341
> URL: https://issues.apache.org/jira/browse/OFBIZ-12341
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> This is an umbrella issue to collect the non completed issues



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12144) Setup Romania GeoData

2021-11-02 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437369#comment-17437369
 ] 

Pierre Smits commented on OFBIZ-12144:
--

Hi Ioan,

Nowadays, there are numerous 3rd party APIs (mostly related to 3rd part 
logistics) that provide services to check and capture postal codes and other 
address details. If such are available for Romania too, consider to create a 
plugin that utilises such API to create and/or update contact mech records.

> Setup Romania GeoData
> -
>
> Key: OFBIZ-12144
> URL: https://issues.apache.org/jira/browse/OFBIZ-12144
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Ioan Eugen Stan
>Assignee: Ioan Eugen Stan
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12145) Setup Romania Tax Authority

2021-11-02 Thread Ioan Eugen Stan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ioan Eugen Stan reassigned OFBIZ-12145:
---

Assignee: Pierre Smits

> Setup Romania Tax Authority
> ---
>
> Key: OFBIZ-12145
> URL: https://issues.apache.org/jira/browse/OFBIZ-12145
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Ioan Eugen Stan
>Assignee: Pierre Smits
>Priority: Major
>  Labels: data, demo
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12345) Add state/provinces for Romania

2021-11-02 Thread Ioan Eugen Stan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ioan Eugen Stan reassigned OFBIZ-12345:
---

Assignee: Ioan Eugen Stan

> Add state/provinces for Romania
> ---
>
> Key: OFBIZ-12345
> URL: https://issues.apache.org/jira/browse/OFBIZ-12345
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Ioan Eugen Stan
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> When creating new contact information we should be able to select the state / 
> provinces in Romania 
> Right now I get : 
> |State/Province|No States/Provinces exist |



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12144) Setup Romania GeoData

2021-11-02 Thread Ioan Eugen Stan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437359#comment-17437359
 ] 

Ioan Eugen Stan commented on OFBIZ-12144:
-

Thanks.

I will check to see if they are in the proper files and focus my efforts in 
adding the other pieces of data: Counties, cities, postal codes, etc. 

> Setup Romania GeoData
> -
>
> Key: OFBIZ-12144
> URL: https://issues.apache.org/jira/browse/OFBIZ-12144
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Ioan Eugen Stan
>Assignee: Ioan Eugen Stan
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12141) Add support for Romania

2021-11-02 Thread Ioan Eugen Stan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ioan Eugen Stan reassigned OFBIZ-12141:
---

Assignee: Ioan Eugen Stan

> Add support for Romania
> ---
>
> Key: OFBIZ-12141
> URL: https://issues.apache.org/jira/browse/OFBIZ-12141
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Ioan Eugen Stan
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> I would like to add support for Romania to OFBiz: provinces, taxes and the 
> rest.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12144) Setup Romania GeoData

2021-11-02 Thread Ioan Eugen Stan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ioan Eugen Stan reassigned OFBIZ-12144:
---

Assignee: Ioan Eugen Stan

> Setup Romania GeoData
> -
>
> Key: OFBIZ-12144
> URL: https://issues.apache.org/jira/browse/OFBIZ-12144
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Ioan Eugen Stan
>Assignee: Ioan Eugen Stan
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party

2021-11-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437269#comment-17437269
 ] 

ASF subversion and git services commented on OFBIZ-5980:


Commit a8ab2be55a96a1aeccc4c07887ebbb4d25b2cc28 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a8ab2be ]

(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation (#330)

added/changed/updated:
- added field definition for from and through date to the entity
- added service for expiration
- request-map for expiration
- appropriate forms to work with  added entity fields
- added groovy code to check existing when adding PartyRole record and call 
expiration service if needed
- adding fromDate value to seed, test and demo data

> Have the ability to revoke (expire) roles of a party
> 
>
> Key: OFBIZ-5980
> URL: https://issues.apache.org/jira/browse/OFBIZ-5980
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: roles
> Fix For: Upcoming Branch
>
>
> Currently it only possible to delete a role.
> Which can lead to potential error messages, when a particular role is 
> associated with records where the roleTypeId is used as a foreign key in the 
> entity-model/database and the user tries to delete that role from the list.
> In order to avoid such, it is better to revoke the PartyRole record by 
> setting an expiration date (end date) on the record.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #330: (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation

2021-11-02 Thread GitBox


JacquesLeRoux merged pull request #330:
URL: https://github.com/apache/ofbiz-framework/pull/330


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #330: (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #330:
URL: https://github.com/apache/ofbiz-framework/pull/330#issuecomment-957306907


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=330=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=330=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=330=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=330=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=330)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=330=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=330=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12355) Have a PartyRelationshipType for Employment

2021-11-02 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437267#comment-17437267
 ] 

Pierre Smits commented on OFBIZ-12355:
--

Thanks, Jaques, for your assistance to get this in the code base.

> Have a PartyRelationshipType for Employment
> ---
>
> Key: OFBIZ-12355
> URL: https://issues.apache.org/jira/browse/OFBIZ-12355
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Currently we have in our seed data RoleType records for Employer and 
> Employee. However, when used in a PartyRelationship record the associated 
> PartyRelationshipTypeId record is not available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12355) Have a PartyRelationshipType for Employment

2021-11-02 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437266#comment-17437266
 ] 

Pierre Smits commented on OFBIZ-12355:
--

It appears there is already a PartyRelationshipType record with the id 
'EMPLOYMENT', however the name is wrong.

> Have a PartyRelationshipType for Employment
> ---
>
> Key: OFBIZ-12355
> URL: https://issues.apache.org/jira/browse/OFBIZ-12355
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Currently we have in our seed data RoleType records for Employer and 
> Employee. However, when used in a PartyRelationship record the associated 
> PartyRelationshipTypeId record is not available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #330: (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation

2021-11-02 Thread GitBox


PierreSmits opened a new pull request #330:
URL: https://github.com/apache/ofbiz-framework/pull/330


   added/changed/updated:
   - added field definition for from and through date to the entity
   - added service for expiration
   - request-map for expiration
   - appropriate forms to work with  added entity fields
   - added groovy code to check existing when adding PartyRole record and call 
expiration service if needed
   - adding fromDate value to seed, test and demo data
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-12355) Have a PartyRelationshipType for Employment

2021-11-02 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12355.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Have a PartyRelationshipType for Employment
> ---
>
> Key: OFBIZ-12355
> URL: https://issues.apache.org/jira/browse/OFBIZ-12355
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Currently we have in our seed data RoleType records for Employer and 
> Employee. However, when used in a PartyRelationship record the associated 
> PartyRelationshipTypeId record is not available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12355) Have a PartyRelationshipType for Employment

2021-11-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437263#comment-17437263
 ] 

ASF subversion and git services commented on OFBIZ-12355:
-

Commit b204b867b40787dbcc5a17a30c1d22ade1a422cc in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b204b86 ]

Improved: seed data (OFBIZ-12355) (#328)

Name of the PartyRelationshipType

> Have a PartyRelationshipType for Employment
> ---
>
> Key: OFBIZ-12355
> URL: https://issues.apache.org/jira/browse/OFBIZ-12355
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> Currently we have in our seed data RoleType records for Employer and 
> Employee. However, when used in a PartyRelationship record the associated 
> PartyRelationshipTypeId record is not available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #328: Improved: seed data (OFBIZ-12355)

2021-11-02 Thread GitBox


JacquesLeRoux merged pull request #328:
URL: https://github.com/apache/ofbiz-framework/pull/328


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12357) Quote: Quote item quantity field not visable

2021-11-02 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437260#comment-17437260
 ] 

Jacques Le Roux commented on OFBIZ-12357:
-

Pierre,

Actually we don't need to backport, so you can close your PR. The error is due 
to OFBIZ-7532, exactly https://s.apache.org/rpdmx. Took me a while to find it.

That's also while I wrongly reverted c431f0657a2fa96ee4a3ce314cdd04d2d5277ecd  
instead of 46f7ee91d3355b3e10a5b2732797591c748a27dd; ie I reverted the change 
here instead of my commit for OFBIZ-5980 :/

Often ignored but backporting is often really hard work. Next time please be 
sure to what you put in "Affects Version/s" field. 

I let you correct it and close, TIA

> Quote: Quote item quantity field not visable
> 
>
> Key: OFBIZ-12357
> URL: https://issues.apache.org/jira/browse/OFBIZ-12357
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.08, 18.12.01
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Major
>  Labels: quote, quote-item
> Fix For: Upcoming Branch
>
> Attachments: Screen Shot 2021-10-31 at 11.18.51 AM.png
>
>
> When I go to enter a quote item, the quantity field is not showing. Causing 
> the quote to display an order item with no quantity resulting in $0.00 
> subtotal pricing. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11718) Deleting a PartyRole from a party generates an error

2021-11-02 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-11718.

Fix Version/s: Upcoming Branch
   Resolution: Fixed

> Deleting a PartyRole from a party generates an error
> 
>
> Key: OFBIZ-11718
> URL: https://issues.apache.org/jira/browse/OFBIZ-11718
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: role, roles, usability
> Fix For: Upcoming Branch
>
> Attachments: Screen Shot 2020-05-20 at 09.10.15.png
>
>
> Deleting a role from a party generates an error when that PartyRole is used 
> in an other entity record.
> See attached screenshot
> Steps to reproduce:
>  # Go to 
> [https://demo-trunk.ofbiz.apache.org/partymgr/control/viewroles?partyId=DemoCustomer;|https://demo-trunk.ofbiz.apache.org/partymgr/control/viewroles?partyId=DemoCustomer]
>  # Remove the 'Contact' role from the party.
> See the error shown (attached screenshot).
> Such errors pop up due to referential integrity (used in other entities).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-5965) PartyRole Lifespan fields - Have PartyRole screens/forms work with the change

2021-11-02 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-5965.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Implemented via OFBIZ-5980

> PartyRole Lifespan fields - Have PartyRole screens/forms work with the change
> -
>
> Key: OFBIZ-5965
> URL: https://issues.apache.org/jira/browse/OFBIZ-5965
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: role, roles, usability
> Fix For: Upcoming Branch
>
>
> Screens/forms need to be adjusted to work with change in the entity model.
> Intention to have an 'expireLink' enabling the user to expire the role 
> assignment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-5961) Update DemoData re PartyRole lifespan

2021-11-02 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-5961.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Is implemented via OFBIZ-5980

> Update DemoData re PartyRole lifespan
> -
>
> Key: OFBIZ-5961
> URL: https://issues.apache.org/jira/browse/OFBIZ-5961
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: role, roles
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-5959-PartyDemoData.xml.patch, 
> OFBIZ-5959-ProjectMgrDemoData.patch, OFBIZ-5959-ScrumDemoData.patch, 
> OFBIZ-5959-SecurityExtUserDemoData.xml.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-5961) Update DemoData re PartyRole lifespan

2021-11-02 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-5961:
---

Assignee: Pierre Smits

> Update DemoData re PartyRole lifespan
> -
>
> Key: OFBIZ-5961
> URL: https://issues.apache.org/jira/browse/OFBIZ-5961
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: role, roles
> Attachments: OFBIZ-5959-PartyDemoData.xml.patch, 
> OFBIZ-5959-ProjectMgrDemoData.patch, OFBIZ-5959-ScrumDemoData.patch, 
> OFBIZ-5959-SecurityExtUserDemoData.xml.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-5966) Update SeedData re PartyRole lifespan fields

2021-11-02 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-5966.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Implemented via OFBIZ-5980

> Update SeedData re PartyRole lifespan fields
> 
>
> Key: OFBIZ-5966
> URL: https://issues.apache.org/jira/browse/OFBIZ-5966
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-5966-SecurityPermissionSeedData.xml.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-5966) Update SeedData re PartyRole lifespan fields

2021-11-02 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-5966:
---

Assignee: Pierre Smits

> Update SeedData re PartyRole lifespan fields
> 
>
> Key: OFBIZ-5966
> URL: https://issues.apache.org/jira/browse/OFBIZ-5966
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Attachments: OFBIZ-5966-SecurityPermissionSeedData.xml.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #329: Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation"

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #329:
URL: https://github.com/apache/ofbiz-framework/pull/329#issuecomment-957266373


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=329=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=329=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=329=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=329=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=329)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=329=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party

2021-11-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437223#comment-17437223
 ] 

ASF subversion and git services commented on OFBIZ-5980:


Commit d0b0656da96dac8bbed313de39bde4201b5be846 in ofbiz-framework's branch 
refs/heads/revert-325-OFBIZ-5980-PartyRole-expiration from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d0b0656 ]

Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation 
(#325)"

This reverts commit 8ed2252df82be226d99d97250c659a1f8e3211fe.


> Have the ability to revoke (expire) roles of a party
> 
>
> Key: OFBIZ-5980
> URL: https://issues.apache.org/jira/browse/OFBIZ-5980
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: roles
> Fix For: Upcoming Branch
>
>
> Currently it only possible to delete a role.
> Which can lead to potential error messages, when a particular role is 
> associated with records where the roleTypeId is used as a foreign key in the 
> entity-model/database and the user tries to delete that role from the list.
> In order to avoid such, it is better to revoke the PartyRole record by 
> setting an expiration date (end date) on the record.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] JacquesLeRoux opened a new pull request #329: Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation"

2021-11-02 Thread GitBox


JacquesLeRoux opened a new pull request #329:
URL: https://github.com/apache/ofbiz-framework/pull/329


   Reverts apache/ofbiz-framework#325


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party

2021-11-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437222#comment-17437222
 ] 

ASF subversion and git services commented on OFBIZ-5980:


Commit 85e066deb358404b4681c148ba0d296e481bf666 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=85e066d ]

Reverted: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)

Reverts commit 46f7ee91d3355b3e10a5b2732797591c748a27dd

Reverted on Pierre Smits kindly asking for authoring by pushing a PR, not only a
thanks while committing his patch after testing it locally


> Have the ability to revoke (expire) roles of a party
> 
>
> Key: OFBIZ-5980
> URL: https://issues.apache.org/jira/browse/OFBIZ-5980
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: roles
> Fix For: Upcoming Branch
>
>
> Currently it only possible to delete a role.
> Which can lead to potential error messages, when a particular role is 
> associated with records where the roleTypeId is used as a foreign key in the 
> entity-model/database and the user tries to delete that role from the list.
> In order to avoid such, it is better to revoke the PartyRole record by 
> setting an expiration date (end date) on the record.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #328: Improved: seed data (OFBIZ-12355)

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #328:
URL: https://github.com/apache/ofbiz-framework/pull/328#issuecomment-957263785


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=328=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=328=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=328=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=328=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=328)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=328=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=328=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #328: Improved: seed data (OFBIZ-12355)

2021-11-02 Thread GitBox


PierreSmits opened a new pull request #328:
URL: https://github.com/apache/ofbiz-framework/pull/328


   Name of the PartyRelationshipType for employment
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party

2021-11-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437219#comment-17437219
 ] 

ASF subversion and git services commented on OFBIZ-5980:


Commit 8ed2252df82be226d99d97250c659a1f8e3211fe in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8ed2252 ]

(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation (#325)

added/changed/updated:
- added field definition for from and through date to the entity
- added service for expiration
- request-map for expiration
- appropriate forms to work with  added entity fields
- added groovy code to check existing when adding PartyRole record and call 
expiration service if needed
- adding fromDate value to seed, test and demo data

> Have the ability to revoke (expire) roles of a party
> 
>
> Key: OFBIZ-5980
> URL: https://issues.apache.org/jira/browse/OFBIZ-5980
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: roles
> Fix For: Upcoming Branch
>
>
> Currently it only possible to delete a role.
> Which can lead to potential error messages, when a particular role is 
> associated with records where the roleTypeId is used as a foreign key in the 
> entity-model/database and the user tries to delete that role from the list.
> In order to avoid such, it is better to revoke the PartyRole record by 
> setting an expiration date (end date) on the record.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #325: (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation

2021-11-02 Thread GitBox


JacquesLeRoux merged pull request #325:
URL: https://github.com/apache/ofbiz-framework/pull/325


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party

2021-11-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437217#comment-17437217
 ] 

ASF subversion and git services commented on OFBIZ-5980:


Commit 5b5e03f71b6f94ca3c4a1a1526681634835527a5 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5b5e03f ]

Reverted: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)

Reverts commit 46f7ee91d3355b3e10a5b2732797591c748a27dd

Reverted on Pierre Smits kindly asking for authoring by pushing a PR, not only a
thanks while committing his patch after testing it locally


> Have the ability to revoke (expire) roles of a party
> 
>
> Key: OFBIZ-5980
> URL: https://issues.apache.org/jira/browse/OFBIZ-5980
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: roles
> Fix For: Upcoming Branch
>
>
> Currently it only possible to delete a role.
> Which can lead to potential error messages, when a particular role is 
> associated with records where the roleTypeId is used as a foreign key in the 
> entity-model/database and the user tries to delete that role from the list.
> In order to avoid such, it is better to revoke the PartyRole record by 
> setting an expiration date (end date) on the record.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12355) Have a PartyRelationshipType for Employment

2021-11-02 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-12355:


Assignee: Pierre Smits

> Have a PartyRelationshipType for Employment
> ---
>
> Key: OFBIZ-12355
> URL: https://issues.apache.org/jira/browse/OFBIZ-12355
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> Currently we have in our seed data RoleType records for Employer and 
> Employee. However, when used in a PartyRelationship record the associated 
> PartyRelationshipTypeId record is not available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #327: Fixed: Quote item quantity field not visable (OFBIZ-12357)

2021-11-02 Thread GitBox


sonarcloud[bot] commented on pull request #327:
URL: https://github.com/apache/ofbiz-framework/pull/327#issuecomment-957185768


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=327=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=327=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=327=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=327=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=327)
 No Coverage information  
   
[![0.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.1%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=327=new_duplicated_lines_density=list)
 [0.1% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=327=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12357) Quote: Quote item quantity field not visable

2021-11-02 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437185#comment-17437185
 ] 

Pierre Smits commented on OFBIZ-12357:
--

Nevermind. I created a new PR.

> Quote: Quote item quantity field not visable
> 
>
> Key: OFBIZ-12357
> URL: https://issues.apache.org/jira/browse/OFBIZ-12357
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.08, 18.12.01
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Major
>  Labels: quote, quote-item
> Fix For: Upcoming Branch
>
> Attachments: Screen Shot 2021-10-31 at 11.18.51 AM.png
>
>
> When I go to enter a quote item, the quantity field is not showing. Causing 
> the quote to display an order item with no quantity resulting in $0.00 
> subtotal pricing. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #327: Fixed: Quote item quantity field not visable (OFBIZ-12357)

2021-11-02 Thread GitBox


PierreSmits opened a new pull request #327:
URL: https://github.com/apache/ofbiz-framework/pull/327


   removed: display attribute
   
   Thanks: Justine Nowak for opening the ticket.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-12357) Quote: Quote item quantity field not visable

2021-11-02 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12357:
-
Fix Version/s: Upcoming Branch

> Quote: Quote item quantity field not visable
> 
>
> Key: OFBIZ-12357
> URL: https://issues.apache.org/jira/browse/OFBIZ-12357
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.08, 18.12.01
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Major
>  Labels: quote, quote-item
> Fix For: Upcoming Branch
>
> Attachments: Screen Shot 2021-10-31 at 11.18.51 AM.png
>
>
> When I go to enter a quote item, the quantity field is not showing. Causing 
> the quote to display an order item with no quantity resulting in $0.00 
> subtotal pricing. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12357) Quote: Quote item quantity field not visable

2021-11-02 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437172#comment-17437172
 ] 

Pierre Smits commented on OFBIZ-12357:
--

[~jleroux] 

Can you also ensure that the commit goes into the 18.x branch, so that it will 
be included in next 18.x.y release?

> Quote: Quote item quantity field not visable
> 
>
> Key: OFBIZ-12357
> URL: https://issues.apache.org/jira/browse/OFBIZ-12357
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.08, 18.12.01
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Major
>  Labels: quote, quote-item
> Fix For: Upcoming Branch
>
> Attachments: Screen Shot 2021-10-31 at 11.18.51 AM.png
>
>
> When I go to enter a quote item, the quantity field is not showing. Causing 
> the quote to display an order item with no quantity resulting in $0.00 
> subtotal pricing. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12357) Quote: Quote item quantity field not visable

2021-11-02 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437170#comment-17437170
 ] 

Pierre Smits commented on OFBIZ-12357:
--

Due to a misconfiguration of the ticketID in the original commit message and 
the subsequent PR, the notification of the merge of the commit in the trunk 
branch didn't go into the ticket.

The gitbox commit message can be found here: 
https://ofbiz.markmail.org/message/g4ys6ftpc5jttfc7?q=+list:org%2Eapache%2Eofbiz%2Ecommits=1

> Quote: Quote item quantity field not visable
> 
>
> Key: OFBIZ-12357
> URL: https://issues.apache.org/jira/browse/OFBIZ-12357
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.08, 18.12.01
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Major
>  Labels: quote, quote-item
> Attachments: Screen Shot 2021-10-31 at 11.18.51 AM.png
>
>
> When I go to enter a quote item, the quantity field is not showing. Causing 
> the quote to display an order item with no quantity resulting in $0.00 
> subtotal pricing. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)