[jira] [Comment Edited] (OFBIZ-12863) Clean up demo site build scripts
[
https://issues.apache.org/jira/browse/OFBIZ-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818127#comment-17818127
]
Jacques Le Roux edited comment on OFBIZ-12863 at 2/17/24 7:08 AM:
--
Using {{sudo deluser \-\-remove-home ofbizDemo}}, I have just removed the
ofbizDemo and its home. I have not used {{--remove-all-files}} because it would
have removed big-files at /var/www/ofbiz/big-files which are now safe under the
997 system "user".
https://askubuntu.com/questions/459365/how-to-delete-a-user-its-home-folder-safely#saves-btn-555450
was (Author: jacques.le.roux):
Using {{sudo deluser --remove-home ofbizDemo}}, I have just removed the
ofbizDemo and its home. I have not used {{--remove-all-files}} because it would
have removed big-files at /var/www/ofbiz/big-files which are now safe under the
997 system "user".
https://askubuntu.com/questions/459365/how-to-delete-a-user-its-home-folder-safely#saves-btn-555450
> Clean up demo site build scripts
>
>
> Key: OFBIZ-12863
> URL: https://issues.apache.org/jira/browse/OFBIZ-12863
> Project: OFBiz
> Issue Type: Improvement
> Components: Demo
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
>
> The three ofbiz demo sites (demo-trunk, demo-next, demo-stable) have now
> hosted from docker containers rather than being built from source on the
> ofbiz-vm1 host.
> The scripts previously used to build the three demo sites, located under
> /home/ofbizDemo, can now be removed. The ofbizDemo user can also be removed.
> Removing unused scripts is worthwhile since it will avoid potential confusion
> about how host ofbiz-vm1 is being used for future system administrators.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12863) Clean up demo site build scripts
[
https://issues.apache.org/jira/browse/OFBIZ-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818127#comment-17818127
]
Jacques Le Roux commented on OFBIZ-12863:
-
Using {{sudo deluser --remove-home ofbizDemo}}, I have just removed the
ofbizDemo and its home. I have not used {{--remove-all-files}} because it would
have removed big-files at /var/www/ofbiz/big-files which are now safe under the
997 system "user".
https://askubuntu.com/questions/459365/how-to-delete-a-user-its-home-folder-safely#saves-btn-555450
> Clean up demo site build scripts
>
>
> Key: OFBIZ-12863
> URL: https://issues.apache.org/jira/browse/OFBIZ-12863
> Project: OFBiz
> Issue Type: Improvement
> Components: Demo
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
>
> The three ofbiz demo sites (demo-trunk, demo-next, demo-stable) have now
> hosted from docker containers rather than being built from source on the
> ofbiz-vm1 host.
> The scripts previously used to build the three demo sites, located under
> /home/ofbizDemo, can now be removed. The ofbizDemo user can also be removed.
> Removing unused scripts is worthwhile since it will avoid potential confusion
> about how host ofbiz-vm1 is being used for future system administrators.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12821) Improvement of the Check xml tag
[ https://issues.apache.org/jira/browse/OFBIZ-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818092#comment-17818092 ] ASF subversion and git services commented on OFBIZ-12821: - Commit e9dbb227a9c8fe4bdb84efc23ad3e07d2ea52145 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e9dbb227a9 ] Fixed: Improvement of the Check XML tag (OFBIZ-12821) Like the 3 previous commits this fixes things rather than improve them. During integration tests, the issue is in ***FormMacroLibrary.ftl files: In a macro declaration, parameters without a default value must all occur before the parameters with default values. > Improvement of the Check xml tag > > > Key: OFBIZ-12821 > URL: https://issues.apache.org/jira/browse/OFBIZ-12821 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Maxime Flammang >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > This improvement focuses on enhancing the syntax of the check XML tag in > Apache OFBiz. It introduces two new attributes, "checked-by-default" and > "unchecked-by-default," which allow the user to pre-select or pre-check boxes. > XML Attributes: > # "all-checked "(Boolean): > ** Purpose: Check all options by default. > ** Note: Not compatible with "unchecked-by-default" and "checked-by-default" > attributes. > # "checked-by-default" (String): > ** Purpose: Specifies which values should be pre-selected or pre-checked. > ** Note: Not compatible with "all-checked" set to "true" and > "unchecked-by-default" attribute. > # "unchecked-by-default" (String): > ** Purpose: Similar to "checked-by-default" attribute, but represents the > variables whose values should be unchecked by default. > ** Note: Not compatible with "all-checked" set to "true" and > "checked-by-default" attribute. > These enhancements provide greater flexibility and control over pre-selection > and pre-checking of boxes within the check XML tag in Apache OFBiz. > EDIT : > In the latest commit, both the "checked-by-default" and > "unchecked-by-default" attributes were removed. The new approach for > pre-checking variables is as follows: if a variable with the same name as the > field exists, its value will be used to determine the pre-check status. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12821) Improvement of the Check xml tag
[ https://issues.apache.org/jira/browse/OFBIZ-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818088#comment-17818088 ] ASF subversion and git services commented on OFBIZ-12821: - Commit 50ee4f972a7067361ce1fd7e7b99e159591e6f91 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=50ee4f972a ] Fixed: Improvement of the Check XML tag (OFBIZ-12821) Like the 2 previous commits this fixes things rather than improve them. During integration tests, the issue is in ***FormMacroLibrary.ftl files: When calling macro "renderCheckField", required parameter "allChecked" (parameter #5) was not specified > Improvement of the Check xml tag > > > Key: OFBIZ-12821 > URL: https://issues.apache.org/jira/browse/OFBIZ-12821 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Maxime Flammang >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > This improvement focuses on enhancing the syntax of the check XML tag in > Apache OFBiz. It introduces two new attributes, "checked-by-default" and > "unchecked-by-default," which allow the user to pre-select or pre-check boxes. > XML Attributes: > # "all-checked "(Boolean): > ** Purpose: Check all options by default. > ** Note: Not compatible with "unchecked-by-default" and "checked-by-default" > attributes. > # "checked-by-default" (String): > ** Purpose: Specifies which values should be pre-selected or pre-checked. > ** Note: Not compatible with "all-checked" set to "true" and > "unchecked-by-default" attribute. > # "unchecked-by-default" (String): > ** Purpose: Similar to "checked-by-default" attribute, but represents the > variables whose values should be unchecked by default. > ** Note: Not compatible with "all-checked" set to "true" and > "checked-by-default" attribute. > These enhancements provide greater flexibility and control over pre-selection > and pre-checking of boxes within the check XML tag in Apache OFBiz. > EDIT : > In the latest commit, both the "checked-by-default" and > "unchecked-by-default" attributes were removed. The new approach for > pre-checking variables is as follows: if a variable with the same name as the > field exists, its value will be used to determine the pre-check status. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12821) Improvement of the Check xml tag
[ https://issues.apache.org/jira/browse/OFBIZ-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818062#comment-17818062 ] ASF subversion and git services commented on OFBIZ-12821: - Commit a8b9de444a026b083f5dbaa06fd08f7fa7845307 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a8b9de444a ] Improved: Improvement of the Check XML tag (OFBIZ-12821) This should fix the integration tests and the WebtoolsLayoutDemo page > Improvement of the Check xml tag > > > Key: OFBIZ-12821 > URL: https://issues.apache.org/jira/browse/OFBIZ-12821 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Maxime Flammang >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > This improvement focuses on enhancing the syntax of the check XML tag in > Apache OFBiz. It introduces two new attributes, "checked-by-default" and > "unchecked-by-default," which allow the user to pre-select or pre-check boxes. > XML Attributes: > # "all-checked "(Boolean): > ** Purpose: Check all options by default. > ** Note: Not compatible with "unchecked-by-default" and "checked-by-default" > attributes. > # "checked-by-default" (String): > ** Purpose: Specifies which values should be pre-selected or pre-checked. > ** Note: Not compatible with "all-checked" set to "true" and > "unchecked-by-default" attribute. > # "unchecked-by-default" (String): > ** Purpose: Similar to "checked-by-default" attribute, but represents the > variables whose values should be unchecked by default. > ** Note: Not compatible with "all-checked" set to "true" and > "checked-by-default" attribute. > These enhancements provide greater flexibility and control over pre-selection > and pre-checking of boxes within the check XML tag in Apache OFBiz. > EDIT : > In the latest commit, both the "checked-by-default" and > "unchecked-by-default" attributes were removed. The new approach for > pre-checking variables is as follows: if a variable with the same name as the > field exists, its value will be used to determine the pre-check status. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12762) OFBiz Asciidoc documentation is broken
[
https://issues.apache.org/jira/browse/OFBIZ-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-12762.
---
Fix Version/s: Upcoming Branch
Assignee: Jacques Le Roux
Resolution: Fixed
This has been all recently cleaned.
> OFBiz Asciidoc documentation is broken
> --
>
> Key: OFBIZ-12762
> URL: https://issues.apache.org/jira/browse/OFBIZ-12762
> Project: OFBiz
> Issue Type: Bug
> Components: asciidoc
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Here are the errors locally (Windows):
> {noformat}
> > Task :generateOfbizDocumentation
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 193: include file not found:
> C:/projectsASF/Git/ofbiz-framework/_include/OFBizDocumentationSystem.adoc
> include file not found:
> C:/projectsASF/Git/ofbiz-framework/_include/OFBizDocumentationSystem.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:193
> (
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 197: include file not found:
> C:/projectsASF/framework/webapp/src/docs/asciidoc/webapp.adoc
> include file not found:
> C:/projectsASF/framework/webapp/src/docs/asciidoc/webapp.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:197
> (uri:classloa
> der:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 205: include file not found:
> C:/projectsASF/framework/entity/src/docs/asciidoc/entity-engine.adoc
> include file not found:
> C:/projectsASF/framework/entity/src/docs/asciidoc/entity-engine.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:205
> (uri:c
> lassloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 219: include file not found:
> C:/projectsASF/framework/datafile/src/docs/asciidoc/datafiles.adoc
> include file not found:
> C:/projectsASF/framework/datafile/src/docs/asciidoc/datafiles.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:219
> (uri:cla
> ssloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 225: include file not found:
> C:/projectsASF/applications/datamodel/DATAMODEL_CHANGES.adoc
> include file not found:
> C:/projectsASF/applications/datamodel/DATAMODEL_CHANGES.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:225
> (uri:classload
> er:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 255: include file not found:
> C:/projectsASF/themes/docs/themes.adoc
> include file not found: C:/projectsASF/themes/docs/themes.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:255
> (uri:classloader:/gems/asciidoctor-2
> .0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> include file not found:
> C:/projectsASF/framework/webtools/src/docs/asciidoc/_include/webtools-main.adoc
> :: developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc
> :276
> (uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> GRAVE: developer-manual.adoc: line 276: include file not
[jira] [Commented] (OFBIZ-12903) Have screen ImportExport show Party MainActionMenu
[ https://issues.apache.org/jira/browse/OFBIZ-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818034#comment-17818034 ] Pierre Smits commented on OFBIZ-12903: -- Thanks Jacques for your assistance to get this into the codebase. > Have screen ImportExport show Party MainActionMenu > -- > > Key: OFBIZ-12903 > URL: https://issues.apache.org/jira/browse/OFBIZ-12903 > Project: OFBiz > Issue Type: Improvement > Components: party >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Currently the ImportExport screen in PartyScreens.xml does not show the > MainActionMenu of the party component. > For a consistent user experience this should be. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12903) Have screen ImportExport show Party MainActionMenu
[ https://issues.apache.org/jira/browse/OFBIZ-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12903. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Implemented Thanks Pierre > Have screen ImportExport show Party MainActionMenu > -- > > Key: OFBIZ-12903 > URL: https://issues.apache.org/jira/browse/OFBIZ-12903 > Project: OFBiz > Issue Type: Improvement > Components: party >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Currently the ImportExport screen in PartyScreens.xml does not show the > MainActionMenu of the party component. > For a consistent user experience this should be. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12903) Have screen ImportExport show Party MainActionMenu
[ https://issues.apache.org/jira/browse/OFBIZ-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818026#comment-17818026 ] ASF subversion and git services commented on OFBIZ-12903: - Commit 3b160d349f9cad32ec4c6ecfcaa2f5c673e23923 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3b160d349f ] Improved: Have screen ImportExport show Party MainActionMenu (OFBIZ-12903) (#696) Currently the ImportExport screen in PartyScreens.xml does not show the MainActionMenu of the party component. For a consistent user experience this should be. modified: PartyScreens.xml - added decorator-section 'pre-body' having include-menu for MainActionMenu > Have screen ImportExport show Party MainActionMenu > -- > > Key: OFBIZ-12903 > URL: https://issues.apache.org/jira/browse/OFBIZ-12903 > Project: OFBiz > Issue Type: Improvement > Components: party >Reporter: Pierre Smits >Priority: Major > > Currently the ImportExport screen in PartyScreens.xml does not show the > MainActionMenu of the party component. > For a consistent user experience this should be. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: Have screen ImportExport show Party MainActionMenu (OFBIZ-12903) [ofbiz-framework]
JacquesLeRoux merged PR #696: URL: https://github.com/apache/ofbiz-framework/pull/696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Have screen ImportExport show Party MainActionMenu (OFBIZ-12903) [ofbiz-framework]
sonarcloud[bot] commented on PR #696: URL: https://github.com/apache/ofbiz-framework/pull/696#issuecomment-1948642694 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=696) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=696=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=696=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=696=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=696) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: Have screen ImportExport show Party MainActionMenu (OFBIZ-12903) [ofbiz-framework]
PierreSmits opened a new pull request, #696: URL: https://github.com/apache/ofbiz-framework/pull/696 Currently the ImportExport screen in PartyScreens.xml does not show the MainActionMenu of the party component. For a consistent user experience this should be. modified: PartyScreens.xml - added decorator-section 'pre-body' having include-menu for MainActionMenu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12903) Have screen ImportExport show Party MainActionMenu
Pierre Smits created OFBIZ-12903: Summary: Have screen ImportExport show Party MainActionMenu Key: OFBIZ-12903 URL: https://issues.apache.org/jira/browse/OFBIZ-12903 Project: OFBiz Issue Type: Improvement Components: party Reporter: Pierre Smits Currently the ImportExport screen in PartyScreens.xml does not show the MainActionMenu of the party component. For a consistent user experience this should be. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12900) Have screen FindPartyClassificationGroups show Party MainActionMenu
[ https://issues.apache.org/jira/browse/OFBIZ-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-12900. Fix Version/s: Upcoming Branch Resolution: Implemented > Have screen FindPartyClassificationGroups show Party MainActionMenu > --- > > Key: OFBIZ-12900 > URL: https://issues.apache.org/jira/browse/OFBIZ-12900 > Project: OFBiz > Issue Type: Improvement > Components: party >Reporter: Pierre Smits >Priority: Major > Fix For: Upcoming Branch > > > Currently the FindPartyClassificationGroups screen in > PartyClassificationScreens.xml does not show the MainActionMenu of the party > component. > For a consistent user experience this should be. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: afbe2437c8b622d85acda63d0d9e257579ae / Jacques Le Roux Improved: Improvement of the Check xml tag (OFBIZ-12821) Cleans MacroFormRendererTest.java for test check to pass + removes useless things Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7932370214 With regards, GitHub Actions via GitBox
[jira] [Commented] (OFBIZ-12821) Improvement of the Check xml tag
[ https://issues.apache.org/jira/browse/OFBIZ-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817995#comment-17817995 ] ASF subversion and git services commented on OFBIZ-12821: - Commit afbe2437c8b622d85acda63d0d9e257579ae in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=afbe2437c8 ] Improved: Improvement of the Check xml tag (OFBIZ-12821) Cleans MacroFormRendererTest.java for test check to pass + removes useless things > Improvement of the Check xml tag > > > Key: OFBIZ-12821 > URL: https://issues.apache.org/jira/browse/OFBIZ-12821 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Maxime Flammang >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > This improvement focuses on enhancing the syntax of the check XML tag in > Apache OFBiz. It introduces two new attributes, "checked-by-default" and > "unchecked-by-default," which allow the user to pre-select or pre-check boxes. > XML Attributes: > # "all-checked "(Boolean): > ** Purpose: Check all options by default. > ** Note: Not compatible with "unchecked-by-default" and "checked-by-default" > attributes. > # "checked-by-default" (String): > ** Purpose: Specifies which values should be pre-selected or pre-checked. > ** Note: Not compatible with "all-checked" set to "true" and > "unchecked-by-default" attribute. > # "unchecked-by-default" (String): > ** Purpose: Similar to "checked-by-default" attribute, but represents the > variables whose values should be unchecked by default. > ** Note: Not compatible with "all-checked" set to "true" and > "checked-by-default" attribute. > These enhancements provide greater flexibility and control over pre-selection > and pre-checking of boxes within the check XML tag in Apache OFBiz. > EDIT : > In the latest commit, both the "checked-by-default" and > "unchecked-by-default" attributes were removed. The new approach for > pre-checking variables is as follows: if a variable with the same name as the > field exists, its value will be used to determine the pre-check status. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12901) Upgrade node.js from v16.13.1 to v20
[ https://issues.apache.org/jira/browse/OFBIZ-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford reassigned OFBIZ-12901: -- Assignee: Daniel Watford > Upgrade node.js from v16.13.1 to v20 > > > Key: OFBIZ-12901 > URL: https://issues.apache.org/jira/browse/OFBIZ-12901 > Project: OFBiz > Issue Type: Task > Components: example, Gradle >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > We currently use Node.js 16 during the OFBiz build: > * to retrieve javascript modules (resolved using NPM) > * to build react components as part of the example plugin. > * in various GiHub Actions, notably those used in the docker image builds > Node 16 is now end-of-life > ([https://github.com/nodejs/Release/#end-of-life-releases)] > Explore upgrading OFBiz usage of Node.js to version 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: e200ed30dfb6e7e4a3fe44b5f2be21c0a6e7b185 / Jacques Le Roux Improved: Improvement of the Check xml tag (OFBIZ-12821) Did not spot this useless line, removed. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7931062952 With regards, GitHub Actions via GitBox
[jira] [Commented] (OFBIZ-12821) Improvement of the Check xml tag
[ https://issues.apache.org/jira/browse/OFBIZ-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817959#comment-17817959 ] ASF subversion and git services commented on OFBIZ-12821: - Commit e200ed30dfb6e7e4a3fe44b5f2be21c0a6e7b185 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e200ed30df ] Improved: Improvement of the Check xml tag (OFBIZ-12821) Did not spot this useless line, removed. > Improvement of the Check xml tag > > > Key: OFBIZ-12821 > URL: https://issues.apache.org/jira/browse/OFBIZ-12821 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Maxime Flammang >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > This improvement focuses on enhancing the syntax of the check XML tag in > Apache OFBiz. It introduces two new attributes, "checked-by-default" and > "unchecked-by-default," which allow the user to pre-select or pre-check boxes. > XML Attributes: > # "all-checked "(Boolean): > ** Purpose: Check all options by default. > ** Note: Not compatible with "unchecked-by-default" and "checked-by-default" > attributes. > # "checked-by-default" (String): > ** Purpose: Specifies which values should be pre-selected or pre-checked. > ** Note: Not compatible with "all-checked" set to "true" and > "unchecked-by-default" attribute. > # "unchecked-by-default" (String): > ** Purpose: Similar to "checked-by-default" attribute, but represents the > variables whose values should be unchecked by default. > ** Note: Not compatible with "all-checked" set to "true" and > "checked-by-default" attribute. > These enhancements provide greater flexibility and control over pre-selection > and pre-checking of boxes within the check XML tag in Apache OFBiz. > EDIT : > In the latest commit, both the "checked-by-default" and > "unchecked-by-default" attributes were removed. The new approach for > pre-checking variables is as follows: if a variable with the same name as the > field exists, its value will be used to determine the pre-check status. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux). Head commit for run: 96bf0094eea925e335301713f1c3293e15cd7dd8 / Pierre Smits Improved: Screen Classifications in Party should not show create trigger to user with only VIEW permission (OFBIZ-12892 (#695) When accessing https://demo-trunk.ofbiz.apache.org/partymgr/control/showclassgroups as a user with only VIEW permissions (e.g. userId = auditor) the action trigger to create a new Party Classification Group is shown. This should not be visible to such a user as it leads to an undesired effect and diminished user experience. modified: PartyClassificationScreens.xml - removed container having action trigger PartyMenus.xml - added menu-item newPartyClassificationGroup having permission condition Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7930924393 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 3b923ad9231dfa799440ba5507b0abe0246c8c86 / Jacques Le Roux Improved: Improvement of the Check xml tag (OFBIZ-12821) The approach for pre-checking variables is as follows: if a variable with the same name as the field exists, its value will be used to determine the pre-check status. There is an example in QuoteForms.xml Thanks: Maxime Flammang and Nereide team Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7930937433 With regards, GitHub Actions via GitBox
[jira] [Closed] (OFBIZ-12892) Screen Classifications in Party should not show create trigger to user with only VIEW permission
[ https://issues.apache.org/jira/browse/OFBIZ-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12892. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Implemented > Screen Classifications in Party should not show create trigger to user with > only VIEW permission > > > Key: OFBIZ-12892 > URL: https://issues.apache.org/jira/browse/OFBIZ-12892 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > When accessing > [https://demo-trunk.ofbiz.apache.org/partymgr/control/showclassgroups] as a > user with only VIEW permissions (e.g. userId = auditor) the action trigger to > create a new Party Classification Group is shown. > This should not be visible to such a user as it leads to an undesired effect > and diminished user experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12821) Improvement of the Check xml tag
[ https://issues.apache.org/jira/browse/OFBIZ-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12821. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Implemented > Improvement of the Check xml tag > > > Key: OFBIZ-12821 > URL: https://issues.apache.org/jira/browse/OFBIZ-12821 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Maxime Flammang >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > This improvement focuses on enhancing the syntax of the check XML tag in > Apache OFBiz. It introduces two new attributes, "checked-by-default" and > "unchecked-by-default," which allow the user to pre-select or pre-check boxes. > XML Attributes: > # "all-checked "(Boolean): > ** Purpose: Check all options by default. > ** Note: Not compatible with "unchecked-by-default" and "checked-by-default" > attributes. > # "checked-by-default" (String): > ** Purpose: Specifies which values should be pre-selected or pre-checked. > ** Note: Not compatible with "all-checked" set to "true" and > "unchecked-by-default" attribute. > # "unchecked-by-default" (String): > ** Purpose: Similar to "checked-by-default" attribute, but represents the > variables whose values should be unchecked by default. > ** Note: Not compatible with "all-checked" set to "true" and > "checked-by-default" attribute. > These enhancements provide greater flexibility and control over pre-selection > and pre-checking of boxes within the check XML tag in Apache OFBiz. > EDIT : > In the latest commit, both the "checked-by-default" and > "unchecked-by-default" attributes were removed. The new approach for > pre-checking variables is as follows: if a variable with the same name as the > field exists, its value will be used to determine the pre-check status. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12821) Improvement of the Check xml tag
[ https://issues.apache.org/jira/browse/OFBIZ-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817958#comment-17817958 ] ASF subversion and git services commented on OFBIZ-12821: - Commit 3b923ad9231dfa799440ba5507b0abe0246c8c86 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3b923ad923 ] Improved: Improvement of the Check xml tag (OFBIZ-12821) The approach for pre-checking variables is as follows: if a variable with the same name as the field exists, its value will be used to determine the pre-check status. There is an example in QuoteForms.xml Thanks: Maxime Flammang and Nereide team > Improvement of the Check xml tag > > > Key: OFBIZ-12821 > URL: https://issues.apache.org/jira/browse/OFBIZ-12821 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Maxime Flammang >Priority: Minor > > This improvement focuses on enhancing the syntax of the check XML tag in > Apache OFBiz. It introduces two new attributes, "checked-by-default" and > "unchecked-by-default," which allow the user to pre-select or pre-check boxes. > XML Attributes: > # "all-checked "(Boolean): > ** Purpose: Check all options by default. > ** Note: Not compatible with "unchecked-by-default" and "checked-by-default" > attributes. > # "checked-by-default" (String): > ** Purpose: Specifies which values should be pre-selected or pre-checked. > ** Note: Not compatible with "all-checked" set to "true" and > "unchecked-by-default" attribute. > # "unchecked-by-default" (String): > ** Purpose: Similar to "checked-by-default" attribute, but represents the > variables whose values should be unchecked by default. > ** Note: Not compatible with "all-checked" set to "true" and > "checked-by-default" attribute. > These enhancements provide greater flexibility and control over pre-selection > and pre-checking of boxes within the check XML tag in Apache OFBiz. > EDIT : > In the latest commit, both the "checked-by-default" and > "unchecked-by-default" attributes were removed. The new approach for > pre-checking variables is as follows: if a variable with the same name as the > field exists, its value will be used to determine the pre-check status. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12892) Screen Classifications in Party should not show create trigger to user with only VIEW permission
[ https://issues.apache.org/jira/browse/OFBIZ-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817957#comment-17817957 ] ASF subversion and git services commented on OFBIZ-12892: - Commit 96bf0094eea925e335301713f1c3293e15cd7dd8 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=96bf0094ee ] Improved: Screen Classifications in Party should not show create trigger to user with only VIEW permission (OFBIZ-12892 (#695) When accessing https://demo-trunk.ofbiz.apache.org/partymgr/control/showclassgroups as a user with only VIEW permissions (e.g. userId = auditor) the action trigger to create a new Party Classification Group is shown. This should not be visible to such a user as it leads to an undesired effect and diminished user experience. modified: PartyClassificationScreens.xml - removed container having action trigger PartyMenus.xml - added menu-item newPartyClassificationGroup having permission condition > Screen Classifications in Party should not show create trigger to user with > only VIEW permission > > > Key: OFBIZ-12892 > URL: https://issues.apache.org/jira/browse/OFBIZ-12892 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > > When accessing > [https://demo-trunk.ofbiz.apache.org/partymgr/control/showclassgroups] as a > user with only VIEW permissions (e.g. userId = auditor) the action trigger to > create a new Party Classification Group is shown. > This should not be visible to such a user as it leads to an undesired effect > and diminished user experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: Screen Classifications in Party should not show create trigger to user with only VIEW permission (OFBIZ-12892) [ofbiz-framework]
JacquesLeRoux merged PR #695: URL: https://github.com/apache/ofbiz-framework/pull/695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improvement of the Check xml tag (OFBIZ-12821) [ofbiz-framework]
JacquesLeRoux closed pull request #639: Improvement of the Check xml tag (OFBIZ-12821) URL: https://github.com/apache/ofbiz-framework/pull/639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improvement of the Check xml tag (OFBIZ-12821) [ofbiz-framework]
JacquesLeRoux commented on PR #639: URL: https://github.com/apache/ofbiz-framework/pull/639#issuecomment-1948327557 Hi @nmalin, Thanks for the explanation, I got it looking at QuoteForms.xml where OTHER_QUOTE and PROPOSAL are preset. I simply amended the doc in widget-form.xsd. I'll commit from my machine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12817) Pagination: jump to page with AJAX enabled is broken
[ https://issues.apache.org/jira/browse/OFBIZ-12817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817921#comment-17817921 ] ASF subversion and git services commented on OFBIZ-12817: - Commit 16481383c3e37f41a308245ff5d5b7289fe691ac in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=16481383c3 ] Fixed: pagination, jump to page with AJAX enabled is broken (OFBIZ-12817 - #637) Last conflict handled by hand was not well done :/ This is OK (and tested) > Pagination: jump to page with AJAX enabled is broken > > > Key: OFBIZ-12817 > URL: https://issues.apache.org/jira/browse/OFBIZ-12817 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch, 18.12.08 >Reporter: Florian Motteau >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.12, 22.01 > > Attachments: image-2023-05-10-08-24-49-082.png, > image-2023-05-10-08-26-47-399.png > > > On a paginated grid/form which extends CommonDynamicGrid/CommonDynamicForm, > with ajaxEnabled=true, the framework builds an input allowing user to jump to > a specific page number. > This input gets a onchange event that triggers a request for the content of > the target page, but the VIEW_INDEX parameter is off by one : when asking for > page 6 we fetch the content of page 5 (page numbers are zero-indexed, so the > value entered by the user should be decremented) : > !image-2023-05-10-08-24-49-082.png|width=724,height=133! > In this screenshot, the VIEW_INDEX should be set to "this.value - 1", just > like the non AJAX pagination widget does : > !image-2023-05-10-08-26-47-399.png|width=671,height=76! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12902) GitHub Workflow builds of docker images triggered by tags cannot retrieve plugin sources
Daniel Watford created OFBIZ-12902: -- Summary: GitHub Workflow builds of docker images triggered by tags cannot retrieve plugin sources Key: OFBIZ-12902 URL: https://issues.apache.org/jira/browse/OFBIZ-12902 Project: OFBiz Issue Type: Bug Components: Docker Affects Versions: 18.12.12 Reporter: Daniel Watford A tag, release18.12.12, was recently applied to the release18.12 branch to exercise the building of a 'release' docker image, rather than the 'snapshot' images we produce following every commit to a branch. The GitHub workflow, 'Build and push docker images', replies on script pullAllPluginSources.sh to retrieve OFBiz plugin sources that correspond to the OFBiz version currently being built. When the GitHub workflow is triggered by a tag, pullAllPluginSources.sh is unable to identify the correct branch of ofbiz-plugins to retrieve, meaning no plugins are included in the docker image. Investigate how to retrieve ofbiz-plugin sources during a GitHub workflow that has been triggered by pushing a tag to the ofbiz-framework git repository. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12901) Upgrade node.js from v16.13.1 to v20
[ https://issues.apache.org/jira/browse/OFBIZ-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford updated OFBIZ-12901: --- Description: We currently use Node.js 16 during the OFBiz build: * to retrieve javascript modules (resolved using NPM) * to build react components as part of the example plugin. * in various GiHub Actions, notably those used in the docker image builds Node 16 is now end-of-life ([https://github.com/nodejs/Release/#end-of-life-releases)] Explore upgrading OFBiz usage of Node.js to version 20. was: We currently use Node.js 16 during the OFBiz build to: * retrieve javascript modules (resolved using NPM) * build react components as part of the example plugin. Node 16 is now end-of-life ([https://github.com/nodejs/Release/#end-of-life-releases)] Explore upgrading OFBiz usage of Node.js to version 20. > Upgrade node.js from v16.13.1 to v20 > > > Key: OFBIZ-12901 > URL: https://issues.apache.org/jira/browse/OFBIZ-12901 > Project: OFBiz > Issue Type: Task > Components: example, Gradle >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Priority: Minor > > We currently use Node.js 16 during the OFBiz build: > * to retrieve javascript modules (resolved using NPM) > * to build react components as part of the example plugin. > * in various GiHub Actions, notably those used in the docker image builds > Node 16 is now end-of-life > ([https://github.com/nodejs/Release/#end-of-life-releases)] > Explore upgrading OFBiz usage of Node.js to version 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12875) [SECURITY: CVE-2023-50968] Use screen engine for the request getJSONuilabels
[ https://issues.apache.org/jira/browse/OFBIZ-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817899#comment-17817899 ] Mekika Leila edited comment on OFBIZ-12875 at 2/16/24 10:04 AM: Hello, For information I have just committed a small fix for showjGrowlMessage call (undefined object error when retrieving jGrowlLabelObject) * 22.01 : [768d0780afb2e8a70acb9017a7ded9d4e72dfa30|https://github.com/apache/ofbiz-framework/commit/768d0780afb2e8a70acb9017a7ded9d4e72dfa30] * trunk : [8813c75986|https://github.com/apache/ofbiz-framework/commit/8813c75986] was (Author: mleila): Hello, For information I just committed an small fix for showjGrowlMessage call (undefined object error when retrieving jGrowlLabelObject) * 22.01 : [768d0780afb2e8a70acb9017a7ded9d4e72dfa30|https://github.com/apache/ofbiz-framework/commit/768d0780afb2e8a70acb9017a7ded9d4e72dfa30] * trunk : [8813c75986|https://github.com/apache/ofbiz-framework/commit/8813c75986] > [SECURITY: CVE-2023-50968] Use screen engine for the request getJSONuilabels > > > Key: OFBIZ-12875 > URL: https://issues.apache.org/jira/browse/OFBIZ-12875 > Project: OFBiz > Issue Type: Sub-task > Components: framework/common >Affects Versions: 18.12.10, 22.01 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01, 18.12.11 > > > Before this improvement, you can resolve a list of labels to display with the > uiLabel resource file > like : "CommonUiLabels" : ["CommonUpload", "CommonSave", > "CommonCompleted"] > > We remove the possibility to specify a uiLabel resource file and make it > work by default with CommonUiLabels. > After that we implement the json return on extend theme screen so we can > add some uiLabel ressource by theme extension or component screen definition. > > Other enhancement, on getJSONuiLabels instead resolve the label with a > list position you can call your label with it key. > resolve : uiLabelJsonObjects.CommonUiLabels[1] >become : uiLabelJsonObjects.CommonSave -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12875) [SECURITY: CVE-2023-50968] Use screen engine for the request getJSONuilabels
[ https://issues.apache.org/jira/browse/OFBIZ-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817899#comment-17817899 ] Mekika Leila commented on OFBIZ-12875: -- Hello, For information I just committed an small fix for showjGrowlMessage call (undefined object error when retrieving jGrowlLabelObject) * 22.01 : [768d0780afb2e8a70acb9017a7ded9d4e72dfa30|https://github.com/apache/ofbiz-framework/commit/768d0780afb2e8a70acb9017a7ded9d4e72dfa30] * trunk : [8813c75986|https://github.com/apache/ofbiz-framework/commit/8813c75986] > [SECURITY: CVE-2023-50968] Use screen engine for the request getJSONuilabels > > > Key: OFBIZ-12875 > URL: https://issues.apache.org/jira/browse/OFBIZ-12875 > Project: OFBiz > Issue Type: Sub-task > Components: framework/common >Affects Versions: 18.12.10, 22.01 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01, 18.12.11 > > > Before this improvement, you can resolve a list of labels to display with the > uiLabel resource file > like : "CommonUiLabels" : ["CommonUpload", "CommonSave", > "CommonCompleted"] > > We remove the possibility to specify a uiLabel resource file and make it > work by default with CommonUiLabels. > After that we implement the json return on extend theme screen so we can > add some uiLabel ressource by theme extension or component screen definition. > > Other enhancement, on getJSONuiLabels instead resolve the label with a > list position you can call your label with it key. > resolve : uiLabelJsonObjects.CommonUiLabels[1] >become : uiLabelJsonObjects.CommonSave -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12875) [SECURITY: CVE-2023-50968] Use screen engine for the request getJSONuilabels
[ https://issues.apache.org/jira/browse/OFBIZ-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817897#comment-17817897 ] ASF subversion and git services commented on OFBIZ-12875: - Commit 768d0780afb2e8a70acb9017a7ded9d4e72dfa30 in ofbiz-framework's branch refs/heads/release22.01 from Mekika Leila [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=768d0780af ] Fixed: Jgrowl label are not well retrieved (OFBIZ-12875) Fix a jGrowlLabelObject undefined error when calling showjGrowlMessage > [SECURITY: CVE-2023-50968] Use screen engine for the request getJSONuilabels > > > Key: OFBIZ-12875 > URL: https://issues.apache.org/jira/browse/OFBIZ-12875 > Project: OFBiz > Issue Type: Sub-task > Components: framework/common >Affects Versions: 18.12.10, 22.01 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01, 18.12.11 > > > Before this improvement, you can resolve a list of labels to display with the > uiLabel resource file > like : "CommonUiLabels" : ["CommonUpload", "CommonSave", > "CommonCompleted"] > > We remove the possibility to specify a uiLabel resource file and make it > work by default with CommonUiLabels. > After that we implement the json return on extend theme screen so we can > add some uiLabel ressource by theme extension or component screen definition. > > Other enhancement, on getJSONuiLabels instead resolve the label with a > list position you can call your label with it key. > resolve : uiLabelJsonObjects.CommonUiLabels[1] >become : uiLabelJsonObjects.CommonSave -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GH] (ofbiz-framework): Workflow run "Build and push docker images" is working again!
The GitHub Actions job "Build and push docker images" on ofbiz-framework.git has succeeded. Run started by GitHub user mleila37 (triggered by mleila37). Head commit for run: 8813c759866b2201bc87b8f20ad655f1bb036d00 / MLeila Fixed: Jgrowl label are not well retrieved (OFBIZ-12875) Fix a jGrowlLabelObject undefined error when calling showjGrowlMessage Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7928676926 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user mleila37 (triggered by mleila37). Head commit for run: 8813c759866b2201bc87b8f20ad655f1bb036d00 / MLeila Fixed: Jgrowl label are not well retrieved (OFBIZ-12875) Fix a jGrowlLabelObject undefined error when calling showjGrowlMessage Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7928676925 With regards, GitHub Actions via GitBox
[jira] [Commented] (OFBIZ-12875) [SECURITY: CVE-2023-50968] Use screen engine for the request getJSONuilabels
[ https://issues.apache.org/jira/browse/OFBIZ-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817890#comment-17817890 ] ASF subversion and git services commented on OFBIZ-12875: - Commit 8813c759866b2201bc87b8f20ad655f1bb036d00 in ofbiz-framework's branch refs/heads/trunk from Mekika Leila [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8813c75986 ] Fixed: Jgrowl label are not well retrieved (OFBIZ-12875) Fix a jGrowlLabelObject undefined error when calling showjGrowlMessage > [SECURITY: CVE-2023-50968] Use screen engine for the request getJSONuilabels > > > Key: OFBIZ-12875 > URL: https://issues.apache.org/jira/browse/OFBIZ-12875 > Project: OFBiz > Issue Type: Sub-task > Components: framework/common >Affects Versions: 18.12.10, 22.01 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01, 18.12.11 > > > Before this improvement, you can resolve a list of labels to display with the > uiLabel resource file > like : "CommonUiLabels" : ["CommonUpload", "CommonSave", > "CommonCompleted"] > > We remove the possibility to specify a uiLabel resource file and make it > work by default with CommonUiLabels. > After that we implement the json return on extend theme screen so we can > add some uiLabel ressource by theme extension or component screen definition. > > Other enhancement, on getJSONuiLabels instead resolve the label with a > list position you can call your label with it key. > resolve : uiLabelJsonObjects.CommonUiLabels[1] >become : uiLabelJsonObjects.CommonSave -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12817) Pagination: jump to page with AJAX enabled is broken
[ https://issues.apache.org/jira/browse/OFBIZ-12817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12817. --- Fix Version/s: 18.12.12 22.01 Assignee: Jacques Le Roux Resolution: Fixed Thanks Florian, works like a charm > Pagination: jump to page with AJAX enabled is broken > > > Key: OFBIZ-12817 > URL: https://issues.apache.org/jira/browse/OFBIZ-12817 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch, 18.12.08 >Reporter: Florian Motteau >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.12, 22.01 > > Attachments: image-2023-05-10-08-24-49-082.png, > image-2023-05-10-08-26-47-399.png > > > On a paginated grid/form which extends CommonDynamicGrid/CommonDynamicForm, > with ajaxEnabled=true, the framework builds an input allowing user to jump to > a specific page number. > This input gets a onchange event that triggers a request for the content of > the target page, but the VIEW_INDEX parameter is off by one : when asking for > page 6 we fetch the content of page 5 (page numbers are zero-indexed, so the > value entered by the user should be decremented) : > !image-2023-05-10-08-24-49-082.png|width=724,height=133! > In this screenshot, the VIEW_INDEX should be set to "this.value - 1", just > like the non AJAX pagination widget does : > !image-2023-05-10-08-26-47-399.png|width=671,height=76! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GH] (ofbiz-framework): Workflow run "Build and push docker images" failed!
The GitHub Actions job "Build and push docker images" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 362538d18fa456a7d5565410cb1c2c47b35bcaf2 / Florian Motteau Fixed: pagination, jump to page with AJAX enabled is broken (OFBIZ-12817 - #637) Jump to page with AJAX enabled fetches the wrong page. We need to decrement the value entered by the user by one (page numbers are zero-indexed) Thanks: Néréide Team :) Conflict handled by hand Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7928259457 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 362538d18fa456a7d5565410cb1c2c47b35bcaf2 / Florian Motteau Fixed: pagination, jump to page with AJAX enabled is broken (OFBIZ-12817 - #637) Jump to page with AJAX enabled fetches the wrong page. We need to decrement the value entered by the user by one (page numbers are zero-indexed) Thanks: Néréide Team :) Conflict handled by hand Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7928259455 With regards, GitHub Actions via GitBox
[jira] [Commented] (OFBIZ-12817) Pagination: jump to page with AJAX enabled is broken
[ https://issues.apache.org/jira/browse/OFBIZ-12817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817879#comment-17817879 ] ASF subversion and git services commented on OFBIZ-12817: - Commit 362538d18fa456a7d5565410cb1c2c47b35bcaf2 in ofbiz-framework's branch refs/heads/release18.12 from Florian Motteau [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=362538d18f ] Fixed: pagination, jump to page with AJAX enabled is broken (OFBIZ-12817 - #637) Jump to page with AJAX enabled fetches the wrong page. We need to decrement the value entered by the user by one (page numbers are zero-indexed) Thanks: Néréide Team :) Conflict handled by hand > Pagination: jump to page with AJAX enabled is broken > > > Key: OFBIZ-12817 > URL: https://issues.apache.org/jira/browse/OFBIZ-12817 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch, 18.12.08 >Reporter: Florian Motteau >Priority: Minor > Attachments: image-2023-05-10-08-24-49-082.png, > image-2023-05-10-08-26-47-399.png > > > On a paginated grid/form which extends CommonDynamicGrid/CommonDynamicForm, > with ajaxEnabled=true, the framework builds an input allowing user to jump to > a specific page number. > This input gets a onchange event that triggers a request for the content of > the target page, but the VIEW_INDEX parameter is off by one : when asking for > page 6 we fetch the content of page 5 (page numbers are zero-indexed, so the > value entered by the user should be decremented) : > !image-2023-05-10-08-24-49-082.png|width=724,height=133! > In this screenshot, the VIEW_INDEX should be set to "this.value - 1", just > like the non AJAX pagination widget does : > !image-2023-05-10-08-26-47-399.png|width=671,height=76! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12817) Pagination: jump to page with AJAX enabled is broken
[ https://issues.apache.org/jira/browse/OFBIZ-12817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817873#comment-17817873 ] ASF subversion and git services commented on OFBIZ-12817: - Commit 770643ae73f388cef17b2e4d354532865c31bf9e in ofbiz-framework's branch refs/heads/release22.01 from Florian Motteau [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=770643ae73 ] Fixed: pagination, jump to page with AJAX enabled is broken (OFBIZ-12817 - #637) Jump to page with AJAX enabled fetches the wrong page. We need to decrement the value entered by the user by one (page numbers are zero-indexed) Thanks: Néréide Team :) > Pagination: jump to page with AJAX enabled is broken > > > Key: OFBIZ-12817 > URL: https://issues.apache.org/jira/browse/OFBIZ-12817 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch, 18.12.08 >Reporter: Florian Motteau >Priority: Minor > Attachments: image-2023-05-10-08-24-49-082.png, > image-2023-05-10-08-26-47-399.png > > > On a paginated grid/form which extends CommonDynamicGrid/CommonDynamicForm, > with ajaxEnabled=true, the framework builds an input allowing user to jump to > a specific page number. > This input gets a onchange event that triggers a request for the content of > the target page, but the VIEW_INDEX parameter is off by one : when asking for > page 6 we fetch the content of page 5 (page numbers are zero-indexed, so the > value entered by the user should be decremented) : > !image-2023-05-10-08-24-49-082.png|width=724,height=133! > In this screenshot, the VIEW_INDEX should be set to "this.value - 1", just > like the non AJAX pagination widget does : > !image-2023-05-10-08-26-47-399.png|width=671,height=76! -- This message was sent by Atlassian Jira (v8.20.10#820010)
