[jira] [Resolved] (OFBIZ-7713) Introduce a quick way for adding Sales Price agreements with customers for any specific product from Catalog

2018-05-02 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-7713.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

I see affected versions for the ticket is 14.12 and 15.12 can be removed, doing 
it. Please raise flag in case I missed something. Thanks!

> Introduce a quick way for adding Sales Price agreements with customers for 
> any specific product from Catalog
> 
>
> Key: OFBIZ-7713
> URL: https://issues.apache.org/jira/browse/OFBIZ-7713
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7713.patch, OFBIZ-7713.patch, SPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a catalog or sales 
> manager doesn't have accounting permission in case quick pricing agreement 
> needs to be placed with customer for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Sales" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the Sales Panel and hitting 
> this link could ask user to enter following very basic parameters:
> #- Party Id From
> #- Party Id To (Default it to product store's owner party id)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> # Upon successful submission of above details system should create Agreement 
> and Agreement Item between customer and organization by passing following 
> default values:
> #- Role Type Id From = 'Customer'
> #- Role Type Id To = 'Internal Organization'
> #- Agreement Type Id = 'Sales'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7713) Introduce a quick way for adding Sales Price agreements with customers for any specific product from Catalog

2018-05-02 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461069#comment-16461069
 ] 

Rishi Solanki commented on OFBIZ-7713:
--

Thanks [~swash78] [~Mohammad K] for your contribution, patch has been committed 
in revision 1830758.

> Introduce a quick way for adding Sales Price agreements with customers for 
> any specific product from Catalog
> 
>
> Key: OFBIZ-7713
> URL: https://issues.apache.org/jira/browse/OFBIZ-7713
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-7713.patch, OFBIZ-7713.patch, SPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a catalog or sales 
> manager doesn't have accounting permission in case quick pricing agreement 
> needs to be placed with customer for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Sales" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the Sales Panel and hitting 
> this link could ask user to enter following very basic parameters:
> #- Party Id From
> #- Party Id To (Default it to product store's owner party id)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> # Upon successful submission of above details system should create Agreement 
> and Agreement Item between customer and organization by passing following 
> default values:
> #- Role Type Id From = 'Customer'
> #- Role Type Id To = 'Internal Organization'
> #- Agreement Type Id = 'Sales'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-7713) Introduce a quick way for adding Sales Price agreements with customers for any specific product from Catalog

2018-04-30 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458558#comment-16458558
 ] 

Rishi Solanki edited comment on OFBIZ-7713 at 4/30/18 1:16 PM:
---

[~Mohammad K] : Make sense to me to not defaulting to any party. I'm up for it, 
[~swash78] I'll commit the changes in couple of days in case no objection come 
over. Also from the ticket history it seems we can close the ticket as well.

I'll cross verify overall feature described initially by Swapnil.
Thanks! 


was (Author: rishisolankii):
[~Mohammad K] : Make sense to me to not defaulting to any party. I'm up for it, 
[~swash78] I'll commit the changes in couple of days in case no objection come 
over. Also from the ticket history it seems we can close the ticket as well.

I'll cross verify overall improvement suggested initially by Swapnil.
Thanks! 

> Introduce a quick way for adding Sales Price agreements with customers for 
> any specific product from Catalog
> 
>
> Key: OFBIZ-7713
> URL: https://issues.apache.org/jira/browse/OFBIZ-7713
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-7713.patch, OFBIZ-7713.patch, SPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a catalog or sales 
> manager doesn't have accounting permission in case quick pricing agreement 
> needs to be placed with customer for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Sales" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the Sales Panel and hitting 
> this link could ask user to enter following very basic parameters:
> #- Party Id From
> #- Party Id To (Default it to product store's owner party id)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> # Upon successful submission of above details system should create Agreement 
> and Agreement Item between customer and organization by passing following 
> default values:
> #- Role Type Id From = 'Customer'
> #- Role Type Id To = 'Internal Organization'
> #- Agreement Type Id = 'Sales'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7713) Introduce a quick way for adding Sales Price agreements with customers for any specific product from Catalog

2018-04-30 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458558#comment-16458558
 ] 

Rishi Solanki commented on OFBIZ-7713:
--

[~Mohammad K] : Make sense to me to not defaulting to any party. I'm up for it, 
[~swash78] I'll commit the changes in couple of days in case no objection come 
over. Also from the ticket history it seems we can close the ticket as well.

I'll cross verify overall improvement suggested initially by Swapnil.
Thanks! 

> Introduce a quick way for adding Sales Price agreements with customers for 
> any specific product from Catalog
> 
>
> Key: OFBIZ-7713
> URL: https://issues.apache.org/jira/browse/OFBIZ-7713
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-7713.patch, OFBIZ-7713.patch, SPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a catalog or sales 
> manager doesn't have accounting permission in case quick pricing agreement 
> needs to be placed with customer for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Sales" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the Sales Panel and hitting 
> this link could ask user to enter following very basic parameters:
> #- Party Id From
> #- Party Id To (Default it to product store's owner party id)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> # Upon successful submission of above details system should create Agreement 
> and Agreement Item between customer and organization by passing following 
> default values:
> #- Role Type Id From = 'Customer'
> #- Role Type Id To = 'Internal Organization'
> #- Agreement Type Id = 'Sales'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7713) Introduce a quick way for adding Sales Price agreements with customers for any specific product from Catalog

2018-04-30 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-7713:


Assignee: Rishi Solanki  (was: Mohammad Kathawala)

> Introduce a quick way for adding Sales Price agreements with customers for 
> any specific product from Catalog
> 
>
> Key: OFBIZ-7713
> URL: https://issues.apache.org/jira/browse/OFBIZ-7713
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-7713.patch, OFBIZ-7713.patch, SPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a catalog or sales 
> manager doesn't have accounting permission in case quick pricing agreement 
> needs to be placed with customer for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Sales" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the Sales Panel and hitting 
> this link could ask user to enter following very basic parameters:
> #- Party Id From
> #- Party Id To (Default it to product store's owner party id)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> # Upon successful submission of above details system should create Agreement 
> and Agreement Item between customer and organization by passing following 
> default values:
> #- Role Type Id From = 'Customer'
> #- Role Type Id To = 'Internal Organization'
> #- Agreement Type Id = 'Sales'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-30 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10282.
-

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10282-plugins.patch, OFBIZ-10282.patch
>
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-30 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10282.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks [~suraj.khurana] your work has been committed in revision 1830545 and 
1830546.

Thanks [~arunpati] [~jacques.le.roux] for your help, input and review.

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10282-plugins.patch, OFBIZ-10282.patch
>
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10312) UI Label Issue on WebPos screen

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-10312:
--
Fix Version/s: Upcoming Branch

> UI Label Issue on WebPos screen
> ---
>
> Key: OFBIZ-10312
> URL: https://issues.apache.org/jira/browse/OFBIZ-10312
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment: https://demo-trunk.ofbiz.apache.org/webpos/control/Login
>Reporter: Archana Asthana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10312.patch, UIlabel.png
>
>
> Steps to regenerate: 
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Check the UI label below the keyboard shortcuts
> Expected: The UI lable should be clear and legible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10312) UI Label Issue on WebPos screen

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10312.
-

> UI Label Issue on WebPos screen
> ---
>
> Key: OFBIZ-10312
> URL: https://issues.apache.org/jira/browse/OFBIZ-10312
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment: https://demo-trunk.ofbiz.apache.org/webpos/control/Login
>Reporter: Archana Asthana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10312.patch, UIlabel.png
>
>
> Steps to regenerate: 
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Check the UI label below the keyboard shortcuts
> Expected: The UI lable should be clear and legible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10312) UI Label Issue on WebPos screen

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10312:
-

Resolution: Fixed
  Assignee: Rishi Solanki  (was: Pawan Verma)

Thanks [~archana.asthana] for reporting the issue and [~pawan.verma] for 
providing fix.

Your work has been committed in revision 1830451.

> UI Label Issue on WebPos screen
> ---
>
> Key: OFBIZ-10312
> URL: https://issues.apache.org/jira/browse/OFBIZ-10312
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment: https://demo-trunk.ofbiz.apache.org/webpos/control/Login
>Reporter: Archana Asthana
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10312.patch, UIlabel.png
>
>
> Steps to regenerate: 
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Check the UI label below the keyboard shortcuts
> Expected: The UI lable should be clear and legible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10282:
-

Assignee: Rishi Solanki  (was: Arun Patidar)

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10282-plugins.patch, OFBIZ-10282.patch
>
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-28 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457597#comment-16457597
 ] 

Rishi Solanki commented on OFBIZ-10282:
---

[~suraj.khurana] : Patch looks good to me, [~jacques.le.roux] [~arunpati] could 
you please confirm if I can go ahead and commit the changes. Thanks!

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-10282-plugins.patch, OFBIZ-10282.patch
>
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10316) Fields going outside

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10316.
-

> Fields going outside
> 
>
> Key: OFBIZ-10316
> URL: https://issues.apache.org/jira/browse/OFBIZ-10316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment:  
> [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
>Reporter: Padmavati Rawat
>Assignee: Rishi Solanki
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FieldsUI.png, OFBIZ-10316.patch
>
>
> *Steps to regenerate: *
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Search customer through search by.
> Select a customer from the list through a checkbox.
> Check the First name and Address line 2 fields in the update modal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10316) Fields going outside

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-10316:
--
Fix Version/s: Upcoming Branch

> Fields going outside
> 
>
> Key: OFBIZ-10316
> URL: https://issues.apache.org/jira/browse/OFBIZ-10316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment:  
> [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
>Reporter: Padmavati Rawat
>Assignee: Rishi Solanki
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FieldsUI.png, OFBIZ-10316.patch
>
>
> *Steps to regenerate: *
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Search customer through search by.
> Select a customer from the list through a checkbox.
> Check the First name and Address line 2 fields in the update modal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10316) Fields going outside

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10316.
---
Resolution: Fixed

Thanks [~padma.rawat] for reporting the issue and [~pawan.verma] for providing 
fix.

Your work has been committed in revision 1830448.

> Fields going outside
> 
>
> Key: OFBIZ-10316
> URL: https://issues.apache.org/jira/browse/OFBIZ-10316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment:  
> [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
>Reporter: Padmavati Rawat
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: FieldsUI.png, OFBIZ-10316.patch
>
>
> *Steps to regenerate: *
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Search customer through search by.
> Select a customer from the list through a checkbox.
> Check the First name and Address line 2 fields in the update modal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10316) Fields going outside

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10316:
-

Assignee: Rishi Solanki  (was: Pawan Verma)

> Fields going outside
> 
>
> Key: OFBIZ-10316
> URL: https://issues.apache.org/jira/browse/OFBIZ-10316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment:  
> [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
>Reporter: Padmavati Rawat
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: FieldsUI.png, OFBIZ-10316.patch
>
>
> *Steps to regenerate: *
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Search customer through search by.
> Select a customer from the list through a checkbox.
> Check the First name and Address line 2 fields in the update modal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10380) Convert facility party related services from simple to entity-auto

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10380.
-

> Convert facility party related services from simple to entity-auto
> --
>
> Key: OFBIZ-10380
> URL: https://issues.apache.org/jira/browse/OFBIZ-10380
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10380.patch
>
>
> There is nothing extra in these services and they can be made to entity-auto



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10380) Convert facility party related services from simple to entity-auto

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10380.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks [~suraj.khurana] for reporting the issue and providing fix for the same.

Your patch has been committed in revision 1830429.

> Convert facility party related services from simple to entity-auto
> --
>
> Key: OFBIZ-10380
> URL: https://issues.apache.org/jira/browse/OFBIZ-10380
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10380.patch
>
>
> There is nothing extra in these services and they can be made to entity-auto



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10380) Convert facility party related services from simple to entity-auto

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10380:
-

Assignee: Rishi Solanki  (was: Suraj Khurana)

> Convert facility party related services from simple to entity-auto
> --
>
> Key: OFBIZ-10380
> URL: https://issues.apache.org/jira/browse/OFBIZ-10380
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10380.patch
>
>
> There is nothing extra in these services and they can be made to entity-auto



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10365) Document design approaches for Inventory Transfer

2018-04-27 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456069#comment-16456069
 ] 

Rishi Solanki commented on OFBIZ-10365:
---

+1 for the design changes. Thanks for the reference flow. My vote is for design 
approach #1.

> Document design approaches for Inventory Transfer 
> --
>
> Key: OFBIZ-10365
> URL: https://issues.apache.org/jira/browse/OFBIZ-10365
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: InventoryTransferModelLevel1.png, 
> OrderModelActivityLevel1.png
>
>
> h2. *Design Approach #1:*
>  * Create Header entity *InventoryTransferHeader (ITH)*
>  ** inventoryTransferId*
>  ** statusId
>  ** facilityId
>  ** locationSeqId
>  ** facilityIdTo
>  ** locationSeqIdTo
>  ** primaryShipmentId
>  
>  * Refactor existing *InventoryTransfer* entity to *InventoryTransferItem* so 
> as to support item level details as follows:
>  ** inventoryTransferId*
>  ** InvtransferItemSeqId*
>  ** inventoryItemId
>  ** shipmentId
>  ** shipmentItemSeqId
>  ** quantity
>  ** unitPrice
>  
> Having InventoryItem detail at InventoryTransferItem level will help us to 
> manage multiple Items under same InventoryTransfer and each 
> InventoryTransferItem can be fulfilled via multiple Inventory items and/or 
> multiple Shipments.
>  
>  * Create *TransferItemBilling* entity to support invoicing (if needed)
>  ** inventoryTransferId*
>  ** InvtransferItemSeqId*
>  ** invoiceId*
>  ** invoiceItemSeqId*
>  ** itemIssuanceId
>  ** shipmentReceiptId
>  ** quantity
>  ** Amount
>  * Create *InventoryTransferContanctMech* entity to support InventoryTransfer 
> Contact Mechanism
>  ** inventoryTransferId*
>  ** contactMechPurposeTypeId*
>  ** contactMechId*
>  * Create *RequirementInventoryTransfer* entity
>  ** requirementId*
>  ** inventoryTransferId*
>  * Refactor existing *InventoryItemDetail* entity
>  ** inventoryTransferId*
>     *Screenflow for Approach #1:* 
>  * Add a new *Find Transfer Requirements* screen.
>  ** Transfer Requirements can be searched with following parameters:
>  *** Requirement ID
>  *** Status ID
>  *** Shipment ID
>  *** Origin Facility ID
>  *** Destination Facility ID
>  *** Product ID
>  *** Description
>  *** Requirement Start Date
>  *** Required By Date
>  
>  * Option for creating Inventory Transfer for Un-approved requirements will 
> be disabled.
>  * User can select multiple Approved Transfer Requirements between any two 
> given facilities to create Single Inventory Transfer between them.
>  * When user hit ‘Create Inventory Transfer’ option new Inventory Transfers 
> would be created by consolidating all products/items requirements between any 
> two given locations.
>  * System would auto-assign the required quantity from existing 
> inventoryItems based on FIFO.
>  * Add a new *View Inventory Transfer* screen
>  ** From here user can manually override the auto-assigned InventoryItems 
> against each product.
>  ** User can Add/Edit/Delete the Transfer Items.
>  ** After assigning InventoryItems user can Approve the Inventory Transfer.
>  ** Upon Approval ATP would get reduced to the tune of assigned quantity from 
> each inventory item.
>  * Refactor the ‘Packing’ screen and allow to submit the Approved Inventory 
> Transfer Id (aka OrderId). Only Approved Inventory Transfer will be available 
> to pack.
>  * Upon completion of packing reduce the QOH from assigned inventory items to 
> the tune of packed quantity.
>  * After completing packing, shipment will be created in shipped status and 
> Inventory Transfer will be marked as 'SENT'.
>  * Once received at destination location the ATP/QOH would be increased up to 
> the transferred quantity per product and shipment will be marked as 
> 'RECEIVED' and Inventory Transfer will be marked as 'COMPLETED'.
>  
>     *To Be Business Process for Approach #1:*
> *!InventoryTransferModelLevel1.png!*
>  
> h2. *Design Approach #2:*
>  * Alter *InventoryTransfer* entity as header entity as follows:
>  ** Add primaryShipmentId
>  ** Remove inventoryItemId
>  
>  * Add new entity *InventoryTransferItem*
>  ** inventoryTransferId*
>  ** InvtransferItemSeqId*
>  ** inventoryItemId
>  ** shipmentId
>  ** shipmentItemSeqId
>  ** quantity
>  ** unitPrice
> Having InventoryItem detail at InventoryTransferItem level will help us to 
> manage multiple Items for same InventoryTransfer and each 
> InventoryTransferItem can be fulfilled via multiple Inventory items and/or 
> multiple Shipments. 
>  * Create TransferItemBilling entity to support tax invoice
>  ** inventoryTransferId*
>  ** InvtransferItemSeqId*
>  ** invoiceId*
>  ** invoiceItemSeqId*
>  ** itemIssu

[jira] [Commented] (OFBIZ-10365) Document design approaches for Inventory Transfer

2018-04-26 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454203#comment-16454203
 ] 

Rishi Solanki commented on OFBIZ-10365:
---

[~pawan.verma]: Thanks for the detailed design.
I'm up for the approach #1 or #2 with following suggestion/concern;
- I'm not able to think of any use of fromDate and thruDate in 
RequirementInventoryTransfer entity design. If not required then can we remove 
them? 
- In TransferItemBilling from where the shipmentReceiptId value come. Could you 
please help me to understand.

Thanks for explaining the design approaches in person.


> Document design approaches for Inventory Transfer 
> --
>
> Key: OFBIZ-10365
> URL: https://issues.apache.org/jira/browse/OFBIZ-10365
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: InventoryTransferModelLevel1.png, 
> OrderModelActivityLevel1.png
>
>
> h2. *Design Approach #1:*
>  * Create Header entity *InventoryTransferHeader (ITH)*
>  ** inventoryTransferId*
>  ** statusId
>  ** facilityId
>  ** locationSeqId
>  ** facilityIdTo
>  ** locationSeqIdTo
>  ** primaryShipmentId
>  
>  * Refactor existing *InventoryTransfer* entity to *InventoryTransferItem* so 
> as to support item level details as follows:
>  ** inventoryTransferId*
>  ** InvtransferItemSeqId*
>  ** inventoryItemId*
>  ** shipmentId
>  ** shipmentItemSeqId
>  ** quantity
>  ** unitPrice
>  
> Having InventoryItem detail at InventoryTransferItem level will help us to 
> manage multiple Items under same InventoryTransfer and each 
> InventoryTransferItem can be fulfilled via multiple Inventory items and/or 
> multiple Shipments.
>  
>  * Create *TransferItemBilling* entity to support invoicing (if needed)
>  ** inventoryTransferId*
>  ** InvtransferItemSeqId*
>  ** invoiceId*
>  ** invoiceItemSeqId*
>  ** itemIssuanceId
>  ** shipmentReceiptId
>  ** quantity
>  ** Amount
>  * Create *InventoryTransferContanctMech* entity to support InventoryTransfer 
> Contact Mechanism
>  ** inventoryTransferId*
>  ** contactMechPurposeTypeId*
>  ** contactMechId*
>  * Create *RequirementInventoryTransfer* entity
>  ** requirementId*
>  ** inventoryTransferId*
>  ** fromDate*
>  ** thruDate
>  * Refactor existing *InventoryItemDetail* entity
>  ** inventoryTransferId*
>     *Screenflow for Approach #1:* 
>  * Add a new *Find Transfer Requirements* screen.
>  ** Transfer Requirements can be searched with following parameters:
>  *** Requirement ID
>  *** Status ID
>  *** Shipment ID
>  *** Origin Facility ID
>  *** Destination Facility ID
>  *** Product ID
>  *** Description
>  *** Requirement Start Date
>  *** Required By Date
>  
>  * Option for creating Inventory Transfer for Un-approved requirements will 
> be disabled.
>  * User can select multiple Approved Transfer Requirements between any two 
> given facilities to create Single Inventory Transfer between them.
>  * When user hit ‘Create Inventory Transfer’ option new Inventory Transfers 
> would be created by consolidating all products/items requirements between any 
> two given locations.
>  * System would auto-assign the required quantity from existing 
> inventoryItems based on FIFO.
>  * Add a new *View Inventory Transfer* screen
>  ** From here user can manually override the auto-assigned InventoryItems 
> against each product.
>  ** User can Add/Edit/Delete the Transfer Items.
>  ** After assigning InventoryItems user can Approve the Inventory Transfer.
>  ** Upon Approval ATP would get reduced to the tune of assigned quantity from 
> each inventory item.
>  * Refactor the ‘Packing’ screen and allow to submit the Approved Inventory 
> Transfer Id (aka OrderId). Only Approved Inventory Transfer will be available 
> to pack.
>  * Upon completion of packing reduce the QOH from assigned inventory items to 
> the tune of packed quantity.
>  * After completing packing, shipment will be created in shipped status and 
> Inventory Transfer will be marked as 'SENT'.
>  * Once received at destination location the ATP/QOH would be increased up to 
> the transferred quantity per product and shipment will be marked as 
> 'RECEIVED' and Inventory Transfer will be marked as 'COMPLETED'.
>  
>     *To Be Business Process for Approach #1:*
> *!InventoryTransferModelLevel1.png!*
>  
> h2. *Design Approach #2:*
>  * Alter *InventoryTransfer* entity as header entity as follows:
>  ** Add primaryShipmentId
>  ** Remove inventoryItemId
>  
>  * Add new entity *InventoryTransferItem*
>  ** inventoryTransferId*
>  ** InvtransferItemSeqId*
>  ** inventoryItemId*
>  ** shipmentId
>  ** shipmentItemSeqId
>  ** quantity
>  ** unitPrice
> Having InventoryItem detail at Inven

[jira] [Commented] (OFBIZ-10369) ConfigXMLReader - Events are not executed in the order defined

2018-04-26 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453857#comment-16453857
 ] 

Rishi Solanki commented on OFBIZ-10369:
---

+1

> ConfigXMLReader - Events are not executed in the order defined
> --
>
> Key: OFBIZ-10369
> URL: https://issues.apache.org/jira/browse/OFBIZ-10369
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 16.11
>Reporter: Vikas Mayur
>Priority: Major
>
> The events contained in the controller configuration for first-visit, 
> pre-post processor and before-after login are executed in arbitrary order 
> rather than the defined order. This results in unexpected results.
> For example,
> {code}
>     
>          path="org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents" 
> invoke="keepCartUpdated"/>
>          path="org.apache.ofbiz.order.shoppinglist.ShoppingListEvents" 
> invoke="restoreAutoSaveList"/>
>          path="org.apache.ofbiz.order.shoppinglist.ShoppingListEvents" 
> invoke="saveCartToAutoSaveList"/>
>     
> {code}
> While debugging I have found that the event 'restoreAutoSaveList' run before 
> 'keepCartUpdated'. I would expect the events to run from top (first) to 
> bottom (last).
>  
> I am unable to attach a patch but below are the changes to fix the issue. I 
> have tested the issue on release 16 and it may be an issue in trunk.
> {code}
> Index: 
> framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ConfigXMLReader.java
> ===
> --- 
> framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ConfigXMLReader.java
>  (revision 1830130)
> +++ 
> framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ConfigXMLReader.java
>  (working copy)
> @@ -25,6 +25,7 @@
>  import java.util.ArrayList;
>  import java.util.HashMap;
>  import java.util.HashSet;
> +import java.util.LinkedHashMap;
>  import java.util.LinkedList;
>  import java.util.List;
>  import java.util.Map;
> @@ -182,11 +183,11 @@
>          private String defaultRequest;
>          private String statusCode;
>          private List includes = new ArrayList();
> -        private Map firstVisitEventList = new HashMap Event>();
> -        private Map preprocessorEventList = new 
> HashMap();
> -        private Map postprocessorEventList = new 
> HashMap();
> -        private Map afterLoginEventList = new HashMap Event>();
> -        private Map beforeLogoutEventList = new 
> HashMap();
> +        private Map firstVisitEventList = new 
> LinkedHashMap();
> +        private Map preprocessorEventList = new 
> LinkedHashMap();
> +        private Map postprocessorEventList = new 
> LinkedHashMap();
> +        private Map afterLoginEventList = new 
> LinkedHashMap();
> +        private Map beforeLogoutEventList = new 
> LinkedHashMap();
>          private Map eventHandlerMap = new HashMap String>();
>          private Map viewHandlerMap = new HashMap String>();
>          private Map requestMapMap = new HashMap RequestMap>();
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-04-10 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432270#comment-16432270
 ] 

Rishi Solanki edited comment on OFBIZ-9501 at 4/10/18 1:38 PM:
---

Done at -r1828817. Thanks Taher!


was (Author: rishisolankii):
Done at -r1828817.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-04-10 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-9501.


> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-04-10 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-9501.
--
Resolution: Fixed

Done at -r1828817.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-04-10 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reopened OFBIZ-9501:
--

Reopening the ticket to address the improvement suggested by Taher in his last 
comment.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-04-06 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428284#comment-16428284
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Comment for myself to work on this. Sorry somehow I missed to get back on 
problem reported by Taher.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-29 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415639#comment-16415639
 ] 

Rishi Solanki edited comment on OFBIZ-10301 at 3/29/18 8:17 AM:


Thanks [~suraj.khurana] for reporting the issue and providing patch for the 
same. Your patch has been committed in trunk -r1827827, 17.12 branch -r1827828 
and 16.11  branch -r1827960.


was (Author: rishisolankii):
Thanks [~suraj.khurana] for reporting the issue and providing patch for the 
same. Your patch has been committed in trunk -r1827827 and 17.12 branch 
-r1827828.

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Trunk, Release Branch 16.11, Upcoming Branch
>
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-29 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-10301:
--
Fix Version/s: Release Branch 16.11

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Trunk, Release Branch 16.11, Upcoming Branch
>
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10301.
-

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Trunk, Upcoming Branch
>
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10301.
---
   Resolution: Fixed
Fix Version/s: Trunk
   Upcoming Branch

Thanks [~suraj.khurana] for reporting the issue and providing patch for the 
same. Your patch has been committed in trunk -r1827827 and 17.12 branch 
-r1827828.

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch, Trunk
>
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-27 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415409#comment-16415409
 ] 

Rishi Solanki commented on OFBIZ-10301:
---

After commit got build failure email, seems no issues with commit. I'll check 
and close the ticket. Thanks Suraj for your work.

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10301:
-

Assignee: Rishi Solanki  (was: Suraj Khurana)

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-10301:
--
Affects Version/s: Trunk
  Component/s: order

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10242) Standardise Layout throughout Applications

2018-03-19 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404808#comment-16404808
 ] 

Rishi Solanki commented on OFBIZ-10242:
---

+1 for back port these improvements to 17.12 . Its worth porting these changes 
for consistency.

> Standardise Layout throughout Applications
> --
>
> Key: OFBIZ-10242
> URL: https://issues.apache.org/jira/browse/OFBIZ-10242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: OFBIZ-10242_common.SecurityScreens.patch, 
> OFBIZ-10242_content.CompDocScreens.patch, 
> OFBIZ-10242_content.ContentScreens.patch, 
> OFBIZ-10242_content.ContentSetupScreens.patch, 
> OFBIZ-10242_content.DataResourceScreens.patch, 
> OFBIZ-10242_content.DataResourceSetupScreens.patch, 
> OFBIZ-10242_content.ForumScreens2.patch, 
> OFBIZ-10242_webtools.EnitityScreens.patch, 
> OFBIZ-10242_webtools.StatsScreens.patch, 
> OFBIZ_webtools.ArtifactInfoScreen.patch
>
>
> While working on a Theme I discovered that many screens are missing 
> screenlets, or some buttons are at the wrong Position etc. .
> I propose to standardise the layout of every screen, to support easy theming. 
> Similar to the examplary patch provided below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10239) Improve GeneralLedgerServices to set transaction date as payment's effective date

2018-03-13 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reopened OFBIZ-10239:
---

Reopening due to buildbot failure.

> Improve GeneralLedgerServices to set transaction date as payment's effective 
> date
> -
>
> Key: OFBIZ-10239
> URL: https://issues.apache.org/jira/browse/OFBIZ-10239
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Aishwary Shrivastava
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-10239.patch
>
>
> Improved createAcctgTransAndEntriesForPaymentApplication and 
> createAcctgTransAndEntriesForOutgoingPayment services to Set transaction date 
> as payment's effective date.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10239) Improve GeneralLedgerServices to set transaction date as payment's effective date

2018-03-13 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10239.
-

> Improve GeneralLedgerServices to set transaction date as payment's effective 
> date
> -
>
> Key: OFBIZ-10239
> URL: https://issues.apache.org/jira/browse/OFBIZ-10239
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Aishwary Shrivastava
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-10239.patch
>
>
> Improved createAcctgTransAndEntriesForPaymentApplication and 
> createAcctgTransAndEntriesForOutgoingPayment services to Set transaction date 
> as payment's effective date.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10239) Improve GeneralLedgerServices to set transaction date as payment's effective date

2018-03-13 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10239.
---
Resolution: Fixed

> Improve GeneralLedgerServices to set transaction date as payment's effective 
> date
> -
>
> Key: OFBIZ-10239
> URL: https://issues.apache.org/jira/browse/OFBIZ-10239
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Aishwary Shrivastava
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-10239.patch
>
>
> Improved createAcctgTransAndEntriesForPaymentApplication and 
> createAcctgTransAndEntriesForOutgoingPayment services to Set transaction date 
> as payment's effective date.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10239) Improve GeneralLedgerServices to set transaction date as payment's effective date

2018-03-13 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396905#comment-16396905
 ] 

Rishi Solanki commented on OFBIZ-10239:
---

Hi [~aishwary]

Your patch has been committed in -r1826627. I have tested it via calling 
services webtools by setting the effective date manually from db layer.

Thanks for your contribution.

> Improve GeneralLedgerServices to set transaction date as payment's effective 
> date
> -
>
> Key: OFBIZ-10239
> URL: https://issues.apache.org/jira/browse/OFBIZ-10239
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Aishwary Shrivastava
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-10239.patch
>
>
> Improved createAcctgTransAndEntriesForPaymentApplication and 
> createAcctgTransAndEntriesForOutgoingPayment services to Set transaction date 
> as payment's effective date.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS

2018-03-05 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386041#comment-16386041
 ] 

Rishi Solanki commented on OFBIZ-10245:
---

[~gil portenseigne],

+1 for the proposal.

I looked at your work looks good. As said, you would like to provide more 
polished work so not commenting on anything. Just one item I would like to see 
if you can consider is to have Electronic Address as parent of Ftp Address in 
the data. I have some more doubts/concerns. But let's come with the finished 
work and then move.

 

Thanks!

> File transfer management with communicationEvent and new contactMech 
> FTP_ADDRESS
> 
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new 
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics : 
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job 
> (like sendEmailDated), to send associated contents to a configured 
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in 
> communicationEvent, waiting for a new try.
> For this purpose :
>  # A new contactMechTypeId is introduced (FtpAddress), with its corresponding 
> table. This contactMech store needed information for basic user/password 
> authentication (server url and protocol, port, username, password, etc.)
>  # A new service sendFileTransferDated (wip) that will look for pending file 
> transfer and call following service.
>  # A new service sendCommEventAsFtp that take a selected commEvent, check its 
> structure and manage its status after trying the associated content file 
> transfers
>  # A new service sendContentToFtp, that take a content and transfer it to a 
> given FtpAddress
>  # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural 
> content file transfer, creating children communicationEvent to follow each 
> content transfer separately (only for several content transfers).
>  # A new Interface FtpClientInterface, with the 3 implementations of FTP, 
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
>  # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress 
> contactMechIdTo, and sendFileTransferDated job planned :
>  * The file is transfered to the ftp : communication event status set to 
> COM_COMPLETE
>  * Error occured : communication event status set to COM_BOUNCED with error 
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk 
> here : 
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
>  (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished 
> work in some days.
> Looking forward reading you !



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-03-04 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385616#comment-16385616
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Taher,

Thanks for reporting this, yes we agree to move these data while working on 
this ticket. I'm not able to recall why Party component left. May be I missed 
this one, I'll take care of this soon and get back.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10239) Improve GeneralLedgerServices to set transaction date as payment's effective date

2018-02-26 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10239:
-

Assignee: Rishi Solanki  (was: Aishwary Shrivastava)

> Improve GeneralLedgerServices to set transaction date as payment's effective 
> date
> -
>
> Key: OFBIZ-10239
> URL: https://issues.apache.org/jira/browse/OFBIZ-10239
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Aishwary Shrivastava
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-10239.patch
>
>
> Improved createAcctgTransAndEntriesForPaymentApplication and 
> createAcctgTransAndEntriesForOutgoingPayment services to Set transaction date 
> as payment's effective date.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10208) Error on Add Item to Shopping List Screen

2018-02-24 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10208.
-

> Error on Add Item to Shopping List Screen
> -
>
> Key: OFBIZ-10208
> URL: https://issues.apache.org/jira/browse/OFBIZ-10208
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 16.11.04
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Release Branch 16.11
>
> Attachments: OFBIZ-10208-EditShoppingListScreen-Fixed.png, 
> OFBIZ-10208-R16.11.patch
>
>
> While working on 16.11 branch, I noticed error when I try to add an item into 
> shopping cart. Here are the steps to replicate the issue:
>  # Go to Party Manager.
>  # Select customer to navigate over profile page.
>  # Click upon Shopping Lists tab.
>  # Create new shopping list, if no one is persist.
>  # Add an item to existing/new shopping list.
> As soon as you click to add on item you will see following error in list item 
> and quick add to shopping list sections.
> {code:java}
> The following has evaluated to null or missing: ==> renderNextPrev [in 
> template "component://common/template/includes/HtmlTemplate.ftl" at line
>  66, column 5]  Tip: If the failing expression is known to be 
> legally refer to something that's sometimes null or missing, either 
> specify a default value like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only 
> cover the last step of the expression; to cover the whole expression, 
> use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)?? 
>   FTL stack trace ("~" means nesting-related): - Failed at: 
> @renderNextPrev paginateStyle, pagina... [in template 
> "component://common/template/includes/HtmlTemplate.ftl" in macro 
> "nextPrev" at line 66, column 3] - Reached through: @nextPrev 
> commonUrl=commonUrl ajaxEna... [in template 
> "component://party/template/party/EditShoppingList.ftl" at line 187, 
> column 9] 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10208) Error on Add Item to Shopping List Screen

2018-02-24 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10208.
---
   Resolution: Fixed
Fix Version/s: Release Branch 16.11

> Error on Add Item to Shopping List Screen
> -
>
> Key: OFBIZ-10208
> URL: https://issues.apache.org/jira/browse/OFBIZ-10208
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 16.11.04
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Release Branch 16.11
>
> Attachments: OFBIZ-10208-EditShoppingListScreen-Fixed.png, 
> OFBIZ-10208-R16.11.patch
>
>
> While working on 16.11 branch, I noticed error when I try to add an item into 
> shopping cart. Here are the steps to replicate the issue:
>  # Go to Party Manager.
>  # Select customer to navigate over profile page.
>  # Click upon Shopping Lists tab.
>  # Create new shopping list, if no one is persist.
>  # Add an item to existing/new shopping list.
> As soon as you click to add on item you will see following error in list item 
> and quick add to shopping list sections.
> {code:java}
> The following has evaluated to null or missing: ==> renderNextPrev [in 
> template "component://common/template/includes/HtmlTemplate.ftl" at line
>  66, column 5]  Tip: If the failing expression is known to be 
> legally refer to something that's sometimes null or missing, either 
> specify a default value like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only 
> cover the last step of the expression; to cover the whole expression, 
> use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)?? 
>   FTL stack trace ("~" means nesting-related): - Failed at: 
> @renderNextPrev paginateStyle, pagina... [in template 
> "component://common/template/includes/HtmlTemplate.ftl" in macro 
> "nextPrev" at line 66, column 3] - Reached through: @nextPrev 
> commonUrl=commonUrl ajaxEna... [in template 
> "component://party/template/party/EditShoppingList.ftl" at line 187, 
> column 9] 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10208) Error on Add Item to Shopping List Screen

2018-02-24 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375532#comment-16375532
 ] 

Rishi Solanki commented on OFBIZ-10208:
---

Thanks Yogesh for providing fix for the issue and Ratnesh for reporting.

Your patch has been committed in R16.11 at revision 1825223.

> Error on Add Item to Shopping List Screen
> -
>
> Key: OFBIZ-10208
> URL: https://issues.apache.org/jira/browse/OFBIZ-10208
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 16.11.04
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10208-EditShoppingListScreen-Fixed.png, 
> OFBIZ-10208-R16.11.patch
>
>
> While working on 16.11 branch, I noticed error when I try to add an item into 
> shopping cart. Here are the steps to replicate the issue:
>  # Go to Party Manager.
>  # Select customer to navigate over profile page.
>  # Click upon Shopping Lists tab.
>  # Create new shopping list, if no one is persist.
>  # Add an item to existing/new shopping list.
> As soon as you click to add on item you will see following error in list item 
> and quick add to shopping list sections.
> {code:java}
> The following has evaluated to null or missing: ==> renderNextPrev [in 
> template "component://common/template/includes/HtmlTemplate.ftl" at line
>  66, column 5]  Tip: If the failing expression is known to be 
> legally refer to something that's sometimes null or missing, either 
> specify a default value like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only 
> cover the last step of the expression; to cover the whole expression, 
> use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)?? 
>   FTL stack trace ("~" means nesting-related): - Failed at: 
> @renderNextPrev paginateStyle, pagina... [in template 
> "component://common/template/includes/HtmlTemplate.ftl" in macro 
> "nextPrev" at line 66, column 3] - Reached through: @nextPrev 
> commonUrl=commonUrl ajaxEna... [in template 
> "component://party/template/party/EditShoppingList.ftl" at line 187, 
> column 9] 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10208) Error on Add Item to Shopping List Screen

2018-02-08 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356978#comment-16356978
 ] 

Rishi Solanki commented on OFBIZ-10208:
---

[~upadhyay.ratnesh] / [~yogesh.naroliya]: Can you please confirm on weather 
issue exists on 17.12 branch, see if you get chance. Otherwise I'll take care 
of it. Thanks!

> Error on Add Item to Shopping List Screen
> -
>
> Key: OFBIZ-10208
> URL: https://issues.apache.org/jira/browse/OFBIZ-10208
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 16.11.04
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10208-EditShoppingListScreen-Fixed.png, 
> OFBIZ-10208-R16.11.patch
>
>
> While working on 16.11 branch, I noticed error when I try to add an item into 
> shopping cart. Here are the steps to replicate the issue:
>  # Go to Party Manager.
>  # Select customer to navigate over profile page.
>  # Click upon Shopping Lists tab.
>  # Create new shopping list, if no one is persist.
>  # Add an item to existing/new shopping list.
> As soon as you click to add on item you will see following error in list item 
> and quick add to shopping list sections.
> {code:java}
> The following has evaluated to null or missing: ==> renderNextPrev [in 
> template "component://common/template/includes/HtmlTemplate.ftl" at line
>  66, column 5]  Tip: If the failing expression is known to be 
> legally refer to something that's sometimes null or missing, either 
> specify a default value like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only 
> cover the last step of the expression; to cover the whole expression, 
> use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)?? 
>   FTL stack trace ("~" means nesting-related): - Failed at: 
> @renderNextPrev paginateStyle, pagina... [in template 
> "component://common/template/includes/HtmlTemplate.ftl" in macro 
> "nextPrev" at line 66, column 3] - Reached through: @nextPrev 
> commonUrl=commonUrl ajaxEna... [in template 
> "component://party/template/party/EditShoppingList.ftl" at line 187, 
> column 9] 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10208) Error on Add Item to Shopping List Screen

2018-02-08 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10208:
-

Assignee: Rishi Solanki  (was: Yogesh Naroliya)

> Error on Add Item to Shopping List Screen
> -
>
> Key: OFBIZ-10208
> URL: https://issues.apache.org/jira/browse/OFBIZ-10208
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 16.11.04
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10208-EditShoppingListScreen-Fixed.png, 
> OFBIZ-10208-R16.11.patch
>
>
> While working on 16.11 branch, I noticed error when I try to add an item into 
> shopping cart. Here are the steps to replicate the issue:
>  # Go to Party Manager.
>  # Select customer to navigate over profile page.
>  # Click upon Shopping Lists tab.
>  # Create new shopping list, if no one is persist.
>  # Add an item to existing/new shopping list.
> As soon as you click to add on item you will see following error in list item 
> and quick add to shopping list sections.
> {code:java}
> The following has evaluated to null or missing: ==> renderNextPrev [in 
> template "component://common/template/includes/HtmlTemplate.ftl" at line
>  66, column 5]  Tip: If the failing expression is known to be 
> legally refer to something that's sometimes null or missing, either 
> specify a default value like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only 
> cover the last step of the expression; to cover the whole expression, 
> use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)?? 
>   FTL stack trace ("~" means nesting-related): - Failed at: 
> @renderNextPrev paginateStyle, pagina... [in template 
> "component://common/template/includes/HtmlTemplate.ftl" in macro 
> "nextPrev" at line 66, column 3] - Reached through: @nextPrev 
> commonUrl=commonUrl ajaxEna... [in template 
> "component://party/template/party/EditShoppingList.ftl" at line 187, 
> column 9] 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-02-06 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355016#comment-16355016
 ] 

Rishi Solanki edited comment on OFBIZ-9501 at 2/7/18 6:26 AM:
--

Thanks [~taher] for your continuous support and all who involve/help in this 
effort. Closing the ticket.

All thanks again for your help.


was (Author: rishisolankii):
Thanks [~taher] for your continuous support and all who involve/help in this 
effort. Closing the ticket.

 

All thanks again for your help.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-02-06 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-9501.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks [~taher] for your continuous support and all who involve/help in this 
effort. Closing the ticket.

 

All thanks again for your help.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-02-06 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-9501.


> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-02-05 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352473#comment-16352473
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Thanks [~sourabh.jain] for your contribution. Your patch has been committed in 
revision 1823177, 1823182.

[~taher] / All do we have anything else we would like to address under this 
ticket?

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10183) Error on My Portal > Request Overview Page

2018-01-29 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10183.
---
   Resolution: Fixed
Fix Version/s: Release Branch 16.11
   Upcoming Branch

[~yogesh.naroliya]: Your patch has been committed in revisions trunk- 1822512, 
17.12- 1822513 and 16.11- 1822515. Thanks for your contribution.

Thanks [~upadhyay.ratnesh] for reporting the issue.

> Error on My Portal > Request Overview Page
> --
>
> Key: OFBIZ-10183
> URL: https://issues.apache.org/jira/browse/OFBIZ-10183
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch, Release Branch 16.11
>
> Attachments: OFBIZ-10183-REL16.11.patch, OFBIZ-10183-Trunk.patch, 
> OFBIZ-10183.png
>
>
> While browsing through my portal app, I noticed this issue. Here are the 
> steps to replicate the issue.
>  # Go to My Portal > My Comms.
>  # Click upon any customer request Id link to navigate on Request Overview 
> page.
> Following error appeared on overview page as soon as user lands on this page.
> {code:java}
> Error
>  rendering included template at location 
> [component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl]:
>  freemarker.template.TemplateNotFoundException: Template not found for 
> name 
> "component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl".
>  The name was interpreted by this TemplateLoader: 
> MultiTemplateLoader(loader1 = 
> org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@49711524,
>  loader2 = StringTemplateLoader(Map { })).
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10183) Error on My Portal > Request Overview Page

2018-01-29 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10183.
-

> Error on My Portal > Request Overview Page
> --
>
> Key: OFBIZ-10183
> URL: https://issues.apache.org/jira/browse/OFBIZ-10183
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Release Branch 16.11, Upcoming Branch
>
> Attachments: OFBIZ-10183-REL16.11.patch, OFBIZ-10183-Trunk.patch, 
> OFBIZ-10183.png
>
>
> While browsing through my portal app, I noticed this issue. Here are the 
> steps to replicate the issue.
>  # Go to My Portal > My Comms.
>  # Click upon any customer request Id link to navigate on Request Overview 
> page.
> Following error appeared on overview page as soon as user lands on this page.
> {code:java}
> Error
>  rendering included template at location 
> [component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl]:
>  freemarker.template.TemplateNotFoundException: Template not found for 
> name 
> "component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl".
>  The name was interpreted by this TemplateLoader: 
> MultiTemplateLoader(loader1 = 
> org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@49711524,
>  loader2 = StringTemplateLoader(Map { })).
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10171) Implement and Apply Return Lookup

2018-01-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10171.
-

> Implement and Apply Return Lookup
> -
>
> Key: OFBIZ-10171
> URL: https://issues.apache.org/jira/browse/OFBIZ-10171
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10171-ReturnLookup-FindResult-InvScreen.png, 
> OFBIZ-10171-ReturnLookup-Optn-CommScreen.png, 
> OFBIZ-10171-ReturnLookup-Optn-InvScreen.png, 
> OFBIZ-10171-ReturnLookup-Popup-CommScreen.png, 
> OFBIZ-10171-ReturnLookup-Popup-InvScreen.png, 
> OFBIZ-10171-ReturnLookup-SearchResult.png, 
> OFBIZ-10171-ReturnLookup-SetField-CommScreen.png, 
> OFBIZ-10171-ReturnLookup-SetField-InvScreen.png, OFBIZ-10171.patch
>
>
> Implement Return Lookup and embed it over related forms where we need to 
> lookup return and set selected return information over form.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10171) Implement and Apply Return Lookup

2018-01-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10171.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

[~upadhyay.ratnesh] Thanks for your contribution your patch has been committed 
in trunk revision 1822411.

Thanks [~yogesh.naroliya] for detail verification.

> Implement and Apply Return Lookup
> -
>
> Key: OFBIZ-10171
> URL: https://issues.apache.org/jira/browse/OFBIZ-10171
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10171-ReturnLookup-FindResult-InvScreen.png, 
> OFBIZ-10171-ReturnLookup-Optn-CommScreen.png, 
> OFBIZ-10171-ReturnLookup-Optn-InvScreen.png, 
> OFBIZ-10171-ReturnLookup-Popup-CommScreen.png, 
> OFBIZ-10171-ReturnLookup-Popup-InvScreen.png, 
> OFBIZ-10171-ReturnLookup-SearchResult.png, 
> OFBIZ-10171-ReturnLookup-SetField-CommScreen.png, 
> OFBIZ-10171-ReturnLookup-SetField-InvScreen.png, OFBIZ-10171.patch
>
>
> Implement Return Lookup and embed it over related forms where we need to 
> lookup return and set selected return information over form.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-01-27 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342148#comment-16342148
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Thank you [~sourabh.jain] for your patch, I'll review and commit it soon.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10171) Implement and Apply Return Lookup

2018-01-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10171:
-

Assignee: Rishi Solanki  (was: Yogesh Naroliya)

> Implement and Apply Return Lookup
> -
>
> Key: OFBIZ-10171
> URL: https://issues.apache.org/jira/browse/OFBIZ-10171
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10171-ReturnLookup-FindResult-InvScreen.png, 
> OFBIZ-10171-ReturnLookup-Optn-CommScreen.png, 
> OFBIZ-10171-ReturnLookup-Optn-InvScreen.png, 
> OFBIZ-10171-ReturnLookup-Popup-CommScreen.png, 
> OFBIZ-10171-ReturnLookup-Popup-InvScreen.png, 
> OFBIZ-10171-ReturnLookup-SearchResult.png, 
> OFBIZ-10171-ReturnLookup-SetField-CommScreen.png, 
> OFBIZ-10171-ReturnLookup-SetField-InvScreen.png, OFBIZ-10171.patch
>
>
> Implement Return Lookup and embed it over related forms where we need to 
> lookup return and set selected return information over form.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10183) Error on My Portal > Request Overview Page

2018-01-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10183:
-

Assignee: Rishi Solanki

> Error on My Portal > Request Overview Page
> --
>
> Key: OFBIZ-10183
> URL: https://issues.apache.org/jira/browse/OFBIZ-10183
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10183-REL16.11.patch, OFBIZ-10183-Trunk.patch, 
> OFBIZ-10183.png
>
>
> While browsing through my portal app, I noticed this issue. Here are the 
> steps to replicate the issue.
>  # Go to My Portal > My Comms.
>  # Click upon any customer request Id link to navigate on Request Overview 
> page.
> Following error appeared on overview page as soon as user lands on this page.
> {code:java}
> Error
>  rendering included template at location 
> [component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl]:
>  freemarker.template.TemplateNotFoundException: Template not found for 
> name 
> "component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl".
>  The name was interpreted by this TemplateLoader: 
> MultiTemplateLoader(loader1 = 
> org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@49711524,
>  loader2 = StringTemplateLoader(Map { })).
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10173) Add/Modify Calender Event Screen is Broken

2018-01-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10173.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Issue has been fixed in trunk revision 1822375 and in 17.12 revision 1822376. 
The issue won't exists in previous branches as code version is different.

Thanks [~yogesh.naroliya] and [~upadhyay.ratnesh] for your contribution.

> Add/Modify Calender Event Screen is Broken
> --
>
> Key: OFBIZ-10173
> URL: https://issues.apache.org/jira/browse/OFBIZ-10173
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10173.patch
>
>
> *Steps to reproduce the issue*:
>  # Go HR component.
>  # Click on Training Tab.
>  # Click on any event listed over training calendar to navigate over modify 
> event screen.
> Here is the error message appearing on page when user tried to navigate on 
> any event from training calendar.
> {code:java}
> java.lang.IllegalArgumentException:
>  Error running script at location 
> [component:///workeffort/groovyScripts/ical/IsCalOwner.groovy]: 
> org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot 
> cast object 
> '[GenericEntity:WorkEffortPartyAssignment][assignedByUserLoginId,admin(java.lang.String)][availabilityStatusId,null()][comments,null()][createdStamp,2018-01-19
>  16:49:36.69(java.sql.Timestamp)][createdTxStamp,2018-01-19 
> 16:49:36.616(java.sql.Timestamp)][delegateReasonEnumId,null()][expectationEnumId,null()][facilityId,null()][fromDate,2018-01-19
>  16:49:36.69(java.sql.Timestamp)][lastUpdatedStamp,2018-01-19 
> 16:49:36.69(java.sql.Timestamp)][lastUpdatedTxStamp,2018-01-19 
> 16:49:36.616(java.sql.Timestamp)][mustRsvp,null()][partyId,admin(java.lang.String)][roleTypeId,CAL_OWNER(java.lang.String)][statusDateTime,null()][statusId,PRTYASGN_ASSIGNED(java.lang.String)][thruDate,null()][workEffortId,10041(java.lang.String)]'
>  with class 'org.apache.ofbiz.entity.GenericValue' to class 
> 'java.util.List' due to: groovy.lang.GroovyRuntimeException: Could not 
> find matching constructor for: 
> java.util.List(org.apache.ofbiz.entity.GenericValue)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10173) Add/Modify Calender Event Screen is Broken

2018-01-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10173.
-

> Add/Modify Calender Event Screen is Broken
> --
>
> Key: OFBIZ-10173
> URL: https://issues.apache.org/jira/browse/OFBIZ-10173
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10173.patch
>
>
> *Steps to reproduce the issue*:
>  # Go HR component.
>  # Click on Training Tab.
>  # Click on any event listed over training calendar to navigate over modify 
> event screen.
> Here is the error message appearing on page when user tried to navigate on 
> any event from training calendar.
> {code:java}
> java.lang.IllegalArgumentException:
>  Error running script at location 
> [component:///workeffort/groovyScripts/ical/IsCalOwner.groovy]: 
> org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot 
> cast object 
> '[GenericEntity:WorkEffortPartyAssignment][assignedByUserLoginId,admin(java.lang.String)][availabilityStatusId,null()][comments,null()][createdStamp,2018-01-19
>  16:49:36.69(java.sql.Timestamp)][createdTxStamp,2018-01-19 
> 16:49:36.616(java.sql.Timestamp)][delegateReasonEnumId,null()][expectationEnumId,null()][facilityId,null()][fromDate,2018-01-19
>  16:49:36.69(java.sql.Timestamp)][lastUpdatedStamp,2018-01-19 
> 16:49:36.69(java.sql.Timestamp)][lastUpdatedTxStamp,2018-01-19 
> 16:49:36.616(java.sql.Timestamp)][mustRsvp,null()][partyId,admin(java.lang.String)][roleTypeId,CAL_OWNER(java.lang.String)][statusDateTime,null()][statusId,PRTYASGN_ASSIGNED(java.lang.String)][thruDate,null()][workEffortId,10041(java.lang.String)]'
>  with class 'org.apache.ofbiz.entity.GenericValue' to class 
> 'java.util.List' due to: groovy.lang.GroovyRuntimeException: Could not 
> find matching constructor for: 
> java.util.List(org.apache.ofbiz.entity.GenericValue)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10173) Add/Modify Calender Event Screen is Broken

2018-01-26 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10173:
-

Assignee: Rishi Solanki

> Add/Modify Calender Event Screen is Broken
> --
>
> Key: OFBIZ-10173
> URL: https://issues.apache.org/jira/browse/OFBIZ-10173
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10173.patch
>
>
> *Steps to reproduce the issue*:
>  # Go HR component.
>  # Click on Training Tab.
>  # Click on any event listed over training calendar to navigate over modify 
> event screen.
> Here is the error message appearing on page when user tried to navigate on 
> any event from training calendar.
> {code:java}
> java.lang.IllegalArgumentException:
>  Error running script at location 
> [component:///workeffort/groovyScripts/ical/IsCalOwner.groovy]: 
> org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot 
> cast object 
> '[GenericEntity:WorkEffortPartyAssignment][assignedByUserLoginId,admin(java.lang.String)][availabilityStatusId,null()][comments,null()][createdStamp,2018-01-19
>  16:49:36.69(java.sql.Timestamp)][createdTxStamp,2018-01-19 
> 16:49:36.616(java.sql.Timestamp)][delegateReasonEnumId,null()][expectationEnumId,null()][facilityId,null()][fromDate,2018-01-19
>  16:49:36.69(java.sql.Timestamp)][lastUpdatedStamp,2018-01-19 
> 16:49:36.69(java.sql.Timestamp)][lastUpdatedTxStamp,2018-01-19 
> 16:49:36.616(java.sql.Timestamp)][mustRsvp,null()][partyId,admin(java.lang.String)][roleTypeId,CAL_OWNER(java.lang.String)][statusDateTime,null()][statusId,PRTYASGN_ASSIGNED(java.lang.String)][thruDate,null()][workEffortId,10041(java.lang.String)]'
>  with class 'org.apache.ofbiz.entity.GenericValue' to class 
> 'java.util.List' due to: groovy.lang.GroovyRuntimeException: Could not 
> find matching constructor for: 
> java.util.List(org.apache.ofbiz.entity.GenericValue)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9911) Add ability to record Return Communication

2018-01-19 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332251#comment-16332251
 ] 

Rishi Solanki commented on OFBIZ-9911:
--

No worries [~jacques.le.roux]  I always find your comments/reviews helpful. :)

> Add ability to record Return Communication
> --
>
> Key: OFBIZ-9911
> URL: https://issues.apache.org/jira/browse/OFBIZ-9911
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, 
> OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, 
> OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, 
> OFBIZ-9911.patch, OFBIZ-9911.patch
>
>
> In OOTB we are having the ability to record order specific communication in 
> CommunicationEventOrder and the user can retrieve/review them from party > 
> communications screen but we don't have such support for return 
> communications. So It would be great to have an ability to record return 
> specific communication in the system.
> We have to implement following items to establish this feature :
> *Data Model Details:*
> - We will have to create new entity CommunicationEventReturn to record return 
> communication. It should have returnId and communicationEventId along with 
> other necessary fields.
> - We have to implement following view CommunicationEventAndReturn to fetch 
> return communications over screens as needed.
> *New Implementation Details:*
> - We have to add CRUD services for the new entity. 
> *Existing Implementation Details:*
> - We have to extend createCommunicationEvent service definition with retunId 
> field and extend the existing implementation to create the record in 
> CommunicationEventReturn based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId 
> in service context.
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication 
> By Order screen, in the same way, we can add another screen to find 
> communication by return.
> - We can add return communication screenlet over Order Manager > Return > 
> Return History screen or we can add communication tab under Order > Return 
> screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
> Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for 
> discussion and inputs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9911) Add ability to record Return Communication

2018-01-18 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-9911.


> Add ability to record Return Communication
> --
>
> Key: OFBIZ-9911
> URL: https://issues.apache.org/jira/browse/OFBIZ-9911
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, 
> OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, 
> OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, 
> OFBIZ-9911.patch, OFBIZ-9911.patch
>
>
> In OOTB we are having the ability to record order specific communication in 
> CommunicationEventOrder and the user can retrieve/review them from party > 
> communications screen but we don't have such support for return 
> communications. So It would be great to have an ability to record return 
> specific communication in the system.
> We have to implement following items to establish this feature :
> *Data Model Details:*
> - We will have to create new entity CommunicationEventReturn to record return 
> communication. It should have returnId and communicationEventId along with 
> other necessary fields.
> - We have to implement following view CommunicationEventAndReturn to fetch 
> return communications over screens as needed.
> *New Implementation Details:*
> - We have to add CRUD services for the new entity. 
> *Existing Implementation Details:*
> - We have to extend createCommunicationEvent service definition with retunId 
> field and extend the existing implementation to create the record in 
> CommunicationEventReturn based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId 
> in service context.
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication 
> By Order screen, in the same way, we can add another screen to find 
> communication by return.
> - We can add return communication screenlet over Order Manager > Return > 
> Return History screen or we can add communication tab under Order > Return 
> screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
> Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for 
> discussion and inputs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9911) Add ability to record Return Communication

2018-01-18 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-9911:
-
Affects Version/s: Trunk

> Add ability to record Return Communication
> --
>
> Key: OFBIZ-9911
> URL: https://issues.apache.org/jira/browse/OFBIZ-9911
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, 
> OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, 
> OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, 
> OFBIZ-9911.patch, OFBIZ-9911.patch
>
>
> In OOTB we are having the ability to record order specific communication in 
> CommunicationEventOrder and the user can retrieve/review them from party > 
> communications screen but we don't have such support for return 
> communications. So It would be great to have an ability to record return 
> specific communication in the system.
> We have to implement following items to establish this feature :
> *Data Model Details:*
> - We will have to create new entity CommunicationEventReturn to record return 
> communication. It should have returnId and communicationEventId along with 
> other necessary fields.
> - We have to implement following view CommunicationEventAndReturn to fetch 
> return communications over screens as needed.
> *New Implementation Details:*
> - We have to add CRUD services for the new entity. 
> *Existing Implementation Details:*
> - We have to extend createCommunicationEvent service definition with retunId 
> field and extend the existing implementation to create the record in 
> CommunicationEventReturn based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId 
> in service context.
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication 
> By Order screen, in the same way, we can add another screen to find 
> communication by return.
> - We can add return communication screenlet over Order Manager > Return > 
> Return History screen or we can add communication tab under Order > Return 
> screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
> Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for 
> discussion and inputs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9911) Add ability to record Return Communication

2018-01-18 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330402#comment-16330402
 ] 

Rishi Solanki commented on OFBIZ-9911:
--

The patch has been committed in trunk -r1821486. Thanks for your contribution 
[~upadhyay.ratnesh] and [~aishwary] for testing.

> Add ability to record Return Communication
> --
>
> Key: OFBIZ-9911
> URL: https://issues.apache.org/jira/browse/OFBIZ-9911
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, 
> OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, 
> OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, 
> OFBIZ-9911.patch, OFBIZ-9911.patch
>
>
> In OOTB we are having the ability to record order specific communication in 
> CommunicationEventOrder and the user can retrieve/review them from party > 
> communications screen but we don't have such support for return 
> communications. So It would be great to have an ability to record return 
> specific communication in the system.
> We have to implement following items to establish this feature :
> *Data Model Details:*
> - We will have to create new entity CommunicationEventReturn to record return 
> communication. It should have returnId and communicationEventId along with 
> other necessary fields.
> - We have to implement following view CommunicationEventAndReturn to fetch 
> return communications over screens as needed.
> *New Implementation Details:*
> - We have to add CRUD services for the new entity. 
> *Existing Implementation Details:*
> - We have to extend createCommunicationEvent service definition with retunId 
> field and extend the existing implementation to create the record in 
> CommunicationEventReturn based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId 
> in service context.
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication 
> By Order screen, in the same way, we can add another screen to find 
> communication by return.
> - We can add return communication screenlet over Order Manager > Return > 
> Return History screen or we can add communication tab under Order > Return 
> screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
> Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for 
> discussion and inputs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-9911) Add ability to record Return Communication

2018-01-18 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-9911.
--
Resolution: Fixed

> Add ability to record Return Communication
> --
>
> Key: OFBIZ-9911
> URL: https://issues.apache.org/jira/browse/OFBIZ-9911
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, 
> OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, 
> OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, 
> OFBIZ-9911.patch, OFBIZ-9911.patch
>
>
> In OOTB we are having the ability to record order specific communication in 
> CommunicationEventOrder and the user can retrieve/review them from party > 
> communications screen but we don't have such support for return 
> communications. So It would be great to have an ability to record return 
> specific communication in the system.
> We have to implement following items to establish this feature :
> *Data Model Details:*
> - We will have to create new entity CommunicationEventReturn to record return 
> communication. It should have returnId and communicationEventId along with 
> other necessary fields.
> - We have to implement following view CommunicationEventAndReturn to fetch 
> return communications over screens as needed.
> *New Implementation Details:*
> - We have to add CRUD services for the new entity. 
> *Existing Implementation Details:*
> - We have to extend createCommunicationEvent service definition with retunId 
> field and extend the existing implementation to create the record in 
> CommunicationEventReturn based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId 
> in service context.
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication 
> By Order screen, in the same way, we can add another screen to find 
> communication by return.
> - We can add return communication screenlet over Order Manager > Return > 
> Return History screen or we can add communication tab under Order > Return 
> screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
> Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for 
> discussion and inputs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-01-16 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327017#comment-16327017
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Taher,

Thank you for the details and everything making perfect sense to me to have 
all/most of the demo data in the data model component. I dig into it further 
and review the data for one component and back  with the data movement plan. 
Then will go for the final move.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-01-11 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322334#comment-16322334
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

[~taher] and all,

I'm looking into it further and check that as per review comment from Taher 
that the data useless without that component then it should belongs to that 
component only. On this we were agree to leave some data in the component 
itself. Here I'm looking into demo data now and taking accounting component 
example for now. Below are the demo data files in the accounting component and 
I see most of the files data should belongs to component itself. So do we need 
to proceed further with this ticket or we should discuss the accounting 
component as example and try to move selective demo data as well. Like all 
seed-initial data belongs to component as per last discussion.
I think demo fall in the same category so no movement required. Also I'm open 
to discuss the part data which can be move and then will apply the patterns to 
other components. Here is the quick reference;

{code}













{code}

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9905) Issue with Agreement under Accounting

2018-01-03 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310795#comment-16310795
 ] 

Rishi Solanki commented on OFBIZ-9905:
--

+1 [~jacques.le.roux] we should consider only Create or New.

> Issue with Agreement under Accounting
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: sourabh jain
> Attachments: OFBIZ-9905.patch, UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-10129) Order Process Broken - Due to Missing Service Defination

2017-12-30 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10129.
-

> Order Process Broken - Due to Missing Service Defination
> 
>
> Key: OFBIZ-10129
> URL: https://issues.apache.org/jira/browse/OFBIZ-10129
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-10129.patch
>
>
> Getting following error over screen while placing order : 
> {code}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> java.lang.IllegalArgumentException: Error running script at location 
> [component://order/groovyScripts/entry/BillSettings.groovy]: 
> org.apache.ofbiz.service.GenericServiceException: Cannot locate service by 
> name (getRelatedParties)
> {code}
> After further research it seems that service definition gets removed at 
> revision:1819138 under OFBIZ-9988



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-10129) Order Process Broken - Due to Missing Service Defination

2017-12-30 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10129.
---
   Resolution: Fixed
Fix Version/s: Upcoming Release

> Order Process Broken - Due to Missing Service Defination
> 
>
> Key: OFBIZ-10129
> URL: https://issues.apache.org/jira/browse/OFBIZ-10129
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-10129.patch
>
>
> Getting following error over screen while placing order : 
> {code}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> java.lang.IllegalArgumentException: Error running script at location 
> [component://order/groovyScripts/entry/BillSettings.groovy]: 
> org.apache.ofbiz.service.GenericServiceException: Cannot locate service by 
> name (getRelatedParties)
> {code}
> After further research it seems that service definition gets removed at 
> revision:1819138 under OFBIZ-9988



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-10129) Order Process Broken - Due to Missing Service Defination

2017-12-30 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307131#comment-16307131
 ] 

Rishi Solanki commented on OFBIZ-10129:
---

[~upadhyay.ratnesh]: Your patch has been committed in trunk  at -r1819587 and 
in 17.12 at -r1819588. Thanks for your contribution.

> Order Process Broken - Due to Missing Service Defination
> 
>
> Key: OFBIZ-10129
> URL: https://issues.apache.org/jira/browse/OFBIZ-10129
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
> Attachments: OFBIZ-10129.patch
>
>
> Getting following error over screen while placing order : 
> {code}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> java.lang.IllegalArgumentException: Error running script at location 
> [component://order/groovyScripts/entry/BillSettings.groovy]: 
> org.apache.ofbiz.service.GenericServiceException: Cannot locate service by 
> name (getRelatedParties)
> {code}
> After further research it seems that service definition gets removed at 
> revision:1819138 under OFBIZ-9988



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-10129) Order Process Broken - Due to Missing Service Defination

2017-12-29 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10129:
-

Assignee: Rishi Solanki  (was: Ratnesh Upadhyay)

> Order Process Broken - Due to Missing Service Defination
> 
>
> Key: OFBIZ-10129
> URL: https://issues.apache.org/jira/browse/OFBIZ-10129
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
> Attachments: OFBIZ-10129.patch
>
>
> Getting following error over screen while placing order : 
> {code}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> java.lang.IllegalArgumentException: Error running script at location 
> [component://order/groovyScripts/entry/BillSettings.groovy]: 
> org.apache.ofbiz.service.GenericServiceException: Cannot locate service by 
> name (getRelatedParties)
> {code}
> After further research it seems that service definition gets removed at 
> revision:1819138 under OFBIZ-9988



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-10120) Unable to remove selected item from cart

2017-12-29 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306283#comment-16306283
 ] 

Rishi Solanki commented on OFBIZ-10120:
---

Thank you [~deepak.dixit] for clarification and closing this ticket.

> Unable to remove selected item from cart
> 
>
> Key: OFBIZ-10120
> URL: https://issues.apache.org/jira/browse/OFBIZ-10120
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Yogesh Naroliya
>Assignee: Rishi Solanki
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-10120.patch, RemoveSelectedItemIssue.png
>
>
> *Steps to Regenerate:*
> 1. Open https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> 2. Press continue on sales order screen.
> 3. Add a finished good item to the sales order.
> 4. Select added item.
> 5. Click on *Remove Selected* button. 
> *Actual:*
> It is throwing following error:
> {code}
> The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: 
> Problems processing event: java.lang.IllegalArgumentException: Timestamp 
> format must be -mm-dd hh:mm:ss[.f] (Timestamp format must be 
> -mm-dd hh:mm:ss[.f])
> {code}
> Note: Screenshot attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-10120) Unable to remove selected item from cart

2017-12-29 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10120.
---
   Resolution: Fixed
Fix Version/s: Upcoming Release

Added fixed version as upcoming release, need to add 17.12 release with this 
ticket (not populating in jira currenly). 

> Unable to remove selected item from cart
> 
>
> Key: OFBIZ-10120
> URL: https://issues.apache.org/jira/browse/OFBIZ-10120
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Yogesh Naroliya
>Assignee: Rishi Solanki
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-10120.patch, RemoveSelectedItemIssue.png
>
>
> *Steps to Regenerate:*
> 1. Open https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> 2. Press continue on sales order screen.
> 3. Add a finished good item to the sales order.
> 4. Select added item.
> 5. Click on *Remove Selected* button. 
> *Actual:*
> It is throwing following error:
> {code}
> The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: 
> Problems processing event: java.lang.IllegalArgumentException: Timestamp 
> format must be -mm-dd hh:mm:ss[.f] (Timestamp format must be 
> -mm-dd hh:mm:ss[.f])
> {code}
> Note: Screenshot attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-10120) Unable to remove selected item from cart

2017-12-29 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306141#comment-16306141
 ] 

Rishi Solanki commented on OFBIZ-10120:
---

[~yogesh.naroliya]: Thank you for reporting the issue and providing patch to 
fix the issue. Your patch has been committed in trunk r1819470 and in 17.12 
branch r1819471. Thanks for your contribution and additional details.

> Unable to remove selected item from cart
> 
>
> Key: OFBIZ-10120
> URL: https://issues.apache.org/jira/browse/OFBIZ-10120
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Yogesh Naroliya
>Assignee: Rishi Solanki
> Attachments: OFBIZ-10120.patch, RemoveSelectedItemIssue.png
>
>
> *Steps to Regenerate:*
> 1. Open https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> 2. Press continue on sales order screen.
> 3. Add a finished good item to the sales order.
> 4. Select added item.
> 5. Click on *Remove Selected* button. 
> *Actual:*
> It is throwing following error:
> {code}
> The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: 
> Problems processing event: java.lang.IllegalArgumentException: Timestamp 
> format must be -mm-dd hh:mm:ss[.f] (Timestamp format must be 
> -mm-dd hh:mm:ss[.f])
> {code}
> Note: Screenshot attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-10120) Unable to remove selected item from cart

2017-12-26 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10120:
-

Assignee: Rishi Solanki

> Unable to remove selected item from cart
> 
>
> Key: OFBIZ-10120
> URL: https://issues.apache.org/jira/browse/OFBIZ-10120
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Yogesh Naroliya
>Assignee: Rishi Solanki
> Attachments: OFBIZ-10120.patch, RemoveSelectedItemIssue.png
>
>
> *Steps to Regenerate:*
> 1. Open https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> 2. Press continue on sales order screen.
> 3. Add a finished good item to the sales order.
> 4. Select added item.
> 5. Click on *Remove Selected* button. 
> *Actual:*
> It is throwing following error:
> {code}
> The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: 
> Problems processing event: java.lang.IllegalArgumentException: Timestamp 
> format must be -mm-dd hh:mm:ss[.f] (Timestamp format must be 
> -mm-dd hh:mm:ss[.f])
> {code}
> Note: Screenshot attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9905) Issue with Agreement under Accounting

2017-12-23 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302436#comment-16302436
 ] 

Rishi Solanki commented on OFBIZ-9905:
--

+1 Sourabh for make it consistent.

> Issue with Agreement under Accounting
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: sourabh jain
> Attachments: OFBIZ-9905.patch, UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9911) Add ability to record Return Communication

2017-12-23 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302434#comment-16302434
 ] 

Rishi Solanki commented on OFBIZ-9911:
--

Thank you [~aishwary] for testing, looks good. I will have some concern over 
the patch will discuss it with [~upadhyay.ratnesh] and commit.

> Add ability to record Return Communication
> --
>
> Key: OFBIZ-9911
> URL: https://issues.apache.org/jira/browse/OFBIZ-9911
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
> Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, 
> OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, 
> OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, 
> OFBIZ-9911.patch
>
>
> In OOTB we are having the ability to record order specific communication in 
> CommunicationEventOrder and the user can retrieve/review them from party > 
> communications screen but we don't have such support for return 
> communications. So It would be great to have an ability to record return 
> specific communication in the system.
> We have to implement following items to establish this feature :
> *Data Model Details:*
> - We will have to create new entity CommunicationEventReturn to record return 
> communication. It should have returnId and communicationEventId along with 
> other necessary fields.
> - We have to implement following view CommunicationEventAndReturn to fetch 
> return communications over screens as needed.
> *New Implementation Details:*
> - We have to add CRUD services for the new entity. 
> *Existing Implementation Details:*
> - We have to extend createCommunicationEvent service definition with retunId 
> field and extend the existing implementation to create the record in 
> CommunicationEventReturn based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId 
> in service context.
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication 
> By Order screen, in the same way, we can add another screen to find 
> communication by return.
> - We can add return communication screenlet over Order Manager > Return > 
> Return History screen or we can add communication tab under Order > Return 
> screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
> Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for 
> discussion and inputs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9911) Add ability to record Return Communication

2017-12-20 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298510#comment-16298510
 ] 

Rishi Solanki commented on OFBIZ-9911:
--

Thanks [~upadhyay.ratnesh] for the details and patch. I'll take care of it soon.

> Add ability to record Return Communication
> --
>
> Key: OFBIZ-9911
> URL: https://issues.apache.org/jira/browse/OFBIZ-9911
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
> Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, 
> OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, 
> OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, 
> OFBIZ-9911.patch
>
>
> In OOTB we are having the ability to record order specific communication in 
> CommunicationEventOrder and the user can retrieve/review them from party > 
> communications screen but we don't have such support for return 
> communications. So It would be great to have an ability to record return 
> specific communication in the system.
> We have to implement following items to establish this feature :
> *Data Model Details:*
> - We will have to create new entity CommunicationEventReturn to record return 
> communication. It should have returnId and communicationEventId along with 
> other necessary fields.
> - We have to implement following view CommunicationEventAndReturn to fetch 
> return communications over screens as needed.
> *New Implementation Details:*
> - We have to add CRUD services for the new entity. 
> *Existing Implementation Details:*
> - We have to extend createCommunicationEvent service definition with retunId 
> field and extend the existing implementation to create the record in 
> CommunicationEventReturn based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId 
> in service context.
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication 
> By Order screen, in the same way, we can add another screen to find 
> communication by return.
> - We can add return communication screenlet over Order Manager > Return > 
> Return History screen or we can add communication tab under Order > Return 
> screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
> Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for 
> discussion and inputs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-16 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293777#comment-16293777
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

This is complete for all the components, and we have now single pattern for all 
the components. We can discuss it further demo data and the data we left in 
last effort on how to proceed.
Thank you [~taher] [~jacques.le.roux] [~swapnilmmane] [~sourabh.jain] 
[~prakhar.kumar] [~saurabh.dixit] and all for your support and help on this.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-12 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287666#comment-16287666
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

As discussed I have moved all the possible data to data model for all 
components except CommonExt component. I'll move that data soon. After that all 
the discussed data which can be moved will be complete and code patterns for 
all component will follow the same practice.

After that this ticket won't block the release cut and we can plan the release 
cut on any date after 17th-Dec-2017. Thanks!


> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-02 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275560#comment-16275560
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Committed changes for product, accounting and manufacturing components.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-11-28 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268958#comment-16268958
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

[~taher] [~jacques.le.roux],
Thanks for your inputs, I'll do the changes accordingly, that means keep 
configuration data in the same component and commit the changes after 
incorporating suggestion.
Coming back to clean up the things is always open for us. But I would prefer to 
go as discussed to minimize the cleanup work. Soon I'll come back on this 
ticket and do the changes.

Thanks again!

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-11-25 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265927#comment-16265927
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Taher,
Thank you for your input, I also think on that data on the similar points. But 
while checking the dependencies I see the data is on seed reader and code will 
also have checks on those data to run the component. For the manufacturing help 
data is only uses the locale demonstration of manufacturing component only. For 
other components help data is only in US English, so I moved that data as well.

In my previous commits I moved the similar data for other components, so if we 
decide to keep such configuration data to the component specific location then 
I'll make changes in those files as well. I agree on the point that 
configuration data should be with component only. But code base uses that data 
in several conditions and seed reader direct me to move that data as well.

On the whole, we can rethink on this and keep the seed reader (for now) at 
component location. Then we can think on seed reader is appropriate for 
configuration data or not. Alternatively if we think seed reader is fine for 
configuration data then we can decide where to keep seed data. Like are we fine 
to have seed data of one component in data model as well as in some specific 
component (Party, Manufacturing etc.). Putting all this to maintain consistency 
and developers ease, because for me when I search for some data in files I 
usually expect that data to some location.

Please suggest how should we proceed, thanks again for your help on this. It 
really help to better understand the things you want to achieve from this 
ticket. Due to the same reason I first add the patch on the ticket and after 
feedback commit the changes.


> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9911) Add ability to record Return Communication

2017-11-25 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-9911:


Assignee: Rishi Solanki  (was: Ratnesh Upadhyay)

> Add ability to record Return Communication
> --
>
> Key: OFBIZ-9911
> URL: https://issues.apache.org/jira/browse/OFBIZ-9911
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, party
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
> Attachments: OFBIZ-9911.patch
>
>
> In OOTB we are having the ability to record order specific communication in 
> CommunicationEventOrder and the user can retrieve/review them from party > 
> communications screen but we don't have such support for return 
> communications. So It would be great to have an ability to record return 
> specific communication in the system.
> We have to implement following items to establish this feature :
> *Data Model Details:*
> - We will have to create new entity CommunicationEventReturn to record return 
> communication. It should have returnId and communicationEventId along with 
> other necessary fields.
> - We have to implement following view CommunicationEventAndReturn to fetch 
> return communications over screens as needed.
> *New Implementation Details:*
> - We have to add CRUD services for the new entity. 
> *Existing Implementation Details:*
> - We have to extend createCommunicationEvent service definition with retunId 
> field and extend the existing implementation to create the record in 
> CommunicationEventReturn based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId 
> in service context.
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication 
> By Order screen, in the same way, we can add another screen to find 
> communication by return.
> - We can add return communication screenlet over Order Manager > Return > 
> Return History screen or we can add communication tab under Order > Return 
> screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
> Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for 
> discussion and inputs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-11-25 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-9501:
-
Attachment: OFBIZ-9501_Consolidated-2.patch

Here is another consolidated patch for product, manufacturing and accounting 
component. Patch covers both seed and seed initial data.
Also I have skip only confusing data, on which we can discuss once we complete 
the effort. I would like to commit the changes once my tests pass.

Thanks!

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-10-29 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224364#comment-16224364
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Taher,
Thanks for your continuous support. I'll commit it by today once tests pass.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-10-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-9501:
-
Attachment: OFBIZ-9501_Consolidated.patch

Here is the consolidated patch covers seed and seed-initial data for party, 
security ext, content and work effort component. We have leave few data as is 
in the component and think over them later where can we move that data.

Thanks to [~sourabh.jain] [~saurabh.dixit] [~prakhar.kumar] for your patches.

I would like to commit the changes in this patch.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-10-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-9758.


> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rishi Solanki
> Fix For: Upcoming Release, Release Branch 16.11
>
> Attachments: OFBIZ-9758.patch, OFBIZ-9758.png
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-10-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-9758.
--
   Resolution: Fixed
Fix Version/s: Release Branch 16.11
   Upcoming Release

> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rishi Solanki
> Fix For: Upcoming Release, Release Branch 16.11
>
> Attachments: OFBIZ-9758.patch, OFBIZ-9758.png
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-10-28 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223317#comment-16223317
 ] 

Rishi Solanki commented on OFBIZ-9758:
--

[~rohit.rai]: Thanks for your contribution, fix has been committed in revision 
trunk-1813588 and 16.11-1813589. Please note the minor modification done in 
your patch before committing. 

> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rishi Solanki
> Attachments: OFBIZ-9758.patch, OFBIZ-9758.png
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-10-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-9758:


Assignee: Rishi Solanki  (was: Rohit Rai)

> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rishi Solanki
> Attachments: OFBIZ-9758.patch, OFBIZ-9758.png
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9892) Error while creating order with product "GZ-1006-1 - Open Gizmo (LGPL)"

2017-10-27 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223271#comment-16223271
 ] 

Rishi Solanki commented on OFBIZ-9892:
--

Thanks Padma!

> Error while creating order with product "GZ-1006-1 - Open Gizmo (LGPL)"
> ---
>
> Key: OFBIZ-9892
> URL: https://issues.apache.org/jira/browse/OFBIZ-9892
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Priority: Minor
> Attachments: errorinorder.png
>
>
> Steps:
> 1. Login to order manager application.
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/main
> 2. Set Demo customer.
> 3. Add item to cart (GZ-1006-1 - Open Gizmo (LGPL)).
> 4. Set COD payment method.
> 5. Place an order.
> Actual:
> Order is created successfully with exception error.
> Please refer attachment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9892) Error while creating order with product "GZ-1006-1 - Open Gizmo (LGPL)"

2017-10-26 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-9892:
-
Description: 
Steps:
1. Login to order manager application.
https://demo-trunk.ofbiz.apache.org/ordermgr/control/main
2. Set Demo customer.
3. Add item to cart (GZ-1006-1 - Open Gizmo (LGPL)).
4. Set COD payment method.
5. Place an order.

Actual:
Order is created successfully with exception error.
Please refer attachment.







  was:
Steps:
1. Login to order manager application.
 https://ofbiz-trunk.hotwaxsystems.com/ordermgr/control/main
2. Set Demo customer.
3. Add item to cart (GZ-1006-1 - Open Gizmo (LGPL)).
4. Set COD payment method.
5. Place an order.

Actual:
Order is created successfully with exception error.
Please refer attachment.








Edit the description and change the demo trunk link.

> Error while creating order with product "GZ-1006-1 - Open Gizmo (LGPL)"
> ---
>
> Key: OFBIZ-9892
> URL: https://issues.apache.org/jira/browse/OFBIZ-9892
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Priority: Minor
> Attachments: errorinorder.png
>
>
> Steps:
> 1. Login to order manager application.
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/main
> 2. Set Demo customer.
> 3. Add item to cart (GZ-1006-1 - Open Gizmo (LGPL)).
> 4. Set COD payment method.
> 5. Place an order.
> Actual:
> Order is created successfully with exception error.
> Please refer attachment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9892) Error while creating order with product "GZ-1006-1 - Open Gizmo (LGPL)"

2017-10-26 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220427#comment-16220427
 ] 

Rishi Solanki commented on OFBIZ-9892:
--

[~padma.rawat]: Thanks for your effort, I see it is working with demo trunk 
https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10007
Please log any jira once you confirm on demo trunk link I mentioned. Thanks!

Please check yourself and close the ticket.

> Error while creating order with product "GZ-1006-1 - Open Gizmo (LGPL)"
> ---
>
> Key: OFBIZ-9892
> URL: https://issues.apache.org/jira/browse/OFBIZ-9892
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Priority: Minor
> Attachments: errorinorder.png
>
>
> Steps:
> 1. Login to order manager application.
>  https://ofbiz-trunk.hotwaxsystems.com/ordermgr/control/main
> 2. Set Demo customer.
> 3. Add item to cart (GZ-1006-1 - Open Gizmo (LGPL)).
> 4. Set COD payment method.
> 5. Place an order.
> Actual:
> Order is created successfully with exception error.
> Please refer attachment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-10-26 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220384#comment-16220384
 ] 

Rishi Solanki commented on OFBIZ-9758:
--

[~rohit.rai]: Your patch fixes the issue, but the issue you have reported 
should not come, as form widget should read the UiLabel value from 
FormFieldTitle_partyId and it is available in the screen/form context.

Could you please check why it is not happening and fix that. In general for 
most direct entity fields if title is not defined then system directly pick the 
right value using FormFieldTitle_ pattern.

> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
> Attachments: OFBIZ-9758.patch, OFBIZ-9758.png
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9769) Instead of using title and labels, use single label for independent fields

2017-10-26 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-9769:
-
Issue Type: Improvement  (was: Bug)

> Instead of using title and labels, use single label for independent fields
> --
>
> Key: OFBIZ-9769
> URL: https://issues.apache.org/jira/browse/OFBIZ-9769
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Garima jain
>Assignee: Garima jain
>Priority: Minor
>
> If there are multiple input fields and all belong to same group/category(like 
> address1, address2, city and state input fields belong to Address category) 
> in a form then we can use a title for such type of categories. But, if there 
> is only a single field (like Email address has single input field) then we 
> should not use the title for it.
>  Here is the reference 
> https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer
> Like for Email address does not require Title and label both we can only use 
> title for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9769) Instead of using title and labels, use single label for independent fields

2017-10-26 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220340#comment-16220340
 ] 

Rishi Solanki commented on OFBIZ-9769:
--

Changing it to improvement as this is not an bug, to port on branches.

> Instead of using title and labels, use single label for independent fields
> --
>
> Key: OFBIZ-9769
> URL: https://issues.apache.org/jira/browse/OFBIZ-9769
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Reporter: Garima jain
>Assignee: Garima jain
>Priority: Minor
>
> If there are multiple input fields and all belong to same group/category(like 
> address1, address2, city and state input fields belong to Address category) 
> in a form then we can use a title for such type of categories. But, if there 
> is only a single field (like Email address has single input field) then we 
> should not use the title for it.
>  Here is the reference 
> https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer
> Like for Email address does not require Title and label both we can only use 
> title for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9767) Missing FK constraints in OrderItem entity for ShoppingListItem

2017-09-28 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184217#comment-16184217
 ] 

Rishi Solanki commented on OFBIZ-9767:
--

Thanks [~jacques.le.roux] just come back to close the ticket. :)

> Missing FK constraints in OrderItem entity for ShoppingListItem
> ---
>
> Key: OFBIZ-9767
> URL: https://issues.apache.org/jira/browse/OFBIZ-9767
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Rishi Solanki
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9767.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


<    1   2   3   4   5   6   >