[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user gtchaboussie (triggered by JacquesLeRoux). Head commit for run: 7dbdfd4eb7cd972d6e5030c80bfcaa9eb40458f2 / cgaetan OFBIZ-12989: Fixes raw type warnings Report URL: https://github.com/apache/ofbiz-framework/actions/runs/13015148221 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user florianMo (triggered by JacquesLeRoux). Head commit for run: 22a610acb040ce6a1d0d64d87141015a32907e22 / Florian Motteau Update renderAsterisks macro declarations OFBIZ-13183 Report URL: https://github.com/apache/ofbiz-framework/actions/runs/12349839244 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 610e2497588f74930a5a67f4f867e9511c00f3be / Jacques Le Roux Improved: Update build.gradle to the latest dependencies (OFBIZ-13194) Thanks to previous precious Danny Trunk's work at OFBIZ-13123, this time the effort was not too hard. There are 2 aspects: 1) In build.gradle: Uses <> for plugins following https://docs.gradle.org/7.0/release-notes.html#using-dynamic-versions-in-the-plugins-block Updates junitReport to 'org.apache.ant:ant-junit:1.10.15' checkstyle to toolVersion = '10.20.2' Adds a commented out "useLatestVersions" section. Commented out because I tried to use the recommended useLatestVersions and useLatestVersionsCheck ie gradlew -PenableDependencyUpdates useLatestVersions && gradlew -PenableDependencyUpdates useLatestVersionsCheck and got an issue: Execution failed for task ':useLatestVersionsCheck' Maybe because of: Failed to determine the latest version for the following dependencies - org.apereo.cas:cas-server-support-ldap-core - org.safehaus.jug:jug This said it was useful, could be more if we complete the "useLatestVersions" section 2) In Dependencies the "standard" updates with new comments when needed ie removing or commenting issues in code with the help of useLatestVersions feature Report URL: https://github.com/apache/ofbiz-framework/actions/runs/12327684367 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user MkLeila (triggered by MkLeila). Head commit for run: 45d9b98e7a42ef1332ff1f331edcc3d6618a303c / Leila Improved: Convert OrderServices.xml mini-lang to groovyDSL (OFBIZ-9984) Fix error in ensureRouteSegPackage Migration of the services: -recreateOrderAdjustments -getOrderItemShipGroupEstimatedShipDate -updateOrderNote -getOrderStatus -orderSequence_enforced -createOrderHeader -updateOrderHeader -updateOrderItemShipGroup -updateOrderContactMech -addPaymentMethodToOrder -checkOrderIsOnBackOrder -createOrderItemChange -createUpdateShippingAddress -createUpdateBillingAddress -createUpdateCreditCard -setUnitPriceAsLastPrice -cancelAllBackOrders -updateShippingMethodAndCharges -productAvailabalityByFacility -createOrderPaymentApplication -moveItemBetweenShipGroups Report URL: https://github.com/apache/ofbiz-framework/actions/runs/12319345957 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 7e868122c90be5e0035a73adc4552e1d62ce0379 / Jacques Le Roux Fixed: Getting error while generating ApprovedProductRequirementsReport PDF (OFBIZ-11845) Reference URI: ordermgr/control/ApprovedProductRequirementsReport Thanks: Chandan Khandelwal jleroux: I tested, reviewed and I think it's good. But as Chandan was not quite sure about possible regressions I prefer to not backport. We will have years to test before it's released... Report URL: https://github.com/apache/ofbiz-framework/actions/runs/12300691192 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: b39996e319f706eba48d289d8e8012d7b1136ced / Jacques Le Roux Improved: Update Apache Commons DBCP to 2.13.0 (OFBIZ-13188) https://lists.apache.org/thread/zfbsdg6jvc1j5njgk89lvxyzr2nqyxy9 It compiles now, tested with "cleanData loadAll" and UI loading Report URL: https://github.com/apache/ofbiz-framework/actions/runs/12135810418 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: e8529573a74eab1cb9ec37861e76147f1093b0fb / Jacques Le Roux Fixed: The links in webtools/control/TestSuiteInfo are not accepted (OFBIZ-13175) Removes duplicate inside code in product/testdef/ProductTest.xml This was put in with Jira Unit test case for service - createProductFeatureType (OFBIZ-9089) Report URL: https://github.com/apache/ofbiz-framework/actions/runs/12117223814 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: 0fce1dd56c76e3dde0d27085ddd90d692560a8e2 / Nicolas Malin Improved: Improve ViewHandler interface (OFBIZ-13179) (#858) We extend *AbstractViewHandler* with a new method to override *prepareViewContext*. For each view handler implementation this will allow to control context used for rendering, applying Scriptlet token detection for security purpose. A new class *SecuredFreemarker* has been created to manage freemarker specific controls, outside global *SecurityUtil* class. We also add a new parameter *secure-context* (set true by default) to view-map xml element to indicate that this view allow unsecure rendering, this implies the view-map to required authentication. Thanks to Gil Portenseigne for help Report URL: https://github.com/apache/ofbiz-framework/actions/runs/12072493650 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: 248dc73aacbe83c7921469763c46aca5dca2a399 / Nicolas Malin Fixed: Escape null pointer if session is empty when resolve the theme On specific case, if the session is empty (like request mocked) the theming failed with a NPE. So just escape it Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11958162577 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: b97957d3ab6bd801b92e4c501f0aa8448c09b26f / Nicolas Malin Fixed: Update end bracket detection en groovy scriplet (OFBIZ-13178) Fixed the long size line issue on introduced tests. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11910507822 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user florianMo (triggered by JacquesLeRoux). Head commit for run: 3675eff2502bfe411c3db1068a6ec7468c012eb5 / Florian Motteau Fixed: jsTree visual glitch on link hover OF-13174 Helveticus introduced a global CSS transition effect, which caused various problems across the app (all the elements that changed dimensions were animated). jsTree plugins is concerned, when hovering links in a tree. This PR removes the global transition effect, and put it on identified elements that need it (buttons and links). Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11819033597 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by JacquesLeRoux). Head commit for run: acfb2ca397cb243a2027a641eb9cd3dee7b834f0 / Jacques Le Roux Improved: Prevent URL parameters manipulation (OFBIZ-13147) Temporary deactivates SecurityUtilTest::webShellTokensTesting, WIP... Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11745456915 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: 0be4e7e0e5037b8612ef064c4f217741186077b0 / Nicolas Malin Fixed: Add uri shortener function (OFBIZ-13154) Codenarc checkstyle error Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11688020532 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 612ad736b5c93db923573388e8565d32db4f90f4 / Jacques Le Roux Improved: Prevent URL parameters manipulation (OFBIZ-13147) I found that java.util.Base64 is not easy to use. Hopefully putting base64 in deniedWebShellTokens should be enough Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11479166947 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: fffa395d17a930bfc6c10b6986876b48ebc63c6d / Jacques Le Roux Improved: Update to Apache Tika 3.0.0 (OFBIZ-13155) This reverts commit 7c3a622f08e37d6a68125844383820dac1592f23. When running testSendOrderConfirmation and testFopMacroLibrary there are a lot of issues with dependencies related to org.apache.xmlgraphics Tika, FOP and PDFBox To be checked before going further using PDFBox 33.0.3 and FOP 2.10 I'll put the the error stack for testSendOrderConfirmation in the Jira Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11444858466 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux). Head commit for run: 67fbf13e9b4e12401cd593ceae34c78e7e7fa721 / Danny Trunk Updated several (transitive) dependencies (OFBIZ-13123) (#819) * Fixed: Corrections based on Checkstyle errors * Improved: Upgrade to gradle 8.8 * Revert "Improved: Abandon the Gradle Owasp dependencycheck task (OFBIZ-13121)" NVD REST API isn't stable but that shouldn't be the reason to abandon this feature. This reverts commit 0a9ee32539a6abe1c3e5d2805fb03df1e8d98144. * Improved: Update org.owasp.dependencycheck to 10.0.2 * Improved: Set checkstyle.toolVersion * Improved: Add guava as dependency It's used in the OFBiz codebase so this should be added as a dependency * Improved: Update esapi to 2.5.4.0 * Improved: Update jackson-databind to 2.17.1 * Improved: Update derby to 10.16.1.1 * Fixed: Corrections based on Checkstyle errors * Improved: Update clojure to 1.11.3 * Improved: Update transitive dependency mime4j to 0.8.10 * Improved: Update fop to 2.9 * Improved: Update tika parsers to 2.9.2 * Improved: Update transitive dependency bcprov-jdk18on to 1.78 * Improved: Update Apache CXF Runtime JAX-RS Frontend to 3.6.3 * Improved: Update jdom to 2.0.6.1 * Improved: Update ez-vcard to 0.12.1 * Improved: Update poi to 5.3.0 * Improved: Update Apache MINA sshd to 2.13.1 * Improved: Update Groovy to 4.0.22 * Improved: Update transitive dependency testng to 7.7.0 * Improved: Update Asciidoctor Gradle Plugin to 4.0.2 * Improved: Update Apache CXF Runtime JAX-RS Frontend to 3.6.4 * Improved: Update Apache PDFBox to 2.0.32 - Co-authored-by: Jacques Le Roux Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11324913646 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux). Head commit for run: 73d5a3d28a0a2a561795f3651c6ac1f670f4a13f / Jacques Le Roux Update FlexibleStringExpanderTests.java Fixes https://github.com/apache/ofbiz-framework/actions/runs/11293546444/job/31411921173 Line too long Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11295864237 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: a64a3cd91f93138b7d827744113ff8be24749b4e / Nicolas Malin Update framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java Co-authored-by: Gil Portenseigne Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11275824285 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 7e3d4230dc7cc983afff2c57d0c428cf4671fad4 / Jacques Le Roux Improved: hides "Unknown request [authview]" in RequestHandler.java The complete line is: Unknown request [authview]; this request does not exist or cannot be called directly The error appears when authview/getUiLabels is called. No need to show that in log Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11203700646 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user MkLeila (triggered by MkLeila). Head commit for run: 91a95377f3cf075f9070bce04a13a81f1122254c / MLeila Improved: Convert OrderServices.xml mini-lang to groovyDSL (OFBIZ-9984) Fix codenarc warnings. checkCreateStockRequirementQoh, checkCreateStockRequirementAtp and checkCreateProductRequirementForFacility Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11182283770 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user dependabot[bot] (triggered by JacquesLeRoux). Head commit for run: 4152470af5f4495d5ad20216c5397db2d14b373c / dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump dompurify in /themes/common-theme/webapp/common-theme/js Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.1.6 to 3.1.7. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](https://github.com/cure53/DOMPurify/compare/3.1.6...3.1.7) --- updated-dependencies: - dependency-name: dompurify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Report URL: https://github.com/apache/ofbiz-framework/actions/runs/11053422554 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user dixitdeepak (triggered by dixitdeepak). Head commit for run: c78ad8cc04cb3ff10fec56ba8b0bea3a2292ef9f / Deepak Dixit Fixed checkstyle error Report URL: https://github.com/apache/ofbiz-framework/actions/runs/10621118885 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 6d9bd037a47035dfbc40040cfedb6277adb1a5eb / Jacques Le Roux Improved: Abandon the Gradle Owasp dependencycheck task (OFBIZ-13121) We have abandoned this feature for years as it was no longer usable (too much false positive in large numbers). https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check The last time I tried to use it was after the last commit for https://issues.apache.org/jira/browse/OFBIZ-10700 http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/build.gradle?r1=1854818&r2=1854817&pathrev=1854818 I just tried and got this: C:\projectsASF\Git\ofbiz-framework>gradlew -PenableOwasp dependencyCheckAnalyze Starting a Gradle Daemon (subsequent builds will be faster) [...] > Task :dependencyCheckAnalyze Verifying dependencies for project ofbiz Checking for updates and analyzing dependencies for vulnerabilities An NVD API Key was not provided - it is highly recommended to use an NVD API key as the update can take a VERY long time without an API Key Actually nothing happens in a reasonable time and I bet it would be mostly unusable. You though may try to follow the NVD API key way, whatever it is. I forgot to remove this information in the main README files (actually in all OFBiz versions supported). You see the README trunk version GH repo. Thanks: Sumesh Acharya for his question on user ML Report URL: https://github.com/apache/ofbiz-framework/actions/runs/9658958441 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user dependabot[bot] (triggered by dependabot[bot]). Head commit for run: 94ebb479278ebfb8beffd052ab7da70e05f900bb / dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump jquery-validation in /themes/common-theme/webapp/common-theme/js Bumps [jquery-validation](https://github.com/jquery-validation/jquery-validation) from 1.20.0 to 1.20.1. - [Release notes](https://github.com/jquery-validation/jquery-validation/releases) - [Changelog](https://github.com/jquery-validation/jquery-validation/blob/master/changelog.md) - [Commits](https://github.com/jquery-validation/jquery-validation/compare/1.20.0...1.20.1) --- updated-dependencies: - dependency-name: jquery-validation dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Report URL: https://github.com/apache/ofbiz-framework/actions/runs/9517349604 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user dependabot[bot] (triggered by dependabot[bot]). Head commit for run: 6c392a267abb0ada48a43f5575053b158fee86b9 / dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump uglify-js in /themes/common-theme/webapp/common-theme/js Bumps [uglify-js](https://github.com/mishoo/UglifyJS) from 3.17.4 to 3.18.0. - [Release notes](https://github.com/mishoo/UglifyJS/releases) - [Commits](https://github.com/mishoo/UglifyJS/compare/v3.17.4...v3.18.0) --- updated-dependencies: - dependency-name: uglify-js dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Report URL: https://github.com/apache/ofbiz-framework/actions/runs/9449306744 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 9443359e73a97bd2562265658332e1a097e805d9 / Jacques Le Roux Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) Fixes a bug put in with last commit. -String uri = requestMap.getUri(); +String uri = requestMap.uri; Also automatically (Eclipse) removes trailing blanks Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8927142918 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 9ec6a618bc4dfac5fc2b7031d6c7805a4900b775 / Jacques Le Roux Fixed: Could not find PortalPage with portalPageId [] (OFBIZ-13071) Fixes a bug put in during backporting. MODULE is not used in this class module is Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8910185684 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 650284168de5976a502fa5e7af8a4685ded50ce9 / Jacques Le Roux Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) The previous commits were not enough as I feared. This time we should not see useless "error" information while running services. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8909902732 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 03291be883cb72315f1e93384ee4013392bc09c5 / Jacques Le Roux Improved: Could not find PortalPage with portalPageId [] (OFBIZ-13071) No need to try to render a PortalPage when there is no PortalPage Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8906783011 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: ff316b6e224b9cb8e3873689f7e6f997af89398a / Jacques Le Roux Fixed: Reject wrong URLs (OFBIZ-13006) Fixes compile errors when backported from trunk Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8647713689 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 445f4ddaa1c3dc11ff4c592bf1a5642fcea2b9c1 / Gil Portenseigne Fixed: Assetmain Groovy tests (OFBIZ-13003) Fix updateFixedAssetMaint service implementation that require oldStatusId OUT parameter. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8647088158 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 365f50ca0ee1511533457394d46c7d99f0fef18c / Gil Portenseigne Fixed: Partymgr Groovy tests (OFBIZ-12998) Fix auto refactor by eclipse IDE, sorry for that. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8570915342 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user florianMo (triggered by mleila37). Head commit for run: 99ddcac6a376f8e18971c52f61f3b87e1bebb3f3 / Florian Motteau Fixed: Broken draggable/resizable modals in Helveticus CSS rules were preventing jQuery UI Dialogs to be draggable (!important in CSS overriding top/left inline styles). Removes "transition: .5s" on dialog elements : it causes slowdowns on drag/resize (a CSS animation is triggered each time the user moves/resizes the dialog) OFBIZ-12992 Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8556588436 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: 1268ed38596e3104bbb19d2567d758e71a42b39d / Nicolas Malin Fixed: codenarc issue introduce on commit 55d33436d87950c7623536b70d297ca770ff5bc9 Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8465912223 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 567405b5024bf50f576c9cd90a485eb69c61ee40 / Jacques Le Roux Fixed: Convert WorkEffortServices.xml mini-lang to groovyDSL (OFBIZ-12965) Fixes few Codenarc issues Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8447762603 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: fae131fabcbacd13d3e00658adbc15e1bdbb6c9c / Jacques Le Roux Improved: pullAllPluginsSource.sh deleted local .git directory (OFBIZ-12927) Removes useless and failing `set -e` as documented at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference Though I have no idea why it's failing :/ Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8322322952 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux). Head commit for run: cf0f874bdad735792280909b6c82ed46a97fc496 / Pierre Smits Improved: ORDER - Move from hard-code menu location to parameterized (OFBIZ-12944) (#729) Move the menu location in the various order screens from hard-coded to parameterized. modified: - AllocationPlanScreens.xml - CommonScreens.xml - CustRequestScreens.xml - OrderEntryCommonScreens.xml - OrderViewScreens.xml - QuoteScreens.xml - QuoteWorkEffortScreens.xml - RequirementScreens.xml Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8306731624 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 9494ef3fc58379f9df4f230021981e03cb71c8ac / Jacques Le Roux Fixed: pullAllPluginsSource.sh deleted local .git directory (OFBIZ-12927) Last commit did not work, syntax error :/ Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8306657069 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 6c3294deaceaf79bc1cbbd91268ad6c841063bcd / Jacques Le Roux Fixed: pullAllPluginsSource.sh deleted local .git directory (OFBIZ-12927) Removes "set -e" <> did not work for a PR in GH, see https://github.com/apache/ofbiz-framework/actions/runs/8306279611/job/22734750400 Summary: Run ./pullAllPluginsSource.sh ##[debug]/usr/bin/bash -e /home/runner/work/_temp/fabb0e97-ff01-44d9-909e-5990257e67ed.sh fatal: repository 'plugins' does not exist Error: Process completed with exit code 128. I keep similar in pullAllPluginsSource.bat Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8306596082 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user mleila37 (triggered by mleila37). Head commit for run: 85e28a9559daaa0d3ee2dc152b3f365ab53b0e05 / MLeila Fixed: Corrections based on Codenarc and Checkstyle errors (OFBIZ-12869) Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8293023964 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 3d755e7cd023015f2c53a902265058f8bdca3b64 / Jacques Le Roux Improved: Make sure no pdf files containing unwanted attachments can be uploaded (OFBIZ-12926) Fixes checkstyle issues Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8247019930 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: f62f17753327c9ae249260a363d1b823842a39c1 / Jacques Le Roux Fixed: SecuredUpload::checkMaxLinesLength put in a regression for PDF files (OFBIZ-12936) As commented at https://s.apache.org/wpkuj, while working on OFBIZ-12926 I realised that checkMaxLinesLength put in a possible regression for PDF files. As a summary: we can't use checkMaxLinesLength for PDF files because they may contain several CharSet encodings. Hence no possibility to use Files::readAllLines that needs a sole CharSet. So we need to bypass this check. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8246523207 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: bc03abc4a219aea12ae0d5f8ea7b277b550fd1c5 / Jacques Le Roux Improved: Implemented: Documented: Completed: Reverted: Fixed: (OFBIZ-) Explanation Thanks: Revert "Fixed: Test sources not recognised in IntelliJ (OFBIZ-12923) (#716)" This reverts commit c438302149830cd5f8153dab8e58e623915b21cf. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8108199375 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user originalnichtskoenner (triggered by JacquesLeRoux). Head commit for run: 182419e5726338007b680748962cc9ec4e3da3e8 / originalnichtskoenner <143175561+originalnichtskoen...@users.noreply.github.com> Improved: allow uploading ZUGFeRD compliant pdf files (OFBIZ-12920) Allow uploading non-empty pdf files. Use ZUGFeRD parser to validate those files. Can be configured in security.properties. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8080288709 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 75a8ba566d1eedbbaa868683a3224f417045ca1a / Jacques Le Roux Improved: Clean code according to SpotBugs in Eclipse (OFBIZ-12912) Fixes checkstyle in FlexibleServletAccessor::equals (Done and checked in console but forgot to update ToirtoiseGit UI list of changes) Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8037491343 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 940ada36260ba7f13e0dc62986b95ec381a978df / Jacques Le Roux Improved: Migrate integration tests to unit tests when possible (OFBIZ-11067) Fixes previous commit where @Test was place one line too low Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8004082448 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user danwatford (triggered by danwatford). Head commit for run: ec2907e82ed4c81203096800f689b69d0061f45d / Daniel Watford Fixed: Specify JDK distribution to build with (OFBIZ-12901) Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7942640030 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: afbe2437c8b622d85acda63d0d9e257579ae / Jacques Le Roux Improved: Improvement of the Check xml tag (OFBIZ-12821) Cleans MacroFormRendererTest.java for test check to pass + removes useless things Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7932370214 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux). Head commit for run: 96bf0094eea925e335301713f1c3293e15cd7dd8 / Pierre Smits Improved: Screen Classifications in Party should not show create trigger to user with only VIEW permission (OFBIZ-12892 (#695) When accessing https://demo-trunk.ofbiz.apache.org/partymgr/control/showclassgroups as a user with only VIEW permissions (e.g. userId = auditor) the action trigger to create a new Party Classification Group is shown. This should not be visible to such a user as it leads to an undesired effect and diminished user experience. modified: PartyClassificationScreens.xml - removed container having action trigger PartyMenus.xml - added menu-item newPartyClassificationGroup having permission condition Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7930924393 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user mleila37 (triggered by mleila37). Head commit for run: 8813c759866b2201bc87b8f20ad655f1bb036d00 / MLeila Fixed: Jgrowl label are not well retrieved (OFBIZ-12875) Fix a jGrowlLabelObject undefined error when calling showjGrowlMessage Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7928676925 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: e4514d2f54e558064ad4253e49db51b6f3502a9a / Jacques Le Roux Fixed: Missing package and syntax error in FixedAssetServices.groovy (OFBIZ-12890) Fixes Codenarc issues Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7785125884 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: c9009b3a4d028715fd602dbe533956541329cd61 / Jacques Le Roux Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Removes definitely SvnCheckout, pullPluginSource and pullAllPluginsSource tasks from Gradle (in build.gradle) Fixes both pullPluginSource scripts, notably uses a shallow clone rather than a blobless clone as suggested by Eugen, less space, faster Conflict handled by hand in build.gradle Conflicts handled by hand in build.gradle Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7407472373 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: d2f682c2d46a6c4b04153c986e72d7c4d9c43db8 / Jacques Le Roux Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Updates the documentation for pullAllPluginsSource.sh and pullPluginSource.sh Uses git switch -C "$branch" instead of git switch "$branch" in both scripts There is something weird with pullPluginSource.sh. It works perfectly on Windows using git-bash, but in Ubuntu 20.04 it does not add but replaces plugins. I tested using current last Git version in both OS (respectively 2.43.0.windows.1 and 2.43.0). It's a minor issue as it does not block the CI so I'll review that later... Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7397017902 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 99dcc9d1ebdbfbe9a7d7a87d1a1a06d2903547b8 / Jacques Le Roux Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Fixes issues while switching branches Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7387983683 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user dixitdeepak (triggered by dixitdeepak). Head commit for run: fb51a0ea5c4f7ff95b1586a5ca1c26e1ec50736f / Deepak Dixit Replaced direct null checks on username, password, and token with UtilValidate.isEmpty() method calls for consistency. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7208523060 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user ieugen (triggered by ieugen). Head commit for run: 1ca2a41bf85203fa284a432c23e91f43edea5f4a / Eugen Stan Improvement: Extract datafile component, base/util and base/crypt (OFBIZ-3500) * There are a LOT of circular dependencies !!! * I had to split some files to be able to shuffle code around: UtilPropertiesRuntime, etc. * A lot of code changes are related to CheckStyle * We should consider spotbugs for code formatting via gradle Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7146982231 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user ieugen (triggered by ieugen). Head commit for run: a0f4d10372bf9cb080111b02c07f1c02999f8f05 / Eugen Stan Improvement: Extract datafile component, base/util and base/crypt projects * There are a LOT of circular dependencies !!! * I had to split some files to be able to shuffle code around: UtilValidateEmpty, UtilPropertiesRuntime, etc. * A lot of code changes are related to CheckStyle * We should consider spotbugs for code formatting via gradle Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7115497915 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: f76c08b0ac64de35fcc458e2ef2a6660507502e0 / Jacques Le Roux Fixed: Upgrade Apache Shiro to 1.13.0 to fix CVE-2023-46750 (OFBIZ-12866) This makes loadAll Gradle task compatible and allows OFBiz to load Report URL: https://github.com/apache/ofbiz-framework/actions/runs/6875576541 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: a05f56f7bb245bb9d463b157a784780fdca27fc1 / Jacques Le Roux Fixed: [SECURITY] Several CVEs in Apache Tomcat (OFBIZ-12860) Concerns CVE-2023-42795, CVE-2023-44487 and CVE-2023-45648 See https://tomcat.apache.org/security-9.html#Fixed_in_Apache_Tomcat_9.0.81 for details Report URL: https://github.com/apache/ofbiz-framework/actions/runs/6481257610 With regards, GitHub Actions via GitBox
