[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.
[ https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870152#comment-16870152 ] Rohit Hukkeri commented on OFBIZ-10150: --- Hello, I have added patch with required type change for the data field "supplierProductId" to make it consist across entities. Regards, Rohit Hukkeri > supplierProductId Should Have Consistent Types Across Entities. > --- > > Key: OFBIZ-10150 > URL: https://issues.apache.org/jira/browse/OFBIZ-10150 > Project: OFBiz > Issue Type: Improvement > Components: order, product >Affects Versions: Trunk > Environment: all >Reporter: jesse thomas >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-10150.patch > > > During some data migration I hit an issue where my data for supplierProductId > was too long. So I looked up the fields and noticed that the order item > entity had a different type for the field than the supplier product entity. I > think it would be a good idea to pick one so the two fields can be treated > consistently. I would vote for id-long, but I think either way it would be > good to have them be the same type. There are other fields that have this > issue too if you are interested? > > Thanks! > applications/datamodel/entitydef/order-entitymodel.xml: > > applications/datamodel/entitydef/product-entitymodel.xml: > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.
[ https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870158#comment-16870158 ] Pierre Smits commented on OFBIZ-10150: -- Hi [~je...@thomasnetworks.net], The patch works. But as you indicated you're migrating from another solution to OFBiz. In that case you may experience this length issue with more id fields. If so, you may consider adjusting the length of the 'id' field type definition. > supplierProductId Should Have Consistent Types Across Entities. > --- > > Key: OFBIZ-10150 > URL: https://issues.apache.org/jira/browse/OFBIZ-10150 > Project: OFBiz > Issue Type: Improvement > Components: order, product >Affects Versions: Trunk > Environment: all >Reporter: jesse thomas >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-10150.patch > > > During some data migration I hit an issue where my data for supplierProductId > was too long. So I looked up the fields and noticed that the order item > entity had a different type for the field than the supplier product entity. I > think it would be a good idea to pick one so the two fields can be treated > consistently. I would vote for id-long, but I think either way it would be > good to have them be the same type. There are other fields that have this > issue too if you are interested? > > Thanks! > applications/datamodel/entitydef/order-entitymodel.xml: > > applications/datamodel/entitydef/product-entitymodel.xml: > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.
[ https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870165#comment-16870165 ] Suraj Khurana commented on OFBIZ-10150: --- Hello, +1 to make the field length consistent for all entities. Just for information, supplierProductId is not part of primary key in both the entities. I think we are good here with the available patch. It looks good to me. Any other thoughts are welcome !! > supplierProductId Should Have Consistent Types Across Entities. > --- > > Key: OFBIZ-10150 > URL: https://issues.apache.org/jira/browse/OFBIZ-10150 > Project: OFBiz > Issue Type: Improvement > Components: order, product >Affects Versions: Trunk > Environment: all >Reporter: jesse thomas >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-10150.patch > > > During some data migration I hit an issue where my data for supplierProductId > was too long. So I looked up the fields and noticed that the order item > entity had a different type for the field than the supplier product entity. I > think it would be a good idea to pick one so the two fields can be treated > consistently. I would vote for id-long, but I think either way it would be > good to have them be the same type. There are other fields that have this > issue too if you are interested? > > Thanks! > applications/datamodel/entitydef/order-entitymodel.xml: > > applications/datamodel/entitydef/product-entitymodel.xml: > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.
[ https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870336#comment-16870336 ] Jacques Le Roux commented on OFBIZ-10150: - I agree with Pierre ans Suraj, better do it for all possible combinations. Maybe not obvious, so baby steps are indicated, and committing the current patch would be the 1st step. > supplierProductId Should Have Consistent Types Across Entities. > --- > > Key: OFBIZ-10150 > URL: https://issues.apache.org/jira/browse/OFBIZ-10150 > Project: OFBiz > Issue Type: Improvement > Components: order, product >Affects Versions: Trunk > Environment: all >Reporter: jesse thomas >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-10150.patch > > > During some data migration I hit an issue where my data for supplierProductId > was too long. So I looked up the fields and noticed that the order item > entity had a different type for the field than the supplier product entity. I > think it would be a good idea to pick one so the two fields can be treated > consistently. I would vote for id-long, but I think either way it would be > good to have them be the same type. There are other fields that have this > issue too if you are interested? > > Thanks! > applications/datamodel/entitydef/order-entitymodel.xml: > > applications/datamodel/entitydef/product-entitymodel.xml: > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.
[ https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874815#comment-16874815 ] Jacques Le Roux commented on OFBIZ-10150: - Thanks Rohit, Your patch is in trunk r1862271 R18 r1862272 R17 r1862273 R196 r1862274 I don't close as it's an opportunity to fix all case. We could create sub-tasks but I believe patches and comments here are enough. No needs to dilute things. Thankd Jesse for report. > supplierProductId Should Have Consistent Types Across Entities. > --- > > Key: OFBIZ-10150 > URL: https://issues.apache.org/jira/browse/OFBIZ-10150 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk > Environment: all >Reporter: jesse thomas >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10150.patch > > > During some data migration I hit an issue where my data for supplierProductId > was too long. So I looked up the fields and noticed that the order item > entity had a different type for the field than the supplier product entity. I > think it would be a good idea to pick one so the two fields can be treated > consistently. I would vote for id-long, but I think either way it would be > good to have them be the same type. There are other fields that have this > issue too if you are interested? > > Thanks! > applications/datamodel/entitydef/order-entitymodel.xml: > > applications/datamodel/entitydef/product-entitymodel.xml: > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.
[ https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874816#comment-16874816 ] Suraj Khurana commented on OFBIZ-10150: --- Thanks Jacques !! > supplierProductId Should Have Consistent Types Across Entities. > --- > > Key: OFBIZ-10150 > URL: https://issues.apache.org/jira/browse/OFBIZ-10150 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk > Environment: all >Reporter: jesse thomas >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10150.patch > > > During some data migration I hit an issue where my data for supplierProductId > was too long. So I looked up the fields and noticed that the order item > entity had a different type for the field than the supplier product entity. I > think it would be a good idea to pick one so the two fields can be treated > consistently. I would vote for id-long, but I think either way it would be > good to have them be the same type. There are other fields that have this > issue too if you are interested? > > Thanks! > applications/datamodel/entitydef/order-entitymodel.xml: > > applications/datamodel/entitydef/product-entitymodel.xml: > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.
[ https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283241#comment-17283241 ] Michael Brohl commented on OFBIZ-10150: --- [~jleroux] Do you still want this to be open as a bug? Should we not better close this specifix bug issue and create another one as an improvement? > supplierProductId Should Have Consistent Types Across Entities. > --- > > Key: OFBIZ-10150 > URL: https://issues.apache.org/jira/browse/OFBIZ-10150 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk > Environment: all >Reporter: jesse thomas >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10150.patch > > > During some data migration I hit an issue where my data for supplierProductId > was too long. So I looked up the fields and noticed that the order item > entity had a different type for the field than the supplier product entity. I > think it would be a good idea to pick one so the two fields can be treated > consistently. I would vote for id-long, but I think either way it would be > good to have them be the same type. There are other fields that have this > issue too if you are interested? > > Thanks! > applications/datamodel/entitydef/order-entitymodel.xml: > > applications/datamodel/entitydef/product-entitymodel.xml: > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.
[ https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283284#comment-17283284 ] Jacques Le Roux commented on OFBIZ-10150: - I agree Michael, I let you create one... > supplierProductId Should Have Consistent Types Across Entities. > --- > > Key: OFBIZ-10150 > URL: https://issues.apache.org/jira/browse/OFBIZ-10150 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk > Environment: all >Reporter: jesse thomas >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10150.patch > > > During some data migration I hit an issue where my data for supplierProductId > was too long. So I looked up the fields and noticed that the order item > entity had a different type for the field than the supplier product entity. I > think it would be a good idea to pick one so the two fields can be treated > consistently. I would vote for id-long, but I think either way it would be > good to have them be the same type. There are other fields that have this > issue too if you are interested? > > Thanks! > applications/datamodel/entitydef/order-entitymodel.xml: > > applications/datamodel/entitydef/product-entitymodel.xml: > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.
[ https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301657#comment-17301657 ] Jacques Le Roux commented on OFBIZ-10150: - Hi Jesse, You proposed: bq. There are other fields that have this issue too if you are interested? Yes I'm, and as suggested Michael I'll open a new Jira for that, would you help? > supplierProductId Should Have Consistent Types Across Entities. > --- > > Key: OFBIZ-10150 > URL: https://issues.apache.org/jira/browse/OFBIZ-10150 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk > Environment: all >Reporter: jesse thomas >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10150.patch > > > During some data migration I hit an issue where my data for supplierProductId > was too long. So I looked up the fields and noticed that the order item > entity had a different type for the field than the supplier product entity. I > think it would be a good idea to pick one so the two fields can be treated > consistently. I would vote for id-long, but I think either way it would be > good to have them be the same type. There are other fields that have this > issue too if you are interested? > > Thanks! > applications/datamodel/entitydef/order-entitymodel.xml: > > applications/datamodel/entitydef/product-entitymodel.xml: > -- This message was sent by Atlassian Jira (v8.3.4#803005)
