[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[ https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438195#comment-15438195 ] ASF GitHub Bot commented on RYA-163: Github user asfgit closed the pull request at: https://github.com/apache/incubator-rya/pull/80 > PCJDetails Test Failures on non-EST TimeZones > - > > Key: RYA-163 > URL: https://issues.apache.org/jira/browse/RYA-163 > Project: Rya > Issue Type: Bug > Environment: Apache Jenkins machine (UTC Timezone) >Reporter: Aaron Mihalik >Assignee: David W. Lotts >Priority: Blocker > > There are two tests failing on the build. I think they are both due to a > timezone issue. > I was able to reproduce these failures by setting my local timezone to > something other than eastern. > https://builds.apache.org/job/incubator-rya-develop/27/testReport/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[
https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436002#comment-15436002
]
ASF GitHub Bot commented on RYA-163:
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/80#discussion_r76162982
--- Diff:
extras/rya.console/src/test/java/mvm/rya/shell/RyaAdminCommandsTest.java ---
@@ -123,6 +124,9 @@ public void deletePCJ() throws
InstanceDoesNotExistException, RyaClientException
@Test
public void getInstanceDetails() throws InstanceDoesNotExistException,
RyaClientException {
+// This test is failed if the default timezone was not EST, so now
it's fixed at EST.
+// If you get assert mismatch of EST!=EDT, try the deprecated
getTimeZone("EST") instead.
+TimeZone.setDefault(TimeZone.getTimeZone("America/New_York"));
--- End diff --
Yes completely agree. Java 8 or JodaTime. They are mostly the same. I
would only use java.util.Date if I had to.
> PCJDetails Test Failures on non-EST TimeZones
> -
>
> Key: RYA-163
> URL: https://issues.apache.org/jira/browse/RYA-163
> Project: Rya
> Issue Type: Bug
> Environment: Apache Jenkins machine (UTC Timezone)
>Reporter: Aaron Mihalik
>Assignee: David W. Lotts
>Priority: Blocker
>
> There are two tests failing on the build. I think they are both due to a
> timezone issue.
> I was able to reproduce these failures by setting my local timezone to
> something other than eastern.
> https://builds.apache.org/job/incubator-rya-develop/27/testReport/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[
https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435993#comment-15435993
]
ASF GitHub Bot commented on RYA-163:
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/80#discussion_r76162747
--- Diff:
extras/rya.console/src/test/java/mvm/rya/shell/RyaAdminCommandsTest.java ---
@@ -123,6 +124,9 @@ public void deletePCJ() throws
InstanceDoesNotExistException, RyaClientException
@Test
public void getInstanceDetails() throws InstanceDoesNotExistException,
RyaClientException {
+// This test is failed if the default timezone was not EST, so now
it's fixed at EST.
+// If you get assert mismatch of EST!=EDT, try the deprecated
getTimeZone("EST") instead.
+TimeZone.setDefault(TimeZone.getTimeZone("America/New_York"));
--- End diff --
I think there is a bigger issue... the setDetails() methods should be using
java 8 Time libraries. I haven't used those yet, but I'm guessing we want to
be using java.time.Instant instead java.util.Date
> PCJDetails Test Failures on non-EST TimeZones
> -
>
> Key: RYA-163
> URL: https://issues.apache.org/jira/browse/RYA-163
> Project: Rya
> Issue Type: Bug
> Environment: Apache Jenkins machine (UTC Timezone)
>Reporter: Aaron Mihalik
>Assignee: David W. Lotts
>Priority: Blocker
>
> There are two tests failing on the build. I think they are both due to a
> timezone issue.
> I was able to reproduce these failures by setting my local timezone to
> something other than eastern.
> https://builds.apache.org/job/incubator-rya-develop/27/testReport/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[
https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435964#comment-15435964
]
ASF GitHub Bot commented on RYA-163:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/80#discussion_r76160592
--- Diff:
extras/rya.console/src/test/java/mvm/rya/shell/RyaAdminCommandsTest.java ---
@@ -123,6 +124,9 @@ public void deletePCJ() throws
InstanceDoesNotExistException, RyaClientException
@Test
public void getInstanceDetails() throws InstanceDoesNotExistException,
RyaClientException {
+// This test is failed if the default timezone was not EST, so now
it's fixed at EST.
+// If you get assert mismatch of EST!=EDT, try the deprecated
getTimeZone("EST") instead.
+TimeZone.setDefault(TimeZone.getTimeZone("America/New_York"));
--- End diff --
Alternatively, couldn't commands.getInstanceDetails(); accept the time zone
as a parameter?
> PCJDetails Test Failures on non-EST TimeZones
> -
>
> Key: RYA-163
> URL: https://issues.apache.org/jira/browse/RYA-163
> Project: Rya
> Issue Type: Bug
> Environment: Apache Jenkins machine (UTC Timezone)
>Reporter: Aaron Mihalik
>Assignee: David W. Lotts
>Priority: Blocker
>
> There are two tests failing on the build. I think they are both due to a
> timezone issue.
> I was able to reproduce these failures by setting my local timezone to
> something other than eastern.
> https://builds.apache.org/job/incubator-rya-develop/27/testReport/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[
https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435962#comment-15435962
]
ASF GitHub Bot commented on RYA-163:
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/80#discussion_r76160440
--- Diff:
extras/rya.console/src/test/java/mvm/rya/shell/RyaAdminCommandsTest.java ---
@@ -123,6 +124,9 @@ public void deletePCJ() throws
InstanceDoesNotExistException, RyaClientException
@Test
public void getInstanceDetails() throws InstanceDoesNotExistException,
RyaClientException {
+// This test is failed if the default timezone was not EST, so now
it's fixed at EST.
+// If you get assert mismatch of EST!=EDT, try the deprecated
getTimeZone("EST") instead.
+TimeZone.setDefault(TimeZone.getTimeZone("America/New_York"));
--- End diff --
These are two different classes. Before will still have an order
dependence.
Also every test after will still be affected.
Another solution is to replace it to the original value when the test is
over.
With that, only concurrent unit tests will have order dependence, in that
case, a race condition. Then we need to synchronize on the timezone setting.
But what is wrong with setting it everywhere there is a dependence on
TimeZone? All the issues with that all have to do with setting the timezone
default globally, but not order, nor concurrency -- unless someone sets it to a
non EST timezone, then the concurrency issue comes back, but not the serial
order.
So I think it is best as it is now -- not perfect, but simple. What do you
think?
> PCJDetails Test Failures on non-EST TimeZones
> -
>
> Key: RYA-163
> URL: https://issues.apache.org/jira/browse/RYA-163
> Project: Rya
> Issue Type: Bug
> Environment: Apache Jenkins machine (UTC Timezone)
>Reporter: Aaron Mihalik
>Assignee: David W. Lotts
>Priority: Blocker
>
> There are two tests failing on the build. I think they are both due to a
> timezone issue.
> I was able to reproduce these failures by setting my local timezone to
> something other than eastern.
> https://builds.apache.org/job/incubator-rya-develop/27/testReport/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[
https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435913#comment-15435913
]
ASF GitHub Bot commented on RYA-163:
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/80#discussion_r76156372
--- Diff:
extras/rya.console/src/test/java/mvm/rya/shell/RyaAdminCommandsTest.java ---
@@ -123,6 +124,9 @@ public void deletePCJ() throws
InstanceDoesNotExistException, RyaClientException
@Test
public void getInstanceDetails() throws InstanceDoesNotExistException,
RyaClientException {
+// This test is failed if the default timezone was not EST, so now
it's fixed at EST.
+// If you get assert mismatch of EST!=EDT, try the deprecated
getTimeZone("EST") instead.
+TimeZone.setDefault(TimeZone.getTimeZone("America/New_York"));
--- End diff --
You made a good point in in the JIRA ticket... I think everything worked
for me because the order of the test execution. Can you move this to a static
class initializer or a BeforeClass method (so that the order of the test within
this file doesn't break things)?
> PCJDetails Test Failures on non-EST TimeZones
> -
>
> Key: RYA-163
> URL: https://issues.apache.org/jira/browse/RYA-163
> Project: Rya
> Issue Type: Bug
> Environment: Apache Jenkins machine (UTC Timezone)
>Reporter: Aaron Mihalik
>Assignee: David W. Lotts
>Priority: Blocker
>
> There are two tests failing on the build. I think they are both due to a
> timezone issue.
> I was able to reproduce these failures by setting my local timezone to
> something other than eastern.
> https://builds.apache.org/job/incubator-rya-develop/27/testReport/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[ https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435911#comment-15435911 ] ASF GitHub Bot commented on RYA-163: Github user DLotts commented on the issue: https://github.com/apache/incubator-rya/pull/80 Done again. Second failed test is fixed using the same method. > PCJDetails Test Failures on non-EST TimeZones > - > > Key: RYA-163 > URL: https://issues.apache.org/jira/browse/RYA-163 > Project: Rya > Issue Type: Bug > Environment: Apache Jenkins machine (UTC Timezone) >Reporter: Aaron Mihalik >Assignee: David W. Lotts >Priority: Blocker > > There are two tests failing on the build. I think they are both due to a > timezone issue. > I was able to reproduce these failures by setting my local timezone to > something other than eastern. > https://builds.apache.org/job/incubator-rya-develop/27/testReport/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[ https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435886#comment-15435886 ] David W. Lotts commented on RYA-163: That ( #80 pull request ) fixes the one failed test. Just noticed this mentions two failed tests! Okay, gimme a second... > PCJDetails Test Failures on non-EST TimeZones > - > > Key: RYA-163 > URL: https://issues.apache.org/jira/browse/RYA-163 > Project: Rya > Issue Type: Bug > Environment: Apache Jenkins machine (UTC Timezone) >Reporter: Aaron Mihalik >Assignee: David W. Lotts >Priority: Blocker > > There are two tests failing on the build. I think they are both due to a > timezone issue. > I was able to reproduce these failures by setting my local timezone to > something other than eastern. > https://builds.apache.org/job/incubator-rya-develop/27/testReport/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[ https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435865#comment-15435865 ] ASF GitHub Bot commented on RYA-163: Github user amihalik commented on the issue: https://github.com/apache/incubator-rya/pull/80 Nice... super simple. I tested it out and it passed on my machine. > PCJDetails Test Failures on non-EST TimeZones > - > > Key: RYA-163 > URL: https://issues.apache.org/jira/browse/RYA-163 > Project: Rya > Issue Type: Bug > Environment: Apache Jenkins machine (UTC Timezone) >Reporter: Aaron Mihalik >Assignee: David W. Lotts >Priority: Blocker > > There are two tests failing on the build. I think they are both due to a > timezone issue. > I was able to reproduce these failures by setting my local timezone to > something other than eastern. > https://builds.apache.org/job/incubator-rya-develop/27/testReport/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[ https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435836#comment-15435836 ] ASF GitHub Bot commented on RYA-163: Github user DLotts commented on the issue: https://github.com/apache/incubator-rya/pull/80 This is complete and ready for review and pull. > PCJDetails Test Failures on non-EST TimeZones > - > > Key: RYA-163 > URL: https://issues.apache.org/jira/browse/RYA-163 > Project: Rya > Issue Type: Bug > Environment: Apache Jenkins machine (UTC Timezone) >Reporter: Aaron Mihalik >Assignee: David W. Lotts >Priority: Blocker > > There are two tests failing on the build. I think they are both due to a > timezone issue. > I was able to reproduce these failures by setting my local timezone to > something other than eastern. > https://builds.apache.org/job/incubator-rya-develop/27/testReport/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[ https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435468#comment-15435468 ] ASF GitHub Bot commented on RYA-163: GitHub user DLotts opened a pull request: https://github.com/apache/incubator-rya/pull/80 [WIP] RYA-163 PCJDetails Test Failures on non-EST TimeZones This bug was found by jenkins. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DLotts/incubator-rya RYA-163_PCJDetails-non-EST Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit d6635321e4dcd6a29c15e850a065c74f2d946bf9 Author: pujav65 Date: 2015-12-18T15:52:18Z RYA-24 issue with hashes and regex queries commit 8df9ac7680dc26265cc41aa2d3193398660f196a Author: pujav65 Date: 2015-12-21T14:10:10Z RYA-23 exposing triple pattern strategy from rya context commit faae178c004c2e96b216192b8ee76892b671d44b Author: pujav65 Date: 2015-12-21T15:12:30Z RYA-21 adding input format and sample mappers/reducers commit 2b30478cdbd0207bfd48d2e2c10c26438fb9b353 Author: Aaron Mihalik Date: 2015-12-23T16:23:31Z RYA-25 Adding Apache-RAT Eclipse Exclusion commit e530aec63ea99f601ccaa6431029023a5325c94a Author: pujav65 Date: 2016-01-04T17:50:43Z Merge branch 'RYA-24' of https://github.com/pujav65/incubator-rya into RYA-24 commit a7d266ea343742921bc5b30ecc276f6297aaf32a Author: pujav65 Date: 2016-01-04T18:19:30Z Merge branch 'RYA-23' of https://github.com/pujav65/incubator-rya into RYA-23 commit 4ca2b241f6dd3394e99f7f49476d6216b400994a Author: pujav65 Date: 2016-01-04T19:37:47Z Merge branch 'RYA-21' of https://github.com/pujav65/incubator-rya into RYA-21 commit db96c4584815fec6b67f31db2753d12c1bb23f64 Author: pujav65 Date: 2016-01-04T21:31:24Z RYA-28 adding additional life cycle dependencies for secondary indices commit 4b7bd4f4ecc7a2d2e074ef6394452145138ebbca Author: pujav65 Date: 2016-01-06T19:01:40Z RYA-28 fixing build after incomplete check in commit 22f82c7abdb53cd16a6c6f77cf605cc8fae5de7e Author: Aaron Mihalik Date: 2015-11-22T22:50:19Z RYA-4 Adding Vagrant Example and Documentation commit c12f58f46be0aed3c88eff7504d4bfd4e4f295e9 Author: Caleb Meier Date: 2016-01-29T16:40:59Z RYA-32 Improve how metadata and values are written to Accumulo PCJ tables commit 6cd8aeb71ee28252023965d2acbffc19eb32296b Author: Aaron Mihalik Date: 2016-02-07T18:24:38Z RYA-32 Adding License Headers commit 19e2e438c9e6aef2585d72a5696b336b7bd7ab8b Author: Aaron Mihalik Date: 2016-02-07T19:15:27Z RYA-4 Adding Vagrant Example and Documentation commit 3157bc466a4faf87814ad9c81166c6f2139fc49c Author: Kevin Chilton Date: 2016-02-14T20:20:15Z RYA-35 - Added a class that converts BindingSet objects into Strings and back again. commit 6b2944693ac5bc4ef0ea9e067715c63c9b78bf88 Author: Mike Pfaffenberger Date: 2016-02-18T14:47:09Z RYA-37 Bump GeoMesa version to 1.2.0 commit 8db5bbc3aa0256426c1c9ec925a31bf9e177ff3b Author: Kevin Chilton Date: 2016-02-19T22:22:15Z RYA-41 Fixed a bug where AccumuloIndexSet assumes the first node of a ParsedQuery is always a Projection node. commit 1a3839607d61be7ddd0124f6e50f7c0ae35367c8 Author: Aaron Mihalik Date: 2016-02-22T19:39:14Z Merge branch 'geomesa_version_bump' of https://github.com/mpfaffenberger/incubator-rya into develop commit 39c39429019937284d2e100ce0cffd214ea726e3 Author: AmilaWijayarathna Date: 2016-03-02T14:44:47Z RYA-44 testMilliSecondsNoZone test case fails when running from +0530 time zone commit 188791306474f5d45f9bb42f3f424bc6709c5eb0 Author: Aaron Mihalik Date: 2016-03-02T23:37:28Z RYA-7 Applying Correct License commit d5202aa52309ab914fb561d73015b22234c0d53f Author: Aaron Mihalik Date: 2016-03-04T02:40:07Z RYA-45 Pushing apache-rat constraints to submodules commit c4d44ebae60c1ac3db5ea91d3f05ed9a588cf9b2 Author: pujav65 Date: 2016-01-13T16:21:52Z RYA-11 initial implementation of free text for mongo backend commit efcae829c97e78b122b0d27586dd2a74e5c3 Author: pujav65 Date: 2016-02-29T20:15:52Z RYA-34 fixing inference with mongo db commit 358c13b83dc04887f95afee1c326971602d31647 Author: pujav65 Date: 2016-03-14T14:55:31Z RYA-11 fixing compile errors commit commit a150595e2184caa57e93e6e1c18c4cac6477e8cb Author: jej2003 Date: 2016-03-17T18:04:01Z update so that regular expressions are applied in cases where the strategy is defaulted to SPO commit 4a73be7ab8afe24faf9b871f5e11c9c3ca5f034a Author: craighahnparsons Date: 2016-03-17T18:31:36Z Added data type in tuple creation commit b
[jira] [Commented] (RYA-163) PCJDetails Test Failures on non-EST TimeZones
[ https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435439#comment-15435439 ] David W. Lotts commented on RYA-163: Expected string is hardcoded as EST. > PCJDetails Test Failures on non-EST TimeZones > - > > Key: RYA-163 > URL: https://issues.apache.org/jira/browse/RYA-163 > Project: Rya > Issue Type: Bug > Environment: Apache Jenkins machine (UTC Timezone) >Reporter: Aaron Mihalik >Assignee: David W. Lotts >Priority: Blocker > > There are two tests failing on the build. I think they are both due to a > timezone issue. > I was able to reproduce these failures by setting my local timezone to > something other than eastern. > https://builds.apache.org/job/incubator-rya-develop/27/testReport/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
