[GitHub] [skywalking] wu-sheng commented on a change in pull request #4292: Improve ES query performance
wu-sheng commented on a change in pull request #4292: Improve ES query
performance
URL: https://github.com/apache/skywalking/pull/4292#discussion_r372794606
##
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/AggregationQueryEsDAO.java
##
@@ -96,7 +96,7 @@ public AggregationQueryEsDAO(ElasticSearchClient client) {
SearchSourceBuilder sourceBuilder = SearchSourceBuilder.searchSource();
BoolQueryBuilder boolQueryBuilder = QueryBuilders.boolQuery();
-sourceBuilder.query(boolQueryBuilder);
+
sourceBuilder.query(QueryBuilders.boolQuery().filter(boolQueryBuilder));
boolQueryBuilder.must().add(QueryBuilders.rangeQuery(Metrics.TIME_BUCKET).lte(endTB).gte(startTB));
boolQueryBuilder.must().add(QueryBuilders.termQuery(EndpointInventory.SERVICE_ID,
serviceId));
Review comment:
Thanks for providing this. Still, the document about `as well as cache
filters for faster subsequent performance` is not very clear. My guess, at our
implementation, you moved all the conditions into the filter, then this part of
optimization should be none(no subsequent), except for aggregation top N query.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4292: Improve ES query performance
wu-sheng commented on a change in pull request #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#discussion_r372794082 ## File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/EsDAO.java ## @@ -53,7 +53,7 @@ protected final void queryBuild(SearchSourceBuilder sourceBuilder, Where where, boolQuery.must().add(QueryBuilders.termQuery(keyValues.getKey(), keyValues.getValues().get(0))); } }); -sourceBuilder.query(boolQuery); + sourceBuilder.query(QueryBuilders.boolQuery().filter(QueryBuilders.boolQuery().filter(boolQuery))); Review comment: Filter twice too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4292: Improve ES query performance
wu-sheng commented on a change in pull request #4292: Improve ES query
performance
URL: https://github.com/apache/skywalking/pull/4292#discussion_r372793949
##
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/EsDAO.java
##
@@ -41,7 +41,7 @@ public EsDAO(ElasticSearchClient client) {
protected final void queryBuild(SearchSourceBuilder sourceBuilder, Where
where, long startTB, long endTB) {
RangeQueryBuilder rangeQueryBuilder =
QueryBuilders.rangeQuery(Metrics.TIME_BUCKET).gte(startTB).lte(endTB);
if (where.getKeyValues().isEmpty()) {
-sourceBuilder.query(rangeQueryBuilder);
+
sourceBuilder.query(QueryBuilders.boolQuery().filter(QueryBuilders.boolQuery().filter(rangeQueryBuilder)));
Review comment:
Why filter twice?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4299: How to use the plugin ---- Spring annotation plugin?
wu-sheng closed issue #4299: How to use the plugin Spring annotation plugin? URL: https://github.com/apache/skywalking/issues/4299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] 17173YeYu commented on issue #4299: How to use the plugin ---- Spring annotation plugin?
17173YeYu commented on issue #4299: How to use the plugin Spring annotation plugin? URL: https://github.com/apache/skywalking/issues/4299#issuecomment-580118356 How to use the plugin Spring annotation plugin? Is there any doc about how to use it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] 17173YeYu opened a new issue #4299: How to use the plugin ---- Spring annotation plugin?
17173YeYu opened a new issue #4299: How to use the plugin Spring annotation plugin? URL: https://github.com/apache/skywalking/issues/4299 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? How to use the plugin Spring annotation plugin? Is there any doc about how to use it? ___ ### Bug - Which version of SkyWalking, OS and JRE? - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking-website] branch asf-site updated (9dc7507 -> 5cf2065)
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git.
discard 9dc7507 Update asf-site
new 5cf2065 Update asf-site
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (9dc7507)
\
N -- N -- N refs/heads/asf-site (5cf2065)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
404.html| 4 ++--
assets/js/20.5c39c1ab.js| 1 +
assets/js/20.6de52e92.js| 1 -
assets/js/33.842bb553.js| 1 +
assets/js/33.da01bcb6.js| 1 -
assets/js/{app.b2d56437.js => app.3d1a72aa.js} | 4 ++--
blog/2018-05-24-skywalking-net.html | 4 ++--
blog/2018-12-12-skywalking-service-mesh-ready.html | 4 ++--
blog/2019-01-01-Understand-Trace.html | 4 ++--
blog/2019-01-25-mesh-loadtest.html | 4 ++--
blog/2019-09-25-alarm-webhook-share.html| 4 ++--
blog/2020-01-20-celebrate-200th-contributor.html| 4 ++--
blog/index.html | 4 ++--
downloads/index.html| 6 +++---
events/index.html | 4 ++--
index.html | 4 ++--
team/index.html | 4 ++--
zh/blog/2018-05-24-skywalking-net.html | 4 ++--
zh/blog/2018-12-18-Apache-SkyWalking-5-0-UserGuide.html | 4 ++--
zh/blog/2018-12-21-SkyWalking-apm-sniffer-beginning.html| 4 ++--
zh/blog/2018-12-21-SkyWalking-source-code-read.html | 4 ++--
zh/blog/2019-01-02-Understand-trace-trans2cn.html | 4 ++--
zh/blog/2019-01-02-skywalking-elasticsearch-basic.html | 4 ++--
zh/blog/2019-01-03-monitor-microservice.html| 4 ++--
zh/blog/2019-01-21-agent-plugin-practice.html | 4 ++--
zh/blog/2019-01-24-skywalking-remote-debug.html | 4 ++--
zh/blog/2019-02-24-skywalking-pk-pinpoint.html | 4 ++--
zh/blog/2019-03-01-skywalking-troubleshoot.html | 4 ++--
.../2019-03-29-introduction-of-skywalking-and-simple-practice.html | 4 ++--
zh/blog/2019-08-30-how-to-use-Skywalking-Agent.html | 4 ++--
zh/blog/2019-09-12-apache-skyWalking-committer-apply-process.html | 4 ++--
zh/blog/2019-10-08-how-to-use-sw-chart.html | 4 ++--
.../2019-11-07-skywalking-elasticsearch-storage-optimization.html | 4 ++--
zh/blog/index.html | 4 ++--
zh/doc/index.html | 4 ++--
zh/downloads/index.html | 6 +++---
zh/events/index.html| 4 ++--
zh/index.html | 4 ++--
zh/team/index.html | 4 ++--
39 files changed, 74 insertions(+), 74 deletions(-)
create mode 100644 assets/js/20.5c39c1ab.js
delete mode 100644 assets/js/20.6de52e92.js
create mode 100644 assets/js/33.842bb553.js
delete mode 100644 assets/js/33.da01bcb6.js
rename assets/js/{app.b2d56437.js => app.3d1a72aa.js} (79%)
[skywalking-website] branch master updated: Make changelog clear and remove the 6.4.0 from recommended download page.
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new d8a23aa Make changelog clear and remove the 6.4.0 from recommended download page. d8a23aa is described below commit d8a23aa5fef98fe5134d8cfc2b85789497fb5f33 Author: Wu Sheng AuthorDate: Thu Jan 30 15:11:28 2020 +0800 Make changelog clear and remove the 6.4.0 from recommended download page. --- docs/downloads/README.md| 10 ++ docs/zh/downloads/README.md | 14 -- 2 files changed, 6 insertions(+), 18 deletions(-) diff --git a/docs/downloads/README.md b/docs/downloads/README.md index 4b52d30..68fcd05 100755 --- a/docs/downloads/README.md +++ b/docs/downloads/README.md @@ -19,10 +19,6 @@ Use the links below to download the Apache SkyWalking from one of our mirrors. | | | Binary Distribution (Windows)| [[zip]](https://www.apache.org/dyn/closer.cgi/skywalking/6.5.0/apache-skywalking-apm-6.5.0.zip) [[asc]](https://www.apache.org/dist/skywalking/6.5.0/apache-skywalking-apm-6.5.0.zip.asc) [[sha512]](https://www.apache.org/dist/skywalking/6.5.0/apache-skywalking-apm-6.5.0.zip.sha512)| | | | Binary Distribution (Linux) | [[tar]](https://www.apache.org/dyn/closer.cgi/skywalking/6.5.0/apache-skywalking-apm-6.5.0.tar.gz) [[asc]](https://www.apache.org/dist/skywalking/6.5.0/apache-skywalking-apm-6.5.0.tar.gz.asc) [[sha512]](https://www.apache.org/dist/skywalking/6.5.0/apache-skywalking-apm-6.5.0.tar.gz.sha512)| | | | Documentation| [Documentation](https://github.com/apache/skywalking/blob/v6.5.0/docs/README.md) | -| Sep. 11th, 2019 | 6.4.0 | Source code| [[src]](https://www.apache.org/dyn/closer.cgi/skywalking/6.4.0/apache-skywalking-apm-6.4.0-src.tgz) [[asc]](https://www.apache.org/dist/skywalking/6.4.0/apache-skywalking-apm-6.4.0-src.tgz.asc) [[sha512]](https://www.apache.org/dist/skywalking/6.4.0/apache-skywalking-apm-6.4.0-src.tgz.sha512)| -| | | Binary Distribution (Windows)| [[zip]](https://www.apache.org/dyn/closer.cgi/skywalking/6.4.0/apache-skywalking-apm-6.4.0.zip) [[asc]](https://www.apache.org/dist/skywalking/6.4.0/apache-skywalking-apm-6.4.0.zip.asc) [[sha512]](https://www.apache.org/dist/skywalking/6.4.0/apache-skywalking-apm-6.4.0.zip.sha512)| -| | | Binary Distribution (Linux) | [[tar]](https://www.apache.org/dyn/closer.cgi/skywalking/6.4.0/apache-skywalking-apm-6.4.0.tar.gz) [[asc]](https://www.apache.org/dist/skywalking/6.4.0/apache-skywalking-apm-6.4.0.tar.gz.asc) [[sha512]](https://www.apache.org/dist/skywalking/6.4.0/apache-skywalking-apm-6.4.0.tar.gz.sha512)| -| | | Documentation| [Documentation](https://github.com/apache/skywalking/blob/v6.4.0/docs/README.md) | ### SkyWalking CLI | Date | Version| | Downloads | @@ -40,6 +36,7 @@ Use the links below to download the Apache SkyWalking from one of our mirrors. ### All Releases * Find all SkyWalking releases in the [Archive repository](https://archive.apache.org/dist/skywalking/) +* [Archive incubating repository](https://archive.apache.org/dist/incubator/skywalking/) hosts older releases when SkyWalking was an incubator project. ### Docker Images for convenience **Docker images are not official ASF releases but provided for convenience. Recommended usage is always to build the source** @@ -48,11 +45,8 @@ Use the links below to download the Apache SkyWalking from one of our mirrors. - SkyWalking OAP Server, https://hub.docker.com/r/apache/skywalking-oap-server - SkyWalking UI, https://hub.docker.com/r/apache/skywalking-ui -## Incubator release versions -Downloads for all versions when SkyWalking was an incubator project. - -* [Archive incubating repository](https://archive.apache.org/dist/incubator/skywalking/). +## Changelog You can also read the [changelogs](https://github.com/apache/incubator-skywalking/blob/master/CHANGES.md) for all versions. diff --git a/docs/zh/downloads/README.md b/docs/zh/downloads/README.md index 9f7b1dc..6d01f15 100755 --- a/docs/zh/downloads/README.md +++ b/docs/zh/downloads/README.md @@ -3,7 +3,7 @@ **只有源码包属于Apache官方发布包，其他Linux和Windows平台二进制发布包只是为了方便用户使用。** -## 下载6.x最新版本 +## 下载最新版本 ### SkyWalking APM | 日期 | 版本| | 下载 | @@ -18,10 +18,7 @@ | | | Binary Distribution (Windows)| [[zip]](https://www.apache.org/dyn/closer.cgi/skywalking/6.5.0/apache-skywalking-apm-6.5.0.zip) [[asc]](https://www.apache.org/dist/skywalking/6.5.0/apache-skywalking-apm-6.5.0.zip.asc) [[sha512]](https://www.apache.org/dist/skywalking/6.5.0/apache-skywalking-apm-6.5.0.zip.sha512)| | | | Binary Distribution (Linux) | [[tar]](https://www.apache.org/dyn/closer.cgi/skywalking/6.5.0/apache-skywalking-apm-6.5.0.tar.gz) [[asc]](https://www.apache.org/dist/skywalking/6.5.0/apache-skywalking-apm-6.5.0.tar.gz.asc)
[GitHub] [skywalking] aderm commented on a change in pull request #4292: Improve ES query performance
aderm commented on a change in pull request #4292: Improve ES query performance
URL: https://github.com/apache/skywalking/pull/4292#discussion_r372785778
##
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/AggregationQueryEsDAO.java
##
@@ -96,7 +96,7 @@ public AggregationQueryEsDAO(ElasticSearchClient client) {
SearchSourceBuilder sourceBuilder = SearchSourceBuilder.searchSource();
BoolQueryBuilder boolQueryBuilder = QueryBuilders.boolQuery();
-sourceBuilder.query(boolQueryBuilder);
+
sourceBuilder.query(QueryBuilders.boolQuery().filter(boolQueryBuilder));
boolQueryBuilder.must().add(QueryBuilders.rangeQuery(Metrics.TIME_BUCKET).lte(endTB).gte(startTB));
boolQueryBuilder.must().add(QueryBuilders.termQuery(EndpointInventory.SERVICE_ID,
serviceId));
Review comment:
[https://www.elastic.co/guide/en/elasticsearch/reference/7.5/query-dsl-filtered-query.html](url)
[https://www.elastic.co/guide/en/elasticsearch/client/net-api/7.x/writing-queries.html](url)
> The benefit of executing a query in a filter context is that Elasticsearch
is able to forgo calculating a relevancy score, as well as cache filters for
faster subsequent performance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4298: How can I trace the time consum of every method now in 6.0.0+ ?
wu-sheng closed issue #4298: How can I trace the time consum of every method now in 6.0.0+ ? URL: https://github.com/apache/skywalking/issues/4298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4298: How can I trace the time consum of every method now in 6.0.0+ ?
wu-sheng commented on issue #4298: How can I trace the time consum of every method now in 6.0.0+ ? URL: https://github.com/apache/skywalking/issues/4298#issuecomment-580105287 That is not possible if you do this in production env. This will make the latency of your app very bad. You could trace some of them by using the optional plugins. Read the agent optional plugin doc. there are spring bean plugin and customize plugin. https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/README.md#optional-plugins This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] 17173YeYu commented on issue #4298: How can I trace the time consum of every method now in 6.0.0+ ?
17173YeYu commented on issue #4298: How can I trace the time consum of every method now in 6.0.0+ ? URL: https://github.com/apache/skywalking/issues/4298#issuecomment-580104724 How can I trace the time consum of every method now in 6.0.0+ ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] 17173YeYu opened a new issue #4298: How can I trace the time consum of every method now in 6.0.0+ ?
17173YeYu opened a new issue #4298: How can I trace the time consum of every method now in 6.0.0+ ? URL: https://github.com/apache/skywalking/issues/4298 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? How can I trace the time consum of every method now in 6.0.0+ ? ___ ### Bug - Which version of SkyWalking, OS and JRE? - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] 17173YeYu opened a new issue #4297: 6.0.0+版本最细的追踪粒度
17173YeYu opened a new issue #4297: 6.0.0+版本最细的追踪粒度 URL: https://github.com/apache/skywalking/issues/4297 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? 6.0.0+版本最细的追踪粒度只能接口级别吗？ 原来的5.0.0+版本不是可以最终每个方法级别的时间消耗吗? 6.0.0+还能做到吗？ 如果6.0.0+没有了，那我该怎么追踪整个调用链上每个方法的耗时呢？ ___ ### Bug - Which version of SkyWalking, OS and JRE? - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4297: 6.0.0+版本最细的追踪粒度
wu-sheng commented on issue #4297: 6.0.0+版本最细的追踪粒度 URL: https://github.com/apache/skywalking/issues/4297#issuecomment-580104021 English only. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4297: 6.0.0+版本最细的追踪粒度
wu-sheng closed issue #4297: 6.0.0+版本最细的追踪粒度 URL: https://github.com/apache/skywalking/issues/4297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] 17173YeYu commented on issue #4297: 6.0.0+版本最细的追踪粒度
17173YeYu commented on issue #4297: 6.0.0+版本最细的追踪粒度 URL: https://github.com/apache/skywalking/issues/4297#issuecomment-580103858 6.0.0+版本最细的追踪粒度只能接口级别吗？ 原来的5.0.0+版本不是可以最终每个方法级别的时间消耗吗? 6.0.0+还能做到吗？ 如果6.0.0+没有了，那我该怎么追踪整个调用链上每个方法的耗时呢？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] 17173YeYu commented on issue #4296: Top 20 slow traces remove ?
17173YeYu commented on issue #4296: Top 20 slow traces remove ? URL: https://github.com/apache/skywalking/issues/4296#issuecomment-580102477 Hello , did the Top 20 slow traces have removed in 6.0.0+? where is the the time consumption of method ？I can find it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4296: Top 20 slow traces remove ?
wu-sheng closed issue #4296: Top 20 slow traces remove ? URL: https://github.com/apache/skywalking/issues/4296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4296: Top 20 slow traces remove ?
wu-sheng commented on issue #4296: Top 20 slow traces remove ? URL: https://github.com/apache/skywalking/issues/4296#issuecomment-580102605 Top slow trace is based on trace query, nothing more. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] 17173YeYu opened a new issue #4296: Top 20 slow traces remove ?
17173YeYu opened a new issue #4296: Top 20 slow traces remove ? URL: https://github.com/apache/skywalking/issues/4296 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? Hello , did the Top 20 slow traces have removed in 6.0.0+? where is the the time consumption of method ？I can find it. ___ ### Bug - Which version of SkyWalking, OS and JRE? - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4295: Skywalking build failure
wu-sheng closed issue #4295: Skywalking build failure URL: https://github.com/apache/skywalking/issues/4295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4295: Skywalking build failure
wu-sheng commented on issue #4295: Skywalking build failure URL: https://github.com/apache/skywalking/issues/4295#issuecomment-580101484 I think this is your local maven or network issue. Every release has been checked in the CI and release process. Pulsar 2.4.0 is existing, https://mvnrepository.com/artifact/org.apache.pulsar/pulsar-client This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] sujithkumar28 opened a new issue #4295: Skywalking build failure
sujithkumar28 opened a new issue #4295: Skywalking build failure URL: https://github.com/apache/skywalking/issues/4295 I'm trying to build skywalking source in windows by executing the command mvnw clean package -DskipTests but i'm receiving the following error Dependencies for project org.apache.skywalking:apm-pulsar-plugin:jar:6.6.0: Faile d to collect dependencies at org.apache.pulsar:pulsar-client:jar:2.4.0: Failed t o read artifact descriptor for org.apache.pulsar:pulsar-client:jar:2.4.0: Could not transfer artifact com.amazonaws:aws-java-sdk-bom:pom:1.11.297 from/to centra l (https://repo1.maven.org/maven2): Connect to repo1.maven.org:443 [repo1.maven. org/151.101.120.209] failed: Connection timed out: connect -> [Help 1] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm edited a comment on issue #4292: Improve ES query performance
aderm edited a comment on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-579832206 https://user-images.githubusercontent.com/2892433/73374322-f51d1a00-42f4-11ea-81e8-5926a69fe450.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr removed a comment on issue #4291: Improve ES query performance
dmsolr removed a comment on issue #4291: Improve ES query performance URL: https://github.com/apache/skywalking/issues/4291#issuecomment-579830178 > As you can see from the results, no score is calculated, this is what we need. max_score":0.0 This is a wonderful feature. As far as I knew, it is included in Lucene8.0. That means the feature is released by above ES7.0, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #4291: Improve ES query performance
aderm commented on issue #4291: Improve ES query performance URL: https://github.com/apache/skywalking/issues/4291#issuecomment-579833364 > Do you have benchmark, document or blogs to verify this change? OK, some bench test examples will be executed next This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr commented on a change in pull request #4292: Improve ES query performance
dmsolr commented on a change in pull request #4292: Improve ES query performance
URL: https://github.com/apache/skywalking/pull/4292#discussion_r372480002
##
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/AggregationQueryEsDAO.java
##
@@ -96,7 +96,7 @@ public AggregationQueryEsDAO(ElasticSearchClient client) {
SearchSourceBuilder sourceBuilder = SearchSourceBuilder.searchSource();
BoolQueryBuilder boolQueryBuilder = QueryBuilders.boolQuery();
-sourceBuilder.query(boolQueryBuilder);
+
sourceBuilder.query(QueryBuilders.boolQuery().filter(boolQueryBuilder));
boolQueryBuilder.must().add(QueryBuilders.rangeQuery(Metrics.TIME_BUCKET).lte(endTB).gte(startTB));
boolQueryBuilder.must().add(QueryBuilders.termQuery(EndpointInventory.SERVICE_ID,
serviceId));
Review comment:
I am not familiar with ES, but I am very familiar with Lucene.
Something likes TimeRange used `filter` is OK. The query clause will be
cached. But something likes ServiceID, I think it is not suitable.
Please recheck. :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on issue #4292: Improve ES query performance
aderm commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-579832206 timed out， A little strange. https://user-images.githubusercontent.com/2892433/73374322-f51d1a00-42f4-11ea-81e8-5926a69fe450.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #4291: Improve ES query performance
dmsolr commented on issue #4291: Improve ES query performance URL: https://github.com/apache/skywalking/issues/4291#issuecomment-579830178 > As you can see from the results, no score is calculated, this is what we need. max_score":0.0 This is a wonderful feature. As far as I knew, it is included in Lucene8.0. That means the feature is released by above ES7.0, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4294: Agent issue with Java Spring framework
wu-sheng commented on issue #4294: Agent issue with Java Spring framework URL: https://github.com/apache/skywalking/issues/4294#issuecomment-579794338 The key is providing a demo code to replicate your error in a very simple demo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4294: Agent issue with Java Spring framework
wu-sheng commented on issue #4294: Agent issue with Java Spring framework URL: https://github.com/apache/skywalking/issues/4294#issuecomment-579793973 Those are test codes. You could see they are common Spring app, it could be traced and monitored by SkyWalking agent. I don't know the real issue you asked. I recommend you compare our tests with yours. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] raybah commented on issue #4294: Agent issue with Java Spring framework
raybah commented on issue #4294: Agent issue with Java Spring framework URL: https://github.com/apache/skywalking/issues/4294#issuecomment-579776264 @wu-sheng thanks for the answer. Please help with understanding what should we do with these scenarios? Should we deploy these as a plugins to Skywalking server? Or we should only make changes in configs? Also if we deploy older versions of Skywalking agent/server, will it help? thanks in advance This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #2438: Increase the test coverage rate
wu-sheng commented on issue #2438: Increase the test coverage rate URL: https://github.com/apache/skywalking/issues/2438#issuecomment-579755207 # Status update All important tests have been provided in the master branch and PR process already. This issue will keep open if any contributor wants to help about the Unit Tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP
wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-57975 ### Metrics are following > 1. PV for every page(endpoint), version(instance) and service 1. **ADD**, browser_app_pv for global. 1. browser_page_pv 1. browser_single_version_page_pv > 2. The error rate for every page. 1. **ADD**, browser_app_error_rate for global. 1. browser_page_error_rate 1. browser_single_version_page_error_rate > 5. Avg value of all fields in PerfDetail. 1. browser_*_percentile 1. browser_*_avg 1. browser_*_percentile Are above three global metrics? _ # Naming 1. BROWSER, global metrics for browser performance, like All in service metrics. 1. BROWSER_APP_*, service level metrics. 1. BROWSER_APP_SINGLE_VERSION_*, service instance level metrics 1. BROWSER_APP_PAGE_*, for every single page. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4292: Improve ES query performance
wu-sheng commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-579745860 Look like e2e is failing, please check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r372358784
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/oal/rt/OALEngineService.java
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.oal.rt;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.server.core.CoreModule;
+import org.apache.skywalking.oap.server.core.analysis.StreamAnnotationListener;
+import org.apache.skywalking.oap.server.core.source.SourceReceiver;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import org.apache.skywalking.oap.server.library.module.ModuleStartException;
+import org.apache.skywalking.oap.server.library.module.Service;
+
+import java.lang.reflect.Constructor;
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ *
+ * @author zhangwei
+ */
+@Slf4j
+public class OALEngineService implements Service {
+
+private final Map engineMap = new HashMap<>();
+private final ModuleManager moduleManager;
+
+public OALEngineService(ModuleManager moduleManager) {
+this.moduleManager = moduleManager;
+}
+
+public void activate(OALEngine.Group group) throws ModuleStartException {
+activate(group, OALEngineService.class.getClassLoader());
+}
+
+public void activate(OALEngine.Group group, ClassLoader classLoader)
throws ModuleStartException {
Review comment:
Who will provide an external ClassLoader?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r372363934
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/browser/source/BrowserSingleVersionPagePathPerfDetail.java
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.browser.source;
+
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.source.ScopeDeclaration;
+import org.apache.skywalking.oap.server.core.source.ScopeDefaultColumn;
+import org.apache.skywalking.oap.server.core.source.Source;
+
+import static
org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.BROWSER_SINGLE_VERSION_PAGE_PATH_CATALOG_NAME;
+import static
org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.BROWSER_SINGLE_VERSION_PAGE_PATH_PERF_DETAIL;
+
+/**
+ * @author zhangwei
+ */
+@ScopeDeclaration(id = BROWSER_SINGLE_VERSION_PAGE_PATH_PERF_DETAIL, name =
"BrowserSingleVersionPagePathPerfDetail", catalog =
BROWSER_SINGLE_VERSION_PAGE_PATH_CATALOG_NAME)
+@ScopeDefaultColumn.VirtualColumnDefinition(fieldName = "entityId", columnName
= "entity_id", isID = true, type = String.class)
+public class BrowserSingleVersionPagePathPerfDetail extends Source {
Review comment:
Naming issue. This should be related to BrowserAppSignleVersion. Not to page
path even you could include the path for filter and metrics funcs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r372362241
##
File path:
oap-server/server-receiver-plugin/skywalking-browser-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/recevier/browser/provider/parse/BrowserPerfDataParse.java
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.recevier.browser.provider.parse;
+
+import lombok.Setter;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.apm.network.language.agent.BrowserPerfData;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.CoreModule;
+import org.apache.skywalking.oap.server.core.analysis.TimeBucket;
+import
org.apache.skywalking.oap.server.core.cache.ServiceInstanceInventoryCache;
+import org.apache.skywalking.oap.server.library.buffer.BufferData;
+import org.apache.skywalking.oap.server.library.buffer.DataStreamReader;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import
org.apache.skywalking.oap.server.recevier.browser.provider.BrowserServiceModuleConfig;
+import
org.apache.skywalking.oap.server.recevier.browser.provider.parse.decorator.BrowserErrorLogDecorator;
+import
org.apache.skywalking.oap.server.recevier.browser.provider.parse.decorator.BrowserPerfDataCoreInfo;
+import
org.apache.skywalking.oap.server.recevier.browser.provider.parse.decorator.BrowserPerfDataDecorator;
+import
org.apache.skywalking.oap.server.recevier.browser.provider.parse.listener.BrowserPerfDataListener;
+import
org.apache.skywalking.oap.server.recevier.browser.provider.parse.standardization.BrowserPerfDataStandardization;
+import
org.apache.skywalking.oap.server.recevier.browser.provider.parse.standardization.BrowserPerfDataStandardizationWorker;
+import
org.apache.skywalking.oap.server.recevier.browser.provider.parse.standardization.PagePathIdExchanger;
+import org.apache.skywalking.oap.server.telemetry.TelemetryModule;
+import org.apache.skywalking.oap.server.telemetry.api.CounterMetrics;
+import org.apache.skywalking.oap.server.telemetry.api.MetricsCreator;
+import org.apache.skywalking.oap.server.telemetry.api.MetricsTag;
+
+import java.util.LinkedList;
+import java.util.List;
+
+/**
+ * @author zhangwei
+ */
+@Slf4j
+public class BrowserPerfDataParse {
Review comment:
`Parse` -> `Parser`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r372364204 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/browser/source/BrowserSingleVersionPerfDetail.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.core.browser.source; + +import lombok.Getter; +import lombok.Setter; +import org.apache.skywalking.oap.server.core.source.ScopeDeclaration; +import org.apache.skywalking.oap.server.core.source.ScopeDefaultColumn; +import org.apache.skywalking.oap.server.core.source.Source; + +import static org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.SERVICE_INSTANCE_CATALOG_NAME; +import static org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.BROWSER_SINGLE_VERSION_PERF_DETAIL; + +/** + * @author zhangwei + */ +@ScopeDeclaration(id = BROWSER_SINGLE_VERSION_PERF_DETAIL, name = "BrowserSingleVersionPerfDetail", catalog = SERVICE_INSTANCE_CATALOG_NAME) Review comment: Catalog is not right. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r372364704
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/browser/source/BrowserPagePathPerfDetail.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.browser.source;
+
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.source.ScopeDeclaration;
+import org.apache.skywalking.oap.server.core.source.ScopeDefaultColumn;
+import org.apache.skywalking.oap.server.core.source.Source;
+
+import static
org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.BROWSER_PAGE_PATH_CATALOG_NAME;
+import static
org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.BROWSER_PAGE_PATH_PERF_DETAIL;
+
+/**
+ * @author zhangwei
+ */
+@ScopeDeclaration(id = BROWSER_PAGE_PATH_PERF_DETAIL, name =
"BrowserPagePathPerfDetail", catalog = BROWSER_PAGE_PATH_CATALOG_NAME)
+@ScopeDefaultColumn.VirtualColumnDefinition(fieldName = "entityId", columnName
= "entity_id", isID = true, type = String.class)
+public class BrowserPagePathPerfDetail extends Source {
Review comment:
`BrowserPagePathPerfDetail`-> `BrowserAppPagePerf`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r372365553
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/browser/source/BrowserPerfData.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.browser.source;
+
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.skywalking.oap.server.core.source.ScopeDeclaration;
+import org.apache.skywalking.oap.server.core.source.Source;
+
+import static
org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.BROWSER_PERF_DATA;
+
+/**
+ * @author zhangwei
+ */
+@ScopeDeclaration(id = BROWSER_PERF_DATA, name = "BrowserPerfData")
+public class BrowserPerfData extends Source {
Review comment:
`Browser`-> `BrowserApp`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r372368071
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/browser/source/BrowserSingleVersionPerfDetail.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.browser.source;
+
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.skywalking.oap.server.core.source.ScopeDeclaration;
+import org.apache.skywalking.oap.server.core.source.ScopeDefaultColumn;
+import org.apache.skywalking.oap.server.core.source.Source;
+
+import static
org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.SERVICE_INSTANCE_CATALOG_NAME;
+import static
org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.BROWSER_SINGLE_VERSION_PERF_DETAIL;
+
+/**
+ * @author zhangwei
+ */
+@ScopeDeclaration(id = BROWSER_SINGLE_VERSION_PERF_DETAIL, name =
"BrowserSingleVersionPerfDetail", catalog = SERVICE_INSTANCE_CATALOG_NAME)
+@ScopeDefaultColumn.VirtualColumnDefinition(fieldName = "entityId", columnName
= "entity_id", isID = true, type = String.class)
+public class BrowserSingleVersionPerfDetail extends Source {
Review comment:
`Browser` -> `BrowserApp`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r372366440 ## File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal ## @@ -0,0 +1,87 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +* +*/ + +// Browser service +browser_redirect_avg = from(BrowserPerfDetail.redirectTime).longAvg(); +browser_dns_avg = from(BrowserPerfDetail.dnsTime).longAvg(); +browser_req_avg = from(BrowserPerfDetail.reqTime).longAvg(); +browser_dom_analysis_avg = from(BrowserPerfDetail.domAnalysisTime).longAvg(); +browser_dom_ready_avg = from(BrowserPerfDetail.domReadyTime).longAvg(); +browser_blank_avg = from(BrowserPerfDetail.blankTime).longAvg(); + +// Multiple values including p50, p75, p90, p95, p99 +browser_redirect_percentile = from(BrowserPerfDetail.redirectTime).percentile(10); +browser_dns_percentile = from(BrowserPerfDetail.dnsTime).percentile(10); +browser_req_percentile = from(BrowserPerfDetail.reqTime).percentile(10); +browser_dom_analysis_percentile = from(BrowserPerfDetail.domAnalysisTime).percentile(10); +browser_dom_ready_percentile = from(BrowserPerfDetail.domReadyTime).percentile(10); +browser_blank_percentile = from(BrowserPerfDetail.blankTime).percentile(10); + +// Browser service page +browser_page_pv = from(BrowserPagePathPerfDetail.count).sum(); +browser_page_error_rate = from(BrowserPagePathPerfDetail.*).percent(status == false); + +browser_page_redirect_avg = from(BrowserPagePathPerfDetail.redirectTime).longAvg(); +browser_page_dns_avg = from(BrowserPagePathPerfDetail.dnsTime).longAvg(); +browser_page_req_avg = from(BrowserPagePathPerfDetail.reqTime).longAvg(); +browser_page_dom_analysis_avg = from(BrowserPagePathPerfDetail.domAnalysisTime).longAvg(); +browser_page_dom_ready_avg = from(BrowserPagePathPerfDetail.domReadyTime).longAvg(); +browser_page_blank_avg = from(BrowserPagePathPerfDetail.blankTime).longAvg(); + +// Multiple values including p50, p75, p90, p95, p99 +browser_page_redirect_percentile = from(BrowserPagePathPerfDetail.redirectTime).percentile(10); +browser_page_dns_percentile = from(BrowserPagePathPerfDetail.dnsTime).percentile(10); +browser_page_req_percentile = from(BrowserPagePathPerfDetail.reqTime).percentile(10); +browser_page_dom_analysis_percentile = from(BrowserPagePathPerfDetail.domAnalysisTime).percentile(10); +browser_page_dom_ready_percentile = from(BrowserPagePathPerfDetail.domReadyTime).percentile(10); +browser_page_blank_percentile = from(BrowserPagePathPerfDetail.blankTime).percentile(10); + +// Browser service version Review comment: This comment is not right. > Performance metrics of every single version . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r372359627 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java ## @@ -71,16 +71,28 @@ public static final int PROFILE_TASK_LOG = 27; public static final int PROFILE_TASK_SEGMENT_SNAPSHOT = 28; +// browser +public static final int BROWSER_PERF_DATA = 40; +public static final int BROWSER_PERF_DETAIL = 41; +public static final int BROWSER_PAGE_PATH_PERF_DETAIL = 42; +public static final int BROWSER_SINGLE_VERSION_PERF_DETAIL = 43; +public static final int BROWSER_SINGLE_VERSION_PAGE_PATH_PERF_DETAIL = 44; + /** * Catalog of scope, the metrics processor could use this to group all generated metrics by oal rt. */ public static final String SERVICE_CATALOG_NAME = "SERVICE"; public static final String SERVICE_INSTANCE_CATALOG_NAME = "SERVICE_INSTANCE"; public static final String ENDPOINT_CATALOG_NAME = "ENDPOINT"; +public static final String BROWSER_PAGE_PATH_CATALOG_NAME = "BROWSER_PAGE_PATH"; +public static final String BROWSER_SINGLE_VERSION_PAGE_PATH_CATALOG_NAME = "BROWSER_SINGLE_VERSION_PAGE_PATH"; Review comment: This should be mapping to the service instance, right? Then it should be named. `BROWSER_APP_SINGLE_VERSION_CATALOG_NAME` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r372360241 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java ## @@ -71,16 +71,28 @@ public static final int PROFILE_TASK_LOG = 27; public static final int PROFILE_TASK_SEGMENT_SNAPSHOT = 28; +// browser +public static final int BROWSER_PERF_DATA = 40; Review comment: `BROWSER_` -> `BROWSER_APP_`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4294: Agent issue with Java Spring framework
wu-sheng commented on issue #4294: Agent issue with Java Spring framework URL: https://github.com/apache/skywalking/issues/4294#issuecomment-579740109 You could check out supported test cases. https://github.com/apache/skywalking/tree/master/test/plugin/scenarios You could look through the test demo we wrote for testing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] raybah opened a new issue #4294: Agent issue with Java Spring framework
raybah opened a new issue #4294: Agent issue with Java Spring framework
URL: https://github.com/apache/skywalking/issues/4294
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Question
- What do you want to know?
How we can resolve this issue?
For example, we can try to use older version of agent, or try to use newer
version of Spring framework. Please help with this or or suggest other
solutions. Also I hope this issue will be fixed in next versions of Skywalking.
___
### Bug
- Which version of SkyWalking, OS and JRE?
Skywalking - 6.6.0 release
(http://apache-mirror.rbc.ru/pub/apache/skywalking/6.6.0/apache-skywalking-apm-es7-6.6.0.tar.gz)
OS - CentOS release 6.5 (Final)
JRE - "1.8.0_92"
[java_info.txt](https://github.com/apache/skywalking/files/4127760/java_info.txt)
Spring version - "4.0.5"
Tomcat version - "7.0.35.0"
- Which company or project?
Company - Tango me
Project - APM research methods, trying to find solution for applications
performance monitoring
- What happen?
If possible, provide a way for reproducing the error. e.g. demo application,
component version.
Skywalking server and agent have been deployed on server according
documentation. Configuration parameters:
server - by default
agent - by default except:
agent.service_name=${SW_AGENT_NAME:controllerator}
collector.backend_service=${SW_AGENT_COLLECTOR_BACKEND_SERVICES:172.20.2.66:11800}
We want to monitor application which was deployed in Apache Tomcat server.
All worked properly for a few hours, seems like after some request in app we
received an error from skywalking agent, see logs attached.
[agent_bug.txt](https://github.com/apache/skywalking/files/4127882/agent_bug.txt)
___
### Requirement or improvement
- Please describe about your requirements or improvement suggestions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4293: Skywalking database connectivity understanding doc
wu-sheng commented on issue #4293: Skywalking database connectivity understanding doc URL: https://github.com/apache/skywalking/issues/4293#issuecomment-579734717 H2 is just an implementation of storage. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4293: Skywalking database connectivity understanding doc
wu-sheng closed issue #4293: Skywalking database connectivity understanding doc URL: https://github.com/apache/skywalking/issues/4293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4293: Skywalking database connectivity understanding doc
wu-sheng commented on issue #4293: Skywalking database connectivity understanding doc URL: https://github.com/apache/skywalking/issues/4293#issuecomment-579734588 `MetricsPersistentWorker` for metrics, topology, and topN. `RecordStreamProcessor` for traces. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4276: Provide AVRO plugin
wu-sheng commented on issue #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#issuecomment-579733601 @dmsolr Avro test failing? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] sujithkumar28 opened a new issue #4293: Skywalking database connectivity understanding doc
sujithkumar28 opened a new issue #4293: Skywalking database connectivity understanding doc URL: https://github.com/apache/skywalking/issues/4293 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question This is to understand skywalking. I'm new to skywalking. I want to understand how data as a whole sent to h2. Anyone naming the files to be looked after will be much helpful. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4291: Improve ES query performance
wu-sheng commented on issue #4291: Improve ES query performance URL: https://github.com/apache/skywalking/issues/4291#issuecomment-579705373 Do you have benchmark, document or blogs to verify this change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm opened a new pull request #4292: Improve ES query performance
aderm opened a new pull request #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [x] Improve performance - Related issues #4291 ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm opened a new issue #4291: Improve ES query performance
aderm opened a new issue #4291: Improve ES query performance
URL: https://github.com/apache/skywalking/issues/4291
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [x] Feature or performance improvement
___
### Question
- What do you want to know?
___
### Bug
- Which version of SkyWalking, OS and JRE?
- Which company or project?
- What happen?
If possible, provide a way for reproducing the error. e.g. demo application,
component version.
___
### Requirement or improvement
- Please describe about your requirements or improvement suggestions.
We can use the 'qool bool filter' statement to replace the normal query of
'qool bool'.
There are two benefits:
1.No scoring calculation is needed to speed up the calculation;
2. Filter query can make full use of the cache and improve the time of
repeated sub-query
Take the query interface `MetadataQueryEsDAO#getAllServices` as an example：
- ES query dsl：
`{"size":5000,"query":{"bool":{"must":[{"bool":{"should":[{"bool":{"must":[{"range":{"heartbeat_time":{"from":158029272,"to":null,"include_lower":true,"include_upper":true,"boost":1.0}}},{"range":{"register_time":{"from":null,"to":158029272,"include_lower":true,"include_upper":true,"boost":1.0}}}],"adjust_pure_negative":true,"boost":1.0}},{"bool":{"must":[{"range":{"register_time":{"from":null,"to":158029272,"include_lower":true,"include_upper":true,"boost":1.0}}},{"range":{"heartbeat_time":{"from":158029176,"to":null,"include_lower":true,"include_upper":true,"boost":1.0}}}],"adjust_pure_negative":true,"boost":1.0}}],"adjust_pure_negative":true,"boost":1.0}},{"term":{"is_address":{"value":0,"boost":1.0}}},{"term":{"node_type":{"value":0,"boost":1.0}}}],"adjust_pure_negative":true,"boost":1.0}}}`
- and result：
`{"took":0,"timed_out":false,"_shards":{"total":2,"successful":2,"skipped":0,"failed":0},"hits":{"total":{"value":1,"relation":"eq"},**"max_score":6.0**,"hits":[{"_index":"service_inventory","_type":"_doc","_id":"Your_ApplicationName_0_0",**"_score":6.0**,"_source":{"sequence":2,"last_update_time":1580287478790,"heartbeat_time":1580292752350,"node_type":0,"name":"Your_ApplicationName","address_id":0,"is_address":0,"mapping_service_id":0,"register_time":1580287478790,"properties":"{}"}}]}}`
In the results, we see that the search engine scored：`max_score:6.0`.
When improvements are made:
- ES query dsl：
`{"size":5000,"query":{"bool":{"**filter**":[{"bool":{"must":[{"bool":{"should":[{"bool":{"must":[{"range":{"heartbeat_time":{"from":158029308,"to":null,"include_lower":true,"include_upper":true,"boost":1.0}}},{"range":{"register_time":{"from":null,"to":158029308,"include_lower":true,"include_upper":true,"boost":1.0}}}],"adjust_pure_negative":true,"boost":1.0}},{"bool":{"must":[{"range":{"register_time":{"from":null,"to":158029308,"include_lower":true,"include_upper":true,"boost":1.0}}},{"range":{"heartbeat_time":{"from":158029212,"to":null,"include_lower":true,"include_upper":true,"boost":1.0}}}],"adjust_pure_negative":true,"boost":1.0}}],"adjust_pure_negative":true,"boost":1.0}},{"term":{"is_address":{"value":0,"boost":1.0}}},{"term":{"node_type":{"value":0,"boost":1.0}}}],"adjust_pure_negative":true,"boost":1.0}}],"adjust_pure_negative":true,"boost":1.0}}}`
- and result：
`{"took":0,"timed_out":false,"_shards":{"total":2,"successful":2,"skipped":0,"failed":0},"hits":{"total":{"value":1,"relation":"eq"},**"max_score":0.0**,"hits":[{"_index":"service_inventory","_type":"_doc","_id":"Your_ApplicationName_0_0",**"_score":0.0**,"_source":{"sequence":2,"last_update_time":1580287478790,"heartbeat_time":1580293072125,"node_type":0,"name":"Your_ApplicationName","address_id":0,"is_address":0,"mapping_service_id":0,"register_time":1580287478790,"properties":"{}"}}]}}`
As you can see from the results, no score is calculated, this is what we
need. **max_score":0.0**
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4177: Enhance gRPC plugin
codecov-io edited a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-575098453 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=h1) Report > Merging [#4177](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/23be98441c0aee38119d1beace166be57930fcbf?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4177 +/- ## == - Coverage 26.83% 26.82% -0.02% == Files1162 1162 Lines 2544825457 +9 Branches 3630 3631 +1 == - Hits 6829 6828 -1 - Misses 1801418023 +9 - Partials 605 606 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=tree) | Coverage Δ | | |---|---|---| | [...alking/oap/query/graphql/resolver/MetricQuery.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL01ldHJpY1F1ZXJ5LmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [.../storage/plugin/jdbc/h2/dao/H2MetricsQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc1F1ZXJ5REFPLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [.../plugin/elasticsearch/query/MetricsQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTWV0cmljc1F1ZXJ5RXNEQU8uamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...king/oap/server/core/query/MetricQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvTWV0cmljUXVlcnlTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `35.63% <0%> (-1.15%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=footer). Last update [23be984...9608d07](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4177: Enhance gRPC plugin
codecov-io edited a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-575098453 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=h1) Report > Merging [#4177](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/23be98441c0aee38119d1beace166be57930fcbf?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4177 +/- ## === Coverage 26.83% 26.83% === Files1162 1162 Lines 2544825448 Branches 3630 3630 === Hits 6829 6829 Misses 1801418014 Partials 605 605 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=footer). Last update [23be984...9608d07](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4290: Skywalking Couldn't view H2 console
kezhenxu94 commented on issue #4290: Skywalking Couldn't view H2 console URL: https://github.com/apache/skywalking/issues/4290#issuecomment-579674477 No you can't access the H2 console by default, if you have to, please start H2 in server mode, for more information, please refer to http://h2database.com/html/features.html#auto_mixed_mode This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] kezhenxu94 closed issue #4290: Skywalking Couldn't view H2 console
kezhenxu94 closed issue #4290: Skywalking Couldn't view H2 console URL: https://github.com/apache/skywalking/issues/4290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4276: Provide AVRO plugin
codecov-io edited a comment on issue #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#issuecomment-576318626 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=h1) Report > Merging [#4276](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9a2633374218366debd1f5c66b773a1ddc6fa4e3?src=pr=desc) will **decrease** coverage by `0.11%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4276 +/- ## == - Coverage 26.88% 26.77% -0.12% == Files1168 1168 Lines 2545625465 +9 Branches 3633 3634 +1 == - Hits 6845 6818 -27 - Misses 1800518041 +36 Partials 606 606 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=tree) | Coverage Δ | | |---|---|---| | [...alking/oap/query/graphql/resolver/MetricQuery.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL01ldHJpY1F1ZXJ5LmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [.../storage/plugin/jdbc/h2/dao/H2MetricsQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc1F1ZXJ5REFPLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [.../plugin/elasticsearch/query/MetricsQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTWV0cmljc1F1ZXJ5RXNEQU8uamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...king/oap/server/core/query/MetricQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvTWV0cmljUXVlcnlTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `59.01% <0%> (-18.04%)` | :arrow_down: | | [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `67.85% <0%> (-17.86%)` | :arrow_down: | | [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `28.73% <0%> (-8.05%)` | :arrow_down: | | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `28.08% <0%> (-3.38%)` | :arrow_down: | | [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `80.88% <0%> (-1.48%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=footer). Last update [9a26333...95f6cda](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=lastupdated). Read the [comment
[GitHub] [skywalking] kezhenxu94 closed issue #4288: Support specific linear query for new `getMultipleLinearIntValues`
kezhenxu94 closed issue #4288: Support specific linear query for new `getMultipleLinearIntValues` URL: https://github.com/apache/skywalking/issues/4288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking] branch master updated: Refactor the storage to support `getSubsetOfMultipleLinearIntValues` (#4289)
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 17e3fff Refactor the storage to support
`getSubsetOfMultipleLinearIntValues` (#4289)
17e3fff is described below
commit 17e3fff83a14776c864cd3bc8a1e7c5c62607169
Author: 吴晟 Wu Sheng
AuthorDate: Wed Jan 29 17:03:39 2020 +0800
Refactor the storage to support `getSubsetOfMultipleLinearIntValues` (#4289)
---
.../oap/server/core/query/MetricQueryService.java | 17 +++--
.../core/storage/query/IMetricsQueryDAO.java | 18 +-
.../oap/query/graphql/resolver/MetricQuery.java| 28 +-
.../src/main/resources/query-protocol | 2 +-
.../elasticsearch/query/MetricsQueryEsDAO.java | 9 +++
.../plugin/jdbc/h2/dao/H2MetricsQueryDAO.java | 9 +++
6 files changed, 60 insertions(+), 23 deletions(-)
diff --git
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/MetricQueryService.java
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/MetricQueryService.java
index 8636edc..d2cb9af 100644
---
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/MetricQueryService.java
+++
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/MetricQueryService.java
@@ -100,6 +100,19 @@ public class MetricQueryService implements Service {
final Downsampling downsampling,
final long startTB,
final long endTB) throws IOException {
+List linearIndex = new ArrayList<>(numOfLinear);
+for (int i = 0; i < numOfLinear; i++) {
+linearIndex.add(i);
+}
+
+return getSubsetOfMultipleLinearIntValues(indName, id, linearIndex,
downsampling, startTB, endTB);
+}
+
+public List getSubsetOfMultipleLinearIntValues(final String
indName, final String id,
+final List linearIndex,
+final Downsampling downsampling,
+final long startTB,
+final long endTB) throws IOException {
List durationPoints =
DurationUtils.INSTANCE.getDurationPoints(downsampling, startTB, endTB);
List ids = new ArrayList<>();
if (StringUtil.isEmpty(id)) {
@@ -108,9 +121,9 @@ public class MetricQueryService implements Service {
durationPoints.forEach(durationPoint ->
ids.add(durationPoint.getPoint() + Const.ID_SPLIT + id));
}
-IntValues[] multipleLinearIntValues =
getMetricQueryDAO().getMultipleLinearIntValues(indName, downsampling, ids,
numOfLinear, ValueColumnIds.INSTANCE.getValueCName(indName));
+IntValues[] multipleLinearIntValues =
getMetricQueryDAO().getMultipleLinearIntValues(indName, downsampling, ids,
linearIndex, ValueColumnIds.INSTANCE.getValueCName(indName));
-List response = new ArrayList<>(numOfLinear);
+List response = new ArrayList<>(linearIndex.size());
Collections.addAll(response, multipleLinearIntValues);
return response;
}
diff --git
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IMetricsQueryDAO.java
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IMetricsQueryDAO.java
index c10aafa..512ac58 100644
---
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IMetricsQueryDAO.java
+++
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IMetricsQueryDAO.java
@@ -21,8 +21,10 @@ package org.apache.skywalking.oap.server.core.storage.query;
import java.io.IOException;
import java.util.List;
import org.apache.skywalking.oap.server.core.analysis.Downsampling;
-import org.apache.skywalking.oap.server.core.query.entity.*;
-import org.apache.skywalking.oap.server.core.query.sql.*;
+import org.apache.skywalking.oap.server.core.query.entity.IntValues;
+import org.apache.skywalking.oap.server.core.query.entity.Thermodynamic;
+import org.apache.skywalking.oap.server.core.query.sql.Function;
+import org.apache.skywalking.oap.server.core.query.sql.Where;
import org.apache.skywalking.oap.server.core.storage.DAO;
/**
@@ -30,11 +32,15 @@ import org.apache.skywalking.oap.server.core.storage.DAO;
*/
public interface IMetricsQueryDAO extends DAO {
-IntValues getValues(String indName, Downsampling downsampling, long
startTB, long endTB, Where where, String valueCName, Function function) throws
IOException;
+IntValues getValues(String indName, Downsampling downsampling, long
startTB, long endTB, Where where,
+String valueCName, Function function) throws IOException;
-IntValues getLinearIntValues(String indName, Downsampling downsampling,
List ids, String valueCName) throws IOException;
+IntValues
[GitHub] [skywalking] kezhenxu94 merged pull request #4289: Refactor the storage to support `getSubsetOfMultipleLinearIntValues`
kezhenxu94 merged pull request #4289: Refactor the storage to support `getSubsetOfMultipleLinearIntValues` URL: https://github.com/apache/skywalking/pull/4289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4276: Provide AVRO plugin
wu-sheng commented on issue #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#issuecomment-579657894 Any issue or just unstable CI? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4276: Provide AVRO plugin
codecov-io edited a comment on issue #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#issuecomment-576318626 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@82cbbb8`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4276 +/- ## = Coverage ? 26.88% = Files ? 1168 Lines ?25456 Branches ? 3633 = Hits ? 6845 Misses?18005 Partials ? 606 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=footer). Last update [82cbbb8...9a26333](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4276: Provide AVRO plugin
codecov-io edited a comment on issue #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#issuecomment-576318626 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@82cbbb8`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4276 +/- ## = Coverage ? 26.88% = Files ? 1168 Lines ?25457 Branches ? 3634 = Hits ? 6845 Misses?18006 Partials ? 606 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=footer). Last update [82cbbb8...9a26333](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #4289: Refactor the storage to support `getSubsetOfMultipleLinearIntValues`
dmsolr commented on issue #4289: Refactor the storage to support `getSubsetOfMultipleLinearIntValues` URL: https://github.com/apache/skywalking/pull/4289#issuecomment-579646440 > FYI @dmsolr This related to your storage PR. We could make it ready ASAP, it has been broken by other changes several times. I got it. I will finish it ASAP. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4289: Refactor the storage to support `getSubsetOfMultipleLinearIntValues`
wu-sheng commented on issue #4289: Refactor the storage to support `getSubsetOfMultipleLinearIntValues` URL: https://github.com/apache/skywalking/pull/4289#issuecomment-579645531 FYI @dmsolr This related to your storage PR. We could make it ready ASAP, it has been broken by other changes several times. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4289: Refactor the storage to support `getSubsetOfMultipleLinearIntValues`
codecov-io commented on issue #4289: Refactor the storage to support `getSubsetOfMultipleLinearIntValues` URL: https://github.com/apache/skywalking/pull/4289#issuecomment-579644650 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4289?src=pr=h1) Report > Merging [#4289](https://codecov.io/gh/apache/skywalking/pull/4289?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e105a49bf349df3106de63608afbf67422c4abf?src=pr=desc) will **increase** coverage by `0.09%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/skywalking/pull/4289?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4289 +/- ## == + Coverage 26.79% 26.88% +0.09% == Files1162 1162 Lines 2538925398 +9 Branches 3626 3627 +1 == + Hits 6802 6829 +27 + Misses 1798217964 -18 Partials 605 605 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4289?src=pr=tree) | Coverage Δ | | |---|---|---| | [...alking/oap/query/graphql/resolver/MetricQuery.java](https://codecov.io/gh/apache/skywalking/pull/4289/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL01ldHJpY1F1ZXJ5LmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [.../storage/plugin/jdbc/h2/dao/H2MetricsQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4289/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc1F1ZXJ5REFPLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [.../plugin/elasticsearch/query/MetricsQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4289/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTWV0cmljc1F1ZXJ5RXNEQU8uamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...king/oap/server/core/query/MetricQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4289/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvTWV0cmljUXVlcnlTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4289/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `82.35% <0%> (+1.47%)` | :arrow_up: | | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4289/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (+3.37%)` | :arrow_up: | | [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4289/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `36.78% <0%> (+8.04%)` | :arrow_up: | | [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4289/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `85.71% <0%> (+17.85%)` | :arrow_up: | | [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4289/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `77.04% <0%> (+18.03%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4289?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4289?src=pr=footer). Last update [0e105a4...cbf400a](https://codecov.io/gh/apache/skywalking/pull/4289?src=pr=lastupdated). Read the
