date:20200210

[GitHub] [skywalking] Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584514378
 
 
   No, the value couldn't be more than 100%. JS error rate = PV(pv with JS 
error in specified time) / PV (total PV in specified time).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

wu-sheng commented on issue #4337: Set up more strict code styles and fix 
existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584514498
 
 
   > [ERROR] Failed to execute goal on project feign-scenario: Could not 
resolve dependencies for project 
org.apache.skywalking.apm.testcase:feign-scenario:jar:1.0.0: Could not transfer 
artifact io.github.openfeign:feign-core:jar:9.2.0 from/to central 
(https://repo.maven.apache.org/maven2): Failed to transfer file 
https://repo.maven.apache.org/maven2/io/github/openfeign/feign-core/9.2.0/feign-core-9.2.0.jar
 with status code 500 -> [Help 1]
   
   Seems like the Maven central is not stable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] Fine0830 commented on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

Fine0830 commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584514378
 
 
   No, the value couldn't be more than 100%. JS error rate = PV(JS error in 
specified time) / PV (total PV in specified time).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

wu-sheng commented on issue #4337: Set up more strict code styles and fix 
existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584513941
 
 
   Is the agent compiling test failure from one to another because of network 
issue? The CI passed, so I assume the compiling should be fine.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

wu-sheng commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584513115
 
 
   > JS error rate equal PV with JS error in specified time divide total PV in 
specified time.
   
   @Fine0830 As I described, that value could be more than 100% as each PV 
could relate multiple error logs. How to deal with it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] Fine0830 commented on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

Fine0830 commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584511783
 
 
   JS error rate equal PV with JS error in specified time divide total PV in 
specified time.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

wu-sheng commented on issue #4337: Set up more strict code styles and fix 
existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584510004
 
 
   Fail in spring case every time, strange though. :P


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4347: How can I deploy skywalking 6.6 in k8s

2020-02-10 Thread GitBox

wu-sheng commented on issue #4347: How can I deploy skywalking 6.6 in k8s
URL: https://github.com/apache/skywalking/issues/4347#issuecomment-584508743
 
 
   Sorry, this hasn't been provided. @innerpeacez has network issue because of 
the public health situation. Most configurations should be as same as the old 
release for most features.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] JCchenxiang opened a new issue #4347: How can I deploy skywalking 6.6 in k8s

2020-02-10 Thread GitBox

JCchenxiang opened a new issue #4347: How can I deploy skywalking 6.6 in k8s
URL: https://github.com/apache/skywalking/issues/4347
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [x] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
--- I want deploy sw6.6 in k8s Cluster，not use helm,I can't found 
6.6skywalking's image address，can you help me ?
   
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happen?
   If possible, provide a way for reproducing the error. e.g. demo application, 
component version.
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4292: Improve ES query performance

2020-02-10 Thread GitBox

wu-sheng commented on issue #4292: Improve ES query performance
URL: https://github.com/apache/skywalking/pull/4292#issuecomment-584507064
 
 
   > any progress？
   
   The conclusion has been made here. 
https://github.com/apache/skywalking/issues/4291#issuecomment-584063442
This PR would not improve the performance.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] dmsolr commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

2020-02-10 Thread GitBox

dmsolr commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL 
driver downloaded failure.
URL: https://github.com/apache/skywalking/issues/4343#issuecomment-584506426
 
 
   got it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] arugal commented on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

arugal commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584504175
 
 
   Please review @wu-sheng  @Fine0830. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

arugal commented on a change in pull request #4228: Support Browser protocol at 
OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r377471040
 
 

 ##
 File path: 
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/browser/source/BrowserAppErrorLog.java
 ##
 @@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.browser.source;
+
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.skywalking.oap.server.core.source.ScopeDeclaration;
+import org.apache.skywalking.oap.server.core.source.ScopeDefaultColumn;
+import org.apache.skywalking.oap.server.core.source.Source;
+
+import static 
org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.BROWSER_APP_ERROR_LOG;
+import static 
org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.SERVICE_CATALOG_NAME;
+
+/**
+ * @author zhangwei
+ */
+@ScopeDeclaration(id = BROWSER_APP_ERROR_LOG, name = "BrowserAppErrorLog", 
catalog = SERVICE_CATALOG_NAME)
+@ScopeDefaultColumn.VirtualColumnDefinition(fieldName = "entityId", columnName 
= "entity_id", isID = true, type = String.class)
+public class BrowserAppErrorLog extends Source {
+
+@Override
+public int scope() {
+return BROWSER_APP_ERROR_LOG;
+}
+
+@Override
+public String getEntityId() {
+return String.valueOf(id);
+}
+
+@Getter @Setter private int id;
+@Getter private final int count = 1;
 
 Review comment:
   Because the client calls the uncertainty of `onCompleted`, leave it as it is.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch chore/code-style updated (60c597e -> 8c31743)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard 60c597e  Set up more strict code styles and fix existing issues
 add 8c31743  Set up more strict code styles and fix existing issues

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (60c597e)
\
 N -- N -- N   refs/heads/chore/code-style (8c31743)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../apm/agent/core/boot/AgentPackagePath.java  |   4 +-
 .../apm/agent/core/boot/ServiceManager.java|  19 ++--
 .../agent/core/conf/ConfigReadFailedException.java |  25 -
 .../apm/agent/core/context/ContextCarrier.java |  26 --
 .../apm/agent/core/context/ContextManager.java |  15 ++-
 .../agent/core/context/IgnoredTracerContext.java   |   2 +-
 .../core/context/OperationNameFormatService.java   |   6 +-
 .../apm/agent/core/context/RuntimeContext.java |   9 +-
 .../agent/core/context/RuntimeContextSnapshot.java |   6 +-
 .../apm/agent/core/context/TracingContext.java |   4 +-
 .../agent/core/context/ids/DistributedTraceId.java |   3 +-
 .../agent/core/context/ids/GlobalIdGenerator.java  |  15 ++-
 .../agent/core/context/trace/LogDataEntity.java|   9 +-
 .../core/context/trace/StackBasedTracingSpan.java  |  36 ++--
 .../apm/agent/core/context/trace/TraceSegment.java |   8 +-
 .../core/dictionary/EndpointNameDictionary.java|  38 +++-
 .../core/dictionary/NetworkAddressDictionary.java  |  13 ++-
 .../core/profile/ProfileTaskChannelService.java| 102 +++--
 .../core/profile/ProfileTaskExecutionService.java  |  58 ++--
 .../apm/agent/core/remote/GRPCChannel.java |   4 +-
 .../apm/agent/core/remote/GRPCChannelManager.java  |  37 +---
 .../agent/core/remote/GRPCStreamServiceStatus.java |  19 +---
 .../remote/ServiceAndEndpointRegisterClient.java   | 100 +++-
 .../agent/core/remote/StandardChannelBuilder.java  |   2 +-
 .../core/remote/TraceSegmentServiceClient.java |  57 ++--
 .../apm/agent/core/sampling/SamplingService.java   |  32 +++
 .../skywalking/apm/agent/core/util/MethodUtil.java |   6 +-
 .../skywalking/apm/agent/SkyWalkingAgent.java  |   8 +-
 ...ProfileVerificationITCase.profileAnayzation.yml |   2 +-
 29 files changed, 313 insertions(+), 352 deletions(-)
 delete mode 100644 
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/ConfigReadFailedException.java

[GitHub] [skywalking] wu-sheng commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

2020-02-10 Thread GitBox

wu-sheng commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL 
driver downloaded failure.
URL: https://github.com/apache/skywalking/issues/4343#issuecomment-584500117
 
 
   @dmsolr The download link has been fixed, the issue is why the test passed 
when the download fails


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] dmsolr commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

2020-02-10 Thread GitBox

dmsolr commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL 
driver downloaded failure.
URL: https://github.com/apache/skywalking/issues/4343#issuecomment-584495052
 
 
   @kezhenxu94 , if you don't have time, I can submit a PR to pre-install the 
driver in e2e-container image.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch chore/code-style updated (5ddc90b -> 60c597e)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard 5ddc90b  Set up more strict code style rules
 add 60c597e  Set up more strict code styles and fix existing issues

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (5ddc90b)
\
 N -- N -- N   refs/heads/chore/code-style (60c597e)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .asf.yaml  |1 +
 .github/workflows/ci-it.yaml   |5 +-
 apm-webapp/src/main/resources/application.yml  |2 +-
 appveyor.yml   |   12 +-
 codeStyle.xml  |   34 +-
 .../envoy/examples/metrics/docker-compose.yaml |   10 +-
 docs/en/setup/istio/yaml/skywalkingadapter.yml |2 +-
 install/kubernetes/helm/skywalking/Chart.yaml  |   10 +-
 .../charts/elasticsearch/templates/deployment.yaml |   68 +-
 .../charts/elasticsearch/templates/ingress.yaml|   74 +-
 .../elasticsearch/templates/serviceaccount.yaml|6 +-
 .../skywalking/charts/elasticsearch/values.yaml|8 +-
 .../helm/skywalking/templates/es-init.job.yaml |   28 +-
 .../templates/istio-adapter/adapter.yaml   |4 +-
 .../templates/istio-adapter/handler.yaml   |4 +-
 .../templates/istio-adapter/instance.yaml  |4 +-
 .../skywalking/templates/istio-adapter/rule.yaml   |4 +-
 .../helm/skywalking/templates/oap-clusterrole.yaml |   16 +-
 .../templates/oap-clusterrolebinding.yaml  |   10 +-
 .../helm/skywalking/templates/oap-deployment.yaml  |  156 +--
 .../helm/skywalking/templates/oap-role.yaml|4 +-
 .../helm/skywalking/templates/oap-rolebinding.yaml |4 +-
 .../helm/skywalking/templates/oap-svc.yaml |8 +-
 install/kubernetes/helm/skywalking/values.yaml |   16 +-
 .../src/main/resources/alarm-settings.yml  |   24 +-
 .../src/test/resources/application.yml |2 +-
 .../src/test/resources/application.yml |6 +-
 .../server-receiver-plugin/receiver-proto/pom.xml  |   11 +-
 .../src/main/proto/envoy/api/v2/core/address.proto |  157 +--
 .../src/main/proto/envoy/api/v2/core/base.proto|  274 ++---
 .../proto/envoy/data/accesslog/v2/accesslog.proto  |  524 +-
 .../proto/envoy/service/accesslog/v2/als.proto |   72 +-
 .../envoy/service/metrics/v2/metrics_service.proto |   26 +-
 .../src/main/proto/envoy/type/percent.proto|   51 +-
 .../src/main/proto/gogoproto/gogo.proto|  156 +--
 .../src/main/proto/google/api/annotations.proto|4 +-
 .../src/main/proto/google/api/http.proto   |  105 +-
 .../src/main/proto/google/rpc/code.proto   |  305 +++---
 .../src/main/proto/google/rpc/error_details.proto  |  201 ++--
 .../src/main/proto/google/rpc/status.proto |   19 +-
 .../src/main/proto/istio/istio-metric.proto|3 +-
 .../src/main/proto/jaeger/collector.proto  |   37 +-
 .../src/main/proto/jaeger/model.proto  |  138 ++-
 .../mixer/adapter/model/v1beta1/extensions.proto   |3 +-
 .../proto/mixer/adapter/model/v1beta1/report.proto |5 +-
 .../src/main/proto/policy/v1beta1/type.proto   |2 +-
 .../src/main/proto/policy/v1beta1/value_type.proto |2 +-
 .../proto/prometheus/client_model/metrics.proto|   62 +-
 .../protoc-gen-swagger/options/annotations.proto   |   50 +-
 .../protoc-gen-swagger/options/openapiv2.proto |  450 
 .../src/main/proto/validate/validate.proto |   88 +-
 test/e2e/e2e-mysql/src/docker/application.yml  |   52 +-
 .../e2e-profile/e2e-profile-test-runner/pom.xml|2 +-
 .../src/docker/rc.d/rc0-prepare.sh |3 -
 .../src/main/proto/register/Register.proto |2 +-
 .../istio/skywalking.config.pb.html|   13 +-
 .../proto/service-mesh-probe/service-mesh.proto|2 +-
 .../src/main/resources/expect-data.yaml|  108 +-
 .../src/main/resources/sample-data.yaml|   88 +-
 .../activemq-scenario/config/expectedData.yaml |  114 +-
 .../scenarios/activemq-scenario/configuration.yml  |6 +-
 .../config/expectedData.yaml   |  932 -
 .../configuration.yml

[GitHub] [skywalking] jadezhong commented on issue #4292: Improve ES query performance

2020-02-10 Thread GitBox

jadezhong commented on issue #4292: Improve ES query performance
URL: https://github.com/apache/skywalking/pull/4292#issuecomment-584486603
 
 
   any progress？


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

codecov-io edited a comment on issue #4337: Set up more strict code styles and 
fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583853097
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=h1) 
Report
   > Merging 
[#4337](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/fa526e52279d553152a1c8ca8dbeb9158fad6296?src=pr&el=desc)
 will **decrease** coverage by `0.65%`.
   > The diff coverage is `33.98%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4337/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4337  +/-   ##
   ==
   - Coverage   26.93%   26.27%   -0.66% 
   ==
 Files1177 1177  
 Lines   2583626698 +862 
 Branches 3688 3680   -8 
   ==
   + Hits 6958 7014  +56 
   - Misses  1825819067 +809 
   + Partials  620  617   -3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...he/skywalking/apm/agent/core/os/ProcessorUtil.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvUHJvY2Vzc29yVXRpbC5qYXZh)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[...m/toolkit/log/log4j/v1/x/TraceIdPatternLayout.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L1RyYWNlSWRQYXR0ZXJuTGF5b3V0LmphdmE=)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==)
 | `69.23% <ø> (ø)` | :arrow_up: |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[...ing/apm/agent/core/plugin/DynamicPluginLoader.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0R5bmFtaWNQbHVnaW5Mb2FkZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...e/skywalking/apm/agent/core/jvm/gc/G1GCModule.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL0cxR0NNb2R1bGUuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...agent/core/plugin/match/MethodAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL01ldGhvZEFubm90YXRpb25NYXRjaC5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=)
 | `0% <ø> (ø)` | :arrow_up: |
   | ... and [1121 
more](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)

[skywalking] branch grpc_alarm updated (afa8e98 -> 17e5b33)

2020-02-10 Thread tanjian

This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a change to branch grpc_alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from afa8e98  Merge branch 'master' into grpc_alarm
 add 17e5b33  fix ci.

No new revisions were added by this update.

Summary of changes:
 .../exporter/provider/grpc/GRPCExporterTest.java   | 24 +++---
 1 file changed, 12 insertions(+), 12 deletions(-)

[skywalking] branch chore/code-style updated (6331adb -> 5ddc90b)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard 6331adb  Set up more strict code style rules
 add 5ddc90b  Set up more strict code style rules

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (6331adb)
\
 N -- N -- N   refs/heads/chore/code-style (5ddc90b)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../oap/server/storage/plugin/jdbc/mysql/MySQLStorageProvider.java | 3 ++-
 .../src/main/java/org/apache/skywalking/e2e/profile/ProfileClient.java | 2 --
 .../test/java/org/apache/skywalking/e2e/ProfileVerificationITCase.java | 3 ---
 3 files changed, 2 insertions(+), 6 deletions(-)

[skywalking] branch chore/code-style updated (bd3e522 -> 6331adb)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard bd3e522  Set up more strict code style rules
 add 6331adb  Set up more strict code style rules

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (bd3e522)
\
 N -- N -- N   refs/heads/chore/code-style (6331adb)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../skywalking/apm/agent/SkyWalkingAgent.java  | 47 +++-
 .../core/profile/analyze/ProfileAnalyzer.java  | 15 ++--
 .../core/profile/analyze/ProfileStackAnalyze.java  |  7 +-
 .../profile/analyze/ProfileStackAnalyzeHolder.java |  1 +
 .../core/profile/analyze/ProfileStackData.java |  1 +
 .../analyze/ProfileStackElementMatcher.java|  1 +
 .../oap/query/graphql/resolver/ProfileQuery.java   |  2 -
 .../StorageModuleElasticsearch7Provider.java   |  4 -
 .../query/ProfileThreadSnapshotQueryEs7DAO.java|  1 +
 .../h2/dao/H2ProfileThreadSnapshotQueryDAO.java| 15 ++--
 .../skywalking/e2e/profile/ProfileClient.java  | 13 +++-
 .../skywalking/e2e/ProfileVerificationITCase.java  | 85 ++
 12 files changed, 100 insertions(+), 92 deletions(-)

[skywalking] branch grpc_alarm updated (c9d3ef4 -> afa8e98)

2020-02-10 Thread tanjian

This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a change to branch grpc_alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from c9d3ef4  remove author anonatation.
 add fa526e5  Provide profile analyze query (#4335)
 add afa8e98  Merge branch 'master' into grpc_alarm

No new revisions were added by this update.

Summary of changes:
 .../oap/server/core/CoreModuleConfig.java  |  10 +
 .../oap/server/core/CoreModuleProvider.java|   2 +-
 .../core/profile/analyze/ProfileAnalyzer.java  | 133 ++-
 .../server/core/query/ProfileTaskQueryService.java |  12 +-
 .../profile/IProfileThreadSnapshotQueryDAO.java|  20 ++
 .../server/core/profile/ProfileAnalyzerTest.java   |   4 +-
 .../{bean => analyze}/ProfileStackAnalyze.java |  17 +-
 .../ProfileStackAnalyzeHolder.java |   2 +-
 .../{bean => analyze}/ProfileStackData.java|   3 +-
 .../ProfileStackElementMatcher.java|   2 +-
 .../oap/query/graphql/resolver/ProfileQuery.java   |   7 +-
 .../query/ProfileThreadSnapshotQueryEsDAO.java |  57 +++
 .../StorageModuleElasticsearch7Provider.java   |   2 +-
 .../query/ProfileThreadSnapshotQueryEs7DAO.java|  47 +++
 .../h2/dao/H2ProfileThreadSnapshotQueryDAO.java|  77 +++-
 .../plugin/jdbc/mysql/MySQLStorageProvider.java|   2 +
 test/e2e/e2e-mysql/src/docker/rc.d/rc0-prepare.sh  |   4 +-
 .../skywalking/e2e/profile/TestController.java |   4 +-
 .../src/docker/rc.d/rc0-prepare.sh |   4 +-
 .../skywalking/e2e/profile/ProfileClient.java  |  26 +-
 .../e2e/profile/query/ProfileAnalyzation.java  |  81 +
 ...atcher.java => ProfileStackElementMatcher.java} |  28 +-
 ...ksMatcher.java => ProfileStackTreeMatcher.java} |  26 +-
 ...ProfileVerificationITCase.profileAnayzation.yml | 389 +
 .../src/main/resources/getProfileAnalyzation.gql}  |  21 +-
 .../skywalking/e2e/ProfileVerificationITCase.java  |  50 ++-
 26 files changed, 937 insertions(+), 93 deletions(-)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackAnalyze.java (68%)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackAnalyzeHolder.java (93%)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackData.java (91%)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackElementMatcher.java (98%)
 create mode 100644 
oap-server/server-storage-plugin/storage-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch7/query/ProfileThreadSnapshotQueryEs7DAO.java
 create mode 100644 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/java/org/apache/skywalking/e2e/profile/query/ProfileAnalyzation.java
 copy 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/java/org/apache/skywalking/e2e/profile/query/{ProfileTaskLogMatcher.java
 => ProfileStackElementMatcher.java} (60%)
 copy 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/java/org/apache/skywalking/e2e/profile/query/{ProfilesTasksMatcher.java
 => ProfileStackTreeMatcher.java} (67%)
 create mode 100644 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/resources/expected-data/org.apache.skywalking.e2e.ProfileVerificationITCase.profileAnayzation.yml
 copy test/e2e/{e2e-base/src/main/resources/endpoints.gql => 
e2e-profile/e2e-profile-test-runner/src/main/resources/getProfileAnalyzation.gql}
 (67%)

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4327: Tag annotation supports returned expression

2020-02-10 Thread GitBox

wu-sheng commented on a change in pull request #4327: Tag annotation supports 
returned expression
URL: https://github.com/apache/skywalking/pull/4327#discussion_r377433128
 
 

 ##
 File path: 
apm-sniffer/apm-toolkit-activation/apm-toolkit-trace-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/trace/TagAnnotationMethodInterceptor.java
 ##
 @@ -75,6 +74,25 @@ public Object afterMethod(
 final Object[] allArguments,
 final Class[] argumentsTypes,
 final Object ret) {
+if (ret == null || !ContextManager.isActive()) {
+ContextManager.stopSpan();
+return ret;
 
 Review comment:
   Move these two lines into the final block.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4327: Tag annotation supports returned expression

2020-02-10 Thread GitBox

wu-sheng commented on a change in pull request #4327: Tag annotation supports 
returned expression
URL: https://github.com/apache/skywalking/pull/4327#discussion_r37741
 
 

 ##
 File path: 
apm-sniffer/apm-toolkit-activation/apm-toolkit-trace-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/util/TagUtil.java
 ##
 @@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.util;
+
+import java.util.Map;
+
+import org.apache.skywalking.apm.agent.core.context.tag.StringTag;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import org.apache.skywalking.apm.agent.core.util.CustomizeExpression;
+import org.apache.skywalking.apm.toolkit.trace.Tag;
+
+public class TagUtil {
+public static void tagParamsSpan(final AbstractSpan span, final 
Map context,
+ final Tag tag) {
+new StringTag(tag.key()).set(span, 
CustomizeExpression.parseExpression(tag.value(), context));
+}
+
+public static void tagReturnSpanSpan(final AbstractSpan span, final 
Map context,
+ final Tag tag) {
+new StringTag(tag.key()).set(span, 
CustomizeExpression.parseReturnExpression(tag.value(), context));
+}
+
+public static Boolean isReturnTag(String expression) {
+String[] es = expression.split("\\.");
+return es.length == 2 && "returnedObj".equals(es[0]);
 
 Review comment:
   `returnedObj` has a specific meaning, should be adding into the document. 
https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Application-toolkit-trace.md


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] hanahmily commented on issue #4291: Improve ES query performance

2020-02-10 Thread GitBox

hanahmily commented on issue #4291: Improve ES query performance
URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584456508
 
 
   Just some tips for us, some queries still need "query context" instead of
   "filter context", for example, endpoint_inventory whose name should support
   searching.
   It's my opinion that we should apply "filter context" to those queries
   really need it.
   
   aderm  于2020年2月11日周二 上午7:50写道：
   
   > Ok, no problem
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   
   
   -- 
   Hongtao Gao
   
   Apache SkyWalking && Apache ShardingSphere
   Twitter, @hanahmily
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch chore/code-style updated (bd67f14 -> bd3e522)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard bd67f14  Set up more strict code style rules
 add fa526e5  Provide profile analyze query (#4335)
 add bd3e522  Set up more strict code style rules

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (bd67f14)
\
 N -- N -- N   refs/heads/chore/code-style (bd3e522)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 dist-material/application.yml  |  88 ++---
 .../src/main/resources/application.yml |  46 +--
 .../oap/server/core/CoreModuleConfig.java  |  10 +
 .../oap/server/core/CoreModuleProvider.java|   2 +-
 .../core/profile/analyze/ProfileAnalyzer.java  | 144 +++-
 .../server/core/query/ProfileTaskQueryService.java |  12 +-
 .../profile/IProfileThreadSnapshotQueryDAO.java|  20 ++
 .../server/core/profile/ProfileAnalyzerTest.java   |   7 +-
 .../{bean => analyze}/ProfileStackAnalyze.java |  19 +-
 .../ProfileStackAnalyzeHolder.java |   4 +-
 .../{bean => analyze}/ProfileStackData.java|   7 +-
 .../ProfileStackElementMatcher.java|   5 +-
 .../oap/query/graphql/resolver/ProfileQuery.java   |  15 +-
 .../query/ProfileThreadSnapshotQueryEsDAO.java |  57 +++
 .../StorageModuleElasticsearch7Provider.java   |  30 +-
 .../query/ProfileThreadSnapshotQueryEs7DAO.java|  47 +++
 .../h2/dao/H2ProfileThreadSnapshotQueryDAO.java|  77 +++-
 .../plugin/jdbc/mysql/MySQLStorageProvider.java|   2 +
 test/e2e-mesh/e2e-istio/scripts/compile_build.sh   |   2 +-
 test/e2e/e2e-mysql/src/docker/rc.d/rc0-prepare.sh  |   4 +-
 .../skywalking/e2e/profile/TestController.java |   4 +-
 .../src/docker/rc.d/rc0-prepare.sh |   4 +-
 .../skywalking/e2e/profile/ProfileClient.java  |  73 ++--
 .../e2e/profile/query/ProfileAnalyzation.java  |  81 +
 ...atcher.java => ProfileStackElementMatcher.java} |  25 +-
 ...ksMatcher.java => ProfileStackTreeMatcher.java} |  24 +-
 ...ProfileVerificationITCase.profileAnayzation.yml | 389 +
 .../src/main/resources/getProfileAnalyzation.gql}  |  21 +-
 .../skywalking/e2e/ProfileVerificationITCase.java  | 113 --
 29 files changed, 1112 insertions(+), 220 deletions(-)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackAnalyze.java (68%)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackAnalyzeHolder.java (93%)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackData.java (91%)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackElementMatcher.java (97%)
 create mode 100644 
oap-server/server-storage-plugin/storage-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch7/query/ProfileThreadSnapshotQueryEs7DAO.java
 create mode 100644 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/java/org/apache/skywalking/e2e/profile/query/ProfileAnalyzation.java
 copy 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/java/org/apache/skywalking/e2e/profile/query/{ProfileTaskLogMatcher.java
 => ProfileStackElementMatcher.java} (60%)
 copy 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/java/org/apache/skywalking/e2e/profile/query/{ProfilesTasksMatcher.java
 => ProfileStackTreeMatcher.java} (69%)
 create mode 100644 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/resources/expected-data/org.apache.skywalking.e2e.ProfileVerificationITCase.profileAnayzation.yml
 copy test/e2e/{e2e-base/src/main/resources/endpoints.gql => 
e2e-profile/e2e-profile-test-runner/src/main/resources/getProfileAnalyzation.gql}
 (67%)

[GitHub] [skywalking] wu-sheng commented on issue #4104: [FEATURE] Performance profile at method level in production environment

2020-02-10 Thread GitBox

wu-sheng commented on issue #4104: [FEATURE] Performance profile at method 
level in production environment
URL: https://github.com/apache/skywalking/issues/4104#issuecomment-584452284
 
 
   All backend related PRs have been merged, and e2e tests passed. @mrproliu 
Next step, let's provide a local test image with data to the UI team(@Fine0830 
). Notice, the TTL should be set as long as possible to avoid the profile data 
being deleted.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

wu-sheng commented on issue #4337: Set up more strict code styles and fix 
existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584449882
 
 
   Merged, and conflicts showing up. Please fix, let's make this PR merged as 
next to avoid endless conflicts.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch master updated (8c96fd4 -> fa526e5)

2020-02-10 Thread wusheng

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 8c96fd4  Update elasticsearch-7.x agent support version. (#4340)
 add fa526e5  Provide profile analyze query (#4335)

No new revisions were added by this update.

Summary of changes:
 .../oap/server/core/CoreModuleConfig.java  |  10 +
 .../oap/server/core/CoreModuleProvider.java|   2 +-
 .../core/profile/analyze/ProfileAnalyzer.java  | 133 ++-
 .../server/core/query/ProfileTaskQueryService.java |  12 +-
 .../profile/IProfileThreadSnapshotQueryDAO.java|  20 ++
 .../server/core/profile/ProfileAnalyzerTest.java   |   4 +-
 .../{bean => analyze}/ProfileStackAnalyze.java |  17 +-
 .../ProfileStackAnalyzeHolder.java |   2 +-
 .../{bean => analyze}/ProfileStackData.java|   3 +-
 .../ProfileStackElementMatcher.java|   2 +-
 .../oap/query/graphql/resolver/ProfileQuery.java   |   7 +-
 .../query/ProfileThreadSnapshotQueryEsDAO.java |  57 +++
 .../StorageModuleElasticsearch7Provider.java   |   2 +-
 .../query/ProfileThreadSnapshotQueryEs7DAO.java|  47 +++
 .../h2/dao/H2ProfileThreadSnapshotQueryDAO.java|  77 +++-
 .../plugin/jdbc/mysql/MySQLStorageProvider.java|   2 +
 test/e2e/e2e-mysql/src/docker/rc.d/rc0-prepare.sh  |   4 +-
 .../skywalking/e2e/profile/TestController.java |   4 +-
 .../src/docker/rc.d/rc0-prepare.sh |   4 +-
 .../skywalking/e2e/profile/ProfileClient.java  |  26 +-
 .../e2e/profile/query/ProfileAnalyzation.java  |  81 +
 ...atcher.java => ProfileStackElementMatcher.java} |  28 +-
 ...ksMatcher.java => ProfileStackTreeMatcher.java} |  26 +-
 ...ProfileVerificationITCase.profileAnayzation.yml | 389 +
 .../src/main/resources/getProfileAnalyzation.gql}  |  21 +-
 .../skywalking/e2e/ProfileVerificationITCase.java  |  50 ++-
 26 files changed, 937 insertions(+), 93 deletions(-)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackAnalyze.java (68%)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackAnalyzeHolder.java (93%)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackData.java (91%)
 rename 
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/profile/{bean
 => analyze}/ProfileStackElementMatcher.java (98%)
 create mode 100644 
oap-server/server-storage-plugin/storage-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch7/query/ProfileThreadSnapshotQueryEs7DAO.java
 create mode 100644 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/java/org/apache/skywalking/e2e/profile/query/ProfileAnalyzation.java
 copy 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/java/org/apache/skywalking/e2e/profile/query/{ProfileTaskLogMatcher.java
 => ProfileStackElementMatcher.java} (60%)
 copy 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/java/org/apache/skywalking/e2e/profile/query/{ProfilesTasksMatcher.java
 => ProfileStackTreeMatcher.java} (67%)
 create mode 100644 
test/e2e/e2e-profile/e2e-profile-test-runner/src/main/resources/expected-data/org.apache.skywalking.e2e.ProfileVerificationITCase.profileAnayzation.yml
 copy test/e2e/{e2e-base/src/main/resources/endpoints.gql => 
e2e-profile/e2e-profile-test-runner/src/main/resources/getProfileAnalyzation.gql}
 (67%)

[GitHub] [skywalking] wu-sheng merged pull request #4335: Provide profile analyze query

2020-02-10 Thread GitBox

wu-sheng merged pull request #4335: Provide profile analyze query
URL: https://github.com/apache/skywalking/pull/4335
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

wu-sheng commented on issue #4337: Set up more strict code styles and fix 
existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584449406
 
 
   Don't worry about profile e2e, it has a code issue which has been fixed in 
#4335. Waiting CI confirmation to merge it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

kezhenxu94 edited a comment on issue #4337: Set up more strict code styles and 
fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584448316
 
 
   > 2790 files changed. :P How this could be review. Haha.
   
   I can't even review myself 😢 , that's why I configure an incremental check 
before https://github.com/apache/skywalking/pull/4337#issuecomment-583848327
   
   FYI, I just configure the rules and hit `Command+Option+L`, use regular 
expression to remove `@author`s, they effect mostly in just JavaDoc and 
`import`s, so as long as the tests passed, it should be generally OK then
   
   I'm Checking the failure of E2E


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

kezhenxu94 edited a comment on issue #4337: Set up more strict code styles and 
fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584448316
 
 
   > 2790 files changed. :P How this could be review. Haha.
   
   I can't even review myself 😢 , that's why I configure an incremental check 
before https://github.com/apache/skywalking/pull/4337#issuecomment-583848327
   
   FYI, I just configure the rules and hit `Command+Option+L`, use regular 
expression to remove `@author`s, they effect mostly in just JavaDoc and 
`import`s, so as long as the tests passed, it should be generally OK then
   
   > Checking the failure of E2E


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

kezhenxu94 commented on issue #4337: Set up more strict code styles and fix 
existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584448316
 
 
   > 2790 files changed. :P How this could be review. Haha.
   
   I can't even review myself 😢 , that's why I configure an incremental check 
before https://github.com/apache/skywalking/pull/4337#issuecomment-583848327
   
   FYI, I just configure the rules and hit `Command+Option+L`, use regular 
expression to remove `@author`s, they effect mostly in just JavaDoc and 
`import`s, so as long as the tests passed, it should be generally OK then


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch grpc_alarm updated (194df3e -> c9d3ef4)

2020-02-10 Thread tanjian

This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a change to branch grpc_alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 194df3e  finish logical.
 add c9d3ef4  remove author anonatation.

No new revisions were added by this update.

Summary of changes:
 .../oap/server/core/alarm/provider/grpc/GRPCAlarmSetting.java  | 3 ---
 .../skywalking/oap/server/core/alarm/provider/grpc/GRPCCallback.java   | 2 --
 .../oap/server/core/alarm/provider/grpc/GRPChookCallbackTest.java  | 3 ---
 .../org/apache/skywalking/oap/server/core/exporter/ExportData.java | 3 ---
 .../org/apache/skywalking/oap/server/core/exporter/ExportStatus.java   | 3 ---
 5 files changed, 14 deletions(-)

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

wu-sheng commented on issue #4337: Set up more strict code styles and fix 
existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584442794
 
 
   2790 files changed. :P How this could be review.  Haha.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

codecov-io edited a comment on issue #4337: Set up more strict code styles and 
fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583853097
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=h1) 
Report
   > Merging 
[#4337](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/8c96fd49ddecb90bb8c98674b378c0d24483c5a7?src=pr&el=desc)
 will **decrease** coverage by `0.6%`.
   > The diff coverage is `34.54%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4337/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4337  +/-   ##
   ==
   - Coverage   27.05%   26.45%   -0.61% 
   ==
 Files1176 1176  
 Lines   2571826586 +868 
 Branches 3675 3667   -8 
   ==
   + Hits 6959 7033  +74 
   - Misses  1813918941 +802 
   + Partials  620  612   -8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...he/skywalking/apm/agent/core/os/ProcessorUtil.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvUHJvY2Vzc29yVXRpbC5qYXZh)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[...m/toolkit/log/log4j/v1/x/TraceIdPatternLayout.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L1RyYWNlSWRQYXR0ZXJuTGF5b3V0LmphdmE=)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==)
 | `69.23% <ø> (ø)` | :arrow_up: |
   | 
[.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[...ing/apm/agent/core/plugin/DynamicPluginLoader.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0R5bmFtaWNQbHVnaW5Mb2FkZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...e/skywalking/apm/agent/core/jvm/gc/G1GCModule.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL0cxR0NNb2R1bGUuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...agent/core/plugin/match/MethodAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL01ldGhvZEFubm90YXRpb25NYXRjaC5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=)
 | `0% <ø> (ø)` | :arrow_up: |
   | ... and [1120 
more](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   >

[GitHub] [skywalking] wu-sheng commented on issue #4344: supprt gRPC alarm hook.

2020-02-10 Thread GitBox

wu-sheng commented on issue #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#issuecomment-584442704
 
 
   Yes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-10 Thread GitBox

wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#discussion_r377411742
 
 

 ##
 File path: 
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/exporter/ExportData.java
 ##
 @@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.exporter;
+
+import lombok.Getter;
+import org.apache.skywalking.oap.server.core.analysis.metrics.Metrics;
+import org.apache.skywalking.oap.server.core.analysis.metrics.MetricsMetaInfo;
+
+/**
+ * @author jian.tan
 
 Review comment:
   Don't add `@author`, all these will be removed by @kezhenxu94 's PR once for 
all.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] JaredTan95 commented on issue #4344: supprt gRPC alarm hook.

2020-02-10 Thread GitBox

JaredTan95 commented on issue #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#issuecomment-584439653
 
 
   Acording to https://github.com/apache/skywalking/pull/4337, should remove 
`@author` anonatation, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] cui-liqiang closed pull request #4346: some code style

2020-02-10 Thread GitBox

cui-liqiang closed pull request #4346: some code style
URL: https://github.com/apache/skywalking/pull/4346
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch grpc_alarm updated (b7605f7 -> 194df3e)

2020-02-10 Thread tanjian

This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a change to branch grpc_alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from b7605f7  Merge branch 'master' into grpc_alarm
 add 194df3e  finish logical.

No new revisions were added by this update.

Summary of changes:
 .../exporter/provider/grpc/GRPCExporter.java   | 53 ++
 .../core/alarm/provider/grpc/GRPCCallback.java | 33 --
 .../alarm/provider/grpc/AlarmMockReceiver.java |  1 -
 .../{ExporterModule.java => ExportData.java}   | 23 +-
 .../oap/server/core/exporter/ExportStatus.java | 18 
 5 files changed, 72 insertions(+), 56 deletions(-)
 copy 
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/exporter/{ExporterModule.java
 => ExportData.java} (68%)
 copy 
test/e2e/e2e-base/src/main/java/org/apache/skywalking/e2e/topo/TopoResponse.java
 => 
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/exporter/ExportStatus.java
 (77%)

[GitHub] [skywalking] cui-liqiang opened a new pull request #4346: some code style

2020-02-10 Thread GitBox

cui-liqiang opened a new pull request #4346: some code style
URL: https://github.com/apache/skywalking/pull/4346
 
 
   Signed-off-by: liqiang.clq 
   
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   None of above, just some code style changes mainly in three patterns:
   1. Change "if() return true; return false" to "return 
;".
   2. Change "while() return xxx" to "if() return xxx".
   3. Remove "public" method modifier in interface definition.
   
   Please let me know if these patterns are intentional.
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aderm commented on issue #4291: Improve ES query performance

2020-02-10 Thread GitBox

aderm commented on issue #4291: Improve ES query performance
URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584415398
 
 
   Ok, no problem


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4279: Micrometer Registry support for Skywalking Metrics

2020-02-10 Thread GitBox

wu-sheng commented on issue #4279: Micrometer Registry support for Skywalking 
Metrics
URL: https://github.com/apache/skywalking/issues/4279#issuecomment-584175136
 
 
   I think the metrics receiver is the gap. SkyWalking is keeping making sure 
to understand the data, including all metrics, so it does accept the agent, 
Istio and Envoy telemetry formats, rather than like Prometheus receiving the 
data and focusing on data type only. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin

2020-02-10 Thread GitBox

wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-584171718
 
 
   #4335 is going to be merged today. There would be the last two new storage 
methods introduced.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] krmeda commented on issue #4279: Micrometer Registry support for Skywalking Metrics

2020-02-10 Thread GitBox

krmeda commented on issue #4279: Micrometer Registry support for Skywalking 
Metrics
URL: https://github.com/apache/skywalking/issues/4279#issuecomment-584171870
 
 
   Idea was when the skywalking java agent is enabled/loaded it registers the 
micrometer-skywalking adapter and then the skywalking agent already uses its 
implementation to send it to the skywalking server. My library/application has 
no knowledge where the metrics are going... it is only producing it... 
   
   Similar to Slf4j... 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4279: Micrometer Registry support for Skywalking Metrics

2020-02-10 Thread GitBox

wu-sheng commented on issue #4279: Micrometer Registry support for Skywalking 
Metrics
URL: https://github.com/apache/skywalking/issues/4279#issuecomment-584164341
 
 
   Today, SkyWalking doesn't have custom metrics, and here is the protocol, 
https://github.com/apache/skywalking-data-collect-protocol
   
   How do you plan to send the metrics?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] JohnNiang commented on a change in pull request #4344: [WIP]supprt gRPC alarm hook.

2020-02-10 Thread GitBox

JohnNiang commented on a change in pull request #4344: [WIP]supprt gRPC alarm 
hook.
URL: https://github.com/apache/skywalking/pull/4344#discussion_r377105587
 
 

 ##
 File path: docs/en/setup/backend/backend-alarm.md
 ##
 @@ -113,6 +114,24 @@ Example as following
 }]
 ```
 
+## gRPCHook
+The alarm message will send through remote gRPC method by `Protobuf` content 
type. 
+The message format with following key information which are defined in 
`oap-server/server-alarm-plugin/src/main/proto/alarm-hook.proto`.
+
+Example as following
+```text
 
 Review comment:
   This code language  could be `protobuf`. It will result as following:
   
   ```protobuf
   message AlarmMessage {
   int64 scopeId = 1;
   string scope = 2;
   string name = 3;
   int64 id0 = 4;
   int64 id1 = 5;
   string ruleName = 6;
   string alarmMessage = 7;
   int64 startTime = 8;
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch chore/code-style updated (7d351b3 -> bd67f14)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard 7d351b3  Set up more strict code style rules
 add bd67f14  Set up more strict code style rules

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (7d351b3)
\
 N -- N -- N   refs/heads/chore/code-style (bd67f14)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../apm/testcase/rabbitmq/controller/CaseController.java  | 12 +---
 .../skywalking/apm/testcase/spring/async/CaseServlet.java |  2 +-
 .../apm/testcase/spring/async/HealthCheckServlet.java |  2 +-
 .../skywalking/apm/testcase/spring/async/HttpBean.java| 15 ---
 .../zookeeper/controller/ZookeeperController.java |  6 ++
 5 files changed, 21 insertions(+), 16 deletions(-)

[GitHub] [skywalking] wu-sheng commented on issue #4291: Improve ES query performance

2020-02-10 Thread GitBox

wu-sheng commented on issue #4291: Improve ES query performance
URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584148823
 
 
   @aderm Could you work on another pull request to implement #4236's idea? 
That PR seems stopped, but the idea and report seem useful. Could you take a 
look?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aderm closed pull request #4292: Improve ES query performance

2020-02-10 Thread GitBox

aderm closed pull request #4292: Improve ES query performance
URL: https://github.com/apache/skywalking/pull/4292
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] krmeda commented on issue #4279: Micrometer Registry support for Skywalking Metrics

2020-02-10 Thread GitBox

krmeda commented on issue #4279: Micrometer Registry support for Skywalking 
Metrics
URL: https://github.com/apache/skywalking/issues/4279#issuecomment-584140882
 
 
   My proposal is to write an adapter for micrometer which plugs into 
micrometer end and publish metrics using skywalking support. It allows end 
users who create custom metrics in an application/library to express that 
metric in micrometer format and not care about which monitoring tool is loaded 
in order to surface those metrics. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aderm commented on issue #4292: Improve ES query performance

2020-02-10 Thread GitBox

aderm commented on issue #4292: Improve ES query performance
URL: https://github.com/apache/skywalking/pull/4292#issuecomment-584141118
 
 
   Reference #4291, so closed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aderm commented on issue #4291: Improve ES query performance

2020-02-10 Thread GitBox

aderm commented on issue #4291: Improve ES query performance
URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584140193
 
 
   agree, It looks like this at the moment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aderm closed issue #4291: Improve ES query performance

2020-02-10 Thread GitBox

aderm closed issue #4291: Improve ES query performance
URL: https://github.com/apache/skywalking/issues/4291
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4345: topology: That 3 servers point to the same mysql at the same time

2020-02-10 Thread GitBox

wu-sheng commented on issue #4345: topology: That 3 servers point to the same 
mysql at the same time
URL: https://github.com/apache/skywalking/issues/4345#issuecomment-584131432
 
 
   I think currently you can't, unless you use the different hostnames to 
access the local database.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng closed issue #4345: topology: That 3 servers point to the same mysql at the same time

2020-02-10 Thread GitBox

wu-sheng closed issue #4345: topology: That 3 servers point to the same mysql 
at the same time
URL: https://github.com/apache/skywalking/issues/4345
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] fadeli1 opened a new issue #4345: That 3 servers point to the same mysql at the same time

2020-02-10 Thread GitBox

fadeli1 opened a new issue #4345: That 3 servers point to the same mysql at the 
same time
URL: https://github.com/apache/skywalking/issues/4345
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [x] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   
   I have 3 servers with the following structure:
   10.1.0.19-> agent-> ofbiz1-> 127.0.0.1mysql
   10.1.0.19-> agent-> ofbiz2-> 127.0.0.1mysql
   10.1.0.11-> agent-> ofbiz-> 127.0.0.1mysql
   
   Displayed in topology as:
   10.1.0.19-> 127.0.0.1 mysql
   10.1.0.19-> 127.0.0.1 mysql
   10.1.0.11-> 127.0.0.1 mysql
   That 3 servers point to the same mysql at the same time
   
   How can I make it distinguish between mysql in 10.1.0.19 and mysql in 
10.1.0.11?
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   SkyWalking 6.6.0
   centos7
   jre 8
   
   - Which company or project?
   Customized ofbiz
   
   - What happen?
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch chore/code-style updated (002a735 -> 7d351b3)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard 002a735  Set up more strict code style rules
 add 7d351b3  Set up more strict code style rules

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (002a735)
\
 N -- N -- N   refs/heads/chore/code-style (7d351b3)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../query-graphql-plugin/src/main/resources/query-protocol  | 2 +-
 test/e2e/e2e-protocol/src/main/proto| 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-10 Thread GitBox

wu-sheng commented on issue #4337: Set up more strict code styles and fix 
existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584125096
 
 
   Seems still failing. :P


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

codecov-io edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/47b4eb80e5cf05a5066315d2fcf9d9907574d170?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4228  +/-   ##
   ==
   + Coverage26.4%   26.41%   +<.01% 
   ==
 Files1211 1211  
 Lines   2638826388  
 Branches 3745 3745  
   ==
   + Hits 6968 6970   +2 
   + Misses  1880018799   -1 
   + Partials  620  619   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `83.6% <0%> (+3.27%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=footer). 
Last update 
[47b4eb8...6b5a733](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4335: Provide profile analyze query

2020-02-10 Thread GitBox

wu-sheng commented on a change in pull request #4335: Provide profile analyze 
query
URL: https://github.com/apache/skywalking/pull/4335#discussion_r377051247
 
 

 ##
 File path: 
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileAnalyzer.java
 ##
 @@ -32,14 +39,90 @@
  */
 public class ProfileAnalyzer {
 
+private static final Logger LOGGER = 
LoggerFactory.getLogger(ProfileAnalyzer.class);
+
 private static final ProfileAnalyzeCollector ANALYZE_COLLECTOR = new 
ProfileAnalyzeCollector();
 
+private final int threadSnapshotAnalyzeBatchSize;
+private final int analyzeSnapshotMaxSize;
+
+private final ModuleManager moduleManager;
+private IProfileThreadSnapshotQueryDAO profileThreadSnapshotQueryDAO;
+
+public ProfileAnalyzer(ModuleManager moduleManager, int 
snapshotAnalyzeBatchSize, int analyzeSnapshotMaxSize) {
+this.moduleManager = moduleManager;
+this.threadSnapshotAnalyzeBatchSize = snapshotAnalyzeBatchSize;
+this.analyzeSnapshotMaxSize = analyzeSnapshotMaxSize;
+}
+
+/**
+ * search snapshots and analyze
+ * @param segmentId
+ * @param start
+ * @param end
+ * @return
+ */
+public ProfileAnalyzation analyze(String segmentId, long start, long end) 
throws IOException {
+ProfileAnalyzation analyzation = new ProfileAnalyzation();
+
+// query sequence range list
+SequenceSearch sequenceSearch = getAllSequenceRange(segmentId, start, 
end);
+if (sequenceSearch == null) {
+analyzation.setTip("Data not found");
+return analyzation;
+}
+if (sequenceSearch.totalSequenceCount > analyzeSnapshotMaxSize) {
+analyzation.setTip("Out of snapshot analyze limit, current size:" 
+ sequenceSearch.totalSequenceCount + ", only analyze snapshot count: " + 
analyzeSnapshotMaxSize);
 
 Review comment:
   `Out of snapshot analyze limit,  xxx snapshots found, but analysis first yyy 
snapshots only`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4335: Provide profile analyze query

2020-02-10 Thread GitBox

wu-sheng commented on a change in pull request #4335: Provide profile analyze 
query
URL: https://github.com/apache/skywalking/pull/4335#discussion_r377052937
 
 

 ##
 File path: 
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileAnalyzer.java
 ##
 @@ -50,9 +133,28 @@ public static ProfileAnalyzation 
analyze(List stacks) {
 .filter(s -> CollectionUtils.isNotEmpty(s.getStack()))
 .collect(Collectors.groupingBy(s -> s.getStack().get(0), 
ANALYZE_COLLECTOR));
 
-ProfileAnalyzation analyzer = new ProfileAnalyzation();
-analyzer.setTrees(new ArrayList<>(stackTrees.values()));
-return analyzer;
+return new ArrayList<>(stackTrees.values());
 }
 
+private IProfileThreadSnapshotQueryDAO getProfileThreadSnapshotQueryDAO() {
+if (profileThreadSnapshotQueryDAO == null) {
+profileThreadSnapshotQueryDAO = 
moduleManager.find(StorageModule.NAME).provider().getService(IProfileThreadSnapshotQueryDAO.class);
+}
+return profileThreadSnapshotQueryDAO;
+}
+
+private static class SequenceSearch {
+LinkedList ranges = new LinkedList<>();
+int totalSequenceCount;
+}
+
+private static class SequenceRange {
 
 Review comment:
   Even for an inner class, please use set/get, rather than accessing fields 
directly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch chore/code-style updated (8a69b86 -> 002a735)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard 8a69b86  Set up more strict code style rules
 add 002a735  Set up more strict code style rules

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (8a69b86)
\
 N -- N -- N   refs/heads/chore/code-style (002a735)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java | 1 +
 1 file changed, 1 insertion(+)

[skywalking] branch chore/code-style updated (e96a425 -> 8a69b86)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard e96a425  Review code styles automatically
 add 8c96fd4  Update elasticsearch-7.x agent support version. (#4340)
 add 8a69b86  Set up more strict code style rules

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (e96a425)
\
 N -- N -- N   refs/heads/chore/code-style (8a69b86)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .github/workflows/plugins-test.yaml|   2 +-
 codeStyle.xml  | 220 +
 .../service-agent/java-agent/Supported-list.md |   2 +-
 .../server/core/alarm/provider/RunningRule.java|  19 +-
 .../support-version.list   |   1 +
 5 files changed, 110 insertions(+), 134 deletions(-)

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4344: [WIP]supprt gRPC alarm hook.

2020-02-10 Thread GitBox

wu-sheng commented on a change in pull request #4344: [WIP]supprt gRPC alarm 
hook.
URL: https://github.com/apache/skywalking/pull/4344#discussion_r37741
 
 

 ##
 File path: 
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/grpc/GRPCCallback.java
 ##
 @@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.grpc;
+
+import io.grpc.stub.StreamObserver;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.grpc.AlarmServiceGrpc;
+import org.apache.skywalking.oap.server.core.alarm.grpc.Response;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+import org.apache.skywalking.oap.server.library.client.grpc.GRPCClient;
+
+/**
+ * Use SkyWalking alarm grpc API call a remote methods.
+ *
+ * @author jian.tan
+ */
+@Slf4j
+public class GRPCCallback implements AlarmCallback {
+
+GRPCAlarmSetting alarmSetting;
+
+private AlarmServiceGrpc.AlarmServiceStub alarmServiceStub;
+
+public GRPCCallback(AlarmRulesWatcher alarmRulesWatcher) {
+alarmSetting = alarmRulesWatcher.getGrpchookSetting();
+if (alarmSetting != null) {
+GRPCClient client = new GRPCClient(alarmSetting.getTargetHost(), 
alarmSetting.getTargetPort());
+client.connect();
+alarmServiceStub = AlarmServiceGrpc.newStub(client.getChannel());
+}
+}
+
+@Override public void doAlarm(List alarmMessage) {
+
+if (alarmServiceStub == null) {
+return;
+}
+
+
StreamObserver 
streamObserver =
+alarmServiceStub.withDeadlineAfter(10, 
TimeUnit.SECONDS).doAlarm(new StreamObserver() {
+@Override public void onNext(Response response) {
+
+}
+
+@Override public void onError(Throwable throwable) {
+if (log.isDebugEnabled()) {
+log.debug("Send alarm message failed: {}", 
throwable.getMessage());
+}
+
+}
+
+@Override public void onCompleted() {
+if (log.isDebugEnabled()) {
+log.debug("Send alarm message successful.");
+}
+}
+});
+
+alarmMessage.forEach(message -> {
+
org.apache.skywalking.oap.server.core.alarm.grpc.AlarmMessage.Builder builder =
+
org.apache.skywalking.oap.server.core.alarm.grpc.AlarmMessage.newBuilder();
+
+builder.setScopeId(message.getScopeId());
+builder.setScope(message.getScope());
+builder.setName(message.getName());
+builder.setId0(message.getId0());
+builder.setId1(message.getId1());
+builder.setRuleName(message.getRuleName());
+builder.setAlarmMessage(message.getAlarmMessage());
+builder.setStartTime(message.getStartTime());
+
+streamObserver.onNext(builder.build());
+});
+
+streamObserver.onCompleted();
+
+if (log.isDebugEnabled()) {
 
 Review comment:
   Waiting for your update.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch grpc_alarm updated (3613ff6 -> b7605f7)

2020-02-10 Thread wusheng

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch grpc_alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 3613ff6  revert submodule commitid.
 add 8c96fd4  Update elasticsearch-7.x agent support version. (#4340)
 add b7605f7  Merge branch 'master' into grpc_alarm

No new revisions were added by this update.

Summary of changes:
 .github/workflows/plugins-test.yaml   | 2 +-
 docs/en/setup/service-agent/java-agent/Supported-list.md  | 2 +-
 test/plugin/scenarios/elasticsearch-7.x-scenario/support-version.list | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

[GitHub] [skywalking] wu-sheng commented on issue #4340: Update elasticsearch-7.x agent support version.

2020-02-10 Thread GitBox

wu-sheng commented on issue #4340: Update elasticsearch-7.x agent support 
version.
URL: https://github.com/apache/skywalking/pull/4340#issuecomment-584072145
 
 
   Merging with e2e profile failure, because the profile case has issue itself.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng merged pull request #4340: Update elasticsearch-7.x agent support version.

2020-02-10 Thread GitBox

wu-sheng merged pull request #4340: Update elasticsearch-7.x agent support 
version.
URL: https://github.com/apache/skywalking/pull/4340
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch master updated: Update elasticsearch-7.x agent support version. (#4340)

2020-02-10 Thread wusheng

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
 new 8c96fd4  Update elasticsearch-7.x agent support version. (#4340)
8c96fd4 is described below

commit 8c96fd49ddecb90bb8c98674b378c0d24483c5a7
Author: aderm <394102...@qq.com>
AuthorDate: Mon Feb 10 19:10:38 2020 +0800

Update elasticsearch-7.x agent support version. (#4340)

* test/plugin/scenarios/elasticsearch-7.x-scenario/support-version.list

* update elasticsearch-7.x agent support version.

Co-authored-by: 吴晟 Wu Sheng 
---
 .github/workflows/plugins-test.yaml   | 2 +-
 docs/en/setup/service-agent/java-agent/Supported-list.md  | 2 +-
 test/plugin/scenarios/elasticsearch-7.x-scenario/support-version.list | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/plugins-test.yaml 
b/.github/workflows/plugins-test.yaml
index 03a9d33..0317d8a 100644
--- a/.github/workflows/plugins-test.yaml
+++ b/.github/workflows/plugins-test.yaml
@@ -459,7 +459,7 @@ jobs:
 run: ./mvnw --batch-mode clean package -DskipTests -Pagent >/dev/null
   - name: Build the Docker image
 run: ./mvnw --batch-mode -f test/plugin/pom.xml clean package 
-DskipTests docker:build -DBUILD_NO=local >/dev/null
-  - name: Run elasticsearch-7.x-scenario 7.0.0-7.5.1 (13)
+  - name: Run elasticsearch-7.x-scenario 7.0.0-7.5.2 (14)
 run: bash test/plugin/run.sh elasticsearch-7.x-scenario
   - name: Run elasticsearch-6.x-scenario 6.7.1-6.8.4 (7)
 run: bash test/plugin/run.sh elasticsearch-6.x-scenario
diff --git a/docs/en/setup/service-agent/java-agent/Supported-list.md 
b/docs/en/setup/service-agent/java-agent/Supported-list.md
index 06c95b6..2e74bb8 100644
--- a/docs/en/setup/service-agent/java-agent/Supported-list.md
+++ b/docs/en/setup/service-agent/java-agent/Supported-list.md
@@ -60,7 +60,7 @@
   * [Elasticsearch](https://github.com/elastic/elasticsearch)
 * 
[transport-client](https://github.com/elastic/elasticsearch/tree/master/client/transport)
 5.2.x-5.6.x
 * 
[rest-high-level-client](https://www.elastic.co/guide/en/elasticsearch/client/java-rest/6.7/index.html)
 6.7.1-6.8.4
-* 
[rest-high-level-client](https://www.elastic.co/guide/en/elasticsearch/client/java-rest/7.0/java-rest-high.html)
 7.0.0-7.5.1
+* 
[rest-high-level-client](https://www.elastic.co/guide/en/elasticsearch/client/java-rest/7.0/java-rest-high.html)
 7.0.0-7.5.2
   * [Solr](https://github.com/apache/lucene-solr/)
 * [SolrJ](https://github.com/apache/lucene-solr/tree/master/solr/solrj) 7.x
   * [Cassandra](https://github.com/apache/cassandra) 3.x
diff --git 
a/test/plugin/scenarios/elasticsearch-7.x-scenario/support-version.list 
b/test/plugin/scenarios/elasticsearch-7.x-scenario/support-version.list
index 09fe2b1..a920685 100644
--- a/test/plugin/scenarios/elasticsearch-7.x-scenario/support-version.list
+++ b/test/plugin/scenarios/elasticsearch-7.x-scenario/support-version.list
@@ -27,3 +27,4 @@
 7.4.2
 7.5.0
 7.5.1
+7.5.2

[GitHub] [skywalking] wu-sheng commented on issue #4291: Improve ES query performance

2020-02-10 Thread GitBox

wu-sheng commented on issue #4291: Improve ES query performance
URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584071547
 
 
   By following your conclusion, as we indeed change conditions usually, should 
we close this PR and tag won't fix?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aderm commented on issue #4291: Improve ES query performance

2020-02-10 Thread GitBox

aderm commented on issue #4291: Improve ES query performance
URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584063442
 
 
   ### Based on the previous situation, a 60W test data was created.
   https://user-images.githubusercontent.com/2892433/74142455-e9eeb600-4c33-11ea-918a-8c8375224b95.png";>
   
   ### Designed four test scenarios
   - Comparing dynamic and non-dynamic query condition scenarios
   - Comparing `ConstantScoreQueryBuilder` and non `ConstantScoreQueryBuilder` 
query condition scenarios
   - Comparing `boolQuery().filter` and non `boolQuery().filter` query 
condition scenarios
   - Comparing all filter and part filter query condition scenarios
   - Comparing all constant score and part constant score query condition 
scenarios
   
   ```
   /**
* @author aderm
*/
   @Warmup(iterations = 5, time = 5, timeUnit = TimeUnit.SECONDS)
   @Measurement(iterations = 5, time = 5, timeUnit = TimeUnit.SECONDS)
   @State(Scope.Benchmark)
   public class FilterQueryTest {
   
   private RestHighLevelClient client;
   
   private final long startTimestamp = 1580287478790L;
   private final long endTimestamp = 168048064L;
   
   private final long MULTIPLE = 1L;
   private final int SEARCH_SIZE = 5000;
   private final String INDEX_NAME = "service_inventory";
   
   @Setup
   public void createClient() {
   client = new RestHighLevelClient((RestClient.builder(new 
HttpHost("127.0.0.1", 9200, "http";
   }
   
   @TearDown
   public void closeClient() throws IOException {
   client.close();
   }
   
   /**
* Benchmark test fix es query clause
*/
   @Benchmark
   @BenchmarkMode(Mode.AverageTime)
   @OutputTimeUnit(TimeUnit.MICROSECONDS)
   public void testFixEsQuery() throws IOException {
   SearchSourceBuilder sourceBuilder = 
SearchSourceBuilder.searchSource();
   
   BoolQueryBuilder boolQueryBuilder = QueryBuilders.boolQuery();
   boolQueryBuilder.should().add(timeRangeQueryBuild(startTimestamp, 
endTimestamp));
   
   boolQueryBuilder.should().add(QueryBuilders.termQuery("is_address", 
0));
   boolQueryBuilder.should().add(QueryBuilders.termQuery("node_type", 
0));
   
   sourceBuilder.query(boolQueryBuilder);
   sourceBuilder.size(SEARCH_SIZE);
   SearchRequest searchRequest = new SearchRequest(INDEX_NAME);
   searchRequest.source(sourceBuilder);
   SearchResponse response = client.search(searchRequest, 
RequestOptions.DEFAULT);
   }
   
   /**
* Benchmark test fix es part const query clause
*/
   @Benchmark
   @BenchmarkMode(Mode.AverageTime)
   @OutputTimeUnit(TimeUnit.MICROSECONDS)
   public void testFixEsConstQueryPart() throws IOException {
   SearchSourceBuilder sourceBuilder = 
SearchSourceBuilder.searchSource();
   
   BoolQueryBuilder boolQueryBuilder = QueryBuilders.boolQuery();
   boolQueryBuilder.should().add(new 
ConstantScoreQueryBuilder(timeRangeQueryBuild(startTimestamp, endTimestamp)));
   
   boolQueryBuilder.should().add(QueryBuilders.termQuery("is_address", 
0));
   boolQueryBuilder.should().add(QueryBuilders.termQuery("node_type", 
0));
   
   sourceBuilder.query(boolQueryBuilder);
   sourceBuilder.size(SEARCH_SIZE);
   SearchRequest searchRequest = new SearchRequest(INDEX_NAME);
   searchRequest.source(sourceBuilder);
   SearchResponse response = client.search(searchRequest, 
RequestOptions.DEFAULT);
   }
   
   /**
* Benchmark test fix es all const query clause
*/
   @Benchmark
   @BenchmarkMode(Mode.AverageTime)
   @OutputTimeUnit(TimeUnit.MICROSECONDS)
   public void testFixEsConstQueryAll() throws IOException {
   SearchSourceBuilder sourceBuilder = 
SearchSourceBuilder.searchSource();
   
   BoolQueryBuilder boolQueryBuilder = QueryBuilders.boolQuery();
   boolQueryBuilder.should().add(timeRangeQueryBuild(startTimestamp, 
endTimestamp));
   
   boolQueryBuilder.should().add(QueryBuilders.termQuery("is_address", 
0));
   boolQueryBuilder.should().add(QueryBuilders.termQuery("node_type", 
0));
   
   sourceBuilder.query(new ConstantScoreQueryBuilder(boolQueryBuilder));
   sourceBuilder.size(SEARCH_SIZE);
   SearchRequest searchRequest = new SearchRequest(INDEX_NAME);
   searchRequest.source(sourceBuilder);
   SearchResponse response = client.search(searchRequest, 
RequestOptions.DEFAULT);
   }
   
   /**
* Benchmark test fix es part filter query clause
*/
   @Benchmark
   @BenchmarkMode(Mode.AverageTime)
   @OutputTimeUnit(TimeUnit.MICROSECONDS)
   public void testFixEsFilterQueryPart() throws IOException {
   SearchSourceBuilder sourceBuilder = 
SearchSourceBuilder.searchSource();

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

codecov-io edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/da1729705a106e7243b1738fa4fc2d8b1c65a5d1?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `56.09%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #4228  +/-   ##
   =
   - Coverage   26.41%   26.4%   -0.01% 
   =
 Files12111211  
 Lines   26388   26388  
 Branches 37453745  
   =
   - Hits 69706968   -2 
   - Misses  18799   18800   +1 
   - Partials  619 620   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==)
 | `18.75% <100%> (ø)` | :arrow_up: |
   | 
[...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh)
 | `96.87% <100%> (ø)` | :arrow_up: |
   | 
[...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh)
 | `68.53% <51.35%> (ø)` | :arrow_up: |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.32% <0%> (-3.28%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=footer). 
Last update 
[da17297...47b4eb8](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch chore/code-style updated (dc1b68d -> e96a425)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard dc1b68d  Review code styles automatically
 add e96a425  Review code styles automatically

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (dc1b68d)
\
 N -- N -- N   refs/heads/chore/code-style (e96a425)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../skywalking/oap/server/core/alarm/provider/RunningRule.java| 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

codecov-io edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/da1729705a106e7243b1738fa4fc2d8b1c65a5d1?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4228   +/-   ##
   ===
 Coverage   26.41%   26.41%   
   ===
 Files1211 1211   
 Lines   2638826388   
 Branches 3745 3745   
   ===
 Hits 6970 6970   
 Misses  1879918799   
 Partials  619  619
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=footer). 
Last update 
[da17297...47b4eb8](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-10 Thread GitBox

JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#discussion_r376960689
 
 

 ##
 File path: 
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/grpc/GRPCCallback.java
 ##
 @@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.grpc;
+
+import io.grpc.stub.StreamObserver;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.grpc.AlarmServiceGrpc;
+import org.apache.skywalking.oap.server.core.alarm.grpc.Response;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+import org.apache.skywalking.oap.server.library.client.grpc.GRPCClient;
+
+/**
+ * Use SkyWalking alarm grpc API call a remote methods.
+ *
+ * @author jian.tan
+ */
+@Slf4j
+public class GRPCCallback implements AlarmCallback {
+
+GRPCAlarmSetting alarmSetting;
+
+private AlarmServiceGrpc.AlarmServiceStub alarmServiceStub;
+
+public GRPCCallback(AlarmRulesWatcher alarmRulesWatcher) {
+alarmSetting = alarmRulesWatcher.getGrpchookSetting();
+if (alarmSetting != null) {
+GRPCClient client = new GRPCClient(alarmSetting.getTargetHost(), 
alarmSetting.getTargetPort());
+client.connect();
+alarmServiceStub = AlarmServiceGrpc.newStub(client.getChannel());
+}
+}
+
+@Override public void doAlarm(List alarmMessage) {
+
+if (alarmServiceStub == null) {
+return;
+}
+
+
StreamObserver 
streamObserver =
+alarmServiceStub.withDeadlineAfter(10, 
TimeUnit.SECONDS).doAlarm(new StreamObserver() {
+@Override public void onNext(Response response) {
+
+}
+
+@Override public void onError(Throwable throwable) {
+if (log.isDebugEnabled()) {
+log.debug("Send alarm message failed: {}", 
throwable.getMessage());
+}
+
+}
+
+@Override public void onCompleted() {
+if (log.isDebugEnabled()) {
+log.debug("Send alarm message successful.");
+}
+}
+});
+
+alarmMessage.forEach(message -> {
+
org.apache.skywalking.oap.server.core.alarm.grpc.AlarmMessage.Builder builder =
+
org.apache.skywalking.oap.server.core.alarm.grpc.AlarmMessage.newBuilder();
+
+builder.setScopeId(message.getScopeId());
+builder.setScope(message.getScope());
+builder.setName(message.getName());
+builder.setId0(message.getId0());
+builder.setId1(message.getId1());
+builder.setRuleName(message.getRuleName());
+builder.setAlarmMessage(message.getAlarmMessage());
+builder.setStartTime(message.getStartTime());
+
+streamObserver.onNext(builder.build());
+});
+
+streamObserver.onCompleted();
+
+if (log.isDebugEnabled()) {
 
 Review comment:
   Yeah


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch grpc_alarm updated (69bdcf7 -> 3613ff6)

2020-02-10 Thread tanjian

This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a change to branch grpc_alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 69bdcf7  revert submodule commit.
 add 3613ff6  revert submodule commitid.

No new revisions were added by this update.

Summary of changes:
 .../query-graphql-plugin/src/main/resources/query-protocol  | 2 +-
 skywalking-ui   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-10 Thread GitBox

wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344#discussion_r376959676
 
 

 ##
 File path: 
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/grpc/GRPCCallback.java
 ##
 @@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.grpc;
+
+import io.grpc.stub.StreamObserver;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.grpc.AlarmServiceGrpc;
+import org.apache.skywalking.oap.server.core.alarm.grpc.Response;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+import org.apache.skywalking.oap.server.library.client.grpc.GRPCClient;
+
+/**
+ * Use SkyWalking alarm grpc API call a remote methods.
+ *
+ * @author jian.tan
+ */
+@Slf4j
+public class GRPCCallback implements AlarmCallback {
+
+GRPCAlarmSetting alarmSetting;
+
+private AlarmServiceGrpc.AlarmServiceStub alarmServiceStub;
+
+public GRPCCallback(AlarmRulesWatcher alarmRulesWatcher) {
+alarmSetting = alarmRulesWatcher.getGrpchookSetting();
+if (alarmSetting != null) {
+GRPCClient client = new GRPCClient(alarmSetting.getTargetHost(), 
alarmSetting.getTargetPort());
+client.connect();
+alarmServiceStub = AlarmServiceGrpc.newStub(client.getChannel());
+}
+}
+
+@Override public void doAlarm(List alarmMessage) {
+
+if (alarmServiceStub == null) {
+return;
+}
+
+
StreamObserver 
streamObserver =
+alarmServiceStub.withDeadlineAfter(10, 
TimeUnit.SECONDS).doAlarm(new StreamObserver() {
+@Override public void onNext(Response response) {
+
+}
+
+@Override public void onError(Throwable throwable) {
+if (log.isDebugEnabled()) {
+log.debug("Send alarm message failed: {}", 
throwable.getMessage());
+}
+
+}
+
+@Override public void onCompleted() {
+if (log.isDebugEnabled()) {
+log.debug("Send alarm message successful.");
+}
+}
+});
+
+alarmMessage.forEach(message -> {
+
org.apache.skywalking.oap.server.core.alarm.grpc.AlarmMessage.Builder builder =
+
org.apache.skywalking.oap.server.core.alarm.grpc.AlarmMessage.newBuilder();
+
+builder.setScopeId(message.getScopeId());
+builder.setScope(message.getScope());
+builder.setName(message.getName());
+builder.setId0(message.getId0());
+builder.setId1(message.getId1());
+builder.setRuleName(message.getRuleName());
+builder.setAlarmMessage(message.getAlarmMessage());
+builder.setStartTime(message.getStartTime());
+
+streamObserver.onNext(builder.build());
+});
+
+streamObserver.onCompleted();
+
+if (log.isDebugEnabled()) {
 
 Review comment:
   If you are using gRPC stream, you should use wait for the onComplete event 
to avoid the memory leak. What do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] branch grpc_alarm updated (7f89261 -> 69bdcf7)

2020-02-10 Thread tanjian

This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a change to branch grpc_alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 7f89261  Merge branch 'master' into grpc_alarm
 add 69bdcf7  revert submodule commit.

No new revisions were added by this update.

Summary of changes:
 .../query-graphql-plugin/src/main/resources/query-protocol  | 2 +-
 skywalking-ui   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

[GitHub] [skywalking] JaredTan95 opened a new pull request #4344: supprt gRPC alarm hook.

2020-02-10 Thread GitBox

JaredTan95 opened a new pull request #4344: supprt gRPC alarm hook.
URL: https://github.com/apache/skywalking/pull/4344
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   send alarm message through remote gRPC way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[skywalking] 02/02: Merge branch 'master' into grpc_alarm

2020-02-10 Thread tanjian

This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a commit to branch grpc_alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit 7f8926144931812a19fdc1dd0a4b8ce305edea71
Merge: 788a416 fc4402f
Author: JaredTan95 
AuthorDate: Mon Feb 10 17:42:10 2020 +0800

Merge branch 'master' into grpc_alarm

# Conflicts:
#   
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.java

 docs/en/guides/How-to-build.md | 155 +++--
 .../oap/server/core/alarm/provider/AlarmRule.java  |   2 +
 .../core/alarm/provider/AlarmRulesWatcher.java |   3 +
 .../oap/server/core/alarm/provider/Rules.java  |   1 +
 .../server/core/alarm/provider/RunningRule.java|  66 +
 .../src/test/resources/log4j2-test.xml |  36 +
 .../profile/analyze/ProfileAnalyzeCollector.java   |   6 +-
 .../core/profile/analyze/ProfileAnalyzer.java  |   6 +-
 .../core/profile/analyze/ProfileStackNode.java |  29 ++--
 .../core/query/entity/ProfileAnalyzation.java  |   7 +-
 .../core/query/entity/ProfileStackElement.java |  12 +-
 ...ofileAnalyzation.java => ProfileStackTree.java} |   9 +-
 .../core/profile/bean/ProfileStackAnalyze.java |   6 +-
 .../profile/bean/ProfileStackElementMatcher.java   |  57 +---
 .../oap/query/graphql/resolver/ProfileQuery.java   |   2 +-
 skywalking-ui  |   2 +-
 16 files changed, 271 insertions(+), 128 deletions(-)

diff --cc 
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.java
index 513eff3,e944377..aefef29
--- 
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.java
+++ 
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.java
@@@ -18,12 -18,8 +18,13 @@@
  
  package org.apache.skywalking.oap.server.core.alarm.provider;
  
 +import java.io.StringReader;
 +import java.util.ArrayList;
 +import java.util.HashMap;
 +import java.util.List;
 +import java.util.Map;
  import lombok.Getter;
+ import lombok.extern.slf4j.Slf4j;
  import org.apache.skywalking.oap.server.configuration.api.ConfigChangeWatcher;
  import org.apache.skywalking.oap.server.core.Const;
  import org.apache.skywalking.oap.server.core.alarm.AlarmModule;
diff --cc skywalking-ui
index 9ad81a0,2cb2305..b911f4f
--- a/skywalking-ui
+++ b/skywalking-ui
@@@ -1,1 -1,1 +1,1 @@@
- Subproject commit 9ad81a05a2f2969420c1f75769c2b4def42819e4
 -Subproject commit 2cb2305af5b2a787fbf877fd0f0092a960b956c2
++Subproject commit b911f4f4adffa704257b118013b8d9e1d0a57fef

[skywalking] branch chore/code-style updated (045b64c -> dc1b68d)

2020-02-10 Thread kezhenxu94

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch chore/code-style
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


 discard 045b64c  Review code styles automatically
 add e9eaa74  sync ui pr #252 (#4338)
 add 45516a3   Make an alternative method while cloning (#4333)
 add fc4402f  Add trace log (#4339)
 add dc1b68d  Review code styles automatically

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (045b64c)
\
 N -- N -- N   refs/heads/chore/code-style (dc1b68d)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 docs/en/guides/How-to-build.md | 155 +++--
 .../oap/server/core/alarm/provider/AlarmRule.java  |   2 +
 .../core/alarm/provider/AlarmRulesWatcher.java |  19 ++-
 .../oap/server/core/alarm/provider/Rules.java  |   1 +
 .../server/core/alarm/provider/RunningRule.java|  85 +--
 .../src/test/resources/log4j2-test.xml |   4 +-
 skywalking-ui  |   2 +-
 7 files changed, 175 insertions(+), 93 deletions(-)
 copy docker/oap-es7/log4j2.xml => 
oap-server/server-alarm-plugin/src/test/resources/log4j2-test.xml (92%)

[skywalking] branch grpc_alarm created (now 7f89261)

2020-02-10 Thread tanjian

This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a change to branch grpc_alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


  at 7f89261  Merge branch 'master' into grpc_alarm

This branch includes the following new commits:

 new 788a416  support gRPC hook.
 new 7f89261  Merge branch 'master' into grpc_alarm

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[skywalking] 01/02: support gRPC hook.

2020-02-10 Thread tanjian

This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a commit to branch grpc_alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit 788a416b90e721cfffc300023ebd1ff05c50d6d8
Author: JaredTan95 
AuthorDate: Mon Feb 10 17:37:55 2020 +0800

support gRPC hook.
---
 docs/en/setup/backend/backend-alarm.md |  19 
 oap-server/server-alarm-plugin/pom.xml |  34 +++
 .../core/alarm/provider/AlarmRulesWatcher.java |  21 +++--
 .../server/core/alarm/provider/NotifyHandler.java  |   2 +
 .../oap/server/core/alarm/provider/Rules.java  |   2 +
 .../server/core/alarm/provider/RulesReader.java|  29 +-
 .../{Rules.java => grpc/GRPCAlarmSetting.java} |  25 +++--
 .../core/alarm/provider/grpc/GRPCCallback.java | 102 +
 .../provider/Rules.java => proto/alarm-hook.proto} |  32 ---
 .../core/alarm/provider/AlarmRulesWatcherTest.java |  13 ++-
 .../alarm/provider/grpc/AlarmMockReceiver.java |  73 +++
 .../alarm/provider/grpc/GRPChookCallbackTest.java  |  72 +++
 .../src/test/resources/alarm-settings.yml  |   4 +
 .../src/main/resources/alarm-settings.yml  |   4 +
 14 files changed, 388 insertions(+), 44 deletions(-)

diff --git a/docs/en/setup/backend/backend-alarm.md 
b/docs/en/setup/backend/backend-alarm.md
index d277958..2787f95 100644
--- a/docs/en/setup/backend/backend-alarm.md
+++ b/docs/en/setup/backend/backend-alarm.md
@@ -3,6 +3,7 @@ Alarm core is driven by a collection of rules, which are 
defined in `config/alar
 There are two parts in alarm rule definition.
 1. [Alarm rules](#rules). They define how metrics alarm should be triggered, 
what conditions should be considered.
 1. [Webhooks](#webhook). The list of web service endpoint, which should be 
called after the alarm is triggered.
+1. [gRPCHook](#gRPCHook). The host and port of remote gRPC method, which 
should be called after the alarm is triggered.
 
 ## Rules
 Alarm rule is constituted by following keys
@@ -113,6 +114,24 @@ Example as following
 }]
 ```
 
+## gRPCHook
+The alarm message will send through remote gRPC method by `Protobuf` content 
type. 
+The message format with following key information which are defined in 
`oap-server/server-alarm-plugin/src/main/proto/alarm-hook.proto`.
+
+Example as following
+```text
+message AlarmMessage {
+int64 scopeId = 1;
+string scope = 2;
+string name = 3;
+int64 id0 = 4;
+int64 id1 = 5;
+string ruleName = 6;
+string alarmMessage = 7;
+int64 startTime = 8;
+}
+```
+
 ## Update the settings dynamically
 Since 6.5.0, the alarm settings can be updated dynamically at runtime by 
[Dynamic Configuration](dynamic-config.md),
 which will override the settings in `alarm-settings.yml`.
diff --git a/oap-server/server-alarm-plugin/pom.xml 
b/oap-server/server-alarm-plugin/pom.xml
index 362902d..24fe8bf 100644
--- a/oap-server/server-alarm-plugin/pom.xml
+++ b/oap-server/server-alarm-plugin/pom.xml
@@ -26,6 +26,7 @@
 4.0.0
 
 server-alarm-plugin
+
 
 
 org.apache.skywalking
@@ -37,7 +38,40 @@
 library-util
 ${project.version}
 
+
+io.grpc
+grpc-testing
+
 
 
+
+
+
+org.xolstice.maven.plugins
+protobuf-maven-plugin
+${protobuf-maven-plugin.version}
+
+
+
com.google.protobuf:protoc:${com.google.protobuf.protoc.version}:exe:${os.detected.classifier}
+
+grpc-java
+
io.grpc:protoc-gen-grpc-java:${protoc-gen-grpc-java.plugin.version}:exe:${os.detected.classifier}
+
+
+
+
+
+compile
+compile-custom
+
+
+
+
+
+
 
 
\ No newline at end of file
diff --git 
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.java
 
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.java
index abfecc9..513eff3 100644
--- 
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.java
+++ 
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.java
@@ -18,22 +18,21 @@
 
 package org.apache.skywalking.oap.server.core.alarm.provider;
 
-import lombok.Getter;
-import org.apache.skywalking.oap.server.configuration.api.ConfigChangeWatcher;
-import org.apache.skywalking.oap.server.core.Const;
-import org.apache.skywalking.oap.server.core.alarm.AlarmModule;
-import org.apache.skywalkin

[GitHub] [skywalking] codecov-io edited a comment on issue #4340: Update elasticsearch-7.x agent support version.

2020-02-10 Thread GitBox

codecov-io edited a comment on issue #4340: Update elasticsearch-7.x agent 
support version.
URL: https://github.com/apache/skywalking/pull/4340#issuecomment-583955232
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4340?src=pr&el=h1) 
Report
   > Merging 
[#4340](https://codecov.io/gh/apache/skywalking/pull/4340?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/4392f683c6e9812174189616f369d5df1179709d?src=pr&el=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `56.09%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4340/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4340?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4340  +/-   ##
   ==
   + Coverage   27.01%   27.06%   +0.05% 
   ==
 Files1176 1176  
 Lines   2567725718  +41 
 Branches 3664 3675  +11 
   ==
   + Hits 6936 6961  +25 
   - Misses  1812818138  +10 
   - Partials  613  619   +6
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4340?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/4340/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==)
 | `18.75% <100%> (+5.41%)` | :arrow_up: |
   | 
[...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/4340/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4340/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh)
 | `96.87% <100%> (+0.2%)` | :arrow_up: |
   | 
[...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/4340/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh)
 | `68.53% <51.35%> (-4.52%)` | :arrow_down: |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4340/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `83.6% <0%> (+3.27%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4340?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4340?src=pr&el=footer). 
Last update 
[4392f68...da75a21](https://codecov.io/gh/apache/skywalking/pull/4340?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

2020-02-10 Thread GitBox

wu-sheng commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL 
driver downloaded failure.
URL: https://github.com/apache/skywalking/issues/4343#issuecomment-584031563
 
 
   The download link will be fixed through #4335, but we need to invest why and 
fix it ASAP.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng opened a new issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

2020-02-10 Thread GitBox

wu-sheng opened a new issue #4343: [e2e] MySQL e2e test could pass even MySQL 
driver downloaded failure.
URL: https://github.com/apache/skywalking/issues/4343
 
 
   We detected a high priority e2e test issue at #4335, the download link of 
MySQL driver is dead, but the e2e test could pass every time.
   
   This is a high priority test issue, which makes reviewers can't use the test 
to verify the codes. @kezhenxu94 please take this as the 1st priority thing to 
fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] justmine66 edited a comment on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

2020-02-10 Thread GitBox

justmine66 edited a comment on issue #4342: According to the latest docs，use 
mixer solution to istio, but no data in skywalking ui.
URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584030168
 
 
   > > Can make a patch immediately to support istio 1.4.3.
   > @hanahmily Do you have time to deal with this recently?
   > @justmine66 Recommend using ALS solution, which has better compatibility 
than mixer itself.
   thanks, i try ALS solution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

2020-02-10 Thread GitBox

justmine66 commented on issue #4342: According to the latest docs，use mixer 
solution to istio, but no data in skywalking ui.
URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584030168
 
 
   > > Can make a patch immediately to support istio 1.4.3.
   > @hanahmily Do you have time to deal with this recently?
   > @justmine66 Recommend using ALS solution, which has better compatibility 
than mixer itself.
   ok，i try ALS solution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

2020-02-10 Thread GitBox

wu-sheng commented on issue #4342: According to the latest docs，use mixer 
solution to istio, but no data in skywalking ui.
URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584029232
 
 
   > Can make a patch immediately to support istio 1.4.3.
   
   @hanahmily Do you have time to deal with this recently?
   
   @justmine66 Recommend using ALS solution, which has better compatibility 
than mixer itself.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

wu-sheng commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584024909
 
 
   And for `collectErrorLogs`, there are logs from further requests on that 
page. 
   
   @Fine0830 Please indicate your idea of success/error rate principle, and how 
should we calculate those.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] justmine66 edited a comment on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

2020-02-10 Thread GitBox

justmine66 edited a comment on issue #4342: According to the latest docs，use 
mixer solution to istio, but no data in skywalking ui.
URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584023373
 
 
   > From what I know, we only support `1.3.3` now according to
   > 
   > 
https://github.com/apache/skywalking/blob/fc4402f5a4bfe8a143e130e92041e0f9b6a045d1/install/deploy/istio-deploy.sh#L98
   > 
   > . For other versions, there's no guarantee, sorry.
   Can make a patch immediately to support istio 1.4.3.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox

wu-sheng commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584024143
 
 
   @Fine0830 Currently, we used to ask `browser_app_error_rate` as a metrics, 
including `error_rate` of single version and page. But in the latest protocol 
change, we support multiple logs for a single one page, 
https://github.com/apache/skywalking-data-collect-protocol/blob/master/browser/BrowserPerf.proto#L34
   
   This protocol can't support to calculate error_rate, because if the 
client-js reports logs for one page in multiple times, the error rate will be 
over 100%. Such as one `collectPerfData` report means 1 PV, but n* 
`collectErrorLogs` reports, the error rate will be n/1.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

2020-02-10 Thread GitBox

justmine66 commented on issue #4342: According to the latest docs，use mixer 
solution to istio, but no data in skywalking ui.
URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584023373
 
 
   > From what I know, we only support `1.3.3` now according to
   > 
   > 
https://github.com/apache/skywalking/blob/fc4402f5a4bfe8a143e130e92041e0f9b6a045d1/install/deploy/istio-deploy.sh#L98
   > 
   > . For other versions, there's no guarantee, sorry.
   
   istion version 1.4.3 unsupported?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] hanahmily commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

2020-02-10 Thread GitBox

hanahmily commented on issue #4342: According to the latest docs，use mixer 
solution to istio, but no data in skywalking ui.
URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584022868
 
 
   From what I know, we only support `1.3.3` now according to 
https://github.com/apache/skywalking/blob/fc4402f5a4bfe8a143e130e92041e0f9b6a045d1/install/deploy/istio-deploy.sh#L98.
 For other versions, there's no guarantee, sorry. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking-client-js] wu-sheng commented on a change in pull request #6: Feat: add performance data

2020-02-10 Thread GitBox

wu-sheng commented on a change in pull request #6: Feat: add performance data
URL: https://github.com/apache/skywalking-client-js/pull/6#discussion_r376933920
 
 

 ##
 File path: src/performance/index.ts
 ##
 @@ -0,0 +1,55 @@
+
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { CustomPerfOptionsType } from '../types';
+import Report from '../services/report';
+import pagePerf from './perf';
+
+class TracePerf {
+  private isPerf: boolean = true;
+  private perfConfig = {
+resources: [],
+perfDetail: {},
+  } as any;
+
+  public recordPerf(options: CustomPerfOptionsType) {
+if (this.isPerf) {
+  this.perfConfig.performance = pagePerf.getPerfTiming();
+}
+const perfInfo = {
+  perfDetail: this.perfConfig.perfDetail,
+  resources: this.perfConfig.resources,
+  ...options,
+};
+new Report(options.reportUrl).sendByXhr(perfInfo);
+this.clearPerf();
 
 Review comment:
   No, those two parameters are required, that is why I asked. 
   1. Version could be set as `-` by default, if the client-js doesn't set it, 
but this must notify the backend implementation.
   1. Service Name is not existing in the protocol, only service ID, which 
means you have registered successfully. Do you want to add a name to the 
protocol as an alternative way?
   
   My point is, this register would take time, you should have a buffer to hold 
this value until the register is done. Unless you should add name and version 
strings into the protocol. Also, you should know, the ID is required in the 
distributed tracing too. Even you add name and version in this protocol, you 
can't add those in the tracing protocol, the buffer mechanism is still required.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

2020-02-10 Thread GitBox

justmine66 commented on issue #4342: According to the latest docs，use mixer 
solution to istio, but no data in skywalking ui.
URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584019966
 
 
   > First, make sure you could send the metrics to OAP server.
   see above. when "Publishing 27 events" has a error.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

2020-02-10 Thread GitBox

wu-sheng commented on issue #4342: According to the latest docs，use mixer 
solution to istio, but no data in skywalking ui.
URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584019219
 
 
   First, make sure you could send the metrics to OAP server.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

1 2 >

1 - 100 of 109 matches

Mail list logo