[PR] fix: remove click event after unmounted [skywalking-booster-ui]
zhourunjie1988 opened a new pull request, #372: URL: https://github.com/apache/skywalking-booster-ui/pull/372 The _handleClick_ function calls the _stopPropagation_, so we'd better remove the click events after component unmounted to prevent potential problems, such as adding click events to the _window_ or _document_ elsewhere won't work correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch fix-kapa-again-htaccess updated (fdb55c54a1a -> 8ab7a94f3e2)
This is an automated email from the ASF dual-hosted git repository. yihaochen pushed a change to branch fix-kapa-again-htaccess in repository https://gitbox.apache.org/repos/asf/skywalking-website.git from fdb55c54a1a Try if config.toml works add 8ab7a94f3e2 Fix No new revisions were added by this update. Summary of changes: config.toml | 2 +- themes/docsy/layouts/partials/head.html | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-)
Re: [PR] Try if config.toml works [skywalking-website]
netlify[bot] commented on PR #680: URL: https://github.com/apache/skywalking-website/pull/680#issuecomment-1955998680 ### Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit | fdb55c54a1a2724787403213774e23c801ca782a | | Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/65d59caf4609a10008d3a104 | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Try if config.toml works [skywalking-website]
Superskyyy opened a new pull request, #680: URL: https://github.com/apache/skywalking-website/pull/680 Maybe this will work https://www.byteinthesky.com/tutorials/adding-content-security-policy-to-hugo-site/#hugo-configuration-file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch fix-kapa-again-htaccess updated: Try if config.toml works
This is an automated email from the ASF dual-hosted git repository.
yihaochen pushed a commit to branch fix-kapa-again-htaccess
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/fix-kapa-again-htaccess by
this push:
new fdb55c54a1a Try if config.toml works
fdb55c54a1a is described below
commit fdb55c54a1a2724787403213774e23c801ca782a
Author: Superskyyy
AuthorDate: Wed Feb 21 01:47:49 2024 -0500
Try if config.toml works
---
config.toml | 5 +
themes/docsy/layouts/partials/head.html | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/config.toml b/config.toml
index 9b16d01343b..dd1508b1fe8 100644
--- a/config.toml
+++ b/config.toml
@@ -267,3 +267,8 @@ weight = 1
changefreq = "daily"
filename = "sitemap.xml"
priority = 0.5
+
+[[headers]]
+ for = "/*"
+ [headers.values]
+Content-Security-Policy = "default-src 'self' google.com netlify.com;"
\ No newline at end of file
diff --git a/themes/docsy/layouts/partials/head.html
b/themes/docsy/layouts/partials/head.html
index c4e5613cd01..33ee9ca565a 100644
--- a/themes/docsy/layouts/partials/head.html
+++ b/themes/docsy/layouts/partials/head.html
@@ -4,7 +4,7 @@
https://skywalking.apache.org/images/skywalking_400x400.png;>
https://skywalking.apache.org/images/skywalking_400x400.png;>
-https://www.google.com https://app.netlify.com;;>
+
{{ hugo.Generator }}
(skywalking-website) branch fix-kapa-again-htaccess created (now 1f5ccd7267a)
This is an automated email from the ASF dual-hosted git repository. yihaochen pushed a change to branch fix-kapa-again-htaccess in repository https://gitbox.apache.org/repos/asf/skywalking-website.git at 1f5ccd7267a Remove trailing slash (#679) No new revisions were added by this update.
(skywalking-go) annotated tag v0.4.0 updated (6426060 -> 214966c)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to annotated tag v0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-go.git *** WARNING: tag v0.4.0 was modified! *** from 6426060 (commit) to 214966c (tag) tagging 642606007162e9b6f5c6827e4903994f6364d8fe (commit) replaces toolkit/v0.3.0 by root on Wed Feb 21 05:23:51 2024 + - Log - Release Apache SkyWalking-Go v0.4.0 --- No new revisions were added by this update. Summary of changes:
(skywalking-go) annotated tag toolkit/v0.4.0 updated (6426060 -> 5ec35e0)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to annotated tag toolkit/v0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-go.git *** WARNING: tag toolkit/v0.4.0 was modified! *** from 6426060 (commit) to 5ec35e0 (tag) tagging 642606007162e9b6f5c6827e4903994f6364d8fe (commit) replaces toolkit/v0.3.0 by root on Wed Feb 21 05:23:51 2024 + - Log - Release Apache SkyWalking-Go Toolkit v0.4.0 --- No new revisions were added by this update. Summary of changes:
Re: [PR] Update Changes for ready release 0.4.0 [skywalking-go]
mrproliu merged PR #171: URL: https://github.com/apache/skywalking-go/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-go) branch main updated: Update Changes for ready release 0.4.0 (#171)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-go.git The following commit(s) were added to refs/heads/main by this push: new 6426060 Update Changes for ready release 0.4.0 (#171) 6426060 is described below commit 642606007162e9b6f5c6827e4903994f6364d8fe Author: mrproliu <741550...@qq.com> AuthorDate: Wed Feb 21 13:21:25 2024 +0800 Update Changes for ready release 0.4.0 (#171) --- CHANGES.md | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 6c55762..08df91e 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -5,7 +5,8 @@ Release Notes. 0.4.0 -- Features -* Add support ignore suffix. +* Add support ignore suffix for span name. +* Adding go `1.21` and `1.22` in docker image. Plugins * Support setting a discard type of reporter. @@ -13,6 +14,7 @@ Release Notes. * Changing intercept point for gin, make sure interfaces could be grouped when params defined in relativePath. * Support [RocketMQ](https://github.com/apache/rocketmq-client-go) MQ. * Support [AMQP](https://github.com/rabbitmq/amqp091-go) MQ. +* support [Echov4](https://github.com/labstack/echo) framework. Documentation @@ -26,6 +28,7 @@ Release Notes. * Fix enhance param error when there are multiple params. * Fix lost trace when multi middleware `handlerFunc` in `gin` plugin. * Fix DBQueryContext execute error in `sql` plugin. +* Fix stack overflow as endless logs triggered. Issues and PR - All issues are [here](https://github.com/apache/skywalking/milestone/197?closed=1) @@ -42,7 +45,6 @@ Release Notes. * Support [iris](https://github.com/kataras/iris) framework. * Support [fasthttp](https://github.com/valyala/fasthttp) framework. * Support [fiber](https://github.com/gofiber/fiber) framework. -* support [Echov4](https://github.com/labstack/echo) framework. Documentation * Add `Tracing APIs` document into `Manual APIs`.
Re: [I] [Feature] Support OTEL Android monitoring [skywalking]
wu-sheng commented on issue #11657: URL: https://github.com/apache/skywalking/issues/11657#issuecomment-1955905978 Please follow [SWIP](https://skywalking.apache.org/docs/main/next/en/swip/readme/) to write the proposal. Notice, as this is new, we need you to provide details as much as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Support OTEL Android monitoring [skywalking]
ro4i7 commented on issue #11657: URL: https://github.com/apache/skywalking/issues/11657#issuecomment-1955904349 I wanna work on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update Changes for ready release 0.4.0 [skywalking-go]
mrproliu opened a new pull request, #171: URL: https://github.com/apache/skywalking-go/pull/171 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Expose traceId in PHP for Enhanced Observability [skywalking]
wu-sheng closed issue #11885: [Feature] Expose traceId in PHP for Enhanced Observability URL: https://github.com/apache/skywalking/issues/11885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-php) branch master updated: Inject skywalking context. (#107)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-php.git
The following commit(s) were added to refs/heads/master by this push:
new c23e76a Inject skywalking context. (#107)
c23e76a is described below
commit c23e76a0028e09924daebfc3949dc05a60d0b609
Author: jmjoy
AuthorDate: Wed Feb 21 10:20:55 2024 +0800
Inject skywalking context. (#107)
---
docs/en/configuration/context-injection.md | 44 ++
docs/en/configuration/ini-settings.md | 1 +
docs/menu.yml | 2 +
src/lib.rs | 7
src/module.rs | 4 ++
src/request.rs | 60 --
6 files changed, 114 insertions(+), 4 deletions(-)
diff --git a/docs/en/configuration/context-injection.md
b/docs/en/configuration/context-injection.md
new file mode 100644
index 000..3bb1eca
--- /dev/null
+++ b/docs/en/configuration/context-injection.md
@@ -0,0 +1,44 @@
+# Context injection
+
+If you want to fetch the SkyWalking Context in your PHP code, which is super
helpful for debugging and observability,
+You can enable the configuration item `skywalking_agent.inject_context`.
+
+## Description
+
+`skywalking_agent.inject_context`
+
+Whether to enable automatic injection of skywalking context variables (such as
`SW_TRACE_ID`). For `php-fpm` mode, it will be injected into the `$_SERVER`
variable. For `swoole` mode, it will be injected into the `$request->server`
variable.
+
+## Configuration
+
+```ini
+[skywalking_agent]
+extension = skywalking_agent.so
+skywalking_agent.inject_context = On
+```
+
+## Usage
+
+For `php-fpm` mode:
+
+```php
+on('request', function ($request, $response) {
+echo $request->server["SW_SERVICE_NAME"]; // get service name
+echo $request->server["SW_INSTANCE_NAME"]; // get instance name
+echo $request->server["SW_TRACE_ID"]; // get trace id
+});
+```
diff --git a/docs/en/configuration/ini-settings.md
b/docs/en/configuration/ini-settings.md
index b8a24fd..f437b6e 100644
--- a/docs/en/configuration/ini-settings.md
+++ b/docs/en/configuration/ini-settings.md
@@ -23,3 +23,4 @@ This is the configuration list supported in `php.ini`.
| skywalking_agent.reporter_type | Reporter type, optional
values are `grpc` and `kafka`.
| grpc |
| skywalking_agent.kafka_bootstrap_servers | A list of host/port pairs
to use for connect to the Kafka cluster. Only available when `reporter_type` is
`kafka`.| |
| skywalking_agent.kafka_producer_config | Configure Kafka Producer
configuration in JSON format `{"key": "value}`. Only available when
`reporter_type` is `kafka`. | {}|
+| skywalking_agent.inject_context | Whether to enable
automatic injection of skywalking context variables (such as `SW_TRACE_ID`).
For `php-fpm` mode, it will be injected into the `$_SERVER` variable. For
`swoole` mode, it will be injected into the `$request->server` variable.
| Off|
diff --git a/docs/menu.yml b/docs/menu.yml
index 723db61..f7f9e1a 100644
--- a/docs/menu.yml
+++ b/docs/menu.yml
@@ -28,6 +28,8 @@ catalog:
path: "/en/configuration/ini-settings"
- name: "Zend Observer"
path: "/en/configuration/zend-observer"
+ - name: "Context injection"
+path: "/en/configuration/context-injection"
- name: "Reporter"
catalog:
- name: "Kafka Reporter"
diff --git a/src/lib.rs b/src/lib.rs
index 25a56a0..28ba16f 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -100,6 +100,12 @@ const SKYWALKING_AGENT_KAFKA_BOOTSTRAP_SERVERS: =
"skywalking_agent.kafka_b
/// Only available when the reporter type is `kafka`.
const SKYWALKING_AGENT_KAFKA_PRODUCER_CONFIG: =
"skywalking_agent.kafka_producer_config";
+/// Whether to enable automatic injection of skywalking context variables (such
+/// as `SW_TRACE_ID`). For `php-fpm` mode, it will be injected into the
+/// `$_SERVER` variable. For `swoole` mode, it will be injected into the
+/// `$request->server` variable.
+const SKYWALKING_AGENT_INJECT_CONTEXT: =
"skywalking_agent.inject_context";
+
#[php_get_module]
pub fn get_module() -> Module {
let mut module = Module::new(
@@ -180,6 +186,7 @@ pub fn get_module() -> Module {
"{}".to_string(),
Policy::System,
);
+module.add_ini(SKYWALKING_AGENT_INJECT_CONTEXT, false, Policy::System);
// Hooks.
module.on_module_init(module::init);
diff --git a/src/module.rs b/src/module.rs
index 93f0cc6..6d5d865 100644
--- a/src/module.rs
+++ b/src/module.rs
@@ -129,6 +129,9 @@ pub static KAFKA_BOOTSTRAP_SERVERS: Lazy =
pub static
Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng merged PR #107: URL: https://github.com/apache/skywalking-php/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955728454 > > > $spanId should not be for the entire request, right? > > > > > > It is not. It is variable according to span creation and stop status. > > I would like to implement $spanId in the future (if there is user demand) If that is the case, please remove segmentId as well, that is useless without span ID. Both IDs lock the specific span. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
jmjoy commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955725165 > > $spanId should not be for the entire request, right? > > It is not. It is variable according to span creation and stop status. I would like to implement $spanId in the future (if there is user demand) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955716258 > > How about $spanId? > > $spanId should not be for the entire request, right? It is not. It is variable according to span creation and stop status. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] skywalking-client-js supports Core Web Vitals metrics [skywalking]
wu-sheng closed issue #11902: [Feature] skywalking-client-js supports Core Web Vitals metrics URL: https://github.com/apache/skywalking/issues/11902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
jmjoy commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955693441 > How about $spanId? $spanId should not be for the entire request, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] skywalking-client-js supports Core Web Vitals metrics [skywalking]
tanshanshan opened a new issue, #11902:
URL: https://github.com/apache/skywalking/issues/11902
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar feature requirement.
### Description
skywalking-client-js is a library that provide metrics and error collection
, and sends them to the SkyWalking backend. Currently, it supports collecting
First Meaningful Paint (FMP) metric.
The goal is to also support collecting and displaying Largest Contentful
Paint (LCP), Cumulative Layout Shift (CLS), and First Input Delay (FID)
metrics, which are core web vitals proposed by Google. These is
These metrics are equally applicable in both Chrome and non-Chrome browsers.
### Use case
By referencing the repository https://github.com/GoogleChrome/web-vitals,
you can calculate metrics using ` import {onLCP, onFID, onCLS} from
'web-vitals' `statement and send them to the SkyWalking backend. The SkyWalking
backend will aggregate and display the metrics.
### Related issues
_No response_
### Are you willing to submit a pull request to implement this on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update i18n for rocketmq monitoring [skywalking-booster-ui]
wu-sheng commented on PR #359: URL: https://github.com/apache/skywalking-booster-ui/pull/359#issuecomment-1954215353 You could sync the UI submodule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update i18n for rocketmq monitoring [skywalking-booster-ui]
wu-sheng commented on PR #359: URL: https://github.com/apache/skywalking-booster-ui/pull/359#issuecomment-1954206722 @peachisai I think this is only about translation. The UI should work without this, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-booster-ui) branch main updated: Update i18n for rocketmq monitoring (#359)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git
The following commit(s) were added to refs/heads/main by this push:
new 73420366 Update i18n for rocketmq monitoring (#359)
73420366 is described below
commit 734203664685fc8b29e3d77e5a4b00ffc83876fd
Author: peachisai <2581009...@qq.com>
AuthorDate: Tue Feb 20 21:25:52 2024 +0800
Update i18n for rocketmq monitoring (#359)
---
src/locales/lang/menus/en.ts | 2 ++
src/locales/lang/menus/es.ts | 2 ++
src/locales/lang/menus/zh.ts | 2 ++
3 files changed, 6 insertions(+)
diff --git a/src/locales/lang/menus/en.ts b/src/locales/lang/menus/en.ts
index d878eefc..133e7eb7 100644
--- a/src/locales/lang/menus/en.ts
+++ b/src/locales/lang/menus/en.ts
@@ -108,6 +108,8 @@ const titles = {
mq_kafka_desc: "Provide Kafka monitoring through OpenTelemetry's Prometheus
Receiver.",
mq_pulsar: "Pulsar",
mq_pulsar_desc: "Provide Pulsar monitoring through OpenTelemetry's
Prometheus Receiver.",
+ mq_rocketmq: "RocketMQ",
+ mq_rocketmq_desc: "Provide RocketMQ monitoring through OpenTelemetry's
Prometheus Receiver.",
// self observability
self_observability: "Self Observability",
self_observability_desc:
diff --git a/src/locales/lang/menus/es.ts b/src/locales/lang/menus/es.ts
index e2f667e0..04a9ed08 100644
--- a/src/locales/lang/menus/es.ts
+++ b/src/locales/lang/menus/es.ts
@@ -108,6 +108,8 @@ const titles = {
mq_kafka_desc: "Provide Kafka monitoring through OpenTelemetry's Prometheus
Receiver.",
mq_pulsar: "Pulsar",
mq_pulsar_desc: "Provide Pulsar monitoring through OpenTelemetry's
Prometheus Receiver.",
+ mq_rocketmq: "RocketMQ",
+ mq_rocketmq_desc: "Provide RocketMQ monitoring through OpenTelemetry's
Prometheus Receiver.",
// self observability
self_observability: "Self Observability",
self_observability_desc:
diff --git a/src/locales/lang/menus/zh.ts b/src/locales/lang/menus/zh.ts
index 5149a7ff..48f649d2 100644
--- a/src/locales/lang/menus/zh.ts
+++ b/src/locales/lang/menus/zh.ts
@@ -96,6 +96,8 @@ const titles = {
mq_Kafka_desc: "通过OpenTelemetry的Prometheus接收器提供Kafka监控。",
mq_pulsar: "Pulsar",
mq_Pulsar_desc: "通过OpenTelemetry的Prometheus接收器提供Pulsar监控。",
+ mq_rocketmq: "RocketMQ",
+ mq_rocketmq_desc: "通过OpenTelemetry的Prometheus接收器提供RocketMQ监控。",
// self observability
self_observability: "自监控",
self_observability_desc: "自观察性为运行SkyWalking生态系统中的组件和服务器提供了可观察性。",
Re: [PR] Update i18n for rocketmq monitoring [skywalking-booster-ui]
wu-sheng merged PR #359: URL: https://github.com/apache/skywalking-booster-ui/pull/359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update i18n for rocketmq monitoring [skywalking-booster-ui]
peachisai commented on PR #359: URL: https://github.com/apache/skywalking-booster-ui/pull/359#issuecomment-1954213885 > Update i18n for rocketmq monitoring Yes,I just remenber it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a new menu for rocketmq monitoring [skywalking-booster-ui]
peachisai commented on PR #359: URL: https://github.com/apache/skywalking-booster-ui/pull/359#issuecomment-1954203392 @wu-sheng Hello, Should this be mentioned? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support rocketmq monitoring [skywalking]
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954159953 > @peachisai Are you working on the showcase or the blog? @wankai123 Should we consider this as a part of showcase? Or the showcase is already too complex? Yes, I have tried to test the showcase locally, and now I am trying to establish the local environment. These days, I'm a little busy, but it is in process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support rocketmq monitoring [skywalking]
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954131649 OK. But I think we should be careful about whether activate this on the demo.skywalking.a.o. We have a heavy resource requirement of CPU and Memory already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support rocketmq monitoring [skywalking]
wankai123 commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954129406 > Should we consider this as a part of showcase? Or the showcase is already too complex? The rocketMQ monitoring could be added to the `ShowCase` first, this part is not complex. After that, we can consider whether to add it to the `sample services` for VirtualMQ. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1954108830 And please update the docs according, after you added the span ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support rocketmq monitoring [skywalking]
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954072644 @peachisai Are you working on the showcase or the blog? @wankai123 Should we consider this as a part of showcase? Or the showcase is already too complex? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]
wu-sheng merged PR #11901: URL: https://github.com/apache/skywalking/pull/11901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch master updated: Mock `/api/v1/status/buildinfo` for PromQL API (#11901)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new a41bd6eddd Mock `/api/v1/status/buildinfo` for PromQL API (#11901)
a41bd6eddd is described below
commit a41bd6eddd27277706b280105de978f099d70ce9
Author: Wan Kai
AuthorDate: Tue Feb 20 19:21:22 2024 +0800
Mock `/api/v1/status/buildinfo` for PromQL API (#11901)
---
docs/en/changes/changes.md | 1 +
docs/en/setup/backend/configuration-vocabulary.md | 6 +
.../skywalking/oap/query/promql/PromQLConfig.java | 8 +++
.../oap/query/promql/PromQLProvider.java | 2 +-
.../{PromQLConfig.java => entity/BuildInfo.java} | 27 +++---
.../response/BuildInfoRsp.java}| 21 +++--
.../oap/query/promql/handler/PromQLApiHandler.java | 21 -
.../src/main/resources/application.yml | 7 ++
8 files changed, 65 insertions(+), 28 deletions(-)
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index f63a3cd727..abd3db6f1f 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -51,6 +51,7 @@
- ROCKETMQ -> K8S_SERVICE
- VIRTUAL_MQ -> ROCKETMQ
* Fix ServiceInstance `in` query.
+* Mock `/api/v1/status/buildinfo` for PromQL API.
* Fix table exists check in the JDBC Storage Plugin.
UI
diff --git a/docs/en/setup/backend/configuration-vocabulary.md
b/docs/en/setup/backend/configuration-vocabulary.md
index 25dea0650c..3b30be2475 100644
--- a/docs/en/setup/backend/configuration-vocabulary.md
+++ b/docs/en/setup/backend/configuration-vocabulary.md
@@ -265,6 +265,12 @@ The Configuration Vocabulary lists all available
configurations provided by `app
| - | - | restMaxThreads
| Maximum thread number
of RESTful services.
[...]
| - | - | restIdleTimeOut
| Connector idle timeout
of RESTful services (in milliseconds).
[...]
| - | - | restAcceptQueueSize
| Maximum request header
size accepted.
[...]
+| - | - | buildInfoVersion
| Mock version for API
buildInfo
[...]
+| - | - | buildInfoRevision
| Mock revision for API
buildInfo
[...]
+| - | - | buildInfoBranch
| Mock branch for API
buildInfo
[...]
+| - | - | buildInfoBuildUser
Re: [I] [Feature] Implement parts of Prometheus `status` HTTP API [skywalking]
wu-sheng closed issue #11714: [Feature] Implement parts of Prometheus `status` HTTP API URL: https://github.com/apache/skywalking/issues/11714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-195384 > > Should we consider the whole trace context? > > $serviceName, $instanceName, $traceId, $traceSegmentId are injected. How about $spanId? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]
wu-sheng commented on code in PR #11901:
URL: https://github.com/apache/skywalking/pull/11901#discussion_r1495533200
##
oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/PromQLConfig.java:
##
@@ -31,4 +31,12 @@ public class PromQLConfig extends ModuleConfig {
private int restMaxThreads = 200;
private long restIdleTimeOut = 3;
private int restAcceptQueueSize = 0;
+
+// SkyWalking supported basic metrics query API in Prometheus 2.45, and it
is a LTS version, the API should stable, set as default.
+private String buildInfoVersion = "2.45.0";
Review Comment:
```suggestion
private String buildInfoVersion = "2.45.0"; // Declare compatibility
with 2.45 LTS version APIs.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]
wu-sheng commented on code in PR #11901:
URL: https://github.com/apache/skywalking/pull/11901#discussion_r1495531905
##
oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/PromQLConfig.java:
##
@@ -31,4 +31,12 @@ public class PromQLConfig extends ModuleConfig {
private int restMaxThreads = 200;
private long restIdleTimeOut = 3;
private int restAcceptQueueSize = 0;
+
+// SkyWalking supported basic metrics query API in Prometheus 2.45, and it
is a LTS version, the API should stable, set as default.
Review Comment:
```suggestion
// The following configs are used to build `/api/v1/status/buildinfo`
API response.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]
wu-sheng commented on code in PR #11901:
URL: https://github.com/apache/skywalking/pull/11901#discussion_r1495531006
##
oap-server/server-starter/src/main/resources/application.yml:
##
@@ -443,6 +443,13 @@ promql:
restMaxThreads: ${SW_PROMQL_REST_MAX_THREADS:200}
restIdleTimeOut: ${SW_PROMQL_REST_IDLE_TIMEOUT:3}
restAcceptQueueSize: ${SW_PROMQL_REST_QUEUE_SIZE:0}
+# The below config is for the API buildInfo, set the value to mock the
build info.
Review Comment:
```suggestion
# The below configs are used to build `/api/v1/status/buildinfo` API
response.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-go) branch main updated: fix sql instrument with DBQueryContext (#168)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-go.git
The following commit(s) were added to refs/heads/main by this push:
new 140c58d fix sql instrument with DBQueryContext (#168)
140c58d is described below
commit 140c58d3991786942ca759cc254e1891e09dd49b
Author: GlqEason <36256450+glqea...@users.noreply.github.com>
AuthorDate: Tue Feb 20 17:48:11 2024 +0800
fix sql instrument with DBQueryContext (#168)
---
CHANGES.md| 1 +
plugins/sql/entry/span.go | 9 -
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/CHANGES.md b/CHANGES.md
index 9e329ec..6c55762 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -25,6 +25,7 @@ Release Notes.
* Fix wrong tracing context when trace have been sampled.
* Fix enhance param error when there are multiple params.
* Fix lost trace when multi middleware `handlerFunc` in `gin` plugin.
+* Fix DBQueryContext execute error in `sql` plugin.
Issues and PR
- All issues are
[here](https://github.com/apache/skywalking/milestone/197?closed=1)
diff --git a/plugins/sql/entry/span.go b/plugins/sql/entry/span.go
index e60f194..be3264b 100644
--- a/plugins/sql/entry/span.go
+++ b/plugins/sql/entry/span.go
@@ -54,6 +54,13 @@ func getInstanceInfo(caller interface{}) InstanceInfo {
if !ok || instance == nil {
return nil
}
- info := instance.GetSkyWalkingDynamicField().(InstanceInfo)
+ df := instance.GetSkyWalkingDynamicField()
+ if df == nil {
+ return nil
+ }
+ info, ok := df.(InstanceInfo)
+ if !ok {
+ return nil
+ }
return info
}
Re: [PR] fix sql instrument with DBQueryContext [skywalking-go]
wu-sheng merged PR #168: URL: https://github.com/apache/skywalking-go/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
jmjoy commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1953830055 > Should we consider the whole trace context? $serviceName, $instanceName, $traceId, $traceSegmentId are injected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]
wu-sheng commented on code in PR #11901:
URL: https://github.com/apache/skywalking/pull/11901#discussion_r1495424254
##
oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/entity/BuildInfo.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.query.promql.entity;
+
+import lombok.Data;
+
+/**
+ * Mock build info for PromQL API, sometimes the client(such as Grafana) use
it to detect the version of the data-source server
+ * for different API support. SkyWalking supported basic metrics query API in
Prometheus 2.45, and it is a LTS version, the API should stable.
+ */
+@Data
+public class BuildInfo {
+private String version = "2.45.0";
+private String revision = "";
+private String branch = "";
+private String buildUser = "";
+private String buildDate = "";
+private String goVersion = "";
Review Comment:
Could we expose this to application.yml? Maybe next time, if some
configurations are required, we could fix not through code changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Mock `/api/v1/status/buildinfo` for PromQL API [skywalking]
wankai123 opened a new pull request, #11901: URL: https://github.com/apache/skywalking/pull/11901 - [X] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #11714. - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
