[PR] Update overview.md [skywalking-rover]
wu-sheng opened a new pull request, #116: URL: https://github.com/apache/skywalking-rover/pull/116 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Overlay display wrongly solved [skywalking-banyandb]
wu-sheng commented on PR #401: URL: https://github.com/apache/skywalking-banyandb/pull/401#issuecomment-1980276249 > Please include a brief video that displays your outcome. @hanahmily The recorded video is here, https://github.com/apache/skywalking/issues/11978#issuecomment-1980266070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug][BanyanDB-UI] Overlay display wrongly [skywalking]
Muyu-art commented on issue #11978: URL: https://github.com/apache/skywalking/issues/11978#issuecomment-1980266070 [2024-03-06 15-36-47.webm](https://github.com/apache/skywalking/assets/72800755/f8d0164f-80cf-4e23-8407-95edc3bb9883) I closed the back end and reproduced the above problem. Troubleshooting revealed that in the getGroupList function, the mask could not be closed because the data could not be requested and no subsequent processing was done. I added $loadingClose() at the end of the function, which solved the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Metrics are not aggregated properly as OTEL collector targeting per node [skywalking]
wu-sheng commented on issue #11982:
URL: https://github.com/apache/skywalking/issues/11982#issuecomment-1980252064
In your case, the data in the DB should be `http_status_401{192.168.0.1=5,
192.168.0.3=1, 192.168.0.2=2}`. Please verify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] Metrics are not aggregated properly as OTEL collector targeting per node [skywalking]
wu-sheng commented on issue #11982:
URL: https://github.com/apache/skywalking/issues/11982#issuecomment-1980250350
I don't think we support multiple labels after you have done the persistent.
```
http_status{host=192.168.0.1, status=401} 5
http_status{host=192.168.0.3, status=401} 1
http_status{host=192.168.0.2, status=401} 2
```
This is not a proper example, because OAP doesn't persistent data like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] Metrics are not aggregated properly as OTEL collector targeting per node [skywalking]
pg-yang commented on issue #11982:
URL: https://github.com/apache/skywalking/issues/11982#issuecomment-1980247042
To build service level metrics with instance/node level metrics through
`AggregateLabels Operation`, I think `AggregateLabels` should support
aggregation through specified labels. Like the scenario below:
instance/node HTTP status metrics
```
# The number means the occurred times
http_status{host=192.168.0.1, status=401} 5
http_status{host=192.168.0.3, status=401} 1
http_status{host=192.168.0.2, status=401} 2
```
The MQE express to aggregate service level metrics should be
```
aggregate_labels(http_status,'status',sum) # aggregate by status label
```
The result will be
```
http_status{status=401} 8
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug][BanyanDB-UI] Overlay display wrongly [skywalking]
Muyu-art commented on issue #11978: URL: https://github.com/apache/skywalking/issues/11978#issuecomment-1980241816 OK, I will try other video formats -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug][BanyanDB-UI] Overlay display wrongly [skywalking]
wu-sheng commented on issue #11978: URL: https://github.com/apache/skywalking/issues/11978#issuecomment-1980239165 I have tried to download the file, still not working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI improved in Not Found View [skywalking-banyandb]
sivasathyaseeelan commented on code in PR #395: URL: https://github.com/apache/skywalking-banyandb/pull/395#discussion_r1513941304 ## ui/src/views/404/NotFound.vue: ## Review Comment: I will change it to Errors instead of 404! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
Sylvie-Wxr commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513940806
##
ui/src/components/Read/index.vue:
##
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
-if (isDatePicker.value) {
-let json = yamlToJson(data.code)
-const begin = new Date()
-const end = new Date()
-const oldBeginDate = new Date(json.data.timeRange.begin)
-const oldEndDate = new Date(json.data.timeRange.end)
-const interval = oldEndDate.getTime() - oldBeginDate.getTime()
+let json = yamlToJson(data.code)
+const begin = new Date()
+const end = new Date()
+const oldBeginDate = new Date(json.data.timeRange.begin)
+const oldEndDate = new Date(json.data.timeRange.end)
+const interval = oldEndDate.getTime() - oldBeginDate.getTime()
-if (interval === last15Minutes.value) {
-begin.setTime(begin.getTime() - last15Minutes.value)
-} else if (interval === lastWeek.value) {
-begin.setTime(begin.getTime() - lastWeek.value)
-} else if (interval === lastMonth.value) {
-begin.setTime(begin.getTime() - lastMonth.value)
-} else if (interval === last3Months.value) {
-begin.setTime(begin.getTime() - last3Months.value)
-}
-json.data.timeRange.begin = begin.toISOString()
-json.data.timeRange.end = end.toISOString()
-data.code = jsonToYaml(json.data).data
+if (interval === last15Minutes) {
+begin.setTime(begin.getTime() - last15Minutes)
+} else if (interval === lastWeek) {
+begin.setTime(begin.getTime() - lastWeek)
+} else if (interval === lastMonth) {
+begin.setTime(begin.getTime() - lastMonth)
+} else if (interval === last3Months) {
+begin.setTime(begin.getTime() - last3Months)
Review Comment:
Removed these code. Please verify the new video demo. Thanks a lot.
##
ui/src/components/Read/index.vue:
##
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
-if (isDatePicker.value) {
Review Comment:
Changed accordingly and upated the description. Please verify the new video
demo. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: 6c64754427c97bec1d578e74ff8454804c8afe77
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 0f1466cdbf9 deploy: 6c64754427c97bec1d578e74ff8454804c8afe77 0f1466cdbf9 is described below commit 0f1466cdbf9d6916cda829878bedbbf5d0d030e2 Author: wu-sheng AuthorDate: Wed Mar 6 07:13:46 2024 + deploy: 6c64754427c97bec1d578e74ff8454804c8afe77 --- contributors/index.html| 22 ++ .../next/api-reference/index.html | 2 +- docs/skywalking-banyandb/next/clients/index.html | 2 +- .../next/concept/clustering/index.html | 2 +- .../next/concept/data-model/index.html | 2 +- .../next/concept/persistence-storage/index.html| 2 +- .../next/concept/tsdb/index.html | 2 +- .../next/concept/wal/index.html| 2 +- .../skywalking-banyandb/next/crud/group/index.html | 2 +- .../next/crud/index_rule/index.html| 2 +- .../next/crud/index_rule_binding/index.html| 2 +- .../next/crud/measure/query/index.html | 2 +- .../next/crud/measure/schema/index.html| 2 +- .../next/crud/property/index.html | 2 +- .../next/crud/stream/query/index.html | 2 +- .../next/crud/stream/schema/index.html | 2 +- .../next/installation/binaries/index.html | 2 +- .../next/installation/cluster/index.html | 2 +- .../next/installation/index.html | 2 +- .../next/installation/standalone/index.html| 2 +- .../next/observability/index.html | 2 +- docs/skywalking-banyandb/next/readme/index.html| 2 +- docs/skywalking-banyandb/next/release/index.html | 4 ++-- index.html | 2 +- index.json | 2 +- team/index.html| 14 -- 26 files changed, 55 insertions(+), 31 deletions(-) diff --git a/contributors/index.html b/contributors/index.html index 9c64f795009..9a4bd87ad33 100644 --- a/contributors/index.html +++ b/contributors/index.html @@ -20365,7 +20365,7 @@ -221 +222 1 @@ -20623,6 +20623,20 @@ + + +https://github.com/Sylvie-Wxr; target="_blank"> + + Sylvie-Wxr + + + +1 +20 + + + + https://github.com/achintya-7; target="_blank"> @@ -20632,7 +20646,7 @@ 1 -20 +21 @@ -20646,7 +20660,7 @@ 1 -21 +22 @@ -20660,7 +20674,7 @@ 1 -22 +23 diff --git a/docs/skywalking-banyandb/next/api-reference/index.html b/docs/skywalking-banyandb/next/api-reference/index.html index 05b441092a0..3fa81e21f7c 100644 --- a/docs/skywalking-banyandb/next/api-reference/index.html +++ b/docs/skywalking-banyandb/next/api-reference/index.html @@ -584,7 +584,7 @@ Table of Contents banyandb/cluster/v1/rpc.proto })() - Commit Id: 2ded410 + Commit Id: f27bbf2 diff --git a/docs/skywalking-banyandb/next/clients/index.html b/docs/skywalking-banyandb/next/clients/index.html index 79af8f8ae42..ae540ee9cc1 100644 --- a/docs/skywalking-banyandb/next/clients/index.html +++ b/docs/skywalking-banyandb/next/clients/index.html @@ -530,7 +530,7 @@ These are several ways to install: })() - Commit Id: 2ded410 + Commit Id: f27bbf2 diff --git a/docs/skywalking-banyandb/next/concept/clustering/index.html b/docs/skywalking-banyandb/next/concept/clustering/index.html index 6a36d5a8219..59afe25262f 100644 --- a/docs/skywalking-banyandb/next/concept/clustering/index.html +++ b/docs/skywalking-banyandb/next/concept/clustering/index.html @@ -530,7 +530,7 @@ })() -
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
Sylvie-Wxr commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513940806
##
ui/src/components/Read/index.vue:
##
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
-if (isDatePicker.value) {
-let json = yamlToJson(data.code)
-const begin = new Date()
-const end = new Date()
-const oldBeginDate = new Date(json.data.timeRange.begin)
-const oldEndDate = new Date(json.data.timeRange.end)
-const interval = oldEndDate.getTime() - oldBeginDate.getTime()
+let json = yamlToJson(data.code)
+const begin = new Date()
+const end = new Date()
+const oldBeginDate = new Date(json.data.timeRange.begin)
+const oldEndDate = new Date(json.data.timeRange.end)
+const interval = oldEndDate.getTime() - oldBeginDate.getTime()
-if (interval === last15Minutes.value) {
-begin.setTime(begin.getTime() - last15Minutes.value)
-} else if (interval === lastWeek.value) {
-begin.setTime(begin.getTime() - lastWeek.value)
-} else if (interval === lastMonth.value) {
-begin.setTime(begin.getTime() - lastMonth.value)
-} else if (interval === last3Months.value) {
-begin.setTime(begin.getTime() - last3Months.value)
-}
-json.data.timeRange.begin = begin.toISOString()
-json.data.timeRange.end = end.toISOString()
-data.code = jsonToYaml(json.data).data
+if (interval === last15Minutes) {
+begin.setTime(begin.getTime() - last15Minutes)
+} else if (interval === lastWeek) {
+begin.setTime(begin.getTime() - lastWeek)
+} else if (interval === lastMonth) {
+begin.setTime(begin.getTime() - lastMonth)
+} else if (interval === last3Months) {
+begin.setTime(begin.getTime() - last3Months)
Review Comment:
Removed these code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
Sylvie-Wxr commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513940477
##
ui/src/components/Read/index.vue:
##
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
-if (isDatePicker.value) {
Review Comment:
Changed accordingly and upated the description. Please verify the new video
demo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug][BanyanDB-UI] Overlay display wrongly [skywalking]
Muyu-art commented on issue #11978: URL: https://github.com/apache/skywalking/issues/11978#issuecomment-1980218485 https://github.com/apache/skywalking/assets/72800755/bfab50e3-ec7b-4aa4-bd7d-114b0eabd532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug][BanyanDB-UI] Overlay display wrongly [skywalking]
wu-sheng commented on issue #11978: URL: https://github.com/apache/skywalking/issues/11978#issuecomment-1980212703 This video seems not to play properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug][BanyanDB-UI] Overlay display wrongly [skywalking]
Muyu-art commented on issue #11978: URL: https://github.com/apache/skywalking/issues/11978#issuecomment-1980210429 https://github.com/apache/skywalking/assets/72800755/593669a4-b665-439a-9f98-ae998c6b1e6e I have solved this issue, here is a brief video to introduce the outcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch main updated: [UI] Use BanyanDB Browser' Icon and Remove Unused Buttons (#402)
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new f27bbf2d [UI] Use BanyanDB Browser' Icon and Remove Unused Buttons
(#402)
f27bbf2d is described below
commit f27bbf2d7c19cddd1f3b793a0e83ab600eba13e9
Author: Sylvie-Wxr <129717259+sylvie-...@users.noreply.github.com>
AuthorDate: Tue Mar 5 22:53:55 2024 -0800
[UI] Use BanyanDB Browser' Icon and Remove Unused Buttons (#402)
---
ui/index.html | 4 ++--
ui/public/banyandb.ico | Bin 0 -> 4286 bytes
ui/src/components/Header/components/header.vue | 12 ++--
3 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/ui/index.html b/ui/index.html
index 7ea20fc2..9abfda1e 100644
--- a/ui/index.html
+++ b/ui/index.html
@@ -21,9 +21,9 @@
-
+
-Vite App
+Banyan DB
diff --git a/ui/public/banyandb.ico b/ui/public/banyandb.ico
new file mode 100644
index ..fe19c13e
Binary files /dev/null and b/ui/public/banyandb.ico differ
diff --git a/ui/src/components/Header/components/header.vue
b/ui/src/components/Header/components/header.vue
index f34107d2..d5772791 100644
--- a/ui/src/components/Header/components/header.vue
+++ b/ui/src/components/Header/components/header.vue
@@ -110,14 +110,7 @@ initData()
Property
-
-
-
-
-
-
-
-Admin
+
@@ -154,9 +147,8 @@ initData()
justify-content: center;
}
-.person {
+.flex-block {
width: 140px;
-height: 100%;
margin-right: 30px;
}
Re: [PR] [UI] Use BanyanDB Browser' Icon and Remove Unused Buttons [skywalking-banyandb]
hanahmily merged PR #402: URL: https://github.com/apache/skywalking-banyandb/pull/402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [BanyanDB-UI] Beautify Some Pages [skywalking]
hanahmily closed issue #11977: [BanyanDB-UI] Beautify Some Pages URL: https://github.com/apache/skywalking/issues/11977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [UI] Use BanyanDB Browser' Icon and Remove Unused Buttons [skywalking-banyandb]
codecov-commenter commented on PR #402: URL: https://github.com/apache/skywalking-banyandb/pull/402#issuecomment-1980190696 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/402?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 48.31%. Comparing base [(`71ad3c6`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/71ad3c681b2c155bfffdb869f137ff2fcfa73997?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`ddd36b4`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/402?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@Coverage Diff @@ ## main #402 +/- ## == - Coverage 48.35% 48.31% -0.05% == Files 173 173 Lines 2156621566 == - Hits1042910419 -10 - Misses 1026510273 +8 - Partials 872 874 +2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/402?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [BanyanDB-UI] Use BanyanDB Browser' Icon and Remove Unused Buttons [skywalking-banyandb]
Sylvie-Wxr opened a new pull request, #402: URL: https://github.com/apache/skywalking-banyandb/pull/402 ### - [ ] If this is non-trivial feature, paste the links/URLs to the design doc. - [ ] Update the documentation to include this new feature. - [ ] Tests(including UT, IT, E2E) are added to verify the new feature. - [x] If it's UI related, attach the screenshots below. - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#11977. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). ### Feature Description: 1. Removed Unused Buttons in red box 2. Use the BanyanDB Icon as the Browser's Icon 3. Update Browser Title to "BanyanDB"  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature][BanyanDB] Support for Tags and Fields TTL [skywalking]
hanahmily opened a new issue, #11987: URL: https://github.com/apache/skywalking/issues/11987 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description I suggest adding a new feature to BanyanDB that supports TTL (Time to Live) for tags and fields. This feature would enable BanyanDB to automatically remove specific tag or field data based on the TTL rules defined on a Group. Currently, BanyanDB only supports TTL for the entire Group, which means that data can accumulate indefinitely, potentially causing storage issues. By implementing TTL for tags and fields, only relevant and recent data will be stored, which optimizes storage usage. Furthermore, the proposed [hot-warm-cold architecture](#11945) could be utilized to set different TTL for cold, warm, or hot data, respectively. ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Temporary testing windows docker image [skywalking-banyandb]
hanahmily commented on code in PR #400: URL: https://github.com/apache/skywalking-banyandb/pull/400#discussion_r1513854636 ## .github/workflows/e2e.storage.yml: ## @@ -31,24 +31,31 @@ concurrency: jobs: StoragePlugins: -if: (github.event_name == 'schedule' && github.repository == 'apache/skywalking-banyandb') || (github.event_name != 'schedule') name: Storage E2E -runs-on: ubuntu-latest Review Comment: You might still use Ubuntu to compile a windows arch binary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Overlay display wrongly solved [skywalking-banyandb]
hanahmily commented on PR #401: URL: https://github.com/apache/skywalking-banyandb/pull/401#issuecomment-1980130373 Please include a brief video that displays your outcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
hanahmily commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513851766
##
ui/src/components/Read/index.vue:
##
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
-if (isDatePicker.value) {
-let json = yamlToJson(data.code)
-const begin = new Date()
-const end = new Date()
-const oldBeginDate = new Date(json.data.timeRange.begin)
-const oldEndDate = new Date(json.data.timeRange.end)
-const interval = oldEndDate.getTime() - oldBeginDate.getTime()
+let json = yamlToJson(data.code)
+const begin = new Date()
+const end = new Date()
+const oldBeginDate = new Date(json.data.timeRange.begin)
+const oldEndDate = new Date(json.data.timeRange.end)
+const interval = oldEndDate.getTime() - oldBeginDate.getTime()
-if (interval === last15Minutes.value) {
-begin.setTime(begin.getTime() - last15Minutes.value)
-} else if (interval === lastWeek.value) {
-begin.setTime(begin.getTime() - lastWeek.value)
-} else if (interval === lastMonth.value) {
-begin.setTime(begin.getTime() - lastMonth.value)
-} else if (interval === last3Months.value) {
-begin.setTime(begin.getTime() - last3Months.value)
-}
-json.data.timeRange.begin = begin.toISOString()
-json.data.timeRange.end = end.toISOString()
-data.code = jsonToYaml(json.data).data
+if (interval === last15Minutes) {
+begin.setTime(begin.getTime() - last15Minutes)
+} else if (interval === lastWeek) {
+begin.setTime(begin.getTime() - lastWeek)
+} else if (interval === lastMonth) {
+begin.setTime(begin.getTime() - lastMonth)
+} else if (interval === last3Months) {
+begin.setTime(begin.getTime() - last3Months)
Review Comment:
There is a bug here
The "last xx" dynamic time range type cannot be determined by the interval.
If a user selects a fixed time range such as "last 15 minutes", the component
will not update the time range upon clicking the search button.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
hanahmily commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513849135
##
ui/src/components/Read/index.vue:
##
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
-if (isDatePicker.value) {
Review Comment:
If a fixed time range is selected, the start and end should remain unchanged
whenever you click "" or "↻". That's why you have to use a variable to mark
this status.
The fixed time range allows users to select specific data within a certain
time range without having to change the time when clicking searching or
refreshing buttons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Overlay display wrongly solved [skywalking-banyandb]
codecov-commenter commented on PR #401: URL: https://github.com/apache/skywalking-banyandb/pull/401#issuecomment-1980011458 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/401?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 48.28%. Comparing base [(`71ad3c6`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/71ad3c681b2c155bfffdb869f137ff2fcfa73997?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`bf86fc4`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/401?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@Coverage Diff @@ ## main #401 +/- ## == - Coverage 48.35% 48.28% -0.08% == Files 173 173 Lines 2156621566 == - Hits1042910413 -16 - Misses 1026510277 +12 - Partials 872 876 +4 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/401?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Overlay display wrongly solved [skywalking-banyandb]
wu-sheng commented on PR #401: URL: https://github.com/apache/skywalking-banyandb/pull/401#issuecomment-1980006047 You should update the PR template to add fixed issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Overlay display wrongly solved [skywalking-banyandb]
Muyu-art opened a new pull request, #401: URL: https://github.com/apache/skywalking-banyandb/pull/401 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Temporary testing windows docker image [skywalking-banyandb]
codecov-commenter commented on PR #400: URL: https://github.com/apache/skywalking-banyandb/pull/400#issuecomment-1979970338 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/400?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 48.28%. Comparing base [(`71ad3c6`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/71ad3c681b2c155bfffdb869f137ff2fcfa73997?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`4c90651`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/400?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@Coverage Diff @@ ## main #400 +/- ## == - Coverage 48.34% 48.28% -0.07% == Files 173 173 Lines 2156621566 == - Hits1042710414 -13 - Misses 1026710276 +9 - Partials 872 876 +4 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/400?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Temporary testing windows docker image [skywalking-banyandb]
mrproliu opened a new pull request, #400: URL: https://github.com/apache/skywalking-banyandb/pull/400 Used to test whether banyandb-server can build images in Windows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support deployment in cluster mode [skywalking-banyandb-helm]
ButterBright commented on PR #7: URL: https://github.com/apache/skywalking-banyandb-helm/pull/7#issuecomment-1979942806 Okay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support deployment in cluster mode [skywalking-banyandb-helm]
wu-sheng commented on PR #7: URL: https://github.com/apache/skywalking-banyandb-helm/pull/7#issuecomment-1979941543 Could you add a two nodes BanyanDB cluster to verify your helm? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch win deleted (was 18c5951e)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch win in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was 18c5951e Remove sync operations The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking-banyandb) branch main updated: Remove redundant sync operation in fs (#399)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 71ad3c68 Remove redundant sync operation in fs (#399)
71ad3c68 is described below
commit 71ad3c681b2c155bfffdb869f137ff2fcfa73997
Author: Gao Hongtao
AuthorDate: Wed Mar 6 09:49:31 2024 +0800
Remove redundant sync operation in fs (#399)
---
.github/workflows/flaky-test.yml| 4 ++--
pkg/fs/local_file_system.go | 23 +++
pkg/fs/local_file_system_nix.go | 10 ++
pkg/fs/local_file_system_windows.go | 4
test/stress/cases/istio/istio_suite_test.go | 13 +++--
5 files changed, 26 insertions(+), 28 deletions(-)
diff --git a/.github/workflows/flaky-test.yml b/.github/workflows/flaky-test.yml
index 3420da1d..e789870c 100644
--- a/.github/workflows/flaky-test.yml
+++ b/.github/workflows/flaky-test.yml
@@ -28,5 +28,5 @@ jobs:
if: github.repository == 'apache/skywalking-banyandb'
uses: ./.github/workflows/test.yml
with:
- options: --repeat 49 --label-filter '(integration&&!slow)||banyand'
- timeout-minutes: 40
+ options: --repeat 3 --label-filter '(integration&&!slow)||banyand'
+ timeout-minutes: 50
diff --git a/pkg/fs/local_file_system.go b/pkg/fs/local_file_system.go
index 7a8b1904..b943a6f1 100644
--- a/pkg/fs/local_file_system.go
+++ b/pkg/fs/local_file_system.go
@@ -100,7 +100,7 @@ func (fs *localFileSystem) mkdir(path string, permission
Mode) {
fs.logger.Panic().Str("path", path).Err(err).Msg("failed to
create directory")
}
parentDirPath := filepath.Dir(path)
- fs.syncPath(parentDirPath)
+ fs.SyncPath(parentDirPath)
}
func (fs *localFileSystem) pathExist(path string) bool {
@@ -113,20 +113,6 @@ func (fs *localFileSystem) pathExist(path string) bool {
return true
}
-func (fs *localFileSystem) syncPath(path string) {
- d, err := os.Open(path)
- if err != nil {
- fs.logger.Panic().Str("path", path).Err(err).Msg("failed to
open directory")
- }
- if err := d.Sync(); err != nil {
- _ = d.Close()
- fs.logger.Panic().Str("path", path).Err(err).Msg("failed to
sync directory")
- }
- if err := d.Close(); err != nil {
- fs.logger.Panic().Str("path", path).Err(err).Msg("ailed to sync
directory")
- }
-}
-
func (fs *localFileSystem) ReadDir(dirname string) []DirEntry {
des, err := os.ReadDir(dirname)
if err != nil {
@@ -418,11 +404,8 @@ func (file *LocalFile) Path() string {
// Close is used to close File.
func (file *LocalFile) Close() error {
- if err := file.file.Sync(); err != nil {
- return {
- Code:closeError,
- Message: fmt.Sprintf("Close File error, directory name:
%s, error message: %s", file.file.Name(), err),
- }
+ if err := syncFile(file.file); err != nil {
+ return err
}
if err := file.file.Close(); err != nil {
diff --git a/pkg/fs/local_file_system_nix.go b/pkg/fs/local_file_system_nix.go
index 75db2649..4f2ebf0a 100644
--- a/pkg/fs/local_file_system_nix.go
+++ b/pkg/fs/local_file_system_nix.go
@@ -72,3 +72,13 @@ func (fs *localFileSystem) SyncPath(name string) {
fs.logger.Panic().Str("name", name).Err(err).Msg("failed to
close file")
}
}
+
+func syncFile(file *os.File) error {
+ if err := file.Sync(); err != nil {
+ return {
+ Code:flushError,
+ Message: fmt.Sprintf("Flush File error, directory name:
%s, error message: %s", file.Name(), err),
+ }
+ }
+ return nil
+}
diff --git a/pkg/fs/local_file_system_windows.go
b/pkg/fs/local_file_system_windows.go
index ab6d5c91..969babc6 100644
--- a/pkg/fs/local_file_system_windows.go
+++ b/pkg/fs/local_file_system_windows.go
@@ -59,3 +59,7 @@ func (*localFileSystem) CreateLockFile(name string,
permission Mode) (File, erro
}
func (fs *localFileSystem) SyncPath(_ string) {}
+
+func syncFile(_ *os.File) error {
+ return nil
+}
diff --git a/test/stress/cases/istio/istio_suite_test.go
b/test/stress/cases/istio/istio_suite_test.go
index a191a2fc..5377b72e 100644
--- a/test/stress/cases/istio/istio_suite_test.go
+++ b/test/stress/cases/istio/istio_suite_test.go
@@ -25,6 +25,7 @@ import (
"io"
"os"
"path/filepath"
+ "sync/atomic"
"testing"
"time"
@@ -103,8 +104,8 @@ var _ = g.Describe("Istio", func() {
fmt.Printf("written %d items in %s\n", writtenCount,
endTime.Sub(startTime).String())
fmt.Printf("throughput: %f items/s\n",
Re: [I] [Bug] Synchronization Error When OAP Accesses BanyanDB on Windows [skywalking]
wu-sheng closed issue #11986: [Bug] Synchronization Error When OAP Accesses BanyanDB on Windows URL: https://github.com/apache/skywalking/issues/11986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove redundant sync operation in fs [skywalking-banyandb]
wu-sheng merged PR #399: URL: https://github.com/apache/skywalking-banyandb/pull/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support ClickHouse server monitoring & Support service hierarchy [skywalking]
wankai123 commented on code in PR #11966:
URL: https://github.com/apache/skywalking/pull/11966#discussion_r1513702487
##
oap-server/server-starter/src/main/resources/otel-rules/clickhouse/clickhouse-instance.yaml:
##
@@ -0,0 +1,173 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This will parse a textual representation of a duration. The formats
+# accepted are based on the ISO-8601 duration format {@code PnDTnHnMn.nS}
+# with days considered to be exactly 24 hours.
+#
+# Examples:
+#
+#"PT20.345S" -- parses as "20.345 seconds"
+#"PT15M" -- parses as "15 minutes" (where a minute is 60 seconds)
+#"PT10H" -- parses as "10 hours" (where an hour is 3600 seconds)
+#"P2D" -- parses as "2 days" (where a day is 24 hours or 86400
seconds)
+#"P2DT3H4M" -- parses as "2 days, 3 hours and 4 minutes"
+#"P-6H3M"-- parses as "-6 hours and +3 minutes"
+#"-P6H3M"-- parses as "-6 hours and -3 minutes"
+#"-P-6H+3M" -- parses as "+6 hours and -3 minutes"
+#
+filter: "{ tags -> tags.job_name == 'clickhouse-monitoring' }" # The
OpenTelemetry job name
+expSuffix: tag({tags -> tags.host_name = 'clickhouse::' +
tags.host_name}).service(['host_name'] ,
Layer.CLICKHOUSE).instance(['host_name'], ['service_instance_id'],
Layer.CLICKHOUSE)
Review Comment:
```suggestion
expSuffix: tag({tags -> tags.host_name = 'clickhouse::' +
tags.host_name}).instance(['host_name'], ['service_instance_id'],
Layer.CLICKHOUSE)
```
we don't need additional service-level function here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix 11273 remove exception log is output in console [skywalking-banyandb]
Fine0830 commented on code in PR #396:
URL:
https://github.com/apache/skywalking-banyandb/pull/396#discussion_r1513694245
##
ui/src/components/Read/index.vue:
##
@@ -184,8 +184,10 @@ watch(() => data.code, () => {
if (index >= 0) {
data.codeStorage[index].params.code = data.code
} else {
+
route.params.code = data.code
-data.codeStorage.push(JSON.parse(JSON.stringify(route)))
+const clonedObject = Object.assign({}, route);
Review Comment:
Probably, it is enough to use `toRaw` here. Transforming a responsive object
generated with reactive into a non responsive regular object, then assign a
value to the new variable. All operations on this object will not cause page
updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-banyandb) branch win updated (6a129ea0 -> 18c5951e)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch win in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 6a129ea0 Remove file sync from windows add d4824d8f Fix data race add 18c5951e Remove sync operations No new revisions were added by this update. Summary of changes: pkg/fs/local_file_system_windows.go | 8 +--- test/stress/cases/istio/istio_suite_test.go | 13 +++-- 2 files changed, 8 insertions(+), 13 deletions(-)
Re: [PR] Fix 11273 remove exception log is output in console [skywalking-banyandb]
hanahmily commented on code in PR #396:
URL:
https://github.com/apache/skywalking-banyandb/pull/396#discussion_r1513687598
##
ui/src/components/Read/index.vue:
##
@@ -184,8 +184,10 @@ watch(() => data.code, () => {
if (index >= 0) {
data.codeStorage[index].params.code = data.code
} else {
+
route.params.code = data.code
-data.codeStorage.push(JSON.parse(JSON.stringify(route)))
+const clonedObject = Object.assign({}, route);
Review Comment:
Did you try using "toRaw" as suggested in the link you shared? This solution
may help resolve the problem you encountered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix 11273 remove exception log is output in console [skywalking-banyandb]
Fine0830 commented on code in PR #396:
URL:
https://github.com/apache/skywalking-banyandb/pull/396#discussion_r1513686905
##
ui/src/components/Read/index.vue:
##
@@ -184,8 +184,10 @@ watch(() => data.code, () => {
if (index >= 0) {
data.codeStorage[index].params.code = data.code
} else {
+
route.params.code = data.code
-data.codeStorage.push(JSON.parse(JSON.stringify(route)))
+const clonedObject = Object.assign({}, route);
Review Comment:
Could you use `toRow` before using `structuredClone`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] Metrics are not aggregated properly as OTEL collector targeting per node [skywalking]
wankai123 commented on issue #11982: URL: https://github.com/apache/skywalking/issues/11982#issuecomment-1979901855 Kafka monitoring service's MAL aggregates the metrics with `cluster and broker`, so it's good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
Sylvie-Wxr commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513674714
##
ui/src/components/Read/index.vue:
##
@@ -197,11 +195,10 @@ function initCode() {
} else {
let timeRange = {
timeRange: {
-begin: new Date(new Date() - 15),
+begin: new Date(new Date() - 15 * 60 * 1000),
Review Comment:
The "ref" here means reactive reference. When the value of the ref changes,
any Vue components that depend on this value will automatically re-render to
reflect the new value.
I think we should not use "ref" here for these time variables
(last15Minutes, lastMonth, ...).
We should just change to `const last15Minutes = 900 * 1000`, and reuse them.
##
ui/src/components/Read/index.vue:
##
@@ -197,11 +195,10 @@ function initCode() {
} else {
let timeRange = {
timeRange: {
-begin: new Date(new Date() - 15),
+begin: new Date(new Date() - 15 * 60 * 1000),
Review Comment:
The "ref" here means reactive reference. When the value of the ref changes,
any Vue components that depend on this value will automatically re-render to
reflect the new value.
I think we should not use "ref" here for these time variables
(last15Minutes, lastMonth, ...).
We should just change to `const last15Minutes = 900 * 1000`, and reuse it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
Sylvie-Wxr commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513682084
##
ui/src/components/Read/index.vue:
##
@@ -197,11 +195,10 @@ function initCode() {
} else {
let timeRange = {
timeRange: {
-begin: new Date(new Date() - 15),
+begin: new Date(new Date() - 15 * 60 * 1000),
Review Comment:
Changed accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-banyandb) branch win updated (d09e9906 -> 6a129ea0)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch win in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from d09e9906 Remove redundant sync operation in fs add 6a129ea0 Remove file sync from windows No new revisions were added by this update. Summary of changes: pkg/fs/local_file_system.go | 7 ++- pkg/fs/local_file_system_nix.go | 10 ++ pkg/fs/local_file_system_windows.go | 10 ++ 3 files changed, 22 insertions(+), 5 deletions(-)
Re: [PR] Support ClickHouse server monitoring & Support service hierarchy [skywalking]
wu-sheng commented on PR #11966: URL: https://github.com/apache/skywalking/pull/11966#issuecomment-1979889100 I see, then, please be clear about this in the docs if you don't intent to build this mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
Sylvie-Wxr commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513674714
##
ui/src/components/Read/index.vue:
##
@@ -197,11 +195,10 @@ function initCode() {
} else {
let timeRange = {
timeRange: {
-begin: new Date(new Date() - 15),
+begin: new Date(new Date() - 15 * 60 * 1000),
Review Comment:
The "ref" here means reactive reference. When the value of the ref changes,
any Vue components that depend on this value will automatically re-render to
reflect the new value.
I think we should not use "ref" here for these time variables
(last15Minutes, lastMonth, ...).
We should just change to `const last15Minutes = 900 * 1000`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support ClickHouse server monitoring & Support service hierarchy [skywalking]
CzyerChen commented on PR #11966: URL: https://github.com/apache/skywalking/pull/11966#issuecomment-1979886065 > ClickHouse Keeper Prometheus endpoint My Cluster test works with Zookeeper not ClickHouse Keeper. If to test the data from ClickHouse Keeper Prometheus endpoint, we have to try a ClickHouse Keeper cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
Sylvie-Wxr commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513662402
##
ui/src/components/Read/index.vue:
##
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
-if (isDatePicker.value) {
Review Comment:
Based on these 4 cases, I am unsure why do we need a boolean flag,
autoRefreshTimeRange() is only called after the user click "".
“isDatePicker” is set to true only after the user manually selects a time
range.
“isDatePicker” is set to false after the user clicks on the code.
So, after my changes, the logic is like this:
### the use did not select anything, or "last 15 minutes" is selected.
If user click "" , autoRefreshTimeRange() is triggered, both the start and
end dates will be updated to last 15 minutes of current time.
If user click "↻", the dates remain unchanged.
### A fixed time range is selected (last week, last month, last 3 months)
If user click "" , autoRefreshTimeRange() is triggered, both the start and
end dates will be updated to the last selected time range of current time.
If user click "↻", the dates remain unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
Sylvie-Wxr commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513662402
##
ui/src/components/Read/index.vue:
##
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
-if (isDatePicker.value) {
Review Comment:
Based on these 4 cases, I am unsure why do we need a boolean flag,
autoRefreshTimeRange() is only called after the user click "".
“isDatePicker” is set to true only after the user manually selects a time
range.
“isDatePicker” is set to false after the user clicks on the code.
So, after my changes, the logic is like this:
### the use did not select anything, or "last 15 minutes" is selected.
If user click "" , autoRefreshTimeRange() is triggered, both the start and
end dates have been updated to last 15 minutes of current time.
If user click "↻", the dates remain unchanged.
### A fixed time range is selected (last week, last month, last 3 months)
If user click "" , autoRefreshTimeRange() is triggered, both the start and
end dates have been updated to the last selected time range of current time.
If user click "↻", the dates remain unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add hierarchy for Pulsar [skywalking]
wu-sheng commented on PR #11971: URL: https://github.com/apache/skywalking/pull/11971#issuecomment-1979879723 From what I saw, your V-MQ is using IP:port which is provided by the agent plugin, meanwhile, server monitoring is using service name in k8s or something similar. You build the hierarchy rules, you need to make sure whey are aligned and the rules follow the setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove redundant sync operation in fs [skywalking-banyandb]
codecov-commenter commented on PR #399: URL: https://github.com/apache/skywalking-banyandb/pull/399#issuecomment-1979878637 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/399?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `1 lines` in your changes are missing coverage. Please review. > Project coverage is 48.31%. Comparing base [(`2ded410`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/2ded410158c95e809d95f34db09f4b82f81fbcf3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`d09e990`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/399?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/399?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [pkg/fs/local\_file\_system.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/399?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL2ZzL2xvY2FsX2ZpbGVfc3lzdGVtLmdv) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/399?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff @@ ## main #399 +/- ## == + Coverage 48.30% 48.31% +0.01% == Files 173 173 Lines 2157321561 -12 == - Hits1042110418 -3 + Misses 1027810268 -10 - Partials 874 875 +1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/399?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support ClickHouse server monitoring & Support service hierarchy [skywalking]
wu-sheng commented on PR #11966: URL: https://github.com/apache/skywalking/pull/11966#issuecomment-1979877600 Are we fetching metrics from ClickHouse Keeper Prometheus endpoint? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support ClickHouse server monitoring & Support service hierarchy [skywalking]
CzyerChen commented on PR #11966: URL: https://github.com/apache/skywalking/pull/11966#issuecomment-1979874144 Two empty metrics `ClickHouseMetrics_KeeperAliveConnections/ClickHouseMetrics_PartMutation` answered here: https://github.com/ClickHouse/ClickHouse/issues/60742 `meter_clickhouse_instance_connections_alive/meter_clickhouse_connections_alive` here will always be 0 because it is from ClickHouse Keeper Prometheus endpoint rather than ClickHouse Prometheus endpoint, and I will remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove redundant sync operation in fs [skywalking-banyandb]
hanahmily opened a new pull request, #399: URL: https://github.com/apache/skywalking-banyandb/pull/399 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#11986. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch win created (now d09e9906)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch win in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at d09e9906 Remove redundant sync operation in fs This branch includes the following new commits: new d09e9906 Remove redundant sync operation in fs The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking-banyandb) 01/01: Remove redundant sync operation in fs
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch win
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit d09e9906e9a79a643e93c0a1cd79dc82a1e82ab7
Author: Gao Hongtao
AuthorDate: Wed Mar 6 00:26:23 2024 +
Remove redundant sync operation in fs
Signed-off-by: Gao Hongtao
---
.github/workflows/flaky-test.yml | 4 ++--
pkg/fs/local_file_system.go | 16 +---
2 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/.github/workflows/flaky-test.yml b/.github/workflows/flaky-test.yml
index 3420da1d..e789870c 100644
--- a/.github/workflows/flaky-test.yml
+++ b/.github/workflows/flaky-test.yml
@@ -28,5 +28,5 @@ jobs:
if: github.repository == 'apache/skywalking-banyandb'
uses: ./.github/workflows/test.yml
with:
- options: --repeat 49 --label-filter '(integration&&!slow)||banyand'
- timeout-minutes: 40
+ options: --repeat 3 --label-filter '(integration&&!slow)||banyand'
+ timeout-minutes: 50
diff --git a/pkg/fs/local_file_system.go b/pkg/fs/local_file_system.go
index 7a8b1904..ccea483e 100644
--- a/pkg/fs/local_file_system.go
+++ b/pkg/fs/local_file_system.go
@@ -100,7 +100,7 @@ func (fs *localFileSystem) mkdir(path string, permission
Mode) {
fs.logger.Panic().Str("path", path).Err(err).Msg("failed to
create directory")
}
parentDirPath := filepath.Dir(path)
- fs.syncPath(parentDirPath)
+ fs.SyncPath(parentDirPath)
}
func (fs *localFileSystem) pathExist(path string) bool {
@@ -113,20 +113,6 @@ func (fs *localFileSystem) pathExist(path string) bool {
return true
}
-func (fs *localFileSystem) syncPath(path string) {
- d, err := os.Open(path)
- if err != nil {
- fs.logger.Panic().Str("path", path).Err(err).Msg("failed to
open directory")
- }
- if err := d.Sync(); err != nil {
- _ = d.Close()
- fs.logger.Panic().Str("path", path).Err(err).Msg("failed to
sync directory")
- }
- if err := d.Close(); err != nil {
- fs.logger.Panic().Str("path", path).Err(err).Msg("ailed to sync
directory")
- }
-}
-
func (fs *localFileSystem) ReadDir(dirname string) []DirEntry {
des, err := os.ReadDir(dirname)
if err != nil {
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
Sylvie-Wxr commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513662402
##
ui/src/components/Read/index.vue:
##
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
-if (isDatePicker.value) {
Review Comment:
Based on these 4 cases, I am unsure why do we need a boolean flag,
autoRefreshTimeRange() is only called after the user click "".
Before my changes, “isDatePicker” is set to true only after the user
manually selects a time range.
So, after my changes, the logic is like this:
### the use did not select anything, or "last 15 minutes" is selected.
If user click "" , autoRefreshTimeRange() is triggered, both the start and
end dates have been updated to last 15 minutes of current time.
If user click "↻", the dates remain unchanged.
### A fixed time range is selected (last week, last month, last 3 months)
If user click "" , autoRefreshTimeRange() is triggered, both the start and
end dates have been updated to the last selected time range of current time.
If user click "↻", the dates remain unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support ClickHouse server monitoring & Support service hierarchy [skywalking]
wu-sheng commented on PR #11966: URL: https://github.com/apache/skywalking/pull/11966#issuecomment-1979868140 @wankai123 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support ClickHouse server monitoring & Support service hierarchy [skywalking]
CzyerChen commented on PR #11966: URL: https://github.com/apache/skywalking/pull/11966#issuecomment-1979863875 Mainly sum up labeled value by MQE. https://github.com/apache/skywalking/assets/22817918/be466d05-bca5-41f6-8414-c15dbef8b49b;> https://github.com/apache/skywalking/assets/22817918/9394271b-dff3-440b-ab8d-ca446dae6dee;> https://github.com/apache/skywalking/assets/22817918/6e6abab0-3b82-4e53-9353-e90758eaebb3;> https://github.com/apache/skywalking/assets/22817918/0a7dd631-3897-4023-9db8-70b77509c834;> https://github.com/apache/skywalking/assets/22817918/895eb1ea-9553-4dbd-afd2-61bf53d13ff2;> https://github.com/apache/skywalking/assets/22817918/c4a5286b-8fbf-4b3a-be5a-0a76e89dd25b;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
hanahmily commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513646894
##
ui/src/components/Read/index.vue:
##
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
-if (isDatePicker.value) {
Review Comment:
This variable is still useful, but the original version still has some
flaws. Let me clarify the logic.
### "last 15 minutes" is selected.
1. If user click "" , both the start and end dates have been updated to
reflect the current time.
2. If user click "↻", the dates remain unchanged.
### A fixed time range is selected
1. If user click "" , the dates remain unchanged.
2. If user click "↻", the dates remain unchanged.
Based on the four cases mentioned above, it appears that
"autoRefreshTimeRange" feature has limited functionality and works only in one
scenario.
##
ui/src/components/Read/index.vue:
##
@@ -197,11 +195,10 @@ function initCode() {
} else {
let timeRange = {
timeRange: {
-begin: new Date(new Date() - 15),
+begin: new Date(new Date() - 15 * 60 * 1000),
Review Comment:
This is a good find.
Since we have a constant variable named 'last15Minutes' defined at line 35,
would it be possible to reuse it instead of generating it repeatedly? I
understand that this constant is a "ref", but it would be better to use a
numeric constant instead and refer to it in the two places it is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] UI improved in Not Found View [skywalking-banyandb]
hanahmily commented on code in PR #395: URL: https://github.com/apache/skywalking-banyandb/pull/395#discussion_r1513624806 ## ui/src/views/404/NotFound.vue: ## Review Comment: make sense. However, have you considered using the term "errors" instead of "404"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix 11273 remove exception log is output in console [skywalking-banyandb]
sksDonni commented on code in PR #396:
URL:
https://github.com/apache/skywalking-banyandb/pull/396#discussion_r1513255399
##
ui/src/components/Read/index.vue:
##
@@ -184,8 +184,10 @@ watch(() => data.code, () => {
if (index >= 0) {
data.codeStorage[index].params.code = data.code
} else {
+
route.params.code = data.code
-data.codeStorage.push(JSON.parse(JSON.stringify(route)))
+const clonedObject = Object.assign({}, route);
Review Comment:
Hi @Fine0830 @hanahmily, tried using structuredClone(). Am encountering some
issue similar to this
[here](https://stackoverflow.com/questions/72632173/unable-to-use-structuredclone-on-value-of-ref-variable).
Will try to manually loop and clone each child recursively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add hierarchy for Pulsar [skywalking]
CodePrometheus commented on PR #11971: URL: https://github.com/apache/skywalking/pull/11971#issuecomment-1979277564 Sorry, I've been busy with work lately. The showcase is in progress, and local test is as shown below, but the `service_hierarchy_relation` does not seem to be related to Virtual-MQ and Pulsar-cluster now, I'm still trying to figure it out, If teachers have any suggestions please let me know, thanks very much. https://github.com/apache/skywalking/assets/66550292/22d60205-9852-4b72-89d0-79a81f53f726;> https://github.com/apache/skywalking/assets/66550292/386e1cb4-5a50-47bf-baed-8a0c35df00a5;> https://github.com/apache/skywalking/assets/66550292/896943f6-ad71-4168-b4cf-2e23344d5ba4;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] Synchronization Error When OAP Accesses BanyanDB on Windows [skywalking]
mrproliu opened a new issue, #11986: URL: https://github.com/apache/skywalking/issues/11986 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component BanyanDB (apache/skywalking-banyandb) ### What happened When deploying SkyWalking with BanyanDB on Windows, I encountered a synchronization error. Specifically, there was an issue when OAP attempted to access BanyanDB during startup. Despite having set full control permissions and running `banyandb-server` as an administrator, I still received an "Access Denied" error. The log in the BanyanDB service is as follows:  The startup command is as follows: `C:\my_test\banyand-server.exe standalone --metadata-root-path C:\Users\hanliu\Documents\banyand --measure-root-path C:\Users\hanliu\Documents\banyand --stream-root-path C:\Users\hanliu\Documents\banyand` By observing the contents of the folder, it was found that there is content being written:  ### What you expected to happen I hope that when SkyWalking is connected to BanyanDB, data writing and reading operations can be performed. ### How to reproduce 1. Clone the skywalking-banyandb repo. 2. Run: `make build` to build the windows version `banyand-server` 3. Startup the banyandb: `C:\my_test\banyand-server.exe standalone --metadata-root-path C:\Users\hanliu\Documents\banyand --measure-root-path C:\Users\hanliu\Documents\banyand --stream-root-path C:\Users\hanliu\Documents\banyand` 4. Download the latest version of SkyWalking(`v9.7.0`) and deploy the OAP. 5. After a few seconds, the error log shows in the banyanDB server console. ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch win-mac-compile updated (38b7d477 -> 23ccc3d5)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch win-mac-compile in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 38b7d477 Fix add 23ccc3d5 Revert No new revisions were added by this update. Summary of changes: .github/workflows/ci.yml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)
(skywalking-banyandb) branch win-mac-compile updated (c554e055 -> 38b7d477)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch win-mac-compile in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from c554e055 Fix. Remove mac. add 38b7d477 Fix No new revisions were added by this update. Summary of changes: .github/workflows/test.yml | 2 -- 1 file changed, 2 deletions(-)
Re: [PR] Add Windows to Compiling and UT [skywalking-banyandb]
codecov-commenter commented on PR #398: URL: https://github.com/apache/skywalking-banyandb/pull/398#issuecomment-1978719713 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/398?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 48.27%. Comparing base [(`2ded410`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/2ded410158c95e809d95f34db09f4b82f81fbcf3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`9209c74`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/398?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > :exclamation: Current head 9209c74 differs from pull request most recent head c554e05. Consider uploading reports for the commit c554e05 to get more accurate results Additional details and impacted files ```diff @@Coverage Diff @@ ## main #398 +/- ## == - Coverage 48.30% 48.27% -0.03% == Files 173 173 Lines 2157321573 == - Hits1042110415 -6 - Misses 1027810282 +4 - Partials 874 876 +2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/398?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch win-mac-compile updated (9209c74e -> c554e055)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch win-mac-compile in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 9209c74e Add a new test plan. add c554e055 Fix. Remove mac. No new revisions were added by this update. Summary of changes: .github/workflows/test.yml | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-)
(skywalking-banyandb) branch win-mac-compile updated (6b70a04f -> 9209c74e)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch win-mac-compile in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 6b70a04f Add MacOS and Windows to Compiling and UT add 9209c74e Add a new test plan. No new revisions were added by this update. Summary of changes: .github/workflows/test.yml | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-)
[PR] Add MacOS and Windows to Compiling and UT [skywalking-banyandb]
wu-sheng opened a new pull request, #398: URL: https://github.com/apache/skywalking-banyandb/pull/398 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch win-mac-compile created (now 6b70a04f)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch win-mac-compile in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at 6b70a04f Add MacOS and Windows to Compiling and UT This branch includes the following new commits: new 6b70a04f Add MacOS and Windows to Compiling and UT The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking-banyandb) 01/01: Add MacOS and Windows to Compiling and UT
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch win-mac-compile
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 6b70a04fe1aae89f096a84e24eb6df2be74357e0
Author: Wu Sheng
AuthorDate: Tue Mar 5 20:44:22 2024 +0800
Add MacOS and Windows to Compiling and UT
---
.github/workflows/ci.yml | 5 -
.github/workflows/test.yml | 3 ++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 8663ca24..10a5596a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -76,7 +76,10 @@ jobs:
run: make check
build:
name: Build
-runs-on: ubuntu-20.04
+runs-on: ${{ matrix.os }}
+strategy:
+ matrix:
+os: [ ubuntu-latest, macos-14, windows-latest ]
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v3
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 926d979a..0261e006 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -30,11 +30,12 @@ on:
jobs:
test:
name: Test
-runs-on: ubuntu-20.04
+runs-on: ${{ matrix.os }}
timeout-minutes: ${{ inputs.timeout-minutes }}
strategy:
matrix:
tz: ["UTC", "Asia/Shanghai", "America/Los_Angeles"]
+os: [ ubuntu-latest, macos-14, windows-latest ]
steps:
- name: Set timezone
run: sudo timedatectl set-timezone ${{ matrix.tz }}
(skywalking-website) branch master updated: Add kindling-originx(originx.kindlingx.com) to user wall. (#684)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 6c64754427c Add kindling-originx(originx.kindlingx.com) to user wall. (#684) 6c64754427c is described below commit 6c64754427c97bec1d578e74ff8454804c8afe77 Author: Freedom AuthorDate: Tue Mar 5 19:15:26 2024 +0800 Add kindling-originx(originx.kindlingx.com) to user wall. (#684) --- data/users.yml | 5 + static/images/users/originx_logo.png | Bin 0 -> 7623 bytes 2 files changed, 5 insertions(+) diff --git a/data/users.yml b/data/users.yml index 6c519469c80..0e645d04458 100644 --- a/data/users.yml +++ b/data/users.yml @@ -748,3 +748,8 @@ users: info: bthhotels.com 首旅如家 website: https://www.bthhotels.com/ logo: /images/users/bthhotels_logo.png + + - name: Kindling-OriginX +info: originx.kindlingx.com OriginX故障根因推理引擎 +website: https://originx.kindlingx.com/ +logo: /images/users/originx_logo.png \ No newline at end of file diff --git a/static/images/users/originx_logo.png b/static/images/users/originx_logo.png new file mode 100644 index 000..d486faf703b Binary files /dev/null and b/static/images/users/originx_logo.png differ
Re: [PR] Add kindling-originx(originx.kindlingx.com) to user wall. [skywalking-website]
wu-sheng merged PR #684: URL: https://github.com/apache/skywalking-website/pull/684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add kindling-originx(originx.kindlingx.com) to user wall. [skywalking-website]
crl228 commented on PR #684: URL: https://github.com/apache/skywalking-website/pull/684#issuecomment-1978523061 > Could you explain your relationship with SkyWalking? Are you a re-distributed version of SkyWalking or something else? We have integrated trace data from Skywalking and also support other trace data such as OpenTelemetry. Based on these data, we conduct analysis in conjunction with system calls. We have not made any modifications to Skywalking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: 9e27a14a8bd54d148adfd8c0a1a4c8160cde75a7
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 2be906aedf8 deploy: 9e27a14a8bd54d148adfd8c0a1a4c8160cde75a7
2be906aedf8 is described below
commit 2be906aedf80c67fd5fffdd390ae8c5f425b51fc
Author: wu-sheng
AuthorDate: Tue Mar 5 10:07:06 2024 +
deploy: 9e27a14a8bd54d148adfd8c0a1a4c8160cde75a7
---
contributors/index.html | 2 +-
index.json | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contributors/index.html b/contributors/index.html
index 90ec3650e21..19fa776bb3e 100644
--- a/contributors/index.html
+++ b/contributors/index.html
@@ -1972,7 +1972,7 @@
-2958
+2959
1
diff --git a/index.json b/index.json
index 1384a87cd3a..91c5ec0cc06 100644
--- a/index.json
+++ b/index.json
@@ -1 +1 @@
-[{"body":"","excerpt":"","ref":"/tags/rocketmq/","title":"RocketMQ"},{"body":"","excerpt":"","ref":"/tags/","title":"Tags"},{"body":"背景介绍
Apache RocketMQ 是一个开源的低延迟、高并发、高可用、高可靠的分布式消息中间件, 从SkyWalking OAP 10.0 版本开始, 新增了
对 RocketMQ Server的监控面板。本文将展示并介绍如何使用 Skywalking来监控RocketMQ\n部署 流程
通过RocketMQ官方提供的RocketMQ exporter来采集RocketMQ
Server数据,再通过opentelmetry-collector来拉取RocketMQ exporter并传输到skywalking
oap服务来处理\nDataFlow: 准备 Skywalking oap服务,v10.0 + RocketMQ v4.3.2 + RocketMQ
exporter v0.0.2+ Open [...]
\ No newline at end of file
+[{"body":"","excerpt":"","ref":"/tags/rocketmq/","title":"RocketMQ"},{"body":"","excerpt":"","ref":"/tags/","title":"Tags"},{"body":"背景介绍
Apache RocketMQ 是一个开源的低延迟、高并发、高可用、高可靠的分布式消息中间件, 从SkyWalking OAP 10.0 版本开始, 新增了
对 RocketMQ Server的监控面板。本文将展示并介绍如何使用 Skywalking来监控RocketMQ\n部署 流程
通过RocketMQ官方提供的RocketMQ exporter来采集RocketMQ
Server数据,再通过opentelmetry-collector来拉取RocketMQ exporter并传输到skywalking
oap服务来处理\nDataFlow: 准备 Skywalking oap服务,v10.0 + RocketMQ v4.3.2 + RocketMQ
exporter v0.0.2+ Open [...]
\ No newline at end of file
Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]
codecov-commenter commented on PR #397: URL: https://github.com/apache/skywalking-banyandb/pull/397#issuecomment-1978173340 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/397?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 48.28%. Comparing base [(`2ded410`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/2ded410158c95e809d95f34db09f4b82f81fbcf3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`45a9353`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/397?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@Coverage Diff @@ ## main #397 +/- ## == - Coverage 48.30% 48.28% -0.03% == Files 173 173 Lines 2157321573 == - Hits1042110416 -5 - Misses 1027810281 +3 - Partials 874 876 +2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/397?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
