Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng merged PR #107: URL: https://github.com/apache/skywalking-php/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955728454 > > > $spanId should not be for the entire request, right? > > > > > > It is not. It is variable according to span creation and stop status. > > I would like to implement $spanId in the future (if there is user demand) If that is the case, please remove segmentId as well, that is useless without span ID. Both IDs lock the specific span. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
jmjoy commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955725165 > > $spanId should not be for the entire request, right? > > It is not. It is variable according to span creation and stop status. I would like to implement $spanId in the future (if there is user demand) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955716258 > > How about $spanId? > > $spanId should not be for the entire request, right? It is not. It is variable according to span creation and stop status. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
jmjoy commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955693441 > How about $spanId? $spanId should not be for the entire request, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1954108830 And please update the docs according, after you added the span ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-195384 > > Should we consider the whole trace context? > > $serviceName, $instanceName, $traceId, $traceSegmentId are injected. How about $spanId? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
jmjoy commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1953830055 > Should we consider the whole trace context? $serviceName, $instanceName, $traceId, $traceSegmentId are injected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Inject skywalking context. [skywalking-php]
wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1953487834 Should we consider the whole trace context? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
