from:"via GitHub"

Re: [I] Ephemeral instances no longer have any example data [superset]

2024-07-24 Thread via GitHub



dosubot[bot] commented on issue #29694:
URL: https://github.com/apache/superset/issues/29694#issuecomment-2249132157

   
   Hey @sadpandajoe! I'm here to assist you with any bugs, questions, or 
contributions while we wait for a human maintainer. Let's tackle this together!
   
   
   The example data such as dashboards and charts no longer exist when spinning 
up an ephemeral instance in a PR because the provided workflow configuration 
does not include any steps to load or initialize example data. To include 
example data, you need to add steps in the workflow to load the example data 
after the environment is spun up. You can use scripts like `misc_dashboard.py` 
to load example dashboards and charts, or leverage the `ImportAssetsCommand` 
from the `superset.commands.importers.v1.assets` module to import predefined 
configurations for databases, datasets, charts, and dashboards 
[[1]](https://github.com/apache/superset/blob/master/.github/workflows/ephemeral-env.yml)[[2]](https://github.com/apache/superset/blob/master/superset/examples/misc_dashboard.py)[[3]](https://github.com/apache/superset/blob/master/tests/unit_tests/commands/importers/v1/assets_test.py).
   
   
   
   *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[I] Ephemeral instances no longer have any example data [superset]

2024-07-24 Thread via GitHub



sadpandajoe opened a new issue, #29694:
URL: https://github.com/apache/superset/issues/29694

   ### Bug description
   
   When you spin up an ephemeral instance in a PR, example data such as 
dashboard, charts, etc. no longer exist.
   
   ### How to reproduce the bug
   
   1. Go to a PR
   2. Spin up an ephemeral
   3. Log into the ephemeral
   4. Go to the dashboard list
   
   Notice that the dashboard list is empty where we used to have example 
dashboards.
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [ ] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [ ] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] feat(alert/reports): adding logic to handle downstream reports when tab is deleted from dashboard [superset]

2024-07-24 Thread via GitHub



codecov[bot] commented on PR #29333:
URL: https://github.com/apache/superset/pull/29333#issuecomment-2249108552

   ## 
[Codecov](https://app.codecov.io/gh/apache/superset/pull/29333?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   Attention: Patch coverage is `39.72603%` with `44 lines` in your changes 
missing coverage. Please review.
   > Project coverage is 61.40%. Comparing base 
[(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`8984dd6`)](https://app.codecov.io/gh/apache/superset/commit/8984dd6596eb7fc87549f64c82ecdc9db1678abf?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   > Report is 477 commits behind head on master.
   
   | 
[Files](https://app.codecov.io/gh/apache/superset/pull/29333?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[superset/commands/dashboard/update.py](https://app.codecov.io/gh/apache/superset/pull/29333?src=pr=tree=superset%2Fcommands%2Fdashboard%2Fupdate.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvZGFzaGJvYXJkL3VwZGF0ZS5weQ==)
 | 18.75% | [26 Missing :warning: 
](https://app.codecov.io/gh/apache/superset/pull/29333?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...-frontend/src/features/alerts/AlertReportModal.tsx](https://app.codecov.io/gh/apache/superset/pull/29333?src=pr=tree=superset-frontend%2Fsrc%2Ffeatures%2Falerts%2FAlertReportModal.tsx_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2FsZXJ0cy9BbGVydFJlcG9ydE1vZGFsLnRzeA==)
 | 55.55% | [12 Missing and 4 partials :warning: 
](https://app.codecov.io/gh/apache/superset/pull/29333?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[superset/commands/report/execute.py](https://app.codecov.io/gh/apache/superset/pull/29333?src=pr=tree=superset%2Fcommands%2Freport%2Fexecute.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvcmVwb3J0L2V4ZWN1dGUucHk=)
 | 0.00% | [1 Missing :warning: 
](https://app.codecov.io/gh/apache/superset/pull/29333?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[superset/daos/report.py](https://app.codecov.io/gh/apache/superset/pull/29333?src=pr=tree=superset%2Fdaos%2Freport.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvZGFvcy9yZXBvcnQucHk=)
 | 66.66% | [1 Missing :warning: 
](https://app.codecov.io/gh/apache/superset/pull/29333?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@Coverage Diff @@
   ##   master   #29333  +/-   ##
   ==
   + Coverage   60.48%   61.40%   +0.91% 
   ==
 Files1931 1969  +38 
 Lines   7623678911+2675 
 Branches 8568 8998 +430 
   ==
   + Hits4611448452+2338 
   - Misses  2801728257 +240 
   - Partials 2105 2202  +97 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/superset/pull/29333/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[hive](https://app.codecov.io/gh/apache/superset/pull/29333/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `49.07% <24.32%> (-0.09%)` | :arrow_down: |
   | 
[presto](https://app.codecov.io/gh/apache/superset/pull/29333/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `53.63% <24.32%> (-0.18%)` | :arrow_down: |
   | 
[python](https://app.codecov.io/gh/apache/superset/pull/29333/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `64.94% <24.32%> (+1.45%)` | :arrow_up: |
   | 
[unit](https://app.codecov.io/gh/apache/superset/pull/29333/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `59.85% <24.32%> (+2.23%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click

Re: [PR] DO NOT MERGE: test 4.1 release [superset]

2024-07-24 Thread via GitHub



github-actions[bot] commented on PR #29693:
URL: https://github.com/apache/superset/pull/29693#issuecomment-2249100889

   @eschutho Ephemeral environment spinning up at http://35.91.219.2:8080. 
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping 
and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] DO NOT MERGE: test 4.1 release [superset]

2024-07-24 Thread via GitHub



eschutho commented on PR #29693:
URL: https://github.com/apache/superset/pull/29693#issuecomment-2249091221

   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[PR] DO NOT MERGE: test 4.1 release [superset]

2024-07-24 Thread via GitHub



eschutho opened a new pull request, #29693:
URL: https://github.com/apache/superset/pull/29693

   
   
   ### SUMMARY
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
   ### TESTING INSTRUCTIONS
   
   
   ### ADDITIONAL INFORMATION
   
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
 - [ ] Migration is atomic, supports rollback & is backwards-compatible
 - [ ] Confirm DB migration upgrade and downgrade tested
 - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] chore: Add the 4.1 release notes [superset]

2024-07-24 Thread via GitHub



sadpandajoe commented on PR #29262:
URL: https://github.com/apache/superset/pull/29262#issuecomment-2249045316

   ️ 4.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] Cag/initial setup [superset]

2024-07-24 Thread via GitHub



Ian2012 closed pull request #29689: Cag/initial setup
URL: https://github.com/apache/superset/pull/29689


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] Cag/initial setup [superset]

2024-07-24 Thread via GitHub



request-info[bot] commented on PR #29689:
URL: https://github.com/apache/superset/pull/29689#issuecomment-2248788219

   We would appreciate it if you could provide us with more info about this 
issue/pr! Please do not leave the `title` or `description` empty.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[PR] Cag/initial setup [superset]

2024-07-24 Thread via GitHub



Ian2012 opened a new pull request, #29689:
URL: https://github.com/apache/superset/pull/29689

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[PR] fix(ci): release process for labeling PRs [superset]

2024-07-24 Thread via GitHub



mistercrunch opened a new pull request, #29688:
URL: https://github.com/apache/superset/pull/29688

   It appears the CI script that runs on-release to label PRs isn't working
   as expected. Here I'm taking the `supersetbot` command out of the matrix
   and running it in parallel with the docker image publication.
   
   Tested with:
   ```
   gh workflow run tag-release.yml --ref fix_release_tags --field
   release="4.0.2" --field git-ref="4.0.2" --field force-latest="true"
   ```
   
   Test run:
   ```
   
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[PR] [WIP] SEC-70 - Gamma users shouldn't be able to create roles [superset]

2024-07-24 Thread via GitHub



hug opened a new pull request, #29687:
URL: https://github.com/apache/superset/pull/29687

   
   
   ### SUMMARY
   
   Currently users with gamma roles are still able to create roles when 
FAB_ADD_SECURITY_API = True, This PR is made to fix this security issue as well 
as add test
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
   ### TESTING INSTRUCTIONS
   
   
   ### ADDITIONAL INFORMATION
   
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
 - [ ] Migration is atomic, supports rollback & is backwards-compatible
 - [ ] Confirm DB migration upgrade and downgrade tested
 - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Superset 3.0 not able to login, cookies are being set as secure even though the site is http. [superset]

2024-07-24 Thread via GitHub



aartisethi05 commented on issue #25374:
URL: https://github.com/apache/superset/issues/25374#issuecomment-2248621001

   How to get session_cookie?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] superset_node build failure @nx/nx-linux-x64-gnu missing module [superset]

2024-07-24 Thread via GitHub



bobular commented on issue #29658:
URL: https://github.com/apache/superset/issues/29658#issuecomment-2248552272

   I got this too.
   
   Manually adding it as a devDependency seems to work as a workaround for me. 
Though I am still having problems logging in as admin/admin.
   
   ```diff
   diff --git a/superset-frontend/package.json b/superset-frontend/package.json
   index bb7a2face8..bba6bef5a7 100644
   --- a/superset-frontend/package.json
   +++ b/superset-frontend/package.json
   @@ -226,6 +226,7 @@
"@emotion/jest": "^11.11.0",
"@hot-loader/react-dom": "^16.14.0",
"@istanbuljs/nyc-config-typescript": "^1.0.1",
   +"@nx/nx-linux-x64-gnu": "^18.3.5",
"@storybook/addon-actions": "^8.1.11",
"@storybook/addon-controls": "^8.1.11",
"@storybook/addon-essentials": "^8.1.11",
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] refactor(ChartCreation): Migrate tests to RTL [superset]

2024-07-24 Thread via GitHub



michael-s-molina commented on code in PR #29674:
URL: https://github.com/apache/superset/pull/29674#discussion_r1690183088


##
superset-frontend/src/pages/ChartCreation/ChartCreation.test.tsx:
##
@@ -59,94 +73,113 @@ const mockUserWithDatasetWrite: 
UserWithPermissionsAndRoles = {
   username: 'admin',
   isAnonymous: false,
 };
+const history = createMemoryHistory();
+
+history.push = jest.fn();
 
 // We don't need the actual implementation for the tests

Review Comment:
   Can we remove this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix(explore): missing column autocomplete in custom SQL [superset]

2024-07-24 Thread via GitHub



michael-s-molina commented on code in PR #29672:
URL: https://github.com/apache/superset/pull/29672#discussion_r1690124530


##
superset-frontend/src/components/AsyncAceEditor/index.tsx:
##
@@ -167,15 +172,66 @@ export default function AsyncAceEditor(
 }, [keywords, setCompleters]);
 
 return (
-  
+  <>
+

[PR] fix: Removed fixed width constraint from Save button [superset]

2024-07-24 Thread via GitHub



goldjee opened a new pull request, #29686:
URL: https://github.com/apache/superset/pull/29686

   ### SUMMARY
   Currently, "Save" button in SQL Lab has fixed width. So, longer labels are 
trimmed. This is an attempt to fix that.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   English / before:
   https://github.com/user-attachments/assets/bbac39de-a4ac-4e42-86b6-0d9dc0e34933;>
   
   English / after:
   https://github.com/user-attachments/assets/90d31b2c-94d3-44f5-8535-b1fc705c956b;>
   
   Russian / before:
   https://github.com/user-attachments/assets/37fd718b-3a41-4456-b865-a6fcd3f4b4f8;>
   
   Russian / after:
   https://github.com/user-attachments/assets/9b971dcc-5f09-4ffd-ad37-828522d7eadb;>
   
   ### TESTING INSTRUCTIONS
   Switch to any language that has long "Save" button translation. Russian, for 
example.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #29477
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
 - [ ] Migration is atomic, supports rollback & is backwards-compatible
 - [ ] Confirm DB migration upgrade and downgrade tested
 - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



goldjee commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247962416

   Ah, I see. Yep, internal LAN IP worked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] fix: Redirect to login on unauthorised access for Dashboard. [superset]

2024-07-24 Thread via GitHub



sfirke commented on PR #23280:
URL: https://github.com/apache/superset/pull/23280#issuecomment-2247963798

   I played with this a little and think I have a solution that works for me.  
I edited where the redirect goes after access check fails when user is 
anonymous.  I replaced 
https://github.com/apache/superset/blob/master/superset/views/core.py#L794-L799 
with:
   ```python
   except SupersetSecurityException as ex:
   # anonymous users should get the login screen, others should go 
to dashboard list
   redirect_url = 
f"{appbuilder.get_url_for_login}?next={request.url}" if g.user is None or 
g.user.is_anonymous else "/dashboard/list/"
   warn_msg = "This dashboard does not allow public access." if 
g.user is None or g.user.is_anonymous else utils.error_msg_from_exception(ex)
   return redirect_with_flash(
   url=redirect_url,
   message=warn_msg,
   category="danger",
   )
   ```
   Thoughts from folks in this thread?  I have DASHBOARD_RBAC enabled and a 
Public role enabled, I'd want to know that it works for people not using those 
features.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



michael-s-molina commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247957755

   Not 127.0.0.1, your real IP such as 192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



goldjee commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247955014

   > Hi @goldjee. I also noticed this problem but haven't had the time to take 
a look. I hope other maintainers can fix it. In the meantime, I discovered that 
it works on Chrome if you use the IP address instead of `localhost`.
   
   Hi! Thank you for the suggestion. Just tried `http://127.0.0.1:9000` and had 
the same result :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[I] Labels of Advanced analytics stats in the chart legend can't be changed [superset]

2024-07-24 Thread via GitHub



petkoaa opened a new issue, #29683:
URL: https://github.com/apache/superset/issues/29683

   ## Screenshot
   
   
![image](https://github.com/user-attachments/assets/b31bcdcf-88da-49d5-b784-086269ba7a50)
   
   ## Description
   
   The labels that appear in the chart legend for Advanced analytics cant be 
changed and are just the Metric name prefixed with "percentage_", etc. 
   
   I'd like to either add a way for the user to set the labels for themselves 
in the UI, or change them so they look less like "raw".  For example 
"Percentage of" or just "Percentage
   
   ## Design input
   I´d like to solve the issue myself, but would like some codepointers to 
begin. 
   Thanks! 
   
   `design:suggest`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



michael-s-molina commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247750247

   Let me tag @geido @rusackas as the leaders of dev experience group.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



michael-s-molina commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247747841

   Hi @goldjee. I also noticed this problem but haven't had the time to take a 
look. Hope other maintainers can fix it. In the meantime, I discovered that it 
works on Chrome if you use the IP address instead of `localhost`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



goldjee commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247696157

   @monsterkai233 Hi! Good tip, Safari works. But I'm much more used to Chrome 
dev tools, so it would be great if maintainers could take a look.
   
   @rusackas @michael-s-molina 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] apache/superset latest 7502beb92ce5, load_examples -> dashboards not creating for me [superset]

2024-07-24 Thread via GitHub



dbaltor commented on issue #24521:
URL: https://github.com/apache/superset/issues/24521#issuecomment-224769

   Can we get this issue reopened please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[PR] Geido/fix/refresh catalogs on db update [superset]

2024-07-24 Thread via GitHub



geido opened a new pull request, #29681:
URL: https://github.com/apache/superset/pull/29681

   
   
   ### SUMMARY
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
   ### TESTING INSTRUCTIONS
   
   
   ### ADDITIONAL INFORMATION
   
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
 - [ ] Migration is atomic, supports rollback & is backwards-compatible
 - [ ] Confirm DB migration upgrade and downgrade tested
 - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



monsterkai233 commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247349176

   @goldjee hi bro, I use safari and it's working fine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



dosubot[bot] commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247331220

   
   To fix the issue of a broken page and garbled text when running the Superset 
development server at `http://localhost:9000`, ensure that the Webpack dev 
server is running in parallel with the Flask server. Follow these steps:
   
   1. **Run the Flask server on port `8088`:**
  ```bash
  superset run -p 8088 --with-threads --reload --debugger --debug
  ```
   
   2. **Run the Webpack dev server on port `9000`:**
  ```bash
  npm run dev-server
  ```
   
   3. **Access the application via `http://localhost:9000` in your web 
browser.**
   
   This setup ensures that the front-end assets are served correctly by the 
Webpack dev server while backend requests are proxied to the Flask server 
[[1]](https://github.com/apache/superset/blob/master/docs/docs/contributing/development.mdx).
   
   
   
   *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



monsterkai233 commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247326839

   > 不，它没有用。
   
   I tried the same thing and it didn't work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Garbled characters on the agent page in the development environment以上翻译结果来自有道神经网络翻译（YNMT）· 通用场景 [superset]

2024-07-24 Thread via GitHub



monsterkai233 commented on issue #29678:
URL: https://github.com/apache/superset/issues/29678#issuecomment-2247323420

   > 嗨，你好！我在这里帮助您解决任何错误、问题或贡献。让我们一起解决这个问题，同时等待人工维护者。
   > 
   > 出现乱码可能是由于 Webpack 开发服务器未运行。要解决此问题，请确保 Webpack 开发服务器与 Flask 
服务器并行启动。步骤如下：`localhost:9000`
   > 
   > 1. 在端口上启动 Flask 服务器：`8088`
   >```shell
   >superset run -p 8088 --with-threads --reload --debugger --debug
   >```
   > 2. 同时，在端口上启动 Webpack 开发服务器：`9000`
   >```shell
   >npm run dev-server
   >```
   > 
   > 在您的 Web 浏览器中访问。此设置可确保前端资产得到正确服务和热重新加载，同时后端请求被代理到在端口上运行的 Flask 
服务器`http://localhost:9000``8088` 
[[1]](https://github.com/apache/superset/blob/master/docs/docs/contributing/development.mdx).
   > 
   > 
如果问题仍然存在，请检查文件是否存在与端口、公共路径或代理设置相关的任何错误配置`webpack.config.js`[[2]](https://github.com/apache/superset/blob/master/superset-frontend/webpack.config.js).
   > 
   > _要继续与 [Dosu](https://dosu.dev) 交谈，请提及 。_
   
   My webpack.config.js correctly configured, bug is same 
[https://github.com/apache/superset/issues/29677](url)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



goldjee commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247306916

   @dosu Nope, it didn't work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Garbled characters on the agent page in the development environment以上翻译结果来自有道神经网络翻译（YNMT）· 通用场景 [superset]

2024-07-24 Thread via GitHub

dosubot[bot] commented on issue #29678:
URL: https://github.com/apache/superset/issues/29678#issuecomment-224732

@monsterkai233 Hello there! I'm here to help you with any bugs, questions,
or contributions. Let's tackle this issue together while we wait for a human
maintainer.

The garbled characters on `localhost:9000` are likely due to the Webpack dev
server not running. To resolve this, ensure that the Webpack dev server is
started in parallel with the Flask server. Here are the steps:

1. Start the Flask server on port `8088`:
```bash
superset run -p 8088 --with-threads --reload --debugger --debug
```

2. In parallel, start the Webpack dev server on port `9000`:
```bash
npm run dev-server
```

Access `http://localhost:9000` in your web browser. This setup ensures that
the frontend assets are properly served and hot-reloaded, while backend
requests are proxied to the Flask server running on port `8088`
[[1]](https://github.com/apache/superset/blob/master/docs/docs/contributing/development.mdx).

If the issue persists, check the `webpack.config.js` file for any
misconfigurations related to the port, public path, or proxy settings
[[2]](https://github.com/apache/superset/blob/master/superset-frontend/webpack.config.js).

*To continue talking to [Dosu](https://dosu.dev), mention @dosu.*

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[I] Garbled characters on the agent page in the development environment以上翻译结果来自有道神经网络翻译（YNMT）· 通用场景 [superset]

2024-07-24 Thread via GitHub



monsterkai233 opened a new issue, #29678:
URL: https://github.com/apache/superset/issues/29678

   ### Bug description
   
   localhost:8088 display normal, but localhost:9000 display garbled code
   
![image](https://github.com/user-attachments/assets/dcd408e2-d31f-4799-8646-a695b72ebc60)
   
![image](https://github.com/user-attachments/assets/1e8c017e-bbb7-4f60-b5f0-0fcbdc466eb8)
   
   
   ### How to reproduce the bug
   
   node: 18.19.1
   superset: 4.0.1
   https://superset.apache.org/docs/contributing/development/#webpack-dev-server
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.11
   
   ### Node version
   
   18 or greater
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [ ] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [ ] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



dosubot[bot] commented on issue #29677:
URL: https://github.com/apache/superset/issues/29677#issuecomment-2247285886

   
   To address the issue of the broken page and garbled text when running the 
Superset development server at `http://localhost:9000`, you can follow these 
steps to ensure the correct character encoding is set:
   
   1. **Set Environment Variables:**
  Ensure that the environment variables for character encoding are set 
correctly. Add the following lines to your shell configuration file (e.g., 
`.bashrc`, `.zshrc`):
   
  ```bash
  export LC_ALL=en_US.UTF-8
  export LANG=en_US.UTF-8
  ```
   
  After adding these lines, reload your shell configuration:
   
  ```bash
  source ~/.bashrc  # or source ~/.zshrc
  ```
   
   2. **Check Flask Configuration:**
  Ensure that Flask is configured to use the correct character encoding. 
Add the following line to your `superset_config.py` file:
   
  ```python
  JSON_AS_ASCII = False
  ```
   
   3. **Restart the Servers:**
  After making these changes, restart both the Flask server and the Webpack 
dev server:
   
  ```bash
  # Restart Flask server
  superset run -p 8088 --with-threads --reload --debugger --debug
   
  # Restart Webpack dev server
  npm run dev-server
  ```
   
   These steps should help resolve the issue of garbled text due to incorrect 
character encoding 
[[1]](https://github.com/apache/superset/blob/master/docs/docs/contributing/development.mdx).
   
   
   
   *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[I] Dev-server page isn't rendered [superset]

2024-07-24 Thread via GitHub



goldjee opened a new issue, #29677:
URL: https://github.com/apache/superset/issues/29677

   ### Bug description
   
   After installing all dependencies and running dev-server, I get broken page 
at `http://localhost:9000`.
   
   I've found the same very old issue 
[#12040](https://github.com/apache/superset/issues/12040). The author supposed 
that it is specific to Chrome. But both Chrome and Firefox show broken page. 
Also it's worth mentioning that, as far as I see, there are no related errors 
in terminal or console output.
   
   ### How to reproduce the bug
   
   1. Install Superset without Docker
   
   ```bash
   source venv/bin/activate
   pip install -r requirements/development.txt
   pip install -e .
   
   cd superset-frontend
   npm ci
   ```
   
   2. Run Superset
   
   ```bash
   export SUPERSET_CONFIG_PATH=./docker/pythonpath_dev/superset_config_local.py
   superset run -p 8088 --with-threads --reload
   ```
   
   3. Run development server
   
   ```bash
   npm run dev-server
   ```
   
   4. Navigate to http://localhost:9000
   
   ### Screenshots/recordings
   
   https://github.com/user-attachments/assets/674a8225-2388-4c1a-802c-020b908678e6;>
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.11
   
   ### Node version
   
   18 or greater
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   node.js version: `18.20.4` (same error on `22.5.1`)
   
   ### Checklist
   
   - [X] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [ ] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [X] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [I] Cannot get back asyncquery result [superset]

2024-07-24 Thread via GitHub



dosubot[bot] commented on issue #29676:
URL: https://github.com/apache/superset/issues/29676#issuecomment-2247151200

   
   @oOhyeahh Hello there! I'm here to help you with your Superset issue. I can 
assist with bug troubleshooting, answer questions, and guide you on becoming a 
contributor. Let's work together to resolve your concerns.
   
   
   To resolve the "Cannot read properties of undefined (reading 'forEach')" 
error on the frontend when enabling the global async query feature flag in 
Superset, ensure that the `events` parameter passed to the `processEvents` 
function is defined and is an array.
   
   The error occurs because `events` is `undefined` or not an array, and the 
`forEach` method cannot be called on it. You can add a check to ensure `events` 
is defined and is an array before calling `forEach`.
   
   Here is the modified `processEvents` function with the necessary check:
   
   ```ts
   export const processEvents = async (events: AsyncEvent[]) => {
 if (!Array.isArray(events)) {
   logging.warn('Expected events to be an array, but got:', events);
   return;
 }
   
 events.forEach((asyncEvent: AsyncEvent) => {
   const jobId = asyncEvent.job_id;
   const listener = listenersByJobId[jobId];
   if (listener) {
 listener(asyncEvent);
 delete retriesByJobId[jobId];
   } else {
 // handle race condition where event is received
 // before listener is registered
 if (!retriesByJobId[jobId]) retriesByJobId[jobId] = 0;
 retriesByJobId[jobId] += 1;
   
 if (retriesByJobId[jobId] <= MAX_RETRIES) {
   setTimeout(() => {
 processEvents([asyncEvent]);
   }, RETRY_DELAY * retriesByJobId[jobId]);
 } else {
   delete retriesByJobId[jobId];
   logging.warn('listener not found for job_id', asyncEvent.job_id);
 }
   }
   setLastId(asyncEvent);
 });
   };
   ```
   
   Additionally, you can refer to the `updateComponentParentsList` function in 
`superset-frontend/src/dashboard/util/updateComponentParentsList.test.js` for 
handling invalid parameters gracefully. This function includes checks to ensure 
that parameters are valid and does not throw errors when they are not, which 
can be a useful pattern to follow:
   
   ```js
   describe('updateComponentParentsList with bad inputs', () => {
 it('should handle invalid parameters and not throw error', () => {
   updateComponentParentsList({
 currentComponent: undefined,
 layout: undefined,
   });
   
   expect(() =>
 updateComponentParentsList({
   currentComponent: undefined,
   layout: undefined,
 }),
   ).not.toThrow();
   
   expect(() =>
 updateComponentParentsList({
   currentComponent: {},
   layout: undefined,
 }),
   ).not.toThrow();
   
   expect(() =>
 updateComponentParentsList({
   currentComponent: {},
   layout: null,
 }),
   ).not.toThrow();
   
   expect(() =>
 updateComponentParentsList({
   currentComponent: { id: 'id3', children: ['id1', 'id2'] },
   layout: { id3: {} },
 }),
   ).not.toThrow();
   
   expect(() =>
 updateComponentParentsList({
   currentComponent: { id: 'id3' },
   layout: { id3: {} },
 }),
   ).not.toThrow();
   
   expect(() =>
 updateComponentParentsList({
   currentComponent: { id: 'id3' },
   layout: {},
 }),
   ).not.toThrow();
 });
   });
   ```
   
   This approach ensures that your code handles unexpected inputs gracefully 
and avoids runtime errors 
[[1]](https://github.com/apache/superset/blob/master/superset-frontend/src/middleware/asyncEvent.ts)[[2]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/util/updateComponentParentsList.test.js).
   
   
   
   *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[I] Cannot get back asyncquery result [superset]

2024-07-24 Thread via GitHub



oOhyeahh opened a new issue, #29676:
URL: https://github.com/apache/superset/issues/29676

   ### Bug description
   
   I try to use global async query feature flag but I keep getting this error 
on the frontend. 
   ```
   Cannot read properties of undefined (reading 'forEach')
   ```
   
   Here's part of my set up in superset config.py
   ```
   FEATURE_FLAGS = {
   "GLOBAL_ASYNC_QUERIES": True,
   }
   
   # 
   # CACHE CONFIG
   # 
   twelve_hour_seconds = 60 * 60 * 12
   REDIS_HOST = os.environ.get("REDIS_HOST")
   REDIS_PORT = 6379
   CACHE_CONFIG = {
   "CACHE_TYPE": "RedisCache",
   "CACHE_DEFAULT_TIMEOUT": twelve_hour_seconds,
   "CACHE_KEY_PREFIX": "s_results_",
   "CACHE_REDIS_URL": f"redis://{REDIS_HOST}:6379/0",
   }
   # Cache for datasource metadata and query results
   DATA_CACHE_CONFIG = {
   "CACHE_TYPE": "RedisCache",
   "CACHE_DEFAULT_TIMEOUT": twelve_hour_seconds,
   "CACHE_KEY_PREFIX": "s_data_",
   "CACHE_REDIS_URL": f"redis://{REDIS_HOST}:6379/1",
   }
   
   GLOBAL_ASYNC_QUERIES_JWT_SECRET = 
os.environ.get("GLOBAL_ASYNC_QUERIES_JWT_SECRET")
   
   GLOBAL_ASYNC_QUERIES_REDIS_CONFIG = {
   "port": REDIS_PORT,
   "host": REDIS_HOST,
   "db": 0,
   "ssl": False,
   }
   
   
   ### How to reproduce the bug
   
   Use the same config I post and go to any chart/dashboard. You should see the 
error 
   https://github.com/user-attachments/assets/390f3ebb-8621-4728-a6f9-f640b58bf853;>
   
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   3.1.3
   
   ### Python version
   
   3.11
   
   ### Node version
   
   Not applicable
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [X] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [X] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [X] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

1 2 3 4 5 6 7 8 9 10 >

1 - 100 of 35639 matches

Mail list logo