[PATCH] debian: package ruby bindings
Felipe Contreras writes: > > Not according to debian: > http://packages.debian.org/sid/amd64/libnotmuch-dev/filelist > The latest is in experimental (because of the freeze) http://packages.debian.org/experimental/amd64/libnotmuch-dev/filelist d
[PATCH] debian: package ruby bindings
Felipe Contreras writes: > On Sat, Apr 13, 2013 at 6:35 AM, David Bremner wrote: >> Felipe Contreras writes: >> Mainly I've been busy. I need to double check the ruby packaging with >> somebody else. So, please continue to be patient, and not modify the >> stuff in ./debian. > > All right. I installed debian squeeze through debootstrap to test > this, and everything worked fine except for dh_python3 renaming .so > files, but that happened also for /usr/lib/libnotmuch.so, which makes > me think that dh_python3 is all buggy and nobody is really using it at > this point. Hi Felipe; Probably you should test in unstable (sid) since that's where the official packages get built. It's also a newer version of python3 (and hence dh_python3). The current packages are multi-arch, so they actually install into /usr/lib/$(arch_triple)/libnotmuch.so; I'm not sure if that is a typo on your part, or something is wrong there as well. d
[PATCH] debian: package ruby bindings
On Sat, Apr 13, 2013 at 6:35 AM, David Bremner wrote: > Felipe Contreras writes: > Mainly I've been busy. I need to double check the ruby packaging with > somebody else. So, please continue to be patient, and not modify the > stuff in ./debian. All right. I installed debian squeeze through debootstrap to test this, and everything worked fine except for dh_python3 renaming .so files, but that happened also for /usr/lib/libnotmuch.so, which makes me think that dh_python3 is all buggy and nobody is really using it at this point. Cheers. -- Felipe Contreras
[PATCH 1/1] emacs: fixed (declare-function ...) definitions
Mark Walters writes: > On Wed, 10 Apr 2013, Tomi Ollila wrote: >> Some (declare-function ...) definitions were drifted away from the >> actual (defun ...)'s. To find the drifts and to verify changes >> the following command line was used: >> >> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")' > > This patch looks good to me +1. > > Is it worth making the above command into a test? Maybe a release check? d
[PATCH] debian: package ruby bindings
Felipe Contreras writes: > On Wed, Apr 3, 2013 at 5:27 PM, Felipe Contreras > wrote: >> Signed-off-by: Felipe Contreras >> --- >> debian/control | 14 ++ >> debian/notmuch-ruby.install | 1 + >> debian/rules| 9 + >> 3 files changed, 24 insertions(+) >> create mode 100644 debian/notmuch-ruby.install > > No comments? Should I push this? > Hi Felipe; Mainly I've been busy. I need to double check the ruby packaging with somebody else. So, please continue to be patient, and not modify the stuff in ./debian. Thanks d
[PATCH 1/1] emacs: fixed (declare-function ...) definitions
On Wed, 10 Apr 2013, Tomi Ollila wrote: > Some (declare-function ...) definitions were drifted away from the > actual (defun ...)'s. To find the drifts and to verify changes > the following command line was used: > > $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")' This patch looks good to me +1. Is it worth making the above command into a test? Best wishes Mark > emacs/notmuch-hello.el | 2 +- > emacs/notmuch-show.el | 1 - > emacs/notmuch-wash.el | 2 +- > 3 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > index cda79f1..c1c6f4b 100644 > --- a/emacs/notmuch-hello.el > +++ b/emacs/notmuch-hello.el > @@ -26,7 +26,7 @@ > (require 'notmuch-lib) > (require 'notmuch-mua) > > -(declare-function notmuch-search "notmuch" (query oldest-first > target-thread target-line continuation)) > +(declare-function notmuch-search "notmuch" ( query oldest-first > target-thread target-line continuation)) > (declare-function notmuch-poll "notmuch" ()) > > (defcustom notmuch-hello-recent-searches-max 10 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index a4d2c12..face2a0 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -38,7 +38,6 @@ > (require 'notmuch-print) > > (declare-function notmuch-call-notmuch-process "notmuch" ( args)) > -(declare-function notmuch-fontify-headers "notmuch" nil) > (declare-function notmuch-search-next-thread "notmuch" nil) > (declare-function notmuch-search-show-thread "notmuch" nil) > > diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el > index 826b6f4..80c475c 100644 > --- a/emacs/notmuch-wash.el > +++ b/emacs/notmuch-wash.el > @@ -23,7 +23,7 @@ > > (require 'coolj) > > -(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part > depth)) > +(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part > depth hide)) > > ;; > > -- > 1.8.0 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] debian: package ruby bindings
On Sat, Apr 13, 2013 at 1:14 AM, Tomi Ollila wrote: > On Sat, Apr 13 2013, Felipe Contreras wrote: > >> On Wed, Apr 3, 2013 at 5:27 PM, Felipe Contreras >> wrote: >>> Signed-off-by: Felipe Contreras >>> --- >>> debian/control | 14 ++ >>> debian/notmuch-ruby.install | 1 + >>> debian/rules| 9 + >>> 3 files changed, 24 insertions(+) >>> create mode 100644 debian/notmuch-ruby.install >> >> No comments? Should I push this? > > How do we ensure that ruby package is working in every release; > there seems to be no tests for it ? We probably should have tests, but how is that relevant to this patch? The code is already there, and distributions are already shipping it: https://projects.archlinux.org/svntogit/community.git/plain/trunk/PKGBUILD?h=packages/notmuch If there's reason to be worried about shipping something that doesn't work, too late, we are already shipping it. And that's orthogonal to this patch, shouldn't prevent it to be merged. Cheers. -- Felipe Contreras
[PATCH] debian: package ruby bindings
On Wed, Apr 3, 2013 at 5:27 PM, Felipe Contreras wrote: > Signed-off-by: Felipe Contreras > --- > debian/control | 14 ++ > debian/notmuch-ruby.install | 1 + > debian/rules| 9 + > 3 files changed, 24 insertions(+) > create mode 100644 debian/notmuch-ruby.install No comments? Should I push this? -- Felipe Contreras
Re: [PATCH] debian: package ruby bindings
On Sat, Apr 13 2013, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Apr 3, 2013 at 5:27 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- debian/control | 14 ++ debian/notmuch-ruby.install | 1 + debian/rules| 9 + 3 files changed, 24 insertions(+) create mode 100644 debian/notmuch-ruby.install No comments? Should I push this? How do we ensure that ruby package is working in every release; there seems to be no tests for it ? -- Felipe Contreras Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] debian: package ruby bindings
On Sat, Apr 13, 2013 at 1:14 AM, Tomi Ollila tomi.oll...@iki.fi wrote: On Sat, Apr 13 2013, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Apr 3, 2013 at 5:27 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- debian/control | 14 ++ debian/notmuch-ruby.install | 1 + debian/rules| 9 + 3 files changed, 24 insertions(+) create mode 100644 debian/notmuch-ruby.install No comments? Should I push this? How do we ensure that ruby package is working in every release; there seems to be no tests for it ? We probably should have tests, but how is that relevant to this patch? The code is already there, and distributions are already shipping it: https://projects.archlinux.org/svntogit/community.git/plain/trunk/PKGBUILD?h=packages/notmuch If there's reason to be worried about shipping something that doesn't work, too late, we are already shipping it. And that's orthogonal to this patch, shouldn't prevent it to be merged. Cheers. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions
On Wed, 10 Apr 2013, Tomi Ollila tomi.oll...@iki.fi wrote: Some (declare-function ...) definitions were drifted away from the actual (defun ...)'s. To find the drifts and to verify changes the following command line was used: $ emacs --batch -L emacs --eval '(check-declare-directory emacs)' This patch looks good to me +1. Is it worth making the above command into a test? Best wishes Mark emacs/notmuch-hello.el | 2 +- emacs/notmuch-show.el | 1 - emacs/notmuch-wash.el | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index cda79f1..c1c6f4b 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -26,7 +26,7 @@ (require 'notmuch-lib) (require 'notmuch-mua) -(declare-function notmuch-search notmuch (query optional oldest-first target-thread target-line continuation)) +(declare-function notmuch-search notmuch (optional query oldest-first target-thread target-line continuation)) (declare-function notmuch-poll notmuch ()) (defcustom notmuch-hello-recent-searches-max 10 diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a4d2c12..face2a0 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -38,7 +38,6 @@ (require 'notmuch-print) (declare-function notmuch-call-notmuch-process notmuch (rest args)) -(declare-function notmuch-fontify-headers notmuch nil) (declare-function notmuch-search-next-thread notmuch nil) (declare-function notmuch-search-show-thread notmuch nil) diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el index 826b6f4..80c475c 100644 --- a/emacs/notmuch-wash.el +++ b/emacs/notmuch-wash.el @@ -23,7 +23,7 @@ (require 'coolj) -(declare-function notmuch-show-insert-bodypart notmuch-show (msg part depth)) +(declare-function notmuch-show-insert-bodypart notmuch-show (msg part depth optional hide)) ;; -- 1.8.0 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] debian: package ruby bindings
Felipe Contreras felipe.contre...@gmail.com writes: On Wed, Apr 3, 2013 at 5:27 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- debian/control | 14 ++ debian/notmuch-ruby.install | 1 + debian/rules| 9 + 3 files changed, 24 insertions(+) create mode 100644 debian/notmuch-ruby.install No comments? Should I push this? Hi Felipe; Mainly I've been busy. I need to double check the ruby packaging with somebody else. So, please continue to be patient, and not modify the stuff in ./debian. Thanks d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions
Mark Walters markwalters1...@gmail.com writes: On Wed, 10 Apr 2013, Tomi Ollila tomi.oll...@iki.fi wrote: Some (declare-function ...) definitions were drifted away from the actual (defun ...)'s. To find the drifts and to verify changes the following command line was used: $ emacs --batch -L emacs --eval '(check-declare-directory emacs)' This patch looks good to me +1. Is it worth making the above command into a test? Maybe a release check? d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] debian: package ruby bindings
On Sat, Apr 13, 2013 at 6:35 AM, David Bremner brem...@debian.org wrote: Felipe Contreras felipe.contre...@gmail.com writes: Mainly I've been busy. I need to double check the ruby packaging with somebody else. So, please continue to be patient, and not modify the stuff in ./debian. All right. I installed debian squeeze through debootstrap to test this, and everything worked fine except for dh_python3 renaming .so files, but that happened also for /usr/lib/libnotmuch.so, which makes me think that dh_python3 is all buggy and nobody is really using it at this point. Cheers. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] debian: package ruby bindings
Felipe Contreras felipe.contre...@gmail.com writes: On Sat, Apr 13, 2013 at 6:35 AM, David Bremner brem...@debian.org wrote: Felipe Contreras felipe.contre...@gmail.com writes: Mainly I've been busy. I need to double check the ruby packaging with somebody else. So, please continue to be patient, and not modify the stuff in ./debian. All right. I installed debian squeeze through debootstrap to test this, and everything worked fine except for dh_python3 renaming .so files, but that happened also for /usr/lib/libnotmuch.so, which makes me think that dh_python3 is all buggy and nobody is really using it at this point. Hi Felipe; Probably you should test in unstable (sid) since that's where the official packages get built. It's also a newer version of python3 (and hence dh_python3). The current packages are multi-arch, so they actually install into /usr/lib/$(arch_triple)/libnotmuch.so; I'm not sure if that is a typo on your part, or something is wrong there as well. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] debian: package ruby bindings
On Sat, Apr 13, 2013 at 10:00 AM, David Bremner brem...@debian.org wrote: Probably you should test in unstable (sid) since that's where the official packages get built. It's also a newer version of python3 (and hence dh_python3). I'll give that a try. The current packages are multi-arch, so they actually install into /usr/lib/$(arch_triple)/libnotmuch.so; I'm not sure if that is a typo on your part, or something is wrong there as well. Not according to debian: http://packages.debian.org/sid/amd64/libnotmuch-dev/filelist -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] debian: package ruby bindings
Felipe Contreras felipe.contre...@gmail.com writes: Not according to debian: http://packages.debian.org/sid/amd64/libnotmuch-dev/filelist The latest is in experimental (because of the freeze) http://packages.debian.org/experimental/amd64/libnotmuch-dev/filelist d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
