[jira] Created: (NUTCH-454) Review Debug Level Log Guards
Review Debug Level Log Guards - Key: NUTCH-454 URL: https://issues.apache.org/jira/browse/NUTCH-454 Project: Nutch Issue Type: Bug Affects Versions: 0.8.1, 0.9.0 Environment: all Reporter: Dennis Kubes Assigned To: Chris A. Mattmann Fix For: 0.9.0, 0.8.1 There are currently log guards (i.e. is*Enabled type code) in many different places in the code. NUTCH-309 is related to removing those log guards. The caveat is that debug level log guards should be reviewed and should be kept only when in performance critical inner loops. The instances where this occurs should be few and far between. This issue request is for reviewing the debug level code guards and keeping only the performance critical ones. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: log guards
Hi Dennis, I'd be happy to: please contact me off list ([EMAIL PROTECTED]), and let's chat :-) Cheers, Chris On 2/28/07 7:38 AM, "Dennis Kubes" <[EMAIL PROTECTED]> wrote: > I can also work on this, Chris do you want me to do it or do you want to > coordinate our efforts? > > Dennis Kubes > > Jérôme Charron wrote: >> Hi Chris, >> >> The JIRA issue is the 309 : https://issues.apache.org/jira/browse/NUTCH-309 >> Thanks for your help. >> >> Jérôme >> >> On 2/13/07, Chris Mattmann <[EMAIL PROTECTED]> wrote: >>> >>> Hi Doug, and Jerome, >>> >>> Ah, yes, the log guard conversation. I remember this from a while back. >>> Hmmm, do you guys know what issue that this recorded as in JIRA? I have >>> some >>> free time recently, so I will be able to add this to my list of Nutch >>> stuff >>> to work on, and would be happy to take the lead on removing the guards >>> where >>> needed, and reviewing whether or not the debug ones make sense where they >>> are. >>> >>> Cheers, >>> Chris >>> >>> >>> >>> On 2/13/07 11:17 AM, "Jérôme Charron" <[EMAIL PROTECTED]> wrote: >>> > These guards were all introduced by a patch some time ago. I >>> complained > at the time and it was promised that this would be repaired, but it >>> has > not yet been. Yes, Sorry Doug that's my own fault I really don't have time to fix this :-( Best regards Jérôme >>> >>> __ >>> Chris A. Mattmann >>> [EMAIL PROTECTED] >>> Staff Member >>> Modeling and Data Management Systems Section (387) >>> Data Management Systems and Technologies Group >>> >>> _ >>> Jet Propulsion LaboratoryPasadena, CA >>> Office: 171-266BMailstop: 171-246 >>> ___ >>> >>> Disclaimer: The opinions presented within are my own and do not reflect >>> those of either NASA, JPL, or the California Institute of Technology. >>> >>> >>> >> __ Chris A. Mattmann [EMAIL PROTECTED] Staff Member Modeling and Data Management Systems Section (387) Data Management Systems and Technologies Group _ Jet Propulsion LaboratoryPasadena, CA Office: 171-266BMailstop: 171-246 ___ Disclaimer: The opinions presented within are my own and do not reflect those of either NASA, JPL, or the California Institute of Technology.
Re: log guards
I can also work on this, Chris do you want me to do it or do you want to coordinate our efforts? Dennis Kubes Jérôme Charron wrote: Hi Chris, The JIRA issue is the 309 : https://issues.apache.org/jira/browse/NUTCH-309 Thanks for your help. Jérôme On 2/13/07, Chris Mattmann <[EMAIL PROTECTED]> wrote: Hi Doug, and Jerome, Ah, yes, the log guard conversation. I remember this from a while back. Hmmm, do you guys know what issue that this recorded as in JIRA? I have some free time recently, so I will be able to add this to my list of Nutch stuff to work on, and would be happy to take the lead on removing the guards where needed, and reviewing whether or not the debug ones make sense where they are. Cheers, Chris On 2/13/07 11:17 AM, "Jérôme Charron" <[EMAIL PROTECTED]> wrote: >> These guards were all introduced by a patch some time ago. I complained >> at the time and it was promised that this would be repaired, but it has >> not yet been. > > Yes, Sorry Doug that's my own fault > I really don't have time to fix this :-( > > Best regards > > Jérôme __ Chris A. Mattmann [EMAIL PROTECTED] Staff Member Modeling and Data Management Systems Section (387) Data Management Systems and Technologies Group _ Jet Propulsion LaboratoryPasadena, CA Office: 171-266BMailstop: 171-246 ___ Disclaimer: The opinions presented within are my own and do not reflect those of either NASA, JPL, or the California Institute of Technology.
Re: log guards
Hi Chris, The JIRA issue is the 309 : https://issues.apache.org/jira/browse/NUTCH-309 Thanks for your help. Jérôme On 2/13/07, Chris Mattmann <[EMAIL PROTECTED]> wrote: Hi Doug, and Jerome, Ah, yes, the log guard conversation. I remember this from a while back. Hmmm, do you guys know what issue that this recorded as in JIRA? I have some free time recently, so I will be able to add this to my list of Nutch stuff to work on, and would be happy to take the lead on removing the guards where needed, and reviewing whether or not the debug ones make sense where they are. Cheers, Chris On 2/13/07 11:17 AM, "Jérôme Charron" <[EMAIL PROTECTED]> wrote: >> These guards were all introduced by a patch some time ago. I complained >> at the time and it was promised that this would be repaired, but it has >> not yet been. > > Yes, Sorry Doug that's my own fault > I really don't have time to fix this :-( > > Best regards > > Jérôme __ Chris A. Mattmann [EMAIL PROTECTED] Staff Member Modeling and Data Management Systems Section (387) Data Management Systems and Technologies Group _ Jet Propulsion LaboratoryPasadena, CA Office: 171-266BMailstop: 171-246 ___ Disclaimer: The opinions presented within are my own and do not reflect those of either NASA, JPL, or the California Institute of Technology.
Re: log guards
Hi Doug, and Jerome, Ah, yes, the log guard conversation. I remember this from a while back. Hmmm, do you guys know what issue that this recorded as in JIRA? I have some free time recently, so I will be able to add this to my list of Nutch stuff to work on, and would be happy to take the lead on removing the guards where needed, and reviewing whether or not the debug ones make sense where they are. Cheers, Chris On 2/13/07 11:17 AM, "Jérôme Charron" <[EMAIL PROTECTED]> wrote: >> These guards were all introduced by a patch some time ago. I complained >> at the time and it was promised that this would be repaired, but it has >> not yet been. > > Yes, Sorry Doug that's my own fault > I really don't have time to fix this :-( > > Best regards > > Jérôme __ Chris A. Mattmann [EMAIL PROTECTED] Staff Member Modeling and Data Management Systems Section (387) Data Management Systems and Technologies Group _ Jet Propulsion LaboratoryPasadena, CA Office: 171-266BMailstop: 171-246 ___ Disclaimer: The opinions presented within are my own and do not reflect those of either NASA, JPL, or the California Institute of Technology.
Re: log guards
These guards were all introduced by a patch some time ago. I complained at the time and it was promised that this would be repaired, but it has not yet been. Yes, Sorry Doug that's my own fault I really don't have time to fix this :-( Best regards Jérôme
log guards
Doug Cutting (JIRA) wrote: this patch in some places removes the log guards Most of the log guards are misguided. Log guards should only be used on DEBUG level messages in performance-critical inner loops. Since INFO is the expected log level, a guard on INFO & WARN level messages does not improve performance, since these will be shown. And most DEBUG-level messages are not in performance critical code and hence do not need guards. The guards only make the code bigger and thus harder to read and maintain. In particular, in all places where we check isWarnEnabled(), isFatalEnabled() and isInfoEnabled(), the 'if' should be removed. All calls to isDebugEnabled() should be reviewed, and most should be removed. These guards were all introduced by a patch some time ago. I complained at the time and it was promised that this would be repaired, but it has not yet been. Doug
