[jira] [Assigned] (OAK-8413) Use the new Azure SDK in the Azure Segment Store
[
https://issues.apache.org/jira/browse/OAK-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Ryan reassigned OAK-8413:
--
Assignee: Matt Ryan
> Use the new Azure SDK in the Azure Segment Store
>
>
> Key: OAK-8413
> URL: https://issues.apache.org/jira/browse/OAK-8413
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: segment-azure
>Reporter: Tomek Rękawek
>Assignee: Matt Ryan
>Priority: Major
> Fix For: 1.20.0
>
>
> We should update the oak-segment-azure to use the most recent Azure SDK
> version, to keep it compatible with the oak-blob-cloud-azure (see OAK-8105):
> {code}
>
> com.microsoft.azure
> azure-storage-blob
> 11.0.1
>
> {code}
> //cc: [~mattvryan]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8105) [Direct Binary Access] Update to latest Azure Blob Storage SDK
[
https://issues.apache.org/jira/browse/OAK-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942344#comment-16942344
]
Matt Ryan commented on OAK-8105:
I have a mostly-working version of {{AzureDataStore}} now atop the Azure v12
SDK preview. SAS-based authentication is working and in my branch I have
extended the tests to also test using this authentication method.
The challenge of updating an existing blob's last modified time remains. The
SDK does not allow us to modify this property directly. In the v8 SDK, we
achieved the end goal by instructing the service to copy the blob to itself,
which had the effect of updating the last modified time. So far I have not
been able to get this to work in the new SDKs (v10, v11, or v12) - a 404 error
is returned. This issue has been brought up with Microsoft and we are working
on a resolution.
> [Direct Binary Access] Update to latest Azure Blob Storage SDK
> --
>
> Key: OAK-8105
> URL: https://issues.apache.org/jira/browse/OAK-8105
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: blob-cloud-azure
>Affects Versions: 1.10.0, 1.12.0
>Reporter: Matt Ryan
>Assignee: Matt Ryan
>Priority: Major
>
> Since the implementation of the original AzureDataStore, the [original Azure
> SDK for Java|https://github.com/Azure/azure-sdk-for-java] has been
> [deprecated|https://github.com/Azure/azure-sdk-for-java/blob/master/README.md]
> and replaced with a [newer SDK|https://github.com/Azure/azure-storage-java]
> that uses a different API.
> The issue raised in OAK-8013 could not be properly fixed due to a bug in the
> original SDK. OAK-8104 was created for the purpose of ensuring this gets
> fixed properly instead of settling for the workaround implemented with
> OAK-8013. The latest Azure SDK does not exhibit the bug that was in the
> original SDK, so the proper way to fix OAK-8104 is to update AzureDataStore
> to use the latest Azure SDK.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8658) Build Jackrabbit Oak #2414 failed
[ https://issues.apache.org/jira/browse/OAK-8658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942197#comment-16942197 ] Hudson commented on OAK-8658: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #2416|https://builds.apache.org/job/Jackrabbit%20Oak/2416/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/2416/console] > Build Jackrabbit Oak #2414 failed > - > > Key: OAK-8658 > URL: https://issues.apache.org/jira/browse/OAK-8658 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #2414 has failed. > First failed run: [Jackrabbit Oak > #2414|https://builds.apache.org/job/Jackrabbit%20Oak/2414/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/2414/console] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8661) deprecate public LazyInputStream(ByteSource byteSource)
[ https://issues.apache.org/jira/browse/OAK-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942168#comment-16942168 ] Julian Reschke commented on OAK-8661: - Proposed patch: [^OAK-8661.diff] (still need to figure out the logging approach) > deprecate public LazyInputStream(ByteSource byteSource) > --- > > Key: OAK-8661 > URL: https://issues.apache.org/jira/browse/OAK-8661 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: commons >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Attachments: OAK-8661.diff > > > - add constructor "Supplier > - add test coverage > - adjust uses > - log calls to old constructor -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8661) deprecate public LazyInputStream(ByteSource byteSource)
[ https://issues.apache.org/jira/browse/OAK-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8661: Attachment: OAK-8661.diff > deprecate public LazyInputStream(ByteSource byteSource) > --- > > Key: OAK-8661 > URL: https://issues.apache.org/jira/browse/OAK-8661 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: commons >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Attachments: OAK-8661.diff > > > - add constructor "Supplier > - add test coverage > - adjust uses > - log calls to old constructor -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8662) Benchmark results for eagercachesize
Angela Schreiber created OAK-8662: - Summary: Benchmark results for eagercachesize Key: OAK-8662 URL: https://issues.apache.org/jira/browse/OAK-8662 Project: Jackrabbit Oak Issue Type: Technical task Components: benchmarks Reporter: Angela Schreiber Assignee: Angela Schreiber -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OAK-8660) Dedicated benchmark for eagerCacheSize option
[ https://issues.apache.org/jira/browse/OAK-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved OAK-8660. --- Fix Version/s: 1.20.0 Resolution: Fixed > Dedicated benchmark for eagerCacheSize option > - > > Key: OAK-8660 > URL: https://issues.apache.org/jira/browse/OAK-8660 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: benchmarks >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: 1.20.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8660) Dedicated benchmark for eagerCacheSize option
[ https://issues.apache.org/jira/browse/OAK-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942110#comment-16942110 ] Angela Schreiber commented on OAK-8660: --- Committed revision 1867848. > Dedicated benchmark for eagerCacheSize option > - > > Key: OAK-8660 > URL: https://issues.apache.org/jira/browse/OAK-8660 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: benchmarks >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8661) deprecate public LazyInputStream(ByteSource byteSource)
Julian Reschke created OAK-8661: --- Summary: deprecate public LazyInputStream(ByteSource byteSource) Key: OAK-8661 URL: https://issues.apache.org/jira/browse/OAK-8661 Project: Jackrabbit Oak Issue Type: Technical task Components: commons Reporter: Julian Reschke Assignee: Julian Reschke - add constructor "Supplier - add test coverage - adjust uses - log calls to old constructor -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8660) Dedicated benchmark for eagerCacheSize option
Angela Schreiber created OAK-8660: - Summary: Dedicated benchmark for eagerCacheSize option Key: OAK-8660 URL: https://issues.apache.org/jira/browse/OAK-8660 Project: Jackrabbit Oak Issue Type: Technical task Components: benchmarks Reporter: Angela Schreiber Assignee: Angela Schreiber -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-7217) check public Oak APIs for references to Guava
[
https://issues.apache.org/jira/browse/OAK-7217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942076#comment-16942076
]
Julian Reschke commented on OAK-7217:
-
FWIW, I just realized that the baseline plugin can be used for checking. For
instance:
{noformat}
fgrep -B7 google */target/baseline.xml
{noformat}
yields:
{noformat}
oak-commons/target/baseline.xml-
oak-commons/target/baseline.xml-false
oak-commons/target/baseline.xml-1.5.0
oak-commons/target/baseline.xml-1.5.0
oak-commons/target/baseline.xml-1.5.0
oak-commons/target/baseline.xml-
oak-commons/target/baseline.xml- 1.5.0
oak-commons/target/baseline.xml:
com.google.common.base,com.google.common.collect,org.apache.commons.io,org.slf4j
--
oak-commons/target/baseline.xml-
oak-commons/target/baseline.xml-false
oak-commons/target/baseline.xml-1.0.0
oak-commons/target/baseline.xml-1.0.0
oak-commons/target/baseline.xml-1.0.0
oak-commons/target/baseline.xml-
oak-commons/target/baseline.xml- 1.0.0
oak-commons/target/baseline.xml: com.google.common.io
--
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml- 1.1.0
oak-core-spi/target/baseline.xml:
com.google.common.cache,com.google.common.collect,org.apache.jackrabbit.oak.api.jmx,org.apache.jackrabbit.oak.commons.jmx
--
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml- 1.0.1
oak-core-spi/target/baseline.xml:
com.google.common.base,javax.management,javax.management.openmbean,org.apache.jackrabbit.oak.api.jmx
--
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml- 1.0.1
oak-core-spi/target/baseline.xml: com.google.common.base
--
oak-security-spi/target/baseline.xml-
oak-security-spi/target/baseline.xml-false
oak-security-spi/target/baseline.xml-2.1.1
oak-security-spi/target/baseline.xml-2.1.1
oak-security-spi/target/baseline.xml-
2.1.1
oak-security-spi/target/baseline.xml-
oak-security-spi/target/baseline.xml- 2.1.1
oak-security-spi/target/baseline.xml:
com.google.common.collect,javax.jcr
{noformat}
> check public Oak APIs for references to Guava
> -
>
> Key: OAK-7217
> URL: https://issues.apache.org/jira/browse/OAK-7217
> Project: Jackrabbit Oak
> Issue Type: Technical task
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: detect-api.diff, extract-guava.sh,
> fileutils-no-commons.diff, guava-global.log, guava-public-v2.log,
> guava-public.log
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OAK-7217) check public Oak APIs for references to Guava
[ https://issues.apache.org/jira/browse/OAK-7217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842162#comment-16842162 ] Julian Reschke edited comment on OAK-7217 at 10/1/19 3:29 PM: -- [^fileutils-no-commons.diff] - FWIW, getting rid of commons.io.LineIterator is pretty simply, as it implements Iterator. However, bundle:baseline gets unhappy, probably because the class on which the methods sits is not final. was (Author: reschke): [^fileutils-no-commons.diff] - FWIW, getting rid of commons.io.LineIterator is pretty simply, as it implements Iterator. However, bundle:baseline gets unhappy, probably because the class on which the methods sit is not final. > check public Oak APIs for references to Guava > - > > Key: OAK-7217 > URL: https://issues.apache.org/jira/browse/OAK-7217 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Priority: Minor > Attachments: detect-api.diff, extract-guava.sh, > fileutils-no-commons.diff, guava-global.log, guava-public-v2.log, > guava-public.log > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8650) PrincipalProviderTest fails with java 14
[
https://issues.apache.org/jira/browse/OAK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942030#comment-16942030
]
Angela Schreiber edited comment on OAK-8650 at 10/1/19 2:46 PM:
[~reschke], all 3 tests have in common that they call a 'default' method of the
{{PrincipalProvider}} interface. For some reason with older java versions using
{{Mockito.doCallRealMethod()}} works for methods on interfaces that come with a
default implementation, but it is considered 'abstract' (like methods that
don't have a default impl) in java 14.
while it could be fixed by creating anonymous {{PrincipalProvider}} for the
test case (see patch), i would have preferred the mock-style. and obviously
would be curious what exactly is the reason for that changed behavior.
was (Author: anchela):
[~reschke], all 3 tests have in common that they call a 'default' method of the
{{PrincipalProvider}} interface. For some reason with older java versions using
{{Mockito.doCallRealMethod()}} works for methods on interfaces that come with a
default implementation, but it is considered 'abstract' (like methods that
don't have a default impl) in java 14.
while it could be fixed by creating anonymous {{PrincipalProvider}} for the
test case, i would have preferred the mock-style. and obviously would be
curious what exactly is the reason for that changed behavior.
> PrincipalProviderTest fails with java 14
>
>
> Key: OAK-8650
> URL: https://issues.apache.org/jira/browse/OAK-8650
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: security-spi
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Attachments: OAK-8650.patch
>
>
> (with the fix for OAK-7358 applies, and jacoco turned off)
> {noformat}
> [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed:
> 0.013 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest
> [ERROR]
> testGetItemBasedPrincipal(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0.012 s <<< ERROR!
> org.mockito.exceptions.base.MockitoException:Cannot call abstract real method
> on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testGetItemBasedPrincipal(PrincipalProviderTest.java:36)[ERROR]
>
> testGetMembershipPrincipals(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0 s <<< ERROR!
> org.mockito.exceptions.base.MockitoException:Cannot call abstract real method
> on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testGetMembershipPrincipals(PrincipalProviderTest.java:43)[ERROR]
>
> testNegativeOffset(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testNegativeOffset(PrincipalProviderTest.java:51){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8650) PrincipalProviderTest fails with java 14
[
https://issues.apache.org/jira/browse/OAK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated OAK-8650:
--
Attachment: OAK-8650.patch
> PrincipalProviderTest fails with java 14
>
>
> Key: OAK-8650
> URL: https://issues.apache.org/jira/browse/OAK-8650
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: security-spi
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Attachments: OAK-8650.patch
>
>
> (with the fix for OAK-7358 applies, and jacoco turned off)
> {noformat}
> [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed:
> 0.013 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest
> [ERROR]
> testGetItemBasedPrincipal(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0.012 s <<< ERROR!
> org.mockito.exceptions.base.MockitoException:Cannot call abstract real method
> on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testGetItemBasedPrincipal(PrincipalProviderTest.java:36)[ERROR]
>
> testGetMembershipPrincipals(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0 s <<< ERROR!
> org.mockito.exceptions.base.MockitoException:Cannot call abstract real method
> on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testGetMembershipPrincipals(PrincipalProviderTest.java:43)[ERROR]
>
> testNegativeOffset(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testNegativeOffset(PrincipalProviderTest.java:51){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8650) PrincipalProviderTest fails with java 14
[
https://issues.apache.org/jira/browse/OAK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942030#comment-16942030
]
Angela Schreiber commented on OAK-8650:
---
[~reschke], all 3 tests have in common that they call a 'default' method of the
{{PrincipalProvider}} interface. For some reason with older java versions using
{{Mockito.doCallRealMethod()}} works for methods on interfaces that come with a
default implementation, but it is considered 'abstract' (like methods that
don't have a default impl) in java 14.
while it could be fixed by creating anonymous {{PrincipalProvider}} for the
test case, i would have preferred the mock-style. and obviously would be
curious what exactly is the reason for that changed behavior.
> PrincipalProviderTest fails with java 14
>
>
> Key: OAK-8650
> URL: https://issues.apache.org/jira/browse/OAK-8650
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: security-spi
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
>
> (with the fix for OAK-7358 applies, and jacoco turned off)
> {noformat}
> [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed:
> 0.013 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest
> [ERROR]
> testGetItemBasedPrincipal(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0.012 s <<< ERROR!
> org.mockito.exceptions.base.MockitoException:Cannot call abstract real method
> on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testGetItemBasedPrincipal(PrincipalProviderTest.java:36)[ERROR]
>
> testGetMembershipPrincipals(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0 s <<< ERROR!
> org.mockito.exceptions.base.MockitoException:Cannot call abstract real method
> on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testGetMembershipPrincipals(PrincipalProviderTest.java:43)[ERROR]
>
> testNegativeOffset(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testNegativeOffset(PrincipalProviderTest.java:51){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OAK-8624) oak-run: tests leak mapd temp files
[
https://issues.apache.org/jira/browse/OAK-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931524#comment-16931524
]
Julian Reschke edited comment on OAK-8624 at 10/1/19 12:35 PM:
---
trunk: (1.18.0) [r1867061|http://svn.apache.org/r1867061]
1.10: [r1867841|http://svn.apache.org/r1867841]
was (Author: reschke):
trunk: [r1867061|http://svn.apache.org/r1867061]
> oak-run: tests leak mapd temp files
> ---
>
> Key: OAK-8624
> URL: https://issues.apache.org/jira/browse/OAK-8624
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: run
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_8
> Fix For: 1.18.0, 1.10.6
>
> Attachments: OAK-8624.diff
>
>
> This is because {{MapDBMapFactory}} is backed by temporary DB, but that one
> is never closed.
> Fix:
> - make it {{closeable}}
> - adapt test case and use in {{RecoveryCommand}}
> However, {{RecoveryCommand}} sets the {{MapFactory}} instance globally, and
> never resets it. Thus, if the factory is indeed closed, subsequent tests will
> fail. So, in {{RecoveryCommand}}, restore the default factory when done.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8624) oak-run: tests leak mapd temp files
[
https://issues.apache.org/jira/browse/OAK-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8624:
Labels: candidate_oak_1_8 (was: candidate_oak_1_10)
> oak-run: tests leak mapd temp files
> ---
>
> Key: OAK-8624
> URL: https://issues.apache.org/jira/browse/OAK-8624
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: run
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_8
> Fix For: 1.18.0, 1.10.6
>
> Attachments: OAK-8624.diff
>
>
> This is because {{MapDBMapFactory}} is backed by temporary DB, but that one
> is never closed.
> Fix:
> - make it {{closeable}}
> - adapt test case and use in {{RecoveryCommand}}
> However, {{RecoveryCommand}} sets the {{MapFactory}} instance globally, and
> never resets it. Thus, if the factory is indeed closed, subsequent tests will
> fail. So, in {{RecoveryCommand}}, restore the default factory when done.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8624) oak-run: tests leak mapd temp files
[
https://issues.apache.org/jira/browse/OAK-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8624:
Fix Version/s: 1.10.6
> oak-run: tests leak mapd temp files
> ---
>
> Key: OAK-8624
> URL: https://issues.apache.org/jira/browse/OAK-8624
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: run
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_10
> Fix For: 1.18.0, 1.10.6
>
> Attachments: OAK-8624.diff
>
>
> This is because {{MapDBMapFactory}} is backed by temporary DB, but that one
> is never closed.
> Fix:
> - make it {{closeable}}
> - adapt test case and use in {{RecoveryCommand}}
> However, {{RecoveryCommand}} sets the {{MapFactory}} instance globally, and
> never resets it. Thus, if the factory is indeed closed, subsequent tests will
> fail. So, in {{RecoveryCommand}}, restore the default factory when done.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8629) Node bundling exposes hidden properties
[ https://issues.apache.org/jira/browse/OAK-8629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941773#comment-16941773 ] Julian Reschke commented on OAK-8629: - trunk: (1.18.0) [r1867374|http://svn.apache.org/r1867374] [r1867136|http://svn.apache.org/r1867136] [r1867060|http://svn.apache.org/r1867060] [r1867057|http://svn.apache.org/r1867057] > Node bundling exposes hidden properties > --- > > Key: OAK-8629 > URL: https://issues.apache.org/jira/browse/OAK-8629 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Affects Versions: 1.16.0 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_10, candidate_oak_1_6, candidate_oak_1_8 > Fix For: 1.18.0 > > Attachments: OAK-8629.patch > > > The DocumentNodeStore node bundling feature may expose a hidden internal > property when a bundled node structure is deleted and re-created with a > non-bundling nodetype. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8643) PrincipalProvider.getMembershipPrincipals should not delegate to deprecated method
[ https://issues.apache.org/jira/browse/OAK-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936049#comment-16936049 ] Julian Reschke edited comment on OAK-8643 at 10/1/19 12:09 PM: --- trunk: (1.18.0) [r1867385|http://svn.apache.org/r1867385] 1.10: [r1867838|http://svn.apache.org/r1867838] was (Author: reschke): trunk: [r1867385|http://svn.apache.org/r1867385] > PrincipalProvider.getMembershipPrincipals should not delegate to deprecated > method > -- > > Key: OAK-8643 > URL: https://issues.apache.org/jira/browse/OAK-8643 > Project: Jackrabbit Oak > Issue Type: Bug > Components: security, security-spi >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8643) PrincipalProvider.getMembershipPrincipals should not delegate to deprecated method
[ https://issues.apache.org/jira/browse/OAK-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8643: Labels: (was: candidate_oak_1_8) > PrincipalProvider.getMembershipPrincipals should not delegate to deprecated > method > -- > > Key: OAK-8643 > URL: https://issues.apache.org/jira/browse/OAK-8643 > Project: Jackrabbit Oak > Issue Type: Bug > Components: security, security-spi >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8643) PrincipalProvider.getMembershipPrincipals should not delegate to deprecated method
[ https://issues.apache.org/jira/browse/OAK-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8643: Labels: candidate_oak_1_8 (was: candidate_oak_1_10) > PrincipalProvider.getMembershipPrincipals should not delegate to deprecated > method > -- > > Key: OAK-8643 > URL: https://issues.apache.org/jira/browse/OAK-8643 > Project: Jackrabbit Oak > Issue Type: Bug > Components: security, security-spi >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8643) PrincipalProvider.getMembershipPrincipals should not delegate to deprecated method
[ https://issues.apache.org/jira/browse/OAK-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8643: Fix Version/s: 1.10.6 > PrincipalProvider.getMembershipPrincipals should not delegate to deprecated > method > -- > > Key: OAK-8643 > URL: https://issues.apache.org/jira/browse/OAK-8643 > Project: Jackrabbit Oak > Issue Type: Bug > Components: security, security-spi >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8625) oak-upgrade leaks empty test folders
[
https://issues.apache.org/jira/browse/OAK-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930606#comment-16930606
]
Julian Reschke edited comment on OAK-8625 at 10/1/19 10:57 AM:
---
trunk: (1.18.0) [r1867005|http://svn.apache.org/r1867005]
1.10: [r1867837|http://svn.apache.org/r1867837]
was (Author: reschke):
trunk: [r1867005|http://svn.apache.org/r1867005]
> oak-upgrade leaks empty test folders
>
>
> Key: OAK-8625
> URL: https://issues.apache.org/jira/browse/OAK-8625
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_8
> Fix For: 1.18.0, 1.10.6
>
> Attachments: OAK-8625.diff
>
>
> This is because of using {{com.google.common.io.Files#createTempDir()}}
> without cleanup up afterwards.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8625) oak-upgrade leaks empty test folders
[
https://issues.apache.org/jira/browse/OAK-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8625:
Labels: candidate_oak_1_8 (was: candidate_oak_1_10)
> oak-upgrade leaks empty test folders
>
>
> Key: OAK-8625
> URL: https://issues.apache.org/jira/browse/OAK-8625
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_8
> Fix For: 1.18.0, 1.10.6
>
> Attachments: OAK-8625.diff
>
>
> This is because of using {{com.google.common.io.Files#createTempDir()}}
> without cleanup up afterwards.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8625) oak-upgrade leaks empty test folders
[
https://issues.apache.org/jira/browse/OAK-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8625:
Fix Version/s: 1.10.6
> oak-upgrade leaks empty test folders
>
>
> Key: OAK-8625
> URL: https://issues.apache.org/jira/browse/OAK-8625
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_10
> Fix For: 1.18.0, 1.10.6
>
> Attachments: OAK-8625.diff
>
>
> This is because of using {{com.google.common.io.Files#createTempDir()}}
> without cleanup up afterwards.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8614) Update httpclient/mime dependencies to 4.5.10
[ https://issues.apache.org/jira/browse/OAK-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8614: Labels: candidate_oak_1_8 (was: candidate_oak_1_10) > Update httpclient/mime dependencies to 4.5.10 > - > > Key: OAK-8614 > URL: https://issues.apache.org/jira/browse/OAK-8614 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8614) Update httpclient/mime dependencies to 4.5.10
[ https://issues.apache.org/jira/browse/OAK-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926478#comment-16926478 ] Julian Reschke edited comment on OAK-8614 at 10/1/19 9:32 AM: -- trunk: (1.18.0) [r1866734|http://svn.apache.org/r1866734] 1.10: [r1867834|http://svn.apache.org/r1867834] was (Author: reschke): trunk: [r1866734|http://svn.apache.org/r1866734] > Update httpclient/mime dependencies to 4.5.10 > - > > Key: OAK-8614 > URL: https://issues.apache.org/jira/browse/OAK-8614 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8614) Update httpclient/mime dependencies to 4.5.10
[ https://issues.apache.org/jira/browse/OAK-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8614: Fix Version/s: 1.10.6 > Update httpclient/mime dependencies to 4.5.10 > - > > Key: OAK-8614 > URL: https://issues.apache.org/jira/browse/OAK-8614 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8657) SimpleCredentialsSupport uses Guava API in exported API
[
https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8657:
Priority: Blocker (was: Major)
> SimpleCredentialsSupport uses Guava API in exported API
> ---
>
> Key: OAK-8657
> URL: https://issues.apache.org/jira/browse/OAK-8657
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: security-spi
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Blocker
> Fix For: 1.24.0
>
>
> {noformat}
> @Override
> @NotNull
> public ImmutableSet getCredentialClasses() {
> return ImmutableSet.of(SimpleCredentials.class);
> }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface).
> However, this would be an incompatible API change; we could do that in sync
> with OAK-7358.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8657) SimpleCredentialsSupport uses Guava API in exported API
[
https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941638#comment-16941638
]
Angela Schreiber commented on OAK-8657:
---
fine with me.
> SimpleCredentialsSupport uses Guava API in exported API
> ---
>
> Key: OAK-8657
> URL: https://issues.apache.org/jira/browse/OAK-8657
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: security-spi
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.24.0
>
>
> {noformat}
> @Override
> @NotNull
> public ImmutableSet getCredentialClasses() {
> return ImmutableSet.of(SimpleCredentials.class);
> }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface).
> However, this would be an incompatible API change; we could do that in sync
> with OAK-7358.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8657) SimpleCredentialsSupport uses Guava API in exported API
[
https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941633#comment-16941633
]
Julian Reschke commented on OAK-8657:
-
+1. It's just that is will require a major version bump, so doing this together
with OAK-7358 makes a lot of sense.
> SimpleCredentialsSupport uses Guava API in exported API
> ---
>
> Key: OAK-8657
> URL: https://issues.apache.org/jira/browse/OAK-8657
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: security-spi
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.24.0
>
>
> {noformat}
> @Override
> @NotNull
> public ImmutableSet getCredentialClasses() {
> return ImmutableSet.of(SimpleCredentials.class);
> }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface).
> However, this would be an incompatible API change; we could do that in sync
> with OAK-7358.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8598) Update httpcore dependency to 4.4.12
[ https://issues.apache.org/jira/browse/OAK-8598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8598: Fix Version/s: 1.10.6 > Update httpcore dependency to 4.4.12 > > > Key: OAK-8598 > URL: https://issues.apache.org/jira/browse/OAK-8598 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8598) Update httpcore dependency to 4.4.12
[ https://issues.apache.org/jira/browse/OAK-8598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923375#comment-16923375 ] Julian Reschke edited comment on OAK-8598 at 10/1/19 8:08 AM: -- trunk: (1.18.0) [r1866453|http://svn.apache.org/r1866453] 1.10: [r1867825|http://svn.apache.org/r1867825] was (Author: reschke): trunk: [r1866453|http://svn.apache.org/r1866453] > Update httpcore dependency to 4.4.12 > > > Key: OAK-8598 > URL: https://issues.apache.org/jira/browse/OAK-8598 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8598) Update httpcore dependency to 4.4.12
[ https://issues.apache.org/jira/browse/OAK-8598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8598: Labels: candidate_oak_1_8 (was: candidate_oak_1_10) > Update httpcore dependency to 4.4.12 > > > Key: OAK-8598 > URL: https://issues.apache.org/jira/browse/OAK-8598 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8659) Remove support for lucene custom scorer
Fabrizio Fortino created OAK-8659: - Summary: Remove support for lucene custom scorer Key: OAK-8659 URL: https://issues.apache.org/jira/browse/OAK-8659 Project: Jackrabbit Oak Issue Type: Task Components: lucene, oak-search Reporter: Fabrizio Fortino The custom scorer exposes the Lucene API directly. This needs to be removed in order to support remote index services (solr, elasticsearch). Since this feature does not seem to be used, we can safely remove it. [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8657) SimpleCredentialsSupport uses Guava API in exported API
[
https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated OAK-8657:
--
Issue Type: Bug (was: Task)
> SimpleCredentialsSupport uses Guava API in exported API
> ---
>
> Key: OAK-8657
> URL: https://issues.apache.org/jira/browse/OAK-8657
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: security-spi
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.24.0
>
>
> {noformat}
> @Override
> @NotNull
> public ImmutableSet getCredentialClasses() {
> return ImmutableSet.of(SimpleCredentials.class);
> }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface).
> However, this would be an incompatible API change; we could do that in sync
> with OAK-7358.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8657) SimpleCredentialsSupport uses Guava API in exported API
[
https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941617#comment-16941617
]
Angela Schreiber commented on OAK-8657:
---
[~reschke], yes, it should be a {{Set}} instead of {{ImmutableSet}}... IMO we
don't necessarily need to tie that to OAK-7358 but maybe it's easier. i
consider the risk of fixing this issue to be really small, specially if the
interface defines it to return {{Set}}. after all i would consider this a bug
in {{SimpleCredentialsSupport}}
> SimpleCredentialsSupport uses Guava API in exported API
> ---
>
> Key: OAK-8657
> URL: https://issues.apache.org/jira/browse/OAK-8657
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: security-spi
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.24.0
>
>
> {noformat}
> @Override
> @NotNull
> public ImmutableSet getCredentialClasses() {
> return ImmutableSet.of(SimpleCredentials.class);
> }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface).
> However, this would be an incompatible API change; we could do that in sync
> with OAK-7358.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8657) SimpleCredentialsSupport uses Guava API in exported API
[
https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated OAK-8657:
--
Summary: SimpleCredentialsSupport uses Guava API in exported API (was:
SimpleCredentialsSupport uses Gauava API in exported API)
> SimpleCredentialsSupport uses Guava API in exported API
> ---
>
> Key: OAK-8657
> URL: https://issues.apache.org/jira/browse/OAK-8657
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: security-spi
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.24.0
>
>
> {noformat}
> @Override
> @NotNull
> public ImmutableSet getCredentialClasses() {
> return ImmutableSet.of(SimpleCredentials.class);
> }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface).
> However, this would be an incompatible API change; we could do that in sync
> with OAK-7358.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8650) PrincipalProviderTest fails with java 14
[
https://issues.apache.org/jira/browse/OAK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941615#comment-16941615
]
Angela Schreiber commented on OAK-8650:
---
[~reschke], i had that before but don't recall exactly what it was will
take a look.
> PrincipalProviderTest fails with java 14
>
>
> Key: OAK-8650
> URL: https://issues.apache.org/jira/browse/OAK-8650
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: security-spi
>Reporter: Julian Reschke
>Priority: Major
>
> (with the fix for OAK-7358 applies, and jacoco turned off)
> {noformat}
> [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed:
> 0.013 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest
> [ERROR]
> testGetItemBasedPrincipal(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0.012 s <<< ERROR!
> org.mockito.exceptions.base.MockitoException:Cannot call abstract real method
> on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testGetItemBasedPrincipal(PrincipalProviderTest.java:36)[ERROR]
>
> testGetMembershipPrincipals(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0 s <<< ERROR!
> org.mockito.exceptions.base.MockitoException:Cannot call abstract real method
> on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testGetMembershipPrincipals(PrincipalProviderTest.java:43)[ERROR]
>
> testNegativeOffset(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testNegativeOffset(PrincipalProviderTest.java:51){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OAK-8650) PrincipalProviderTest fails with java 14
[
https://issues.apache.org/jira/browse/OAK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber reassigned OAK-8650:
-
Assignee: Angela Schreiber
> PrincipalProviderTest fails with java 14
>
>
> Key: OAK-8650
> URL: https://issues.apache.org/jira/browse/OAK-8650
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: security-spi
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
>
> (with the fix for OAK-7358 applies, and jacoco turned off)
> {noformat}
> [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed:
> 0.013 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest
> [ERROR]
> testGetItemBasedPrincipal(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0.012 s <<< ERROR!
> org.mockito.exceptions.base.MockitoException:Cannot call abstract real method
> on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testGetItemBasedPrincipal(PrincipalProviderTest.java:36)[ERROR]
>
> testGetMembershipPrincipals(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0 s <<< ERROR!
> org.mockito.exceptions.base.MockitoException:Cannot call abstract real method
> on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testGetMembershipPrincipals(PrincipalProviderTest.java:43)[ERROR]
>
> testNegativeOffset(org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.jackrabbit.oak.spi.security.principal.PrincipalProviderTest.testNegativeOffset(PrincipalProviderTest.java:51){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941610#comment-16941610 ] Julian Reschke commented on OAK-7182: - We may not have a plan how to remove Guava or update it yet. What's sure is that we need to get rid of Guava objects in our exported APIs (either because otherwise we'll never be able to remove them, or because Guava updates - when applied - might break our APIs). I'll thus file individual tickets for the affected APIs to deprecate those methods (which in most cases will require us to provide an alternative). > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, > OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, > guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OAK-8244) Build failure: ThreadLeakError
[
https://issues.apache.org/jira/browse/OAK-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke reassigned OAK-8244:
---
Assignee: Tommaso Teofili
> Build failure: ThreadLeakError
> --
>
> Key: OAK-8244
> URL: https://issues.apache.org/jira/browse/OAK-8244
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: continuous integration, solr
>Reporter: Hudson
>Assignee: Tommaso Teofili
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2091 has failed.
> First failed run: [Jackrabbit Oak
> #2091|https://builds.apache.org/job/Jackrabbit%20Oak/2091/] [console
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2091/console]
> {noformat}
> [ERROR] Tests run: 13, Failures: 0, Errors: 2, Skipped: 2, Time elapsed:
> 3.402 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.index.solr.configuration.DefaultAnalyzersConfigurationTest
> [ERROR]
> org.apache.jackrabbit.oak.plugins.index.solr.configuration.DefaultAnalyzersConfigurationTest
> Time elapsed: 3.08 s <<< ERROR!
> com.carrotsearch.randomizedtesting.ThreadLeakError:
> 1 thread leaked from SUITE scope at
> org.apache.jackrabbit.oak.plugins.index.solr.configuration.DefaultAnalyzersConfigurationTest:
>
>1) Thread[id=143, name=oak-scheduled-executor-61, state=TIMED_WAITING,
> group=main]
> at sun.misc.Unsafe.park(Native Method)
> at
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.poll(ScheduledThreadPoolExecutor.java:1129)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.poll(ScheduledThreadPoolExecutor.java:809)
> at
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1073)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> at __randomizedtesting.SeedInfo.seed([7416B4EE1CED31C6]:0)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8355) AuthorizableImpl.isEveryone should not throw RepositoryException
[
https://issues.apache.org/jira/browse/OAK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated OAK-8355:
--
Component/s: security
core
> AuthorizableImpl.isEveryone should not throw RepositoryException
>
>
> Key: OAK-8355
> URL: https://issues.apache.org/jira/browse/OAK-8355
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: 1.14.0
>
>
> {{AuthorizableImpl.isEveryone}} should be refactored such that it doesn't
> throw {{RepositoryException}}, which doesn't add any value for this internal
> method.
> [~stillalex], fyi
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OAK-8583) getNodeByIdentifier may fail with RuntimeException
[ https://issues.apache.org/jira/browse/OAK-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917805#comment-16917805 ] Julian Reschke edited comment on OAK-8583 at 10/1/19 6:40 AM: -- trunk: (1.18.0) [r1866041|http://svn.apache.org/r1866041] [r1866039|http://svn.apache.org/r1866039] 1.10: [r1867824|http://svn.apache.org/r1867824] was (Author: reschke): trunk: [r1866041|http://svn.apache.org/r1866041] [r1866039|http://svn.apache.org/r1866039] > getNodeByIdentifier may fail with RuntimeException > -- > > Key: OAK-8583 > URL: https://issues.apache.org/jira/browse/OAK-8583 > Project: Jackrabbit Oak > Issue Type: Task > Components: jcr >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8583) getNodeByIdentifier may fail with RuntimeException
[ https://issues.apache.org/jira/browse/OAK-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8583: Labels: candidate_oak_1_8 (was: ) > getNodeByIdentifier may fail with RuntimeException > -- > > Key: OAK-8583 > URL: https://issues.apache.org/jira/browse/OAK-8583 > Project: Jackrabbit Oak > Issue Type: Task > Components: jcr >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8583) getNodeByIdentifier may fail with RuntimeException
[ https://issues.apache.org/jira/browse/OAK-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8583: Labels: (was: candidate_oak_1_10) > getNodeByIdentifier may fail with RuntimeException > -- > > Key: OAK-8583 > URL: https://issues.apache.org/jira/browse/OAK-8583 > Project: Jackrabbit Oak > Issue Type: Task > Components: jcr >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8583) getNodeByIdentifier may fail with RuntimeException
[ https://issues.apache.org/jira/browse/OAK-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8583: Fix Version/s: 1.10.6 > getNodeByIdentifier may fail with RuntimeException > -- > > Key: OAK-8583 > URL: https://issues.apache.org/jira/browse/OAK-8583 > Project: Jackrabbit Oak > Issue Type: Task > Components: jcr >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.18.0, 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
