[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643722#comment-15643722
]
Alex Parvulescu commented on OAK-5046:
--
patch looks ok. one thing missing is the deprecation warning when someone still
uses the old properties to configure the estimation. they need to have a
warning in the logs about the change.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch, OAK-5046-02.patch, OAK-5046-03.patch,
> OAK-5046-04.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633311#comment-15633311
]
Alex Parvulescu commented on OAK-5046:
--
I think you might have completely ignored my remark about being able to disable
estimation via the OSGi settings?
Let me try to rephrase: given an OSGi instance, try to disable estimation using
only configs in a way that is persistent across restarts.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch, OAK-5046-02.patch, OAK-5046-03.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633012#comment-15633012
]
Alex Parvulescu commented on OAK-5046:
--
right, let's look at the entire picture now. if I'm running an instance, how do
I disable this via OSGi settings, so that it survives a restart? To give you a
hint of what I'm asking, it used to be possible by setting the
{{gainThreshold}} value to {{0}}. Related to this you've removed it from the
{{SegmentCompactionIT}} test without noticing the impact (so probably also
replace this with {{disableEstimation()}} in your patch).
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch, OAK-5046-02.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632966#comment-15632966
]
Andrei Dulceanu commented on OAK-5046:
--
bq Also, How does the current code deal with disabling the estimation phase?
Let's say I want to skip estimation, how do I do that?
One way to do it would
be:{{SegmentGCOptions.defaultGCOptions().disableEstimation()}}. If you are OK
with it and everything else I will create a new patch including the two other
suggestions from above.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch, OAK-5046-02.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632945#comment-15632945
]
Alex Parvulescu commented on OAK-5046:
--
bq. I have one question though: does it make sense to have access to
SegmentGCOptions.isDisabled() from SegmentRevisionGCMBean? My assumption was
that it doesn't, since this was also the way to handle
SegmentGCOptions.isOffline().
I think it does, yes. let's add this to the jmx info
One small thing is {{SegmentGCOptions#toString}} is missing the
gcSizeDeltaEstimation information. it was missing before the patch, now is a
good time to add it.
Also, How does the current code deal with disabling the estimation phase? Let's
say I want to skip estimation, how do I do that?
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch, OAK-5046-02.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632859#comment-15632859
]
Andrei Dulceanu commented on OAK-5046:
--
Created OAK-5058 to track this.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch, OAK-5046-02.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632404#comment-15632404
]
Alex Parvulescu commented on OAK-5046:
--
bq. we want to get rid of everything involving the old compaction gain
threshold, but properties like GAIN_THRESHOLD_DEFAULT are still to be kept
I'm not sure who 'we' is, but I'm in favor of keeping the old estimation bits
around (not enabled by default), with the option of enabling it via a system
property.
bq. although we want to switch to the new implementation, a property from the
old one is used to make the decision of running the estimation, or not
(gainThreshold).
whatever you think is best here. I'm not sure what the plan would be, I would
not add a new property, just hide the decision mechanics behind a dedicated
method, {{disableEstimation}} as you called it.
bq. I don't know all the details behind, but having a threshold expressed as a
percentage (the old compaction gain), seems more natural than having one based
on a value in gigabytes.
no preference, but this does seem outside of this issue's scope. you could
provide this as a patch on a dedicated issue.
bq. To sum up my proposal is to go all the way and remove everything related to
the old compaction gain, clarifying also the points above.
if there is no way of keeping both estimation options, and enable just one
based on config settings, then yeah, remove the old one completely.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632193#comment-15632193
]
Andrei Dulceanu commented on OAK-5046:
--
That's exactly what I was thinking, but my wording might have been unclear.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632189#comment-15632189
]
Michael Dürig commented on OAK-5046:
I think it should be the other way around as we should avoid running compaction
too often on small repositories. E.g. run if there is > 50% increase or more
than 10GB.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632169#comment-15632169
]
Andrei Dulceanu commented on OAK-5046:
--
I know it sounds complicated, but would it be an option to have a composed
threshold like "run compaction on a *20%* increase, but at least *20 GB*"? If
both values are met, it runs, otherwise it won't.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632158#comment-15632158
]
Michael Dürig commented on OAK-5046:
My reasoning for using an absolute threshold instead of a relative one for the
estimator was that e.g. on a 1GB repository a 50% increase would lead to 1.5GB.
Hardy a reason to run gc. OTOH a 50% increase on a 50GB repository leads to
75GB, which should cause a gc run.
But as we seem to have a hard time with coming up with a good default value, we
should maybe try to tackle this from the other end: say we make it a relative
value. Can we come up with a good default value then? What would it be and why?
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632142#comment-15632142
]
Michael Dürig commented on OAK-5046:
+1 to the idea to decouple whether estimation should run at all from the actual
strategy and its parameters.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632132#comment-15632132
]
Andrei Dulceanu commented on OAK-5046:
--
After carefully reading the code and all its implications, I think that
deriving a simple solution is hard to achieve. Let me explain my idea:
* we want to get rid of everything involving the old compaction gain threshold,
but properties like {{GAIN_THRESHOLD_DEFAULT}} are still to be kept
* although we want to switch to the new implementation, a property from the old
one is used to make the decision of running the estimation, or not
({{gainThreshold}}). Wouldn't it be clearer to add a separate member in
{{SegmentGCOptions}}, a boolean like {{disableEstimation}} to make this
decision?
* I don't know all the details behind, but having a threshold expressed as a
percentage (the old compaction gain), seems more natural than having one based
on a value in gigabytes. I think it's easier to say "run compaction when
there's a 20% percent increase in repository size" than putting it "run
compaction when there's an increase of 10GB in repository size". The latter
might be a very small percentage for a huge repo. That's why I think it's hard
to come up with some default value here.
To sum up my proposal is to go all the way and remove everything related to the
old compaction gain, clarifying also the points above.
[~alexparvulescu], [~mduerig], WDYT?
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629467#comment-15629467
]
Alex Parvulescu commented on OAK-5046:
--
The provided patch has 2 problems:
* first setting the {{gainThreshold}} to {{0}} will disable estimation
completely. not good.
* second it doesn't switch the default estimation impl over to the new
estimation approach.
have you tested what estimation method (if any) is used with this patch?
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628495#comment-15628495
]
Michael Dürig commented on OAK-5046:
Fine with me. Although I'd prefer to remove the old code unless we see still
value in keeping it. But let's focus on the external facing parts first.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-5046) Remove the old estimation OSGi setting (compaction.gainThreshold)
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628487#comment-15628487
]
Andrei Dulceanu commented on OAK-5046:
--
Per [~alexparvulescu]'s suggestion, currently the focus is only to tidy up the
OSGi configs, without removing any code. [~mduerig], WDYT?
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.5.12
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
