[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198339#comment-16198339
]
Tommaso Teofili commented on OAK-6790:
--
ok, thanks [~catholicon] and [~chetanm].
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8, 1.7.10
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198337#comment-16198337
]
Tommaso Teofili commented on OAK-6790:
--
I think [~catholicon] proposal is more consistent with the overall migration
effort, however [~chetanm] is right that this would be a breaking change
anyway, regardless of which bundles are deployed or not, because consumer code
would _import org.apache.jackrabbit.oak.query.facet.FacetResult_ which no
bundle is exporting at the moment.
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8, 1.7.10
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198330#comment-16198330
]
Vikas Saurabh commented on OAK-6790:
Ok, so talked to [~chetanm] and he pointed me to OAK-6607 and OAK-6676. So,
moving the class to {{o.a.j.o.query.facet}} in
[r1811647|https://svn.apache.org/r1811647].
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8, 1.7.10
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198260#comment-16198260
]
Chetan Mehrotra commented on OAK-6790:
--
bq. Otoh, not picking up oak-query-spi on such setup would still fail to
resolve the bundle.
That would. But here case would be that Oak user updated to newer version of
Oak based application which adds all the new bundles. However his bundle would
still not resolve even with oak-uery-spi being present
bq. All that said, I think we have moved around quite a few packages in the
refactoring exercise. So, if we're ok with a bit of backward incompatibility
hit, I think the current place (bundle and package) is more fitting place.
Most of such moves involved packages which were to be consumed by other Oak
bundles hence changing them does not impact backward compatability. However
this package was meant to be consumer by non Oak bundles and hence would pose
problem
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8, 1.7.10
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198248#comment-16198248
]
Vikas Saurabh commented on OAK-6790:
Umm. I've always felt that bnd is what defines out backward compatibility. I
think what you're saying is that with provided dependency on oak-core and
deploying both oak-core and oak-query-spi in consuming setup won't feel bad
about backward compatibility.
Otoh, not picking up oak-query-spi on such setup would still fail to resolve
the bundle.
All that said, I think we have moved around quite a few packages in the
refactoring exercise. So, if we're ok with a bit of backward incompatibility
hit, I think the current place (bundle and package) is more fitting place.
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8, 1.7.10
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198195#comment-16198195
]
Chetan Mehrotra commented on OAK-6790:
--
bq. I'm guessing consumer of this class would have to mark dependency on
oak-query-spi anyway
Not necessarily as his code would still compile fine with older maven
dependency however his existing working app would not work post upgrade as his
bundle using the older FacetResult would not resolve
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8, 1.7.10
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198191#comment-16198191
]
Vikas Saurabh commented on OAK-6790:
[~chetanm], I'm guessing consumer of this class would have to mark dependency
on {{oak-query-spi}} anyway. So, unless we move it back to {{oak-core}}, I am
not sure if not changing package would be helpful from backward compatibility
pov.
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8, 1.7.10
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198153#comment-16198153
]
Chetan Mehrotra commented on OAK-6790:
--
[~catholicon] If the package is not used in multiple bundles
"org.apache.jackrabbit.oak.query.facet" then lets keep the same package name to
avoid any backward compatibility issue as this class was sort of api
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8, 1.7.10
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196865#comment-16196865
]
Tommaso Teofili commented on OAK-6790:
--
[~catholicon] sure, I guess this is not the only export we changed in that area.
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196838#comment-16196838
]
Vikas Saurabh commented on OAK-6790:
[~teofili], yes, I realized that the package export is breaking backward in
comatibility - I was assuming that we've done this for a lot other packages and
felt that it might be ok here too. I feel if we're ok to move it to a separate
bundle (to me query-spi feels better home), then we might be ok with package
update too.
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196770#comment-16196770
]
Tommaso Teofili commented on OAK-6790:
--
+1 to expose it, however I think this is a not backward compatible change as
{{FacetResult}} used to be exposed from _org.apache.jackrabbit.oak.query.facet_
package.
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6790) FacetResult class isn't exposed anymore
[
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196475#comment-16196475
]
Vikas Saurabh commented on OAK-6790:
[~anchela], could you please review this issue? And, if it feels ok to move
this class to {{oak-query-spi}} under
{{org.apache.jackrabbit.oak.*spi*.query.facet}} package?
> FacetResult class isn't exposed anymore
> ---
>
> Key: OAK-6790
> URL: https://issues.apache.org/jira/browse/OAK-6790
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
>Affects Versions: 1.7.2
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
> Fix For: 1.8
>
>
> OAK-3847 exposed {{FacetResult}} (rather
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume
> extracted facet data. That exported package got removed during OAK-6304 (as
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie
> if we can simply re-enable the removed export AND that its current place in
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without
> removing this export (disclaimer: I still feel that it belongs in
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]:
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
