Re: [PATCH v3 00/13] Add support for BlueZ 5 Profile1 API to dundee
Hi Paulo, [sorry for the late response, was on vacation] On 03/25/2013 03:43 PM, Paulo Borges wrote: Hi Daniel, On Sun, Mar 24, 2013 at 9:31 AM, Daniel Wagner mailto:w...@monom.org>> wrote: Hi Paulo, I have pushed all patches except patch #3. "dun_gw: Add BlueZ 5 version" from Frédéric just added recently the definition for DUN_GW_UUID. Obviously, I needed to update your patches to use DUN_GW_UUID instead of DUN_UUID. The bluez4.c file also uses DUN_GW_UUID as identifier. Thanks a lot, daniel Actually, DUN profile is "asymmetric": it doesn't have an UUID for each role, they share the same UUID [1]. The only way to distinguish the current role is to specify it when registering the profile with bt_register_profile_with_role function. Specifying the role when registering a DUN profile is important because only GW should expose a SDP record. [1] https://www.bluetooth.org/Technical/AssignedNumbers/service_discovery.htm I see. The thing I wanted to avoid is to have twice a define for the same value. In the end the way how the define is used (as you have described above) is essential. cheers, daniel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH v3 00/13] Add support for BlueZ 5 Profile1 API to dundee
Hi Daniel, On Sun, Mar 24, 2013 at 9:31 AM, Daniel Wagner wrote: > Hi Paulo, > > I have pushed all patches except patch #3. "dun_gw: Add BlueZ 5 version" > from Frédéric just added recently the definition for DUN_GW_UUID. > Obviously, I needed to update your patches to use DUN_GW_UUID instead of > DUN_UUID. The bluez4.c file also uses DUN_GW_UUID as identifier. > > Thanks a lot, > daniel > Actually, DUN profile is "asymmetric": it doesn't have an UUID for each role, they share the same UUID [1]. The only way to distinguish the current role is to specify it when registering the profile with bt_register_profile_with_role function. Specifying the role when registering a DUN profile is important because only GW should expose a SDP record. [1] https://www.bluetooth.org/Technical/AssignedNumbers/service_discovery.htm Cheers, Paulo Borges ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH v3 00/13] Add support for BlueZ 5 Profile1 API to dundee
Hi Paulo, I have pushed all patches except patch #3. "dun_gw: Add BlueZ 5 version" from Frédéric just added recently the definition for DUN_GW_UUID. Obviously, I needed to update your patches to use DUN_GW_UUID instead of DUN_UUID. The bluez4.c file also uses DUN_GW_UUID as identifier. Thanks a lot, daniel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
[PATCH v3 00/13] Add support for BlueZ 5 Profile1 API to dundee
This series implements support for BlueZ 5 to dundee. It uses the org.bluez.Profile1 API to register an external profile. While the interface between BlueZ and dundee has changed, the interfaces "org.ofono.dundee.Device" and "org.ofono.dundee.Manager" remains unchanged. Paulo Borges (13): dundee: Rename dundee BlueZ 4 support dundee: Start BlueZ 5 support bluez5: Add DUN_UUID dundee: Initial GDBusClient for BlueZ 5 dundee: Add mechanism to store bluetooth devices dundee: Add tracking of bluetooth devices dundee: Listen to devices property changes dundee: Add dundee device driver skeleton dundee: Register/unregister dundee device dundee: Add BlueZ Profile handler dundee: Add support for driver connect dundee: Add dundee disconnect function dundee: Handle Profile connect and disconnect Makefile.am| 15 +- dundee/bluetooth.c | 297 dundee/bluez4.c| 297 dundee/bluez5.c| 422 dundee/device.c| 14 +- dundee/dundee.h|5 + plugins/bluez5.h |1 + 7 files changed, 746 insertions(+), 305 deletions(-) delete mode 100644 dundee/bluetooth.c create mode 100644 dundee/bluez4.c create mode 100644 dundee/bluez5.c -- 1.7.9.5 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
