Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Upgrade Mac SDL2 framework (Issue #1255)

2023-09-04 Thread Ralph Versteegen via Ohrrpgce
10.9, but yes. It seems reasonable.

The requirement change to macOS 10.11+ is discussed here: 
https://github.com/libsdl-org/SDL/issues/7636
Supposedly before 2.24.0, SDL supported mac OS 10.7+, not 10.6. (IIRC macOS 
10.6 has an incomplete set of 64-bit APIs so it's common to say 64-bit apps 
require 10.7+ but many will run on 10.6 too and I expected the OHR would.) And 
SDL still can be compiled to support 10.7+ provided you do it yourself; the 
change was made simply to support XCode 14.3 out of the box. If we ever feel 
like bothering we can do so (and use lastest SDL 2.x).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1255#issuecomment-1705917878
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Upgrade Mac SDL2 framework (Issue #1255)

2023-09-04 Thread James Paige via Ohrrpgce
So if I understand correctly, we should use version 2.26.4 and also update the 
requirements page to say that 10.10 is the minimum supported, yes?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1255#issuecomment-1705806080
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Upgrade Mac SDL2 framework (Issue #1255)

2023-09-04 Thread Ralph Versteegen via Ohrrpgce
I see that you upgraded (`get_sdl_frameworks.sh`) from SDL 2.0.14 to 2.24.0 a 
year ago, which was presumably when we dropped support for OS 10.6-10.9 without 
realising it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1255#issuecomment-1705802175
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Upgrade Mac SDL2 framework (Issue #1255)

2023-09-04 Thread Ralph Versteegen via Ohrrpgce
Looking through the SDL changelog I notice:

2.26.5 (Apr 6 2023)
> The minimum deployment target on macOS is now 10.11, due to changes in the 
> latest Xcode update

2.26.1 (Dec 2, 2022)
> Fixed building with older Xcode and macOS SDK

2.26.0 (Nov 22, 2022)
> Implemented vsync synchronization on macOS 12   [seems important; did Apple 
> break the previous vsync support?]

2.24.0 (Aug 20, 2022):
> Bumped minimum OS deployment version to macOS 10.9

And there's not really anything interesting in 2.28.x (although unfortunately 
no list of bugfixes is provided).

This makes me wonder whether we should use SDL 2.26.4 instead to support older 
OS versions. According to our System Requirements page (which I'm not certain 
is up to date), "Mac OS 10.6-10.14 can run both the 32-bit or 64-bit apps". So 
it looks like this drops support for Mac OS 10.6-10.10 in the default build. 
(10.10 was released in 2014.) Although the 32-bit app supports those, noone is 
going to package their games with that. We need to at least update the 
requirements.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1255#issuecomment-1705799909
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] gfx_sdl2/Linux: fullscreening randomly broken (Issue #1242)

2023-09-04 Thread James Paige via Ohrrpgce
Aha! Yes, I can reproduce it with ./game.sh

It does indeed happen roughly 50% of the time

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1242#issuecomment-1705779371
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Upgrade Mac SDL2 framework (Issue #1255)

2023-09-04 Thread James Paige via Ohrrpgce
The latest Mac Frameworks seem to be:
SLD2 = 2.28.3
SLD2_mixer = 2.6.3

I have updated them both.
I also rewrote and renamed the script that downloads them, now it also installs 
them

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1255#issuecomment-1705777976
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Upgrade Mac SDL2 framework (Issue #1255)

2023-09-04 Thread James Paige via Ohrrpgce
Closed #1255 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1255#event-10277585078
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


[Ohrrpgce] SVN: james/13318 install_sdl_frameworks.sh - fix a typo, and use sudo for /Library/Framew

2023-09-04 Thread subversion--- via Ohrrpgce
james
2023-09-04 16:56:35 -0700 (Mon, 04 Sep 2023)
77
install_sdl_frameworks.sh - fix a typo, and use sudo for /Library/Frameworks/
---
U   wip/mac/install_sdl_frameworks.sh

___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


[Ohrrpgce] SVN: james/13317 Rename get_sdl_frameworks.sh to install_sdl_frameworks.sh

2023-09-04 Thread subversion--- via Ohrrpgce
james
2023-09-04 16:49:51 -0700 (Mon, 04 Sep 2023)
57
Rename get_sdl_frameworks.sh to install_sdl_frameworks.sh
---
D   wip/mac/get_sdl_frameworks.sh
A   wip/mac/install_sdl_frameworks.sh

___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


[Ohrrpgce] SVN: james/13316 mac/get_sdl_frameworks.sh now also installs the frameworks that it downl

2023-09-04 Thread subversion--- via Ohrrpgce
james
2023-09-04 16:49:48 -0700 (Mon, 04 Sep 2023)
76
mac/get_sdl_frameworks.sh now also installs the frameworks that it downloads
---
U   wip/mac/get_sdl_frameworks.sh

___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] gfx_sdl2/Linux: fullscreening randomly broken (Issue #1242)

2023-09-04 Thread Ralph Versteegen via Ohrrpgce
Interesting, it seems to be specific to certain SDL2 versions, or maybe builds. 
Can you reproduce it when running game.sh? When I run game.sh (which uses SDL 
2.0.22) it happens about 80-90% of the time. When I use my distro's SDL 2.0.26 
build it never happens. Probably an SDL2 bug that was fixed, although it could 
be a problem with Valve's build.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1242#issuecomment-1705770368
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


[Ohrrpgce] SVN: james/13315 Bump the versions of SDL2 and SDL2_mixer downloaded by mac/get_sdl_frame

2023-09-04 Thread subversion--- via Ohrrpgce
james
2023-09-04 15:02:07 -0700 (Mon, 04 Sep 2023)
80
Bump the versions of SDL2 and SDL2_mixer downloaded by mac/get_sdl_frameworks.sh
---
U   wip/mac/get_sdl_frameworks.sh

___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] in menu editor, clicking/hovering is wrongly offset (Issue #1257)

2023-09-04 Thread James Paige via Ohrrpgce
This was fixed in r13313 ( 9c268a9ee5e )

TMC, I think the "F5 reload debug menu's MenuDef is now cut off (at 320px 
wide)" thing was likely something different, file a separate bug if it is still 
a problem

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1257#issuecomment-1705711047
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] in menu editor, clicking/hovering is wrongly offset (Issue #1257)

2023-09-04 Thread James Paige via Ohrrpgce
Closed #1257 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1257#event-10277137493
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


[Ohrrpgce] SVN: james/13314 In the menu editor, clicking outside of the detail menu takes you back t

2023-09-04 Thread subversion--- via Ohrrpgce
james
2023-09-04 14:22:53 -0700 (Mon, 04 Sep 2023)
193
In the menu editor, clicking outside of the detail menu takes you back to the 
menu you are editing, and clicking outside the menu you are editing takes you 
back to the toplevel menu editor menu
---
U   wip/common.bi
U   wip/common.rbas
U   wip/menuedit.bas

___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


[Ohrrpgce] SVN: james/13313 In the menu editor, fix the rect.topleft of the menu state for the menu

2023-09-04 Thread subversion--- via Ohrrpgce
james
2023-09-04 14:22:49 -0700 (Mon, 04 Sep 2023)
151
In the menu editor, fix the rect.topleft of the menu state for the menu we are 
editing to match the preview window in the bottom right

Fixes bug #1257
---
U   wip/menuedit.bas

___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] in menu editor, clicking/hovering is wrongly offset (Issue #1257)

2023-09-04 Thread James Paige via Ohrrpgce
This bug was introduced at r12750 ( e5f2b4d8b240 ) on 2022-02-05
"Menu editor now shows how the menu is positioned at the in-game resolution"

This was the first revision that moved the menu preview to the bottom-right of 
the menu editor, so the mouse hover has always been offset for it.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1257#issuecomment-1705654037
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] gfx_sdl2/Linux: fullscreening randomly broken (Issue #1242)

2023-09-04 Thread James Paige via Ohrrpgce
I am not able to reproduce this bug on Debian Linux xfce4 using the current 
nightlies (or any other version, I have never personally seen this bug)

I tested with all the methods of switching into fullscreen, alt+enter, command 
line argument, and last-stat-defaulting

My version of SDL2 is 2.0.14+dfsg2-3+deb11u1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1242#issuecomment-1705623841
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Target cursors and damage digits appear behind battle menus (Issue #1262)

2023-09-04 Thread James Paige via Ohrrpgce
Closed #1262 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1262#event-10276513279
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Target cursors and damage digits appear behind battle menus (Issue #1262)

2023-09-04 Thread James Paige via Ohrrpgce
I have fixed this bug in r13312 ( d8537a82a7 )

ClassSlice is really nice! This is my first time looking at that code.

The MenuDefSlice is currently very unambitious, it just draws the menu in the 
correct order in the slice tree
I imagine later we could add features, like positioning the menu based on the 
slice position, or vice versa, snapping the slice position to the MenuDef 
position

At any rate, i am closing this bug now. One release blocker down!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1262#issuecomment-1705619815
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


[Ohrrpgce] SVN: james/13312 Add a very simple MenuDefSlice (subclass of ClassSlice) which allows dra

2023-09-04 Thread subversion--- via Ohrrpgce
james
2023-09-04 11:47:51 -0700 (Mon, 04 Sep 2023)
201
Add a very simple MenuDefSlice (subclass of ClassSlice) which allows drawing a 
menu at the correct depth in a slice tree.

Resolves bug #1262 Target cursors and damage digits appear behind battle menus
---
U   wip/SConscript
U   wip/bmod.rbas
U   wip/sliceedit.bas
U   wip/slices.bas
U   wip/slices.bi
U   wip/specialslices.bas
U   wip/specialslices.bi
U   wip/whatsnew.txt

___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Distributing a game for Mac from Windows is broken (Issue #1239)

2023-09-04 Thread James Paige via Ohrrpgce
I am marking this one closed. I am satisfied with the testing that I did on VMs

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1239#issuecomment-1705434577
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Distributing a game for Mac from Windows is broken (Issue #1239)

2023-09-04 Thread James Paige via Ohrrpgce
Closed #1239 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1239#event-10275234834
You are receiving this because you are subscribed to this thread.

Message ID: ___
Ohrrpgce mailing list
ohrrpgce@lists.motherhamster.org
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org