Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Aleix Pol Gonzalez]

> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" 
> > anymore.
> 
> Aleix Pol Gonzalez wrote:
> https://git.reviewboard.kde.org/r/127024/
> 
> :)
> 
> Albert Astals Cid wrote:
> that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog 
> i guess? Is it really supposed to be that ugly?
> 
> Aleix Pol Gonzalez wrote:
> You don't have it set up properly, you should be getting the normal 
> KFileWidget-based dialog.
> 
> Albert Astals Cid wrote:
> I know i don't have it setup to give me the "Plasma experience", it's 
> giving me the "Okular experience outside plasma", and it is a serious 
> regression to what we have by using KFileDialog, don't you think?

As I see it, there's no non-_Plasma Experience_. In Gnome, it should use the 
GTK thingie, in Plasma it should use the Plasma dialog, and on Windows or 
Android, whatever they use there: so it's not a regression but a feature.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
---


On Feb. 10, 2016, 3:23 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 10, 2016, 3:23 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Albert Astals Cid]

> On Feb. 9, 2016, 11:23 p.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" 
> > anymore.
> 
> Aleix Pol Gonzalez wrote:
> https://git.reviewboard.kde.org/r/127024/
> 
> :)
> 
> Albert Astals Cid wrote:
> that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog 
> i guess? Is it really supposed to be that ugly?
> 
> Aleix Pol Gonzalez wrote:
> You don't have it set up properly, you should be getting the normal 
> KFileWidget-based dialog.

I know i don't have it setup to give me the "Plasma experience", it's giving me 
the "Okular experience outside plasma", and it is a serious regression to what 
we have by using KFileDialog, don't you think?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
---


On Feb. 10, 2016, 2:23 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 10, 2016, 2:23 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127013: Properly show marker for current section in TOC

[Albert Astals Cid]

> On Feb. 11, 2016, 10:27 p.m., Miklós Máté wrote:
> > ui/toc.cpp, line 44
> > 
> >
> > The model has to know about the treeview, see line 209. This also makes 
> > sure that the model is deleted when the view is deleted, just like when 
> > this is used as a KPart (see finishReload).

> This also makes sure that the model is deleted when the view is deleted

But that already happens becase the view is the parent of the model, no?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/#review92277
---


On Feb. 8, 2016, 5:49 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127013/
> ---
> 
> (Updated Feb. 8, 2016, 5:49 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> fixes bug #342076
> 
> 
> Diffs
> -
> 
>   ui/toc.cpp 09625af 
>   ui/tocmodel.cpp ce93366 
> 
> Diff: https://git.reviewboard.kde.org/r/127013/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 332372] Edit and save (PDF) Document Information

[Sylvain via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=332372

Sylvain  changed:

   What|Removed |Added

 CC||ago.sylv...@gmail.com

--- Comment #1 from Sylvain  ---
Just wanted to add my 2 cents on this.
I have been looking in okular where I can edit the metadata before
understanding that it is not possible at the moment. Okular is such a great
document reader that I was convinced that editing the metadata was possible
The metadata are editable using exiftool, through the command line, it would be
nice if this was possible through okular: the field in the property dialog
should be editable. Now I understand that okular is a "viewer" but because
there is no simple way to edit pdf metadata through the gui under kde, at least
to my knowledge", it would be nice if okular could do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125020: okular: Add zip/x-rar mimetype to .desktop files

[Albert Astals Cid]

> On Sept. 16, 2015, 8:59 p.m., Albert Astals Cid wrote:
> > Actually, if you just leave the libokularGenerator_comicbook.desktop change 
> > this should be ok, tells okular this plugin may know how to open rar files, 
> > so if you use the file dialog or the command line it should work, but it 
> > doesn't tell the rest of the world so dolphin et al won't suggest okular to 
> > open random .rar files.  I think this should be a good enough compromise, 
> > can you check what i am saying is actually true?
> 
> Boris Egorov wrote:
> I'll check it asap.
> 
> Boris Egorov wrote:
> Completely forgot about this bug.
> So, each of the files affect different behavior.
> 
> libokularGenerator_comicbook.desktop allows to open files from 
> command line
> okularComicbook.desktop allows to select them in Okular's file dialog
> okularApplication_comicbook.desktop shows Okular in Dolphin context 
> menu for .zip and .rar files
> 
> So, I guess we can leave changes in the first two files, but rejects the 
> last one. What do you think?

Those files don't do what you say they do, as i said on my original one 
libokularGenerator_comicbook.desktop should be more than enough, have you tried 
just leaving the change there?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125020/#review85517
---


On Sept. 1, 2015, 4:02 p.m., Boris Egorov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125020/
> ---
> 
> (Updated Sept. 1, 2015, 4:02 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 343645
> http://bugs.kde.org/show_bug.cgi?id=343645
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Adds ability to open rar/zip archives with images in okular
> 
> 
> Diffs
> -
> 
>   generators/comicbook/libokularGenerator_comicbook.desktop 5a91a5f 
>   generators/comicbook/okularApplication_comicbook.desktop dee494b 
>   generators/comicbook/okularComicbook.desktop 1dded78 
> 
> Diff: https://git.reviewboard.kde.org/r/125020/diff/
> 
> 
> Testing
> ---
> 
> Build; open some archives in okular.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127036: Fix for CUPS printing in Okular 1.0.0

[Krzysztof Pyrkosz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127036/
---

(Updated Feb. 16, 2016, 1:27 a.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Changes
---

Submitted with commit 14c936ea1b0a9094b476da45160ebb23614f3a39 by Albert Astals 
Cid on behalf of Krzysztof Pyrkosz to branch frameworks.


Repository: okular


Description
---

Okular is checking for Q_WS_X11 definition (which is not available since Qt 5) 
to detect CUPS, so detection always fails making CUPS parameters ignored. I 
have changed it to:
#if defined(Q_OS_UNIX) && !defined(Q_OS_OSX)


Diffs
-

  core/fileprinter.cpp 2c8b199 

Diff: https://git.reviewboard.kde.org/r/127036/diff/


Testing
---


Thanks,

Krzysztof Pyrkosz

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127036: Fix for CUPS printing in Okular 1.0.0

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127036/#review92421
---


Ship it!




Ship It!

- Albert Astals Cid


On Feb. 11, 2016, 1:04 a.m., Krzysztof Pyrkosz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127036/
> ---
> 
> (Updated Feb. 11, 2016, 1:04 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Okular is checking for Q_WS_X11 definition (which is not available since Qt 
> 5) to detect CUPS, so detection always fails making CUPS parameters ignored. 
> I have changed it to:
> #if defined(Q_OS_UNIX) && !defined(Q_OS_OSX)
> 
> 
> Diffs
> -
> 
>   core/fileprinter.cpp 2c8b199 
> 
> Diff: https://git.reviewboard.kde.org/r/127036/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Krzysztof Pyrkosz
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359223] [framework] okular cannot open files with spaces in path or name (both from terminal and from dolphin)

[Albert Astals Cid via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359223

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #5 from Albert Astals Cid  ---
(In reply to Yi Yang from comment #3)
> Same for me. This is actually one of the more annoying bugs for me, since
> most of my files reside on paths with spaces in it, making Okular nearly
> unusable. Worse, it seems to try to expand symlinks so I can't even use
> symlinks to circumvent this bug.

You should not be using the frameworks branch if you need to use Okular
reliably, the frameworks branch is not supported, so if you're using it, is
because you want, we appreciate you report bugs and people that created those
bugs in the frameworks branch may eventually fix them, but don't complain it
doesn't work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

[Albert Astals Cid]

> On Feb. 11, 2016, 9:41 p.m., Armin K. wrote:
> > I didn't notice this review request and did porting on my own. My patch 
> > takes into account some things your doesn't at the moment. Can you port the 
> > version checks and possibly other changes from my RR to your patch, so I 
> > can close my review request?
> > 
> > https://git.reviewboard.kde.org/r/127049/
> 
> Michael Palimaka wrote:
> Your patch looks more complete, so I'd suggest using that and closing 
> this instead.

Well, it's your MR, you can close it as you wish.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126842/#review92275
---


On Jan. 22, 2016, 12:31 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126842/
> ---
> 
> (Updated Jan. 22, 2016, 12:31 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Some small changes are required to ensure build passes with ECM's new 
> FindPoppler.cmake.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 492de006c58904f0da94f4cfb9e2ca79ab839c45 
>   cmake/modules/FindPoppler.cmake 80a78627438703a9db4d7cd97649098c41b1b2ce 
>   generators/CMakeLists.txt ce1d9bfeeb401466c47648d1d828fbd2ff4b18f6 
>   generators/poppler/CMakeLists.txt 740b6fd8d6311bee80845a034bba148d443afbd4 
> 
> Diff: https://git.reviewboard.kde.org/r/126842/diff/
> 
> 
> Testing
> ---
> 
> Builds, PDFs still open.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel