[Okular-devel] [okular] [Bug 361490] Opening of files on password protected SMB share fails

[richardlm via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361490

--- Comment #2 from richardlm  ---
(In reply to Albert Astals Cid from comment #1)
> Let me make sure i understand this correct:
>  * if you use okular to open the file, it works
If I use the File - Open dialog in okular it works.

>  * if you dolphin to open the file, it fails
If I click the file in dolphin, okular opens, but with error message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 361487] Stream Files instead of creating local copy

[richardlm via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361487

--- Comment #2 from richardlm  ---
(In reply to Albert Astals Cid from comment #1)
> > It is not possible to see changes on the pdf file by reloading (F5)
> You mean that if you open a file on smb and press F5 it doesn't reload the
> file?
I just checked and indeed Okular does loads a new (changed) copy of that file.

> I guess that's because dolphin does that not because okular does it right?
I do not understand this sentence.

> i.e. if you call okular from the command line it will work, no?
It is the same behavior (okular creates local copy of pdf file).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127366: Resize annotations

[Jonathan Schultz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127366/#review94355
---



Sorry I've been meaning to test this a bit more and only got to it today.

I have a couple of minor comments:

1. The corner boxes do not seem to work - even though the mouse icon changes to 
indicate resizing, left-clicking causes the annotation to become unselected. 
That looks like such an obvious thing that perhaps it is a bug that has crept 
in, or is strangely dependent on my particular build?

2. The mouse icon changes could be made much better. Could the cursor not first 
(ie before an annotation has been selected) change to a pointer when over a 
point that left-clicking would select an annotation? When an annotation is 
selected, the "move annotation" (ie the vertical cross) is currently maintained 
even when the mouse cursor is no longer over the annotation itself, ie that 
left-clicking will not produce movement of the annotation.

More generally in terms of UI I really like the "select then operate on" model, 
and would suggest that, once an annotation has been selected, a range of 
functions (most obviously delete/edit/properties of annotation but also 
cut/copy and others) then become accessible through a context-dependent 
right-click menu?

> Sounds interesting... who would eventually care about merging?

I think you are way ahead of me, and I am looking forward to going over your 
patch to learn how to do a few things. That said, I have contributed one tiny 
review request: https://git.reviewboard.kde.org/r/127496/ but haven't had any 
response yet.

- Jonathan Schultz


On April 5, 2016, 8:02 a.m., Tobias Deiminger wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127366/
> ---
> 
> (Updated April 5, 2016, 8:02 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This diff adds an annotation resize feature to okular (see Bug 18).
> 
> Usage:
> If you left-click at an annotation, it gets selected and 8 resize handles 
> appear on the corners/edges of the selection rectangle. When cursor is moved 
> over one of the handles, the cursor shape indicates resize mode (everywhere 
> else on the annotation means "move", just as it was before resize feature was 
> added). Press ESC, or click an area outside the annotation to cancel 
> selection. Feature is only applicable for annotation types AText, AStamp and 
> AGeom.
> 
> Notable changes:
> It works by eventually changing AnnotationPrivate::m_boundary and notifying 
> generator (i.e. poppler) about that change, similar to the existing move 
> functionality.
> -Separated annotation state handling out of PageView into a new class 
> MouseAnnotation (ui/pageviewmouseannotation.cpp)
> -Added method Document::adjustPageAnnotation, backed by a QUndoCommand class 
> Okular::AdjustAnnotationCommand
> -Added method Annotation::adjust
> -Draw resize handles and selection boundary in MouseAnnotation::routePaint
> -Draw only a bounding rectangle during resize, if annotation is rendered 
> externally
> 
> TODO:
> -Add test cases once requirements are fixed.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 97e8db6e4a704fd34331fad7b7628ca2248b62d8 
>   core/annotations.h 4f107440dc824fd9049a30082befd18642e63895 
>   core/annotations.cpp e02994688414bdf485b308d6ef122ee2eff3fbaf 
>   core/annotations_p.h 07b124a4fae40b7a983aa382ae824125e6d25746 
>   core/document.h 63f58741bd6680a673945a7b7c05a10130968beb 
>   core/document.cpp 6953b1fb0dc29a375be7ff331a2a2bccce975366 
>   core/document_p.h fda23275033645ea67f5ad9d27341fc4635ede34 
>   core/documentcommands.cpp 95aded51d73a3d3b98ff26284c9c46fc5c9cf0ca 
>   core/documentcommands_p.h 17394f2a25b187cf4aff66b3a7f891b81be5acdd 
>   generators/poppler/annots.cpp 8cde64833831ec833b3be552608cff99d38f8e63 
>   tests/translateannotationtest.cpp 184b9474e6072a991a5ee5f1116bf7a9ef10cadc 
>   ui/pagepainter.h 68b241658162d9bd6eb187efc594ef17ea99d899 
>   ui/pagepainter.cpp 3bcd8bc4cfe7471bc3c21cfcd3cff50b8a8d49ee 
>   ui/pageview.cpp 3ebf7dcb04aa1942e02f49133d98081e2bbb565c 
>   ui/pageviewmouseannotation.h PRE-CREATION 
>   ui/pageviewmouseannotation.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127366/diff/
> 
> 
> Testing
> ---
> 
> Resize and move work
> -for types AText, AStamp and AGeom
> -on all pages of document
> -when viewport position changes
> -when zoom level changes
> -for all page rotations (0°, 90°, 180°, 270°)
> 
> Selection is canceled
> -when currently selected annotation is deleted
> -on mouse click outside of currently selected annotation
> -ESC is pressed
> 
> Viewport is shifted when mouse cursor during move/resize comes 

Re: [Okular-devel] Annotation ergonmy suggestion

[Albert Astals Cid]

El dimarts, 5 d’abril de 2016, a les 11:21:05 CEST, Henin Clement va escriure:
> Hi everyone,

Hi

> 
> Thanks a lot for creating Okular, I use it all the time and really likes
> it.

Nice :)

> 
> There is just one feature that I would really enjoy. Everytime I have
> highlighted a piece of text, I have to click again on the highlight
> button (or to use the shortcut [4]). I would prefer to stay on the
> hightlighting cursor by default so I could gain time when reviewing
> documents.
> 
> I don't know if it is possible to add an option that could allow that
> but I would enjoy it.

There's no need to add it since it already exists :)

From
https://docs.kde.org/stable4/en/kdegraphics/okular/annotations.html

" With a single left mouse button click on an annotation tool button you can 
use a tool once. If you e.g. want to highlight all important parts of a text, 
activate that tool permanently by double clicking on the tool button. Press 
the Esc key or click the tool button again to leave the permanent mode. "

Cheers,
 Albert

> 
> Have a nice day.
> 
> Clément
> 
> P.S : characteristics of my installation :
> 
> ➜ ~ okular --version
> Qt: 4.8.6
> KDE Development Platform: 4.13.3
> Okular: 0.19.3
> ➜ ~ lsb_release -a
> No LSB modules are available.
> Distributor ID: Ubuntu
> Description: Ubuntu 14.04.4 LTS
> Release: 14.04
> Codename: trusty


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Annotation ergonmy suggestion

[Henin Clement]

 

Hi everyone, 

Thanks a lot for creating Okular, I use it all the time and really likes
it. 

There is just one feature that I would really enjoy. Everytime I have
highlighted a piece of text, I have to click again on the highlight
button (or to use the shortcut [4]). I would prefer to stay on the
hightlighting cursor by default so I could gain time when reviewing
documents. 

I don't know if it is possible to add an option that could allow that
but I would enjoy it. 

Have a nice day. 

Clément 

P.S : characteristics of my installation : 

➜ ~ okular --version
Qt: 4.8.6
KDE Development Platform: 4.13.3
Okular: 0.19.3
➜ ~ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 14.04.4 LTS
Release: 14.04
Codename: trusty

 ___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 361490] Opening of files on password protected SMB share fails

[Albert Astals Cid via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361490

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
Let me make sure i understand this correct:
 * if you use okular to open the file, it works
 * if you dolphin to open the file, it fails
Am i correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 361487] Stream Files instead of creating local copy

[Albert Astals Cid via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361487

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
> It is not possible to see changes on the pdf file by reloading (F5)
You mean that if you open a file on smb and press F5 it doesn't reload the
file?
I guess that's because dolphin does that not because okular does it right?
i.e. if you call okular from the command line it will work, no?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 361490] New: Opening of files on password protected SMB share fails

[richardlm via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361490

Bug ID: 361490
   Summary: Opening of files on password protected SMB share fails
   Product: okular
   Version: 0.24.0
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: richard.l...@gmail.com

I cannot open pdf files with okular on my password protected smb-share

Reproducible: Always

Steps to Reproduce:
1. In dolphin open pdf file on password protected smb share


Actual Results:  
Okular opens with following error message:
"Could not open smb://diskstation/test.pdf. Reason: The file or folder
smb://diskstation/test.pdf does not exist."

Expected Results:  
Okular opens the pdf file

If I do in okular:
1. File -> Open...
2. browse to my smb-share
-> Dialog pop-up and asks for my credentials + password
3. Enter credentials + password
4. continue browsing to file
5. open file
6. file is correctly opened in okular

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 361487] New: Stream Files instead of creating local copy

[richardlm via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361487

Bug ID: 361487
   Summary: Stream Files instead of creating local copy
   Product: okular
   Version: 0.24.0
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: richard.l...@gmail.com

I have pdf's on a local NAS which I access via smb (or ftp - behavior is the
same) with dolphin.

When I click on a pdf, first of all copy dialog appears and then okular opens
the local copy.
This has several disadvantages:
- Unnecessary slow (one has to wait for the copy of the whole file, instead of
an instant open)
- It is not possible to see changes on the pdf file by reloading (F5)
- Unnecessary local disk usage / fragmentation, etc
- Unnecessary UI clutter/popups/notification (Copy dialog, examination
finished, etc.)

So I propose that okular should "stream" the file from the NAS server, instead
of creating a local copy.

This is the open command for pdfs in my file type properties:
"okular %U %i -caption %c"

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel